| mnaser | sean-k-mooney, bauzas: ricolin on our side will help drive this and i'll also be helping in shaping it from our side. we don't have a whole *lot* of background knowledge about it but we can do a bunch of testing about the vIOMMU stuff | 03:13 |
|---|---|---|
| opendevreview | Merged openstack/nova stable/yoga: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/836788 | 03:38 |
| opendevreview | Merged openstack/nova stable/ussuri: Fix the vGPU dynamic options race https://review.opendev.org/c/openstack/nova/+/831524 | 05:03 |
| gibi | good morning | 07:14 |
| bauzas | gibi: morning | 07:16 |
| bauzas | mnaser: ack, very much appreciated | 07:16 |
| bauzas | elodilles: I made my homework I promised | 07:26 |
| bauzas | melwitt: sent to the gate | 07:26 |
| elodilles | bauzas: cool, thanks \o/ | 08:12 |
| opendevreview | Andrew Bonney proposed openstack/nova master: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/839361 | 09:25 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 10:00 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 10:00 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 10:00 |
| ricolin | bauzas: for vIOMMU, I will work on BP asap for further discussion. Also I'm not that familar with nova future develop, are these also require to raise a meeting topic, or BP is enough for first step | 10:21 |
| sean-k-mooney | ricolin: you should ideally draft a spec | 10:33 |
| sean-k-mooney | rather then just a blueprint | 10:33 |
| ricolin | sean-k-mooney: agree | 10:39 |
| sean-k-mooney | are you familar enough with that process https://github.com/openstack/nova-specs/blob/master/specs/zed-template.rst | 10:43 |
| sean-k-mooney | the poc patch is a good start | 10:44 |
| sean-k-mooney | and i left most of my feed back in that patch already from a design point of view | 10:44 |
| sean-k-mooney | so for the spec really waht i am looking for is to defien the scope of the chagne, the interfac (extra_specs and image proerties) and the usecasses we want to adress. | 10:45 |
| sean-k-mooney | there is also a schduling question e.g. can we rely based on min libvirt version on all host suport this or do we need a compute capablity trait and prefileter for schduling | 10:45 |
| sean-k-mooney | i havent checked thet min version to determin that | 10:46 |
| sean-k-mooney | the vIOMMU has been aroudn a while so i think our min version support it but the adress space option is newer so not sure about that part | 10:47 |
| gibi | bauzas: you probably interested in https://review.opendev.org/c/openstack/nova/+/839361 as it fixes a bug in the routed net pre-filter | 11:27 |
| sean-k-mooney | gibi: i was looking at that | 11:39 |
| sean-k-mooney | im not sure why we would need admin rights | 11:39 |
| sean-k-mooney | i would have expect the segment id to be viabel to a normal user | 11:39 |
| gibi | because neutron does not return the segment_id for non admins in the GET /subnets response | 11:40 |
| gibi | I tried in a devstack, it only returns it for an admin | 11:40 |
| sean-k-mooney | hum that soudn like a design issue to me on the neutron side | 11:40 |
| sean-k-mooney | i wonder why that desision was made | 11:40 |
| gibi | of course other solution is to change neutron to return that for non-admins | 11:40 |
| gibi | I haven't tracked down the reason of this on the neutron side | 11:41 |
| gibi | I had many similar bugs in the qos work | 11:41 |
| gibi | there the resource_request field being admin-only caused similar problems | 11:41 |
| sean-k-mooney | right but i dont think using admin is the right move in general | 11:41 |
| gibi | in general no | 11:41 |
| sean-k-mooney | yep i was thinking of that and there is no reason that shoudl be admin-only | 11:41 |
| sean-k-mooney | it shoudl not be writable form the api but it shoudl be readable by the owner | 11:42 |
| sean-k-mooney | i think the segment id shoudl be the same readable by project_reader | 11:43 |
| sean-k-mooney | but not writabel by project_member | 11:43 |
| gibi | I'm OK to pursue this with the neutron team but I think we can merge the above fix as changing API behavior like that might no be backportable | 11:45 |
| sean-k-mooney | its currently project_admin by policy https://github.com/openstack/neutron/blob/master/neutron/conf/policies/subnet.py#L54-L67= its a correct fix i guess | 11:50 |
| gibi | hm, that is subnet creation | 11:51 |
| gibi | but yes the GET is project admin too segment_id | 11:51 |
| gibi | https://github.com/openstack/neutron/blob/6db61d070483df60ffbf992d57cef2c1903fe355/neutron/conf/policies/subnet.py#L98-L108 | 11:51 |
| sean-k-mooney | ya its there in both | 11:52 |
| opendevreview | Wenping Song proposed openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | 11:52 |
| sean-k-mooney | what troubling is actully https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/subnet_segmentid_writable.py | 11:52 |
| sean-k-mooney | apparently you can update the segment id of a subnet | 11:53 |
| sean-k-mooney | i dont know if the vm/schdilign implciations fo that were considered | 11:54 |
| gibi | I don't want to know what happens with the IP pool during such update | 11:54 |
| gibi | and yes, you are right that can go against the currently scheduled host of the VMs | 11:54 |
| sean-k-mooney | or if it went form not a routed netowk to a routed one | 11:54 |
| gibi | yeah that too | 11:54 |
| * sean-k-mooney lesson is to stop looking at what extensions neutorn optionall support | 11:55 | |
| sean-k-mooney | i hope they only allow this before ports are added to the subnet | 11:55 |
| * gibi closes the browser tab and goes to wash his hands | 11:55 | |
| sean-k-mooney | gibi: added +2 but now +w to see if bauzas wants to review. we can kick it into the gate if bauzas is busy and does not review by tomorrow | 11:58 |
| gibi | sure. thanks | 11:59 |
| gibi | btw the author is a first time nova contributor :) | 11:59 |
| sean-k-mooney | i guess https://bugzilla.redhat.com/show_bug.cgi?id=1761903 woudl fail qe without thsi so once that lands we should backport it for them i guess | 12:01 |
| gibi | yeah this fix needs to be backport | 12:06 |
| gibi | up until wallaby upstream | 12:08 |
| opendevreview | Wenping Song proposed openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | 12:20 |
| *** amoralej is now known as amoralej|lunch | 12:30 | |
| gibi | sean-k-mooney: the OWNER os-traits patch now looks good to me https://review.opendev.org/c/openstack/os-traits/+/839128 let's land it and propose a os-traits release | 12:57 |
| sean-k-mooney | yep i see the added a release not. i guess that does not hurt but im not sure how many people actully consume that | 12:58 |
| sean-k-mooney | ill take a look again shortly | 12:58 |
| gibi | yeah reno does not hurt | 12:59 |
| sean-k-mooney | i need to finsih reviewing your pci patches again too | 12:59 |
| gibi | thanks for that! | 12:59 |
| sean-k-mooney | the code looks fine on the first patch but i have not found a block of uninterupted time in the last few days to trace through the unit tests and line them up | 12:59 |
| sean-k-mooney | im sure they are fine but that all i have left to do on the first patch | 13:00 |
| gibi | no worries | 13:07 |
| *** amoralej|lunch is now known as amoralej | 13:12 | |
| opendevreview | Merged openstack/os-traits master: Add nova and cyborg owner traits for resources https://review.opendev.org/c/openstack/os-traits/+/839128 | 13:26 |
| bauzas | gibi: sean-k-mooney: eventually accepted https://review.opendev.org/c/openstack/nova/+/839361 | 13:28 |
| bauzas | gibi: sean-k-mooney: that said, I'm sad we need to be an admin for knowing the API extensiion | 13:29 |
| sean-k-mooney | well we can know if the extension is aviabel without being an admin but we cant consume the data form the extention without being an admin | 13:31 |
| sean-k-mooney | i guess the assumetion here is that routed networks are provider networks and requies an admin to create | 13:32 |
| sean-k-mooney | but you then dont need to be an admin to create ports on that network | 13:32 |
| sean-k-mooney | so i really think it shoudl be readonly | 13:32 |
| sean-k-mooney | for project_memeber | 13:32 |
| sean-k-mooney | and project_admin to create the subnet and affinitese it to a segment | 13:32 |
| sean-k-mooney | so we likely shoudl add neutron to the bug and ask them to change the default policy for get but not create to project_reader | 13:33 |
| *** dasm|off is now known as dasm | 13:48 | |
| bauzas | sean-k-mooney: yeah, we should ask the neutron team to change the policy | 14:19 |
| sean-k-mooney | should we just tag them in the bug and ask them to update and or propsoe a patch to do that? | 14:27 |
| sean-k-mooney | we dont consider policy change to be api changes | 14:27 |
| sean-k-mooney | so presumable that would be backportable | 14:27 |
| gibi | I'm not sure neutron will think this is backportable, but let see | 14:47 |
| melwitt | bauzas: thanks ^_^ | 14:59 |
| opendevreview | Dan Smith proposed openstack/nova master: DNM: Run against performance.json patch https://review.opendev.org/c/openstack/nova/+/838934 | 15:45 |
| *** amoralej is now known as amoralej|off | 15:57 | |
| gibi | bauzas: I reported a gate-failure https://bugs.launchpad.net/nova/+bug/1970642 it is not super frequent but I saw it multiple times | 17:00 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/839091 | 18:53 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: Fix LM rollback w/o multi port bindings extension https://review.opendev.org/c/openstack/nova/+/839227 | 18:53 |
| *** artom__ is now known as artom | 18:53 | |
| *** dasm is now known as dasm|off | 22:19 | |
| opendevreview | Ghanshyam proposed openstack/nova master: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839648 | 22:53 |
| opendevreview | Ghanshyam proposed openstack/nova stable/yoga: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839653 | 22:56 |
| opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839654 | 22:56 |
| opendevreview | Ghanshyam proposed openstack/nova master: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839648 | 23:02 |
| opendevreview | Ghanshyam proposed openstack/nova stable/yoga: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839653 | 23:02 |
| opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: test https://review.opendev.org/c/openstack/tempest/+/839647 https://review.opendev.org/c/openstack/nova/+/839654 | 23:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!