| brinzhang_ | bauzas:about tenant_id topic, imo, there is nothing need to discuss, I have been doing it since wallaby, it's clear what we should do | 00:34 |
|---|---|---|
| brinzhang_ | and the time it's later for me, sorry I will absent. | 00:36 |
| *** bhagyashris_ is now known as bhagyashris | 05:52 | |
| *** amoralej|off is now known as amoralej | 07:21 | |
| bauzas | brinzhang_: no worries, we already discussed about your series and I think it's prioritized | 07:56 |
| brinzhang_ | bauzas:ack, thx | 08:35 |
| opendevreview | Wenping Song proposed openstack/nova-specs master: qUsage of new trait of OWNER_NOVA https://review.opendev.org/c/openstack/nova-specs/+/836583 | 09:07 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/836788 | 10:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/836733 | 11:34 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Store old_flavor already on source host during resize https://review.opendev.org/c/openstack/nova/+/836734 | 11:53 |
| *** amoralej is now known as amoralej|lunch | 12:11 | |
| Uggla | hello | 12:34 |
| sean-k-mooney | o/ | 12:34 |
| Uggla | sean-k-mooney, I need help. | 12:35 |
| Uggla | I try to test my code with devstack. I have an issue with the migration of DB. It seems that nove-manage db sync did the correctly on cell0 but not cell1. | 12:36 |
| sean-k-mooney | you have to run it twice | 12:36 |
| Uggla | hum no | 12:36 |
| Uggla | I don't think so | 12:37 |
| sean-k-mooney | you have to run the sycn for each db | 12:37 |
| sean-k-mooney | cell0 is kind of special | 12:37 |
| sean-k-mooney | but in general you run the sync per cell | 12:37 |
| sean-k-mooney | devstack should already do this | 12:37 |
| sean-k-mooney | how exactly did it fail | 12:37 |
| Uggla | it seems it doesn't fail. But cell1 has not the share_mapping table and the version within alambic_version table has not evolved. | 12:39 |
| Uggla | I may miss something but .... | 12:39 |
| sean-k-mooney | where did you create it | 12:40 |
| sean-k-mooney | do you have the link to your patch | 12:40 |
| Uggla | sure | 12:40 |
| Uggla | https://review.opendev.org/c/openstack/nova/+/831193 | 12:40 |
| sean-k-mooney | ok you modified the main db model | 12:41 |
| sean-k-mooney | that should be correct | 12:41 |
| sean-k-mooney | i just wanted to make sur eyou did not put it in the api db by mistake | 12:41 |
| Uggla | All tests unit + func looks fine with tox. | 12:41 |
| Uggla | I mean a functional test using the api + db is working fine. | 12:42 |
| Uggla | But on devstack the migration seemed to not fan out to all cell. | 12:42 |
| Uggla | It happens only on cell0 | 12:42 |
| Uggla | sean-k-mooney, we can share a gmeet session, if you would like to see it. | 12:43 |
| sean-k-mooney | the dbs are set up here | 12:43 |
| sean-k-mooney | https://github.com/openstack/devstack/blob/master/lib/nova#L818-L871= | 12:43 |
| Uggla | oh ok I get it . | 12:44 |
| Uggla | If necessary, the --config-file argument can be used to point to the correct nova.conf file for the given cell. | 12:45 |
| sean-k-mooney | yes | 12:45 |
| sean-k-mooney | https://github.com/openstack/devstack/blob/master/lib/nova#L843= | 12:46 |
| sean-k-mooney | is where the db sync shoudl happen for cell 1 | 12:46 |
| sean-k-mooney | using the cell1 conductor config | 12:46 |
| Uggla | I did not understand the doc correctly | 12:46 |
| sean-k-mooney | so we are doing $NOVA_BIN_DIR/nova-manage --config-file $conffile db sync --local_cell | 12:47 |
| sean-k-mooney | --local_cell disables faning out ot other celsl as part of the sync | 12:47 |
| chateaulav | bauzas: great PTG so far! I am otherwise held up today, but i will be there tomorrow just fyi | 12:47 |
| sean-k-mooney | ack | 12:48 |
| sean-k-mooney | Uggla: have you tried runnign that manually | 12:48 |
| Uggla | yep it is a bit ambiguous IMHO. | 12:48 |
| Uggla | I'm gonna try. | 12:48 |
| sean-k-mooney | nova-manage --config-file /etc/nova/nova-conductor-1.conf db sync --local_cell | 12:49 |
| sean-k-mooney | i think that woudl be the right path but its something like that | 12:49 |
| sean-k-mooney | ah its /etc/nova/nova_cell1.conf | 12:49 |
| Uggla | nova-manage --config-file /etc/nova/nova_cell1.conf db sync correct ? | 12:51 |
| sean-k-mooney | yes | 12:51 |
| sean-k-mooney | that is what devstack ran | 12:51 |
| Uggla | ERROR: Could not access cell0. | 12:51 |
| sean-k-mooney | odd... | 12:51 |
| sean-k-mooney | let me try that myself | 12:51 |
| bauzas | chateaulav: no worries | 12:52 |
| Uggla | sean-k-mooney, I got this: https://paste.openstack.org/show/bw9C4K0JEaD2eH2kM3TF/ | 12:53 |
| sean-k-mooney | Uggla: you are missing --local_cell | 12:53 |
| sean-k-mooney | that disablise it trying to connect to cell0 | 12:53 |
| sean-k-mooney | when syncign cell 1 | 12:53 |
| sean-k-mooney | stack@controller:/home/vagrant$ nova-manage --config-file /etc/nova/nova_cell1.conf db sync --local_cell | 12:54 |
| sean-k-mooney | that should work | 12:54 |
| Uggla | sean-k-mooney, sounds good ! I'm gonna check | 12:54 |
| bauzas | correct ^ | 12:54 |
| Uggla | it is ok regarding the tables \o/ | 12:55 |
| sean-k-mooney | so how did you configure devstack to use your patch | 12:56 |
| Uggla | but I'm unclear if this is specific onlyfor devstack ? | 12:56 |
| sean-k-mooney | no you have to do this for all installers | 12:56 |
| sean-k-mooney | nova-manage can try and discover all the cells via the api db technially but that assuem either you store the password in the db which we discurage or you use the same password on all db instances | 12:57 |
| bauzas | https://github.com/openstack/devstack/blob/master/lib/nova#L818 | 12:57 |
| bauzas | and https://github.com/openstack/devstack/blob/master/lib/nova#L847 | 12:57 |
| sean-k-mooney | in generall its simpler to have one config file per cell and run the comand once per cell | 12:58 |
| Uggla | for devstack I use my patch by configuring a git remote on my repo and "pulling" it | 12:58 |
| bauzas | context : https://docs.openstack.org/nova/latest/admin/cells.html#configuring-a-new-deployment | 12:58 |
| sean-k-mooney | Uggla: ok so you set NOVA_REPO and NOVA_BRANCH before you stacked | 12:58 |
| sean-k-mooney | and you did not already have /opt/stack/nova right | 12:58 |
| sean-k-mooney | before you ran stack.sh | 12:58 |
| Uggla | not sorry, I had a already installed devstack and replace the code with mine + restart | 12:59 |
| sean-k-mooney | oh ok | 12:59 |
| sean-k-mooney | so doing sudo systemctl restart devstack@n-* | 12:59 |
| Uggla | yep | 12:59 |
| sean-k-mooney | works only for python changes | 12:59 |
| sean-k-mooney | if you chagne the db you have to manually sync again | 12:59 |
| Uggla | ack | 13:00 |
| sean-k-mooney | 99% of the time we are not touching the db so we dont usually call that out | 13:00 |
| Uggla | do we agree that the doc for db migration is this one: https://docs.openstack.org/nova/latest/admin/upgrades.html | 13:00 |
| sean-k-mooney | yes it is | 13:01 |
| sean-k-mooney | """Using the newly installed nova code, run the DB sync. First run nova-manage api_db sync, then nova-manage db sync. nova-manage db sync should be run for all cell databases, including cell0. If necessary, the --config-file argument can be used to point to the correct nova.conf file for the given cell.""" | 13:01 |
| Uggla | any objection if I propose a minor update to make it clearer ? | 13:01 |
| sean-k-mooney | im not sure what is not clear but sure we can review it | 13:02 |
| sean-k-mooney | its always ok to propose updates to docs ectra | 13:02 |
| sean-k-mooney | we will just review it as normal | 13:02 |
| sean-k-mooney | you could add an example i guess | 13:02 |
| Uggla | sean-k-mooney, that's clearly what I was looking. And I was confuse by the fact that it was not clear for me is all cells will be updated or not. | 13:02 |
| Uggla | And more confuse by that: --local_cell Only sync db in the local cell: do not attempt to fan-out to all cells | 13:03 |
| sean-k-mooney | well it says ""nova-manage db sync should be run for all cell databases"" | 13:03 |
| sean-k-mooney | that imperitive directing you to run it for each cell | 13:04 |
| *** amoralej|lunch is now known as amoralej | 13:04 | |
| sean-k-mooney | Uggla: feel free to add a note with examples or other changes if you think it would help make it cleaner | 13:05 |
| Uggla | I agree, but I had the doubt if it was automatic or normal. | 13:05 |
| sean-k-mooney | Uggla: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L193-L195= | 13:07 |
| Uggla | sean-k-mooney, clearly I understood it incorrectly. But I think this is mainly due to: "Only sync db in the local cell: do not attempt to fan-out to all cells" --> so without this option I thought it will configure all cells | 13:08 |
| sean-k-mooney | not quite | 13:08 |
| sean-k-mooney | without it it will do cell0 and the curernt cell | 13:09 |
| sean-k-mooney | each nova.conf will only have one cell db configured | 13:09 |
| sean-k-mooney | we do not have the code required to loop over all the cells in the api db and update them automatically | 13:09 |
| sean-k-mooney | so without --local_cell it does cell0 and the local cell | 13:09 |
| sean-k-mooney | with it it only does the local cell | 13:10 |
| sean-k-mooney | cell1 in this case | 13:10 |
| sean-k-mooney | cell0 is speical its not a real cell | 13:10 |
| sean-k-mooney | it used for instance that could not be schduled to a host | 13:10 |
| Uggla | I'm not clear. What is local cell ? | 13:10 |
| sean-k-mooney | and a few other internal usecases | 13:10 |
| sean-k-mooney | it the one that is reference in the nova.conf | 13:11 |
| sean-k-mooney | in the [database]/connection value | 13:11 |
| sean-k-mooney | so | 13:12 |
| sean-k-mooney | [database] | 13:12 |
| sean-k-mooney | connection = mysql+pymysql://root:password@127.0.0.1/nova_cell1?charset=utf8 | 13:12 |
| sean-k-mooney | by default devstack generates /etc/nova/nova.conf with that pointign at cell0 | 13:13 |
| Uggla | ok back to my previous question, do you have cases where nova.conf does not contain cell0 ? | 13:13 |
| Uggla | or is it only devstack specific ? | 13:13 |
| sean-k-mooney | no you do | 13:13 |
| sean-k-mooney | the conductor config dont point to cell0 | 13:13 |
| sean-k-mooney | they point to there cell db | 13:13 |
| sean-k-mooney | whcih will be cell1 or in osp we call it just nova | 13:14 |
| Uggla | ok it clear now. thx. | 13:17 |
| Uggla | \o/ my code is working. At least the index part... ;) | 13:22 |
| Uggla | and the creation part. Seems I manage to discuss with manila ! | 13:35 |
| spatel | sean-k-mooney i have opened this bug for my issue - https://bugs.launchpad.net/nova/+bug/1968054 | 13:53 |
| sean-k-mooney | that does not seem like a nova issue | 13:54 |
| sean-k-mooney | the error is with conencting to the rabbitmq right | 13:54 |
| bauzas | reminder : nova sessions start in 4 mins | 13:56 |
| bauzas | nova sessions start now | 14:02 |
| sean-k-mooney | joining | 14:02 |
| bauzas | https://www.openstack.org/ptg/rooms/newton | 14:02 |
| sean-k-mooney | spatel: that looks like you are having internal network issue with connectivty between your comptues and the contoler | 14:02 |
| spatel | This is all running behind single switch so its hard to say network issue. all other nodes are happy | 14:03 |
| spatel | as soon as i restart my nova-compute everything came back | 14:04 |
| spatel | look like some thread crashed and never recover until manually restart | 14:04 |
| sean-k-mooney | it could be related to dns | 14:04 |
| spatel | Out of 20 compute 2 nodes encounter with this issue.. | 14:04 |
| sean-k-mooney | https://github.com/openstack/nova/commit/fe1ebe69f358cbed62434da3f1537a94390324bb | 14:05 |
| spatel | I have everything using IP address | 14:06 |
| spatel | i have found similar bug but not sure its related to my issue or not - https://bugs.launchpad.net/oslo.messaging/+bug/1934937 | 14:06 |
| sean-k-mooney | spatel: the error are not coming from nova so i woudl think its unlikely this is a nova bug it proably an oslo one if its not related to your infra | 14:07 |
| spatel | i don't think its related to infra for sure | 14:07 |
| spatel | i may post same bug to oslo | 14:08 |
| sean-k-mooney | you can just add them to the bug | 14:08 |
| sean-k-mooney | you dont need to create a second one | 14:08 |
| *** artom__ is now known as artom | 14:12 | |
| spatel | sean-k-mooney how do i add them in existing bug? | 14:24 |
| spatel | affected project? | 14:24 |
| sean-k-mooney | yes | 14:26 |
| spatel | done, thanks | 14:26 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace implicit conversion of SELECT into FROM https://review.opendev.org/c/openstack/placement/+/800910 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace 'as_scalar()' with 'scalar_subquery()' https://review.opendev.org/c/openstack/placement/+/801100 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Use Row, not LegacyRow https://review.opendev.org/c/openstack/placement/+/828305 | 14:41 |
| opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | 14:41 |
| stephenfin | gibi: Fixed that placement issue. Can you relook at https://review.opendev.org/c/openstack/placement/+/801103 and https://review.opendev.org/c/openstack/placement/+/800910 when you get a chance (maybe after CI runs if you want) | 14:52 |
| gibi | stephenfin: added to my review list | 14:53 |
| stephenfin | sean-k-mooney: melwitt: bauzas: I'll need one of you folks to be the other +2/+W when you've time ^ | 14:53 |
| stephenfin | Context is this SQLA 2.0 stuff came up in the TC call earlier and I thought these had merged already :) | 14:53 |
| bauzas | stephenfin: ack, will look | 14:54 |
| stephenfin | ta | 14:54 |
| sean-k-mooney | ah ws going to ask | 14:55 |
| sean-k-mooney | ok its sqla | 14:55 |
| sean-k-mooney | ya no worries | 14:55 |
| bauzas | as I wrote on https://ptg.opendev.org/ptg.html, next discussion will be at 4pmUTC | 15:12 |
| bauzas | stephenfin: you got my review-prio flag on your placement SQLA db series | 15:22 |
| stephenfin | bauzas: thanks | 15:31 |
| sean-k-mooney | we proably should have proceeded witht he nova adgenda and then asked them to ping us in highsight | 15:37 |
| gibi | next time we will be smarter :) | 15:40 |
| gibi | maybe we need to punt the rest of the nova topic to friday? | 15:42 |
| sean-k-mooney | we coudl i guess | 15:44 |
| sean-k-mooney | i kind of wanted to finish today if we did not have other topics | 15:44 |
| sean-k-mooney | so that we could sync with neutron or cinder tomorrow | 15:45 |
| sean-k-mooney | or tc | 15:45 |
| sean-k-mooney | without worring about conflicts | 15:45 |
| gibi | yeah | 15:47 |
| gibi | let see how fast the tc session goes | 15:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/836993 | 15:55 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Store old_flavor already on source host during resize https://review.opendev.org/c/openstack/nova/+/836994 | 15:55 |
| bauzas | folks, what should we do ? | 16:00 |
| gibi | I think this tc discussion is useful | 16:02 |
| bauzas | artom_: melwitt: gibi: sean-k-mooney: Uggla: elodilles: could we have our arbiterd session by 1630UTC ? | 16:02 |
| gibi | bauzas: works for me | 16:02 |
| bauzas | I tend to agree with sean-k-mooney, ideally we should free ourselves tomorrow as soon as we can | 16:02 |
| * Uggla ok | 16:02 | |
| melwitt | sure | 16:02 |
| artom_ | So in 30 minutes? | 16:02 |
| bauzas | thanks folks, updating then the ptgbot | 16:02 |
| bauzas | yeah | 16:03 |
| artom_ | Sure | 16:03 |
| elodilles | bauzas: ack, don't wait for me. (especially, since i haven't added much to the topics + there won't be any stable or release specific topic o:)) | 16:06 |
| bauzas | elodilles: ack, you're free to end up early, I bless you :p | 16:07 |
| elodilles | :) | 16:07 |
| bauzas | sean-k-mooney: just sayin', I'll leave the TC room | 16:28 |
| bauzas | and open the nova room | 16:28 |
| sean-k-mooney | ack ok ill swap now | 16:31 |
| bauzas | gibi: ack, no worries, see you tomorrow morning | 17:02 |
| bauzas | as a reminder, we have a cyborg x-p at 8amUTC | 17:02 |
| gibi | ack | 17:03 |
| bauzas | gibi: we'll just wrap the nova sessions tomorrow I think | 17:03 |
| gibi | I will join to the Cyborg session | 17:03 |
| bauzas | just after the neutron topic | 17:03 |
| bauzas | gibi: thanks ! | 17:03 |
| *** amoralej is now known as amoralej|off | 17:08 | |
| sean-k-mooney | bauzas: i likely will be asleep for the cyborg session. if i am awake ill try and attend but ill read back after most likely. | 17:35 |
| sean-k-mooney | the main topic is just thw owner_ traits | 17:35 |
| sean-k-mooney | right | 17:35 |
| sean-k-mooney | or general topic of how to model some rps are not owned by nova | 17:36 |
| sean-k-mooney | i think we had agreed to add owned_by on all our RPs last cycle but it then never happened | 17:36 |
| sean-k-mooney | we discussed this in relation to generic mdevs | 17:37 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/836583/3/specs/zed/approved/owner-nova-trait-usage.rst | 17:44 |
| *** dasm|off is now known as dasm | 18:42 | |
| *** dasm is now known as dasm|off | 22:44 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!