| bauzas | hello Nova | 10:02 |
|---|---|---|
| bauzas | I'm surprised we won't need a RC2 release | 10:03 |
| * bauzas tries to look at the open bugs | 10:03 | |
| bauzas | https://bugs.launchpad.net/nova/+bugs?field.tag=yoga-rc-potential is empty | 10:04 |
| * kashyap waves hi | 10:06 | |
| bauzas | mmmm | 10:10 |
| bauzas | actually, found https://bugs.launchpad.net/nova/+bug/1964995 | 10:10 |
| bauzas | dmitriis: adding the yoga regression tag to your BP | 10:10 |
| bauzas | once sean-k-mooney is back, I'd like to understand whether it's a regression | 10:11 |
| gibi_pto | bauzas: vpd is a new thing in Xena isn't it? so that bug cannot be a direct regression, more like a limitation on the new feature | 10:50 |
| bauzas | gibi_pto: welcome back if you are no longer on PTO | 10:51 |
| bauzas | gibi_pto: I don't know, I just saw the title so I added the tag | 10:51 |
| bauzas | but I'll look at it later today | 10:51 |
| gibi_pto | bauzas: ~backish | 10:52 |
| gibi_pto | I think I will be useless today | 10:52 |
| * bauzas needs to prepare the lunch for her kid | 10:53 | |
| opendevreview | Felix Huettner proposed openstack/nova stable/queens: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/829861 | 10:54 |
| erlon | bauzas: hey, when you have a chance can you look at my comment on bug 1944619? sean-k-mooney1 also said he would look it today, so I think we still can consider it to yoga | 12:02 |
| sean-k-mooney1 | erlon: yep im just pulling down your patch locally im going to run the regression test a few times then ill review it | 12:51 |
| *** sean-k-mooney1 is now known as sean-k-mooney | 12:51 | |
| sean-k-mooney | erlon: im not sure if this rises to the level fo an rc2 fix | 12:52 |
| sean-k-mooney | but it can be fixed on master and then backported and released in 25.0.1 after the yoga offial release is done | 12:52 |
| erlon | right | 13:00 |
| *** iurygregory_ is now known as iurygregory | 13:10 | |
| *** needssleep is now known as TheJulia | 13:13 | |
| *** dasm|off is now known as dasm | 13:29 | |
| sean-k-mooney | erlon: ok i have the first patch running with "tox -e functional -- --until-failure 1944619" ill leave that runing for 10 mins while i review the patches and then ill do the same on the second patch. if both look stable and i see no issues with the patches ill re add my +2 | 13:44 |
| sean-k-mooney | erlon: minor issue in https://review.opendev.org/c/openstack/nova/+/815324 | 13:50 |
| erlon | let me check | 13:51 |
| sean-k-mooney | just the fixme comment its now fixed | 13:51 |
| erlon | pw, tru, missed that one | 13:51 |
| erlon | let me fix | 13:51 |
| opendevreview | Erlon R. Cruz proposed openstack/nova master: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/815324 | 13:54 |
| sean-k-mooney | cool im am runing htat version now ill leave it for 10 mins and then ill review it again | 13:55 |
| sean-k-mooney | thanks for updating it quickly | 13:55 |
| bauzas | erlon: sorry, but like I said in the bug report, it's not a regression so we can't fix it for yoga RC2 | 13:59 |
| erlon | bauzas: ok, I had forgotten about the RC policies, but sean suggested us to merge it on master and backport it | 14:00 |
| bauzas | erlon: yup | 14:00 |
| bauzas | but we can only backport after Yoga release | 14:00 |
| erlon | right | 14:00 |
| erlon | it can wait | 14:00 |
| erlon | thanks for given attention to it | 14:01 |
| sean-k-mooney | the test seams stable locally at least so i reinstated my +2 on both patches | 14:10 |
| sean-k-mooney | the releas should be thrusday week so the back port can be done from april 1st once the master version is merged | 14:11 |
| bauzas | sean-k-mooney: Yoga GA is on Wed next week | 14:21 |
| bauzas | ie. March 30th | 14:22 |
| sean-k-mooney | oh they are not going with the normal "thursday" fo the week convention | 14:22 |
| sean-k-mooney | ok | 14:22 |
| bauzas | sean-k-mooney: they always release on Wednesdays | 14:22 |
| bauzas | the GA, I mean | 14:22 |
| sean-k-mooney | really? ok didnt know that | 14:22 |
| sean-k-mooney | i guess it give more time for press releases ectra | 14:23 |
| bauzas | lemme verify but I'm 99% on it | 14:23 |
| bauzas | https://releases.openstack.org/xena/schedule.html#xena-release | 14:23 |
| sean-k-mooney | i dont think it changes the math much. tl;dr we can start backporting after that release is done | 14:23 |
| bauzas | https://releases.openstack.org/wallaby/schedule.html#wallaby-release | 14:23 |
| bauzas | etc. | 14:23 |
| bauzas | erlon: if I have time, I'll try to look at your change tomorrow | 14:24 |
| bauzas | sean-k-mooney: have you seen my ping about https://bugs.launchpad.net/nova/+bug/1964995 ? | 14:24 |
| bauzas | sean-k-mooney: not sure it's a regression | 14:24 |
| erlon | no, let me see | 14:26 |
| bauzas | I just added the tag to make sure we don't forget about it | 14:27 |
| bauzas | for the moment, we don't have any needs for a RC2 | 14:27 |
| bauzas | https://review.opendev.org/q/project:openstack/nova+branch:stable/yoga is super empty | 14:27 |
| sean-k-mooney | bauzas: am so vpd was added this cycle and it intoduced the bug | 14:27 |
| bauzas | elodilles: ^ for your knowledge | 14:28 |
| sean-k-mooney | however nothing uses the network capablities | 14:28 |
| sean-k-mooney | so to me its a regression but it wont break anything | 14:28 |
| sean-k-mooney | we only merged half of the network capablities feature e.g. the reportign into the db we did not merge the other half that consumes that info | 14:28 |
| sean-k-mooney | bauzas: so i think that should be fixed but im not conviced we need an RC2 for it | 14:30 |
| sean-k-mooney | its more tech debth then somethign that will break any user of nova | 14:30 |
| bauzas | sean-k-mooney: if nothing was used in Xena, it's not a regression | 14:30 |
| bauzas | sean-k-mooney: ok, so I'll remove the tag and I'll change the title | 14:31 |
| sean-k-mooney | i was orginaly hoping to get that in rc1 by the way now that that has shiped i think it can just be a normal bugfix after the release | 14:31 |
| bauzas | sean-k-mooney: yeah, we can merge any bugfix before RC1 but after, the ship has sailed | 14:37 |
| bauzas | like erlon's bugfix | 14:37 |
| bauzas | those are just policies for distro vendors and ops, which I can understand | 14:37 |
| elodilles | bauzas: sean-k-mooney: yepp, GA is always Wednesday (compared to milestone and other deadlines, which are on Thursdays) | 14:46 |
| elodilles | bauzas: ack, so we have one bug that does not need an RC2, as it seems now | 14:47 |
| sean-k-mooney | bauzas: can we retarget https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration to zed yet or do we need to wait | 15:10 |
| sean-k-mooney | it looks like yoga is still set as the current branch in launchpad | 15:11 |
| sean-k-mooney | i assume you are waitign till the actual release to swap it over | 15:11 |
| sean-k-mooney | should we add that blueprint to the meeting adgenda or wait untill after the release | 15:13 |
| sean-k-mooney | elodilles: could you take a look at https://review.opendev.org/c/openstack/nova/+/828413/2 the follow up has +2+w and is waiting on the job being enabled | 15:22 |
| elodilles | sean-k-mooney: hmmm, jobs aren't backported usually, and as I see it's non-voting | 15:29 |
| sean-k-mooney | well we dont currently have coverage for hybrid plug in xena | 15:31 |
| sean-k-mooney | it was the default before xena | 15:31 |
| sean-k-mooney | but we did not readd it when we changed the devstack default | 15:31 |
| sean-k-mooney | so this is really just add back coverage we had for wallaby to xena | 15:32 |
| sean-k-mooney | which we now have on yoga again | 15:32 |
| elodilles | (at least the new job nicely shows that the bug fix works) | 15:33 |
| sean-k-mooney | it is non voting but it actully should get fliped to voting at some point | 15:33 |
| sean-k-mooney | i think that is in the follow up patch | 15:33 |
| elodilles | yes, i see now | 15:33 |
| sean-k-mooney | yep so we were using that like a regression test to demonstrate the issue | 15:34 |
| elodilles | sean-k-mooney: +2+W'd, thanks for the details about the fix | 15:54 |
| sean-k-mooney | :) | 15:56 |
| bauzas | sean-k-mooney: I prepared the zed cycle | 16:00 |
| bauzas | sean-k-mooney: but actually I forgot to update the launchpad main branch | 16:00 |
| artom | bauzas, sean-k-mooney, https://review.opendev.org/c/openstack/nova/+/806049/ | 16:15 |
| sean-k-mooney | thanks :) | 16:17 |
| bauzas | fwiw, I'm about to give a go to https://review.opendev.org/c/openstack/nova/+/833440 as it won't harm our future tick-tock cadence | 16:52 |
| bauzas | this is about removing Xena computes support for Zed | 16:53 |
| bauzas | but we definitely need to discuss this at the PTG | 16:53 |
| gibi_pto | bauzas: correct, we have to change that limitation in the future to support N-2 -> N upgrades | 17:30 |
| bauzas | I'll leave this change open until tomorrow and we'll discuss at the nova meeting | 17:31 |
| sean-k-mooney | gibi_pto: well that is the topic to discuss at the PTG apprently we dont actully have too but likely should | 17:31 |
| sean-k-mooney | gibi_pto: just repeating what i have heard but appretly live rolling upgrade supprot for n-2 is left to the projects to opt in too | 17:32 |
| sean-k-mooney | so if we elect to supprot n-2 rolling upgrades upstream then we shoudl alter that check and add a job to validate it if we dont then we could keep it at n-1 | 17:33 |
| gibi_pto | ahh, OK, lets talk that through on the PTHG | 17:33 |
| gibi_pto | PTG | 17:33 |
| gibi_pto | bauzas: that change fails in grenade on the service version check | 17:33 |
| gibi_pto | https://zuul.opendev.org/t/openstack/build/a24b974ae9fd487694724da795bfcd2a/log/controller/logs/screen-n-cond.txt#1140 | 17:34 |
| dansmith | bauzas: I think we should have something like this for nova: https://docs.openstack.org/cinder/latest/contributor/gerrit.html#ci-job-rechecks | 17:34 |
| dansmith | some discussion of late in the tc about how most people just do blind rechecks all the time | 17:34 |
| dansmith | probably don't need that much detail for nova given that we don't have all the drivers, but still, I see a lot of "recheck" with no explanation, which I think often means no inspection | 17:35 |
| dansmith | I'm hoping we'll have some general direction out of the tc about this, but would be nice to jumpstart in the nova community with reminders and constructive peer pressure :) | 17:35 |
| gibi_pto | dansmith: I suppor that idea! | 17:36 |
| dansmith | gibi_pto: I support your support :) | 17:37 |
| sean-k-mooney | we used to have a section that said you should file a bug and add an elastic recheck query i think | 17:37 |
| dansmith | however, I do not support you spending pto hanging out in irc :P | 17:37 |
| gmann | like neutron, we can monitor how many recheck for this week we had | 17:37 |
| dansmith | sean-k-mooney: yeah, but we need more constructive peer pressure regardless.. clear documentation to point to would be helpful when doing that | 17:38 |
| gmann | s/gibi_pto/gibi_pto_but_work_on_irc :) | 17:38 |
| dansmith | sean-k-mooney: if we've got it, then cool, but a concerted team-wide effort is needed I think | 17:38 |
| dansmith | gmann: paid time on work is just work :P | 17:38 |
| gibi_pto | nah, I just randomly hanging around :) | 17:38 |
| sean-k-mooney | dansmith: i think we removed it at som epoint im checking to see if we still do | 17:38 |
| sean-k-mooney | i tought it was in https://github.com/openstack/nova/blob/master/doc/source/contributor/code-review.rst but not seeign it | 17:38 |
| dansmith | I can certainly write up some stuff | 17:40 |
| sean-k-mooney | its also not in our testing doc https://github.com/openstack/nova/blob/master/doc/source/contributor/testing.rst so ya i think we remved it | 17:40 |
| sean-k-mooney | dansmith: this is proably where it need to be updated https://opendev.org/openstack/nova/src/branch/master/doc/source/contributor/process.rst#how-can-i-get-my-code-merged-faster | 17:47 |
| sean-k-mooney | we currently say """If you're fixing something that only occasionally failed before, maybe recheck a few times to prove the tests stay passing.""" | 17:48 |
| sean-k-mooney | but we dont give guidnce on when its appropate to recheck in general | 17:48 |
| gmann | dansmith: or may be to writeup in project-team-guide and point projects doc to that ? | 17:48 |
| sean-k-mooney | gmann: we do link to this https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing | 17:49 |
| sean-k-mooney | we used to have a version fo that in nova | 17:50 |
| gmann | I mean to tell "no blind recheck" and 'best way to check logs and find issue' explicitly | 17:50 |
| sean-k-mooney | step 2 """Examine the console log or other relevant log files to determine the cause of the error. If it is related to your change, you should fix the problem and upload a new patchset. Do not use “recheck”.""" | 17:50 |
| sean-k-mooney | we do link to that form our testing.rst doc | 17:52 |
| gmann | yeah, I think due length of this doc it got hidden and people ignore to read the complete doc. we can add link to this doc for details but have a explicit section about recheck and how to use it in best way | 17:53 |
| gmann | dur to | 17:53 |
| sean-k-mooney | if we had a centralised one we coudl have zuul link top it when it fails | 17:53 |
| sean-k-mooney | by updating the failure message | 17:54 |
| sean-k-mooney | in any case it took me 5 mins to find that and i more or less know what im looking for so a new contibutor is likely not going to find it | 17:55 |
| gmann | true | 17:56 |
| *** lajoskatona_ is now known as lajoskatona | 17:59 | |
| stephenfin | sean-k-mooney: https://review.opendev.org/c/openstack/os-traits/+/833826 easy patch | 18:44 |
| sean-k-mooney | stephenfin: ah has the discussion on that been resovled | 18:47 |
| sean-k-mooney | i saw the thread you started but did not keep track of it while i was off | 18:47 |
| sean-k-mooney | oh its just the reference syntax in zuul. that keeps duplicaiton down at least. | 18:49 |
| sean-k-mooney | the zuul change that is https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/833286/2/zuul.d/project-templates.yaml | 18:49 |
| sean-k-mooney | stephenfin: ok done.# | 18:54 |
| stephenfin | spot on, thanks! | 18:54 |
| sean-k-mooney | did you also do os-resource classes | 18:57 |
| sean-k-mooney | stephenfin: dont see it here https://review.opendev.org/q/topic:add-python3-unversioned-jobs but i think its independent too https://github.com/openstack/releases/blob/master/deliverables/_independent/os-resource-classes.yaml | 18:59 |
| stephenfin | Oh, my hacky script probably just missed that | 18:59 |
| sean-k-mooney | i need to add a PTG topic about this by the way | 19:00 |
| sean-k-mooney | we might want to merge those back into placment | 19:00 |
| sean-k-mooney | we have a cirular dep issue with testing and releases | 19:00 |
| sean-k-mooney | we can either relax the test that assert the amount of traits/resouce classes or we can put them all in the same repo | 19:01 |
| sean-k-mooney | stephenfin: im going to go eat something. if you push a patch add me and ill look at it tomorrow | 19:02 |
| opendevreview | Stephen Finucane proposed openstack/os-resource-classes master: Update CI to use unversioned jobs template https://review.opendev.org/c/openstack/os-resource-classes/+/834537 | 19:02 |
| stephenfin | sean-k-mooney: Cool. It's there btw ^ | 19:03 |
| opendevreview | Merged openstack/os-traits master: Update CI to use unversioned jobs template https://review.opendev.org/c/openstack/os-traits/+/833826 | 19:04 |
| gmann | stephenfin I missed it for os-traits but please update setup.cfg too to reflect the tested versions https://review.opendev.org/c/openstack/os-resource-classes/+/834537 | 19:13 |
| stephenfin | gmann: I'd rather not mix those two things though I'll admit they're related. Do we want to bump 'python-requires' also? | 19:14 |
| gmann | also, like i mentioned in ML reply, I have added to remove the release specific templates itself which will fix all these issue and less work during releases https://etherpad.opendev.org/p/tc-zed-ptg#L108 | 19:14 |
| gmann | stephenfin: yes we can bump python-requires also. They are related as if we do not test py3.6/7 then we should update it in classifier too. | 19:15 |
| gmann | in zed release template we will do the same for branched repo also | 19:16 |
| stephenfin | Oh, that's a good idea | 19:16 |
| gmann | in Zed: python-requires >= py3.8 and remove py3.6 and py3.7 from list | 19:16 |
| stephenfin | _Personally_, I'd question the value the classifiers bring. They aren't used by any tooling that I'm aware of, unlike python-requires. I wonder if we should get rid of them? | 19:17 |
| gmann | I think someone might be checking it from pypi doc but yes I do not have anyone asked about it explicitly | 19:19 |
| dansmith | gmann: yeah, maybe some centralized docs would be good | 19:25 |
| dansmith | gmann: I definitely think we need PTLs to get the word out though | 19:25 |
| gmann | dansmith: +1 on PTL one. I like to neutron way to track it in their weekly meeting. that is something we can suggest PTL to do. | 19:26 |
| gmann | I have added it in TC+PTL PTG etherpad | 19:27 |
| dansmith | yeah | 19:30 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily for a Gerrit patch upgrade and kernel update, but should return again shortly | 21:33 | |
| *** dasm is now known as dasm|afk | 21:45 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!