| opendevreview | Keigo Noha proposed openstack/nova stable/wallaby: libvirt: Always delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/828148 | 00:58 |
|---|---|---|
| *** hemna2 is now known as hemna | 01:36 | |
| *** amoralej|off is now known as amoralej | 07:33 | |
| *** hemna7 is now known as hemna | 07:38 | |
| opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | 08:07 |
| *** akekane_ is now known as abhishekk | 08:31 | |
| *** Uggla|afk is now known as Uggla | 08:39 | |
| *** lifeless_ is now known as lifeless | 09:24 | |
| kashyap | sean-k-mooney: Do you know if Swift is requirement for vTPM to work? The docs say no: https://docs.openstack.org/nova/latest/admin/emulated-tpm.html | 10:18 |
| kashyap | But the spec mentions "Swift" | 10:18 |
| sean-k-mooney | no its not | 10:19 |
| sean-k-mooney | the storage to swift was never implemented | 10:19 |
| kashyap | Ah-ha, good to know. | 10:20 |
| kashyap | Thank you | 10:20 |
| sean-k-mooney | if i recall correctly that was propsed for shelve which i belive we did not implement | 10:20 |
| sean-k-mooney | kashyap: barbican is needed however for the key management | 10:21 |
| kashyap | Yeah, figured as much from the doc | 10:21 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Include pf mac and vf num in port updates https://review.opendev.org/c/openstack/nova/+/824833 | 11:33 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | 11:33 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | 11:33 |
| dmitriis | sean-k-mooney: added handling for the PF PCI address + vf product/device id + remote managed tag case by using some additional info from sysfs: https://review.opendev.org/c/openstack/nova/+/824834/10/nova/pci/devspec.py#322 Also added unit tests to cover various ways to specify this in a whitelist | 11:38 |
| dmitriis | handling of ANY ("*") for vendor/product id along with PF PCI address specified is interesting | 11:39 |
| sean-k-mooney | well if its a PF and you dont specify the vendor and product id of the vf i think we can treat that as an error | 11:45 |
| sean-k-mooney | since pfs are not supported | 11:45 |
| sean-k-mooney | just using the adress of the pf woudl allow the pf not the vfs normally i belive | 11:45 |
| dmitriis | sean-k-mooney: looks like WhitelistPciAddress.match treats the presence of pci_phys_addr as an indicator that the caller is trying to match a VF https://review.opendev.org/c/openstack/nova/+/824834/10/nova/pci/devspec.py#252 And then PciDeviceSpec.match https://review.opendev.org/c/openstack/nova/+/824834/10/nova/pci/devspec.py#377 does a | 12:22 |
| dmitriis | comparison of its vendor_id/product_id against both ANY and the device dict passed in. | 12:22 |
| dmitriis | IIUC, something like this `passthrough_whitelist = {"vendor_id":"*","product_id":"*", "address":"0000:0a:00.0"}` would match both a PF with address 0000:0a:00.0 and any vendor/device ID, and VFs of any PF with a PCI address 0000:0a:00.0 | 12:30 |
| dmitriis | so, in summary: I could block this explicitly if remote_managed: "true" is present because it allows both PFs and VFs to be matched but we want to prohibit PFs. | 12:33 |
| sean-k-mooney | dmitriis: sorry was on a meeting reading back | 12:35 |
| dmitriis | np | 12:35 |
| sean-k-mooney | you mean block "vendor_id":"*","product_id":"*", explcitly if remote managed | 12:36 |
| sean-k-mooney | i think you need to do this outside of the whitelist/devspec parseing | 12:37 |
| sean-k-mooney | when we are constucting the device pools in the pci tracker we could block it as we woudl know if its a pf | 12:38 |
| sean-k-mooney | dmitriis: im just reviewing you latest patches by the way lets continue this conversation after that | 12:46 |
| dmitriis | sean-k-mooney: ack, trying to figure out what to move to PciDevTracker. There's some remove-managed-related logic already in the PciDeviceSpec in the current patches | 12:47 |
| sean-k-mooney | one important thign to rememebr is the nova/pci fould has to be driver independent so we need to ensure that we do not do any checks there that would be driver dependent. those need to live in the virt driver. in this case i think you can do checks pci manager possible in update_devices_from_hypervisor_resources | 12:49 |
| sean-k-mooney | similar to https://github.com/openstack/nova/blob/master/nova/pci/manager.py#L134-L136 | 12:50 |
| sean-k-mooney | that is currently delegating back to the whitelist class https://github.com/openstack/nova/blob/master/nova/pci/whitelist.py#L85-L93 | 12:51 |
| sean-k-mooney | but its really just validting the whitelist data is correct and that the device being tested is allowed | 12:51 |
| sean-k-mooney | dmitriis: i could maybe live with a check here https://github.com/openstack/nova/blob/master/nova/pci/whitelist.py#L92 | 12:52 |
| sean-k-mooney | assert that dev is not a pf if spec has remote managed | 12:53 |
| sean-k-mooney | dmitriis: perhaps it would make sense to change device_assignable to return the spec that allowed it so that you can use it to do other validation | 12:55 |
| dmitriis | sean-k-mooney: ok, I think I see where you are going. While the PF and VF-related checks for the remote-managed tag are not themselves driver-dependent, whether we need to do them or not is driver-depenent. | 12:55 |
| dmitriis | s/depenent/dependent/ | 12:56 |
| sean-k-mooney | well yes and no the data required to do the check is driver depenent since we need to get the list of device form the driver | 12:57 |
| sean-k-mooney | i guess technially you could get that from sysfs. | 12:57 |
| sean-k-mooney | im concerned that might break powervm | 12:57 |
| sean-k-mooney | or hyperv but im not sure it would | 12:57 |
| dmitriis | yeah, I added a couple of utils to do sysfs lookup in the last upload https://review.opendev.org/c/openstack/nova/+/824834/10/nova/pci/devspec.py#324 https://review.opendev.org/c/openstack/nova/+/824834/10/nova/pci/utils.py#217 | 12:58 |
| sean-k-mooney | so https://github.com/openstack/nova/blob/master/nova/pci/utils.py#L132-L144 could be called by the whitelist | 12:59 |
| sean-k-mooney | in device_assignable | 12:59 |
| sean-k-mooney | to check if the dev is a pf | 12:59 |
| sean-k-mooney | and you could see if it has remote managed and return true or false | 12:59 |
| sean-k-mooney | that would filter out the pfs | 13:00 |
| sean-k-mooney | may main concern with tha tis currently device_assinable does not make casles to the underlying system | 13:01 |
| sean-k-mooney | it used the in memory specs list and the data passed in | 13:01 |
| dmitriis | sean-k-mooney: there's one code-path where it may do it https://github.com/openstack/nova/blob/master/nova/pci/devspec.py#L290 | 13:02 |
| dmitriis | get_function_by_ifname uses sysfs for the netdev lookup | 13:03 |
| sean-k-mooney | yes indriectly by the match function | 13:03 |
| sean-k-mooney | with dev name | 13:03 |
| sean-k-mooney | so ya if it works for you i woudl move the check to device_assignable | 13:04 |
| sean-k-mooney | although | 13:04 |
| sean-k-mooney | you curently have it in _init_dev_details | 13:04 |
| sean-k-mooney | dmitriis: im just looking at https://review.opendev.org/c/openstack/nova/+/824834/9..10/nova/pci/devspec.py#287 | 13:05 |
| dmitriis | ack | 13:06 |
| opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | 13:08 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Use Row, not LegacyRow https://review.opendev.org/c/openstack/placement/+/828305 | 13:08 |
| dmitriis | sean-k-mooney: the goal of moving the checks closer to parsing was to avoid devices from getting into the pools in the first place (to avoid filtering PFs in PciDeviceStats) and for early config error detection. During the earlier reviews I went from (1) filtering in PciDeviceStats -> (2) returning false while matching in PciDeviceSpec -> (3) | 13:17 |
| dmitriis | raising exceptions in _init_dev_details | 13:17 |
| sean-k-mooney | dmitriis: while i dont nessisaly love doing these remote managed check in _init_dev_details i think im ok with it for now | 13:17 |
| sean-k-mooney | dmitriis: your current code avoids needeign to pass allow remote managed allover the place which was the main code smell | 13:18 |
| *** amoralej is now known as amoralej|lunch | 13:18 | |
| sean-k-mooney | we have other checks like | 13:18 |
| sean-k-mooney | if address and self.dev_name: | 13:18 |
| sean-k-mooney | raise exception.PciDeviceInvalidDeviceName() | 13:18 |
| sean-k-mooney | in _init_dev_details | 13:18 |
| sean-k-mooney | so it kind of fits there | 13:18 |
| dmitriis | sean-k-mooney: well, the other thing still needs addressing I think: https://review.opendev.org/c/openstack/nova/+/827839/2/nova/pci/devspec.py#318. Do we want to check for the use of `remote_managed: "true"` in case a driver doesn't support it? | 13:19 |
| dmitriis | perhaps not in the devspec.py code but I could try to expose a property on the whitelist and check for this elsewhere | 13:20 |
| sean-k-mooney | no i dont think so | 13:20 |
| sean-k-mooney | we could | 13:20 |
| dmitriis | sean-k-mooney: ok, so I can then just drop this altogether | 13:20 |
| sean-k-mooney | but the request filter woudl block it | 13:20 |
| sean-k-mooney | with the capablty traits | 13:20 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/812111/22/nova/scheduler/request_filter.py | 13:21 |
| sean-k-mooney | that is unconditionally enabled | 13:21 |
| sean-k-mooney | so as long as the driver does not incorrectly report the trait | 13:21 |
| dmitriis | so, we are essentially allowing `remote_managed: "true"` to be specified in the config even if a particular driver doesn't support it. It will not be surfaced to an operator early but other parts of the system will work as they should | 13:22 |
| sean-k-mooney | it the host will not be included in the set form placemnt | 13:22 |
| sean-k-mooney | i guess we could see how gibi feels but i think documenation fo "this only work with libvirt" + the prefileter is enough | 13:22 |
| dmitriis | Works for me. I'll just drop the extra check in the other patch for now and we can conclude there if we are ok with the result | 13:24 |
| dmitriis | since we document it for deployers/operators it should be ok in my view | 13:24 |
| sean-k-mooney | cool | 13:25 |
| sean-k-mooney | so assuming the neutorn lib stuff gets sorted we hopefully can get this all merged in the next week or two | 13:25 |
| sean-k-mooney | dmitriis: what is the state of the neutron code | 13:26 |
| dmitriis | sean-k-mooney: just got updated to include the new VNIC_TYPE_REMOTE_MANAGED https://review.opendev.org/c/openstack/neutron/+/808961/. Otherwise fnordahl promoted it from the WIP status and is waiting for reviews | 13:27 |
| dmitriis | there's also a second patch around extra validation https://review.opendev.org/c/openstack/neutron/+/818420 | 13:28 |
| dmitriis | the test failure on the first is about VNIC_TYPE_REMOTE_MANAGED so we're just waiting for it to land | 13:28 |
| sean-k-mooney | ok we likely need a depends on link agaisnt the neutorn series at some point in the nova one | 13:30 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/812111/22 should also be before https://review.opendev.org/c/openstack/nova/+/824835/13 i think | 13:31 |
| sean-k-mooney | dmitriis: when you respin those for the vnic type change can you put the filter before the final patch that enables the feature | 13:32 |
| sean-k-mooney | if that is a lot of work we can proably keep the order as is and just merge tehm together | 13:33 |
| sean-k-mooney | /together/at the same time/ | 13:33 |
| *** dasm|off is now known as dasm | 13:55 | |
| dmitriis | sean-k-mooney: ack, the filter one needs `is_smartnic_port` from the previous patch which I am going to replace to is_remote_managed_port | 14:07 |
| dmitriis | so I guess I could add the is_remote_managed_port in the filter patch instead and reorder | 14:08 |
| sean-k-mooney | if that is not a lot of touble i think it woudl better yes but ill leave that to you | 14:08 |
| sean-k-mooney | it just chagnes if we merge the patch all at one or together. | 14:09 |
| dmitriis | sean-k-mooney: ack, started looking into it now (had to attend a call) | 14:14 |
| opendevreview | Jonathan Race proposed openstack/nova master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 14:14 |
| *** amoralej|lunch is now known as amoralej | 14:22 | |
| sean-k-mooney | stephenfin: if you rebase https://review.opendev.org/c/openstack/nova/+/705792/12 it might help | 14:43 |
| sean-k-mooney | stephenfin: we are now skiping the failing test https://review.opendev.org/c/openstack/nova/+/705792/12 | 14:43 |
| stephenfin | zuul should do that for me | 14:43 |
| stephenfin | so long as there are no conflicts | 14:43 |
| sean-k-mooney | it should but i think the last run did not have it | 14:43 |
| sean-k-mooney | perhaps | 14:43 |
| sean-k-mooney | it was before that merged | 14:43 |
| sean-k-mooney | oh i ment https://review.opendev.org/c/openstack/nova/+/827851 | 14:44 |
| sean-k-mooney | ah it was | 14:44 |
| sean-k-mooney | the last run was on the 3rd | 14:44 |
| sean-k-mooney | the skip merged on the 5th | 14:44 |
| sean-k-mooney | stephenfin: after those two patches merge care to respin your mock replacement patch? | 14:45 |
| sean-k-mooney | oh looks like there is a func tst failure... | 14:46 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Extend the RP db query to support any-traits https://review.opendev.org/c/openstack/placement/+/825848 | 14:48 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: DB layer should only depend on trait id not names https://review.opendev.org/c/openstack/placement/+/826490 | 14:48 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Enhance doc of _get_trees_with_traits https://review.opendev.org/c/openstack/placement/+/825780 | 14:48 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Extend the RP tree DB query to support any-traits https://review.opendev.org/c/openstack/placement/+/825849 | 14:48 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Add any-traits support for listing resource providers https://review.opendev.org/c/openstack/placement/+/826491 | 14:48 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Add any-traits support for allocation candidates https://review.opendev.org/c/openstack/placement/+/826492 | 14:49 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Remove unused compatibility code https://review.opendev.org/c/openstack/placement/+/826493 | 14:49 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Add microversion 1.39 to support any-trait queries https://review.opendev.org/c/openstack/placement/+/826719 | 14:49 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | 14:49 |
| stephenfin | sean-k-mooney: Yoga is due the end of March, yeah? Assuming we can drop Python 3.6 (and maybe 3.7) then, I think we should just wait. unittest.mock has a solid number of bugs in 3.6 that we're having to work around, including that one in the func test | 14:52 |
| stephenfin | gibi: since you've been following that long-running effort ^ | 14:52 |
| gibi | stephenfin: I'm not sure what are the plans about dropping py36 | 14:57 |
| sean-k-mooney | gibi: we really reallly need too | 14:57 |
| gibi | but overall agree that if we can drop py36 that would help | 14:57 |
| sean-k-mooney | gibi: we shoudl not keep support after yoga | 14:57 |
| sean-k-mooney | i wanted to drop it this cycle but we kept it for centos 8 for one more release | 14:58 |
| sean-k-mooney | we shoudl be droping centos 8 entirly next release and with it 36 | 14:58 |
| gibi | ahh, yes centos 8 was the reason we kept it | 14:58 |
| sean-k-mooney | stephenfin: so yes let hold off so till we drop centos 8 and 36 | 14:58 |
| gibi | OK, lets drop centos 8 and py36 and then we can merge the unittest change a easier | 14:58 |
| gibi | sean-k-mooney: agree | 14:58 |
| stephenfin | Sweet. I'll mark as -W and comment as much. Thanks | 14:59 |
| sean-k-mooney | speaking of cento i shoudl proably finsh my "stack on c9s" and see what breaks taks | 14:59 |
| gibi | melwitt: thank you so much for review on the any-traits series. I've fixed your comments. | 14:59 |
| sean-k-mooney | chateaulav: by the way are you planning to split up https://review.opendev.org/c/openstack/nova/+/822053/34 | 15:01 |
| chateaulav | sean-k-mooney: i can,if that makes things easier? | 15:02 |
| sean-k-mooney | im not sure how tightly coupled that change is but its getting pretty large | 15:02 |
| sean-k-mooney | i would put the zuul job in its own patch at the end | 15:02 |
| sean-k-mooney | and maybe split the object changes into the fist pathc and then driver chagnes as second | 15:03 |
| sean-k-mooney | the schduler filter proably shoudl be before the driver changes | 15:03 |
| sean-k-mooney | but not sure if that is warented | 15:03 |
| sean-k-mooney | its only 2 lines so i woudl leave it in the driver change | 15:04 |
| sean-k-mooney | chateaulav: so ya if you could make it 3 patches that woudl be nice | 15:04 |
| chateaulav | sean-k-mooney: yeah that can work. is it usually best to create new patches overall and eventually abandon this once all are marged? or have this patch be one of the 3 | 15:05 |
| sean-k-mooney | objects/notifications, driver/secheduler/docs and zuul-job/roles | 15:05 |
| sean-k-mooney | am no i woudl keep this one adn split out the rest form it | 15:05 |
| chateaulav | sounds good | 15:05 |
| sean-k-mooney | thanks ill try an review it this week before or after the split | 15:06 |
| frickler | headsup: I just approved devstack switching Fedora from 34 to 35, you will want to check your depending jobs (not sure whether there are still any) | 15:08 |
| sean-k-mooney | frickler: we have an experimental job i think | 15:09 |
| sean-k-mooney | but we do not use fedroa in the gate normally | 15:09 |
| bauzas | reminder : nova meeting in 48 mins here at #openstack-nova | 15:11 |
| frickler | it will use py3.10, so might discover some interesting things like it did for horizon | 15:12 |
| sean-k-mooney | frickler: well we shoudl not need fedora to test that we shoudl be able to run the unit and functets already right | 15:13 |
| sean-k-mooney | but i agree that will break thigns proably | 15:13 |
| sean-k-mooney | frickler: part of the issue is soem of the things depercated in 3.6 are removed in 3.10 | 15:13 |
| frickler | I don't think there are other tests on py3.10 yet, still no pkgs for focal last time I checked | 15:13 |
| sean-k-mooney | and 3.11 will similar remove more things | 15:14 |
| gibi | stephenfin: if you are around do you have an insight how to fix this sphinx issue in a good way? | 15:26 |
| gibi | stephenfin: https://zuul.opendev.org/t/openstack/build/6b956593572d4d1c81ac65e46475f24e/log/job-output.txt the nova-specs doc gen fails with duplicet ref | 15:27 |
| gibi | stephenfin: it seems that _`[1]` type of refs are become global | 15:27 |
| gibi | stephenfin: and we have spec docs that are independently using those and causing the doc build to break now | 15:28 |
| gibi | if I have to guess it is caused by this feature from sphinx 4.4.0 https://github.com/sphinx-doc/sphinx/issues/9993 | 15:28 |
| stephenfin | gibi: Good find on the RFE. That's a bug IMO | 15:31 |
| stephenfin | Let me open a report. I think I'm a maintainer on Sphinx somehow :-D | 15:31 |
| gibi | stephenfin: thank you :) | 15:32 |
| gibi | I will try to pin back the sphinx version in nova-specs then | 15:32 |
| gibi | stephenfin: I confirmed that with Sphinx 4.3.2 the problem is not reproduceable | 15:36 |
| opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Avoid Sphinx 4.4.0 to fix specs doc build https://review.opendev.org/c/openstack/nova-specs/+/828368 | 15:40 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 15:45 |
| gmann | stephenfin: sean-k-mooney gibi py3.6 is there for Yoga testing but for sure in Z cycle it will be dropped from testing runtime. | 15:45 |
| gibi | gmann: sounds good. thanks for confirming | 15:46 |
| bauzas | gmann: any update so far about the Z naming ? | 15:48 |
| bauzas | I know it's in the hands of the legal folks | 15:48 |
| * bauzas wanted to tell something for this meeting | 15:48 | |
| gmann | bauzas: yeah, TC votes are done. it is under trademark checks from foundation which will be done in 1-2 weeks | 15:48 |
| bauzas | gmann: can we already know what was the TC votes ? | 15:49 |
| gmann | bauzas: may be by next week we might get name. but let's see how fast legal team is ready | 15:49 |
| gmann | bauzas: yeah, it is open | 15:49 |
| gmann | https://civs1.civs.us/cgi-bin/control.pl?id=E_693bd8bbe63ca52f&key=9ec9708dc7e8a814&akey=b13149621594beda | 15:49 |
| gmann | sorry, let me grab result one | 15:49 |
| gmann | https://civs1.civs.us/cgi-bin/results.pl?id=E_693bd8bbe63ca52f | 15:50 |
| gmann | ^^ this one | 15:50 |
| gmann | In the 'show details' button at bottom you can see 'Ballot report' too | 15:51 |
| bauzas | gmann: thanks | 15:52 |
| * Uggla Zen is exactly what i need this week managing my little daughter... ;) | 15:52 | |
| * bauzas remembers we have a nova meeting in 8 mins | 15:53 | |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 15:58 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Feb 8 16:00:42 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
| gibi | o/ | 16:00 |
| dansmith | o/ | 16:00 |
| gmann | o/ | 16:01 |
| chateaulav | \o | 16:01 |
| bauzas | sorry I was late, someone pinged me at house | 16:01 |
| elodilles | o/ | 16:01 |
| bauzas | ok, let's start | 16:02 |
| bauzas | #topic Bugs (stuck/critical) | 16:02 |
| bauzas | #info One Critical bug | 16:02 |
| bauzas | #link https://bugs.launchpad.net/nova/+bug/1959899 this is the critical bug for nova-next | 16:02 |
| bauzas | do we want to discuss this one ? | 16:02 |
| gibi | my last info | 16:03 |
| gibi | that artom and sean-k-mooney figured out that this is a q35 machine type related issue | 16:03 |
| gibi | then we turned off the test on master to unblock the gate | 16:03 |
| gibi | I don't know if there is any fix in the works | 16:03 |
| bauzas | oh shit | 16:04 |
| bauzas | ok, so maybe we should put it to High ? | 16:05 |
| * bauzas looked at the bug | 16:05 | |
| gibi | yeah we can decrease it to High as the gate is not blocked now | 16:05 |
| gibi | as we skip | 16:05 |
| bauzas | as this test is executed in other jobs | 16:05 |
| sean-k-mooney | we dont have a fix yet | 16:06 |
| sean-k-mooney | artom speculated it might be related to a state tracking but with qemu | 16:06 |
| bauzas | I'm only afraid of the fact it means we would have problems when upgrading | 16:06 |
| sean-k-mooney | that is still pending | 16:06 |
| bauzas | sean-k-mooney: at least this is blocking q35 to be the next machine type, right ? | 16:07 |
| artom | The only data point I have is that it passed without q35... once | 16:07 |
| artom | But it also passed intermittently *with* q35 on other patches | 16:07 |
| bauzas | ah, this is different then | 16:07 |
| sean-k-mooney | yes so q35 and pc use difffernt hotplug code paths | 16:07 |
| artom | So... more testing needed? | 16:07 |
| bauzas | I guess | 16:07 |
| bauzas | anyway, let's punt the bug report to High | 16:07 |
| sean-k-mooney | bauzas: we als think the way the device is presented in teh guest might change based on q35 or pc | 16:08 |
| bauzas | but we need to fix this bug | 16:08 |
| sean-k-mooney | so we shoudl keep looking into it and try and fix it | 16:08 |
| sean-k-mooney | yep | 16:08 |
| sean-k-mooney | it may not be fixable in nova | 16:08 |
| sean-k-mooney | but we have nto figure that out yet | 16:08 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Fix clean-up process for aborted queued live migrations https://review.opendev.org/c/openstack/nova/+/828374 | 16:09 |
| gibi | artom: this test runs in tempest-integrated-compute job with pc machine type | 16:09 |
| gibi | artom: and it appears to be green there | 16:09 |
| bauzas | could we create another job for testing ? | 16:10 |
| bauzas | non-voting, of course | 16:10 |
| sean-k-mooney | this is the qemu bug we think might be relevent https://bugzilla.redhat.com/show_bug.cgi?id=2007129 | 16:10 |
| sean-k-mooney | bauzas: i htink we have enough test coverage with teh integrated job | 16:11 |
| gibi | agree ^ | 16:11 |
| bauzas | OK | 16:11 |
| sean-k-mooney | so i think we can move on for now and just monitor/investigate | 16:11 |
| bauzas | cool then, we can moveo n | 16:11 |
| bauzas | move on, even | 16:11 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 39 new untriaged bugs (+0 since the last meeting) | 16:11 |
| bauzas | #help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage | 16:12 |
| bauzas | I triaged a few evident bugs | 16:12 |
| bauzas | #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement | 16:12 |
| bauzas | that's it for bugs | 16:13 |
| bauzas | any ones to tell ? | 16:13 |
| bauzas | looks not | 16:14 |
| bauzas | #topic Gate status | 16:14 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:14 |
| bauzas | we discussed the critical one | 16:14 |
| gibi | besides the one we discussed | 16:14 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status | 16:14 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:14 |
| gibi | the nova-specs doc build is broken due to sphinx 4.4.0 | 16:14 |
| gibi | fix is here https://review.opendev.org/c/openstack/nova-specs/+/828368 | 16:15 |
| gibi | and here https://github.com/sphinx-doc/sphinx/pull/10178 (thanks to stephenfin) | 16:15 |
| bauzas | saw it, had no time to vote yet | 16:15 |
| bauzas | vote coming up after the meeting | 16:15 |
| gibi | cool | 16:15 |
| gibi | thanks | 16:15 |
| stephenfin | please pile on the latter bug (+1) if you can :) | 16:15 |
| gmann | +A, 4.4.0 has caused on ext link other repo too | 16:15 |
| gmann | in governance doc etc | 16:16 |
| bauzas | damn, you beat me | 16:16 |
| gibi | gmann: is there a global requiremnet fix up for it or should I push? | 16:16 |
| stephenfin | and indicate on the bug if there are other failures other than nova-specs. Sounds like there are | 16:16 |
| gmann | gibi: that was different i fixed few on governance repo but removed ext_link from election repo as thre were many to fix | 16:16 |
| gmann | example #link https://review.opendev.org/c/openstack/governance/+/825257 | 16:17 |
| bauzas | stephenfin: I'm afraid we would need to modify our specs and docs in order to make them compliant with a foreseenable future of sphinx ? | 16:17 |
| gmann | but that was for extlink in conf | 16:17 |
| stephenfin | I don't think so. I think it's a bug | 16:17 |
| sean-k-mooney | i think in this cae there was only 1 duplicate link | 16:17 |
| bauzas | stephenfin: or does sphinx team said sorry it was an unwanted regression? | 16:17 |
| gibi | gmann: ohh OK, so that is different | 16:17 |
| gmann | there were many change in 4.4.0 which broke our existing doc | 16:18 |
| stephenfin | doing e.g. [1] style referencing is a perfectly reasonable thing to do | 16:18 |
| bauzas | stephenfin: ok, so bug it was, not a feature | 16:18 |
| bauzas | stephenfin: we'll propose you a full-time job for fixing our docs then | 16:18 |
| stephenfin | Both. It was a feature that was a breaking change | 16:18 |
| sean-k-mooney | yep within a singel doc it shoudl be fine | 16:18 |
| gibi | sean-k-mooney: nope, there are many, sphinx gave up parsing at the first duplicate | 16:18 |
| sean-k-mooney | ah ok | 16:18 |
| sean-k-mooney | so the "feature" was treating them a global link targets | 16:19 |
| sean-k-mooney | not local to the current doc? | 16:19 |
| gibi | sean-k-mooney: something like that | 16:19 |
| sean-k-mooney | that would be a problem ya | 16:19 |
| stephenfin | shouldn't have happened in minor release or arguably at all. Context in the upstream bug https://github.com/sphinx-doc/sphinx/issues/10177 | 16:19 |
| bauzas | just to make it clear, that means we have homework before accepting 4.4.x, right? | 16:19 |
| sean-k-mooney | ack | 16:19 |
| sean-k-mooney | well or we can see if we can get this reverted | 16:20 |
| sean-k-mooney | or made configurable | 16:20 |
| bauzas | stephenfin: ah I see | 16:20 |
| gibi | sean-k-mooney: yepp, stephenfin proposed the revert :) | 16:20 |
| sean-k-mooney | if we need too its proably scriptable to make them unique | 16:20 |
| sean-k-mooney | but ya lets see what happens with stephenfin pr | 16:20 |
| gmann | another gate failure we discussed in QA meeting is about failure in devstack-platform-centos-9-stream job which seems 100 % #link https://zuul.openstack.org/builds?job_name=devstack-platform-centos-9-stream&skip=0 | 16:21 |
| gmann | rescue server test failing on volume detach #link https://a886e0e70a23f464643f-7cd608bf14cafb686390b86bc06cde2a.ssl.cf1.rackcdn.com/827576/6/check/devstack-platform-centos-9-stream/53de74e/testr_results.html | 16:21 |
| gmann | I have not checked log yet, in case anyone aware of it? | 16:21 |
| gibi | that feels new | 16:22 |
| gibi | at least to me | 16:22 |
| gmann | ok, let me see if I get any info in logs and then will report bug | 16:24 |
| gibi | thanks | 16:24 |
| bauzas | the error seems weird | 16:24 |
| bauzas | InvalidVolume | 16:24 |
| bauzas | but a timeout | 16:25 |
| bauzas | which indicates something bad happening on the cinder side | 16:25 |
| gibi | affraid it is libvirt device detach issue again | 16:26 |
| gibi | https://zuul.openstack.org/build/3e24d977991d4536b6279afd7f3b5d56/log/controller/logs/screen-n-cpu.txt?severity=4#49433 | 16:26 |
| bauzas | gibi: on centos then ? | 16:28 |
| gibi | for some reason it is hitting only that centos job but hitting it hard | 16:28 |
| gmann | yeah | 16:29 |
| bauzas | ok, I guess we need to investigate more, next | 16:29 |
| bauzas | #topic Release Planning | 16:30 |
| bauzas | #link https://releases.openstack.org/yoga/schedule.html#y-ff FeatureFreeze in 2.5 weeks | 16:30 |
| bauzas | #link https://etherpad.opendev.org/p/nova-yoga-blueprint-status Etherpad for blueprints tracking | 16:30 |
| bauzas | thanks gibi for having made a couple of insighful reviews | 16:30 |
| bauzas | I started to review as well | 16:30 |
| bauzas | folks, just a reminder to use this etherpad for coordinating review requests and comments | 16:31 |
| bauzas | any particular BP someone wanting to address by now ? (provided this is not about asking reviews) | 16:31 |
| gmann | added link for policy refresh 2 BP and moved up for review section #link https://etherpad.opendev.org/p/nova-yoga-blueprint-status#L40 | 16:32 |
| gmann | It is not complete yet, I am working on system_reader conversion | 16:32 |
| gmann | but existing patches is up for review | 16:33 |
| gmann | dansmith: ^^ I am +2 on your patches for server policy | 16:33 |
| opendevreview | Merged openstack/nova-specs master: Avoid Sphinx 4.4.0 to fix specs doc build https://review.opendev.org/c/openstack/nova-specs/+/828368 | 16:33 |
| bauzas | gmann: thanks | 16:33 |
| dansmith | gmann: ack, I've been wondering when that was going to go | 16:33 |
| bauzas | anyone wanting to discuss now about priorities ? | 16:33 |
| dansmith | bauzas: want a note on the quotas stuff? | 16:33 |
| gmann | dansmith: lot of test to fix so taking time but I am working on remaining policies | 16:33 |
| bauzas | dansmith: I started looking at your comment | 16:33 |
| bauzas | on the next patch I wanted to review | 16:34 |
| dansmith | bauzas: well, | 16:34 |
| bauzas | dansmith: those are reasonable concerns but I started reviewing this patch too | 16:34 |
| dansmith | melwitt and I discussed a few refactoring changes | 16:34 |
| dansmith | after my first review, and we're still working on hammering those out | 16:34 |
| bauzas | dansmith: given the series, do you feel she needs to rebase his change or can she work on a follow-up patch ? | 16:35 |
| bauzas | (well, can ping melwitt actually for the answer) | 16:35 |
| dansmith | I'm working on the rebase now, | 16:35 |
| dansmith | but yeah, we're actually going to drop the latest PS, back to the previous and iterate from there | 16:35 |
| dansmith | I'm almost done with that actually, | 16:35 |
| dansmith | but want to sync with her when she's around this morning before I push that major change up :) | 16:36 |
| bauzas | dansmith: ok, then I'll look at other bps tonight and I'll look back at the unified limits one tomorrow | 16:36 |
| bauzas | thanks for the notice | 16:36 |
| dansmith | aye | 16:36 |
| bauzas | fwiw, I thought about a simple thing for giving ourselves visibility during the last 3-week sprint | 16:37 |
| bauzas | if cores don't disagree, I'd recommend cores to mark their IRC nicks on the BPs they'd like to review this week | 16:37 |
| bauzas | no obligation | 16:37 |
| bauzas | just a matter of giving a bit of visibility for the people who want | 16:38 |
| bauzas | feel it like it's runways or whatever name it is | 16:38 |
| bauzas | it's just about adding a bullet point below each blueprint on the blueprint etherpad for people willing to mark their names | 16:39 |
| bauzas | another option could be the Review-Priority flag :) | 16:39 |
| bauzas | what folks think about it ? maybe this is a bit early ? | 16:40 |
| gibi | I can do both | 16:40 |
| gmann | either is fine, I will review tenant-id series this week | 16:41 |
| bauzas | I don't want to ask for duplicate things | 16:41 |
| bauzas | I feel we can use the review-prio flag then | 16:42 |
| bauzas | but that means we need to clean it up first | 16:42 |
| gibi | there is not much marked with review priority at the moment | 16:43 |
| bauzas | ok, then let's jump straight to the next topîc | 16:43 |
| bauzas | #topic Review priorities | 16:44 |
| bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B1 | 16:44 |
| gibi | pack and spread, remote-manged and unified limits are all has core review attention so they are good having the prio label | 16:45 |
| bauzas | right | 16:45 |
| gibi | the other patches in that list feels less important now | 16:45 |
| bauzas | pack-n-spread doesn't match a bp | 16:45 |
| bauzas | but I'm ok with treating it as some kind of feature request | 16:46 |
| bauzas | anyway, let's overthink that | 16:46 |
| bauzas | sean-k-mooney: can you drop r-p flag on https://review.opendev.org/c/openstack/os-vif/+/765912 and https://review.opendev.org/c/openstack/os-vif/+/765970 | 16:47 |
| bauzas | those are old patches that fail CI, hence meaningless to be 'priorities' | 16:47 |
| sean-k-mooney | yes | 16:48 |
| bauzas | https://review.opendev.org/c/openstack/os-resource-classes/+/819207 will be tonight's priority for me | 16:48 |
| bauzas | so hopefully we could merge it | 16:48 |
| sean-k-mooney | done | 16:48 |
| bauzas | that would leave the other changes having r-p matching blueprints | 16:48 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | 16:49 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Add supports_remote_managed_ports capability https://review.opendev.org/c/openstack/nova/+/827839 | 16:49 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Filter computes without remote-managed ports early https://review.opendev.org/c/openstack/nova/+/812111 | 16:49 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add support for VNIC_REMOTE_MANAGED https://review.opendev.org/c/openstack/nova/+/824835 | 16:49 |
| bauzas | let's finish this discussion next week and make the r-p flag be the tool for coordinating review priorities for this feature freeze | 16:50 |
| bauzas | agreed ? | 16:50 |
| gibi | works for me | 16:50 |
| bauzas | anyway, moving on, time is flying | 16:51 |
| bauzas | #topic Stable Branches | 16:51 |
| bauzas | elodilles: your turn | 16:51 |
| elodilles | #info stable/queens and stable/pike gates are blocked by docs job (details: http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027106.html ) | 16:51 |
| elodilles | i'm planning to propose some patch to unblock the gate | 16:52 |
| elodilles | probably just removing the doc job (if i cannot make the sphinx job to work) | 16:52 |
| elodilles | #info other stable gates are not blocked, but hard to merge patches due to intermittent failures | 16:52 |
| elodilles | probably Lee's patches, that would disable guest's apic in CI, could eliminate some part of the problem for wallaby and older branches: https://review.opendev.org/q/topic:workaround-disable-apic | 16:53 |
| elodilles | so if any stable core has some time to review ^^^ that would be nice | 16:53 |
| elodilles | and that's all i think :X | 16:53 |
| dmitriis | sean-k-mooney, gibi: resubmitted with the VNIC type change and other stuff included. | 16:54 |
| bauzas | dmitriis: we're in a meeting, please | 16:54 |
| bauzas | elodilles: thanks elod | 16:54 |
| dmitriis | bauzas: apologies | 16:54 |
| bauzas | dmitriis: no worries, that's one of the issues we have with meetings running at the existing channel | 16:54 |
| bauzas | elodilles: will promise a few reviews if I have time | 16:55 |
| bauzas | last topic | 16:55 |
| bauzas | #topic Open discussion | 16:55 |
| elodilles | bauzas: thanks in advance! \o/ | 16:55 |
| bauzas | (skipping the subteam topic meaningless) | 16:55 |
| bauzas | Z release name should be known in 1 or 2 weeks | 16:55 |
| bauzas | let's hold until we know which Zen or Zombie we'll have | 16:55 |
| * bauzas imagines the Foundation lawyers scratching their heads trying to guess whether Zen is trademarked | 16:56 | |
| bauzas | not saying some chip company used that word | 16:57 |
| DHilsbos | Maybe they'll meditate on it... | 16:57 |
| bauzas | anyway | 16:57 |
| bauzas | any other business before we close ? | 16:57 |
| DHilsbos | Is now a good time to ask for assistance with a feature for Z? | 16:58 |
| bauzas | DHilsbos: nothing prevents you to get assistance | 16:58 |
| bauzas | DHilsbos: this is just a matter of priorities | 16:58 |
| DHilsbos | My question is more along the lines of process. | 16:59 |
| bauzas | the Z specs repo isn't yet created but you can work on WIP patchers | 16:59 |
| bauzas | patches* | 16:59 |
| bauzas | DHilsbos: then, let's close this meeting and we'll discuss this right after | 16:59 |
| bauzas | thanks all | 16:59 |
| bauzas | #endmeeting | 16:59 |
| opendevmeet | Meeting ended Tue Feb 8 16:59:34 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-08-16.00.html | 16:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-08-16.00.txt | 16:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-08-16.00.log.html | 16:59 |
| elodilles | thanks bauzas o/ | 16:59 |
| bauzas | DHilsbos: what do you want about the release process for Z ? | 16:59 |
| bauzas | what do you want to know* | 17:00 |
| gibi | dmitriis: I will check tomorrow | 17:00 |
| dmitriis | gibi: ack, tyvm | 17:00 |
| DHilsbos | I have made changes to the libvirt driver that brings it inline (maybe) with a feature for Hyper-V, I'd like to submit that code. | 17:01 |
| bauzas | DHilsbos: then you'll need a blueprint | 17:02 |
| bauzas | DHilsbos: you can start writing this blueprint | 17:02 |
| bauzas | and then working on patches | 17:02 |
| DHilsbos | Ok, that's what I trhought. Are there blueprint forms? | 17:02 |
| bauzas | but we won't look at both patches and the blueprint until RC1 which is when Z becomes a thing | 17:03 |
| dansmith | I'm sure anything with that description requires a spec and not just a blueprint | 17:03 |
| dansmith | and yes, there's a spec template :) | 17:03 |
| bauzas | DHilsbos: there is even a button | 17:03 |
| bauzas | dansmith: don't disagreed, just oversimplified the explanation | 17:03 |
| DHilsbos | I'm not suprised by the need for the spec. | 17:04 |
| bauzas | https://docs.openstack.org/nova/latest/contributor/process.html#when-do-i-need-a-blueprint-vs-a-spec | 17:04 |
| DHilsbos | So; Blueprint, spec, patches, yeah? | 17:04 |
| bauzas | blueprint is the first procedural step | 17:04 |
| DHilsbos | Ok. | 17:05 |
| bauzas | then you'd have to upload a spec if you really care in advance but given the directory name isn't created yet due to legal naming implications ( :) ) you'd have to either refrain to push or fake a name when you uploda | 17:05 |
| DHilsbos | Anyone on that is famialir with the Hyper-V driver code? | 17:06 |
| bauzas | and then rebase your spec change with the proper dirname once known and created | 17:06 |
| bauzas | DHilsbos: I guess you'll find plenty of people who are familiar with the process that aren't familiar with Hyper-V | 17:06 |
| bauzas | the contrary seems difficult to me | 17:07 |
| bauzas | DHilsbos: but yeah, if you really care about a feature, just start writing a few things in a blueprint and try to grab me or someone else once we're free | 17:08 |
| DHilsbos | I need to know what the hw:virtual_displays flavor extra_spec does within Hyper-V | 17:08 |
| opendevreview | Merged openstack/os-resource-classes master: Test all supported python version https://review.opendev.org/c/openstack/os-resource-classes/+/819207 | 17:08 |
| bauzas | gmann: ^ | 17:08 |
| gmann | bauzas: thanks | 17:08 |
| DHilsbos | It can wait for Z naming to be addressed. I'll start writing the blueprint. | 17:09 |
| bauzas | DHilsbos: https://docs.openstack.org/nova/latest/configuration/extra-specs.html#hw | 17:09 |
| DHilsbos | hw:virtual_displays is not present on that page. | 17:10 |
| bauzas | correct, because it's virt-specific | 17:11 |
| bauzas | which we now are relunctant to add | 17:12 |
| DHilsbos | Ah, ok. | 17:13 |
| DHilsbos | So, looking at naming, I think I would need something like "hw_video:count"? | 17:13 |
| DHilsbos | I think I understand what is needed, thank you. | 17:14 |
| bauzas | spec it up, I guess :) | 17:14 |
| *** Uggla is now known as Uggla|afk | 17:15 | |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 17:20 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 17:30 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 17:31 |
| *** amoralej is now known as amoralej|off | 17:39 | |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | 17:49 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 17:53 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 17:58 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 18:01 |
| opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Change to make live_migration_downtime clearer https://review.opendev.org/c/openstack/nova/+/828387 | 18:03 |
| opendevreview | Dan Smith proposed openstack/nova master: Join quota exception family trees https://review.opendev.org/c/openstack/nova/+/828185 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Move keypair quota error message into exception https://review.opendev.org/c/openstack/nova/+/828186 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | 18:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | 18:57 |
| dansmith | melwitt: ^ | 18:57 |
| dansmith | I think it turned out nice | 18:57 |
| dansmith | there's one thing in the placement patch where it was raising quotaerror more like an actual error because of a placement failure | 18:57 |
| dansmith | but it was raising quotaerror which was actually the over-quota case before, so I converted it as such, | 18:58 |
| dansmith | but I think we should probably not just be copying the api/network/whatever failure into the OverQuota.message, for the same reason as the session init thing from earlier | 18:58 |
| melwitt | dansmith: ok cool, thanks | 18:59 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 19:16 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828413 | 19:27 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828414 | 19:27 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 19:28 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 19:32 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828418 | 19:40 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828419 | 19:40 |
| artom | fsck me that was mostly clean to wallaby, and I don't think we need it further | 19:40 |
| * artom double checks | 19:41 | |
| artom | Well, at least downstream we don't | 19:41 |
| artom | ... and same for upstream \o/ | 19:42 |
| artom | For some reason I was expecting stable/train levels of pain | 19:43 |
| chateaulav | https://www.irccloud.com/pastebin/XwYHRJuH/ | 19:46 |
| chateaulav | any advice is appreciated | 19:46 |
| artom | chateaulav, you don't need Depends-on if it's in the same project (nova) | 19:51 |
| artom | Just stack them on top of each other | 19:51 |
| artom | IOW, locally `git commit` as many patches as makes sense, then `git review` them in one shot | 19:52 |
| chateaulav | ok, so then to make sure i understand. remove the depends on, make all my commits and then when all the commits are staged do review and it will run all of them. | 19:53 |
| artom | Yep | 19:55 |
| artom | So if you have A depends on B depends on C | 19:55 |
| artom | Commit C first, then B, then A, then submit for review | 19:55 |
| artom | And if you have A depends on B depends on C but also D depends on C | 19:56 |
| artom | Commit C first, then C and D in either order, then A | 19:56 |
| artom | "linearize" it, so to speak | 19:56 |
| artom | Sorry, then B and D in any order, then A | 19:57 |
| chateaulav | artom: ok, makes sense | 20:12 |
| opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | 20:18 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 20:25 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 20:26 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 20:26 |
| opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | 20:54 |
| *** prometheanfire is now known as Guest0 | 20:56 | |
| *** osmanlicilegi is now known as Guest1 | 20:56 | |
| *** Guest0 is now known as prometheanfire | 21:56 | |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | 22:23 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | 22:23 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Add supports_remote_managed_ports capability https://review.opendev.org/c/openstack/nova/+/827839 | 22:23 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Filter computes without remote-managed ports early https://review.opendev.org/c/openstack/nova/+/812111 | 22:23 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Add support for VNIC_REMOTE_MANAGED https://review.opendev.org/c/openstack/nova/+/824835 | 22:23 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | 22:23 |
| *** mdbooth8 is now known as mdbooth | 22:50 | |
| opendevreview | Merged openstack/nova master: neutron: Rework how we check for extensions https://review.opendev.org/c/openstack/nova/+/705792 | 22:56 |
| *** dasm is now known as dasm|off | 23:02 | |
| *** mdbooth8 is now known as mdbooth | 23:02 | |
| *** mdbooth3 is now known as mdbooth | 23:30 | |
| opendevreview | melanie witt proposed openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | 23:32 |
| opendevreview | melanie witt proposed openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!