Tuesday, 2022-01-18

*** tbachman__ is now known as tbachman00:16
sean-k-mooney[m]ade_lee ack. ill take a look again tomorrow but looks like everything passed. i think it would still be worth trying to enable zswap as a seperate patch but glad the oom issue are gone00:48
*** tbachman_ is now known as tbachman01:09
*** tbachman_ is now known as tbachman01:44
*** tbachman_ is now known as tbachman01:52
*** tbachman_ is now known as tbachman02:01
*** tobias-urdin5 is now known as tobias-urdin02:09
*** tbachman_ is now known as tbachman02:09
*** tbachman_ is now known as tbachman02:43
*** EugenMayer4 is now known as EugenMayer02:45
*** artom__ is now known as artom03:28
opendevreviewMerged openstack/nova master: Move ReaderWriterLock to the test tree  https://review.opendev.org/c/openstack/nova/+/82493106:27
opendevreviewLior Friedman proposed openstack/nova master: support use_multipath for nvme driver. Update nvme UT. Add release notes. Change-Id: I20f6aa2d422259601c44d024099cd5760a8e21c6  https://review.opendev.org/c/openstack/nova/+/82394107:33
plibeau2lyarwood: hello, sorry to push you my pull request again :) https://review.opendev.org/c/openstack/nova/+/820531/508:23
*** xek_ is now known as xek13:26
*** dasm|off is now known as dasm13:31
elodillesbauzas: are you updating the nova meeting wiki right now? because if not, then i'll update the stable part there14:18
bauzaselodilles: do the stable things14:20
bauzaselodilles: I'll update later14:20
bauzasgibi: food for thoughts https://bugs.launchpad.net/nova/+bug/195698314:20
sean-k-mooney1bauzas: that is propably realted to the other bug we have in that area14:32
sean-k-mooney1currently FFU is broken14:32
sean-k-mooney1we are checkign the min service version not the min service version fo the running computes14:32
elodillesbauzas: thanks, done14:32
sean-k-mooney1so you cant skip level upgrade the contoler to n+3 and start it as it will fail the check even if you have stopped all compute unless you work aroudn it with force down14:33
gibibauzas: context L398 https://etherpad.opendev.org/p/nova-wallaby-ptg14:38
gibiwe prevent starting services with older than N-1 computes since https://review.opendev.org/c/openstack/nova/+/73848214:38
gibiwhich is merged in wallaby14:39
sean-k-mooney1gibi: yep but that has a bug in it14:39
sean-k-mooney1i assume you have seen the mail thread14:39
gibisean-k-mooney1: I saw the ML thread, I did not see the bug report yet14:39
sean-k-mooney1i dont think they filed one14:40
gibibauzas: so I think the bug is already fixed since wallaby 14:40
gibi:)14:40
gibisean-k-mooney1: as of the bug in the N-1 check14:40
sean-k-mooney1but looking at the code you cannot start the nova conductor of you have n-2 comptue in the db not just n-2 compute running14:40
gibisean-k-mooney1: I still need to dig up more context14:40
gibisean-k-mooney1: I feel our original intention was to detect even stopped computes14:40
gibibut I'm not sure14:40
sean-k-mooney1well that makes FFU impossible14:41
gibiif FFU is broken then we have to do someting14:41
sean-k-mooney1well it depend the only escape hatch in the current code is to force all compute as down14:42
gibiwhich is probably unintentional too :)14:42
sean-k-mooney1possible14:42
gibiI'm wondering what would happen in an N could if an N-2 compute that was stopped now suddenly started up14:43
sean-k-mooney1in the ffucase if you update the contoler to n+3 then the condcutre wont be able to start until after you have updated all compute agent but they wont be abel to start cause the conductor is stopped14:43
sean-k-mooney1gibi: ideally the comptue should fail to start but the conductor should keep running14:43
gibisean-k-mooney1: OK, so now we probably fail backward as we not allow to start the new controller, but we should fail forward and only not allow the old compute to start up14:44
sean-k-mooney1no14:45
sean-k-mooney1we want the contoler to start we dont want the computes to start14:45
sean-k-mooney1until they are upgraded14:45
gibido we allow starting up an N-2 controller in an N cloud?14:46
gibior even an N-1 controller?14:46
sean-k-mooney1the contoler process, conductor in particalar need to be running so the compute can update its version in the db14:46
sean-k-mooney1gibi: today proably14:46
sean-k-mooney1which woudl be unsupported 14:46
sean-k-mooney1since the contoler shoudl always be upgraded first14:47
sean-k-mooney1i mean if you clamp the rpc apis in the config you can praobly make it work but the assumtion we have is contoler are always newer or the same version as the computes14:47
*** sean-k-mooney1 is now known as sean-k-mooney14:51
sean-k-mooneygibi: basicaly i think we shoudl either modify the check to only consider up compute servics or we shoudl move the check to the compute agent instead14:52
gibihehe, I had considered disabled old computes https://review.opendev.org/c/openstack/nova/+/738482/4..10/nova/service.py#43014:52
sean-k-mooneyor add a config option to opt out of the check for ffu14:52
sean-k-mooneyfor what its worth i did some testing with devstack not so long ago14:53
sean-k-mooneyif i disable the version check you can mix wallaby contoler with train computes14:53
sean-k-mooneyto enable better upgrades we are considering supproting that as an upgrade path in the future downstream. not for train to wallaby but from wallaby to whatever our next release would be based on14:54
gibihm, a disable but running old compute can cause trouble in the cluster, a disable + force down compute cannot as we define force_down as "admin-promised-it-is-not-running"14:55
gibialso based on the discussion in the original patch14:55
sean-k-mooneyyes force down means this is down nova just has not noticed yet i promise14:55
gibiso at leat keeping the force_down make sense14:56
gibiI'm not sure about the disable but running compute14:56
sean-k-mooneywell i was not thinking about disable14:56
sean-k-mooneyi was thinking more up=false14:56
gibiahh14:56
sean-k-mooneyso heartbeat is missing and we mark it as down14:56
gibiso the compute definition exists in the db but the compute is timed out 14:56
sean-k-mooneyya presujmably because you stop it on the compute hosts as part of the upgrade14:57
gibiit could be a network partition but it also can be a manual stop yes14:57
sean-k-mooneywell if it a network partiion it cant talk to the conductor :) but honestly i think the check is better done on the comptue side then the conductor side14:58
gibiyeah but the check on the compute side only work if the compute is restarted14:58
gibiif the compute is running14:58
gibithen no check happens14:58
sean-k-mooneythat is fair14:58
gibithat prevent the old compute to send nonsense to new conductor14:58
gibiprobably there is no perfect solution14:59
gibias from the controller perspective a timed out compute can mean multiple things14:59
sean-k-mooneyi mean for now we have the workaround of before you FFU stop all compute agaents and force themn down in the api14:59
gibiyeah, and while that is an extra step it does not create an extra inconsistency15:00
gibiyou just need to double confirm that those computes are not coming back 15:00
gibiwithout a restart15:00
sean-k-mooneyhonestly unless we have done a major rpc bump the comptue wont impact the conductor if they start15:00
sean-k-mooneybut yes if you use force down you shoudl fulfil its requiremetns15:01
gibihm an old compute cannot decided if it is too old, as the old code does not know what is the service version of the N+2 release15:02
gibiexcept if we backport fixes to stable branches after the N15:03
gibiN+2 release15:03
sean-k-mooneywell i was more thingink it would try to connect to the conductor and it would say its too old15:03
sean-k-mooneybut ya they cant really15:03
gibiyeah the conductor could tell the compute to go away you are too old15:04
sean-k-mooneyit will do that if a new compute tries to regeister15:04
bauzasgibi: I could be late for the meeting, could you please start it if so ?15:17
bauzasthe agenda is updated15:17
* bauzas rushes15:17
bauzasreminder : nova meeting starts in 42 mins here15:18
gibibauzas: sure15:22
gibijust a quick reminder nova meeting starts in 13 minutes here in the channel15:47
bauzasI'm back15:57
bauzasright on time15:57
* bauzas heads to the coffee machine15:57
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Jan 18 16:00:00 2022 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
gibio.16:00
gibio/16:00
* bauzas bows to the community16:00
chateaulav\o16:00
elodilleso/16:00
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:01
bauzasok, let's start16:01
bauzas#topic Bugs (stuck/critical) 16:02
bauzas #info No Critical bug16:02
bauzas#info No Critical bug16:02
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 32 new untriaged bugs (-4 since the last meeting)16:02
bauzas#help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage16:02
bauzas#link https://storyboard.openstack.org/#!/project/openstack/placement 23 open stories (-2 since the last meeting) in Storyboard for Placement 16:02
bauzasthanks to those who helped to triage16:02
bauzas(I dunno who about placement :p)16:02
gibibauzas: can be that the any-trait spec merges closed the related ticjket16:04
gibiI will check16:04
bauzasmaybe16:04
bauzasanyway16:04
bauzasany bug to want to discuss ?16:04
bauzaslooks not16:05
bauzas#topic Gate status 16:05
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:05
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status 16:05
bauzas#info Please look at the gate failures, file a bug, and add an  elastic-recheck signature in the opendev/elastic-recheck repo (example: https://review.opendev.org/#/c/759967)16:05
bauzaslet's discuss about the centos8 job with elodilles in the stable branches topic16:06
gibi(yepp the two missing placement ticket is the any-trait support, I will reopen them by creating an open task on them)16:06
bauzasapart from this job, nothing to say16:06
bauzasanyone ?16:06
bauzasmmmm, ok, let's move16:08
bauzas#topic Release Planning 16:08
bauzas#info FeatureApprovalFreeze was Jan 13st16:08
bauzas#link https://blueprints.launchpad.net/nova/yoga 23 approved blueprints for the Yoga cycle with 16 of them having specs16:08
bauzas#link https://etherpad.opendev.org/p/nova-yoga-blueprint-status Etherpad for blueprints tracking 16:08
bauzasso, as you see, I created an etherpad for yoga16:08
bauzasI'll look at each of the blueprints16:08
bauzasand I'll modify the etherpad to explain which ones are started, and which ones need reviews16:09
bauzasbut if folks want to modify the etherpad and explain the changes they have for their blueprint, fine by me :)16:09
bauzasevery meeting until FeatureFreeze, I'll provide this etherpad during the meeting16:10
gibicool16:10
bauzasjust remember that we now have 6 weeks before it16:10
bauzasanyway, let's discuss about this etherpad by next week as I need to modify it for providing the changes16:11
bauzasalso, last thought16:11
bauzasgiven it's difficult to merge API changes as they're conficting once we merge one16:12
bauzasI'll provide all the changes wanting to add a new microversion16:12
sean-k-mooneyya we can likely come up with a merge order when we get a little closer to FF16:12
bauzasso during the reviews, people could organize themselves to see who and what could be reviewed first etc.16:12
bauzassean-k-mooney: yeah, here I just want to tell it by now so people see 16:13
sean-k-mooneyi think there are only 3 specs that would need a microversion maybe 416:13
bauzaslike, for the moment, I wonder how many blueprints are asking to get a microversion16:13
bauzassean-k-mooney: that's the question I have for the moment, but I'll look back at the specs16:14
bauzasanyway16:14
bauzasthe etherpad is just starting, we'll see how we organize it16:14
* artom wonders if some sort of mechanism for grabbing the next available microversion would be worth it16:14
artomProbably not16:14
bauzasartom: we can't ask slots16:15
sean-k-mooneyi think they are https://blueprints.launchpad.net/nova/+spec/remove-tenant-id https://blueprints.launchpad.net/nova/+spec/unified-limits-nova and  https://blueprints.launchpad.net/nova/+spec/libvirt-virtiofs-attach-manila-shares16:15
bauzasartom: as we need to merge them one after the other16:15
artombauzas, I was thinking some sort of gate job that does it16:15
bauzasartom: we don't need a job16:15
artomSo the final microversion isn't known until merge, it's all placeholders16:15
artomAnways, I'm inventing complexity for nothing, carry on :)16:16
bauzasartom: you get a merge conflict for your change if another one was merged :p16:16
gibimodifying a code by a gate job... hm16:16
bauzasgibi: agreed, let's keep it simple16:16
bauzasif we only have 4 changes asking microversions, they can organize themselves to be depending on each of them if really needed 16:17
bauzasbut again, before saying this, I need to look at which ones specifically so we know them16:17
* gibi is lucky being the only one wants a new placement microversion...16:17
bauzaslol16:18
bauzasanyway, moving on ?16:18
sean-k-mooneysure16:18
bauzas#topic Review priorities 16:19
bauzas#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B116:19
bauzas#link https://review.opendev.org/c/openstack/nova/+/816861 bauzas proposing a documentation change for helping contributors to ask for reviews, needs a second +216:19
bauzasnothing to tell it for this meeting from me16:19
bauzasoh actually my change was +W and got a CI issue16:20
bauzasbecause of the centos8 job16:20
bauzasanyway, nothing to tell here16:20
bauzasI guess we should discuss about the job and the stable branches now16:20
bauzas#topic Stable Branches 16:21
bauzaselodilles: your turn16:21
elodilles#info stable gates were blocked, due to centos-8-stream job, which is now set as non-voting ( https://review.opendev.org/c/openstack/tempest/+/824740 ) so should be OK16:21
elodillesat least i think so :)16:21
elodilles#info patches waiting for a 2nd +2 (please review some if you have time): https://review.opendev.org/q/project:openstack/nova+branch:%255Estable/.*+is:open+label:Code-Review%253D%252B216:21
elodillesthese were probably interesting things for now16:22
bauzasagreed16:22
sean-k-mooneythe centos-8-stream issues should i belive be fixed now with the release of a new package16:22
elodillesi know that stable is not the top priority between Yoga-2 and Yoga-3, but if anyone have some time... :)16:22
sean-k-mooneyso they could go back to voting shortly once we confrim they are stable16:23
elodillessean-k-mooney: thanks for the info!16:23
bauzascool16:24
clarkbsean-k-mooney: I don't see commits to systemd or iputils in git.centos.org. Any idea where the fix is?16:24
sean-k-mooneyoh i tought it had been fixed and pushed to some of our mirrors. was that just pinning to an old verion16:25
sean-k-mooneyif its not fixed ill flag it internally and see if i can find more info16:25
bauzasclarkb: we're in a meeting but should be ended quickly in 5 mins hopefully16:26
bauzasnothing to say more about stable branches ?16:26
bauzasif not, let's move on and wrap this thing :)16:26
bauzas#topic Sub/related team Highlights 16:26
bauzas#info No subteam left16:26
bauzas#topic Open discussion 16:26
bauzasnothing on the agenda16:26
bauzasso, I guess we're done ?16:27
bauzasanyone whats to shout something ?16:27
bauzasor yelling about something ?16:27
bauzass/whats/wants (gosh)16:27
bauzasif not, let's pretend we're done16:28
bauzas#endmeeting16:28
opendevmeetMeeting ended Tue Jan 18 16:28:18 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:28
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2022/nova.2022-01-18-16.00.html16:28
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-01-18-16.00.txt16:28
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2022/nova.2022-01-18-16.00.log.html16:28
gibithis was faaast16:29
clarkbI didn't mean to interrupt the meeting, just wanted to point out that I don't think anything has been fixed on centos 8 stream yet. At least not if you look at the package git repos16:29
clarkbmaybe they can revert packages without going through git16:29
sean-k-mooneyclarkb: i think i miss read the mail thread16:30
sean-k-mooneyi tought ye had forced the mirror update in http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026687.html16:33
sean-k-mooneyhttps://bugzilla.redhat.com/show_bug.cgi?id=2037807 is currently on qa16:33
bauzasclarkb: oh my bad, missed the context16:33
bauzasclarkb: that's the problems with the meetings in lieu of the regular IRC chan16:34
bauzaswe get interruptions often16:34
clarkbsean-k-mooney: I think fungi had the impression that it was fixed upstream when it wasn't. As far as I can tell there has been no fix made upstream yet.16:34
bauzasso I thought your ping was unintentional16:34
clarkbbauzas: ah16:34
clarkbI could've been more specific that I was referring to the centos 8 ping issues :)16:34
sean-k-mooneyclarkb: ya its still on qa so it has not been shiped yet in rhel and presumable not yet in centos stream16:34
bauzasclarkb: but yeah, reading at what you wrote, this makes perfect sense this was on purpose :D my bad.16:35
sean-k-mooneyclarkb: the plue reuest seams to have been merged here https://github.com/redhat-plumbers/systemd-rhel8/pull/24616:35
clarkbsean-k-mooney: we want systemd-239-55 or newer or a revert on the iputils package aiui16:35
sean-k-mooneyyes http://pkgs.devel.redhat.com/cgit/rpms/systemd/commit/?id=a4b172eaddf0882435fd2eb4d146012db8e5a2f216:36
sean-k-mooneyhttps://git.centos.org/rpms/systemd/commits/c8s16:38
sean-k-mooneyits still on 239-5416:38
sean-k-mooneysorry for the confusion ill see if i can find someoen internally16:39
fungiclarkb: sean-k-mooney: the mirror update i forced was for centos stream 9, because the official mirror we'd been copying from started refusing rsync connections on friday16:51
fungiunrelated to the ping behavior16:51
opendevreviewAde Lee proposed openstack/nova master: Add check job for FIPS  https://review.opendev.org/c/openstack/nova/+/79051918:47
opendevreviewMerged openstack/nova master: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/74152920:03
opendevreviewsean mooney proposed openstack/nova stable/xena: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82506421:26
opendevreviewsean mooney proposed openstack/nova stable/victoria: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517521:32
opendevreviewsean mooney proposed openstack/nova stable/ussuri: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517621:34
opendevreviewsean mooney proposed openstack/nova stable/train: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517721:37
opendevreviewsean mooney proposed openstack/nova stable/wallaby: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517821:45
opendevreviewsean mooney proposed openstack/nova stable/victoria: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517521:48
opendevreviewsean mooney proposed openstack/nova stable/ussuri: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517621:49
opendevreviewsean mooney proposed openstack/nova stable/train: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/82517721:51
opendevreviewMerged openstack/nova master: Remove deprecated opts from VNC conf  https://review.opendev.org/c/openstack/nova/+/82447822:46
*** dasm is now known as dasm|23:02
*** dasm| is now known as dasm|off23:02

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!