Friday, 2022-01-14

opendevreviewGhanshyam proposed openstack/nova master: Server actions APIs scoped to project scope  https://review.opendev.org/c/openstack/nova/+/82435800:54
gmannseems like  tempest-integrated-compute-centos-8-stream is failing consistently https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-8-stream01:50
opendevreviewGhanshyam proposed openstack/nova master: Server actions APIs scoped to project scope  https://review.opendev.org/c/openstack/nova/+/82435802:04
melwittgmann: :(  thanks, I wondered about it02:04
*** artom__ is now known as artom02:07
gmannmelwitt: I am seeing this traceback in logs, not sure about root cause https://zuul.opendev.org/t/openstack/build/e0db6a9a7ba04e66b0781ba7d259357d/log/controller/logs/screen-q-svc.txt#3287502:08
gmannpinged neutron folks about it in case they are aware or can find the rootcause02:10
melwittack, that's not something I've seen before02:12
gmannit seems it started failing since ~1.5  hrs https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-8-stream02:14
melwittthat's consistent with what I observed. I had been following that change and rechecking it and it had been working until not too long ago02:16
*** EugenMayer3 is now known as EugenMayer04:05
*** hemna9 is now known as hemna07:38
*** songwenping_ is now known as songwenping08:09
bauzasgood morning Nova08:57
gibigood morning Nova08:57
* bauzas will start his upstream day by using his -2 stick for specs 08:57
gibiI have a full day workshop downstream so I my presence will be spotty08:57
bauzasgibi: spotty ? fine08:59
bauzasuse a headset to listen to it08:59
gibiyeah 08:59
bauzasok, my pun is terrible09:00
gibivideo is mandatoryt09:00
* bauzas hears crickets about his joke09:00
bauzashttp://www.reactiongifs.com/r/weeds.gif09:01
gibisorry I'm distracted09:02
* kashyap waves09:05
gibikashyap: o/09:05
kashyap[Off-topic] If any of you use fancy ergonomic mechanical keyboards09:06
*** Uggla|afk is now known as Uggla09:07
bauzashmmm, I forgot about this spec https://review.opendev.org/c/openstack/nova-specs/+/81951009:12
bauzassad it got a -209:12
* bauzas wonders what happens with cyborg, haven't seen anything during the last weeks09:13
opendevreviewFederico Ressi proposed openstack/nova master: Debug Nova APIs call failures  https://review.opendev.org/c/openstack/nova/+/80668311:50
*** dasm|off is now known as dasm13:32
*** tbachman_ is now known as tbachman15:09
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject AZ changes during aggregate add / remove host  https://review.opendev.org/c/openstack/nova/+/82142316:51
opendevreviewBalazs Gibizer proposed openstack/nova master: DNM: trigger nova-next with new tempest test  https://review.opendev.org/c/openstack/nova/+/82460716:58
gmannmelwitt: bauzas gibi for centos8 stream job failing, I have filed the bug https://bugs.launchpad.net/neutron/+bug/195794117:12
gmannand making job as non voting to unblock the nova and tempest gate https://review.opendev.org/c/openstack/tempest/+/82474017:12
sean-k-mooneygmann: oh i see the binding detail are failing a scope check17:30
sean-k-mooneyand other fileds17:31
sean-k-mooneywith the new deftionsing some of those shoudl be project_admin and the rest project member17:31
sean-k-mooneyi.e. host_id woudl be project_admin17:31
sean-k-mooneyas would the physical_network and segmentation_id i belive17:32
sean-k-mooneyhave neutron acidentlly started enforcing scope by default?17:33
noonedeadpunkhey! I was wondering - does keystone_authtoken/neutron sections should be defined for nova-compute?18:20
noonedeadpunkeventually does it needs interaction with keystone? I bet no as it only talk to conductor?18:20
noonedeadpunklikely only key_manager is required though18:22
sean-k-mooneynova-compute directly calls neutron18:25
noonedeadpunkaha18:25
sean-k-mooneynova-compute directly talks to most other services rest apis18:25
sean-k-mooneyit only uses the condutor to talk to the scheduler, db and conductor itslef18:25
noonedeadpunkWe in #openstack-ansible were just asked what can be done http://seclab.cs.sunysb.edu/seclab/pubs/asiaccs16.pdf and it feels what they write about RPC is a bit stupid since you have keystone admin credentials stored on each compute...18:26
sean-k-mooneyyou dont nessisarly have keystone admin creds18:27
sean-k-mooneyin fact you shoudl not have keystone admin creds18:27
noonedeadpunkwell, ok, service creds18:27
noonedeadpunkbut it would still have kind of admin privileges?18:27
sean-k-mooneyok yes18:27
sean-k-mooneyiddeally you woudl use application credentils18:27
sean-k-mooneyam yes nova need to all some other services as admin18:28
noonedeadpunkso the idea there was - how much you fucked if one compute node is hacked :)18:28
sean-k-mooneybut those service creditely shoudl only give admin on those spercices18:28
sean-k-mooneyit depend on what you put there18:29
sean-k-mooneyif you use app creds you can avoid using a password in your config18:29
noonedeadpunkI don't think it's still smth that keystone has out of the box? I mean even with all these scoped tokens you would still need to mess up with policies to get yourself covered?18:29
sean-k-mooneywhich makes revocation simpler18:29
noonedeadpunklike credential per compute... hm...18:30
noonedeadpunkthat's interesting idea18:30
sean-k-mooneyyep you can do cred per service per compute today18:30
sean-k-mooneyif you really want too18:30
sean-k-mooneyalso if you are deploying in contiaenr you dont need the nova.conf to be visable to the nova_libvirt container18:31
sean-k-mooneyso even if you break out of the vm you then have to also escap the container and selix and the file permisions to read the config file18:31
sean-k-mooneyat least with ooo that is18:31
sean-k-mooneyso for ooo the vms are runing itn the filesystem namesapce of nova_libvirt as the qemu user18:32
sean-k-mooneythat contaienr does not have the nova.conf visable to it18:32
sean-k-mooneyand selinux + file system permission woudl prevent the vm process form reading it 18:32
clarkbwouldn't that be true for any setup running libvirt as not the nova user and basic file permissions?18:32
clarkbya that18:33
clarkbhowever libvirt is privileged18:33
noonedeadpunkyeah, I guess in ubuntu apparmour does kind of same anyway18:33
clarkbso might be defeatable?18:33
sean-k-mooneyyep even in a normal rpm/deb install selinux/apparmor + file system permisions can help18:33
melwittthanks gmann++18:33
sean-k-mooneyclarkb: libvirt is but qemu does not run with the same user or group as libvirt18:33
clarkbaha got it18:34
noonedeadpunkbut yeah, I got the idea:) At least I thought that we do smth stupid by placing access to keystone in nova-compute.conf but no, it's required)18:34
opendevreviewMerged openstack/nova master: Add regression test for bug #1937084  https://review.opendev.org/c/openstack/nova/+/81212618:34
sean-k-mooneyso in general qemu shoudl not be part of the nova group so should not be able to read nova config files18:34
sean-k-mooneynova is often part of the qemu/libvirt group but that direction makes sense18:35
sean-k-mooneysince nova need to be able to talk to libvirt at least and create files that qemu can read18:36
melwittlyarwood: in case you didn't see, I addressed your comments on https://review.opendev.org/c/openstack/python-openstackclient/+/81830618:37
sean-k-mooneynoonedeadpunk: so ya i have not read that paper but im not sure how valid it is and if they have correctly deployed thigns18:38
sean-k-mooneynoonedeadpunk: with devstack for example most thigns are owned by the stack user so the filesystem doesnt do much for you but opensack ansible, kolla or ooo should provide much more protection18:39
noonedeadpunkwasnt it reading in details, but yeah, it weird, as they read nova.conf, get rabbitmq creds, then were snifffing tokens (why when they could jsut take that from keystone_authotoken?)18:40
noonedeadpunkbut yeah, I got idea, thanks sean-k-mooney a lot!18:40
noonedeadpunkas always, I got bunch of good ideas how to improve things)18:41
*** tbachman_ is now known as tbachman18:43
sean-k-mooneynoonedeadpunk: looking at https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_pre_install.yml#L85-L121 by the way it looks like osa is already creating /etc/nova in the nova user and group18:43
noonedeadpunkyep, sure we do that!18:43
sean-k-mooneyyou likely dont want to use 755 for the mode 18:43
sean-k-mooneyhttps://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_pre_install.yml#L9218:43
sean-k-mooneysince that is world readable18:44
noonedeadpunkgood point18:44
sean-k-mooneysay 75018:44
sean-k-mooneyor 650 for files18:44
noonedeadpunkwe should totally review that asap...18:45
noonedeadpunknova.conf is stored 0640 though18:45
sean-k-mooneyack then its likely fin already18:45
sean-k-mooneynova is part fo the libvirt group https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/drivers/kvm/nova_compute_kvm.yml#L56-L6318:45
noonedeadpunkhttps://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_post_install.yml#L58-L8118:45
sean-k-mooneywhich is corrct18:45
sean-k-mooneyand i dont see qemu or libvirt beign added to nova18:46
sean-k-mooneyso for osa they should not be able to read the nova.conf18:46
noonedeadpunkyep, thanks a lot for checking that! We still should review directory permissions18:47
sean-k-mooneyno worries, security is important18:54
sean-k-mooneyeventually i hope ooo or some of the installer will start using https://docs.openstack.org/keystone/queens/user/application_credentials.html18:54
sean-k-mooneyin the config 18:54
noonedeadpunkI wish there was an ansible module ready for that... Shouldn't be that hard to write one though18:58
noonedeadpunkbut we have huge backlog of missed features anyway now :( we still haven't managed to implement service_tokens https://docs.openstack.org/keystone/latest/admin/manage-services.html#configuring-service-tokens19:01
noonedeadpunkbut the biggest issue I see with application credentials - is how to template config. So they should be stored somewhere after being created and managed...19:04
noonedeadpunkand kind of rotating of regular credentials is not _that_ hard - a matter of re-running playbook with specific tags....19:15
noonedeadpunkI think the most challendging thing is to get aware that they got compromised19:15
opendevreviewAde Lee proposed openstack/nova master: Add check job for FIPS  https://review.opendev.org/c/openstack/nova/+/79051919:37
*** tbachman_ is now known as tbachman19:50
*** tbachman_ is now known as tbachman20:32
opendevreviewMerged openstack/nova master: Make API fixture pass roles  https://review.opendev.org/c/openstack/nova/+/81990721:02
*** tbachman_ is now known as tbachman21:22
*** dasm is now known as dasm|off21:46
*** tbachman_ is now known as tbachman22:24
opendevreviewMerged openstack/nova master: Update Interop doc  https://review.opendev.org/c/openstack/nova/+/81698022:27
opendevreviewMerged openstack/nova master: api-ref: Adjust BFV rescue non-support note.  https://review.opendev.org/c/openstack/nova/+/81882322:28

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!