Tuesday, 2021-11-23

mnasersean-k-mooney: https://bugs.launchpad.net/nova/+bug/1917645?comments=all there's literally no way to workaround this issue, if that rabbitmq is down, the whole clouds melts down, even with retry=004:02
opendevreviewNicolas Parquet proposed openstack/nova master: Add v2.91 microversion, allowing @ and dot (.) characters in keypair name  https://review.opendev.org/c/openstack/nova/+/78107608:49
opendevreviewNicolas Parquet proposed openstack/nova master: Add v2.91 microversion, allowing @ and dot (.) characters in keypair name  https://review.opendev.org/c/openstack/nova/+/78107609:04
gibimnaser: hi, about notification blocking the main thread, there is a bug from belmiro https://bugs.launchpad.net/nova/+bug/191764509:14
gibiI intended to look into at some point, but never had the time09:15
gibinow I feel again I should look09:17
gibistephenfin: I have a bad feeling about https://review.opendev.org/c/openstack/nova/+/817746/comment/6690000b_3989ece7/ but if there is no better way then I will +A it 09:46
bauzasgibi: looking at https://docs.openstack.org/nova/latest/contributor/ptl-guide.html#milestone-109:46
bauzasgibi: wondering if all this fish is still needed ?09:46
gibibauzas: launchpad bookkeeping is really just bookkeeping. If you don't do it then nothing will fail09:47
bauzasgibi: you did this for Xena ?09:48
gibibauzas: the lib releases are probably proposed by the release team automatically09:48
bauzasif so, I'll do it09:48
bauzasgibi: yeah I'm looking at the releases gerrit09:48
bauzasgibi: I wasn't asked to look at some changes09:48
gibibauzas: it seems that I only released xena-3 in launchpad not 1, 2 or rc109:49
* gibi is a lazy bastard09:49
bauzashah, OK09:49
bauzasI'll look at that09:49
gibibauzas: I think the release team only proposes a release if there was real content on the branch since the last release09:50
bauzasyeah, I only see https://review.opendev.org/c/openstack/releases/+/81841509:51
bauzaselodilles: ^ correct ?09:51
gibibauzas: we have os-vif release proposed https://review.opendev.org/c/openstack/releases/+/81841509:51
bauzasjinxed :p09:51
gibibut not python-novaclient09:51
bauzasyup09:52
gibios-vif had some meaningfull change since 2.609:52
bauzasyes09:52
gibinovaclient does not09:52
bauzascorrect09:52
gibiand I thin placement's os-traits and os-resource-classes are marked as independent libs so there we don't need a release09:53
gibiper milestone09:53
bauzasthis is correct09:53
bauzashttps://releases.openstack.org/independent.html#os-traits09:54
bauzashttps://releases.openstack.org/independent.html#os-resource-classes09:54
bauzasthey are independant09:54
gibiwhat I did at m1 is to move the bps targeted to m1 to m209:56
gibibut as far as see you opted not to target bps to milestones at all, so that retargeting is not needed 09:58
gibithe list https://blueprints.launchpad.net/nova/yoga seem OK09:58
elodillesbauzas: gibi is right :) at milestone-1 only such projects had a generated release patch that had some real content in their master branch since the last release10:02
*** blmt is now known as Guest659710:08
bauzaselodilles: thanks for explaining :)10:17
elodilles:)10:33
opendevreviewMerged openstack/nova master: db: Replace use of Executable.scalar(), Executable.execute()  https://review.opendev.org/c/openstack/nova/+/80487811:10
bauzaslyarwood: haven't seen that https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/ephemeral-encryption-libvirt.html shares the same BP than https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/ephemeral-encryption.html11:17
bauzaslyarwood: could you please create another BP for the libvirt one so I could mark it for yoga ?11:17
bauzaslyarwood: also, could you please modify the spec to use the new BP ?11:18
opendevreviewMerged openstack/nova master: db: Replace use of 'autoload' parameter  https://review.opendev.org/c/openstack/nova/+/80573411:26
opendevreviewMerged openstack/nova master: db: Replace use of legacy select() calling style  https://review.opendev.org/c/openstack/nova/+/80573511:26
lyarwoodbauzas: do we need a bp per spec? It appears to graph them out correctly in the bp at least11:34
opendevreviewMerged openstack/nova master: db: Replace 'insert.inline' parameter with 'Insert.inline()' method  https://review.opendev.org/c/openstack/nova/+/80573611:35
opendevreviewMerged openstack/nova master: db: Don't pass strings to 'Connection.execute'  https://review.opendev.org/c/openstack/nova/+/80573711:35
jhartkopfHi there, I'd like to add another topic to the open discussion section of today's Nova meeting, but it seems to be quite full already. Would you recommend to add the topic to next week's meeting instead? And how can I add a topic to the list? Should I just edit the Wiki page?13:09
sean-k-mooneyyou can just add it to the adgenda13:14
sean-k-mooneyjust edit the wiki13:14
sean-k-mooneywhat is the topic13:14
sean-k-mooneylyarwood: normally yes we have a blueprint per spec, you can model the depencies between the blueprints13:15
sean-k-mooneylyarwood: i think that works across projects too but not tried that in a while so not 100% sure13:16
sean-k-mooneylyarwood: im pretty sure i have linke a nova blueprint to a neutron one at some point13:16
jhartkopfsean-k-mooney: Alright, thanks. The topic is the spec for updating user data. We've already discussed it on OpenDev but I'd like to bring up some specific use cases once again.13:22
sean-k-mooneyack13:23
opendevreviewLee Yarwood proposed openstack/nova-specs master: fup: Correct the libvirt ephemeral encryption blueprint link  https://review.opendev.org/c/openstack/nova-specs/+/81891713:28
lyarwoodsean-k-mooney: right thanks I thought the single bp showed the spec relationship but it looks like you created another bp previously 13:29
lyarwoodupdated the spec to point to that second bp, iirc gibi was cool with one bp previously but I really don't mind either way13:29
sean-k-mooneyya im fine with both where it was useful in the past was vhost-user13:30
sean-k-mooneywe had one blueprint for generic vhost-user support and a second for vhost-user with ovs-dpdk13:30
sean-k-mooneywe happend to enable both in the same release but if the ovs-dpdk supprot had slipped we could have closed the generic one and move the ovs one13:30
sean-k-mooneywe rarely have 2 feature that share a common part like that13:31
sean-k-mooneyat least rarely in the same cycle13:31
sean-k-mooneylyarwood: actully one minor reason to have 2 bluepritns is the script we use to mark specs as implemented and move them uses the script file name to determin which blueprint to query13:34
sean-k-mooneylyarwood: i thinkthat is why i originally created the second libvirt one13:34
EugenMayeris it a known issue that ubuntu (20.04) does not accept the DNS server pushed by DHCP openstack (OVN)? Debian generic cloud image does work though13:37
sean-k-mooneyEugenMayer: thats odd i would have expected that to work13:38
sean-k-mooneyyou set the nameservers on the subnet as normal13:39
EugenMayerSame does me. Spinnging up a debian box right now, expecting it to work (since all the debian boxes worked)13:39
sean-k-mooneyand it just does not pic those up via dhcp?13:39
EugenMayeryes i do13:39
EugenMayerit ignores it on ubuntu, exactly13:39
sean-k-mooneyya that sound like a dhcpclint bug in ubuntu 20.0413:39
sean-k-mooneyi assume they are both useing the came dhcp clinet implemenation by default13:40
EugenMayeryes debian works. Same network same everything (using terraform here, so just replaced the image)13:40
sean-k-mooneyperhap its fixed in a later cloud image? im not sure if you are using the latest point release image of 20.04 but might be worth trying the nightly image13:41
EugenMayerusing the latest one13:41
EugenMayernot older then 5 days13:41
EugenMayerdid you find a bug reeport?13:41
sean-k-mooneyno have not look13:41
EugenMayeri look it up and try > 20.xx13:42
sean-k-mooneyit used to work i think but that the only thing i can think of is a bug in the dhcpclient or the cloud-init default behavior in ubuntu13:42
EugenMayermaybe it is netplan related13:42
EugenMayeri use what is referenced at Same does me. Spinnging up a debian box right now, expecting it to work about 13:43
EugenMayersorry13:43
EugenMayerhere https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/configure-openstack.html#set-up-public-networking13:43
EugenMayerinteresting, resolvectl status shows up the right dns serevers... but the resolution of my internal domains does not work13:49
EugenMayeri have to use 'dig @IP domain'13:49
bauzaslyarwood: oh, sorry, I haven't seen https://blueprints.launchpad.net/nova/+spec/ephemeral-encryption-libvirt13:56
bauzaslyarwood: then we need to update the spec to tell that the BP is ^13:56
bauzaslyarwood: I mean, in https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/ephemeral-encryption-libvirt.html13:56
lyarwoodbauzas: yeah there's a fup above for that now13:57
lyarwoodhttps://review.opendev.org/c/openstack/nova-specs/+/818917 sorry13:59
EugenMayersean-k-mooney ok i found it. Damn i confused the isolated test. I had a typo in my CNAME thus the isolated test with a blank 20.04 box failed and i assumed a general issues. Now vanilla focal works. just focal + rke2 has the wrong DNS servers, which might be an RKE2 setup thing. Sorry for wasting time, got dragged away, missed that typo14:03
sean-k-mooneyEugenMayer: no worries14:04
opendevreviewMerged openstack/nova-specs master: fup: Correct the libvirt ephemeral encryption blueprint link  https://review.opendev.org/c/openstack/nova-specs/+/81891714:19
bauzaseeeeek https://github.com/libvirt/libvirt/commit/3bd8181bc5548a0ce81107cbfb480dfdcba5679d14:33
bauzassean-k-mooney ^14:33
mnasergibi: yeah i saw your comments and found that issue, it seems like even with retry=0, it still is kinda failing 14:34
mnasersince it gets stuck in a reconnecting loop14:34
bauzassean-k-mooney: context is https://bugs.launchpad.net/nova/+bug/195165614:34
gibimnaser: yepp the retry config is only used to message sending but not connection setup14:34
mnaserthat's where i ended up and it felt pretty non-trivial at that point to go from there :(14:35
mnaserat least, it's beyond my scope of comfortable knowledge anyways14:35
gibimnaser: it seems the current oslo.messaging driver interface does not have way to express that the consumer wants configurable retry for conenction setup14:35
sean-k-mooneybauzas: we proably shoudl jsut not use libvirt for mdevs at all honestly but fun14:36
gibimnaser: I'm still digging oslo.messaging to understand more how to fit this in14:36
bauzassean-k-mooney: well, I'd prefer the other way, ie. asking libvirt to create mdevs14:36
mnasergibi: something i found interesting was - https://docs.celeryproject.org/projects/kombu/en/stable/_modules/kombu/connection.html#Connection.ensure_connection14:36
bauzassean-k-mooney: but they won't do it14:36
mnaserit looks like kombu has it's own error handling inside ensure_connection that maybe didn't exist back when openstack started using it14:36
sean-k-mooneybauzas: well the reason i say that is libvirt does not define that as a stable interface14:37
sean-k-mooneyand createing/remvoing mdevs via the filesystem is pretty trivial14:37
gibimnaser: yeah komubo has the flags in the interface14:37
gibikombu14:37
bauzasanyway, when I'm seeing it, I wonder whether libvirt folks know there are some upper services that use them14:37
gibimnaser: so we could configure kombu to stop after x retries14:37
gibimnaser: we just don't have the scaffolding in oslo.messaging to use that14:38
mnasergibi: yeah but i think then that brings the other interesting issue of 'does that mean it gives up forever for all future notifications'14:38
sean-k-mooneybauzas: they are partly aware i had a converstaion with them about this in relateino to vdpa14:38
sean-k-mooneyand mac adresses14:38
sean-k-mooneythey do not guarenttee the names are stabel and said we shoudl avoid realying on them14:38
bauzasmeh14:40
bauzasOK14:40
sean-k-mooneybauzas: to me this is incorrect behavior in mdevctl and the libvirt chagne should be reverted14:40
bauzasgibi: heh https://bugs.launchpad.net/nova/+bug/195162314:40
bauzasgibi: I guess this will be fixed by your change, right ?14:40
bauzasoh, nevermind, it was for reboot14:41
mnaseri do see a point in 'if notifications are down, stop doing things that can be billed'14:43
gibibauzas: unfortunatly that is a different problem14:45
sean-k-mooneymnaser: that is anyting other then delete including allowing the instance to continue running :)14:45
bauzasgibi: looks like, yes14:45
mnasersean-k-mooney: but that means more $$$ am i rite? =ap14:45
gibimnaser: yepp, I agree, but I think this behavior needs to be configurable14:46
gibimnaser: to handle the case when notification only just good to have 14:46
gibibut not must have14:46
opendevreviewArtom Lifshitz proposed openstack/nova master: DNM: Explode libvirt builds to trigger tempest error code  https://review.opendev.org/c/openstack/nova/+/81893214:47
sean-k-mooneymnaser: :) i think the correct behavior if notification cant be sent is either to just log an error and drop them or continue to have the service work but set its healtch check to degraded14:47
sean-k-mooneythe only other option i see would be for the service to terminate14:47
opendevreviewArtom Lifshitz proposed openstack/nova master: DNM: Explode libvirt builds to trigger tempest error code  https://review.opendev.org/c/openstack/nova/+/81893214:48
sean-k-mooneymnaser: if we are going to stop some operation from workign i dont think we shoudl be reportign the srvice as up in our current status filed14:48
sean-k-mooneybut that is based on a heatbeat which might still be working14:48
sean-k-mooneyso that not really something we can change14:48
mnasersean-k-mooney: historically i rather a failure and consistent behaviour than a degraded 'pass' that leaves a bit of a mess14:49
mnaser(see: ignore cinder volume deletes)14:49
sean-k-mooneywell notifocation are generally considerd besteffort14:49
sean-k-mooneyits not a mission cirtical part of the cloud14:50
sean-k-mooneyso we could make the service exit as an opt in behavior but in generally i think logging an error and reportign a degrated health status then allowing something external to decied what to do i think is better14:50
mnaseri guess notifications being critical will dpeend on who you ask ;p14:51
sean-k-mooneyform a nova point of view i dont think they ever have had any guarentees14:51
sean-k-mooneyi know people do consume them for billing and other uses but the in ablity to send a notificaotn shoudl not have any impact on a user operation by default14:52
sean-k-mooneymnaser: as a customer if i tried to reboot a vm and it failed because fo a notrifcaiton issue i wold expect a 500 or other error code to be logged showing its an infra issue so i can file a ticket with my cloud provider for downtime14:53
mnasersean-k-mooney: that's true, but i guess since we don't have any buffering right now, it means notifications can be lost .. and in theory, they'll get a 500 anyways now if the notifications are down =P14:54
sean-k-mooneymnaser:basicly in cloud where notificaiotn are treated as critical it would be a cloud outage from a customer point of ivew14:54
sean-k-mooneymnaser: hehe i guess they will get the 500 now ture14:55
sean-k-mooneyalthough only if you dont set a retry limit right14:55
mnasernope, even if you set retry=0 it fails :(14:55
mnasersee what gibi mentioned above, it gets stuck on trying to connect and that has no retries14:55
sean-k-mooneyoh ok then that is a bug14:55
mnaserit loops forever on trying to connect14:55
sean-k-mooneyah right14:56
sean-k-mooneybecause its the amqp connection that is down its not an issue with sendign to a queue or exchange14:56
mnaseri captured GMR and updated info here - https://bugs.launchpad.net/nova/+bug/191764514:56
sean-k-mooneymnaser: well that proably  should be converted to an oslo messaging bug at this point14:57
mnasersean-k-mooney: good point actually14:57
sean-k-mooneynova might be able to work around this but eventually we will want to adress this there i suspect 14:57
opendevreviewDmitrii Shcherbakov proposed openstack/os-traits master: Add a trait for remote_managed port-capable nodes  https://review.opendev.org/c/openstack/os-traits/+/81851415:01
gibisean-k-mooney: sure oslo.messaging lacks a configuration possibility to stop retrying the connect, but I don't think it is purelya bug15:03
sean-k-mooneypro tip dont put a folder with 2412 sub directories in your test path if you want test discovery to happen before the heat death of the universe15:03
gibisean-k-mooney: on nova side it is sure a bug if the instances stuck in some tranisitional state due to hanging15:04
sean-k-mooneygibi: yes but i dont think im sold that we should  intoduction config driven api behavior15:04
gibisean-k-mooney: not in nova no15:04
gibisean-k-mooney: we need oslo.messaging configurability15:05
sean-k-mooneyright so we cant block opertaion because we failed to send a notification15:05
sean-k-mooneygibi: well not i think not at all nova need to proceed even if the notificaiton cant be sent15:05
sean-k-mooneywe can log an error ro report it via a healthcheck or similar15:05
gibisean-k-mooney: I don't agree. If notifications are used for billing then I can imagine that the operator want the instance boot to fail if the notification bus is down15:06
sean-k-mooneygibi: its a grey area i guess15:06
gibisure, don't stuck, but fail cleanly15:06
sean-k-mooneyto me unless we can report a 500 to the user im not sure we should block the operation15:06
bauzasgibi: sean-k-mooney: thoughts abotu https://bugs.launchpad.net/nova/+bug/1951623 be a nova or neutron issue ?15:07
* sean-k-mooney clicks15:07
sean-k-mooney..... both15:08
bauzasnova wouldn't know whether the port is disabled15:08
gibibauzas: nova, as nova waits unconditionally15:08
sean-k-mooneynova can check that15:08
bauzasyeah15:08
gibibauzas: nova can query the port sate15:08
gibistate15:08
sean-k-mooneynova because this is not checked today15:08
sean-k-mooneyand neutron because this change depending on the backend15:08
bauzasgibi: mmm, that means that we would call neutron to get the port state15:08
sean-k-mooneybauzas: i think we have that in the network info cache but yes we have a check for this in some of the code already15:09
bauzassean-k-mooney: ok, then it's a nova bug if we already call it15:09
sean-k-mooneywe just dont in that part of the code15:09
sean-k-mooneybut part of me is wondering if we would be better off just not using those event until we actully define a contract with neutorn on when they will be sent15:10
gibisean-k-mooney: but thing might never happen based on past experience ^^ :)15:10
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7221-L722815:11
bauzasgibi: sean-k-mooney: I just triaged the bug https://bugs.launchpad.net/nova/+bug/195162315:11
sean-k-mooneyso we check if its active here but we dont for the migration events15:11
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/network/model.py#L488-L508 or here https://github.com/openstack/nova/blob/master/nova/network/model.py#L567-L58615:12
sean-k-mooneybauzas: gibi  so we just need to update the model fucntion to skip disbaled ports15:12
bauzasack15:13
bauzasbug confirmed anyway15:13
sean-k-mooneythe issue is that in some cases we will get event if the port is disabled15:13
sean-k-mooneywhich we will now be ignorign but thats is likely ok15:13
gibiyeah15:13
bauzaselodilles: I hadn't time to update the meeting agenda, but add your points if you want15:20
bauzasreminder : nova meeting in 40 mins here in #openstack-nova15:20
elodillesbauzas: adding it now then15:23
DK4when creating instances they are all stuck in creating state. ive combed thrtough logs and did not find anything special. any advice on debugging that? 15:23
elodillesbauzas: done, just added a short info update, quickly15:25
elodillesbauzas: you can edit now the page if you want15:26
sean-k-mooneybauzas: by the way unless youhave actully repoduced the bug or root caused it you should be setting it to triaged not confirmed15:31
sean-k-mooneywe treat them more or less the same so i guess it does not matter but confrimed imples we coudl repoduces it triage does not15:32
opendevreviewDan Smith proposed openstack/nova master: Revert project-specific APIs for servers  https://review.opendev.org/c/openstack/nova/+/81620615:37
bauzaslast reminder: nova meeting starts in 10 mins here at #openstack-nova IRC chan15:51
bauzassean-k-mooney: yes and no, we could put in Triaged if we don't know the direction15:51
bauzassean-k-mooney: we don't ask bug triagers to test all the issues15:51
bauzas(even if Launchpad says it)15:52
bauzasat least that's the census we have15:52
sean-k-mooneyyes i know which is why i am saying confirmed is a larger statement15:52
sean-k-mooneytriaged just means we think its valid and have some understading of why it happens, confrimed implies you ahve actully tried to repoduce it an have confirmed the behavior is as reported in the bug15:53
sean-k-mooneyor at least that is how i treat it15:53
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Nov 23 16:00:15 2021 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
gibio/16:00
elodilleso/16:00
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:00
bauzasgood day, 'vyone16:00
lyarwood\o16:00
bauzasok, let's start16:01
* kashyap waves16:01
bauzasa few folks could be off b/c of some holiday they have on Thursday :)16:02
bauzasnot French , tho16:02
bauzas#topic Bugs (stuck/critical) 16:02
bauzas#info No Critical bug16:02
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 29 new untriaged bugs (+1 since the last meeting)16:02
bauzasI did a bit of triage and will continue on it tomorrow16:02
bauzasthanks for the people who did this too16:03
bauzas#help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage16:03
bauzas#link https://storyboard.openstack.org/#!/project/openstack/placement 33 open stories (+0 since the last meeting) in Storyboard for Placement 16:03
bauzasany bug to discuss by now ?16:03
bauzas#topic Gate status 16:04
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:04
bauzasno new gate bug AFAICS16:04
bauzasbtw. we could triage three of them that are NEW :)16:05
bauzas(even 4)16:05
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status 16:05
bauzaswe have an issue16:05
bauzas#info tempest-integrated-placement job had a CI issue16:05
bauzas#link https://zuul.openstack.org/build/43f380b91bd14579806d0b9be0d702c8 the job itself16:06
bauzaslooks like an unrelated package issue16:06
gibiit is a known issue https://zuul.openstack.org/build/43f380b91bd14579806d0b9be0d702c8/log/job-output.txt#420616:06
gibithe pmlogger service did not start16:07
kashyapWhat does the service even do?16:07
gibiwe see it time to time in nova jobs too16:07
gibikashyap: never digged into it16:07
kashyapIs it this? - https://man7.org/linux/man-pages/man1/pmlogger.1.html16:07
kashyapAnyway, don't want to distract from the main point :)16:07
bauzas#agreed this is a known issue related to pmlogger, should be automatically fixed next run16:08
bauzasagreed on the agreed ? ^16:08
gibipmlogger.service - Performance Metrics Archive Logge16:08
gibiso yes16:08
gibibauzas: sure16:08
bauzasok, if this is done, let's move on16:08
bauzas#info Please look at the gate failures, file a bug, and add an  elastic-recheck signature in the opendev/elastic-recheck repo (example: https://review.opendev.org/#/c/759967)16:08
bauzasany other gate issue to mention ?16:09
bauzaslooks not16:10
bauzas#topic Release Planning 16:10
bauzasYoga-1 was Nova 18th#link https://releases.openstack.org/yoga/schedule.html#y-116:10
bauzasdang16:10
bauzaslink https://releases.openstack.org/yoga/schedule.html#y-116:10
bauzasYoga-1 was Nova 18th16:10
bauzas#info Spec review day helped to merge 3 specs16:10
bauzasthanks people who reviewed them16:11
bauzas#info at Yoga-1 timeframe, Nova already accepted 7 specs and 4 specless BPs16:12
bauzas(sorry, was counting)16:12
bauzasanything to mention about the pace we have ?16:13
bauzas#info reminder that we plan another spec review day mid-Dec, exact date to be discussed in a next meeting16:13
bauzasmoving on ?16:14
bauzasI guess so16:14
bauzas#topic Review priorities 16:14
bauzas#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement)+label:Review-Priority%252B116:14
bauzas#link https://review.opendev.org/c/openstack/nova/+/816861 bauzas proposing a documentation change for helping contributors to ask for reviews16:15
bauzasthat reminds me I need to update this change16:15
bauzas#action bauzas to update his change to reflect the consensus about non-ownership ask for this label16:15
bauzasbut then, I'll ask next week what and how people feel about how to asynchronously ask reviewers (cores and non-cores) to look at changes16:16
bauzasor the other way, how reviewers can discover changes16:16
bauzaswe have room for contributors happy to review that we can help them how to do this16:17
gibibauzas: btw, can we remove review priority from https://review.opendev.org/c/openstack/nova/+/810220 it is in -1 since 5th of Nov16:18
bauzasgibi: fair enough, you provided good comments on it, and I didn't added my ones since I agree with you16:19
gibiand I have the same feeling about https://review.opendev.org/c/openstack/nova/+/810849 too16:19
bauzaseven if I'd like this bugfix to be merged somehow16:19
gibiand this too https://review.opendev.org/c/openstack/nova/+/80371316:19
bauzas#info we removed the Review-Priority flag from a few changes as they were lacking updates16:21
bauzasI added a comment to each of the changes explaining to ping me again once they revise the change16:21
bauzasgibi: thanks for the cleanup 16:22
bauzasI should somehow think about how to periodically check this16:22
bauzasthat's it for the RP labelling and usage ?16:22
bauzasI guess so16:24
bauzas#topic Stable Branches 16:24
bauzaselodilles: the mic is yours16:24
elodilles#info stable gates are not blocked16:24
bauzaswoow16:24
elodilles#info Ussuri transitioned to Extended Maintenance for nova projects \o/16:25
elodillesand that's it i think16:25
elodillesi have no updates for the intermittent failures on stable gates :(16:25
bauzaselodilles: don't wanna release any stable branch as we're around yoga-1 ?16:25
elodillesgood question16:26
bauzaswe could do a xena .z release16:26
elodillesi haven't checked how much new content we have on stable branches16:26
bauzasnot sure if people want it tho16:26
bauzasI'm pretty sure gibi would like a release, nope?16:26
bauzasgiven of the backports16:26
bauzasor do people want to stack a bit more until we release ?16:27
elodillesi can prepare some if there is need :)16:27
gibibauzas: no hard push on a release16:29
bauzasI have no personal interest beyond curiosity16:29
bauzasok, we can wait them16:29
bauzasthen*16:29
gibibauzas: the waiting for plug fix needed on victora / pike for my downstream counterpart16:29
elodilles(i don't see much merged content)16:29
opendevreviewDan Smith proposed openstack/nova master: Revert project-specific APIs for servers  https://review.opendev.org/c/openstack/nova/+/81620616:29
bauzasgibi: well, for us, wallaby and train, but whatever16:30
gibiyeah probably train too 16:30
bauzasI guess we're done with this topic, we can rediscuss about the opportunity to release a bit later in the cycle16:30
elodillesyes, let's discuss later16:31
bauzas++16:32
bauzas#topic Sub/related team Highlights 16:32
bauzasLibvirt (lyarwood)16:32
lyarwoodWe are tracking a QEMU 6.1.0 regression downstream with [libvirt]num_pcie_ports >= 15 when using the q35 machine type, we aren't hitting it yet upstream in Nova itself as we only use q35 in nova-next but TripleO is seeing it with centos 8 and 9 stream after a QEMU rebase. The workaround is to lower the port count to <=14. Just a heads up for now, I've got a TODO to create a known issue release note in Nova for the time being while we16:32
lyarwoodwait on a fix in QEMU.16:32
bauzasouch.16:32
lyarwoodand that's all I have this week16:33
sean-k-mooneyack so noting to do in nova other then the known issue16:33
bauzasack, I also saw some bad libvirt modification that creates problems for our vgpu support16:33
sean-k-mooneyand perhaps change job config if needd16:33
lyarwoodsean-k-mooney: ack pretty much16:33
bauzashttps://bugs.launchpad.net/nova/+bug/195165616:33
bauzasthe fix is easy but that makes me worried about the fact that the namings we have are not a public API 16:34
sean-k-mooneyits not the first time we have been broken by such name changes16:35
bauzascan't imagine what would happen if the drivers can also change their mdev type names16:35
bauzaswe're a bit fragile16:36
bauzasanyway16:36
bauzaslet's not overdiscuss this16:36
bauzaswe have a few specless bps requests again this week16:36
bauzas#info QEMU 6.1.0 regression downstream with [libvirt]num_pcie_ports >= 15 requires for the moment to work around by lowering the port count to <=14. lyarwood will provide a relnote for it until the QEMU regression is fixed16:38
bauzasmoving on16:38
bauzas #topic Open discussion 16:38
bauzas#topic Open discussion 16:38
bauzas(dasp) Blueprint for review: "Make no_compression_image_types configurable" -- https://blueprints.launchpad.net/nova/+spec/configurable-no-compression-image-types16:38
bauzasdasp: around ?16:38
bauzas Rationale: hardcoded behavior slows down cold migrations with local RAW disk images to 8 mbps and maxes CPU.  It might be a good idea to change the default value as well or disable compression for all types.16:38
dansmiththis is compression of just the stream?16:39
* bauzas reads the blueprint description16:41
dansmithI assume the original thought is that raw disks *might* be mostly zeroes which compress to nothing during transfer,16:41
dansmithbut that probably falls apart over time and makes it compression for no reason16:41
bauzasthat's my general assumption16:41
sean-k-mooneyfor ssh 16:42
dansmithideally libvirt would just do hole detection and not transfer the holes, I think, but...16:42
sean-k-mooneyit just adds -C16:42
sean-k-mooneyfor rsync it enable rsync compression16:42
dansmithsean-k-mooney: ah, right16:42
dansmithwell, I see no reason to prevent people from choosing this, so seems okay to me16:42
bauzasoh the ssh transfer itself ?16:42
sean-k-mooneyyes16:42
bauzasI guess the proposal is to make it configurable ?16:42
dansmithyeah16:43
bauzasbut that would be for all images of the same type16:43
daspI'm here16:43
dansmithdefault to the same behavior it looks like, so no change unless you want change16:43
bauzas(I guess)16:43
sean-k-mooneyits this https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/libvirt/volume/remotefs.py#L192-L19316:43
bauzasdansmith: if this is opt-in for uncompress, that's OK16:43
dansmithbauzas: right16:43
bauzasdansmith: if that's changing the default to *not* compress raw images, I'm -116:44
sean-k-mooneyso the current patch if they have not reviesed it maintianed the exsting behavior16:44
dansmithbauzas: no, it's keeping the same default, just allowing people to control it16:44
sean-k-mooneyand i was suggesting we would not change the default without more dicussion16:44
bauzasthen it looks to me a simple configurable ask, which doesn't require a spec provided they don't break existing behaviour16:44
sean-k-mooneyalthough both rsync and ssh recommend it only for slow connections16:44
daspyes, changing default is not in scope right now as it comes from me. However, based on my tests, the default behavior is very bad unless I'm doing something unusually wrong.16:45
daspSo I'm likely going to propose another future spec to change the default separately.16:45
sean-k-mooneydasp: right so for now i think we shoudl add the option and consider changing the default after we get some operator input16:45
bauzaswhat sean-k-mooney said16:45
dansmithI dunno if discard will cause qemu to zero sections of a raw disk, but if not, over time your raw disk of zeroes becomes not that, so compression becomes useless after a point16:45
bauzasexpose the new knob16:45
bauzaslet operators play with it16:46
bauzasand give us figures about why this is helpful to change the default16:46
bauzasanyone having concerns about https://blueprints.launchpad.net/nova/+spec/configurable-no-compression-image-types NOT being a specless BP ?16:47
bauzasno API modifications, no upgrade concerns, no DB modifications, just a configurable add16:48
sean-k-mooneythis is ok to me so no objections16:48
dansmithyup16:48
bauzaslooks like nobody is freaking out16:49
bauzas#agreed https://blueprints.launchpad.net/nova/+spec/configurable-no-compression-image-types is approved as a specless BP, provided no change in default behaviour 16:49
bauzasnext one16:49
bauzas(jhartkopf) Update user data spec (https://review.opendev.org/c/openstack/nova-specs/+/816542)16:49
bauzasjhartkopf: around ?16:49
bauzasare you just asking for spec review ?16:49
jhartkopfaround16:50
bauzasoh, I remember this one16:50
bauzasthat's an interesting case16:50
sean-k-mooneyi think jhartkopf  wanted to expand on there usecase16:50
bauzasright16:51
jhartkopfWe have already discussed this spec extensively, but I’d like to focus on a specific use case now.16:51
jhartkopfWe think the change would make sense when using Cloudbase-init plugins, which can run at every boot and configures guest settings based on user data16:51
jhartkopfWe already brought that up, but still think this would be a valid use case16:51
sean-k-mooneycloud-init support that too by the way its just not how its typically used16:52
bauzasjhartkopf: IIRC, your usecase was for ssh key management, right?16:52
sean-k-mooneyi thikn that was someone else usecase16:52
jhartkopfbauzas: no, that was the other person who wanted the same feature some years ago16:52
bauzashah, apologies then16:53
sean-k-mooneyfor ssh key manament i do think there is vaule in support multiple keys and updating them16:53
bauzasjhartkopf: my concern is, which specific cases are useful that require the userdata to be mutable ?16:53
bauzasbesides the fact that other big Fives do this 16:53
sean-k-mooneyspeificly is there a usecase you are trying to enable that is a usecase for the end user/tenant not the operator16:54
jhartkopfsean-k-mooney: Cloud-init supports this as well, yes. But why would you want to restrict API functionality and potentially restrict other's workflows?16:54
bauzassean-k-mooney: indeed, cases about end user 16:55
sean-k-mooneythe user-data is "owned" by the enduser so if the reason to make it mutable is so operators can chagne it it would not be consitnet with the usage of that api16:55
daspwhen rebuilding an instance, you can't redeclare userdata (AFAIK) but you effectively make cloud-init re-run, that's a trap my users run into16:55
sean-k-mooneydasp: for rebuild we do allow new user data to be pass in a later microverion i belive16:56
bauzasyeah that rings me a bell16:56
sean-k-mooneydasp: you are correct that orginally we did not16:56
bauzassec16:56
daspoh, sorry my org is running a bit "behind" on versions16:56
bauzassean-k-mooney: 2.316:57
bauzasso... Kilo16:57
sean-k-mooney2.54 allows the key to be changed on rebuild https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id50 and 2.57 allows user data to be updated16:57
bauzasoh, that one16:57
sean-k-mooneybauzas: its no 2.316:57
bauzasyeah my bad16:57
bauzasthis is Queens16:58
sean-k-mooneybut ya since queens16:58
bauzaswe only have 2 mins left16:58
bauzas(as a timekeeper)16:58
sean-k-mooneyjhartkopf: we could proably make it mutable if there is a use facing usecase but we would need to support config dirve and note that the change may not fully be ableable untill after a hard reboot16:59
bauzasI'll have to call it a wrap16:59
bauzasfor this week16:59
bauzaswe can revisite this in the spec16:59
bauzas#info https://review.opendev.org/c/openstack/nova-specs/+/816542 requires propre description of enduser cases for mutable user data17:00
bauzasthat's it, we're over time17:00
bauzasthanks all17:00
bauzas#endmeeting17:00
opendevmeetMeeting ended Tue Nov 23 17:00:36 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)17:00
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-23-16.00.html17:00
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-23-16.00.txt17:00
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-23-16.00.log.html17:00
sean-k-mooneyjhartkopf: so i dont think bauzas  or myself are entirly aginst this but the reasons for doing it present sofare in the spec dont fully seam valid17:01
bauzascorrect17:01
jhartkopfWell, I understand your concerns.17:01
bauzascopying others isn't enough for me17:01
jhartkopfThis was definitely not a copy, as you can see in the implementation. We had a use case internally, which may seem not valid to others.17:02
jhartkopfI don't know if we will put further work into it.17:03
sean-k-mooneyjhartkopf: i think you orginally mention NTP servers chanign which i woudl have expected to be pushed out via either vendor data or neutron via dhcp17:03
opendevreviewArtom Lifshitz proposed openstack/nova master: DNM: Explode libvirt builds to trigger tempest error code  https://review.opendev.org/c/openstack/nova/+/81893217:03
sean-k-mooneyjhartkopf: i do liek the multiple key pairs or updating keypairs usecase17:04
sean-k-mooneyso perhaps if we support that it also makes sense to allow updatign the user-datat to allow bootstraping that 17:05
bauzasjhartkopf: sorry, didn't wanted to nack, I need to revisite your spec17:05
bauzasjhartkopf: probably understanding which specific instance action you'd like the userdata to be updated, and why, would help17:06
sean-k-mooneybauzas: well without config driver i think its just a server update17:06
bauzasand what would be the benefit for the end user17:06
bauzassean-k-mooney: that's why I don't want to discuss about the solution yet17:07
sean-k-mooneythen its updated in the metadata api so the instance can retirve the new version 17:07
bauzasI need to understand the problem that a immutable userdata creaters17:07
bauzascreates*17:07
jhartkopfsean-k-mooney: Maybe, I have to think about that multiple SSH keys use case more.17:08
sean-k-mooneyjhartkopf: with your proposal this would also be a replace of the user data right17:09
sean-k-mooneyso you would have to get it then update it localy then submit the updated version17:09
sean-k-mooneyso its a replace not inplace update/patch17:09
jhartkopfThis replaces current user data, yes17:09
sean-k-mooneypart of my consern is this is a potenital securrity issue17:10
sean-k-mooneyin that an admin could alter the user data, reboot the instnace and then gain access to the instnace17:10
sean-k-mooneyi know the admin can get acess other ways17:11
sean-k-mooneybut its potentally problematic in some cases17:11
jhartkopfsean-k-mooney: I see, it's something to consider.17:14
jhartkopfWill discuss with my team and decide what to do17:15
jhartkopfThanks for your time sean-k-mooney and bauzas17:15
jhartkopfhave a good day :)17:16
bauzasyou too17:21
* bauzas stops for the day17:21
gansostephenfin, sean-k-mooney: hi! very quick question: in light of patch https://review.opendev.org/c/openstack/nova/+/792356 then it means this doc is incorrect, right?: https://docs.openstack.org/neutron/wallaby/admin/config-ovs-dpdk.html#using-vhost-user-multiqueue17:39
sean-k-mooneyganso: just looking17:40
sean-k-mooneywhat specificlly17:40
gansogrepping the code in wallaby branch still doesn't turn anything up related to vif_multiqueue_enabled being used through the flavor17:40
gansosean-k-mooney: the doc states the property could be used in the flavor17:41
gansosean-k-mooney: which does not seem to be the case17:41
sean-k-mooneyyes so that will need to be udated as part of this change17:41
sean-k-mooneysorry not17:41
sean-k-mooneyit has $ openstack flavor set $m1.large --property hw:vif_multiqueue_enabled=true and $ openstack image set --property hw_vif_multiqueue_enabled=true IMAGE_NAME17:41
gansosean-k-mooney: oh cool so no need to update the doc, thanks!17:42
sean-k-mooneyganso: it looks like the doc was incorreectly updated at some point17:43
sean-k-mooneyassuming likely that this chagne had already merged17:43
sean-k-mooneyganso: there is a docs change in this serise anyway https://review.opendev.org/c/openstack/nova/+/792362/817:44
sean-k-mooneywhich can be used to do any more change that are required17:44
*** mdbooth8 is now known as mdbooth17:48
opendevreviewRodrigo Barbieri proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware  https://review.opendev.org/c/openstack/nova/+/79236417:48
gansosean-k-mooney: oh thanks I had forgotten about the other patches in the topic17:49
*** jamesdenton_alt is now known as jamesdenton20:12
*** artom_ is now known as artom20:20
* artom will end up just doing https://review.opendev.org/c/openstack/nova/+/813419 for https://review.opendev.org/c/openstack/nova/+/81730320:20
artomUntil Neutron starts telling us authoritatively what kind of events to wait for and when, we're pushing the responsibility on the operator to tell us in config options.20:21
sean-k-mooneyartom: maybe20:47
sean-k-mooneywe have a simialir issue wiht disable ports and evacuatate apparently20:48
sean-k-mooneyim not sure we can really just set thse for every operation20:48
opendevreviewDan Smith proposed openstack/nova master: Revert project-specific APIs for servers  https://review.opendev.org/c/openstack/nova/+/81620621:01
artomsean-k-mooney, ugh21:43
sean-k-mooneythe disable prot issue is simpel to fix21:47
sean-k-mooneybut im not sure if the downstream evacute issue is related to the revirt migrate issue or not21:47
sean-k-mooneyartom: the event handeling is all a bit of a mess since neutron is so inconsitent when sending events21:47
sean-k-mooneyartom: latest live migration issue https://bugs.launchpad.net/nova/+bug/195162321:48
sean-k-mooneyi outlined the fix in comment 3 but technically neutron should be seind plug event even for disable interface21:49
artomsean-k-mooney, yeah, so if Neutron's not fixing themselves, and we're not dumping all that complexity on the operator, then... just stop using external events altogether?21:49
sean-k-mooneybecause we do plug them the agent is just ment to set the port down21:49
artomAnd too bad if the instance has no network for the first few seconds?21:49
sean-k-mooneyno we need to find time to fix it21:50
sean-k-mooneyyou can just disable treating vif plug failrue as error today21:51
sean-k-mooneyits not the right solution long term but you can if you need too21:51
sean-k-mooneyand we have a second option specificly for live migration i belte and now gibi has added a new one21:51
opendevreviewArtom Lifshitz proposed openstack/nova master: Add nova-next-hybrid-plug job  https://review.opendev.org/c/openstack/nova/+/81730321:52
sean-k-mooneyhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.vif_plugging_is_fatal21:52
sean-k-mooneyand https://docs.openstack.org/nova/latest/configuration/config.html#compute.live_migration_wait_for_vif_plug21:52
artomTrue, we have the first config option21:53
* artom preps supper and other household chores21:55

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!