| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 01:26 |
|---|---|---|
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 01:47 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | 03:02 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 03:14 |
| *** gouthamr_ is now known as gouthamr | 06:19 | |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | 06:35 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | 06:47 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | 06:47 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 06:47 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | 07:09 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 07:09 |
| brinzhang | hi team, the series of remove tenant_id patches have been updated, please review them while you are free, thanks | 07:11 |
| gibi | stephenfin: nice catch | 07:19 |
| bauzas | good morning fokls | 08:14 |
| lyarwood | Morning | 08:21 |
| gibi | bauzas, lyarwood: happy Friday! | 08:22 |
| *** gibi is now known as giblet | 08:22 | |
| bauzas | oh, the Friday dress code is back ? | 08:22 |
| *** bauzas is now known as bauwser | 08:22 | |
| giblet | my neighbor decided to renovate his flat and the workers demolishing his bathroom at the moment which has a common wall with my flat. there is a constant noise so I feel like giblet already | 08:23 |
| giblet | hence the name | 08:23 |
| bauwser | hah, the likes of remote working | 08:24 |
| lyarwood | urgh that's awful giblet | 08:26 |
| giblet | I will survive | 08:29 |
| bauwser | every last Thurday of the month, I appreciate my neighbor | 08:30 |
| bauwser | just because then he gets 5 people for mowing his lawn | 08:31 |
| giblet | a lot of lawn I assume | 08:32 |
| bauwser | yeah, around ~2500sqm | 08:32 |
| bauwser | but they are not having mowers | 08:32 |
| bauwser | rather lawn tractors... | 08:32 |
| bauwser | you can imagine the noise | 08:33 |
| giblet | :/ | 08:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/pike: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813437 | 09:06 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | 09:46 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | 09:46 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | 09:46 |
| opendevreview | Merged openstack/nova master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/nova/+/817641 | 09:52 |
| bauwser | gibi: thanks for reviewing https://review.opendev.org/c/openstack/nova/+/816861 | 09:56 |
| bauwser | ah, giblet ^ | 09:57 |
| bauwser | giblet: your comment looks good to me, I'll provide a new revision | 09:57 |
| giblet | bauwser: how do you feel about my top level comment there that I'm supportive to allows non-cores to state priority but not for patch owners to self +1? | 10:02 |
| bauwser | giblet: honestly, I don't have any opinion | 10:03 |
| bauwser | giblet: maybe we should not use this label for asking folks to look at our change | 10:03 |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 10:03 |
| bauwser | giblet: but we should try to find some way to help contributors to ask for reviews without needing to go in IRC | 10:04 |
| bauwser | so I'll provide 2 different points | 10:04 |
| bauwser | and we'll discuss this in the change | 10:04 |
| giblet | hm | 10:17 |
| giblet | why people cannot come to IRC? | 10:17 |
| giblet | is the problem that it is real time and therefore time zone dependent? | 10:18 |
| giblet | then they can use the ML | 10:18 |
| giblet | (but also I keep my client up and read scrollback so I can be reached from other timezones via IRC too) | 10:19 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: [doc] propose Review-Priority label for contribs https://review.opendev.org/c/openstack/nova/+/816861 | 10:34 |
| bauwser | giblet: we provided a way to async ask for reviews previously with the etherpad | 10:36 |
| bauwser | now, you need to ping people, ideally synchronously | 10:36 |
| bauwser | and I don't want the ML to be used for begging reviews or other non-nova contributors will yell at us :) | 10:37 |
| bauwser | but I need to go to gym | 10:38 |
| bauwser | I'm starting to look at https://gerrit-review.googlesource.com/Documentation/user-attention-set.html | 10:38 |
| bauwser | we could use it | 10:38 |
| *** lbragstad0 is now known as lbragstad | 11:06 | |
| giblet | bauwser: attentions set is built on people added in CC and in Review field of a patch | 11:18 |
| giblet | btw, why don't we say, add me in the review if you need me to look at the patch | 11:19 |
| giblet | that is async and gerrit based | 11:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Enable SQLAlchemy 2.0 deprecation warnings https://review.opendev.org/c/openstack/nova/+/804709 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of Executable.scalar(), Executable.execute() https://review.opendev.org/c/openstack/nova/+/804878 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of 'autoload' parameter https://review.opendev.org/c/openstack/nova/+/805734 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of legacy select() calling style https://review.opendev.org/c/openstack/nova/+/805735 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace 'insert.inline' parameter with 'Insert.inline()' method https://review.opendev.org/c/openstack/nova/+/805736 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Don't pass strings to 'Connection.execute' https://review.opendev.org/c/openstack/nova/+/805737 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Don't use legacy 'Row()' methods https://review.opendev.org/c/openstack/nova/+/817746 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove use of 'bind' arguments https://review.opendev.org/c/openstack/nova/+/817747 | 11:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove unnecessary warning filters https://review.opendev.org/c/openstack/nova/+/817748 | 11:27 |
| giblet | lyarwood, sean-k-mooney: so the patch with the sleep before detach now reproduced the kernel panic https://review.opendev.org/c/openstack/nova/+/817564/3#message-8ef45ae21f54b427ae2c88bbc19a4c926ce00883 | 13:17 |
| giblet | from the consol log it is clear that the kernel panic happened _before_ we trigger detach | 13:18 |
| sean-k-mooney | is it possible the panic was tirggered by the attach | 13:18 |
| giblet | or by the live migration | 13:18 |
| giblet | or by the initial boot | 13:18 |
| giblet | all possible | 13:18 |
| giblet | so I will add more console printing step to the test case | 13:19 |
| giblet | to see when the panic happens | 13:19 |
| sean-k-mooney | looks liek it happend 19 seocnd after boot | 13:20 |
| giblet | true, we can try to correlate that to the action in the test | 13:20 |
| sean-k-mooney | the vm went active ~ 12:04:29 | 13:21 |
| sean-k-mooney | we did the attach at 12:04:40 | 13:21 |
| sean-k-mooney | actully no maybe i misread that | 13:22 |
| giblet | 2021-11-12 12:04:30,036 99321 INFO [tempest.common.waiters] State transition "BUILD/spawning" ==> "ACTIVE/None" after 7 second wait | 13:23 |
| giblet | 2021-11-12 12:04:38,573 99321 INFO [tempest.common.waiters] volume 0f307fda-dbef-408c-a029-97401db15945 reached in-use after waiting for 0.573394 seconds | 13:23 |
| sean-k-mooney | looks liek we were just finsihing the mightation when the panic happend | 13:24 |
| sean-k-mooney | it went active at 2021 12:04:52 | 13:24 |
| giblet | 2021-11-12 12:04:40,615 <- trigger the live migration | 13:25 |
| giblet | 2021-11-12 12:04:52,693 99321 INFO [tempest.common.waiters] State transition "MIGRATING/migrating" ==> "ACTIVE/None" after 12 second wait | 13:25 |
| giblet | yeah so the panic is somehow related to the live migration | 13:26 |
| sean-k-mooney | yep | 13:26 |
| sean-k-mooney | it woudl have been i gues at :49 ish | 13:26 |
| sean-k-mooney | giblet: just looking at the panic | 13:27 |
| sean-k-mooney | its realted to ipv6 adress configuraiton | 13:28 |
| giblet | I saw at least 3 different kernel panic | 13:28 |
| giblet | that test can produce | 13:28 |
| giblet | this is the 4th one :) | 13:28 |
| sean-k-mooney | well its specifclay failing in _raw_spin_lock_bh | 13:29 |
| lyarwood | sorry have various trades people in my house today trying to sort something out | 13:30 |
| lyarwood | really hard to focus on anything | 13:30 |
| sean-k-mooney | lyarwood: tl;dr the panic happen during the migration in an interupt handel form _raw_spin_lock_bh at least in this insntace | 13:31 |
| lyarwood | giblet: remind me again, when did thi start failing? | 13:32 |
| sean-k-mooney | so its before the detach in the cleanup phase if the time stames are correct | 13:32 |
| lyarwood | this* | 13:32 |
| giblet | tehre is lot of different RIP codes in the reproductions https://paste.ubuntu.com/p/QGrtv2nZWz/ | 13:32 |
| giblet | lyarwood: on it ... | 13:32 |
| giblet | lyarwood: the first panic was 2021-11-08T12:59:16 | 13:33 |
| sean-k-mooney | giblet: yes altoh galoto of them look like they are related to lcoking/interupt handeling in general | 13:33 |
| giblet | this one https://zuul.opendev.org/t/openstack/build/c445dc25cb2c4567b223f05d95134c47 | 13:34 |
| lyarwood | giblet: kk it's not related to https://review.opendev.org/c/openstack/devstack/+/812928 then | 13:34 |
| giblet | lyarwood: there is big gaps between nova-live-migration job run before 11.08. | 13:36 |
| giblet | https://zuul.opendev.org/t/openstack/builds?job_name=nova-live-migration&project=openstack%2Fnova&branch=stable%2Fvictoria | 13:36 |
| giblet | only 2 runs in october | 13:36 |
| giblet | the newer october run still has the logs the older is already lost | 13:38 |
| sean-k-mooney | looking at https://zuul.opendev.org/t/openstack/build/c445dc25cb2c4567b223f05d95134c47 that panic happend even eairlier in the test after 15 seconds | 13:39 |
| sean-k-mooney | i have not check if that is during th migration or not but i suspect its also before the detach | 13:39 |
| sean-k-mooney | 2021-11-08 12:41:10,502 99684 INFO [tempest.common.waiters] State transition "BUILD/spawning" ==> "ACTIVE/None" after 6 second wait | 13:40 |
| sean-k-mooney | volume was attached at | 13:41 |
| sean-k-mooney | 2021-11-08 12:41:18,780 99684 INFO [tempest.common.waiters] volume fb8d4e1c-5dae-41b4-a1d9-6ef20937997b reached in-use after waiting for 0.780033 seconds | 13:41 |
| sean-k-mooney | and the migration finished at 2021-11-08 12:41:32,756 99684 INFO [tempest.common.waiters] State transition "MIGRATING/migrating" ==> "ACTIVE/None" after 12 second wait | 13:42 |
| sean-k-mooney | so the panic was also during the live migration | 13:42 |
| sean-k-mooney | so the detach is failing because the vm was dead after the migration | 13:43 |
| giblet | I checked the oct 29 green run has the same qemu / libvirt version as the later failed runs | 13:43 |
| giblet | qemu-system-x86 amd64 1:4.2-3ubuntu6.18 and libvirt0 amd64 6.0.0-0ubuntu8.14 | 13:43 |
| sean-k-mooney | im just checking dowstram if we have an closed bugs with live migration or painc in ther enames | 13:47 |
| sean-k-mooney | 11 | 13:47 |
| sean-k-mooney | there are 3 nested virt issue that lok somewhat related but thos where this is happenign are not using that correct | 13:52 |
| giblet | we have virt_type=qemu in the config | 13:55 |
| giblet | so they are not nested guests | 13:55 |
| sean-k-mooney | yes but im wonderign if nested virt is avaiabel and if the host are intel do they have kvm_intel.pml=1 | 13:59 |
| sean-k-mooney | its not nested kvm but its still a nested qemu instnace | 13:59 |
| sean-k-mooney | actully the pml issue seams to be more related to live migrating the l1 vm not the l2 vm | 14:00 |
| sean-k-mooney | so ya i dont see anything downstram that imidiatly screams this is a fixed qemu/kernel bug | 14:09 |
| giblet | I did a summary in the bug and linket do this chat | 14:13 |
| belmoreira | hi, I remember that in the past there were some discussions to have live migrations between cells. | 14:44 |
| belmoreira | is there any progress on this? | 14:45 |
| giblet | belmoreira: I think the cross cell migration work was stopped when mriedem left | 14:45 |
| sean-k-mooney | we have not implemeted it | 14:45 |
| sean-k-mooney | we have cross cell cold migratiohn/resize | 14:46 |
| sean-k-mooney | belmoreira: there is no assumtion that hyperviors can talk to each other directly between cells | 14:46 |
| sean-k-mooney | belmoreira: they might be abel too but we decied we could not assuem that | 14:46 |
| belmoreira | yeah... is what I recall. And I think he was only working in cold migration as a starting point | 14:46 |
| sean-k-mooney | giblet: the cross cell migration work is completed | 14:47 |
| sean-k-mooney | giblet: that works but only cold migration | 14:47 |
| sean-k-mooney | via effectivly a shelve | 14:47 |
| giblet | yepp | 14:47 |
| sean-k-mooney | and then unshelve to the new cell | 14:47 |
| belmoreira | humm... I missed that in the release notes. | 14:48 |
| dansmith | belmoreira: it's been like a couple years at this point.. :P | 14:48 |
| dansmith | I dunno how reliable it is because I think it's very infrequently used, if that :/ | 14:49 |
| sean-k-mooney | i think its in train | 14:49 |
| sean-k-mooney | but ya i don tknow if any of our downstream custoemr use it | 14:50 |
| sean-k-mooney | most of them are not multi cell | 14:50 |
| belmoreira | honestly, I was searching for it just few minutes ago... in all releases after Rocky because I recall that mriedem was working on it | 14:50 |
| belmoreira | but anyway... what I'm looking at is a way to live migrate not cold migrate | 14:51 |
| sean-k-mooney | oh its ussuri https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/cross-cell-resize.html | 14:51 |
| sean-k-mooney | belmoreira: right we basically agree to not implemnte live migration | 14:51 |
| sean-k-mooney | effectivly ever | 14:51 |
| dansmith | sean-k-mooney: did we? | 14:51 |
| belmoreira | :) | 14:51 |
| sean-k-mooney | we could but it would reuiqre assumeing conenctivty betwenn the hyperviors in diffenet cells | 14:51 |
| dansmith | IIRC it was going to be more complicated, very little audience, and so had no plans | 14:52 |
| sean-k-mooney | dansmith: well i thinke the connectivty was the main blocker | 14:52 |
| dansmith | sure, but live migration already assumes connectivity between hosts that not everyone allows, even in one cel | 14:52 |
| sean-k-mooney | i gues that is true | 14:52 |
| belmoreira | my use case is a one off... I'm trying to get rid of nova-network | 14:52 |
| dansmith | my recollection was "if there's large uptake of cells and this becomes a thing lots of people want, we can consider, but no plans until then" | 14:53 |
| sean-k-mooney | belmoreira: if you have a need for it and or people to work on it i would be happy to review a spec | 14:53 |
| dansmith | and so far, no such demand that I know of | 14:53 |
| sean-k-mooney | dansmith: yep i think that is a fiar summary | 14:53 |
| belmoreira | the hypothetical plan would be to live migrate the instances from a nova-network cell to a neutron cell | 14:53 |
| dansmith | belmoreira: well, unlikely that would work anyway I think, without very special planning on our part, | 14:54 |
| dansmith | which we obviously can't and won't do without the code being in master :) | 14:54 |
| belmoreira | yeah... honestly I'm not asking for it... but it would be great if we can discuss the blockers... in case I need to deal with them | 14:55 |
| belmoreira | the main problem in my view would be to make both source and dest talk (different conductors) and populate the DB | 14:55 |
| *** efried1 is now known as efried | 14:56 | |
| dansmith | belmoreira: it would need to work the same way the cross-cell cold migration works, | 14:56 |
| dansmith | which is the superconductor does that bridging from the nova perspective | 14:56 |
| dansmith | i.e. it's the thing that creates the instance in the target cell and deletes it from the old cell when the time comes | 14:56 |
| sean-k-mooney | dansmith: we might also need to proxy the conntion between the hypervirous via the the super condctor host or some other host if we coudl not asusme direct conenctivity | 14:57 |
| belmoreira | in my case I can have direct connectivity | 14:57 |
| sean-k-mooney | there are also complcaiton when volumes or ceph gets invovled | 14:57 |
| sean-k-mooney | belmoreira: is your cinder/ceph storage shared accross cells | 14:58 |
| belmoreira | yes, it is | 14:58 |
| dansmith | sean-k-mooney: well, or we have to redesign the live migration flow to go through (super)conductor in a more push-pull sort of way | 14:58 |
| sean-k-mooney | well i ment makign it so qemu on one host could talke to qemu on another via proxign the coneection. | 15:00 |
| dansmith | oh, I dunno, I think you'd just make it a requirement that they can talk direct, | 15:01 |
| dansmith | even if for a short time | 15:01 |
| dansmith | implementing a well-performing proxy at the superconductor (which is likely just a container on a host) seems like more work than necessary | 15:01 |
| sean-k-mooney | ya it does | 15:02 |
| belmoreira | those are not limitations for me... | 15:02 |
| sean-k-mooney | belmoreira: yep the were just limiation in general | 15:02 |
| sean-k-mooney | e.g. if you map cells to edge sites | 15:02 |
| sean-k-mooney | cross cell migration get a lot harder if its over the wan | 15:03 |
| belmoreira | it looks like it's a lot of work... because its a live migration the instance entries need to be created in the dest cell DB, domain XML needs to be created, take care of the network logic, and possible ceph volumes attached... qemu starts the migration and it needs to be removed from the source DB, placement updated | 15:04 |
| sean-k-mooney | i dont link config driven api behavior but i kind of feel like we woudl need a way to enabel/disabel this perhapes via the sschuler config in soem way | 15:04 |
| sean-k-mooney | belmoreira: we would have to also update the instnace cell mapping in the api db | 15:05 |
| belmoreira | true | 15:05 |
| sean-k-mooney | which is parly why this need to be driven by the super conductor | 15:05 |
| dansmith | sean-k-mooney: we disabled it via policy now | 15:05 |
| sean-k-mooney | dansmith: cross cell live migration | 15:06 |
| sean-k-mooney | how does the policy rule know its corsscell | 15:06 |
| sean-k-mooney | are we actully doign a lookup of the host if we force the destionaion? | 15:07 |
| belmoreira | Cross cell resize was added in Ussuri (i was searching for migration, that's why I missed it) | 15:07 |
| dansmith | sean-k-mooney: we have a flag to the api that says "can cross cell boundaries" I think, and only allow that if policy passes | 15:08 |
| sean-k-mooney | belmoreira: ah ya same code path internelly | 15:09 |
| belmoreira | great... looks like I will be the oldest nova-network user around :) | 15:12 |
| belmoreira | dansmith sean-k-mooney thanks a lot for the comments and insights | 15:12 |
| dansmith | sean-k-mooney: well, I thought we expressed intent to the api that we wanted to cross, but apparently it's only the config flag, but yeah we check the policy deeper in compute/api to decide if the user is allowed | 15:15 |
| sean-k-mooney | ya that would work. i dont think we modify the request body to request cross cell either, so ya it woudl have to be checked later in the compute api | 15:18 |
| giblet | sean-k-mooney: Am I correct that nova uses the physnet of the neutron network in two cases 1) matching it with the physical_network property of the PciDevice (coming from the whitelist) during scheduling if there is InstancePciRequest 2) if numa aware vswitches are configured then matching against novas configuration | 15:35 |
| giblet | https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/numa-aware-vswitches.html#id33 ? | 15:35 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 15:36 |
| elodilles | bauwser: sorry, I forgot to ping you earlier about the ussuri release patch (as today is the Ussuri Transition Day o:)) if you could approve this that would be great :) https://review.opendev.org/c/openstack/releases/+/817226 | 15:48 |
| bauwser | elodilles: done :) | 15:50 |
| elodilles | bauwser: cool, thanks! \o/ I'll update the nova ussuri-em patch after this has merged | 15:52 |
| bauwser | ;) | 15:52 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 16:50 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 16:52 |
| elodilles | bauwser if you are still here: ussuri relese patch has merged and the ussuri-em patch is updated: https://review.opendev.org/c/openstack/releases/+/817606 | 16:55 |
| bauwser | elodilles: last call, indeed. | 16:55 |
| elodilles | bauwser: uh, didn't want to leave it to end of the day, but somehow forgot to ping you earlier :S sorry :/ | 16:56 |
| bauwser | np :) | 16:57 |
| artom | dansmith, hey, if we do an instance.save() for example, but no fields have changed, we don't actually do the DB update, correct? | 17:08 |
| * bauwser goes off for the day | 17:15 | |
| bauwser | elodilles: I could be wrong but I said 'no' to https://review.opendev.org/c/openstack/releases/+/817606 | 17:16 |
| dansmith | artom: https://github.com/openstack/nova/blob/171138146a648d22474b7021ac730e26f03455f8/nova/objects/instance.py#L810-L811 | 17:16 |
| artom | dansmith, oh, it's only in instance, not provided by base ovo? | 17:17 |
| * artom checks base ovo save() | 17:17 | |
| dansmith | artom: not all objects even have a save | 17:17 |
| artom | Doh, right | 17:18 |
| dansmith | artom: base ovo provides dirty tracking for the fields, but what you do with it is up to you | 17:18 |
| *** amodi_ is now known as amodi | 17:19 | |
| artom | dansmith, yeah, makes sense | 17:20 |
| sean-k-mooney | giblet: yes those are the two cases it uses it | 17:58 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 18:01 |
| elodilles | bauwser: sorry, yes, so those patches are not relevant from release perspective :) | 18:12 |
| elodilles | bauwser: why would we force customers to upgrade those packages on production systems because of some TOX and zuul and gerrit related changes? o:) | 18:14 |
| sean-k-mooney[m] | which packages | 18:15 |
| elodilles | osc-placement and python-novaclient | 18:15 |
| elodilles | sean-k-mooney[m]: see this patch: https://review.opendev.org/c/openstack/releases/+/817606 | 18:15 |
| sean-k-mooney[m] | the oscp placment tox changes wont alter what is installed | 18:18 |
| sean-k-mooney[m] | it just uses the ussuri upper-constratings instead of master | 18:19 |
| elodilles | yepp, exactly :) | 18:22 |
| sean-k-mooney[m] | elodilles i would personally update the shas to the latest if we are doing a release anyway but i dont see any issues that would need a release to be packaged | 18:23 |
| sean-k-mooney[m] | there is a fix for one func test in novaclient | 18:23 |
| sean-k-mooney[m] | but again wont affect end users | 18:23 |
| elodilles | sean-k-mooney[m]: the *-em tag is not a "release" it is a tag against the latest release. and releases should be meaningful for end users as far as i know | 18:24 |
| *** Guest5508 is now known as melwitt | 19:26 | |
| *** melwitt is now known as Guest5716 | 19:27 | |
| *** Guest5716 is now known as melwitt | 19:32 | |
| *** melwitt is now known as jgwentworth | 19:34 | |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 20:25 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 20:26 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | 21:53 |
| opendevreview | David Hill proposed openstack/nova stable/ussuri: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/817689 | 23:00 |
| opendevreview | David Hill proposed openstack/nova stable/train: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/817830 | 23:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!