Wednesday, 2021-11-03

brinzhangbauzas, gibi, gmann, stenphenfin, sean-k-mooney: I have reprosed the remove_tenant_id spec, do you have time to review? 02:57
*** redrobot2 is now known as redrobot05:58
gibibrinzhang: ack06:11
*** gibi is now known as gibi_pto_back_thu06:11
brinzhanggibi: thanks06:11
opendevreviewElod Illes proposed openstack/nova stable/rocky: [stable-only] Pin virtualenv and setuptools  https://review.opendev.org/c/openstack/nova/+/81643607:56
kashyapfrickler: Morning, I also filed this one: https://gitlab.com/libvirt/libvirt/-/issues/23309:07
kashyap(It also links to the RFE you posted.)09:08
fricklerkashyap: thx for the link, I'll watch that issue, too09:19
lyarwoodfrickler: do we have an openstack bug tracking this?09:21
lyarwoodI seem to recall something for the centos issues etc but I can't find it09:22
fricklerlyarwood: actually https://bugs.launchpad.net/devstack/+bug/1938914 might have been the same thing in retrospect09:26
fricklerI was wondering early why centos jobs didn't seem to be affected and found the swap setting that likely mitigates it09:26
fricklers/early/earlier/, like yesterday09:27
lyarwoodhmm is that setting also used by centos-stream jobs?09:27
lyarwoodbecause they were still failing 3 weeks ago09:27
* lyarwood checks09:27
lyarwoodyeah they are centos stream09:28
fricklerhttps://review.opendev.org/c/openstack/devstack/+/803706/2/.zuul.yaml09:28
lyarwoodokay weird, https://zuul.opendev.org/t/openstack/builds?job_name=devstack-platform-centos-8-stream is green but I'm sure things were borked the last time I looked09:28
lyarwoodah I think it was tempest-full-py3-centos-8-stream that I was having issues with09:30
lyarwoodin https://review.opendev.org/c/openstack/tempest/+/79761409:30
lyarwoodand that doesn't have the swap setting09:30
lyarwoodcool09:31
fricklerlyarwood: looks likely related. maybe to verify you'll want to build a custom qemu like I did for bullseye09:32
lyarwoodfrickler: yeah, I'll add the swap for now. FWIW we are likely going to escalate this to the virt folks downstream so we can work something out asap as Nova isn't even able to workaround this09:33
lyarwoodand we really don't want to use custom builds upstream09:33
kashyapfrickler: lyarwood: So, even if libvirt upstream provides a patch right away, next upstream release is only a month away09:34
lyarwoodright and then it needs to be backported09:34
lyarwoodso it's going to take time09:34
fricklerlyarwood: kashyap: I was about to say the same thing. and getting it into Ubuntu 22.04 and/or Bullseye will even be more difficult09:34
opendevreviewMerged openstack/nova master: db: Enable auto-generation of API DB migrations  https://review.opendev.org/c/openstack/nova/+/81214409:35
lyarwoodI guess the swap workaround might be enough as well?09:35
opendevreviewMerged openstack/nova master: db: De-duplicate list of removed table columns  https://review.opendev.org/c/openstack/nova/+/81448909:36
kashyapfrickler: So, are _all_ CI jobs failing here?09:36
kashyaplyarwood: Another idea to explore is to temporarily pin to a lower QEMU version? 09:37
lyarwoodkashyap: I don't think that's an option with centos-8-stream?09:37
fricklerkashyap: it depends on tempest scheduling, so it is not 100%. with -c2, which lyarwood set for the tempest patch, we had around 50% failure rate for Bullseye09:39
kashyaplyarwood: I don't know top off my head what's possible w/ -8-stream09:39
kashyapfrickler: Hmm09:44
lyarwoodfrickler: have you tried the Bullseye jobs with increased swap?09:45
fricklerlyarwood: not yet, for now it seemed o.k. with -c1, but I can give that a spin09:53
lyarwoodack that might be a better short term workaround09:54
kashyaplyarwood: What is -c1?09:59
lyarwoodconcurrency 1 , a tempest configurable that controls how many tests run at the same time10:00
lyarwoodso -c1 meaning run one test at a time10:00
kashyapAh, thanks10:00
kashyaplyarwood: Also, BTW: I was just chatting to the QEMU TCG maint - 10:00
lyarwood-c1 is just shorthand FWIW it isn't the actual option10:01
kashyaplyarwood: They won't revert it, because ramping up that value makes TCG much faster (which also benefits us, as frickler also found it from his tests)10:01
lyarwoodkk 10:01
kashyapfrickler: lyarwood: Can you point to the sepcs of the VM images?  I'm being asked about it10:02
kashyapIs it 8G RAM per env?10:03
kashyaps/sepcs/specs/10:04
kashyaplyarwood: BTW: on version pinning I just found this one: https://dnf-plugins-core.readthedocs.io/en/latest/versionlock.html10:06
kashyaplyarwood: It _is_ possible to lock to `dnf versionlock`10:06
lyarwoodright my point was if we had an older version available in the repos10:06
kashyaplyarwood: frickler: Also, can the concurrency variable limit the no. of VMs that can run?10:07
lyarwoodthat's essentially what it's doing yes10:07
lyarwoodsome tests have multiple vms10:07
lyarwoodbut overall it should limit it to roughly twice the concurrency value10:08
kashyaplyarwood: *Twice* the concurrency value?  Or half?10:08
* kashyap goes to read - https://docs.openstack.org/tempest/latest/run.html10:08
kashyapOkay, there's also a --serial/-t -- but that'll be slow, I guess.  How slow, only one way to figure out10:09
lyarwoodkashyap: twice, concurrency 2 will run 2 tests at the same time and both of these could have 2 instances each (at most IIRC, I can't think of anything with more than 2)10:09
kashyapAh, I see.  Thanks10:09
lyarwoodso we are already running -c1 that's essentially -s 10:11
lyarwoodand my centos jobs are using -c2 and now with an increased amount of swap10:11
lyarwoodhopefully that's enough to get things stable in the meantime10:11
kashyapAh, that's good to know.  You only mention CentOS.  But Debian "Bullseye" jobs also seems to be impacted w/ it, yeah?10:13
lyarwoodyeah correct, as above frickler is going to play around with adding the extra swap now I believe10:19
kashyapThanks!  So extra swap + serial should get out of the ditch temporarily?10:20
kashyapBy "serial" I mean "-c1" / --serial10:21
lyarwoodwell as high as we can go10:21
lyarwoodso hopefully -c2 10:21
lyarwoodwith swap10:21
lyarwoodand failing that -c1 / serial10:21
lyarwoodassuming we don't hit the job timeout of 2 hours10:21
kashyapNoted, thanks!10:29
fricklerlyarwood: the job timeout for both platform jobs in devstack has been raised to 3 hours10:35
fricklerkashyap: 8G is the memory size for default CI instances, we have that documented somewhere ...10:36
fricklerhttps://docs.opendev.org/opendev/infra-manual/latest/testing.html#unprivileged-single-use-vms10:36
fricklerdoes that answer your question or what specs were you referring to?10:37
* kashyap clicks10:38
kashyapfrickler: Great link; yes, it does.  One of the QE devs was asking of it10:38
stephenfinlyarwood: when I do 'openstack server add volume $SERVER $VOLUME --tag $TAG', where should I expect to see the tag appear?11:09
lyarwoodstephenfin: https://docs.openstack.org/api-ref/compute/?expanded=attach-a-volume-to-an-instance-detail#id190 - it's in the response from 2.70 11:10
lyarwoodstephenfin: if osc can handle that of course11:10
lyarwoodstephenfin: looks like we don't dump anything on attach, it should also be there with a list of the attached volumes using 2.7011:13
lyarwoodstephenfin: you added support for it11:13
stephenfinyeah, I'm not sure why. Seems we just dispose of the result from the API11:15
opendevreviewLee Yarwood proposed openstack/nova-specs master: libvirt: Allow Manila shares to be directly attached to instances  https://review.opendev.org/c/openstack/nova-specs/+/81318012:00
stephenfinlyarwood: FYI https://review.opendev.org/c/openstack/python-openstackclient/+/81649112:24
stephenfinalso, I rediscovered 'openstack server volume list'...which it turns out I also wrote /o\ That confirms the tag gets passed through12:27
stephenfinWith the benefit of hindsight, it should probably have been called 'openstack server volume attachment list' (and 'openstack server add volume' should be 'openstack server volume attachment create') but 🤷‍♂️12:27
opendevreviewJulia Kreger proposed openstack/nova master: Ignore plug_vifs on the ironic driver  https://review.opendev.org/c/openstack/nova/+/81326312:57
lyarwoodstephenfin: thanks, looking now and yeah with hindsight adding attachment in there would make sense but meh14:45
opendevreviewJulia Kreger proposed openstack/nova master: WIP Ironic - Handle instance host on rebalance  https://review.opendev.org/c/openstack/nova/+/81389715:05
johnthetubaguy[m]dansmith: for those policy patches, I should be availabe to help review those when they are ready16:02
dansmithjohnthetubaguy[m]: ack, I'll continue working on getting tests passed and then will poke you16:03
johnthetubaguy[m]cool, awesome16:03
gmannjohnthetubaguy[m]: dansmith i can too help in code/review. do you want me to create xls/wiki listing all APIs policy and we weight on what is system scope and project then code. so that we can visualize overall pic instead of going one by in code or separate patches ?16:05
gmannthat was what we missed last time and mixed up scope in many APIs16:05
gmanni saw many projects doing it and it was helpful 16:06
dansmithgmann: sure, I've just been focusing on servers for the moment, but that might be good to have a burndown chart16:07
dansmithabhi did that for policy refactor in glance and it was nice16:08
gmannok, i will do that and then we can keep reviewing those16:08
opendevreviewMerged openstack/os-vif master: Use TCP keepalives for ovsdb connections  https://review.opendev.org/c/openstack/os-vif/+/80522317:00
opendevreviewMerged openstack/os-vif master: only register tables used by os-vif  https://review.opendev.org/c/openstack/os-vif/+/80562517:03
opendevreviewJan Hartkopf proposed openstack/nova-specs master: update userdata  https://review.opendev.org/c/openstack/nova-specs/+/81654217:27
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove models that were moved to the API database  https://review.opendev.org/c/openstack/nova/+/81214917:34
opendevreviewStephen Finucane proposed openstack/nova master: objects: Remove 'bandwidth' fields from notifications  https://review.opendev.org/c/openstack/nova/+/81214817:34
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove models for removed services, features  https://review.opendev.org/c/openstack/nova/+/81215017:34
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove nova-network models  https://review.opendev.org/c/openstack/nova/+/81215117:34
opendevreviewJulia Kreger proposed openstack/nova master: WIP Ironic - Handle instance host on rebalance  https://review.opendev.org/c/openstack/nova/+/81389717:56
sean-k-mooneystephenfin: no you got the name right the resouce is the volumen not the attachments18:46
sean-k-mooneystephenfin: we shoudl not have the concept of port bidnings, volume attachments, cyborg arqs or manilla shares in our apis18:47
sean-k-mooneythe can live in the other service or internally in our dbs but as a use i really should discib what resouces are assocaited with the server instace not how or where18:48
sean-k-mooneythe how and where are all internal implemeation detail that users shoudl not need to reason about if we did things correctly18:48
opendevreviewMerged openstack/nova-specs master: Re-propose Remove tenant_id  https://review.opendev.org/c/openstack/nova-specs/+/80993919:24
opendevreviewMerged openstack/nova master: Avoid unbound instance_uuid var during delete  https://review.opendev.org/c/openstack/nova/+/80560519:51
opendevreviewMerged openstack/nova master: Reno for qos-minimum-guaranteed-packet-rate  https://review.opendev.org/c/openstack/nova/+/80504619:51
opendevreviewMerged openstack/nova master: db: Remove unused build_requests columns  https://review.opendev.org/c/openstack/nova/+/81214519:52
opendevreviewMerged openstack/nova master: Prevent leaked eventlets to send notifications  https://review.opendev.org/c/openstack/nova/+/81403620:49
opendevreviewGhanshyam proposed openstack/nova master: Remove broken tempest-full-py3-opensuse15 job  https://review.opendev.org/c/openstack/nova/+/81657420:57
opendevreviewMerged openstack/nova master: api: enable oslo.reports when using uWSGI  https://review.opendev.org/c/openstack/nova/+/81092221:57
opendevreviewMerged openstack/nova stable/wallaby: Parse alias from domain hostdev  https://review.opendev.org/c/openstack/nova/+/80776722:10
opendevreviewMerged openstack/nova stable/ussuri: Fix error that cannot overwrite policy rule for 'forced_host'  https://review.opendev.org/c/openstack/nova/+/80223822:42

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!