| opendevreview | Jinsheng Zhang proposed openstack/nova master: Nova support live-migrate instance between different ipxe efi rom https://review.opendev.org/c/openstack/nova/+/812796 | 06:26 |
|---|---|---|
| gibi | o/ | 08:00 |
| gibi | bauzas: do we have a meeting this morning? | 08:03 |
| bauzas | dang | 08:03 |
| bauzas | gibi: remind me the meeting name ? | 08:03 |
| gibi | nova_extra | 08:04 |
| gibi | I always have to look that up from https://meetings.opendev.org/#Nova_Monthly_Asia_Friendly_Team_Meeting | 08:04 |
| bauzas | #startmeeting nova_extra | 08:04 |
| opendevmeet | Meeting started Thu Oct 7 08:04:33 2021 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:04 |
| opendevmeet | The meeting name has been set to 'nova_extra' | 08:04 |
| bauzas | good moning folks, I have forgotten to open it :) | 08:04 |
| bauzas | sorry for having it delayed | 08:04 |
| bauzas | I don't have agenda for this meeting | 08:05 |
| bauzas | it's more something like "if you want to discuss with us, let us know" | 08:05 |
| bauzas | do we have Asian contributors here ? | 08:05 |
| bauzas | or any other folks wanting to discuss ? | 08:06 |
| gibi | I can rant about the rainy weather | 08:07 |
| gibi | ;) | 08:07 |
| sean-k-mooney[m] | just looking at the patch submitted above by jingsheng zhang https://review.opendev.org/c/openstack/nova/+/812796 | 08:08 |
| sean-k-mooney[m] | is that something we even support | 08:08 |
| sean-k-mooney[m] | ipxe boot of nova vms | 08:09 |
| bauzas | gibi: hah | 08:09 |
| bauzas | we have a good weather here :) | 08:09 |
| sean-k-mooney[m] | i dont know if they are here and could explain there motivation for that | 08:09 |
| bauzas | sean-k-mooney: good question | 08:09 |
| * bauzas looks at the change | 08:09 | |
| sean-k-mooney[m] | my understandign is the only way to use ipxe is to enable the qemu boot menu | 08:10 |
| sean-k-mooney[m] | and manually select it | 08:10 |
| bauzas | I'm not really sure it's a nova question | 08:10 |
| sean-k-mooney[m] | also this feels like a spec not a bug since it has object changes | 08:10 |
| bauzas | maybe more an image | 08:10 |
| bauzas | I mean, if you want to have instances calling PXE, then you need to have an image booting by it | 08:11 |
| sean-k-mooney[m] | not really | 08:11 |
| sean-k-mooney[m] | that is provided by the qemu seabios image on the host | 08:12 |
| bauzas | sean-k-mooney: but agreed, this isn't a bug, more a new feature | 08:12 |
| sean-k-mooney[m] | its not provide by the glance image | 08:12 |
| gibi | I agree that it feels like a feature | 08:12 |
| sean-k-mooney[m] | we dont officaly support ipxe boot which is why i raised it | 08:12 |
| gibi | when I see ipxe boot with nova that was with a special image booted | 08:12 |
| bauzas | sean-k-mooney: oh, you mean that the host needs to support iPXE ? | 08:12 |
| sean-k-mooney[m] | gibi you can use an ipxe image form glance | 08:13 |
| sean-k-mooney[m] | but seabios i belive support ipex/network boot too | 08:13 |
| bauzas | is this about having guests calling a pxe server or having a way to have a host supporting pxe ? | 08:13 |
| gibi | sean-k-mooney[m]: I see so there is multiple ways | 08:14 |
| sean-k-mooney[m] | its about the guest pxe booting and what happens if you live migrate that guest between hosts | 08:14 |
| sean-k-mooney[m] | if the image was from glance then presumable it would not change between hosts when you live migrate | 08:15 |
| sean-k-mooney[m] | which is why im assumje this is related to teh seabios image form the host | 08:15 |
| sean-k-mooney[m] | it may not be however | 08:15 |
| sean-k-mooney[m] | https://bugs.launchpad.net/nova/+bug/1946298 | 08:16 |
| sean-k-mooney[m] | this is the relevent bug report | 08:17 |
| sean-k-mooney[m] | anyway it looks like they are not present to talk about it in the meeting | 08:17 |
| bauzas | yeah | 08:17 |
| sean-k-mooney[m] | so we can disucss it later | 08:17 |
| bauzas | sean-k-mooney: you should review the change and tell me to at least create a blueprint | 08:17 |
| bauzas | to exactly explain their needs | 08:17 |
| bauzas | it looks to me we never supported ipxe booting with libvirt | 08:18 |
| bauzas | libvirt had the knob, but we never exposed it on nova | 08:19 |
| bauzas | so this is fortunate to work, but indeed for move operations, you have to do extra things | 08:19 |
| sean-k-mooney[m] | correct we dont offically support it | 08:19 |
| sean-k-mooney[m] | looking at the bug report then issue is related to the option rom of the network interface which can have different size on diferent hosts | 08:20 |
| sean-k-mooney[m] | but i dd not think we supported enabling that either | 08:20 |
| gibi | I agree with generic sentiment above, so this is a bp at least but most probably a spec | 08:20 |
| bauzas | that's probably a spec indeed, but let's just ask for the blueprint first | 08:21 |
| bauzas | just to understand the needs | 08:21 |
| bauzas | sean-k-mooney: I can triage the bug as Invalid/Wishlist and explain them to open a blueprint | 08:22 |
| bauzas | agreed ? | 08:22 |
| sean-k-mooney[m] | sure | 08:22 |
| gibi | agreed | 08:23 |
| bauzas | ok, anything else to discuss ? | 08:24 |
| bauzas | I'll put a PTG session proposal to discuss the opportunity of the Asian timeslot | 08:24 |
| bauzas | I don't exactly want to kill it, but I wonder how to make it productive if we keep it | 08:25 |
| bauzas | meetings for the sake of meeting seems a bit irrelevant | 08:25 |
| gibi | bauzas: I had the meeting mentioned in the retro part of the etherpad | 08:25 |
| bauzas | cool | 08:25 |
| bauzas | thanks | 08:25 |
| bauzas | it's more or less the question to reach the contributors who don't usually get into IRC | 08:26 |
| gibi | L119 | 08:26 |
| bauzas | at least, if we continue, I'll officially name "office hour" | 08:26 |
| bauzas | this sounds more reasonable | 08:27 |
| bauzas | as we don't really have an agenda | 08:27 |
| bauzas | ok, anything to add before I close ? | 08:27 |
| gibi | - | 08:29 |
| bauzas | #endmeeting | 08:32 |
| opendevmeet | Meeting ended Thu Oct 7 08:32:13 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:32 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-10-07-08.04.html | 08:32 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-10-07-08.04.txt | 08:32 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-10-07-08.04.log.html | 08:32 |
| * bauzas can now go to the coffee machine | 08:32 | |
| opendevreview | Jinsheng Zhang proposed openstack/nova master: Nova support live-migrate instance between different ipxe efi rom https://review.opendev.org/c/openstack/nova/+/812796 | 08:39 |
| lyarwood | gibi: https://bugs.launchpad.net/nova/+bug/1946339 you might be interested in this | 08:50 |
| gibi | looking | 08:54 |
| gibi | lyarwood: thanks,yes, that is one of the recently added test case | 08:56 |
| gibi | lyarwood: is it high frequency? | 08:56 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | 09:06 |
| lyarwood | gibi: sorry not looked at the frequency, just saw one hit and raised the bug | 09:17 |
| gibi | lyarwood: ack, I will check it | 09:17 |
| gibi | I need to juggle multiple things right now downstream so it will take a bit of time to get to it | 09:18 |
| lyarwood | ack np | 09:20 |
| stephenfin | now that we've forked, any chance we could get these in nice and early? https://review.opendev.org/c/openstack/nova/+/810291 | 09:42 |
| gibi | stephenfin: I want them, I just need to find the time to review them :/ | 09:44 |
| gibi | (there is an ongoing discussion to upgrade a mitaka cloud to victoria downstream in a single step and that discussion is killing meg right now) | 09:45 |
| opendevreview | Lee Yarwood proposed openstack/nova master: compute: Update volume_id within connection_info during swap_volume https://review.opendev.org/c/openstack/nova/+/807025 | 09:46 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fup: Move _wait_for_volume_{attach,detach} to os-volume_attachments https://review.opendev.org/c/openstack/nova/+/810775 | 09:46 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fup: Refactor and simplify Cinder fixture GET volume mock https://review.opendev.org/c/openstack/nova/+/810776 | 09:46 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | 10:11 |
| opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Move live migration jobs back to voting https://review.opendev.org/c/openstack/nova/+/812392 | 10:22 |
| opendevreview | Lee Yarwood proposed openstack/nova master: Revert "zuul: Skip block migration with attached volumes tests due to bug #1931702" https://review.opendev.org/c/openstack/nova/+/812473 | 10:22 |
| lyarwood | ^ also needs the stable/xena backport of my devstack fix to allow grenade to work /o\ | 10:22 |
| opendevreview | sean mooney proposed openstack/nova master: Add autopep8 to tox and pre-commit https://review.opendev.org/c/openstack/nova/+/806182 | 10:42 |
| sean-k-mooney | i hope people will be open to ^ | 10:42 |
| sean-k-mooney | well this is new "flake8.exceptions.PluginRequestedUnknownParameters: "pycodestyle" requested unknown parameters causing 'FileProcessor' object has no attribute 'indent_size'" | 10:57 |
| sean-k-mooney | ah ok that with my patch im not capping the deps when installing autopep8 | 10:59 |
| sean-k-mooney | hum no thats not the issue | 11:01 |
| noonedeadpunk | sean-k-mooney: hey! regarding https://review.opendev.org/c/openstack/nova/+/811947 - setting lower would require adjusting a lot of existing unit tests because all of them have assumption about mac being in upper case | 11:17 |
| noonedeadpunk | Having that in mind - should I still convert it to lower()? | 11:17 |
| noonedeadpunk | Because what I didn't want to do - to change tests to fit my change :) | 11:18 |
| noonedeadpunk | But if you think it's fine - no problems | 11:18 |
| sean-k-mooney | i kind of dont like sprinkeling random upper and lower cases converstion in the code in general and would prefer to have normalise utility function that is used consitently | 11:20 |
| sean-k-mooney | i would prefer to have it normalise to lower case but i think your bug is just a sincel case of thsi | 11:21 |
| sean-k-mooney | i think there could be other places that woudl still break | 11:21 |
| sean-k-mooney | noonedeadpunk: with that said i also think this is a neuton bug | 11:24 |
| sean-k-mooney | i think neutron should be normalising this internally themselves | 11:24 |
| noonedeadpunk | Well... Maybe it should, but, we take xml from libvirt and from neutron api. So these are 2 different sources of truth nova takes info from. And current assumption that they shoudl be equal | 11:26 |
| sean-k-mooney | correct | 11:27 |
| sean-k-mooney | a mac is justa 48bit int | 11:27 |
| noonedeadpunk | Also, that patch is pretty much simple and backportable | 11:27 |
| sean-k-mooney | its not a strirng so we shoudl not be doing a case sensitive comparison | 11:27 |
| noonedeadpunk | While fixing neutron will require db migrations | 11:27 |
| sean-k-mooney | that or a conversion on load and normalisation in store | 11:28 |
| sean-k-mooney | but ya we can normalise in nova but i think neutron should also fix this themseleves | 11:28 |
| noonedeadpunk | I don't disagree here :) | 11:29 |
| sean-k-mooney | at the end of the day it does not really matter which way we go but lower case is my prefernce we can see what other think in general your patch looks fine | 11:30 |
| noonedeadpunk | yeah, it was mine as well:) but I'd need to fix all other unit tests if change that to lower case | 11:31 |
| sean-k-mooney | this is really an internal fix in the nova side so i dont think you need a release note but that is the only other thing i was thinking of | 11:31 |
| sean-k-mooney | noonedeadpunk: yep i done see any issue with fixing the unit tests other then time | 11:31 |
| sean-k-mooney | i would guess there is a mix of case already | 11:32 |
| sean-k-mooney | yep https://github.com/openstack/nova/blob/8d9785b965657d42f20e1ad7234f570077a387d7/nova/tests/unit/virt/libvirt/test_vif.py#L81 | 11:32 |
| noonedeadpunk | well, I was also unsure if I haven't break anything else accidentally:) so with current change log I was more sure about zero impact on current functionality | 11:33 |
| sean-k-mooney | im prettty sure i have always used lower case in our tests | 11:33 |
| noonedeadpunk | ah, well, so it's more test_migration thing I guess | 11:34 |
| sean-k-mooney | what im more concerneed about is https://github.com/openstack/nova/blob/66574018b517f14dc26e581d0ddaa7788806f83e/nova/objects/virtual_interface.py#L44 | 11:36 |
| sean-k-mooney | and other place we store the adress in our code | 11:36 |
| sean-k-mooney | i had alway assumed that neutron was already normalising | 11:36 |
| * bauzas disappears until 1300UTC (dentist appointment) | 11:37 | |
| sean-k-mooney | noonedeadpunk: when we lookup pci device mac adress we do not normalise there currently either | 11:39 |
| sean-k-mooney | https://github.com/openstack/nova/blob/66574018b517f14dc26e581d0ddaa7788806f83e/nova/pci/utils.py#L173-L191 | 11:39 |
| sean-k-mooney | we just take the value form /sys which should be lower case | 11:39 |
| sean-k-mooney | sean@p50:~/repos/nova$ cat /sys/class/net/enp0s31f6/address | 11:40 |
| sean-k-mooney | 8c:16:45:81:48:b5 | 11:40 |
| sean-k-mooney | for the unique constraint in the db for the virtual interfaces table we are also useing the mac un normalised | 11:41 |
| sean-k-mooney | https://github.com/openstack/nova/blob/66574018b517f14dc26e581d0ddaa7788806f83e/nova/network/neutron.py#L1307-L1308 | 11:41 |
| sean-k-mooney | noonedeadpunk: likely we should just fix your inital case in this patch but we should think about the other cases at some point | 11:42 |
| noonedeadpunk | well neutron is not normalazing https://paste.opendev.org/show/809839/ | 11:43 |
| sean-k-mooney | yep that would appear to be the case | 11:43 |
| sean-k-mooney | whcih mean sif you were ever to change the mac on the neutron port it could break things in nova unless we propagate that update in some cases | 11:44 |
| noonedeadpunk | actually I thought that in domain xml mac is also stored non-normalized | 11:44 |
| noonedeadpunk | And I saw that issue first when was live-migrating instances from bionic to focal computes | 11:45 |
| sean-k-mooney | libvirt normalises the xml we provide so the one we provide is not the one that it actully uses | 11:45 |
| sean-k-mooney | so we likely dont normalise it when we give it to libvirt | 11:45 |
| noonedeadpunk | was it always like that ? | 11:45 |
| sean-k-mooney | yep | 11:46 |
| noonedeadpunk | huh, okay then. Wondering why it's haven't been spotted before then... | 11:46 |
| sean-k-mooney | the xml you see with virsh dumpxml is not the one that nova provided | 11:46 |
| sean-k-mooney | well neutron default to lower case | 11:46 |
| noonedeadpunk | Yeah, that's what I saw as well | 11:46 |
| sean-k-mooney | so unless you provdided a mac it wont be an issue | 11:46 |
| noonedeadpunk | yeah, maybe we saw that because we were doing really mass migrations of all vms in our deployments... | 11:47 |
| sean-k-mooney | so i think this is only an issue for user provided macs | 11:47 |
| noonedeadpunk | yeah, indeed | 11:47 |
| noonedeadpunk | Ok, so then I will change that to lower() | 11:47 |
| sean-k-mooney | if the test fallout of that is no horrific then yes please do | 11:48 |
| sean-k-mooney | i suspect it will not be that bad | 11:49 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | 12:22 |
| noonedeadpunk | yeah you was right, it's not bad at all) | 12:22 |
| * bauzas 's back | 12:42 | |
| opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | 13:48 |
| bauzas | gibi: sean-k-mooney: shit, I remember we need to move the merged specs into implemented https://specs.openstack.org/openstack/nova-specs/specs/xena/ | 15:08 |
| gibi | bauzas: yeah, we tend to forget that | 15:09 |
| * gibi just back from the openinfra live event | 15:09 | |
| bauzas | gibi: I can do it | 15:09 |
| gibi | there is script for that | 15:09 |
| gibi | thans | 15:09 |
| gibi | thanks | 15:09 |
| lyarwood | bauzas: https://review.opendev.org/c/x/gerrit-dash-creator/+/813050 | 16:21 |
| bauzas | gibi: oh, I wasn't knowing | 16:25 |
| melwitt | bauzas: there's some instructions here too https://docs.openstack.org/nova/latest/contributor/ptl-guide.html | 16:27 |
| bauzas | melwitt: /me facepalms | 16:28 |
| lyarwood | https://review.opendev.org/c/openstack/nova/+/812392 - bauzas / gibi / melwitt ; this should be good now the stable/xena devstack change is in the gate | 16:29 |
| bauzas | I have this link open as a tab since a month and I forgot about this | 16:29 |
| melwitt | :) | 16:29 |
| *** ralonsoh_ is now known as ralonsoh | 16:35 | |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Move Xena implemented specs https://review.opendev.org/c/openstack/nova-specs/+/813051 | 16:44 |
| bauzas | gibi: melwitt: there there ^ | 16:45 |
| * bauzas ends on this for the day | 16:52 | |
| melwitt | bauzas: I just remembered you'll want to do the placement repo too. have to do it manually afaik, placement doesn't use launchpad https://docs.openstack.org/placement/latest/specs/index.html#xena they are located under placement/doc/source/specs/ | 16:53 |
| melwitt | gmann: in case you didn't see my comment on https://review.opendev.org/c/openstack/devstack/+/812092 I think stable/train is also broken in the same way cc elodilles | 16:56 |
| gmann | melwitt: checking, stable/train still run tempest master so it should be ok. | 16:57 |
| melwitt | gmann: oh, so my patch has jsonschema fail bc of the stable/stein side of grenade /facepalm ok I understand now | 16:59 |
| gmann | melwitt: yeah, once stable/stein patch is merged then we can recheck or, we can make depends-on just to be sure | 16:59 |
| melwitt | yeah I see. I'm writing up a comment about the novnc issue. I don't understand why it's happening though so can't fix it yet :( | 17:00 |
| gmann | thanks, I will try to dig into that next week or so. | 17:01 |
| elodilles | melwitt: thanks for the heads up, i will also add this to my TODO list and try to debug it :S | 17:03 |
| melwitt | elodilles: to correct myself it's stable/stein that needs a fix but it's failing for a novnc issue that I don't understand how is happening. I'm writing a comment for gmann's patch ^ with what I found so far | 17:04 |
| elodilles | melwitt: ack, thanks! | 17:13 |
| melwitt | gmann: just a fyi, I think I finally figured out why the tempest 20.0.0 patch failed on stable/stein https://review.opendev.org/c/openstack/devstack/+/812092/1#message-348d913f2bbcf909533d62c3cb4e02d6a0100664 cc elodilles | 18:54 |
| gmann | melwitt: ah thanks, let me try 24.0.0 which should work as it has old jsonschema in requirement filr https://github.com/openstack/tempest/blob/24.0.0/requirements.txt#L6 | 22:21 |
| gmann | oh, you already updated, great | 22:22 |
| melwitt | gmann: I already updated your patch, I hope you don't mind. I did not update the commit message or code comment yet as it's just for testing. if it works well, we can update the writings | 22:22 |
| gmann | melwitt: +1. | 22:23 |
| opendevreview | Merged openstack/nova master: zuul: Move live migration jobs back to voting https://review.opendev.org/c/openstack/nova/+/812392 | 22:27 |
| melwitt | gmann: the novnc problem went away but we have a new problem now on the minimum basic scenario test image create: FileNotFoundError: [Errno 2] No such file or directory: '/opt/stack/new/devstack/files/images/cirros-0.3.1-x86_64-uec/cirros-0.3.1-x86_64-vmlinuz' | 22:37 |
| gmann | checking | 22:37 |
| gmann | may be that is because we change the configuration of image location in tempest and devstack for tempest 25.0.0, let me check the patch which we can revert. | 22:38 |
| gmann | melwitt: this one. we did backport it to stable/stein as tempest 26.0.0 was used there and img location changes done in tempest 25.0.0 but now as we have to use tempest 24.0.0 in stable/stein we should revert it https://review.opendev.org/c/openstack/devstack/+/770839 | 22:40 |
| melwitt | oh I see | 22:41 |
| gmann | let me do revert and squash the both | 22:42 |
| melwitt | kk | 22:43 |
| opendevreview | melanie witt proposed openstack/nova master: Make the CellDatabases fixture work with fasteners >= 0.15 https://review.opendev.org/c/openstack/nova/+/813114 | 23:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!