Thursday, 2021-09-02

opendevreviewmelanie witt proposed openstack/placement master: Add reproducer for Project creation race bug  https://review.opendev.org/c/openstack/placement/+/80673002:50
opendevreviewmelanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction  https://review.opendev.org/c/openstack/placement/+/80701402:50
*** akekane__ is now known as abhishekk05:54
opendevreviewKevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform  https://review.opendev.org/c/openstack/nova/+/76392806:14
opendevreviewMaAoyu proposed openstack/nova master: swap multiattach volume, report an error VolumeNotFound  https://review.opendev.org/c/openstack/nova/+/80702506:21
gibio/07:54
gibithe Asia friendly nova meeting starts in 5 minutes here in the channel07:55
gibi#startmeeting nova_extra08:00
opendevmeetMeeting started Thu Sep  2 08:00:38 2021 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.08:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.08:00
opendevmeetThe meeting name has been set to 'nova_extra'08:00
gibiwho we have here to day for the meeting?08:00
gibinobody?08:05
gibinot even bauzas? ;)08:05
* gibi feels alone08:05
lyarwood\o08:07
lyarwoodsorry 08:07
lyarwoodhas anyone from Asia actually joined this meeting recently?08:07
gibilyarwood: thanks, it is better now :)08:07
gibilyarwood: no. on the first occasion there was somebody telling us that the devs in his/her team will join next time08:08
gibithen nothing08:08
lyarwood^_^08:08
gibiso it is a huuuge success08:08
lyarwoodsomething to discuss at the PTG08:08
gibiadding a topic ...08:08
bauzas\o08:09
* bauzas waves late as his daughter was going for the first time to high school :cry:08:09
gibiohh08:09
gibiI accept your excuse :)08:10
gibiOK, I'm closing this08:12
gibi#endmeeting08:12
opendevmeetMeeting ended Thu Sep  2 08:12:14 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)08:12
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-09-02-08.00.html08:12
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-09-02-08.00.txt08:12
opendevmeetLog:            https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-09-02-08.00.log.html08:12
bauzasyeah, actually I made a mistake, this is middle school 08:12
lyarwooddid you drop her at the wrong school?! ;D08:13
bauzaslyarwood: man, don't make me wish Bonaparte ruled your country or we could have had the same teaching system08:14
lyarwoodwe actually have middle schools in parts of the country, I don't recall why tbh08:14
bauzaswe call it "college" but weirdly enough, your colleges are for post-graduate kids08:15
lyarwoodbut not in the area I grew up in08:15
lyarwoodyeah college here is 16-1808:15
lyarwoodthen unit08:15
lyarwooduni*08:15
gibiit is complicated08:16
bauzasanyway, she's changing from a classic single teacher with one program to multiple teachers with different programs and options08:16
lyarwoodyeah that's a big step, hope it goes well :)08:16
bauzaswe'll see :p08:17
bauzas(and fwiw, I was kidding for Bonaparte, I'm maybe one of the few French who consider it as a dictator)08:17
lyarwoodI always berate my family about my first day at high school, thanks to my surname I was the last kid to be called forward out of ~250 in the year, honestly thought I was at the wrong school.08:18
lyarwoodFinal name in the final set (class), horrid way to start lol.08:19
bauzashah08:20
bauzasI alwayts hated my surname because I was having no extra time for arriving compared to my other friends08:20
lyarwood^_^08:21
lyarwoodYeah I guess that part was always useful08:21
kashyaplyarwood: That's quite some etched memory about your first day at school :)08:22
lyarwoods/etched/chiseled/g08:22
kashyapHaha08:22
gibibeing at the end of the name list would have other advanteges at least here. We had a big book with the stundents in the class ordered by surname containing basic information and the grades and marks for the student. And teachers tend to use this book to randomly generate a student for oral exam / quiz at the beginning of a class. But humans are bad at randomly opening book...08:32
gibipeople in the middle of the book got selected a lot more than the first and the last person08:33
gibiand here in Hungary the primary and middle school are basically a single school, then we have high scool and then university08:35
opendevreviewmelanie witt proposed openstack/placement master: Add reproducer for Project creation race bug  https://review.opendev.org/c/openstack/placement/+/80673008:45
opendevreviewmelanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction  https://review.opendev.org/c/openstack/placement/+/80701408:45
melwittgibi: sorry for updating your test ^, I got carried away. feel free to revert it if desired. also not sure the fix approach is the best one but I couldn't think of anything better08:48
gibiadd a topic on the ptg retrospective about the asia friendly meeting slot https://etherpad.opendev.org/p/nova-yoga-ptg L60 now08:48
gibimelwitt: ack, I will check 08:48
gibithanks for working on it08:49
melwitttl;dr is I removed the helper method that was being called and thought "oh maybe we can test this higher up the stack" and then I got into the weeds08:49
melwittno thanks needed. I'm sorry consumer types has been a pain08:50
gibimelwitt: don't be hard on yourself 09:08
bauzassean-k-mooney: just in case you haven't seen my -1 for a doc nit https://review.opendev.org/c/openstack/nova/+/792362/609:15
stephenfinlyarwood: Can we get a release note for this? https://review.opendev.org/c/openstack/python-openstackclient/+/80437709:27
lyarwoodack I'll  respin shortly09:29
opendevreviewStephen Finucane proposed openstack/python-novaclient master: tests: Add missing 'nova update' unit tests  https://review.opendev.org/c/openstack/python-novaclient/+/80691610:02
opendevreviewStephen Finucane proposed openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames  https://review.opendev.org/c/openstack/python-novaclient/+/80691710:02
opendevreviewStephen Finucane proposed openstack/python-novaclient master: trivial: Remove use of kwargs  https://review.opendev.org/c/openstack/python-novaclient/+/80691810:02
stephenfingibi: lyarwood: Could we merge this ancient release notes patch? I still think the information contained within is useful https://review.opendev.org/c/openstack/nova/+/70566710:09
gibistephenfin: is it impacting an old release's reno?10:15
gibidoes the tooling handle that properly or it will show up in our Xena renos?10:15
stephenfinnope, it'll just update the previous release note10:16
gibicool10:16
gibithen I will +2 shortly10:16
stephenfin(the release note's "location" is determined by the initial commit)10:16
gibigthiemonge: hi! mellwit proposed a fix for the placement issue you reported on Tuesday https://review.opendev.org/c/openstack/placement/+/807014 Would it be possible to trigger octavia jobs with a commit that depends-on the fix? 10:19
gthiemongegibi: oh cool! yes, I'll trigger it!10:20
gibigthiemonge: let us know how it looks10:21
gibiand thanks10:21
stephenfingibi: Oh, I also need eyes on https://review.opendev.org/c/openstack/nova/+/705666/ too, since it's below the release note change, please + thank you :)10:22
stephenfinI have a series to remove all that crud but I haven't rebased it in a while :-(10:22
gthiemongegibi: melwitt: thanks10:22
gibistephenfin: looking10:22
stephenfinty10:24
* gibi goes grab lunch and then look at the open client patches10:25
lyarwoodstephenfin: I'll have to look this afternoon sorry, getting sucked in by a downstream thing10:25
opendevreviewsean mooney proposed openstack/nova master: docs: Document virtio-net multiqueue  https://review.opendev.org/c/openstack/nova/+/79236210:37
opendevreviewsean mooney proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware  https://review.opendev.org/c/openstack/nova/+/79236410:37
sean-k-mooneybauzas: done ^10:37
opendevreviewStephen Finucane proposed openstack/nova master: neutron: Rework how we check for extensions  https://review.opendev.org/c/openstack/nova/+/70579211:11
opendevreviewStephen Finucane proposed openstack/nova master: neutron: Remove references to dead 'qos-queue' extension  https://review.opendev.org/c/openstack/nova/+/75444811:11
stephenfinsean-k-mooney: Left comments on that patch ^ fwict, the changes you've made aren't complete. I'd suggest reverting back to the previous version and instead inserting a preceding patch to change the base exception for FlavorImageConflict instead11:24
stephenfinI can do that if you're swamped, given today is feature freeze (?)11:25
sean-k-mooneystephenfin: if you want to go for it11:29
sean-k-mooneyi havent fully pasrced what you wrote11:30
sean-k-mooneyare you concerned about the other places you have used that11:30
sean-k-mooneyi noticed you did not add that excption in the first patch11:30
sean-k-mooneyunless i missed it11:30
stephenfinI'm concerned about the other places _others_ have used it11:31
sean-k-mooneyah ok ya i tought about that but didnt have a chance to look11:31
sean-k-mooneystephenfin: you could also just make that a follow up change that change the base code11:32
opendevreviewStephen Finucane proposed openstack/nova master: Add 'hw:vif_multiqueue_enabled' flavor extra spec  https://review.opendev.org/c/openstack/nova/+/79235611:48
opendevreviewStephen Finucane proposed openstack/nova master: docs: Document virtio-net multiqueue  https://review.opendev.org/c/openstack/nova/+/79236211:48
opendevreviewStephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware  https://review.opendev.org/c/openstack/nova/+/79236411:48
stephenfinsean-k-mooney: Okay, new comments left. I've respin it to drop that code setting on the back of said comments. Let me know if I missed anything obvious11:48
sean-k-mooneystephenfin: so https://github.com/openstack/nova/blob/75f719e0/nova/api/openstack/compute/servers.py#L854-L855 will still change the code form a 403 to a 400 right11:48
sean-k-mooneyso that is still not correct?11:49
stephenfinIt will result in a HTTP 400. Where are you getting HTTP 403 from?11:49
sean-k-mooneythe orginial expciton inherited form forbiden11:49
sean-k-mooneywhich returned a 40311:49
stephenfinwhich original exception?11:49
sean-k-mooneythis one11:51
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/792364/8/nova/exception.py11:51
sean-k-mooneyin the followup11:51
stephenfinsean-k-mooney: that's a different review11:51
sean-k-mooneyyes11:51
sean-k-mooneyhum11:51
stephenfinohhhhh11:51
sean-k-mooneyok its also in INVALID_FLAVOR_IMAGE_EXCEPTIONS11:51
sean-k-mooneyso it was getting converted too11:52
sean-k-mooneyok it should be good11:52
stephenfinso because we were introducing this new helper in that change, you suggested changing it there11:52
stephenfinthat was not at all obvious :-D context, lad11:52
stephenfinanyway, yeah, it was all getting translated to HTTP 400 in the end11:52
stephenfinand even if it wasn't, this would be an okay change IMO11:52
sean-k-mooneyto a 40011:53
sean-k-mooneyyes to a 500 no11:53
stephenfinyup, fair11:53
sean-k-mooneyanyway ok it should be good again11:53
stephenfinyup, should be11:53
sean-k-mooneyand no i was chaning the code in hte bottom change becasue i tought it was not being caught there11:54
stephenfingotcha11:55
sean-k-mooneywe have a top level excption handeler above that that catuche anything that inherits form NovaException11:55
sean-k-mooneythat is not caught else whwere i tought we were going all the way to that11:56
stephenfinThe whole nova.exception module needs a rework to either double down on exception inheritance or remove it entirely. It's all very confusing. That rework would be seriously tedious though and I doubt anyone sane will want to do it :)11:56
sean-k-mooneyya espcially since we marshal between them in a few places too11:57
stephenfinyup11:57
opendevreviewBalazs Gibizer proposed openstack/nova master: Add --sleep option for archive_deleted_rows --until-complete  https://review.opendev.org/c/openstack/nova/+/77174911:57
kashyapsean-k-mooney: Heya, are you able to tell what's off with this negative test (only remaining failure from the CI for me)  - It passed when I posted the patch locally; https://cpaste.org/?e49aa4ae738ca284#5xdtN3VCgvzp3P5fFPXDmYJ8gYxVRQvuGaKyfxsRjYfb12:10
sean-k-mooneydo you have a link to the review12:11
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/794796?12:12
kashyapYep12:12
kashyapSorry, was just about to fetch it12:12
sean-k-mooneysimple12:12
sean-k-mooney1.30 is not less then 1.30 https://review.opendev.org/c/openstack/nova/+/794796/3/nova/objects/image_meta.py#19012:12
kashyap(I fixed the trivial notification object part; so ignore that test, pls)12:12
sean-k-mooneyso     self.assertRaises(exception.ObjectActionError,12:12
sean-k-mooney                                   obj.obj_to_primitive, '1.30')12:13
sean-k-mooneyshoudl ne '1.29'12:13
kashyapsean-k-mooney: Urgh, <embarassed> :D12:13
kashyapsean-k-mooney: Thanks!12:14
sean-k-mooneyThere are two hard things in computer science: cache invalidation, naming things, and off-by-one errors.12:15
kashyapsean-k-mooney: LOL12:15
opendevreviewMerged openstack/nova master: workarounds: Remove rbd_volume_local_attach  https://review.opendev.org/c/openstack/nova/+/80564812:16
opendevreviewFederico Ressi proposed openstack/nova master: [WIP] Debug APIs call failures  https://review.opendev.org/c/openstack/nova/+/80668312:18
opendevreviewFederico Ressi proposed openstack/nova master: Debug Nova APIs call failures  https://review.opendev.org/c/openstack/nova/+/80668312:18
opendevreviewFederico Ressi proposed openstack/nova master: [WIP] Check Nova project changes with tobiko scenario test cases  https://review.opendev.org/c/openstack/nova/+/80685312:27
opendevreviewFederico Ressi proposed openstack/nova master: Check Nova project changes with Tobiko scenario test cases  https://review.opendev.org/c/openstack/nova/+/80685312:31
opendevreviewKashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option  https://review.opendev.org/c/openstack/nova/+/79479612:40
gibisean-k-mooney: :D12:51
opendevreviewTakashi Natsume proposed openstack/nova master: Update compute rpc version alias for xena  https://review.opendev.org/c/openstack/nova/+/80713713:13
kashyapsean-k-mooney: Oh, duh.  In my revision I missed the extra test that stephenfin asked above.  Adding that too13:20
opendevreviewKevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform  https://review.opendev.org/c/openstack/nova/+/76392813:50
opendevreviewKashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option  https://review.opendev.org/c/openstack/nova/+/79479614:00
kashyapstephenfin: Fixed --^ That should address all you asked for.  Let me know if I missed anything.  And thanks for the review.14:00
opendevreviewBalazs Gibizer proposed openstack/placement master: Reproduce 404 when allocation queried with 1.38  https://review.opendev.org/c/openstack/placement/+/80715414:04
opendevreviewBalazs Gibizer proposed openstack/placement master: Fix adding 'unknown' to the ConsumerTypeCache  https://review.opendev.org/c/openstack/placement/+/80715514:04
gibilyarwood, stephenfin, bauzas: can I get a second set of eyes on https://review.opendev.org/c/openstack/osc-placement/+/804458 (consumer_types osc-placement client support)14:14
bauzasgibi: doing it now14:15
gibithanks you14:17
kashyapgibi: WHen you get 20 minutes, mind have a look at this? - https://review.opendev.org/c/openstack/nova/+/76392814:24
opendevreviewMerged openstack/osc-placement master: Add support for microversion 1.38 consumer types  https://review.opendev.org/c/openstack/osc-placement/+/80445814:31
gibikashyap: are you OK with that patch?14:49
kashyapgibi: 80%; I just want to do a real migration test w/ that patch - that gives me more peace of mind.  (I wanted to split it up for better reviewability but just couldn't get around to it.)15:01
kashyapgibi: How about this:15:02
gibikashyap: I have no problem with the patch, as far as see it is specialized to arm64 so we cannot broke our main deployers with it :)15:03
kashyapgibi: I'll setup a local env to do a bunch more tests on KVM (our CI tests only QEMU)15:03
kashyapgibi: Oh, wait15:03
kashyapgibi: I gave you the wrong patch; damn15:03
gibior you linked me something else :D15:03
kashyapgibi: Yeah, grrrr me.15:03
gibino worries15:03
kashyapI meant this chunky one (hence the "20 minutes") - https://review.opendev.org/c/openstack/nova/+/76392815:03
kashyapFeel free to say: "no, that is too much review at this point".  15:04
kashyapBut I can answer any questions about that patch.15:04
kashyapgibi: Incidentally, the commit message from the patch author is a verbatim copy/paste of what I wrote in one of the reviews :D15:04
gibi:)15:05
gibiyou linked the wrong patch again https://review.opendev.org/c/openstack/nova/+/76392815:05
kashyapgibi: The short summary is - this patch will be replacing the two older libvirt CPU APIs that are now causing more problems in the new world of hardware CVE flaws15:05
kashyapgibi: Gah, sorry, this one - https://review.opendev.org/c/openstack/nova/+/762330/15:06
kashyap"libvirt: Use improved guest CPU config APIs"15:06
gibiok that is chunky indeed :) 15:06
kashyapgibi: It's a chunky one.  Actually, this hour is not good to review it.  And will only make you grumpy, I'm afraid 15:06
gibiI will try and lets see how far I can get15:07
kashyapgibi: I can split it up, if you like.  (That's also the right thing in my view, and told that on the review a few times)15:07
kashyap(And also in the original spec I wrote)15:07
kashyapgibi: I'll copy/paste from my notes, the "outline" of the patch:15:09
kashyap- libvirt: Introduce compare_hypervisor_cpu() method15:09
kashyap- libvirt: Introduce baseline_hypervisor_cpu() method15:09
kashyap- Rework _get_guest_cpu_model_config() method to take advantage of the new CPU APIs15:09
kashyap- Update the get_capabilities() method to make use of baseline_hypervisor_cpu()15:09
kashyap- Update the check_can_live_migrate_destination() method to use compare_hypervisor_cpu()15:09
gibithanks15:10
melwittgibi: thank you for reviewing my patch. I'm going to try a simpler fix and try to restore the original func test. if it works, I think reviewers might like it more15:38
bauzasmelwitt: you're on my plate15:38
bauzasbut I've seen gibi's concerns so I held a bit15:39
melwittbauzas: yes thank you for your review too, I'm going to try a simpler approach bc as you said the current patch looks pretty hacky15:39
gibimelwitt: I have no problem with the logic of the current fix. Just had some nits about docs15:40
gibimelwitt: but sure, if you have a simpler solution then I'm happy to review that too later15:40
melwittgibi: understood. I worry that it's too confusing15:40
melwitt(for maintainability)15:41
gibiOK15:41
gibibtw, there is another small fix targeting consumer_types here https://review.opendev.org/c/openstack/placement/+/80715515:42
gibibut I think there will not be conflicts15:42
melwittgibi: thanks for figuring that out, I will review15:43
gibino problem15:44
opendevreviewMerged openstack/python-novaclient master: tests: Add missing 'nova update' unit tests  https://review.opendev.org/c/openstack/python-novaclient/+/80691615:44
opendevreviewMerged openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames  https://review.opendev.org/c/openstack/python-novaclient/+/80691715:50
gibikashyap: timed out on reading https://review.opendev.org/c/openstack/nova/+/762330, I left some comments / questions inline. 16:06
gibibut I haven't read the driver part yet16:06
* gibi goes updating python-novaclient release patch and the cyclehighlights16:07
gibiall - please review the cycle highlights and lt me know if anything is wrong or missing https://review.opendev.org/c/openstack/releases/+/80075516:29
gibiending my day. see you tomorrow o/16:30
opendevreviewStephen Finucane proposed openstack/nova master: Allow 'bochs' as a display device option  https://review.opendev.org/c/openstack/nova/+/79479616:46
sean-k-mooneyok i think im going to call it a day o/17:59
opendevreviewMerged openstack/nova master: Add two new hacking rules  https://review.opendev.org/c/openstack/nova/+/80566819:03
opendevreviewMerged openstack/nova master: Support interface attach / detach with new resource request format  https://review.opendev.org/c/openstack/nova/+/80008919:03
opendevreviewMerged openstack/nova master: [func test] move unshelve test to the proper place  https://review.opendev.org/c/openstack/nova/+/79362119:04
opendevreviewMerged openstack/nova master: Update compute rpc version alias for xena  https://review.opendev.org/c/openstack/nova/+/80713720:15
opendevreviewmelanie witt proposed openstack/placement master: Add reproducer for Project creation race bug  https://review.opendev.org/c/openstack/placement/+/80673020:18
opendevreviewmelanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction  https://review.opendev.org/c/openstack/placement/+/80701420:18
melwittgibi, bauzas: I rewrote the func tests and gibi I think I addressed all of your comments on the fix patch. I decided to just stay with the current approach, keeping the transaction as small as possible is likely most important20:24
*** bnemec is now known as bnemec-pto21:45
opendevreviewmelanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction  https://review.opendev.org/c/openstack/placement/+/80701422:10
opendevreviewFederico Ressi proposed openstack/nova master: Debug Nova APIs call failures  https://review.opendev.org/c/openstack/nova/+/80668322:18
opendevreviewFederico Ressi proposed openstack/nova master: Check Nova project changes with Tobiko scenario test cases  https://review.opendev.org/c/openstack/nova/+/80685322:21

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!