| opendevreview | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/c/openstack/nova/+/749052 | 02:38 |
|---|---|---|
| *** efried1 is now known as efried | 06:09 | |
| *** akekane_ is now known as abhishekk | 06:46 | |
| opendevreview | Merged openstack/nova master: fup: Move _migrate_stub into LibvirtMigrationMixin https://review.opendev.org/c/openstack/nova/+/804232 | 07:26 |
| *** rpittau|afk is now known as rpittau | 07:51 | |
| gibi | stephenfin: hi! I had to rebase the pps series as cyborg smartnic support landed in the meantime causing conflicts. If you have time then re-review would be appreciated | 08:39 |
| gibi | lyarwood: I know that it is a big thing to ask but I would need a second core on the pps series. I'm happy to trade reviews on anything | 08:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid unbound instance_uuid var during delete https://review.opendev.org/c/openstack/nova/+/805605 | 09:01 |
| qiujunting_ | sean-k-mooney | 10:11 |
| qiujunting_ | sean:https://review.opendev.org/c/openstack/nova/+/802225/1/nova/compute/manager.py#5615 this should be done in prep_resize, but in the spec, Copy the PMEM data from old PMEM device to new PMEM device at migtate_disk_and_power_off. https://review.opendev.org/c/openstack/nova-specs/+/785563/14/specs/xena/approved/allow-migrate-pmem-data.rst#65 | 10:15 |
| lyarwood | gibi: of course, sorry just back online, got held up coming back from a weekend away because of $baby. | 11:03 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Drop references to non-filter scheduler drivers https://review.opendev.org/c/openstack/nova/+/773645 | 11:06 |
| opendevreview | Stephen Finucane proposed openstack/nova master: scheduler: Merge driver into manager https://review.opendev.org/c/openstack/nova/+/773644 | 11:06 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_utils', 'test_scheduler_utils' https://review.opendev.org/c/openstack/nova/+/773646 | 11:06 |
| opendevreview | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated aliases https://review.opendev.org/c/openstack/nova/+/773647 | 11:06 |
| gibi | lyarwood: hi. no worries and thanks | 11:06 |
| opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | 11:39 |
| *** tbachman is now known as Guest5151 | 12:12 | |
| opendevreview | sean mooney proposed openstack/os-vif master: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/805625 | 12:25 |
| opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | 12:37 |
| opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | 12:54 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805628 | 12:55 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805629 | 12:55 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805630 | 12:55 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/train: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805631 | 13:01 |
| sean-k-mooney | gibi: can you take a look at https://review.opendev.org/c/openstack/project-config/+/787523/ for the review priorty lable | 13:22 |
| sean-k-mooney | i think that should implement it correctly now if you want any changes let me know | 13:23 |
| sean-k-mooney | sorry to have put that off for so long but it would be nice to have it working before we hit FF so we can use it for FF and RC issues | 13:23 |
| gibi | sean-k-mooney: thanks for working on that I left feedback | 13:29 |
| gibi | I agree that we should try to use that | 13:30 |
| gibi | for the incoming FF | 13:31 |
| sean-k-mooney | ack you suggestions make sense let me update it quickly | 13:31 |
| gibi | ok | 13:32 |
| sean-k-mooney | ok that should do it https://review.opendev.org/c/openstack/project-config/+/787523 | 13:35 |
| opendevreview | Vadym Markov proposed openstack/nova master: Fix for concurrent DB update issue https://review.opendev.org/c/openstack/nova/+/804985 | 13:38 |
| opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Remove disable_native_luksv1 https://review.opendev.org/c/openstack/nova/+/805647 | 14:02 |
| opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Remove rbd_volume_local_attach https://review.opendev.org/c/openstack/nova/+/805648 | 14:03 |
| fungi | melwitt: gibi: someone commented on https://launchpad.net/bugs/1927677 (OSSA-2021-002, CVE-2021-3654) that the fix is incomplete... any chance you have time to take a closer look and reopen the bug if so? | 14:04 |
| opendevreview | Ilya Popov proposed openstack/nova master: Fix to use cell with more free memory first https://review.opendev.org/c/openstack/nova/+/805649 | 14:07 |
| gibi | fungi: ack | 14:08 |
| gibi | fungi, melwitt: I can look at it tomorrow so melwitt if you have time still today then feel free to check it out | 14:09 |
| fungi | i don't know that it's urgent, just didn't want it to slip through the cracks as it's comments on a closed bug | 14:14 |
| fungi | but thanks! | 14:14 |
| gibi | fungi: thanks for the headsup it would not notice it otherwise | 14:15 |
| fungi | no worries, it's exactly why i continue to monitor comments on presumed fixed vulnerability reports | 14:16 |
| sean-k-mooney | so they are reporting it does not work with 3 slashes | 14:21 |
| sean-k-mooney | but with 2 or more then 4 | 14:22 |
| sean-k-mooney | https://launchpadlibrarian.net/554904339/python3.patch is more general | 14:23 |
| opendevreview | Ilya Popov proposed openstack/nova master: Fix to use cell with more free memory first https://review.opendev.org/c/openstack/nova/+/805649 | 14:23 |
| fungi | sean-k-mooney: yep, hoping someone can test and confirm the assertion that the vulnerability is still exploitable with odd numbers of slashes | 14:24 |
| sean-k-mooney | let me see if we have a func test for this | 14:24 |
| sean-k-mooney | if we do i can try it with 3 slasshes | 14:24 |
| fungi | thanks a bunch | 14:24 |
| fungi | that's a huge help | 14:24 |
| sean-k-mooney | we dont seam to have a func test but we do have a unit test https://review.opendev.org/c/openstack/nova/+/803091 ill see if i can modify that quickly | 14:26 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805628 | 14:29 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805629 | 14:30 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805630 | 14:30 |
| sean-k-mooney | testtools.matchers._impl.MismatchError: 'Error code: 400' not in 'HTTP/1.1 301 Moved Permanently\r\nServer: WebSockify Python/3.8.10\r\nDate: Mon, 23 Aug 2021 14:31:26 GMT\r\nLocation: /example.com/%2F../\r\n\r\n' | 14:31 |
| sean-k-mooney | fungi: ^ so ya that seams to confirm that /// is not blocked | 14:31 |
| sean-k-mooney | ill quickly apply there patch and see if that correct it | 14:32 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/train: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/805631 | 14:33 |
| sean-k-mooney | gibi: fungi there patch seams to work for both cases. shall i submit it to gerrit | 14:34 |
| gibi | sean-k-mooney: yes please | 14:34 |
| gibi | or wait | 14:34 |
| gibi | do we need any special treatment due to this being a secuirty bug? | 14:35 |
| gibi | I guess not but fungi might knows better | 14:35 |
| sean-k-mooney | well its public and the report and patch were submitted in the clear | 14:35 |
| sean-k-mooney | so i think at this point we treat it as a public security bug | 14:35 |
| sean-k-mooney | if the report was made privatly then yes | 14:36 |
| fungi | sean-k-mooney: gibi: no special treatment other than please prioritize reviews and backporting | 14:37 |
| sean-k-mooney | ok give me 2 mins to write a commit message and ill push the new unit test and the fix with the reporter listed as a co author of the patch | 14:37 |
| gibi | sean-k-mooney: ack, I will prioritize the review | 14:38 |
| fungi | or you could git am it | 14:38 |
| fungi | i didn't look to see whether they included sufficient headers (a la git format-patch or similar) | 14:38 |
| fungi | gerrit will allow you to push with any author on the commit, so long as your account is listed as the committer | 14:38 |
| sean-k-mooney | its just https://launchpadlibrarian.net/554904339/python3.patch | 14:38 |
| sean-k-mooney | no commit headers it just a raw patch file | 14:39 |
| sean-k-mooney | not a git commit | 14:39 |
| fungi | yeah, co-authored-by or whatever then | 14:39 |
| fungi | the patch is trivial enough i doubt we need to worry about icla | 14:40 |
| fungi | hopefully melwitt knows if there was some necessary nuance to the other solution we're not spotting | 14:41 |
| fungi | once she's able to review it | 14:42 |
| opendevreview | sean mooney proposed openstack/nova master: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/805654 | 14:48 |
| opendevreview | sean mooney proposed openstack/nova master: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/805654 | 14:52 |
| lyarwood | gibi: thanks for creating https://bugs.launchpad.net/nova/+bug/1940741 - have you had time to look into the race that's causing it? | 14:52 |
| * lyarwood just saw it and was about to dive into your DEBUG logs | 14:53 | |
| gibi | lyarwood: I only have the repro with DEBUG and tried to add sleep before the confirm call but that did not increased the chance of repro | 14:53 |
| lyarwood | `2021-08-23 12:47:50,585 DEBUG [nova.servicegroup.drivers.db] Seems service nova-compute on host src is down. Last heartbeat was 2021-08-23 12:47:45.500309. Elapsed time is 5.084755` what the hell | 14:53 |
| gibi | lyarwood: I'm deep in https://bugs.launchpad.net/nova/+bug/1936849 now so you can take https://bugs.launchpad.net/nova/+bug/1940741 forward | 14:54 |
| lyarwood | ack np | 14:54 |
| gibi | lyarwood: yepp I saw that hence my trial with sleeps | 14:54 |
| gibi | lyarwood: maybe the compute service is busy and cannot do an update in every second | 14:55 |
| lyarwood | yeah the dest is likely running through the resize codepaths and blocking the src prior to that | 14:56 |
| lyarwood | good old func tests | 14:56 |
| gibi | :) | 14:56 |
| gibi | lyarwood: but you can prove that if you slow down the resize on the dest with sleep | 14:56 |
| gibi | if that increases the repro rate then we have a proof | 14:57 |
| gibi | lyarwood: you won't belive what causing https://bugs.launchpad.net/nova/+bug/1936849 | 15:01 |
| lyarwood | surprise me :) | 15:02 |
| gibi | lyarwood: https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/storage/test_rbd.py#L122-L125 | 15:02 |
| gibi | that is the same shutdown as https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/virt/hyperv/test_serialproxy.py#L70 | 15:03 |
| gibi | because the Rbd test sets shutdown on the Mock class level | 15:03 |
| gibi | becuase Rados is an alias for Mock not an instance of Mock | 15:04 |
| gibi | the missing () | 15:04 |
| lyarwood | oofffffff | 15:05 |
| lyarwood | nice catch | 15:05 |
| gibi | I will do some grepping for other missing () after mock.Mock | 15:06 |
| gibi | as this was a long journey :) | 15:06 |
| lyarwood | yeah that sounds like an easy hacking rule | 15:06 |
| gibi | hehh after the fix the rbd unit tests are failing :) The Rados = mock.Mock was intentional in the setup as they wanted to make sure that when the code calls Rados() it actually calls Mock() | 15:21 |
| lyarwood | noice | 15:23 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid modifying the Mock class in test https://review.opendev.org/c/openstack/nova/+/805657 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Drop references to non-filter scheduler drivers https://review.opendev.org/c/openstack/nova/+/773645 | 15:52 |
| opendevreview | Stephen Finucane proposed openstack/nova master: scheduler: Merge driver into manager https://review.opendev.org/c/openstack/nova/+/773644 | 15:52 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_utils', 'test_scheduler_utils' https://review.opendev.org/c/openstack/nova/+/773646 | 15:52 |
| opendevreview | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated aliases https://review.opendev.org/c/openstack/nova/+/773647 | 15:52 |
| *** rpittau is now known as rpittau|afk | 15:58 | |
| sean-k-mooney | gibi: oh it was using the class defintion not an instance of the class | 16:00 |
| gibi | sean-k-mooney: yepp | 16:00 |
| sean-k-mooney | fun | 16:00 |
| gibi | sean-k-mooney: and as the class definitions are global per interpreter it created a way that two tests interfere | 16:00 |
| sean-k-mooney | yep we have seen that several times before | 16:01 |
| opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | 16:03 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 16:45 |
| stephenfin | lyarwood: sean-k-mooney: Feel free to improve the commit message on that with additional context if you'd like | 16:46 |
| * stephenfin has to run o/ | 16:46 | |
| sean-k-mooney | stephenfin: ack thanks | 16:49 |
| sean-k-mooney | ah you are adding a url parse was not sure if it needed a pears or a decode | 16:50 |
| sean-k-mooney | in anycase the test seams good | 16:51 |
| lyarwood | I don't get how it's encoded by the time it gets there however if it's not in the config | 16:55 |
| sean-k-mooney | i think its becasue we were geting it form an object of type sqlalchemy.engine.url.URL | 16:58 |
| sean-k-mooney | and then casting that to a string | 16:59 |
| lyarwood | ah | 16:59 |
| sean-k-mooney | so it was likely being url encoded by the str call | 16:59 |
| opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | 17:19 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | 17:19 |
| lyarwood | gibi: ^ there was a silly race in my func test causing https://bugs.launchpad.net/nova/+bug/1940741 that should hopefully fix it now | 17:20 |
| gibi | lyarwood: good catch! | 17:21 |
| gibi | I did not know there is an initial delay | 17:21 |
| lyarwood | ah wait, might need to refine that a little | 17:21 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | 17:32 |
| gibi | lyarwood: the hacking rule ^^ | 17:32 |
| gibi | and that marks my end of the day o/ see you tomorrow folks | 17:34 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | 17:35 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | 17:37 |
| opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | 17:37 |
| lyarwood | Do you really want to submit the above commits? | 17:37 |
| lyarwood | Type 'yes' to confirm, other to cancel: yes | 17:37 |
| lyarwood | Aborting. | 17:37 |
| * lyarwood flips keyboard and also logs for a while | 17:37 | |
| melwitt | hmm.. why isn't zuul voting on a change when it passes? https://review.opendev.org/c/openstack/nova/+/805654 sorry if I missed the discussion | 18:18 |
| melwitt | maybe a fluke. just rechecked it | 18:30 |
| melwitt | sean-k-mooney: hey, in case you didn't see, I replied to your comments on https://review.opendev.org/c/openstack/placement/+/679441 | 18:34 |
| opendevreview | Ilya Popov proposed openstack/nova master: Fix to use cell with more free memory first https://review.opendev.org/c/openstack/nova/+/805649 | 18:34 |
| opendevreview | Lee Yarwood proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 18:58 |
| opendevreview | Merged openstack/nova master: VMWare: Use WithRetrieval to get all results https://review.opendev.org/c/openstack/nova/+/804968 | 19:32 |
| *** slaweq is now known as slaweq_ | 19:50 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org has been restarted for a patch version upgrade, resulting in a brief outage | 21:43 | |
| opendevreview | Merged openstack/nova master: Avoid modifying the Mock class in test https://review.opendev.org/c/openstack/nova/+/805657 | 22:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Enable SQLAlchemy 2.0 deprecation warnings https://review.opendev.org/c/openstack/nova/+/804709 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of Engine.scalar(), Engine.execute() https://review.opendev.org/c/openstack/nova/+/804878 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of 'autoload' parameter https://review.opendev.org/c/openstack/nova/+/805734 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace use of legacy select() calling style https://review.opendev.org/c/openstack/nova/+/805735 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Replace 'insert.inline' parameter with 'Insert.inline()' method https://review.opendev.org/c/openstack/nova/+/805736 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Don't pass strings to 'Connection.execute' https://review.opendev.org/c/openstack/nova/+/805737 | 23:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add migration to resolve shadow table discrepancies https://review.opendev.org/c/openstack/nova/+/805738 | 23:15 |
| *** yoctozepto4 is now known as yoctozepto | 23:37 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!