| opendevreview | zhen proposed openstack/nova stable/victoria: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/803550 | 02:21 |
|---|---|---|
| opendevreview | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 06:32 |
| *** akekane_ is now known as abhishekk | 06:41 | |
| opendevreview | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 06:58 |
| gibi | fyi the Asia friendly nova meeting starts in 29 minutes here in the channel | 07:31 |
| *** rpittau|afk is now known as rpittau | 07:47 | |
| bauzas | gibi: maybe another email for telling we have an Asian friendly meeting now ? | 07:58 |
| bauzas | (and good morning ;) ) | 07:58 |
| gibi | bauzas: morning | 07:59 |
| gibi | I think I'm late with that mail now, but good idea | 07:59 |
| gibi | I will note that for the next meeting | 08:00 |
| bauzas | np | 08:00 |
| gibi | #startmeeting nova_xtra | 08:00 |
| opendevmeet | Meeting started Thu Aug 5 08:00:35 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:00 |
| opendevmeet | The meeting name has been set to 'nova_xtra' | 08:00 |
| gibi | #endmeeting | 08:00 |
| opendevmeet | Meeting ended Thu Aug 5 08:00:43 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova_xtra/2021/nova_xtra.2021-08-05-08.00.html | 08:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova_xtra/2021/nova_xtra.2021-08-05-08.00.txt | 08:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova_xtra/2021/nova_xtra.2021-08-05-08.00.log.html | 08:00 |
| gibi | #startmeeting nova_extra | 08:00 |
| opendevmeet | Meeting started Thu Aug 5 08:00:46 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:00 |
| opendevmeet | The meeting name has been set to 'nova_extra' | 08:00 |
| gibi | (interestingly it allows any name it seems) | 08:00 |
| gibi | \o | 08:01 |
| gibi | who we have here today? | 08:01 |
| bauzas | gibi: yup, you can ask for any meeting name | 08:01 |
| bauzas | \o | 08:02 |
| gibi | then why we have to do a booking in the irc repo? | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 08:02 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 08:02 |
| bauzas | gibi: for the meeting time, that's it | 08:02 |
| gibi | that make sense, but the booking also contains a define ticker for the meeting bot like " Start this meeting using: #startmeeting nova_extra" https://meetings.opendev.org/#Nova_Monthly_Asia_Friendly_Team_Meeting | 08:03 |
| bauzas | but for example, you'd see some nova_scheduler meetings logs in eavesdrop ;) | 08:03 |
| gibi | those old times... | 08:04 |
| gibi | when there was even a notification subteam meeting | 08:04 |
| bauzas | :) https://meetings.opendev.org/meetings/ | 08:04 |
| gibi | that seems interesting https://meetings.opendev.org/meetings/honeybooboo/ | 08:06 |
| bauzas | :) | 08:08 |
| gibi | do we have some folks here today for this meeting? | 08:08 |
| gibi | or should I just stop the recording of bauzas and me joking around | 08:09 |
| gibi | #endmeeting | 08:12 |
| opendevmeet | Meeting ended Thu Aug 5 08:12:04 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:12 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-08-05-08.00.html | 08:12 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-08-05-08.00.txt | 08:12 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova_extra/2021/nova_extra.2021-08-05-08.00.log.html | 08:12 |
| gibi | we tried at least | 08:12 |
| bauzas | :) | 08:12 |
| bauzas | maybe that's because we haven't told jokes | 08:12 |
| gibi | I keep the rights to entertain myself while waiting :D | 08:12 |
| bauzas | do you know how IT folks name their bathrooms ? | 08:14 |
| bauzas | an I-Pee address | 08:14 |
| gibi | lol | 08:14 |
| gibi | we need more like this | 08:14 |
| kashyap | sean-k-mooney: Hi, when you're about: I guessed yesterday, the "concern" about moving from cirrus to virtio-vga with 1080p turned out to be a non-problem: Cirrus simply does not support 1080p. | 08:15 |
| kashyap | Gerd from QEMU confirmed it. So, moooving on. | 08:15 |
| kashyap | s/I guessed/As I guessed/ :D | 08:15 |
| kashyap | bauzas: :D What did you have for breakfast | 08:16 |
| bauzas | kashyap: morning | 08:16 |
| bauzas | I'm nearly off for vacations, I guess | 08:16 |
| bauzas | gibi: the whole list of meetings names make me loling https://meetings.opendev.org/meetings/ | 08:17 |
| kashyap | bauzas: Likewise; I'm off from 12-27 Aug | 08:17 |
| bauzas | lots of typos | 08:17 |
| bauzas | kashyap: quite identical, Aug 9-30 (incl.) | 08:18 |
| kashyap | Cool | 08:18 |
| gibi | I guess next week we should just close the nova channel | 08:19 |
| gibi | as stephenfin and I will be off too | 08:20 |
| kashyap | Heh | 08:48 |
| kashyap | gibi: Probably we could update the channel topic? | 08:50 |
| kashyap | To the effect of: "Bear timezones and work hours in mind | If IRC is quiet, write to the mailing list?" | 08:51 |
| gibi | heh | 08:54 |
| gibi | hm I don't have OP rights | 08:55 |
| bauzas | stephenfin: thanks for reviewing the mdev series, as a trade, please ping me your own DB series ;) | 09:21 |
| stephenfin | bauzas: nw! It starts here https://review.opendev.org/c/openstack/nova/+/799520/ | 09:23 |
| bauzas | I'm just uploading my series again given your logs point and gibi's comment on the commit msg about more is more than less | 09:23 |
| gibi | stephenfin: I managed to finish the packet rate series up until the last WIP patch (nova-manage heal_allocation) | 09:24 |
| gibi | stephenfin: so if you still have time then review is appreciated | 09:24 |
| stephenfin | can do! | 09:24 |
| gibi | stephenfin: I can also trade reviews :) | 09:24 |
| stephenfin | I was going to say, reviews on the remainder of the DB series would be appreciated :-D | 09:24 |
| gibi | stephenfin: OK, I will do that then | 09:25 |
| bauzas | gibi: my last 2 days are dedicated to Gerrit looking fwiw | 09:27 |
| gibi | bauzas: I'm affraid to ask you to look at the packet rate as you will dissappear for 3 weeks so I will be blocked waiting you to come back and re-review just before FF. but if you have time... | 09:28 |
| bauzas | that's understandable | 09:29 |
| bauzas | one day, feature freezes won't happen on end of Augusts | 09:29 |
| bauzas | fun fact, my wife is always grumbling about the fact our release cadence is always hitting our usual resting periods :) | 09:30 |
| gibi | this end of summer FF is not idea, the W FF happened at a better time for me at least | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Change the admin-visible logs for mdev support https://review.opendev.org/c/openstack/nova/+/803378 | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | 09:31 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | 09:31 |
| bauzas | (just a rebase for other changes but https://review.opendev.org/c/openstack/nova/+/803378 which fixes two nits) | 09:32 |
| bauzas | gibi: right, but honestly, only europeans feel this being problematic so I'm OK to live with it | 09:32 |
| gibi | ^^ looks good to me | 09:35 |
| songwenping | sean-k-mooney: https://review.opendev.org/c/openstack/cyborg/+/797403 this patch backport to victoria, but it requires oslo.db==10.0.0, because this patch https://review.opendev.org/c/openstack/oslo.db/+/792124 resolved duplicate key error for mysql. how can we fix the cyborg tempest? | 09:35 |
| opendevreview | Lee Yarwood proposed openstack/nova master: Add regression test for bug 1938326 https://review.opendev.org/c/openstack/nova/+/802801 | 09:38 |
| opendevreview | Lee Yarwood proposed openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | 09:38 |
| lyarwood | gibi: https://bugs.launchpad.net/nova/+bug/1912310/comments/7 - TIL about logsearch, is that a local tool or something I could use? | 09:59 |
| gibi | lyarwood: I would say highly experimental https://github.com/gibizer/zuul-log-search | 10:00 |
| lyarwood | awesome | 10:00 |
| gibi | I'm plannig for the time when logstash will be gone | 10:01 |
| gibi | this logsearch needs decent net bandwidth and a plenty of local space but it does not need a always running service | 10:01 |
| gibi | right now I'm trying to add capability for matching build queries against stored search patterns to help figuring out why a job failed | 10:03 |
| kashyap | lyarwood: Once again ... thanks for the 'nova-mange libvirt update_machine_type'! :) | 10:04 |
| gibi | lyarwood: here are my config dir too with some bug patterns https://github.com/gibizer/zuul-log-search-config | 10:07 |
| gibi | lyarwood: and as always, pull requests are welcome :) | 10:08 |
| stephenfin | lyarwood, bauzas, gibi: Reworking this hostname API change. I was asked to drop the 'OS-EXT-SRV-ATTR:' prefix for the 'hostname' field from responses to make it align with the request. Do we want to drop all of these prefixes? | 10:13 |
| stephenfin | so 'OS-EXT-SRV-ATTR:hostname' becomes 'hostname', 'OS-SRV-USG:launched_at' becomes 'launched_at', ... | 10:13 |
| stephenfin | I ask because when I'm doing one and already spinning up the microversion machinery, it makes sense for me to do them all | 10:14 |
| gibi | doesn't make much sense to keep them, they are there only for historical reasons as far as I remember | 10:14 |
| stephenfin | yes, due to the old-school extension framework | 10:14 |
| gibi | kill them with fire! | 10:14 |
| stephenfin | OS-EXT-SRV => os-extended-server-attributes extension; OS-SRV-USG => os-server-usage extension etc. | 10:15 |
| stephenfin | (I only learned that today from https://wiki.openstack.org/wiki/NovaAPIv2tov3) | 10:15 |
| stephenfin | 🔥🔥🔥 | 10:16 |
| lyarwood | stephenfin: so is this behind a microversion? | 10:16 |
| stephenfin | absolutely | 10:16 |
| lyarwood | right cool then burn away | 10:17 |
| opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Skip volume and block live migrations due to bug #1912310 https://review.opendev.org/c/openstack/nova/+/803585 | 10:59 |
| lyarwood | ^ gibi / stephenfin ; okay I've had enough of https://bugs.launchpad.net/nova/+bug/1912310 borking things in the check and gate queues, lets skip things and ask the QEMU folks to look at this | 11:00 |
| stephenfin | agree | 11:02 |
| gibi | lyarwood: do we have left any live migration coverage? | 11:04 |
| lyarwood | ah, not in the nova-live-migration job because it isn't using shared storage | 11:04 |
| lyarwood | let me respin this | 11:04 |
| gibi | bauzas: I'm just wondering did we ever updated nova-manage placement heal_allocation to support healing vGPUs? | 11:08 |
| gibi | bauzas: I think if today we have an instance with vGPU request and the heal_allocation CLI is used it will try to allocate VGPU resource from the root RP that will fail | 11:13 |
| gibi | I guess the same is true for flavor based cyborg devices | 11:14 |
| gibi | the code simply assumes that everything coming from the flavor need to be allocated from the root RP https://github.com/openstack/nova/blob/2ffd9738602531e93495a1feca76bbb687c3e72c/nova/cmd/manage.py#L1700-L1705 | 11:15 |
| gibi | https://github.com/openstack/nova/blob/2ffd9738602531e93495a1feca76bbb687c3e72c/nova/scheduler/utils.py#L607-L612 | 11:17 |
| gibi | this is a scary TODO^^ | 11:18 |
| gibi | amending the cyborg part. If the flavor has cyborg device profile extra_spec then that is simply ignored by the heal_allocation code | 11:20 |
| gibi | with a --force used it can mean that a healthy cyborg allocation is dropped from an instance | 11:20 |
| gibi | /o\ | 11:20 |
| * gibi goeas adding a big red warning to the top of the CLI | 11:21 | |
| sean-k-mooney | ya... that is not ideal | 11:36 |
| sean-k-mooney | gibi: that also affects QOS | 11:37 |
| gibi | sean-k-mooney: not, there is explicit QoS support there | 11:37 |
| gibi | I'm just about to extend that with the packet rate handling | 11:37 |
| gibi | when I detected the missing pieces | 11:37 |
| sean-k-mooney | oh its after this | 11:38 |
| sean-k-mooney | you fix things up later? | 11:38 |
| gibi | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1557 | 11:39 |
| sean-k-mooney | ah https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1609-L1610 | 11:39 |
| gibi | first heal_allocation was added my mriedem then I added port allocation healing to it when the QoS was first done | 11:39 |
| gibi | now I need to fix up the QoS support due to the format change in the resource request as part of the pps feature | 11:40 |
| sean-k-mooney | i was actully wonderign if we use resources_from_flavor for any other operation in nova | 11:40 |
| gibi | fortunetly not | 11:40 |
| gibi | that would be a huge bug | 11:40 |
| sean-k-mooney | yep | 11:40 |
| gibi | we should move that util function to the manage.py to show it is not used by any other code | 11:41 |
| sean-k-mooney | ah i see nov amanage trhen unit and func tests | 11:41 |
| sean-k-mooney | ya i guess we could | 11:42 |
| sean-k-mooney | ok so this would affect vGPU, Cyborg and vPMEM | 11:43 |
| gibi | vPMEM is also not on the root provider? | 11:43 |
| sean-k-mooney | i belive we have multipel namespaces fo differnet size so i think its nested | 11:44 |
| sean-k-mooney | it may also impact inventories created via provider.yaml | 11:44 |
| gibi | sean-k-mooney: vpmem is on the root according to this doc https://docs.openstack.org/nova/latest/admin/virtual-persistent-memory.html | 11:45 |
| gibi | does provider.yaml today support creating child RPs? | 11:45 |
| gibi | or inventories on child rps? | 11:46 |
| sean-k-mooney | ah right we are using different RC for the different namespaces so that does not need to be nested | 11:46 |
| gibi | we don't have tests but I assume that anytign that is on the root healed correctly | 11:47 |
| gibi | I mean we have tests for basic mem, disk, vcpu and port QoS but not to the others like vpmem | 11:47 |
| sean-k-mooney | gibi: so i tdoes not look like we can crete nested rps with the file but we can specifcy the uuid | 11:48 |
| sean-k-mooney | so if you precreate the RPs the it can manage them | 11:49 |
| gibi | ok, so provider yaml can add inventories to existing childs like cyborg, vgpu or QoS childs. So that is also affected | 11:49 |
| sean-k-mooney | so it wont use nested RP by default but there is nothing to prevent you doing that | 11:49 |
| sean-k-mooney | yes exactly | 11:49 |
| gibi | but there is no way I can detect that from the manage CLI. I can detect vgpu and cyborg dev profile in the flavor and blow up | 11:50 |
| sean-k-mooney | well im wondering why we cant try and retrive the structure form placment initally | 11:50 |
| gibi | sean-k-mooney: so you mean if the instance has nested allocation then we dont try to heal it | 11:51 |
| gibi | sean-k-mooney: that can be done | 11:51 |
| gibi | sean-k-mooney: but we cannot detect that an instance would need a nested allocation if that allocation is missig | 11:51 |
| sean-k-mooney | well that could be a first step | 11:51 |
| gibi | and the whole reason of heal allocation is to heal missing allocations :) | 11:52 |
| sean-k-mooney | but i was wondering if we could derive where the allocation should come from using the tree structure of plamcnet and its current allocation if they existis | 11:52 |
| sean-k-mooney | gibi: well for the we kind of can | 11:53 |
| sean-k-mooney | if we se it uses a CUSTOM_CYBORG_THING | 11:53 |
| sean-k-mooney | and we look at the RP tree for the host and see that is not on the root RP we know it need to be healed usign the nested RP inventory | 11:54 |
| sean-k-mooney | if and only if that RC exist on only one nested RP we can heal it | 11:54 |
| gibi | cyborg is requested via device profile name in the flavor so that can be detected easier, for any CUSTOM_FOO your idea is viable | 11:54 |
| sean-k-mooney | but if the same RC exits on multiple RPS really only the virt dirver would be able to figure out what rp is correct | 11:55 |
| sean-k-mooney | e.g. it would have to use inform form the libvirt domain or similar to try and determin which pGPU the vGPU was allocated form | 11:55 |
| gibi | sean-k-mooney: yes, the ambiguity cannot be resolved in the CLI, we have that thing already implemented (rejected) for the QoS healing | 11:56 |
| gibi | there the VF - PF - port - PF RP relationship cannot be disambiguated in the CLI | 11:56 |
| sean-k-mooney | part of me thinks we should be storing some addtion info in our db to allow this | 11:57 |
| sean-k-mooney | but im not sure what that should be | 11:57 |
| sean-k-mooney | what annoys me about this problem is even if we save a copy of the inital allocation summeries and the placment query that we used to generate it im not conviced that is sufficent to reconstuct the allocations remotely | 12:01 |
| gibi | I stop here now. I will add some blocking and documentation to the CLI about vgpu and cyborg dev profile to prevent damage. then I will continue adding QoS support. other can take up removing the vgpu and cyborg block by implementing support | 12:01 |
| sean-k-mooney | gibi: it kind of feels like the only way to do this would be to have nova-manage call the virt dirver over rpc to have it fix it | 12:02 |
| sean-k-mooney | gibi: ack | 12:02 |
| gibi | yes, the full support most probably would need that | 12:02 |
| opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Mark live migration jobs as non-voting due to bug #1912310 https://review.opendev.org/c/openstack/nova/+/803585 | 12:03 |
| songwenping | sean-k-mooney: we have a problem on cyborg that you may know, please give some tips if you have free time. | 12:03 |
| songwenping | https://review.opendev.org/c/openstack/cyborg/+/797403 this patch backport to victoria, but it requires oslo.db==10.0.0 for cybort, because this patch https://review.opendev.org/c/openstack/oslo.db/+/792124 resolved duplicate key error for mysql. how can we fix the cyborg tempest? | 12:03 |
| songwenping | https://review.opendev.org/c/openstack/cyborg/+/797403 this patch backport to victoria, but it requires oslo.db==10.0.0 for cyborg tempest, because this patch https://review.opendev.org/c/openstack/oslo.db/+/792124 resolved duplicate key error for mysql. how can we fix the cyborg tempest? | 12:04 |
| sean-k-mooney | ok so you are gettign duplicate DeviceProfile uuids in this case 977806ca-4e8e-40c2-aa3a-09cef2903336 | 12:06 |
| sean-k-mooney | and this is currently how you create your device profiles https://github.com/openstack/cyborg/blob/1052efe93b5e7aa351b1f50cfe80f504dcf48b72/cyborg/db/sqlalchemy/api.py#L499-L517 | 12:08 |
| sean-k-mooney | so this is the contraing that is filing | 12:10 |
| sean-k-mooney | pymysql.err.IntegrityError: (1062, "Duplicate entry 'fpga_same_test' for key 'device_profiles.uniq_device_profiles0name'") | 12:10 |
| sean-k-mooney | ok i see | 12:14 |
| sean-k-mooney | https://review.opendev.org/c/openstack/oslo.db/+/792124/6/oslo_db/sqlalchemy/exc_filters.py | 12:14 |
| sean-k-mooney | so thet way that code is ment to work is it parses device_profiles.uniq_device_profiles0name | 12:15 |
| sean-k-mooney | and it should extract the unique constrait by firsts discarding eveything before uniq_ leaving device_profiles0name | 12:16 |
| sean-k-mooney | the it splits that on the 0 to get the table device_profiles and columns in this case name | 12:16 |
| sean-k-mooney | so the unique constrati you were expecting was device_profiles name not the uuid | 12:17 |
| sean-k-mooney | without that fix it was using all colums as unique constriats? i guess at least that the oslo db level | 12:19 |
| sean-k-mooney | oh i see | 12:19 |
| sean-k-mooney | In mysql 8.0.19 , Duplicate key error information is extended to | 12:20 |
| sean-k-mooney | include the table name of the key.Previously, duplicate key error | 12:20 |
| sean-k-mooney | information included only the key value and key name. | 12:20 |
| bauzas | gibi: sorry was out for lunch | 12:21 |
| sean-k-mooney | songwenping: im surpised that affect https://github.com/openstack/cyborg/blob/1052efe93b5e7aa351b1f50cfe80f504dcf48b72/cyborg/db/sqlalchemy/api.py#L511-L516 | 12:22 |
| bauzas | gibi: about the VGPU healed allocations, well, we already verify the VGPU RC for the audit command but we don't do this for the heal_allocations | 12:22 |
| bauzas | gibi: also, given we would now use other custom RCs, maybe we could also modify both the audit and heal_allocs commands to have a new attribute for telling which RCs to look at | 12:22 |
| songwenping | sean-k-mooney: yes, the mysql version is update. | 12:25 |
| sean-k-mooney | songwenping: without the oslo.db patch teh colum will be named "device_profiles.uniq_device_profiles0name" with it it will be "name" | 12:25 |
| sean-k-mooney | oh i see | 12:25 |
| sean-k-mooney | ok i get what is happening now so e.columns is a dict | 12:25 |
| sean-k-mooney | if 'name' in e.columns: is checkking if there is a key that exactly match | 12:26 |
| sean-k-mooney | the keey has chaned to now have the table name prefixed | 12:26 |
| sean-k-mooney | so the fix you can do in cyborg is to add an elif | 12:26 |
| songwenping | right, the e.columns isnot ['name'] any more. | 12:27 |
| sean-k-mooney | ya so we just need to make the comparisone a little more robost | 12:29 |
| songwenping | if i make the name and id all conflict, the e.columns is ['id'] and isnot ['id','name'] | 12:30 |
| sean-k-mooney | https://paste.opendev.org/show/807904/ | 12:31 |
| sean-k-mooney | i think this will work ^ | 12:31 |
| songwenping | this is good for now. | 12:32 |
| sean-k-mooney | https://paste.opendev.org/show/807905/ | 12:32 |
| sean-k-mooney | or maybe that | 12:33 |
| sean-k-mooney | add an else just in case we have a conflicat that is not on name or uuid although it would be treated as a uuid conflict today | 12:33 |
| sean-k-mooney | songwenping: but ya the other way to do this is to preporcess the columns dict and stip the table prefix | 12:34 |
| songwenping | does other projects have the same problems? | 12:35 |
| songwenping | i see only cyborg distingush the uuid and name conflict. | 12:36 |
| sean-k-mooney | i think we might define unique constraints differently then cyborg does | 12:36 |
| sean-k-mooney | songwenping: so this is the other way to fix it https://paste.opendev.org/show/807908/ | 12:39 |
| sean-k-mooney | all that has changed here is instead of using e.colums directly i have generated a new columns dict and then the exsitng if else just uses that | 12:39 |
| songwenping | this is same as the oslo.db does. | 12:39 |
| sean-k-mooney | yep more or less | 12:40 |
| songwenping | but whether it depends on mysql version | 12:40 |
| sean-k-mooney | so on brances that cant use the new version fo oslo db you can backport that in cyborg | 12:40 |
| sean-k-mooney | songwenping: this will work for any mysql verion | 12:41 |
| sean-k-mooney | if you have old mysql it will be a noop as none of the column names will have 0 in them | 12:41 |
| songwenping | ok, this is a good idea, thanks. | 12:41 |
| sean-k-mooney | so columns and e.columns will be the same | 12:41 |
| songwenping | right | 12:42 |
| sean-k-mooney | that is proably the minimal change let me see quickly what is different between how nova defines unique constraints an cyborg | 12:42 |
| songwenping | nova doesnot distingush the conflict types | 12:44 |
| sean-k-mooney | ah ok that wold make sense then | 12:46 |
| sean-k-mooney | i guess if any of them fail we dont realy care why we know the request is invlaid | 12:46 |
| songwenping | yes, i also wonder if we should distinguish them | 12:47 |
| sean-k-mooney | you proably do it today to have a better error message but you likely could do tha tdifferently | 12:48 |
| songwenping | ack | 12:48 |
| sean-k-mooney | oh https://github.com/openstack/nova/blob/35ddf1ad40207dee681a3c92cc9e86b061234edd/nova/db/sqlalchemy/api.py#L545-L550 | 12:49 |
| sean-k-mooney | so we do have that patteren | 12:50 |
| sean-k-mooney | that would have changed form ServiceBinaryExists to ServiceTopicExists silently | 12:50 |
| songwenping | so this also have problem | 12:52 |
| songwenping | the tempest doesnot check the ServiceBinaryExists exception? | 12:52 |
| sean-k-mooney | kind of becaue we use .get it wont fail | 12:53 |
| sean-k-mooney | ya we likely dont have tempest coverage for this | 12:53 |
| sean-k-mooney | although we should have and api funct tests for thsi | 12:53 |
| songwenping | +1 | 12:53 |
| gibi | bauzas: OK, so you have plans to amend the audit support for MDEV. then that is really a good time to add some support for heal if possible. | 12:53 |
| bauzas | gibi: well, I have around 12 hours for doing this until 3 weeks :p | 12:54 |
| songwenping | i will commit one patch to coverage it. | 12:54 |
| bauzas | 8 hours for tomorrow and 4 jours this afternoon :) | 12:54 |
| bauzas | hours* | 12:54 |
| gibi | bauzas: I'm not saying that you have to do it now. :D | 12:54 |
| gibi | bauzas: it is totally ok to do it in Yoga | 12:54 |
| gibi | bauzas: I just noted that we have a gap in heal | 12:55 |
| bauzas | gibi: create a bug report and I'll own it | 12:55 |
| gibi | I will make sure that it is now documented | 12:55 |
| gibi | bauzas: OK I can file a bug too | 12:55 |
| bauzas | or a blueprint maybe | 12:55 |
| gibi | that is a good idea | 12:55 |
| gibi | I will create a bug and later on we can transform that to a bp | 12:55 |
| bauzas | this is a tech debt fix | 12:55 |
| gibi | if we ever get to it | 12:55 |
| opendevreview | Pierre Libeau proposed openstack/nova master: Reset state during service nova-compute init https://review.opendev.org/c/openstack/nova/+/803600 | 13:24 |
| opendevreview | Merged openstack/nova master: trivial: Cleanup a comment about a now removed libvirt version check https://review.opendev.org/c/openstack/nova/+/802617 | 13:37 |
| gibi | bauzas: filed the bug about heal_allocation https://bugs.launchpad.net/nova/+bug/1939020 | 13:51 |
| bauzas | gibi: and triaged | 13:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Block servers wit vGPU and device profile in heal_allocations https://review.opendev.org/c/openstack/nova/+/803603 | 13:53 |
| gibi | bauzas: thanks, and here is the doc and block ^^ | 13:53 |
| bauzas | gibi: looking | 13:57 |
| melwitt | bauzas: I'm gonna respond on the review too but the "unknown" is not a default consumer type, it's a cosmetic-only label for friendliness to the user. (same with the "all" label as a query parameter). a consumer with no type has NULL in the column. the reproposal of the spec has removed mention of the original proposed "UNKNOWN" official default type. during review reviewers preferred to leave NULL to represent the absence of a consumer | 15:08 |
| melwitt | type | 15:08 |
| bauzas | melwitt: oh ok | 15:08 |
| bauzas | I only looked at the train spec | 15:08 |
| bauzas | when this was something as a gerrit spec :p | 15:09 |
| melwitt | ah gotcha | 15:09 |
| bauzas | melwitt: will then remove my -1 | 15:09 |
| melwitt | cool thanks :) | 15:09 |
| bauzas | (and yeah sorry I cheated :p ) | 15:10 |
| melwitt | haha no worry | 15:11 |
| lyarwood | https://review.opendev.org/c/openstack/nova/+/803585 btw gibi / stephenfin / melwitt ; moving the LM jobs to NV for the time being while someone looks at the underlying QEMU failure(s) | 15:14 |
| melwitt | /sad trombone sound | 15:14 |
| melwitt | kashyap: I see you have commented on https://launchpad.net/bugs/1912310 before ^ but no leads yet right? | 15:18 |
| kashyap | melwitt: Hi, /me looks | 15:18 |
| kashyap | (The bot doesn't seem to higlight the summary on IRC anymore) | 15:19 |
| melwitt | hm yeah not sure what happened to the bot | 15:20 |
| kashyap | melwitt: Yeah, no leads yet | 15:20 |
| kashyap | melwitt: Is it hitting more often? Looks like so from gibi's #7 on 31Jul | 15:22 |
| melwitt | kashyap: yeah, lyarwood is proposing above making the live migration job non-voting because of it | 15:22 |
| kashyap | melwitt: Oh, yeah - just saw that | 15:23 |
| bauzas | lyarwood: unfortunately +Wd the live-mig job be non-votign | 15:55 |
| lyarwood | ack thanks | 15:56 |
| *** akekane_ is now known as abhishekk | 16:01 | |
| gibi | about the bug resolver bot I asked infra they said that https://meetings.opendev.org/irclogs/%23opendev/%23opendev.2021-08-03.log.html#t2021-08-03T16:31:32 | 16:06 |
| melwitt | thanks gibi | 16:11 |
| gibi | so probably we lost the both the topic handling and the bug resolving capability of the bot during that transformatin | 16:14 |
| *** rpittau is now known as rpittau|afk | 16:41 | |
| gibi | If I had time I would be happy working on those bots | 16:43 |
| * gibi needs a time machine | 16:43 | |
| opendevreview | Merged openstack/nova master: zuul: Mark live migration jobs as non-voting due to bug #1912310 https://review.opendev.org/c/openstack/nova/+/803585 | 18:11 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is going down for a quick restart to adjust its database connection configuration, and should return to service momentarily | 20:03 | |
| nurdie | Hey OS nova! I had to evacuate a failed compute node (it's super dead) on shared storage (ceph). 3 instances are hanging in "nova migration-list" as "accepted" but are already on another compute node. Does anyone know what galera db.table I can edit real quick to clear that up? | 21:12 |
| opendevreview | melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | 23:23 |
| opendevreview | melanie witt proposed openstack/placement master: Microversion 1.38: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | 23:24 |
| opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 23:24 |
| melwitt | bauzas: updated first patch per your comments ^ | 23:24 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!