| *** ianw is now known as Guest52 | 01:07 | |
| *** Guest52 is now known as ianw | 01:29 | |
| opendevreview | jiang guodao proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 01:46 |
|---|---|---|
| swp20 | gmann: hi, our cyborg-tempest-plugin test failed, seems there are no accelerator resources on the zuul server, please help us: https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/796977 | 01:55 |
| opendevreview | jiang guodao proposed openstack/nova stable/victoria: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787252 | 03:23 |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 05:58 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 05:58 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 05:58 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 05:58 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 05:58 |
| opendevreview | Eric Xie proposed openstack/nova master: Fix error '404 Not Found' https://review.opendev.org/c/openstack/nova/+/797233 | 07:09 |
| *** rpittau|afk is now known as rpittau | 07:41 | |
| slaweq | elodilles hi, can You +W patch https://review.opendev.org/c/openstack/nova/+/787252 ? It was rebased recently | 08:32 |
| elodilles | slaweq: +W'd | 08:34 |
| elodilles | I hope it really merges now... the gate is in surprisingly bad shape according to the rechecks on this patch :/ | 08:36 |
| elodilles | despite that a number of gate improvements were merged :X | 08:37 |
| lyarwood | sean-k-mooney / gibi / artom / bauzas ; https://review.opendev.org/c/openstack/nova/+/797142 - can you all take a look at this when you get a chance? Blocks the already in progress backport of https://review.opendev.org/q/I11fb5d3ada7f27b39c183157ea73c8b72b4e672e | 08:56 |
| lyarwood | oh and morning btw :) | 08:56 |
| bauzas | fer sur | 08:56 |
| bauzas | and bonjour | 08:56 |
| slaweq | elodilles thx a lot | 09:27 |
| elodilles | slaweq: np | 09:37 |
| stephenfin | sean-k-mooney: It's working for real this time now https://review.opendev.org/c/openstack/nova/+/797142 | 10:52 |
| sean-k-mooney | stephenfin: yep reviewing it again | 10:53 |
| sean-k-mooney | i did not have a chance to test that since i added the detection mechanium in a real mixed env only with the ci | 10:54 |
| sean-k-mooney | its annoying that this sliped though but im about to +1 that | 10:54 |
| stephenfin | lyarwood: I'd rather avoid addressing those nits on ^, since I've already prepared the backports (with a -1 to prevent anyone merging yet) and don't want to drag more work on myself :-D | 10:55 |
| stephenfin | I could do a follow-up but they seem too minor to bother, for once | 10:55 |
| sean-k-mooney | i dont think the new=... | 10:56 |
| sean-k-mooney | is needed | 10:56 |
| sean-k-mooney | its defenetly nice to prefer to do that | 10:56 |
| sean-k-mooney | if the mock is not required in the test | 10:56 |
| sean-k-mooney | but we didnt do that until about a year or so ago because we did not know we could | 10:57 |
| sean-k-mooney | so its not inconsitnet with thte exsiting test just not the optimal way | 10:57 |
| stephenfin | yeah, my thinking too | 11:05 |
| stephenfin | I'd respin if I hadn't already started on the backports, but ... | 11:05 |
| stephenfin | backports appear to be working as expected too | 11:05 |
| stephenfin | I'll tackle stable/ussuri and stable/train after lunch | 11:05 |
| sean-k-mooney | yeah!!! i really wasnt looking forward to debuging that if it didint | 11:06 |
| sean-k-mooney | /yeah/yay/ | 11:07 |
| sean-k-mooney | by the way http://paste.openstack.org/show/806817/ | 11:22 |
| sean-k-mooney | we have q35 testing right? | 11:22 |
| sean-k-mooney | actully this is more userful http://paste.openstack.org/show/806818/ | 11:23 |
| sean-k-mooney | wait i wonder did i uppercase Q35 instead of q35 | 11:24 |
| sean-k-mooney | lyarwood: stephenfin bauzas https://bugs.launchpad.net/nova/+bug/1933097 this is what i get form deploying openstack at home, more work | 11:41 |
| bauzas | sean-k-mooney: *me* facepalms | 12:24 |
| sean-k-mooney | i never write it with an uppercase but this time i did... | 12:28 |
| opendevreview | Merged openstack/nova master: api: Log correct client IP if load balancer in use https://review.opendev.org/c/openstack/nova/+/786766 | 12:37 |
| sean-k-mooney | bauzas: can you take a look at https://review.opendev.org/q/topic:%22bug%252F1910466%22+(status:open%20OR%20status:merged) | 12:50 |
| bauzas | ack, will look | 12:50 |
| sean-k-mooney | we suspect the customer might start escalating that soonish so just trying to get ahead fo that | 12:50 |
| opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797291 | 13:09 |
| *** abhishekk is now known as akekane|home | 13:41 | |
| lyarwood | stephenfin: yeah no issues | 13:46 |
| lyarwood | sean-k-mooney: haha nice, I did think about that when I was doing the nova-manage stuff that does validate that | 13:46 |
| * lyarwood is going to be offline for the rest of today btw | 13:47 | |
| *** akekane|home is now known as abhishekk | 13:55 | |
| opendevreview | Stephen Finucane proposed openstack/nova stable/train: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797316 | 14:11 |
| stephenfin | sean-k-mooney: ^ will wait and see how the stable/ussuri change goes (I can't run all tests locally in my env) but that _should_ be it | 14:13 |
| sean-k-mooney | ok good | 14:17 |
| sean-k-mooney | did you hit any issue with python2 compatiablity | 14:17 |
| sean-k-mooney | or other funcitonal test issue | 14:17 |
| opendevreview | Merged openstack/nova master: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601 | 14:19 |
| stephenfin | sean-k-mooney: not that I can tell. The modified tests did pass | 14:22 |
| stephenfin | (I could run those) | 14:23 |
| stephenfin | gibi: Are you around today? Care to look at https://review.opendev.org/c/openstack/nova/+/797142 if so? | 14:23 |
| sean-k-mooney | i was ok cool from thje commit it looks like the conflict were not as bad as i was fearing | 14:23 |
| sean-k-mooney | s/i was// | 14:24 |
| *** rpittau is now known as rpittau|afk | 16:00 | |
| opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797291 | 16:11 |
| opendevreview | Stephen Finucane proposed openstack/nova stable/train: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797316 | 16:20 |
| sean-k-mooney | stephenfin: https://zuul.opendev.org/t/openstack/build/73f734b9ffe745bd833ffe90f324d6d8/log/controller/logs/screen-n-cpu.txt#7643-7653 | 17:51 |
| sean-k-mooney | stephenfin: its still using <interface type=bridge> | 17:51 |
| sean-k-mooney | stephenfin: it should be <interface type=ethernet> | 17:52 |
| sean-k-mooney | stephenfin: this is how i orginally set teh flag by the way https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/objects/migrate_data.py | 17:59 |
| sean-k-mooney | i was trying to use udate which updates in place and returns None instead of the updated dict which was a bug | 18:02 |
| sean-k-mooney | this is the only other thing that chaged that jumped out at me https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/conductor/tasks/live_migrate.py#b403 | 18:04 |
| sean-k-mooney | but i think that is logically the same thing | 18:04 |
| sean-k-mooney | so we still have the same probelm that i was havign with that patch orginally when i put in the code to detect if the dest was patched it always disables the code even after fixing the profile update issue | 18:06 |
| sean-k-mooney | even with https://review.opendev.org/c/openstack/nova/+/797142 | 18:07 |
| sean-k-mooney | i can try and take a look at this with you tomorow if you like but i think we need a functional test that assert the xml has interface type=ethernet | 18:07 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!