Wednesday, 2021-05-26

« Tuesday, 2021-05-25 Index Thursday, 2021-05-27 »
*** mlavalle has quit IRC00:22
*** martinkennelly has quit IRC00:37
*** sapd1_x has quit IRC01:09
openstackgerritWenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client  https://review.opendev.org/c/openstack/nova-specs/+/78717801:48
*** jangutter_ has quit IRC01:54
*** gyee has quit IRC02:05
*** alex_xu has joined #openstack-nova02:24
*** jawad_axd has joined #openstack-nova03:22
*** xek_ has joined #openstack-nova03:25
*** xek has quit IRC03:25
*** jawad_axd has quit IRC03:27
openstackgerritKevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform  https://review.opendev.org/c/openstack/nova/+/76392803:44
*** boxiang_ has quit IRC04:18
*** boxiang_ has joined #openstack-nova04:18
*** ociuhandu has joined #openstack-nova04:31
*** ociuhandu has quit IRC04:36
*** mkrai has joined #openstack-nova04:37
*** ratailor has joined #openstack-nova04:44
*** ralonsoh has joined #openstack-nova05:10
*** links has joined #openstack-nova05:16
*** slaweq has joined #openstack-nova05:42
*** ccstone has quit IRC06:09
*** eandersson has quit IRC06:09
*** eandersson has joined #openstack-nova06:10
*** ccstone has joined #openstack-nova06:10
*** dklyle has quit IRC06:51
*** jawad_axd has joined #openstack-nova06:56
*** vishalmanchanda has joined #openstack-nova07:00
*** pmannidi has quit IRC07:07
*** whoami-rajat has quit IRC07:09
*** andrewbonney has joined #openstack-nova07:14
*** pmannidi has joined #openstack-nova07:20
*** pmannidi has quit IRC07:20
*** sapd1 has joined #openstack-nova07:25
*** xek_ is now known as xek07:30
*** tosky has joined #openstack-nova07:35
*** k_mouza has joined #openstack-nova07:38
*** rpittau|afk is now known as rpittau07:41
*** k_mouza has quit IRC07:43
*** janno has quit IRC07:50
*** lucasagomes has joined #openstack-nova08:03
*** mkrai has quit IRC08:12
bauzasgood morning Nova08:12
*** ociuhandu has joined #openstack-nova08:13
lyarwoodMorning08:17
lyarwoodso what happens to this channel if I look in a mirror and say `Libera Chat` three times?08:18
lyarwoodhttps://twitter.com/fosdem/status/1397454352835653632 context08:19
lyarwoodgibi: stephenfin08:19
lyarwoodargh sorry can you hit https://review.opendev.org/c/openstack/nova/+/790660 again please08:20
* lyarwood is still getting use to nick auto-complete in the element matrix client08:20
*** gokhani has joined #openstack-nova08:32
*** cz3 has quit IRC08:32
gibisure'08:38
lyarwoodthanks08:39
*** martinkennelly has joined #openstack-nova08:43
*** dtantsur|afk is now known as dtantsur08:56
*** stephenfin has joined #openstack-nova08:58
openstackgerritVlad Gusev proposed openstack/nova stable/stein: libvirt: Ignore device already in the process of unplug errors  https://review.opendev.org/c/openstack/nova/+/79304409:13
*** f0o has quit IRC09:32
*** ratailor has quit IRC09:43
*** ratailor has joined #openstack-nova09:45
*** ociuhandu has quit IRC09:45
*** logan- has quit IRC09:46
*** f0o has joined #openstack-nova09:49
*** macz_ has joined #openstack-nova09:49
*** macz_ has quit IRC09:54
*** logan- has joined #openstack-nova09:57
*** ociuhandu has joined #openstack-nova09:59
*** k_mouza has joined #openstack-nova09:59
*** ratailor has quit IRC10:03
*** ociuhandu has quit IRC10:04
*** sean-k-mooney[m] has joined #openstack-nova10:12
sean-k-mooney[m]lyarwood:  i think i figured out the cause of https://bugs.launchpad.net/nova/+bug/1929446 by the way so hopefully we will be able to fix that relitivly quickly10:13
openstackLaunchpad bug 1929446 in OpenStack Compute (nova) "check_can_live_migrate_source taking > 60 seconds in CI" [Medium,Triaged]10:13
* lyarwood clicks10:14
lyarwoodthat's blocking the other nova thread?10:14
sean-k-mooney[m]https://zuul.opendev.org/t/openstack/build/bb6fd21b5d8c471a89f4f6598aa84e5d/log/controller/logs/screen-n-cpu.txt#1224210:14
sean-k-mooney[m]yep all logs form the agent stop until the timeout fires10:15
*** ociuhandu has joined #openstack-nova10:16
lyarwoodreq-00377477-1efd-417a-b9c1-5db2f656c051 seems to run just fine in between10:17
lyarwoodand req-cb0aa064-b389-4cd5-aeb3-5c5cf0541b0010:17
sean-k-mooney[m]yep but that could just be down to the order in whic the green thread are resumed10:18
* lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/iVBmpWasUBctVWPeNDxVklaG/message.txt >10:19
lyarwood:|10:19
lyarwoodwas just checking _check_shared_storage_test_file to see if that spawned anything10:19
lyarwoodand that caught my eye10:20
*** ociuhandu has quit IRC10:20
sean-k-mooney[m]the exists check will yelid10:21
sean-k-mooney[m]we do not need the polling behavior in os-vif10:22
sean-k-mooney[m]so im going to see if i can disable it without having to recreate the connection every time we plug or unplug a port10:22
*** ociuhandu has joined #openstack-nova10:24
lyarwoodkk there is a call to libvirt in between the two logged lines for this request btw10:25
lyarwoodthere's a lookupByUUIDString10:26
lyarwoodfetching the guest10:26
*** ociuhandu has quit IRC10:27
*** ociuhandu has joined #openstack-nova10:27
*** mgoddard has quit IRC10:27
sean-k-mooneyya that coudl be related as we have had similar blocking issue there too10:28
*** alex_xu has quit IRC10:37
*** ociuhandu has quit IRC10:37
*** mkrai has joined #openstack-nova10:38
*** ratailor has joined #openstack-nova10:40
*** ratailor_ has joined #openstack-nova10:42
*** ratailor has quit IRC10:45
*** ociuhandu has joined #openstack-nova10:50
*** mkrai_ has joined #openstack-nova10:52
*** mkrai has quit IRC10:53
*** k_mouza has quit IRC10:57
*** ratailor has joined #openstack-nova11:00
*** ratailor_ has quit IRC11:02
*** gokhani has quit IRC11:03
*** k_mouza has joined #openstack-nova11:13
*** sapd1 has quit IRC11:16
*** gokhani has joined #openstack-nova11:17
*** ociuhandu has quit IRC11:18
*** k_mouza has quit IRC11:19
*** k_mouza has joined #openstack-nova11:19
sean-k-mooneystephenfin: you missing a comma in https://review.opendev.org/c/openstack/nova/+/792356/3/nova/tests/unit/virt/libvirt/test_vif.py#107611:23
sean-k-mooneythats why the jobs failed.11:23
sean-k-mooneyill update https://review.opendev.org/c/openstack/nova/+/777679 quickly for the nits and let you know when its done11:25
sean-k-mooneygibi: i have one comment that i would like your opipion on https://review.opendev.org/c/openstack/nova-specs/+/787178/5/specs/xena/approved/cyborg-no-user-token.rst#5611:36
*** ociuhandu has joined #openstack-nova11:36
sean-k-mooneyim +1 on the spec currently if other are ok with that then im also +2 i think. its a relitvly simple change and it mirror what we do for other services so i dont think this is really that contoversial.11:37
*** ociuhandu has quit IRC11:38
*** ociuhandu has joined #openstack-nova11:38
*** ociuhandu has quit IRC11:38
*** ociuhandu has joined #openstack-nova11:44
gibisean-k-mooney: you have a good point. I dropped my +2. Lets document the compromise in the secuirty section then I'm +2 again11:44
*** ociuhandu has quit IRC11:44
sean-k-mooneyok works for me11:44
*** jraju__ has joined #openstack-nova11:45
*** links has quit IRC11:45
*** macz_ has joined #openstack-nova11:50
*** macz_ has quit IRC11:54
*** ociuhandu has joined #openstack-nova11:59
*** ociuhandu has quit IRC12:05
lyarwoodWould anyone care if we dropped the direct swap volume tests from tempest and instead just had the indirect volume migration/retype tests to exercise it?12:06
lyarwoodit's failing again at the moment on master12:06
*** ociuhandu has joined #openstack-nova12:07
gibilyarwood: is it so that the direct test is someting that a user would never do as swap volume is for cinder to call?12:11
lyarwoodadmins can use it at the moment but I've wanted to move it under the external events API12:11
stephenfinlyarwood: I don't really understand the question, so I'll defer to your judgement 0:)12:11
lyarwoodhappy to wait until that's done to remove it12:11
lyarwoodlol12:12
*** mkrai_ has quit IRC12:12
lyarwoodanyway the CI failures a valid so I'll fix these first12:12
lyarwoodhttp://paste.openstack.org/show/805745/ - I assume something has changed with the way in which libvirt looks up devices12:12
*** ociuhandu has quit IRC12:13
*** ociuhandu has joined #openstack-nova12:15
gibilyarwood: if you have a clue how to fix it then it is better to fix first and then decide on if we want to move12:18
gibidoes the indirect test uses the API differently that it is not affected?12:18
sean-k-mooneylyarwood: if the direct swap volume tests are currently calling apis that we only expect cinder to call then defintly agree we shoudl disable them12:21
sean-k-mooneyi assume the inderct test call cinder to drive the workflow12:21
*** ociuhandu has quit IRC12:22
lyarwoodgibi: it will likely hit this as well if I'm understanding the issue correctly12:22
lyarwoodsean-k-mooney: yeah correct cinder-api drives things with volume migrations and retypes12:22
sean-k-mooneynova's swap volume is cinders retype rightr12:22
lyarwoodyup12:22
sean-k-mooneyok then if we have the cidner test i think that is enough coverage12:23
sean-k-mooneyat least untill we do the cahgne to external events12:23
*** ociuhandu has joined #openstack-nova12:24
sean-k-mooneyread ^ as a +0.5 sure but not may area :)12:24
*** ociuhandu has quit IRC12:28
*** mkrai_ has joined #openstack-nova12:31
gibiI agree with sean-k-mooney here.12:33
stephenfinsean-k-mooney: RE: the broken l-c jobs on os-vif stable branches: I see you're trying to fix them12:36
stephenfinshould we be bothering though12:36
stephenfinif it's broken now then it was always broken12:36
sean-k-mooneythe inital backport https://review.opendev.org/c/openstack/os-vif/+/792840 failed to install hacking12:36
stephenfinpip's broken resolver was just hiding that12:36
sean-k-mooneyi can ditch that and drop it for stable branchs but i would like elod  and lyarwood  to comment on that12:37
stephenfinyeah, I would be in favour of dropping this rather than investing more effort in it, personally12:37
stephenfinbut stable cores should weigh in. melwitt too12:37
lyarwoodyup FWIW I'm fine dropping it12:37
gibiour agreement was that we try to fix but drop it if we cannot12:38
gibiso if the consensus is that it is now hard to fix then I'm fine to drop it12:38
stephenfinyeah, that's my recollection also12:39
sean-k-mooneyfrom stable only or also form master?12:39
stephenfinif master is still working, I see no reason to drop it there12:39
stephenfinpersonally12:39
sean-k-mooneymaster is yes12:39
stephenfinbut per gibi's comment above, if it breaks and is more than trivial to resolve, we should drop from master also12:40
sean-k-mooneyand stable wallaby is since it has your fix12:40
sean-k-mooneyso it would be victoria and older12:40
gibiI agree with stephenfin12:40
stephenfinsean-k-mooney: victoria and older wfm12:40
sean-k-mooneyok i just reject the victoria fix if that fails to install hacking again or fails in general ill drop it and then propose the other patches for stable and rebase any pending patches12:41
sean-k-mooneywell the 2 i want to backport in anycase :)12:41
*** ociuhandu has joined #openstack-nova12:42
*** ociuhandu has quit IRC12:44
*** ociuhandu has joined #openstack-nova12:45
*** coreycb has quit IRC12:50
*** rm_work has quit IRC12:56
*** rm_work has joined #openstack-nova12:56
*** ociuhandu has quit IRC13:04
*** coreycb has joined #openstack-nova13:05
openstackgerritStephen Finucane proposed openstack/nova master: Add 'hw:vif_multiqueue_enabled' flavor extra spec  https://review.opendev.org/c/openstack/nova/+/79235613:07
openstackgerritStephen Finucane proposed openstack/nova master: docs: Document virtio-net multiqueue  https://review.opendev.org/c/openstack/nova/+/79236213:07
openstackgerritStephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware  https://review.opendev.org/c/openstack/nova/+/79236413:07
*** ociuhandu has joined #openstack-nova13:09
*** coreycb has quit IRC13:10
openstackgerritElod Illes proposed openstack/os-vif stable/victoria: [stable-only] Fix lower-constraints  https://review.opendev.org/c/openstack/os-vif/+/79315513:16
*** k_mouza_ has joined #openstack-nova13:16
elodsean-k-mooney: this worked for me locally, let's see if zuul is also happy with it ^^^13:17
sean-k-mooneyelod: so did the patch i pushed :)13:17
sean-k-mooneyelod: https://review.opendev.org/c/openstack/os-vif/+/79284013:17
elodoh did it meanwhile? :) I just saw that it failed :)13:17
sean-k-mooneywell it passed before i pushed it13:18
sean-k-mooneyit failed in teh gate because it could not install hacking13:18
sean-k-mooneyi think that was a limestone issue13:18
*** k_mouza has quit IRC13:19
sean-k-mooneyelod: the recheck of min passed lower constratits for what its worth13:20
elodit was passing before if I remember correctly13:20
sean-k-mooneyhttps://a23e1d5d8671587c8417-333846024fbe3cd00d8d8f9166c680e2.ssl.cf2.rackcdn.com/792840/1/check/openstack-tox-lower-constraints/f0bf4ed/13:20
sean-k-mooneylooks like other josb are failing to conenct to opendev.org13:21
*** ociuhandu has quit IRC13:21
elodthe only concern why I sticked to the fixing of constraints instead of removing most of them is I think it is more "future proof" to keep more constraints. otherwise the resolver could become slower and slower.13:22
*** ociuhandu has joined #openstack-nova13:22
elodbut, anyway, both patch works for me :)13:22
*** ratailor has quit IRC13:25
sean-k-mooneyelod: it could although os-vif tries to have relitivly minimal deps13:26
*** sapd1 has joined #openstack-nova13:26
*** ociuhandu has quit IRC13:26
sean-k-mooneyi would even like to reduce the set we have futher by removng oslo.i18n13:27
sean-k-mooneywe have never hadn and translsation for os-vif and i dont think we do that anymore for logs/errors in general13:28
elodsean-k-mooney: with the minimal l-c set, if you check the job time is 10 mins for the l-c job compared to py** which are 4 mins. at least that's what I saw after the first test results13:33
sean-k-mooneythe job rund the doc generation and unit tests13:34
sean-k-mooneythe py** jobs do far less work13:34
sean-k-mooneywell maybe not far less but it is less13:34
sean-k-mooneywe shoudl compare the runtime  of the two version of the patch when zuul reports back13:35
elodof course, but with more lower constraints the resolver is quicker and takes more or less the same time. :)13:35
elodanyway, as I said, both patch works for me :)13:36
sean-k-mooneythe ussuri version will only need a minor change to add one pep8 rule to the ignore list by the way13:37
sean-k-mooneyso im ok with fixing it in the older branch provide its simple too13:38
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Allow provider re-parenting in placement  https://review.opendev.org/c/openstack/nova-specs/+/78824313:38
sean-k-mooneythat said there are some patch that for downstream reason we kind of need to merge before june 2nd13:38
sean-k-mooneyspecificaly https://review.opendev.org/c/openstack/os-vif/+/765912 and https://review.opendev.org/c/openstack/os-vif/+/765970/313:39
gibisean-k-mooney, bauzas, tetsuro, melwitt: I made a step back and realized that non of you wanted a saftey check in the first place in https://review.opendev.org/c/openstack/nova-specs/+/788243 so I changed to propose not to add one. Lets see if this removes the impass13:39
gibiimpasse even13:40
sean-k-mooneyack just finishing reviewing your qos spec. lyarwood's encypeted volumn on is next on my list then ill loop back to ^13:43
gibisean-k-mooney: awesome, thanks13:43
bauzasgibi: ack, will look again13:46
*** ociuhandu has joined #openstack-nova13:49
*** macz_ has joined #openstack-nova13:51
*** macz_ has quit IRC13:55
*** ociuhandu has quit IRC13:59
ozzzosean-k-mooney: I tried your grub trick and it allowed me to start the compute service with "cpu_models=Skylake-Server-IBRS,Cascadelake-Server-noTSX"13:59
*** ociuhandu has joined #openstack-nova13:59
ozzzobut my cpu_info changed from "Cascadelake-Server-noTSX" to "Cascadelake-Server" whcih still doesn't match "Skylake-Server-IBRS"13:59
*** whoami-rajat_ has joined #openstack-nova13:59
sean-k-mooneythey should not need to match13:59
sean-k-mooneyfor live migration the xml that is used to start the dest server is a modifed one of the orginail server xml14:00
sean-k-mooneywe will not update the cpu model in that process14:00
sean-k-mooneyso the live migration will try to create the dest vm with Skylake-Server-IBRS14:01
sean-k-mooneyso you should be able to live migrate14:01
ozzzosean-k-mooney: I must be missing a step; I still get the "Host filter ignoring hosts" error14:02
sean-k-mooneythe host filter? that should only ignore the current host14:03
ozzzoI did the grub trick, and then rebooted the compute, then deployed the compute14:03
sean-k-mooneyhttps://github.com/openstack/nova/blob/b0cd985f0c09088098f74cc0cb1df616cc0ef12b/nova/scheduler/filters/__init__.py#L22-L5014:03
ozzzothis is what I get in the scheduler log: https://paste.ubuntu.com/p/tX9W7dT3PH/14:04
sean-k-mooneyactully its not that filter14:04
sean-k-mooneythats coming form https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L490-L49814:06
sean-k-mooneyso it means that the host has been added to the ignored host list14:06
sean-k-mooneywhat release of openstack are you using by the way14:06
ozzzoTrain14:06
ozzzoworking on upgrading from centos 7-8 to prepare for train-ussuri14:07
sean-k-mooneyok so you need to use debug logs in the schudler to see why the hsot got filtered out14:08
ozzzook14:08
sean-k-mooneysomething added the host to the ignored list becaue it failed a filter14:09
*** tkajinam has quit IRC14:12
*** tkajinam has joined #openstack-nova14:12
*** gokhani has quit IRC14:20
sean-k-mooneygibi: im +1 on your pps spec but i have two things i woudl like to highlihgt quickly if you have time14:21
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova-specs/+/785014/8/specs/xena/approved/qos-minimum-guaranteed-packet-rate.rst#328 and https://review.opendev.org/c/openstack/nova-specs/+/785014/8/specs/xena/approved/qos-minimum-guaranteed-packet-rate.rst#42714:22
sean-k-mooneygibi: neither are blocker to me i just want to make sure we are on the same page14:22
gibisean-k-mooney: sure14:23
gibisean-k-mooney: reading...14:23
*** ociuhandu has quit IRC14:24
*** ociuhandu has joined #openstack-nova14:25
*** ociuhandu has quit IRC14:28
*** ociuhandu has joined #openstack-nova14:29
*** Luzi has joined #openstack-nova14:32
*** Luzi has quit IRC14:33
*** dklyle has joined #openstack-nova14:41
ozzzosean-k-mooney: Here's the debug log: https://paste.ubuntu.com/p/4MrhjJs4r6/14:41
ozzzoat line 102 it says "Host filter ignoring hosts: chrnc-area51-os-compute-02.chtrse.com, chrnc-area51-os-compute-01.chtrse.com"14:41
ozzzobut it's not obvious why14:41
ozzzocompute-01 is the one where I did the grub trick14:42
*** mkrai_ has quit IRC14:47
*** Luzi has joined #openstack-nova14:59
*** Luzi has quit IRC15:06
*** macz_ has joined #openstack-nova15:12
*** gibi has quit IRC15:15
*** gibi has joined #openstack-nova15:15
*** macz_ has quit IRC15:16
*** gibi has quit IRC15:18
*** gibi has joined #openstack-nova15:18
*** fnordahl has quit IRC15:20
*** mlavalle has joined #openstack-nova15:20
*** ociuhandu has quit IRC15:30
stephenfinsean-k-mooney: looks like that stable l-c patch for os-vif failed. I assume you're going to look at disabling those now, or should I do it?15:32
ozzzosean-k-mooney: turns out it's in the conductor log: https://paste.ubuntu.com/p/tNYS3jzXsT/15:33
ozzzoat 221 it says "nova.exception.MigrationPreCheckError: Migration pre-check error: CPU doesn't have compatibility."15:34
ozzzoand then "internal error: Unknown CPU feature arch-facilities"15:34
ozzzoactually it looks like the problem starts at line 35:15:36
ozzzo2021-05-26 14:30:35.457 23 DEBUG nova.conductor.tasks.live_migrate [req-d5ac7239-4326-4d9e-9731-e4fe53a19929 - - - - -] Skipping host: chrnc-area51-os-compute-02.chtrse.com because: Migration pre-check error: CPU doesn't have compatibility.15:36
sean-k-mooneyoh the arch-facilities thing15:37
ozzzowhen I google it I find this: https://bugzilla.redhat.com/show_bug.cgi?id=165840615:38
openstackbugzilla.redhat.com bug 1658406 in libvirt "mode="host-model" VMs include broken "arch-facilities" flag name [libvirt]" [Urgent,Closed: errata] - Assigned to jdenemar15:38
sean-k-mooneythats a different upgrade issue where they chagne that between centos 8 and centos 715:38
*** alex_xu has joined #openstack-nova15:42
ozzzosean-k-mooney: how can I work around it?15:45
sean-k-mooneystephenfin: we have two fixes that work15:46
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: [template]suggest work item ordering  https://review.opendev.org/c/openstack/nova-specs/+/79319715:47
sean-k-mooneystephenfin: https://review.opendev.org/c/openstack/os-vif/+/792840 fixed lc and https://review.opendev.org/c/openstack/os-vif/+/793155 also fix it15:47
sean-k-mooneyzuul faild for other reasons15:47
sean-k-mooneyozzzo: i think you need to update the version fo qemu then hard reboot the guest15:49
sean-k-mooneyozzzo: i dont think there is a fix for that that does not invovle a guest reboot15:49
sean-k-mooneyozzzo: so effectivly you cant avoid guest downtime so your simplest solution would be to cold migrate15:50
*** ociuhandu has joined #openstack-nova15:50
ozzzook I'll experiment with cold-migration15:51
sean-k-mooneyozzzo: unfortnetly this is a libvirt abi breakage that we cannot fix in nova15:51
ozzzosean-k-mooney: got it. thanks for your advice!15:52
gibisean-k-mooney: replied in https://review.opendev.org/c/openstack/nova-specs/+/785014 I think we are more or less on the same page15:53
*** ociuhandu has quit IRC15:55
sean-k-mooneygibi: cool ill quickly skim over them one sec15:55
openstackgerritStephen Finucane proposed openstack/nova-specs master: Repropose "vm-boot-with-unaddressed-port" spec  https://review.opendev.org/c/openstack/nova-specs/+/79319915:58
sean-k-mooneygibi: cool i agree with youre respeonces so +w but just want to reinfoce that there is no way currently to make a neutron extention required unless nova is willign to stop supportin all neutron backends16:02
sean-k-mooneygibi: i have brought up this problem at the last couple of ptgs16:03
*** rpittau is now known as rpittau|afk16:03
gibisean-k-mooney: ack, then it means we will keep support for both format for a while16:03
*** lucasagomes has quit IRC16:03
gibiand I will look into adding support for making someting mandatory in neutron16:03
sean-k-mooneygibi: yes but if more them me are asking for this maybe we can actully get neutron to add a way16:03
sean-k-mooneygibi: this type of exteniton can be implemented at the m2 2 level but since they still supprot monolity plugins the only way to make it mandatory is to implemetned above the ml2 laywer16:04
sean-k-mooneyas in move it to the core api16:05
sean-k-mooneyor start requiring that monolitich plugins implemenet a subset of the extentions16:05
* bauzas needs to go off but I could chime on gibi's pps spec if needed16:06
sean-k-mooneybauzas: i dont have any open issues with nova16:06
sean-k-mooneybauzas: or the nova part of the spec16:06
sean-k-mooneybauzas: its a neuton process/rules change that im raising16:07
bauzasack, will look at the spec16:08
sean-k-mooneybauzas: i had just put a +w on it do you want me to remvoe that and leave it to you16:12
gibithere are feedback in the neutron pps spec but I can only take that tomorrow so it is totally ok to keep the nova spec open16:13
* gibi leaves the building16:13
sean-k-mooneyyou have a very well put together spec so i would also be happy addressing any nits that arise as a folow up if that works for you16:14
sean-k-mooneyi removed -w to let bauzas read the latest comments but feel free to re add it16:18
sean-k-mooneylyarwood: minor point on your spec https://review.opendev.org/c/openstack/nova-specs/+/783806/2/specs/xena/approved/ephemeral-encryption.rst#18716:21
stephenfinsean-k-mooney: +w away16:21
stephenfinwe can always revert if needed16:21
stephenfinIMO16:21
sean-k-mooneylyarwood: are we going to have COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV1 and COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV2 or COMPUTE_EPHEMERAL_ENCRYPTION_LUKS and COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV216:21
lyarwoodENCRYPTION_LUKS and ENCRYPTION_LUKSV2 are already in os-traits16:23
sean-k-mooneyoh...16:23
lyarwoodI get that v1/v2 would be nicer but I think this was done to mirror the volume encryption types we have defined in os-brick16:23
sean-k-mooneybecause we approve the spec last cycle16:23
lyarwoodthat pre-date v2 so we started with luks and then added luksv2 later16:23
lyarwoodyeah16:24
sean-k-mooneyif the traits are already there then ok16:24
lyarwoodcool cool16:24
sean-k-mooneyi feel like im +w too many thing so i just +2'd https://review.opendev.org/c/openstack/nova-specs/+/78380616:25
stephenfin+W ALL the things!16:25
*** Jeffrey4l has quit IRC16:25
stephenfinI did it for you ;)16:25
*** Jeffrey4l has joined #openstack-nova16:26
* sean-k-mooney is trying to be conservitive with merge writes16:26
* sean-k-mooney is also reading a lot of well trought out specs16:26
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Enable 'vmcoreinfo' feature by default  https://review.opendev.org/c/openstack/nova/+/75291216:26
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove 'create_fake_libvirt_mock'  https://review.opendev.org/c/openstack/nova/+/79094516:26
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Make vmcoreinfo dependent on feature flag  https://review.opendev.org/c/openstack/nova/+/77934216:26
openstackgerritStephen Finucane proposed openstack/nova master: WIP: libvirt: Make vmcoreinfo checks guest arch specific  https://review.opendev.org/c/openstack/nova/+/79094616:26
stephenfinlyarwood: Could I get your +2 on the first of those again? ^16:27
stephenfinmerge conflict :(16:27
lyarwoodyup no issues16:27
artomsean-k-mooney, so about https://bugzilla.redhat.com/show_bug.cgi?id=1963164 - you said libvirt being restarted will remove and re-add the TAP interface, right?16:33
openstackbugzilla.redhat.com bug 1963164 in openstack-nova "[update] 16.1 to 16.2 update fail on ping loss." [Urgent,New] - Assigned to nova-maint16:33
sean-k-mooneyartom: i belive it will trigger https://github.com/libvirt/libvirt/blob/c8238579fb0b1c3affbd77749ae2b2c4dfafb2d6/src/util/virnetdevopenvswitch.c#L158-L15916:34
sean-k-mooneywe shoudl get them to confirm if that is the case16:34
artomsean-k-mooney, this is OVN though16:34
sean-k-mooneyyes16:34
sean-k-mooneyform a libvirt point of view it cant tell teh difference16:34
artomOK, that code looks like OVS, but that's just my ignorance talking16:34
sean-k-mooneyovn is a replamcent for the neutorn l2 agent not a replacment for ovs16:35
artomSo we need to get #virt eyes on the BZ then...16:35
sean-k-mooneyyes to confirm if restrating will cause the port add to be reporces after a contaienr upgrade16:36
artom(We're in the wrong channel, aren't we?)16:36
sean-k-mooneyon 16/traing plug_vif is a noop for ovn16:36
artomThis was supposed to be downstream, but with the, err, kerfuffle, I have more networks open than before ;)16:36
sean-k-mooneyboth work16:36
sean-k-mooneythere is noting private related to that16:37
artomI know, just scope-wise16:37
sean-k-mooneyscope wise i am 99.99% sure this is not related to nova16:38
sean-k-mooneyor os-vif16:38
sean-k-mooneyso yes we should follow up with the libvirt folks downstream and get them to confrim16:39
*** ralonsoh has quit IRC16:42
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Remove 'USES_ALLOCATION_CANDIDATES'  https://review.opendev.org/c/openstack/nova/+/77364016:44
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Remove 'hosts_up'  https://review.opendev.org/c/openstack/nova/+/77364116:44
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove FakeScheduler (for realz)  https://review.opendev.org/c/openstack/nova/+/77364216:44
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Merge 'FilterScheduler' into base class  https://review.opendev.org/c/openstack/nova/+/77364316:44
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Merge driver into manager  https://review.opendev.org/c/openstack/nova/+/77364416:44
openstackgerritStephen Finucane proposed openstack/nova master: docs: Drop references to non-filter scheduler drivers  https://review.opendev.org/c/openstack/nova/+/77364516:44
openstackgerritStephen Finucane proposed openstack/nova master: tests: Merge 'test_utils', 'test_scheduler_utils'  https://review.opendev.org/c/openstack/nova/+/77364616:44
openstackgerritStephen Finucane proposed openstack/nova master: conf: Remove deprecated aliases  https://review.opendev.org/c/openstack/nova/+/77364716:44
stephenfinlyarwood: might ask for you to look at https://review.opendev.org/c/openstack/nova/+/773640/ again too, if you could. Again, trivial merge conflict16:45
stephenfinI'll bug bauzas for reviews on that tomorrow and try close it out16:45
stephenfinOr Monday, rather16:45
* stephenfin is out for the rest of the week16:45
lyarwoodYup no issues I can hit that again later this evening or tomorrow16:46
stephenfinPerfect, thanks. Let me know if I can return the favour16:47
openstackgerritMerged openstack/nova-specs master: Repropose flavour and image defined ephemeral storage encryption  https://review.opendev.org/c/openstack/nova-specs/+/78380617:04
*** gyee has joined #openstack-nova17:08
*** sapd1 has quit IRC17:08
*** efried has joined #openstack-nova17:09
*** eandersson has quit IRC17:23
*** rnoriega_ has quit IRC17:23
*** amotoki has quit IRC17:23
*** k_mouza_ has quit IRC17:24
*** eandersson0 has joined #openstack-nova17:25
*** k_mouza has joined #openstack-nova17:25
*** ianw_ has joined #openstack-nova17:25
*** sapd1 has joined #openstack-nova17:25
*** eandersson0 is now known as eandersson17:25
*** smcginni1 has quit IRC17:25
*** ianw has quit IRC17:25
*** ianw_ is now known as ianw17:25
*** smcginnis has joined #openstack-nova17:26
*** amotoki has joined #openstack-nova17:30
*** k_mouza has quit IRC17:30
*** k_mouza has joined #openstack-nova17:31
*** rnoriega_ has joined #openstack-nova17:32
*** k_mouza has quit IRC17:36
*** cgoncalves has quit IRC17:42
*** irclogbot_1 has quit IRC17:43
*** cgoncalves has joined #openstack-nova17:43
*** irclogbot_3 has joined #openstack-nova17:49
*** gyee has quit IRC17:52
*** openstack has quit IRC18:09
*** openstack has joined #openstack-nova18:10
*** ChanServ sets mode: +o openstack18:10
*** k_mouza has joined #openstack-nova18:12
*** k_mouza has quit IRC18:16
*** alex_xu has quit IRC18:21
*** vishalmanchanda has quit IRC18:33
*** zer0c00l|afk has quit IRC18:34
*** efried has quit IRC18:35
openstackgerritLee Yarwood proposed openstack/nova master: hardware: Use image_meta.id within get_mem_encryption_constraint  https://review.opendev.org/c/openstack/nova/+/79066018:36
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Skip swap_volume tests as part of nova-next  https://review.opendev.org/c/openstack/nova/+/79321918:36
lyarwood^ giving up trying to fix swap_volume for now as the change above is more important, core reviews would be appreciated.18:36
*** efried has joined #openstack-nova18:37
sean-k-mooneyhttps://review.opendev.org/c/openstack/os-vif/+/792840 has now passed ci18:40
sean-k-mooneystephenfin: ^ are you ok with me continutin gto back port your change18:41
*** k_mouza has joined #openstack-nova18:43
*** k_mouza has quit IRC18:48
melwittsean-k-mooney[m]: did you want stephenfin to ack that before +W?18:49
sean-k-mooney[m]melwitt:  am i think we can proceed but stephenfin  was suggesting that if it does not work we can just delete the job18:50
sean-k-mooney[m]it works so if it comes to it we can still delete the job next time it breaks18:51
melwittsean-k-mooney[m]: he just wants to delete everything18:51
melwittjk stephenfin :)18:51
sean-k-mooney[m]im going to backport that to train  later today if i can18:51
sean-k-mooney[m]well or tommorow if it gets too late18:52
*** mgariepy has quit IRC18:54
*** mgariepy has joined #openstack-nova18:54
*** whoami-rajat_ has quit IRC19:09
*** iurygregory has quit IRC19:10
*** iurygregory has joined #openstack-nova19:10
*** iurygregory has quit IRC19:11
*** andrewbonney has quit IRC19:11
*** iurygregory has joined #openstack-nova19:12
sean-k-mooneyok it will be tomorow thank melwitt for looking at that19:17
melwittyw19:18
*** openstackstatus has quit IRC19:50
*** openstackstatus has joined #openstack-nova19:51
*** ChanServ sets mode: +v openstackstatus19:51
*** _erlon_ has joined #openstack-nova19:56
*** jraju__ has quit IRC20:09
*** hamalq has joined #openstack-nova20:12
openstackgerritmelanie witt proposed openstack/nova stable/victoria: Initialize global data separately and run_once in WSGI app init  https://review.opendev.org/c/openstack/nova/+/78505920:24
*** penick has joined #openstack-nova20:28
*** penick has quit IRC20:28
*** slaweq has quit IRC20:34
*** guilhermesp has quit IRC20:36
*** slaweq has joined #openstack-nova20:37
*** guilhermesp has joined #openstack-nova20:37
*** slaweq has quit IRC20:37
*** slaweq has joined #openstack-nova20:38
*** slaweq has quit IRC20:40
*** slaweq has joined #openstack-nova20:40
*** slaweq has quit IRC20:41
openstackgerritMerged openstack/os-vif stable/victoria: Resolve dependency issues  https://review.opendev.org/c/openstack/os-vif/+/79284020:41
*** slaweq has joined #openstack-nova20:42
*** k_mouza has joined #openstack-nova20:44
*** hamalq has quit IRC20:45
*** hamalq has joined #openstack-nova20:45
*** slaweq has quit IRC20:49
*** k_mouza has quit IRC20:49
*** slaweq has joined #openstack-nova20:50
*** tobiash_ has joined #openstack-nova20:51
*** openstack has joined #openstack-nova21:25
*** ChanServ sets mode: +o openstack21:25
*** slaweq_ has joined #openstack-nova21:29
*** slaweq has quit IRC21:31
*** slaweq_ has quit IRC21:33
*** slaweq has joined #openstack-nova21:34
*** slaweq has quit IRC21:35
*** LinPeiWen has quit IRC21:38
*** slaweq has joined #openstack-nova21:39
*** slaweq has quit IRC21:41
*** slaweq has joined #openstack-nova21:42
*** amotoki has quit IRC21:43
*** amotoki has joined #openstack-nova21:46
*** sorrison has quit IRC21:50
*** melwitt has quit IRC21:51
*** melwitt has joined #openstack-nova21:51
*** k_mouza has joined #openstack-nova22:02
*** k_mouza has quit IRC22:03
*** melwitt has quit IRC22:14
*** melwitt has joined #openstack-nova22:14
*** alex_xu has joined #openstack-nova22:24
*** hamalq has quit IRC22:58
*** tosky has quit IRC22:58
*** hamalq has joined #openstack-nova22:58
*** k_mouza has joined #openstack-nova22:59
*** k_mouza has quit IRC23:04
*** hamalq has quit IRC23:30
*** hamalq has joined #openstack-nova23:30
« Tuesday, 2021-05-25 Index Thursday, 2021-05-27 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!