| *** k_mouza has quit IRC | 00:03 | |
| *** tosky has quit IRC | 00:26 | |
| *** LinPeiWen has joined #openstack-nova | 00:50 | |
| *** mlavalle has quit IRC | 01:00 | |
| *** LinPeiWen has quit IRC | 01:09 | |
| *** jamesdenton has quit IRC | 01:26 | |
| *** jamesden_ has joined #openstack-nova | 01:27 | |
| *** swp20 has quit IRC | 01:30 | |
| *** ociuhandu has joined #openstack-nova | 01:45 | |
| *** ociuhandu has quit IRC | 01:50 | |
| *** rcernin has quit IRC | 02:01 | |
| *** macz_ has quit IRC | 02:02 | |
| *** spatel_ has joined #openstack-nova | 02:03 | |
| *** rcernin has joined #openstack-nova | 02:05 | |
| *** alex_xu has quit IRC | 02:36 | |
| *** rcernin has quit IRC | 02:39 | |
| *** rcernin has joined #openstack-nova | 02:42 | |
| *** macz_ has joined #openstack-nova | 02:49 | |
| *** rcernin has quit IRC | 02:51 | |
| *** macz_ has quit IRC | 02:54 | |
| *** zzzeek has quit IRC | 02:55 | |
| *** zzzeek has joined #openstack-nova | 02:56 | |
| *** rcernin has joined #openstack-nova | 03:05 | |
| *** rcernin has quit IRC | 03:12 | |
| *** zzzeek has quit IRC | 03:15 | |
| *** zzzeek has joined #openstack-nova | 03:20 | |
| *** rcernin has joined #openstack-nova | 03:23 | |
| *** rcernin has quit IRC | 03:24 | |
| *** rcernin has joined #openstack-nova | 03:24 | |
| *** openstackgerrit has quit IRC | 03:25 | |
| *** zzzeek has quit IRC | 03:48 | |
| *** zzzeek has joined #openstack-nova | 03:51 | |
| *** spatel_ has quit IRC | 03:53 | |
| *** LinPeiWen89 has joined #openstack-nova | 04:23 | |
| *** openstackgerrit has joined #openstack-nova | 04:31 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Dynamically archive FK related records in archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/773834 | 04:31 |
|---|---|---|
| *** jamesden_ has quit IRC | 04:36 | |
| *** jamesdenton has joined #openstack-nova | 04:37 | |
| *** ociuhandu has joined #openstack-nova | 05:22 | |
| *** ociuhandu has quit IRC | 05:26 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Deprecate disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/c/openstack/nova/+/778004 | 05:37 |
| *** gyee has quit IRC | 05:52 | |
| openstackgerrit | Merged openstack/nova master: Follow up for QoS interface attach https://review.opendev.org/c/openstack/nova/+/777112 | 05:54 |
| *** jamesdenton has quit IRC | 06:21 | |
| *** jamesden_ has joined #openstack-nova | 06:22 | |
| openstackgerrit | Merged openstack/nova master: setup.cfg: Resolve warning https://review.opendev.org/c/openstack/nova/+/779449 | 06:42 |
| *** ralonsoh has joined #openstack-nova | 06:51 | |
| openstackgerrit | Merged openstack/nova master: Make nova-ceph-multistore use policy.yaml https://review.opendev.org/c/openstack/nova/+/779815 | 06:57 |
| *** ociuhandu has joined #openstack-nova | 07:02 | |
| *** ociuhandu has quit IRC | 07:06 | |
| *** ociuhandu has joined #openstack-nova | 07:08 | |
| *** ociuhandu has quit IRC | 07:12 | |
| *** slaweq has joined #openstack-nova | 07:13 | |
| *** khomesh24 has joined #openstack-nova | 07:31 | |
| *** khomesh24 has quit IRC | 07:32 | |
| *** khomesh24 has joined #openstack-nova | 07:36 | |
| *** rcernin has quit IRC | 07:40 | |
| *** lpetrut has joined #openstack-nova | 07:41 | |
| *** LinPeiWen89 has quit IRC | 07:43 | |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:46 |
| *** david-lyle has joined #openstack-nova | 07:47 | |
| *** rcernin has joined #openstack-nova | 07:47 | |
| *** dklyle has quit IRC | 07:49 | |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:50 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:52 |
| *** links has joined #openstack-nova | 07:55 | |
| *** belmoreira has joined #openstack-nova | 08:04 | |
| yonglihe | sean-k-mooney: alex_xu: could you please remove that -1 (base on discuss with alex): https://review.opendev.org/c/openstack/nova/+/771363 | 08:05 |
| *** rcernin has quit IRC | 08:06 | |
| *** aarents has joined #openstack-nova | 08:07 | |
| *** dklyle_ has joined #openstack-nova | 08:08 | |
| *** david-lyle has quit IRC | 08:10 | |
| *** ociuhandu has joined #openstack-nova | 08:11 | |
| *** ociuhandu has quit IRC | 08:11 | |
| *** tesseract has joined #openstack-nova | 08:12 | |
| *** rcernin has joined #openstack-nova | 08:17 | |
| *** alex_xu has joined #openstack-nova | 08:18 | |
| gibi | yonglihe: hi, sorry I was not able to get back to the smartnic patches yesterday | 08:20 |
| *** andrewbonney has joined #openstack-nova | 08:24 | |
| yonglihe | gibi: got, busy day. | 08:26 |
| gibi | yonglihe: I see -1s on https://review.opendev.org/c/openstack/nova/+/771363/12 does the problem resolved? | 08:26 |
| yonglihe | I post another patch to fix alex coments. | 08:27 |
| yonglihe | and there are one unit test case will posted soon. | 08:27 |
| gibi | OK | 08:28 |
| *** tosky has joined #openstack-nova | 08:33 | |
| *** ociuhandu has joined #openstack-nova | 08:38 | |
| *** ociuhandu has quit IRC | 08:42 | |
| *** jamesden_ has quit IRC | 08:44 | |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 08:45 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 08:45 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 08:45 |
| *** jamesdenton has joined #openstack-nova | 08:46 | |
| *** xinranwang has joined #openstack-nova | 08:47 | |
| yonglihe | gibi alex_xu, sean-k-mooney, xinranwang: test cases added. | 08:48 |
| yonglihe | gibi: all the problem resolved, https://review.opendev.org/c/openstack/nova/+/771363/13 | 08:51 |
| gibi | reading it ... | 08:51 |
| *** tosky_ has joined #openstack-nova | 08:52 | |
| *** tosky is now known as Guest86814 | 08:53 | |
| *** tosky_ is now known as tosky | 08:53 | |
| *** Guest86814 has quit IRC | 08:55 | |
| *** ociuhandu has joined #openstack-nova | 08:57 | |
| *** rcernin has quit IRC | 09:01 | |
| *** lucasagomes has joined #openstack-nova | 09:06 | |
| *** derekh has joined #openstack-nova | 09:15 | |
| *** rcernin has joined #openstack-nova | 09:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add note about rescuing bfv instances with the 2.87 microversion https://review.opendev.org/c/openstack/nova/+/779479 | 09:42 |
| lyarwood | whops | 09:43 |
| *** zzzeek has quit IRC | 09:43 | |
| *** zzzeek has joined #openstack-nova | 09:46 | |
| lyarwood | Type 'yes' to confirm, other to cancel: yes | 09:47 |
| lyarwood | Aborting. | 09:47 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add note about rescuing bfv instances with the 2.87 microversion https://review.opendev.org/c/openstack/nova/+/779479 | 09:47 |
| lyarwood | >.< git-review WHY DO YOU HATE ME?! | 09:47 |
| *** rcernin has quit IRC | 09:47 | |
| bauzas | folks, I'll resume reviewing the uefi secure boot series starting with https://review.opendev.org/c/openstack/nova/+/779302/2 | 09:48 |
| bauzas | stephenfin: lyarwood: gibi: ^ | 09:48 |
| stephenfin | ta | 09:48 |
| gibi | ack | 09:49 |
| stephenfin | lyarwood: You can probably bump your +1 to +2 on this now? https://review.opendev.org/c/openstack/nova/+/779303/ | 09:50 |
| stephenfin | It failed, but not for related reasons | 09:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'VDPA' to 'PciDeviceType' https://review.opendev.org/c/openstack/nova/+/777481 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Move PCI host device parsing to 'host' https://review.opendev.org/c/openstack/nova/+/779851 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add vDPA nodedev parsing https://review.opendev.org/c/openstack/nova/+/770533 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add guest generation for vDPA https://review.opendev.org/c/openstack/nova/+/770532 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: pci: Add vDPA vnic to PCI request mapping and filtering https://review.opendev.org/c/openstack/nova/+/778350 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: add hw:mlock extra spec https://review.opendev.org/c/openstack/nova/+/778347 | 09:51 |
| lyarwood | stephenfin: ack yeah sorry will do | 09:51 |
| stephenfin | kashyap: Can you revisit https://review.opendev.org/c/openstack/nova/+/776681/6/nova/virt/libvirt/driver.py#5917 and see if you're happy with my response RE: the 'optional' secure boot policy? | 09:52 |
| kashyap | stephenfin: Morning, will do | 09:52 |
| kashyap | stephenfin: Yeah, that response is fair enough. We expect people to read the docs. We can't put a guard against every potential foot-gun | 09:55 |
| stephenfin | yup, exactly | 10:00 |
| kashyap | stephenfin: Also, I like the clean test in test_driver.py; thakns! | 10:00 |
| stephenfin | I plan to resolve the nvram issue as a bug after feature freeze | 10:00 |
| * lyarwood steals foot-gun for future use | 10:00 | |
| kashyap | stephenfin: Right; that's fine | 10:01 |
| stephenfin | the series is already too big to bring that in, IMO | 10:01 |
| kashyap | Agree | 10:01 |
| *** ociuhandu has quit IRC | 10:01 | |
| *** ociuhandu has joined #openstack-nova | 10:02 | |
| kashyap | And it's a more time-taking one anyway; we shouldn't block on it for now. | 10:02 |
| * stephenfin has to go to Limerick for house stuff and will be back after lunch o/ | 10:04 | |
| *** rcernin has joined #openstack-nova | 10:04 | |
| kashyap | Don't know where you are at this moment :-) | 10:05 |
| *** zzzeek has quit IRC | 10:11 | |
| *** ociuhandu has quit IRC | 10:11 | |
| *** tesseract has quit IRC | 10:14 | |
| *** zzzeek has joined #openstack-nova | 10:15 | |
| bauzas | stephenfin: slight -1 for https://review.opendev.org/c/openstack/nova/+/779302 | 10:16 |
| *** ociuhandu has joined #openstack-nova | 10:16 | |
| bauzas | I need to get my daughters from the school but please reply | 10:16 |
| bauzas | and then I'll look later | 10:16 |
| *** dtantsur|afk is now known as dtantsur | 10:17 | |
| *** tesseract has joined #openstack-nova | 10:17 | |
| *** rcernin has quit IRC | 10:20 | |
| *** ociuhandu has quit IRC | 10:25 | |
| *** k_mouza has joined #openstack-nova | 10:26 | |
| *** LinPeiWen has joined #openstack-nova | 10:27 | |
| *** k_mouza has quit IRC | 10:31 | |
| *** jangutter_ has quit IRC | 10:41 | |
| *** jangutter has joined #openstack-nova | 10:42 | |
| *** ociuhandu has joined #openstack-nova | 10:46 | |
| artom | stephenfin, gibi, with sean-k-mooney's port NUMA affinity patch on top of my socket stuff, we found an issue with PCI devices that have parents | 10:57 |
| lyarwood | bauzas: stephenfin just stepped out but I replied in that change, I'm not sure what you're suggesting tbh. | 10:58 |
| artom | Because I was setting 'socket' *on* the pool, it b0rked comparison for parent PFs. I've had to fix and push again: https://review.opendev.org/c/openstack/nova/+/772779 | 10:58 |
| sean-k-mooney | the fix artom did was to get teh list of numa node related to the sockets the guest is on and then require the pool be in one of those numa nodes | 11:00 |
| artom | Yep - that way, nothing is being set on the pool, no side effect surprises | 11:01 |
| artom | It's not a radical departure from what was there before :) | 11:01 |
| *** zzzeek has quit IRC | 11:03 | |
| sean-k-mooney | hehe its litrally https://review.opendev.org/c/openstack/nova/+/772779/17..18/nova/pci/stats.py | 11:05 |
| sean-k-mooney | so ya +9-14 lines | 11:05 |
| *** rcernin has joined #openstack-nova | 11:07 | |
| *** jangutter has quit IRC | 11:07 | |
| lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/735947 - btw I -1'd this earlier, more for my own education and understanding as the code LGTM but the commit wasn't clear on the reasoning for this. | 11:07 |
| *** jangutter has joined #openstack-nova | 11:07 | |
| *** zzzeek has joined #openstack-nova | 11:08 | |
| gibi | artom: ack, looks good to me | 11:09 |
| gibi | lyarwood: I have to get back to that | 11:10 |
| *** k_mouza has joined #openstack-nova | 11:11 | |
| artom | gibi, mcuh thanks! | 11:12 |
| sean-k-mooney | off the top of my head i dont rememebr all the detail but the highlevle reasoning is that hyperthreading affect the entire host ans sicne cpu are part of the unname greoup these should also be. it would be invalid today to have 2 named groups one that requested HT on and the other HT off for the same host | 11:12 |
| openstackgerrit | Merged openstack/nova master: apidb: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759405 | 11:12 |
| sean-k-mooney | i rememebr suggesting that we shoudl perhaps only ally HW_CPU_* in general in the unamed group becasue at the time i did not think there was ever a valid usecase for varing them in depently in the named groups | 11:13 |
| sean-k-mooney | lyarwood:^ | 11:13 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/735947/5/nova/api/validation/extra_specs/traits.py#26 | 11:15 |
| *** jawad_axd has joined #openstack-nova | 11:17 | |
| *** k_mouza has quit IRC | 11:18 | |
| *** k_mouza has joined #openstack-nova | 11:18 | |
| *** k-s-dean has joined #openstack-nova | 11:19 | |
| gibi | I think I agree with sean-k-mooney here | 11:21 |
| sean-k-mooney | lyarwood: actully i remember more of the context now filling it in to the patch | 11:21 |
| lyarwood | k thanks I also need to drop in a min to pick up some new glasses, I'll get back to the review this afternoon | 11:25 |
| sean-k-mooney | lyarwood: https://review.opendev.org/c/openstack/nova/+/735947/5//COMMIT_MSG#13 | 11:26 |
| *** sapd1 has joined #openstack-nova | 11:41 | |
| *** jangutter has quit IRC | 11:42 | |
| *** jangutter has joined #openstack-nova | 11:42 | |
| *** ociuhandu has quit IRC | 11:51 | |
| *** rcernin has quit IRC | 11:58 | |
| *** jangutter_ has joined #openstack-nova | 11:59 | |
| *** jangutter has quit IRC | 12:02 | |
| *** macz_ has joined #openstack-nova | 12:06 | |
| *** macz_ has quit IRC | 12:11 | |
| *** jamesdenton has quit IRC | 12:13 | |
| *** jamesdenton has joined #openstack-nova | 12:14 | |
| *** rcernin has joined #openstack-nova | 12:23 | |
| *** emmadavis has joined #openstack-nova | 12:25 | |
| *** emmadavis has quit IRC | 12:28 | |
| *** emmadavis has joined #openstack-nova | 12:28 | |
| *** rcernin has quit IRC | 12:29 | |
| *** rcernin has joined #openstack-nova | 12:41 | |
| *** rcernin has quit IRC | 12:46 | |
| *** rcernin has joined #openstack-nova | 12:52 | |
| *** mdbooth has joined #openstack-nova | 12:53 | |
| *** rcernin has quit IRC | 12:57 | |
| *** rcernin has joined #openstack-nova | 12:58 | |
| *** openstack has joined #openstack-nova | 13:17 | |
| *** ChanServ sets mode: +o openstack | 13:17 | |
| *** bbowen has joined #openstack-nova | 13:31 | |
| *** __ministry1 has joined #openstack-nova | 13:41 | |
| *** dklyle_ has quit IRC | 13:43 | |
| *** ociuhandu has joined #openstack-nova | 13:44 | |
| *** jangutter has joined #openstack-nova | 13:45 | |
| *** jangutter_ has quit IRC | 13:48 | |
| *** mjturek has joined #openstack-nova | 13:54 | |
| *** sapd1 has joined #openstack-nova | 14:00 | |
| gibi | yonglihe: finshed reading the main smartnic patch I still have issues. Also I think you missed my earlier request to add a set of functional tests | 14:01 |
| gibi | alex_xu: ^^ fyi | 14:09 |
| gibi | is there any patch that needs my immediate attention? | 14:20 |
| stephenfin | sean-k-mooney: question: is this change necessary? https://review.opendev.org/c/openstack/nova/+/770533/10/nova/virt/libvirt/host.py#1262 | 14:22 |
| stephenfin | I can't figure out what uses it? I don't think we ever finished the NIC capability feature and that's the only thing that code was used for previously | 14:23 |
| sean-k-mooney | the elif? | 14:23 |
| sean-k-mooney | yes the elif is | 14:23 |
| stephenfin | adding the 'vdpa' field to the 'capabilities' | 14:23 |
| stephenfin | dic | 14:23 |
| stephenfin | *dict | 14:23 |
| sean-k-mooney | its used to get the path to add to the xml | 14:24 |
| stephenfin | which will be saved in the 'extra_info' field of the 'PciDevice' table | 14:24 |
| stephenfin | I don't think it is | 14:25 |
| stephenfin | https://review.opendev.org/c/openstack/nova/+/770532/10/nova/virt/libvirt/vif.py#501 | 14:25 |
| sean-k-mooney | when generating the xml for the interface we add the vdpa path not the pci addres or the parent | 14:25 |
| stephenfin | that's calling the 'get_vdpa_device_path' | 14:25 |
| stephenfin | which is pretty self-contained and inspect the XML from libvirt directly https://review.opendev.org/c/openstack/nova/+/770533/10/nova/virt/libvirt/host.py#1333 | 14:25 |
| sean-k-mooney | ach right | 14:26 |
| stephenfin | so is that something you forgot to cleanup? | 14:26 |
| sean-k-mooney | both will work | 14:26 |
| stephenfin | personally, I'd rather we didn't have to pass through an instance of 'Host' | 14:26 |
| stephenfin | if that's an option | 14:26 |
| sean-k-mooney | we do not have the pci request here | 14:27 |
| sean-k-mooney | so we cant get if form the db like i planned orginally | 14:27 |
| sean-k-mooney | thats why im looking it up i think | 14:27 |
| sean-k-mooney | i will need to look at this in context again sorry | 14:28 |
| stephenfin | okay | 14:28 |
| stephenfin | I'll play around with it a little more, see if I can make sense of it :) | 14:28 |
| *** jangutter_ has joined #openstack-nova | 14:29 | |
| sean-k-mooney | so we dont have the pci devices form the db in the virt driver | 14:30 |
| sean-k-mooney | and at present we do not have the mapping form the neutorn port to the pci request ourside of the network_request object | 14:30 |
| sean-k-mooney | so to remove passing in host we would have to pass in the network requiest to lookup the requite id then do a db lookup | 14:31 |
| sean-k-mooney | that would be much more expensive | 14:31 |
| stephenfin | can we pass information through as part of the binding profile, like we do for SR-IOV? | 14:31 |
| sean-k-mooney | i personally have been using the vdpa path in the pci_devices table to debug this and ensure the xml is useing the correct path for the device tha was saved | 14:31 |
| sean-k-mooney | stephenfin: i really dont want to do that | 14:32 |
| sean-k-mooney | because i want to stop using the binding procile for the xml generation entirely soon | 14:32 |
| gibi | somebody opened ~80 new bugs to nova based on fault injection. e.g. https://bugs.launchpad.net/nova/+bug/1918340 | 14:32 |
| openstack | Launchpad bug 1918340 in OpenStack Compute (nova) "Fault Injection #1 - improve unit test effectiveness" [Undecided,New] | 14:32 |
| stephenfin | e.g. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L242-L246 | 14:32 |
| *** jangutter has quit IRC | 14:32 | |
| sean-k-mooney | close them all with we do not consider bugs cause by falut injectoin to be valid? | 14:32 |
| sean-k-mooney | stephenfin: ya i want to remove that use of the profile | 14:33 |
| stephenfin | sean-k-mooney: could we do that wholesale though? | 14:33 |
| sean-k-mooney | we never should have done that in the first place it was a hack | 14:33 |
| stephenfin | I'm sure there's a good reason not to do it, but it's a bit weird having two different ways to do things now | 14:33 |
| sean-k-mooney | right now im using that | 14:34 |
| sean-k-mooney | to get the pci addres of the parent vf | 14:34 |
| sean-k-mooney | but in the futre i want to store this info in our own data stucure in nova db somewhere | 14:34 |
| sean-k-mooney | and pass it in to build/attach ectra | 14:35 |
| yonglihe | gibi, then i got work to do. -:) | 14:35 |
| sean-k-mooney | stephenfin: by the way im currently writing two patches. one to block booting vms with ports of type vdpa until its supproted and a second to block unsupported operations in general | 14:47 |
| sean-k-mooney | similar to how we block api calls with cyborg if they are not supported yet with a 403. | 14:47 |
| stephenfin | makes sense | 14:49 |
| *** k_mouza_ has joined #openstack-nova | 14:50 | |
| *** k_mouza has quit IRC | 14:54 | |
| kashyap | stephenfin: For later, you might also find this useful to know about: https://github.com/rhuefi/qemu-ovmf-secureboot | 14:59 |
| *** rcernin has joined #openstack-nova | 14:59 | |
| kashyap | (Fedora and other distros already ship a variant of this tool we wrote in the past.) | 14:59 |
| *** derekh has quit IRC | 15:01 | |
| *** derekh has joined #openstack-nova | 15:01 | |
| *** derekh has quit IRC | 15:02 | |
| *** rcernin has quit IRC | 15:04 | |
| *** efried has quit IRC | 15:07 | |
| *** derekh has joined #openstack-nova | 15:08 | |
| *** efried has joined #openstack-nova | 15:08 | |
| *** spotz has joined #openstack-nova | 15:10 | |
| *** k_mouza_ has quit IRC | 15:15 | |
| *** k_mouza has joined #openstack-nova | 15:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add functional tests for UEFI, secure boot https://review.opendev.org/c/openstack/nova/+/776682 | 15:16 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove duplicated 'start_compute' helper https://review.opendev.org/c/openstack/nova/+/776683 | 15:16 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document UEFI secure boot feature https://review.opendev.org/c/openstack/nova/+/776684 | 15:16 |
| stephenfin | lyarwood: removed that unnecessary ADMIN_API from the functional test ^ | 15:16 |
| *** ociuhandu has quit IRC | 15:16 | |
| *** ociuhandu has joined #openstack-nova | 15:17 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758733 | 15:17 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] gate: Skip ceph tests after plugin moved to Octopus release https://review.opendev.org/c/openstack/nova/+/780014 | 15:17 |
| lyarwood | elod / melwitt ; ^ fun times with ceph on stable/train btw | 15:17 |
| lyarwood | stephenfin: ack thanks | 15:17 |
| sean-k-mooney | lyarwood: you could pin the plugin to an older commit no? | 15:21 |
| *** ociuhandu has quit IRC | 15:22 | |
| sean-k-mooney | lyarwood: you just do https://github.com/SeanMooney/ci-sean-mooney/blob/main/zuul.d/jobs.yaml#L36 | 15:22 |
| sean-k-mooney | required-projects: | 15:22 |
| sean-k-mooney | - name: openstack/devstack | 15:22 |
| sean-k-mooney | override-checkout: master | 15:22 |
| sean-k-mooney | but in this case override the ceph plugin | 15:22 |
| sean-k-mooney | so you can continue to deploy what ever it had before | 15:23 |
| *** tobias-urdin has joined #openstack-nova | 15:23 | |
| elod | lyarwood: yikes. thanks for looking it and fixing! is this blocking train and older branches? | 15:23 |
| lyarwood | yeah the issue is these jobs aren't zuul native on stable/train and manually check out the plugin | 15:23 |
| lyarwood | elod: I assume <=stable/train with the nova-live-migration failures | 15:24 |
| lyarwood | elod: given grenade isn't running prior to stable/train right? | 15:24 |
| lyarwood | sean-k-mooney: that's a neat hack btw, I wansn't aware of it. | 15:25 |
| lyarwood | sean-k-mooney: we could limit the checkout in the hook script to a known good commit to keep ceph coverage I guess | 15:25 |
| sean-k-mooney | we use it in a number of places for stable branches | 15:25 |
| sean-k-mooney | lyarwood: tempest is one case sicne it branchless | 15:25 |
| * lyarwood adds a note | 15:26 | |
| sean-k-mooney | lyarwood: but yes pinning to a know good commit or actully taging it and pinnging to that tag would proably be the way to go | 15:26 |
| sean-k-mooney | if it was zuul native i think that can be anything that is vaild for a git checkout command | 15:27 |
| sean-k-mooney | so commit tag or branch | 15:27 |
| lyarwood | right, let me do it that way actually so we don't drop coverage | 15:27 |
| *** ociuhandu has joined #openstack-nova | 15:28 | |
| sean-k-mooney | where is the job defiend | 15:28 |
| sean-k-mooney | the enable plugin line optionally takes a git ref | 15:28 |
| sean-k-mooney | which is the branch/tag/commit to use | 15:28 |
| *** lpetrut has quit IRC | 15:29 | |
| sean-k-mooney | you can do it trivally in the lcoal.conf if you can change the enable_plugin line | 15:29 |
| *** spatel_ has joined #openstack-nova | 15:29 | |
| *** jmlowe has quit IRC | 15:30 | |
| sean-k-mooney | oh ... https://github.com/openstack/nova/blob/stable/train/gate/live_migration/hooks/ceph.sh#L13 | 15:30 |
| lyarwood | yeah there | 15:30 |
| sean-k-mooney | why were we ever doing that | 15:30 |
| lyarwood | like I said, tis fun | 15:30 |
| lyarwood | not my code ./me runs | 15:30 |
| lyarwood | and it's pre-zuul | 15:30 |
| sean-k-mooney | right but even pre-zuul this was wrong | 15:30 |
| lyarwood | I'm being an idiot, I can just export CEPH_RELEASE | 15:33 |
| sean-k-mooney | ah the plugin supprot that as a configurable | 15:33 |
| sean-k-mooney | you could add --branch to the git clone too | 15:33 |
| *** jmlowe has joined #openstack-nova | 15:34 | |
| *** ociuhandu has quit IRC | 15:34 | |
| lyarwood | sean-k-mooney: the plugin is branchless | 15:35 |
| sean-k-mooney | ya but i tought that worked with commit too | 15:35 |
| sean-k-mooney | it does not | 15:36 |
| sean-k-mooney | i was expecting use to be using it like this | 15:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] gate: Pin CEPH_RELEASE to nautilus in LM hook https://review.opendev.org/c/openstack/nova/+/780014 | 15:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758733 | 15:40 |
| sean-k-mooney | export DEVSTACK_LOCAL_CONFIG="enable_plugin devstack-plugin-ceph https://opendev.org/openstack/devstack-plugin-ceph <git commit>" | 15:40 |
| sean-k-mooney | like this https://docs.openstack.org/devstack/latest/plugins.html#legacy-project-config-jobs | 15:41 |
| kashyap | stephenfin: What is "rubric" in rST lingo? (I know the English word itself, but first time I see in rST) | 15:41 |
| kashyap | stephenfin: My guess is: "Heading" | 15:41 |
| stephenfin | Yeah, it's a heading that doesn't affect the structure of the document | 15:41 |
| kashyap | "Under the rubric of Y" | 15:41 |
| kashyap | Right; thx | 15:42 |
| stephenfin | So it won't appear in a table of contents | 15:42 |
| kashyap | stephenfin: Nice; I bow to your rST wisdom | 15:42 |
| sean-k-mooney | ist that what cascade list use internally | 15:42 |
| sean-k-mooney | i always hade when heading are not linkable in our docs | 15:42 |
| sean-k-mooney | *hate | 15:42 |
| stephenfin | cascade list? | 15:43 |
| gibi | nova meeting will start in 16 minutes on #openstack-meeting-3 | 15:43 |
| sean-k-mooney | stephenfin: what we sue here https://raw.githubusercontent.com/openstack/nova/master/doc/source/user/flavors.rst | 15:44 |
| sean-k-mooney | for the titles | 15:44 |
| stephenfin | oh, definition lists | 15:44 |
| sean-k-mooney | yep those | 15:44 |
| stephenfin | no, similar but different | 15:44 |
| stephenfin | rubric is it's own thing | 15:45 |
| sean-k-mooney | ah ok | 15:45 |
| stephenfin | similar to an aside (warning, tip, information, ...) | 15:45 |
| sean-k-mooney | can we make definiton lists linkable by the way | 15:46 |
| sean-k-mooney | e.g. with a css selector | 15:46 |
| kashyap | stephenfin: Thx also for cleaning up the Hyper-V docs, and as is your wont, general "docs excellency". Added my +1, FWIW. | 15:46 |
| sean-k-mooney | the curent issue is while the definitoin list title elemnt is sepreate it does not have an id | 15:47 |
| *** dklyle has joined #openstack-nova | 15:47 | |
| sean-k-mooney | so you cant do http://.../#id-of-list-item-title | 15:47 |
| bauzas | gibi: I'll have to bail out from the nova meeting after 10 mins #curfew | 15:47 |
| bauzas | gibi: no stories to tell from the libvirt subteam | 15:48 |
| *** ociuhandu has joined #openstack-nova | 15:48 | |
| stephenfin | sean-k-mooney: I'm not sure off the top of my head, tbh | 15:48 |
| sean-k-mooney | i think i asked you before and you said no | 15:49 |
| stephenfin | I don't see any href on any of the definitions in the policy doc so I don't think Sphinx does it natively | 15:49 |
| stephenfin | https://docs.openstack.org/nova/latest/configuration/policy.html | 15:49 |
| sean-k-mooney | stephenfin: they should not be hrefs | 15:49 |
| stephenfin | sorry, ids | 15:49 |
| sean-k-mooney | right so nova has one https://docs.openstack.org/nova/latest/configuration/policy.html#nova | 15:50 |
| sean-k-mooney | but none of the other items | 15:50 |
| stephenfin | whereas we do have them for the config doc https://docs.openstack.org/nova/latest/configuration/config.html | 15:50 |
| sean-k-mooney | yep we dont use definition list there i think | 15:50 |
| stephenfin | that's because 'oslo_policy.sphinxext' uses a custom domain, which means you can index them | 15:50 |
| sean-k-mooney | we generate that form code | 15:50 |
| stephenfin | sorry, 'oslo_config.sphinxext' | 15:50 |
| sean-k-mooney | yep | 15:50 |
| stephenfin | whereas 'oslo_policy.sphinxext' is just using definition lits | 15:51 |
| stephenfin | lists | 15:51 |
| stephenfin | we could improve that, of course | 15:51 |
| stephenfin | I just haven't gotten to do it yet | 15:51 |
| gibi | bauzas: ack | 15:51 |
| gibi | bauzas: thanks | 15:51 |
| sean-k-mooney | stephenfin: ya its more of a minor annowyance but it also affect ones we write by hand | 15:51 |
| *** jangutter has joined #openstack-nova | 15:52 | |
| sean-k-mooney | althoguh when writing them by hand we can just add anchors to fix it | 15:52 |
| sean-k-mooney | which we do in thing like the schduler doc if i remeber correctly | 15:52 |
| sean-k-mooney | oh we dont | 15:53 |
| sean-k-mooney | it has the same issue | 15:53 |
| stephenfin | I have a huge doc rework to fix that | 15:54 |
| sean-k-mooney | anyway not importnat right now just annoying ux | 15:54 |
| stephenfin | I'll get people to take a look after feature freeze | 15:54 |
| bauzas | stephenfin: the os secure boot eventually got my approval till the func test | 15:54 |
| bauzas | stephenfin: waiting for gerrit to tell me about the func test | 15:54 |
| bauzas | stephenfin: but I guess you got no issues locally, right? | 15:54 |
| *** jangutter_ has quit IRC | 15:54 | |
| stephenfin | I tested before I pushed. Works as expected, if that helps | 15:55 |
| stephenfin | and it won't merge if the CI isn't happy even with +W | 15:55 |
| stephenfin | as we're seeing :'( | 15:55 |
| *** ociuhandu has quit IRC | 15:57 | |
| *** ociuhandu has joined #openstack-nova | 15:57 | |
| *** __ministry1 has quit IRC | 15:58 | |
| artom | stephenfin, hey, so turns out with sean-k-mooney's port affinity patch on top of mine, we discovered an issue with devices that have parents | 15:59 |
| artom | I was setting pool['socket'], and that cause bad side effects when doing pool comparisons later on | 15:59 |
| artom | So I had to respin and kick it out of the gate | 16:00 |
| *** macz_ has joined #openstack-nova | 16:00 | |
| *** macz_ has quit IRC | 16:01 | |
| gibi | and I'm already +2 :) | 16:01 |
| *** macz_ has joined #openstack-nova | 16:01 | |
| bauzas | dansmith: I haven't forgotten the rpc changes but reviews day hell here | 16:25 |
| bauzas | tomorrow, that's better. | 16:25 |
| * bauzas jumps off before the shops close in 30 mins | 16:25 | |
| *** prometheanfire has joined #openstack-nova | 16:34 | |
| *** jangutter_ has joined #openstack-nova | 16:37 | |
| *** jangutter has quit IRC | 16:40 | |
| dansmith | bauzas:ack | 16:40 |
| dansmith | sean-k-mooney: you just too good for the nova meeting these days? | 16:41 |
| sean-k-mooney | sorry forgot it was time for it joining | 16:41 |
| dansmith | sean-k-mooney: so I asked a question there expecting maybe a response from you and realized you weren't around | 16:42 |
| sean-k-mooney | dansmith: ah its just over | 16:42 |
| dansmith | sean-k-mooney: related to the glance metadef api, | 16:42 |
| dansmith | you probably saw the OSSN and query about getting ops feedback | 16:42 |
| dansmith | but I (and stephenfin) thought you might be aware of how this is used | 16:42 |
| sean-k-mooney | the metadef api | 16:43 |
| dansmith | I think horizon uses it to present templates of nova metadata you can apply to things in some way | 16:43 |
| sean-k-mooney | its use by heat i belive and yest its used by horizon | 16:43 |
| dansmith | but it's not clear to me if that's like really useful, widely-used, etc | 16:43 |
| sean-k-mooney | to generate the view that is ues to add flaovr extra specs and image poeprtyes | 16:43 |
| dansmith | okay, does it allow you to create those things or just use it to show? | 16:44 |
| sean-k-mooney | you can create them too | 16:44 |
| sean-k-mooney | i belive that is admin only | 16:44 |
| dansmith | it's not | 16:44 |
| dansmith | at least on the glance side | 16:44 |
| sean-k-mooney | really | 16:44 |
| dansmith | it's also not properly isolated, | 16:44 |
| sean-k-mooney | well its not ment ot be per tenant | 16:45 |
| sean-k-mooney | its ment to be a global registry | 16:45 |
| dansmith | which means you can use (apparently horizon) to poke and see if other tenants have things defined | 16:45 |
| sean-k-mooney | right but this was not ment to be per tenant | 16:45 |
| dansmith | sean-k-mooney: it's completely wide open by default | 16:45 |
| sean-k-mooney | ok so the issue there is that writing to it is allowd | 16:46 |
| sean-k-mooney | reading form it by default is fien for everyone | 16:46 |
| dansmith | sean-k-mooney: also, it is clearly tenantified a little bit, just not well | 16:46 |
| sean-k-mooney | is see i was not aware of that | 16:46 |
| dansmith | sean-k-mooney: so tenants can create things that aren't shown to other tenants, but if you know the name, you can see it | 16:46 |
| sean-k-mooney | ah i see | 16:46 |
| sean-k-mooney | i did not see the OSSN for this by the way | 16:47 |
| sean-k-mooney | so didnt know that context | 16:47 |
| dansmith | it seems to be that namespace is the thing that is tied to the tenant, | 16:47 |
| dansmith | and you create things tied to that namespace that are private to you, but if someone knows the name (or happens to pick the same one you did) then ... oopsie, here's their data | 16:47 |
| dansmith | exposure seems limited to just names, which may be harmless, but may have customer names or infrastructure details of course | 16:48 |
| dansmith | and the other issue is that open by default, with no creation controls, you can fill the database for fun and profit :) | 16:48 |
| sean-k-mooney | ya so what the api was intended for was to provide a central regeistry for all falovr extra specs, image proertes, host aggreate and volumen metadata key and the allows values | 16:49 |
| dansmith | seems odd to put that in glance, but I understand now that's the goal, at least | 16:50 |
| sean-k-mooney | basically it was created as a programatic way to document and encode the value values for all the tunables user and operations might use when creating image/flavor/aggreates and volumnes | 16:50 |
| sean-k-mooney | well it was adding very early on | 16:51 |
| dansmith | yeah, so there have been contributions to the metadefs since the original thing, presumably because someone wants something to show up in horizon | 16:51 |
| sean-k-mooney | well before we added stephenfin flavor validation stuff i was pushing for use to keep it in sysnc to defien the falvor extra specs | 16:51 |
| *** belmoreira has quit IRC | 16:53 | |
| *** khomesh24 has quit IRC | 16:54 | |
| gibi | stephenfin: will you look at the two artom's and sean-k-mooney's numa policy patches as second core? | 16:59 |
| stephenfin | yup, on it | 16:59 |
| *** rcernin has joined #openstack-nova | 17:00 | |
| gibi | thanks | 17:00 |
| *** lucasagomes has quit IRC | 17:00 | |
| *** mlavalle has joined #openstack-nova | 17:02 | |
| *** belmoreira has joined #openstack-nova | 17:06 | |
| *** bbowen has quit IRC | 17:07 | |
| *** tesseract has quit IRC | 17:07 | |
| *** fnordahl has joined #openstack-nova | 17:11 | |
| *** jamesdenton has quit IRC | 17:16 | |
| *** jamesdenton has joined #openstack-nova | 17:16 | |
| *** rcernin has quit IRC | 17:16 | |
| stephenfin | gibi: done on both | 17:24 |
| gibi | stephenfin: any issue? | 17:24 |
| stephenfin | Nope. Good catch on the socket policy though | 17:24 |
| gibi | reno fix can land after FF so I'm not worrying about it | 17:25 |
| stephenfin | yup, agreed | 17:25 |
| gibi | lyarwood, bauzas, dansmith: we need a second core for an easy refactor patch https://review.opendev.org/c/openstack/nova/+/779851 the rest of the series is reviewd by stephen but his patch is stephen's so we need somebody else to get vdpa to land | 17:26 |
| gibi | stephenfin: thanks | 17:26 |
| lyarwood | looking | 17:26 |
| *** jangutter has joined #openstack-nova | 17:26 | |
| gibi | lyarwood: thanks | 17:27 |
| *** jangutter_ has quit IRC | 17:30 | |
| lyarwood | gibi: done | 17:31 |
| gibi | lyarwood: thanks | 17:33 |
| *** gyee has joined #openstack-nova | 17:35 | |
| * lyarwood calls it a day \o | 17:40 | |
| gibi | lyarwood: o/ | 17:48 |
| *** jangutter_ has joined #openstack-nova | 17:53 | |
| *** jangutter has quit IRC | 17:57 | |
| *** derekh has quit IRC | 18:01 | |
| *** andrewbonney has quit IRC | 18:12 | |
| *** mlavalle has quit IRC | 18:23 | |
| *** mlavalle has joined #openstack-nova | 18:24 | |
| *** ociuhandu has quit IRC | 18:32 | |
| *** k_mouza has quit IRC | 18:33 | |
| *** k_mouza has joined #openstack-nova | 18:37 | |
| *** mlavalle has quit IRC | 18:38 | |
| *** dtantsur is now known as dtantsur|afk | 18:39 | |
| *** sapd1 has quit IRC | 18:43 | |
| *** ralonsoh has quit IRC | 18:48 | |
| *** k_mouza has quit IRC | 18:53 | |
| openstackgerrit | sean mooney proposed openstack/nova master: block vm boot with vdpa ports https://review.opendev.org/c/openstack/nova/+/780065 | 19:00 |
| *** hamalq has joined #openstack-nova | 19:01 | |
| *** _gryf has joined #openstack-nova | 19:01 | |
| sean-k-mooney | FYI that is only needed if we dont merge the VDPA inital boot support to ensure that even though neutron support the vdpa type we do not try to boot with it until we do | 19:03 |
| gibi | sean-k-mooney: I'm reading vdpa right now | 19:04 |
| gibi | sean-k-mooney: I have a question | 19:04 |
| sean-k-mooney | ask away | 19:05 |
| gibi | sean-k-mooney: do we need to make the VDPA devs unavaible when the related PF is become allocated? | 19:05 |
| gibi | s/is become/becomes | 19:05 |
| sean-k-mooney | yes we should | 19:05 |
| sean-k-mooney | i know wehere we do that let me check if it will do that | 19:05 |
| gibi | I'm looking at https://review.opendev.org/c/openstack/nova/+/778350/7/nova/pci/stats.py#215 | 19:06 |
| gibi | _handle_device_dependents | 19:06 |
| sean-k-mooney | yep | 19:06 |
| sean-k-mooney | so that will mark the parent as unavaiable if we use a vf | 19:06 |
| gibi | and I see that we make the PF unavailable when we allocate a VF or a VDPA | 19:06 |
| sean-k-mooney | *vdpa dev | 19:06 |
| gibi | yepp | 19:06 |
| gibi | but what about the other direction | 19:06 |
| sean-k-mooney | so you are saying we shoudl do the reverse too | 19:07 |
| gibi | wondering | 19:07 |
| gibi | if I allocated the PF | 19:07 |
| gibi | then all the devs under the PF should not be used any more | 19:07 |
| sean-k-mooney | ya i did not think of that edgecase because i only whitelisted the VF in the pci whitelist not the PF | 19:07 |
| *** ociuhandu has joined #openstack-nova | 19:07 | |
| sean-k-mooney | gibi: correct | 19:07 |
| gibi | I guess there is also the case when both the VF and the related VDPA is whitelsited and I allocate the VF | 19:08 |
| sean-k-mooney | it might just work however depending on how remove_device works | 19:08 |
| sean-k-mooney | gibi: no we will only ever get either the VF or VDPA divce listed | 19:08 |
| sean-k-mooney | im basically taking the VF recored and changing its type | 19:09 |
| gibi | sean-k-mooney: so when the admin creates the VDPA dev that consumes the VF already from the host? | 19:09 |
| sean-k-mooney | when an admin create a vdpa device on the host it will be reported as vdpa instead of a VF | 19:10 |
| gibi | OK | 19:10 |
| gibi | so we wont see both the VF and the VDPA at the same time | 19:10 |
| sean-k-mooney | not for the same VF no | 19:10 |
| gibi | cool | 19:10 |
| sean-k-mooney | you could have a mix of VF and VDPA devices | 19:10 |
| gibi | then only the PF edge case remains | 19:10 |
| gibi | when the PF is allocated we have the code somewhere that makes the VFs unavailable | 19:11 |
| sean-k-mooney | if each VDPA device is from a VF not listed as a VF | 19:11 |
| sean-k-mooney | yes its here https://review.opendev.org/c/openstack/nova/+/778350/7/nova/pci/stats.py#223 | 19:11 |
| gibi | ahh yes | 19:11 |
| gibi | so that removes the list of vfs | 19:11 |
| sean-k-mooney | the VDPA devices are listed with the VF address in the tracker | 19:12 |
| gibi | so pci_dev.child_devices does have the VDPAs listed? | 19:12 |
| sean-k-mooney | i need to check if that will remove the VDPA device too or not | 19:12 |
| gibi | OK | 19:12 |
| sean-k-mooney | im not sure ill whitelist the PF on my test system and check | 19:12 |
| gibi | cool | 19:12 |
| gibi | I continue reading in the meantime | 19:12 |
| sean-k-mooney | i plan to write some func test for this too but i need to extend our fixture support | 19:13 |
| *** ociuhandu has quit IRC | 19:15 | |
| gibi | Do I understand correclty that not having the mlock extra spec in W is OK if we document to use VDPA always with huge pages? | 19:17 |
| stephenfin | that's the thinking, yes | 19:17 |
| stephenfin | huge pages or real-time | 19:18 |
| sean-k-mooney | unfortunetly no. you would have to use hw:realtime or have a libvirt that does it for you | 19:18 |
| *** ociuhandu has joined #openstack-nova | 19:18 | |
| sean-k-mooney | stephenfin: hugepages is not enough unfortunetly | 19:18 |
| *** jawad_axd has quit IRC | 19:18 | |
| stephenfin | sean-k-mooney: oh, are they not locked by default? | 19:18 |
| sean-k-mooney | they are unswapable but not locked | 19:18 |
| sean-k-mooney | technially they can be moved if you configure your kernel to allow that | 19:19 |
| stephenfin | sean-k-mooney: I've forgotten - have you a release note? | 19:19 |
| sean-k-mooney | in practic they basially are but i still got the dma issue becuase qemu was not allowed lock the memory | 19:19 |
| sean-k-mooney | stephenfin: not yet that was going to be in the patch that block the unsupported ops | 19:20 |
| stephenfin | If not, that should be called out. I suspect libvirt will start doing this shortly since it's an obvious oversight but just in case they don't | 19:20 |
| sean-k-mooney | im working on that now | 19:20 |
| stephenfin | Okay, cool | 19:20 |
| stephenfin | I've got a functional test almost done, btw | 19:20 |
| stephenfin | lots of mocking | 19:20 |
| stephenfin | artom is right - we're eventually going to reinvent libvirt :) | 19:20 |
| sean-k-mooney | did you implement vdpa in the pci fixture? | 19:20 |
| stephenfin | yeah | 19:20 |
| gibi | yeah I wanted to ask for a reno and blockin of the unsupported ops | 19:20 |
| stephenfin | I copied bauzas' pattern for mdevs | 19:21 |
| stephenfin | there's cleanup needed, but I want to rework all this next cycle | 19:21 |
| stephenfin | start using template files with a proper language like jinja2 | 19:21 |
| stephenfin | instead of hacking them together like we're doing /o\ | 19:21 |
| sean-k-mooney | gibi: so here is the testing i did yesterday https://review.opendev.org/c/openstack/nova/+/778350/7#message-0bb79aad698ad4acacfec150e80d58d7abc1d09b | 19:21 |
| sean-k-mooney | im going to block all the ops that did not work with the 403 and same exception i have in that other patch | 19:22 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/780065/1/nova/exception.py | 19:22 |
| sean-k-mooney | that i was also goign to add a user dock liek we have for port resouce requests | 19:23 |
| sean-k-mooney | https://docs.openstack.org/api-guide/compute/port_with_resource_request.html | 19:23 |
| gibi | sean-k-mooney: nice | 19:24 |
| gibi | sean-k-mooney: I finished reading the vdpa patches (I ignored mlock for now) I have nothing major blocking this. But I will not be around to review the incoming reno and ops blocking patch today | 19:25 |
| *** ociuhandu has quit IRC | 19:25 | |
| sean-k-mooney | ya its getting late for you thanks for staying with it so far | 19:26 |
| gibi | stephenfin, sean-k-mooney: is it OK for you if we treat this now as a possible FFE | 19:26 |
| gibi | ? | 19:26 |
| *** tbachman has quit IRC | 19:26 | |
| gibi | I can do the remaining reviews tomorrow morning | 19:26 |
| sean-k-mooney | i was not sure if we were going to have any but if you would be ok with that then yes | 19:26 |
| stephenfin | sure, wfm. It'd be nice to be able to get dinner :) | 19:26 |
| * stephenfin is official sick of playing with fixtures | 19:27 | |
| gibi | OK, then I will check where we are tomorrow morning | 19:27 |
| sean-k-mooney | i can email the list and formally request one if you like | 19:27 |
| gibi | sean-k-mooney: yes please | 19:27 |
| sean-k-mooney | ok will do | 19:27 |
| gibi | you can refer to me and stephenfin as supporters for the FFE | 19:27 |
| gibi | this is really close and it is useful | 19:27 |
| gibi | so I'm willing to spend timeon this tomorrow and early next week | 19:28 |
| sean-k-mooney | ok ill wait for the irc logs to catch up and ill also link to this conversation | 19:28 |
| gibi | to get it approvaed | 19:28 |
| gibi | sean-k-mooney: sure | 19:28 |
| sean-k-mooney | gibi++ | 19:28 |
| gibi | OK, I'm leaving now | 19:28 |
| sean-k-mooney | o/ | 19:28 |
| gibi | o/ | 19:28 |
| stephenfin | ciao | 19:28 |
| *** tbachman has joined #openstack-nova | 19:30 | |
| *** belmoreira has quit IRC | 19:31 | |
| *** belmoreira has joined #openstack-nova | 19:31 | |
| *** ociuhandu has joined #openstack-nova | 19:40 | |
| *** k-s-dean has quit IRC | 19:40 | |
| *** links has quit IRC | 19:44 | |
| *** ociuhandu has quit IRC | 19:51 | |
| *** rcernin has joined #openstack-nova | 20:00 | |
| sean-k-mooney | ok so i have a small bug here https://review.opendev.org/c/openstack/nova/+/770533/10/nova/virt/libvirt/host.py#1237 so ill respin that patch and add testing to make sure claiming the PF handels the VDPA devices correctly | 20:03 |
| openstackgerrit | melanie witt proposed openstack/nova master: Dynamically archive FK related records in archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/773834 | 20:06 |
| *** martinkennelly has joined #openstack-nova | 20:09 | |
| *** xinranwang has quit IRC | 20:11 | |
| *** k-s-dean has joined #openstack-nova | 20:27 | |
| *** k_mouza has joined #openstack-nova | 20:28 | |
| *** kd has joined #openstack-nova | 20:30 | |
| *** bbowen has joined #openstack-nova | 20:32 | |
| *** k-s-dean has quit IRC | 20:33 | |
| *** k_mouza has quit IRC | 20:33 | |
| *** tobiash_ is now known as tobiash | 20:36 | |
| *** jamesdenton has quit IRC | 20:53 | |
| *** jamesdenton has joined #openstack-nova | 20:53 | |
| *** k_mouza has joined #openstack-nova | 20:54 | |
| *** slaweq has quit IRC | 20:56 | |
| *** ociuhandu has joined #openstack-nova | 20:56 | |
| *** zul has joined #openstack-nova | 20:56 | |
| *** k_mouza has quit IRC | 20:59 | |
| *** rcernin has quit IRC | 21:04 | |
| *** ociuhandu has quit IRC | 21:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: tests: Add functional test for vDPA device https://review.opendev.org/c/openstack/nova/+/780112 | 21:09 |
| stephenfin | sean-k-mooney: so that's not done, but you should be able to see where it's going. I'll finish it in the morning ^ | 21:09 |
| *** spatel_ has quit IRC | 21:10 | |
| sean-k-mooney | thanks | 21:10 |
| *** spatel has joined #openstack-nova | 21:10 | |
| stephenfin | sean-k-mooney: nw. Don't forget to file the FFE email :) | 21:10 |
| * stephenfin knocks off for the evening | 21:10 | |
| sean-k-mooney | i fixed the bug i had and now im testing the PF issue that gibi asked about | 21:11 |
| sean-k-mooney | ill send the email yeas | 21:11 |
| *** belmoreira has quit IRC | 21:23 | |
| *** hamalq has quit IRC | 21:30 | |
| *** hamalq has joined #openstack-nova | 21:31 | |
| *** rcernin has joined #openstack-nova | 21:35 | |
| *** tobias-urdin has quit IRC | 21:47 | |
| *** rcernin has quit IRC | 21:51 | |
| *** rcernin has joined #openstack-nova | 21:54 | |
| *** rcernin has quit IRC | 22:00 | |
| *** rcernin has joined #openstack-nova | 22:00 | |
| *** hamalq has quit IRC | 22:38 | |
| *** spatel has quit IRC | 22:44 | |
| *** ociuhandu has joined #openstack-nova | 22:45 | |
| *** ociuhandu has quit IRC | 22:51 | |
| *** smcginnis has quit IRC | 23:04 | |
| *** smcginnis has joined #openstack-nova | 23:15 | |
| *** jamesdenton has quit IRC | 23:23 | |
| *** jamesdenton has joined #openstack-nova | 23:24 | |
| *** smcginnis has quit IRC | 23:28 | |
| *** mlavalle has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!