| openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1853009 https://review.opendev.org/c/openstack/nova/+/695012 | 00:06 |
|---|---|---|
| openstack | bug 1853009 in OpenStack Compute (nova) ussuri "Ironic node rebalance race can lead to missing compute nodes in DB" [High,In progress] https://launchpad.net/bugs/1853009 - Assigned to Mark Goddard (mgoddard) | 00:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/695187 | 00:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/695188 | 00:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/694802 | 00:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/695189 | 00:06 |
| *** tosky has quit IRC | 00:11 | |
| *** yoctozepto has quit IRC | 00:13 | |
| *** yoctozepto has joined #openstack-nova | 00:13 | |
| *** gryf has quit IRC | 00:18 | |
| *** gryf has joined #openstack-nova | 00:21 | |
| *** hamalq has quit IRC | 00:26 | |
| *** jamesdenton has quit IRC | 00:46 | |
| *** jamesden_ has joined #openstack-nova | 00:46 | |
| *** tbachman_ has joined #openstack-nova | 00:51 | |
| *** brinzhang0 has joined #openstack-nova | 00:54 | |
| *** tbachman has quit IRC | 00:54 | |
| *** tbachman has joined #openstack-nova | 00:54 | |
| *** tbachman_ has quit IRC | 00:57 | |
| *** brinzhang_ has quit IRC | 00:57 | |
| *** mlavalle has quit IRC | 01:19 | |
| *** hemanth_n has joined #openstack-nova | 01:44 | |
| *** masterpe has quit IRC | 01:48 | |
| *** ihti[m] has quit IRC | 01:49 | |
| *** masterpe has joined #openstack-nova | 02:20 | |
| *** k_mouza has joined #openstack-nova | 02:21 | |
| *** k_mouza has quit IRC | 02:26 | |
| *** songwenping_ has joined #openstack-nova | 02:38 | |
| *** swp20 has quit IRC | 02:41 | |
| *** martinkennelly has quit IRC | 02:42 | |
| *** irclogbot_3 has quit IRC | 02:52 | |
| *** irclogbot_2 has joined #openstack-nova | 02:55 | |
| *** gyee has quit IRC | 03:08 | |
| *** ircuser-1 has quit IRC | 03:11 | |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** ircuser-1 has joined #openstack-nova | 03:51 | |
| *** tbachman has quit IRC | 03:56 | |
| *** tbachman has joined #openstack-nova | 03:57 | |
| *** k_mouza has joined #openstack-nova | 03:59 | |
| *** k_mouza has quit IRC | 04:04 | |
| *** ircuser-1 has quit IRC | 04:24 | |
| *** jamesden_ has quit IRC | 04:25 | |
| *** jamesdenton has joined #openstack-nova | 04:25 | |
| *** mkrai has joined #openstack-nova | 04:27 | |
| *** ircuser-1 has joined #openstack-nova | 04:28 | |
| *** ratailor has joined #openstack-nova | 04:37 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 04:53 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 04:53 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 04:53 |
| *** ratailor_ has joined #openstack-nova | 04:59 | |
| *** ratailor__ has joined #openstack-nova | 05:02 | |
| *** ratailor has quit IRC | 05:03 | |
| *** ratailor_ has quit IRC | 05:06 | |
| *** dviroel has quit IRC | 05:10 | |
| *** rcernin has quit IRC | 06:00 | |
| *** vishalmanchanda has joined #openstack-nova | 06:24 | |
| *** amodi has quit IRC | 06:28 | |
| *** bnemec has quit IRC | 06:43 | |
| *** bnemec has joined #openstack-nova | 06:44 | |
| *** slaweq has joined #openstack-nova | 06:59 | |
| *** ralonsoh has joined #openstack-nova | 07:03 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 07:04 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 07:04 |
| openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 07:04 |
| *** khomesh24 has joined #openstack-nova | 07:05 | |
| *** cz3 has quit IRC | 07:19 | |
| *** cz3 has joined #openstack-nova | 07:20 | |
| *** mkrai has quit IRC | 07:43 | |
| *** zzzeek has quit IRC | 07:52 | |
| *** zzzeek has joined #openstack-nova | 07:53 | |
| *** songwenping__ has joined #openstack-nova | 07:55 | |
| *** mkrai has joined #openstack-nova | 07:56 | |
| *** songwenping_ has quit IRC | 07:58 | |
| *** lpetrut has joined #openstack-nova | 08:00 | |
| *** dklyle has quit IRC | 08:01 | |
| *** zzzeek has quit IRC | 08:08 | |
| *** zzzeek has joined #openstack-nova | 08:09 | |
| *** mkrai has quit IRC | 08:18 | |
| *** rpittau|afk is now known as rpittau | 08:21 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | 08:24 |
| *** luksky has joined #openstack-nova | 08:25 | |
| lyarwood | elod: https://review.opendev.org/c/openstack/nova/+/777209/1 - would you mind hitting this and the regression test below it for melwitt please. | 08:27 |
| *** zzzeek has quit IRC | 08:40 | |
| *** zzzeek has joined #openstack-nova | 08:41 | |
| *** zzzeek has quit IRC | 08:42 | |
| *** zzzeek has joined #openstack-nova | 08:43 | |
| *** ociuhandu has joined #openstack-nova | 08:44 | |
| elod | lyarwood: sure, looking | 08:47 |
| yonglihe | alex_xu: gibi: test cases fixed, resolve concerns. | 08:48 |
| lyarwood | elod: thanks | 08:57 |
| *** lucasagomes has joined #openstack-nova | 09:04 | |
| *** derekh has joined #openstack-nova | 09:14 | |
| bauzas | gibi: stephenfin: the whole api db series is now +Wd | 09:23 |
| bauzas | but, | 09:23 |
| *** tosky has joined #openstack-nova | 09:23 | |
| bauzas | have we forgotten to add wallaby db placeholders like we did for Rocky ? :scared_emoji_you'd_like_have: | 09:23 |
| stephenfin | Do we need to? | 09:24 |
| stephenfin | We can just use the Victoria placeholders | 09:24 |
| stephenfin | We don't have any DB migrations afaik | 09:24 |
| bauzas | stephenfin: well, in general, we create DB placeholders even if we don't have existing DB things | 09:25 |
| bauzas | https://github.com/openstack/nova/tree/master/nova/db/sqlalchemy/api_migrations/migrate_repo/versions | 09:25 |
| stephenfin | I know. I'm questioning that :) | 09:26 |
| bauzas | stephenfin: the point is, if someone writes a DB migration in Xena and then we need to backport it in Wallaby but not in Victoria, how to do it ? | 09:26 |
| bauzas | surely, it's a corner case, but that's why we have placeholders for every release | 09:27 |
| stephenfin | Hmm, that's a good point | 09:27 |
| stephenfin | I really doubt we'd want/need them but you can add them if you think it's a good idea? | 09:28 |
| bauzas | I can try | 09:28 |
| stephenfin | They'll all be deleted when we switch to alembic in Xena anyway | 09:28 |
| bauzas | it's maybe just a bikeshed | 09:28 |
| bauzas | but in case we have issues, then... | 09:28 |
| bauzas | stephenfin: have we already agreed on accepting to use alembic for nova db migrations in Xena ? :D | 09:29 |
| stephenfin | I'm going on the assumption that we have, yes :D | 09:29 |
| openstackgerrit | Merged openstack/nova stable/victoria: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/777121 | 09:29 |
| openstack | bug 1914777 in OpenStack Compute (nova) victoria "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt) | 09:29 |
| stephenfin | If not, I'm core on sqlalchemy-migrate. It'd be a shame if something were to...happen to it | 09:29 |
| stephenfin | "Nice DB migration library you got there..." | 09:29 |
| stephenfin | 😈 | 09:30 |
| bauzas | :) | 09:30 |
| bauzas | at least we should remember why we had concerns before | 09:30 |
| stephenfin | http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020638.html | 09:30 |
| bauzas | stephenfin: add this to the xena ptg etherpad if you haven't done it already :) | 09:31 |
| stephenfin | link? | 09:31 |
| bauzas | sec | 09:31 |
| bauzas | https://etherpad.opendev.org/p/nova-xena-ptg | 09:31 |
| bauzas | haven't you went to the nova meeting yesterday ? maaaaaan | 09:31 |
| stephenfin | I have a conflict :-( | 09:31 |
| bauzas | ;) | 09:31 |
| stephenfin | NDSU mentoring meeting | 09:31 |
| bauzas | what's NSDU ? | 09:32 |
| stephenfin | North Dakota State University | 09:33 |
| stephenfin | Students | 09:33 |
| bauzas | hah | 09:34 |
| bauzas | I'd love to help some students here | 09:35 |
| bauzas | but... | 09:35 |
| bauzas | french universities don't like to have remote mentors | 09:35 |
| stephenfin | this year could be your year | 09:36 |
| stephenfin | it's all remote now :-\ | 09:36 |
| bauzas | meh | 09:37 |
| bauzas | it's... difficult, trust me | 09:37 |
| bauzas | even for our company :) | 09:37 |
| *** k_mouza has joined #openstack-nova | 09:42 | |
| *** Underknowledge has quit IRC | 09:48 | |
| *** Underknowledge1 has joined #openstack-nova | 09:49 | |
| *** Underknowledge1 is now known as Underknowledge | 09:49 | |
| stephenfin | gibi: URI qemu:///system does not support events: module 'nova.tests.unit.virt.libvirt.fakelibvirt' has no attribute 'VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED' | 10:09 |
| stephenfin | I'm seeing that in unit tests | 10:09 |
| stephenfin | Looks like you might want to add stuff to fakelibvirt, else mute the warning? | 10:10 |
| *** zoharm has joined #openstack-nova | 10:17 | |
| *** dviroel has joined #openstack-nova | 10:18 | |
| *** tbachman has quit IRC | 10:30 | |
| *** tbachman has joined #openstack-nova | 10:31 | |
| *** jangutter has joined #openstack-nova | 10:41 | |
| *** jangutter has quit IRC | 10:43 | |
| *** jangutter has joined #openstack-nova | 10:43 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-next: Start testing the q35 machine type https://review.opendev.org/c/openstack/nova/+/708701 | 10:44 |
| lyarwood | ^ gibi / kashyap / stephenfin ; this should be ready for reviews now, just had a quick nit to resolve. | 10:44 |
| *** jangutter_ has quit IRC | 10:45 | |
| kashyap | lyarwood: Thanks for the sustained effort on it; will look today | 10:45 |
| gibi | bauzas, stephenfin: I think we only need to add the wallaby db placeholders at the start of X as in X we need to differentiate between db changes that are X only from db changes that are backported to W | 10:51 |
| gibi | stephenfin: regarding the unit test logs I will look into it | 10:52 |
| stephenfin | lyarwood: cool | 10:53 |
| kashyap | lyarwood: If you're respinning, can you please add the comment I noted in the review? It'll be useful for those who don't dwell on machine types | 10:58 |
| kashyap | I don't insist; just that it avoids some head-scratching; I added my +1 regardless, FWIW. | 10:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/c/openstack/nova/+/756552 | 11:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Stop mocking 'nova.virt.libvirt.utils.get_arch' https://review.opendev.org/c/openstack/nova/+/778879 | 11:01 |
| openstackgerrit | Merged openstack/nova stable/victoria: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/777209 | 11:02 |
| stephenfin | lyarwood, gibi: Mind taking at look at ^ again? Took a while but I got the mocking nailed down eventually | 11:05 |
| lyarwood | kashyap: ack I did note something about that in the commit but if I respin I'll add a note | 11:09 |
| lyarwood | stephenfin: ack looking | 11:09 |
| *** k_mouza has quit IRC | 11:10 | |
| gibi | stephenfin: done | 11:12 |
| stephenfin | ty | 11:12 |
| *** artom has quit IRC | 11:16 | |
| *** ociuhandu has quit IRC | 11:16 | |
| *** ociuhandu has joined #openstack-nova | 11:17 | |
| *** ociuhandu has quit IRC | 11:17 | |
| *** ociuhandu has joined #openstack-nova | 11:18 | |
| *** k_mouza has joined #openstack-nova | 11:22 | |
| *** lucasagomes has quit IRC | 11:24 | |
| *** lucasagomes has joined #openstack-nova | 11:28 | |
| *** ociuhandu has quit IRC | 11:29 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | 11:29 |
| *** jangutter has quit IRC | 11:29 | |
| *** jangutter has joined #openstack-nova | 11:30 | |
| *** ociuhandu has joined #openstack-nova | 11:31 | |
| kashyap | lyarwood: Unless I'm terribly blind, I see that you've added about the SATA bus aspect, but I can't find anything about the PCIe root ports. :) But no prob | 11:33 |
| stephenfin | lyarwood: The patch to add '--block-device' to 'openstack server create' landed and I'm adding functional tests. It seems boot_index is not mandatory | 11:34 |
| stephenfin | If I omit it, I guess it defaults to -1. The guest correctly boots from the image I'm specifying alongside (cirros) | 11:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Replace nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/778885 | 11:36 |
| lyarwood | stephenfin: are you providing both --image and --block-device? | 11:36 |
| stephenfin | yes | 11:37 |
| lyarwood | stephenfin: I think osc and novaclient fudge things in the past to always boot from the --image you provided | 11:37 |
| lyarwood | stephenfin: in terms of the api behaviour | 11:37 |
| lyarwood | stephenfin: I think n-api also ensures we boot from the image, let me check | 11:38 |
| stephenfin | There's also additional weirdness. I was copying this behaviour https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L775-L779 | 11:39 |
| stephenfin | However, that seems broken. nova rejects those requests with 'Block Device Mapping is Invalid: Mapping image to local is not supported.' | 11:40 |
| stephenfin | openstack server create ... --image cirros-0.5.1-x86_64-disk --block-device device_name=vdb,source_type=image,destination_type=volume,uuid=$UUID ... | 11:41 |
| gibi | stephenfin: ooh that image to local error was one of my early nova contribution ;) I0c38134e2aacca83d98ed0b341f15c480afe14f1 | 11:41 |
| stephenfin | that works just fine, so I'm going to change it to default destination type to volume when source type is image instead, since that seems more logical/correct | 11:42 |
| * stephenfin validates | 11:42 | |
| stephenfin | gibi: we can't be blamed for the mistakes of our younger selves ;) | 11:42 |
| gibi | indeed | 11:43 |
| * lyarwood reads | 11:43 | |
| stephenfin | ah, wait, I think I misunderstood that code | 11:43 |
| lyarwood | right | 11:44 |
| lyarwood | image to local is valid | 11:44 |
| lyarwood | I'm not sure what we end up doing to hit that | 11:44 |
| lyarwood | do we provide an imageRef *and* image->local bdm? | 11:44 |
| stephenfin | I think that's transforming the '--image' request to a bdm dict | 11:45 |
| * stephenfin runs with --debug | 11:45 | |
| lyarwood | yeah it should do and I think that needs to drop the imageRef as a result? | 11:45 |
| lyarwood | with imageRef we end up with an image based local bdm so I'm not sure why we would block this in the API | 11:46 |
| lyarwood | maybe because it skips imageRef | 11:46 |
| stephenfin | http://paste.openstack.org/show/803266/ | 11:46 |
| stephenfin | that's what the OSC code currently ends up generating | 11:46 |
| stephenfin | in response to http://paste.openstack.org/show/803267/ | 11:47 |
| lyarwood | stephenfin: and n-api rejects that? | 11:47 |
| stephenfin | nope, that's fine | 11:47 |
| lyarwood | oh | 11:48 |
| lyarwood | okay | 11:48 |
| stephenfin | if I add destination_type=local to the '--block-device' arg though | 11:48 |
| stephenfin | the API rejects _that_ | 11:48 |
| lyarwood | oh right | 11:48 |
| lyarwood | yeah | 11:48 |
| lyarwood | there can only be one | 11:48 |
| lyarwood | I think | 11:48 |
| stephenfin | Yeah, quite possibly | 11:49 |
| stephenfin | I'm also using the same image twice | 11:49 |
| stephenfin | i don't know if that's an issue or not | 11:49 |
| stephenfin | http://paste.openstack.org/show/803268/ | 11:49 |
| lyarwood | https://github.com/openstack/nova/blob/c8a6f8d2e502e139c2212fb20cc0f89de816aeb1/nova/block_device.py#L193-L206 | 11:49 |
| stephenfin | plus other differences as you can see | 11:49 |
| stephenfin | okay, so the logic should be... | 11:51 |
| gibi | as far as I remember I blocked image to local mapping as it was not implemented (for other than for a single image) | 11:51 |
| stephenfin | if --image is specified, use destination_type=volume since this is an additional image | 11:51 |
| lyarwood | destination_type shouldn't be optional right? | 11:52 |
| lyarwood | huh it is | 11:52 |
| lyarwood | I thought it wasn't in the API | 11:52 |
| lyarwood | so yeah default to volume if --image is provided | 11:52 |
| lyarwood | and destination_type isn't | 11:52 |
| stephenfin | they're all optional except UUID | 11:52 |
| lyarwood | and reject the use of image as a destination_type if --image is already provided in the cli | 11:53 |
| stephenfin | of local you mean | 11:53 |
| lyarwood | yeah sorry | 11:53 |
| lyarwood | local | 11:53 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add device event constants to fakelibvirt https://review.opendev.org/c/openstack/nova/+/778887 | 11:53 |
| stephenfin | --image + --block-device source_type=image,destination_type=local ==> FAIL | 11:53 |
| lyarwood | I can add a note in the api docs about this | 11:54 |
| stephenfin | actually, for OSC I might just leave this to the server | 11:54 |
| stephenfin | as you suggested in the review | 11:54 |
| lyarwood | ah damn past me | 11:54 |
| stephenfin | simply using a sensible destination_type (volume) would be good | 11:54 |
| *** ociuhandu has quit IRC | 11:54 | |
| lyarwood | but that makes sense | 11:54 |
| stephenfin | enough | 11:54 |
| lyarwood | yeah | 11:54 |
| *** ociuhandu has joined #openstack-nova | 11:56 | |
| *** ociuhandu has quit IRC | 12:00 | |
| *** derekh has quit IRC | 12:13 | |
| *** k_mouza has quit IRC | 12:16 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/778885 | 12:26 |
| lyarwood | ^ tosky / gmann ; I'm not sure what you both think about this approach but it could allow us to finish our move to zuulv3 before M3 | 12:27 |
| lyarwood | tl;dr - move everything to grenade-multinode and add coverage for ceph later once that multinode base job is finished | 12:27 |
| *** tkajinam has quit IRC | 12:35 | |
| *** tkajinam has joined #openstack-nova | 12:35 | |
| *** ratailor__ has quit IRC | 12:36 | |
| *** belmoreira has joined #openstack-nova | 12:40 | |
| *** k_mouza has joined #openstack-nova | 12:52 | |
| *** k_mouza has quit IRC | 12:52 | |
| *** k_mouza has joined #openstack-nova | 12:53 | |
| sean-k-mooney | lyarwood: that wont actully remove grenade unless we remove it form the integrated-gate-compute template | 12:55 |
| sean-k-mooney | it wil still be added by integrated-gate-compute and it will no longer use the irrelevant-files list | 12:55 |
| sean-k-mooney | so what you really need to do is also remove the integrated-gate-compute template | 12:56 |
| sean-k-mooney | oh never mind | 12:56 |
| sean-k-mooney | https://github.com/openstack/tempest/blob/master/zuul.d/integrated-gate.yaml#L442-L454 the patch to remvoe grenade form that has been merged | 12:57 |
| *** whoami-rajat has joined #openstack-nova | 12:58 | |
| *** tbachman has quit IRC | 12:58 | |
| *** tbachman has joined #openstack-nova | 12:58 | |
| *** xek has joined #openstack-nova | 13:01 | |
| gmann | yeah that is already done | 13:05 |
| gmann | lyarwood: ack, thanks, I will check during weekend or on Monday | 13:05 |
| *** ociuhandu has joined #openstack-nova | 13:06 | |
| lyarwood | sean-k-mooney: it's already removed from that template | 13:06 |
| lyarwood | sean-k-mooney: yeah | 13:06 |
| tosky | lyarwood: that's entirely up to what you (nova) think it's better | 13:07 |
| lyarwood | I'd rather avoid duplication and move to zuulv3 now instead of waiting to get the ceph coverage in place | 13:08 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908 | 13:09 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | 13:09 |
| *** artom has joined #openstack-nova | 13:10 | |
| stephenfin | lyarwood: Low priority, but you may like 'Either a URI-style path (\'file:\\\\{path}\') to a JSON file ' | 13:11 |
| stephenfin | whoops | 13:11 |
| stephenfin | https://review.opendev.org/c/openstack/python-openstackclient/+/778910 | 13:12 |
| * stephenfin gets back to secure boot | 13:12 | |
| *** bbowen has quit IRC | 13:12 | |
| lyarwood | stephenfin: nice idea | 13:13 |
| stephenfin | I stole it https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html | 13:13 |
| stephenfin | (search for --block-device-mappings) | 13:13 |
| *** jamesdenton has quit IRC | 13:18 | |
| *** jamesden_ has joined #openstack-nova | 13:18 | |
| *** khomesh24 has quit IRC | 13:18 | |
| sean-k-mooney | speaking of osc https://review.opendev.org/c/openstack/python-openstackclient/+/778571 | 13:18 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | 13:18 |
| sean-k-mooney | that is for vdpa | 13:18 |
| sean-k-mooney | stephenfin: care to take a look i dont know if i need a release note for that or anything else | 13:19 |
| sean-k-mooney | stephenfin: i just did then minium i needed to not have to use curl | 13:19 |
| stephenfin | sean-k-mooney: will do | 13:20 |
| stephenfin | that's merged in neutron now? | 13:20 |
| sean-k-mooney | yep | 13:20 |
| stephenfin | cool | 13:20 |
| stephenfin | will review fully after lunch but a small release note would be A+ | 13:21 |
| stephenfin | and a link to the neutron change that added it (for context) | 13:21 |
| * stephenfin does lunch | 13:21 | |
| sean-k-mooney | sure ill see if i can do that later today | 13:21 |
| *** ociuhandu has quit IRC | 13:26 | |
| *** ociuhandu has joined #openstack-nova | 13:26 | |
| *** tbachman has quit IRC | 13:27 | |
| *** tbachman has joined #openstack-nova | 13:28 | |
| openstackgerrit | Merged openstack/nova master: tests: Stop mocking 'nova.virt.libvirt.utils.get_arch' https://review.opendev.org/c/openstack/nova/+/778879 | 13:30 |
| *** ociuhandu has quit IRC | 13:31 | |
| *** jangutter has quit IRC | 13:33 | |
| *** jangutter has joined #openstack-nova | 13:34 | |
| tosky | lyarwood: in that patch, maybe you can also emove nova-dsvm-multinode-base | 13:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move instance power state check to _detach_with_retry https://review.opendev.org/c/openstack/nova/+/778918 | 13:41 |
| lyarwood | tosky: I've done that in the following change | 13:42 |
| *** hemanth_n has quit IRC | 13:43 | |
| *** jangutter has quit IRC | 13:43 | |
| *** jangutter has joined #openstack-nova | 13:44 | |
| *** tbachman has quit IRC | 13:46 | |
| *** tbachman has joined #openstack-nova | 13:46 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Placeholders for DB migration backports to Wallaby https://review.opendev.org/c/openstack/nova/+/778923 | 13:55 |
| bauzas | gibi: stephenfin: sorry, was at some gym, here is the wallaby db placeholders change ^ | 13:55 |
| bauzas | lemme look when we merged the other ones | 13:55 |
| gibi | bauzas: thanks | 13:55 |
| *** efried has quit IRC | 13:56 | |
| bauzas | gibi: IIRC, we wanted to have the placeholders *before* any other db migration for a cycle | 13:56 |
| gibi | yes | 13:56 |
| gibi | so if we merge it at the start of the cycle then we are goo | 13:56 |
| gibi | d | 13:56 |
| bauzas | like, you write a db migration for wallaby, you need to have the placeholders *before* | 13:56 |
| bauzas | sure, but then we are lucky to not have any merged db migration during this cycle | 13:57 |
| bauzas | my point is, we should backport this sooner than later and write another change for reserving the xena ones early in the cycle | 13:57 |
| bauzas | don't we have this in the ptl guide or something like it ? | 13:57 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/686411 is the Train one | 13:58 |
| gibi | bauzas: post release check list https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | 13:58 |
| gibi | linked in the https://docs.openstack.org/nova/latest/contributor/ptl-guide.html | 13:59 |
| bauzas | the above change was merged on oct 4th | 13:59 |
| bauzas | (2019) | 13:59 |
| bauzas | and the train timeline was https://releases.openstack.org/train/schedule.html | 13:59 |
| gibi | according to git it was included from ussuri | 14:00 |
| sean-k-mooney | bauzas: so for xena i think stephenfin wants to move to alemnbic | 14:00 |
| sean-k-mooney | so that might be different in the future | 14:00 |
| bauzas | gibi: /me facepalms | 14:00 |
| sean-k-mooney | not sure if we still need to do reservations the same way | 14:00 |
| bauzas | so, yeah, this was merged early in the cycle, not late | 14:00 |
| gibi | bauzas: hm, I think ti was merged after RC1 and therefore after we branched out stable/train | 14:00 |
| bauzas | sean-k-mooney: we'll open the xena cycle before the PTG, we need the placeholders sooner than later | 14:01 |
| bauzas | gibi: sure, but at this point in time, the ussuri placeholders change was merged when we did the master branch to ussuri | 14:01 |
| sean-k-mooney | bauzas: sure just pointing out thye may not be used | 14:01 |
| gibi | bauzas: correct | 14:01 |
| sean-k-mooney | that said they dont hurt to have really | 14:01 |
| gibi | bauzas: so it is only in ussuri but not in train | 14:01 |
| bauzas | gibi: correct, that's a PEBKAC when I said Train | 14:02 |
| bauzas | oh wai | 14:02 |
| gibi | sean-k-mooney: it is like we don't know yet how the alembic migration will look like so I think we have to do the safe move and add reservation | 14:02 |
| bauzas | man, this is confusing | 14:02 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/686411/2/nova/tests/functional/db/api/test_migrations.py | 14:02 |
| bauzas | this was merged just after the branch but we name them train migrations | 14:03 |
| bauzas | so, hence my confusion, placeholders go last | 14:03 |
| bauzas | and just after we cut | 14:03 |
| gibi | yeah it is like placeholder for migration backported from ussuri to train | 14:03 |
| gibi | so both name can be correct :) | 14:03 |
| bauzas | gibi: so you were right, we should hold until the branhc | 14:03 |
| sean-k-mooney | gibi: yep we should for that reason and because whilte stephenfin want to do the move next cycle something might come up which means we cant finish it | 14:03 |
| sean-k-mooney | so we need to prepare for backport in anycase | 14:04 |
| gibi | sean-k-mooney: correct | 14:04 |
| bauzas | sean-k-mooney: gibi: like I said to stephenfin, before discussing it at the PTG, I'd like to dig why we didn't like that before | 14:04 |
| sean-k-mooney | alembic | 14:07 |
| bauzas | yup | 14:07 |
| sean-k-mooney | it was manly because we did not feel the effort of the move was worth it similar to removing mox | 14:07 |
| bauzas | I recall this | 14:07 |
| bauzas | but IIRC there were other concerns | 14:07 |
| bauzas | that's what I'd like to dif | 14:08 |
| sean-k-mooney | but like mox that ment the nova team was signing up to maintian sqlalchemy-migrate indefinetly | 14:08 |
| bauzas | dig* | 14:08 |
| bauzas | sure, but this prove to work ? | 14:08 |
| bauzas | we would just pull another dependency we loose control | 14:08 |
| bauzas | over their releases | 14:08 |
| sean-k-mooney | bauzas: we are using a dep that neutron uses already | 14:08 |
| bauzas | I know | 14:09 |
| sean-k-mooney | bauzas: and the maintiner of sqlachmey asked us to move | 14:09 |
| bauzas | but that just increases the potential flaw, it doesn't prove it works | 14:09 |
| sean-k-mooney | it does prove it works they have used it for years | 14:09 |
| sean-k-mooney | im pretty sure neutron moved beofre we created placment | 14:10 |
| bauzas | oh yes, I remember | 14:15 |
| sean-k-mooney | neutron dont seam to have placeholder migration anymore https://github.com/openstack/neutron/tree/b04dfcee192cf7ddcb69854e760739fdcfa7839e/neutron/db/migration/alembic_migrations/versions | 14:15 |
| bauzas | I actually never remember neutron using sqalchemy-migrate | 14:16 |
| bauzas | even when they were named quantum | 14:16 |
| sean-k-mooney | and they have tooling to auto genrate the migrations | 14:16 |
| sean-k-mooney | bauzas: i tought quantum did but maybe not | 14:16 |
| *** jangutter has quit IRC | 14:16 | |
| *** ociuhandu has joined #openstack-nova | 14:16 | |
| bauzas | well, i played with quantum with the Folsom release, and I don't think they were using migrate | 14:16 |
| bauzas | but that's been a while | 14:17 |
| *** jangutter has joined #openstack-nova | 14:17 | |
| sean-k-mooney | actully hevan used it alredy | 14:17 |
| sean-k-mooney | so i guess not | 14:17 |
| bauzas | they were incubated during Essex, so I didn't use it in my prod | 14:17 |
| bauzas | can't speak for Essex | 14:17 |
| bauzas | oh gosh, remembrance times... | 14:18 |
| sean-k-mooney | looking at the eol tags | 14:20 |
| *** claudiub has joined #openstack-nova | 14:20 | |
| sean-k-mooney | up to fulsom they had not migration in repo | 14:20 |
| sean-k-mooney | so the first migration they added was grizzly and that used alembic | 14:21 |
| sean-k-mooney | so for as long as they had migghration yes they used alembic to handel it | 14:21 |
| bauzas | glad to know my memory haven't vanished :) | 14:21 |
| bauzas | hasn't* | 14:22 |
| sean-k-mooney | if it woks well enough for neutron which allows exptions to also have addtional db tables i think it should be flexably enough ot use in nova | 14:22 |
| bauzas | again, this is not news | 14:22 |
| sean-k-mooney | the main issue for use will be learning how to write them correctly and review them | 14:22 |
| bauzas | that's my point | 14:22 |
| bauzas | neutron uses it for ages, but by the times we discussed this for nova, we nacked the idea a couple of times, so I just want to refresh my memory before jumping into conclusions | 14:23 |
| sean-k-mooney | sure but for me continuing to use it is like continuting ot use mox or python2 | 14:23 |
| sean-k-mooney | sure they work but it woudl be better to simply the dendencis fo openstack an converg on alembic | 14:24 |
| *** ociuhandu has quit IRC | 14:33 | |
| *** spatel has joined #openstack-nova | 14:34 | |
| openstackgerrit | sean mooney proposed openstack/nova master: support per port numa policies with sriov https://review.opendev.org/c/openstack/nova/+/773792 | 14:37 |
| *** ociuhandu has joined #openstack-nova | 14:39 | |
| *** efried has joined #openstack-nova | 14:49 | |
| *** efried has quit IRC | 14:54 | |
| *** efried has joined #openstack-nova | 14:59 | |
| *** jamesden_ is now known as jamesdenton | 15:03 | |
| *** lpetrut has quit IRC | 15:03 | |
| *** rpittau is now known as rpittau|afk | 15:03 | |
| melwitt | lyarwood, elod: thank you for the reviews :) fyi the stable/ussuri changes for the same bug, I stacked them on top of this other bug (2 patches) fix to eliminate merge conflicts. I figured it was a useful fix for stable anyways https://review.opendev.org/c/openstack/nova/+/777216 and https://review.opendev.org/c/openstack/nova/+/777217 | 15:09 |
| *** mkrai has joined #openstack-nova | 15:12 | |
| *** amodi has joined #openstack-nova | 15:12 | |
| *** ociuhandu has quit IRC | 15:29 | |
| *** ociuhandu has joined #openstack-nova | 15:33 | |
| *** ociuhandu has quit IRC | 15:36 | |
| *** ociuhandu has joined #openstack-nova | 15:36 | |
| claudiub | Hello, so, I have been looking a bit into the NUMA node 0 overcommit issue I was having. As a reminder, I had ~400 instaHello, so, I have been looking a bit into the NUMA node 0 overcommit issue I was having. As a reminder, I had ~400 instances in NUMA node 0, while NUMA node 1 was mostly empty. | 15:40 |
| claudiub | Turns out, there seems to be an issue when live-migrate / host-evacuate-live is called with a target destination. | 15:40 |
| claudiub | It seems that the CPU allocation and the memory allocation ratio is ignored in this case, leading to the overcommit, and even OOM, apparently. | 15:41 |
| claudiub | So, from what I saw, the live_migrate task will eventually call check_can_live_migrate_destination on the destination node (https://github.com/openstack/nova/blob/c8a6f8d2e502e139c2212fb20cc0f89de816aeb1/nova/compute/manager.py#L7931), | 15:41 |
| claudiub | which will then call _live_migration_clain and then self.rt.live_migration_clain. In there, a new claims.MoveClaim is created (https://github.com/openstack/nova/blob/c8a6f8d2e502e139c2212fb20cc0f89de816aeb1/nova/compute/resource_tracker.py#L298), | 15:41 |
| stephenfin | You mean e.g. 'openstack server migrate --live HOST SERVER' ? | 15:41 |
| claudiub | hich will then call hardware.numa_fit_instance_to_host to get the new instance_topology (https://github.com/openstack/nova/blob/c8a6f8d2e502e139c2212fb20cc0f89de816aeb1/nova/compute/claims.py#L138), which will then set it in self.claimed_numa_topology. In the hardware.numa_fit_instance_to_host call, | 15:41 |
| claudiub | because the given limits is None, there is no check that CPU / memory is not overcommited in numa cell 0, so it gets scheduled there, since it's first match. https://github.com/openstack/nova/blob/5b52db409b00e6257e83598efa0d8528ebe380e0/nova/virt/hardware.py#L1168 | 15:42 |
| claudiub | And indeed, the limits are None, from what I've seen in the extra logging I've added. | 15:42 |
| claudiub | stephenfin: yep. :) | 15:42 |
| stephenfin | How about if you do 'openstack server migrate --live-migration --host HOST SERVER'? | 15:42 |
| stephenfin | '--live HOST' bypasses the scheduler which means the NUMATopologyFilter never triggers to populate limits | 15:43 |
| stephenfin | (it's deprecated and we're removing it in the next version of OSC, fwiw) | 15:43 |
| stephenfin | in fact the patch to do so merged yesterday :) | 15:43 |
| *** dklyle has joined #openstack-nova | 15:43 | |
| claudiub | stephenfin: sorry, it was openstack server migrate --live --host dest_host --block-migration inst_uuid | 15:46 |
| stephenfin | ah, sorry, okay, that means this is likely an issue so | 15:46 |
| stephenfin | claudiub: I won't have time to look at this in depth today (on RFE review/rework duty pending feature freeze) but I could help work on this the end of next week | 15:47 |
| stephenfin | any chance you could open a bug? | 15:47 |
| claudiub | also, I saw that the NUMATopologyFilter was populating the limits. Why is that? Couldn't that just be initialized in the HostState anyways? It's not dependent on a request anyways. | 15:47 |
| claudiub | stephenfin: will do. :) | 15:48 |
| claudiub | I was wondering if, on the nova-compute side, if we get a check_can_live_migrate_destination call from somewhere and we don't get any limits, couldn't we just use the CPU / mem allocation ratios in the nova.conf file as the limits? | 15:49 |
| stephenfin | I assume we could. I think the reason we package the limits up is so we can check them in the scheduler (since we don't want to use the limits of the nova-scheduler service) | 15:50 |
| claudiub | ok then, will open up that issue, and I'll check how it goes if we use the nova.conf cpu / mem allocation ratios as limits if no limits are given. :) | 15:53 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consolidate device detach error handling https://review.opendev.org/c/openstack/nova/+/778978 | 15:54 |
| stephenfin | sounds good | 15:54 |
| stephenfin | lyarwood: Can you look at my two replies here before I pushed the rebased series? https://review.opendev.org/c/openstack/nova/+/775689 | 15:54 |
| sean-k-mooney | claudiub: the limit not being poplulated is the corrct behaivor | 15:55 |
| lyarwood | stephenfin: yup can do, just need to grab a tea first | 15:55 |
| stephenfin | ack | 15:55 |
| sean-k-mooney | if you do not have hw:cpu_policy=dedicated or hw:mem_page_size set then we dont really expect it to be set | 15:55 |
| sean-k-mooney | although there is a sperate bug fix that is relevent | 15:55 |
| sean-k-mooney | claudiub: https://review.opendev.org/c/openstack/nova/+/769614 | 15:56 |
| sean-k-mooney | claudiub: the limits are depended on the request at least for cpus | 15:57 |
| elod | melwitt: the functional job failure seems legit in the patch: https://review.opendev.org/c/openstack/nova/+/777218/ | 15:58 |
| sean-k-mooney | claudiub: none of the behviaor your are discibing is new to me | 15:58 |
| *** zoharm has quit IRC | 15:58 | |
| sean-k-mooney | claudiub: this is why i said added hw:numa_nodes with no other numa parmateters is not valid | 15:58 |
| elod | melwitt: otherwise it would be clean & OK o:) | 15:59 |
| melwitt | elod: oh, sorry I completely missed that and only saw the pep8 cherry pick fail. thanks for pointing it out, I will fix :) | 15:59 |
| sean-k-mooney | claudiub: the limits are not in general related to the nova.conf allocation ratios | 16:00 |
| gibi | lyarwood: fyi, now I think I fixed every comment in https://review.opendev.org/c/openstack/nova/+/770246/ with two follow up patch | 16:00 |
| elod | melwitt: np :) | 16:00 |
| sean-k-mooney | claudiub: well there are 2 limits object https://github.com/openstack/nova/blob/db666e2118972e501637141e48164a94f9bead54/nova/objects/numa.py#L273 and https://github.com/openstack/nova/blob/db666e2118972e501637141e48164a94f9bead54/nova/objects/request_spec.py#L1076-L1087 | 16:03 |
| lyarwood | gibi++ awesome | 16:03 |
| gibi | lyarwood: you had very good comments about simplifying error handling | 16:03 |
| claudiub | oh ok. I only saw the host_state.limits here: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L112 | 16:04 |
| sean-k-mooney | that being none or not has nothing to do with your stacking problem | 16:06 |
| sean-k-mooney | if you dont have hw:cpu_polciy=dedicated or hw:mem_page_size | 16:06 |
| sean-k-mooney | you have not told nova to claim any reslouce form the numa nodes | 16:07 |
| sean-k-mooney | so it will never decrement the capsity | 16:07 |
| sean-k-mooney | therefor as long as the vm can fit on the numa node e.g. does not exceed the reouce avaiable on the node it will be accpeted | 16:07 |
| claudiub | sean-k-mooney: indeed, my current stacking problem is not caused by the numa topology filter, since that is skipped if you specify the destination host on live migration. Will try live-migration with instances having that flavor extra_spec to see if it still persists. | 16:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move the guest.get_disk test to test_guest https://review.opendev.org/c/openstack/nova/+/777151 | 16:08 |
| sean-k-mooney | claudiub: the same logic is used on the compute hosts | 16:08 |
| claudiub | (with the destination host specified) | 16:08 |
| sean-k-mooney | we should be blocking all flaovr that only have hw:numa_node at the api level but we can do inter extraspec validation currenlty | 16:09 |
| lyarwood | stephenfin: LGTM, sorry about that, two pointless things to block that on previously | 16:09 |
| * lyarwood isn't sure how he missed the caps caching | 16:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on libvirt/guest.py https://review.opendev.org/c/openstack/nova/+/777155 | 16:09 |
| lyarwood | gibi: you're welcome! :) | 16:10 |
| sean-k-mooney | claudiub: well to be percise using a flaovr with hw:numa_node and no other numa prarmater with an image that also does not set themis invalid | 16:10 |
| sean-k-mooney | claudiub: the fact that you have to chekc the flavor and image is why we cand do the valdiation at flavor create time | 16:10 |
| gibi | lyarwood: thanks :) | 16:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up type hints for a634103 https://review.opendev.org/c/openstack/nova/+/777159 | 16:11 |
| sean-k-mooney | claudiub: we should technically be blocking it here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L760 | 16:11 |
| sean-k-mooney | by adding a check here https://github.com/openstack/nova/blob/a65e4201cc03f89d37296ddb803934c5a7977a71/nova/virt/hardware.py#L1942 | 16:13 |
| sean-k-mooney | numa_get_constraints should raise an excption in this case or default the mem_page_size=any | 16:14 |
| *** psachin has quit IRC | 16:17 | |
| sean-k-mooney | claudiub: i was going to defaut the pagezie request to any there fyi so that it would at least blance based on memory usage | 16:24 |
| *** mkrai has quit IRC | 16:29 | |
| *** mkrai_ has joined #openstack-nova | 16:29 | |
| *** ociuhandu has quit IRC | 16:29 | |
| *** ociuhandu has joined #openstack-nova | 16:32 | |
| *** ociuhandu has quit IRC | 16:36 | |
| *** ociuhandu has joined #openstack-nova | 16:42 | |
| *** mkrai_ has quit IRC | 16:47 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add firmware auto-configuration support https://review.opendev.org/c/openstack/nova/+/776678 | 16:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add tests for insecure UEFI configuration https://review.opendev.org/c/openstack/nova/+/777367 | 16:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Stop passing around virt_type, caps https://review.opendev.org/c/openstack/nova/+/775689 | 16:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add missing type hints https://review.opendev.org/c/openstack/nova/+/775688 | 16:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Clarify purpose of 'Host.supports_*' properties https://review.opendev.org/c/openstack/nova/+/778739 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Start parsing 'os_secure_boot' https://review.opendev.org/c/openstack/nova/+/682628 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Report COMPUTE_SECURITY_UEFI_SECURE_BOOT https://review.opendev.org/c/openstack/nova/+/776679 | 16:59 |
| *** lucasagomes has quit IRC | 16:59 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Translate secure boot requests to trait https://review.opendev.org/c/openstack/nova/+/776680 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Switch to libvirt's firmware auto-selection https://review.opendev.org/c/openstack/nova/+/775691 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Wire up 'os_secure_boot' property https://review.opendev.org/c/openstack/nova/+/776681 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Report secure boot support to scheduler https://review.opendev.org/c/openstack/nova/+/775690 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add functional tests for UEFI, secure boot https://review.opendev.org/c/openstack/nova/+/776682 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove duplicated 'start_compute' helper https://review.opendev.org/c/openstack/nova/+/776683 | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document UEFI secure boot feature https://review.opendev.org/c/openstack/nova/+/776684 | 16:59 |
| stephenfin | lyarwood: That's mostly merge conflict resolution. I'm working on undoing the firmware auto-selection changes now but it should free up everything below it to merge, at least | 17:00 |
| stephenfin | just FYI | 17:00 |
| stephenfin | bauzas also | 17:00 |
| lyarwood | stephenfin: thanks, can we chat about the auto selection stuff on Monday just so I'm sure I get the direction? | 17:01 |
| stephenfin | sure | 17:01 |
| lyarwood | stephenfin: I'll also hit everything up to that first thing on Monday regardless | 17:01 |
| stephenfin | in short though, I'm just going to drop that patch and go back to generating everything manually | 17:01 |
| stephenfin | https://that.guru/blog/uefi-secure-boot-in-libvirt/ | 17:01 |
| stephenfin | that might help explain what it was supposed to do and why we can't use it (scroll to the bottom for that) | 17:02 |
| lyarwood | kk I thought so, I couldn't get my head around all of the details in the bug | 17:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add device event constants to fakelibvirt https://review.opendev.org/c/openstack/nova/+/778887 | 17:05 |
| *** belmoreira has quit IRC | 17:10 | |
| kashyap | stephenfin: That's quite some speed there. | 17:20 |
| kashyap | I mean, in reworking the series. | 17:20 |
| * kashyap will look with proper energy on Mon | 17:20 | |
| *** mjturek has quit IRC | 17:23 | |
| *** k_mouza has quit IRC | 17:24 | |
| *** ociuhandu_ has joined #openstack-nova | 17:39 | |
| *** ociuhandu_ has quit IRC | 17:40 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** ociuhandu has joined #openstack-nova | 17:41 | |
| *** mlavalle has joined #openstack-nova | 17:47 | |
| *** jawad_axd has joined #openstack-nova | 17:50 | |
| *** dklyle has quit IRC | 17:52 | |
| *** dklyle has joined #openstack-nova | 17:52 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/777218 | 17:52 |
| openstack | bug 1914777 in OpenStack Compute (nova) victoria "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt) | 17:52 |
| openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/777219 | 17:52 |
| *** mjturek has joined #openstack-nova | 17:55 | |
| *** irclogbot_2 has quit IRC | 18:03 | |
| *** irclogbot_3 has joined #openstack-nova | 18:05 | |
| *** k_mouza has joined #openstack-nova | 18:10 | |
| *** k_mouza has quit IRC | 18:15 | |
| *** gyee has joined #openstack-nova | 18:17 | |
| *** irclogbot_3 has quit IRC | 18:24 | |
| *** irclogbot_0 has joined #openstack-nova | 18:28 | |
| *** admin0 has joined #openstack-nova | 18:31 | |
| admin0 | hi all openstack server show $uuid => hostId -- how do i check what hostId is which hypervisor ? | 18:32 |
| sean-k-mooney | as a non admin you cant intntionally | 18:33 |
| sean-k-mooney | ifyou are an admin you can check it differently | 18:33 |
| sean-k-mooney | hostid is a hash of the hostname salted by your poject id | 18:34 |
| sean-k-mooney | OS-EXT-SRV-ATTR:hypervisor_hostname should be avaiable as an admin | 18:35 |
| *** ralonsoh has quit IRC | 18:35 | |
| sean-k-mooney | hostid: "An ID string representing the host. This is a hashed value so will not actually look like a hostname, and is hashed with data from the project_id, so the same physical host as seen by two different project_ids, will be different. It is useful when within the same project you need to determine if two instances are on the same or different physical hosts for the purposes of | 18:36 |
| sean-k-mooney | availability or performance." | 18:36 |
| sean-k-mooney | from the api ref ^ | 18:36 |
| sean-k-mooney | admin0: hopefully that helps. its considerd a security issue if vms can determin what host they are running on directly | 18:38 |
| sean-k-mooney | assuming they can use that info to target another vm to the same host | 18:38 |
| sean-k-mooney | that is why the hostid is hashed and different proejct will see different values for the same host | 18:39 |
| admin0 | oh .. got it | 18:39 |
| *** ociuhandu has quit IRC | 18:42 | |
| *** jawad_axd has quit IRC | 18:44 | |
| openstackgerrit | sean mooney proposed openstack/nova master: support per port numa policies with sriov https://review.opendev.org/c/openstack/nova/+/773792 | 18:49 |
| *** ociuhandu has joined #openstack-nova | 18:54 | |
| *** ociuhandu has quit IRC | 18:58 | |
| *** spatel has quit IRC | 18:58 | |
| *** spatel_ has joined #openstack-nova | 18:59 | |
| *** xek has quit IRC | 19:04 | |
| *** jawad_axd has joined #openstack-nova | 19:05 | |
| *** elod has quit IRC | 19:12 | |
| *** takamatsu has quit IRC | 19:13 | |
| *** elod has joined #openstack-nova | 19:13 | |
| *** kevinbenton has quit IRC | 19:15 | |
| *** k_mouza has joined #openstack-nova | 19:25 | |
| *** takamatsu has joined #openstack-nova | 19:27 | |
| dansmith | has anyone noticed compute nodes getting 500 errors from placement? | 19:27 |
| dansmith | https://zuul.opendev.org/t/openstack/build/19989232c4b94c848894c6e54d9fa49c/log/logs/subnode-2/screen-n-cpu.txt#9204 | 19:27 |
| dansmith | oh you know, | 19:28 |
| dansmith | that might be during the upgrade part where the service is down | 19:28 |
| *** k_mouza has quit IRC | 19:30 | |
| melwitt | dansmith: I haven't noticed that before but can see the corresponding request doesn't show up in the placement logs, so that seems to support what you're thinking that it's when the service is down? I didn't know how/if the service can 500 while it is maybe partially up/in a state where it would not log the request in placement. timestamps match too | 19:35 |
| dansmith | melwitt: because of the TLS proxies I expect | 19:36 |
| dansmith | melwitt: after that in the log, conductor is down for a while when it's trying to update its service record, which I think is the key indicating we're in the upgrade phase | 19:36 |
| dansmith | this is the left-behind node of the multinode upgrade | 19:36 |
| melwitt | oh I didn't realize that job ran with TLS enabled | 19:36 |
| dansmith | well, I guess I was assuming it did | 19:37 |
| melwitt | it might, I had thought only nova-next did | 19:37 |
| dansmith | oh, actually, what I mean is with the apache->uwsgi->nova bit | 19:38 |
| dansmith | technically that's not the tls | 19:38 |
| dansmith | lots of jobs do, this is the base tempest integrated job: https://zuul.opendev.org/t/openstack/build/266f30d8a31944ca8e391c2d67402582/log/controller/logs/local_conf.txt#34 | 19:39 |
| dansmith | not just nova-next | 19:39 |
| melwitt | oh, TIL. cool | 19:40 |
| sean-k-mooney | the tls proxy? | 19:41 |
| sean-k-mooney | i think thats enabled by default | 19:41 |
| melwitt | I was thinking of this jazz, since I've worked with it before https://github.com/openstack/nova/blob/master/.zuul.yaml#L229-L235 | 19:41 |
| sean-k-mooney | but that is quite different form tls everywhere as we normally thinkg of it | 19:41 |
| dansmith | right | 19:41 |
| dansmith | melwitt: yeah I think it's on in more base jobs we inherit from | 19:42 |
| dansmith | melwitt: that nova-next job might not because it's multinode or something, but it's on in a lot of places now | 19:42 |
| dansmith | "might not get it from inheritance" I mean | 19:42 |
| melwitt | I see, cool | 19:42 |
| sean-k-mooney | https://github.com/openstack/devstack/blob/master/.zuul.yaml#L485 | 19:43 |
| sean-k-mooney | its on by default in the base devstack job | 19:43 |
| sean-k-mooney | which menas it on in all the tempest jobs by default https://github.com/openstack/tempest/blob/master/zuul.d/base.yaml#L2-L3 | 19:44 |
| sean-k-mooney | melwitt: i think setting it in nova-next is likely legacy form when that was zullv2 based | 19:46 |
| sean-k-mooney | melwitt: i dont think the tls_proxy was enabeld in the legacy jobs | 19:46 |
| *** jawad_axd has quit IRC | 19:52 | |
| *** jawad_axd has joined #openstack-nova | 19:57 | |
| *** slaweq has quit IRC | 20:17 | |
| admin0 | hi guys . my openstack ansible is stuck here: my nova is stuck at raise exceptions.VersionNotFoundError(", "migrate.exceptions.VersionNotFoundError: \"Database schema file with version 82 doesn't exist.\""]} | 20:19 |
| admin0 | any ideas where to get this version 82 from ? | 20:19 |
| *** jamesdenton has quit IRC | 20:49 | |
| *** jamesden_ has joined #openstack-nova | 20:49 | |
| *** jawad_axd has quit IRC | 20:55 | |
| *** hoonetorg has quit IRC | 20:57 | |
| *** hoonetorg has joined #openstack-nova | 21:01 | |
| *** k_mouza has joined #openstack-nova | 21:10 | |
| *** hamalq has joined #openstack-nova | 21:14 | |
| *** k_mouza has quit IRC | 21:15 | |
| *** jawad_axd has joined #openstack-nova | 21:17 | |
| *** jawad_axd has quit IRC | 21:31 | |
| *** spatel_ has quit IRC | 22:41 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Differentiate between InstanceNotFound and ConstraintNotMet https://review.opendev.org/c/openstack/nova/+/775309 | 22:54 |
| *** iurygregory has quit IRC | 22:57 | |
| *** iurygregory has joined #openstack-nova | 23:22 | |
| *** elod has quit IRC | 23:25 | |
| *** hamalq has quit IRC | 23:44 | |
| *** k_mouza has joined #openstack-nova | 23:52 | |
| *** k_mouza has quit IRC | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!