| *** zenkuro has quit IRC | 00:00 | |
| *** tosky has quit IRC | 00:30 | |
| *** luksky has quit IRC | 00:33 | |
| *** LinPeiWen has joined #openstack-nova | 00:43 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | 01:12 |
|---|---|---|
| *** mlavalle has quit IRC | 01:32 | |
| *** ccstone has joined #openstack-nova | 01:35 | |
| *** eandersson has joined #openstack-nova | 01:35 | |
| *** ccstone has quit IRC | 01:42 | |
| *** eandersson has quit IRC | 01:42 | |
| *** ccstone has joined #openstack-nova | 01:42 | |
| *** eandersson has joined #openstack-nova | 01:42 | |
| *** macz_ has quit IRC | 02:04 | |
| *** songwenping_ has joined #openstack-nova | 02:35 | |
| *** swp20 has quit IRC | 02:37 | |
| *** spatel has joined #openstack-nova | 02:44 | |
| *** zzzeek has quit IRC | 02:47 | |
| *** zzzeek has joined #openstack-nova | 02:50 | |
| *** hemanth_n has joined #openstack-nova | 02:53 | |
| *** dviroel has quit IRC | 02:55 | |
| *** priteau has quit IRC | 02:59 | |
| *** gouthamr has quit IRC | 02:59 | |
| *** nicolasbock has quit IRC | 02:59 | |
| *** ianw has quit IRC | 02:59 | |
| *** nicolasbock has joined #openstack-nova | 03:00 | |
| *** ianw has joined #openstack-nova | 03:00 | |
| *** gouthamr has joined #openstack-nova | 03:00 | |
| *** gouthamr has quit IRC | 03:00 | |
| *** gouthamr has joined #openstack-nova | 03:01 | |
| *** gouthamr has quit IRC | 03:01 | |
| *** gouthamr has joined #openstack-nova | 03:01 | |
| *** gouthamr has quit IRC | 03:01 | |
| *** k_mouza has joined #openstack-nova | 03:02 | |
| *** gouthamr has joined #openstack-nova | 03:02 | |
| *** gouthamr has quit IRC | 03:02 | |
| *** gouthamr has joined #openstack-nova | 03:03 | |
| *** gouthamr has quit IRC | 03:03 | |
| *** gouthamr has joined #openstack-nova | 03:04 | |
| *** gouthamr has quit IRC | 03:04 | |
| *** gouthamr has joined #openstack-nova | 03:04 | |
| *** gouthamr has quit IRC | 03:04 | |
| *** gouthamr has joined #openstack-nova | 03:05 | |
| *** gouthamr has quit IRC | 03:05 | |
| *** gouthamr has joined #openstack-nova | 03:06 | |
| *** gouthamr has quit IRC | 03:06 | |
| *** k_mouza has quit IRC | 03:07 | |
| *** gouthamr has joined #openstack-nova | 03:07 | |
| *** gouthamr has quit IRC | 03:07 | |
| *** gouthamr has joined #openstack-nova | 03:11 | |
| *** gouthamr has quit IRC | 03:11 | |
| *** gouthamr has joined #openstack-nova | 03:17 | |
| *** gouthamr has quit IRC | 03:17 | |
| *** gouthamr has joined #openstack-nova | 03:22 | |
| *** gouthamr has quit IRC | 03:22 | |
| *** songwenping_ has quit IRC | 03:24 | |
| *** kevinbenton has quit IRC | 03:27 | |
| *** kevinbenton has joined #openstack-nova | 03:27 | |
| *** spatel has quit IRC | 03:27 | |
| *** gouthamr has joined #openstack-nova | 03:28 | |
| *** gouthamr has quit IRC | 03:28 | |
| *** gouthamr has joined #openstack-nova | 03:32 | |
| *** gouthamr has quit IRC | 03:32 | |
| *** zoharm1 has joined #openstack-nova | 03:34 | |
| *** rcernin has quit IRC | 03:36 | |
| *** gouthamr has joined #openstack-nova | 03:38 | |
| *** gouthamr has quit IRC | 03:38 | |
| *** khomesh24 has joined #openstack-nova | 03:39 | |
| *** mkrai has joined #openstack-nova | 03:41 | |
| *** psachin has joined #openstack-nova | 03:42 | |
| *** gouthamr has joined #openstack-nova | 03:43 | |
| *** gouthamr has quit IRC | 03:43 | |
| *** spatel has joined #openstack-nova | 03:45 | |
| *** gouthamr has joined #openstack-nova | 03:49 | |
| *** gouthamr has quit IRC | 03:49 | |
| *** gouthamr has joined #openstack-nova | 03:53 | |
| *** gouthamr has quit IRC | 03:53 | |
| *** gouthamr has joined #openstack-nova | 03:59 | |
| *** gouthamr has quit IRC | 03:59 | |
| *** rcernin has joined #openstack-nova | 04:16 | |
| *** gouthamr has joined #openstack-nova | 04:25 | |
| *** gouthamr has quit IRC | 04:26 | |
| *** ratailor has joined #openstack-nova | 04:35 | |
| *** whoami-rajat__ has joined #openstack-nova | 04:38 | |
| *** mkrai has quit IRC | 04:56 | |
| *** mkrai_ has joined #openstack-nova | 04:56 | |
| *** gouthamr has joined #openstack-nova | 05:00 | |
| *** gouthamr has quit IRC | 05:00 | |
| *** macz_ has joined #openstack-nova | 05:10 | |
| *** gyee has quit IRC | 05:15 | |
| *** macz_ has quit IRC | 05:15 | |
| *** swp20 has joined #openstack-nova | 05:25 | |
| *** gouthamr has joined #openstack-nova | 05:26 | |
| *** gouthamr has quit IRC | 05:26 | |
| *** macz_ has joined #openstack-nova | 05:48 | |
| *** psachin has quit IRC | 05:50 | |
| *** ociuhandu has joined #openstack-nova | 05:51 | |
| *** macz_ has quit IRC | 05:52 | |
| *** ociuhandu has quit IRC | 05:56 | |
| *** gouthamr has joined #openstack-nova | 06:00 | |
| *** spatel has quit IRC | 06:02 | |
| *** macz_ has joined #openstack-nova | 06:09 | |
| *** macz_ has quit IRC | 06:14 | |
| *** k_mouza has joined #openstack-nova | 06:16 | |
| *** k_mouza has quit IRC | 06:20 | |
| *** ircuser-1 has joined #openstack-nova | 06:22 | |
| *** vishalmanchanda has joined #openstack-nova | 06:34 | |
| *** ccstone has quit IRC | 06:53 | |
| *** eandersson has quit IRC | 06:53 | |
| *** ccstone has joined #openstack-nova | 06:53 | |
| *** eandersson has joined #openstack-nova | 06:53 | |
| *** ccstone has quit IRC | 06:56 | |
| *** eandersson has quit IRC | 06:56 | |
| *** eandersson has joined #openstack-nova | 06:56 | |
| *** ccstone has joined #openstack-nova | 06:56 | |
| *** mkrai_ has quit IRC | 07:00 | |
| *** mkrai has joined #openstack-nova | 07:00 | |
| *** lpetrut has joined #openstack-nova | 07:06 | |
| openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | 07:07 |
| *** slaweq has joined #openstack-nova | 07:13 | |
| *** ralonsoh has joined #openstack-nova | 07:21 | |
| *** mkrai has quit IRC | 07:30 | |
| *** mkrai_ has joined #openstack-nova | 07:30 | |
| *** links has joined #openstack-nova | 07:39 | |
| *** slaweq has quit IRC | 07:39 | |
| *** slaweq has joined #openstack-nova | 07:42 | |
| *** brinzhang has quit IRC | 07:45 | |
| *** brinzhang has joined #openstack-nova | 07:45 | |
| *** macz_ has joined #openstack-nova | 07:53 | |
| *** macz_ has quit IRC | 07:57 | |
| *** rcernin has quit IRC | 07:58 | |
| *** belmoreira has joined #openstack-nova | 07:59 | |
| *** rcernin has joined #openstack-nova | 08:02 | |
| *** rcernin has quit IRC | 08:07 | |
| *** LinPeiWen has quit IRC | 08:12 | |
| *** macz_ has joined #openstack-nova | 08:14 | |
| *** rpittau|afk is now known as rpittau | 08:14 | |
| *** luksky has joined #openstack-nova | 08:17 | |
| *** macz_ has quit IRC | 08:19 | |
| *** andrewbonney has joined #openstack-nova | 08:26 | |
| *** xek has joined #openstack-nova | 08:27 | |
| *** dklyle has quit IRC | 08:30 | |
| *** kashyap has joined #openstack-nova | 08:31 | |
| *** links has quit IRC | 08:38 | |
| *** tosky has joined #openstack-nova | 08:45 | |
| *** rcernin has joined #openstack-nova | 08:49 | |
| *** rcernin has quit IRC | 08:53 | |
| *** macz_ has joined #openstack-nova | 08:55 | |
| *** links has joined #openstack-nova | 08:58 | |
| *** LinPeiWen has joined #openstack-nova | 08:59 | |
| *** macz_ has quit IRC | 09:00 | |
| *** brinzhang has quit IRC | 09:00 | |
| *** macz_ has joined #openstack-nova | 09:16 | |
| *** macz_ has quit IRC | 09:21 | |
| *** k_mouza has joined #openstack-nova | 09:28 | |
| *** dtantsur|afk is now known as dtantsur | 09:31 | |
| *** ociuhandu has joined #openstack-nova | 09:36 | |
| *** derekh has joined #openstack-nova | 09:38 | |
| swp20 | gibi: morning, please check the NOVNC patch https://review.opendev.org/c/openstack/nova/+/622336 if you have spare time. | 09:42 |
| *** macz_ has joined #openstack-nova | 09:58 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550 | 10:00 |
| stephenfin | gibi: bauzas: I'm +2 on https://review.opendev.org/c/openstack/nova/+/750552 but have held off on +W because you both reviewed it previously | 10:01 |
| stephenfin | Ah, wait, lyarwood dropped his +2 while I was reviewing so not as urgent after all | 10:01 |
| stephenfin | lyarwood: Left comments inline but fwiw I'm fine with camelCase. We can discuss in the team meeting today if we want to though | 10:02 |
| *** ociuhandu has quit IRC | 10:02 | |
| bauzas | stephenfin: ack, just fixing your concerns about negative tests missing on routed networks and then hopefully I should be on the review side | 10:02 |
| gibi | bauzas, stephenfin: the general direction is OK to me in https://review.opendev.org/c/openstack/nova/+/706295 (neutron client bump) I just had some question inline | 10:03 |
| *** macz_ has quit IRC | 10:03 | |
| gibi | swp20: I will try | 10:03 |
| gibi | stephenfin: ack, I will check the libvirt metadata too | 10:04 |
| stephenfin | gibi: cool, I'll take a look at the noVNC patch too | 10:04 |
| * stephenfin needs a break from secure boot fun | 10:05 | |
| lyarwood | stephenfin: yup sorry didn't want to jump the gun on that | 10:05 |
| * lyarwood has also reviewed the noVNC patch and left some comments | 10:12 | |
| openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | 10:15 |
| *** macz_ has joined #openstack-nova | 10:19 | |
| gibi | stephenfin, lyarwood: I'm +2 on the libvirt ip metadata (including ipVersion). lyarwood do you want to get back to that patch or should I send it through? | 10:21 |
| lyarwood | gibi: I just wanted to ensure Sean was okay with it tbh | 10:22 |
| lyarwood | gibi: they left a comment on the spec about talking it over in the review | 10:22 |
| gibi | lyarwood: OK let's wait for sean-k-mooney's vote on the review then | 10:23 |
| lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/763550 - FWIW the HyperV RBD change looks ready now | 10:23 |
| gibi | lyarwood: on it | 10:23 |
| *** macz_ has quit IRC | 10:24 | |
| lpetrut | thanks for the reviews | 10:26 |
| gibi | lpetrut: is there any other patch needed in nova for the rbd support? or can I close the bp once https://review.opendev.org/c/openstack/nova/+/763550 merges? | 10:27 |
| lpetrut | nope, that's it | 10:28 |
| gibi | lyarwood: thanks for the review on the noVNC patch | 10:28 |
| gibi | lpetrut: ack, I will close the bp accordingly | 10:28 |
| *** ociuhandu has joined #openstack-nova | 10:33 | |
| *** jangutter_ has joined #openstack-nova | 10:34 | |
| *** jangutter has quit IRC | 10:38 | |
| *** macz_ has joined #openstack-nova | 10:40 | |
| *** ociuhandu has quit IRC | 10:43 | |
| *** ociuhandu has joined #openstack-nova | 10:44 | |
| *** macz_ has quit IRC | 10:45 | |
| bauzas | oh, man, why _get_provider_aggregates() is so cryptic ? | 10:45 |
| bauzas | it can return either None, a tuple with empty list, or an exception | 10:46 |
| bauzas | stephenfin: thanks for having letting me rework on negative tests, I need to check all of the above | 10:46 |
| gibi | because nobody cared in the past to have a proper return type. but now with mypy... :D | 10:46 |
| bauzas | gibi: technically, it's a private method, so that's my call | 10:47 |
| gibi | also we don't have a clear guideline (or pattern) when to return None for error case and when to raise for it | 10:47 |
| gibi | s/None/falsy value/ | 10:48 |
| *** ociuhandu has quit IRC | 10:50 | |
| *** mkrai_ has quit IRC | 10:51 | |
| *** mkrai__ has joined #openstack-nova | 10:51 | |
| *** ociuhandu has joined #openstack-nova | 10:53 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [OVN] Adapt the live-migration job scripts to work with OVN https://review.opendev.org/c/openstack/nova/+/776419 | 10:59 |
| *** macz_ has joined #openstack-nova | 11:01 | |
| *** macz_ has quit IRC | 11:05 | |
| *** mkrai__ has quit IRC | 11:09 | |
| stephenfin | lyarwood: gibi: I have some pretty serious concerns about the VNC patch. Why would one ever recommend an 8 ASCII character, trivially brute forceable password over TLS encryption? | 11:16 |
| stephenfin | Lots of comments left. I don't know if it's possible yet (starting to investigate), but this feels like something the proxy layer should be providing for us (i.e. HTTPS and a password to get to the proxy, and then TLS from the proxy to the guest) | 11:17 |
| lyarwood | stephenfin: hmm how do we lose the ability to encrypt traffic between the proxy and guest? | 11:19 |
| stephenfin | per my reading of things, yes | 11:19 |
| stephenfin | the presence of an entirely separate auth scheme suggests as much https://review.opendev.org/c/openstack/nova/+/622336/30/nova/console/rfb/auths.py#30 | 11:20 |
| stephenfin | as does the QEMU doc on available security methods https://qemu.readthedocs.io/en/latest/system/vnc-security.html | 11:20 |
| *** dviroel has joined #openstack-nova | 11:21 | |
| lyarwood | stephenfin: ah crap sorry I didn't look at RFBAuthSchemeVeNCrypt | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/770745 | 11:32 |
| stephenfin | Man, my security know how is not what it should be, but it sounds like there's a TLSNone subtype we can use with VeNCrypt https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#7243subtypes-with-vnc-suffix | 11:33 |
| stephenfin | Sorry, X509Vnc | 11:34 |
| *** priteau has joined #openstack-nova | 11:35 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add net & utils methods for routed nets & segments https://review.opendev.org/c/openstack/nova/+/773976 | 11:38 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 11:38 |
| bauzas | gibi: stephenfin: sean-k-mooney: last round hopefully ^ | 11:38 |
| bauzas | tl;dr: I now hard-stop when we can't find aggregates for subnets | 11:39 |
| bauzas | s/subnets/segments | 11:39 |
| *** links has quit IRC | 11:40 | |
| *** links has joined #openstack-nova | 11:41 | |
| *** macz_ has joined #openstack-nova | 11:42 | |
| *** ociuhandu has quit IRC | 11:45 | |
| *** ociuhandu has joined #openstack-nova | 11:46 | |
| *** macz_ has quit IRC | 11:47 | |
| *** zenkuro has joined #openstack-nova | 11:52 | |
| gibi | bauzas: acj | 11:59 |
| gibi | ack even | 11:59 |
| * bauzas goes grabbing some food | 11:59 | |
| gibi | good idea ^^ | 12:06 |
| * gibi joins virtually | 12:06 | |
| *** hemanth_n has quit IRC | 12:16 | |
| *** zenkuro has quit IRC | 12:17 | |
| *** zenkuro has joined #openstack-nova | 12:21 | |
| openstackgerrit | Merged openstack/nova stable/victoria: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766023 | 12:21 |
| *** macz_ has joined #openstack-nova | 12:24 | |
| *** zenkuro has quit IRC | 12:27 | |
| *** zenkuro has joined #openstack-nova | 12:28 | |
| *** macz_ has quit IRC | 12:29 | |
| *** ociuhandu has quit IRC | 13:00 | |
| *** ociuhandu has joined #openstack-nova | 13:03 | |
| openstackgerrit | Belmiro Moreira proposed openstack/nova master: Fixes the elapsed time logged during a live migration https://review.opendev.org/c/openstack/nova/+/776428 | 13:04 |
| *** macz_ has joined #openstack-nova | 13:06 | |
| gibi | stephenfin: this bp is set to Need Code Review state but I haven't found the impl code https://blueprints.launchpad.net/nova/+spec/configurable-instance-hostnames did I miss something? | 13:08 |
| sean-k-mooney | bauzas: that is only if its a routed network yes | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: extra specs/image props: add `socket` PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Track host NUMA topology in PCI manager https://review.opendev.org/c/openstack/nova/+/774149 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | 13:10 |
| *** macz_ has quit IRC | 13:10 | |
| *** belmoreira has quit IRC | 13:11 | |
| *** belmoreira has joined #openstack-nova | 13:14 | |
| *** ociuhandu has quit IRC | 13:15 | |
| *** ociuhandu has joined #openstack-nova | 13:15 | |
| *** ociuhandu has quit IRC | 13:15 | |
| *** ratailor has quit IRC | 13:16 | |
| *** ociuhandu has joined #openstack-nova | 13:17 | |
| *** ociuhandu has quit IRC | 13:22 | |
| *** macz_ has joined #openstack-nova | 13:27 | |
| *** macz_ has quit IRC | 13:31 | |
| bauzas | stephenfin: gibi: sean-k-mooney: guys, hopefully, we could see us not virtually ;) | 13:31 |
| bauzas | :( | 13:32 |
| gibi | yeah | 13:33 |
| sean-k-mooney | eventually | 13:33 |
| *** ociuhandu has joined #openstack-nova | 13:34 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | 13:35 |
| kashyap | gibi: sean-k-mooney: artom: --^ IMHO, really don't like two separate config options (which was suggested in there); it is needlessly verbose and adds noise work | 13:37 |
| kashyap | I refactored it into a helper method; rewrote docs | 13:37 |
| kashyap | And added a test, of course; and fixed other bits. /me hopes he didn't miss anything else. | 13:37 |
| sean-k-mooney | kashyap: as i said this is one of the points of contention that has come up every time we discussed it. i know you have always favoured the +/- approch but i know others have requested two config options in the past | 13:39 |
| *** LinPeiWen has quit IRC | 13:39 | |
| kashyap | Well, it is overblown "contention". No one else disagreed with it | 13:39 |
| kashyap | sean-k-mooney: Right; I really dislike bike-shedding on this, really | 13:40 |
| kashyap | I just feel it is bloated to add needlessly extra options | 13:40 |
| kashyap | sean-k-mooney: I know you were in the "+/- camp" as you put it | 13:40 |
| sean-k-mooney | kashyap: im pretty sure other cores have asked you in the passed to have the two config options | 13:40 |
| kashyap | No | 13:40 |
| sean-k-mooney | i think i rememebr who they were too | 13:40 |
| kashyap | sean-k-mooney: The patch is only posted now. There was no patch before | 13:40 |
| sean-k-mooney | i just dont want to name drop in case im wrong | 13:40 |
| kashyap | You're imagining the conversation. Really. | 13:40 |
| sean-k-mooney | kashyap: we have discussed this in person at a desing summit before | 13:41 |
| kashyap | Oh, well. I was not there; or don't remember the details. | 13:41 |
| kashyap | It is simply overkill; and is not just worth it. What is there is clear, and intuitive. That suffices. | 13:42 |
| * kashyap needs a walk; feeling grumpy | 13:42 | |
| *** iurygregory has quit IRC | 13:47 | |
| *** macz_ has joined #openstack-nova | 13:47 | |
| *** ociuhandu has quit IRC | 13:48 | |
| *** ociuhandu has joined #openstack-nova | 13:49 | |
| *** iurygregory has joined #openstack-nova | 13:50 | |
| *** macz_ has quit IRC | 13:52 | |
| *** ociuhandu has quit IRC | 13:53 | |
| *** ociuhandu has joined #openstack-nova | 13:53 | |
| *** jangutter has joined #openstack-nova | 13:54 | |
| *** mlavalle has joined #openstack-nova | 13:55 | |
| *** martinkennelly has joined #openstack-nova | 13:56 | |
| *** sapd1 has joined #openstack-nova | 13:56 | |
| *** jangutter_ has quit IRC | 13:57 | |
| *** spatel has joined #openstack-nova | 13:58 | |
| bauzas | stephenfin: working on the new rev | 14:03 |
| bauzas | stephenfin: could we discuss on https://review.opendev.org/c/openstack/nova/+/773976/7/nova/exception.py ? | 14:06 |
| stephenfin | bauzas: sure, what's up? | 14:10 |
| stephenfin | did you see my comment on the next patch also? | 14:10 |
| bauzas | stephenfin: just uploaded my comments | 14:12 |
| * stephenfin refreshes | 14:12 | |
| * bauzas goes looking at the next change | 14:13 | |
| sean-k-mooney | ah here https://review.opendev.org/c/openstack/nova/+/773976/7/nova/scheduler/utils.py#1370 | 14:13 |
| sean-k-mooney | ys its used in both | 14:13 |
| sean-k-mooney | thats called form the request filter in the next change right | 14:14 |
| sean-k-mooney | ya here https://review.opendev.org/c/openstack/nova/+/749068/17/nova/scheduler/request_filter.py#341 | 14:15 |
| bauzas | sean-k-mooney: yup | 14:15 |
| bauzas | honestly, we should just supporting this exception | 14:15 |
| bauzas | for all of the issues | 14:15 |
| bauzas | we could have other exceptions, like for looking at the port | 14:15 |
| bauzas | but for getting a NoValidHost, just the above should be needed | 14:16 |
| bauzas | anyway, stephenfin provided me a good concern for https://review.opendev.org/c/openstack/nova/+/749068/17/nova/tests/fixtures.py so I'll provide a new revision, but in case we want to dicuss about exceptions here, maybe let's agree on providing a new FUP then | 14:17 |
| *** links has quit IRC | 14:17 | |
| *** links has joined #openstack-nova | 14:18 | |
| stephenfin | bauzas: hmm, so we do | 14:18 |
| stephenfin | I hate to say it but could we use two exceptions? /o\ | 14:18 |
| stephenfin | I know it's sort of bikeshedding, but I'm uncomfortable with using non-generic exceptions across multiple "services"# | 14:19 |
| stephenfin | with the obvious caveat that if everyone else disagrees with me or thinks it's not an option, I can go along with the majority | 14:20 |
| bauzas | well, I can see your concerns | 14:22 |
| bauzas | let me try to first upload the new series and discuss about it later for a FUP | 14:22 |
| stephenfin | sounds good to me | 14:22 |
| *** macz_ has joined #openstack-nova | 14:29 | |
| *** macz_ has quit IRC | 14:34 | |
| bauzas | stephenfin: huh, /me is a sad panda again due to mypy https://review.opendev.org/c/openstack/nova/+/773976/7/nova/network/neutron.py#3533 | 14:42 |
| bauzas | because of static type checking, we need to change code | 14:42 |
| bauzas | it's like when we want to tell about objects and we need to avoid circular imports | 14:42 |
| bauzas | sounds to me that mypy is strictier than it should and prevents us good faith | 14:43 |
| bauzas | any static type checker shouldn't be invasive | 14:43 |
| bauzas | so, I'll explicitly return None as I stepped into this 'shit' (with the left foot hopefully), but that won't convince me of the mypy opportunity | 14:44 |
| bauzas | and if I was grumpy (which i was horribly last days and I apologize), I could just remove all my annotations from the code I wrote | 14:45 |
| bauzas | but I'll continue the game | 14:45 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [OVN] Adapt the live-migration job scripts to work with OVN https://review.opendev.org/c/openstack/nova/+/776419 | 14:47 |
| bauzas | at least, having static type tool developers being pedantic and opionated about what python should be seems to be fragile for the very least | 14:47 |
| gibi | bauzas: I felt the same when I got introduced to this return None change. It is a pain. But it is a one time pain and I believe the explicit types will give us gains when reading and changing the code later | 14:47 |
| bauzas | again, not convinced from the experience I have of various linters | 14:47 |
| bauzas | and again, python is all duck typing | 14:48 |
| bauzas | having developers convinced of the opposite seems terrible to me frankly | 14:48 |
| *** whoami-rajat__ is now known as whoami-rajat | 14:48 | |
| bauzas | the fact is, OpenStack is made with python, OK | 14:49 |
| bauzas | but it's just a language | 14:49 |
| bauzas | and we shouldn't be doing pythonesque things because of python, but rather because we want it | 14:49 |
| *** zimmerry has joined #openstack-nova | 14:50 | |
| *** macz_ has joined #openstack-nova | 14:50 | |
| sean-k-mooney | bauzas: i think the different is that we disagree on what improves the code | 14:50 |
| *** tosky has quit IRC | 14:51 | |
| *** tosky_ has joined #openstack-nova | 14:51 | |
| *** tosky_ is now known as tosky | 14:51 | |
| bauzas | being explicit on the fact that return has to return None doesn't sound to me a major improvement :) | 14:51 |
| bauzas | and a linter never proved me enough confidence in the fact we would write better code | 14:52 |
| bauzas | better code is written by people who better understand code | 14:52 |
| sean-k-mooney | it depens how far you take it. if you look at c++ for example being able to annotate funcitons with nodiscard is powerful | 14:52 |
| bauzas | and code reviews certainly help more than any linter | 14:53 |
| sean-k-mooney | e.g. it allows you to state if you dont at least store and preferebaly check the retrun value then its a logic error | 14:53 |
| bauzas | like, the best comments from stephenfin would never be caught by a linter | 14:53 |
| bauzas | and I feel we are distracting ourselves | 14:53 |
| sean-k-mooney | true but i think type hint aid understanding. we dont have to use them but i think we would have better code if we did | 14:54 |
| bauzas | giving us false confidence that we will improve our internal APIs | 14:54 |
| *** macz_ has quit IRC | 14:54 | |
| bauzas | fwiw, I did a lot of programming with strong typed languages | 14:55 |
| sean-k-mooney | well i have seen too many bugs cause by using incorrect data in our tests to think that if we enforced type better it would not happen | 14:55 |
| bauzas | and I never saw this being a benefit for distributed programming | 14:55 |
| sean-k-mooney | python is a stongly typed language | 14:55 |
| bauzas | Java pursues the idea that annotations help microservices | 14:55 |
| sean-k-mooney | its just not staticly typed | 14:55 |
| bauzas | but trust me, you can write terrible microservices in Java despite using annotations | 14:56 |
| sean-k-mooney | of coruce you can | 14:56 |
| sean-k-mooney | its a tool like any other | 14:56 |
| bauzas | right | 14:56 |
| sean-k-mooney | you can always missuse a tool if you dont understand it | 14:56 |
| bauzas | but if a tool (or a process), instead of easing my work, requires me to further work, this doesn't sound to me then right | 14:57 |
| sean-k-mooney | well personly i always found the parms in docs sting unhelpfull and a hinderance to future work | 14:57 |
| bauzas | and here, explicitly stating "return None" in order to get my code merged doesn't sound to me great at most | 14:57 |
| sean-k-mooney | they get out of data and you have to check it | 14:58 |
| sean-k-mooney | well you are relying on an implict convertion to None otherwise | 14:58 |
| sean-k-mooney | if you just do return | 14:58 |
| bauzas | sean-k-mooney: they get out of data by lack of solid reviews | 14:58 |
| sean-k-mooney | return None is more explcit | 14:58 |
| sean-k-mooney | not eveyone know if you do return it accutly become the same a return None | 14:59 |
| bauzas | again, that's why we have Gerrit | 14:59 |
| bauzas | humans are the best linters by far | 15:00 |
| sean-k-mooney | im not sure this is getting us anywhere productive | 15:00 |
| sean-k-mooney | and since im currently in a low to moderate amount of pain im goignto try an get some work done sorry | 15:01 |
| gibi | bauzas: return None is price to gain every benefit of mypy, it is not return None that directly helps you | 15:01 |
| gibi | return None enables mypy to helps us :) | 15:03 |
| bauzas | gibi: my other concern is that we currently make mypy fencing our gate | 15:04 |
| sean-k-mooney | bauzas: we dont | 15:04 |
| bauzas | sean-k-mooney: really ? | 15:04 |
| sean-k-mooney | its not enforced by ci | 15:04 |
| sean-k-mooney | unless we put it in the pep8 job | 15:04 |
| sean-k-mooney | but i did not think we did | 15:05 |
| bauzas | then, can I leave "return" without explicitely following it by "None" ? | 15:05 |
| sean-k-mooney | let me check | 15:05 |
| bauzas | in the past, we decided which PEPs we were following | 15:05 |
| sean-k-mooney | oh sorry ya we do https://github.com/openstack/nova/blob/master/tox.ini#L57 | 15:06 |
| sean-k-mooney | but only on the files we have enabled | 15:06 |
| sean-k-mooney | thats why im miss remembering | 15:06 |
| bauzas | right, my point | 15:06 |
| bauzas | anyway, 1:1 now | 15:06 |
| gibi | bauzas: what we are fencing against is a half done mypy support. If you don't want to use mypy you dont add any annotation to a function the mypy will assume Any | 15:06 |
| sean-k-mooney | if its not listed in https://github.com/openstack/nova/blob/master/mypy-files.txt we currently dont enforce it | 15:07 |
| gibi | bauzas: as soon as you added some annotation to a function then you have to make it complete and consistent for mypy | 15:07 |
| gibi | we are fencing against that | 15:07 |
| gibi | to avoid wrong type annotation | 15:07 |
| gibi | as wrong annotation is worst than no annotation | 15:07 |
| sean-k-mooney | yep | 15:07 |
| sean-k-mooney | its worse then no annotation | 15:08 |
| stephenfin | bauzas: Don't you feel we're going in roundabouts here? :) | 15:09 |
| artom | Yeah, but you're Irish, so you're going round the other way | 15:10 |
| sean-k-mooney | lol | 15:10 |
| *** dave-mccowan has joined #openstack-nova | 15:11 | |
| sean-k-mooney | did people see the securit sig email a few minuts ago | 15:11 |
| *** ihti[m] has joined #openstack-nova | 15:12 | |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1798904 might be mitgated by the patches for https://bugs.launchpad.net/neutron/+bug/1734320 the last of which is https://review.opendev.org/c/openstack/nova/+/602432 | 15:13 |
| openstack | Launchpad bug 1798904 in os-vif "tenant isolation is bypassed if port admin-state-up=false" [Critical,Confirmed] - Assigned to sean mooney (sean-k-mooney) | 15:13 |
| openstack | Launchpad bug 1734320 in os-vif "Eavesdropping private traffic" [High,Fix released] - Assigned to sean mooney (sean-k-mooney) | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs https://review.opendev.org/c/openstack/nova/+/706295 | 15:13 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1552042 im not familar with | 15:13 |
| openstack | Launchpad bug 1552042 in OpenStack Compute (nova) "Host data corruption through nova inject_key feature" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 15:13 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add net & utils methods for routed nets & segments https://review.opendev.org/c/openstack/nova/+/773976 | 15:14 |
| sean-k-mooney | looks like mriedem was trying to remove the file injefction feature with https://review.opendev.org/c/openstack/nova/+/324720/ | 15:14 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 15:14 |
| *** efried has joined #openstack-nova | 15:18 | |
| gibi | artom: lol | 15:20 |
| *** ociuhandu has quit IRC | 15:24 | |
| *** ociuhandu has joined #openstack-nova | 15:25 | |
| *** links has quit IRC | 15:27 | |
| *** zoharm1 has quit IRC | 15:29 | |
| *** ociuhandu has quit IRC | 15:30 | |
| *** ociuhandu has joined #openstack-nova | 15:30 | |
| sean-k-mooney | gibi: fyi just updated https://bugs.launchpad.net/nova/+bug/1798904 with my current understanding perhapes we shoudl review https://bugs.launchpad.net/nova/+bug/1552042 in the team call | 15:34 |
| openstack | Launchpad bug 1798904 in os-vif "tenant isolation is bypassed if port admin-state-up=false" [Critical,Confirmed] - Assigned to sean mooney (sean-k-mooney) | 15:34 |
| openstack | Launchpad bug 1552042 in OpenStack Compute (nova) "Host data corruption through nova inject_key feature" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 15:34 |
| sean-k-mooney | by which i mean nova meeting | 15:34 |
| sean-k-mooney | stephenfin: have we removed file injection yet? | 15:36 |
| stephenfin | I don't think so | 15:37 |
| stephenfin | From nova, you mean? | 15:38 |
| sean-k-mooney | ya | 15:38 |
| stephenfin | I don't think we can without bumping out minimum API microversion | 15:38 |
| sean-k-mooney | we deprecated it queens for removal | 15:38 |
| stephenfin | *our | 15:38 |
| stephenfin | Right? | 15:38 |
| sean-k-mooney | well you just deleted half of the hyperviors api | 15:38 |
| sean-k-mooney | and remove xen specifc ones last cycle | 15:38 |
| sean-k-mooney | so we could | 15:38 |
| stephenfin | That's different though | 15:39 |
| *** spatel has quit IRC | 15:39 | |
| sean-k-mooney | how | 15:39 |
| sean-k-mooney | you flat out removed api with no fallback | 15:39 |
| stephenfin | Right, but this would involve suggested removing certain microversions and keeping the rest of the API | 15:40 |
| sean-k-mooney | we partly have doe this by the way in https://github.com/openstack/nova/blob/e6f5e814050a19d6f027037424556b2889514ec3/nova/api/openstack/compute/rest_api_version_history.rst#257 | 15:40 |
| stephenfin | Or at least having those microversions behave differently on one server than another | 15:40 |
| stephenfin | which is arguably worse, depending on how much of a purist you are | 15:40 |
| sean-k-mooney | yep thats what will happen with the xenapis or hyperviors | 15:41 |
| sean-k-mooney | or any other api wehre we now return a 404 and removed the code | 15:41 |
| stephenfin | not realllly | 15:42 |
| sean-k-mooney | im really not seeing why it is not | 15:42 |
| stephenfin | we've never (knowingly) changed behavior of an existing microversion | 15:42 |
| stephenfin | except where it was returning a 5xx error | 15:42 |
| stephenfin | right? | 15:43 |
| sean-k-mooney | sure we have | 15:43 |
| sean-k-mooney | you jsut did it with the hyperviors stats api | 15:43 |
| sean-k-mooney | you cant use the old microverion and get that back right? | 15:43 |
| stephenfin | No, you can | 15:43 |
| sean-k-mooney | really i though you were killing the code | 15:44 |
| stephenfin | 2.87 and boom, you're back to the bad old world full of lies and deceit | 15:44 |
| stephenfin | nope | 15:44 |
| *** k_mouza has quit IRC | 15:44 | |
| stephenfin | cos we don't do that | 15:44 |
| stephenfin | unless we have no choice | 15:44 |
| sean-k-mooney | well you did kill the code for xen | 15:44 |
| stephenfin | yes, we had no choice there. The APIs didn't work without it | 15:44 |
| sean-k-mooney | and we have killed the code for nova networks and cells v1 | 15:44 |
| *** k_mouza has joined #openstack-nova | 15:44 | |
| stephenfin | but we never had a release where 2.N still existed but gave different responses to previous releases | 15:45 |
| sean-k-mooney | im not sure about that | 15:45 |
| *** dklyle has joined #openstack-nova | 15:45 | |
| stephenfin | 2.N should yield consistent behaviour until we reach the point where we can no longer support it, in which case it'll return 404 or 410 for all microversions | 15:46 |
| sean-k-mooney | do we still have the code for the xen specific console server action | 15:46 |
| stephenfin | I think that's a HTTP 410 now | 15:46 |
| stephenfin | Or 404, I don't recall | 15:46 |
| sean-k-mooney | so there is a case where its go. | 15:47 |
| sean-k-mooney | your conserned that we woudl be breaking server cretae for those that use file injection | 15:47 |
| sean-k-mooney | usign the old microverion | 15:47 |
| stephenfin | yeah, exactly | 15:47 |
| sean-k-mooney | right im suggesting its been deprecated for remval since queens | 15:47 |
| sean-k-mooney | and we shoudl actully remove it | 15:47 |
| stephenfin | We don't think anyone was using the Xen stuff, and we know they couldn't use the nova-network stuff | 15:48 |
| stephenfin | You'd only know that if you used a newer microversion though | 15:48 |
| stephenfin | and if you're using OSC, you're probably using 2.1 | 15:48 |
| stephenfin | for now - we're working on it | 15:48 |
| sean-k-mooney | yep probably | 15:48 |
| stephenfin | this really feels like a PTG discussion | 15:48 |
| stephenfin | or at least openstack-discuss | 15:48 |
| sean-k-mooney | well its a long standing public security bug | 15:48 |
| stephenfin | since you and I can't decide this unilaterally | 15:49 |
| sean-k-mooney | we can fix it other ways too | 15:49 |
| stephenfin | yup, aware there are attenuating circumstances here | 15:49 |
| sean-k-mooney | i just dont want us to keep putting of fixing the secuity bug | 15:49 |
| sean-k-mooney | deprecation happend via this spec by the way minimum supported microversion in the distant future. | 15:50 |
| sean-k-mooney | .... | 15:50 |
| sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html#rest-api-impact | 15:51 |
| stephenfin | now bumping the API minimum is something I could get behind | 15:51 |
| stephenfin | we're coming close to 3 digit microversions... | 15:51 |
| sean-k-mooney | yep | 15:51 |
| stephenfin | that's _definitely_ a PTG discussion though :-D | 15:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [OVN] Adapt the live-migration job scripts to work with OVN https://review.opendev.org/c/openstack/nova/+/776419 | 15:51 |
| sean-k-mooney | and we called that out in the spec by the way | 15:51 |
| sean-k-mooney | " The point of this microversion is really to signal that users should not be using this legacy part of the compute API, and to set a timer on when it could be removed if nova ever starts requiring a higher minimum supported microversion in the distant future." | 15:52 |
| sean-k-mooney | gibi: is there an etherpad for the xena ptg? | 15:52 |
| sean-k-mooney | gibi: part of me really wants to declare xena a tech debt removal cycle | 15:53 |
| sean-k-mooney | but i do think discussing raising the min microverion may be somethign we shoudl discuss or a differnt path to removing long deperecated apis | 15:54 |
| gibi | sean-k-mooney: good point I should have start a xena ptg pad | 15:54 |
| sean-k-mooney | gibi: ya that getting worringly close... | 15:54 |
| * sean-k-mooney still has to finish features | 15:54 | |
| gibi | sean-k-mooney: I've just read back, if you want to discuss the unembargoed security bug on the meeting then please bring it up :) either in the bug section or in the OpenDiscussion | 15:55 |
| sean-k-mooney | an sure i thin the networking one im goign to fix via other work so ill just add it to the things i test | 15:56 |
| gibi | ok | 15:56 |
| * sean-k-mooney if we were to raise min micoro version 2.60 (queens) would be nice. | 15:57 | |
| *** lpetrut has quit IRC | 16:00 | |
| gibi | sean-k-mooney: xena ptg etherpad https://etherpad.opendev.org/p/nova-xena-ptg | 16:00 |
| sean-k-mooney | gibi: thanks im going to try and avoid adding too much to it if i can :) | 16:01 |
| gibi | sean-k-mooney: do not limit yourself, we can always remove things later :) | 16:01 |
| sean-k-mooney | oh you already have the do not translate message nice | 16:01 |
| *** spatel has joined #openstack-nova | 16:01 | |
| *** vishalmanchanda has quit IRC | 16:02 | |
| gibi | carried over from the wallaby pad :) | 16:02 |
| sean-k-mooney | ya i guess i just havent done my onw retro on how things have gone over the last 6-12 monts and what did/didnt get done | 16:02 |
| gibi | sean-k-mooney: btw team meeting is ongoing :) | 16:03 |
| gibi | if you want to mention something | 16:03 |
| sean-k-mooney | oh ya :) | 16:03 |
| *** khomesh24 has quit IRC | 16:09 | |
| *** spatel has quit IRC | 16:13 | |
| *** spatel has joined #openstack-nova | 16:22 | |
| *** macz_ has joined #openstack-nova | 16:56 | |
| sean-k-mooney | actully looks liek we have a few others that were not on the list | 16:58 |
| sean-k-mooney | like https://bugs.launchpad.net/nova/+bug/1861893 | 16:58 |
| openstack | Launchpad bug 1861893 in OpenStack Compute (nova) "os-assisted-volume-snapshots passes unsanitised file path to the libvirt driver" [Medium,Confirmed] | 16:58 |
| sean-k-mooney | we could not actuly exploit ^ so its just a security hardening case | 16:59 |
| openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | 16:59 |
| sean-k-mooney | specificly class c1 "Not considered a practical vulnerability (but some people might assign a CVE for it)" | 16:59 |
| * lyarwood can take https://bugs.launchpad.net/nova/+bug/1861893 | 17:00 | |
| openstack | Launchpad bug 1861893 in OpenStack Compute (nova) "os-assisted-volume-snapshots passes unsanitised file path to the libvirt driver" [Medium,Confirmed] | 17:00 |
| *** macz_ has quit IRC | 17:01 | |
| gibi | stephenfin, dansmith: I have extra logs for the slowness of the db migration tests (even after the compaction) https://review.opendev.org/c/openstack/nova/+/775094 This result confirms for me that it is simply an extremely slow test node with noisy neighbors. I have not got new ideas how to move forward with this | 17:05 |
| *** luksky has quit IRC | 17:05 | |
| sean-k-mooney | can we increase the timeout wait again | 17:13 |
| sean-k-mooney | you tweaked it previously if im remebring corectly | 17:14 |
| sean-k-mooney | if its really just a slow node retrying it like the pytest flaky decorator does wont help | 17:14 |
| sean-k-mooney | gibi: alternitivly i dont know if there is a way to do the db walk in multiple tests | 17:15 |
| sean-k-mooney | e.g decompose it to do it in severnal batches of verions over 2+ tests | 17:15 |
| sean-k-mooney | but ya not really sure how to workaroud this | 17:16 |
| sean-k-mooney | at least nothing to adress the underlying issue | 17:16 |
| dansmith | gibi: what provider? | 17:16 |
| *** macz_ has joined #openstack-nova | 17:17 | |
| dansmith | gibi: tripleo was having some IO problems on a vexx node, but we did a bunch of digging into the node stats and it seemed like it was just too many noisy neighbors | 17:17 |
| dansmith | gibi: oh that's an arm64 run | 17:18 |
| sean-k-mooney | in that case ya | 17:19 |
| sean-k-mooney | so Provider: linaro-us | 17:20 |
| sean-k-mooney | although the py39 verion passed in hlaf the time | 17:20 |
| sean-k-mooney | so its not a genral problem with the provider but there might be too high a contention on some hosts | 17:21 |
| gibi | sean-k-mooney: I can increase the timeout yes | 17:21 |
| gibi | dansmith: I can do some more recheck to get a non arm failure if that helps | 17:21 |
| *** macz_ has quit IRC | 17:22 | |
| dansmith | gibi: well, I'm just saying, I don't know much about that environment.. could be raspberry pis and slow SD cards for all I know :P | 17:22 |
| gibi | dansmith: OK :) | 17:22 |
| sean-k-mooney | dansmith: they are realy arm server systems | 17:22 |
| dansmith | sean-k-mooney: I know :P | 17:23 |
| stephenfin | I think they're emulated | 17:24 |
| stephenfin | Assuming it's the same machines that you linked me from the kolla jobs yesterday, sean-k-mooney | 17:24 |
| dansmith | really? I thought these were actual arm boxes | 17:24 |
| sean-k-mooney | dansmith: https://zuul.openstack.org/build/b038b4112ef34b15b885f204da27c808/log/primary/logs/kolla/nova/nova-compute.txt#843 | 17:24 |
| sean-k-mooney | stephenfin: its is and its not emulated | 17:24 |
| sean-k-mooney | well they are vms if that is what you mean | 17:25 |
| stephenfin | I mean it's using <domain>qemu</domain> | 17:25 |
| sean-k-mooney | but this i arm hardware provide by linaro to do real testing on arm | 17:25 |
| stephenfin | not <domain>kvm</domain> | 17:25 |
| sean-k-mooney | stephenfin: right but thats becasue we disabel nested vert | 17:26 |
| stephenfin | so it's entirely software emulation, right? | 17:26 |
| stephenfin | okay, cool, that's all I was saying | 17:26 |
| sean-k-mooney | the vms created by it will use qemu without kvm in the kolla job | 17:26 |
| stephenfin | the PPC jobs you linked are running on bare metal (with KVM) | 17:26 |
| sean-k-mooney | but the vms we are runing the test in are on real arm hardware | 17:26 |
| sean-k-mooney | stephenfin: yep its a third party ci | 17:27 |
| *** ociuhandu has quit IRC | 17:27 | |
| sean-k-mooney | stephenfin: nested vrit was disabled by policy in the first party ci | 17:27 |
| sean-k-mooney | that has been relaxed slightly more recnetly but its still not gernarally avaliable | 17:28 |
| stephenfin | yup | 17:28 |
| stephenfin | fwiw, the PPC jobs seem to be running on bare metal or nested virt | 17:28 |
| stephenfin | I'm not sure which | 17:28 |
| stephenfin | but KVM is enabled | 17:29 |
| sean-k-mooney | i would guess nested virt | 17:29 |
| sean-k-mooney | did they only have 8 cores? | 17:29 |
| stephenfin | as would I. Letting arbitrary jobs loose on bare metal doesn't sound so good | 17:29 |
| sean-k-mooney | and 8 G of ram | 17:29 |
| stephenfin | Oh, I don't recall and I don't have the links handy | 17:30 |
| sean-k-mooney | the arm jobs are 8 cores and 8g of ram like or standard ci flavors | 17:30 |
| sean-k-mooney | stephenfin: not important but htat a good way to ficure out if its nested virt or not even with host passthough | 17:31 |
| stephenfin | yup, good point that | 17:31 |
| * sean-k-mooney forgot to disabel image integraty check when installing | 17:33 | |
| sean-k-mooney | that takes over an hour if your doing a remote instal like i am | 17:33 |
| *** rpittau is now known as rpittau|afk | 17:47 | |
| *** ociuhandu has joined #openstack-nova | 17:50 | |
| *** ociuhandu has quit IRC | 17:50 | |
| *** ociuhandu has joined #openstack-nova | 17:51 | |
| *** luksky has joined #openstack-nova | 17:54 | |
| *** ociuhandu has quit IRC | 17:55 | |
| *** dtantsur is now known as dtantsur|afk | 18:00 | |
| *** k_mouza has quit IRC | 18:04 | |
| *** macz_ has joined #openstack-nova | 18:09 | |
| *** macz_ has quit IRC | 18:14 | |
| *** ralonsoh has quit IRC | 18:15 | |
| *** derekh has quit IRC | 18:24 | |
| *** sapd1 has quit IRC | 18:28 | |
| *** macz_ has joined #openstack-nova | 18:30 | |
| *** andrewbonney has quit IRC | 18:34 | |
| *** macz_ has quit IRC | 18:35 | |
| *** xarlos has joined #openstack-nova | 18:47 | |
| *** efried has quit IRC | 18:49 | |
| *** bbowen has quit IRC | 19:06 | |
| *** arne_wiebalck has quit IRC | 19:15 | |
| *** mgoddard has quit IRC | 19:17 | |
| *** mgoddard has joined #openstack-nova | 19:18 | |
| *** efried has joined #openstack-nova | 19:41 | |
| spatel | sean-k-mooney any idea i am seeing this error on nova - ERROR stevedore.extension [req-249d0078-a423-4815-9c32-589f1814209a 3ffb7b8d55e1471aa56407e5a583037f 584651a0fe954d9480435678ea3ce5ba - default default] Could not load 'oslo_cache.etcd3gw': No module named 'etcd3gw': ModuleNotFoundError: No module named 'etcd3gw' | 19:47 |
| *** arne_wiebalck has joined #openstack-nova | 19:58 | |
| sean-k-mooney | am its realted to how oslo.cache is loading all the backend drivers even if you are not using it | 19:59 |
| sean-k-mooney | it wont break anything but it should be fixed at some point | 19:59 |
| spatel | thank you for confirmation. | 20:00 |
| sean-k-mooney | when it import the backeds to see which one it shoudl use its uncondtionaly trying to import etcd3gw package | 20:01 |
| spatel | After rebooting my rabbitMQ cluster look like everything slowed down, VM creation process and VM delete process are very slow | 20:01 |
| spatel | I have noticed this in nova logs - failed to perform operation on queue 'notifications_designate.info' in vhost '/nova' due to timeout | 20:02 |
| spatel | when i checked designate.info queue on rabbitMQ and it doesn't exist | 20:02 |
| sean-k-mooney | well if you restarted it its going to cause all the compute to have to reconnect | 20:02 |
| sean-k-mooney | depending on how it happend you might need to restart the nove comptue agents too | 20:02 |
| spatel | hmm! i did rolling restart node-1 then node-2 ... node-3 | 20:03 |
| sean-k-mooney | depending on how you have the clustering set up and loadbalnce it may or may not help | 20:04 |
| spatel | i don't mind to restart all compute agent or nova-api | 20:04 |
| spatel | i am wondering about 'notifications_designate.info' queue, who create that queue ? | 20:05 |
| spatel | does nova create that queue when it receive designate notification? | 20:05 |
| sean-k-mooney | its the other way around | 20:06 |
| sean-k-mooney | designate subscipes to nova notifiction | 20:06 |
| sean-k-mooney | nova does not listten for notificaiton | 20:06 |
| spatel | how do i get that queue back? 'notifications_designate.info' | 20:07 |
| sean-k-mooney | posibly restart the designate server but i dont really know | 20:08 |
| spatel | what if i tell nova.conf driver = noop | 20:08 |
| spatel | I did restart designate but no luck | 20:08 |
| johnsom | spatel Did you upgrade designate? Newer versions don't rely on rabbit or the sink for nova/neutron/designate messaging. | 20:14 |
| spatel | I didn't upgrade designate, i am running victoria one | 20:14 |
| spatel | johnsom it was working before but after rabbitMQ rolling restart everything looks bad | 20:15 |
| spatel | i may try to re-install designate | 20:15 |
| johnsom | Hmm, that seems unnecessary. | 20:16 |
| johnsom | I really haven't poked too much at the notifications, so don't have a lot of experience there. You could ask in the #openstack-dns channel though. Others there may have more details on the notifications. | 20:17 |
| *** gyee has joined #openstack-nova | 20:18 | |
| spatel | johnsom agreed, i am seeing when i create vm it takes almost 5 min to spun up, getting stuck in scheduling... | 20:18 |
| spatel | if i delete vm it get stuck in deleting stat for 5 min.. | 20:18 |
| spatel | all i am seeing in error related designate.info queue not found | 20:19 |
| *** slaweq has quit IRC | 20:21 | |
| *** k_mouza has joined #openstack-nova | 20:29 | |
| *** k_mouza has quit IRC | 20:34 | |
| *** tbarron|out has joined #openstack-nova | 20:38 | |
| *** arne_wiebalck has quit IRC | 21:05 | |
| *** mgagne has quit IRC | 21:08 | |
| spatel | johnsom after restarting glance i found VM creating process speed up but deleting still taking 5 min to delete vm | 21:19 |
| johnsom | So maybe the designate messages are not related | 21:19 |
| spatel | possible | 21:21 |
| spatel | my rabbitMQ cluster also looking health so not sure what holding back to delete vm | 21:21 |
| spatel | not seeing any error also.. | 21:21 |
| *** whoami-rajat has quit IRC | 21:21 | |
| spatel | let me restart all service except rabbitMQ and see | 21:22 |
| *** arne_wiebalck has joined #openstack-nova | 21:27 | |
| *** xek has quit IRC | 21:47 | |
| *** belmoreira has quit IRC | 21:50 | |
| *** bbowen has joined #openstack-nova | 21:59 | |
| *** ociuhandu has joined #openstack-nova | 22:33 | |
| *** rcernin has joined #openstack-nova | 23:03 | |
| spatel | johnsom does image-caching is disable when using Ceph storage for glance? | 23:04 |
| johnsom | spatel Sorry, I have no idea. | 23:04 |
| spatel | I wonder that was my issue because recently i migrated glance to ceph rbd | 23:04 |
| spatel | may be that is why its very slow to create VM (earlier when i was using local disk with glance talking few second to spun up vm) | 23:05 |
| spatel | taking* | 23:05 |
| *** rcernin has quit IRC | 23:11 | |
| *** rcernin has joined #openstack-nova | 23:12 | |
| *** tosky has quit IRC | 23:31 | |
| *** ociuhandu has quit IRC | 23:44 | |
| spatel | johnsom all my problem solved :) | 23:46 |
| johnsom | spatel Oh good | 23:46 |
| spatel | after setting driver = noop in nova-api and nova-compute* nodes | 23:46 |
| spatel | my issue is nova still looking for designate.info queue which doesn't exist and that was causing all chaos | 23:47 |
| spatel | I need to work on designate to find out what is going on but i believe interim solution is to tell nova don't look for notification queue | 23:48 |
| spatel | anyway! time for dinner! see you tomorrow.. thank you for your support. | 23:49 |
| *** spatel has quit IRC | 23:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!