| *** tosky has quit IRC | 00:15 | |
| *** LinPeiWen42 has joined #openstack-nova | 00:31 | |
| *** sapd1 has joined #openstack-nova | 01:24 | |
| *** martinkennelly has quit IRC | 01:40 | |
| *** dviroel has quit IRC | 01:54 | |
| *** mlavalle has quit IRC | 01:55 | |
| openstackgerrit | Merged openstack/nova master: zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702 | 02:06 |
|---|---|---|
| openstackgerrit | Merged openstack/nova master: zuul: Mark nova-lvm as voting https://review.opendev.org/c/openstack/nova/+/772871 | 02:06 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 02:10 |
| *** zzzeek has quit IRC | 02:12 | |
| *** zzzeek has joined #openstack-nova | 02:12 | |
| *** lbragstad_ has joined #openstack-nova | 02:14 | |
| *** k_mouza has joined #openstack-nova | 02:15 | |
| *** lbragstad has quit IRC | 02:17 | |
| *** hemanth_n has joined #openstack-nova | 02:19 | |
| *** k_mouza has quit IRC | 02:19 | |
| *** rcernin has quit IRC | 02:37 | |
| *** rcernin has joined #openstack-nova | 02:51 | |
| *** tbachman has quit IRC | 02:51 | |
| *** tbachman has joined #openstack-nova | 02:54 | |
| *** tbachman_ has joined #openstack-nova | 02:56 | |
| *** tbachman has quit IRC | 02:59 | |
| *** tbachman_ is now known as tbachman | 02:59 | |
| *** LinPeiWen42 has quit IRC | 03:13 | |
| *** dustinc has joined #openstack-nova | 03:29 | |
| *** lbragstad_ is now known as lbragstad | 03:51 | |
| *** spatel has quit IRC | 04:13 | |
| *** spatel has joined #openstack-nova | 04:14 | |
| *** zul has quit IRC | 04:16 | |
| *** ratailor has joined #openstack-nova | 04:19 | |
| *** LinPeiWen has joined #openstack-nova | 04:23 | |
| *** spatel has quit IRC | 04:24 | |
| *** spatel has joined #openstack-nova | 04:24 | |
| *** links has joined #openstack-nova | 04:25 | |
| *** swp20 has quit IRC | 04:27 | |
| *** swp20 has joined #openstack-nova | 04:27 | |
| *** lemko2 has joined #openstack-nova | 04:28 | |
| *** lemko has quit IRC | 04:29 | |
| *** lemko2 is now known as lemko | 04:29 | |
| *** spatel has quit IRC | 04:34 | |
| *** brinzhang has quit IRC | 04:52 | |
| *** brinzhang has joined #openstack-nova | 04:53 | |
| *** brinzhang_ has joined #openstack-nova | 05:02 | |
| *** brinzhang has quit IRC | 05:05 | |
| *** khomesh24 has joined #openstack-nova | 05:34 | |
| *** xinranwang has joined #openstack-nova | 05:35 | |
| xinranwang | Hi all, fyi, here is a test report for smartnic support. We have tested the code in local, you can also following the report's instruction to test our patches. https://wiki.openstack.org/wiki/Cyborg/TestReport/IntelNic | 05:37 |
| *** dustinc has quit IRC | 05:39 | |
| *** lemko has quit IRC | 05:46 | |
| *** lemko7 has joined #openstack-nova | 05:46 | |
| *** khomesh24 has quit IRC | 05:47 | |
| *** sapd1 has quit IRC | 05:54 | |
| *** khomesh24 has joined #openstack-nova | 05:55 | |
| *** khomesh24 has quit IRC | 05:55 | |
| *** khomesh24 has joined #openstack-nova | 05:56 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Centralize sqlite FK constraint enforcement https://review.opendev.org/c/openstack/nova/+/773833 | 05:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Dynamically archive FK related records in archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/773834 | 05:56 |
| *** rcernin has quit IRC | 06:08 | |
| *** rcernin has joined #openstack-nova | 06:08 | |
| *** ratailor has quit IRC | 06:14 | |
| *** ratailor has joined #openstack-nova | 06:14 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-nova | 06:17 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-nova | 06:19 | |
| *** k_mouza has joined #openstack-nova | 06:26 | |
| *** ratailor has quit IRC | 06:28 | |
| *** ratailor has joined #openstack-nova | 06:28 | |
| *** k_mouza has quit IRC | 06:30 | |
| *** sapd1 has joined #openstack-nova | 06:49 | |
| *** dasp has joined #openstack-nova | 07:00 | |
| *** dasp_ has quit IRC | 07:01 | |
| *** brinzhang_ has quit IRC | 07:04 | |
| *** brinzhang_ has joined #openstack-nova | 07:04 | |
| *** khomesh24 has quit IRC | 07:24 | |
| *** aarents has joined #openstack-nova | 07:25 | |
| *** slaweq has joined #openstack-nova | 07:28 | |
| *** ralonsoh has joined #openstack-nova | 07:28 | |
| *** vishalmanchanda has joined #openstack-nova | 07:33 | |
| *** sapd1 has quit IRC | 07:37 | |
| *** khomesh24 has joined #openstack-nova | 07:40 | |
| *** sapd1 has joined #openstack-nova | 07:42 | |
| *** ircuser-1 has joined #openstack-nova | 07:45 | |
| *** zenkuro has joined #openstack-nova | 07:52 | |
| *** dklyle has quit IRC | 07:58 | |
| *** zenkuro has quit IRC | 08:07 | |
| *** zenkuro has joined #openstack-nova | 08:09 | |
| *** psachin has joined #openstack-nova | 08:11 | |
| *** zenkuro has quit IRC | 08:14 | |
| *** andrewbonney has joined #openstack-nova | 08:19 | |
| *** tesseract has joined #openstack-nova | 08:20 | |
| *** zenkuro has joined #openstack-nova | 08:21 | |
| *** macz_ has joined #openstack-nova | 08:23 | |
| *** macz_ has quit IRC | 08:27 | |
| *** tesseract has quit IRC | 08:30 | |
| *** tesseract has joined #openstack-nova | 08:32 | |
| *** tosky has joined #openstack-nova | 08:40 | |
| *** rpittau|afk is now known as rpittau | 08:41 | |
| *** zenkuro has quit IRC | 08:48 | |
| *** brinzhang_ has quit IRC | 08:59 | |
| *** brinzhang_ has joined #openstack-nova | 09:00 | |
| *** ociuhandu has joined #openstack-nova | 09:06 | |
| kashyap | lyarwood: Thanks for the rebase! | 09:16 |
| kashyap | lyarwood: (On this one: https://review.opendev.org/c/openstack/nova/+/758763) | 09:17 |
| kashyap | It passed, BTW :-) | 09:19 |
| lyarwood | kashyap: \o morning, np and cool I'll review now, elod ^ you also if you have time, could you review this please? | 09:25 |
| kashyap | Morning | 09:27 |
| *** xek has joined #openstack-nova | 09:28 | |
| *** ociuhandu has quit IRC | 09:28 | |
| kashyap | lyarwood: The tricky thing is that patch is a band-aid for some scenarios -- but will not fix the more difficult CPU-based live migration problems fully. | 09:29 |
| kashyap | lyarwood: I've been thinking enough that I had a CPU model bug walk into my dream last night! | 09:29 |
| lyarwood | haha | 09:29 |
| kashyap | No kidding; I felt strange waking up | 09:29 |
| kashyap | lyarwood: Given the bug OSP upgrades folks found ... for the fuller solution, a potential process trouble: | 09:30 |
| lyarwood | kashyap: so that isn't going to resolve the the noTSX part? | 09:30 |
| *** nightmare_unreal has joined #openstack-nova | 09:30 | |
| kashyap | lyarwood: It should, if your CPU problems are _just_ related to TSX | 09:31 |
| lyarwood | kashyap: ack | 09:31 |
| lyarwood | stephenfin: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f6e/769920/3/check/openstack-tox-py38/f6e5b16/testr_results.html btw, looks like my posion patch found *some* get_arch holes | 09:31 |
| kashyap | lyarwood: The aforementioned "process trouble" is: I'm working w/ chengsheng (don't see them on IRC for a while) here (https://review.opendev.org/c/openstack/nova/+/762330/) to switch to newer CPU APIs | 09:31 |
| stephenfin | lyarwood: oh boy :) | 09:32 |
| kashyap | I've suggested a patch split of 5 pieces for ease of reviewing in my comment on PS12. | 09:32 |
| * stephenfin wonders how | 09:32 | |
| stephenfin | lyarwood: Can you look at this. Should unblock circa 10 RBAC patches https://review.opendev.org/c/openstack/placement/+/771852/ | 09:32 |
| stephenfin | *? | 09:33 |
| lyarwood | stephenfin: ack | 09:33 |
| *** ociuhandu has joined #openstack-nova | 09:33 | |
| kashyap | If chengsheng is busy; I'll split it (and give attribution where due, of course) as per the original spec ... which is not proposed for W -- that's the "too late to get in spec" process part; we uncovered this problem only recently. | 09:34 |
| lyarwood | stephenfin: ah re the stable placement changes, I'm not a placement stable core | 09:34 |
| * kashyap --> coffee | 09:34 | |
| stephenfin | oh, really? | 09:34 |
| stephenfin | that sounds like another situation where we should be merging nova and placement | 09:35 |
| stephenfin | gibi? ^ | 09:35 |
| lyarwood | yeah it's a old list + stable-maint-core | 09:35 |
| lyarwood | which I'm also not a member of | 09:35 |
| gibi | hm | 09:35 |
| gibi | do you suggest to add nova-stable-core to placement-stable-core? | 09:35 |
| lyarwood | kashyap: yeah it's too late for W | 09:35 |
| kashyap | lyarwood: Right, aware of that | 09:36 |
| stephenfin | Yeah, I think that's a reasonable move | 09:36 |
| lyarwood | kashyap: but we can still get it into a good state for X | 09:36 |
| kashyap | Yep | 09:36 |
| lyarwood | gibi: yes I think that would help | 09:36 |
| kashyap | lyarwood: So, what I'm hoping is, if the band-aid backport above will fix most cases, we can get away with solid documentation of the issue. | 09:36 |
| lyarwood | gibi: given we have outstanding .gitreview changes for stable/victoria still | 09:36 |
| kashyap | (Which, I'm writing) | 09:36 |
| lyarwood | kashyap: well downstream at least we could backport that | 09:37 |
| kashyap | lyarwood: Sorry, backport what? The earlier-mentioned train backport? | 09:38 |
| kashyap | If so, yes, of course | 09:38 |
| lyarwood | the feature, it looks pretty self contained in the virt driver | 09:38 |
| lyarwood | tbh you could even sell that as a bugfix in W | 09:38 |
| lyarwood | for me at least | 09:38 |
| lyarwood | if it's replacing broken behaviour | 09:38 |
| *** derekh has joined #openstack-nova | 09:39 | |
| lyarwood | stephenfin: ^ would you agree? | 09:39 |
| lyarwood | stephenfin: context is https://review.opendev.org/c/openstack/nova/+/762330 | 09:39 |
| stephenfin | This is about libvirt using the wrong APIs? | 09:39 |
| lyarwood | stephenfin: switching over to a different libvirt API for checking CPUs | 09:39 |
| lyarwood | yeah | 09:39 |
| stephenfin | Yeah, I thought that was a bug tbh. Is someone saying otherwise? | 09:40 |
| * stephenfin promised to review that but hasn't yet /o\ | 09:40 | |
| lyarwood | it's associated with a blueprint | 09:40 |
| kashyap | lyarwood: Yeah, it could be argued as a bug-fix in good-faith | 09:40 |
| *** psachin has quit IRC | 09:40 | |
| lyarwood | cool, lets drop that reference and proceed as a bugfix | 09:41 |
| kashyap | lyarwood: It is associated with a spec even: https://opendev.org/openstack/nova-specs/commit/70811da221035044e27 | 09:41 |
| kashyap | See the work items for the recommended split of patches | 09:41 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 09:42 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 09:42 |
| lyarwood | MIN_{LIBVIRT,QEMU}_VERSION is beyond the required versions now so I'd say this is even more of a bugfix | 09:42 |
| lyarwood | with some pre-written documentation we can use from the spec ;) | 09:42 |
| kashyap | lyarwood: Yeap, yeap | 09:42 |
| *** psachin has joined #openstack-nova | 09:44 | |
| gibi | lyarwood, stephenfin: sent a mail about placement-stable-maint to ML http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020186.html | 09:44 |
| lyarwood | gibi: many thanks | 09:44 |
| gibi | I will couple of days and then I will make the change | 09:44 |
| *** ociuhandu has quit IRC | 09:45 | |
| lyarwood | ack | 09:45 |
| *** LinPeiWen has quit IRC | 10:00 | |
| elod | lyarwood: kashyap: +2+W'd >>> https://review.opendev.org/c/openstack/nova/+/758763 | 10:02 |
| kashyap | elod: Thanks! | 10:02 |
| *** martinkennelly has joined #openstack-nova | 10:02 | |
| elod | kashyap: np :) | 10:02 |
| *** martinkennelly has quit IRC | 10:02 | |
| *** psachin has quit IRC | 10:04 | |
| *** LinPeiWen has joined #openstack-nova | 10:18 | |
| *** ociuhandu has joined #openstack-nova | 10:19 | |
| *** ociuhandu has quit IRC | 10:24 | |
| *** rcernin has quit IRC | 10:24 | |
| *** k_mouza has joined #openstack-nova | 10:27 | |
| *** k_mouza has quit IRC | 10:31 | |
| *** ociuhandu has joined #openstack-nova | 10:36 | |
| *** ociuhandu has quit IRC | 10:41 | |
| *** ociuhandu has joined #openstack-nova | 10:42 | |
| *** dtantsur|afk is now known as dtantsur | 10:49 | |
| *** k_mouza has joined #openstack-nova | 10:52 | |
| *** rcernin has joined #openstack-nova | 10:55 | |
| *** LinPeiWen has quit IRC | 11:02 | |
| *** ratailor has quit IRC | 11:09 | |
| *** ratailor has joined #openstack-nova | 11:09 | |
| *** xinranwang has quit IRC | 11:13 | |
| *** dviroel has joined #openstack-nova | 11:15 | |
| *** rcernin has quit IRC | 11:15 | |
| *** ociuhandu has quit IRC | 11:27 | |
| *** jangutter_ has joined #openstack-nova | 11:32 | |
| *** jangutter has quit IRC | 11:36 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge duplicate volume attachment checks https://review.opendev.org/c/openstack/nova/+/773380 | 11:36 |
| *** LinPeiWen has joined #openstack-nova | 11:38 | |
| *** sapd1 has quit IRC | 11:49 | |
| *** tbachman has quit IRC | 11:52 | |
| *** tbachman has joined #openstack-nova | 11:53 | |
| *** martinkennelly has joined #openstack-nova | 11:58 | |
| *** ociuhandu has joined #openstack-nova | 11:59 | |
| *** martinkennelly has quit IRC | 11:59 | |
| *** martinkennelly has joined #openstack-nova | 12:00 | |
| *** rcernin has joined #openstack-nova | 12:01 | |
| *** jangutter has joined #openstack-nova | 12:05 | |
| *** jangutter_ has quit IRC | 12:08 | |
| *** ociuhandu_ has joined #openstack-nova | 12:12 | |
| *** ociuhandu has quit IRC | 12:15 | |
| *** macz_ has joined #openstack-nova | 12:20 | |
| *** macz_ has quit IRC | 12:24 | |
| *** sapd1 has joined #openstack-nova | 12:33 | |
| *** rcernin has quit IRC | 12:43 | |
| *** ociuhandu_ has quit IRC | 12:46 | |
| *** ociuhandu has joined #openstack-nova | 12:47 | |
| *** hemanth_n has quit IRC | 13:00 | |
| *** martinkennelly has quit IRC | 13:01 | |
| *** sapd1 has quit IRC | 13:10 | |
| *** ociuhandu has quit IRC | 13:10 | |
| *** ociuhandu has joined #openstack-nova | 13:11 | |
| *** ratailor has quit IRC | 13:14 | |
| *** sapd1 has joined #openstack-nova | 13:22 | |
| sean-k-mooney | V comes after U ... | 13:45 |
| sean-k-mooney | meaning i need to backport to Victoria then Ussuri | 13:46 |
| *** zul has joined #openstack-nova | 13:50 | |
| openstackgerrit | sean mooney proposed openstack/nova stable/victoria: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/770744 | 13:51 |
| *** whoami-rajat__ has joined #openstack-nova | 13:55 | |
| sean-k-mooney | lyarwood: can you take a look at ^ again | 13:56 |
| sean-k-mooney | now that its in the correct order | 13:56 |
| *** lbragstad has quit IRC | 13:57 | |
| bauzas | sean-k-mooney: fwiw, I'm splitting my -W change for routed networks | 14:01 |
| bauzas | the functests are saying OK so we know it works | 14:01 |
| bauzas | (for all the move operations) | 14:01 |
| sean-k-mooney | ok | 14:02 |
| sean-k-mooney | i assume your going to either move teh func tests or the unit tests to a second patch? | 14:03 |
| sean-k-mooney | for this type of change i trust the func tests more so would prefer those to stay with the code but ill leave that up to you | 14:03 |
| sean-k-mooney | we will be reviewing the serise as a whole anyway | 14:03 |
| bauzas | no, I'll have the functests in the same change for the filter | 14:07 |
| bauzas | but I'll move the renaming of ensure_network_metadata() in a dependent change | 14:08 |
| *** ociuhandu has quit IRC | 14:08 | |
| *** ociuhandu has joined #openstack-nova | 14:09 | |
| sean-k-mooney | cool | 14:10 |
| *** brinzhang_ has quit IRC | 14:17 | |
| *** brinzhang_ has joined #openstack-nova | 14:17 | |
| *** ociuhandu has quit IRC | 14:27 | |
| *** ociuhandu has joined #openstack-nova | 14:28 | |
| *** ociuhandu has quit IRC | 14:32 | |
| *** zoharm has joined #openstack-nova | 14:33 | |
| *** brinzhang_ has quit IRC | 14:35 | |
| *** lbragstad has joined #openstack-nova | 14:35 | |
| *** brinzhang_ has joined #openstack-nova | 14:36 | |
| *** alex_xu has joined #openstack-nova | 14:39 | |
| gibi | fyi cores, I'm +2 on the vnc password patch https://review.opendev.org/c/openstack/nova/+/622336/ but it needs a second set of eyes | 14:48 |
| sean-k-mooney | hum that touches a bunch of files but most are small changes it seams | 14:56 |
| sean-k-mooney | im not a core but ill take a look at it | 14:57 |
| gibi | sean-k-mooney: cool, thanks | 14:57 |
| sean-k-mooney | it dose not look that difficult to reiew | 14:57 |
| *** ociuhandu has joined #openstack-nova | 15:06 | |
| *** k_mouza has quit IRC | 15:14 | |
| *** ociuhandu has quit IRC | 15:15 | |
| *** ociuhandu has joined #openstack-nova | 15:18 | |
| *** khomesh24 has quit IRC | 15:23 | |
| *** khomesh24 has joined #openstack-nova | 15:23 | |
| *** sapd1 has quit IRC | 15:26 | |
| sean-k-mooney | gibi: -1 because i have a question on allowing console without a password to be created when the nova config has [vnc]/auth_schemes = none,vnc,vencrypt | 15:31 |
| gibi | sean-k-mooney: thanks | 15:32 |
| sean-k-mooney | gibi: but other then that the code looks ok | 15:32 |
| sean-k-mooney | my comments are on the patch but while i woudl prefer not to save the pasword in plain text in novas db it is out of scope to use barbican so i view that as a future imporvment not a requirement for the feature | 15:33 |
| *** links has quit IRC | 15:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/773930 | 15:41 |
| openstack | bug 1907522 in OpenStack Compute (nova) victoria "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [Medium,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer) | 15:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/773932 | 15:42 |
| *** dklyle has joined #openstack-nova | 15:51 | |
| *** k_mouza has joined #openstack-nova | 15:52 | |
| *** dklyle has quit IRC | 15:53 | |
| *** david-lyle has joined #openstack-nova | 15:53 | |
| *** ociuhandu_ has joined #openstack-nova | 16:00 | |
| *** sapd1 has joined #openstack-nova | 16:03 | |
| *** ociuhandu has quit IRC | 16:03 | |
| melwitt | kashyap: took me awhile (sorry) but here's the qemu bug I opened about the block copy taking a long time to end the job after the last block is done https://bugs.launchpad.net/qemu/+bug/1914282 | 16:08 |
| openstack | Launchpad bug 1914282 in QEMU "block copy job sometimes hangs on the last block for minutes" [Undecided,New] | 16:08 |
| kashyap | melwitt: Hello | 16:08 |
| melwitt | hello | 16:08 |
| kashyap | melwitt: Thanks for filing; no need for sorry :-) | 16:09 |
| kashyap | melwitt: Nice write-up | 16:09 |
| kashyap | melwitt: One small comment; do you want to attach the pastebin content as a text file to the bug? | 16:09 |
| kashyap | As pastebins expire | 16:09 |
| melwitt | kashyap: oh, yeah, I will do that | 16:10 |
| kashyap | melwitt: Also, the bug will show up on the main 'qemu-devel' list; so the Block Layer devs should notice it | 16:10 |
| melwitt | I thought pastebin wasn't expiration by default but it's a good idea to attach it even so | 16:10 |
| kashyap | If we don't hear a response in a week, I'll get Eric Blake to have a gander; he knows this inside out, as someone who's worked on QEMU and libvirt | 16:10 |
| *** LinPeiWen has quit IRC | 16:11 | |
| melwitt | ok great | 16:11 |
| *** macz_ has joined #openstack-nova | 16:12 | |
| kashyap | melwitt: Is this affecting the Gate quite often? | 16:13 |
| melwitt | kashyap: I think no but I don't know for sure bc I haven't figured out a unique fingerprint to logstash for it | 16:14 |
| * kashyap taps on the table and thinks | 16:14 | |
| melwitt | lyarwood: I opened this bug yesterday based on a gate failure I saw and was curious if you've ever seen this before? https://bugs.launchpad.net/nova/+bug/1914296 | 16:25 |
| openstack | Launchpad bug 1914296 in OpenStack Compute (nova) "tests involving encrypted volumes sometimes (rarely) fail with libvirtError: [...] Volume is not in LUKS format" [Undecided,New] | 16:25 |
| kashyap | melwitt: Hmm, so I can't see a unique signature either ... as most of the messages are "usual", but they're on loop | 16:26 |
| kashyap | Unless I'm missing something badly, looks like it's tricky to check for its frequency | 16:26 |
| melwitt | kashyap: yeah exactly. the only place where I think we have a chance is in the job-output.txt but IIRC that text is also quite generic | 16:26 |
| melwitt | I will take another look to see if anything jumps out | 16:26 |
| kashyap | melwitt: Thank you. I hope this won't come back to bite us - as we can't (yet) see how often we're hitting it | 16:27 |
| lyarwood | melwitt: can't say I have, *clicks* | 16:28 |
| lyarwood | melwitt: if it's a block device n-cpu should format it with LUKS before using it | 16:29 |
| melwitt | lyarwood: it seems weird bc the error message says both format=luks and then "Volume not in LUKS format", like how is that possible? | 16:30 |
| *** ociuhandu_ has quit IRC | 16:30 | |
| lyarwood | melwitt: urgh that chrome tab just died, I'll pull down the log after the call if that's okay | 16:31 |
| * lyarwood has 64GB of RAM and still chrome tabs die | 16:31 | |
| melwitt | sure np, just wanted to link you before I forgot | 16:31 |
| melwitt | it's not urgent | 16:31 |
| *** mjturek has joined #openstack-nova | 16:32 | |
| *** mlavalle has joined #openstack-nova | 16:34 | |
| *** ociuhandu has joined #openstack-nova | 16:38 | |
| *** spatel has joined #openstack-nova | 16:39 | |
| *** sapd1 has quit IRC | 16:50 | |
| *** zoharm has quit IRC | 16:52 | |
| kashyap | melwitt: I have attached the QEMU <-> libvirt exchange from the dest-host in the bug. | 17:13 |
| *** spatel has quit IRC | 17:14 | |
| melwitt | kashyap: thanks! | 17:14 |
| kashyap | NP. Thx, you too | 17:15 |
| *** spatel has joined #openstack-nova | 17:16 | |
| *** ralonsoh has quit IRC | 17:31 | |
| *** ociuhandu_ has joined #openstack-nova | 17:34 | |
| *** khomesh24 has quit IRC | 17:34 | |
| *** k_mouza has quit IRC | 17:35 | |
| *** ociuhandu has quit IRC | 17:37 | |
| *** ociuhandu_ has quit IRC | 17:38 | |
| *** david-lyle is now known as dklyle | 17:39 | |
| *** k_mouza has joined #openstack-nova | 17:41 | |
| sean-k-mooney | lyarwood: can you reveiw https://review.opendev.org/c/openstack/nova/+/622336/29/nova/api/openstack/compute/remote_consoles.py#183 and confirm if you expect that to have teh same effect as the issue we discussed downstream | 17:44 |
| sean-k-mooney | we do not want the password to end up in the image data or in config_dirver/metadata api | 17:45 |
| sean-k-mooney | but here it may end up in both correct | 17:45 |
| melwitt | sean-k-mooney: hm, I'd have thought that should be stored encrypted, same as we do for admin password | 17:49 |
| sean-k-mooney | melwitt: ya i mentioned that | 17:49 |
| sean-k-mooney | although i dont think it can be | 17:50 |
| sean-k-mooney | the admin password is not in the libvirt xml | 17:50 |
| sean-k-mooney | we use the ssh public key to encypt it yes | 17:50 |
| melwitt | yes | 17:50 |
| sean-k-mooney | in this case we wont have the private key to decyprti it ot stick it in the libvirt xml | 17:50 |
| melwitt | oh :\ | 17:50 |
| sean-k-mooney | so we can use the ssh public key here | 17:50 |
| sean-k-mooney | but we coudl use soemthign else | 17:51 |
| sean-k-mooney | e.g. a keystore | 17:51 |
| sean-k-mooney | or static encyption with a fixed key seeded with the ssk public key or somehtihng | 17:51 |
| *** k_mouza has quit IRC | 17:52 | |
| melwitt | yeah.. I guess I'm slowly remembering this spec, and this aspect of it is "better than nothing" I guess (comparing with no novnc password at all) | 17:52 |
| sean-k-mooney | is fixed key enabled by default | 17:52 |
| sean-k-mooney | because if it is using castalain with fixed key to store it would be better | 17:53 |
| sean-k-mooney | as that would allowy you to plug in barbican to do it proably too | 17:53 |
| sean-k-mooney | that said as long as we call this out | 17:53 |
| sean-k-mooney | and ensure we dont make the password visable in ways we did not intend | 17:53 |
| sean-k-mooney | then i think its ok to improve it later | 17:53 |
| melwitt | I dunno if it is enabled by default. I don't know how to tell | 17:53 |
| sean-k-mooney | the nova keysotre cofnig? thats a thing i think | 17:54 |
| prometheanfire | any progress on updating mock (nova still holds back the 3.0.5 -> 4.0.3 update)? | 17:54 |
| sean-k-mooney | prometheanfire: we were tryihng to stop using it entirly at one point | 17:54 |
| melwitt | yeah there's a fixed_key conf option but it doesn't have a default value, so that means it's not enabled by default? | 17:54 |
| melwitt | prometheanfire: I have a change to the one test that is failing that I need to upload | 17:55 |
| prometheanfire | sean-k-mooney: iirc it was given up on at some point (using the built in) | 17:55 |
| prometheanfire | melwitt: kk, feel free to add me to the review (or ping me) :D | 17:56 |
| sean-k-mooney | prometheanfire: i am not aware of a reason not tooo | 17:56 |
| sean-k-mooney | prometheanfire: i suspect if it was it was just capasity | 17:56 |
| melwitt | will do prometheanfire | 17:56 |
| *** ociuhandu has joined #openstack-nova | 17:56 | |
| sean-k-mooney | melwitt: ya not sure the https://docs.openstack.org/nova/latest/configuration/config.html#key-manager config is what i was thinking | 17:56 |
| sean-k-mooney | i was hoptin we had a default fixed key version that was always there if you dont use a real one | 17:57 |
| prometheanfire | sean-k-mooney: well, using the built-in is always preferred | 17:57 |
| melwitt | sean-k-mooney: oh I see | 17:58 |
| sean-k-mooney | prometheanfire: yep we only used mock the lib for python 2 compatiablity | 17:58 |
| sean-k-mooney | melwitt: anyway i dont think we have a basic intree keymanager that implemnt the castalin api that we can just assume is a thing | 17:58 |
| sean-k-mooney | melwitt: well we have https://github.com/openstack/nova/blob/master/nova/keymgr/conf_key_mgr.py | 17:59 |
| lyarwood | sean-k-mooney: sorry was afk, instance.metadata != instance.system_metadata so I'm not sure if it's going to have any impact | 18:00 |
| sean-k-mooney | lyarwood: right but instace.metadata is the place we store metata we set with --property | 18:00 |
| sean-k-mooney | and i though that was put in the the instace_system_metatadata table | 18:01 |
| *** ociuhandu has quit IRC | 18:01 | |
| sean-k-mooney | although it could be in instance_extra | 18:01 |
| lyarwood | sean-k-mooney: the system_metadata issue I was talking about downstream comes from https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py | 18:01 |
| melwitt | isn't instance.metadata public? | 18:01 |
| sean-k-mooney | melwitt: yes | 18:01 |
| sean-k-mooney | with a nova show | 18:01 |
| sean-k-mooney | i think | 18:01 |
| lyarwood | ops that didnt link correctly | 18:01 |
| melwitt | so the novnc password shouldn't be put in there, right? | 18:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object https://review.opendev.org/c/openstack/nova/+/749977 | 18:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 18:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Rename ensure_network_metadata to amend requested_networks https://review.opendev.org/c/openstack/nova/+/773955 | 18:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add network and utils methods for getting routed networks and segments https://review.opendev.org/c/openstack/nova/+/773976 | 18:01 |
| sean-k-mooney | melwitt: correct | 18:02 |
| lyarwood | https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py#L752-L778 was what I wanted to link to | 18:02 |
| sean-k-mooney | if its there i belive it will be avaiable via the metadata service | 18:02 |
| melwitt | if it goes in system_metadata I guess that's ok, IIUC | 18:02 |
| sean-k-mooney | allowing anyone in the project ot get it | 18:02 |
| melwitt | but not metadata, that will be public to all in the project like you said | 18:02 |
| *** derekh has quit IRC | 18:02 | |
| lyarwood | melwitt: so the issue then is it would show up as an image metadata property | 18:02 |
| sean-k-mooney | yep and the feature is ment to make it so only the user that created the instace can log in | 18:03 |
| sean-k-mooney | via vnc with the password they set | 18:03 |
| melwitt | oh system_meta gets reflected out of metadata? oh, I didn't know that :\ | 18:03 |
| lyarwood | neither did I until a few hours ago | 18:03 |
| sean-k-mooney | or i | 18:03 |
| lyarwood | slightly weird behaviour tbh, I can't think why | 18:03 |
| melwitt | hrm | 18:03 |
| sean-k-mooney | i though it was only stuff with the image_ prefix or img_ | 18:03 |
| sean-k-mooney | not everything becase we store stuff for tpm there too | 18:04 |
| melwitt | yeah I had thought system_meta was like internal system info that wasn't put out there | 18:04 |
| melwitt | ok so you're saying a subset of it is reflected out | 18:04 |
| sean-k-mooney | no i thouhg only a subset shoudl be relected out via the image | 18:04 |
| lyarwood | my reading of https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py#L752-L778 and what I've seen when stashing hw_machine_type in there is that it ends up being reflected in the image metadata properties | 18:05 |
| sean-k-mooney | but lyarwood seams to have found all of it might be in a specific case? | 18:05 |
| melwitt | oh | 18:05 |
| sean-k-mooney | so SM_IMAGE_PROP_PREFIX | 18:05 |
| sean-k-mooney | was ment to be filtering to just the image ones right | 18:05 |
| lyarwood | you would assume so | 18:06 |
| sean-k-mooney | so key = key[len(SM_IMAGE_PROP_PREFIX):] | 18:07 |
| sean-k-mooney | is striping the key | 18:07 |
| sean-k-mooney | i think that is the issue | 18:07 |
| sean-k-mooney | because you have img_hw_machine_type that matches hw_machine_type which you added | 18:08 |
| lyarwood | so in my case I've not even set it in the image metadata | 18:08 |
| lyarwood | I'm only updating it in system_metadata while n-cpu starts | 18:08 |
| lyarwood | and spawns | 18:08 |
| lyarwood | and it's still showing up as an image prop | 18:08 |
| lyarwood | let me write a func test to show this | 18:08 |
| *** rpittau is now known as rpittau|afk | 18:08 | |
| sean-k-mooney | can you include your new key with a prfix too | 18:10 |
| sean-k-mooney | e.g. abi_hw_machine_type | 18:10 |
| sean-k-mooney | i think adding an abi prefix or simialr would stopp it being included | 18:10 |
| lyarwood | it wouldn't, that's just trimming off SM_IMAGE_PROP_PREFIX from any matching keys | 18:10 |
| lyarwood | L771-774 will still include it | 18:11 |
| sean-k-mooney | oh i see | 18:12 |
| sean-k-mooney | we shoudl be looping over the known filed in the image metadata object | 18:12 |
| lyarwood | brb | 18:12 |
| sean-k-mooney | not everything in the dict | 18:12 |
| sean-k-mooney | so for key, value in system_meta.items(): is wrong | 18:12 |
| sean-k-mooney | well that woudl work but we need to check " if key not in imageMeta.fields(): continue | 18:13 |
| sean-k-mooney | or similar | 18:13 |
| *** dtantsur is now known as dtantsur|afk | 18:16 | |
| *** nightmare_unreal has quit IRC | 18:26 | |
| openstackgerrit | Merged openstack/placement master: policy: Suppress policy deprecation warnings https://review.opendev.org/c/openstack/placement/+/771852 | 18:36 |
| openstackgerrit | Merged openstack/placement master: policy: Don't persist default rule changes in tests https://review.opendev.org/c/openstack/placement/+/772508 | 18:36 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 18:38 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 18:38 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 18:39 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 18:44 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 18:48 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 18:48 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 18:49 |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 18:49 |
| openstackgerrit | Merged openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333 | 18:50 |
| *** k_mouza has joined #openstack-nova | 19:15 | |
| *** andrewbonney has quit IRC | 19:17 | |
| *** k_mouza has quit IRC | 19:19 | |
| *** k_mouza has joined #openstack-nova | 19:35 | |
| *** k_mouza has quit IRC | 19:40 | |
| *** rcernin has joined #openstack-nova | 19:49 | |
| openstackgerrit | Merged openstack/nova stable/ussuri: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761810 | 19:50 |
| openstackgerrit | Merged openstack/nova stable/victoria: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/758837 | 19:56 |
| *** ociuhandu has joined #openstack-nova | 20:04 | |
| *** rcernin has quit IRC | 20:20 | |
| *** rcernin has joined #openstack-nova | 20:20 | |
| melwitt | ci passed on 3 patches of mine in a row | 20:23 |
| * melwitt faints | 20:23 | |
| sean-k-mooney | lol | 20:26 |
| *** tesseract has quit IRC | 20:49 | |
| *** rcernin has quit IRC | 21:22 | |
| *** hamalq has joined #openstack-nova | 21:27 | |
| *** whoami-rajat__ has quit IRC | 21:34 | |
| *** ociuhandu has quit IRC | 21:36 | |
| *** k_mouza has joined #openstack-nova | 21:44 | |
| *** k_mouza has quit IRC | 21:48 | |
| *** xek has quit IRC | 22:03 | |
| *** rcernin has joined #openstack-nova | 22:05 | |
| *** rcernin has quit IRC | 22:06 | |
| *** rcernin has joined #openstack-nova | 22:07 | |
| *** openstackgerrit has quit IRC | 22:11 | |
| *** vishalmanchanda has quit IRC | 22:30 | |
| *** slaweq has quit IRC | 22:41 | |
| *** slaweq has joined #openstack-nova | 22:43 | |
| *** rcernin has quit IRC | 22:45 | |
| *** slaweq has quit IRC | 22:47 | |
| *** openstackgerrit has joined #openstack-nova | 22:52 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351 | 22:52 |
| openstackgerrit | melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351 | 22:54 |
| openstackgerrit | Merged openstack/nova stable/train: Handle disabled CPU features to fix live migration failures https://review.opendev.org/c/openstack/nova/+/758763 | 22:58 |
| *** spatel has quit IRC | 23:06 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi https://review.opendev.org/c/openstack/nova/+/741351 | 23:18 |
| melwitt | prometheanfire: this should hopefully work ^ you're already cc'd on the review but in case you miss the gerrit notification | 23:19 |
| openstackgerrit | Ghanshyam proposed openstack/placement master: DNM: testing direct l-c https://review.opendev.org/c/openstack/placement/+/773813 | 23:20 |
| *** bbowen_ has quit IRC | 23:24 | |
| *** tosky has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!