Friday, 2021-01-15

*** ociuhandu has joined #openstack-nova00:01
*** macz_ has quit IRC00:02
*** rcernin has quit IRC00:03
*** gyee has quit IRC00:03
*** dklyle has quit IRC00:03
*** artom has quit IRC00:03
*** tbachman has quit IRC00:03
*** alex_xu has quit IRC00:03
*** lemko has quit IRC00:03
*** yoctozepto has quit IRC00:03
*** hack-char has quit IRC00:03
*** benj_ has quit IRC00:03
*** bbowen has quit IRC00:03
*** openstackgerrit has quit IRC00:03
*** elod has quit IRC00:03
*** irclogbot_0 has quit IRC00:03
*** antonym has quit IRC00:03
*** spotz has quit IRC00:03
*** arne_wiebalck has quit IRC00:03
*** hamalq has quit IRC00:03
*** jmlowe has quit IRC00:03
*** tkajinam has quit IRC00:03
*** dviroel has quit IRC00:03
*** jkulik has quit IRC00:03
*** StevenK has quit IRC00:03
*** guilhermesp has quit IRC00:03
*** rm_work has quit IRC00:03
*** fyx has quit IRC00:03
*** donnyd has quit IRC00:03
*** cz3 has quit IRC00:03
*** andrewbogott has quit IRC00:03
*** coreycb has quit IRC00:03
*** gmann has quit IRC00:03
*** melwitt has quit IRC00:03
*** ttx has quit IRC00:03
*** hamalq has joined #openstack-nova00:05
*** andrewbogott has joined #openstack-nova00:05
*** jmlowe has joined #openstack-nova00:05
*** tkajinam has joined #openstack-nova00:05
*** dviroel has joined #openstack-nova00:05
*** jkulik has joined #openstack-nova00:05
*** StevenK has joined #openstack-nova00:05
*** guilhermesp has joined #openstack-nova00:05
*** rm_work has joined #openstack-nova00:05
*** fyx has joined #openstack-nova00:05
*** donnyd has joined #openstack-nova00:05
*** cz3 has joined #openstack-nova00:05
*** coreycb has joined #openstack-nova00:05
*** gmann has joined #openstack-nova00:05
*** melwitt has joined #openstack-nova00:05
*** ttx has joined #openstack-nova00:05
*** rcernin has joined #openstack-nova00:06
*** gyee has joined #openstack-nova00:06
*** dklyle has joined #openstack-nova00:06
*** artom has joined #openstack-nova00:06
*** bbowen has joined #openstack-nova00:06
*** alex_xu has joined #openstack-nova00:06
*** tbachman has joined #openstack-nova00:06
*** lemko has joined #openstack-nova00:06
*** elod has joined #openstack-nova00:06
*** spotz has joined #openstack-nova00:06
*** yoctozepto has joined #openstack-nova00:06
*** irclogbot_0 has joined #openstack-nova00:06
*** antonym has joined #openstack-nova00:06
*** arne_wiebalck has joined #openstack-nova00:06
*** benj_ has joined #openstack-nova00:06
*** ociuhandu has quit IRC00:07
*** masterpe has quit IRC00:07
*** cz3 has quit IRC00:07
*** artom has quit IRC00:07
*** tosky has quit IRC00:07
*** alex_xu has quit IRC00:08
*** artom has joined #openstack-nova00:08
*** hack-char has joined #openstack-nova00:08
*** bbowen_ has joined #openstack-nova00:09
*** guilhermesp has quit IRC00:09
*** fyx has quit IRC00:09
*** donnyd has quit IRC00:09
*** andrewbogott has quit IRC00:09
*** coreycb has quit IRC00:09
*** gmann has quit IRC00:09
*** bbowen has quit IRC00:10
*** andrewbogott has joined #openstack-nova00:10
*** donnyd has joined #openstack-nova00:10
*** coreycb has joined #openstack-nova00:10
*** gmann has joined #openstack-nova00:10
*** irclogbot_0 has quit IRC00:10
*** guilhermesp has joined #openstack-nova00:11
*** fyx has joined #openstack-nova00:11
*** cz3 has joined #openstack-nova00:11
*** irclogbot_3 has joined #openstack-nova00:12
*** spatel has joined #openstack-nova00:12
*** artom has quit IRC00:15
*** spatel has quit IRC00:17
*** hamalq has quit IRC00:40
*** mlavalle has quit IRC00:42
*** masterpe has joined #openstack-nova00:43
*** zenkuro has quit IRC00:44
*** masterpe has quit IRC00:52
*** masterpe has joined #openstack-nova01:01
*** songwenping_ has quit IRC01:50
*** spatel has joined #openstack-nova02:17
*** sapd1 has joined #openstack-nova02:28
*** brinzhang_ has joined #openstack-nova02:31
*** brinzhang0 has quit IRC02:34
*** ociuhandu has joined #openstack-nova02:43
*** ociuhandu has quit IRC02:47
*** sapd1 has quit IRC02:50
*** brinzhang_ has quit IRC03:00
*** brinzhang_ has joined #openstack-nova03:00
*** sapd1 has joined #openstack-nova03:06
*** rcernin has quit IRC03:11
*** rcernin has joined #openstack-nova03:12
*** openstackgerrit has joined #openstack-nova03:29
openstackgerritBrin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support  https://review.opendev.org/c/openstack/nova/+/72956303:29
*** bbowen has joined #openstack-nova03:29
*** bbowen_ has quit IRC03:30
*** mkrai has joined #openstack-nova03:33
*** psachin has joined #openstack-nova03:36
*** gyee has quit IRC04:12
*** dave-mccowan has quit IRC04:40
*** ratailor has joined #openstack-nova05:28
*** brinzhang0 has joined #openstack-nova05:36
*** brinzhang0 has quit IRC05:37
*** brinzhang0 has joined #openstack-nova05:37
*** brinzhang_ has quit IRC05:38
*** psachin has quit IRC05:40
*** psachin has joined #openstack-nova06:22
*** spatel has quit IRC07:03
*** rcernin has quit IRC07:05
*** rcernin has joined #openstack-nova07:43
*** rcernin has quit IRC07:48
*** rcernin has joined #openstack-nova07:49
*** rcernin has quit IRC07:54
*** dklyle has quit IRC07:55
*** ralonsoh has joined #openstack-nova07:55
gibidansmith: thanks for finding out reasone of the multistore failure an proposing a fix. nice catch!08:04
*** rpittau|afk is now known as rpittau08:09
*** andrewbonney has joined #openstack-nova08:12
lyarwoodmorning08:17
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION  https://review.opendev.org/c/openstack/nova/+/75470008:18
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_BLOCKDEV  https://review.opendev.org/c/openstack/nova/+/75470108:18
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_S390X_CPU_COMPARE  https://review.opendev.org/c/openstack/nova/+/75470408:18
*** tesseract has joined #openstack-nova08:21
*** xek has joined #openstack-nova08:25
*** rcernin has joined #openstack-nova08:26
*** rcernin has quit IRC08:31
*** tosky has joined #openstack-nova08:42
*** lpetrut has joined #openstack-nova08:50
*** swp20 has joined #openstack-nova08:59
*** swp20 has quit IRC09:00
*** swp20 has joined #openstack-nova09:02
*** songwenping_ has joined #openstack-nova09:11
openstackgerritwushiming proposed openstack/os-vif master: Drop lower-constraints job  https://review.opendev.org/c/openstack/os-vif/+/77090709:11
*** swp20 has quit IRC09:14
*** spatel has joined #openstack-nova09:16
*** nightmare_unreal has joined #openstack-nova09:17
nightmare_unrealHello , is there a way to force a VM to boot from volume. For e.g. during VM creation i want to enforce that it should be from volume only09:17
kashyaplyarwood: Morning; for the NEXT_ version bump, we also traditionally give a heads-up on the openstack-discuss list -- wanna do that too?  (E.g. one of my past emails: http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010907.html)09:19
*** spatel has quit IRC09:21
openstackgerritwushiming proposed openstack/python-novaclient master: Drop lower-constraints job  https://review.opendev.org/c/openstack/python-novaclient/+/77091209:22
lyarwoodkashyap: yup can do09:24
kashyapThank ya.09:25
*** rcernin has joined #openstack-nova09:28
*** ociuhandu has joined #openstack-nova09:33
*** rcernin has quit IRC09:33
songwenping_sean-k-mooney: Hi, what do you means about the vgpu spec: https://review.opendev.org/c/openstack/nova-specs/+/750116/17#L97, should we use rpc.cast the cyborg-agent to create a new mdev?09:35
*** derekh has joined #openstack-nova09:37
lyarwoodkashyap: sent09:37
kashyaplyarwood: Just read the mail in the archives; looks fine, thx.09:39
lyarwoodcool thanks09:41
*** ociuhandu has quit IRC09:44
*** mkrai has quit IRC09:50
*** mkrai_ has joined #openstack-nova09:50
*** ociuhandu has joined #openstack-nova09:50
*** sapd1 has quit IRC10:04
*** macz_ has joined #openstack-nova10:07
*** macz_ has quit IRC10:12
*** mkrai_ has quit IRC10:18
*** mkrai has joined #openstack-nova10:19
songwenping_gibi: hi, about your comment in line https://review.opendev.org/c/openstack/nova/+/622336/20/nova/api/openstack/compute/remote_consoles.py#186, `if svc.version < <the new service version>` shoudld we raise 400 or 404?10:20
brinzhang0gibi: cyborg shelve/unshelve updated alex_xu's concern, pls re-check again, thanks https://review.opendev.org/c/openstack/nova/+/72956310:21
gibisongwenping_: I would go with http 40010:21
gibibrinzhang0: ack10:21
songwenping_gibi: get10:22
brinzhang0gibi: yes, the same as songwenping_'s concern , IMO 400 is more suitable10:23
brinzhang0gibi: thanks for check the cyborg shelve/unshelve patch ^^10:24
*** dtantsur|afk is now known as dtantsur10:38
*** rcernin has joined #openstack-nova10:45
*** Oriz|2 has joined #openstack-nova10:46
*** ociuhandu has quit IRC10:46
*** sanderp has quit IRC10:55
*** psachin has quit IRC10:58
*** songwenping__ has joined #openstack-nova11:12
*** songwenping_ has quit IRC11:15
*** ociuhandu has joined #openstack-nova11:17
*** rcernin has quit IRC11:17
*** ociuhandu has quit IRC11:26
*** ociuhandu has joined #openstack-nova11:27
openstackgerritLee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action  https://review.opendev.org/c/openstack/nova/+/77092611:29
*** rcernin has joined #openstack-nova11:30
*** martinkennelly has joined #openstack-nova11:33
*** mkrai has quit IRC11:37
gibibauzas: are your concerns answered in https://review.opendev.org/c/openstack/nova/+/729563 ? I'm holding the +W until ack it11:43
*** jangutter_ has joined #openstack-nova11:48
*** jangutter has quit IRC11:51
*** jangutter has joined #openstack-nova11:55
*** jangutter_ has quit IRC11:57
*** macz_ has joined #openstack-nova11:58
*** raildo has joined #openstack-nova12:00
*** macz_ has quit IRC12:03
*** jamesdenton has quit IRC12:07
*** jamesdenton has joined #openstack-nova12:07
*** mgariepy has quit IRC12:14
*** artom has joined #openstack-nova12:16
*** spatel has joined #openstack-nova12:17
*** spatel has quit IRC12:21
*** rcernin has quit IRC12:31
*** brinzhang_ has joined #openstack-nova12:32
sean-k-mooneysongwenping__: i was suggesting that gets shoudl not create teh mdev ever. the cyborg agent should create the mdevs for all bound arqs on start up. ideally it would set the binding state to "provisioning" on start up also and we would have anohter state "unknown" that the api would report if the cyborg agent misses its heart beat12:36
*** brinzhang0 has quit IRC12:36
sean-k-mooneysongwenping__: so on start up nova would see 1 of 3 states, bound if the cyborg agent started first and hadn completed bininding, unknown if the cyborg agent has not heartbeat to the cyborg conductor yet12:37
sean-k-mooneyor provisioning if the agent is in the process of creating the mdev12:37
sean-k-mooneyif cyborg was to send the same bining complete event when it change teh status form provisioning to bound as it does during normal arq binding12:38
sean-k-mooneythe process in nova awould be the same12:38
sean-k-mooneye.g. set up event handeler, check if its already bound if not wait for binding complete event, if it si bound cancel the even waiter and proceed with boot12:39
*** ratailor has quit IRC12:40
sean-k-mooneygibi: bauzas  does that sound like a resonable approch to ye instead of have get arq sometimes do an rpc call to the cybrog agent to create mdevs12:40
bauzasgibi: will look at https://review.opendev.org/c/openstack/nova/+/72956312:41
gibibauzas: thanks12:42
bauzasand for the vGPU support in Cyborg, I'll also look at the new revision today12:42
gibisean-k-mooney: do we have this event handling at nova compute startup for neutron ports too?12:43
*** whoami-rajat__ has joined #openstack-nova12:43
sean-k-mooneygibi: we do not need to rebinding them in the neutron case just replug them.12:44
sean-k-mooneyin the neutorn case os-vif is the thing that attaches the ports to the network backend in general12:45
*** rcernin has joined #openstack-nova12:45
sean-k-mooneywhich si the equivalent of creating the mdev12:45
gibisean-k-mooney: I see12:45
sean-k-mooneyi just find it unsetaling that we would considre change a get form a simple db lookup into an rpc call12:47
gibisean-k-mooney: so at compute startup nova gets the binding state from cyborg, if it is unknow or provisioning then keep the guest power state off but set up an event waiter. If the arq state is "OK" then nova would start the guest during compute startup.12:48
sean-k-mooneygibi: not quite12:48
gibicorrect me please12:48
sean-k-mooneyi was thinking we would always set up the waiter and early out if it was bound like we do for normal spwan12:49
gibican nova we loose an event during the compute reboot?12:50
gibiif yes then that guest would be stuck waiting of the event that was sent by cyborg but lost in the comptue restart12:50
gibiif the event is never lost then I'm OK to wait for the event12:51
sean-k-mooneythe event would hit the api and then be enqued to the compute node topic queue12:51
sean-k-mooneyso i dont think it would be lost12:51
gibisean-k-mooney: cool12:51
gibithat seem OK12:51
gibihm12:51
gibiso in this case the sending the event is triggered by cyborg agent restart, in any other case sending the event is triggered by a nova bind request12:52
sean-k-mooneyyes12:52
gibiso there are extra cases to handle. 1) a single cyborg agent restart will send events and if the compute service was not restarted then these events needs to be consumed but ignored12:53
sean-k-mooneywe could just call bind if we wanted too and not require teh cyborg agent to auto create them but i think the auto create would be more efficent12:53
sean-k-mooneygibi: we have unexpeted event handeling in nova already12:54
gibicool12:54
sean-k-mooneyif we dont have a waiter when we deque it we just log it and discard12:54
gibithat seems OK too then12:54
sean-k-mooneywhich si ok because we will check the state when we get to that part of the code12:54
sean-k-mooneybasically im just suggesting using the exact saem event system we use of inital sapwn after where we start the binidng in the conductor then wait for it with an early out in the compute12:55
gibiOK, I don't have a #2 actually :)12:56
sean-k-mooneybut in this case the cyborg agent would start the bind on start up12:56
gibisean-k-mooney: so far what you suggest feels OK to me12:56
sean-k-mooneyill find the time stamp for this and add it to the reveiw12:57
gibicool12:57
gibithanks12:57
sean-k-mooneybauzas: if you have time to read scool back and find anything concering with that please chime in12:57
*** zzzeek has quit IRC13:00
*** rcernin has quit IRC13:00
*** zzzeek has joined #openstack-nova13:00
*** mgariepy has joined #openstack-nova13:02
*** zenkuro has joined #openstack-nova13:03
*** rcernin has joined #openstack-nova13:05
*** nightmare_unreal has quit IRC13:14
*** JamesBenson has joined #openstack-nova13:19
*** sapd1 has joined #openstack-nova13:26
bauzassean-k-mooney: looking13:26
*** derekh has quit IRC13:29
*** derekh has joined #openstack-nova13:30
*** rcernin has quit IRC13:30
bauzassean-k-mooney: are you talking about creating the mdevs in sysfs or binding them to the instance by modifying the XML ?13:33
sean-k-mooneybauzas: sysfs13:35
bauzasack13:36
bauzasif so, I agree, Cyborg should create them13:36
sean-k-mooneyspecifically cyborg creating them13:36
bauzas(the agent)13:36
sean-k-mooneyright but it shoudl do it automatically rather then as a result of a GET ot ARQ show13:36
sean-k-mooneywell GET /ARQ/<uuid>13:37
*** spatel has joined #openstack-nova13:48
openstackgerritBalazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events  https://review.opendev.org/c/openstack/nova/+/74992913:55
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach  https://review.opendev.org/c/openstack/nova/+/77024613:55
*** mlavalle has joined #openstack-nova13:58
bauzassean-k-mooney: yeah, provisioning them directly13:59
bauzasonce the operator modifies the config14:00
sean-k-mooneywhat config?14:00
bauzastheir own config for telling which vgpu type for each pGPU14:00
sean-k-mooneywe are talking about recreating them after a host reboot14:00
sean-k-mooneythe cyborg spec currently say after a host reboot when we reboot the instance that we will do a arq show14:01
bauzasI haven't seen it14:01
sean-k-mooneyand that show will do an rpc to the agent to create the mdev14:01
bauzasif so, -1 for me14:01
sean-k-mooneyim suggesting that instead on start up the agent shoucl check what instance are on the current host and ensure there mdevs exist14:01
sean-k-mooneyand that arqs should have 2 newe states14:02
sean-k-mooneyunknon meaning the agent missed it heart beat14:02
sean-k-mooneyand provisioning meaning its currenlty seting up the mdev14:02
sean-k-mooneyso when we do the show arq binding call if its in provisioning or unknow we wait for the async event14:03
sean-k-mooneyif its in bound we know cyborg is done and we proceed14:03
*** songwenping__ has quit IRC14:10
*** songwenping__ has joined #openstack-nova14:10
bauzassean-k-mooney: then I agree with you14:10
bauzashave you provided those comments in the spec ?14:11
sean-k-mooneyyes although not that cohently initally so i reference the irc logs above14:11
sean-k-mooneyi had give that feedbac in patch set 7 or 9 too14:11
bauzas++14:22
bauzasI'll then add my comments then too14:22
*** dave-mccowan has joined #openstack-nova14:28
*** ociuhandu_ has joined #openstack-nova14:28
*** ociuhandu has quit IRC14:31
*** nweinber has joined #openstack-nova14:35
openstackgerritLee Yarwood proposed openstack/nova stable/train: trivial: Resolve (most) flake8 3.x issues  https://review.opendev.org/c/openstack/nova/+/77094314:39
openstackgerritLee Yarwood proposed openstack/nova stable/train: WIP/DNM Switch to hacking 2.x  https://review.opendev.org/c/openstack/nova/+/77094414:39
stephenfinlyarwood: Does this need a blueprint, I wonder? It is kind of feature'ish https://review.opendev.org/c/openstack/nova/+/77092614:47
*** rpittau is now known as rpittau|afk14:48
lyarwoodstephenfin: likely, I was procrastinating this morning and wrote that without thinking15:03
lyarwoodgibi: ^ re this, should I create a blueprint for this?15:07
*** lpetrut has quit IRC15:07
gibilyarwood: yeah, a bp would be good for that it is adding a feature basically15:08
gibior we can phrase the whole thing as a bug15:09
gibiwe forget to log resetState into the instance actions15:09
gibiso meh, either a bp or a bug would be good15:09
*** ociuhandu_ has quit IRC15:09
gibino structural API impact so definetly not a spec15:10
lyarwoodgibi: ack let me spin this into a bug15:19
gibiworks for me15:20
openstackgerritStephen Finucane proposed openstack/nova master: api-ref: Clarify 'all_tenants' command  https://review.opendev.org/c/openstack/nova/+/77094715:21
stephenfinThat's the easiest "bugfix" anyone will see this week ^15:21
*** ociuhandu has joined #openstack-nova15:22
gibistephenfin: +@15:24
gibistephenfin: +215:24
stephenfinthanks :)15:24
*** jmlowe has quit IRC15:27
dansmithahh, the rare but coveted +@ vote15:30
openstackgerritLee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action  https://review.opendev.org/c/openstack/nova/+/77092615:30
gibidansmith: :)15:39
stephenfinIs https://docs.openstack.org/ down for anyone else?15:41
stephenfinnvm, it's back15:42
lyarwoodstephenfin: rate limited again? :D15:43
*** dklyle has joined #openstack-nova15:50
* stephenfin glares at lyarwood 15:51
*** mgariepy has quit IRC15:55
openstackgerritLee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action  https://review.opendev.org/c/openstack/nova/+/77092616:06
lyarwoodstephenfin: well you did ask me to write another bloody reno ;) ^16:06
dansmithstephenfin: really nice job on the db compaction series... you made validating them as easy as I hoped, so I hope we'll get at least another core or two to do it :)16:09
stephenfinoh, thanks. Hopefully16:12
*** slaweq has joined #openstack-nova16:19
stephenfinmelwitt: quota question: if I create a server in a server group, should I expect the server_group_members.in_use count seen in 'nova quota-show --detail' to increment?16:28
melwittstephenfin: that might be one that stays stuck at zero. let me look and refresh my memory16:29
melwittstephenfin: yeah, that is one of the two that stays at zero (legacy behavior that hasn't been changed) https://github.com/openstack/nova/blob/master/nova/quota.py#L178-L18216:32
melwittso you would expect it not to ever increment16:32
stephenfinokay, great. Thanks for the confirmation16:32
* stephenfin closes https://bugs.launchpad.net/nova/+bug/190926916:33
openstackLaunchpad bug 1909269 in OpenStack Compute (nova) "I create a server_groups vm , but server_group_members doesn't add one." [Undecided,New]16:33
*** dtantsur is now known as dtantsur|afk16:41
*** iurygregory has quit IRC16:41
*** mgariepy has joined #openstack-nova16:42
lyarwoodstephenfin: did you plan on wiring up openstack server migration show btw?16:43
* lyarwood has lost the link to the pad tracking all of this if you have it to hand16:44
stephenfinoh, fair point16:45
stephenfinI don't think there's a patch open for that. I can add one16:45
stephenfinhttps://etherpad.opendev.org/p/compute-api-microversion-gap-in-osc16:45
* lyarwood bookmarks16:45
lyarwoodstephenfin: cool happy to also look at that post m216:46
lyarwoodin the context of https://bugs.launchpad.net/nova/+bug/1910781 btw16:46
openstackLaunchpad bug 1910781 in OpenStack Compute (nova) "Live migration to different host returns complete but nothing has happened" [Undecided,New]16:46
lyarwoodlooks like there's another bug there with --wait16:46
* stephenfin looks16:47
*** ociuhandu_ has joined #openstack-nova16:53
*** ociuhandu has quit IRC16:56
*** ociuhandu_ has quit IRC16:58
*** sapd1 has quit IRC17:01
*** iurygregory has joined #openstack-nova17:06
openstackgerritMerged openstack/nova master: Fix typo in warning message  https://review.opendev.org/c/openstack/nova/+/77006717:06
*** ociuhandu has joined #openstack-nova17:11
*** slaweq has quit IRC17:12
*** xek has quit IRC17:13
*** ociuhandu has quit IRC17:16
*** mlavalle has quit IRC17:31
*** mlavalle has joined #openstack-nova17:32
*** dave-mccowan has quit IRC17:38
*** tbachman_ has joined #openstack-nova17:38
*** tbachman has quit IRC17:39
*** tbachman_ is now known as tbachman17:39
*** ralonsoh has quit IRC17:56
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host  https://review.opendev.org/c/openstack/nova/+/76577217:57
*** derekh has quit IRC18:03
*** gyee has joined #openstack-nova18:14
*** tesseract has quit IRC18:27
*** andrewbonney has quit IRC19:00
*** zenkuro has quit IRC19:03
*** spatel has quit IRC19:03
*** zenkuro has joined #openstack-nova19:04
*** Oriz|2 has quit IRC19:09
*** slaweq has joined #openstack-nova19:22
gmanndansmith: melwitt if you are around can you check these two reviews for JSON->YAMl policy file migration - https://review.opendev.org/c/openstack/placement/+/764394  https://review.opendev.org/c/openstack/nova/+/76348719:23
*** jdillaman has quit IRC19:26
*** rcernin has joined #openstack-nova19:27
*** rcernin has quit IRC19:31
dansmithgmann: you replace a function ref with a (function, dict) tuple.. do the upgrade checks support that for args?19:52
dansmithfunctools.partial or lambda would make that a little clearer, but I'm not sure what exactly parses this19:54
*** andrewbogott has left #openstack-nova20:06
gmanndansmith: I added the support for tuple in oslo.upgradecheck - https://github.com/openstack/oslo.upgradecheck/blob/a962943bdaa746ad238f003f56556eb02d1ea8e8/oslo_upgradecheck/upgradecheck.py#L10420:10
*** slaweq has quit IRC20:11
dansmithgmann: okay20:11
dansmithgmann: left you another question20:11
gmanndansmith: this one? https://review.opendev.org/c/openstack/nova/+/763487/9/nova/policy.py#7920:12
melwittgmann: ack, will look20:12
dansmithgmann: yar20:12
dansmithoh sorry20:12
* dansmith refreshes20:12
gmannwe have covered the test on oslo side, you want to keep existing nova test too20:12
dansmithno,20:13
dansmithI just want to make sure we know what is and isn't changing20:13
dansmithare you saying that oslo.policy controls CONF.policy_file, and is handling the CONF.find_file behavior?20:14
gmannok, yeah be default this fallback is maintained in oslo side until oslo.policy remove the JSON support20:14
dansmithoh wait wait, I see20:14
dansmithbecause we're calling into policy.Enforcer... nevermind20:14
dansmithsorry20:14
gmannyeah https://github.com/openstack/oslo.policy/blob/0a228dea2ee96ec3eabed3361ca22502d0bbd4a1/oslo_policy/policy.py#L53320:15
openstackgerritMerged openstack/nova stable/stein: [stable-only] Fix lower-constraints job  https://review.opendev.org/c/openstack/nova/+/76980920:15
openstackgerritGhanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file  https://review.opendev.org/c/openstack/placement/+/76439420:35
gmanndansmith: ^^ updated20:35
melwittgmann: one comment on the nova change, looks like the code you need is in 1.2.0, did you want to go ahead and keep it at 1.3.0?20:38
gmannmelwitt: i remember something extra i fixed in 1.3.0, let me check20:38
melwittgmann: ok, completely up to you. just pointed it out in case it isn't what you intended20:39
gmannmelwitt: CLI opt registration things added in 1.30 - https://github.com/openstack/oslo.upgradecheck/blob/1.3.0/oslo_upgradecheck/common_checks.py#L2920:40
gmannreplied in gerrit too20:40
melwittgmann: ok, great. thanks for clarifying that20:41
gmannthanks dansmith melwitt for review, have a nice weekend20:53
dansmithgmann: you as well :)20:53
gmannthx :)20:54
*** rcernin has joined #openstack-nova20:57
melwittgmann: have a nice weekend o/20:58
*** rcernin has quit IRC21:01
*** JamesBenson has quit IRC21:03
*** bbowen has quit IRC21:05
*** raildo has quit IRC21:08
*** nweinber has quit IRC21:24
*** whoami-rajat__ has quit IRC21:26
*** rcernin has joined #openstack-nova21:53
*** rcernin has quit IRC21:58
*** rcernin has joined #openstack-nova22:04
*** ociuhandu has joined #openstack-nova22:20
*** ociuhandu has quit IRC22:25
*** tbachman has quit IRC22:27
*** tbachman has joined #openstack-nova22:29
*** bbowen has joined #openstack-nova22:39
*** logan- has quit IRC22:40
openstackgerritMerged openstack/nova master: Reuse code from oslo lib for JSON policy migration  https://review.opendev.org/c/openstack/nova/+/76348722:44
*** logan- has joined #openstack-nova22:53
*** yoctozepto5 has joined #openstack-nova22:54
*** yoctozepto has quit IRC22:55
*** yoctozepto5 is now known as yoctozepto22:55
*** vdrok has quit IRC22:57
*** vdrok has joined #openstack-nova22:58
*** flaviof has quit IRC22:58
*** TheJulia has quit IRC22:58
*** flaviof has joined #openstack-nova22:58
*** TheJulia has joined #openstack-nova22:58
*** nautik has quit IRC22:58
*** cap has quit IRC23:00
*** coreycb has quit IRC23:01
*** jrosser has quit IRC23:01
*** coreycb has joined #openstack-nova23:01
*** cap has joined #openstack-nova23:01
*** jrosser has joined #openstack-nova23:03
*** ftarasenko has quit IRC23:03
*** logan- has quit IRC23:04
*** songwenping_ has joined #openstack-nova23:08
*** songwenping__ has quit IRC23:11
*** yoctozepto6 has joined #openstack-nova23:16
*** yoctozepto has quit IRC23:17
*** yoctozepto6 is now known as yoctozepto23:17
*** logan- has joined #openstack-nova23:19
*** eandersson has quit IRC23:20
*** aarents has quit IRC23:20
*** johanssone has quit IRC23:20
*** aarents has joined #openstack-nova23:21
*** eandersson has joined #openstack-nova23:21
*** johanssone has joined #openstack-nova23:24
*** yoctozepto4 has joined #openstack-nova23:43
*** yoctozepto has quit IRC23:44
*** yoctozepto4 is now known as yoctozepto23:44
*** yoctozepto4 has joined #openstack-nova23:58
*** yoctozepto has quit IRC23:59
*** yoctozepto4 is now known as yoctozepto23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!