Monday, 2021-01-04

*** ociuhandu has quit IRC00:04
*** ociuhandu has joined #openstack-nova00:05
*** ociuhandu has quit IRC00:09
*** brinzhang0 has joined #openstack-nova00:09
*** ociuhandu has joined #openstack-nova00:11
*** tosky has quit IRC00:12
*** brinzhang_ has quit IRC00:13
*** ociuhandu has quit IRC00:15
*** ociuhandu has joined #openstack-nova00:16
*** ociuhandu has quit IRC00:21
*** ociuhandu has joined #openstack-nova00:22
*** ociuhandu has quit IRC00:27
*** ociuhandu has joined #openstack-nova00:28
*** ociuhandu has quit IRC00:33
*** ociuhandu has joined #openstack-nova00:34
*** ociuhandu has quit IRC00:39
*** ociuhandu has joined #openstack-nova00:39
*** ociuhandu has quit IRC00:44
*** ociuhandu has joined #openstack-nova00:46
*** LinPeiWen has joined #openstack-nova00:46
*** ociuhandu has quit IRC00:50
*** ociuhandu has joined #openstack-nova00:57
*** ociuhandu has quit IRC01:02
*** ociuhandu has joined #openstack-nova01:15
*** ociuhandu has quit IRC01:20
*** ociuhandu has joined #openstack-nova01:20
*** ociuhandu has quit IRC01:30
*** brinzhang_ has joined #openstack-nova01:42
*** brinzhang0 has quit IRC01:45
openstackgerritArthur Dayne proposed openstack/nova master: Libvirt: fix the bug volume attaching failure when the VM domain is in transient status.  https://review.opendev.org/c/openstack/nova/+/76907401:48
*** ociuhandu has joined #openstack-nova02:00
*** ociuhandu has quit IRC02:05
*** ociuhandu has joined #openstack-nova02:06
*** ociuhandu has quit IRC02:11
*** ociuhandu has joined #openstack-nova02:12
*** ociuhandu has quit IRC02:17
*** ociuhandu has joined #openstack-nova02:18
*** ociuhandu has quit IRC02:23
*** ociuhandu has joined #openstack-nova02:24
*** ociuhandu has quit IRC02:29
*** ociuhandu has joined #openstack-nova02:30
*** ociuhandu has quit IRC02:35
*** ociuhandu has joined #openstack-nova02:36
*** ociuhandu has quit IRC02:40
*** zzzeek has quit IRC03:25
*** zzzeek has joined #openstack-nova03:29
*** mkrai has joined #openstack-nova03:43
*** LinPeiWen has quit IRC03:52
*** ociuhandu has joined #openstack-nova03:52
*** ratailor has joined #openstack-nova03:56
*** ociuhandu has quit IRC03:57
*** psachin has joined #openstack-nova04:00
*** bhagyashris has joined #openstack-nova04:19
*** abhishekk has joined #openstack-nova04:28
openstackgerritTakashi Natsume proposed openstack/python-novaclient master: Fix undesirable raw Python error  https://review.opendev.org/c/openstack/python-novaclient/+/76908204:50
*** mkrai has quit IRC04:57
*** mkrai has joined #openstack-nova05:31
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:33
*** ociuhandu has joined #openstack-nova05:40
*** ociuhandu has quit IRC05:47
*** fnordahl has joined #openstack-nova06:01
*** vishalmanchanda has joined #openstack-nova06:14
*** macz_ has joined #openstack-nova06:32
*** macz_ has quit IRC06:37
*** whoami-rajat__ has joined #openstack-nova06:39
*** songwenping_ has joined #openstack-nova06:58
*** ociuhandu has joined #openstack-nova07:02
*** ociuhandu has quit IRC07:07
*** LinPeiWen has joined #openstack-nova07:15
*** mkrai has quit IRC07:24
*** cgoncalves has joined #openstack-nova07:27
*** mkrai has joined #openstack-nova07:37
*** ralonsoh has joined #openstack-nova07:49
*** gibi_pto is now known as gibi07:58
gibigood morning07:58
bauzasgood morning Nova and happy new year !08:04
*** slaweq has joined #openstack-nova08:09
*** tesseract has joined #openstack-nova08:16
*** xek has joined #openstack-nova08:32
*** vishalmanchanda has quit IRC08:34
*** lee1 has joined #openstack-nova08:35
*** tosky has joined #openstack-nova08:35
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next  https://review.opendev.org/c/openstack/nova/+/76833408:43
gibibauzas: happy new year to you too08:48
*** ociuhandu has joined #openstack-nova08:50
*** rpittau|afk is now known as rpittau08:51
*** mkrai has quit IRC08:52
*** lee1 is now known as lyarwood08:52
lyarwoodmorning all and a happy new year08:52
*** kashyap has joined #openstack-nova08:52
gibilyarwood: happy new year to you too08:52
*** andrewbonney has joined #openstack-nova08:53
*** brinzhang0 has joined #openstack-nova08:56
*** ociuhandu has quit IRC08:56
*** brinzhang_ has quit IRC08:59
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next  https://review.opendev.org/c/openstack/nova/+/76833409:04
stephenfinhappy new year09:07
gibistephenfin: o/09:09
kashyapNew year's greetings to you all too09:10
bauzasmaybe I should tell "Better New Year" instead of "Happy new year" ?09:11
gibikashyap: \o09:12
gibibauzas: or simply just different new year :D09:12
lyarwoodbauzas: that's a pretty low bar after 2020 ;)09:12
kashyapbauzas: I ended my new year w/ this video: https://www.youtube.com/watch?v=fn3KWM1kuAw09:13
kashyapErr, the old year, I mean.09:13
bauzaskashyap: saw it ;) <309:13
lyarwoodI for one welcome our new dad dancing overlords09:15
* bauzas wonders if Asimov would love this 09:15
*** lemko has quit IRC09:19
*** lemko has joined #openstack-nova09:19
stephenfingibi: What do we want to do about this? https://review.opendev.org/c/openstack/python-novaclient/+/769066/09:20
openstackgerritMerged openstack/osc-placement master: remove unicode from code  https://review.opendev.org/c/openstack/osc-placement/+/76905909:28
*** mkrai has joined #openstack-nova09:29
openstackgerritMerged openstack/osc-placement master: remove unicode from code  https://review.opendev.org/c/openstack/osc-placement/+/76906209:30
*** slaweq has quit IRC09:31
gibistephenfin: looking09:32
*** ociuhandu has joined #openstack-nova09:32
stephenfinTa. Historically, mriedem had removed the novaclient features once the nova API was removed, however, since novaclient is used as a library by things like OSC, I'm not sure if we want to keep doing that09:32
*** slaweq has joined #openstack-nova09:33
gibistephenfin: I think it is OK to keep the nova client as is even for remove APIs as this code is not a big burden to maintain and as you said a new novaclient might be used towards an old nova API endpoint09:34
gibistephenfin: I don't even sure we want a deprecation message from the client itself as the server response is pretty obvious09:36
stephenfinOkay, cool. Let's keep it so09:37
brinzhang0gibi, stephenfin: happy new year09:39
brinzhang0gibi, stephenfin: did you have seen my news above? pinged you yesterday09:39
gibibrinzhang0: saw it but haven't looked the patches yet09:40
stephenfinsame09:41
brinzhang0gibi: ack, yeah, I just want to use v2.88 as the remove tenant_id microversion09:41
*** hamalq has joined #openstack-nova09:42
*** ociuhandu has quit IRC09:42
gibibrinzhang0: I have to see what are the other patches fighting for the same microversion and how ready these patches are09:42
stephenfinI was pretty sure we'd said we'd use 2.88 for the os-hypervisor work, since that's the smallest of the three items. I could have picked that up wrong though09:42
stephenfinIt's okay though. I think we're all aware there are competing microversion changes and can be sure to finish one before starting on the next09:43
bauzasgibi: stephenfin: MHO about client changes is that we can remove old features if the API is no longer supporting it09:43
bauzasbut then we would have to say that the minor version supported by the client would change09:44
gibibauzas: sure we can, it is more the question if we want to remove.09:44
brinzhang0stephenfin: yeah, if possible, I can help you to change, because the remove tenant_id patach depends on 2.88, and there are some place use v2.8809:44
stephenfinbauzas: what do we do about things like OSC though, that depend on the novaclient library implementation09:44
bauzasstephenfin: the question is, should we still support v2.1 for the client ?09:45
bauzasif yes, we *can't* remove09:45
stephenfinbrinzhang0: That's true for all changes. Whatever gets punted to 2.89 just has to be rebased and references to 2.88 updated to 2.8909:46
*** hamalq has quit IRC09:46
stephenfinbauzas: OSC does, yes. It's supposed to support all OpenStack clouds, regardless of version (though I suspect we fall well short of that marker, and I also doubt many people are using new OSC with an e.g. Essex cloud)09:47
brinzhang0stephenfin: yeah, after you can review these patch, and pls consider waht I want to say, thanks09:48
brinzhang0and I am sure the remove tenant_id feature can be done in this release09:49
brinzhang0but as bauzas and you talked above, how to deal with the OSC changes?09:50
*** derekh has joined #openstack-nova09:50
brinzhang0ah, maybe it's(OSC) ok for the latest changes :D09:51
bauzasstephenfin: brinzhang0: see how version discovery works https://docs.openstack.org/api-guide/compute/microversions.html#version-discovery09:53
bauzasgiven our API provides minimum as 2.0 (or 2.1, can't remember exactly which one given they are the same)09:53
bauzas,09:53
bauzasthen the client would have to support the minimum too09:54
bauzashere, 2.109:54
bauzasactually, wrong link, https://docs.openstack.org/api-guide/compute/microversions.html#client-interaction is better09:54
*** ociuhandu has joined #openstack-nova09:56
*** ociuhandu has quit IRC09:56
*** hamalq has joined #openstack-nova09:57
*** ociuhandu has joined #openstack-nova09:57
gibiso the conclusion could be that we can remove the CLI part but we cannot remove the lib part due to OSC09:59
brinzhang0I think yes10:01
*** hamalq has quit IRC10:02
gibistephenfin, bauzas: summarized my view in https://review.opendev.org/c/openstack/python-novaclient/+/76906810:04
bauzasgibi: if we cut the support on the CLI, then we need to bump a major version when we release the client10:10
bauzasbut that's ok IMHO10:10
gibibauzas: correct, that is what the deprecation messages now describe in the patch10:10
bauzasack10:11
*** ociuhandu has quit IRC10:13
gibiwhen (or even if ever) we cut a major version is open10:14
bauzasright10:14
*** ociuhandu has joined #openstack-nova10:16
*** jangutter_ has joined #openstack-nova10:18
*** jangutter has quit IRC10:21
*** ociuhandu has quit IRC10:22
lyarwoodgibi / stephenfin ; https://review.opendev.org/c/openstack/nova/+/767590 - time to +W this?10:32
openstackgerritMerged openstack/nova master: tests: Merge 'test_hypervisor_status' into 'test_hypervisors'  https://review.opendev.org/c/openstack/nova/+/76403910:33
stephenfinI think so10:33
*** macz_ has joined #openstack-nova10:34
lyarwooddone10:35
*** ociuhandu has joined #openstack-nova10:36
*** macz_ has quit IRC10:38
*** macz_ has joined #openstack-nova10:54
openstackgerritMerged openstack/nova master: Run the db migration tests in the same test worker  https://review.opendev.org/c/openstack/nova/+/76759010:56
*** lpetrut has joined #openstack-nova10:59
*** macz_ has quit IRC10:59
gibilyarwood,stephenfin: thanks11:01
gibiI will keep monitoring those tests11:01
gibias we did not solved the issue we just decreased the likelyhood11:02
gibistephen's db migration compression patch series will be an even better fix when it lands11:02
* gibi starts getting back the memories where he left of work last year11:03
openstackgerritLee Yarwood proposed openstack/nova master: WIP zuul: Add nova-live-migration-ceph job  https://review.opendev.org/c/openstack/nova/+/76846611:11
lyarwood^ getting close with this btw, there are some random volume backup test failures at the moment but the live migration and evacuation parts are working11:12
sean-k-mooneyoh nice11:13
openstackgerritLee Yarwood proposed openstack/nova master: Add regression test for bug #1908075  https://review.opendev.org/c/openstack/nova/+/76697611:18
openstackbug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Undecided,New] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)11:18
openstackgerritLee Yarwood proposed openstack/nova master: api: Reject volume attach requests when an active bdm exists  https://review.opendev.org/c/openstack/nova/+/76847211:18
gibistephenfin: I'm looking at the hypervisor series and wondering if the impl now in sync with the uptime change proposed in the yet unmerged spec additon here https://review.opendev.org/c/openstack/nova-specs/+/765797/1 ?11:19
stephenfingibi: I need to refresh my memory, but it doesn't appear to be, no11:22
stephenfinI guess we need to approve https://review.opendev.org/c/openstack/nova-specs/+/765797/ and then I can rework. bauzas? lyarwood?11:23
gibistephenfin: so pontentially we need either a new microversion for the uptime thing or a new PS for the current hypervisor patch11:23
stephenfinideally the latter11:23
stephenfinthat change hardly seems worth a microversion by itself11:24
sean-k-mooneyi would be -1 on a microverion to readd uptime11:24
sean-k-mooneyso ya either respin the patch or just drop uptime would but a second micorversion for it seam excessive11:25
gibiOK, I agree, let's merge that spec amendment and the respin the impl patch11:26
gibibauzas: could you look at the small spec addition at  https://review.opendev.org/c/openstack/nova-specs/+/765797/1 ?11:27
* sean-k-mooney appears to have forgotten how to use gerrit and keeps clicking change instead of your11:27
sean-k-mooneyf**** the extra * is to account for my usual misspelling :)11:30
sean-k-mooneymy main server has decided to stop negocition gigabit full duplex  connectivity and keeps downgrading to 100mbps but that breaks all network connectivity11:32
sean-k-mooneyits started doing this saturday after i rebooted it before i tried to install my gpu in it to do gpu passthough11:32
sean-k-mooneyso now i dont have access to any of my dev envionments...11:33
sean-k-mooneyalso our gpu passtough works but nvida chave changed how they do the vm detachtion so the kvm hidden feature we supprot nolonger works for windows guests11:33
sean-k-mooneythis came up on irc a a few weeks ago acctully but i can now confirm that our current code is not sufficent, if nova users upgrade there gpu driver it there gueste will eventually stop working which is lovely11:35
lyarwoodsean-k-mooney:s~.11:49
lyarwoodurgh sorry11:49
lyarwoodstephenfin: sorry was afk, I'll take a look at that now11:50
*** zzzeek has quit IRC11:50
*** zzzeek has joined #openstack-nova11:52
gibianother easy spec update needs anther core eyes https://review.opendev.org/c/openstack/nova-specs/+/76880311:53
*** ociuhandu has quit IRC12:01
stephenfingibi: done12:16
gibithanks12:16
*** slaweq has quit IRC12:18
*** slaweq has joined #openstack-nova12:20
openstackgerritMerged openstack/nova-specs master: [Trivial] Clarify the deprecated apis in *Proposed change*  https://review.opendev.org/c/openstack/nova-specs/+/76880312:29
*** ociuhandu has joined #openstack-nova12:32
*** ociuhandu has quit IRC12:37
*** mkrai has quit IRC12:38
bauzasgibi: stephenfin: sure, will look at https://review.opendev.org/c/openstack/nova-specs/+/765797/12:41
gibibauzas: thanks12:47
bauzasdone, +Wd12:48
gibistephenfin: you are good to go for a respin of your hypervisor patch12:48
*** viks____ has joined #openstack-nova12:48
gibimeanwhile I looked at the vncconsole password patch (another microversion bump) but that is not ready yet, I still have serious comments there (not published yet)12:49
gibiso right now the hypervisor patch feels the closest for the 2.88 microversion12:49
gibiI will look at the tenant_id patch series too12:49
openstackgerritMerged openstack/nova-specs master: Update modernize-os-hypervisors-api spec, pt. 3  https://review.opendev.org/c/openstack/nova-specs/+/76579712:54
*** Luzi has joined #openstack-nova12:55
*** macz_ has joined #openstack-nova12:55
*** macz_ has quit IRC13:00
*** mkrai has joined #openstack-nova13:03
*** eharney has joined #openstack-nova13:22
*** ratailor has quit IRC13:23
*** haleyb has quit IRC13:24
*** haleyb has joined #openstack-nova13:27
*** eharney has quit IRC13:29
*** ociuhandu has joined #openstack-nova13:30
*** tosky has quit IRC13:30
*** tosky has joined #openstack-nova13:30
*** eharney has joined #openstack-nova13:31
*** artom has joined #openstack-nova13:39
stephenfingibi: Yup, I'll do it now13:45
gibistephenfin: cool13:45
*** dave-mccowan has joined #openstack-nova13:53
*** tbachman has quit IRC13:56
*** martinkennelly has joined #openstack-nova14:07
*** songwenping_ has quit IRC14:09
*** lbragstad has joined #openstack-nova14:09
*** zoharm has joined #openstack-nova14:10
zoharmhi, regarding proposed nvme healing agent feature: https://review.opendev.org/c/openstack/cinder-specs/+/76673214:12
zoharmwe would like to ask, what is the right way to spawn it? we had it proposed to use python-daemon python package for maintaining an independent process. Is it ok to add that dependency?14:13
zoharmif using python-daemon is not ok, geguileo suggested previously to look at privsep daemon and see how it is spawned. which way in there is better? https://opendev.org/openstack/oslo.privsep/src/branch/master/oslo_privsep/daemon.py line 296 or 336 - we would like to have only one agent process per host. any pointers / details would be useful here. Thank you!14:13
*** Luzi has quit IRC14:14
*** nweinber has joined #openstack-nova14:19
kashyapstephenfin: sean-k-mooney: Remind me again, Nova supports CPU pinnning to host core and to host NUMA node, both, yes?14:26
*** lbragstad has quit IRC14:27
stephenfinyes14:27
sean-k-mooneykashyap: kindo of it depend on what you mean by host numa nodes14:27
gibizoharm: the nova services (daemons) using oslo_services to spawn the daemon process https://docs.openstack.org/oslo.service/latest/14:27
*** mkrai has quit IRC14:27
stephenfinhw:cpu_policy=dedicated to pin to individual host cores14:27
sean-k-mooneywe support soft pinning so a vm will float over the cores of a singel numa node if that is what you mean14:27
sean-k-mooneyand we obvioulsy support direct 1:1 gust cpu to host cpu pinning too14:28
kashyapI'm just asked if "CPU Pinning to host core" is supported or not14:28
sean-k-mooneyhw:numa_nodes=1 to pin the vm to just one host numa node14:28
sean-k-mooneykashyap: you cant choose the core but yes14:29
kashyapOkay; thx14:29
zoharmgibi thank you, we want to do this from os-brick, is that ok?14:29
zoharmalso, any chance for a pointer at an example of how to use it?14:29
sean-k-mooneyzoharm: not really14:29
sean-k-mooneyso os-brick is shared between nova and cinder14:30
sean-k-mooneyboth run as deams already and invoke the lib14:30
*** tbachman has joined #openstack-nova14:30
kashyapstephenfin: sean-k-mooney: One more, the above of what I asked is supported from Queens, is it?14:30
sean-k-mooneyyou proably should not be sapawning a second deamon out of the os-brick lib14:30
zoharmright, but we need an entry point for the agent/daemon as per the spec, and the connector is the place decided on14:30
zoharmdo you have an alternative?14:31
*** lbragstad has joined #openstack-nova14:31
bnemeczoharm: If you want to know more about how privsep works, you can read about it in https://github.com/openstack/oslo.privsep/blob/master/oslo_privsep/daemon.py#L1514:31
sean-k-mooneyzoharm: a better apprcoh would be to have a seperate console script entry point that is run seperatly as a deamon and no tspawned out of eithet the nova-compute process or the cinder-volume process14:31
zoharmwhat is a console script?14:32
*** lbragstad has quit IRC14:32
zoharmwe are aware of the option of having an external script, but the goal here is to get it into openstack14:32
sean-k-mooneyzoharm: its a setuptool entroy point that creates a indepenten binary that you can run in the termal14:32
*** lbragstad has joined #openstack-nova14:32
zoharmok that sounds interesting, can you give me a reference / example?14:33
sean-k-mooneysure on sec14:33
zoharmand proposal is not to run it from terminal, but have openstack run it only when needed.14:33
gibiif this agent is just executes a periodic task then I guess such periodic task can be added to either the cinder or the nova agent to call a function in the os-brick lib14:33
sean-k-mooneythe nova compute agent itslef is one https://github.com/openstack/nova/blob/master/setup.cfg#L7314:33
sean-k-mooneythat creats a binary that runs https://github.com/openstack/nova/blob/master/nova/cmd/compute.py14:34
sean-k-mooneywhich uses oslo service to run the nova compute applicatoin as a deamon14:34
zoharmi see, but that would be a whole new service, which the operator would need to launch independently14:34
sean-k-mooneyyes14:34
sean-k-mooneyprivsep works slightly differently14:35
zoharmthis is not the proposal, it is just as good as an external script14:35
sean-k-mooneyin that we launch a different process in one of 2 ways14:35
sean-k-mooneyeither we fork a seperate process using the privsep helper and typicaly sudo14:35
zoharmi think having completley new service to something that is tightly coupled to an os-brick connector is overkill both operationally and in code14:35
sean-k-mooneyor we run nova with elevetated prviages for the process and drop privlates on nova-compute14:35
zoharmok, can we do that for this agent too?14:36
zoharmif we can't use python-daemon14:36
sean-k-mooneypossibly but it depned on what it does i have not read the spec14:36
zoharmit is ran only when an NVMe volume is connected to a host14:36
zoharmit monitors the connection, and if its a replicated volume, self heals it14:37
sean-k-mooneybut then it continues running14:37
sean-k-mooneybasicaly what are the lifetime sematince you want14:37
zoharmyes, but we can add a mechanism to self kill when there are not more nvme connections14:37
sean-k-mooneyshould it continue running if nova-compute is stopped but the vm is still running14:37
zoharmkeep running as long as there are managed nvme volumes connected to by connector14:37
zoharmyes14:37
*** tbachman has quit IRC14:38
zoharmif vm is connected to nvme volume via the nvme connector14:38
sean-k-mooneyi think right now privsep will exit in that case wehn the last clinet on the privsep socket disconnects14:38
sean-k-mooneyprivsep usins a unix socket to comunicate between the two processes14:38
zoharmright14:38
zoharmthat is a good point, that all process can exit but VMs can keep running and consuming connected volumes...14:39
zoharmlooks like another pain point14:39
sean-k-mooneythat is one that comes up during upgrades14:39
zoharmwe can argue that it is ok to have this agent disabled for short time during upgrade, as long as something turns it back on14:39
sean-k-mooneywell the thing that turns it back on would be initalisin os-brick14:40
sean-k-mooneywhen nova-compute is started after the upgrade14:40
sean-k-mooneyif the lifetime of this seperate process could be made the same as the process the spawned ti then mimicing privsep works14:41
zoharmok, so in this case in connector init, scan for nvme volumes that are managed by this and if there are launch the agent14:41
sean-k-mooneythe trigger from the nova side would likely be init_host14:41
zoharmwhat if one process spawned it, then another process also wants it spawned, and then first process was permanently stopped14:41
zoharminit_host sounds good, that is in os-brick?14:42
sean-k-mooneywhere we loop over all the vms and check that there networking and presumabley volume connection are set up14:42
sean-k-mooneyno in nova14:42
sean-k-mooneybut i think we call into os-brick14:42
sean-k-mooneywe call into os-vif to ensure the vifs are pluuged in init host14:42
sean-k-mooneyi expect we do the same for os-brick14:42
zoharmok, we want to keep this change out of nova for now since its specifically deals with only volumes14:43
zoharmunless you think its better to add it to nova14:43
sean-k-mooneydose os-brick have an inialise function?14:44
zoharmfor volume connection?14:44
zoharmthere is init for the connector which is called when its loaded up for first time14:44
sean-k-mooneyno for the lib in general14:44
*** zzzeek has quit IRC14:44
sean-k-mooneyos-vif has https://github.com/openstack/os-vif/blob/master/os_vif/__init__.py#L2414:44
sean-k-mooneywhich is called when the compute agent start to tell os vif to load all its plugin dirvers14:45
zoharmi dont know, but i think that is not best place to put this re-init agent entrypoint14:45
zoharmdo you know if nova ends up calling os-brick connect_volume during host_init?14:45
zoharmif it does, then that solves everything for us because connect_volume is currently the entry point14:45
*** cap has quit IRC14:46
zoharmwe dont want to launch this agent when os-brick or connector loads (since all connectors / os-brick are loaded for every service and we dont want this agent running everywhere, only where nvme volumes are connected via the connector)14:46
sean-k-mooneyim just reading https://github.com/openstack/nova/blob/b0f241e5425c99866223bae4b404a4aa1abdfddf/nova/compute/manager.py#L956 now14:46
sean-k-mooneyfor each instance we call _init_instance in init_host14:46
*** zzzeek has joined #openstack-nova14:47
sean-k-mooneythis is where we ensure the network interfaces are set up https://github.com/openstack/nova/blob/b0f241e5425c99866223bae4b404a4aa1abdfddf/nova/compute/manager.py#L113714:47
*** cap has joined #openstack-nova14:47
zoharmim looking through it too now, found _init_volume_connection but it is not called during init_host14:48
zoharmback to python-daemon, do you think it is not ok to propose this new depedency?14:48
sean-k-mooneyyou could but do you need too14:51
sean-k-mooneywhat benifit will it provide14:51
zoharmit will allow to run this agent as a single independent process that will keep running regardless of the different services that may spawn it14:56
sean-k-mooneyok but then how to you interact with it and manage its lifetime14:57
zoharmand we can have it terminate itself when no connections are left if needed14:57
zoharmwe dont need to interact with it much, the interaction is mostly spawning it, and then it will be calling volume backend API for its functionality14:58
sean-k-mooneybased on what? i will need to have some set of input and know when a nvme volume attachemt is made14:59
zoharmonce it runs it basically just monitors local nvme connections belonging to it (it can tell them apart) and calling volume backend if necessary14:59
zoharmthe nvme connector connect_volume is called when nvme volume attachment is made, and that is the entry point where we ensure the agent is running15:00
zoharmcertain agent implementation is vendor specific, but it can tell by reading nvme device related dev paths information about where it came from15:01
zoharmand backend provides metadata15:01
openstackgerritMerged openstack/python-novaclient master: Fix a functional test for 'nova agent-list'  https://review.opendev.org/c/openstack/python-novaclient/+/76906615:01
zoharmbasically what the agent does is reconcile metadata from backend with physical connection state on host (this is mostly for mdraid replicated volumes)15:02
sean-k-mooneyim reading the spec now but i dont think this agent really fits in the project scope fo os-brick15:02
zoharmi understand your concern, this is where we settled on putting it for now15:03
sean-k-mooneyit really does seam like an indepenet service similar to multipathd rhater then a capablity a libviary shoudl be providing15:03
zoharmgood point15:03
sean-k-mooneywell im concerend that this is a possibel ddos vector for the cinder api or storage backend depending on how it monitors the conenctiions and what api calls its makink15:03
sean-k-mooneye.g. if i have a 1000 node deployment and i install this on all notes how will that work15:04
sean-k-mooneythis agent will spawn a monitoring task which will repeat15:05
sean-k-mooneyperiodically.15:05
sean-k-mooneydoes it need to be an agent or could it be a perodic task defined in os-brick15:05
sean-k-mooneythat is then elecitly run by the consumer of os-brick15:05
*** mkrai has joined #openstack-nova15:06
sean-k-mooney"One key problem that would need to be addressed by this selection is a scenario15:06
sean-k-mooneywhere compute service goes down, while the VMs continue operating (and their15:06
sean-k-mooneyvolumes remain attached) - we don't want to lose this agent in this case.15:06
sean-k-mooney"15:06
sean-k-mooneythat is the main motivator for a seperate deamon process right15:06
sean-k-mooneyhttps://review.opendev.org/c/openstack/cinder-specs/+/766732/12/specs/wallaby/nvme-agent.rst#7115:07
*** lpetrut has quit IRC15:10
zoharmright15:10
zoharmopen to all suggestions here15:11
zoharmwe want it to be a periodic task that is launched only when nvme volumes are connected by the nvme connector15:14
*** swright has joined #openstack-nova15:17
*** jangutter_ has quit IRC15:20
*** jangutter has joined #openstack-nova15:20
kashyapstephenfin: One more, sorry: vTPM 2.0 and TPM passthrough -- both are supported in upstream Train, yeah?15:28
stephenfinkashyap: no, vTPM is supported since Victoria. TPM passthrough is not supported afaik15:29
sean-k-mooneyTPM passtough can only be done via pci passtough15:29
sean-k-mooneybut that is for stateless devices only15:30
sean-k-mooneyso using it wiwth a tpm which has state would be invalid15:30
kashyapstephenfin: sean-k-mooney: Nod; thx.  Context on these random questions, I got a ping elsewhere about these, so trying to fill in details15:30
sean-k-mooneyif cyborg had a TPM dirver it could provide a tpm to us and do the required cleaning but they dont as far as i know15:31
kashyapstephenfin: I have one more: I take it, your recent virtio device addition work means, we now support all these devices, corecct? —15:31
*** psachin has quit IRC15:31
kashyap    virtio-serial, virtio-vga, virtio-balloon, virtio-input, virtio-keyboard, virtio-mouse, virtio-tablet15:32
kashyapPerhaps not the -mouse yet15:32
sean-k-mooneyyou conflating different things15:32
kashyapsean-k-mooney: What am I conflating?15:32
sean-k-mooneyvirtio-serial has been supproted for year with the serial-console15:32
sean-k-mooneyvirtio-ballon cant be turned off yet so you always get it because libvirt adds one we agreeed to change that15:33
kashyapsean-k-mooney: Yeah; I know some of them have existed forever; all I care about is - does the latest upstream release support all the above devices or not15:33
kashyapRight.  (I know -balloon is supported; and we recommend it to turn off for especially the real-time cases)15:33
sean-k-mooneyvirti-input i think is not but im not sure15:33
sean-k-mooneykashyap: yes but right now you cant turn it off15:33
kashyap(And I recall reviewing the -keyboard and -input patches from Stephen, recently)15:33
sean-k-mooneyyou uses to be able to by disbleing mermoy stat monitoring15:34
sean-k-mooneybut at some point libvirt started always adding it15:34
sean-k-mooneykashyap: im just sure what -input is15:34
sean-k-mooney-tablet is definetly supported15:35
kashyapsean-k-mooney: You mean not sure?15:35
kashyaphttps://www.kraxel.org/blog/2016/09/using-virtio-input-with-libvirt/15:35
sean-k-mooneysorry yes15:35
sean-k-mooneyya ok so stephenfin was changing that but i havent revied it in a while15:35
sean-k-mooneybut he wrote a nice table in the commit message15:36
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/75655215:36
sean-k-mooneyoh the table was in https://review.opendev.org/c/openstack/nova/+/756551/315:37
kashyapsean-k-mooney: Right; inded, I was looking at that table a minute ago15:40
kashyapOkay; thanks.  I may come back with more "does upstream support X?" questions, if I can't figure it out myself :-)15:41
*** macz_ has joined #openstack-nova15:53
*** macz_ has quit IRC15:53
*** macz_ has joined #openstack-nova15:54
*** ociuhandu has quit IRC16:08
*** LinPeiWen has quit IRC16:15
*** dklyle has joined #openstack-nova16:18
*** slaweq has quit IRC16:19
*** slaweq has joined #openstack-nova16:20
*** zzzeek has quit IRC16:39
*** zzzeek has joined #openstack-nova16:40
*** zzzeek has quit IRC16:46
*** ociuhandu has joined #openstack-nova16:46
*** zzzeek has joined #openstack-nova16:47
*** gyee has joined #openstack-nova16:50
*** ociuhandu has quit IRC16:51
*** hamalq has joined #openstack-nova16:53
*** mkrai has quit IRC17:02
*** qqmber has joined #openstack-nova17:04
qqmberHi! How can I make a auth token to last longer? Because when I try to create a snapshot of a big instance takes around 120 minutes and fails because a 401 error, due a timeout ( auth expired). I tried to configure "expiration_time = 7200" in [cache] section, but no luck....17:06
qqmberin keystone.conf17:06
sean-k-mooneyyou can use service tokens17:08
sean-k-mooneybut it should not take 120mins to spawn17:08
qqmberhmmm... sorry, I don't get it.. what do you mean?17:09
qqmberHow can I use service tokens? Never did before..17:10
*** zzzeek has quit IRC17:13
*** slaweq has quit IRC17:13
*** zzzeek has joined #openstack-nova17:14
sean-k-mooneyyou have to configure them in the nova config17:14
sean-k-mooneyone sec17:14
*** rpittau is now known as rpittau|afk17:14
*** hamalq_ has joined #openstack-nova17:14
sean-k-mooneyhttps://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/use-service-tokens.html17:14
*** slaweq has joined #openstack-nova17:15
*** hamalq has quit IRC17:17
*** zenkuro has quit IRC17:25
lyarwoodqqmber: https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html might be useful assuming the instance is boot from volume?17:27
qqmbersean-k-mooney: thanks17:28
qqmberlyarwood: it does not boot from volume17:28
*** zenkuro has joined #openstack-nova17:32
qqmbersean-k-mooney: actually I'm in Pike.. and as says there.. is a change proposal... so.. I guess I can't use it in Pike :(17:38
*** tesseract has quit IRC17:44
sean-k-mooneyqqmber: it was added in pike17:48
sean-k-mooneyso that the first release you cna use it in17:48
qqmberoh, cool. thx17:49
sean-k-mooneyqqmber: you should still look in to why it took 2 hours to boot17:55
qqmberbecause it's a snapshot of 160GB and the host is pretty busy17:56
qqmberthat's all17:56
sean-k-mooneyunless you have reallly slow HDD and are copying TBs of root disk over 1G links it should not be that slow17:56
sean-k-mooneyi see17:56
sean-k-mooneywell if you know why i guess that is ok17:56
qqmbersean-k-mooney: that's why I'm doing the snapshot, to take off those instances to a new cluster17:57
qqmbera faster one17:57
*** derekh has quit IRC18:02
*** andrewbonney has quit IRC18:03
*** zzzeek has quit IRC18:26
*** zoharm has quit IRC18:27
*** zzzeek has joined #openstack-nova18:28
*** zenkuro has quit IRC18:52
*** zzzeek has quit IRC19:19
*** zzzeek has joined #openstack-nova19:20
*** zzzeek has quit IRC19:27
*** zzzeek has joined #openstack-nova19:28
*** qqmber has quit IRC19:43
*** _mlavalle3 has joined #openstack-nova20:16
*** _mlavalle_2 has quit IRC20:17
*** ociuhandu has joined #openstack-nova20:18
*** dave-mccowan has quit IRC20:40
*** ociuhandu has quit IRC20:40
*** ociuhandu has joined #openstack-nova20:43
*** ociuhandu has quit IRC20:49
*** whoami-rajat__ has quit IRC21:01
*** ociuhandu has joined #openstack-nova21:15
*** slaweq has quit IRC21:24
*** ralonsoh has quit IRC21:28
*** ociuhandu has quit IRC21:52
*** xek has quit IRC22:13
*** nweinber has quit IRC22:13
*** hack-char has quit IRC22:25
*** hack-char has joined #openstack-nova22:25
*** tkajinam has joined #openstack-nova23:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!