Thursday, 2020-12-10

*** tosky has quit IRC00:02
*** jangutter_ has joined #openstack-nova00:16
*** jangutter has quit IRC00:19
*** dcapone2004 has quit IRC00:20
*** adrian-a has quit IRC00:25
*** macz_ has quit IRC00:25
*** mlavalle has quit IRC00:30
*** brinzhang has joined #openstack-nova00:38
openstackgerritWenping Song proposed openstack/nova master: Remove redundant code in instance delete  https://review.opendev.org/c/openstack/nova/+/75957700:45
*** aj_mailing has quit IRC00:52
*** benj_- has joined #openstack-nova00:53
*** aj_mailing has joined #openstack-nova00:54
*** benj_ has quit IRC00:54
*** benj_- is now known as benj_00:54
*** littleboyfury has joined #openstack-nova00:54
*** nweinber has joined #openstack-nova01:01
*** nweinber has quit IRC01:01
*** LinPeiWen has joined #openstack-nova01:09
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API  https://review.opendev.org/c/openstack/nova/+/76638002:17
*** k_mouza has joined #openstack-nova02:28
brinzhanggmann: hi, I have a question with remove tenant_id02:29
brinzhanggmann: the Servers Security Groups API, just need to change this apihttps://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#servers-security-groups-servers-os-security-groups02:30
brinzhangbut it will be impact the deprecated apis,  https://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#security-groups-os-security-groups-deprecated02:31
brinzhangdoes it need to be consider to change the deprecated apis?02:31
brinzhangI saw the refresh policies changed the deprecated APIs too02:32
*** k_mouza has quit IRC02:33
*** mkrai has joined #openstack-nova02:57
*** priteau has quit IRC03:03
*** hemanth_n has joined #openstack-nova03:10
*** tbachman has quit IRC03:18
*** tbachman_ has joined #openstack-nova03:18
*** openstackgerrit has quit IRC03:22
JamesBensonsean-k-mooney: originally I had tried `custom` and posted `cpu_models = nehalem,westmere` & `cpu_model_extra_flags = pcid, vmx, pdpe1gb`  but then I couldn't boot up VM's. Those three flags are the ones of interest, but aren't in both models.03:34
*** hemanth_n has quit IRC03:35
JamesBensonsean-k-mooney: I thought that the way mentioned above was the right way, but couldn't get it working. Maybe the flags need to be there for all of them?03:36
*** psachin has joined #openstack-nova03:45
*** hamalq_ has quit IRC03:45
*** hemanth_n has joined #openstack-nova03:50
*** dave-mccowan has quit IRC03:54
*** gyee has quit IRC04:00
*** littleboyfury has quit IRC04:05
*** ratailor has joined #openstack-nova04:54
*** sapd1 has joined #openstack-nova04:55
*** bauzas has quit IRC05:02
*** zzzeek has quit IRC05:06
*** zzzeek has joined #openstack-nova05:08
*** bauzas has joined #openstack-nova05:09
*** dasp has quit IRC05:18
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:33
*** JamesBenson has quit IRC05:33
*** dasp has joined #openstack-nova05:34
*** JamesBenson has joined #openstack-nova05:35
*** JamesBenson has quit IRC05:41
*** rpittau|afk has quit IRC06:11
*** mnaser has quit IRC06:11
*** mnaser has joined #openstack-nova06:11
*** rpittau|afk has joined #openstack-nova06:11
*** sapd1 has quit IRC06:15
*** tbachman_ has quit IRC06:16
*** zzzeek has quit IRC06:17
*** JamesBenson has joined #openstack-nova06:17
*** zzzeek has joined #openstack-nova06:18
*** tbachman has joined #openstack-nova06:19
*** JamesBenson has quit IRC06:22
*** tbachman has quit IRC06:35
*** tbachman has joined #openstack-nova06:36
*** links has joined #openstack-nova06:40
*** evrardjp has quit IRC06:49
*** evrardjp_ has joined #openstack-nova06:49
*** lpetrut has joined #openstack-nova07:00
*** rcernin has quit IRC07:10
*** slaweq has joined #openstack-nova07:18
*** ralonsoh has joined #openstack-nova07:25
*** links has quit IRC07:28
*** rcernin has joined #openstack-nova07:29
*** dklyle has quit IRC07:37
*** macz_ has joined #openstack-nova07:51
*** openstackgerrit has joined #openstack-nova07:53
openstackgerritWenping Song proposed openstack/nova master: Nova supports password encrypted VNC  https://review.opendev.org/c/openstack/nova/+/62233607:53
*** macz_ has quit IRC07:55
*** hamalq has joined #openstack-nova08:06
*** mkrai has quit IRC08:07
*** rcernin has quit IRC08:07
*** andrewbonney has joined #openstack-nova08:11
openstackgerritWenping Song proposed openstack/nova master: Nova supports password encrypted VNC  https://review.opendev.org/c/openstack/nova/+/62233608:12
*** rpittau|afk is now known as rpittau08:17
*** teoobo_ has joined #openstack-nova08:18
*** JamesBenson has joined #openstack-nova08:18
openstackgerritWenping Song proposed openstack/nova master: Nova supports password encrypted VNC  https://review.opendev.org/c/openstack/nova/+/62233608:19
*** tesseract has joined #openstack-nova08:22
*** JamesBenson has quit IRC08:23
*** mkrai has joined #openstack-nova08:29
*** links has joined #openstack-nova08:34
*** larainema has joined #openstack-nova08:35
*** zzzeek has quit IRC08:36
bauzasgood morning Nova08:38
*** zzzeek has joined #openstack-nova08:39
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API  https://review.opendev.org/c/openstack/nova/+/76638008:44
*** tosky has joined #openstack-nova08:47
*** spatel has joined #openstack-nova08:52
*** spatel has quit IRC08:56
*** rcernin has joined #openstack-nova08:56
*** derekh has joined #openstack-nova08:58
*** rcernin has quit IRC09:13
*** links has quit IRC09:16
*** martinkennelly has joined #openstack-nova09:16
*** k_mouza has joined #openstack-nova09:17
*** aj_mailing has quit IRC09:31
*** zzzeek has quit IRC09:32
*** zzzeek has joined #openstack-nova09:33
gibimelwitt: hi09:34
melwittgibi: hi09:35
gibimelwitt: I saw your comment about the chicken-egg09:35
melwittI figured :) I'm tired so I might be wrong but afaict it is chicken and egg09:36
gibimelwitt: I guess we need to pull the fixes top of each other and then ask infra to promote09:36
gibimelwitt: I will add a unit test coverage for your qos fix during my day (I assume you will go to sleep soon)09:36
melwittyeah, either that or disable the min bw tempest tests to let the lower-constraints change through and then re-enable it09:37
lyarwoodah right I was going to ask about the bw failures in nova-next09:37
brinzhanggibi, dansmith: could you please review cyborg shelve/unshelve patch again https://review.opendev.org/c/openstack/nova/+/729563 ? thanks09:37
lyarwoodbrinzhang: dansmith is out until 2021 FYI09:37
melwittgibi: cool yes that would be appreciated, I am going to sleep soon. also I didn't find anything as to the cause for the failure on the master branch with the port binding failure too so that one needs eyes on it too09:38
brinzhanglyarwood: ack, a shocking news, dansmith will work to k8s?09:39
melwittgibi: for my patch I had been thinking to add resource requests to one of the nova/tests/functional/cross_cell_migrate.py but it would take me a bit to learn how to incorporate that09:39
lyarwoodbrinzhang: umm not that I'm aware of, he's just out on PTO until the new year.09:39
*** xek_ has joined #openstack-nova09:40
melwitt*test_cross_cell_migrate.py09:40
melwittmaybe that would be overkill anyway, I dunno09:41
gibimelwitt: I think this upgrade check that breaks in stable is removed from master09:41
melwittgibi: it is but it's failing in a different way for the master branch09:41
brinzhanglyarwood: yeah, I like that job too^, thanks09:41
gibimelwitt: ohh, then I will check that too09:41
melwittgibi: here's my ML post with links to more info http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html09:42
melwittlajoskatona is looking at the neutron side but I doubt it's neutron. it's just that when we request the port binding it results in neutron getting UnknownResourceProvider, I have no idea how that can happen09:43
gibimelwitt: sorry I was pulled in a downstream call09:53
gibiI will pick up the threads after it09:54
melwittthanks gibi++09:54
melwitto/09:54
gibimelwitt: have a nice evening09:54
*** ralonsoh_ has joined #openstack-nova10:00
stephenfinsean-k-mooney: The issue with https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises is nothing to do with mock the lib10:00
stephenfinsean-k-mooney: that happens because of testtools10:00
stephenfinsean-k-mooney: https://github.com/testing-cabal/testtools/issues/113 https://github.com/testing-cabal/testtools/issues/27510:01
*** ralonsoh has quit IRC10:01
gibilyarwood: regarding qos stable failures: other than the the packaging 20.4 bump and the qos break, is there any other know break on stable/victoria at the moment?10:02
lyarwoodgibi: not on stable/victoria that I'm aware of10:04
lyarwoodgibi: <= stable/train has other issues10:04
brinzhanghi all, the nova-multi-cell task always failed, is there a bug tracing?10:07
*** hamalq has quit IRC10:07
brinzhanghttps://8881082f52814b33cb4d-7716d10619577c42ab1386a760b8bb5c.ssl.cf2.rackcdn.com/764292/8/check/nova-multi-cell/9429107/testr_results.html10:07
gibilyarwood: ack, I saw the bandit affecting train and older10:10
gibibrinzhang: yes, the nova-cell-multi is broken right now10:10
gibibrinzhang: I have to look at it after my current call10:11
gibibrinzhang: here is melwitt's post about it from the mL http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html10:11
brinzhanggibi: ack10:11
brinzhanggibi: I saw your talking about above, sorry to mention again10:12
*** zzzeek has quit IRC10:13
lyarwoodgibi: ack kk, we could switch both jobs to NV and then land things?10:13
*** zzzeek has joined #openstack-nova10:14
gibilyarwood: both job is nova specific? then yes. NV->fix1->fix2->revert NV could be a solution10:16
gibilyarwood: sorry I have to be off for an hour or so10:17
lyarwoodgibi: np10:19
lyarwoodgibi: pushing now, I'll ask elod and others to review10:19
*** JamesBenson has joined #openstack-nova10:19
lyarwoodgit-review really takes a while now10:19
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4  https://review.opendev.org/c/openstack/nova/+/76574910:20
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: zuul: Temporarily make nova-multi-cell non-voting  https://review.opendev.org/c/openstack/nova/+/76644010:20
lyarwoodoh lyarwood--10:20
*** JamesBenson has quit IRC10:23
openstackgerritMIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata  https://review.opendev.org/c/openstack/nova/+/75055210:24
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: [stable-only] Temporarily make nova-multi-cell non-voting  https://review.opendev.org/c/openstack/nova/+/76644010:25
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4  https://review.opendev.org/c/openstack/nova/+/76574910:25
*** macz_ has joined #openstack-nova10:33
*** ralonsoh_ is now known as ralonsoh10:33
*** bbowen has quit IRC10:34
lyarwoodelod / bauzas ^ would you mind taking a look at the above stable changes10:34
*** bbowen has joined #openstack-nova10:35
*** songwenping_ has quit IRC10:35
elodlyarwood: sure, looking10:35
*** songwenping_ has joined #openstack-nova10:35
melwittgibi: one last update before I really go, I can see on zuul status that my stable/victoria change minbw tests have failed still but now for a different reason. the logs are not yet available but I suspect that now that the cell is correctly targeted, it's now hitting the same bug that exists on the master branch. just fyi10:37
lyarwoodcan someone kick melwitt so she can get some sleep?10:38
*** macz_ has quit IRC10:38
lyarwood:)10:38
melwittD:10:38
lyarwoodonly joking10:38
lyarwoodbut seriously get some sleep :D10:38
melwittI know, that was my OMG I CANT BELIEVE YOU SAID THAT look10:38
melwitt:)10:38
* melwitt jokes without skill10:39
*** zzzeek has quit IRC10:39
melwittok, gnight for reals10:39
lyarwoodhehe twas a good one :)10:39
lyarwood\o10:39
*** ociuhandu has joined #openstack-nova10:40
*** zzzeek has joined #openstack-nova10:41
*** mkrai has quit IRC10:42
*** k_mouza has quit IRC10:46
elodlyarwood: will the two patch work separately? Don't they need to be squashed to fix every issue? (or will the .zuul.yaml change only run limited tests that could pass? O.o)10:48
*** k_mouza has joined #openstack-nova10:48
* lyarwood gulps coffee10:49
lyarwoodelod: yup I'm an idiot10:49
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4  https://review.opendev.org/c/openstack/nova/+/76574910:51
elodlyarwood: I'm not sure, just asking10:51
lyarwoodelod: no no you are right, lower-constraints would fail in the standalone change10:52
lyarwoodelod: so I've squashed it into the fix for that job10:52
lyarwoodelod: and once we have a fix for the multi-cell job we should enable it again in that change10:53
lyarwoodelod: the only other way of fixing this would be to squash both fixes into one change10:53
lyarwoodelod: that I'm not a fan of tbh10:54
*** ociuhandu has quit IRC10:54
elodlyarwood: ok, good, thx!10:55
*** rcernin has joined #openstack-nova10:57
*** adrian-a has joined #openstack-nova11:08
*** hamalq has joined #openstack-nova11:09
*** links has joined #openstack-nova11:12
*** hamalq has quit IRC11:14
*** jangutter has joined #openstack-nova11:28
*** jangutter_ has quit IRC11:32
*** dtantsur|afk is now known as dtantsur11:33
openstackgerritLucian Petrut proposed openstack/nova master: Fix unshelved image ref  https://review.opendev.org/c/openstack/nova/+/76592411:40
*** larainema has quit IRC11:44
*** tbachman has quit IRC11:55
* gibi is back11:57
openstackgerritLee Yarwood proposed openstack/nova-specs master: DNM/WIP Remove device from attach_volume request response  https://review.opendev.org/c/openstack/nova-specs/+/76509711:58
gibilyarwood: I will start looking into the qos failure on the master as melwitt said we propably hit that on stable after we fix the context targeting issue12:00
*** JamesBenson has joined #openstack-nova12:00
gibihm, first, I will confirm that the stable failure after the context targeting fix is the same as the master failure12:01
*** ociuhandu has joined #openstack-nova12:02
*** ociuhandu has quit IRC12:03
*** ociuhandu has joined #openstack-nova12:03
*** JamesBenson has quit IRC12:06
*** JamesBenson has joined #openstack-nova12:06
*** ratailor has quit IRC12:08
*** larainema has joined #openstack-nova12:12
gibiOK, I confirm that after https://review.opendev.org/c/openstack/nova/+/766364 on stable we hit the same issue as visible on msater12:12
gibimaster12:12
gibiso on master we need to fix https://bugs.launchpad.net/nova/+bug/1907522 and then backport the fix to stable on top of https://review.opendev.org/c/openstack/nova/+/766364 which is only needed on stable12:13
openstackLaunchpad bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [Undecided,New]12:13
*** rcernin has quit IRC12:13
gibithis will be fun12:13
*** zzzeek has quit IRC12:14
*** zzzeek has joined #openstack-nova12:17
*** ociuhandu has quit IRC12:23
*** hamalq has joined #openstack-nova12:28
*** ociuhandu has joined #openstack-nova12:31
*** hamalq has quit IRC12:33
*** mkrai has joined #openstack-nova12:36
*** zzzeek has quit IRC12:40
*** zzzeek has joined #openstack-nova12:41
*** raildo has joined #openstack-nova12:42
*** ociuhandu has quit IRC12:55
*** dave-mccowan has joined #openstack-nova12:56
*** adrian-a has quit IRC12:57
gibilyarwood, melwitt : I'm affraid that we missed the qos support for cross cell resize. I think qos and cross cell work was done in parallel.13:00
*** adrian-a has joined #openstack-nova13:00
gibias the migration uses different conductor tasks and ComputeManager methods we simply missing the qos code from the cross cell path13:00
*** adrian-a has quit IRC13:01
*** adrian-a has joined #openstack-nova13:01
*** ociuhandu has joined #openstack-nova13:05
openstackgerritIlles Elod proposed openstack/nova stable/train: DNM: tox constraints test  https://review.opendev.org/c/openstack/nova/+/76646313:07
*** teoobo_ has quit IRC13:08
*** hemanth_n has quit IRC13:09
*** priteau has joined #openstack-nova13:11
*** ociuhandu has quit IRC13:15
*** hemna has quit IRC13:28
*** slaweq has quit IRC13:29
*** hemna has joined #openstack-nova13:31
*** k_mouza_ has joined #openstack-nova13:33
*** k_mouza has quit IRC13:33
*** teoobo_ has joined #openstack-nova13:33
*** slaweq has joined #openstack-nova13:33
openstackgerritBalazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job  https://review.opendev.org/c/openstack/nova/+/76647113:38
gibilyarwood, melwitt: ^^ this is my way forward on the master and this needs to be backported to stable13:38
bauzasI agree13:44
bauzaswe need to revert the tests13:44
openstackgerritBalazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job  https://review.opendev.org/c/openstack/nova/+/76647113:44
gibibauzas: the test works fine with same cell resize so I would not revert the whole test13:45
bauzasyeah, by reverting, I meant disabling the faulty ones13:47
bauzasnot the whole patch13:47
bauzasanyway +2d with comments13:47
gibilet me quicly fix those nits13:49
*** teoobo_ has quit IRC13:49
*** _erlon_ has joined #openstack-nova13:50
*** ociuhandu has joined #openstack-nova13:52
*** zigo has joined #openstack-nova13:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job  https://review.opendev.org/c/openstack/nova/+/76647113:52
gibibauzas: ^^13:53
*** tbachman has joined #openstack-nova13:53
bauzasack13:54
*** nweinber has joined #openstack-nova13:56
*** sapd1 has joined #openstack-nova13:59
*** sapd1 has quit IRC14:00
*** sapd1 has joined #openstack-nova14:01
elodlyarwood: I think the bandit patch needs to be merged starting from pike, and then to newer branches, branch by branch... due to grenade job. (which would be unnecessary if bandit 1.6.3 was yanked, but that might not happen soon...)14:05
*** mkrai has quit IRC14:06
*** ociuhandu has quit IRC14:06
*** mkrai has joined #openstack-nova14:07
elodlyarwood: also, I'm experimenting with the 'general' lower-constraint fix ( https://review.opendev.org/q/topic:"constrain-tox-install" ) but it might be better to try to fix the lower-constraints.txt instead, if it does not bring up infinite package version bumps there...14:08
*** ociuhandu has joined #openstack-nova14:09
openstackgerritBalazs Gibizer proposed openstack/nova stable/victoria: Disable qos resize tempest test for nova-multi-cell job  https://review.opendev.org/c/openstack/nova/+/76647414:10
*** ociuhandu has quit IRC14:13
*** ociuhandu has joined #openstack-nova14:15
*** adrian-a has quit IRC14:17
*** teoobo_ has joined #openstack-nova14:19
*** ociuhandu has quit IRC14:19
*** adrian-a has joined #openstack-nova14:21
gibielod: lyarwood: now I two possible way forward for stable. a) disable nova-multi-cell job b) disable the qos tests in the nova-multi-cell job14:23
lyarwoodhey sorry just back from lunch14:24
lyarwoodelod: ack I can work my way forwards from pike if it's going to be easier14:25
lyarwoodgibi: https://review.opendev.org/c/openstack/nova/+/765749 is alreadying in the gate for victoria14:25
lyarwoodgibi: making the entire job non-voting14:25
gibilyarwood: OK to merge that. Then to re-enable the job we need https://review.opendev.org/c/openstack/nova/+/76647414:26
gibithen the question what to do https://review.opendev.org/c/openstack/nova/+/766364/14:27
*** psachin has quit IRC14:28
*** ociuhandu has joined #openstack-nova14:28
*** hamalq has joined #openstack-nova14:29
lyarwoodgibi: https://review.opendev.org/c/openstack/nova/+/765749 isn't actually in the gate yet so we could yank it out now14:29
elodlyarwood: I've just checked that there's no lower-constraint job @ pike, so bandit patch could be merged easier (fingers crossed) :]14:29
gibilyarwood: keep it as it is closer to merge14:30
lyarwoodelod: cool, I'll try to make a start shortly14:30
lyarwoodgibi: kk14:30
gibilyarwood: then I will try to reenable the gate with https://review.opendev.org/c/openstack/nova/+/76647414:30
gibiregarding https://review.opendev.org/c/openstack/nova/+/766364/ I have to figure out if we need this to avoid leaking something instead of clearly rolling back the migration14:31
*** hamalq_ has joined #openstack-nova14:32
*** hamalq has quit IRC14:34
*** hamalq_ has quit IRC14:36
*** k_mouza_ has quit IRC14:38
*** tobberydberg has quit IRC14:38
*** k_mouza has joined #openstack-nova14:39
*** tobberydberg has joined #openstack-nova14:39
gmannbrinzhang: ah that is good question, I do not think we need to do any improvement on deprecated APIs. We have not done any update on deprecated API in past too. policy changes were on policy side only so we thought of keeping consistency. But I will discuss it in today meeting to get more opinion.14:40
elodlyarwood: btw, if you are busy, I can do the bandit backports till pike14:41
elodjust let me know :)14:42
lyarwoodelod: if you have time then please go ahead and I can review14:44
gmannbrinzhang: but server sec group is not deprecated API -https://docs.openstack.org/api-ref/compute/?expanded=list-security-groups-by-server-detail#servers-security-groups-servers-os-security-groups14:44
elodlyarwood: ok, doing it now14:45
gmannbrinzhang: ah just saw that we did mention about not to change deprecated APIs for tenant-id - https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/remove-tenant-id.html14:45
gmannbrinzhang: so we are good on that and let's target only non-deprecated APIs only14:46
gmannbrinzhang: also our all deprecated APIs are capped with corresponding microversion and they are 404 for higher than deprecated microversion so technically we cannot do any change in those API which include the microversion bump.14:49
openstackgerritIlles Elod proposed openstack/nova stable/stein: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76648714:49
*** k_mouza has quit IRC14:52
*** k_mouza has joined #openstack-nova14:56
*** ociuhandu has quit IRC14:57
openstackgerritIlles Elod proposed openstack/nova stable/stein: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76648715:00
openstackgerritIlles Elod proposed openstack/nova stable/rocky: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76649215:03
*** links has quit IRC15:04
*** ociuhandu has joined #openstack-nova15:05
*** ociuhandu has quit IRC15:10
lyarwoodelod: Bernard just replied on the ML about the cross project issue with the bandit cap15:11
*** ociuhandu has joined #openstack-nova15:11
lyarwoodelod: and thinking about it more an overall cap in requirements might be the only way to unblock things here15:11
*** songwenping_ has quit IRC15:11
lyarwoodelod: but landing from stable/pike as you suggested for the project specific changes15:11
lyarwoodelod: so grenade works etc15:11
*** songwenping_ has joined #openstack-nova15:12
lyarwood`ERROR Failed to update project None in 3s` oh cool a new zuul error15:12
openstackgerritIlles Elod proposed openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76649715:13
lyarwoodhttps://github.com/PyCQA/bandit/issues/663 that said it looks like they might yank 1.6.3 after all15:14
*** ociuhandu has quit IRC15:15
*** ociuhandu has joined #openstack-nova15:20
gibilyarwood: this is not the first time I saw that zuul ERROR15:23
*** k_mouza has quit IRC15:24
gibilyarwood: at the previous time it was around a gerrit restart so I assmue that caused it15:24
lyarwoodah kk15:24
bauzasergh, call me stupid15:24
bauzasrequested_networks can be None15:25
* bauzas hides15:25
gibilyarwood: pinged infra about it15:26
*** dklyle has joined #openstack-nova15:27
lyarwoodgibi: ah thanks, I was just going to recheck tbh15:28
gibilyarwood: sure,15:28
gibilyarwood: infra increased some git cloning timeouts in the zuul executors15:29
gibirecently15:29
gibithey expect that it helps15:30
elodlyarwood: if they would yank bandit 1.6.3 that would be the best :)15:35
elodlyarwood: until that, let's see if we can merge the bandit cap patches, as it might take some time15:35
lyarwoodelod: ack lets keep trying15:36
lyarwoodelod: I'm just worried that we will need to land multiple caps across multiple projects to allow the gate to work again15:36
elodlyarwood: yes, that's possible :S15:37
*** k_mouza has joined #openstack-nova15:49
*** sapd1 has quit IRC15:52
*** adrian-a has quit IRC15:57
*** lpetrut has quit IRC15:57
*** links has joined #openstack-nova16:00
*** sapd1 has joined #openstack-nova16:01
*** macz_ has joined #openstack-nova16:01
*** sapd1 has quit IRC16:07
*** mkrai has quit IRC16:26
*** hamalq has joined #openstack-nova16:30
*** ociuhandu has quit IRC16:31
*** teoobo_ has left #openstack-nova16:31
*** k_mouza has quit IRC16:33
*** k_mouza has joined #openstack-nova16:35
*** ociuhandu has joined #openstack-nova16:36
*** songwenping__ has joined #openstack-nova16:46
*** ociuhandu has quit IRC16:48
*** songwenping_ has quit IRC16:48
*** ociuhandu has joined #openstack-nova16:53
*** ociuhandu_ has joined #openstack-nova16:59
gibilyarwood, melwitt: I rechecked https://review.opendev.org/c/openstack/nova/+/766471 (master unblock patch) as it bounced due to zuul " ERROR Failed to update project None in"17:00
gibiI have to leave in ~15 minutes so I hope melwitt can take over rechecking it if needed17:01
*** ociuhandu has quit IRC17:03
*** links has quit IRC17:09
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM  https://review.opendev.org/c/openstack/nova/+/76650917:12
openstackgerritBalazs Gibizer proposed openstack/nova stable/victoria: DNM  https://review.opendev.org/c/openstack/nova/+/76651117:13
lyarwoodgibi: ack thanks I'll also be around for a while to recheck when required17:15
gibilyarwood: thanks I will check back too before I go to sleep but now dinner time17:16
gibio/17:16
gibilyarwood: ahh, it is already got errors from zuul on https://zuul.opendev.org/t/openstack/status17:17
gibi:/17:17
gibiso I think we have to wait for infra17:17
*** adrian-a has joined #openstack-nova17:19
lyarwoodack np enjoy dinner \o17:22
bauzassean-k-mooney: around ?17:29
bauzassean-k-mooney: I found why my functest is not working, I need to mock the neutron extension for segments17:29
sean-k-mooneybauzas: ah yes you do17:30
sean-k-mooneyi think i have an example of that17:30
sean-k-mooneyin one of teh regression test i wrote17:30
sean-k-mooneybauzas: https://github.com/openstack/nova/commit/71bc6fc9b89535679252ffe5a737eddad60e4102#diff-4763b3c03cb51e2efd60e19a11af59d4bfb76fbca93c953dfd9201eb5187ee8817:32
sean-k-mooneybauzas: you can just do https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1888395.py#L38-L5517:33
*** dave-mccowan has quit IRC17:33
sean-k-mooneybauzas: you could also update the fixture17:33
*** hamalq has quit IRC17:34
sean-k-mooneybauzas: but im not sure we want it there by default17:34
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1891-L190517:35
sean-k-mooneypersonally i would not add it there since most deployment wont have it and just add it in your test class17:35
bauzasack thanks17:35
bauzassorry I had to drop because of an Amazon delivery for my new headset \o/17:36
sean-k-mooneyoh nice17:36
* bauzas will test the Plantronics RIG800HS for tomorrow's meeting :)17:37
JamesBensonsean-k-mooney: originally I had tried `custom` and posted `cpu_models = nehalem,westmere` & `cpu_model_extra_flags = pcid, vmx, pdpe1gb`  but then I couldn't boot up VM's. Those three flags are the ones of interest, but aren't in both models.  I thought that the way mentioned above was the right way, but couldn't get it working. Maybe the flags need to be there for all of them?17:38
*** ociuhandu_ has quit IRC17:42
sean-k-mooneyJamesBenson: that should be valid17:45
sean-k-mooneypdep1GB is for 1G hugepages17:45
sean-k-mooneynehalem does not actully support that if i remeber correctly17:45
sean-k-mooneyyou need host supprot to use it17:46
JamesBensoncorrect, nehalem doesn't support any of those three.17:46
JamesBensonbut westmere does17:46
sean-k-mooneywel it support vmx17:46
sean-k-mooneynot in the model defieniotn but in the cpu17:46
sean-k-mooneywehn using multiple models the flags must be valid for all models in the list17:47
sean-k-mooneyon your westmer host that should work17:47
JamesBensonah, okay, so that's the trick then.  And just verifying, to check for the flags, I just issued `cat /proc/cpuinfo`17:48
sean-k-mooneybut on your nehalem host it will fail17:48
JamesBensonlet me double check the flags on my hosts.17:48
sean-k-mooneyyep cat /proc/cpuinfo or use lscpu17:48
sean-k-mooneyfor vmx you need to enable nested virt too in the hosts kernel17:49
JamesBensonokay, yeah only vmx on the nehalem, westmere has all three.17:50
sean-k-mooney cat /sys/module/kvm_intel/parameters/nested17:50
sean-k-mooneyY17:50
JamesBensonjust change that to Y?17:50
sean-k-mooneyY or 117:50
sean-k-mooneythat is showing the current nested virt status17:51
sean-k-mooneyif that is N or 0 then you dont have it enabled17:51
JamesBensonokay, cool.  So which is better: cpu_models = nehalem,westmere with the vmx flag or host-model?  Or should I get a list of flags that are on both and put all of the flags in there?17:51
JamesBensonIt is an `N`17:52
JamesBensonThanks for the help & insight be the way. Super helpful :-)17:52
sean-k-mooneyya so you need to drop a file into /etc/modeprobe.d17:52
sean-k-mooneywhat i would do is as follows17:53
sean-k-mooneyon the nehelm host set cpu_models = nehalem and cpu_model_extra_flags = vmx17:54
*** ociuhandu has joined #openstack-nova17:54
sean-k-mooneyon the westmear host do cpu_model_extra_flags = pcid, vmx, pdpe1gb cpu_models = nehalem,westmere17:54
sean-k-mooneyin the flavor then add a required trait for pdep1gb on flavor that use 1G hugepages17:55
sean-k-mooneyJamesBenson: the feature flags are reported as traits to placement so you can express what you need in both the flavor and image17:56
JamesBensonokay.  Is this the recommended path for mixed architectures to get the most out of them?17:56
JamesBensongreat, we have windows VM's so that's what I'm hoping to speed up with using those flags.17:56
*** raildo has quit IRC17:57
sean-k-mooneynormaly you would use something like host aggreates. PCID should acclerate gust where you have mitigation enabled somewhat17:57
*** raildo has joined #openstack-nova17:58
sean-k-mooneyvmx is only useful if those windows instnace have hyperv or are using docker with linux instance17:58
*** ociuhandu has quit IRC17:58
*** tesseract has quit IRC17:58
sean-k-mooneyon host without pdep1gb you can still use 2MB hugepages17:59
sean-k-mooneyso that is what i advise on nehelem17:59
sean-k-mooneyJamesBenson: http://paste.openstack.org/show/800947/18:01
*** derekh has quit IRC18:01
sean-k-mooneyyou shoudl have a file that looks like that or you can create one18:01
sean-k-mooneyoptions kvm_intel nested=1 is what you need to uncomment unless you have a kernel newwer then 4.1918:01
sean-k-mooneyin which case its the default value18:01
sean-k-mooneyalthough your proably want a kernel newer then 5.1 unless it has backports18:02
JamesBensonfreshly deployed ubuntu 18.04 with 4.15.018:02
sean-k-mooneyi would sugges using the 5.3 or 5.4 kernel they provide form focal instead18:03
sean-k-mooneyits the hwe kernel18:03
*** hamalq has joined #openstack-nova18:03
sean-k-mooneyhttps://wiki.ubuntu.com/Kernel/LTSEnablementStack18:03
*** rpittau is now known as rpittau|afk18:04
JamesBensonokay :-)18:05
sean-k-mooneyout of interst is tehre a reason you are not usin g2.0418:05
sean-k-mooney*20.0418:05
sean-k-mooneyif its a fresh install18:05
JamesBensonkolla doesn't support it I think fully18:06
JamesBensonThat's my deployment method.18:06
sean-k-mooneyyep i use kolla too. althouhg im currentoy using centos kind of18:07
*** hamalq_ has joined #openstack-nova18:07
sean-k-mooneyJamesBenson: depending on the release they have different levels of supprot for 20.0418:07
JamesBensonyeah, I'm on ussuri, I thought victoria was the first one to support 20 fully.18:08
sean-k-mooneyJamesBenson: yes it is18:09
sean-k-mooneyJamesBenson: i guess they have not had there offical release yet technically18:09
JamesBensonah, well, then I can definitely try that out.  We do it all, including the OS deploy, in a CI/CD environment, so easy enough ;-)18:09
JamesBensonyeah, not yet, soon I think18:10
*** hamalq has quit IRC18:10
JamesBensonbut for victoria, we do plan on pushing to ubuntu 20.0418:10
JamesBensonbut I'll see about bumping the kernel, I've just been using what it deploys with, having tried to get it to a newer version.18:10
sean-k-mooneythe nested virt support signifcantly improve after kernel 4.19 so if you use it i always recommend having 4.19 and preferbly 5.1+ as you min kernel18:11
sean-k-mooneyJamesBenson: the hwe kernel works well for nested virt without needing the  os bump18:12
sean-k-mooneyits 5.3 i belive18:12
JamesBensoncool, have you ever tried low-latency kernels in openstack?18:12
sean-k-mooneyi have but my experice was tainted. i deployed with the low-latency kernel but i later found out that my system hangs which i attibuted to it was due to 3 failing dimms18:13
gansoelod, bauzas, lyarwood: Hi! do you think those patches could be allowed to be backported from rocky to queens: https://review.opendev.org/c/openstack/nova/+/580720 and https://review.opendev.org/c/openstack/nova/+/583715 ?18:13
sean-k-mooneyJamesBenson: so i have not really looked at it fairly.18:14
sean-k-mooneyJamesBenson: my deployemtn is just my home test/dev cloud so its currently runing the mainline 5.9 kernel18:14
sean-k-mooneyi was hoping to move to the 5.10 upstream lts and do a ussuri to victoria upgrade over the holiday break but that is still tbd18:15
JamesBensonokay, looks like linux-lowlatency-hwe-18.04 is 5.4.0.53.5918:15
JamesBensonso maybe I'll try that out :-)18:15
sean-k-mooneycool with that you wont need t o set the modeprobe paramter eitehr since its enabel by default18:17
gansoelod, bauzas, lyarwood, nevermind I kind of got the answer myself by cherry-picking and seeing that queens is missing 2 other RequestSpec updates18:17
sean-k-mooneyganso: we cant backport modifcation to any nova objects18:17
gansosean-k-mooney: thanks!18:18
sean-k-mooneyganso: well we cant backport new fields18:18
sean-k-mooneywe can backport change that dont modify the serialsed format18:18
sean-k-mooneyganso: you wanted this in queens18:20
gansosean-k-mooney: yes, in queens18:20
gansosean-k-mooney: since the fix requires the new field, we wouldn't be able to adapt it to queens, as I understand18:20
sean-k-mooneythat is correct unfortunetly however we coudl do something else possibly18:22
sean-k-mooneyif the places that need is_bfv hae a context and instnace tehy could use  is_volume_backed_instance(ctxt, instance) instead directly18:22
*** jangutter_ has joined #openstack-nova18:23
gansosean-k-mooney: hmmm I will investigate this in the code. Thanks! Although, I'm aware it would make the backport with new code with extra risk, and then the stable maintainers may disagree with merging it18:24
sean-k-mooneyyes you would basically have to modeify https://review.opendev.org/c/openstack/nova/+/580720/6/nova/scheduler/utils.py18:24
sean-k-mooneyunfortunetly that does not have th instance or a keystone context18:25
gansooh I see18:25
gansoyea, bummer18:25
gansothanks again sean-k-mooney ! =)18:25
*** jangutter has quit IRC18:26
*** CeeMac has joined #openstack-nova18:34
*** jangutter_ has quit IRC18:40
*** dtantsur is now known as dtantsur|afk18:40
*** jangutter has joined #openstack-nova18:41
*** k_mouza has quit IRC18:48
*** efried1 has joined #openstack-nova19:13
*** efried has quit IRC19:15
*** efried1 is now known as efried19:15
*** adrian-a has quit IRC19:20
*** adrian-a has joined #openstack-nova19:24
melwittgibi, lyarwood: yes I can take over babysitting those patches once yall are gone19:44
*** xek_ has quit IRC19:49
*** xek has joined #openstack-nova20:04
*** andrewbonney has quit IRC20:05
*** jangutter has quit IRC20:05
*** martinkennelly has quit IRC20:06
*** jangutter has joined #openstack-nova20:06
*** tbachman has quit IRC20:09
openstackgerritLance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers  https://review.opendev.org/c/openstack/placement/+/76024020:10
*** martinkennelly has joined #openstack-nova20:10
*** martinkennelly has quit IRC20:19
*** rcernin has joined #openstack-nova20:21
*** nweinber has quit IRC20:26
*** martinkennelly has joined #openstack-nova20:27
*** nweinber has joined #openstack-nova20:47
*** xek has quit IRC20:50
*** xek has joined #openstack-nova20:54
*** slaweq has quit IRC21:16
JamesBensonsean-k-mooney, one follow up question.  Is there a setting (or benefit) to passing all of the CPU flags in the nova.conf?21:21
*** songwenping_ has joined #openstack-nova21:28
*** songwenping__ has quit IRC21:31
*** rcernin has quit IRC21:31
*** rcernin has joined #openstack-nova21:34
*** eharney has quit IRC21:38
*** ociuhandu has joined #openstack-nova21:40
lyarwoodelod: https://review.opendev.org/q/I8f24b839bf42e2fb9803dc7df3a30ae20cf264eb lets see what that breaks21:50
lyarwoodmelwitt: ack sorry had already gone, just wanted to check on the bandit thing and it looks like we might be able to get away with backporting the above to workaround it21:50
*** xek has quit IRC21:51
*** rcernin has quit IRC21:51
melwittlyarwood: is there a bug link for the bandit thing? sorry I fell too far behind with knowing what was going on there21:53
*** rcernin has joined #openstack-nova21:53
lyarwoodmelwitt: http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019292.html and https://bugs.launchpad.net/nova/+bug/190743821:55
openstackLaunchpad bug 1907438 in OpenStack Object Storage (swift) "ERROR: Package 'bandit' requires a different Python: 2.7.17 not in '>=3.5'" [Undecided,Confirmed]21:55
melwittah thanks21:55
melwittI don't know how I missed that on the ML21:55
lyarwoodthere's so many fires at the moment, I wouldn't worry about it :)21:56
melwittyou can say that again21:56
lyarwoodthere's so many fires at the moment, I wouldn't worry about it :)21:56
* lyarwood shows himself out21:56
melwittlast night I almost tweeted "openstack ci right now is" with a mushroom cloud gif21:56
melwitthah xD21:56
melwittor the gif of elmo with the fire behind him21:57
*** nweinber has quit IRC21:58
lyarwoodhehe yeah both would still work right now :D21:59
lyarwoodah cool the stable/victoria LC change made it to the gate22:00
melwitthot dog!22:00
*** eharney has joined #openstack-nova22:02
melwittlyarwood: hm something I don't get though is how the LC change is having nova-multi-cell as non-voting if the disable voting change isn't in the gate?22:06
lyarwoodmelwitt: different branches, I wrote the LC change switching nova-multi-cell to non-voting before gibi pushed his master change22:08
lyarwoodmelwitt: I was going to pull it out and backport squash his into the stable/victoria LC fix but he said to just go on with the non-voting change22:09
lyarwoodmelwitt: either way it's only to allow the LC change to land in stable/victoria, we will need to follow up once it's in22:10
melwittlyarwood: yeah but https://review.opendev.org/c/openstack/nova/+/766440 isn't approved? maybe I'm just missing something dumb22:10
lyarwoodmelwitt: oh I need to close that, I squashed that into the actual LC change, that's an old PS that isn't used anymore22:11
melwittoh you squashed it. sorry /facepalm22:11
melwittyeah I see now. guhhhhh22:11
lyarwoodyeah sorry I've got dead changes all over the place from the last few days22:11
melwittno it's not your fault that I can't see things :)22:11
melwittok, so iiuc we'll do this and then after gibi's change lands, we need to backport it to stable/victoria, then we re-enable voting22:12
*** mlavalle has joined #openstack-nova22:13
lyarwoodyeah I think so22:14
lyarwoodokay bed time for me now, good luck with the gate :D22:14
*** bbowen has quit IRC22:15
melwittok cool, gnight o/22:15
melwittargh nova-ceph-multistore failed in the gate queue. of course it did22:17
*** adrian-a has quit IRC22:38
*** martinkennelly has quit IRC22:48
*** ociuhandu has quit IRC22:59
*** efried has quit IRC23:04
*** bbowen has joined #openstack-nova23:37
*** tosky has quit IRC23:53

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!