| *** spatel has quit IRC | 00:01 | |
| *** JamesBenson has joined #openstack-nova | 00:04 | |
| *** luksky has quit IRC | 00:04 | |
| *** JamesBenson has quit IRC | 00:08 | |
| *** zzzeek has quit IRC | 00:12 | |
| *** zzzeek has joined #openstack-nova | 00:16 | |
| *** tosky has quit IRC | 00:20 | |
| *** ociuhandu has joined #openstack-nova | 00:22 | |
| *** ociuhandu has quit IRC | 00:26 | |
| *** JamesBenson has joined #openstack-nova | 00:36 | |
| *** JamesBenson has quit IRC | 00:40 | |
| *** jamesdenton has quit IRC | 00:48 | |
| *** jamesden_ has joined #openstack-nova | 00:49 | |
| *** LinPeiWen15 has joined #openstack-nova | 00:49 | |
| *** brinzhang has joined #openstack-nova | 00:54 | |
| *** LinPeiWen15 has quit IRC | 01:13 | |
| *** LinPeiWen has joined #openstack-nova | 01:15 | |
| *** ociuhandu has joined #openstack-nova | 02:10 | |
| *** ociuhandu has quit IRC | 02:15 | |
| *** sapd1 has joined #openstack-nova | 02:38 | |
| *** JamesBenson has joined #openstack-nova | 03:12 | |
| *** JamesBenson has quit IRC | 03:17 | |
| *** ociuhandu has joined #openstack-nova | 03:24 | |
| *** ociuhandu has quit IRC | 03:29 | |
| *** spatel has joined #openstack-nova | 03:29 | |
| *** spatel has quit IRC | 03:32 | |
| *** chengsheng1 has joined #openstack-nova | 03:33 | |
| *** chengsheng1 is now known as chengsheng | 03:33 | |
| *** vesper11 has quit IRC | 03:34 | |
| *** vesper11 has joined #openstack-nova | 03:35 | |
| chengsheng | Originally, the code I submitted passed zuul. Today I rechecked and found that the unit test reported a lot of failures. I checked the log and found that the unit test code was different from the patch I submitted. I am a newbie and want to know what is going on. | 03:40 |
|---|---|---|
| *** JamesBenson has joined #openstack-nova | 03:51 | |
| *** JamesBenson has quit IRC | 03:55 | |
| *** ratailor has joined #openstack-nova | 04:24 | |
| *** jamesden_ has quit IRC | 04:34 | |
| *** jamesdenton has joined #openstack-nova | 04:35 | |
| *** vesper has joined #openstack-nova | 04:36 | |
| *** vesper11 has quit IRC | 04:37 | |
| *** whoami-rajat__ has joined #openstack-nova | 04:44 | |
| *** bbowen has quit IRC | 05:01 | |
| *** bbowen has joined #openstack-nova | 05:02 | |
| *** ociuhandu has joined #openstack-nova | 05:12 | |
| *** ociuhandu has quit IRC | 05:17 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-nova | 05:33 | |
| *** sapd1 has quit IRC | 05:45 | |
| *** mkrai has joined #openstack-nova | 06:04 | |
| *** vishalmanchanda has joined #openstack-nova | 06:15 | |
| *** sapd1 has joined #openstack-nova | 06:19 | |
| *** mkrai has quit IRC | 06:27 | |
| *** mkrai has joined #openstack-nova | 06:28 | |
| *** mkrai has quit IRC | 06:46 | |
| *** sapd1 has quit IRC | 06:51 | |
| *** chengsheng has quit IRC | 06:52 | |
| *** HagunKim has joined #openstack-nova | 06:56 | |
| *** fnordahl has quit IRC | 06:58 | |
| *** ociuhandu has joined #openstack-nova | 07:01 | |
| openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | 07:05 |
| *** ociuhandu has quit IRC | 07:07 | |
| *** LinPeiWen has quit IRC | 07:15 | |
| *** ociuhandu has joined #openstack-nova | 07:21 | |
| *** ociuhandu has quit IRC | 07:28 | |
| *** ircuser-1 has joined #openstack-nova | 07:33 | |
| *** luksky has joined #openstack-nova | 07:40 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 07:47 |
| *** LinPeiWen has joined #openstack-nova | 07:50 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 07:53 |
| *** rcernin has quit IRC | 07:55 | |
| *** rcernin has joined #openstack-nova | 08:25 | |
| *** tesseract has joined #openstack-nova | 08:28 | |
| *** andrewbonney has joined #openstack-nova | 08:28 | |
| *** rcernin has quit IRC | 08:30 | |
| *** tbachman_ has joined #openstack-nova | 08:34 | |
| *** tbachman has quit IRC | 08:36 | |
| *** tbachman_ is now known as tbachman | 08:36 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110 | 08:42 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111 | 08:43 |
| *** lpetrut has joined #openstack-nova | 08:44 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614 | 08:45 |
| *** rpittau|afk is now known as rpittau | 08:46 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/c/openstack/nova/+/756530 | 08:46 |
| *** ociuhandu has joined #openstack-nova | 08:53 | |
| *** ociuhandu has quit IRC | 08:53 | |
| *** derekh has joined #openstack-nova | 09:04 | |
| *** HagunKim has quit IRC | 09:05 | |
| *** hemanth_n has joined #openstack-nova | 09:09 | |
| *** ociuhandu has joined #openstack-nova | 09:15 | |
| *** xek_ has joined #openstack-nova | 09:17 | |
| *** zzzeek has quit IRC | 09:19 | |
| *** zzzeek has joined #openstack-nova | 09:20 | |
| *** mgoddard has joined #openstack-nova | 09:20 | |
| *** rcernin has joined #openstack-nova | 09:25 | |
| *** ociuhandu has quit IRC | 09:28 | |
| *** rcernin has quit IRC | 09:30 | |
| openstackgerrit | Wenping Song proposed openstack/nova-specs master: libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | 09:30 |
| kashyap | chengsheng: Do you mean the unit test failure is unrelated to your patch? If so, sometimes the CI hits issues that are not your fault | 09:35 |
| lyarwood | \o morning all | 09:35 |
| * lyarwood starts to catch up | 09:35 | |
| kashyap | chengsheng: If you can post the failure here, others might recognize it. Alternatively, there might be intermittent failures; so you try to type "recheck" (without quotes) in a comment in your change, and see if that helps. | 09:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765769 | 09:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765770 | 09:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 09:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765772 | 09:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765773 | 09:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765774 | 09:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: Add regression test for bug #1899649 https://review.opendev.org/c/openstack/nova/+/764611 | 09:43 |
| openstack | bug 1899649 in OpenStack Compute (nova) "Volume marked as available after a failure to build" [Undecided,In progress] https://launchpad.net/bugs/1899649 - Assigned to Lee Yarwood (lyarwood) | 09:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: compute: Don't detach volumes when RescheduledException raised without retry https://review.opendev.org/c/openstack/nova/+/764612 | 09:43 |
| *** sapd1 has joined #openstack-nova | 09:47 | |
| openstackgerrit | chengsheng proposed openstack/nova master: CPU selection with hypervisor consideration https://review.opendev.org/c/openstack/nova/+/762330 | 09:50 |
| *** sapd1 has quit IRC | 09:51 | |
| gibi | aarents: I have a question in https://review.opendev.org/c/openstack/nova/+/765561 | 09:54 |
| gibi | lyarwood: welcome back o/ | 09:55 |
| openstackgerrit | Aleksey Ulyanov proposed openstack/nova master: Fix graceful shutdown timeout https://review.opendev.org/c/openstack/nova/+/764927 | 10:00 |
| *** mkrai has joined #openstack-nova | 10:02 | |
| *** dtantsur|afk is now known as dtantsur | 10:07 | |
| *** sapd1 has joined #openstack-nova | 10:12 | |
| *** sapd1 has quit IRC | 10:16 | |
| *** rcernin has joined #openstack-nova | 10:21 | |
| *** rcernin has quit IRC | 10:21 | |
| aarents | Hi gibi lyarwood | 10:22 |
| aarents | gibi: I just replied | 10:22 |
| gibi | looking | 10:22 |
| gibi | aarents: so resize depends on image_base_image_ref being present in metadata and some instances doesn't have it as the previous fix only fixed it for new instances | 10:26 |
| gibi | Am I correct? | 10:26 |
| aarents | gibi: correct | 10:26 |
| gibi | then I think only the comment need a bit of rewording to state this | 10:27 |
| gibi | as from the bug link it was not totally clear | 10:27 |
| gibi | but your review answer cleared it | 10:28 |
| gibi | aarents: replied in the review, thanks for the clarification | 10:29 |
| *** ociuhandu has joined #openstack-nova | 10:30 | |
| *** mgoddard has quit IRC | 10:33 | |
| aarents | gibi: oky | 10:33 |
| aarents | lyarwood: thnsk I will address the nit | 10:33 |
| *** spatel has joined #openstack-nova | 10:35 | |
| *** spatel has quit IRC | 10:40 | |
| *** mkrai has quit IRC | 10:43 | |
| *** mgoddard has joined #openstack-nova | 10:43 | |
| *** jangutter has quit IRC | 10:43 | |
| *** jangutter has joined #openstack-nova | 10:44 | |
| *** mgoddard has quit IRC | 10:49 | |
| *** mgoddard has joined #openstack-nova | 10:49 | |
| *** teoobo_ has joined #openstack-nova | 10:51 | |
| *** mgoddard has quit IRC | 10:52 | |
| *** mgoddard has joined #openstack-nova | 10:52 | |
| *** mkrai has joined #openstack-nova | 10:53 | |
| *** sapd1 has joined #openstack-nova | 11:09 | |
| *** sapd1 has quit IRC | 11:14 | |
| *** tosky has joined #openstack-nova | 11:22 | |
| *** mkrai has quit IRC | 11:28 | |
| *** mkrai has joined #openstack-nova | 11:29 | |
| *** ratailor has quit IRC | 11:32 | |
| *** sapd1 has joined #openstack-nova | 11:33 | |
| *** ratailor has joined #openstack-nova | 11:33 | |
| *** sapd1 has quit IRC | 11:37 | |
| *** mkrai has quit IRC | 11:44 | |
| *** mkrai_ has joined #openstack-nova | 11:44 | |
| *** DinaBelova has quit IRC | 11:46 | |
| *** raildo has joined #openstack-nova | 11:48 | |
| *** tbachman has quit IRC | 11:49 | |
| *** DinaBelova has joined #openstack-nova | 11:51 | |
| *** mkrai_ has quit IRC | 11:58 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update modernize-os-hypervisors-api spec, pt. 2 https://review.opendev.org/c/openstack/nova-specs/+/765796 | 12:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update modernize-os-hypervisors-api spec, pt. 3 https://review.opendev.org/c/openstack/nova-specs/+/765797 | 12:03 |
| *** zzzeek has quit IRC | 12:03 | |
| *** zzzeek has joined #openstack-nova | 12:05 | |
| *** mkrai has joined #openstack-nova | 12:09 | |
| *** ociuhandu has quit IRC | 12:09 | |
| gibi | fyi I see this happening quite a lot recently on the gate https://bugs.launchpad.net/tempest/+bug/1907084 | 12:11 |
| openstack | Launchpad bug 1907084 in tempest "test_attach_scsi_disk_with_config_drive intermittently fails at detaching volume" [Undecided,New] | 12:11 |
| gibi | I think it is just a race condition in the test. So I will try to propose a re-query of the volume attachemnts in tempest | 12:11 |
| *** JamesBenson has joined #openstack-nova | 12:11 | |
| sean-k-mooney | gibi: well that or its realted to the race lyarwood was working around with the retry interval | 12:14 |
| gibi | sean-k-mooney: do you have a link for that? | 12:15 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/755799 was the workaround | 12:16 |
| sean-k-mooney | the fix is to use libvirt events | 12:17 |
| * lyarwood looks | 12:17 | |
| gibi | sean-k-mooney: ahh, could be related to the fact that now the race happens more than before as I guess we delayed the detach on the libvirt side | 12:18 |
| gibi | making the bdm.destroy even more delayed | 12:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_hypervisor_status' into 'test_hypervisors' https://review.opendev.org/c/openstack/nova/+/764039 | 12:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040 | 12:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors' https://review.opendev.org/c/openstack/nova/+/765798 | 12:18 |
| sean-k-mooney | well its load related, so 10 seconds was just a guess based on what we were seeing | 12:18 |
| sean-k-mooney | but a slighly slower node could still nit it | 12:19 |
| sean-k-mooney | it may be something else but it sounds related | 12:19 |
| lyarwood | gmann: ^ btw, smells like an issue with https://review.opendev.org/c/openstack/tempest/+/764407 | 12:21 |
| lyarwood | I don't think this is an issue with https://review.opendev.org/c/openstack/nova/+/755799 fwiw sean-k-mooney, at least at first glance | 12:22 |
| lyarwood | gmann: ignore that ping, the assertion is in the test itself, not cleanup. | 12:22 |
| sean-k-mooney | that test chagne merged 9 days ago, gibi are you still seeing it after that? | 12:23 |
| gibi | sean-k-mooney: yepp it is actively happening | 12:23 |
| gibi | logstash link is in the bugreport | 12:24 |
| gibi | but I now 70% confident that the cinder volume becomes available _befor_ nova deletes the BDM | 12:24 |
| gibi | so the tempest test is simply racing on this | 12:24 |
| lyarwood | that shouldn't be possible | 12:24 |
| gibi | lyarwood: I think this is the relevant code path https://github.com/openstack/nova/blob/97729aabaa7768e1af2fa4a0bdda0df7ad598426/nova/compute/manager.py#L7071-L7086 | 12:25 |
| gibi | the bdm.destory() is the last thing nova does during volume detach | 12:25 |
| lyarwood | gibi: right and that point we've already detached from the instance in libvirt and detached the volume from the instance via c-api | 12:26 |
| gibi | yepp | 12:26 |
| gibi | so there is a timewindow where the volume is available in cinder, but still has a BDM in nova | 12:27 |
| gibi | hence the nova volume attachment list will show the attachment | 12:27 |
| lyarwood | ah right | 12:27 |
| lyarwood | it's using servers_client | 12:27 |
| lyarwood | instead of volumes_client | 12:27 |
| lyarwood | so we could race the bdm.destroy in the db | 12:28 |
| sean-k-mooney | for what its worth that might also be an issue with shift on stack | 12:28 |
| sean-k-mooney | they were reporting similar behavior where the volumes were atached in nova but not in cinder | 12:28 |
| sean-k-mooney | although in there case i think that was a persitent state | 12:29 |
| sean-k-mooney | not just an interval where it was racy | 12:29 |
| gibi | sean-k-mooney: we will see if this is a persistent bug after I propose a re-query in the tempest test | 12:30 |
| gibi | if the re-query fails then we know we have a problem where the bdm is not deleted | 12:30 |
| lyarwood | gibi: the way to fix this is to add a waiter for volume attachments to the servers_clienty | 12:31 |
| lyarwood | client* | 12:31 |
| gibi | lyarwood: yes | 12:31 |
| sean-k-mooney | i prefer clienty | 12:31 |
| gibi | that is my plan | 12:31 |
| lyarwood | cool, let me know when you've posted a review and I'll happily review | 12:31 |
| sean-k-mooney | espcially the clinety thingy | 12:31 |
| gibi | sean-k-mooney: :) | 12:31 |
| gibi | lyarwood: ack | 12:31 |
| * lyarwood wonders why we are passing destroy_bdm into the driver bdm classes if it isn't actually used until the end of this method | 12:32 | |
| lyarwood | urgh | 12:33 |
| lyarwood | I see | 12:33 |
| *** zzzeek has quit IRC | 12:38 | |
| *** zzzeek has joined #openstack-nova | 12:39 | |
| *** priteau has quit IRC | 12:40 | |
| *** ociuhandu has joined #openstack-nova | 12:40 | |
| *** ociuhandu has quit IRC | 12:49 | |
| *** spatel has joined #openstack-nova | 12:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/765802 | 12:54 |
| lyarwood | ^ workaround for our downstream CI so we can use jobs and tox envs directly from upstream for a change | 12:54 |
| *** Luzi has joined #openstack-nova | 12:55 | |
| *** spatel has quit IRC | 12:57 | |
| sean-k-mooney | instead of just using sed to remove it | 13:02 |
| sean-k-mooney | that is cleaner then our current hack i guess | 13:03 |
| *** ociuhandu has joined #openstack-nova | 13:12 | |
| teoobo_ | gibi: I am working on this bug (https://bugs.launchpad.net/nova/+bug/1751784) but I cannot reproduce it in my devstack | 13:14 |
| openstack | Launchpad bug 1751784 in OpenStack Compute (nova) "Add more LOG.debug in nova.virt.hardware" [Wishlist,Confirmed] - Assigned to Matteo Sposato (teoobo) | 13:14 |
| teoobo_ | gibi: I have already filled out the form to request a mentor, but in the meantime I would like to continue working on it | 13:14 |
| *** mgariepy has quit IRC | 13:14 | |
| *** mgariepy has joined #openstack-nova | 13:19 | |
| *** ociuhandu has quit IRC | 13:20 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: [WIP] Migrate nova-grenade-multinode job to zuulv3 native https://review.opendev.org/c/openstack/nova/+/742056 | 13:21 |
| *** priteau has joined #openstack-nova | 13:27 | |
| gibi | teoobo_: on a call, I will get back to you in 30 minutes | 13:28 |
| *** tbachman has joined #openstack-nova | 13:29 | |
| *** hemanth_n has quit IRC | 13:31 | |
| *** bbowen has quit IRC | 13:33 | |
| *** bbowen has joined #openstack-nova | 13:33 | |
| lyarwood | `ERROR: No matching distribution found for packaging>=20.4` fun | 13:42 |
| *** CeeMac has joined #openstack-nova | 13:44 | |
| gibi | lyarwood: hm, pypi has packaging-20.4-py2.py3-none-any.whl | 13:50 |
| sean-k-mooney | ya i was checkin ghtat before i grabed coffee | 13:51 |
| sean-k-mooney | i would guess this is just an issue with the mirros | 13:51 |
| sean-k-mooney | stephenfin: by the way are we going to remove vcpu_pin_set and the fallback query this cycle? | 13:53 |
| sean-k-mooney | we deprecated them in train | 13:53 |
| sean-k-mooney | just trying to figure out if they will be present in 17 or not | 13:53 |
| *** ociuhandu has joined #openstack-nova | 13:53 | |
| *** ociuhandu has quit IRC | 13:53 | |
| lyarwood | gibi / sean-k-mooney ; yeah I've asked in #openstack-infra, I assume 20.6 being yanked has caused this | 13:54 |
| sean-k-mooney | we already dont support the deprecated option for new deployments downstream just for upgrades | 13:54 |
| *** ociuhandu has joined #openstack-nova | 13:54 | |
| lyarwood | as in we haven't sync'd the newer version yet | 13:54 |
| * lyarwood doesn't know how to query the mirror to check this however | 13:54 | |
| sean-k-mooney | lyarwood: well 20.5 and 20.7 should be valid | 13:54 |
| sean-k-mooney | lyarwood: they are not public mirrors as far as i know | 13:55 |
| sean-k-mooney | they are limited to the the ci vms | 13:55 |
| lyarwood | sean-k-mooney: yeah I assume we had 20.6 cached in the mirror | 13:55 |
| lyarwood | sean-k-mooney: that was then yanked | 13:55 |
| lyarwood | sean-k-mooney: and for some reason we don't have 20.5 or 20.7 now | 13:56 |
| sean-k-mooney | yep so normally we would jsut hop on the infra channel and ask the ci provier to check | 13:58 |
| sean-k-mooney | infra can also hold a vm and ssh in if needed i guess | 13:58 |
| *** ratailor has quit IRC | 14:00 | |
| lyarwood | cool cool | 14:00 |
| lyarwood | lets see what they say | 14:00 |
| *** ociuhandu has quit IRC | 14:04 | |
| *** ociuhandu_ has joined #openstack-nova | 14:04 | |
| gibi | teoobo_: when you say that you cannot reproduce what do you really mean? For me the bug is pretty generic: "This filter is difficult to troubleshoot because there are not much LOG.debug functions in nova.virt.hardware" | 14:05 |
| gibi | teoobo_: do you mean that since then we added plenty of debug logs and now it is clear why the NUMATopologyFilter fails when it fails? | 14:06 |
| teoobo_ | gibi: Yes, I mean that, but since I'm not a nova expert I'm not sure if my judgment is valid | 14:09 |
| gibi | teoobo_: it is nice to here that the filter is now better about logging. I think it would be nice to summarize your experience in the bug. Maybe an example about the logs now emitted helping the troubleshooting | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Image and flavor defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/752284 | 14:11 |
| teoobo_ | gibi: thanks for the advice | 14:14 |
| gibi | teoobo_: we could even close the bug with your comment and realy on other users still feeling bad about the logging to open a new one with a specific case when the logging is not enough | 14:15 |
| stephenfin | sean-k-mooney: I have draft patches written but I haven't decided what to do with the reshaper yet | 14:17 |
| *** ociuhandu_ has quit IRC | 14:19 | |
| *** owalsh has quit IRC | 14:19 | |
| mgariepy | lyarwood, do you have a few minutes to review the ussuri cpu feature backport please ? https://review.opendev.org/c/openstack/nova/+/758761 | 14:21 |
| *** k_mouza has joined #openstack-nova | 14:21 | |
| lyarwood | mgariepy: yeah I can take a look now | 14:21 |
| mgariepy | thanks | 14:21 |
| *** k_mouza has quit IRC | 14:22 | |
| *** k_mouza_ has joined #openstack-nova | 14:23 | |
| lyarwood | mgariepy: done, LGTM. | 14:24 |
| mgariepy | Thanks a lot :D | 14:25 |
| gibi | teoobo_: do you need some low hanging improvement that could be worked on? | 14:27 |
| gibi | teoobo_: I think there is a list of functional test improvement like this https://review.opendev.org/c/openstack/nova/+/758210 to be done | 14:27 |
| gibi | teoobo_: let me know if you are interested | 14:28 |
| *** ociuhandu has joined #openstack-nova | 14:34 | |
| *** artom has joined #openstack-nova | 14:37 | |
| *** Luzi has quit IRC | 14:38 | |
| gibi | lyarwood: tempest fix for the racy detach https://review.opendev.org/c/openstack/tempest/+/765814 | 14:40 |
| *** owalsh has joined #openstack-nova | 14:42 | |
| *** ociuhandu has quit IRC | 14:46 | |
| *** owalsh has quit IRC | 14:47 | |
| *** ociuhandu has joined #openstack-nova | 14:49 | |
| sean-k-mooney | stephenfin: ah ok ya makes sense | 14:50 |
| *** mkrai has quit IRC | 14:52 | |
| *** owalsh has joined #openstack-nova | 14:58 | |
| *** ociuhandu_ has joined #openstack-nova | 14:59 | |
| *** k_mouza_ has quit IRC | 14:59 | |
| *** xek__ has joined #openstack-nova | 15:01 | |
| lyarwood | gibi: ack LGTM, quick naming nit and we will need some tests but this should be good | 15:02 |
| gibi | we need test for tempest tests? whaaat :D | 15:02 |
| gibi | looking ... | 15:02 |
| lyarwood | gibi: but who is going to test the test that tests the test?!! | 15:02 |
| lyarwood | gibi: /s | 15:02 |
| lyarwood | gibi: yeah just basic unit tests for the waiter | 15:02 |
| gibi | yeah, I need self testing tests in a recursive way... :D | 15:03 |
| lyarwood | gibi: I was asked to do it before so I'm assuming someone will ask for them here | 15:03 |
| gibi | lyarwood: sure, thanks. I will fix the patch up | 15:03 |
| *** lpetrut has quit IRC | 15:03 | |
| *** ociuhandu has quit IRC | 15:03 | |
| *** xek_ has quit IRC | 15:04 | |
| *** k_mouza has joined #openstack-nova | 15:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Image and flavor defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/752284 | 15:10 |
| *** spatel has joined #openstack-nova | 15:11 | |
| *** ociuhandu_ has quit IRC | 15:19 | |
| *** efried has joined #openstack-nova | 15:31 | |
| *** efried has quit IRC | 15:33 | |
| *** ociuhandu has joined #openstack-nova | 15:36 | |
| teoobo_ | gibi: I am interested in helping out! | 15:36 |
| kashyap | lyarwood: A stupid question - upstream CI runs instance deletion (functional) tests, right? Got a pointer to a latest run for it? | 15:38 |
| kashyap | I think in any CI run I should be able to find it | 15:39 |
| *** mlavalle has joined #openstack-nova | 15:39 | |
| *** efried has joined #openstack-nova | 15:40 | |
| gibi | teoobo_: so there are those nice helpers for the functional test but they are not always used in the tests, so the work would be to find where direct api calls are used for those server actions and replace it with the call to the helper | 15:40 |
| lyarwood | kashyap: remember that we change the real meaning of functional tests in Nova | 15:40 |
| lyarwood | kashyap: do you mean actual instance deletion including the removal of a libvirt domain etc? | 15:41 |
| lyarwood | kashyap: if so that's actually under integration testing with tempest and yeah there should be loads of examples | 15:41 |
| lyarwood | kashyap: each time we create and instance we should eventually clean it up | 15:41 |
| lyarwood | create an* | 15:41 |
| kashyap | lyarwood: Yeah, indeed - actual instance deletion including the removal | 15:41 |
| kashyap | ... of libvirt domain | 15:41 |
| kashyap | lyarwood: The reason why I ask is, | 15:41 |
| lyarwood | kashyap: kk, should be loads of examples in any tempest run | 15:42 |
| kashyap | I was debugging an NVDIMM issue with OSP QE; and Nova (upstream) code currently assumes you have 'daxio' tool installed | 15:42 |
| kashyap | But ... some enterprise distros don't have it installed in their containers :-) | 15:42 |
| kashyap | And it's causing a mess | 15:42 |
| kashyap | lyarwood: Okay; thanks! | 15:42 |
| sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/virtual-persistent-memory.html#virtual-persistent-memory-disposal | 15:43 |
| sean-k-mooney | its called out in the sepc that its requried | 15:43 |
| sean-k-mooney | The nova compute libvirt driver uses daxio utility (wrapped by privsep library functions) for this purpose. | 15:43 |
| sean-k-mooney | so just like ndctl it was missed in the deployment update in ooo/kolla | 15:44 |
| kashyap | I'm aware; that's what I pointed out earlier | 15:44 |
| kashyap | Yeah, they need to re-update the containers (Kolla, I guess) like they had to do for 'virt-admin' package | 15:44 |
| lyarwood | yup | 15:44 |
| lyarwood | it's an optional dep in Nova itself | 15:44 |
| lyarwood | so we don't enforce it to be installed in code | 15:45 |
| sean-k-mooney | https://github.com/openstack/kolla/commit/f9ea23d940ec4ce35d503ac62f202daaa9db502d only added ndctl | 15:46 |
| sean-k-mooney | it need to be in nova_compute not nova_libvirt by the way | 15:46 |
| kashyap | They also need ndctl-libs; without which 'daxio' doesn't work | 15:47 |
| sean-k-mooney | ndctl should pull that in | 15:47 |
| kashyap | (Yeah) | 15:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: Use cell targeted context to query BDMs for metadata https://review.opendev.org/c/openstack/nova/+/765748 | 15:48 |
| kashyap | I'm hoping; but better be explicit than implicit | 15:48 |
| kashyap | sean-k-mooney: Also what's the rationale for installing it in 'nova_compute' vs. 'nova_libvirt' container? | 15:48 |
| kashyap | Just a bit ago I thought it should be in the latter | 15:48 |
| kashyap | Container hell for the win | 15:48 |
| sean-k-mooney | nova_libvirt just runs libvirtd | 15:49 |
| sean-k-mooney | the compute agent that uses it is in nova_compute | 15:49 |
| sean-k-mooney | https://rpmfind.net/linux/RPM/centos/8.3.2011/baseos/x86_64/Packages/ndctl-67-2.el8.x86_64.html | 15:51 |
| sean-k-mooney | so it required ndctl-libs and daxctl-libs | 15:51 |
| sean-k-mooney | but not the daxio cli im guessiing | 15:51 |
| kashyap | (I know the container's purpose of course; but which container requires which deps to be installed isn't always apparent.) | 15:51 |
| sean-k-mooney | ya its a seperate package https://centos.pkgs.org/8/centos-appstream-x86_64/daxio-1.6.1-1.el8.x86_64.rpm.html | 15:51 |
| kashyap | It is | 15:52 |
| sean-k-mooney | daxio does not depend on ndctl-libs by the way so that looks like a bug unless its an optional dep | 15:52 |
| kashyap | It won't; daxio needs to be separately installed. | 15:52 |
| kashyap | Either way; I'll file a tracker for TripleO to get this going | 15:52 |
| sean-k-mooney | well we coudl reopen the bz. from an upstream ppoint of view this need 2 bugs or 1 but against 2 compnetnts | 15:54 |
| sean-k-mooney | we need to update kolla and ooo | 15:54 |
| sean-k-mooney | sicne we need the dep to be added to both image build systems | 15:54 |
| sean-k-mooney | e.g. kolla and the new ooo one | 15:54 |
| *** dklyle has joined #openstack-nova | 15:54 | |
| teoobo_ | gibi: do i have to open a bug on launchpad before working on it? | 15:54 |
| sean-k-mooney | kolla for 16.1 and ooo for 16.2 | 15:54 |
| gibi | teoobo_: no need for a bug, just add me and stephenfin to the patch as reviewer | 15:58 |
| *** jamesdenton has quit IRC | 15:58 | |
| gibi | teoobo_: I suggest to propose one patch per helper if possible, and add the same gerrit topic to each patch | 15:59 |
| *** jamesdenton has joined #openstack-nova | 15:59 | |
| teoobo_ | gibi: thanks again for the help | 16:00 |
| gibi | teoobo_: I'm happy to help :) | 16:00 |
| gibi | teoobo_: thanks for picking up some of these work | 16:00 |
| *** salmankhan has joined #openstack-nova | 16:00 | |
| gibi | stephenfin: you were +2 on https://review.opendev.org/c/openstack/nova-specs/+/752284 now I'm +2 too, so you can send it through if you wish | 16:00 |
| stephenfin | sure, will take a look shortly :) | 16:01 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765824 | 16:08 |
| lyarwood | ^ should fix openstack-tox-lower-constraints | 16:08 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765824 | 16:10 |
| gibi | lyarwood: +2 | 16:14 |
| * lyarwood waits to see if that passes | 16:16 | |
| *** ociuhandu has quit IRC | 16:27 | |
| *** macz_ has joined #openstack-nova | 16:31 | |
| *** ociuhandu has joined #openstack-nova | 16:32 | |
| *** teoobo__ has joined #openstack-nova | 16:38 | |
| *** teoobo_ has quit IRC | 16:41 | |
| *** macz_ has quit IRC | 16:41 | |
| *** macz_ has joined #openstack-nova | 16:44 | |
| *** rpittau is now known as rpittau|afk | 16:58 | |
| *** slaweq has quit IRC | 17:05 | |
| *** slaweq has joined #openstack-nova | 17:07 | |
| *** ociuhandu_ has joined #openstack-nova | 17:38 | |
| *** ociuhandu has quit IRC | 17:42 | |
| *** ociuhandu_ has quit IRC | 17:43 | |
| lyarwood | stephenfin / melwitt / bauzas ; https://review.opendev.org/c/openstack/nova/+/765824 - This should unblock the lc job if anyone has time this evening. | 17:46 |
| *** teoobo__ has quit IRC | 17:48 | |
| *** ociuhandu has joined #openstack-nova | 17:51 | |
| melwitt | lyarwood: done, thanks for fixing that! | 17:54 |
| *** gyee has joined #openstack-nova | 17:54 | |
| stephenfin | lyarwood: done | 17:55 |
| stephenfin | oh, Mel beat me to it | 17:55 |
| *** ociuhandu has quit IRC | 17:55 | |
| *** k_mouza has quit IRC | 17:56 | |
| lyarwood | np thanks both :) | 17:56 |
| *** derekh has quit IRC | 17:58 | |
| *** andrewbonney has quit IRC | 18:17 | |
| *** tesseract has quit IRC | 18:18 | |
| *** hamalq has joined #openstack-nova | 18:19 | |
| *** hamalq_ has joined #openstack-nova | 18:21 | |
| *** jangutter has quit IRC | 18:22 | |
| *** jangutter has joined #openstack-nova | 18:23 | |
| *** hamalq has quit IRC | 18:25 | |
| *** jangutter has quit IRC | 18:26 | |
| *** jangutter has joined #openstack-nova | 18:26 | |
| *** dtantsur is now known as dtantsur|afk | 18:28 | |
| *** jangutter has quit IRC | 18:40 | |
| *** jangutter has joined #openstack-nova | 18:40 | |
| *** jangutter has quit IRC | 18:40 | |
| *** jangutter has joined #openstack-nova | 18:41 | |
| *** jangutter has quit IRC | 18:45 | |
| *** jangutter has joined #openstack-nova | 18:46 | |
| *** dcapone2004 has quit IRC | 18:58 | |
| *** jangutter_ has joined #openstack-nova | 19:03 | |
| *** jangutter has quit IRC | 19:07 | |
| *** damien_r has quit IRC | 19:50 | |
| *** tbachman has quit IRC | 19:51 | |
| *** luksky has quit IRC | 19:54 | |
| *** luksky has joined #openstack-nova | 19:54 | |
| *** jangutter has joined #openstack-nova | 20:06 | |
| *** jangutter_ has quit IRC | 20:08 | |
| *** jangutter_ has joined #openstack-nova | 20:10 | |
| openstackgerrit | Merged openstack/nova master: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765824 | 20:11 |
| *** jangutter has quit IRC | 20:13 | |
| gmann | stephenfin: you are not covering the detail-False cases in this as it pass True for detail param - https://review.opendev.org/c/openstack/nova/+/764039/1/nova/tests/unit/api/openstack/compute/test_hypervisors.py#285 | 20:14 |
| *** jamesdenton has quit IRC | 20:15 | |
| *** elod is now known as elod_pto | 20:16 | |
| *** jamesdenton has joined #openstack-nova | 20:16 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749 | 20:22 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-evacuate: Remove leftover playbook from standalone job https://review.opendev.org/c/openstack/nova/+/764618 | 20:26 |
| spatel | johnsom: Hey! | 20:29 |
| johnsom | Hello | 20:30 |
| spatel | My octivia lb working great now :) | 20:30 |
| johnsom | Great to hear! | 20:30 |
| spatel | I am going to do some benchmarking to certify performance. | 20:30 |
| openstackgerrit | Rafael Weingartner proposed openstack/nova master: Enhance simple usage API documentation https://review.opendev.org/c/openstack/nova/+/765871 | 20:30 |
| johnsom | spatel This is the nova channel, we should talk about Octavia in #opendstack-lbaas | 20:30 |
| spatel | damn!! sorry | 20:31 |
| johnsom | NP, just being courteous to our nova friends. | 20:31 |
| openstackgerrit | Rafael Weingartner proposed openstack/nova master: Nova's `os-simple-tenant-usage` has the following statement. https://review.opendev.org/c/openstack/nova/+/765871 | 20:34 |
| openstackgerrit | Rafael Weingartner proposed openstack/nova master: Enhance simple usage API documentation https://review.opendev.org/c/openstack/nova/+/765871 | 20:36 |
| openstackgerrit | Rafael Weingartner proposed openstack/nova master: Enhance simple usage API documentation https://review.opendev.org/c/openstack/nova/+/765871 | 20:39 |
| *** bbowen has quit IRC | 20:45 | |
| *** haleyb has quit IRC | 20:53 | |
| *** haleyb has joined #openstack-nova | 20:54 | |
| *** damien_r has joined #openstack-nova | 20:54 | |
| *** raildo has quit IRC | 21:07 | |
| *** tbachman has joined #openstack-nova | 21:11 | |
| *** elod_pto has quit IRC | 21:13 | |
| *** luksky has quit IRC | 21:14 | |
| *** jamesdenton has quit IRC | 21:18 | |
| *** jamesdenton has joined #openstack-nova | 21:18 | |
| *** luksky has joined #openstack-nova | 21:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765769 | 21:44 |
| *** jmlowe has quit IRC | 21:45 | |
| *** brinzhang_ has joined #openstack-nova | 21:45 | |
| *** jmlowe has joined #openstack-nova | 21:47 | |
| *** brinzhang has quit IRC | 21:48 | |
| *** k_mouza has joined #openstack-nova | 21:57 | |
| *** damien_r has quit IRC | 21:58 | |
| *** slaweq has quit IRC | 21:58 | |
| *** rcernin has joined #openstack-nova | 22:00 | |
| *** k_mouza has quit IRC | 22:01 | |
| *** lyarwood has quit IRC | 22:02 | |
| *** johnsom has quit IRC | 22:02 | |
| *** sorrison has quit IRC | 22:02 | |
| *** purplerbot has quit IRC | 22:06 | |
| *** jhesketh has quit IRC | 22:06 | |
| *** purplerbot has joined #openstack-nova | 22:07 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/c/openstack/nova/+/720769 | 22:07 |
| *** k_mouza has joined #openstack-nova | 22:07 | |
| *** jhesketh has joined #openstack-nova | 22:08 | |
| *** k_mouza has quit IRC | 22:12 | |
| *** tobberydberg has quit IRC | 22:14 | |
| *** tobberydberg has joined #openstack-nova | 22:19 | |
| *** xek__ has quit IRC | 22:28 | |
| *** johnsom has joined #openstack-nova | 22:30 | |
| *** lyarwood has joined #openstack-nova | 22:30 | |
| *** spatel has quit IRC | 22:40 | |
| *** JamesBenson has quit IRC | 22:41 | |
| *** dviroel has quit IRC | 22:55 | |
| *** bbowen has joined #openstack-nova | 22:58 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/755360 | 23:15 |
| *** hoonetorg has quit IRC | 23:20 | |
| *** vishalmanchanda has quit IRC | 23:24 | |
| *** hoonetorg has joined #openstack-nova | 23:34 | |
| *** luksky has quit IRC | 23:51 | |
| *** spatel has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!