| *** brinzhang0 has quit IRC | 00:37 | |
| *** brinzhang has joined #openstack-nova | 00:37 | |
| *** takamatsu has quit IRC | 00:49 | |
| *** jhesketh has joined #openstack-nova | 00:49 | |
| *** bbowen has joined #openstack-nova | 00:50 | |
| *** gyee has quit IRC | 01:12 | |
| *** macz_ has quit IRC | 01:15 | |
| openstackgerrit | chengsheng proposed openstack/nova master: Add hypervisor CPU feature check during live migration https://review.opendev.org/762330 | 01:20 |
|---|---|---|
| *** mlavalle has quit IRC | 01:33 | |
| *** LinPeiWen has joined #openstack-nova | 02:07 | |
| *** hongbin has joined #openstack-nova | 02:12 | |
| *** Yumeng has joined #openstack-nova | 02:15 | |
| *** rcernin has quit IRC | 02:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate nova-grenade-multinode job to zuulv3 native https://review.opendev.org/742056 | 02:32 |
| *** macz_ has joined #openstack-nova | 02:36 | |
| *** macz_ has quit IRC | 02:41 | |
| openstackgerrit | chengsheng proposed openstack/nova master: Modify the default value of the force parameter in live migration https://review.opendev.org/762458 | 02:45 |
| *** rcernin has joined #openstack-nova | 02:50 | |
| *** xinranwang has joined #openstack-nova | 03:03 | |
| *** hamalq has quit IRC | 03:07 | |
| *** hongbin has quit IRC | 03:16 | |
| *** mkrai has joined #openstack-nova | 03:27 | |
| *** psachin has joined #openstack-nova | 03:27 | |
| *** ircuser-1 has joined #openstack-nova | 03:31 | |
| *** eharney has quit IRC | 04:10 | |
| *** nweinber has joined #openstack-nova | 04:15 | |
| *** k_mouza has joined #openstack-nova | 04:16 | |
| *** k_mouza has quit IRC | 04:21 | |
| *** macz_ has joined #openstack-nova | 04:25 | |
| *** sapd1_y has quit IRC | 04:29 | |
| *** macz_ has quit IRC | 04:30 | |
| *** nweinber has quit IRC | 04:44 | |
| *** Yumeng has quit IRC | 05:06 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate nova-grenade-multinode job to zuulv3 native https://review.opendev.org/742056 | 05:28 |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-nova | 05:33 | |
| *** eharney has joined #openstack-nova | 05:35 | |
| *** vishalmanchanda has joined #openstack-nova | 05:48 | |
| openstackgerrit | Xinran WANG proposed openstack/nova-specs master: SRIOV Enabled Nic Support Specification https://review.opendev.org/742785 | 05:57 |
| *** rcernin_ has joined #openstack-nova | 05:59 | |
| *** rcernin has quit IRC | 06:01 | |
| openstackgerrit | norman shen proposed openstack/nova-specs master: Adds spec for instance live resize https://review.opendev.org/141219 | 06:14 |
| *** otubo has left #openstack-nova | 06:35 | |
| openstackgerrit | Jorhson Deng proposed openstack/nova master: To deal instance with soft-deleting in _init_instance https://review.opendev.org/761264 | 06:50 |
| *** takamatsu has joined #openstack-nova | 07:20 | |
| *** brinzhang_ has joined #openstack-nova | 07:21 | |
| *** xinranwang has quit IRC | 07:22 | |
| *** takamatsu has quit IRC | 07:23 | |
| *** takamatsu has joined #openstack-nova | 07:23 | |
| *** ralonsoh has joined #openstack-nova | 07:23 | |
| *** brinzhang has quit IRC | 07:24 | |
| *** rcernin_ has quit IRC | 07:26 | |
| *** slaweq has joined #openstack-nova | 07:29 | |
| *** lpetrut has joined #openstack-nova | 07:35 | |
| *** mkrai has quit IRC | 07:42 | |
| *** hemna has quit IRC | 07:50 | |
| *** dklyle has quit IRC | 07:50 | |
| openstackgerrit | Jorhson Deng proposed openstack/nova master: To deal instance with soft-deleting in _init_instance https://review.opendev.org/761264 | 07:54 |
| *** hemna has joined #openstack-nova | 07:56 | |
| f0o | Hi, not sure if this is an issue in nova/kvm or the guest-os: Sometimes (really random) when a linux guest, predominantly CoreOS/Flatcar, attempts to reboot the instance is placed into Puased state instead. However the pause state is erroneously because there's no resume action possible so something must've gone bonkers in the state sync. Only issueing Hard-Reboot via cli will actually | 08:07 |
| f0o | bring the guest back alive | 08:07 |
| *** rcernin_ has joined #openstack-nova | 08:09 | |
| *** andrewbonney has joined #openstack-nova | 08:11 | |
| *** prometheanfire has quit IRC | 08:16 | |
| *** mkrai has joined #openstack-nova | 08:16 | |
| *** tesseract has joined #openstack-nova | 08:19 | |
| *** rpittau|afk is now known as rpittau | 08:19 | |
| *** prometheanfire has joined #openstack-nova | 08:20 | |
| *** rcernin_ has quit IRC | 08:22 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: Improve error handling during service level check https://review.opendev.org/762471 | 08:23 |
| *** rcernin_ has joined #openstack-nova | 08:41 | |
| bauzas | good and very cold morning Nova | 08:45 |
| *** rcernin_ has quit IRC | 08:57 | |
| *** rcernin_ has joined #openstack-nova | 09:01 | |
| *** rcernin_ has quit IRC | 09:06 | |
| lyarwood | has anyone written up a bug for functional failing (due to an eventlet bug) on 3.9 yet? | 09:19 |
| lyarwood | AttributeError: 'Semaphore' object has no attribute '_at_fork_reinit' | 09:19 |
| lyarwood | https://github.com/eventlet/eventlet/issues/646 fixed it a few days ago | 09:19 |
| *** martinkennelly has joined #openstack-nova | 09:26 | |
| lyarwood | kay weird now it's working | 09:26 |
| lyarwood | okay* | 09:26 |
| lyarwood | nvm | 09:26 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Remove redundant check https://review.opendev.org/762482 | 09:29 |
| *** ociuhandu has joined #openstack-nova | 09:32 | |
| *** sean-k-mooney1 has joined #openstack-nova | 09:42 | |
| *** sean-k-mooney has quit IRC | 09:43 | |
| *** mkrai has quit IRC | 09:45 | |
| *** zzzeek has quit IRC | 09:45 | |
| *** zzzeek has joined #openstack-nova | 09:46 | |
| *** hongbin has joined #openstack-nova | 09:46 | |
| openstackgerrit | chengsheng proposed openstack/nova master: Modify the default value of the force parameter in live migration https://review.opendev.org/762458 | 09:48 |
| stephenfin | gibi: sean-k-mooney1: FYI https://review.opendev.org/762396 | 09:53 |
| stephenfin | that's the OSC change to support shelve offload | 09:54 |
| *** k_mouza has joined #openstack-nova | 09:55 | |
| *** LinPeiWen has quit IRC | 10:04 | |
| gibi | stephenfin: ack, thanks, will look | 10:05 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 10:12 |
| *** ociuhandu has quit IRC | 10:21 | |
| *** zzzeek has quit IRC | 10:22 | |
| *** zzzeek has joined #openstack-nova | 10:25 | |
| *** dtantsur|afk is now known as dtantsur | 10:29 | |
| openstackgerrit | Jorhson Deng proposed openstack/nova master: To deal instance with soft-deleting in _init_instance https://review.opendev.org/761264 | 10:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Revert "Temporarily disable parts of heal port allocation test" https://review.opendev.org/755995 | 10:33 |
| *** ociuhandu has joined #openstack-nova | 10:34 | |
| *** hongbin has quit IRC | 10:36 | |
| *** hongbin has joined #openstack-nova | 10:37 | |
| *** k_mouza has quit IRC | 10:39 | |
| *** k_mouza has joined #openstack-nova | 10:48 | |
| *** alex_xu has quit IRC | 10:54 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Rename host to hostname in conductor manager https://review.opendev.org/762499 | 10:55 |
| *** jangutter_ has joined #openstack-nova | 10:55 | |
| *** jangutter_ has quit IRC | 10:56 | |
| brinzhang_ | gibi: I would like to rename the variable 'host' express 'hostname' in conductor manager, is it ok? | 10:56 |
| *** jangutter_ has joined #openstack-nova | 10:56 | |
| *** jangutter has quit IRC | 10:56 | |
| gibi | brinzhang_: just quickly looked at it it seems OK, you might consider renaming node to nodename in the same context | 10:59 |
| *** jangutter has joined #openstack-nova | 11:01 | |
| brinzhang_ | gibi: ok, I will do it later, thanks | 11:02 |
| *** jangutter_ has quit IRC | 11:04 | |
| gibi | fyi folks, there is a new type of gate failure (at least it is new for me) https://bugs.launchpad.net/nova/+bug/1903979 | 11:06 |
| openstack | Launchpad bug 1903979 in OpenStack Compute (nova) "nova-live-migration job fails during evacuate negative test" [High,Confirmed] | 11:06 |
| lyarwood | gibi: I can look at this today | 11:12 |
| gibi | lyarwood: thanks, I'm pushing a e-r signature for it | 11:12 |
| gibi | here is the e-r patch https://review.opendev.org/762502 | 11:14 |
| lyarwood | urgh zuul's webui isn't responding for me | 11:16 |
| gibi | it is slow | 11:16 |
| gibi | for me | 11:16 |
| gibi | but eventually opens | 11:16 |
| lyarwood | gibi: do you have the raw console log link? | 11:16 |
| gibi | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ca4/762319/1/check/nova-live-migration/ca4ccb9/job-output.txt | 11:19 |
| gibi | lyarwood: ^^ | 11:20 |
| sean-k-mooney1 | stephenfin: it more or less looks ok but i left a few comments | 11:23 |
| sean-k-mooney1 | stephenfin: i think you are failing out to early | 11:23 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Rename host/node to hostname/nodename in conductor manager https://review.opendev.org/762499 | 11:23 |
| stephenfin | sean-k-mooney1: replied | 11:35 |
| sean-k-mooney1 | oh my nick is wrong on sec | 11:36 |
| *** sean-k-mooney1 is now known as sean-k-mooney | 11:36 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 11:43 |
| *** hongbin has quit IRC | 11:48 | |
| *** k_mouza has quit IRC | 11:51 | |
| sean-k-mooney | stephenfin: i have removed the -1 and reviewd the other i can accept adressing the inefficnies in a follow up to keep the inital patch less complex espically since you left the todo | 11:58 |
| stephenfin | great, thanks :) | 11:58 |
| *** tbachman has quit IRC | 11:58 | |
| sean-k-mooney | stephenfin: i dont think you need a wait_for_deletes that shoudl just call a more generialsed wait_for_statuses | 11:59 |
| stephenfin | I could probably do that, yeah | 11:59 |
| stephenfin | I'd have to keep wait_for_delete around though | 11:59 |
| sean-k-mooney | is that not just calling wait_for_statuses with a list of 1 | 12:00 |
| stephenfin | no, you need exception handling | 12:00 |
| sean-k-mooney | right but you can add that to wait_for_statuses | 12:00 |
| stephenfin | since a 404 is actually success (the resource has been deleted) | 12:00 |
| sean-k-mooney | just default it to an empty list of allowed excptionts | 12:00 |
| stephenfin | Right, but people are using 'wait_for_delete' in the wild | 12:01 |
| stephenfin | so I'd have to keep the API for some time at least | 12:01 |
| sean-k-mooney | oh ya keep the function | 12:01 |
| sean-k-mooney | just rip out the logic | 12:01 |
| sean-k-mooney | and delegate | 12:01 |
| stephenfin | I think it's clearer as a separate function, tbh | 12:01 |
| stephenfin | deleted isn't a status | 12:01 |
| stephenfin | it's a binary condition | 12:01 |
| sean-k-mooney | it is if you pass the flag to list deleted servers | 12:02 |
| sean-k-mooney | stephenfin: no if you have not done archive and purge | 12:02 |
| sean-k-mooney | you can see deleted servers form the api | 12:02 |
| sean-k-mooney | you just do "openstack server list --deleted" | 12:03 |
| stephenfin | for nova, yes | 12:03 |
| stephenfin | it's racy though | 12:03 |
| stephenfin | even for nova | 12:03 |
| sean-k-mooney | you mean with the chron job | 12:04 |
| stephenfin | yes | 12:04 |
| sean-k-mooney | for osp at least that only deletes things older then 30 days | 12:04 |
| stephenfin | Right, but its config specific. HTTP 404 isn't, by comparison | 12:04 |
| stephenfin | and it works for multiple different services, so I think that's still the correct approach to use | 12:05 |
| sean-k-mooney | ya anyway if you want to keep but its fine it just really felt like needless code duplication | 12:05 |
| stephenfin | It probably is, but I think it's worth the cost compared to the complexity de-duplication would bring | 12:05 |
| stephenfin | We could probably have an inner function not exposed to users. I'll take a look at that later | 12:06 |
| *** ociuhandu has quit IRC | 12:13 | |
| *** k_mouza has joined #openstack-nova | 12:14 | |
| *** tosky has joined #openstack-nova | 12:18 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Rename host/node to hostname/nodename in conductor manager https://review.opendev.org/762499 | 12:18 |
| *** ociuhandu has joined #openstack-nova | 12:27 | |
| *** ociuhandu has quit IRC | 12:32 | |
| openstackgerrit | Daniel de Oliveira Pereira proposed openstack/nova master: [WIP] Avoid getting transport_url from config file when updating Cell0 https://review.opendev.org/762433 | 12:41 |
| *** artom has joined #openstack-nova | 12:54 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 12:55 |
| zigo | sean-k-mooney: This will need a fix in puppet-openstack and OSA, that's my concern... | 13:18 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Change host to hostname https://review.opendev.org/762518 | 13:19 |
| zigo | Which is why I'm insisting to say we should all go on the same direction (ie: all distro and config management), otherwise it's going to be a mess. | 13:19 |
| sean-k-mooney | zigo: OSA does not need a fix | 13:20 |
| sean-k-mooney | it already does the right thing and does not include the db creds | 13:20 |
| zigo | sean-k-mooney: It depends how you see it, the version that uses packages does. | 13:20 |
| sean-k-mooney | the version that uses package does not use the config form the packages | 13:21 |
| sean-k-mooney | it still generate its own | 13:21 |
| zigo | And anyways, it'd be nice if it was doing the same thing. | 13:21 |
| zigo | Oh ... Ok. | 13:21 |
| sean-k-mooney | i think that is fairly common practice | 13:22 |
| sean-k-mooney | not to use the disto config if you are using a intall tool | 13:22 |
| zigo | So, I should generate the db config file with only --namespace oslo.db --namespace oslo.db.concurrency, right? | 13:22 |
| sean-k-mooney | they all tend to generat there own based on the layer tehy provide in ther own tuning files | 13:22 |
| zigo | Or should I just extract it from the existing nova.conf stuff? | 13:22 |
| sean-k-mooney | zigo: what we were suggeting to do for the rpms was have an update script that copied the nova.conf to nova-compute.conf adn then use sed or curidini to remove the db sections | 13:23 |
| sean-k-mooney | but if we go with the seperate files for db | 13:24 |
| sean-k-mooney | then both would work generating only really works for new installs | 13:24 |
| zigo | sean-k-mooney: I'm generating the files when building the package... | 13:24 |
| sean-k-mooney | for upgrades of the package you kind of need to extract | 13:24 |
| sean-k-mooney | generating the files is fine but only on a fresh install right | 13:25 |
| sean-k-mooney | you dont want an apt udpate to nuke your files | 13:25 |
| zigo | https://salsa.debian.org/openstack-team/services/nova/-/blob/debian/victoria/debian/rules#L75 | 13:25 |
| zigo | The packages don't take care of the upgrades (yet). So it will simply do nothing to the existing nova.conf file when upgrading. | 13:26 |
| sean-k-mooney | oh right but thats just the copy in /usr/share | 13:26 |
| sean-k-mooney | not the /etc/ ones | 13:26 |
| zigo | Yeap, but postinst writes in /etc/nova if the file isn't there. | 13:26 |
| sean-k-mooney | yep i was refing to a postinst script | 13:27 |
| zigo | I'm doing like that to avoid the file being a CONFFILE and getting annoying config file update prompts at upgrade time. | 13:27 |
| sean-k-mooney | for the /usr/shar just generating the db config would be fine | 13:27 |
| sean-k-mooney | ah ya the do you want to accpet the package mainters version one? | 13:27 |
| *** macz_ has joined #openstack-nova | 13:30 | |
| *** macz_ has quit IRC | 13:35 | |
| *** nweinber has joined #openstack-nova | 13:35 | |
| *** tbachman has joined #openstack-nova | 13:41 | |
| *** Luzi has joined #openstack-nova | 13:44 | |
| Luzi | Hi I have a question concerning the SHELVED state: When I try to shelve two instances (one image-based the other volume-based) only the image-based goes into the SHELVED state. The volume based instance is offloaded despite having set the config option shelved_offload_time to 3000 | 13:49 |
| Luzi | why do they behave different? | 13:50 |
| sean-k-mooney | likely because teh bfv instance does not have state on the host | 13:54 |
| sean-k-mooney | so its more or less free to resume | 13:54 |
| sean-k-mooney | the intermite shelved state is really just an optimisation for instance with local disks | 13:54 |
| Luzi | ok thank you sean-k-mooney | 13:55 |
| sean-k-mooney | because its expensive to snapshot and restore them due to the data copy | 13:55 |
| sean-k-mooney | it proably shoudl be consistent but that would be the most likely reason its not | 13:55 |
| Luzi | it sounds reasonable, but i did not find the reason documented, even though i found the code lines, where they paths begin to differ | 13:57 |
| sean-k-mooney | ya i think different peopel have different expectaions for shelve we had a conversation about it yesterday | 13:57 |
| Luzi | its definitely confusing :D | 13:57 |
| sean-k-mooney | i expect that all shelved instance shoudl eventually end up in shelve offloaded not shelved but that based on the defaults and how i use it | 13:58 |
| sean-k-mooney | in the bfv case basically there is no data too offload since its not on the host to begin with | 13:59 |
| sean-k-mooney | the docs could proably be improved however | 13:59 |
| Luzi | from what i have experienced today, it would be nice to state it at least in the config example documentation | 14:00 |
| Luzi | a hint, that volume based server will always go directly into the offloaded state | 14:00 |
| sean-k-mooney | ya we could proably just add a sleep(conf.shelve_offload_time) in the bfv path befor ecalling offload | 14:00 |
| sean-k-mooney | its likely not going dirctly but just ignoring the time out | 14:01 |
| sean-k-mooney | do you have a reference to the code i have not look at it that closely in a while | 14:01 |
| Luzi | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4185 | 14:03 |
| sean-k-mooney | ah its calling shelve offload directly | 14:04 |
| Luzi | yes | 14:04 |
| Luzi | and the config option is used here: https://github.com/openstack/nova/blob/eb279e9a5676f4142cce4700c3097ecc14161895/nova/compute/manager.py#L6363 | 14:05 |
| sean-k-mooney | ya so we could call shelve directrly i think but how we do the snapshot would have to be conditional on the instance type | 14:06 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6396 | 14:07 |
| sean-k-mooney | basically move that first if into shelve | 14:08 |
| Luzi | it makes sense to directly go into the offloaded state, so imho it would just need some fixed documentation. | 14:08 |
| sean-k-mooney | yep that works too | 14:08 |
| sean-k-mooney | just need to let people know | 14:09 |
| sean-k-mooney | gibi: stephenfin dansmith since most of my insstance are bfv this also expalins why i expect shelve to more or less always got to shelve_offladed pretty quickly | 14:10 |
| sean-k-mooney | given bfv instance skip shleved | 14:10 |
| gibi | sean-k-mooney: I saw the brancing in the code but I don't know the original reason of such branching | 14:11 |
| sean-k-mooney | my specutlation was there is no data too offload so just go strait to offloaded | 14:12 |
| sean-k-mooney | a comment would have been nice but that is my guess. i agree with luzi that there is likely no utility in makeing them waith in shelved until the time out expries and a doc update is proably enough | 14:13 |
| sean-k-mooney | gibi: that said its directly calling the compute to avoid this check today https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4197 | 14:15 |
| sean-k-mooney | so we are not recordign the offload in the evnet log | 14:16 |
| *** Luzi has quit IRC | 14:32 | |
| *** dave-mccowan has joined #openstack-nova | 14:33 | |
| *** artom has quit IRC | 14:37 | |
| *** artom has joined #openstack-nova | 14:37 | |
| *** dave-mccowan has quit IRC | 14:37 | |
| openstackgerrit | Marc Gariépy (mgariepy) proposed openstack/nova stable/ussuri: Handle disabled CPU features to fix live migration failures https://review.opendev.org/758761 | 14:39 |
| mgariepy | any nova core avalaible to review: https://review.opendev.org/#/c/758760/ ? | 14:42 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [WIP] Migrate nova-grenade-multinode job to zuulv3 native https://review.opendev.org/742056 | 14:42 |
| dansmith | sean-k-mooney: ah yeah bfv doesn't need to offload anything of course | 14:44 |
| *** vishalmanchanda has quit IRC | 14:47 | |
| gibi | mgariepy: added to my queue which happens to be long these days so other core please don't wait for me | 14:54 |
| mgariepy | thanks gibi | 14:57 |
| mgariepy | also add: https://review.opendev.org/#/c/758761/ | 14:58 |
| gibi | mgariepy: ohh, so this is a backport that is already merged on master | 14:59 |
| gibi | then, elod, could you look at it please ^^ ? | 14:59 |
| gibi | mgariepy: sorry, I don't have +2 rights on stable branches, elod has ;) | 14:59 |
| mgariepy | ha no worry | 15:00 |
| *** lpetrut has quit IRC | 15:05 | |
| stephenfin | sean-k-mooney: We used to have a list of projects that had to be present to call something an OpenStack cloud. What was that program called? Does it still exist? | 15:20 |
| sean-k-mooney | yes its defcore i think there is a branding requirement | 15:26 |
| stephenfin | defcore. That's it | 15:26 |
| sean-k-mooney | just trying to find the repo its in | 15:27 |
| sean-k-mooney | its for the openstack powered trademakrs mainly | 15:27 |
| *** martinkennelly has quit IRC | 15:35 | |
| *** ociuhandu has joined #openstack-nova | 15:35 | |
| gibi | nova weekly meeting starts in 25 minutes on #opentack-meeting-3 | 15:35 |
| gibi | at the same time as the opentack wallaby community meeting | 15:35 |
| gibi | I will be present on both (the first part of the community meeting is prerecorded) | 15:36 |
| sean-k-mooney | stephenfin: it used to be defiend in https://github.com/openstack-archive/refstack | 15:41 |
| sean-k-mooney | then it move dto https://github.com/openstack-archive/interop i think | 15:41 |
| sean-k-mooney | they are now at https://opendev.org/osf/interop and https://opendev.org/osf/refstack | 15:43 |
| sean-k-mooney | stephenfin: this is the latest definition https://opendev.org/osf/interop/src/commit/5f7a8cf9c43015a27c2ed56cad8501d470807461/2020.06.json | 15:45 |
| sean-k-mooney | https://opendev.org/osf/interop/src/commit/5f7a8cf9c43015a27c2ed56cad8501d470807461/2020.06.json#L80-L86 | 15:46 |
| *** ociuhandu has quit IRC | 15:47 | |
| *** mlavalle has joined #openstack-nova | 15:54 | |
| *** macz_ has joined #openstack-nova | 16:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Wait for revert resize to complete https://review.opendev.org/762543 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use helpers for cross-cell resize https://review.opendev.org/762544 | 16:05 |
| *** k_mouza has quit IRC | 16:06 | |
| *** macz_ has quit IRC | 16:08 | |
| *** macz_ has joined #openstack-nova | 16:12 | |
| *** macz_ has quit IRC | 16:12 | |
| *** macz_ has joined #openstack-nova | 16:13 | |
| *** digvijay has joined #openstack-nova | 16:21 | |
| digvijay | trying to attach a GPFS-NFS based cinder volume to vm & getting error in nova-compute.log... (http://paste.openstack.org/show/799964/) | 16:21 |
| digvijay | any idea what might be issue? | 16:21 |
| *** ociuhandu has joined #openstack-nova | 16:27 | |
| *** elod has quit IRC | 16:31 | |
| *** elod has joined #openstack-nova | 16:32 | |
| *** nweinber has quit IRC | 16:37 | |
| *** nweinber has joined #openstack-nova | 16:40 | |
| *** k_mouza has joined #openstack-nova | 16:40 | |
| stephenfin | dansmith: So regarding that virtio tablet discussion. I'd rather introduce 'hw_input_bus' and deprecate 'hw_pointer_model' | 16:55 |
| stephenfin | If the only reason to use mouse is compatibility, then there isn't really any reason to want to keep the latter long-term | 16:55 |
| bauzas | gibi: sorry, I was on a dentist appointment | 16:56 |
| gibi | bauzas: no worries | 16:56 |
| gibi | bauzas: hope it did not hurt | 16:56 |
| dansmith | stephenfin: and what, assume tablet from usb or virtio, and mouse from ps2? | 16:56 |
| dansmith | since it's image metadata, deprecating a thing just means debt forever that we can never get rid of right? | 16:56 |
| stephenfin | yes, assuming we even want to support ps2 | 16:56 |
| *** dklyle has joined #openstack-nova | 16:57 | |
| bauzas | gibi: nope, no worries, it was just a yearly one | 16:57 |
| gibi | :) | 16:57 |
| stephenfin | dansmith: Sort of, but I think this is actually better | 16:57 |
| bauzas | (and I was off the chan today because I was working on https://review.opendev.org/#/c/761452/ ) | 16:58 |
| owalsh | dansmith: so I've been thinking about https://review.opendev.org/762176. I'm really not convinced yet but maybe I'm missing something obvious... | 16:58 |
| stephenfin | Actually, no, it makes no difference | 16:58 |
| stephenfin | We can remove the 'hw_pointer_model' image metadata property in a future major version bump | 16:58 |
| dansmith | stephenfin: but it's "better" just in that you like the name of input_bus more than pointer_model right? Just adding virtiotablet to the existing key gives us no infinite debt, keeps the choices small so that it's harder to pick something that will likely work | 16:58 |
| stephenfin | If we do, nova will simply start ignoring it | 16:58 |
| dansmith | stephenfin: then we've broken users | 16:59 |
| dansmith | I think we're pretty much trying to never do that right? have we ever stopped honoring an image meta property? | 16:59 |
| stephenfin | yes, we'd need mitigation which is why I don't think we'd ever do it | 16:59 |
| stephenfin | same reason we'll continue supporting e.g. 'hw_disk_bus=uml' | 17:00 |
| owalsh | dansmith: so based on what sean said most of the deployment frameworks already do the right thing, and I'm sorting out tripleo/puppet-nova ... | 17:00 |
| stephenfin | like, forever | 17:00 |
| owalsh | dansmith: so I think that leave two scenarios where we could have a nova.conf where the compute gets db creds: | 17:01 |
| stephenfin | dansmith: it's much better UX IMO, yes | 17:01 |
| dansmith | stephenfin: well, it just doesn't make any sense to me to deprecate a thing we'll never remove, which is really not that in need of change | 17:01 |
| owalsh | dansmith: 1 - a roll you're own deployment that screws it up (because there are no docs) | 17:01 |
| stephenfin | dansmith: we're going to end up in that situation anyway | 17:01 |
| stephenfin | usbtablet will be meaningless in a Q35 world | 17:01 |
| dansmith | owalsh: I think everyone agrees it needs to be doc'd better | 17:01 |
| digvijay | hi.. facing issue with attaching NFS based cinder volume to VM.. (http://paste.openstack.org/show/799964/).. any ideas | 17:02 |
| stephenfin | and already is on non-x86 | 17:02 |
| owalsh | dansmith: 2 - an all-in-one deployment (is that not a valid expection to the rule) | 17:02 |
| stephenfin | given neither support ps2 | 17:02 |
| owalsh | dansmith: so we just fix the docs and leave it at that instead of ripping puppet-nova, and the debs, and the rpms and etc.. into pieces... | 17:02 |
| dansmith | stephenfin: that's the same for all of our keys that specify a platform-specific value (like ide, sata, etc).. you're just adding an additional degree of freedom by adding a new key | 17:02 |
| owalsh | dansmith: or maybe we do that, for the sake of elegance, but not a priority in W | 17:03 |
| dansmith | owalsh: well, I meant document it to help with the roll-your-own case and for future deployment tools, but go forward with the startup abort, which requires fixing tripleo | 17:03 |
| dansmith | owalsh: tbh, I'm not the one that really wanted the startup abort, but it does seem like the right thing to do to me | 17:04 |
| dansmith | owalsh: especially since tripleo seems to be one of the only ones not already getting this right | 17:04 |
| owalsh | issue is actually in puppet-nova so tripleo is not to blame here | 17:05 |
| dansmith | owalsh: do any other major deployment tools use puppet-nova besides tripleo? | 17:05 |
| dansmith | they used to, but I didn't think much anymore | 17:06 |
| dansmith | however, tripleo is easier to type, but feel free to apply my comments to the appropriate project :) | 17:06 |
| owalsh | ack, either way take it for granted that the fix is happening and will be backported. Once that is out of the way the hard fail doesn't achieve much IMO, just breaks all-in-one for a lot of people | 17:07 |
| dansmith | devstack is by default an AIO tool and it has been doing it right for years | 17:07 |
| dansmith | but, again, I'm not the only one you need to convince | 17:08 |
| dansmith | IIRC, it was stephenfin that originally thought we should be blocking startup on invalid or insecure configs, and I agree with him | 17:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: Testing system scope in tempest https://review.opendev.org/740124 | 17:08 |
| dansmith | and that doesn't happen very often, so it MUST be right :) | 17:08 |
| *** ociuhandu_ has joined #openstack-nova | 17:09 | |
| owalsh | dansmith: well I know where he lives, if it wasn't for this lockdown! | 17:10 |
| dansmith | sudo refuses to run when a sudoers.d file has invalid permissions, even on my single-user laptop because it's a bad idea for everyone | 17:10 |
| dansmith | owalsh: hah | 17:10 |
| owalsh | dansmith: well given this wasn't really documented I don't think it ok land the assert in W. How about warning that is deprecated for now? | 17:12 |
| *** ociuhandu has quit IRC | 17:13 | |
| dansmith | owalsh: that's a gibi call.. so far I've not heard that this was a surprise to anyone, and you know we have known this is wrong downstream for a while. So to me it seems like a valid thing to do aggressively because of the security aspect, but I'll defer to gibi for timing | 17:13 |
| *** ociuhandu_ has quit IRC | 17:14 | |
| gibi | I see a big pushback on the hard fail, but I also do supprised that all tool that supprots all-in-one today are worked around that hard failure due to upgrade_level 'auto' that is landed cycle ago | 17:15 |
| gibi | if the whole push back is just to get more time to do the fixes then I'm fine to delay the patch even further | 17:16 |
| dansmith | gibi: you _do_ see a big pushback? I didn't see much from the ML, but maybe I'm missing some? | 17:16 |
| *** dklyle has quit IRC | 17:16 | |
| dansmith | sounded to me like debian just wanted some agreement on best practices or something | 17:16 |
| *** david-lyle has joined #openstack-nova | 17:16 | |
| gibi | dansmith: I understood from the ML that we are breaking debian, osa, and tripleo as well. Only kolla and devstack are immune | 17:17 |
| *** david-lyle is now known as dklyle | 17:17 | |
| dansmith | but OSA says they already try to do the right thing and are willing to change, especially if we do some docs | 17:18 |
| dansmith | anyway, as I said, I defer to you on the timing | 17:18 |
| gibi | yeah, I might mix the amount of broken thing with the amount of pushback. Now that I re-read OSA mail it does not feel like a pushback | 17:19 |
| dansmith | they know that db creds do not belong in the nova-compute conf, they just let them be there for AIO | 17:20 |
| dansmith | just like we (tripleo/puppet/whatever) also know that, and have hacked around it thus far :) | 17:20 |
| owalsh | no hack, it was just like that when I got here and it comes from puppet-nova. tripleo will be immune too once https://review.opendev.org/755689 lands, so probably today/tomorrow | 17:21 |
| *** k_mouza has quit IRC | 17:21 | |
| *** k_mouza has joined #openstack-nova | 17:21 | |
| owalsh | however AFAIK there are puppet AIO jobs in CI | 17:22 |
| owalsh | and RDO | 17:22 |
| dansmith | it was a hack when we set the config to something non-default purely to avoid a failure, and we knew that the right thing was to stop putting creds in that file :) | 17:22 |
| gibi | I have to leave for today, will read back tomorrow, and reply on the ML | 17:22 |
| dansmith | o/ | 17:22 |
| gibi | o/ | 17:22 |
| owalsh | o/ I'll poke some CI guys to think about it too, not sure they have grokked the implications yet | 17:23 |
| owalsh | sean-k-mooney: re https://bugs.launchpad.net/nova/+bug/1903908 you looked at the code yea? | 17:27 |
| openstack | Launchpad bug 1903908 in puppet-nova "nova conf [api]/dhcp_domain is required on nova-compute" [Undecided,New] - Assigned to Oliver Walsh (owalsh) | 17:27 |
| owalsh | sean-k-mooney: would you mind explaining the issue on the LP? | 17:28 |
| *** dtantsur is now known as dtantsur|afk | 17:34 | |
| *** digvijay has quit IRC | 17:35 | |
| sean-k-mooney | owalsh: its required to generate teh config dirve yes | 17:38 |
| sean-k-mooney | with the correct hostname | 17:38 |
| sean-k-mooney | if its not set then it will not have the doamin | 17:39 |
| sean-k-mooney | and will get novalocal instead | 17:39 |
| *** k_mouza has quit IRC | 17:45 | |
| *** k_mouza has joined #openstack-nova | 17:46 | |
| owalsh | sean-k-mooney: ack, could you response to gibi on the LP? CI logs from the original LP are long gone I expect | 17:50 |
| owalsh | respond | 17:50 |
| *** rpittau is now known as rpittau|afk | 17:51 | |
| sean-k-mooney | ya i can | 17:51 |
| *** k_mouza has quit IRC | 17:51 | |
| owalsh | ack thanks | 17:51 |
| *** k_mouza has joined #openstack-nova | 17:52 | |
| *** k_mouza has quit IRC | 17:52 | |
| *** tesseract has quit IRC | 17:52 | |
| stephenfin | dansmith: Sorry, had a meeting. It's late so I won't pick up the hw_input_bus vs. virtiotablet discussion again rn, but needless to say I still think my approach is the right one and will just have to think of ways to talk you around ;) In the interim, the reviews at https://review.opendev.org/#/c/756552/ if you want to note down your concerns for others to see | 18:03 |
| stephenfin | and yes to blocking startup on invalid or insecure configs | 18:04 |
| dansmith | stephenfin: yeah, I was going to suggest you update it with your (new, I think) approach of just going with bus only, and then I can -1 with my concerns | 18:04 |
| dansmith | I'd like to see some more input on it, given that it affects rpc, api, images, and the future, | 18:04 |
| dansmith | but if I'm the only one that doesn't like a new thing, then obviously I'll move on | 18:04 |
| dansmith | "update it" meaning, comment on the patch with your thoughts | 18:05 |
| stephenfin | gotcha | 18:05 |
| stephenfin | I'll post to openstack-discuss too. We could spin out a spec to discuss this but the ML would probably attract a larger audience and a spec is a lot for a single design debate | 18:06 |
| dansmith | well, I think gerrit is plenty wide for a detail like this, but whatever you want.. ml is fine too | 18:08 |
| openstackgerrit | Daniel de Oliveira Pereira proposed openstack/nova master: Avoid changing transport_url value when updating Cell0 https://review.opendev.org/762433 | 18:17 |
| *** psachin has quit IRC | 18:28 | |
| *** ralonsoh has quit IRC | 18:44 | |
| *** amodi has quit IRC | 19:11 | |
| *** gyee has joined #openstack-nova | 19:19 | |
| *** jangutter has quit IRC | 19:26 | |
| *** jangutter has joined #openstack-nova | 19:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Wait for revert resize to complete https://review.opendev.org/762543 | 19:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use helpers for cross-cell resize https://review.opendev.org/762544 | 19:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use helpers for cross-cell resize https://review.opendev.org/762544 | 19:42 |
| stephenfin | lyarwood, gibi: I'm on PTO tomorrow, but if you have a chance to look at https://review.opendev.org/762543 (now with a bug report), that's be great. It's not super common but even one intermittent gate failure is one too many | 19:43 |
| stephenfin | o/ | 19:43 |
| *** andrewbonney has quit IRC | 20:00 | |
| *** ociuhandu has joined #openstack-nova | 20:22 | |
| *** ociuhandu has quit IRC | 20:25 | |
| *** ociuhandu_ has joined #openstack-nova | 20:25 | |
| *** bbowen has quit IRC | 20:26 | |
| *** bbowen has joined #openstack-nova | 20:26 | |
| *** ociuhandu has joined #openstack-nova | 20:31 | |
| *** ociuhandu_ has quit IRC | 20:31 | |
| *** rcernin has joined #openstack-nova | 20:32 | |
| *** rcernin has quit IRC | 20:35 | |
| *** ociuhandu_ has joined #openstack-nova | 21:03 | |
| *** ociuhandu has quit IRC | 21:06 | |
| *** artom has quit IRC | 21:15 | |
| *** ociuhandu has joined #openstack-nova | 21:17 | |
| openstackgerrit | Daniel de Oliveira Pereira proposed openstack/nova master: Avoid changing transport_url when updating Cell0 https://review.opendev.org/762433 | 21:18 |
| *** ociuhandu_ has quit IRC | 21:18 | |
| *** elod has quit IRC | 21:18 | |
| *** slaweq has quit IRC | 21:30 | |
| *** slaweq has joined #openstack-nova | 21:33 | |
| *** ociuhandu has quit IRC | 21:34 | |
| *** slaweq has quit IRC | 21:41 | |
| *** rcernin has joined #openstack-nova | 21:47 | |
| *** k_mouza has joined #openstack-nova | 21:53 | |
| *** k_mouza has quit IRC | 21:57 | |
| *** rcernin has quit IRC | 22:01 | |
| *** raildo has quit IRC | 22:07 | |
| *** rcernin has joined #openstack-nova | 22:14 | |
| *** bbowen_ has joined #openstack-nova | 22:23 | |
| *** bbowen has quit IRC | 22:24 | |
| *** fyx has quit IRC | 22:31 | |
| *** fyx has joined #openstack-nova | 22:32 | |
| *** zzzeek has quit IRC | 22:34 | |
| *** zzzeek has joined #openstack-nova | 22:34 | |
| *** nweinber has quit IRC | 22:43 | |
| *** tosky has quit IRC | 22:44 | |
| *** _mlavalle_1 has joined #openstack-nova | 23:21 | |
| *** lyarwood has quit IRC | 23:23 | |
| *** lyarwood has joined #openstack-nova | 23:24 | |
| *** mlavalle has quit IRC | 23:24 | |
| *** CeeMac has quit IRC | 23:42 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!