| *** zzzeek has joined #openstack-nova | 00:02 | |
| *** bbowen has quit IRC | 00:04 | |
| *** martinkennelly has quit IRC | 00:26 | |
| *** rcernin has quit IRC | 00:28 | |
| *** rcernin has joined #openstack-nova | 00:31 | |
| luyao | stephenfin: Hi, recheck succeeds at ' | 00:34 |
|---|---|---|
| luyao | Rollback when reset running live migration' https://review.opendev.org/#/c/747899/, thanks for review | 00:34 |
| *** yingjisun has joined #openstack-nova | 00:53 | |
| *** yingjisun has quit IRC | 00:58 | |
| *** tetsuro has quit IRC | 01:00 | |
| *** hamalq_ has quit IRC | 01:03 | |
| *** Liang__ has joined #openstack-nova | 01:30 | |
| openstackgerrit | zhufl proposed openstack/nova master: Fix invalid assert_has_calls https://review.opendev.org/751143 | 01:30 |
| *** lbragstad_ has joined #openstack-nova | 01:33 | |
| *** jhui has joined #openstack-nova | 01:34 | |
| *** yingjisun has joined #openstack-nova | 01:35 | |
| *** lbragstad has quit IRC | 01:36 | |
| *** artom has quit IRC | 02:12 | |
| *** lbragstad_ has quit IRC | 02:17 | |
| *** Liang__ has quit IRC | 02:24 | |
| openstackgerrit | Eric Xie proposed openstack/nova master: Fix error that cannot overwrite policy rule for 'forced_host' https://review.opendev.org/751152 | 02:24 |
| *** Liang__ has joined #openstack-nova | 02:24 | |
| *** zzzeek has quit IRC | 02:27 | |
| openstackgerrit | Merged openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281 | 02:31 |
| *** zzzeek has joined #openstack-nova | 02:33 | |
| *** jhui_ has joined #openstack-nova | 02:44 | |
| *** jhui has quit IRC | 02:44 | |
| *** jhui_ is now known as jhui | 02:44 | |
| *** suryasingh has joined #openstack-nova | 02:50 | |
| *** gyee has quit IRC | 02:54 | |
| openstackgerrit | Rui Zang proposed openstack/nova master: DO NOT REVIEW https://review.opendev.org/751156 | 02:56 |
| *** mkrai has joined #openstack-nova | 02:58 | |
| *** dave-mccowan has quit IRC | 03:06 | |
| *** mkrai has quit IRC | 03:46 | |
| *** brinzhang_ has joined #openstack-nova | 03:52 | |
| *** rcernin has quit IRC | 03:53 | |
| *** brinzhang0 has quit IRC | 03:55 | |
| *** yingjisun has quit IRC | 04:02 | |
| *** yingjisun has joined #openstack-nova | 04:02 | |
| *** yingjisun has quit IRC | 04:03 | |
| *** rcernin has joined #openstack-nova | 04:15 | |
| *** ratailor has joined #openstack-nova | 04:18 | |
| *** jhui has quit IRC | 04:20 | |
| *** lemko8 has joined #openstack-nova | 04:25 | |
| *** lemko has quit IRC | 04:28 | |
| *** lemko8 is now known as lemko | 04:28 | |
| *** tetsuro has joined #openstack-nova | 04:29 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** Liang__ has quit IRC | 04:37 | |
| *** Liang__ has joined #openstack-nova | 04:38 | |
| *** hongbin has quit IRC | 04:46 | |
| *** mkrai has joined #openstack-nova | 04:49 | |
| *** manuvakery has joined #openstack-nova | 04:52 | |
| *** lemko7 has joined #openstack-nova | 04:53 | |
| *** lemko has quit IRC | 04:54 | |
| *** lemko7 is now known as lemko | 04:54 | |
| *** ratailor has quit IRC | 05:06 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** ratailor has quit IRC | 05:11 | |
| *** aj_mailing has joined #openstack-nova | 05:23 | |
| *** xek has joined #openstack-nova | 05:35 | |
| *** slaweq has joined #openstack-nova | 06:01 | |
| *** jsuchome has joined #openstack-nova | 06:07 | |
| *** tetsuro has quit IRC | 06:11 | |
| *** tetsuro has joined #openstack-nova | 06:14 | |
| *** slaweq has quit IRC | 06:18 | |
| *** jhui has joined #openstack-nova | 06:21 | |
| *** jhui has left #openstack-nova | 06:21 | |
| *** zzzeek has quit IRC | 06:23 | |
| *** zzzeek has joined #openstack-nova | 06:24 | |
| *** xek has quit IRC | 06:27 | |
| *** rcernin has quit IRC | 06:28 | |
| *** yedongcan has joined #openstack-nova | 06:33 | |
| *** ralonsoh has joined #openstack-nova | 06:43 | |
| *** rcernin has joined #openstack-nova | 06:45 | |
| *** rcernin has quit IRC | 06:45 | |
| *** rcernin has joined #openstack-nova | 06:46 | |
| *** zzzeek has quit IRC | 06:51 | |
| *** zzzeek has joined #openstack-nova | 06:53 | |
| *** dklyle has quit IRC | 06:55 | |
| *** manuvakery has quit IRC | 07:02 | |
| *** slaweq has joined #openstack-nova | 07:03 | |
| gibi | sean-k-mooney: sounds interesting. I will have to dig into it a bit | 07:11 |
| *** mkrai has quit IRC | 07:23 | |
| *** tetsuro has quit IRC | 07:25 | |
| *** yedongcan has quit IRC | 07:25 | |
| *** tesseract has joined #openstack-nova | 07:27 | |
| *** tetsuro has joined #openstack-nova | 07:28 | |
| *** links has joined #openstack-nova | 07:33 | |
| bauzas | good Friday Nova | 07:39 |
| bauzas | gibi: I have a specific concern on the relnote for the vmwareapi driver undeprecation but I forgot to tell it during the meeting yesterday | 07:39 |
| bauzas | gibi: https://review.opendev.org/#/c/742407/5/releasenotes/notes/undeprecate-vmware-victoria-2eaf5d877733f8d9.yaml | 07:39 |
| bauzas | not worth holding the change, but maybe a FUP could be nice | 07:39 |
| gibi | bauzas: will push a follow up, thanks | 07:42 |
| bauzas | thanks | 07:42 |
| gibi | and good Friday morning to you too | 07:42 |
| bauzas | gibi: and I -w'd the prelude because of the xenapi change still in the gate + this one that I think which needs to be in the prelude | 07:42 |
| gibi | yeah, I kikked the xenapi series this morning with a recheck | 07:43 |
| gibi | *kicked | 07:43 |
| bauzas | I saw | 07:43 |
| *** tetsuro_ has joined #openstack-nova | 07:45 | |
| *** tetsuro has quit IRC | 07:48 | |
| *** mkrai has joined #openstack-nova | 07:50 | |
| *** martinkennelly has joined #openstack-nova | 08:02 | |
| *** yankcrime has joined #openstack-nova | 08:04 | |
| *** songwenping__ has joined #openstack-nova | 08:09 | |
| *** brinzhang0 has joined #openstack-nova | 08:09 | |
| *** songwenping_ has quit IRC | 08:12 | |
| *** brinzhang_ has quit IRC | 08:12 | |
| *** tetsuro has joined #openstack-nova | 08:20 | |
| *** tetsuro_ has quit IRC | 08:23 | |
| sean-k-mooney | o/ | 08:23 |
| sean-k-mooney | gibi: so i would still like to procee with the deprecation of the az filter and enableing the placment version by default in Victoria since its behavior is equivalent, but i think i am going to split out the Comptefilter changes and look to adress that in Wallaby when we have more time to think about it | 08:25 |
| sean-k-mooney | i dont know if we want to reuse the COMPUTE_STATUS_DISABLED trait for force down or not and i dont really want ot rush figuring that out | 08:27 |
| sean-k-mooney | i think having a sperate COMPUTE_STATUS_DOWN trait is proably more correct but that would need an os-traits release and i dont think this warrents a FFE for os-triats since its just tech debt removal | 08:28 |
| gibi | sean-k-mooney: make sense, keep the ComputeFilter then for V and please open a bug to track the problem you detected with the pre-filter | 08:28 |
| sean-k-mooney | yep i can do that that was actully going to be my question should i open a bug or blueprint. e.g. is this an oversight in the original filter that it ignore force down or a new feature | 08:29 |
| gibi | i consider this as a bug | 08:31 |
| sean-k-mooney | cool ill file one so then respin the patch to drop the computefitler changes | 08:35 |
| gibi | thanks | 08:36 |
| bauzas | sean-k-mooney: wait, what ? | 08:38 |
| bauzas | sean-k-mooney: which filter are you going to deprecate ? | 08:38 |
| *** tetsuro_ has joined #openstack-nova | 08:39 | |
| bauzas | AZFilter or ComputeFilter ? | 08:39 |
| sean-k-mooney | i was deprecating both | 08:39 |
| sean-k-mooney | but the behavior of the ComputeFilter | 08:39 |
| sean-k-mooney | is not identical to the placment prefilter for compute status | 08:39 |
| sean-k-mooney | because the prefilter does not take accound of force_down | 08:39 |
| bauzas | ok, now I better understand and yes | 08:39 |
| bauzas | I was about to say this | 08:39 |
| bauzas | but... are we considering the AZfilter deprecation for the Victoria cycle ? | 08:40 |
| sean-k-mooney | so for now im just going to depercate teh az filter then file a bug for the gap in behavior and we can figure out the correct way to handel force_down in wallaby | 08:40 |
| bauzas | I'd say it's a Wallaby thing | 08:40 |
| sean-k-mooney | bauzas: yes i was | 08:40 |
| sean-k-mooney | https://review.opendev.org/#/c/745605/ | 08:41 |
| sean-k-mooney | i have had that open for a while but only dug into the fun test fialure properly yesterday | 08:41 |
| bauzas | ok, I feel we need to talk then | 08:41 |
| bauzas | because I agree with the fact that the AZfilter is on par with the pre-filter | 08:42 |
| *** tetsuro has quit IRC | 08:42 | |
| *** derekh has joined #openstack-nova | 08:42 | |
| sean-k-mooney | i could delay this if you want by the way but if you dont have an object ot the AZfilter then i would prefer to proceed with just that | 08:42 |
| bauzas | but I know ops use filters by ordering them like they want | 08:42 |
| sean-k-mooney | yes | 08:43 |
| sean-k-mooney | but the AZ filter always goes first right | 08:43 |
| bauzas | no | 08:43 |
| sean-k-mooney | no? | 08:43 |
| bauzas | by default, ComputeFilter goes first | 08:43 |
| bauzas | and then AZ | 08:43 |
| bauzas | if we deprecate the AZ, this will change | 08:44 |
| bauzas | oh shit | 08:44 |
| bauzas | I'm wrong | 08:44 |
| openstackgerrit | Dat Le proposed openstack/nova stable/rocky: Fix unplugging VIF when migrate/resize/rebuild VM between hosts have difference VIF type https://review.opendev.org/751186 | 08:44 |
| sean-k-mooney | ya i was going to say https://review.opendev.org/#/c/745605/3/nova/conf/scheduler.py | 08:44 |
| bauzas | that's... disturbing | 08:44 |
| sean-k-mooney | it makes sense from an information gain point of view | 08:45 |
| bauzas | I'm almost sure this wasn't the case years ago | 08:45 |
| bauzas | but anyway | 08:45 |
| bauzas | in this case, this sounds legit | 08:45 |
| bauzas | sean-k-mooney: if so, I'll review your deprecation patch | 08:45 |
| sean-k-mooney | the point is in anycase to move both operation eventually to the placment query | 08:46 |
| sean-k-mooney | since in that case ordering does not matter | 08:46 |
| sean-k-mooney | at least form teh point of view of the query construction | 08:47 |
| *** tosky has joined #openstack-nova | 08:47 | |
| sean-k-mooney | bauzas: ill ping you with the update patch with just the AZfilter deprecation in a few once its ready | 08:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Spell out 3pp in vmware undeprecation reno https://review.opendev.org/751188 | 08:48 |
| sean-k-mooney | whats 3pp | 08:48 |
| sean-k-mooney | oh hehe | 08:49 |
| sean-k-mooney | third party | 08:49 |
| sean-k-mooney | i see that was bauzas nit | 08:49 |
| bauzas | sean-k-mooney: also, I left a comment on your deprecation patch, having the sheduler being underoptimized is not a performance issue | 08:51 |
| *** tetsuro_ has quit IRC | 08:53 | |
| *** xek has joined #openstack-nova | 08:53 | |
| sean-k-mooney | bauzas: thanks that said the orginal doc state that enabling the prefilter improves performance, so when i flip the docs to state its enabled by default now does it not make sense to now also state that reverting to the az filter woudl reduce performance | 08:55 |
| sean-k-mooney | bauzas: i can remove that i just basically inverted the previous statement but if you dont think it adds value ill just drop it | 08:56 |
| sean-k-mooney | bauzas: you were refering to your comment here right https://review.opendev.org/#/c/745605/3/doc/source/admin/availability-zones.rsthttps://review.opendev.org/#/c/745605/3/doc/source/admin/availability-zones.rst | 08:56 |
| sean-k-mooney | the funny thing is that change was orginally just ment to be the az filter | 08:57 |
| sean-k-mooney | i only added the compute filter when i was doing the doc update and was like waith there is a prefilter that "does the same thing" that can go too. i was wrong :( | 08:58 |
| *** vishalmanchanda has joined #openstack-nova | 09:00 | |
| *** k_mouza has joined #openstack-nova | 09:04 | |
| *** rcernin has quit IRC | 09:10 | |
| openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 09:13 |
| openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 09:13 |
| bauzas | sean-k-mooney: I know, we have a lot of docs that are wrong by saying "heh, prefilters are better for performance" | 09:14 |
| bauzas | tbc: NO | 09:15 |
| bauzas | a prefilter just allows you to get more candidates | 09:15 |
| sean-k-mooney | bauzas: that is not true | 09:15 |
| *** ratailor has joined #openstack-nova | 09:16 | |
| bauzas | filters perfomance is not an issue | 09:16 |
| sean-k-mooney | bauzas: if you enable a prefilter and disable a schduler filter the db outperform python | 09:16 |
| bauzas | sean-k-mooney: again, it's wrong | 09:16 |
| sean-k-mooney | bauzas: in general yes | 09:16 |
| bauzas | lots of folks (eg. CERN) looked at the scheduler performance | 09:16 |
| sean-k-mooney | bauzas: we have see this form operators reporting that its faster | 09:16 |
| bauzas | and none of them said that the filters were outperfomed | 09:16 |
| bauzas | the problem was with the DB | 09:17 |
| sean-k-mooney | i acutlly tought cern said it did | 09:17 |
| bauzas | not the filters | 09:17 |
| *** xek has quit IRC | 09:17 | |
| sean-k-mooney | i guess it woudl only help | 09:17 |
| sean-k-mooney | as you said if we dont return the 1000 limit on allocitons | 09:17 |
| sean-k-mooney | e.g. if it reduces the set below that | 09:17 |
| bauzas | no, the problem is that NOBODY thought about the performance for getting more than 1000 candidates | 09:17 |
| bauzas | I mean the API performance | 09:18 |
| bauzas | so we said, "ok let's limit to 1000 candidates" | 09:18 |
| bauzas | and then we said "oh but then shit, we won't then verify all the candidates" | 09:18 |
| bauzas | and then that's why we started using prefilters | 09:18 |
| sean-k-mooney | ya i know that i was there | 09:19 |
| sean-k-mooney | and NOBODY is a strech | 09:19 |
| bauzas | if the Placement API was able to provide *all* candidates, the performance in between checking all of them with a filter, or instead querying the Placement *before* wouldn't be differnet | 09:19 |
| sean-k-mooney | we did discuss the subseting problem before we started using placment | 09:19 |
| sean-k-mooney | bauzas: the different is the number of candiates pass to the schduler | 09:20 |
| bauzas | meh, the ship has sailed either way | 09:20 |
| sean-k-mooney | if we have 1000 nodes in 2 az of 500 | 09:20 |
| bauzas | again, not a problem | 09:20 |
| sean-k-mooney | the az prefilter will limit the repsoce to at most 500 | 09:20 |
| sean-k-mooney | without it all 1000 nodes asumming all other thing are equall would pass to the scudler | 09:21 |
| sean-k-mooney | and the az filter would have to filter the 500 nodes then | 09:21 |
| sean-k-mooney | which si where ordering is importnat | 09:21 |
| sean-k-mooney | and why the azfilter come before the expensive ones | 09:21 |
| sean-k-mooney | anyway i can jsut drop the last line that menations performance | 09:22 |
| bauzas | sean-k-mooney: tbc, filters aren't expensive | 09:23 |
| bauzas | even the NUMATopology one, per say | 09:23 |
| bauzas | compared to how long it takes for getting all the candidates | 09:23 |
| sean-k-mooney | that has not been my experince but i also have not seen data for large clouds | 09:24 |
| sean-k-mooney | it really jsut comes down to how many candiate you need to check | 09:24 |
| sean-k-mooney | well hosts | 09:24 |
| sean-k-mooney | bauzas: by the way we both also agree that schduling is not the slow part fo booting a vm | 09:25 |
| sean-k-mooney | bauzas: but what your really arguing is the previous docs were wrong | 09:25 |
| bauzas | sean-k-mooney: don't get me wrong | 09:26 |
| bauzas | placement is better for large clouds compared to what we had in the past | 09:26 |
| sean-k-mooney | when they said enabling the prefilter would improve performance | 09:26 |
| bauzas | sean-k-mooney: true, I'm just saying 'folks, don't trust everything written or said by someone you care" | 09:27 |
| bauzas | and rather experiment yourselves or at least look at more than a single person | 09:27 |
| * bauzas tries hard to not make a corollar with a certain molecule | 09:27 | |
| sean-k-mooney | so tl;dr drop the last line and we good ? | 09:28 |
| bauzas | I'd say so | 09:28 |
| sean-k-mooney | cool | 09:28 |
| sean-k-mooney | that also means i dont need to figure out how to adress gibis comment if i jsut delete the line :) | 09:28 |
| *** mkrai has quit IRC | 09:49 | |
| *** mkrai has joined #openstack-nova | 09:49 | |
| *** brinzhang_ has joined #openstack-nova | 09:50 | |
| *** brinzhang0 has quit IRC | 09:54 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417 | 09:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747361 | 09:56 |
| *** brinzhang0 has joined #openstack-nova | 10:04 | |
| *** brinzhang_ has quit IRC | 10:07 | |
| *** Liang__ has quit IRC | 10:09 | |
| *** ratailor_ has joined #openstack-nova | 10:09 | |
| *** ratailor has quit IRC | 10:11 | |
| *** mnaser has quit IRC | 10:11 | |
| *** donnyd has quit IRC | 10:11 | |
| *** pas-ha has quit IRC | 10:11 | |
| *** fyx has quit IRC | 10:11 | |
| *** ttx has quit IRC | 10:11 | |
| *** jrosser has quit IRC | 10:11 | |
| *** andreykurilin has quit IRC | 10:11 | |
| *** corvus has quit IRC | 10:11 | |
| *** andreykurilin has joined #openstack-nova | 10:11 | |
| *** corvus has joined #openstack-nova | 10:11 | |
| *** pas-ha has joined #openstack-nova | 10:11 | |
| *** donnyd has joined #openstack-nova | 10:11 | |
| *** jrosser has joined #openstack-nova | 10:11 | |
| *** fyx has joined #openstack-nova | 10:16 | |
| *** mnaser has joined #openstack-nova | 10:16 | |
| *** ttx has joined #openstack-nova | 10:16 | |
| *** mnaser has quit IRC | 10:17 | |
| *** mnaser has joined #openstack-nova | 10:17 | |
| *** fyx has quit IRC | 10:17 | |
| *** fyx has joined #openstack-nova | 10:17 | |
| *** brinzhang_ has joined #openstack-nova | 10:17 | |
| lyarwood | random question for the channel but does anyone know if CODEOWNERS has ever been talked about within OpenStack? https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners & https://docs.gitlab.com/ee/user/project/code_owners.html | 10:17 |
| lyarwood | I appreciate this is platform specific without us writing automation around it for opendev but it seems like a nice codeified way of keeping https://wiki.openstack.org/wiki/Nova#People up to date | 10:18 |
| *** brinzhang0 has quit IRC | 10:20 | |
| sean-k-mooney | not familar with it | 10:21 |
| *** tkajinam has quit IRC | 10:22 | |
| sean-k-mooney | but it does not really aligh with how we work since we dont have subsystem maintianers | 10:22 |
| sean-k-mooney | if we did then yes | 10:22 |
| sean-k-mooney | lyarwood: i didnt even know that existed | 10:22 |
| lyarwood | we've listed contacts for areas of the code on the wiki for years now | 10:22 |
| lyarwood | yeah I only just heard about it tbh | 10:23 |
| sean-k-mooney | right but that is not what i tought we used | 10:23 |
| sean-k-mooney | i tought we only had https://wiki.openstack.org/wiki/Nova/BugTriage | 10:23 |
| sean-k-mooney | the tag owners | 10:23 |
| lyarwood | we don't use CODEOWNERS for that, I'm suggesting we do so we can keep this in the actual git tree vs a random wiki page | 10:23 |
| * lyarwood adds it to the PTG pad | 10:24 | |
| sean-k-mooney | right but i dont think the peopel section makes sense | 10:24 |
| sean-k-mooney | the tags might | 10:24 |
| sean-k-mooney | the bullets in the people section dont correspond to files or subsystmes | 10:24 |
| lyarwood | ah sorry I was thinking about Developer Contacts | 10:26 |
| lyarwood | but anyway I'd rather this lived in tree as there appears to be tooling to do quick lookups locally | 10:27 |
| lyarwood | without relying on a given platform | 10:27 |
| sean-k-mooney | also did not know that existed | 10:27 |
| sean-k-mooney | but ya i can see it just bing a file in the git repo i guess | 10:28 |
| sean-k-mooney | just a simiple yaml file or rst in the docs under the contibutors section | 10:28 |
| sean-k-mooney | lyarwood: i wonder how much traffic if any the wiki gets | 10:29 |
| sean-k-mooney | i have very very rearly checked any of the wikis since we started using specs | 10:29 |
| sean-k-mooney | i do if google brings be there but that is very rare | 10:30 |
| lyarwood | sean-k-mooney: yeah we could also render it somehow in the docs I'm sure | 10:30 |
| lyarwood | sean-k-mooney: I also hardly ever go there, just had a patch against stable that needed to go to master first so went looking for docs | 10:31 |
| lyarwood | sean-k-mooney: found the wiki pages and recalled reading about CODEOWNERS somewhere the other day | 10:31 |
| sean-k-mooney | and the wiki was the only place? | 10:31 |
| *** bbowen has joined #openstack-nova | 10:31 | |
| *** jangutter_ has joined #openstack-nova | 10:31 | |
| *** aj_mailing has quit IRC | 10:31 | |
| sean-k-mooney | i dont know if we even mention the wiki in the contibutors guide anymore | 10:31 |
| lyarwood | sean-k-mooney: no I've linked to the contrib guide | 10:32 |
| lyarwood | sean-k-mooney: it links to the wiki in places iirc | 10:32 |
| sean-k-mooney | the only wiki page i check semi regularly is https://wiki.openstack.org/wiki/Meetings/Nova | 10:32 |
| * lyarwood -> coffee brb | 10:33 | |
| brinzhang_ | gibi: hi | 10:34 |
| brinzhang_ | gibi: https://review.opendev.org/#/c/729563/13/nova/tests/unit/compute/test_api.py@7685 here, what did your mean? | 10:34 |
| *** jangutter has quit IRC | 10:35 | |
| gibi | brinzhang_: I don't expect any change in your patch due to that comment | 10:36 |
| gibi | it is just a note why we are collecting arqs for shelve even if during shelve we dont use them | 10:37 |
| brinzhang_ | gibi: ack, thanks, I misunderstand that words | 10:37 |
| brinzhang_ | yes | 10:37 |
| gibi | sorry, I could have been clearer in my words | 10:37 |
| brinzhang_ | np, I will update later | 10:37 |
| gibi | thanks | 10:39 |
| brinzhang_ | gibi: https://review.opendev.org/#/c/729563/13/nova/tests/fixtures.py@2601 this can't change to arq_host_rp_list = CyborgFixture.bindings_by_instance.get(instance_uuid, []) | 10:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: [placement] Add status and links fields to version document at / https://review.opendev.org/751239 | 10:39 |
| brinzhang_ | in Line2601, if the arq_host_rp_list==[], that will be an error | 10:39 |
| brinzhang_ | so I will keep this not change yet | 10:39 |
| brinzhang_ | if arq_host_rp_list ==[], return [] | 10:40 |
| openstackgerrit | Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175 | 10:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/pike: [placement] Add status and links fields to version document at / https://review.opendev.org/751240 | 10:42 |
| gibi | brinzhang_: you are right, my mistake I mixed arq_host_rp_list with bound_arq_list | 10:42 |
| brinzhang_ | gibi: https://review.opendev.org/#/c/729563/13/nova/tests/fixtures.py@2557 | 10:42 |
| brinzhang_ | gibi: ack | 10:42 |
| *** brinzhang_ has quit IRC | 10:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Support old & new versions of svm and vmx traits https://review.opendev.org/660515 | 10:56 |
| *** k_mouza_ has joined #openstack-nova | 10:56 | |
| lyarwood | ^ kashyap / stephenfin ; fixed up some nits quickly if you can review and ack | 10:56 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481 https://review.opendev.org/750184 | 10:56 |
| stephenfin | lyarwood: Done. Assume kashyap will comment if he's not happy with it | 10:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Cleanup unused code https://review.opendev.org/750947 | 10:58 |
| *** k_mouza has quit IRC | 10:58 | |
| *** jsuchome has quit IRC | 10:59 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: trivial: Remove useless comment https://review.opendev.org/748475 | 11:00 |
| lyarwood | stephenfin: ^ and that | 11:00 |
| stephenfin | also done :) | 11:01 |
| *** artom has joined #openstack-nova | 11:01 | |
| *** rcernin has joined #openstack-nova | 11:06 | |
| *** songwenping_ has joined #openstack-nova | 11:13 | |
| openstackgerrit | Merged openstack/nova master: Spell out 3pp in vmware undeprecation reno https://review.opendev.org/751188 | 11:14 |
| sean-k-mooney | stephenfin: just took another pass at https://review.opendev.org/#/c/749175/3 it now has a functional test. still want a reno but could you also take a look | 11:15 |
| stephenfin | sean-k-mooney: will do | 11:16 |
| *** mkrai has quit IRC | 11:16 | |
| *** songwenping__ has quit IRC | 11:16 | |
| *** songwenping_ has quit IRC | 11:18 | |
| *** rcernin has quit IRC | 11:20 | |
| hemanth_n | sean-k-mooney: thanks for the quick review, i will work on your comments | 11:21 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 11:23 |
| *** songwenping_ has joined #openstack-nova | 11:24 | |
| sean-k-mooney | ill be deploying an sriov env later this after noon so ill try and test it there too | 11:25 |
| sean-k-mooney | i wont actully be able to test the device type changeing | 11:25 |
| sean-k-mooney | but i can atleast assert it works fine normally | 11:26 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747611 | 11:26 |
| sean-k-mooney | which i expect it will but i want to see if this fixes an edgecase i found when looking at sriov atach/detach | 11:26 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747612 | 11:26 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/751249 | 11:27 |
| sean-k-mooney | hemanth_n: i assume you would like this to be backported to all maintained branches too by the way | 11:27 |
| sean-k-mooney | i didnt see anything that would prevent that but we might want to updat the bug with the other branches since i did not do that when i triaged it | 11:28 |
| kashyap | stephenfin: Just reading the scroll, is it realted to VMX traits? | 11:30 |
| kashyap | (Ans: yes) | 11:32 |
| lyarwood | stephenfin: https://review.opendev.org/#/c/747746/4/nova/compute/resource_tracker.py - question in here, couldn't we use `reverting` here? | 11:35 |
| lyarwood | brb | 11:35 |
| *** mgariepy has quit IRC | 11:37 | |
| *** ttx has quit IRC | 11:39 | |
| *** ttx has joined #openstack-nova | 11:39 | |
| *** ttx has quit IRC | 11:40 | |
| *** ttx has joined #openstack-nova | 11:40 | |
| stephenfin | lyarwood: replied | 11:43 |
| hemanth_n | sean-k-mooney: yes would like to backport, will do | 11:44 |
| openstackgerrit | Merged openstack/nova master: Add regression test for bug 1893284 https://review.opendev.org/748779 | 11:44 |
| openstack | bug 1893284 in OpenStack Compute (nova) "Per-user quotas not scoped correctly when creating a server" [Low,In progress] https://launchpad.net/bugs/1893284 - Assigned to melanie witt (melwitt) | 11:44 |
| *** xek has joined #openstack-nova | 11:45 | |
| openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 11:46 |
| openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 11:46 |
| *** manuvakery has joined #openstack-nova | 11:47 | |
| *** raildo has joined #openstack-nova | 11:48 | |
| *** xek has quit IRC | 12:12 | |
| *** mgariepy has joined #openstack-nova | 12:19 | |
| *** k_mouza_ has quit IRC | 12:23 | |
| *** k_mouza has joined #openstack-nova | 12:27 | |
| openstackgerrit | Merged openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550 | 12:31 |
| openstackgerrit | Merged openstack/nova master: Fix an erroneous grammar in explanatory notes https://review.opendev.org/730176 | 12:31 |
| *** raildo_ has joined #openstack-nova | 12:35 | |
| *** raildo has quit IRC | 12:35 | |
| *** jangutter has joined #openstack-nova | 12:36 | |
| *** jangutter_ has quit IRC | 12:39 | |
| *** ratailor_ has quit IRC | 12:42 | |
| openstackgerrit | Merged openstack/nova master: func: Remove references to attachment_id when volume_id is used https://review.opendev.org/749664 | 12:45 |
| *** lbragstad_ has joined #openstack-nova | 12:49 | |
| *** zzzeek has quit IRC | 12:50 | |
| *** lbragstad_ is now known as lbragstad | 12:51 | |
| *** zzzeek has joined #openstack-nova | 12:51 | |
| *** raildo has joined #openstack-nova | 12:53 | |
| *** raildo_ has quit IRC | 12:53 | |
| *** zzzeek has quit IRC | 13:04 | |
| *** zzzeek has joined #openstack-nova | 13:07 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: xenapi: Remove driver and tests https://review.opendev.org/749304 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'is_xenapi' helper https://review.opendev.org/749305 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: xenapi: Remove Xen-only code paths https://review.opendev.org/749306 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'XenapiLiveMigrateData' https://review.opendev.org/749307 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Final cleanup https://review.opendev.org/749308 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_console_pool_info' API https://review.opendev.org/749311 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API https://review.opendev.org/749313 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'set_bootable' API https://review.opendev.org/749314 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove various aggregate APIs https://review.opendev.org/749317 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_per_instance_usage' API https://review.opendev.org/749318 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'os-agents' API https://review.opendev.org/749309 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove Agent, AgentList https://review.opendev.org/749310 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_all_bw_counters' API https://review.opendev.org/749312 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'reset_network' API https://review.opendev.org/749315 | 13:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'change_instance_metadata' API https://review.opendev.org/749316 | 13:11 |
| *** nweinber has joined #openstack-nova | 13:12 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: [placement] Add status and links fields to version document at / https://review.opendev.org/751239 | 13:16 |
| *** jangutter_ has joined #openstack-nova | 13:18 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/pike: [placement] Add status and links fields to version document at / https://review.opendev.org/751240 | 13:20 |
| *** jangutter has quit IRC | 13:22 | |
| *** links has quit IRC | 13:27 | |
| *** jangutter has joined #openstack-nova | 13:31 | |
| *** jangutter_ has quit IRC | 13:34 | |
| *** dave-mccowan has joined #openstack-nova | 13:45 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/747746/4/nova/compute/resource_tracker.py - final clarification | 13:49 |
| *** dave-mccowan has quit IRC | 13:50 | |
| stephenfin | lyarwood: responded | 13:52 |
| lyarwood | stephenfin: ack thanks LGTM then | 13:56 |
| *** aj_mailing has joined #openstack-nova | 14:00 | |
| *** gmann is now known as gmann_afk | 14:05 | |
| openstackgerrit | Merged openstack/nova master: Support old & new versions of svm and vmx traits https://review.opendev.org/660515 | 14:10 |
| *** jangutter_ has joined #openstack-nova | 14:22 | |
| *** aj_mailing has quit IRC | 14:22 | |
| *** aj_mailing has joined #openstack-nova | 14:22 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Correctly disable greendns https://review.opendev.org/751302 | 14:25 |
| *** jangutter has quit IRC | 14:25 | |
| artom | lyarwood, ^^ after the bug call | 14:38 |
| *** dklyle has joined #openstack-nova | 14:41 | |
| lyarwood | artom: yup already have it open | 14:43 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 14:47 |
| *** aj_mailing has quit IRC | 14:48 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | 14:48 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | 14:49 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | 14:49 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109 | 14:50 |
| *** songwenping__ has joined #openstack-nova | 14:59 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | 15:00 |
| *** mlavalle has joined #openstack-nova | 15:01 | |
| *** songwenping_ has quit IRC | 15:02 | |
| *** jangutter has joined #openstack-nova | 15:02 | |
| *** jangutter has quit IRC | 15:03 | |
| *** jangutter has joined #openstack-nova | 15:03 | |
| *** xek has joined #openstack-nova | 15:05 | |
| *** jangutter_ has quit IRC | 15:06 | |
| *** mgariepy has quit IRC | 15:07 | |
| *** xek has quit IRC | 15:19 | |
| *** mkrai has joined #openstack-nova | 15:28 | |
| *** spatel has joined #openstack-nova | 15:28 | |
| *** spatel has quit IRC | 15:32 | |
| *** zzzeek has quit IRC | 15:32 | |
| *** zzzeek has joined #openstack-nova | 15:34 | |
| gibi | have a nice weekend folks, I'm out | 15:40 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533 | 15:41 |
| *** spatel has joined #openstack-nova | 15:43 | |
| *** spatel has quit IRC | 15:48 | |
| *** spatel has joined #openstack-nova | 15:48 | |
| *** mkrai has quit IRC | 15:49 | |
| *** mgariepy has joined #openstack-nova | 15:49 | |
| *** elod has quit IRC | 15:51 | |
| *** elod has joined #openstack-nova | 15:53 | |
| *** zzzeek has quit IRC | 15:55 | |
| *** zzzeek has joined #openstack-nova | 15:56 | |
| *** hamalq has joined #openstack-nova | 15:58 | |
| *** hamalq_ has joined #openstack-nova | 15:59 | |
| *** zzzeek has quit IRC | 16:03 | |
| *** hamalq has quit IRC | 16:03 | |
| *** zzzeek has joined #openstack-nova | 16:05 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: doc: mark the max microversion for victoria https://review.opendev.org/751342 | 16:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove write_to_file. https://review.opendev.org/645087 | 16:17 |
| openstackgerrit | Merged openstack/nova stable/stein: Removed the host FQDN from the exception message https://review.opendev.org/749610 | 16:17 |
| openstackgerrit | Merged openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746 | 16:17 |
| *** derekh has quit IRC | 16:23 | |
| *** zzzeek has quit IRC | 16:26 | |
| *** zzzeek has joined #openstack-nova | 16:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: tests: Add reproducer for bug #1879878 https://review.opendev.org/751349 | 16:32 |
| openstack | bug 1879878 in OpenStack Compute (nova) ussuri "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Undecided,Confirmed] https://launchpad.net/bugs/1879878 | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: Add generic reproducer for bug #1879878 https://review.opendev.org/751350 | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: functional: Don't inherit from 'ProviderUsageBaseTestCase' https://review.opendev.org/751351 | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751352 | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: Move confirm resize under semaphore https://review.opendev.org/751353 | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: Move revert resize under semaphore https://review.opendev.org/751354 | 16:32 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Update compute rpc version alias for victoria https://review.opendev.org/751355 | 16:33 |
| *** artom has quit IRC | 16:35 | |
| *** artom has joined #openstack-nova | 16:35 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Correctly disable greendns https://review.opendev.org/751302 | 16:42 |
| *** mgariepy has quit IRC | 16:43 | |
| *** spatel has quit IRC | 16:46 | |
| *** raildo_ has joined #openstack-nova | 16:46 | |
| *** raildo has quit IRC | 16:49 | |
| *** mgariepy has joined #openstack-nova | 16:50 | |
| *** tobberydberg has quit IRC | 16:57 | |
| *** jangutter_ has joined #openstack-nova | 17:14 | |
| *** jangutter has quit IRC | 17:18 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Only allow one scheduler service in tests https://review.opendev.org/751362 | 17:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: func tests: move _run_periodics() into base class https://review.opendev.org/751363 | 17:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Helper to start computes with different HostInfos https://review.opendev.org/751364 | 17:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: tests: Add reproducer for bug #1879878 https://review.opendev.org/751365 | 17:21 |
| openstack | bug 1879878 in OpenStack Compute (nova) ussuri "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Undecided,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | 17:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Add generic reproducer for bug #1879878 https://review.opendev.org/751366 | 17:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751367 | 17:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Move confirm resize under semaphore https://review.opendev.org/751368 | 17:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Move revert resize under semaphore https://review.opendev.org/751369 | 17:21 |
| *** gyee has joined #openstack-nova | 17:31 | |
| *** tesseract has quit IRC | 17:39 | |
| *** gmann_afk is now known as gmann | 17:42 | |
| *** k_mouza has quit IRC | 17:54 | |
| *** k_mouza has joined #openstack-nova | 17:54 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/pike: DNM: zuul fix check https://review.opendev.org/751373 | 17:55 |
| *** stephenfin has quit IRC | 17:56 | |
| *** aj_mailing has joined #openstack-nova | 17:59 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/stein: DNM: zuul fix check https://review.opendev.org/751374 | 18:00 |
| *** aj_mailing has quit IRC | 18:13 | |
| *** vishalmanchanda has quit IRC | 18:20 | |
| *** manuvakery has quit IRC | 18:27 | |
| *** ralonsoh has quit IRC | 18:36 | |
| *** mriedem has joined #openstack-nova | 18:39 | |
| *** tobberydberg has joined #openstack-nova | 18:58 | |
| *** aj_mailing has joined #openstack-nova | 19:03 | |
| *** tbachman has quit IRC | 19:07 | |
| *** tbachman has joined #openstack-nova | 19:10 | |
| *** johanssone_ has joined #openstack-nova | 19:13 | |
| *** johanssone has quit IRC | 19:15 | |
| *** xek has joined #openstack-nova | 19:47 | |
| *** jangutter has joined #openstack-nova | 19:55 | |
| *** jangutter_ has quit IRC | 19:58 | |
| *** tbachman_ has joined #openstack-nova | 19:58 | |
| *** tbachman has quit IRC | 19:58 | |
| *** tbachman_ is now known as tbachman | 19:58 | |
| *** nweinber has quit IRC | 20:07 | |
| *** tbachman has quit IRC | 20:37 | |
| *** tbachman has joined #openstack-nova | 20:39 | |
| *** tbachman_ has joined #openstack-nova | 20:42 | |
| *** tbachman has quit IRC | 20:44 | |
| *** tbachman_ is now known as tbachman | 20:44 | |
| *** raildo_ has quit IRC | 21:06 | |
| openstackgerrit | Elancheran S proposed openstack/nova stable/train: Removes the delta file once image is extracted https://review.opendev.org/748035 | 21:14 |
| openstackgerrit | sean mooney proposed openstack/nova master: Deprecate filters that have been replaced by placement filters https://review.opendev.org/745605 | 21:19 |
| *** mriedem has left #openstack-nova | 21:28 | |
| *** xek has quit IRC | 21:49 | |
| openstackgerrit | Merged openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481 https://review.opendev.org/750184 | 21:56 |
| *** rcernin has joined #openstack-nova | 22:02 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Deprecate filters that have been replaced by placement filters https://review.opendev.org/745605 | 22:02 |
| *** rcernin has quit IRC | 22:03 | |
| *** rcernin has joined #openstack-nova | 22:03 | |
| *** bbowen has quit IRC | 22:09 | |
| *** mlavalle has quit IRC | 22:36 | |
| *** gyee has quit IRC | 22:46 | |
| *** hamalq has joined #openstack-nova | 23:13 | |
| *** hamalq_ has quit IRC | 23:14 | |
| *** k_mouza has quit IRC | 23:15 | |
| *** tosky has quit IRC | 23:20 | |
| *** k_mouza has joined #openstack-nova | 23:23 | |
| *** k_mouza has quit IRC | 23:28 | |
| *** k_mouza has joined #openstack-nova | 23:34 | |
| *** hamalq has quit IRC | 23:37 | |
| *** k_mouza has quit IRC | 23:38 | |
| *** k_mouza has joined #openstack-nova | 23:43 | |
| *** k_mouza has quit IRC | 23:46 | |
| openstackgerrit | Merged openstack/nova master: trivial: Remove useless comment https://review.opendev.org/748475 | 23:59 |
| openstackgerrit | Merged openstack/nova master: xenapi: Remove driver and tests https://review.opendev.org/749304 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!