| brinzhang | alex_xu: ack. | 00:00 |
|---|---|---|
| brinzhang | luyao: please review this patch https://review.opendev.org/#/c/749472/ | 00:00 |
| brinzhang | luyao: we should be have maintained document consistency | 00:01 |
| *** k_mouza has quit IRC | 00:02 | |
| *** Yumeng has quit IRC | 00:05 | |
| *** raildo__ has joined #openstack-nova | 00:05 | |
| *** raildo_ has quit IRC | 00:08 | |
| *** JamesBenson has quit IRC | 00:08 | |
| *** JamesBenson has joined #openstack-nova | 00:09 | |
| *** lemko0 has joined #openstack-nova | 00:16 | |
| *** lemko has quit IRC | 00:16 | |
| *** lemko0 is now known as lemko | 00:16 | |
| *** artom has quit IRC | 00:19 | |
| openstackgerrit | Merged openstack/nova stable/train: Add regression tests for bug #1889108 https://review.opendev.org/748494 | 00:22 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 00:22 |
| openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: Removed the host FQDN from the exception message https://review.opendev.org/749607 | 00:25 |
| *** prometheanfire has joined #openstack-nova | 00:25 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/train: Removed the host FQDN from the exception message https://review.opendev.org/749609 | 00:28 |
| *** k_mouza has joined #openstack-nova | 00:29 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: Removed the host FQDN from the exception message https://review.opendev.org/749610 | 00:29 |
| *** hoonetorg has quit IRC | 00:29 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Removed the host FQDN from the exception message https://review.opendev.org/749612 | 00:31 |
| *** raildo__ has quit IRC | 00:31 | |
| *** raildo__ has joined #openstack-nova | 00:32 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613 | 00:32 |
| *** lemko has quit IRC | 00:33 | |
| *** k_mouza has quit IRC | 00:33 | |
| *** lemko has joined #openstack-nova | 00:34 | |
| prometheanfire | fatfingering, causing me to spend hours beating head against the wall | 00:36 |
| *** hoonetorg has joined #openstack-nova | 00:41 | |
| *** sapd1_x has quit IRC | 00:48 | |
| *** lifeless has joined #openstack-nova | 01:02 | |
| *** Liang__ has joined #openstack-nova | 01:08 | |
| *** zzzeek has quit IRC | 01:11 | |
| *** zzzeek has joined #openstack-nova | 01:14 | |
| *** kaisers has quit IRC | 01:15 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/749052 | 01:20 |
| openstackgerrit | Merged openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495 | 01:27 |
| openstackgerrit | Merged openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496 | 01:27 |
| *** Yumeng has joined #openstack-nova | 01:32 | |
| *** JamesBenson has quit IRC | 01:35 | |
| *** raildo_ has joined #openstack-nova | 01:52 | |
| *** zhanglong has joined #openstack-nova | 01:54 | |
| *** raildo__ has quit IRC | 01:54 | |
| openstackgerrit | Merged openstack/nova master: Remove support for Intel CMT events https://review.opendev.org/740922 | 01:59 |
| openstackgerrit | Merged openstack/nova master: Update image_base_image_ref during rebuild. https://review.opendev.org/749205 | 01:59 |
| *** zhanglong has quit IRC | 02:12 | |
| *** zhanglong has joined #openstack-nova | 02:14 | |
| *** zhanglong has quit IRC | 02:18 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | 02:50 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | 02:51 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | 02:55 |
| *** xinranwang__ has joined #openstack-nova | 03:03 | |
| *** JamesBenson has joined #openstack-nova | 03:05 | |
| *** JamesBen_ has joined #openstack-nova | 03:09 | |
| *** JamesBenson has quit IRC | 03:10 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add note and daxio version to the vPMEM document https://review.opendev.org/749628 | 03:15 |
| *** sapd1_x has joined #openstack-nova | 03:22 | |
| *** psachin has joined #openstack-nova | 03:32 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | 03:42 |
| openstackgerrit | Akhil Gudise proposed openstack/nova master: Introduced a service UP check for host to the Rebuild path https://review.opendev.org/749531 | 03:50 |
| *** songwenping_ has joined #openstack-nova | 04:07 | |
| *** lemko has quit IRC | 04:07 | |
| *** lemko8 has joined #openstack-nova | 04:07 | |
| *** dave-mccowan has quit IRC | 04:09 | |
| *** songwenping__ has quit IRC | 04:10 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** JamesBen_ has quit IRC | 04:39 | |
| *** TheJulia has quit IRC | 04:39 | |
| *** TheJulia has joined #openstack-nova | 04:40 | |
| *** osmanlicilegi has quit IRC | 04:40 | |
| *** osmanlicilegi has joined #openstack-nova | 04:40 | |
| *** osmanlicilegi has quit IRC | 04:40 | |
| *** osmanlicilegi has joined #openstack-nova | 04:41 | |
| *** JamesBenson has joined #openstack-nova | 05:00 | |
| *** ratailor has joined #openstack-nova | 05:27 | |
| *** sapd1_x has quit IRC | 05:29 | |
| *** JamesBenson has quit IRC | 05:32 | |
| *** JamesBenson has joined #openstack-nova | 05:33 | |
| *** JamesBenson has quit IRC | 05:38 | |
| *** jsuchome has joined #openstack-nova | 05:47 | |
| *** songwenping__ has joined #openstack-nova | 05:52 | |
| *** songwenping_ has quit IRC | 05:55 | |
| *** Liang__ has quit IRC | 06:08 | |
| *** Liang__ has joined #openstack-nova | 06:10 | |
| *** raildo_ has quit IRC | 06:11 | |
| *** Liang__ has quit IRC | 06:17 | |
| *** Liang__ has joined #openstack-nova | 06:19 | |
| *** songwenping__ has quit IRC | 06:28 | |
| *** manuvakery has joined #openstack-nova | 06:33 | |
| *** links has joined #openstack-nova | 06:34 | |
| *** swp20 has joined #openstack-nova | 06:35 | |
| *** belmoreira has joined #openstack-nova | 06:36 | |
| *** JamesBenson has joined #openstack-nova | 06:38 | |
| *** JamesBenson has quit IRC | 06:43 | |
| *** gibi has joined #openstack-nova | 06:56 | |
| *** xek has joined #openstack-nova | 07:00 | |
| *** JamesBenson has joined #openstack-nova | 07:06 | |
| *** ralonsoh has joined #openstack-nova | 07:11 | |
| *** sapd1_x has joined #openstack-nova | 07:13 | |
| *** brinzhang_ has joined #openstack-nova | 07:16 | |
| *** songwenping_ has joined #openstack-nova | 07:17 | |
| *** brinzhang has quit IRC | 07:19 | |
| *** tesseract has joined #openstack-nova | 07:19 | |
| *** yoctozepto2 has joined #openstack-nova | 07:20 | |
| *** swp20 has quit IRC | 07:21 | |
| *** yoctozepto has quit IRC | 07:22 | |
| *** yoctozepto2 is now known as yoctozepto | 07:22 | |
| *** JamesBenson has quit IRC | 07:24 | |
| *** zhanglong has joined #openstack-nova | 07:32 | |
| gibi | sean-k-mooney: is there anything we are still waiting to land in os-vif or I can approve the propoesd release? | 07:38 |
| *** tosky has joined #openstack-nova | 07:40 | |
| bauzas | good morning | 07:44 |
| gibi | good morning | 07:46 |
| suryasingh | Good Morning gibi bauzas | 07:47 |
| *** zhanglong has quit IRC | 07:50 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove no-op fake calls from network_info tests https://review.opendev.org/749661 | 07:50 |
| *** songwenping__ has joined #openstack-nova | 07:55 | |
| *** zhanglong has joined #openstack-nova | 07:56 | |
| *** avolkov has joined #openstack-nova | 07:56 | |
| *** gyee has quit IRC | 07:57 | |
| *** songwenping_ has quit IRC | 07:58 | |
| gibi | sean-k-mooney: I'm building on the existing libvirt sriov functional test but not depending on stephenfin's cleanup series for that. I'm willing to rebase and resolve conflicts when the cleanup merge | 07:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Remove references to attachment_id when volume_id is used https://review.opendev.org/749664 | 07:59 |
| *** ratailor has quit IRC | 08:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: resolve ResourceProviderSyncFailed issue https://review.opendev.org/749668 | 08:13 |
| *** brinzhang0 has joined #openstack-nova | 08:13 | |
| brinzhang0 | alex_xu, gibi: luyao has checked the change of vPMEM dependencies, please review https://review.opendev.org/#/q/topic:bug/1894022+(status:open+OR+status:merged) | 08:15 |
| *** brinzhang0 has quit IRC | 08:16 | |
| *** brinzhang0 has joined #openstack-nova | 08:16 | |
| *** brinzhang_ has quit IRC | 08:16 | |
| *** martinkennelly has joined #openstack-nova | 08:26 | |
| *** brinzhang0 has quit IRC | 08:33 | |
| *** brinzhang0 has joined #openstack-nova | 08:33 | |
| *** ebbex has quit IRC | 08:37 | |
| *** brinzhang0 has quit IRC | 08:39 | |
| *** vishalmanchanda has joined #openstack-nova | 08:39 | |
| *** brinzhang0 has joined #openstack-nova | 08:39 | |
| *** brinzhang has joined #openstack-nova | 08:39 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Add devstack-plugin-ceph-compute-local-eph to the experimental queue https://review.opendev.org/743220 | 08:43 |
| *** ebbex has joined #openstack-nova | 08:44 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Add devstack-plugin-ceph-compute-local-ephemeral to experimental https://review.opendev.org/743220 | 08:45 |
| *** derekh has joined #openstack-nova | 08:47 | |
| *** priteau has joined #openstack-nova | 08:49 | |
| jkulik | stephenfin, may I ask you something? How small/large should I make the changes for the oslo.vmware SOAP library switch. Downstream, I keep commits small and let them only do one thing, but I'm not sure posting 7 patches for review upstream is the best way, if some of them only contain ~3 line changes to a new attribute. | 08:50 |
| stephenfin | jkulik: Small changes are fine | 08:51 |
| stephenfin | Probably better, in fact. They're easier to review | 08:51 |
| jkulik | ok then, thank you | 08:51 |
| *** zhanglong has quit IRC | 08:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745 | 08:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746 | 08:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim' https://review.opendev.org/747747 | 08:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Address TODO https://review.opendev.org/747748 | 08:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674 | 08:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | 08:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | 08:56 |
| *** sapd1_x has quit IRC | 08:59 | |
| *** sapd1_x has joined #openstack-nova | 08:59 | |
| *** xinranwang__ has quit IRC | 09:00 | |
| openstackgerrit | Merged openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560 | 09:04 |
| openstackgerrit | Merged openstack/nova master: Add note and daxio version to the vPMEM document https://review.opendev.org/749628 | 09:04 |
| openstackgerrit | Merged openstack/nova master: Remove no-op fake calls from network_info tests https://review.opendev.org/749661 | 09:04 |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/ussuri: Add note and daxio version to the vPMEM document https://review.opendev.org/749681 | 09:05 |
| *** dtantsur|afk is now known as dtantsur | 09:06 | |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware: Use cookiejar from oslo.vmware client directly https://review.opendev.org/749682 | 09:07 |
| openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | 09:14 |
| *** damien_r has joined #openstack-nova | 09:29 | |
| gibi | dansmith: hi! can we finalize documentation for the multistore spec? https://review.opendev.org/#/c/731577/ | 09:33 |
| gibi | dansmith: I would like to mention that feature in the cycle highlights and link to the documentation | 09:33 |
| *** Liang__ has quit IRC | 09:36 | |
| *** sapd1_x has quit IRC | 09:36 | |
| gibi | stephenfin: could you hit this doc patch about rdb export https://review.opendev.org/#/c/728411 ? | 09:46 |
| stephenfin | sure | 09:46 |
| gibi | thanks | 09:46 |
| lyarwood | gibi: that needs to be updated | 09:47 |
| stephenfin | lyarwood: I'd say I've pointed out why? | 09:48 |
| stephenfin | (wrong section for conf options) | 09:48 |
| * lyarwood refreshes | 09:48 | |
| stephenfin | lyarwood: Got time to do the respin quickly while we're looking at it? I can do so if not | 09:50 |
| lyarwood | stephenfin: yeah I can | 09:51 |
| gibi | thanks ^^ | 09:52 |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749698 | 10:00 |
| *** rcernin has quit IRC | 10:01 | |
| lyarwood | stephenfin: stupid question, but how would you list user defined things like rbd_user etc | 10:02 |
| lyarwood | stephenfin: rbd_user=$rbd_user or rbd_user=foo etc? | 10:02 |
| stephenfin | can you rephrase that? | 10:02 |
| stephenfin | oh | 10:02 |
| stephenfin | really up to you. I prefer dummy values that somewhat resemble reality | 10:02 |
| stephenfin | http://example.com for URLs, 1.2.3.4 for IP addresses etc. | 10:03 |
| lyarwood | meh I was thinking that could confuse people tbh | 10:03 |
| lyarwood | kk | 10:03 |
| stephenfin | Yeah, tbc that's just what I do. I don't know if there are recommendations in the OpenStack Style Guide or not | 10:03 |
| *** rcernin has joined #openstack-nova | 10:06 | |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749698 | 10:08 |
| openstackgerrit | Yao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume https://review.opendev.org/749489 | 10:10 |
| brinzhang | stephenfin: thanks, done ^ | 10:11 |
| *** rcernin has quit IRC | 10:11 | |
| stephenfin | brinzhang: I think you need to abandon that and re-propose with the same change ID as the original | 10:14 |
| brinzhang | stephenfin: ack, let me try | 10:16 |
| stephenfin | alex_xu: Could I ask you to review https://review.opendev.org/#/c/747745/ with the expectation that I'll fix the live migration path also but in a separate, follow-up change? | 10:19 |
| *** rcernin has joined #openstack-nova | 10:19 | |
| brinzhang | stephenfin: I cannot run git commit, if I run git commit -s, is it ok? | 10:20 |
| brinzhang | root@ubuntu-OpenStack:/home/my_work/code/backup/nova# git commit | 10:20 |
| brinzhang | Unova/compute/api.py | 10:20 |
| brinzhang | Unova/tests/unit/compute/test_compute_api.py | 10:20 |
| brinzhang | error: Committing is not possible because you have unmerged files. | 10:20 |
| brinzhang | hint: Fix them up in the work tree, and then use 'git add/rm <file>' | 10:20 |
| brinzhang | hint: as appropriate to mark resolution and make a commit. | 10:20 |
| brinzhang | fatal: Exiting because of an unresolved conflict. | 10:20 |
| stephenfin | oh, sorry, 'git add <changed files>' | 10:20 |
| stephenfin | then commit | 10:20 |
| brinzhang | ^ | 10:20 |
| stephenfin | I think 'git cherry-pick --continue' will work instead of 'git commit', but that also needs the merge conflict marked as resolved using 'git add' or whatever | 10:21 |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749701 | 10:22 |
| brinzhang | stephenfin: yes, we cannot run "git cherry-pick --continue", that will generate a new commit message | 10:22 |
| brinzhang | and I tried many times in my evn, I think I get the way to cherry-pick if there is a conflict in the stable release | 10:23 |
| *** rcernin has quit IRC | 10:24 | |
| brinzhang | stephenfin: good guideline, thanks ^^ | 10:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Adapt the admin guide to describe the direct RBD export https://review.opendev.org/728411 | 10:31 |
| lyarwood | stephenfin: ^ sorry had to deal with something downstream | 10:31 |
| *** rcernin has joined #openstack-nova | 10:31 | |
| songwenping__ | bauzas: hi, my ubuntu env is ok now. i set two vgpu_types and vgpu_nvidia-180 and vgpu_nvidia-181 in nova-compute.conf, but i cant get vgpu_nvidia-180 and vgpu-nvidia-181 group. | 10:32 |
| *** priteau has quit IRC | 10:33 | |
| songwenping__ | i find the _get_supported_vgpu_types function is first called and then register_dynamic_opts is called. | 10:36 |
| *** rcernin has quit IRC | 10:36 | |
| songwenping__ | so when i boot vm with vgpu flavor, i cant get device_addresses. | 10:38 |
| songwenping__ | sean-k-mooney: hi, i reinstall vgpu-kvm.run package and restart my host, i can find nvidia-* at /sys/class/mdev_bus/0000\:af\:00.0/mdev_supported_types/. | 10:46 |
| *** songwenping_ has joined #openstack-nova | 10:48 | |
| *** priteau has joined #openstack-nova | 10:49 | |
| *** brinzhang_ has joined #openstack-nova | 10:49 | |
| *** songwenping__ has quit IRC | 10:51 | |
| *** brinzhang has quit IRC | 10:52 | |
| *** priteau has quit IRC | 10:54 | |
| *** JamesBenson has joined #openstack-nova | 11:00 | |
| *** priteau has joined #openstack-nova | 11:03 | |
| *** k_mouza has joined #openstack-nova | 11:08 | |
| alex_xu | stephenfin: yea, will take a look at | 11:10 |
| *** priteau has quit IRC | 11:11 | |
| *** k_mouza has quit IRC | 11:14 | |
| *** jangutter has joined #openstack-nova | 11:16 | |
| *** jangutter_ has quit IRC | 11:20 | |
| *** Yumeng has quit IRC | 11:22 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver https://review.opendev.org/749707 | 11:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_QEMU_VTPM https://review.opendev.org/749708 | 11:24 |
| *** lpetrut has joined #openstack-nova | 11:47 | |
| CeeMac | afternoon | 11:59 |
| CeeMac | is it possible to 'retrofit' a qemu guest agent channel to a volume backed instance after deployment? | 11:59 |
| *** xek has quit IRC | 12:00 | |
| CeeMac | if i dumpxml for the domain of an instance that has it enabled and working in can see the unix device with the sock binding etc | 12:00 |
| CeeMac | this device is missing from the other instance that weren't deployed from an image with the guest agent metadata tag | 12:00 |
| CeeMac | wasn't sure if there was a way to generate the sock and binding manually and update the xml / refresh the instance? | 12:00 |
| CeeMac | I've tried adding the metadata item to the instance and power cycling but no dice | 12:01 |
| *** priteau has joined #openstack-nova | 12:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reproducer for bug #1894095 https://review.opendev.org/749713 | 12:03 |
| openstack | bug 1894095 in OpenStack Compute (nova) "Running periodic task during live migration results in incorrect usage" [Medium,Confirmed] https://launchpad.net/bugs/1894095 - Assigned to Stephen Finucane (stephenfinucane) | 12:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Move live migration rollback under semaphore https://review.opendev.org/749714 | 12:03 |
| *** JamesBenson has quit IRC | 12:04 | |
| *** raildo has joined #openstack-nova | 12:04 | |
| stephenfin | CeeMac: There isn't any way to modify that kind of configuration without a rebuild (new image) or resize (new flavor), unfortunately | 12:07 |
| stephenfin | and the latter isn't an option because, weirdly, there's no equivalent flavor extra spec for the image metadata property | 12:08 |
| CeeMac | ah | 12:08 |
| CeeMac | boo, i was about to jump on that as a workable option | 12:08 |
| CeeMac | its an odd one | 12:08 |
| stephenfin | Well I don't see any reason we couldn't add the latter | 12:08 |
| stephenfin | though I'm not sure about backportability | 12:08 |
| CeeMac | as just having the metadata on the image isn't sufficient for it to work on a volume backed image, the metadata also needs adding to the instance at point of deployment from what I can see | 12:09 |
| stephenfin | if it was reasonable to do but not backportable, you'd have to carry that yourself/prod your vendor to carry the backport downstream | 12:09 |
| CeeMac | sure | 12:09 |
| CeeMac | thanks stephenfin very helpful, if not much help :D | 12:10 |
| CeeMac | I figured this would be the case though, just wanted some validation I wasn't going mad | 12:10 |
| CeeMac | now I know, so I'll need to work around it | 12:10 |
| CeeMac | i'm still on rocky, so I'm not sure the backport option would be acceptable, its probably fairly niche as far as requirements go | 12:11 |
| *** nightmare_unreal has joined #openstack-nova | 12:15 | |
| *** JamesBenson has joined #openstack-nova | 12:19 | |
| *** JamesBenson has quit IRC | 12:23 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744552 | 12:30 |
| *** lemko8 has quit IRC | 12:32 | |
| *** lemko has joined #openstack-nova | 12:33 | |
| *** jangutter_ has joined #openstack-nova | 12:35 | |
| *** jangutter has quit IRC | 12:39 | |
| *** ralonsoh has quit IRC | 12:51 | |
| *** ralonsoh has joined #openstack-nova | 12:52 | |
| *** nweinber has joined #openstack-nova | 12:54 | |
| *** rcernin has joined #openstack-nova | 12:59 | |
| *** rcernin has quit IRC | 13:04 | |
| *** psachin has quit IRC | 13:08 | |
| *** dave-mccowan has joined #openstack-nova | 13:11 | |
| *** sapd1_x has joined #openstack-nova | 13:19 | |
| *** jangutter has joined #openstack-nova | 13:21 | |
| *** jangutter_ has quit IRC | 13:23 | |
| *** JamesBenson has joined #openstack-nova | 13:25 | |
| *** jangutter has quit IRC | 13:26 | |
| *** jangutter has joined #openstack-nova | 13:27 | |
| *** jangutter has quit IRC | 13:29 | |
| *** jangutter has joined #openstack-nova | 13:30 | |
| *** artom has joined #openstack-nova | 13:37 | |
| *** xek has joined #openstack-nova | 13:38 | |
| *** spatel has joined #openstack-nova | 13:40 | |
| *** sapd1_x has quit IRC | 13:40 | |
| *** spatel has quit IRC | 13:44 | |
| dansmith | gibi: ++ for mentioning in the highlights, especially since a lot of cross-project collab has come out of it | 13:49 |
| dansmith | gibi: I was kinda waiting for lyarwood to come back (which he did a while ago) and hopefully get some more meat in that doc about general rbd setup instructions and choices | 13:49 |
| dansmith | gibi: since it's not as helpful to have a "so assume you already know a lot about a not-very-well-documented feature, here's some more details" doc | 13:50 |
| *** Luzi has joined #openstack-nova | 13:50 | |
| lyarwood | dansmith: yeah sorry did you have a draft change somewhere for that? | 13:55 |
| dansmith | lyarwood: yeah | 13:56 |
| dansmith | lyarwood: https://review.opendev.org/#/c/731577/ | 13:56 |
| lyarwood | dansmith: cool thanks, I'll try to sort something out shortly | 13:56 |
| dansmith | lyarwood: thanks, sorry to play the "shame is a powerful motivator" card :P | 13:56 |
| lyarwood | dansmith: np I said I would do this and totally forgot so it's valid :) | 13:57 |
| artom | gibi, was a func test for https://review.opendev.org/#/c/748453/ ever discussed? | 13:57 |
| dansmith | :) | 13:57 |
| sean-k-mooney | artom: not for that but there are some func tests later in the series | 13:59 |
| sean-k-mooney | in https://review.opendev.org/#/c/740995/14 | 13:59 |
| CeeMac | stephenfin: I managed to find a workable solution! | 14:00 |
| sean-k-mooney | for what its worth i do think the first 4 patches in the series are ready to merge if we can get more core eyes on them | 14:00 |
| sean-k-mooney | the following 3 im re reviewing | 14:00 |
| artom | sean-k-mooney, afaict those tests don't have both SRIOV and NUMA in the same instance | 14:01 |
| stephenfin | CeeMac: Nice. What did you do? | 14:01 |
| artom | And don't test live migration | 14:01 |
| artom | sean-k-mooney, would be reasonable to ask for that, no? | 14:01 |
| sean-k-mooney | it would be valid | 14:01 |
| artom | We should have the framework(s) in place already... | 14:01 |
| sean-k-mooney | i cloud re run my sriov testing with numa guest too i guess | 14:02 |
| sean-k-mooney | i tested live migration with seriov but not of a numa instance | 14:02 |
| sean-k-mooney | i still suspect "Make PCI claim NUMA aware during live migration" is incomplte but its strictly better then what we did before | 14:03 |
| * stephenfin always forgets PCI is not one of those things that results in implicit NUMA topologies | 14:03 | |
| CeeMac | stephenfin: as the instance is volume backed, I removed the instance (keeping the volume), set the hw_qemu_guest_agent=yes image-property on the volume. Launched a new instance from the volume settings hw_qemu_guest_agent=yes as customer meta-data. | 14:03 |
| lyarwood | elod / melwitt ; thanks for the reviews again! https://review.opendev.org/#/q/topic:bug/1889108+branch:stable/stein should be ready now if you have time | 14:04 |
| CeeMac | unix socket is created, guest-ping works from host :D | 14:04 |
| sean-k-mooney | CeeMac: ya that shoudl work | 14:04 |
| *** links has quit IRC | 14:04 | |
| sean-k-mooney | since we will pull the volume metadata for the new isntance | 14:05 |
| stephenfin | CeeMac: Great to hear :) If you've time and are set up for Gerrit, that'd be a nice little footnote to include in the 'doc/source/admin/configuration/hypervisor-kvm.rst' doc. | 14:05 |
| stephenfin | If not, at least you're sorted | 14:05 |
| *** jsuchome has quit IRC | 14:06 | |
| CeeMac | stephenfin: i have gerrit set up | 14:06 |
| CeeMac | whats the process for updating the doc? | 14:06 |
| CeeMac | haven't done that yet | 14:06 |
| stephenfin | CeeMac: you'll want to clone the nova repo and edit the source doc at 'doc/source/admin/configuration/hypervisor-kvm.rst' | 14:06 |
| CeeMac | just master? | 14:06 |
| stephenfin | That's rendered and results in https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm | 14:07 |
| stephenfin | Yeah, we can cherry-pick it back then | 14:07 |
| elod | lyarwood: will do! to tell you the truth it's a bit too many refactoring patch backport for my taste :/ | 14:07 |
| stephenfin | backport it | 14:07 |
| CeeMac | i'll give it a go! | 14:08 |
| lyarwood | elod: yeah I appreciate that, some of these should've already been backported as bugfixes tbh | 14:09 |
| lyarwood | elod: but the func changes are required to actually test this correctly | 14:09 |
| lyarwood | elod: and it's all pretty trivial IMHO | 14:09 |
| *** eharney has quit IRC | 14:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver https://review.opendev.org/749707 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 14:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 14:11 |
| elod | lyarwood: ok, i see. I'll try to overcome my taste o:) | 14:15 |
| CeeMac | stephenfin: is there a topic naming convention for branching? | 14:16 |
| artom | sean-k-mooney, wait, we didn't add any functional tests for SRIOV live migration? | 14:17 |
| artom | sean-k-mooney, all I see is the PCI stuff - ie, not Neutron ports, but flavor-driven | 14:17 |
| stephenfin | CeeMac: If it's a bug, bug/<bug-id>. Because you likely want this backported, I'd suggest opening one if you can? | 14:17 |
| sean-k-mooney | artom: not without stephenfin patch set | 14:17 |
| stephenfin | artom: I have it done but it didn't exist previously, no | 14:17 |
| stephenfin | It was a lot of work, in fairness | 14:17 |
| artom | stephenfin, it merged? | 14:17 |
| artom | Link plz? | 14:17 |
| sean-k-mooney | no | 14:17 |
| CeeMac | stephenfin: sure I can open a bug for this | 14:18 |
| sean-k-mooney | its conflicting wiht many things | 14:18 |
| stephenfin | https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:sriov-functional-tests | 14:18 |
| CeeMac | i'll grab a coffee first! | 14:18 |
| sean-k-mooney | artom: specificaly its conflicting with both my live migration bug fix your live migration bug fix and gibi sriov attach/detach series | 14:18 |
| stephenfin | CeeMac: Sure thing :) | 14:18 |
| artom | sean-k-mooney, sounds about right | 14:19 |
| sean-k-mooney | the conflict are not surpriseing since we are all modifying similar parts fo the code | 14:19 |
| sean-k-mooney | and adding tests | 14:19 |
| *** eharney has joined #openstack-nova | 14:19 | |
| artom | stephenfin, wait, how does https://review.opendev.org/#/c/746950/6 pass if you're depending on gibi's NUMA SRIOV live migration fix? | 14:19 |
| stephenfin | artom: I'm not. His fix is for a certain edge condition I'm not triggering | 14:20 |
| sean-k-mooney | it does not depend on it | 14:20 |
| stephenfin | I did try to add a test for it but clearly didn't understand the bug enough | 14:20 |
| artom | Err, *you're not | 14:20 |
| stephenfin | *well enough | 14:20 |
| sean-k-mooney | stephenfin: by edgecase you mean the fact we dont consider the numa toplogy of the guest at all right now | 14:21 |
| artom | Also, having NUMA and SRIOV in the same instance is not an edge condition :) | 14:21 |
| artom | Unless I'm way off base on that bug | 14:21 |
| stephenfin | sean-k-mooney: it's to do with the claiming bit right? | 14:21 |
| sean-k-mooney | yes | 14:21 |
| sean-k-mooney | when we claim we pass None currenlty | 14:21 |
| stephenfin | okay, so I have https://review.opendev.org/#/c/749360/ | 14:21 |
| artom | stephenfin, ah, you're not using NUMA | 14:22 |
| artom | Just SRIOV | 14:22 |
| stephenfin | but the guest NUMA topology appears to be getting correctly recalculated to ensure the instance lands on the same host NUMA node as the PCI device | 14:22 |
| artom | Not in the same test, at least | 14:22 |
| stephenfin | I am in that one | 14:22 |
| stephenfin | I'm using CPU pinning | 14:22 |
| stephenfin | that's NUMA | 14:22 |
| stephenfin | https://review.opendev.org/#/c/749360/1/nova/tests/functional/libvirt/test_pci_sriov_servers.py@363 | 14:23 |
| sean-k-mooney | it could be passing jsut out of luck | 14:24 |
| artom | Interesting, I wonder if there's a specific assertion that's missing | 14:24 |
| sean-k-mooney | you would need to force a case where cpus are only avaiable on one node and the pci device is on another | 14:24 |
| sean-k-mooney | with the bug it would boot | 14:24 |
| stephenfin | sean-k-mooney: Yeah, I think that's what I'm missing | 14:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744552 | 14:24 |
| stephenfin | But I wasn't able to come up with a clever way to do that since conf is global :-( | 14:25 |
| sean-k-mooney | by the way gibi's fix i dont thnk it a full fix | 14:25 |
| *** jangutter_ has joined #openstack-nova | 14:25 | |
| sean-k-mooney | since we are claiming the devices at a different point then we are generating the numa toplogy there is always a race with outher vms unless this is all happening under a common lock | 14:25 |
| sean-k-mooney | and i dont think it is | 14:26 |
| sean-k-mooney | gibi's patch makes the code stricly better | 14:26 |
| sean-k-mooney | but it does not make the numa toplogy generation and pci claims effectly atomic | 14:26 |
| *** jangutter has quit IRC | 14:28 | |
| stephenfin | I'm getting the impression, based on those resize/cold migrate resize/confirm bugs, that pretty much everything the resource tracker is doing has to be atomic | 14:31 |
| sean-k-mooney | where we dont have tristate logic like the pci tracker yes definetly | 14:31 |
| sean-k-mooney | but in general yes | 14:32 |
| sean-k-mooney | that is why we have the lock | 14:32 |
| artom | The whole periodic using the migrations and flavors and instances is a mess | 14:33 |
| artom | Kinda makes me wonder if there's a still a point to it... | 14:35 |
| artom | We've gotten a lot better at making migrations correctly track resources, especially live migrations | 14:35 |
| artom | Might make more sense to address the remaining gaps, and then remove it altogether | 14:35 |
| artom | Or make it a nova-manager command, with a lock | 14:35 |
| artom | Kinda like the placement audit thing | 14:35 |
| sean-k-mooney | you mean in placment | 14:36 |
| sean-k-mooney | in theory you should be abel to run nova with that periodic disabled | 14:36 |
| sean-k-mooney | in paratics i expect that to be super broken | 14:37 |
| *** dklyle has joined #openstack-nova | 14:37 | |
| artom | sean-k-mooney, no, I mean fix the remaining problems with resources not being correctly updated | 14:37 |
| artom | And stop running the periodic | 14:37 |
| sean-k-mooney | yes but that means basicaly persit stuff to the db properly | 14:38 |
| sean-k-mooney | so stop usign move cliams and claims in general in memory and actully claim the stuff in the db atomicly | 14:38 |
| artom | Well claims do update the usage eventually | 14:40 |
| sean-k-mooney | part of the reason we have to rebuild the resouce state form flaovr/instance/migration is because we dont store it anywhere but in memory | 14:40 |
| sean-k-mooney | artom: sure but if you restart the agent then you have to rebuild the state again on start up | 14:40 |
| sean-k-mooney | form the migrations and isntance exctra | 14:41 |
| *** ralonsoh has quit IRC | 14:41 | |
| artom | sean-k-mooney, https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L344 | 14:41 |
| *** ralonsoh has joined #openstack-nova | 14:42 | |
| sean-k-mooney | yes that update teh compute nodes table | 14:42 |
| sean-k-mooney | that is not the same thing | 14:42 |
| sean-k-mooney | oh thats in the move claim | 14:42 |
| sean-k-mooney | its not updateign the db | 14:43 |
| sean-k-mooney | its updating the resouce tracker | 14:43 |
| artom | How so? | 14:43 |
| artom | sean-k-mooney, https://github.com/openstack/nova/blob/c57d52e1978210fb3260bf8ea442237d548db576/nova/compute/resource_tracker.py#L1185 | 14:43 |
| sean-k-mooney | the compute node table does not containe all the data in the resouce tracker | 14:44 |
| sean-k-mooney | just a summary | 14:44 |
| sean-k-mooney | it has non of the vgpu mdeves for example | 14:44 |
| artom | Aren't those in placement? | 14:44 |
| sean-k-mooney | no | 14:44 |
| sean-k-mooney | the count of how many we can create is | 14:44 |
| *** xek has quit IRC | 14:45 | |
| artom | But we have to care about the specific individual ones like we do with PCPUs? | 14:45 |
| sean-k-mooney | not the mdev paths for the vgpu instnace | 14:45 |
| sean-k-mooney | artom: yes and no | 14:45 |
| sean-k-mooney | artom: if you have multiple devices or multipel mdev_types enabled on the host yes | 14:46 |
| sean-k-mooney | artom: we create one RP per pGPU | 14:46 |
| sean-k-mooney | so the allcoation need to be collated to the correct pgpu on the host and the mdev need to be created form that gpu | 14:46 |
| sean-k-mooney | that info is stored only in memory | 14:46 |
| sean-k-mooney | well we also parse the libvirt xmls when the agent restarts too | 14:47 |
| *** manuvakery has quit IRC | 14:47 | |
| artom | The host capabilities you mean? | 14:47 |
| sean-k-mooney | no what do you mean by host capablities | 14:48 |
| artom | You said XML | 14:48 |
| artom | I'm asking *which* XML :) | 14:48 |
| sean-k-mooney | yes i ment the domain xml | 14:48 |
| artom | Ah, that lists the mdevs that each instance uses | 14:48 |
| sean-k-mooney | when the agent restarts since we dont store the mdev a vm is using in the db we have to look it up for the running vms | 14:49 |
| artom | Hrmpf :( | 14:49 |
| sean-k-mooney | i argued it shoudl be stored in the db either in its own tabel or in the host numa toplogy blob | 14:49 |
| sean-k-mooney | for what its worth | 14:49 |
| sean-k-mooney | its true that in generall the uuid we use does not matter to the vm | 14:50 |
| *** lpetrut has quit IRC | 14:50 | |
| sean-k-mooney | but there are edgecase where we do care like agent restart | 14:50 |
| sean-k-mooney | artom: for what its wort we have added a new generic resouce filed ot the instance_extra_tables | 14:51 |
| sean-k-mooney | https://github.com/openstack/nova/commit/6a4d6ec786bb35b0bf81d91b867d55f4f8b1e32d | 14:51 |
| sean-k-mooney | that could be used for mdev for vgpus too if we wanted | 14:51 |
| sean-k-mooney | it was created to be generic so we could reuse it | 14:52 |
| sean-k-mooney | its currently only used for pmem | 14:52 |
| sean-k-mooney | the pmem resouce are also not in the comptue nodes table unless they are embeed in say the host numa_toplogy bolb | 14:53 |
| sean-k-mooney | unless i missed something | 14:53 |
| artom | I don't have enough context, but maybe they don't need to be persisted in the DB? | 14:54 |
| artom | Like, what does it affect? For scheduling, we only need to know quantities of mdevs, not individual ones, no? | 14:54 |
| sean-k-mooney | we do but we use placement for the sechduling aspect | 14:55 |
| sean-k-mooney | artom: for vGPUs you mean | 14:55 |
| artom | sean-k-mooney, yeah, for example | 14:55 |
| artom | Building the XML of new instances? Do we need to now the paths of available mdevs? | 14:55 |
| sean-k-mooney | quantity and mdev_type which can be tracked via triats is enough in that specific case | 14:56 |
| sean-k-mooney | artom: we need to create an mdev and put the path in the xml | 14:56 |
| artom | So based on that seems like not tracking them was maybe the correct choice? | 14:56 |
| sean-k-mooney | yes and no | 14:56 |
| sean-k-mooney | it creates a depenency on the domain xmls for running guest | 14:57 |
| sean-k-mooney | but it was doable without the db level tracking | 14:57 |
| sean-k-mooney | so we did not modify the db | 14:57 |
| artom | You mean for stuff like hard reboot? | 14:57 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/nova master: Raise 409 when removing security group from instance https://review.opendev.org/735572 | 14:57 |
| sean-k-mooney | since we coudl rely on plamcnet for atomic claims of resouces we coudl skip doning that in nova | 14:58 |
| artom | OTOH, it's not like vGPUs have state, so if it gets a different mdev after hard reboot, does it really matter? | 14:58 |
| artom | sean-k-mooney, definitely agree with the general idea | 14:58 |
| sean-k-mooney | if the mdev type does not change no | 14:58 |
| sean-k-mooney | for pmem its much more important | 14:58 |
| sean-k-mooney | which is why we now have https://github.com/openstack/nova/blob/c57d52e1978210fb3260bf8ea442237d548db576/nova/objects/resource.py | 14:59 |
| *** manuvakery has joined #openstack-nova | 14:59 | |
| sean-k-mooney | so that we can do this genericly | 14:59 |
| artom | sean-k-mooney, ah, so for when it matters we *do* persist it in the DB | 14:59 |
| sean-k-mooney | we do now yes | 14:59 |
| sean-k-mooney | and we have a generic way to do it in the future without db modficiations | 14:59 |
| sean-k-mooney | its one of the thing i pushed for durign the pmem stuff which alex_xu and other kindly implemented | 15:00 |
| *** belmoreira has quit IRC | 15:00 | |
| artom | sean-k-mooney, so yeah, NUMA in placement would be nice, and would solve a whole bunch of problems, but it's a mess to make work, so here we are ^_^ | 15:01 |
| sean-k-mooney | this really doesnt have that much to do with numa in placment although this generic resouce field would allow use to too remove teh numa blobs if we had that | 15:02 |
| sean-k-mooney | we would still have to do the resouce tracking in the db using this but its an alternitive | 15:02 |
| sean-k-mooney | im not sure its worth the work to move it | 15:02 |
| *** jangutter has joined #openstack-nova | 15:03 | |
| *** lpetrut has joined #openstack-nova | 15:03 | |
| sean-k-mooney | but for example if we start support vdpa devices in the futrue | 15:03 |
| sean-k-mooney | i would proably look to use this or extend the pci tracker | 15:03 |
| sean-k-mooney | (just the type filed) | 15:04 |
| sean-k-mooney | but we should not need to modify the db to add support for vdpa | 15:04 |
| sean-k-mooney | or if we wanted to add orther host device passhtough support like block devices or usb devices | 15:05 |
| sean-k-mooney | the resouce filed can be used for that | 15:05 |
| *** jangutter_ has quit IRC | 15:06 | |
| sean-k-mooney | the limitation is that to use it you have to frist track the resouce in placment | 15:07 |
| *** jangutter_ has joined #openstack-nova | 15:07 | |
| *** ganso has quit IRC | 15:08 | |
| *** dosaboy has quit IRC | 15:10 | |
| *** jangutter has quit IRC | 15:11 | |
| artom | sean-k-mooney, yeah, I meant more in the general sense of "using placement for atomic resource tracking" | 15:13 |
| sean-k-mooney | artom: well it will never actully do that | 15:14 |
| sean-k-mooney | it will track capastity | 15:14 |
| sean-k-mooney | but not indiviual resouces | 15:14 |
| artom | sean-k-mooney, yeah, inventories | 15:14 |
| artom | (In retrospect, maybe that was a mistake?) | 15:14 |
| sean-k-mooney | it was a deliberate design choice | 15:14 |
| artom | I know | 15:14 |
| sean-k-mooney | we knew the concequece was the resouce tracker would alwys be needed for assignment | 15:15 |
| artom | Just saying, maybe not the correct one to make - though obviously hindsight is 20/20, yadda yadda | 15:15 |
| openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747975 | 15:15 |
| sean-k-mooney | it not a hignsight thing we knew the resouce treacker and some level of assignment logic woudl be needed in nova | 15:15 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Removed the host FQDN from the exception message https://review.opendev.org/749607 | 15:16 |
| openstackgerrit | Merged openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | 15:16 |
| sean-k-mooney | to be clear we coudl use palcment for indeivigual resouce tracking if we wanted via nesting and many many more resouce providers | 15:16 |
| artom | Eww | 15:17 |
| sean-k-mooney | its flexable enough to do that but we chose not too | 15:17 |
| artom | sean-k-mooney, anyways, it's all moot at this point | 15:17 |
| * artom needs phood | 15:18 | |
| *** mlavalle has joined #openstack-nova | 15:20 | |
| *** artom has quit IRC | 15:22 | |
| *** iurygregory has quit IRC | 15:24 | |
| *** artom has joined #openstack-nova | 15:27 | |
| *** Luzi has quit IRC | 15:28 | |
| *** dtantsur is now known as dtantsur|afk | 15:31 | |
| *** iurygregory has joined #openstack-nova | 15:42 | |
| * artom just noticed the "Download logs" shell script link in Zuul test results | 15:49 | |
| artom | Whoever did that is awesome | 15:49 |
| * gibi lost his afternoon downstream | 15:50 | |
| gibi | nova meeting starts in 6 minutes on openstack-meeting-3 | 15:53 |
| *** rambo_li has joined #openstack-nova | 15:59 | |
| lyarwood | artom: it's great but I'd also love to write a script to open everything in vim (over http) using the raw links | 16:00 |
| artom | lyarwood, ... everything? | 16:01 |
| sean-k-mooney | lyarwood: i think lnav support direct links | 16:01 |
| sean-k-mooney | it would automaticaly syntax highlith and alinge all the logs by time stamp too if that worked | 16:01 |
| lyarwood | artom: well not everything but the stuff I typically look at, so n-* logs, tempest logs etc | 16:02 |
| sean-k-mooney | anything ending in log | 16:02 |
| sean-k-mooney | oh i guess most end in .txt | 16:03 |
| sean-k-mooney | ah the gzip compression mess up usin lnav and likely vim with the raw urls | 16:04 |
| *** gyee has joined #openstack-nova | 16:05 | |
| lyarwood | sean-k-mooney: vim WORKSFORME with gzip FWIW | 16:08 |
| sean-k-mooney | lyarwood: gzip is not the issue | 16:08 |
| sean-k-mooney | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_557/746986/3/check/nova-live-migration/557b715/logs/screen-n-cpu.txt | 16:09 |
| sean-k-mooney | us being served compressed | 16:09 |
| lyarwood | ah yeah that borks vim | 16:09 |
| sean-k-mooney | yep | 16:09 |
| sean-k-mooney | vim and lnave are not reading the hearer or it is not serving it with the writh header | 16:10 |
| lyarwood | I think vim just calls out to wget tbh | 16:10 |
| sean-k-mooney | ya its being served tih text/plain and Content-encoding gzip | 16:10 |
| lyarwood | at least it does for me but that could be a plugin | 16:10 |
| sean-k-mooney | yep so lnav and vim would have to use teh Accepts-encode header to not allow copression | 16:11 |
| sean-k-mooney | or read the respocne head and do the right thing | 16:11 |
| sean-k-mooney | that said just localy donloadingthm to somewhere in /tmp and then passing the paths to vim or lnav works | 16:12 |
| *** rambo_li has quit IRC | 16:21 | |
| *** rambo_li has joined #openstack-nova | 16:21 | |
| *** priteau has quit IRC | 16:25 | |
| *** adrianc has quit IRC | 16:25 | |
| *** adrianc has joined #openstack-nova | 16:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reproducer for bug #1894095 https://review.opendev.org/749713 | 16:31 |
| openstack | bug 1894095 in OpenStack Compute (nova) "Running periodic task during live migration results in incorrect usage" [Medium,Confirmed] https://launchpad.net/bugs/1894095 - Assigned to Stephen Finucane (stephenfinucane) | 16:31 |
| gibi | sean-k-mooney: can I pull the trigger on the os-vif release https://review.opendev.org/#/c/749535/ ? | 16:37 |
| artom | lyarwood, so actually our volume thing with whitebox is different - it's a test for detaching a volume with libvirt stopped, so we expect the volume to remain in-use until libvirt starts up again and the detach completes. Did that behaviour change? | 16:40 |
| sean-k-mooney | gibi: ya i think so | 16:45 |
| gibi | sean-k-mooney: ack | 16:45 |
| sean-k-mooney | the two patches i was waiting for are still not merged but they need rework | 16:45 |
| sean-k-mooney | so we will just backport them later | 16:45 |
| gibi | OK, done | 16:45 |
| lyarwood | artom: when you say completes is the disk detached from the domain? | 16:45 |
| lyarwood | artom: or just detached in cinder | 16:45 |
| artom | lyarwood, cinder | 16:46 |
| lyarwood | artom: if libvirt is stopped the call to detach should fail but AFAIK we should then rollback the volume state to in-use | 16:46 |
| lyarwood | artom: if we don't that's a bug | 16:46 |
| artom | lyarwood, ok, I'll dig some more then - looks like it's only happening with focal | 16:47 |
| artom | For all I know we're stopping libvirt wrong :P | 16:47 |
| *** rambo_li has quit IRC | 16:47 | |
| lyarwood | huh, might be the error raised from the libvirt python lib has changed | 16:47 |
| lyarwood | when it can't talk to libvirtd | 16:47 |
| lyarwood | or some weirdness like that | 16:47 |
| gibi | dansmith: lyarwood: thanks for taking care of the rbd documentation | 16:54 |
| gmann | lyarwood: you can use this patch also which unskip the tests - https://review.opendev.org/#/c/734029/ | 16:54 |
| gmann | devstack-platform-focal job run those test on focal | 16:55 |
| *** derekh has quit IRC | 16:55 | |
| artom | lyarwood, ah, no, looks like systemctl is configured in focal to restart libvirtd if it dies? | 16:55 |
| artom | In any case, something starts it back up again, 3 seconds afer we stop it | 16:55 |
| gibi | artom: thanks for the review on https://review.opendev.org/#/c/748453/ I can try to add a functional test for that later, if that is OK | 16:55 |
| artom | gibi, I think we're better off reviewing stephenfin's series first | 16:56 |
| artom | Then adding on to it | 16:56 |
| lyarwood | gmann: ack thanks | 16:56 |
| lyarwood | artom: kk | 16:56 |
| lyarwood | gibi: np | 16:56 |
| *** lpetrut has quit IRC | 16:57 | |
| gibi | artom: make sense | 16:59 |
| gibi | artom: I will try to get to that series | 16:59 |
| artom | gibi, same here | 16:59 |
| artom | There's a lot there to unpack | 17:00 |
| sean-k-mooney | atuclly i was hoping we could merge the sriov feature first | 17:03 |
| sean-k-mooney | because im not sure we will get both done by m3 | 17:04 |
| sean-k-mooney | so put stephens changes on top of gibis? | 17:04 |
| sean-k-mooney | that way we can avoid the merge conflitcs and still review them all in context? | 17:05 |
| artom | sean-k-mooney, yeah, I was saying the same thing | 17:05 |
| gibi | I would not rush with that move, as I lost my whole afternoon downstream today. I think if we approve both and then there is a conflict we can decide which one to move | 17:05 |
| artom | sean-k-mooney, gibi, 1. merge SRIOV 2. merge stephenfin func tests 3. improve func tests to cover the case gibi is fixing | 17:05 |
| gibi | in general I agree | 17:06 |
| artom | And 4. convert SRIOV live migration to use claims like NUMA live migration, giving sean-k-mooney an aneurysm in the process ;) | 17:06 |
| gibi | It is just hard to commit to 1. right now as I still have a list of func test to write | 17:06 |
| sean-k-mooney | :) | 17:06 |
| gibi | please don't kill each other over it, I need both of you in this team! | 17:07 |
| artom | Nah, we'll just have an honest drinking competition for it | 17:07 |
| artom | I'm only saying that because I believe sean-k-mooney is one of the very few Irish people I might actually beat | 17:07 |
| sean-k-mooney | if we create cliams in the conductor/scheduler it would impove my opipion of them | 17:08 |
| sean-k-mooney | hehe that because i dont drink that often | 17:08 |
| sean-k-mooney | does not mean i will let you win too easy :) | 17:09 |
| gibi | I can be the judge of that drinking contest after the pandemic | 17:09 |
| sean-k-mooney | gibi: for what its worth we both agree we shoudl have 1 code path for the migration stuff | 17:10 |
| gibi | agree | 17:10 |
| sean-k-mooney | im just not comfortably with the level of tech debt that claims have | 17:10 |
| sean-k-mooney | if we make claims better and more useful by creating claims for resouce eairler then i would be more comfortable adtoping them for sriov migration | 17:11 |
| sean-k-mooney | but that one of those things like move neutron port creation to the conductor | 17:12 |
| sean-k-mooney | it would be good to do but not something we can sell to customers or PMs easily. | 17:13 |
| *** manuvakery has quit IRC | 17:17 | |
| gibi | yeah, it is tech debt removal, and that is hard to sell | 17:17 |
| sean-k-mooney | also in this case hard work with all the other things that have built up around it | 17:28 |
| *** gregwork has quit IRC | 17:29 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 17:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: refactor volume bdm rollback error handling https://review.opendev.org/748512 | 17:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Add regression tests for bug #1889108 https://review.opendev.org/748513 | 17:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514 | 17:56 |
| openstack | bug 1889108 in OpenStack Compute (nova) stein "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 17:56 |
| *** dklyle has quit IRC | 18:16 | |
| *** david-lyle has joined #openstack-nova | 18:16 | |
| *** david-lyle is now known as dklyle | 18:16 | |
| *** tesseract has quit IRC | 18:21 | |
| openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | 18:22 |
| *** priteau has joined #openstack-nova | 18:24 | |
| *** nightmare_unreal has quit IRC | 18:29 | |
| *** priteau has quit IRC | 18:47 | |
| *** xek has joined #openstack-nova | 19:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | 19:28 |
| *** vishalmanchanda has quit IRC | 19:28 | |
| *** ralonsoh has quit IRC | 19:30 | |
| *** niedbalski has joined #openstack-nova | 19:35 | |
| *** tosky has quit IRC | 19:45 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533 | 19:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [Trivial] Replace ref of policy.json to policy.yaml https://review.opendev.org/749821 | 19:49 |
| openstackgerrit | Merged openstack/nova master: Adapt the admin guide to describe the direct RBD export https://review.opendev.org/728411 | 19:57 |
| *** nweinber has quit IRC | 20:04 | |
| *** zzzeek has quit IRC | 20:08 | |
| *** zzzeek has joined #openstack-nova | 20:12 | |
| *** slaweq has quit IRC | 20:20 | |
| *** xiaolin has joined #openstack-nova | 20:20 | |
| *** slaweq has joined #openstack-nova | 20:26 | |
| *** JamesBenson has quit IRC | 20:51 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM libvirt: Increase device detach wait times https://review.opendev.org/749827 | 20:54 |
| *** xek has quit IRC | 21:00 | |
| *** JamesBenson has joined #openstack-nova | 21:08 | |
| *** raildo has quit IRC | 21:16 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | 21:17 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [Trivial] Replace ref of policy.json to policy.yaml https://review.opendev.org/749821 | 21:18 |
| *** adrianc has quit IRC | 21:35 | |
| *** adrianc has joined #openstack-nova | 21:35 | |
| *** k_mouza has joined #openstack-nova | 21:38 | |
| *** xiaolin has quit IRC | 21:54 | |
| openstackgerrit | Sean McGinnis proposed openstack/nova master: Handle oslo.messaging ping endpoint https://review.opendev.org/749838 | 22:06 |
| smcginnis | Needed for the global requirements update patch for the latest oslo.messaging ^ | 22:07 |
| *** k_mouza has quit IRC | 22:09 | |
| *** avolkov has quit IRC | 22:26 | |
| *** mlavalle has quit IRC | 23:01 | |
| *** zzzeek has quit IRC | 23:05 | |
| *** zzzeek has joined #openstack-nova | 23:06 | |
| *** rcernin has joined #openstack-nova | 23:24 | |
| *** rcernin has quit IRC | 23:31 | |
| *** rcernin has joined #openstack-nova | 23:31 | |
| *** zzzeek has quit IRC | 23:39 | |
| *** zzzeek has joined #openstack-nova | 23:40 | |
| *** jamesden_ has joined #openstack-nova | 23:53 | |
| *** jamesdenton has quit IRC | 23:56 | |
| *** zzzeek has quit IRC | 23:57 | |
| *** zzzeek has joined #openstack-nova | 23:59 | |
| *** sapd1_x has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!