| *** artom has quit IRC | 00:21 | |
| *** _erlon_ has quit IRC | 00:25 | |
| *** brinzhang_ has joined #openstack-nova | 00:32 | |
| *** brinzhang0 has quit IRC | 00:36 | |
| *** bnemec has quit IRC | 00:41 | |
| *** mgoddard has quit IRC | 00:41 | |
| *** bnemec has joined #openstack-nova | 00:46 | |
| *** jamesdenton has joined #openstack-nova | 00:47 | |
| *** mgoddard has joined #openstack-nova | 00:47 | |
| *** k_mouza has joined #openstack-nova | 01:08 | |
| *** k_mouza has quit IRC | 01:13 | |
| *** kberger_ has quit IRC | 01:13 | |
| *** mgoddard has quit IRC | 01:17 | |
| *** Liang__ has joined #openstack-nova | 01:21 | |
| *** mgoddard has joined #openstack-nova | 01:24 | |
| *** brinzhang_ has quit IRC | 01:31 | |
| *** brinzhang_ has joined #openstack-nova | 01:31 | |
| *** bnemec has quit IRC | 01:34 | |
| *** zzzeek has quit IRC | 01:36 | |
| *** zzzeek has joined #openstack-nova | 01:38 | |
| *** bnemec has joined #openstack-nova | 01:39 | |
| *** xiaolin has joined #openstack-nova | 01:59 | |
| openstackgerrit | Wenping Song proposed openstack/nova master: Process exception of delete resource provider https://review.opendev.org/748339 | 02:03 |
|---|---|---|
| *** jamesdenton has quit IRC | 02:25 | |
| *** rcernin has quit IRC | 02:29 | |
| *** links has joined #openstack-nova | 02:29 | |
| *** jamesdenton has joined #openstack-nova | 02:31 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326 | 02:40 |
| *** boxiang_ has quit IRC | 02:41 | |
| *** boxiang has joined #openstack-nova | 02:42 | |
| *** rcernin has joined #openstack-nova | 02:51 | |
| *** Liang__ has quit IRC | 02:53 | |
| *** Liang__ has joined #openstack-nova | 02:54 | |
| *** rcernin has quit IRC | 02:56 | |
| *** rcernin has joined #openstack-nova | 02:56 | |
| *** efried has quit IRC | 02:57 | |
| *** dave-mccowan has quit IRC | 03:00 | |
| *** efried has joined #openstack-nova | 03:01 | |
| *** sapd1_x has joined #openstack-nova | 03:01 | |
| *** zzzeek has quit IRC | 03:02 | |
| *** zzzeek has joined #openstack-nova | 03:05 | |
| *** k_mouza has joined #openstack-nova | 03:10 | |
| *** k_mouza has quit IRC | 03:14 | |
| *** sapd1_x has quit IRC | 03:31 | |
| *** psachin has joined #openstack-nova | 03:39 | |
| *** sapd1_x has joined #openstack-nova | 03:42 | |
| openstackgerrit | Harshavardhan Metla proposed openstack/nova master: Raising a deprecated warning in case of 403 https://review.opendev.org/735068 | 03:48 |
| *** ratailor has joined #openstack-nova | 04:31 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** mkrai has joined #openstack-nova | 04:36 | |
| *** sapd1_x has quit IRC | 04:49 | |
| *** belmoreira has joined #openstack-nova | 04:53 | |
| *** suryasingh has joined #openstack-nova | 05:01 | |
| *** bhagyashris|away is now known as bhagyashris | 05:02 | |
| *** vishalmanchanda has joined #openstack-nova | 05:10 | |
| openstackgerrit | Merged openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 05:10 |
| *** k_mouza has joined #openstack-nova | 05:10 | |
| *** k_mouza has quit IRC | 05:14 | |
| *** belmoreira has quit IRC | 05:26 | |
| *** belmoreira has joined #openstack-nova | 05:34 | |
| *** zzzeek has quit IRC | 05:37 | |
| *** zzzeek has joined #openstack-nova | 05:37 | |
| *** gyee has quit IRC | 05:39 | |
| *** ratailor has quit IRC | 05:47 | |
| *** ratailor has joined #openstack-nova | 05:48 | |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware: Handle exception in destroy with attached volumes https://review.opendev.org/738416 | 05:54 |
| *** jsuchome has joined #openstack-nova | 05:59 | |
| *** ralonsoh has joined #openstack-nova | 06:14 | |
| *** sapd1_x has joined #openstack-nova | 06:16 | |
| *** zzzeek has quit IRC | 06:16 | |
| *** zzzeek has joined #openstack-nova | 06:17 | |
| *** ratailor has quit IRC | 06:24 | |
| *** slaweq has joined #openstack-nova | 06:32 | |
| *** zzzeek has quit IRC | 06:47 | |
| *** hoonetorg has quit IRC | 06:48 | |
| *** zzzeek has joined #openstack-nova | 06:50 | |
| *** mkrai has quit IRC | 06:57 | |
| *** mkrai has joined #openstack-nova | 06:57 | |
| *** hoonetorg has joined #openstack-nova | 07:01 | |
| *** ratailor has joined #openstack-nova | 07:03 | |
| *** tesseract has joined #openstack-nova | 07:04 | |
| *** k_mouza has joined #openstack-nova | 07:11 | |
| *** damien_r has joined #openstack-nova | 07:14 | |
| *** k_mouza has quit IRC | 07:16 | |
| *** damien_r has quit IRC | 07:18 | |
| *** rcernin has quit IRC | 07:28 | |
| *** sapd1_x has quit IRC | 07:31 | |
| *** brinzhang_ has quit IRC | 07:31 | |
| *** brinzhang_ has joined #openstack-nova | 07:32 | |
| *** yoctozepto has quit IRC | 07:34 | |
| *** dtantsur|afk is now known as dtantsur | 07:40 | |
| *** tosky has joined #openstack-nova | 07:47 | |
| *** derekh has joined #openstack-nova | 07:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Ensure source compute is up when confirming a resize https://review.opendev.org/748369 | 08:08 |
| *** brinzhang_ has quit IRC | 08:10 | |
| *** brinzhang_ has joined #openstack-nova | 08:11 | |
| *** sapd1_x has joined #openstack-nova | 08:17 | |
| *** chenhaw has quit IRC | 08:25 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 08:32 |
| stephenfin | gibi: Respun that to address the failing test /o\ ^ | 08:33 |
| stephenfin | so dumb :( | 08:33 |
| gibi | no worries, I put my +2 back | 08:36 |
| stephenfin | thanks | 08:37 |
| bauzas | gibi: I want to provide the implementation for the routed networks spec, can I supersed https://review.opendev.org/#/c/656885/7 ? | 08:39 |
| bauzas | I mean, not providing a new revision, rather a new change | 08:39 |
| gibi | bauzas: sure | 08:43 |
| bauzas | thanks | 08:44 |
| gibi | sean-k-mooney: do you have ideas what happenening here https://bugs.launchpad.net/nova/+bug/1892361 ? | 08:44 |
| openstack | Launchpad bug 1892361 in OpenStack Compute (nova) "SRIOV instance gets type-PF interface, libvirt kvm fails" [Undecided,New] | 08:44 |
| *** k_mouza has joined #openstack-nova | 08:46 | |
| gibi | it seems libvirt driver generates wrong xml for a PF dev | 08:46 |
| stephenfin | gibi: btw, finally got around to this https://review.opendev.org/#/c/748377/ | 08:51 |
| stephenfin | It's the backport-candidate label change for Gerrit. I think that's how one does it. I've asked hberaud (who did it for oslo) for advice | 08:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Only call _local_delete_cleanup when scheduled instance is found https://review.opendev.org/748380 | 08:52 |
| lyarwood | now to work out how to exercise that in a regression test | 08:53 |
| *** yoctozepto has joined #openstack-nova | 08:55 | |
| gibi | stephenfin: ack, thanks | 08:56 |
| *** sapd1_x has quit IRC | 08:58 | |
| gibi | artom, bauzas: there is a vGPU related bugs in the tracker https://bugs.launchpad.net/nova/+bug/1887380 | 09:02 |
| openstack | Launchpad bug 1887380 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova" [Undecided,New] | 09:02 |
| bauzas | gibi: ack | 09:03 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/ussuri: docs: Resolve issue with deprecated extra specs https://review.opendev.org/748386 | 09:21 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/ussuri: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/747189 | 09:22 |
| *** k_mouza has quit IRC | 09:22 | |
| *** k_mouza has joined #openstack-nova | 09:23 | |
| *** k_mouza has quit IRC | 09:24 | |
| *** k_mouza_ has joined #openstack-nova | 09:25 | |
| openstackgerrit | Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957 | 09:35 |
| *** ftarasenko has joined #openstack-nova | 09:41 | |
| jsuchome | Hi stephenfin, could we get https://review.opendev.org/#/c/574301/ merged? I think your ,ain concerns were adressed | 09:46 |
| *** zzzeek has quit IRC | 09:57 | |
| *** derekh has quit IRC | 10:00 | |
| stephenfin | jsuchome: I think lyarwood might have accidentally regressed your changes from PS37 when updating the patch below it. That's why my -1 is still there | 10:01 |
| stephenfin | the docs are still wrong here https://review.opendev.org/#/c/574301/39/nova/conf/glance.py | 10:01 |
| *** zzzeek has joined #openstack-nova | 10:01 | |
| stephenfin | jsuchome: Also, would it impact you if I asked for a new boolean config option to turn on rbd direct download instead of reviving 'allowed_direct_url_schemes'? The more I think about it, the less I like it /o\ | 10:03 |
| stephenfin | that would let you drop the following patch and finish this in one patch | 10:03 |
| gibi | stephenfin, jsuchome: if it matters I can quickly re-review the patch(s) after such change | 10:05 |
| lyarwood | stephenfin: did I? | 10:05 |
| lyarwood | stephenfin: crap my bad sorry | 10:05 |
| stephenfin | easily fixed | 10:06 |
| stephenfin | I really do think the new option is better idea though. Much easier to discover and just better UX in general, IMHO. Looks like it'll have a minimal impact of the patch too | 10:09 |
| jsuchome | I'm not exactly in favor of that ... I think reusing that old option was described as a way to go in the blueprint | 10:14 |
| stephenfin | jsuchome: Right, but the spec was first proposed in Queens when that option wasn't yet deprecated. I realize the approved spec notes the deprecation and its impact, but is there a clear technical reason for undeprecating the option or was it simply inertia? | 10:20 |
| jsuchome | I don't think there's technical reason, main reason is that it all takes so much time... | 10:22 |
| *** xek has joined #openstack-nova | 10:24 | |
| jsuchome | I hear there are some users using this patch already so I would think it's nice to just keep the option the same, but that's just it. Maybe the inconsistency with the bp is not an issue, it just looks ugly in a different way | 10:24 |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 10:29 |
| *** Liang__ has quit IRC | 10:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce '[glance] enable_rbd_download' https://review.opendev.org/748411 | 10:55 |
| stephenfin | jsuchome, (lyarwood): ^ | 10:55 |
| *** jangutter has joined #openstack-nova | 11:00 | |
| *** jangutter_ has quit IRC | 11:03 | |
| *** k_mouza_ has quit IRC | 11:03 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use absolute path during qemu img rebase https://review.opendev.org/739246 | 11:10 |
| gibi | stephenfin, lyarwood: rebased and fixed up ^^ | 11:12 |
| *** jangutter has quit IRC | 11:15 | |
| *** jangutter has joined #openstack-nova | 11:15 | |
| tony_su | stephenfin: gibi: thanks for your kind assistance for code review and all patches were merged today. | 11:18 |
| *** k_mouza has joined #openstack-nova | 11:19 | |
| gibi | tony_su: thanks for taking care of those patches. nicely done! | 11:19 |
| tony_su | I will continue to take care of any remaining nit comments as a follow-up patch. | 11:20 |
| gibi | thanks | 11:22 |
| *** mkrai has quit IRC | 11:24 | |
| *** sapd1_x has joined #openstack-nova | 11:25 | |
| *** k_mouza has quit IRC | 11:35 | |
| *** ratailor has quit IRC | 11:36 | |
| jsuchome | stephenfin: I understand it can be done and that the change is small (altough you see youreself that it is affecting the testsuite) ... it just means back to the step 1 with reviews after months getting it to the current state... | 11:37 |
| *** xiaolin has quit IRC | 11:37 | |
| *** efried has quit IRC | 11:45 | |
| stephenfin | jsuchome: Hardly. The idea is sound. Just a tweak to the config option | 11:55 |
| stephenfin | and the change is to the new test, not to anything existing | 11:56 |
| stephenfin | gibi: Done | 11:56 |
| gibi | stephenfin: thanks | 12:05 |
| *** spatel has joined #openstack-nova | 12:22 | |
| brinzhang_ | stephenfin: hope you can review the cyborg evacuate support patch, it has +2 by gibi, https://review.opendev.org/#/c/715326/ | 12:23 |
| brinzhang_ | stephenfin, gibi: thanks | 12:24 |
| *** sapd1_x has quit IRC | 12:24 | |
| *** dklyle has quit IRC | 12:24 | |
| *** artom has joined #openstack-nova | 12:25 | |
| *** spatel has quit IRC | 12:27 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only unplug vif after the device is detached from libvirt https://review.opendev.org/744934 | 12:27 |
| *** nweinber has joined #openstack-nova | 12:43 | |
| *** psachin has quit IRC | 13:14 | |
| *** jangutter_ has joined #openstack-nova | 13:20 | |
| stephenfin | brinzhang_: Done. I'm -1 but it's just a collection of mostly trivial stuff | 13:22 |
| *** efried has joined #openstack-nova | 13:23 | |
| *** jangutter has quit IRC | 13:24 | |
| *** jangutter has joined #openstack-nova | 13:26 | |
| *** k_mouza has joined #openstack-nova | 13:27 | |
| *** jangutter_ has quit IRC | 13:29 | |
| brinzhang_ | stephenfin: thanks, I will update tomorrow | 13:29 |
| *** jangutter_ has joined #openstack-nova | 13:29 | |
| brinzhang_ | stephenfin: https://review.opendev.org/#/c/715326/22/nova/accelerator/cyborg.py@313 this function I would not like to change, and Iwant keep it in the cyborg file | 13:30 |
| brinzhang_ | and I think it's easy to maintain in the furture | 13:30 |
| brinzhang_ | s/furture/future | 13:31 |
| stephenfin | okay, it just seemed unnecessary when it's only one line long and has a single caller. If you're planning to add additional callers, then maybe it makes sense to keep | 13:31 |
| *** sapd1_x has joined #openstack-nova | 13:32 | |
| brinzhang_ | stephenfin: yes, the cyborg shelve/unshelve patch also need to use this function | 13:32 |
| *** jangutter has quit IRC | 13:32 | |
| stephenfin | okay, just leave a comment in the patch then (y) | 13:32 |
| stephenfin | *a reply | 13:33 |
| brinzhang_ | stephenfin: thanks | 13:33 |
| stephenfin | Is anyone else see "Code Review - Error Server Unavailable" occasionally from Gerrit? | 13:34 |
| brinzhang_ | it's the shelve/unshelve patch https://review.opendev.org/#/c/729563/8/nova/compute/api.py@4033 | 13:34 |
| * stephenfin wonders if it's his internet or a dodgy Gerrit instance | 13:34 | |
| sean-k-mooney | given where you are currently working its proably your internet | 13:35 |
| *** dave-mccowan has joined #openstack-nova | 13:38 | |
| bauzas | stephenfin: I do, lots of time | 13:42 |
| bauzas | but... I can't say my Internet is the better, right? | 13:42 |
| stephenfin | heh, yeah, no | 13:42 |
| stephenfin | :P | 13:42 |
| * bauzas clicked on the optic fiber deployment page to see whether there was progress | 13:42 | |
| bauzas | and the answer is sadly "yes, but not for your zone" | 13:43 |
| * bauzas is pretty sure he'll have optic fiber for Christmas | 13:43 | |
| bauzas | but I don't know which one | 13:43 |
| bauzas | stephenfin: that being said, this error seems very server-side to me | 13:44 |
| gibi | stephenfin: I do get Server Unavailable about 5 times per day from gerrit on an otherwise stable internet connection | 13:44 |
| bauzas | gibi: do you accept a coworker ? | 13:44 |
| stephenfin | I'm getting it every 30 seconds or so at the moment | 13:44 |
| bauzas | yesterday was bad on this now that I remember | 13:45 |
| bauzas | they're probably exhausting the number of java processes | 13:45 |
| gibi | bauzas: I do, but I repeatedly failed to get more headcount on OpenStack upstream | 13:45 |
| bauzas | gibi: well, I just need a seat and a decent connection, a contract is too much :p | 13:46 |
| * bauzas won't tell jokes on java | 13:46 | |
| gibi | bauzas: the seating would be a problem. MY 33m^2 flat does not even serve me well on seating | 13:47 |
| bauzas | gibi: I invested on a small Swedish company which I don't remember the name | 13:48 |
| bauzas | gibi: but they are good at providing you decent chairs around 200€ that are worth it | 13:49 |
| bauzas | Ike-something | 13:49 |
| * gibi needs to either move to a bigger place or get rid of some existing furniture | 13:49 | |
| gibi | bauzas: :) | 13:49 |
| * bauzas lives 5 mins away from a Ikea store | 13:50 | |
| *** arxcruz|ruck has left #openstack-nova | 13:50 | |
| bauzas | stephenfin can speak of how my house is just an Ikea showroom | 13:50 |
| *** k_mouza has quit IRC | 13:51 | |
| gibi | I have no problem with Ikea stuff, my kichen is from there | 13:51 |
| bauzas | you know that you frequented too much Ikea when you're able to name furniture by their Ikea names | 13:51 |
| bauzas | gibi: worth saying, the Markus chair is very decent for the price | 13:52 |
| bauzas | this saves my butt 5 times a week, 10 hours per day | 13:52 |
| gibi | thanks for the suggestion | 13:53 |
| gibi | do you happen to have one of those Ikea Skarsta desk? | 13:54 |
| bauzas | nope but I know them | 13:54 |
| gibi | is it worth the price tag? | 13:55 |
| bauzas | looks like, yes | 13:55 |
| bauzas | some coworkers have them | 13:55 |
| *** k_mouza has joined #openstack-nova | 13:55 | |
| gibi | cool, thanks. | 13:56 |
| bauzas | (I personnally have the Linnmon desk, cheap but large) | 13:57 |
| bauzas | gibi: still homeoffice, I guess ? | 13:59 |
| gibi | yes. It seems this year I don't have to go back to the office if I don't want to | 13:59 |
| bauzas | this seems reasonable | 14:02 |
| *** k_mouza has quit IRC | 14:05 | |
| *** k_mouza has joined #openstack-nova | 14:06 | |
| artom | lyarwood, https://review.opendev.org/#/c/720769/5 -0.5 I guess? | 14:07 |
| artom | I left it voteless, take it or leave it :P | 14:07 |
| artom | OK, on second thought, -1. Comment left. | 14:09 |
| *** k_mouza has quit IRC | 14:10 | |
| lyarwood | artom: that's dead until W btw | 14:11 |
| *** bnemec has quit IRC | 14:11 | |
| *** bnemec has joined #openstack-nova | 14:12 | |
| *** mriedem has joined #openstack-nova | 14:14 | |
| stephenfin | aarents: Comment on https://review.opendev.org/#/c/747957/ | 14:19 |
| stephenfin | bauzas: Is https://review.opendev.org/#/c/748271/ sufficient to resolve your concerns with https://review.opendev.org/#/c/747744/ ? | 14:20 |
| bauzas | stephenfin: thanks, yes it is | 14:20 |
| stephenfin | hurray | 14:20 |
| * bauzas is on the implementation side today but can +2 tho | 14:20 | |
| stephenfin | Great. Can rebase and remove the duplication from the vTPM series then (y) | 14:21 |
| aarents | stephenfin: thks | 14:23 |
| * bauzas wasn't thinking he would write a StarWars phrase in a review today | 14:24 | |
| *** k_mouza has joined #openstack-nova | 14:24 | |
| sean-k-mooney | bauzas i have a few metere of optic cable left over from when they installed mine i can proably post it to you:P eventurlly you can collect enough and run it yourslef probalem solved right | 14:25 |
| sean-k-mooney | bauzas: starlink is ment to be roling out early next year too | 14:26 |
| sean-k-mooney | if the price is right that might be an option | 14:26 |
| bauzas | sean-k-mooney: hold my beer | 14:26 |
| bauzas | sean-k-mooney: I personnally like to consider being able to join a free ISP with a specific AS if my ISP sucks | 14:29 |
| bauzas | which won't be possible if I go with starlink | 14:29 |
| bauzas | that, and the fact I don't like how this will pollute space | 14:29 |
| sean-k-mooney | also you dont want to have to wait till 2021 or later when it actully start going live | 14:30 |
| bauzas | honestly, I could just pay a local mobile provider and run a LTE connection with 100 gigs fair use | 14:30 |
| bauzas | sean-k-mooney: well, about 2021, I become almost sure that starlink would be operational before I get optic fiber at home | 14:31 |
| sean-k-mooney | ya if im at my mother house i get 150 down and about 80 up on my phone while her landline broadband only get 4 down and .25-.6 up on a good day | 14:34 |
| *** k_mouza has quit IRC | 14:35 | |
| sean-k-mooney | i have suggested just bying a pone pluging it in and paying the 30 euro a month for unlimited broadband with thearhing allowed | 14:35 |
| *** k_mouza has joined #openstack-nova | 14:35 | |
| sean-k-mooney | it would be a 1TB fair usge limit | 14:35 |
| lyarwood | https://paste.centos.org/view/39276981 <- can anyone think why I could be getting this error in a func test on stable/train using integrated_helpers._IntegratedTestBase and starting two compute services ? | 14:37 |
| lyarwood | ComputeHostNotFound: Compute host 2 could not be found. | 14:37 |
| lyarwood | everything seems to start correctly | 14:37 |
| * lyarwood is missing something obvious | 14:38 | |
| lyarwood | for context I'm backporting https://review.opendev.org/#/q/Ib9dbc792dc918e7ea45915e2c1dbd96be82ef562 | 14:38 |
| *** dklyle has joined #openstack-nova | 14:41 | |
| aarents | stephenfin: not sure to get this one: https://review.opendev.org/#/c/747957/4/nova/tests/unit/compute/test_compute.py@10296 (I replied) | 14:41 |
| stephenfin | aarents: Fair point. Ignore that comment :) | 14:50 |
| stephenfin | (replied also) | 14:50 |
| *** dave-mccowan has quit IRC | 14:50 | |
| *** k_mouza has quit IRC | 14:52 | |
| *** links has quit IRC | 14:53 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453 | 14:56 |
| aarents | stephenfin: oky thks, I will fixup the others | 14:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995 | 14:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: tracing the PCI allocation code path https://review.opendev.org/748454 | 14:59 |
| gibi | sean-k-mooney: added some logs ^^ to see why the pci device goes to allocated immediately in your env | 15:01 |
| *** k_mouza has joined #openstack-nova | 15:01 | |
| gibi | I mean why it doesn't go to allocated | 15:01 |
| *** dklyle has quit IRC | 15:05 | |
| *** mkrai has joined #openstack-nova | 15:10 | |
| sean-k-mooney | gibi: so i still dont think we should make sriov use claims for what its worth | 15:12 |
| sean-k-mooney | im hoping eventully claims wil go away and we will use migrate data like we do with sriov migration | 15:12 |
| sean-k-mooney | oh sorry this is something esle | 15:13 |
| sean-k-mooney | ya ok i see what you have changed | 15:13 |
| sean-k-mooney | gibi: i was getting confused with the TODO to converge numa migration and sriov migration to claim devices in a common way | 15:13 |
| sean-k-mooney | https://review.opendev.org/#/c/748453/1/nova/compute/resource_tracker.py is adress the comment i left about not passign the numa toplogy | 15:14 |
| sean-k-mooney | artom: this is better then we do today where we dont pass the numa toplogy but its still wrogn correct^ | 15:24 |
| sean-k-mooney | https://review.opendev.org/#/c/748453/1 | 15:24 |
| gibi | sean-k-mooney: do you mean we pass the wrong topology during live migration? | 15:25 |
| sean-k-mooney | it depend on where that is being called | 15:25 |
| artom | gibi, I think sean-k-mooney means adding PCI devices to the _live_migration_claim()... | 15:25 |
| sean-k-mooney | artom: well i want to delete that | 15:26 |
| artom | sean-k-mooney, delete... the _live_migration_claim()? | 15:26 |
| sean-k-mooney | but currently its done in check_can_live_migrate_destination | 15:26 |
| sean-k-mooney | artom: i want to remove claims eventually | 15:26 |
| artom | In favor of what? | 15:26 |
| * gibi listens | 15:26 | |
| artom | They're like the basis of all of NUMA live migraiton | 15:26 |
| sean-k-mooney | yep i know | 15:27 |
| artom | And I mean... they work. | 15:27 |
| sean-k-mooney | in favor of doing it the way we do for sriov live migration | 15:27 |
| artom | ... why? | 15:27 |
| sean-k-mooney | anyway different topic for a different day | 15:27 |
| gibi | :) | 15:27 |
| sean-k-mooney | port_id_to_pci = self._claim_pci_for_instance_vifs(ctxt, instance) | 15:27 |
| artom | Like yeah, they're hard to grok initially, but they do a bunch of useful things | 15:27 |
| sean-k-mooney | we do that in check_can_live_migrate_destination | 15:28 |
| artom | And they're battle-tested | 15:28 |
| sean-k-mooney | im not sure which numa toplogy is stored in the instance at that point | 15:29 |
| artom | I mean not really for another day, because gibi's patch has to chose 1 or the other... | 15:29 |
| sean-k-mooney | is it the souce numa toplogy or the dest | 15:29 |
| artom | sean-k-mooney, the source, until we apply_move_claim() | 15:29 |
| sean-k-mooney | ok so then that is the wrong numa toplogy for 2 reasons | 15:29 |
| sean-k-mooney | first the souce and dest can differ | 15:29 |
| gibi | I have access to the MoveClaim but that also seems to returning the numa topology stored on the instnace | 15:30 |
| sean-k-mooney | and second if the dest numa toplogy has not been caulated with the numa reuqirement it also wrong | 15:30 |
| sean-k-mooney | we shoudl be geting the toplogy info form the migate_data object right | 15:30 |
| gibi | sean-k-mooney: I did not found it there | 15:30 |
| artom | sean-k-mooney, the whole point of using claims was to calculate the dest numa topology, and store the old and new until we apply the claim... | 15:31 |
| sean-k-mooney | artom: right but sriov migration merged a few months before any for the numa migration stuff did | 15:31 |
| gibi | artom let me know where is the dest numa topology stored and I will modify my patch | 15:31 |
| sean-k-mooney | and it was expictly not using move claims | 15:31 |
| artom | sean-k-mooney, I know, we discussed that during review | 15:32 |
| sean-k-mooney | yes i wanted to move to a case where we claimd resouce in the db and passed the info via migrate data and start using that of all move operations | 15:32 |
| artom | That's what claims do :) | 15:32 |
| sean-k-mooney | badly | 15:33 |
| artom | Why? | 15:33 |
| sean-k-mooney | for one they dont actully store them in the db | 15:33 |
| sean-k-mooney | the are in memroy we are not claiming indivutal resouce on the numa toplogy blob for example | 15:33 |
| artom | Store what? The resource usage? Yes they do, the update the resource tracker, and the migration is consuming the resources | 15:33 |
| sean-k-mooney | the host one | 15:33 |
| sean-k-mooney | claims basically are boolean this is free or it might be used | 15:34 |
| sean-k-mooney | with pci devces we have a tristate | 15:34 |
| artom | Yeah, the eventually call down to rt._update() or w/e it's called | 15:34 |
| sean-k-mooney | available, claimed for an instnace but not used yet and allocated | 15:35 |
| sean-k-mooney | that is stored in teh db drictly in a table not in memory | 15:35 |
| artom | sean-k-mooney, so can the resource tracker already call down to the pci tracker to udpate those? | 15:35 |
| sean-k-mooney | which means if we restart the compute agent that info is not actully lost | 15:35 |
| sean-k-mooney | yes | 15:35 |
| artom | sean-k-mooney, so what's wrong with using that exisiting plumbing? | 15:36 |
| sean-k-mooney | but thats kind of missign the point that i dont really think how we do claimis is a good thing. i know othere wanted to move to a model weher we rely more on plament allocation and directl claims or resouce that are not tempory in memory | 15:36 |
| artom | sean-k-mooney, Placement, sure | 15:36 |
| artom | But let's be honest, NUMA in placement is never happening :P | 15:37 |
| sean-k-mooney | we basically have two source of info here the live migration claim and the migrate_data | 15:37 |
| artom | sean-k-mooney, the migrate data is just the info for the source to update the XML | 15:37 |
| sean-k-mooney | well actully we might eventually have to make that deciesion | 15:37 |
| artom | The claim is for resources consumed | 15:37 |
| sean-k-mooney | there are feature that have been waitn 4+year for numa in placment | 15:38 |
| sean-k-mooney | im not really sure we can justify blocking them to much longer but ill try to get it done next cycle | 15:38 |
| sean-k-mooney | after wallaby however we really need to consier if we will ever do int plamcent | 15:38 |
| sean-k-mooney | we did not need placment ot solve the races we have with numa | 15:39 |
| sean-k-mooney | we just need to not use claims the way they are right now | 15:39 |
| sean-k-mooney | that is one of my main issue with them | 15:39 |
| sean-k-mooney | because the calims are done locally on the compute node it cause the numa races | 15:39 |
| artom | sean-k-mooney, plus, we *already have* PCI stuff in the rt's _move_claim() | 15:39 |
| sean-k-mooney | for what | 15:40 |
| artom | Moves :) Cold migrations | 15:40 |
| sean-k-mooney | oh you put in a hack i remmeber | 15:40 |
| sean-k-mooney | ya for cold migation | 15:40 |
| sean-k-mooney | but also the hack for live | 15:40 |
| sean-k-mooney | where we dont set them or something | 15:40 |
| sean-k-mooney | this https://github.com/openstack/nova/blob/f521f4dbace0e35bedd089369da6f6969da5ca32/nova/compute/resource_tracker.py#L303-L314 | 15:41 |
| artom | gibi, so https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L223 is the live migration claim creation method, that creates the migration context with the old and new NUMA topologies by calling down to _move_claim() | 15:42 |
| artom | gibi, and yeah, sean-k-mooney found my TODO about converging the 2 (NUMA and SRIOV live migration) | 15:42 |
| artom | gibi, the live migration claim is created on the destination at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L7670 | 15:43 |
| sean-k-mooney | right which i objected too at the time and still do unless we remove the migration_data object | 15:43 |
| sean-k-mooney | and and a couple of other things | 15:43 |
| sean-k-mooney | like moving claims for spawn and other vent to the conductor | 15:44 |
| sean-k-mooney | or ideally earlier | 15:44 |
| artom | gibi, and then we eventually save the dest stuff (like numa topology) here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L8587 | 15:44 |
| sean-k-mooney | artom: if its not clear as far as i am concerned the main reason we have races with numa is due to claims beign done on the compute node. that is what placment and numa in plamcnet was ment to solve | 15:45 |
| sean-k-mooney | or we could have fixed it years ago if claims were dont in the scuderler of conductor | 15:46 |
| sean-k-mooney | gibi: https://github.com/openstack/nova/blob/f521f4dbace0e35bedd089369da6f6969da5ca32/nova/compute/resource_tracker.py#L328 | 15:46 |
| sean-k-mooney | gibi: you need to use the new_numa_topology for the migration context | 15:46 |
| artom | sean-k-mooney, it's not so much *where* they're done, it's that scheduling and claiming happened in 2 steps | 15:47 |
| sean-k-mooney | artom: yes which is where they are done | 15:47 |
| artom | sean-k-mooney, but yeah, claiming in the scheduler would have fixed that, because we could have made schedule + claim atomic | 15:47 |
| sean-k-mooney | yes | 15:47 |
| sean-k-mooney | which is what i argured for befor placment was created | 15:47 |
| artom | Yeah, I could get behind that | 15:48 |
| artom | But it's moot at this point | 15:48 |
| artom | For better or worse | 15:48 |
| mriedem | search is busted in the docs https://docs.openstack.org/nova/latest/search.html?q=cross_az_attach - click on one of those | 15:48 |
| sean-k-mooney | oh it is | 15:48 |
| sean-k-mooney | did we move things | 15:48 |
| gibi | sean-k-mooney, artom: thanks I think I see it now | 15:49 |
| sean-k-mooney | availability-zonesundefined | 15:49 |
| artom | Where did the 'undefined' in that URL come from? | 15:49 |
| artom | gibi, that's actually impressive that you do :) | 15:49 |
| sean-k-mooney | so we are not substituing somthing | 15:49 |
| gibi | artom: I see from where I need to use the topology | 15:49 |
| gibi | artom: honeslty I don't have the brainpower to deeploy follow the argument about claims vs pci_tracker | 15:50 |
| sean-k-mooney | migration_contex.new_toplogy | 15:50 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1893238 | 15:50 |
| openstack | Launchpad bug 1893238 in OpenStack Compute (nova) "nova document search result links not working" [Undecided,New] | 15:50 |
| sean-k-mooney | ha we must have chagne some of the shinx setting | 15:50 |
| gibi | ohh, nova meeting starts in 9 minutes in #openstack-meeting-3 | 15:51 |
| bauzas | this meeting time kills me :( | 15:53 |
| gibi | bauzas: how can I help? | 15:53 |
| bauzas | nothing really, I'll attend | 15:53 |
| bauzas | but please, be short :) | 15:53 |
| gibi | I will try | 15:54 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | 15:58 |
| stephenfin | artom: got a flake8 issue on https://review.opendev.org/#/c/747451/ | 16:00 |
| artom | gdi | 16:00 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: trivial: Remove useless comment https://review.opendev.org/748475 | 16:01 |
| artom | stephenfin, in the meantime, here's that useless comment removal ^^ | 16:02 |
| stephenfin | +2 | 16:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | 16:04 |
| *** gyee has joined #openstack-nova | 16:06 | |
| *** JamesBenson has joined #openstack-nova | 16:06 | |
| *** dustinc has quit IRC | 16:07 | |
| *** manuvakery has joined #openstack-nova | 16:12 | |
| *** chenhaw has joined #openstack-nova | 16:14 | |
| *** derekh has joined #openstack-nova | 16:21 | |
| *** bnemec has quit IRC | 16:22 | |
| *** tesseract has quit IRC | 16:23 | |
| *** dtantsur is now known as dtantsur|afk | 16:23 | |
| *** bnemec has joined #openstack-nova | 16:30 | |
| *** martinkennelly has joined #openstack-nova | 16:33 | |
| *** k_mouza has quit IRC | 16:38 | |
| *** k_mouza has joined #openstack-nova | 16:45 | |
| *** tosky has quit IRC | 16:45 | |
| *** derekh has quit IRC | 16:47 | |
| *** mkrai has quit IRC | 16:49 | |
| *** harsha24 has joined #openstack-nova | 16:49 | |
| * bauzas calls it a day, bye folks | 16:49 | |
| *** k_mouza has quit IRC | 16:49 | |
| artom | lyarwood, melwitt, wanna take a gander at https://review.opendev.org/#/c/747451/? | 16:50 |
| * gibi also leaves for today | 16:50 | |
| * stephenfin too | 16:50 | |
| lyarwood | artom: I can try | 16:51 |
| artom | lyarwood, cheers! | 16:51 |
| *** belmoreira has quit IRC | 16:52 | |
| gibi | gmann: sorry I totally forget you a second time too | 16:53 |
| gibi | gmann: /o\ | 16:53 |
| gibi | gmann: is there anything important from API side? | 16:53 |
| *** harsha24 has quit IRC | 16:55 | |
| gmann | gibi: ah yeah me too :). just json to yaml migration, anyways let me get oslo tooling in for that and then we can talk on nova patch - https://review.opendev.org/#/q/topic:bp/policy-json-to-yaml+(status:open+OR+status:merged) | 16:56 |
| gibi | gmann: seems like a fairly easy nova change | 16:57 |
| gibi | gmann: if the oslo change lands before the non-client library freeze then we can try to land the nova change before m3 | 16:58 |
| gmann | yeah. i hope at least with upgrade checks, changing the default value would not break operators but dansmith or johnthetubaguy can corret me | 16:58 |
| gmann | gibi: yeah that is the plan. i think we can merge the olso change by tomorrow | 16:58 |
| gibi | cool, let's get back to this tomorrow or next week | 16:59 |
| gibi | I have to drop now | 16:59 |
| gmann | yup | 16:59 |
| gibi | o/ | 16:59 |
| dansmith | gmann: json still works, right? | 17:00 |
| gmann | dansmith: yeah it will work but default value of policy_file will change. https://review.opendev.org/#/c/748059/1/nova/policy.py | 17:00 |
| dansmith | yaml is the default for the generation, right? I wouldn't think any problem on upgrade that wouldn't happen if we overwrote their file with fresh jsson anyway | 17:01 |
| dansmith | oh | 17:01 |
| gmann | i mean is anyone has policy.json then it has to be converted to policy,yaml | 17:01 |
| dansmith | wait, they *have* to convert to yaml? | 17:01 |
| gmann | yeah because of extension name change in default value. json formatted still work though | 17:03 |
| dansmith | you mean if they take the default | 17:03 |
| dansmith | file name | 17:03 |
| gmann | yes | 17:03 |
| sean-k-mooney | you need to use yaml to use some of the feautures | 17:03 |
| dansmith | sean-k-mooney: yeah that's not what we're talking about | 17:03 |
| sean-k-mooney | ah ok | 17:03 |
| gmann | converting json formatted to yaml is separate thing and they can do in their own time and we provide tool also for that. | 17:04 |
| dansmith | gmann: ah so, wait, we don't have a policy file conf, is that right? | 17:04 |
| gmann | we do have | 17:04 |
| sean-k-mooney | gmann: i assume the tool just does yaml.dump(json.loads(file)) | 17:04 |
| sean-k-mooney | or similar | 17:04 |
| dansmith | gmann: where is it? | 17:04 |
| sean-k-mooney | e.g. parse the profile then dump it in the other format | 17:05 |
| gmann | sean-k-mooney: more than that - https://review.opendev.org/#/c/748055/4//COMMIT_MSG@17 | 17:05 |
| dansmith | sean-k-mooney: we're talking about breaking existing people, not generation right now | 17:05 |
| sean-k-mooney | we kind of need to do this in a falback way | 17:05 |
| sean-k-mooney | check for policy.json then check for policy.yaml right | 17:06 |
| sean-k-mooney | and fail if we find both | 17:06 |
| dansmith | sean-k-mooney: exactly, that's what I'm getting at | 17:06 |
| gmann | dansmith: this is per service option - https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L48 | 17:06 |
| dansmith | prefer yaml, but fall back to json | 17:06 |
| sean-k-mooney | just prefer or hard error if both | 17:07 |
| dansmith | gmann: ack, so where is that DEFAULT_POLICY_FILE thing used? | 17:07 |
| dansmith | oh jeez, I see | 17:07 |
| dansmith | right under it, sorry :P | 17:07 |
| dansmith | but yeah, we *have* to fall back IMHO | 17:07 |
| sean-k-mooney | to fultile on upgrade we dont change config right | 17:08 |
| sean-k-mooney | that part of the grenade theory of upgrades workflow | 17:08 |
| gmann | dansmith: this will change the default for nova - https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L121 | 17:08 |
| dansmith | sean-k-mooney: right | 17:08 |
| dansmith | gmann: right, I see it now | 17:08 |
| dansmith | gmann: but we can't just change the default and break everyone, even if the workaround is to change the config or copy the file, IMHO | 17:08 |
| gmann | dansmith: but at some point we have to do that right? may be upgrade check in this cycle with warning and next cycle change default ? | 17:09 |
| dansmith | that passes grenade because we don't override any policy I imagine, but if we did it'd be broken | 17:09 |
| dansmith | gmann: yep, we can do that, warn now switch next | 17:09 |
| gmann | ok. and with new tools operator have time for converting to yaml file too other than default one. | 17:10 |
| sean-k-mooney | we shoudl add a nova status check too | 17:11 |
| sean-k-mooney | because tehy should convert on victoria before upgrading idealy | 17:11 |
| gmann | yeah its there but with failure which i can convert to warning for this cycle | 17:11 |
| gmann | https://review.opendev.org/#/c/748059/1/nova/cmd/status.py | 17:12 |
| *** ralonsoh has quit IRC | 17:12 | |
| sean-k-mooney | so i would propose the following. check for the existine of both policy.yaml and policy.json. error if you find both and warn if you finde policy.json but use either policy.json or policy.yaml if you find one but not the other | 17:13 |
| gmann | all except 'error if you find both' s part of this oslo spec. | 17:14 |
| sean-k-mooney | right didn oslo say we should treat that as an error | 17:14 |
| gmann | 'existine of both policy.yaml and policy.json' is not possible as file can be detected via config potion only | 17:14 |
| gmann | which one, finding both? | 17:15 |
| sean-k-mooney | yes | 17:15 |
| sean-k-mooney | didnt they call that out as an error as we dont know which policy to follow | 17:15 |
| gmann | we cannot find both as we can only look for conf.oslo_policy.policy_file | 17:15 |
| sean-k-mooney | so we shoudl hard error | 17:15 |
| dansmith | sean-k-mooney: he's saying that there is only one option and we will hard fail in both cases, | 17:15 |
| sean-k-mooney | we can do import os; os.path.exist(filename) | 17:16 |
| dansmith | which means we have to warn this time before we can switch the default | 17:16 |
| gmann | yeah | 17:16 |
| dansmith | it would be better if we could make nova prefer one over the other, and I think it's possible to do that, but not required | 17:16 |
| dansmith | gmann: nova could check for the file and if not existing, parse the config opt, check for the .json equivalent and reset the default right? | 17:16 |
| sean-k-mooney | right instead of hardcoding DEFAULT_POLICY_FILE = 'policy.yaml' | 17:17 |
| dansmith | like if CONF.policy_file == DEFAULT_POLICY_FILE and os.path.exists(CONF.policy_file.replace('yaml', 'json')): cfg.set_defaults(...) | 17:17 |
| gmann | first one is not right thing to do as any existing file should be consider as policy file | 17:18 |
| dansmith | sean-k-mooney: no, we have to hardcode it | 17:18 |
| dansmith | but we can be flexible in our use of it | 17:18 |
| sean-k-mooney | ya what you sugges seam sane to me too | 17:18 |
| sean-k-mooney | its more or less what i ment | 17:18 |
| gmann | you mean just change the extension name? | 17:18 |
| sean-k-mooney | yep | 17:19 |
| sean-k-mooney | check if the file exists | 17:19 |
| sean-k-mooney | if not change extnetion | 17:19 |
| sean-k-mooney | and check again if found use it | 17:19 |
| dansmith | gmann: yeah my str.replace was just an example, but basically if the config is not overridden, and the file does not exist but the s/yaml/json/ one does, change the default | 17:19 |
| gmann | i think policy.json -> policy.yaml should be converted via new tool which acutally convert the JSON formatted to YAM L formatted. | 17:20 |
| gmann | otherwise policy.yaml in JSON format is confusing | 17:21 |
| dansmith | they should, but we can't make them | 17:21 |
| dansmith | putting json in a .yaml file is not a good idea, nor what we're suggesting | 17:21 |
| sean-k-mooney | well this is not assumign yaml in an .json | 17:21 |
| sean-k-mooney | we are assumign that are on ussuri upgradeing to victoria | 17:22 |
| sean-k-mooney | so they have a policy.json with json in it now | 17:22 |
| gmann | i was thinking warn now give them time to properly convert the json to yaml and in next cycle or so we just change default | 17:22 |
| sean-k-mooney | and we want to make sure we can load that in victoria without them modifying it in any way | 17:22 |
| *** k_mouza has joined #openstack-nova | 17:23 | |
| dansmith | gmann: we can do that too, but we're saying it would be better if we can make it default to yaml now, but fall back to json if need b | 17:23 |
| dansmith | *be | 17:23 |
| gmann | and remove fallback in next cycle? | 17:24 |
| sean-k-mooney | yep | 17:24 |
| dansmith | potentially..some future cycle | 17:24 |
| sean-k-mooney | basicaly treat this as a deprecation | 17:24 |
| sean-k-mooney | we normally remove in a cycle or two | 17:24 |
| gmann | ok. yeah if at some point we can remove fallback then it is fine | 17:24 |
| dansmith | gmann: where is policy.init called from the actual code? | 17:24 |
| dansmith | I only see it from cmd/status | 17:25 |
| gmann | from manage also and at the first call of context.can( | 17:25 |
| sean-k-mooney | you mean in the api wsgi app | 17:25 |
| dansmith | ah, context.can runs it if not run yet? | 17:25 |
| gmann | yeah | 17:26 |
| gmann | https://github.com/openstack/nova/blob/f521f4dbace0e35bedd089369da6f6969da5ca32/nova/policy.py#L168 | 17:26 |
| gmann | which is called from context.can() | 17:27 |
| sean-k-mooney | i was expecting to see it in here https://github.com/openstack/nova/blob/master/nova/api/wsgi.py but ok | 17:27 |
| *** k_mouza has quit IRC | 17:27 | |
| dansmith | gmann: we're suggesting this: https://pastebin.com/WASufpac | 17:28 |
| dansmith | but less crappy and working.. I just hacked that up like pseudocode | 17:28 |
| sean-k-mooney | ya something like that | 17:29 |
| dansmith | make sense? | 17:29 |
| gmann | yeah but we should only replace replace('yaml', 'json') if default file, 'policy.json' and not any other name | 17:31 |
| sean-k-mooney | thats why there is CONF.policy_file == DEFAULT_POLICY_FILE | 17:31 |
| gmann | if CONF.policy_file == OLD_DEFAULT | 17:31 |
| dansmith | gmann: no, | 17:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: WIP Add regression tests for bug #1889108 https://review.opendev.org/748494 | 17:32 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,New] https://launchpad.net/bugs/1889108 | 17:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495 | 17:32 |
| gmann | DEFAULT_POLICY_FILE will be policy.yaml right | 17:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496 | 17:32 |
| dansmith | gmann: only do this if they haven't touched their config file | 17:32 |
| sean-k-mooney | we only do hte fall back if the value is the default | 17:32 |
| dansmith | right | 17:32 |
| sean-k-mooney | dansmith: actully isnt there a way to check if a config value has been set or is the default | 17:32 |
| dansmith | because if they're relying on the default file being policy.json, only THEN do we fall back to the old default | 17:32 |
| dansmith | sean-k-mooney: yes, I'm just doing the easy thing without having to look that up :) | 17:32 |
| gmann | else part change overridden policy file also | 17:32 |
| gmann | xyv_policy_nova.json | 17:33 |
| sean-k-mooney | ok cool i think i have used it before | 17:33 |
| dansmith | gmann: if they have overridden it in the config, then we take what they have set | 17:33 |
| dansmith | gmann: we only need to look for the old file if they haven't, but are assuming the default is the old thing | 17:33 |
| gmann | that is what i am saying. which need to change else: -> elif CONF.policy_file == OLD_DEFAULT_POLICY_FILE | 17:35 |
| *** nweinber has quit IRC | 17:36 | |
| dansmith | NO | 17:36 |
| dansmith | :) | 17:36 |
| dansmith | we don't need to do anything if they have said their CONF.policy_file to anything, including the old default | 17:36 |
| dansmith | because of L13 | 17:36 |
| dansmith | wait, maybe I'm missing which else you're talking about.. gmann maybe update the pastebin with what you mean? | 17:37 |
| gmann | if they set CONF.policy_file=nova_policy.json | 17:37 |
| gmann | ok | 17:37 |
| sean-k-mooney | if they set it at all we just use what they set | 17:37 |
| dansmith | sean-k-mooney: right | 17:38 |
| sean-k-mooney | if they dont set it. we check the new default and if the file does not exists check the old default. | 17:38 |
| dansmith | we never need to check to see if the conf is set to the old default, | 17:39 |
| sean-k-mooney | that is what dansmith's pastebin does | 17:39 |
| sean-k-mooney | correct | 17:39 |
| dansmith | we only need to do something different if the conf is unchanged, i.e. set to the NEW default | 17:39 |
| *** nweinber has joined #openstack-nova | 17:39 | |
| dansmith | and knowing if it's overridden is better than knowing if it's set to the default | 17:39 |
| dansmith | because if it's just set to the default in their config, we should *only* honor that file | 17:39 |
| gmann | https://pastebin.com/GN7mz5tE | 17:40 |
| dansmith | gmann: no, that's not what we want | 17:40 |
| dansmith | if it's set to the old value, then we just use the old value, end of story | 17:41 |
| dansmith | if it's not overridden, then we need to check the new value, and if not present, check the old value..that's it | 17:41 |
| sean-k-mooney | gmann: that woudl expand to 'policy.json'.replace('yaml', 'json') on line 14 | 17:41 |
| dansmith | right | 17:42 |
| gmann | in case of overridden to any new-name.json also else block is executed right? | 17:44 |
| dansmith | if the value is set to *anything* other than the new default in config, then we just honor that | 17:44 |
| dansmith | the ONLY thing we need to handle is the case where the value is not overridden and the operator or packager assumes the filename is the old value | 17:45 |
| dansmith | i.e. "I don't need to set it in my config because I use the default filename" | 17:45 |
| sean-k-mooney | gmann: did you miss the early return on line 11 https://pastebin.com/WASufpac | 17:45 |
| dansmith | we break those people if we change the default filename | 17:45 |
| dansmith | we we'd like to change the default filename, but still honor the old one IF-AND-ONLY-IF they're relying on the default and have not specified a value in their config file | 17:46 |
| sean-k-mooney | im going to go have food o/ | 17:46 |
| gmann | yeah but i was thinking to change the existing default policy file instead if cONF default based on what exist | 17:46 |
| dansmith | gmann: I don't understand that last statement | 17:47 |
| *** sapd1_x has quit IRC | 17:47 | |
| *** eharney has quit IRC | 17:49 | |
| gmann | overall goal i was thinking is to warn with upgrade checks and change default to yaml so that oslo_policy can remove the json format support at some point. | 17:51 |
| gmann | but having fallback is kind of same situation with what we have currently. | 17:51 |
| dansmith | we were discussion two options and maybe we confused you, so let me reiterate the two options: | 17:52 |
| dansmith | 1. Leave the default as json now, warn in nova status, change default later and break people that didn't notice | 17:52 |
| gmann | yeah this one | 17:52 |
| dansmith | 2. Switch default to yaml now, but fall back to json file for a release or two and warn in nova-status | 17:52 |
| dansmith | if we do #2, which is my pastebin, then we can remove json more aggressively because we have been defaulting to yaml for one more release (i.e. default to yaml starts in V) | 17:53 |
| dansmith | sean-k-mooney and I prefer #2, more aggressive, without breaking people, so we can say json goes away sooner | 17:53 |
| gmann | but operator would not notice the default change as fallback is there. | 17:54 |
| *** xinranwang__ has quit IRC | 17:54 | |
| dansmith | if we do #1, then we will want to wait longer | 17:54 |
| gmann | unless we fail upgrade checks | 17:54 |
| dansmith | the upgrade checks can be the same in both cases | 17:54 |
| gmann | i was thinking in option1, fail upgrade checks in W | 17:54 |
| dansmith | gmann: we can fail upgrade checks in V if we do #2, we just need to fall back to the old filename because not everyone runs upgrade checks | 17:55 |
| *** raildo_ has quit IRC | 17:55 | |
| gmann | humm, you mean fail upgrade check but also fallback? does not that make upgrade checks a false info? | 17:55 |
| *** raildo_ has joined #openstack-nova | 17:56 | |
| gmann | upgrade checks should fail at the same time we start rejecting the json file in both otion | 17:56 |
| gmann | option | 17:56 |
| dansmith | the upgrade checks are informational anyway.. we have "warning" and "failure" in upgrade checks, we can warn now and fail on the release where we remove it in either case | 17:56 |
| *** k_mouza has joined #openstack-nova | 17:57 | |
| *** jsuchome has quit IRC | 17:57 | |
| gmann | yeah fail later seems more correct and what our code will behave | 17:57 |
| dansmith | if we do #2, then we get all new users to yaml right now, which means we can dump json support sooner | 17:57 |
| dansmith | that's what we're going for | 17:57 |
| dansmith | it doesn't change the signaling now at all | 17:57 |
| dansmith | it just means we can get all new users on yaml right away, | 17:58 |
| gmann | yeah that is good i think. | 17:58 |
| dansmith | instead of new users being on yaml later when everyone else if forced to do the same | 17:58 |
| gmann | yeah. it is better way | 17:58 |
| *** kevinz has quit IRC | 17:58 | |
| gmann | and this warning in doc still valid for option2 also - https://review.opendev.org/#/c/748059/1/doc/source/configuration/policy-concepts.rst | 18:00 |
| gmann | or we should add default value things also here? | 18:00 |
| dansmith | warning applies to either for sure, I wouldn't add the json fallback here | 18:01 |
| gmann | ok | 18:01 |
| dansmith | I would only mention the fallback in the reno | 18:01 |
| *** eharney has joined #openstack-nova | 18:01 | |
| *** k_mouza has quit IRC | 18:01 | |
| *** k_mouza has joined #openstack-nova | 18:02 | |
| gmann | will update patch with option2 once oslo.policy is released. thanks dansmith sean-k-mooney . | 18:02 |
| *** k_mouza has quit IRC | 18:06 | |
| dansmith | cool, thanks gmann ! | 18:08 |
| gmann | dansmith: but i will add "elif CONF.policy_file == OLD_POLICY_FILE:" for case - policy.json exist but an old, not supposed to be used file and CONF.policy_file =nova_policy.* means overridden file | 18:08 |
| dansmith | gmann: then I will -1 it :) | 18:09 |
| gmann | so that we do not pick not-supposed-to-use but existing policy.json | 18:09 |
| gmann | :) | 18:09 |
| dansmith | if CONF.policy_file is set to anything, then we should do what they ask | 18:09 |
| *** eharney has quit IRC | 18:10 | |
| dansmith | but go ahead and propose what you want and let sean-k-mooney and I have a chance to -1 with discussion and we can do it there, which might be easier since we can reference actual code and lines | 18:10 |
| gmann | but where you are checking override file? | 18:10 |
| gmann | ok | 18:11 |
| dansmith | bnemec: apologize for asking this again, but.. there's some oslo_config method for determining if the conf option has been set or not right? | 18:13 |
| mriedem | set vs the value coming from a default? | 18:13 |
| dansmith | bnemec: is it just opt.value == opt.default ? | 18:14 |
| dansmith | mriedem: yeah | 18:14 |
| mriedem | there is some location thing i thought | 18:14 |
| mriedem | which says where the value comes from | 18:14 |
| *** eharney has joined #openstack-nova | 18:14 | |
| mriedem | https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L57 | 18:14 |
| bnemec | Yes | 18:14 |
| dansmith | okay, perfect | 18:15 |
| bnemec | Docs are here: https://docs.openstack.org/oslo.config/latest/reference/locations.html | 18:15 |
| dansmith | gmann: for sean-k-mooney and my desired behavior, the *only* thing you need to check is if CONF.policy_file's location == opt_default :) | 18:15 |
| gmann | +1, that can save any accidental pick of file if both extensions exist | 18:15 |
| dansmith | right | 18:15 |
| gmann | +1. CONF.policy_file's location in [opt_default, set_default ] as nova will do set_default to change the default. | 18:16 |
| dansmith | ack | 18:18 |
| *** manuvakery has quit IRC | 18:22 | |
| *** suryasingh has quit IRC | 18:33 | |
| *** tosky has joined #openstack-nova | 18:35 | |
| *** k_mouza has joined #openstack-nova | 18:36 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Improve CinderFixtureNewAttachFlow https://review.opendev.org/748509 | 18:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/748510 | 18:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/748511 | 18:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: refactor volume bdm rollback error handling https://review.opendev.org/748512 | 18:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: WIP Add regression tests for bug #1889108 https://review.opendev.org/748513 | 18:39 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 18:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514 | 18:39 |
| *** k_mouza has quit IRC | 18:51 | |
| lyarwood | melwitt: https://review.opendev.org/#/c/742415/ - can you look at this if you get time, it's holding up the CVE on stable/train | 18:54 |
| *** belmoreira has joined #openstack-nova | 18:54 | |
| lyarwood | melwitt: well the release at least | 18:54 |
| *** rambo_li has joined #openstack-nova | 19:02 | |
| ganso | hello Nova folks! I just logged bug: https://bugs.launchpad.net/nova/+bug/1893263 after reproducing the issue on master. I am planning to work on the fix myself, however, I am curious to know if anyone here knows the reason why plug_tap() needs to run, as if the instance is ever being rebooted, the tap device goes away and is re-created by libvirt instead (therefore plug_tap() seems to have never needed to run at all) | 19:03 |
| openstack | Launchpad bug 1893263 in OpenStack Compute (nova) "Cannot create instance with multiqueue image and vif_type=tap (calico)" [Undecided,New] | 19:03 |
| ganso | because one of the possible fixes is just to remove plug_tap() and be happy | 19:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Add regression tests for bug #1889108 https://review.opendev.org/748494 | 19:07 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 19:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495 | 19:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496 | 19:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Add regression tests for bug #1889108 https://review.opendev.org/748513 | 19:11 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 19:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514 | 19:11 |
| *** rambo_li has quit IRC | 19:12 | |
| *** vishalmanchanda has quit IRC | 19:25 | |
| melwitt | lyarwood: ack will do | 19:26 |
| *** bbowen has quit IRC | 19:28 | |
| *** bbowen has joined #openstack-nova | 19:28 | |
| lyarwood | melwitt: thanks! :) | 19:30 |
| lyarwood | artom: https://review.opendev.org/#/c/747451/ - LGTM, I've got a few questions but I'm not comfortable +2+W'ing networking stuff so even with these answered I'm going to defer to other cores on this one | 19:31 |
| melwitt | sean-k-mooney: fyi I added you to review https://review.opendev.org/747451 please. iirc you have said using the cache is fine but it would be good if you could ack it | 19:31 |
| lyarwood | ah there we go \o/ | 19:32 |
| *** nweinber has quit IRC | 19:56 | |
| *** xek has quit IRC | 20:08 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389 | 20:16 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533 | 20:37 |
| *** rambo_li has joined #openstack-nova | 20:39 | |
| *** martinkennelly has quit IRC | 20:47 | |
| *** martinkennelly has joined #openstack-nova | 20:47 | |
| *** rambo_li has quit IRC | 20:57 | |
| *** slaweq has quit IRC | 21:22 | |
| *** raildo_ has quit IRC | 21:28 | |
| *** slaweq has joined #openstack-nova | 21:29 | |
| *** slaweq has quit IRC | 21:34 | |
| *** martinkennelly has quit IRC | 21:36 | |
| *** JamesBenson has quit IRC | 21:42 | |
| *** belmoreira has quit IRC | 21:56 | |
| sean-k-mooney | melwitt: yes, when using multiple port bindings the ports are still active on the source host at this point and when not using multiple portbining we update the neutron port later in post_live_migration_at_destination | 21:57 |
| sean-k-mooney | melwitt: there are other point in pre live migration where it would also be valid to use the cache for the same reason | 21:59 |
| gmann | stephenfin: you forgot to update this test - https://review.opendev.org/#/c/745906/4/nova/tests/functional/api_sample_tests/test_servers.py@978 | 22:00 |
| sean-k-mooney | i can note as much in the review | 22:00 |
| melwitt | sean-k-mooney: yes, it would be ideal if you could review the change as you're expert on the network stuff | 22:01 |
| *** bnemec has quit IRC | 22:07 | |
| *** mtreinish has quit IRC | 22:10 | |
| *** bnemec has joined #openstack-nova | 22:12 | |
| *** mtreinish has joined #openstack-nova | 22:16 | |
| sean-k-mooney | melwitt: actully if you dont mind ill review artoms change tomorrow. but ill leave it open to remind me. | 22:17 |
| melwitt | sure, thanks | 22:18 |
| sean-k-mooney | sorry brain has alreay turned off. we had tunder today so have had a headache all enving. cam back to check something quickly but dont have the brain power to review something properly | 22:26 |
| melwitt | np at all, take some rest | 22:29 |
| *** eharney has quit IRC | 22:44 | |
| *** rcernin has joined #openstack-nova | 22:45 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | 23:19 |
| *** lbragstad has quit IRC | 23:27 | |
| *** lbragstad has joined #openstack-nova | 23:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | 23:30 |
| *** bnemec has quit IRC | 23:37 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550 | 23:39 |
| *** bnemec has joined #openstack-nova | 23:43 | |
| *** jangutter_ has quit IRC | 23:49 | |
| *** jangutter has joined #openstack-nova | 23:49 | |
| *** tosky has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!