Friday, 2020-08-21

« Thursday, 2020-08-20 Index Saturday, 2020-08-22 »
*** pas-ha has joined #openstack-nova00:02
*** csatari has joined #openstack-nova00:02
*** evrardjp has quit IRC00:05
*** evrardjp has joined #openstack-nova00:06
*** _erlon_ has quit IRC00:21
openstackgerritsean mooney proposed openstack/nova master: [WIP] Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/74218000:30
*** dave-mccowan has quit IRC00:45
*** Liang__ has joined #openstack-nova01:26
*** hongbin has quit IRC01:36
*** gyee has quit IRC01:55
*** hongbin has joined #openstack-nova02:06
*** suryasingh has joined #openstack-nova02:12
*** rcernin has quit IRC02:37
openstackgerritMerged openstack/nova master: Pass the actual target in baremetal nodes policy  https://review.opendev.org/74171702:45
openstackgerritMerged openstack/nova master: Add scope and new default roles in extensions policies  https://review.opendev.org/74304602:45
openstackgerritMerged openstack/nova master: Add new default roles in networks policies  https://review.opendev.org/74256602:45
openstackgerritMerged openstack/nova master: Pass the actual target in networks policy  https://review.opendev.org/74256802:45
openstackgerritMerged openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74621002:45
*** mkrai has joined #openstack-nova02:54
*** rcernin has joined #openstack-nova02:58
*** rcernin has quit IRC03:04
*** rcernin has joined #openstack-nova03:04
*** boxiang has joined #openstack-nova03:07
*** evrardjp_ has joined #openstack-nova03:12
*** evrardjp has quit IRC03:15
*** psachin has joined #openstack-nova03:38
*** sapd1 has joined #openstack-nova04:05
*** Liang__ has quit IRC04:24
*** Liang__ has joined #openstack-nova04:24
*** evrardjp_ has quit IRC04:33
*** evrardjp has joined #openstack-nova04:35
*** hongbin has quit IRC04:36
*** vishalmanchanda has joined #openstack-nova05:08
*** ratailor has joined #openstack-nova05:13
*** mkrai has quit IRC05:22
*** sapd1 has quit IRC05:30
*** mkrai has joined #openstack-nova05:32
*** Liang__ has quit IRC05:56
*** yonglihe has joined #openstack-nova05:57
*** Liang__ has joined #openstack-nova05:58
*** sapd1 has joined #openstack-nova06:28
*** slaweq has joined #openstack-nova06:34
*** sapd1 has quit IRC06:36
*** tbachman has quit IRC06:38
*** jdillaman has quit IRC06:38
*** purplerbot has quit IRC06:38
*** danpawlik has quit IRC06:38
*** ganso has quit IRC06:38
*** noonedeadpunk has quit IRC06:38
*** rnoriega_ has quit IRC06:38
*** mvorwerk has joined #openstack-nova06:43
*** tbachman has joined #openstack-nova06:43
*** jdillaman has joined #openstack-nova06:43
*** purplerbot has joined #openstack-nova06:43
*** danpawlik has joined #openstack-nova06:43
*** ganso has joined #openstack-nova06:43
*** noonedeadpunk has joined #openstack-nova06:43
*** rnoriega_ has joined #openstack-nova06:43
*** sapd1 has joined #openstack-nova06:48
*** mvorwerk has quit IRC06:49
*** mvorwerk has joined #openstack-nova06:49
*** damien_r has joined #openstack-nova06:51
*** sapd1 has quit IRC06:53
*** ociuhandu has quit IRC06:56
*** damien_r has quit IRC06:56
*** ociuhandu has joined #openstack-nova06:57
*** belmoreira has joined #openstack-nova06:57
*** ociuhandu has quit IRC07:01
*** damien_r has joined #openstack-nova07:03
*** mkrai has quit IRC07:03
*** sapd1 has joined #openstack-nova07:05
*** happyhemant has joined #openstack-nova07:21
*** rcernin has quit IRC07:22
*** tesseract has joined #openstack-nova07:25
*** jkulik has joined #openstack-nova07:28
*** dtantsur|afk is now known as dtantsur07:31
*** damien_r has quit IRC07:35
*** damien_r has joined #openstack-nova07:36
*** hongbin has joined #openstack-nova07:36
*** priteau has joined #openstack-nova07:41
*** hongbin has quit IRC07:41
*** damien_r has quit IRC07:50
*** slaweq has quit IRC07:50
*** gibi_pto_24th has quit IRC07:50
*** admin0 has quit IRC07:50
*** mkrai has joined #openstack-nova08:02
*** sapd1 has quit IRC08:14
*** tosky has joined #openstack-nova08:22
*** damien_r has joined #openstack-nova08:22
*** slaweq has joined #openstack-nova08:22
*** admin0 has joined #openstack-nova08:22
*** gibi_pto_24th has joined #openstack-nova08:22
*** sapd1 has joined #openstack-nova08:22
*** lpetrut has joined #openstack-nova08:22
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74735708:23
openstackgerritLee Yarwood proposed openstack/nova stable/train: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74735808:27
*** k_mouza has joined #openstack-nova08:37
*** brinzhang has joined #openstack-nova08:41
*** arne_wiebalck has quit IRC08:44
*** danpawlik has quit IRC08:45
*** arne_wiebalck has joined #openstack-nova08:46
*** danpawlik has joined #openstack-nova08:47
*** dklyle has quit IRC08:49
alex_xustephenfin: yea, guess, the db status and rt isn't update under same lock08:49
alex_xus/guess/guess so/08:50
stephenfinalex_xu: The ResourceTracker is so broken :'(08:50
stephenfinSpent all day merely trying to figure out how broken it is, heh08:51
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74736008:51
alex_xuhah08:51
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74736108:52
*** openstackgerrit has quit IRC08:54
*** openstackgerrit has joined #openstack-nova08:55
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74736208:55
lyarwoodelod_off: https://review.opendev.org/#/q/topic:bug/1887946+status:open - When you're back this series will need some stable reviews :)08:56
*** rcernin has joined #openstack-nova09:07
*** sapd1 has quit IRC09:10
*** martinkennelly has joined #openstack-nova09:24
*** k_mouza has quit IRC09:27
*** ratailor has quit IRC09:38
*** k_mouza has joined #openstack-nova09:42
*** ociuhandu has joined #openstack-nova09:53
*** ociuhandu has quit IRC09:53
*** ociuhandu has joined #openstack-nova09:54
openstackgerritMerged openstack/nova master: functional: Move single-use function to its caller  https://review.opendev.org/74590410:06
openstackgerritMerged openstack/nova master: functional: Drop '_api' suffix from placement fixture  https://review.opendev.org/74590510:06
*** belmoreira has quit IRC10:07
*** rcernin has quit IRC10:13
*** mkrai has quit IRC10:14
*** k_mouza has quit IRC10:31
*** k_mouza has joined #openstack-nova10:42
*** brinzhang has quit IRC10:45
*** Liang__ has quit IRC10:48
*** jhesketh has quit IRC10:53
*** jhesketh has joined #openstack-nova10:55
*** rcernin has joined #openstack-nova10:59
*** jangutter_ has joined #openstack-nova10:59
*** jangutter has quit IRC11:02
lyarwoodhttps://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/context.py#L268-L279 - does anyone know if there's a way to get an admin context with a populated service catalog?11:04
lyarwood^ at the moment we are using this during self.driver.resume_state_on_host_boot and failing when attempting to hard reboot instances with encrypted volumes as the key_manager service isn't listed in the service catalog11:05
lyarwoodappreciate that even if it was the admin context wouldn't be able to fetch user secrets without changing policy but I'd still like to fix this if possible11:06
*** rcernin has quit IRC11:12
*** jangutter has joined #openstack-nova11:15
*** jangutter_ has quit IRC11:17
*** raildo has joined #openstack-nova11:22
*** k_mouza has quit IRC11:34
*** boxiang_ has joined #openstack-nova11:40
*** boxiang has quit IRC11:43
*** links has joined #openstack-nova11:46
artomsean-k-mooney, well my VPN just died, but https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L9611:49
artomAnd https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L14411:50
*** yonglihe has quit IRC11:54
*** _erlon_ has joined #openstack-nova11:57
*** k_mouza has joined #openstack-nova12:06
*** k_mouza has quit IRC12:21
*** k_mouza has joined #openstack-nova12:21
*** k_mouza has quit IRC12:26
*** dave-mccowan has joined #openstack-nova12:38
sean-k-mooney artom that only does it for numa migration12:40
sean-k-mooneyartom: it does not print them for all migrations12:40
sean-k-mooneybecause of https://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/virt/libvirt/migration.py#L6612:40
sean-k-mooneywe should move the loging to the start and end of get_updated_guest_xml12:40
sean-k-mooneyso it does it for all migrations12:41
artomsean-k-mooney, ah, in that sense, yeah12:43
sean-k-mooneydansmith: by the way i figured out why https://bugs.launchpad.net/nova/+bug/1888395 happens im working on a repoducer now but the fix is basicaly https://review.opendev.org/#/c/742180/12:44
openstackLaunchpad bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [High,In progress] - Assigned to sean mooney (sean-k-mooney)12:44
sean-k-mooneystephenfin: is the only functional test with live migration and port your new one or do you know if gibi added some for bandwidth based schduling12:46
sean-k-mooneyi think he did but just going to look for them now12:46
sean-k-mooneyartom: you siad your numa live migation test dont use interface right12:47
artomsean-k-mooney, nope12:48
sean-k-mooneyah yes  server = self._create_server(flavor_id=flavor, host=host,12:48
sean-k-mooney                                         networks='none')12:48
artomsean-k-mooney, I'm wondering if it wouldn't be easier to reproduce that migrate_data.vifs bug with a DNM CI patch12:48
artomIs there a way we can deploy Neutron in CI without the multiple port bindings extension?12:48
sean-k-mooneyno but i can hack the nova neutron client to always return false12:49
sean-k-mooneythat may or may not tirgger it i guess12:50
sean-k-mooneyi might however ill try that quickly i would prefer to have a regression test however12:50
artomsean-k-mooney, yeah, long-term something merged in-tree would be better12:51
artomOr a real CI job for it12:51
sean-k-mooneyim not standing up a contrial ci :P12:51
sean-k-mooneylive migration is really uncloudy we should maybe just remove it instead. it would be a lot less work and headaces then a contrail ci :)12:52
artomlulz12:53
sean-k-mooneyit would "fix" all the live migration bugs :)12:53
sean-k-mooneyso there is a live migration test with the old microvertion that does not support it for bandwith12:58
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L5993-L602912:58
sean-k-mooneybut not the new one so ya i think i would need stephenfin patches to cover the gaps in the neutron fixture12:58
sean-k-mooneyoh there are more test for move operatoins later12:59
sean-k-mooneyah ha https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L729913:01
sean-k-mooneytest_live_migrate_with_qos_port13:01
sean-k-mooneyso even without stephenfin patches there is technically enough of a fixture to do the migration with a port13:02
sean-k-mooneyjust not sriov which is fine13:02
sean-k-mooneyi just need to mock the fixture or alter it in the regression test.13:03
sean-k-mooneyi need to redefine https://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/tests/fixtures.py#L1739-L175213:04
sean-k-mooneywhich i think i can do with a mock13:05
*** happyhemant has quit IRC13:10
*** k_mouza has joined #openstack-nova13:19
*** KeithMnemonic has joined #openstack-nova13:20
*** mriedem has joined #openstack-nova13:21
stephenfinyou could totally modify the fixture to remove "support" for multiple port bindings13:22
sean-k-mooneyim just replaceing the list_extensions function on my instance of the fixture object before i activate it13:26
sean-k-mooneyit looks like that shoudl work and is trivial to do13:26
sean-k-mooneyself.neutron = nova_fixtures.NeutronFixture(self)13:26
sean-k-mooney        self.neutron.list_extensions = self.list_extensions13:26
sean-k-mooney        self.useFixture(self.neutron)13:27
sean-k-mooneybasicly that13:27
sean-k-mooneyim basically modifing https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1862633.py13:27
dansmithsean-k-mooney: I saw the discussion, thanks for chasing that down13:27
sean-k-mooneywell not modifing just copying it and creating a new one13:27
sean-k-mooneydansmith: it was not obvious at first but i knew the code path it was taking was for multipel portbindings13:28
*** sapd1 has joined #openstack-nova13:29
sean-k-mooneyanyway hopefully ill have a functional regression test for this today and we can do the too patch thing were i assert the behavior is broken and then that the patch fixes it13:29
dansmithsweet13:30
*** nweinber has joined #openstack-nova13:32
*** mlavalle has joined #openstack-nova14:01
*** lpetrut has quit IRC14:15
*** hongbin has joined #openstack-nova14:23
*** links has quit IRC14:23
*** mvorwerk has quit IRC14:31
*** nweinber has quit IRC14:42
*** dklyle has joined #openstack-nova14:54
*** nweinber has joined #openstack-nova14:58
*** slaweq has quit IRC15:17
*** tkajinam has quit IRC15:26
*** slaweq has joined #openstack-nova15:28
*** gyee has joined #openstack-nova15:34
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722415:41
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775715:42
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777715:43
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809415:43
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810915:43
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811715:44
openstackgerritGhanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies  https://review.opendev.org/74661015:49
*** mkrai has joined #openstack-nova15:53
*** ociuhandu_ has joined #openstack-nova15:53
*** ociuhandu has quit IRC15:56
*** ociuhandu_ has quit IRC15:57
*** mlavalle has quit IRC15:59
*** tosky has quit IRC16:00
*** mlavalle has joined #openstack-nova16:02
*** tesseract has quit IRC16:09
*** suryasingh has quit IRC16:10
*** ociuhandu has joined #openstack-nova16:15
sean-k-mooneyanyone know of the top of your head how i get a valid admin context in a functional test16:16
stephenfinsean-k-mooney: nova.context.get_admin_context()16:19
stephenfinlook for 'self.ctxt' in nova/tests/functional16:19
*** ociuhandu has quit IRC16:19
sean-k-mooneythanks16:19
*** k_mouza has quit IRC16:30
openstackgerritGhanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies  https://review.opendev.org/74661016:39
sean-k-mooneyoh i need to use the libvirt driver in this regression test16:40
sean-k-mooneythat explains why its passing wehn it shoudl not be.16:40
sean-k-mooneyok that is  still doable16:40
*** dtantsur is now known as dtantsur|afk16:50
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()"  https://review.opendev.org/74744316:52
* artom wants a Pulitzer prize for that commit message ^^16:53
artom... which I screwed up.16:53
sean-k-mooneyit certenly rivial some of the epics stephenfin has written lately16:55
sean-k-mooney:) http://paste.openstack.org/show/797050/16:56
sean-k-mooneythere we go repoduced it in a functional test16:56
stephenfinnot so fast16:57
artomNoice.16:57
sean-k-mooneyi feel like im mocking more then i then i need to and could remove some of the fixture im using16:57
stephenfinactually, yeah, that'd make sense for this bug16:57
sean-k-mooneybut on the other hand its working so....16:58
stephenfinwas going to say that was failing for me because the NeutronFixture wasn't setting that field like neutron would in real-life16:58
stephenfinbut of course it'll only set it if the port-binding extension is present16:58
sean-k-mooneyactully that the correct behavior16:58
stephenfinsee the changes I made to https://review.opendev.org/#/c/746947/2/nova/conductor/tasks/live_migrate.py16:58
sean-k-mooneycurrenlty we are setting migrate_data.vif unconditionally16:59
sean-k-mooneyim fixint that16:59
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()"  https://review.opendev.org/74744316:59
stephenfinalready fixed ^16:59
sean-k-mooneyno that is not the fix16:59
sean-k-mooneystephenfin: that code we determined can never be hit16:59
sean-k-mooneythe if will always be false17:00
artomsean-k-mooney, that's just an argument to remove it, which stephenfin is doing17:00
sean-k-mooneyhttps://review.opendev.org/#/c/742180/6/nova/compute/manager.py17:00
sean-k-mooneystephenfin: that id the fix17:00
sean-k-mooneyartom: ya i know17:00
artomBut yeah, they're different things17:00
sean-k-mooneyartom: also the do said to remove it in ussurit and its victoria17:00
* stephenfin doesn't have enough context and doesn't want to start at 6pm on a Friday, so will stay whisht17:02
artomstephenfin, understandable. It took sean-k-mooney and me 2 hours on gmeet to nail it. We considered recording it and just putting the YouTube link in the commit messages.17:03
*** jangutter has quit IRC17:03
*** jangutter has joined #openstack-nova17:04
sean-k-mooneyso we coudl say you can trust us or here 2 hours of trailing through the code to fiture it out17:04
*** mkrai has quit IRC17:04
*** priteau has quit IRC17:07
sean-k-mooneystephenfin: your patch removing that is not wrong by the way we should do that anyway17:07
sean-k-mooneybut lets fix the other issue breaking live migation before merging it i want to try and keep the patches small for backproting17:11
*** psachin has quit IRC17:15
*** k_mouza has joined #openstack-nova17:17
*** chenhaw has joined #openstack-nova17:22
openstackgerritArtom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly  https://review.opendev.org/74745117:38
artomI'm pretty sure I broke some unit tests, let's see what CI says.17:38
*** dustinc has quit IRC17:45
sean-k-mooneythere are a tone of places we saw that could also use the info from the infor case in pre livem migration too right17:46
artomsean-k-mooney, I think they'd have to get double checked one by one...17:50
artomThat being said, maybe it wouldn't hurt to do them all in the same patch17:50
artomOr least, more than 117:50
sean-k-mooneyi would do them in a followup17:50
sean-k-mooneyso just replace teh once case in post live migrate in that one17:51
sean-k-mooneyand then see if you could replace the other use in pre livemigate in a different patch17:51
*** sapd1 has quit IRC17:59
openstackgerritsean mooney proposed openstack/nova master: [WIP] Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/74218018:02
openstackgerritsean mooney proposed openstack/nova master: add functional regression test for bug #188395  https://review.opendev.org/74745418:02
openstackbug 188395 in pyTD "Strange Behavior of the game.creeps list" [Undecided,Fix released] https://launchpad.net/bugs/18839518:02
sean-k-mooneyi still need to add unit tests and update the commit message but thats the repodcuer and fix18:02
sean-k-mooneyas a followup im also thinking of replacing all uses of18:04
sean-k-mooney if 'vifs' in migrate_data and migrate_data.vifs:18:04
sean-k-mooneywith "if migrate_data.using_multiple_port_bindings():"18:04
artomWould definitely be more readable, aye18:04
sean-k-mooneyi can do it as a property so its technically not an ovo change too18:05
sean-k-mooneyif we wanted to backport that18:05
sean-k-mooneybut it will be a spereate patch anyway18:05
sean-k-mooneywell it is an ovo change but not one that is visable when you serialise so its fine18:06
sean-k-mooneyapparently its only there 3 times18:11
sean-k-mooneyi tought it was more18:11
sean-k-mooneyguess not18:11
sean-k-mooneyanyway im going to call it a day o/18:11
*** hongbin has quit IRC18:17
*** mvorwerk has joined #openstack-nova18:23
*** vishalmanchanda has quit IRC18:27
*** martinkennelly has quit IRC18:38
*** bnemec has quit IRC18:53
*** bnemec has joined #openstack-nova19:01
*** bnemec has quit IRC19:08
*** mvorwerk has quit IRC19:09
*** hongbin has joined #openstack-nova19:10
*** mvorwerk_ has joined #openstack-nova19:11
*** mvorwerk_ has quit IRC19:16
*** nweinber_ has joined #openstack-nova19:28
*** yoctozepto1 has joined #openstack-nova19:30
*** raildo_ has joined #openstack-nova19:30
*** raildo has quit IRC19:31
*** arne_wiebalck_ has joined #openstack-nova19:31
*** nweinber has quit IRC19:32
*** arne_wiebalck has quit IRC19:32
*** yoctozepto has quit IRC19:32
*** arne_wiebalck_ is now known as arne_wiebalck19:32
*** yoctozepto1 is now known as yoctozepto19:32
*** gyee has quit IRC19:32
*** gyee has joined #openstack-nova19:36
*** csatari_ has joined #openstack-nova19:37
*** jhesketh_ has joined #openstack-nova19:38
*** slaweq has quit IRC19:42
*** csatari has quit IRC19:42
*** jhesketh has quit IRC19:42
*** csatari_ is now known as csatari19:42
*** mlavalle has quit IRC19:42
*** mlavalle has joined #openstack-nova19:48
*** slaweq has joined #openstack-nova19:53
*** slaweq has quit IRC19:57
*** slaweq has joined #openstack-nova20:03
*** slaweq has quit IRC20:07
*** artom has quit IRC20:21
*** nweinber_ has quit IRC20:30
*** tosky has joined #openstack-nova20:30
*** artom has joined #openstack-nova21:13
*** owalsh has quit IRC21:25
*** bbowen__ has quit IRC21:29
*** bbowen has joined #openstack-nova21:34
*** KeithMnemonic has quit IRC21:40
openstackgerritMerged openstack/nova master: Add new default roles in FIP policies  https://review.opendev.org/74203021:46
*** dave-mccowan has quit IRC22:03
*** k_mouza has quit IRC22:11
*** ociuhandu has joined #openstack-nova22:16
*** ociuhandu has quit IRC22:21
*** jamesdenton has joined #openstack-nova22:31
*** _erlon_ has quit IRC22:46
*** mriedem has quit IRC22:47
*** mlavalle has quit IRC23:02
openstackgerritArtom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly  https://review.opendev.org/74745123:16
*** tosky has quit IRC23:48
« Thursday, 2020-08-20 Index Saturday, 2020-08-22 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!