| *** songwenping_ has joined #openstack-nova | 00:23 | |
| *** zhanglong has joined #openstack-nova | 00:25 | |
| *** songwenping__ has quit IRC | 00:26 | |
| *** zhanglong has quit IRC | 00:32 | |
| *** zhanglong has joined #openstack-nova | 00:42 | |
| *** brinzhang has joined #openstack-nova | 00:51 | |
| brinzhang | gibi_pto_24th, gmann, stephenfin, alex_xu, bauzas: I was update the runway slot, because some patches have reached the dealine in the slot | 00:55 |
|---|---|---|
| *** ociuhandu has joined #openstack-nova | 01:00 | |
| *** hack-char has joined #openstack-nova | 01:01 | |
| *** ociuhandu has quit IRC | 01:05 | |
| *** suryasingh has joined #openstack-nova | 01:06 | |
| *** songwenping__ has joined #openstack-nova | 01:43 | |
| *** songwenping_ has quit IRC | 01:46 | |
| *** songwenping__ has quit IRC | 01:46 | |
| *** songwenping__ has joined #openstack-nova | 01:47 | |
| *** ociuhandu has joined #openstack-nova | 02:25 | |
| *** ociuhandu has quit IRC | 02:29 | |
| *** brinzhang_ has joined #openstack-nova | 02:34 | |
| *** brinzhang has quit IRC | 02:37 | |
| *** sapd1 has joined #openstack-nova | 02:50 | |
| *** brinzhang0 has joined #openstack-nova | 03:04 | |
| *** songwenping_ has joined #openstack-nova | 03:04 | |
| *** brinzhang_ has quit IRC | 03:07 | |
| *** songwenping__ has quit IRC | 03:07 | |
| *** mkrai has joined #openstack-nova | 03:20 | |
| *** psachin has joined #openstack-nova | 03:37 | |
| *** zhanglong has quit IRC | 04:27 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** links has joined #openstack-nova | 05:02 | |
| *** brinzhang_ has joined #openstack-nova | 05:04 | |
| *** brinzhang0 has quit IRC | 05:06 | |
| *** sapd1 has quit IRC | 05:11 | |
| *** zhanglong has joined #openstack-nova | 05:28 | |
| *** songwenping__ has joined #openstack-nova | 05:45 | |
| *** songwenping_ has quit IRC | 05:48 | |
| *** brinzhang0 has joined #openstack-nova | 05:54 | |
| *** songwenping_ has joined #openstack-nova | 05:54 | |
| *** slaweq has joined #openstack-nova | 05:55 | |
| *** songwenping__ has quit IRC | 05:57 | |
| *** brinzhang_ has quit IRC | 05:57 | |
| *** slaweq has quit IRC | 06:00 | |
| *** mkrai has quit IRC | 06:00 | |
| *** mkrai_ has joined #openstack-nova | 06:01 | |
| *** sapd1 has joined #openstack-nova | 06:10 | |
| *** sapd1 has quit IRC | 06:11 | |
| *** sapd1 has joined #openstack-nova | 06:13 | |
| *** damien_r has joined #openstack-nova | 06:24 | |
| *** damien_r has quit IRC | 06:24 | |
| *** xek has joined #openstack-nova | 06:26 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:34 | |
| *** zhanglong has quit IRC | 06:37 | |
| *** zhanglong has joined #openstack-nova | 06:40 | |
| *** happyhemant has joined #openstack-nova | 06:40 | |
| *** songwenping__ has joined #openstack-nova | 06:43 | |
| *** belmoreira has joined #openstack-nova | 06:45 | |
| *** songwenping_ has quit IRC | 06:46 | |
| *** vishalmanchanda has joined #openstack-nova | 06:49 | |
| *** mvorwerk has joined #openstack-nova | 06:52 | |
| *** links has quit IRC | 06:52 | |
| *** tobias-urdin has joined #openstack-nova | 06:56 | |
| *** mvorwerk_ has joined #openstack-nova | 06:57 | |
| *** mvorwerk has quit IRC | 06:58 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 06:59 | |
| *** maciejjozefczyk has quit IRC | 06:59 | |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 07:02 | |
| *** tesseract has joined #openstack-nova | 07:03 | |
| *** mkrai_ has quit IRC | 07:07 | |
| *** songwenping_ has joined #openstack-nova | 07:14 | |
| *** songwenping__ has quit IRC | 07:16 | |
| *** jsuchome has joined #openstack-nova | 07:24 | |
| *** zhanglong has quit IRC | 07:28 | |
| *** zhanglong has joined #openstack-nova | 07:30 | |
| *** songwenping__ has joined #openstack-nova | 07:44 | |
| *** songwenping_ has quit IRC | 07:46 | |
| openstackgerrit | Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068 | 07:50 |
| *** dtantsur|afk is now known as dtantsur | 07:55 | |
| *** tosky has joined #openstack-nova | 07:56 | |
| *** zhanglong has quit IRC | 08:00 | |
| *** k_mouza has joined #openstack-nova | 08:03 | |
| *** brinzhang_ has joined #openstack-nova | 08:04 | |
| *** brinzhang0 has quit IRC | 08:07 | |
| *** zhanglong has joined #openstack-nova | 08:13 | |
| *** martinkennelly has joined #openstack-nova | 08:18 | |
| *** mkrai has joined #openstack-nova | 08:30 | |
| *** k_mouza has quit IRC | 08:41 | |
| *** songwenping_ has joined #openstack-nova | 08:43 | |
| *** links has joined #openstack-nova | 08:44 | |
| *** k_mouza has joined #openstack-nova | 08:45 | |
| *** songwenping__ has quit IRC | 08:46 | |
| *** happyhemant has quit IRC | 08:50 | |
| *** zhanglong has quit IRC | 08:52 | |
| *** zhanglong has joined #openstack-nova | 08:54 | |
| *** slaweq has joined #openstack-nova | 09:07 | |
| *** luyao has quit IRC | 09:10 | |
| *** arne_wiebalck has quit IRC | 09:11 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/746210/ - would you mind hitting this today? simple fup from https://review.opendev.org/#/q/I7eb86edc130d186a66c04b229d46347ec5c0b625 as we all missed we are using < v4.1.0 in CI at the moment. | 09:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/746464 | 09:12 |
| *** songwenping__ has joined #openstack-nova | 09:13 | |
| stephenfin | sure | 09:13 |
| *** arne_wiebalck has joined #openstack-nova | 09:14 | |
| *** songwenping_ has quit IRC | 09:17 | |
| *** swp20 has joined #openstack-nova | 09:18 | |
| *** luyao has joined #openstack-nova | 09:19 | |
| *** songwenping__ has quit IRC | 09:20 | |
| lyarwood | stephenfin: are you rebasing the vtpm stuff today btw? | 09:25 |
| stephenfin | yup, in the middle of that atm | 09:25 |
| lyarwood | wonderful | 09:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285 | 09:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_guest' https://review.opendev.org/741286 | 09:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500 | 09:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | 09:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 09:31 |
| *** slaweq has quit IRC | 09:32 | |
| *** ociuhandu has joined #openstack-nova | 09:44 | |
| *** tkajinam has quit IRC | 09:55 | |
| *** jangutter has joined #openstack-nova | 09:57 | |
| *** Luzi has joined #openstack-nova | 09:59 | |
| *** brinzhang_ has quit IRC | 10:04 | |
| *** brinzhang_ has joined #openstack-nova | 10:04 | |
| *** brinzhang_ has quit IRC | 10:06 | |
| *** brinzhang_ has joined #openstack-nova | 10:06 | |
| *** k_mouza has quit IRC | 10:10 | |
| *** k_mouza has joined #openstack-nova | 10:12 | |
| *** ociuhandu has quit IRC | 10:37 | |
| *** mkrai has quit IRC | 10:37 | |
| *** mkrai has joined #openstack-nova | 10:37 | |
| *** priteau has joined #openstack-nova | 10:41 | |
| *** mkrai has quit IRC | 10:48 | |
| *** mkrai has joined #openstack-nova | 10:48 | |
| *** k_mouza has quit IRC | 10:52 | |
| *** sapd1 has quit IRC | 10:52 | |
| *** k_mouza has joined #openstack-nova | 10:55 | |
| *** happyhemant has joined #openstack-nova | 11:25 | |
| *** breizhkoala has joined #openstack-nova | 11:26 | |
| *** tkajinam has joined #openstack-nova | 11:27 | |
| openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | 11:32 |
| *** songwenping_ has joined #openstack-nova | 11:34 | |
| *** brinzhang0 has joined #openstack-nova | 11:34 | |
| *** swp20 has quit IRC | 11:36 | |
| *** brinzhang_ has quit IRC | 11:37 | |
| *** dave-mccowan has joined #openstack-nova | 11:39 | |
| lyarwood | stephenfin: do you plan on blocking non-owner ops with vTPM instances in the API? | 11:41 |
| *** raildo has joined #openstack-nova | 11:49 | |
| *** k_mouza has quit IRC | 11:57 | |
| openstackgerrit | Merged openstack/nova master: Remove dead volume driver code https://review.opendev.org/745393 | 12:07 |
| *** songwenping__ has joined #openstack-nova | 12:09 | |
| *** mkrai has quit IRC | 12:10 | |
| *** songwenping_ has quit IRC | 12:11 | |
| *** brinzhang_ has joined #openstack-nova | 12:14 | |
| *** brinzhang0 has quit IRC | 12:17 | |
| *** tesseract has quit IRC | 12:17 | |
| *** ratailor has quit IRC | 12:21 | |
| *** songwenping_ has joined #openstack-nova | 12:23 | |
| *** songwenping__ has quit IRC | 12:26 | |
| *** zhanglong has quit IRC | 12:29 | |
| *** lbragstad has quit IRC | 12:32 | |
| *** dave-mccowan has quit IRC | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:37 | |
| *** dave-mccowan has joined #openstack-nova | 12:41 | |
| *** ociuhandu has quit IRC | 12:42 | |
| *** lbragstad has joined #openstack-nova | 12:43 | |
| *** songwenping__ has joined #openstack-nova | 12:43 | |
| *** artom has joined #openstack-nova | 12:44 | |
| *** tesseract has joined #openstack-nova | 12:45 | |
| *** songwenping_ has quit IRC | 12:46 | |
| *** mkrai has joined #openstack-nova | 12:54 | |
| *** mkrai has quit IRC | 13:00 | |
| *** nweinber has joined #openstack-nova | 13:01 | |
| *** Luzi has quit IRC | 13:26 | |
| *** dtantsur has quit IRC | 13:32 | |
| lyarwood | melwitt: https://review.opendev.org/#/c/746210/ - Morning, when you're online would you mind taking a look at this please? | 13:33 |
| *** songwenping_ has joined #openstack-nova | 13:33 | |
| *** brinzhang0 has joined #openstack-nova | 13:33 | |
| *** brinzhang0 has quit IRC | 13:35 | |
| *** brinzhang0 has joined #openstack-nova | 13:35 | |
| *** brinzhang_ has quit IRC | 13:36 | |
| *** songwenping__ has quit IRC | 13:37 | |
| *** ociuhandu has joined #openstack-nova | 13:37 | |
| *** dtantsur has joined #openstack-nova | 13:38 | |
| *** k_mouza has joined #openstack-nova | 13:57 | |
| *** k_mouza has quit IRC | 14:02 | |
| *** tkajinam has quit IRC | 14:06 | |
| *** mvorwerk_ has quit IRC | 14:18 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Mock LoopingCallBase._sleep in rbd tests https://review.opendev.org/745512 | 14:20 |
| lyarwood | stephenfin: ^ trivial one for you if you have bandwidth | 14:20 |
| stephenfin | lyarwood: done | 14:22 |
| stephenfin | as for your earlier question (sorry, missed it then), yeah, that probably makes sense. I assume all non-owner ops except delete, of course | 14:23 |
| *** songwenping__ has joined #openstack-nova | 14:23 | |
| *** mvorwerk has joined #openstack-nova | 14:25 | |
| *** brinzhang has joined #openstack-nova | 14:25 | |
| *** ircuser-1 has joined #openstack-nova | 14:26 | |
| *** songwenping_ has quit IRC | 14:26 | |
| *** brinzhang0 has quit IRC | 14:27 | |
| *** k_mouza has joined #openstack-nova | 14:27 | |
| lyarwood | stephenfin: well any move ops really | 14:29 |
| lyarwood | stephenfin: hard reboot as well thinking about it | 14:30 |
| *** mvorwerk_ has joined #openstack-nova | 14:30 | |
| gmann | lyarwood: stephenfin can you check this, Focal migration patch is ready- https://review.opendev.org/#/c/738126/ | 14:32 |
| *** mvorwerk has quit IRC | 14:33 | |
| *** brinzhang_ has joined #openstack-nova | 14:34 | |
| openstackgerrit | Merged openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/746464 | 14:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in baremetal nodes policies https://review.opendev.org/741716 | 14:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in baremetal nodes policy https://review.opendev.org/741717 | 14:36 |
| *** brinzhang has quit IRC | 14:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add scope and new default roles in extensions policies https://review.opendev.org/743046 | 14:40 |
| lyarwood | gmann: so what about that change moves us to focal? Wouldn't it be better to say that this is just bumping our reqs so we *can* move to focal in the future? | 14:42 |
| *** songwenping_ has joined #openstack-nova | 14:43 | |
| gmann | lyarwood: with the depends-on in previous PS tested all devstack based jobs on focal to it also made sure everything worked fine here so whenever base jobs moves to Focal nova automatically start tested on Focal | 14:44 |
| *** psachin has quit IRC | 14:45 | |
| *** links has quit IRC | 14:46 | |
| *** songwenping__ has quit IRC | 14:46 | |
| lyarwood | gmann: shouldn't we have a .DNM change on top of this to ensure it's still working? | 14:47 |
| lyarwood | gmann: oh I see the PS now | 14:48 |
| gmann | lyarwood: Patch Set 14 was that | 14:48 |
| gmann | yeah, i am testing first and then removing the depensd-on to merge it before base job migrate and break the gate | 14:48 |
| lyarwood | gmann: hmm but that had a depends-on of https://review.opendev.org/#/c/746327/ ? | 14:48 |
| lyarwood | gmann: that doesn't seem right | 14:49 |
| lyarwood | oh and that was the tip of the focal changes | 14:49 |
| gmann | yeah | 14:49 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566 | 14:51 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568 | 14:52 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/746527 | 14:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/ussuri: Add regression test for bug 1879787 https://review.opendev.org/746528 | 14:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/ussuri: Handle Neutron errors in _post_live_migration() https://review.opendev.org/746529 | 14:53 |
| openstack | bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom) | 14:53 |
| lyarwood | gmann: some quick nits in the commit message otherwise it LGTM | 14:56 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030 | 14:57 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in FIP policy https://review.opendev.org/742570 | 14:58 |
| *** gyee has joined #openstack-nova | 14:58 | |
| gmann | stephenfin: gibi_pto_24th I have rebased the policy pacthes due to conflict. please re-approve those. I have made them in series to avoid any future conflict. - https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh-deprecated-apis+status:open | 14:59 |
| gmann | lyarwood: thanks, checking | 14:59 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04) https://review.opendev.org/738126 | 15:00 |
| *** purplerbot has quit IRC | 15:00 | |
| gmann | lyarwood: ^^ | 15:00 |
| *** purplerbot has joined #openstack-nova | 15:01 | |
| melwitt | lyarwood: ack will do | 15:03 |
| *** brinzhang0 has joined #openstack-nova | 15:04 | |
| *** brinzhang_ has quit IRC | 15:06 | |
| *** sapd1 has joined #openstack-nova | 15:08 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281 | 15:11 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker https://review.opendev.org/745282 | 15:11 |
| *** dklyle has joined #openstack-nova | 15:13 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker https://review.opendev.org/745282 | 15:14 |
| *** mlavalle has joined #openstack-nova | 15:15 | |
| *** belmoreira has quit IRC | 15:20 | |
| openstackgerrit | Merged openstack/nova master: Remove monotonic usage https://review.opendev.org/725425 | 15:29 |
| openstackgerrit | Merged openstack/nova master: Rebase qcow2 images when unshelving an instance https://review.opendev.org/696084 | 15:29 |
| *** prometheanfire has joined #openstack-nova | 15:30 | |
| prometheanfire | any work nova side to support mock 4.0.2? https://review.opendev.org/712713 | 15:31 |
| *** songwenping__ has joined #openstack-nova | 15:34 | |
| *** happyhemant has quit IRC | 15:35 | |
| melwitt | prometheanfire: I spent a lot of time on it, didn't get anywhere, got discouraged. working up the will to try again | 15:35 |
| prometheanfire | fair | 15:37 |
| *** songwenping_ has quit IRC | 15:37 | |
| *** martinkennelly has quit IRC | 15:41 | |
| *** priteau has quit IRC | 15:57 | |
| *** mkrai has joined #openstack-nova | 16:02 | |
| *** martinkennelly has joined #openstack-nova | 16:18 | |
| *** belmoreira has joined #openstack-nova | 16:33 | |
| *** songwenping_ has joined #openstack-nova | 16:33 | |
| *** belmoreira has quit IRC | 16:36 | |
| *** songwenping__ has quit IRC | 16:36 | |
| *** k_mouza has quit IRC | 16:37 | |
| *** brinzhang_ has joined #openstack-nova | 16:38 | |
| *** brinzhang0 has quit IRC | 16:42 | |
| *** alex_xu has quit IRC | 16:43 | |
| *** tesseract has quit IRC | 16:52 | |
| *** sapd1 has quit IRC | 16:56 | |
| *** dtantsur is now known as dtantsur|afk | 16:59 | |
| *** mkrai has quit IRC | 17:05 | |
| *** artom has quit IRC | 17:30 | |
| *** artom has joined #openstack-nova | 17:32 | |
| *** brinzhang0 has joined #openstack-nova | 17:37 | |
| *** vishalmanchanda has quit IRC | 17:37 | |
| *** brinzhang_ has quit IRC | 17:40 | |
| *** kegorov35 has joined #openstack-nova | 17:44 | |
| kegorov35 | hey! my supervisor told me that this review https://review.opendev.org/#/c/742180/ should be merged. can you please merge it or explain to me why can't you merge it | 17:45 |
| kegorov35 | #openstack-nova urgent question | 17:56 |
| prometheanfire | kegorov35: better to ask for a review than a merge (a review allows the review to say no, a merge kinda expects a yes) | 17:58 |
| dansmith | kegorov35: it can't be merged because it hasn't been reviewed, and definitely because it has no tests, and also because it claims there's a bug being fixed, with non referenced and no reproducer information | 17:58 |
| dansmith | oh I see it's jammed in the subject, but still.. | 18:01 |
| *** kegorov35 has quit IRC | 18:08 | |
| *** mriedem has joined #openstack-nova | 18:08 | |
| openstackgerrit | Luigi Toscano proposed openstack/nova master: zuul: use the new barbican simple-crypto job https://review.opendev.org/746583 | 18:10 |
| *** jsuchome has quit IRC | 18:29 | |
| *** hoonetorg has joined #openstack-nova | 18:29 | |
| *** breizhkoala has quit IRC | 18:36 | |
| *** songwenping__ has joined #openstack-nova | 18:44 | |
| *** slaweq has joined #openstack-nova | 18:44 | |
| prometheanfire | melwitt: for mock, my stance is that if nova is not gonna use the python builtin unittest.mock then it needs to update :| | 18:46 |
| *** songwenping_ has quit IRC | 18:46 | |
| melwitt | prometheanfire: we want to and we can, but the snag is that the fixtures library we use (https://pypi.org/project/fixtures/) prefers the third-party mock library when it imports mock, and then it creates mocks using that library, and so when we "switch" to unittest.mock in some places, we end up with third-party mocks + unittest.mocks that don't know about each other and we can't "stop" a third-party mock embedded inside the fixtures | 18:49 |
| melwitt | library without importing third-party mock | 18:49 |
| prometheanfire | melwitt: understood, I wasn't knocking you at all :D | 18:49 |
| melwitt | everything works fine if the third-party mock library is not installed in the venv at all but if it's present, fixtures prefers it and causes problems | 18:50 |
| melwitt | I tried a bunch of workarounds and none worked, I ran out of ideas and I haven't been back yet to see if I could find some other way around | 18:50 |
| prometheanfire | eww, uses launchpad :P | 18:50 |
| melwitt | maybe if I did something like fixtures.<whatever>.mock.stopall() that might work | 18:51 |
| mriedem | hack idea: monkey patch the 3rd party lib with the std lib if found | 18:53 |
| melwitt | yesss mriedem | 18:53 |
| melwitt | this is right up your alley | 18:54 |
| melwitt | thanks. I will try that too | 18:54 |
| prometheanfire | hmm, I don't see fixtures itself calling mock, so I guess it's in how nova calls fixtures? | 18:55 |
| mriedem | my guess is it's this down in here https://github.com/testing-cabal/fixtures/blob/41774d58ed86b92dd60d727f00f1040f862c8ed1/fixtures/_fixtures/mockpatch.py#L22 | 18:56 |
| melwitt | mriedem: yup, that's exactly it | 18:56 |
| mriedem | could probably also avoid using those fixtures, there are other ways of doing those | 18:57 |
| mriedem | but their usage might be pervasive | 18:57 |
| melwitt | yeah, fair | 18:57 |
| mriedem | not sure how you _prevent_ their usage later without a hacking check | 18:57 |
| prometheanfire | hmm, ya, guess I was looking at what pypi linked to (launchpad) and not testing-cabal's org | 18:58 |
| mriedem | i remember quite a bit of this in nova which isn't using mock https://github.com/openstack/nova/blob/master/nova/test.py#L352 but _can_ be replaced with mock | 18:59 |
| mriedem | and stuff like https://github.com/openstack/nova/blob/master/nova/test.py#L423 could be replaced to just be mock rather than fixtures | 18:59 |
| mriedem | i smell a 3 year all encompassing blueprint coming on | 18:59 |
| melwitt | we could chance it and just fix the stuck cases (by not using fixtures in those spots) and then once third-party mock is gone from reqs, we are in the clear for future even with fixtures | 18:59 |
| melwitt | lol @ 3 year blueprint. yes, I think we all want that in our life | 19:00 |
| mriedem | i've had to ween myself off the fixtures library because i don't think it works with pytest, and i'm in pytest land now | 19:01 |
| melwitt | ah | 19:01 |
| *** belmoreira has joined #openstack-nova | 19:13 | |
| *** songwenping_ has joined #openstack-nova | 19:14 | |
| *** songwenping__ has quit IRC | 19:17 | |
| *** smcginnis has quit IRC | 19:19 | |
| *** smcginnis has joined #openstack-nova | 19:21 | |
| *** martinkennelly has quit IRC | 19:31 | |
| *** martinkennelly has joined #openstack-nova | 19:31 | |
| *** slaweq has quit IRC | 19:36 | |
| *** slaweq has joined #openstack-nova | 19:46 | |
| *** slaweq has quit IRC | 19:52 | |
| *** belmoreira has quit IRC | 20:43 | |
| *** nweinber has quit IRC | 20:45 | |
| *** xek has quit IRC | 21:00 | |
| *** maciejjozefczyk has quit IRC | 21:01 | |
| *** raildo has quit IRC | 21:22 | |
| openstackgerrit | Kirill Egorov proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180 | 21:23 |
| openstack | bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742) | 21:23 |
| *** songwenping__ has joined #openstack-nova | 21:34 | |
| *** songwenping_ has quit IRC | 21:37 | |
| *** ociuhandu has quit IRC | 21:39 | |
| *** brinzhang_ has joined #openstack-nova | 21:44 | |
| *** brinzhang0 has quit IRC | 21:47 | |
| *** mgoddard has quit IRC | 22:10 | |
| *** mgoddard has joined #openstack-nova | 22:18 | |
| *** mriedem has left #openstack-nova | 22:23 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610 | 22:28 |
| *** rcernin has joined #openstack-nova | 22:33 | |
| *** songwenping_ has joined #openstack-nova | 22:34 | |
| *** mvorwerk_ has quit IRC | 22:35 | |
| *** songwenping__ has quit IRC | 22:37 | |
| *** mlavalle has quit IRC | 22:38 | |
| *** tosky has quit IRC | 22:57 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/746210 | 23:00 |
| *** martinkennelly has quit IRC | 23:00 | |
| *** breizhkoala has joined #openstack-nova | 23:03 | |
| *** tkajinam has joined #openstack-nova | 23:07 | |
| *** mvorwerk has joined #openstack-nova | 23:08 | |
| *** brinzhang0 has joined #openstack-nova | 23:09 | |
| *** brinzhang_ has quit IRC | 23:12 | |
| *** mvorwerk has quit IRC | 23:12 | |
| *** mvorwerk has joined #openstack-nova | 23:17 | |
| *** ociuhandu has joined #openstack-nova | 23:39 | |
| *** ociuhandu has quit IRC | 23:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!