| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix multinic policy for admin_or_owner https://review.opendev.org/742317 | 00:01 |
|---|---|---|
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315 | 00:01 |
| *** gyee has quit IRC | 00:20 | |
| *** hamalq has quit IRC | 00:27 | |
| *** tetsuro has joined #openstack-nova | 00:27 | |
| *** zhanglong has joined #openstack-nova | 00:33 | |
| *** brinzhang has joined #openstack-nova | 00:44 | |
| *** brinzhang_ has joined #openstack-nova | 00:51 | |
| *** brinzhang has quit IRC | 00:53 | |
| *** k_mouza has joined #openstack-nova | 01:12 | |
| *** nweinber has joined #openstack-nova | 01:12 | |
| *** k_mouza has quit IRC | 01:16 | |
| *** zhanglong has quit IRC | 01:24 | |
| *** zhanglong has joined #openstack-nova | 01:24 | |
| *** hamalq has joined #openstack-nova | 01:30 | |
| *** hamalq_ has joined #openstack-nova | 01:31 | |
| *** hamalq has quit IRC | 01:36 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315 | 01:36 |
| *** hamalq_ has quit IRC | 01:38 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328 | 01:40 |
| *** nweinber has quit IRC | 01:44 | |
| *** zhanglong has quit IRC | 01:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330 | 01:53 |
| *** zhanglong has joined #openstack-nova | 01:55 | |
| *** yaawang has quit IRC | 01:57 | |
| *** yaawang has joined #openstack-nova | 01:58 | |
| *** hamalq has joined #openstack-nova | 02:04 | |
| openstackgerrit | Merged openstack/nova master: Remove broken legacy zuul jobs https://review.opendev.org/741603 | 02:09 |
| *** hamalq has quit IRC | 02:10 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 02:12 |
| *** nweinber has joined #openstack-nova | 02:16 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315 | 02:17 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328 | 02:18 |
| *** tetsuro has quit IRC | 02:20 | |
| openstackgerrit | Merged openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866 | 02:22 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies https://review.opendev.org/742330 | 02:23 |
| *** zhanglong has quit IRC | 02:29 | |
| *** zhanglong has joined #openstack-nova | 02:33 | |
| *** sapd1 has joined #openstack-nova | 02:41 | |
| *** nweinber has quit IRC | 02:42 | |
| openstackgerrit | Merged openstack/nova master: Make our ceph job test with glance in multistore mode https://review.opendev.org/734184 | 02:46 |
| *** dave-mccowan has quit IRC | 02:51 | |
| *** huaqiang has quit IRC | 02:56 | |
| openstackgerrit | Merged openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531 | 03:23 |
| *** psachin has joined #openstack-nova | 03:31 | |
| *** Liang__ has joined #openstack-nova | 03:31 | |
| tony_su | gibi: alex_xu: Thanks for your reviewing and comments. I will check them and update patches accordingly. In any way I have to change patches as there is merging conflict. | 03:32 |
| *** redrobot has quit IRC | 03:42 | |
| *** ratailor has joined #openstack-nova | 04:14 | |
| *** ratailor_ has joined #openstack-nova | 04:26 | |
| *** ratailor has quit IRC | 04:26 | |
| *** zhanglong has quit IRC | 04:30 | |
| *** zhanglong has joined #openstack-nova | 04:34 | |
| *** hamalq has joined #openstack-nova | 04:43 | |
| *** hamalq_ has joined #openstack-nova | 04:44 | |
| *** hamalq has quit IRC | 04:48 | |
| *** hamalq_ has quit IRC | 04:55 | |
| *** udesale has joined #openstack-nova | 05:27 | |
| *** sapd1 has quit IRC | 05:32 | |
| *** tobias-urdin|pto has quit IRC | 05:39 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 05:43 | |
| *** links has joined #openstack-nova | 05:44 | |
| *** sapd1 has joined #openstack-nova | 05:54 | |
| *** vishalmanchanda has joined #openstack-nova | 05:55 | |
| *** iurygregory has joined #openstack-nova | 06:25 | |
| *** elod is now known as elod_off | 06:31 | |
| openstackgerrit | Adit Sarfaty proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565 | 06:39 |
| *** eharney has quit IRC | 06:40 | |
| *** eharney has joined #openstack-nova | 06:52 | |
| *** nightmare_unreal has joined #openstack-nova | 07:01 | |
| *** damien_r has joined #openstack-nova | 07:08 | |
| *** tesseract has joined #openstack-nova | 07:10 | |
| *** ociuhandu has quit IRC | 07:10 | |
| *** sapd1 has quit IRC | 07:10 | |
| *** zhanglong has quit IRC | 07:11 | |
| *** damien_r has quit IRC | 07:12 | |
| *** sapd1 has joined #openstack-nova | 07:13 | |
| *** zhanglong has joined #openstack-nova | 07:15 | |
| *** ralonsoh has joined #openstack-nova | 07:29 | |
| *** rcernin has quit IRC | 07:32 | |
| gibi | stephenfin: hi! you vtpm patches are the next for a runway slot, but if I understood correctly the main feature patches are in merge conflict. | 07:33 |
| gibi | stephenfin: if you have a set of ready patches then I can pull that into a slot | 07:33 |
| gibi | stephenfin: do you have a clear bottom that is ready? | 07:34 |
| *** xek has joined #openstack-nova | 07:36 | |
| *** ociuhandu has joined #openstack-nova | 07:36 | |
| *** tosky has joined #openstack-nova | 07:39 | |
| *** zhanglong has quit IRC | 07:40 | |
| openstackgerrit | Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180 | 07:46 |
| openstack | bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742) | 07:46 |
| *** markvoelker has joined #openstack-nova | 07:47 | |
| *** markvoelker has quit IRC | 07:52 | |
| openstackgerrit | Sergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395 https://review.opendev.org/742180 | 07:53 |
| openstack | bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742) | 07:53 |
| *** zhanglong has joined #openstack-nova | 07:59 | |
| *** kleini has joined #openstack-nova | 08:01 | |
| kleini | What means a cpu_allocation_ratio of zero actually in placement or scheduler? | 08:01 |
| *** tosky has quit IRC | 08:04 | |
| *** tosky_ has joined #openstack-nova | 08:04 | |
| *** jangutter_ has joined #openstack-nova | 08:05 | |
| gibi | kleini: have you seen the Note in this doc ? https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.cpu_allocation_ratio | 08:07 |
| kleini | Yes, but it confuses me more, than it clarifies behavior for me. | 08:07 |
| gibi | kleini: OK, then the next piece of doc is https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios | 08:09 |
| *** jangutter has quit IRC | 08:09 | |
| kleini | That clarifies the defaults. Many thanks! | 08:09 |
| kleini | I was already on the same page but did not read past compute filters *facepalm* | 08:11 |
| gibi | you are welcome | 08:11 |
| *** kaisers has joined #openstack-nova | 08:11 | |
| *** yaawang has quit IRC | 08:13 | |
| *** sapd1 has quit IRC | 08:13 | |
| *** yaawang has joined #openstack-nova | 08:13 | |
| *** aj_mailing has quit IRC | 08:13 | |
| gibi | kleini: don't be hard on yourself, allocation ratios is confusing | 08:14 |
| *** aj_mailing has joined #openstack-nova | 08:14 | |
| *** aj_mailing has quit IRC | 08:14 | |
| kleini | yes, a whole OpenStack is huge and maintenance sometimes gives headaches but it always resolves somehow after some time of research. | 08:15 |
| *** aj_mailing has joined #openstack-nova | 08:16 | |
| *** tosky_ is now known as tosky | 08:19 | |
| *** jraju__ has joined #openstack-nova | 08:21 | |
| *** links has quit IRC | 08:21 | |
| *** sapd1 has joined #openstack-nova | 08:22 | |
| *** tetsuro has joined #openstack-nova | 08:24 | |
| *** martinkennelly has joined #openstack-nova | 08:27 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561 | 08:33 |
| *** tetsuro has quit IRC | 08:48 | |
| stephenfin | gibi: I can rebase, but I was hoping lyarwood might be able to hit some of the lower ones that you've already looked at before I did | 08:48 |
| lyarwood | stephenfin: vtpm? | 08:49 |
| lyarwood | stephenfin: I'll take a look this morning once I've woken up a little more, had a long night :| | 08:51 |
| stephenfin | lyarwood: yup and sure, no problem :D | 08:51 |
| lyarwood | stephenfin / gibi ; https://review.opendev.org/#/c/741561/ should be ready for reviews now btw now that melwitt++ has updated the comments | 08:52 |
| *** dtantsur|afk is now known as dtantsur | 08:52 | |
| *** kashyap has joined #openstack-nova | 08:53 | |
| kashyap | lyarwood: I appreciate the commit message with informative (non-null) pointers -- https://review.opendev.org/#/c/741561/. Good sleuthing :-) | 08:59 |
| *** ratailor__ has joined #openstack-nova | 09:04 | |
| lyarwood | I thought you might :) | 09:04 |
| *** ratailor_ has quit IRC | 09:06 | |
| gibi | stephenfin: OK. we can put the lower ones into a slot | 09:06 |
| gibi | lyarwood: approved https://review.opendev.org/#/c/741561/ | 09:09 |
| *** jangutter has joined #openstack-nova | 09:10 | |
| *** rcernin has joined #openstack-nova | 09:10 | |
| *** aj_mailing has quit IRC | 09:11 | |
| lyarwood | gibi: thanks | 09:12 |
| *** jangutter_ has quit IRC | 09:13 | |
| stephenfin | I really wish Gerrit had notifications a lá GitHub. Would save me parsing the emails every morning :-\ | 09:15 |
| *** zhanglong has quit IRC | 09:17 | |
| *** xek has quit IRC | 09:19 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712 | 09:21 |
| *** zhanglong has joined #openstack-nova | 09:27 | |
| *** rcernin has quit IRC | 09:35 | |
| openstackgerrit | Merged openstack/nova master: hardware: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706 | 09:37 |
| *** sapd1 has quit IRC | 09:37 | |
| *** Liang__ has quit IRC | 09:40 | |
| *** k_mouza has joined #openstack-nova | 09:53 | |
| *** udesale_ has joined #openstack-nova | 09:58 | |
| tony_su | gibi: just status update for provider-config-file patches. I have updated the first two patches and is now working on the 3rd patch. | 10:00 |
| *** udesale has quit IRC | 10:01 | |
| *** yaawang has quit IRC | 10:11 | |
| *** yaawang has joined #openstack-nova | 10:12 | |
| gibi | tony_su: thanks. i will try to get back those patches soon | 10:13 |
| *** sapd1_y has quit IRC | 10:14 | |
| *** sapd1 has joined #openstack-nova | 10:14 | |
| openstackgerrit | Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565 | 10:15 |
| stephenfin | lyarwood: Could you also re-add https://review.opendev.org/742383 to your list? | 10:17 |
| *** yaawang has quit IRC | 10:20 | |
| *** yaawang has joined #openstack-nova | 10:21 | |
| lyarwood | stephenfin: ack | 10:24 |
| stephenfin | ta | 10:27 |
| stephenfin | bauzas: Got an old, pretty trivial patch for you here if you've got time today? https://review.opendev.org/#/c/684393/ | 10:30 |
| bauzas | stephenfin: I can take a look | 10:32 |
| *** priteau has joined #openstack-nova | 10:34 | |
| stephenfin | bauzas: thanks! | 10:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390 | 10:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390 | 10:43 |
| *** brinzhang0 has joined #openstack-nova | 10:58 | |
| *** tkajinam has quit IRC | 10:59 | |
| *** brinzhang_ has quit IRC | 11:01 | |
| openstackgerrit | Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712 | 11:27 |
| *** raildo has joined #openstack-nova | 11:29 | |
| openstackgerrit | Yingji Sun proposed openstack/nova master: resolve ResourceProviderSyncFailed issue https://review.opendev.org/742398 | 11:37 |
| *** rcernin has joined #openstack-nova | 11:49 | |
| *** maciejjozefczyk_ has quit IRC | 12:01 | |
| *** maciejjozefczyk has joined #openstack-nova | 12:01 | |
| *** ociuhandu has quit IRC | 12:03 | |
| *** ociuhandu_ has joined #openstack-nova | 12:03 | |
| *** dave-mccowan has joined #openstack-nova | 12:10 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | 12:15 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | 12:15 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | 12:16 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 12:16 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | 12:16 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | 12:16 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | 12:17 |
| *** brinzhang_ has joined #openstack-nova | 12:17 | |
| *** brinzhang0 has quit IRC | 12:21 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407 | 12:23 |
| *** artom has quit IRC | 12:24 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407 | 12:26 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109 | 12:28 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | 12:28 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance https://review.opendev.org/683043 | 12:29 |
| *** yankcrime has quit IRC | 12:32 | |
| *** zhanglong has quit IRC | 12:34 | |
| *** seba has quit IRC | 12:38 | |
| *** rouk has quit IRC | 12:38 | |
| *** rm_work has quit IRC | 12:38 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Re-enable live snapshot for paused instances https://review.opendev.org/740334 | 12:39 |
| *** mordred has quit IRC | 12:40 | |
| *** masterpe has quit IRC | 12:40 | |
| stephenfin | gibi: Could you stick https://review.opendev.org/#/c/683043/ on your review queue, please? :) | 12:41 |
| *** yankcrime has joined #openstack-nova | 12:41 | |
| gibi | stephenfin: ack, enqueued | 12:42 |
| *** seba has joined #openstack-nova | 12:42 | |
| *** rm_work has joined #openstack-nova | 12:42 | |
| *** nweinber has joined #openstack-nova | 12:44 | |
| *** ratailor__ has quit IRC | 12:45 | |
| *** mordred has joined #openstack-nova | 12:45 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561 | 12:52 |
| *** masterpe has joined #openstack-nova | 12:54 | |
| *** sapd1 has quit IRC | 12:56 | |
| *** zhanglong has joined #openstack-nova | 12:56 | |
| *** zhanglong has quit IRC | 13:03 | |
| *** zhanglong has joined #openstack-nova | 13:06 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742414 | 13:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415 | 13:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742416 | 13:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417 | 13:08 |
| *** zhanglong has quit IRC | 13:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Remove reference to transient domain when detaching devices https://review.opendev.org/608186 | 13:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: sync_guest_time: use the proper errno https://review.opendev.org/742423 | 13:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742424 | 13:12 |
| *** zhanglong has joined #openstack-nova | 13:14 | |
| lyarwood | bauzas: https://review.opendev.org/#/c/729595/ - would you mind hitting this again? | 13:21 |
| bauzas | ack | 13:21 |
| *** artom has joined #openstack-nova | 13:21 | |
| lyarwood | https://review.opendev.org/#/c/729261/ could also use some additional core review if anyone has bandwidth | 13:21 |
| lyarwood | and https://review.opendev.org/#/c/724842/ both are pretty simple | 13:22 |
| *** zhanglong has quit IRC | 13:23 | |
| *** xek has joined #openstack-nova | 13:26 | |
| gibi | lyarwood: added to my queue but I will focus on the sriov attach this afternoon so I can get to your patches tomorrow | 13:27 |
| *** zhanglong has joined #openstack-nova | 13:27 | |
| *** brinzhang0 has joined #openstack-nova | 13:29 | |
| bauzas | lyarwood: stephenfin: gibi: others, honestly, I'd be super happy if we could just provide a commit tag for py3-only changes | 13:29 |
| bauzas | something like "Py3-only" | 13:29 |
| bauzas | so, stable cores looking at it would see it | 13:29 |
| bauzas | I know how this can be difficult to do it every time | 13:29 |
| bauzas | but if people don't think about py3 styling, then I'm pretty sure we will get bugs in say one year | 13:30 |
| *** bnemec has joined #openstack-nova | 13:30 | |
| bauzas | context https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 | 13:30 |
| bauzas | I totally understand that people want to use py3 styling | 13:30 |
| bauzas | but honestly, if you want to do it, think about backports | 13:31 |
| gibi | bauzas: I would expect that such thing is caught by the unit test on the backported patch | 13:31 |
| lyarwood | stable cores would see this, py2 jobs would bork due to this. | 13:31 |
| *** brinzhang_ has quit IRC | 13:31 | |
| *** rcernin has quit IRC | 13:32 | |
| lyarwood | also, the py3 style boat has sailed | 13:32 |
| bauzas | gibi: well, for https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 we don't test it, right? | 13:32 |
| lyarwood | stephenfin has been landing stuff for most of the cycle already | 13:32 |
| bauzas | lyarwood: I don't see how CI can see it : https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 | 13:32 |
| lyarwood | bauzas: that's a DEBUG log in a codepath we hit loads in our tempest tests so that would definitley catch it | 13:32 |
| bauzas | with py3 | 13:32 |
| bauzas | py2 rather | 13:33 |
| lyarwood | we log at DEBUG in CI | 13:33 |
| lyarwood | we always run tests that hit that codepath | 13:33 |
| bauzas | again, there will be conditions where some code wouldn't be tested by CI and then we would get bugs | 13:33 |
| *** nweinber has quit IRC | 13:33 | |
| *** nweinber has joined #openstack-nova | 13:33 | |
| bauzas | this is not that I hate py3 styling, I'm just conservative with any change that can be backported, that's it | 13:34 |
| *** nweinber has quit IRC | 13:34 | |
| bauzas | for a new feature ? sure. | 13:34 |
| *** nweinber has joined #openstack-nova | 13:34 | |
| gibi | I would rather improve our test coverage than rely on a manual commit tag | 13:34 |
| bauzas | meh, ok, you're right | 13:36 |
| bauzas | lyarwood: fwiw, given you just told that stein jobs would hit this, I upvoted | 13:39 |
| *** zhanglong has quit IRC | 13:39 | |
| bauzas | my main concern is, please be explicit when you write py3-styling and be clear whether you already thought about backports | 13:39 |
| bauzas | the better commit msg you write, the easier it would be for reviewers | 13:39 |
| bauzas | that's it, I don't want to rathole about f-strings anymore | 13:40 |
| lyarwood | bauzas: FWIW I have no intention of backporting this, it was more to help debug some failures in master CI that look performance related | 13:41 |
| gibi | bauzas: I agree that better commit message helps | 13:45 |
| bauzas | lyarwood: ack, gtk | 13:45 |
| bauzas | thanks | 13:45 |
| *** brinzhang_ has joined #openstack-nova | 13:48 | |
| gibi | stephenfin: when the reno patch merges for the use-pcpu-and-vcpu-in-one-instance does it mean that the feature is done? | 13:50 |
| * stephenfin checks where in the series that is | 13:51 | |
| *** brinzhang0 has quit IRC | 13:52 | |
| gibi | I'm asking this as there are other patches open but they seem to be good to have not must hav | 13:52 |
| stephenfin | gibi: Yep. The only thing that we don't support after that is requesting PCPU + VCPU via 'resources:' extra specs, which we're deferring since it's (a) low priority and (b) interferes with the NUMA in placement work | 13:52 |
| gibi | OK | 13:52 |
| gibi | then I will mark the bp complete (with a note about the deferred part) after the reno merge | 13:52 |
| gibi | s | 13:53 |
| gibi | thanks for checking it | 13:53 |
| artom | gibi, replied on https://review.opendev.org/#/c/741436/, but you seem to have found the right track on your own :) | 13:57 |
| gibi | artom: thanks. I will check if I can check for vlan | 13:58 |
| *** Liang__ has joined #openstack-nova | 13:58 | |
| gibi | artom: thanks for pointing me to the code that was supposed to clean up the metadata I missed that orignally | 13:58 |
| artom | gibi, it was well hidden. Blame mriedem ;) | 13:59 |
| gibi | :) | 13:59 |
| artom | (For real, it was his idea - performance-wise, it's the good choice. Code-understandability-wise, clearly not so great ;) | 13:59 |
| *** Liang__ is now known as LiangFang | 13:59 | |
| gibi | artom: as far as I see if I simply remove the tag in vif conditional then the code still don't do any expensive things, jut iterate through instance.device_metadata to find the metadata by vif.address | 14:01 |
| artom | gibi, maybe the easiest way to do it is to do a reverse lookup kind of thing: just loop through the device metadata regardless, and if the mac matches the vif mac, delete that entry. | 14:02 |
| artom | gibi, hah, jiinx | 14:02 |
| gibi | that the baseline code does today | 14:02 |
| artom | IOW, as you said, remove the conditional | 14:02 |
| gibi | https://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L1788 | 14:02 |
| gibi | Ok | 14:03 |
| *** xek has quit IRC | 14:05 | |
| artom | Which reminds me, I really need to get https://bugs.launchpad.net/tempest/+bug/1775947 figured out | 14:06 |
| openstack | Launchpad bug 1775947 in tempest "tempest.api.compute.servers.test_device_tagging.TaggedAttachmentsTest failing" [Medium,Confirmed] | 14:06 |
| artom | And fixed | 14:06 |
| *** dave-mccowan has quit IRC | 14:07 | |
| *** LiangFang has quit IRC | 14:12 | |
| *** Liang__ has joined #openstack-nova | 14:14 | |
| *** dave-mccowan has joined #openstack-nova | 14:20 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Remove workaround for really old QEMU https://review.opendev.org/740335 | 14:21 |
| *** psachin has quit IRC | 14:24 | |
| *** dave-mccowan has quit IRC | 14:26 | |
| *** brinzhang0 has joined #openstack-nova | 14:31 | |
| *** brinzhang_ has quit IRC | 14:33 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: extra logging for tagged device detach https://review.opendev.org/742450 | 14:34 |
| *** sapd1 has joined #openstack-nova | 14:37 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach https://review.opendev.org/742451 | 14:39 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach https://review.opendev.org/741436 | 14:42 |
| *** mlavalle has joined #openstack-nova | 14:44 | |
| *** Guest23136 has joined #openstack-nova | 14:47 | |
| *** xek has joined #openstack-nova | 14:48 | |
| *** Guest23136 is now known as redrobot | 14:49 | |
| *** brinzhang_ has joined #openstack-nova | 14:58 | |
| *** KeithMnemonic has joined #openstack-nova | 14:59 | |
| *** brinzhang has joined #openstack-nova | 14:59 | |
| *** k_mouza has quit IRC | 15:00 | |
| *** brinzhang0 has quit IRC | 15:00 | |
| *** k_mouza has joined #openstack-nova | 15:01 | |
| *** brinzhang_ has quit IRC | 15:02 | |
| *** brinzhang_ has joined #openstack-nova | 15:05 | |
| *** brinzhang has quit IRC | 15:08 | |
| *** jraju__ has quit IRC | 15:13 | |
| *** Liang__ has quit IRC | 15:15 | |
| *** Liang__ has joined #openstack-nova | 15:19 | |
| *** Liang__ has quit IRC | 15:23 | |
| *** factor has joined #openstack-nova | 15:26 | |
| *** martinkennelly has quit IRC | 15:37 | |
| *** k_mouza has quit IRC | 15:41 | |
| *** k_mouza has joined #openstack-nova | 15:44 | |
| *** gyee has joined #openstack-nova | 15:48 | |
| *** k_mouza has quit IRC | 15:55 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995 | 16:03 |
| *** factor has quit IRC | 16:08 | |
| *** factor has joined #openstack-nova | 16:09 | |
| openstackgerrit | Merged openstack/nova master: hardware: create 'mixed' instance for realtime CPUs https://review.opendev.org/728485 | 16:09 |
| *** factor has left #openstack-nova | 16:11 | |
| *** mriedem has joined #openstack-nova | 16:17 | |
| *** xek has quit IRC | 16:17 | |
| *** hamalq has joined #openstack-nova | 16:22 | |
| *** hamalq_ has joined #openstack-nova | 16:23 | |
| *** hamalq has quit IRC | 16:27 | |
| *** dtantsur is now known as dtantsur|afk | 16:35 | |
| *** udesale_ has quit IRC | 16:47 | |
| *** tesseract has quit IRC | 16:54 | |
| *** lbragstad_ has joined #openstack-nova | 16:54 | |
| *** lbragstad has quit IRC | 16:57 | |
| *** sapd1 has quit IRC | 17:03 | |
| *** ociuhandu has joined #openstack-nova | 17:11 | |
| *** ociuhandu_ has quit IRC | 17:14 | |
| *** brinzhang0 has joined #openstack-nova | 17:15 | |
| *** ociuhandu has quit IRC | 17:16 | |
| *** brinzhang_ has quit IRC | 17:18 | |
| *** ociuhandu has joined #openstack-nova | 17:22 | |
| *** nightmare_unreal has quit IRC | 17:22 | |
| *** brinzhang_ has joined #openstack-nova | 17:23 | |
| *** brinzhang0 has quit IRC | 17:26 | |
| *** ociuhandu has quit IRC | 17:26 | |
| *** brinzhang0 has joined #openstack-nova | 17:35 | |
| *** lbragstad_ has quit IRC | 17:37 | |
| *** lbragstad_ has joined #openstack-nova | 17:38 | |
| *** brinzhang_ has quit IRC | 17:38 | |
| *** lbragstad__ has joined #openstack-nova | 17:45 | |
| *** lbragstad_ has quit IRC | 17:47 | |
| *** k_mouza has joined #openstack-nova | 17:55 | |
| *** aj_mailing has joined #openstack-nova | 17:56 | |
| *** aj_mailing has quit IRC | 17:57 | |
| *** aj_mailing has joined #openstack-nova | 17:58 | |
| *** k_mouza has quit IRC | 17:59 | |
| *** _erlon_ has joined #openstack-nova | 18:02 | |
| openstackgerrit | Gonéri Le Bouder proposed openstack/nova master: QEMU/KVM: accept vmxnet3 NIC https://review.opendev.org/738695 | 18:22 |
| openstackgerrit | Gonéri Le Bouder proposed openstack/nova master: QEMU/KVM: accept vmxnet3 NIC https://review.opendev.org/738695 | 18:41 |
| *** brinzhang_ has joined #openstack-nova | 18:41 | |
| *** brinzhang has joined #openstack-nova | 18:43 | |
| *** brinzhang0 has quit IRC | 18:44 | |
| *** ralonsoh has quit IRC | 18:45 | |
| *** brinzhang_ has quit IRC | 18:46 | |
| *** brinzhang0 has joined #openstack-nova | 18:46 | |
| artom | Random thought - someone should probably remove efried and mriedem from https://review.opendev.org/#/admin/groups/25,members, no? | 18:48 |
| artom | Nothing against you fellas, obviously :) | 18:48 |
| *** xek has joined #openstack-nova | 18:49 | |
| *** brinzhang has quit IRC | 18:49 | |
| * mriedem cries so hard | 18:59 | |
| mriedem | i'm removed myseflf | 19:00 |
| mriedem | *myself even | 19:00 |
| mriedem | and https://review.opendev.org/#/admin/groups/1936,members | 19:01 |
| *** bnemec has quit IRC | 19:03 | |
| artom | mriedem, RIP in pieces :( | 19:07 |
| artom | I was randomly linking that page to someone who needed core review | 19:08 |
| artom | This isn't a coup, is what I'm saying :) | 19:08 |
| mriedem | yup, np | 19:21 |
| *** maciejjozefczyk has quit IRC | 19:26 | |
| *** ociuhandu has joined #openstack-nova | 19:31 | |
| *** ociuhandu_ has joined #openstack-nova | 19:34 | |
| *** ociuhand_ has joined #openstack-nova | 19:35 | |
| *** ociuhandu has quit IRC | 19:36 | |
| *** ociuhandu_ has quit IRC | 19:38 | |
| *** adrianc_ has joined #openstack-nova | 19:44 | |
| *** ociuhand_ has quit IRC | 19:45 | |
| *** adrianc has quit IRC | 19:47 | |
| *** jralbert has joined #openstack-nova | 19:48 | |
| *** jralbert has left #openstack-nova | 19:48 | |
| *** jralbert has joined #openstack-nova | 20:03 | |
| *** brinzhang_ has joined #openstack-nova | 20:13 | |
| *** brinzhang0 has quit IRC | 20:16 | |
| *** nweinber has quit IRC | 20:16 | |
| jralbert | I've raised this question in #openstack and so far received no response; anybody here have any advice? I've just upgraded from Rocky to Stein, and Placement seems to have gotten very confused about resources in-use vs available. A number of compute nodes with running instances which are known to 'openstack server show' are reporting 0 running_vms | 20:22 |
| jralbert | in 'nova hypervisor-stats', and have no entries in the allocations table in the nova_api database. Running nova-manage placement heal_allocations for affected instances returns an error that "Compute host <compute_node> could not be found", but all the compute nodes are visible in nova-manage cell_v2 list_hosts. Has anyone encountered this? Any | 20:22 |
| jralbert | suggestions on how to troubleshoot it further? | 20:22 |
| *** hemna has quit IRC | 20:32 | |
| melwitt | jralbert: it sounds like your nova.instances records instance.host and instance.node aren't matching any records in nova.compute_nodes 'host' and 'hypervisor_hostname', as for why you're getting Compute host could not be found | 20:39 |
| *** hemna has joined #openstack-nova | 20:39 | |
| melwitt | did you replace any nova-compute services during the upgrade with different hostnames or something like that? | 20:40 |
| jralbert | melwitt: Thanks, I'll have a look at those tables. We didn't change any hostnames during the upgrade, although because it was being orchestrated by OSA there may have been steps taken we weren't fully aware of | 20:41 |
| melwitt | ok. I can't tell you how things got into that state but just for the sake of understanding why heal_allocations won't work: it will look up the compute node for an instance by querying for the instance.host and instance.node in the nova.compute_nodes table and if it finds no match, you'll get the Compute host could not be found error | 20:43 |
| melwitt | I'm not aware of any change from rocky to stein that could cause something like this. are you running with integrated placement (in nova) or did you split out to running extracted placement I wonder? | 20:45 |
| jralbert | I'm not 100% sure what integrated/extracted placement means, but I can find out - we're relying mostly on OSA defaults with some overrides, but that's not one I'm aware of. | 20:46 |
| melwitt | if you've moved to extracted placement, there are additional steps you need to follow for an upgrade, linked from here: https://docs.openstack.org/releasenotes/nova/stein.html#prelude | 20:46 |
| jralbert | Interestingly, there is a bit of a hint in the tables: http://paste.openstack.org/show/796222/ | 20:47 |
| melwitt | https://docs.openstack.org/placement/latest/admin/upgrade-to-stein.html | 20:47 |
| *** priteau has quit IRC | 20:47 | |
| jralbert | The compute nodes get '.openstack.local' hostnames in instances, but a genuine FQDN in compute_nodes | 20:47 |
| melwitt | the reason I ask about extracted placement is because you said your nova_api.allocations table is empty. did you already move to a separate placement db? do you have placement.allocations records? | 20:48 |
| jralbert | Sorry, the allocations table isn't completely empty - it's just missing *some* instances on *some* compute nodes | 20:49 |
| melwitt | ok, I think that difference in the nodename is causing the failure to lookup the compute nodes for the heal_allocations command | 20:49 |
| jralbert | we became aware of this because our instance/vcpu metrics suddenly dropped by about half during the upgrade, but all the instances were still running that had been | 20:49 |
| melwitt | this is where I see the lookup by host and node for heal_allocations https://github.com/openstack/nova/blob/stable/stein/nova/cmd/manage.py#L1829 | 20:50 |
| jralbert | So would I safely be able to update those definitions directly in the database, or is there a better-bounded API/CLI approach? | 20:50 |
| jralbert | I guess I would have hoped that compute nodes would be identified by uuids since names (especially hostnames) often produce collisions like this, but I'm guessing there's a legacy reason why this is the way it is. | 20:52 |
| melwitt | yeah, they are not linked by uuid. I don't know the history behind it. probably something like since you can delete/create services via the API, if we didn't link by name, you'd lose the association for all your instances even if the hostname is the same (service create makes a new uuid) | 20:55 |
| jralbert | Yep, I can imagine. We too are victims of our own legacy here: our compute nodes always had shortnames rather than FQDNs, and I'm pretty sure that's how we got burned here | 20:56 |
| melwitt | I think you'd have to update manually in the database for this (please backup first). I'm looking to see where the hypervisor_hostname comes from when the compute_nodes record is initially created, to see how it happened and whether it will happen again if you were to delete/create the nova-compute service later on | 20:56 |
| *** hamalq_ has quit IRC | 20:57 | |
| jralbert | I actually think I can maybe do this without futzing with the database, come to think of it: if I let nova-compute discover the node's FQDN and register itself as a "new" compute-service, it'll probably also create a new compute node record with FQDN, and ideally trigger a new resource allocation update. I'll try this with one node to see how it | 20:57 |
| jralbert | goes - otherwise, I'll update in the database | 20:57 |
| *** hamalq has joined #openstack-nova | 20:58 | |
| jralbert | Thank you very much for taking the time to help me with this today, I really appreciate it | 20:58 |
| melwitt | yeah, that would be the ideal way. fingers crossed that it'll match what your instances already have stored in their host/node | 20:58 |
| jralbert | To be discovered! | 20:58 |
| *** brinzhang0 has joined #openstack-nova | 20:59 | |
| *** brinzhang_ has quit IRC | 21:02 | |
| *** bnemec has joined #openstack-nova | 21:04 | |
| *** bnemec has quit IRC | 21:11 | |
| *** bnemec has joined #openstack-nova | 21:18 | |
| *** raildo has quit IRC | 21:28 | |
| *** ociuhandu has joined #openstack-nova | 21:46 | |
| *** ociuhandu has quit IRC | 21:50 | |
| *** vishalmanchanda has quit IRC | 22:01 | |
| *** brinzhang_ has joined #openstack-nova | 22:07 | |
| *** brinzhang0 has quit IRC | 22:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547 | 22:11 |
| *** efried has quit IRC | 22:27 | |
| *** jralbert has quit IRC | 22:30 | |
| *** efried has joined #openstack-nova | 22:31 | |
| efried | artom: It's not out of the question that I'll still review something here or there. But yeah, soon. | 22:44 |
| artom | efried, still addicted, eh? I thought you quit cold-turkey ;) | 22:45 |
| artom | But ack, you're an adult, you can do the needful when it's time | 22:46 |
| efried | I've quit almost nothing in my life cold turkey | 22:46 |
| artom | ;) | 22:46 |
| efried | With the possible exception of running. | 22:47 |
| efried | I actually had an orthopedic surgeon tell me I was too white to run marathons. | 22:47 |
| artom | Hah, you told me that once | 22:47 |
| artom | I remember laughing like an idiot at the most recent Denver PTG | 22:48 |
| efried | orite, because you were limping, s'how that conversation started. All recovered by now I assume (like three years later) | 22:49 |
| artom | Yeah, back to running :) | 22:50 |
| artom | No full marathons, but I've done a couple of halfs | 22:50 |
| efried | nice. I had a half where all the stars aligned, averaged 7:30/mi, reverse split. My best run ever. | 22:51 |
| efried | (which tells you all you need to know about my running talent) | 22:51 |
| *** rcernin has joined #openstack-nova | 22:52 | |
| *** mriedem has left #openstack-nova | 22:54 | |
| *** rcernin has quit IRC | 22:58 | |
| *** mlavalle has quit IRC | 23:00 | |
| *** rcernin has joined #openstack-nova | 23:01 | |
| *** tosky has quit IRC | 23:03 | |
| *** rcernin has quit IRC | 23:04 | |
| *** rcernin has joined #openstack-nova | 23:05 | |
| *** brinzhang0 has joined #openstack-nova | 23:12 | |
| *** brinzhang_ has quit IRC | 23:16 | |
| *** markvoelker has joined #openstack-nova | 23:27 | |
| *** markvoelker has quit IRC | 23:32 | |
| *** ociuhandu has joined #openstack-nova | 23:47 | |
| *** ociuhandu has quit IRC | 23:52 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!