Tuesday, 2020-07-14

*** k_mouza has quit IRC00:01
*** hoonetorg has quit IRC00:04
*** tetsuro has joined #openstack-nova00:10
*** k_mouza has joined #openstack-nova00:12
*** k_mouza has quit IRC00:17
*** hoonetorg has joined #openstack-nova00:17
*** hoonetorg has quit IRC00:36
*** gyee has quit IRC00:52
*** brinzhang has joined #openstack-nova00:57
*** brinzhang_ has joined #openstack-nova01:33
*** brinzhang has quit IRC01:36
*** bbowen has joined #openstack-nova01:40
*** mkrai has joined #openstack-nova01:48
*** spatel has joined #openstack-nova01:55
*** brinzhang0 has joined #openstack-nova01:56
*** brinzhang has joined #openstack-nova01:57
*** brinzhang_ has quit IRC01:59
*** brinzhang0 has quit IRC02:00
*** brinzhang_ has joined #openstack-nova02:17
*** brinzhang has quit IRC02:20
*** efried has quit IRC02:20
*** spatel has quit IRC02:34
*** efried has joined #openstack-nova02:36
*** efried has quit IRC02:42
*** spatel has joined #openstack-nova02:51
*** psachin has joined #openstack-nova02:59
*** tetsuro has quit IRC03:04
*** mkrai has quit IRC03:26
*** mkrai has joined #openstack-nova03:33
openstackgerritzhangboye proposed openstack/nova-specs master: migrate testing to ubuntu focal  https://review.opendev.org/74086303:43
*** sapd1 has quit IRC03:54
*** iurygregory has quit IRC03:54
*** TheJulia has quit IRC03:54
*** sapd1_x has joined #openstack-nova03:54
*** TheJulia has joined #openstack-nova03:55
*** sapd__x has joined #openstack-nova03:57
*** psachin has quit IRC04:07
*** ratailor has joined #openstack-nova04:20
*** tetsuro has joined #openstack-nova04:22
*** tetsuro_ has joined #openstack-nova04:26
*** tetsuro has quit IRC04:27
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** mkrai has quit IRC04:40
*** tetsuro_ has quit IRC04:41
*** tetsuro has joined #openstack-nova04:46
*** psachin has joined #openstack-nova04:46
*** tetsuro has quit IRC04:58
*** ociuhandu has joined #openstack-nova05:01
*** ociuhandu has quit IRC05:05
*** spatel has quit IRC05:09
*** udesale has joined #openstack-nova05:29
*** psachin has quit IRC05:29
openstackgerritTakashi Kajinami proposed openstack/nova master: Change default num_retries for glance to 3  https://review.opendev.org/74038905:33
*** psachin has joined #openstack-nova05:39
*** vishalmanchanda has joined #openstack-nova05:41
*** links has joined #openstack-nova05:50
*** sapd__x has quit IRC05:59
*** elod is now known as elod_off06:15
*** ccamacho has joined #openstack-nova06:18
*** hoonetorg has joined #openstack-nova06:19
*** dklyle has quit IRC06:39
*** jsuchome has joined #openstack-nova06:42
*** tony_su has joined #openstack-nova06:48
*** rcernin has quit IRC07:05
*** maciejjozefczyk has joined #openstack-nova07:10
*** iurygregory_ has joined #openstack-nova07:10
*** kevinz has joined #openstack-nova07:26
*** iurygregory_ is now known as iurygregory07:31
*** ralonsoh has joined #openstack-nova07:31
*** nightmare_unreal has joined #openstack-nova07:31
*** ccamacho has quit IRC07:32
*** tosky has joined #openstack-nova07:37
*** xek has joined #openstack-nova07:40
*** bhagyashris|afk is now known as bhagyashris07:44
*** sapd__x has joined #openstack-nova07:55
*** avolkov has joined #openstack-nova07:55
*** dtantsur|afk is now known as dtantsur07:56
*** Habib-A has joined #openstack-nova08:01
Habib-AHello all please help :D  https://ask.openstack.org/en/question/128468/windows-server-2019-with-ovs-and-nova-compute/08:02
*** rcernin has joined #openstack-nova08:10
*** rcernin has quit IRC08:14
*** rcernin has joined #openstack-nova08:15
*** mkrai has joined #openstack-nova08:21
gibikashyap: hi! you might have knowledge that I could use. I see a strange behavior from libvirt / qemu . with libvirt 4.0.0 and qemu 2.11 I can only hotplug an SRIOV VF to a guest if I detach the VF  first from the host even if I specify managed=yes in the xml. The domain create works, libvirt automatically detach the device from the host.08:26
kashyapgibi: Mornin08:27
gibikashyap: then I upgraded to libvirt 6.0.0 and qemu 4.2 and now hotplug also works without a manual detach08:27
gibiI looked at the changelog of libvirt but nothing pops up08:27
kashyapgibi: So a "feature was introduced silently"? :-)08:28
gibiI think it is more like bugfix than a feature08:28
*** martinkennelly has joined #openstack-nova08:29
kashyapgibi: A question: is the libvirt-6.0.0 & qemu-4.2 behaviour desirable to you, or not?  (Let's keep the surprise part aside :))08:29
kashyapRight, I first wrote 'bug-fix' indeed08:29
gibidesirable08:29
gibivery mutch08:29
gibiI'm working on nova to support sriov attach08:29
gibiand for that this behavior is needed08:30
kashyapgibi: So you want to know whether this is intended or not?08:30
gibiI want to know what is the minimum libvirt / qemu version that this behavior exists08:30
*** brinzhang_ has quit IRC08:31
*** brinzhang0 has joined #openstack-nova08:31
kashyapgibi: Ah, good one; I can check w/ one of the upstream libvirt folks08:31
gibikashyap: thanks a lot!08:32
kashyapgibi: I'll get back to you in a bit.  Today also I need to finish some administrative paperwork (deadline is 16 Jul; dammit).  But it's on my to-do08:32
gibikashyap: thanks. it is not urgent08:32
kashyapgibi: But yeah; silently introducing such a user-visible bug fix without even a changelog is not nice08:33
gibiI'm glad they fixed it :)08:38
*** martinkennelly has quit IRC08:41
*** rcernin has quit IRC08:42
*** martinkennelly has joined #openstack-nova08:42
*** derekh has joined #openstack-nova08:48
*** ociuhandu has joined #openstack-nova08:50
*** donnyd has quit IRC08:53
*** donnyd has joined #openstack-nova08:53
*** ccamacho has joined #openstack-nova09:00
*** brinzhang_ has joined #openstack-nova09:05
*** brinzhang0 has quit IRC09:08
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Use constants for libvirt version checks  https://review.opendev.org/74092109:09
openstackgerritStephen Finucane proposed openstack/nova master: Remove support for Intel CMT events  https://review.opendev.org/74092209:09
*** xek has quit IRC09:12
*** jangutter_ has joined #openstack-nova09:28
*** jangutter has quit IRC09:31
stephenfingibi: You're working on SR-IOV attach, you say?09:33
stephenfinThat's interesting, because that's on the backlogs of sean-k-mooney and I for quite some time now, and we simply hadn't gotten to it yet09:33
*** k_mouza has joined #openstack-nova09:35
openstackgerritHuaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum  https://review.opendev.org/71626709:37
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: refactor the code for CPU policy sanity check  https://review.opendev.org/74092509:37
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: refactor the code for CPU policy sanity check  https://review.opendev.org/74092509:40
stephenfingibi: I parroted your question back to danpb, given kashyap was occupied - as far as he's concerned, the behaviour you saw on the older version is bogus and reflects a bug09:40
stephenfin"as managed=yes stuff has been around forever and never required a manual detach"09:41
kashyapsfinucan: Thanks; you checked off a TODO on my list :)09:41
* kashyap crawls back into his cave09:41
*** frickler is now known as frickler_pto09:44
*** frickler_pto is now known as frickler09:47
*** dtantsur is now known as dtantsur|bbl09:49
*** tkajinam has quit IRC10:12
openstackgerritHuaqiang Wang proposed openstack/nova master: [DNM] bump nova-compute version for mixed instance in API  https://review.opendev.org/74093310:12
huaqiangstephenfin: I have sent out another ongoing change as a possible alternative of https://review.opendev.org/71627110:14
huaqianghttps://review.opendev.org/716271 checks the nova-compute service version in conductor layer10:14
huaqiangwhile https://review.opendev.org/740933 is doing this in API layer10:15
huaqiangjust for comparison10:15
*** Habib-A has quit IRC10:15
gibistephenfin: yeah, I did not assigned the bp or file a spec for it as I did not know how much time I will have during this cycle. So basically I spent yesterday putting a PoC together that started working today morning. I will do the paperwork at some point before M210:19
gibiregarding the libvirt bug, it would be nice to know what is the minimum libvirt version that works for documentation purposes10:20
*** gouthamr has quit IRC10:22
*** gouthamr has joined #openstack-nova10:23
*** Jeffrey4l has quit IRC10:23
*** Jeffrey4l has joined #openstack-nova10:24
stephenfinhuaqiang: ack, will look10:28
stephenfingibi: Okay, cool. I know Sean and I would be keen to take a look at that, so if/when you do lemme know10:29
stephenfinI can't help with testing at the moment since my SR-IOV machines are at home (I'm staying with my folks in the countryside since March), but hopefully it was just a single bad version of libvirt. Can probably test by building various versions from source10:30
stephenfinOnce I get access to those machines, I could do that testing10:30
*** jangutter has joined #openstack-nova10:34
*** jangutter_ has quit IRC10:37
gibistephenfin: OK, thanks. I have access to an SRIOV capable machine so I can try different libvirt version too10:39
*** mkrai has quit IRC10:49
gibiI think I will be able to post some WIP code this week10:50
*** martinkennelly has quit IRC10:53
*** mkrai has joined #openstack-nova11:13
*** rcernin has joined #openstack-nova11:13
stephenfinhuaqiang: Okay, I prefer https://review.opendev.org/#/c/740933/11:20
stephenfinMay be wise to get someone that knows RPC better than I do (dansmith or gibi, perhaps?) to weigh in11:21
stephenfinlyarwood: I had my message asking you to look at the vTPM work already typed out before I checked Gerrit 😅 Thanks for the reviews11:25
*** mkrai has quit IRC11:31
*** mkrai has joined #openstack-nova11:32
gibistephenfin, huaqiang: looking at the alternatives I think I would go with the check in the api service11:32
stephenfingibi: so you mean prefer https://review.opendev.org/#/c/740933/ over https://review.opendev.org/716271 ?11:33
gibiyes I prefer https://review.opendev.org/#/c/740933/11:34
gibiit is a bit more explicit what operations we block if the check is in the API11:37
gibiand also understanding the code is easier for me if the check is not burried down in a long call path11:38
openstackgerritMerged openstack/nova stable/stein: Check cherry-pick hashes in pep8 tox target  https://review.opendev.org/73792211:39
openstackgerritJinsheng Zhang proposed openstack/nova-specs master: Add nova-support-multiple-boot-volume-with-boot-order-selection spec  https://review.opendev.org/73789711:41
huaqiangstephenfin and gibi, thanks for comments!11:45
*** iurygregory has quit IRC11:46
*** sapd__x has quit IRC11:50
*** spatel has joined #openstack-nova11:58
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Attempt to restore some sanity to snapshot  https://review.opendev.org/74033611:59
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Use better variable names for '_create_guest'  https://review.opendev.org/74094511:59
*** iurygregory has joined #openstack-nova12:00
*** raildo has joined #openstack-nova12:02
*** spatel has quit IRC12:03
stephenfinlyarwood: replied at https://review.opendev.org/#/c/739209/412:09
* stephenfin goes for lunch12:09
lyarwoodstephenfin: just back sorry12:21
lyarwoodstephenfin: ack thanks12:21
*** udesale_ has joined #openstack-nova12:22
*** xek has joined #openstack-nova12:23
*** derekh has quit IRC12:23
*** udesale has quit IRC12:25
*** mkrai has quit IRC12:25
*** artom has quit IRC12:43
*** artom has joined #openstack-nova12:44
*** artom has joined #openstack-nova12:45
*** rcernin has quit IRC12:48
openstackgerritLee Yarwood proposed openstack/nova stable/train: Silence amqp heartbeat warning  https://review.opendev.org/72805712:55
*** Luzi has joined #openstack-nova12:55
lyarwoodmelwitt: https://review.opendev.org/#/c/732708/ - would you mind hitting this once you're online today, the stable/stein change has merged.12:57
lyarwoodand the func test below it please :)12:57
*** spatel has joined #openstack-nova12:58
*** efried has joined #openstack-nova13:00
*** derekh has joined #openstack-nova13:03
*** eharney has joined #openstack-nova13:11
*** xek has quit IRC13:13
*** Luzi has quit IRC13:29
*** benj_ has quit IRC13:39
*** benj_ has joined #openstack-nova13:41
*** psachin has quit IRC13:44
*** Luzi has joined #openstack-nova13:45
*** dtantsur|bbl is now known as dtantsur13:45
*** sean-k-mooney has joined #openstack-nova13:46
*** ralonsoh has quit IRC13:49
*** frickler is now known as frickler_pto13:50
*** mlavalle has joined #openstack-nova13:58
*** ralonsoh has joined #openstack-nova14:00
*** sapd__x has joined #openstack-nova14:00
*** dave-mccowan has joined #openstack-nova14:01
*** maciejjozefczyk has quit IRC14:01
mnaserso neutron makes 0 use of wrap_db_retry and has ssome convluted 4 year old retry mechanism which tries to avoid nested use of wrap_db_retry (well, if it detects it, it removes it, sounds like a workaround to me)14:06
mnaserdoes nova have some policy on what is retried and what isn't?14:06
dansmithmnaser: we decorate the methods we want to retry, IIRC14:07
mnaserdansmith: ok so there isn't a "if X then decorate" policy that i can try and adopt for neutron's db stuff14:08
dansmithmnaser: I think we also don't have a lot of nesting of things that might be called from the top, or called from within, so no nesting14:08
dansmithmnaser: yes, the policy is "if we get a bug for a thing, decorate it" :)14:08
mnaserok, so the current what-seems-to-be-neutron policy is... decorate everything with a decorator that removes an extra one if it finds one to avoid nested retries14:08
mnaserso this is going to be very fun to unwind14:09
*** mriedem has joined #openstack-nova14:10
*** ratailor has quit IRC14:17
*** Luzi has quit IRC14:18
*** knikolla has joined #openstack-nova14:21
*** jobewan has joined #openstack-nova14:29
*** dave-mccowan has quit IRC14:33
*** dklyle has joined #openstack-nova14:34
*** dave-mccowan has joined #openstack-nova14:37
*** johnthetubaguy has quit IRC14:50
*** johnthetubaguy has joined #openstack-nova14:52
*** artom has quit IRC14:56
dansmithgmann: tres woot: https://review.opendev.org/#/c/734184/14:56
*** artom has joined #openstack-nova14:56
*** artom has quit IRC14:57
*** artom has joined #openstack-nova14:57
gmanndansmith: nice, checking14:57
dansmith(moved to -qa)14:58
*** artom has quit IRC14:59
*** xek has joined #openstack-nova15:00
*** artom has joined #openstack-nova15:01
*** artom has quit IRC15:01
*** artom has joined #openstack-nova15:01
*** artom has quit IRC15:04
*** xek has quit IRC15:19
*** hamalq has joined #openstack-nova15:23
*** mkrai has joined #openstack-nova15:24
*** artom has joined #openstack-nova15:27
*** hamalq has quit IRC15:29
*** hamalq has joined #openstack-nova15:35
*** udesale_ has quit IRC15:35
*** mkrai has quit IRC15:39
*** mkrai has joined #openstack-nova15:40
*** gyee has joined #openstack-nova15:50
*** spatel has quit IRC15:54
*** mkrai has quit IRC15:57
*** jsuchome has quit IRC15:59
*** artom has quit IRC15:59
*** links has quit IRC15:59
openstackgerritBalazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach  https://review.opendev.org/74099516:09
gibistephenfin, sean-k-mooney: this might be intresting for you ^^16:10
openstackgerritDan Smith proposed openstack/nova master: Make our ceph job test with glance in multistore mode  https://review.opendev.org/73418416:12
openstackgerritHuaqiang Wang proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload  https://review.opendev.org/72848016:42
openstackgerritHuaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum  https://review.opendev.org/71626716:42
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: refactor the code for CPU policy sanity check  https://review.opendev.org/74092516:42
openstackgerritHuaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy  https://review.opendev.org/72848116:42
*** k_mouza has quit IRC16:46
*** nightmare_unreal has quit IRC16:52
*** ociuhandu_ has joined #openstack-nova16:58
*** derekh has quit IRC16:58
*** ociuhandu has quit IRC17:01
*** huaqiang has quit IRC17:01
*** ociuhandu_ has quit IRC17:02
openstackgerritHuaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance  https://review.opendev.org/71626917:08
openstackgerritHuaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating  https://review.opendev.org/72848217:08
*** huaqiang has joined #openstack-nova17:15
openstackgerritHuaqiang Wang proposed openstack/nova master: Validate CPU pinning configuration for mixed instance  https://review.opendev.org/71626817:25
openstackgerritHuaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance  https://review.opendev.org/71626917:25
openstackgerritHuaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating  https://review.opendev.org/72848217:25
*** k_mouza has joined #openstack-nova17:25
*** k_mouza has quit IRC17:30
*** dtantsur is now known as dtantsur|afk17:31
*** mgariepy has quit IRC17:36
*** ralonsoh has quit IRC17:57
*** xek has joined #openstack-nova18:04
*** sapd__x has quit IRC18:18
*** mgariepy has joined #openstack-nova18:22
*** k_mouza has joined #openstack-nova18:32
*** k_mouza has quit IRC18:37
openstackgerritMerged openstack/nova master: utils: Move 'get_bdm_image_metadata' to nova.block_device  https://review.opendev.org/73999618:53
*** slaweq has joined #openstack-nova18:54
*** slaweq has quit IRC18:56
*** mgariepy has quit IRC19:03
*** ociuhandu has joined #openstack-nova19:14
*** ociuhandu has quit IRC19:23
dansmithsean-k-mooney: replied. thanks for reviewing and for your initial help in that of course20:30
*** k_mouza has joined #openstack-nova20:32
sean-k-mooneyno worries20:33
sean-k-mooneydansmith: ya makes sense to me20:36
sean-k-mooneyim glad you finally got it working by the way.20:36
sean-k-mooneyits always nice when the ci verifys something like this for us20:37
sean-k-mooneythe glance folks might even want to take a look for there own testing20:37
*** k_mouza has quit IRC21:06
*** markvoelker has joined #openstack-nova21:23
*** markvoelker has quit IRC21:27
openstackgerritMerged openstack/nova stable/rocky: Add functional test for bug 1550919  https://review.opendev.org/73270721:36
openstackbug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)21:36
*** spatel has joined #openstack-nova21:45
dansmithsean-k-mooney: yeah, they'll have a lot more surface they can test once my two devstack patches land.. I hope they will make use of that, but.. who knows21:54
*** spatel has quit IRC22:04
*** spatel has joined #openstack-nova22:23
*** spatel has quit IRC22:23
sean-k-mooneydansmith: well if we are testing it its better then nothing22:24
*** vishalmanchanda has quit IRC22:39
*** rcernin has joined #openstack-nova22:44
*** tosky has quit IRC22:50
*** rcernin has quit IRC22:51
*** rcernin has joined #openstack-nova22:51
*** tkajinam has joined #openstack-nova22:58
*** hamalq has quit IRC22:58
*** mlavalle has quit IRC23:01
openstackgerritMerged openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/73270823:20
*** xek has quit IRC23:36
mnasermelwitt: i know you've worked some with the quota code.  does nova have any locking on quota usages?  neutron currently has a row-level lock on a resource/tenant_id which is causing me worlds of pain on highly parallelized port creation23:37
mnaserit pretty much holds a lock the whole time (with a select for update) while it calculates the usage and updates...23:38
gmanndansmith: seems oslo policy not able to format the target data for copy_image - https://zuul.opendev.org/t/openstack/build/aa1a5cd62aaa4210b19a5877e77b87db/log/controller/logs/screen-g-api.txt#60023:46
gmanntrying to reproduce this locally to see if oslo trying to change 'hw_rng_model' for some reason.23:47
gmannmnaser: not sure about lock (melwitt can confirm if we do have that) but nova does recheck quota again just before the resource creation to avoid(or to minimize as much as possible) any wrong calculation or over-quota in parallel request cases.23:52
mnasergmann: ok so nova doesnt do any row level locking for quota usage -- also yeah, i remember that, it's even an option to recheck quota in config if i remember right23:52
gmann* after resource creation. this config - https://github.com/openstack/nova/blob/7385adb2f526166bb174dab055d060a428d4d4ff/nova/conf/quota.py#L18923:53
gmannmnaser: afaik, no locks but melwitt or dansmith can confirm it.23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!