Thursday, 2020-07-09

*** hamalq has quit IRC00:09
*** tetsuro has joined #openstack-nova00:27
*** lseki has quit IRC00:54
*** gouthamr_ has quit IRC00:59
*** gouthamr_ has joined #openstack-nova01:05
*** jdillaman has quit IRC01:11
*** Liang__ has joined #openstack-nova01:15
*** gouthamr_ has quit IRC01:25
*** gouthamr_ has joined #openstack-nova01:37
*** gyee has quit IRC01:38
*** Yumeng has joined #openstack-nova02:01
*** mkrai has joined #openstack-nova02:18
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602902:39
*** mkrai has quit IRC02:49
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree  https://review.opendev.org/67652202:50
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346002:50
*** gouthamr_ has quit IRC02:52
*** tetsuro has quit IRC02:55
*** brinzhang has joined #openstack-nova02:55
*** mkrai has joined #openstack-nova02:56
*** gouthamr_ has joined #openstack-nova02:56
*** swp20 has joined #openstack-nova02:57
*** rcernin has quit IRC03:00
*** jmlowe has quit IRC03:01
*** rcernin has joined #openstack-nova03:03
*** yaawang has quit IRC03:10
*** yaawang has joined #openstack-nova03:10
*** brinzhang_ has joined #openstack-nova03:11
*** songwenping_ has joined #openstack-nova03:12
*** brinzhang has quit IRC03:15
*** swp20 has quit IRC03:15
*** gouthamr_ has quit IRC03:26
*** gouthamr_ has joined #openstack-nova03:32
openstackgerritXiaolinZhao proposed openstack/nova master: Add UEFI support for architecture MIPS  https://review.opendev.org/74015103:35
*** ociuhandu has joined #openstack-nova03:56
*** gouthamr_ has quit IRC04:00
*** ociuhandu has quit IRC04:01
*** markvoelker has joined #openstack-nova04:08
*** gouthamr_ has joined #openstack-nova04:11
*** ratailor has joined #openstack-nova04:22
*** gouthamr_ has quit IRC04:29
*** gouthamr_ has joined #openstack-nova04:30
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602904:34
*** tetsuro has joined #openstack-nova04:34
*** gouthamr_ has quit IRC04:35
*** gouthamr_ has joined #openstack-nova04:40
*** Luzi has joined #openstack-nova05:12
*** udesale has joined #openstack-nova05:13
*** brinzhang0 has joined #openstack-nova05:13
*** markvoelker has quit IRC05:13
*** songwenping__ has joined #openstack-nova05:13
*** markvoelker has joined #openstack-nova05:14
*** songwenping_ has quit IRC05:16
*** brinzhang_ has quit IRC05:16
*** songwenping__ has quit IRC05:16
*** swp20 has joined #openstack-nova05:18
*** markvoelker has quit IRC05:18
*** Luzi has quit IRC05:19
*** zzzeek has quit IRC05:19
*** Luzi has joined #openstack-nova05:19
*** zzzeek has joined #openstack-nova05:23
*** links has joined #openstack-nova05:43
*** mkrai has quit IRC05:50
*** songwenping_ has joined #openstack-nova05:53
*** swp20 has quit IRC05:57
*** brinzhang_ has joined #openstack-nova05:59
*** songwenping__ has joined #openstack-nova06:01
*** brinzhang0 has quit IRC06:03
*** songwenping_ has quit IRC06:04
*** vishalmanchanda has joined #openstack-nova06:05
*** ralonsoh has joined #openstack-nova06:10
*** dklyle has quit IRC06:16
*** yaawang has quit IRC06:32
*** yaawang has joined #openstack-nova06:33
*** slaweq has joined #openstack-nova06:39
*** xek_ has joined #openstack-nova06:44
*** CeeMac has joined #openstack-nova06:44
*** brinzhang0 has joined #openstack-nova06:48
*** gouthamr_ has quit IRC06:50
*** brinzhang_ has quit IRC06:51
*** gouthamr_ has joined #openstack-nova06:52
*** knikolla has quit IRC06:54
*** slaweq has quit IRC06:55
*** knikolla has joined #openstack-nova06:56
*** csatari has quit IRC06:58
*** csatari has joined #openstack-nova07:01
*** gouthamr_ has quit IRC07:04
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree  https://review.opendev.org/67652207:05
*** gouthamr_ has joined #openstack-nova07:05
gibigood morning nova07:09
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346007:11
*** gouthamr_ has quit IRC07:15
*** ttsiouts has joined #openstack-nova07:17
*** tesseract has joined #openstack-nova07:18
*** gouthamr_ has joined #openstack-nova07:22
*** tony_su has joined #openstack-nova07:22
tony_sugibi: sean-k-mooney: I am still taking the provider-config-file job and fully supporting its merging into upstream.07:24
gibitony_su: cool. So I will move the series to a runway slot and we will try to focus on it in the next two weeks07:25
gibiare you available in the next to week to iterate on the series based on our feedback?07:26
openstackgerritElancheran S proposed openstack/nova master: Removes the delta file once image is extracted  https://review.opendev.org/73442107:27
tony_suyes, definitely.07:27
tony_sugibi: yes, definitely.07:28
gibitony_su: cool07:28
gibithanks07:28
*** xek_ has quit IRC07:38
*** markvoelker has joined #openstack-nova07:43
*** gouthamr_ has quit IRC07:46
*** ttsiouts has quit IRC07:47
*** slaweq has joined #openstack-nova07:47
*** markvoelker has quit IRC07:48
huaqianggibi: hi can you review https://review.opendev.org/728480?07:49
*** alex_xu has quit IRC07:50
*** gouthamr_ has joined #openstack-nova07:52
*** tony_su has quit IRC07:52
openstackgerritJie Li proposed openstack/nova-specs master: add volume backed server rebuild spec  https://review.opendev.org/73934907:55
openstackgerritHuaqiang Wang proposed openstack/nova master: doc: correct the link to user/flavor.rst  https://review.opendev.org/74017607:55
gibihuaqiang: is this in the middle of the series?07:57
*** gouthamr_ has quit IRC07:57
huaqianggibi: do you mean https://review.opendev.org/73934907:57
huaqiangfor https://review.opendev.org/739349, yes it is, it belongs to bp/mixed-instance07:58
gibiI mean https://review.opendev.org/#/c/728480/07:58
gibiI can review https://review.opendev.org/#/c/728480/ but I reviewd the ancestors of that patch in the series already07:58
huaqiangmy mistake07:59
huaqianghttps://review.opendev.org/#/c/728480/ belongs to bp/mixed-instances07:59
huaqiangStephen suggests to have your review,07:59
huaqianglet me check08:00
*** udesale_ has joined #openstack-nova08:00
*** udesale has quit IRC08:03
*** gmann has quit IRC08:03
*** fyx has quit IRC08:04
*** fyx has joined #openstack-nova08:04
*** gmann has joined #openstack-nova08:06
*** ttsiouts has joined #openstack-nova08:06
gibihuaqiang: sure I will try to look deeper into the series. I have feedback in https://review.opendev.org/#/c/71470108:07
gibiand in https://review.opendev.org/#/c/71470308:07
gibiand also alex_xu has feedback in that series08:08
*** gouthamr_ has joined #openstack-nova08:09
*** iurygregory has quit IRC08:10
brinzhang0gibi: do you have time to review the nova-cyborg patch? https://review.opendev.org/#/c/716186/1308:10
*** udesale_ has quit IRC08:10
brinzhang0gibi: and the cyborg evacuate support patch https://review.opendev.org/#/c/715326/1508:11
brinzhang0the cyborg shelve/unshelve support depends on these patch, and these pataches are already to review, thanks08:11
huaqianggibi: sorry about that, I missed your comments even I go through some of my abandoned changes.08:15
huaqianggibi: can you have a look again :)08:15
huaqianggibi: get your message, thanks08:16
*** songwenping_ has joined #openstack-nova08:17
*** songwenping__ has quit IRC08:20
openstackgerritWenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client  https://review.opendev.org/74018408:20
openstackgerritWenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client  https://review.opendev.org/74018408:22
*** iurygregory has joined #openstack-nova08:24
*** songwenping__ has joined #openstack-nova08:25
*** tobiash has quit IRC08:26
*** ttsiouts_ has joined #openstack-nova08:27
*** songwenping_ has quit IRC08:28
*** maciejjozefczyk has joined #openstack-nova08:28
gibibrinzhang0: if the cyborg patches are ready then please add them to the runway queue. At the momement I will focus on the 3 series that is currently in the 3 slots.08:29
*** ttsiouts_ has quit IRC08:29
gibihuaqiang: ack I will look08:29
*** ttsiouts has quit IRC08:30
brinzhang0gibi: ok, I will add these to the runway queue08:30
gibibrinzhang0: thanks08:31
brinzhang0gibi: np08:31
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests  https://review.opendev.org/73960808:32
gibibrinzhang0: also summer vacation time will soon arrives. I will take 3 weeks of during july - august08:32
gibis/of/off/08:32
gibiI guess others from EU will do similar things08:32
brinzhang0gibi: have a holiday ^08:32
gibithanks :)08:32
lyarwoodelod: https://review.opendev.org/#/c/739608/ should finally fix stable/rocky08:34
*** derekh has joined #openstack-nova08:36
*** tetsuro has quit IRC08:38
*** benj_ has quit IRC08:41
stephenfingibi, elod, lyarwood: Can raise on the team meeting, but what do we think about adding the Backport-Candidate flag to Gerrit like oslo has done? https://review.opendev.org/#/c/740068/08:44
*** k_mouza has joined #openstack-nova08:44
lyarwoodstephenfin: OOoOOOoO shiny08:46
lyarwoodstephenfin: +1 from me if we can query on that flag08:46
lyarwoodthat we must be able to08:47
stephenfinhttps://review.opendev.org/#/q/label:Backport-Candidate%253D%252B208:47
stephenfinYup08:47
stephenfin(label:Backport-Candidate=+2)08:47
gibistephenfin: how does this relate to the way we target bugs to series in launchpad?08:48
gibiwill we do duble accounting?08:48
stephenfingibi: what do you mean?08:48
stephenfinoh, as in setting the affected series for a reported bug in LP?08:49
gibiin launchpad I can go to a bug and target it to multpile series (Ussurit, Train...) this way showing that the bugfix needs to be backported to those releases08:49
gibithis also shows _where_ to backport08:50
stephenfinthat would sound like double accounting, yes. I guess we could either check both, or decide on which one we'd prefer08:50
stephenfiniiuc we only do that launchpad tracking for some bugs, so we could use the backport-candidate feature for everything, and then be more specific in launchpad if necessary08:50
* stephenfin tends to keep backporting things as far back as they can reasonably go08:51
gibicorrect, there are non-bugs that we backport08:53
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Fix os_CODENAME detection and repo refresh during ceph tests  https://review.opendev.org/74019308:53
gibiand launchpad does not help there08:53
gibido you have a good working example for a patch that is backported but would be strange to track it with an LP bug?08:54
*** songwenping_ has joined #openstack-nova08:54
stephenfinI wasn't even being that specific. I meant bug reporters often don't set target versions in Launchpad, and I don't tend to set them when reviewing bugfixes08:55
stephenfinBut the ability to say "this looks like a fix we probably want to backport" from Gerrit does sound like something I'd use, if only because it doesn't involve context switching08:56
stephenfinso tl;dr: this feels like something we'd collectively use far more, if that makes sense?08:57
*** songwenping__ has quit IRC08:57
*** benj_ has joined #openstack-nova08:58
gibistephenfin: I see, so the benefit of the new solution is that the recording of the information is closer to the place where the information is created. That definitely helps09:01
stephenfinYeah, that's a better way of saying what I'm trying to say :)09:01
xiaolinlyarwood: Do you have time to review https://review.opendev.org/#/c/740151/ , I don not know how to change the branch  and proposed a new one against branch master09:02
gibiwe can use the gerrit flag, to force a discusson of the question "how far to be backported?" and then the answer can be recorded in LP by assigning series09:02
lyarwoodxiaolin: I'll take a look today yes09:02
*** tobiash has joined #openstack-nova09:03
gibiI'm not against the new flag, I feel it has some cost of re-learning the gerrit interface due to the extra flag a the reply button, but I see the benefit of the flag09:03
xiaolinlyarwood: thanks09:03
*** songwenping__ has joined #openstack-nova09:07
stephenfingibi: I'm already doing that for oslo so not a massive deal for me, personally :)09:10
*** songwenping_ has quit IRC09:10
*** tosky has joined #openstack-nova09:10
gibiyeah, I can adapt too :)09:10
*** swp20 has joined #openstack-nova09:11
*** udesale has joined #openstack-nova09:12
*** songwenping__ has quit IRC09:13
*** rcernin has quit IRC09:23
*** dtantsur|afk is now known as dtantsur09:29
elodstephenfin: that could help, yes, it's easy to see if a patch should be backported, in that way09:31
elodstephenfin: i usually check the bugreport as well if a patch was marked to be backported to certain branches, too09:31
elodstephenfin: unfortunately most of the time that detail is not filled in09:32
elodstephenfin: so maybe it's worth adding that option :)09:34
*** hrw has joined #openstack-nova09:38
hrwmorning09:38
hrwhttps://1d9789842ee1597bfc07-adfe1c2e7945e3f1ebfe34ebeb2d7062.ssl.cf2.rackcdn.com/739800/2/check/kayobe-overcloud-centos8/c7c8c01/primary/kolla/nova/nova-compute.txt shows new nova issue09:38
hrw2020-07-08 16:44:28.078 6 ERROR nova   File "/usr/lib/python3.6/site-packages/nova/virt/libvirt/utils.py", line 65, in <module>09:39
hrw2020-07-08 16:44:28.078 6 ERROR nova     'avx512vbmi': os_traits.HW_CPU_X86_AVX512VBMI,09:39
hrw2020-07-08 16:44:28.078 6 ERROR nova AttributeError: module 'os_traits' has no attribute 'HW_CPU_X86_AVX512VBMI'09:39
*** songwenping_ has joined #openstack-nova09:39
*** xek has joined #openstack-nova09:40
*** swp20 has quit IRC09:42
fricklerhrw: guess you either need an intermediate os_traits release or use it from git instead pypi09:43
*** markvoelker has joined #openstack-nova09:44
hrwor update to 2.4.009:45
*** k_mouza has quit IRC09:47
*** markvoelker has quit IRC09:48
lyarwoodyeah FWIW tripleo hit this as well and they just needed to pull in the new os-traits release09:48
lyarwoodthat's AFAIK anyway09:48
hrwweird as image says 2.4.0 os_traits.09:49
hrwsomething to debug then09:49
bauzasstephenfin: jumping late on your Backport-Candidate question, could you please explain the usage ?09:52
lyarwoodhrw: do you have a link to the build logs showing that?09:53
bauzasstephenfin: if it's for telling "I think it's a good change for backporting it", then anyone can just bakcport it and leave the stable cores to look at it09:53
bauzasI don't really see what it's helping09:54
hrwlyarwood: https://1d9789842ee1597bfc07-adfe1c2e7945e3f1ebfe34ebeb2d7062.ssl.cf2.rackcdn.com/739800/2/check/kayobe-overcloud-centos8/c7c8c01/ is zuul job log dir09:54
hrwlyarwood: docker kolla/centos-binary-nova-compute:master image used09:55
bauzasstephenfin: and like gibi said, we already have both launchpad tags and series for stable09:55
hrwyaawang: I did docker run image, python3, import os_traits and HW_CPU_X86_AVX512VBMI was there so wondering what is going on09:55
stephenfinbauzas: You can just do the backport, but that means you have to remember to do it there and then09:56
stephenfinwhich might be easier said than done, particularly if there are merge conflicts09:56
*** k_mouza has joined #openstack-nova09:56
stephenfinthis is just a way for (core) reviewers to say "I think this should be backported"09:57
stephenfinor, conversely, I think this should not be backported09:57
stephenfinand then the actual backport can take place later09:57
*** jraju__ has joined #openstack-nova09:57
hrwstephenfin: 'Backport Candidate' options in gerrit you discuss?09:57
stephenfinhrw: correct09:58
hrwI like them. Use them in kolla09:58
*** links has quit IRC09:58
stephenfinSo do I. Maybe you can answer the questions gibi and bauzas have? Namely, what it gives over setting the series metadata in Launchpad09:59
bauzasmmm, I see your usecase then10:00
bauzasit would be for people wanting to know what to backport ?10:01
bauzasbut honestly, who ?10:01
hrwstephenfin bauzas: when I have fix for stable/* I have to get it into master and then u->t->s->r if needed. so I send for master and then comment with "backport needed" and say which branches10:01
hrwso later it is visible which patches need backporting10:01
openstackgerritXiaolinZhao proposed openstack/nova master: Add USB keyboard to support for MIPS architecture  https://review.opendev.org/74021310:01
bauzasand who would say +1/-1 ? stable cores or master cores ?10:01
hrwbauzas: in kolla we have just cores10:02
bauzaseither way, not saying I disagree, just it looks to me something we don't really *need*10:02
stephenfinbauzas: I mean, if I was given a list of stuff to backport and promised reviews then I'd be happy to skim the backport candidate list occasionally10:02
stephenfinand it's backport candidate - not actual backport - so normal cores10:02
stephenfinthough we could conceivably do both10:02
hrwbauzas: as you have master and stable cores then I would say that master core suggests backport and stable core may accept/reject10:03
stephenfinyeah, that ^10:03
bauzasokay I see, it's then just yet another process...10:03
*** jmlowe has joined #openstack-nova10:03
bauzassome people would use it, some not10:04
stephenfinYes and no. It's just another checkbox in the review dropdown10:04
stephenfinPersonally, everyone is using it in oslo land because it's really low friction10:04
stephenfinCertainly less than going to Launchpad and setting metadata there (which I don't currently do because I didn't know I was supposed to)10:04
hrwxiaolin: nice to see that some other arch follows aarch64 steps10:05
*** xek has quit IRC10:05
stephenfinbauzas: If it means we remember to backport even a few more bugfixes then I think it's a good thing, personally10:06
stephenfinlyarwood: Have you been looking at https://review.opendev.org/739349 ?10:06
bauzasokay okay, let's discuss tonight anyway10:06
stephenfinseems tangentially related to stuff you've been working on recently10:06
lyarwoodstephenfin: on my list10:09
xiaolinhrw: thanks : ) We just started10:10
*** its-surya has joined #openstack-nova10:11
hrwxiaolin: check https://review.opendev.org/#/c/538003/ as you need to add test cases10:11
*** maciejjozefczyk has quit IRC10:13
*** maciejjozefczyk has joined #openstack-nova10:14
*** songwenping__ has joined #openstack-nova10:14
*** ociuhandu has joined #openstack-nova10:16
xiaolinhrw: Thanks :)  I will add test cases10:17
*** songwenping_ has quit IRC10:17
hrwxiaolin: it took some revisions before I got them right so prefer to point you at start10:21
*** jmlowe has quit IRC10:24
*** jmlowe has joined #openstack-nova10:24
*** Liang__ has quit IRC10:28
*** xek has joined #openstack-nova10:45
xiaolinhrw: Thanks so much10:48
xiaolinhrw: do you have time to review https://review.opendev.org/#/c/740151/10:50
hrwsure10:52
hrwxiaolin: you do not use pflash on mips?10:54
elodlyarwood: thanks for the patch! \o/[4~ I've fast-approved it >>> https://review.opendev.org/#/c/739608/10:55
hrwxiaolin: done10:56
lyarwoodelod: awesome thanks :)10:56
xiaolinhrw:  our KVM only support rom now10:57
lyarwoodelod: https://review.opendev.org/#/c/740193/ should also fix stable/queens btw10:57
hrwxiaolin: comment comment then10:59
elodlyarwood: thanks! let's wait for Rocky patch to merge then I'll +2+W that too :)10:59
sean-k-mooneylyarwood: what branches are teh migration test broken on10:59
sean-k-mooneyah also rocky?10:59
sean-k-mooneyi notice many of the rechecks i kicked off for some of my backports failed yesterday on the live migration job11:00
sean-k-mooneyhavent had time to look into it yet11:00
sean-k-mooneyERROR] /tmp/devstack-plugin-ceph/devstack/lib/ceph:1029 Supported for Ubuntu Xenial, Bionic or Focal. Not supported for other releases.11:01
sean-k-mooneythats what ye are fixing?11:01
lyarwoodyes11:01
lyarwoodjust taken a while as there were other issues with the ceph plugin we had to fix first11:02
sean-k-mooneycool ill recheck those after it merges so11:02
lyarwoodhttps://review.opendev.org/#/c/739694/11:02
sean-k-mooneyare tehre any other issue i should be aware of for rocky and queens that i should wait for11:02
*** tkajinam has quit IRC11:02
lyarwoodsean-k-mooney: rocky should be GREEN once that lands11:03
lyarwoodsean-k-mooney: and queens once https://review.opendev.org/#/c/740193/ lands11:03
lyarwoodAFAIK11:03
sean-k-mooneyok i have a number of backport against rock and queens that im trying to get off my outgouing queue but i can wait another while11:03
lyarwoodyeah shouldn't be long now11:04
lyarwoodI also have a load of stuff I want to rebase once these land11:04
sean-k-mooneyoh will i need to rebase i can but then i have too update the commit ids in train which i can do but effort :P11:04
lyarwoodsean-k-mooney: and this is why I hate the cherry-pick lines ;)11:05
lyarwoodsean-k-mooney: and yes you need to rebase11:05
sean-k-mooneyhehe stephenfin aggrees with you11:05
stephenfinself-inflicted pain11:05
lyarwoodyarp11:06
sean-k-mooneyi normally just avoid backporting acrooss more then one or two branches but its still less painful to do it upstream then downstream11:06
sean-k-mooneyif i do it donwstream i also have to clone the bug across multiple releases11:06
elodactually i think the rebase is only needed if there's a merge conflict :-o11:10
elodotherwise zuul takes care of it11:10
sean-k-mooneyelod: that is my understandign too11:11
sean-k-mooneyalthough sometiems we get weird behavior  for example as with the new cherry-pick checker but normally the zuul speculative merge is suffiecent11:12
gibicores: can someone send this through? https://review.opendev.org/#/c/725163/ It would unblock the python-novaclient gate11:12
sean-k-mooneyand also get once step closer to no more legacy jobs11:13
elodsean-k-mooney: the new cherry-pick checker had a problem if the patch's parent was not the HEAD of the branch, but that is fixed already (in ussuri and train, where the check is merged so far)11:13
sean-k-mooneyelod: yep i saw the discussion on the topic11:14
sean-k-mooneydownstream our branches are named differently so we are figuring out how to handel that11:14
elodoh :S11:15
sean-k-mooneyi think we are going to trun it off and replace it with a different one11:15
sean-k-mooneyso that if we import change to the script it wont confliect with our downstream changes11:15
*** songwenping__ has quit IRC11:15
sean-k-mooneylyarwood: did you propsoe a patch to do that by the way?11:16
*** songwenping__ has joined #openstack-nova11:16
*** dave-mccowan has joined #openstack-nova11:17
sean-k-mooneyelod: right now it just another reason to do more backports upstream since they can actully merge :)11:17
sean-k-mooneywell pass pep811:17
elodsean-k-mooney: that's at least a good thing ;)11:17
lyarwoodsean-k-mooney: yeah we disabled it downstream for now11:18
sean-k-mooneycool11:18
lyarwoodhttps://review.gerrithub.io/c/redhat-openstack/octario/+/49709711:18
sean-k-mooneyoh we just comment it out11:19
sean-k-mooneythat works11:19
*** markvoelker has joined #openstack-nova11:19
sean-k-mooneyits not the most horrid thing we do to the tox.ini11:19
elodthen I just quietly advertise that the cherry-pick check script is backported to stein and waiting for review :X o:)11:22
*** markvoelker has quit IRC11:24
*** songwenping_ has joined #openstack-nova11:25
*** songwenping__ has quit IRC11:28
*** songwenping__ has joined #openstack-nova11:42
*** songwenping_ has quit IRC11:45
sean-k-mooneyim not a functional progaming person normally but its nice whe a refactoring turns a function that previously required mocks to test into a pure function of its inputs11:46
*** jungleboyj_ is now known as jungleboyj11:46
*** songwenping_ has joined #openstack-nova11:52
*** songwenping__ has quit IRC11:55
*** bhagyashris is now known as bhagyashris|brb12:04
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3  https://review.opendev.org/72651212:07
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.add_metaclass  https://review.opendev.org/72656512:08
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.reraise  https://review.opendev.org/72689812:08
*** songwenping__ has joined #openstack-nova12:14
*** xek has quit IRC12:14
*** songwenping_ has quit IRC12:17
gibistephenfin: I'm pretty close to +A https://review.opendev.org/#/c/714701/12/nova/virt/hardware.py@1956 but it would be nice to get a nod from you too12:21
stephenfinlooking12:21
sean-k-mooneyisnt that stephens pathc12:21
gibisean-k-mooney: the explanation is not from Stephen12:22
sean-k-mooneyah12:22
sean-k-mooneyi was like the fact he wrote it proably means he thinks its correct12:22
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722412:23
stephenfingibi: Yeah, so numa_topology is set to None on line 1813 https://review.opendev.org/#/c/714701/12/nova/virt/hardware.py@a181312:23
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775712:23
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777712:23
stephenfinand it's not set to anything else until it's returned on line 191512:23
stephenfinin the old code, this is12:23
*** raildo has joined #openstack-nova12:23
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809412:23
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810912:24
gibistephenfin: ack, thanks12:24
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811712:24
gibistephenfin: if you are at it, I have a similar question in https://review.opendev.org/#/c/714703/11/nova/virt/hardware.py@a114812:25
stephenfiniirc no because it's set by something else later, but let me double check :)12:26
sean-k-mooneythat if looks correct to me too by the way12:26
sean-k-mooneyalthough i proably woudl have fliped it and returned none rather then the else12:26
openstackgerritMerged openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests  https://review.opendev.org/73960812:27
lyarwood\o/12:30
openstackgerritWenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client  https://review.opendev.org/74018412:30
stephenfingibi: I need to pull this down to figure it out, but I'm in the middle of fixing up some vTPM stuff. I'll get to it soon as I'm done with that :)12:31
gibistephenfin: no worries I can switch from vtpm to the pcpu series in the meantime12:31
gibiI mean the opposite12:32
stephenfingibi: Cool. This one's the one I'm fixing by the way. I got my logic wrong :( Comments left https://review.opendev.org/#/c/739208/312:32
stephenfinI'm going to get rid of the '_create_domain_from_guest' function entirely since it's not doing what we think (all it does is resume the guest)12:33
stephenfinthat file needs to be broken up asap :(12:33
sean-k-mooneystephenfin: while you are hear quick question about the type annotation, do you only use 'module.classname' for cases where it is not in scope locally where you are using the annotation12:34
sean-k-mooneythere is no reason to do that if its in scope correct12:34
stephenfinsean-k-mooney: I have a great answer for that prepared for gibi :D12:34
gibistephenfin: I missed that logic error too. good catch12:34
stephenfinsean-k-mooney: https://review.opendev.org/#/c/730382/6/nova/virt/libvirt/driver.py@358612:34
sean-k-mooneyi was reading the upstream docs and i cant find any reference to the '' syntax that is why i asked12:34
sean-k-mooneyas i would have assume that triggered type inferance and would treat it as a sting12:35
stephenfinNope, it just prevents Python (the interpreter) from parsing it12:35
stephenfinOnly mypy will do so12:35
sean-k-mooneyah ok12:36
* gibi glad that he is not the only one got confused by type hinting and mypy12:36
stephenfinsean-k-mooney: https://www.python.org/dev/peps/pep-0563/12:36
sean-k-mooneyreading your responce now12:36
sean-k-mooneygibi: its relitivly new and still evolving12:36
stephenfinsean-k-mooney: and also https://mypy.readthedocs.io/en/latest/kinds_of_types.html#class-name-forward-references12:36
*** bhagyashris|brb is now known as bhagyashris12:37
sean-k-mooneyah i skimed the kinds_of_types section a few mintues ago but missed that12:37
stephenfinYeah, lots of rough edges. I like what it promises though, plus the fact we can introduce it in stages12:37
* stephenfin has been using it for Sphinx12:37
sean-k-mooney ah its a forwared refernce that is what i was asking12:37
sean-k-mooneyits like when you do struct MyStruct{}; in c/c++ to avoid importing MyStruct.h12:38
* gibi likes sean-k-mooney's c++ metaphors12:40
sean-k-mooneyi almost never write c++ but i watch a tone of talks ans podcasts on c++12:41
sean-k-mooneyi hate c but to be honest after 7+ years of python at this point im now coming to like it as much or more then c++12:42
sean-k-mooneytype hits certenly remove one of my gripes with python12:42
gibiI wrote c++ last time 7 years ago still I appreciate it as a language. I would go with Rust if I have to choose today12:46
*** raildo has quit IRC12:47
sean-k-mooneyi dont like the syntax of rust but i can appreciate some of the design chosies regarding the borrow checker. though the clang based tooling that has been wrrent for c++ is quickly approchign the same level of checking12:48
*** nweinber has joined #openstack-nova12:48
sean-k-mooneylanguates that use let to intoduce variables like basic just feel strange to me12:49
sean-k-mooneyit took me a very long time to get used to type on the right had side of an identifier too12:49
*** raildo has joined #openstack-nova12:50
sean-k-mooneyits becomeing the norm now but the reason new lanagues do that is its eaier to write the parser it has nothing to do with human readabilty12:50
*** lseki has joined #openstack-nova12:51
gibistephenfin: you did a nice job splitting up the vtpm series. thank you for that12:55
stephenfinnp12:56
stephenfinthanks for the reviews :)12:56
stephenfinbe sure to let me know if I can return the favour12:57
gibisure :)12:57
*** alex_xu has joined #openstack-nova12:58
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Reject boot request for unsupported images  https://review.opendev.org/70860813:05
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Add functional test for bug 1550919  https://review.opendev.org/73270713:05
openstackbug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)13:05
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/73270813:05
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances  https://review.opendev.org/72917713:07
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event  https://review.opendev.org/71123313:07
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Remove 'test_cold_migrate_with_physnet_fails' test  https://review.opendev.org/70311513:08
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed  https://review.opendev.org/70311613:08
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/70311713:08
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: FUP for in-place numa rebuild  https://review.opendev.org/70311813:08
lyarwoodsean-k-mooney: ^ rebased for you btw13:09
*** songwenping_ has joined #openstack-nova13:13
sean-k-mooneyoh cool thanks13:16
*** songwenping__ has quit IRC13:17
*** xek has joined #openstack-nova13:17
*** mtreinish has quit IRC13:33
*** mtreinish has joined #openstack-nova13:33
*** songwenping__ has joined #openstack-nova13:35
openstackgerritHuaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum  https://review.opendev.org/71626713:37
openstackgerritHuaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy  https://review.opendev.org/72848113:37
openstackgerritHuaqiang Wang proposed openstack/nova master: Validate CPU pinning configuration for mixed instance  https://review.opendev.org/71626813:37
openstackgerritHuaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance  https://review.opendev.org/71626913:37
openstackgerritHuaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating  https://review.opendev.org/72848213:37
openstackgerritHuaqiang Wang proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance  https://review.opendev.org/71470613:37
openstackgerritHuaqiang Wang proposed openstack/nova master: compute: bump nova-compute service version for mixed instance  https://review.opendev.org/71627113:37
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs  https://review.opendev.org/72848513:37
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: refactor numa_get_constraints  https://review.opendev.org/71829413:37
openstackgerritHuaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs  https://review.opendev.org/68893613:37
openstackgerritHuaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance  https://review.opendev.org/73699713:37
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Simplify '_create_domain' function  https://review.opendev.org/73920813:38
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Add vTPM config support  https://review.opendev.org/73920913:38
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Request vTPM trait based on flavor or image  https://review.opendev.org/73921013:38
openstackgerritStephen Finucane proposed openstack/nova master: crypto: Add support for creating, destroying vTPM secrets  https://review.opendev.org/73921113:38
openstackgerritStephen Finucane proposed openstack/nova master: manager: Prevent compute startup on invalid vTPM config  https://review.opendev.org/73921213:38
openstackgerritStephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova  https://review.opendev.org/63136313:38
openstackgerritStephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993413:38
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support  https://review.opendev.org/73921313:38
*** songwenping_ has quit IRC13:38
openstackgerritDan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job  https://review.opendev.org/73418413:44
stephenfingibi: Have effectively rewritten https://review.opendev.org/#/c/739208/ again from learnings on the previous PS. Hopefully it makes sense13:48
openstackgerritLee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job  https://review.opendev.org/71160413:57
*** ratailor has quit IRC14:04
openstackgerritMerged openstack/nova master: hardware: Invert order of NUMA topology generation  https://review.opendev.org/71470114:12
*** mriedem has joined #openstack-nova14:16
*** lbragstad_ has joined #openstack-nova14:29
*** lbragstad has quit IRC14:29
*** lchabert has quit IRC14:29
*** dklyle has joined #openstack-nova14:30
*** lchabert has joined #openstack-nova14:32
*** mlavalle has joined #openstack-nova14:50
*** bhagyashris is now known as bhagyashris|dinn14:52
*** vishalmanchanda has quit IRC14:54
openstackgerritGhanshyam Mann proposed openstack/os-vif master: DNM: testing os-vif gate on ubuntu focal  https://review.opendev.org/73813014:56
*** Luzi has quit IRC14:56
*** jraju__ has quit IRC14:57
*** mnasiadka has joined #openstack-nova14:58
openstackgerritMerged openstack/nova stable/queens: Fix os_CODENAME detection and repo refresh during ceph tests  https://review.opendev.org/74019315:11
*** ganso has quit IRC15:13
*** ganso has joined #openstack-nova15:17
openstackgerritGhanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal  https://review.opendev.org/73812615:22
*** k_mouza has quit IRC15:31
*** k_mouza has joined #openstack-nova15:37
openstackgerritMerged openstack/python-novaclient master: Switch legacy Zuul jobs to native Zuul v3 jobs  https://review.opendev.org/72516315:42
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests  https://review.opendev.org/73819915:44
openstackgerritLee Yarwood proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported  https://review.opendev.org/73696215:44
gibistephenfin: https://review.opendev.org/#/c/739208/ looks good to me15:48
*** bhagyashris|dinn is now known as bhagyashris15:49
*** gyee has joined #openstack-nova15:50
gibinova meeting starts in 9 minutes on #openstack-meeting-315:51
openstackgerritArtom Lifshitz proposed openstack/nova master: Improve documentation of (unpin|pin)_cpus_with_siblings()  https://review.opendev.org/74032715:56
artomsean-k-mooney, stephenfin ^^ quick drive-by comment patch while I work on the downstream bug15:56
sean-k-mooneythere are docs for that :P16:00
sean-k-mooneyso on master  if cpus & sib: should alwasy be empty/false when you have hw:cpu_thread_policy=isolate16:02
sean-k-mooneywe change the meaning in train16:02
sean-k-mooneybefore it ment select host without SMT or claim both siblings if SMT is enabled on the host16:03
sean-k-mooneyform train on its just select a host without SMT16:03
artomsean-k-mooney, *shrug* feel free to -1 :)16:03
sean-k-mooneyso i dont think there is a valid path to use pin_cpus_with_siblings anymore unless we are allowing the old behavior if you dont report PCPUs16:04
sean-k-mooneystephenfin: are we supporting ^16:04
stephenfinsean-k-mooney: https://review.opendev.org/#/c/705666/16:05
sean-k-mooneyhehe i even reviewd it i tought we spoke about this before16:05
sean-k-mooneyso we can remove those in victoria right16:06
stephenfinyup16:07
sean-k-mooneyshould thos be in the runway with the mixed cpus changes or just treated as seperate cleanups16:07
stephenfinjust got to find the time16:07
stephenfinseparate16:07
stephenfinlet's land the feature first16:07
sean-k-mooneyok16:07
*** udesale_ has joined #openstack-nova16:08
*** udesale has quit IRC16:10
*** hamalq has joined #openstack-nova16:18
*** k_mouza has quit IRC16:19
*** hamalq_ has joined #openstack-nova16:19
*** hamalq has quit IRC16:22
*** ociuhandu_ has joined #openstack-nova16:23
openstackgerritsean mooney proposed openstack/nova master: lookup nic feature by pci address  https://review.opendev.org/73913116:24
sean-k-mooneyalex_xu: i need to test this on my sriov servers so ill set -w on it for now but ^ should adress your comment16:24
sean-k-mooneyit  should be much more effiecnt then we had before16:25
*** ociuhandu has quit IRC16:27
*** udesale_ has quit IRC16:27
*** ociuhandu_ has quit IRC16:28
gmannsean-k-mooney: there are more deps need to bump lower-constraint, I am getting nova job green first and then same we can apply on os-vif-  https://review.opendev.org/#/c/738126/816:31
gmanni think i need to create Focal env and test in one shot. let's see if  there are more failure16:33
sean-k-mooneyi have folal devn envs but i have run devstack so they are not clean anymore16:44
sean-k-mooneyi can proabnly test the pathcs locally if you need me too i just need to boot a clean vm but not today16:44
sean-k-mooneygmann: i assme infra have no plance to add the deps to the base images so we either need to fix them in bindeps in each project or bump the minor verions16:45
sean-k-mooneygmann: looks like https://review.opendev.org/#/c/738130/ passed for os-vif16:46
gmannsean-k-mooney: cool.16:46
gmanninfra side, not at lest min version as that is project side things16:47
*** andreaf has quit IRC16:48
*** mnasiadka_ has joined #openstack-nova16:48
sean-k-mooneyi was more thinking of the libffi-dev issue16:48
sean-k-mooneybut ok16:48
gmannlet me update cmt msg and remove depends-on as 738130 has lower-constraint update also16:48
*** yankcrime has quit IRC16:49
sean-k-mooneysure. the kuryr-kubernetes-tempest job is not an os-vif job by the way so we will need to fix kuryr-kubernetes before that will pass16:49
*** dasp_ has joined #openstack-nova16:49
gmannyeah16:49
sean-k-mooneyits uses os-vif form git however so we run it to make sure we dont break them16:50
sean-k-mooneywhich reminds me with the upcoming change in devstack to use ovn by default         - os-vif-ovs will be come an ovn job but we need to make sure that         - os-vif-ovs-iptables keeps using ml2/ovs16:51
sean-k-mooneythats unrealted but it just occured to me16:51
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Re-enable live snapshot for paused instances  https://review.opendev.org/74033416:53
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Remove workaround for really old QEMU  https://review.opendev.org/74033516:53
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Attempt to restore some sanity to snapshot  https://review.opendev.org/74033616:53
gmannyeah, till now we added ovn as n-v job on devstack and check its stability but yes we need to adjust few bits for ovs specific jobs16:53
gmannlet me try kuryr-kubernetes migration also and test all things together.16:54
*** coreycb has quit IRC16:55
*** mnasiadka has quit IRC16:55
*** rm_work has quit IRC16:55
*** nicolasbock has quit IRC16:55
*** mordred has quit IRC16:55
*** dasp has quit IRC16:55
*** mnasiadka_ is now known as mnasiadka16:55
sean-k-mooneygiven that job install k8s it might be more work then other to get working16:55
sean-k-mooneyit will pull in docker and k8s which both shoudl be availabel on ubuntu 20.04 but there may be issue with the devstack plugin even before you get to the kuyry part16:56
sean-k-mooneyor it might just work16:56
gmannyeah, i remember the bionic migration case. but let's try16:56
*** rouk has quit IRC16:56
*** masterpe has quit IRC16:56
sean-k-mooneyill admit its the job i know least about on the os-vif gate16:57
gmannany reason it was n-v ?16:57
sean-k-mooneyyes it used to be quite unstable16:58
sean-k-mooneywell the old job did at least then the old job was deleted16:58
*** coreycb has joined #openstack-nova16:58
*** rm_work has joined #openstack-nova16:58
*** nicolasbock has joined #openstack-nova16:58
sean-k-mooneyits been fine form most of last cycle but we have had relitivly low volume of patches so it never seamed worth the effort to make it voting16:58
sean-k-mooneyi still check its results before mreging stuff but dont want to have it block someting it there gate is broken16:59
*** derekh has quit IRC16:59
sean-k-mooneywe did plan to make it voting evnetually it has just never happened.17:00
*** masterpe has joined #openstack-nova17:00
*** yankcrime has joined #openstack-nova17:00
*** mordred has joined #openstack-nova17:07
gmannok, I created Focal env, testing locally17:08
*** songwenping_ has joined #openstack-nova17:16
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Allow 'hw:cpu_realtime_mask' to be omitted  https://review.opendev.org/73702617:17
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly  https://review.opendev.org/46145617:17
*** songwenping__ has quit IRC17:19
*** lbragstad_ is now known as lbragstad17:21
bauzasgibi: sorry, I was off my keyboard, and I'll be on PTO from tomorrow to Wednesday morning17:23
* bauzas going to some resort 17:23
*** slaweq has quit IRC17:28
*** slaweq has joined #openstack-nova17:31
*** slaweq has quit IRC17:36
*** dtantsur is now known as dtantsur|afk17:45
*** ralonsoh has quit IRC17:57
*** JamesBenson has joined #openstack-nova18:18
*** tesseract has quit IRC18:27
*** its-surya has quit IRC18:35
*** xek has quit IRC18:57
openstackgerritMerged openstack/python-novaclient master: use stevedore to load extensions  https://review.opendev.org/73933119:03
*** songwenping__ has joined #openstack-nova19:13
*** songwenping_ has quit IRC19:16
*** tosky has quit IRC19:26
*** damien_r has quit IRC19:50
*** damien_r has joined #openstack-nova19:50
*** JamesBenson has quit IRC20:06
*** xek has joined #openstack-nova20:07
*** ociuhandu has joined #openstack-nova20:12
*** Yumeng has quit IRC20:13
*** damien_r has quit IRC20:24
*** ociuhandu has quit IRC20:31
*** slaweq has joined #openstack-nova20:33
*** xek has quit IRC20:36
*** ociuhandu has joined #openstack-nova20:47
*** nweinber has quit IRC20:56
*** ociuhandu has quit IRC20:59
openstackgerritMerged openstack/nova stable/ussuri: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/73607321:05
eanderssonbauzas if you guys have time could you look at getting https://review.opendev.org/#/c/703116/ merged? would love to push that patch out21:07
eanderssonWorst case I can just cherry-pick it, but a lot nicer to just be able to rebase :D21:07
eanderssonhttps://review.opendev.org/#/q/topic:bug/1763766+(status:open)21:11
*** damien_r has joined #openstack-nova21:11
*** maciejjozefczyk has quit IRC21:12
*** raildo has quit IRC21:22
*** songwenping_ has joined #openstack-nova21:26
*** songwenping__ has quit IRC21:29
openstackgerritMerged openstack/nova stable/train: Guard against missing image cache directory  https://review.opendev.org/73845521:39
*** eharney has quit IRC21:42
*** slaweq has quit IRC22:21
*** damien_r has quit IRC22:33
*** slaweq has joined #openstack-nova22:38
*** jamesdenton has quit IRC22:40
*** hrw has quit IRC22:43
*** damien_r has joined #openstack-nova22:44
*** hrw has joined #openstack-nova22:53
*** tkajinam has joined #openstack-nova23:00
*** mlavalle has quit IRC23:06
*** mriedem has left #openstack-nova23:07
*** damien_r has quit IRC23:11
*** damien_r has joined #openstack-nova23:17
*** damien_r has quit IRC23:22
openstackgerritMerged openstack/nova stable/queens: Reset the cell cache for database access in Service  https://review.opendev.org/72059623:44
*** gyee has quit IRC23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!