Wednesday, 2020-07-01

« Tuesday, 2020-06-30 Index Thursday, 2020-07-02 »
*** rchurch has quit IRC00:34
*** zhanglong has joined #openstack-nova00:38
*** grandchild has quit IRC01:00
openstackgerritGonéri Le Bouder proposed openstack/nova master: QEMU/KVM: accept vmxnet3 NIC  https://review.opendev.org/73869501:04
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing nova gate on ubuntu focal  https://review.opendev.org/73812601:05
*** Liang__ has joined #openstack-nova01:17
*** markvoelker has joined #openstack-nova01:20
*** markvoelker has quit IRC01:24
*** gyee has quit IRC01:35
openstackgerritKevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job  https://review.opendev.org/71443901:37
*** yaawang has quit IRC01:42
*** yaawang has joined #openstack-nova01:43
*** Liang__ has quit IRC01:46
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing nova gate on ubuntu focal  https://review.opendev.org/73812601:49
openstackgerritTony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334102:10
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree  https://review.opendev.org/67652202:10
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346002:10
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602902:10
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing nova gate on ubuntu focal  https://review.opendev.org/73812602:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix user creation with GRANT in MySQL 8.0(Ubuntu Focal)  https://review.opendev.org/73872302:27
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing nova gate on ubuntu focal  https://review.opendev.org/73812602:28
gmanndansmith: melwitt gibi Ubuntu Focal fix for tool/test-setup.sh - https://review.opendev.org/#/c/738723/  Testing it in https://review.opendev.org/#/c/738126/ .02:30
gmannResult should be ready by morning. I will be on holiday tomorrow, so pinged before gate result.02:31
*** yaawang has quit IRC02:45
*** yaawang has joined #openstack-nova02:46
openstackgerritWenping Song proposed openstack/nova master: Add instance project_id for cyborg arq  https://review.opendev.org/73842803:04
*** psachin has joined #openstack-nova03:33
*** zhanglong has quit IRC03:42
*** Liang__ has joined #openstack-nova03:58
*** markvoelker has joined #openstack-nova04:03
*** markvoelker has quit IRC04:08
*** iurygregory has quit IRC04:31
*** evrardjp has quit IRC04:33
*** udesale has joined #openstack-nova04:33
*** evrardjp has joined #openstack-nova04:33
*** mugsie has quit IRC04:53
*** mugsie has joined #openstack-nova04:57
*** markvoelker has joined #openstack-nova05:03
*** markvoelker has quit IRC05:07
*** vishalmanchanda has joined #openstack-nova05:23
*** links has joined #openstack-nova05:34
*** yaawang has quit IRC05:45
*** yaawang has joined #openstack-nova05:45
*** ccamacho has quit IRC05:58
*** factor has quit IRC06:03
*** factor has joined #openstack-nova06:03
*** icarusfactor has joined #openstack-nova06:05
*** factor has quit IRC06:06
*** jsuchome has joined #openstack-nova06:09
*** zhanglong has joined #openstack-nova06:09
*** ratailor has joined #openstack-nova06:12
*** zhanglong has quit IRC06:18
*** zhanglong has joined #openstack-nova06:20
*** icarusfactor has quit IRC06:22
*** mkrai has joined #openstack-nova06:28
*** ccamacho has joined #openstack-nova06:31
*** tetsuro has joined #openstack-nova06:33
*** zhanglong has quit IRC06:42
*** tetsuro has quit IRC06:43
*** tetsuro has joined #openstack-nova06:43
*** tetsuro has quit IRC06:43
*** zhanglong has joined #openstack-nova06:43
*** yaawang has quit IRC06:43
*** yaawang has joined #openstack-nova06:51
openstackgerritJiri Suchomel proposed openstack/nova master: Move image verification and writing out of download method  https://review.opendev.org/73873806:55
*** tetsuro has joined #openstack-nova06:55
*** yaawang has quit IRC06:55
*** yaawang has joined #openstack-nova06:55
*** tetsuro has quit IRC06:56
*** bhagyashris is now known as bhagyashris|brb06:59
*** luksky has joined #openstack-nova07:02
*** rcernin has quit IRC07:02
*** markvoelker has joined #openstack-nova07:04
*** rcernin has joined #openstack-nova07:04
*** iurygregory has joined #openstack-nova07:09
*** markvoelker has quit IRC07:09
*** mkrai has quit IRC07:10
*** slaweq has quit IRC07:12
*** slaweq has joined #openstack-nova07:13
*** maciejjozefczyk has joined #openstack-nova07:15
*** bhagyashris|brb is now known as bhagyashris07:15
*** tesseract has joined #openstack-nova07:17
*** markvoelker has joined #openstack-nova07:18
*** markvoelker has quit IRC07:23
*** rcernin has quit IRC07:30
*** nightmare_unreal has joined #openstack-nova07:30
*** Liang__ has quit IRC07:30
*** Liang__ has joined #openstack-nova07:31
*** ralonsoh has joined #openstack-nova07:33
*** zhanglong has quit IRC07:34
*** dtantsur|afk is now known as dtantsur07:35
*** mkrai has joined #openstack-nova07:35
*** zhanglong has joined #openstack-nova07:36
*** tosky has joined #openstack-nova07:40
*** ociuhandu has quit IRC07:41
huaqianga07:43
*** rcernin has joined #openstack-nova07:50
*** ttsiouts has joined #openstack-nova07:53
*** ttsiouts has quit IRC07:53
*** ttsiouts has joined #openstack-nova07:54
*** xek has joined #openstack-nova07:58
openstackgerritJiri Suchomel proposed openstack/nova master: Move image verification and writing out of download method  https://review.opendev.org/73873807:58
*** xek has quit IRC07:59
*** xek has joined #openstack-nova08:00
*** rcernin has quit IRC08:06
*** zhanglong has quit IRC08:11
*** k_mouza has joined #openstack-nova08:15
*** zhanglong has joined #openstack-nova08:15
*** sapd1 has joined #openstack-nova08:18
*** ociuhandu has joined #openstack-nova08:20
*** martinkennelly has joined #openstack-nova08:24
*** ttsiouts has quit IRC08:37
*** ttsiouts has joined #openstack-nova08:38
*** ttsiouts has quit IRC08:42
*** derekh has joined #openstack-nova08:45
*** yaawang has quit IRC08:46
*** yaawang has joined #openstack-nova08:46
*** lee1 has joined #openstack-nova08:51
*** lee1 is now known as lyarwood08:52
*** k_mouza has quit IRC09:00
*** k_mouza has joined #openstack-nova09:05
*** ttsiouts has joined #openstack-nova09:27
*** yaawang has quit IRC09:30
*** yaawang has joined #openstack-nova09:31
*** tkajinam has quit IRC09:59
*** xek has quit IRC10:05
*** dtantsur is now known as dtantsur|brb10:27
*** Liang__ has quit IRC10:40
stephenfinbauzas: Can you take a punt at https://review.opendev.org/#/c/733827/ ?10:57
bauzasstephenfin: will look this afternoon10:58
stephenfinThanks10:58
*** priteau has joined #openstack-nova11:02
*** kevinz has quit IRC11:11
*** markvoelker has joined #openstack-nova11:15
*** markvoelker has quit IRC11:19
*** mkrai has quit IRC11:26
*** raildo has joined #openstack-nova11:28
*** udesale_ has joined #openstack-nova11:28
*** udesale has quit IRC11:31
*** zhanglong has quit IRC11:32
*** csatari has quit IRC11:53
*** owalsh_ has joined #openstack-nova11:55
*** csatari has joined #openstack-nova11:56
*** rnoriega_ has quit IRC11:58
*** owalsh has quit IRC11:58
*** rnoriega- has joined #openstack-nova11:58
*** sapd1 has quit IRC12:05
*** sapd1 has joined #openstack-nova12:05
*** k_mouza has quit IRC12:13
*** k_mouza has joined #openstack-nova12:13
*** breizhkoala has joined #openstack-nova12:15
*** irclogbot_3 has quit IRC12:16
*** irclogbot_0 has joined #openstack-nova12:18
*** derekh has quit IRC12:28
*** martinkennelly has quit IRC12:40
*** dtantsur|brb is now known as dtantsur12:45
*** xek has joined #openstack-nova12:46
*** trident has quit IRC12:46
*** derekh has joined #openstack-nova12:48
*** zhanglong has joined #openstack-nova12:48
*** trident has joined #openstack-nova12:49
*** tbachman has quit IRC12:57
*** tbachman has joined #openstack-nova12:58
*** nweinber has joined #openstack-nova12:59
*** xek has quit IRC13:01
lsekiHello folks, could you give some suggestions on how to address this bug?13:08
lsekihttps://bugs.launchpad.net/cinder/+bug/1870367 "Fail to extend attached volume using generic NFS driver"13:08
openstackLaunchpad bug 1870367 in Cinder "Fail to extend attached volume using generic NFS driver" [High,In progress] - Assigned to Silvan Kaiser (2-silvan)13:08
lsekiin summary, when trying to resize a volume in-use, `qemu-img resize` command fails to get the write lock, because `qemu` process has locked the volume file upon VM start.13:08
lsekiThis was discussed on Cinder PTG, but we didn't come up with a solution yet13:08
*** mriedem has joined #openstack-nova13:13
lyarwoodlseki: you can use --force-share to workaround the locks but I'm not sure that it would be the best approach here tbh13:16
lyarwoodlseki: but then again we were essentially doing that prior to QEMU taking the locks13:17
lyarwoodlseki: but without quessing the disk on the compute side first that might be problematic13:18
gibilyarwood: welcome back!13:21
lyarwoodgibi: \o hey thanks, glad to be back finally :)13:21
*** ratailor has quit IRC13:21
*** xek has joined #openstack-nova13:22
*** yankcrime has quit IRC13:22
*** jhesketh has quit IRC13:22
*** jhesketh has joined #openstack-nova13:24
gibi:)13:24
*** yankcrime has joined #openstack-nova13:24
*** psachin has quit IRC13:31
*** xek has quit IRC13:33
sean-k-mooneylyarwood: we do quiese the disk for vm snapshots right13:33
sean-k-mooneyif we are doing a live snapshot via the qemu-guest agent?13:34
sean-k-mooneywe use the monitor to invoke freeze13:34
sean-k-mooneycould we do the same for volume snapshots?13:34
*** zhanglong has quit IRC13:34
*** dklyle has quit IRC13:35
lyarwoodsean-k-mooney: we do for snapshots, we could for extend as well I guess but I'm not entirely sure if we need to tbh13:36
lsekilyarwood: in my machine (without openstack, just qemu-kvm), I managed to resize an attached disk with the command13:36
lseki`sudo virsh qemu-monitor-command ubuntu18.04 --hmp "block_resize drive-virtio-disk1 2G"`13:36
sean-k-mooneylseki: well that is having qemu do the resize13:37
sean-k-mooneylseki: which s not normally how a volume resize would work13:37
sean-k-mooneylseki: a volume resize for other driver would have the backend to the resize13:37
sean-k-mooneylseki: i think that only works because qemu is the thing with the lock13:38
lyarwoodwell, c-vol resizes the underlying device, n-cpu then resizes the host device on the compute and then we resize the device within QEMU13:38
sean-k-mooneywe could special case but that would fail for iscsi backend and proably ceph13:38
lsekisean-k-mooney: hmm would it be possible to add a condition to do that only when the backend driver is qemu?13:39
sean-k-mooneylyarwood: right but presumably the nfs driver cant resize the file because qemu has locked the file right13:39
lyarwoodthe issue here is that we are asking qemu-img to resize the host device, in this case a file.13:39
lyarwoodyeah13:39
lyarwoodbut I guess c-vol is actually calling this13:40
sean-k-mooneylseki: you mean the backedn driver is nfs13:40
lsekisean-k-mooney: oops, yes13:40
sean-k-mooneylyarwood: yes becasue if it was not attached to a vm then it would have to do the resize13:40
lyarwoodI think we should be safe to add --force-share to the qemu-img resize call in c-vol tbh13:40
sean-k-mooneylyarwood: will that also resize the filesystem13:41
lyarwoodsean-k-mooney: no13:41
sean-k-mooneyjsut the qcow/raw file13:41
lyarwoodright, virt-resize does both13:41
lyarwoodor it's up to the user13:41
lyarwoodonce n-cpu has called QEMU to resize the device within the domain13:41
*** bhagyashris is now known as bhagyashris|afk13:42
sean-k-mooneywell i know for a server resize we resize the filesystem automatically13:43
lyarwoodthat's only for ephemeral disks where we know the format right?13:44
*** liuyulong has joined #openstack-nova13:50
sean-k-mooneyyes13:53
sean-k-mooneybasically whatever libguestfs supports13:53
sean-k-mooneyif it does recognise the filesytem i think it jsut resizes the block device13:54
*** mkrai has joined #openstack-nova13:56
*** mlavalle has joined #openstack-nova13:58
*** Liang__ has joined #openstack-nova14:02
*** Liang__ is now known as LiangFang14:02
*** xek has joined #openstack-nova14:07
lsekilyarwood: your suggestion is to add `--force-share` to `qemu-img resize` command?14:11
lsekihttps://github.com/openstack/cinder/blob/f74c533382ec256ca7dda41e8e451392d81e2944/cinder/image/image_utils.py#L35314:11
lyarwoodlseki: yeah correct14:11
lsekioh14:12
lsekihttps://www.irccloud.com/pastebin/LBtS5n4l/14:12
lyarwoodlseki: which version of QEMU are you using?14:13
lyarwoodlseki: I can't recall which version we require to use that switch as Nova already requires it on the computesd14:14
* lyarwood checks14:14
sean-k-mooneyso we can set the trasport we use for cold migration with https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.remote_filesystem_transport14:14
lsekihttps://www.irccloud.com/pastebin/U58tnfou/14:14
sean-k-mooneydo we have a way to choose the ssh user?14:14
sean-k-mooneylike we do for live migration14:14
lyarwoodlseki: https://www.irccloud.com/pastebin/U58tnfou/ - hmm 2.11 should have it, we dropped the version check once we hit that14:16
lyarwoodor was that 2.1214:16
sean-k-mooneylooks like no... i guess ill just excange ssh keys14:16
lyarwoodah no that's 2.1014:17
lyarwoodlseki: yeah weird you should have that14:17
lyarwoodmaybe it's missing from resize?14:17
lyarwoodyeah it is14:18
lyarwoododd14:18
*** dave-mccowan has quit IRC14:22
*** dave-mccowan has joined #openstack-nova14:25
lsekioh... seems that there's no force-resize param for `img_resize` https://github.com/qemu/qemu/blob/6bb228190ef0b45669d285114cf8a280c55f4b39/qemu-img.c#L3856_L405314:33
lsekioops wrong branch14:34
lyarwoodyeah I don't really know what we could do in this case14:34
lsekibut it's not in the master branch as well https://github.com/qemu/qemu/blob/master/qemu-img.c#L3856_#L405314:35
lseki😢14:35
lyarwoodyeah apologies, I assumed it was an available option across the subcommands but that isn't the case14:36
lyarwoodwe can just truncate RAW files14:37
lyarwoodbut these are qcow214:37
sean-k-mooneywe dont allow resize down of attached volumes right14:38
sean-k-mooneythat sound bad14:38
lyarwoodno I don't think so14:38
sean-k-mooneyso you just mean use the truncate command but not to shrink14:38
lyarwoodhttps://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=extend-a-volume-size-detail#extend-a-volume-size14:38
lyarwoodsean-k-mooney: yeah you can use truncate to grow files14:38
lyarwoodsean-k-mooney: but that wouldn't work in this case as it wouldn't update the qcow2 headers to use the extra space14:39
sean-k-mooney ya wasnt sure if you ment the command or not14:39
sean-k-mooneyyes14:39
lyarwooda hackaround would be to use swap_volume in n-cpu to switch to a larger file14:40
sean-k-mooneylyarwood: so what we likely need to do is if the volume is attach have the backend not resize it and have nova via the qemu monitor command have qemu do the resize14:41
lyarwoodtbh using that approach for all backends might be nicer anyway now I think about it14:41
sean-k-mooneyso if volume is available then c-vol will do the resize else nova will just invoke qemu to do it14:41
sean-k-mooneyand we never call qemu-img for nfs backend14:41
lyarwoodblock resize by QEMU isn't going to resize the file14:42
lyarwoodjust as it isn't going to resize host devices for other backends AFAIK14:42
sean-k-mooneyso  `sudo virsh qemu-monitor-command ubuntu18.04 --hmp "block_resize  drive-virtio-disk1 2G"`14:43
sean-k-mooneywont grow the file14:43
sean-k-mooneylseki: didnt you say that worked14:43
lyarwoodI don't believe so14:43
sean-k-mooneyfor qcow it does not need to make the file physically bigger14:43
sean-k-mooneyjust update the headers14:43
sean-k-mooneyso that qemu can allocate it when needed14:44
sean-k-mooneywhich is what we want. e.g. keep the file sparse14:44
lyarwoodhmmm is that enough?14:44
sean-k-mooneyim not sure but lseki could test with dd?14:45
lyarwoodI thought you had to at least grow the sparse file so it looks like it's 2G before you can update the qcow2 headers to be 2G14:45
sean-k-mooneynot sure but it sounds like something we should test14:46
lyarwoodyup14:46
lyarwoodbrb14:46
sean-k-mooneylseki: can you try that. grow you iamge to like 10G and then use dd to crate a 5G file in the vm14:47
*** dkehn has quit IRC14:47
lsekisean-k-mooney: lyarwood oops, I was using a raw file instead of qcow14:47
sean-k-mooneyif it had less then 2G before that would fail14:47
sean-k-mooneylseki: oh in that case what the size of the file on disk after that command14:47
sean-k-mooneydid it grow it to 2G14:47
*** LiangFang has quit IRC14:48
lsekiyes it did, and `lsblk` inside the vm also is updated to 2G14:48
sean-k-mooneycould you convert it over to a qcow boot a vm with the new image and then grow it to say 4G14:48
sean-k-mooneyusing the same command on the new vm14:49
sean-k-mooneylets see if it will do the right thing in that case14:49
*** nweinber has quit IRC14:49
sean-k-mooneyif so i think we have a way to adresss this14:49
*** dklyle has joined #openstack-nova14:49
*** Liang__ has joined #openstack-nova14:51
lsekilet me try that...14:51
*** nweinber has joined #openstack-nova14:53
*** links has quit IRC14:55
*** suryasingh has joined #openstack-nova15:01
lyarwoodsean-k-mooney: TIL I didn't think blockResize did that, given that we resized the file before I guess that was the case and something has changed?15:03
sean-k-mooneyfrom the name that is what i would expect ti to do15:04
sean-k-mooneymaybe not for host devices15:04
sean-k-mooneybut for files at least15:04
lyarwoodyeah it can't for host devices15:04
lyarwoodI might be mixing things up with blockRebase tbh15:05
*** dave-mccowan has quit IRC15:08
*** dave-mccowan has joined #openstack-nova15:11
*** _mlavalle_1 has joined #openstack-nova15:19
*** mlavalle has quit IRC15:22
*** factor has joined #openstack-nova15:32
*** Liang__ has quit IRC15:33
*** JamesBenson has joined #openstack-nova15:37
lsekisean-k-mooney: I downloaded a cirros image and booted a vm from it. I successfully extended the volume to 4G.15:40
lsekihttps://www.irccloud.com/pastebin/QF9Dk7Wa/15:41
lsekiwithin the vm:15:42
lsekihttps://www.irccloud.com/pastebin/QJ8flBUZ/15:42
*** mkrai has quit IRC15:42
lsekithough it didn't work when the disk was attached using the default IDE bus15:43
lsekihttps://www.irccloud.com/pastebin/pv6e5QOF/15:43
lsekiso I had to specify virtio bus while booting the vm `--disk cirros-0.5.1-x86_64-disk.img,bus=virtio`15:44
openstackgerritMerged openstack/nova master: Correct reported system memory  https://review.opendev.org/73382715:47
openstackgerritMerged openstack/nova master: Extend is_ipv6_supported() to cover more error cases  https://review.opendev.org/73616715:47
stephenfinbauzas: Thanks for that review. You'd probably also be interested in gibi's follow-up fix here https://review.opendev.org/#/c/737508/15:50
bauzasstephenfin: ack, thanks for helping me to go off some hardware discussion, my brain being fried ;)15:50
stephenfin:P15:50
stephenfinanytime, buddy15:51
*** hamalq has joined #openstack-nova15:57
*** hamalq_ has joined #openstack-nova15:58
bauzasgibi: stephenfin: holding my +W on https://review.opendev.org/#/c/737508/3 just for saying I honestly feel we should document this15:59
bauzasand not leave operators discovering it by themselves15:59
bauzasbut, a FUP for course15:59
*** hamalq has quit IRC16:02
*** liuyulong has quit IRC16:05
*** ttsiouts has quit IRC16:06
*** ttsiouts has joined #openstack-nova16:07
*** ttsiouts has quit IRC16:11
*** dkehn has joined #openstack-nova16:11
*** udesale_ has quit IRC16:12
*** derekh has quit IRC16:15
*** etp has quit IRC16:16
*** etp has joined #openstack-nova16:19
*** k_mouza has quit IRC16:19
*** etp has quit IRC16:24
stephenfinbauzas: To be honest, I thought that was assumed and I can't find anywhere easy to slot it in :-\16:25
*** efried has quit IRC16:28
*** xek has quit IRC16:29
bauzasstephenfin: right, hence my main comment16:30
bauzasanyway, you saw it, +Wing16:30
*** breizhkoala has quit IRC16:41
*** etp has joined #openstack-nova16:44
*** dtantsur is now known as dtantsur|afk16:44
*** ociuhandu_ has joined #openstack-nova16:45
*** ociuhandu has quit IRC16:49
sean-k-mooneywhile the libvirt driver could work on non linux hosts. it has been deployed on freebsd years ago that has never really been supported16:50
sean-k-mooneywe make assumtions about linux in the code to day so i doubt you could make it work on say window easily even if you wanted too16:50
*** factor has quit IRC16:51
*** icarusfactor has joined #openstack-nova16:51
*** ociuhandu_ has quit IRC16:52
*** efried has joined #openstack-nova16:56
lsekilyarwood: oh, and the volume size started with 39M, but after doing some dd inside the vm it growed to 2G16:57
*** ociuhandu has joined #openstack-nova16:59
sean-k-mooneylseki: so the qcow stayed sparse until we actuly wrote data too it16:59
sean-k-mooneywhich is what we want right16:59
lsekiyes16:59
sean-k-mooneyso to summerise 1, we should modify the cinder nfs backend to only extend voluem if its not attached to a vm, 2 when we are using nfs voluem in nova we should skip calling qemu-image and jsut do a block resize via the qemu monitor command17:00
sean-k-mooneylyarwood: ^ does that make sense too you?17:01
sean-k-mooneylseki: for the ide case did you use the correct name?17:04
sean-k-mooneyi mean it wont be drive-virtio-disk0 right17:04
sean-k-mooneyit would be something like drive-ide-disk017:04
lsekisean-k-mooney: I tried the one shown by dumpxml, which is simply `disk`17:05
lsekilet me try with `drive-ide-disk0`17:05
sean-k-mooneywell its just disk for virtio as well17:06
sean-k-mooney   <disk type='file' device='disk'>17:06
sean-k-mooneyi think you are looking for the alias element17:06
sean-k-mooney <alias name='virtio-disk0'/17:06
*** ociuhandu has quit IRC17:07
lsekioh that's right, so I should use `drive-ide0-0-0` for ide17:09
lsekiyeah it works :-)17:09
sean-k-mooneycool17:09
sean-k-mooneyso we can lookup the alais from the xml17:09
sean-k-mooneyi assume its jsut ide0-0-017:09
sean-k-mooneyand we need to prepend drive-17:10
*** ralonsoh has quit IRC17:10
*** ralonsoh has joined #openstack-nova17:10
lsekiyes17:11
sean-k-mooneyim not going to ask you to test ceph but it might be intersting to see if we could use this patteren for other drivers too and avoid the calll to qemu-img17:13
sean-k-mooneythat can be a step 317:13
sean-k-mooneyafter 1 and 217:13
sean-k-mooneywhcih will fix your usecase17:13
*** jdillaman has quit IRC17:15
*** corvus has quit IRC17:15
*** bnemec has quit IRC17:15
*** mvkr has quit IRC17:15
*** ganso has quit IRC17:15
*** andreykurilin has quit IRC17:15
*** ericyoung has quit IRC17:15
*** factor has joined #openstack-nova17:16
*** icarusfactor has quit IRC17:16
*** ganso has joined #openstack-nova17:18
*** corvus has joined #openstack-nova17:18
*** ericyoung has joined #openstack-nova17:18
*** jdillaman has joined #openstack-nova17:18
*** andreykurilin has joined #openstack-nova17:19
lsekiso currently cinder nfs driver calls qemu-img resize to extend a volume, attached or not17:19
lsekihttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L38017:19
lsekihttps://github.com/openstack/cinder/blob/master/cinder/image/image_utils.py#L40817:19
lsekithe step 1 is to stop calling qemu-img resize if the volume is attached17:19
*** mvkr has joined #openstack-nova17:19
*** _gryf has joined #openstack-nova17:20
*** bnemec has joined #openstack-nova17:21
lsekibut regarding the step 2, I'm not familiar with nova code... is there some workflow we can modify to make it call qemu monitor command?17:22
sean-k-mooneythis might be in os-brick im not certin17:22
sean-k-mooneylseki: stephenfin or lyarwood have looked at this more recently then i have17:22
sean-k-mooneylseki: is there a bug for this17:23
sean-k-mooneylseki: if so can you summerise this in a comment17:24
lsekihttps://bugs.launchpad.net/cinder/+bug/187036717:24
openstackLaunchpad bug 1870367 in Cinder "Fail to extend attached volume using generic NFS driver" [High,In progress] - Assigned to Silvan Kaiser (2-silvan)17:24
lsekiyeah I'll add a comment there17:24
lyarwoodsean-k-mooney / lseki ; we already call blockResize in n-cpu17:25
sean-k-mooneylyarwood: ok so we just need to not call qemu-img in cinder or nova when using nfs17:26
*** rnoriega- has quit IRC17:26
*** huaqiang has quit IRC17:26
*** johanssone has quit IRC17:26
*** mtreinish has quit IRC17:26
*** zzzeek has quit IRC17:26
*** gryf has quit IRC17:26
sean-k-mooneyand the volume is attached17:26
lyarwoodsean-k-mooney: we just need to remove the call in c-vol17:26
lyarwoodhttps://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/driver.py#L2044-L204817:27
lyarwoodhttps://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/guest.py#L811-L81917:27
*** hongbin has joined #openstack-nova17:28
*** irclogbot_0 has quit IRC17:28
*** gyee has joined #openstack-nova17:29
*** rnoriega- has joined #openstack-nova17:29
*** huaqiang has joined #openstack-nova17:29
*** johanssone has joined #openstack-nova17:29
*** mtreinish has joined #openstack-nova17:29
*** zzzeek has joined #openstack-nova17:29
*** nightmare_unreal has quit IRC17:29
*** irclogbot_2 has joined #openstack-nova17:30
*** dkehn has quit IRC17:37
*** hoonetorg has quit IRC17:40
*** tesseract has quit IRC17:41
*** hoonetorg has joined #openstack-nova17:52
*** xek has joined #openstack-nova17:54
*** damien_r has joined #openstack-nova17:55
lsekilyarwood / sean-k-mooney: is blockResize called always, no matter what c-vol did before?18:03
lsekitesting it in a stable/train devstack here...18:15
*** eharney has quit IRC18:16
*** slaweq has quit IRC18:25
lyarwoodlseki: yes18:27
lsekioh no18:34
lsekihttps://www.irccloud.com/pastebin/hmybxXhk/18:34
*** dasp_ has quit IRC18:39
*** jsuchome has quit IRC18:40
*** dasp has joined #openstack-nova18:41
*** _gryf is now known as gryf18:41
*** hongbin has quit IRC18:44
*** factor has quit IRC18:46
*** factor has joined #openstack-nova18:46
lsekithe driver being used is `LibvirtNFSVolumeDriver`, with parent `LibvirtBaseFileSystemVolumeDriver` and grandpa `LibvirtBaseVolumeDriver`18:49
lsekinone of them implement `extend_volume` :-(18:49
*** dklyle has quit IRC18:54
lsekiso it stops here https://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/driver.py#L2100 before reaching `_resize_attached_volume`18:54
*** dklyle has joined #openstack-nova19:02
*** factor has quit IRC19:04
*** factor has joined #openstack-nova19:04
lsekiI implemented `LibvirtNFSVolumeDriver.extend_volume` that just returns `requested_size`, and then attached extend worked!19:05
lseki🎉19:05
*** ociuhandu has joined #openstack-nova19:06
lsekiI'll update the bug report and submit the patches for both cinder and nova19:06
lsekilyarwood: sean-k-mooney thank you for helping me!19:07
*** factor has quit IRC19:10
*** _mlavalle_1 has quit IRC19:10
*** _mlavalle_1 has joined #openstack-nova19:15
*** hongbin has joined #openstack-nova19:18
*** yoctozepto7 has joined #openstack-nova19:37
*** yoctozepto has quit IRC19:45
*** yoctozepto7 is now known as yoctozepto19:45
*** vishalmanchanda has quit IRC19:47
*** ralonsoh has quit IRC19:50
*** spatel has joined #openstack-nova19:55
openstackgerritMerged openstack/nova master: Prevent libvirt driver starting on non Linux platform  https://review.opendev.org/73750819:59
*** eharney has joined #openstack-nova19:59
*** hongbin has quit IRC20:06
*** slaweq has joined #openstack-nova20:25
*** spatel has quit IRC20:29
*** spatel has joined #openstack-nova20:30
*** spatel has quit IRC20:30
*** maciejjozefczyk has quit IRC20:36
*** nweinber has quit IRC20:53
*** hongbin has joined #openstack-nova20:54
*** ircuser-1 has quit IRC21:03
*** slaweq has quit IRC21:19
*** xek has quit IRC21:20
*** priteau has quit IRC21:21
*** factor has joined #openstack-nova21:29
*** factor has quit IRC21:33
*** factor has joined #openstack-nova21:33
*** factor has quit IRC21:49
*** factor has joined #openstack-nova21:50
*** haleyb has joined #openstack-nova21:52
openstackgerritMerged openstack/nova master: Limit the number of concurrent snapshots  https://review.opendev.org/73616921:56
*** gregwork has joined #openstack-nova22:09
*** zhanglong has joined #openstack-nova22:22
*** luksky has quit IRC22:29
*** icarusfactor has joined #openstack-nova22:33
*** factor has quit IRC22:36
*** rcernin has joined #openstack-nova22:36
*** tkajinam has joined #openstack-nova22:46
*** rcernin has quit IRC22:47
*** rcernin has joined #openstack-nova22:47
*** JamesBenson has quit IRC22:47
*** JamesBenson has joined #openstack-nova22:49
*** zhanglong has quit IRC22:50
*** zhanglong has joined #openstack-nova22:52
*** mriedem has left #openstack-nova22:54
*** JamesBenson has quit IRC22:54
*** spatel has joined #openstack-nova22:58
*** jmlowe has quit IRC23:06
*** spatel has quit IRC23:07
*** hoonetorg has quit IRC23:08
*** _mlavalle_1 has quit IRC23:11
*** hongbin has quit IRC23:11
*** hoonetorg has joined #openstack-nova23:11
*** tosky has quit IRC23:16
*** hongbin has joined #openstack-nova23:16
*** zhanglong has quit IRC23:17
*** jmlowe has joined #openstack-nova23:28
*** JamesBenson has joined #openstack-nova23:29
*** JamesBenson has quit IRC23:34
*** hamalq_ has quit IRC23:41
« Tuesday, 2020-06-30 Index Thursday, 2020-07-02 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!