| *** tbachman has quit IRC | 00:22 | |
| *** brinzhang0 has joined #openstack-nova | 00:30 | |
| *** brinzhang_ has quit IRC | 00:33 | |
| *** grandchild has quit IRC | 00:34 | |
| *** nweinber has joined #openstack-nova | 00:36 | |
| *** nweinber has quit IRC | 00:46 | |
| *** tetsuro has joined #openstack-nova | 00:49 | |
| *** markvoelker has joined #openstack-nova | 01:14 | |
| *** Liang__ has joined #openstack-nova | 01:31 | |
| *** rchurch has quit IRC | 01:43 | |
| *** yaawang has quit IRC | 01:45 | |
| *** markvoelker has quit IRC | 01:46 | |
| *** yaawang has joined #openstack-nova | 01:47 | |
| *** Liang__ has quit IRC | 01:50 | |
| *** Liang__ has joined #openstack-nova | 01:53 | |
| *** markvoelker has joined #openstack-nova | 01:57 | |
| *** boxiang has joined #openstack-nova | 02:08 | |
| *** markvoelker has quit IRC | 02:16 | |
| *** markvoelker has joined #openstack-nova | 02:17 | |
| *** rcernin has quit IRC | 02:19 | |
| *** markvoelker has quit IRC | 02:21 | |
| *** boxiang has quit IRC | 02:30 | |
| *** boxiang_ has joined #openstack-nova | 02:30 | |
| *** yaawang has quit IRC | 02:40 | |
| *** yaawang has joined #openstack-nova | 02:40 | |
| *** rcernin has joined #openstack-nova | 02:43 | |
| *** johanssone has quit IRC | 02:43 | |
| *** rcernin has quit IRC | 02:43 | |
| *** rcernin has joined #openstack-nova | 02:44 | |
| *** johanssone has joined #openstack-nova | 02:45 | |
| *** tbachman has joined #openstack-nova | 03:04 | |
| *** Liang__ has quit IRC | 03:04 | |
| *** Liang__ has joined #openstack-nova | 03:04 | |
| *** psachin has joined #openstack-nova | 03:38 | |
| *** yaawang has quit IRC | 03:46 | |
| *** yaawang has joined #openstack-nova | 03:47 | |
| *** markvoelker has joined #openstack-nova | 04:17 | |
| *** markvoelker has quit IRC | 04:22 | |
| *** udesale has joined #openstack-nova | 04:28 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** yaawang has quit IRC | 04:59 | |
| *** yaawang has joined #openstack-nova | 05:00 | |
| *** bhagyashris is now known as bhagyashris|pto | 05:16 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** links has joined #openstack-nova | 05:34 | |
| *** links has quit IRC | 05:58 | |
| *** jawad_axd has joined #openstack-nova | 05:59 | |
| *** jawad_axd has quit IRC | 06:03 | |
| *** xek has joined #openstack-nova | 06:11 | |
| *** slaweq has joined #openstack-nova | 06:12 | |
| *** links has joined #openstack-nova | 06:17 | |
| *** slaweq has quit IRC | 06:18 | |
| *** slaweq has joined #openstack-nova | 06:19 | |
| *** dpawlik4 has joined #openstack-nova | 06:20 | |
| *** slaweq has quit IRC | 06:25 | |
| *** damien_r has joined #openstack-nova | 06:30 | |
| *** damien_r has quit IRC | 06:35 | |
| *** tetsuro has quit IRC | 06:43 | |
| *** ccamacho has joined #openstack-nova | 06:47 | |
| *** rpittau|afk is now known as rpittau | 06:51 | |
| *** nightmare_unreal has joined #openstack-nova | 06:54 | |
| *** ircuser-1 has quit IRC | 06:54 | |
| *** tetsuro has joined #openstack-nova | 06:56 | |
| *** ccamacho has quit IRC | 07:02 | |
| *** xek has quit IRC | 07:02 | |
| *** xek has joined #openstack-nova | 07:03 | |
| *** slaweq has joined #openstack-nova | 07:04 | |
| *** luksky has joined #openstack-nova | 07:05 | |
| *** takamatsu is now known as mauro|hackfest-o | 07:08 | |
| *** mauro|hackfest-o is now known as mauro|hackfest | 07:09 | |
| *** mauro|hackfest is now known as takamatsu | 07:09 | |
| *** yaawang has quit IRC | 07:10 | |
| *** xek has quit IRC | 07:10 | |
| *** ttsiouts has joined #openstack-nova | 07:11 | |
| *** yaawang has joined #openstack-nova | 07:12 | |
| *** xek has joined #openstack-nova | 07:13 | |
| *** ralonsoh has joined #openstack-nova | 07:19 | |
| *** xek_ has joined #openstack-nova | 07:19 | |
| *** xek has quit IRC | 07:22 | |
| *** yaawang has quit IRC | 07:22 | |
| *** tesseract has joined #openstack-nova | 07:23 | |
| *** dtantsur|afk is now known as dtantsur | 07:28 | |
| *** ccamacho has joined #openstack-nova | 07:29 | |
| *** vishalmanchanda has joined #openstack-nova | 07:31 | |
| *** links has quit IRC | 07:37 | |
| *** boxiang_ has quit IRC | 07:38 | |
| *** boxiang_ has joined #openstack-nova | 07:39 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:49 | |
| *** aarents has quit IRC | 07:50 | |
| *** aarents has joined #openstack-nova | 07:50 | |
| *** rcernin has quit IRC | 07:52 | |
| bauzas | good morning Nova | 07:53 |
|---|---|---|
| *** ttsiouts has quit IRC | 07:54 | |
| *** ttsiouts has joined #openstack-nova | 08:08 | |
| *** xek_ has quit IRC | 08:10 | |
| *** jawad_axd has joined #openstack-nova | 08:11 | |
| *** xek_ has joined #openstack-nova | 08:11 | |
| *** yaawang has joined #openstack-nova | 08:11 | |
| *** yaawang has quit IRC | 08:17 | |
| *** jawad_axd has quit IRC | 08:20 | |
| *** jawad_axd has joined #openstack-nova | 08:21 | |
| *** yaawang has joined #openstack-nova | 08:25 | |
| *** ratailor has quit IRC | 08:26 | |
| *** ratailor has joined #openstack-nova | 08:26 | |
| *** xek_ has quit IRC | 08:29 | |
| *** jawad_ax_ has joined #openstack-nova | 08:30 | |
| *** links has joined #openstack-nova | 08:32 | |
| *** ttsiouts has quit IRC | 08:34 | |
| *** jawad_axd has quit IRC | 08:35 | |
| *** tetsuro has quit IRC | 08:36 | |
| *** tetsuro has joined #openstack-nova | 08:37 | |
| gibi | bauzas: good morning | 08:37 |
| bauzas | gibi: any spec you'd like me to review ? | 08:37 |
| gibi | bauzas: let me check the list | 08:38 |
| *** brinzhang_ has joined #openstack-nova | 08:39 | |
| gibi | bauzas: I only see a spec update from dansmith https://review.opendev.org/#/c/728778/ | 08:41 |
| gibi | bauzas: sorry mixed up the link | 08:41 |
| gibi | bauzas: this is a spec update https://review.opendev.org/#/c/735192 | 08:42 |
| *** brinzhang0 has quit IRC | 08:42 | |
| gibi | bauzas: https://review.opendev.org/#/c/728778/ is a re-propose | 08:42 |
| bauzas | gibi: okay, I'll look | 08:43 |
| *** derekh has joined #openstack-nova | 08:44 | |
| *** avolkov has joined #openstack-nova | 08:44 | |
| gibi | thanks | 08:44 |
| *** ociuhandu has quit IRC | 08:46 | |
| *** tetsuro has quit IRC | 08:46 | |
| *** jawad_ax_ has quit IRC | 08:48 | |
| *** jawad_axd has joined #openstack-nova | 08:49 | |
| gibi | brinzhang_: did you hit the archiving case described in the comment https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L1499-L1500 ? | 08:49 |
| *** markvoelker has joined #openstack-nova | 08:51 | |
| *** songwenping__ has joined #openstack-nova | 08:53 | |
| *** martinkennelly has joined #openstack-nova | 08:55 | |
| *** markvoelker has quit IRC | 08:56 | |
| *** k_mouza has joined #openstack-nova | 08:58 | |
| *** ociuhandu has joined #openstack-nova | 09:00 | |
| brinzhang_ | gibi: yes | 09:03 |
| brinzhang_ | gibi: we meet the case that the RequestSpec data of instance isnot exist, but the allocations data still exist, maybe it is migration operation causes this scence, but i am not sure. | 09:04 |
| *** ociuhandu has quit IRC | 09:07 | |
| openstackgerrit | Merged openstack/nova-specs master: Support volume local cache https://review.opendev.org/728778 | 09:09 |
| *** tetsuro has joined #openstack-nova | 09:09 | |
| *** tetsuro has quit IRC | 09:09 | |
| *** ttsiouts has joined #openstack-nova | 09:12 | |
| gibi | brinzhang_: do you have a reproduction? if yes then please file a bug | 09:13 |
| brinzhang_ | gibi: I am sorry, I cannot provide exact steps :( | 09:15 |
| brinzhang_ | gibi: Can you think of the anomalies that will occur here? | 09:15 |
| brinzhang_ | whatever you can think | 09:15 |
| *** jangutter has joined #openstack-nova | 09:17 | |
| *** ttsiouts has quit IRC | 09:17 | |
| openstackgerrit | Merged openstack/nova-specs master: Update the testing section of the rbd-glance-multistore spec https://review.opendev.org/735192 | 09:17 |
| gibi | brinzhang_: so by the fact that not even the RequestSpec of the instance exists in the db you concluded that this instance was deleted + archived. | 09:19 |
| gibi | brinzhang_: if that the case then there is no way to check instance.state == BUILDING | 09:20 |
| *** jangutter has quit IRC | 09:20 | |
| gibi | brinzhang_: also you cannot simply check the existence of the RequestSpec from the compute as RequestSpec is in the api database | 09:22 |
| *** martinkennelly has quit IRC | 09:24 | |
| *** markvoelker has joined #openstack-nova | 09:24 | |
| brinzhang_ | gibi: I discussed it with my colleagues. In the following situation, the resource cannot be cleaned up: | 09:27 |
| brinzhang_ | Steps to reproduce: | 09:27 |
| brinzhang_ | 1. Failed to create instance A, instance A exist in cell0 | 09:28 |
| brinzhang_ | 2. Delete instance A, the placement API is abnormal and cannot synchronize resource information. RequestSPEC will store instance A resource allocation information | 09:28 |
| brinzhang_ | 3. Timed task update_available_resource() fails to synchronize resource occupancy to placement | 09:28 |
| *** markvoelker has quit IRC | 09:29 | |
| gibi | brinzhang_: i think what you need is "nova-manage placement audit | 09:30 |
| gibi | " | 09:30 |
| gibi | brinzhang_: and later on https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/nova-audit.html | 09:31 |
| gibi | when it is implemented | 09:31 |
| brinzhang_ | gibi: later I will review this spec | 09:34 |
| brinzhang_ | gibi: in Lin1487, we just get the instance from nova cell1 db, but cannot get from cell0(store the error instances) https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L1487 | 09:36 |
| gibi | I don't think you can talk to the cell0 db from a compute host | 09:37 |
| brinzhang_ | I know | 09:37 |
| gibi | but placement audit runs on the top therefore it can inspect every cell db | 09:37 |
| brinzhang_ | if so, I think it can resolve my question | 09:38 |
| *** Liang__ has quit IRC | 09:40 | |
| *** ttsiouts has joined #openstack-nova | 09:44 | |
| *** jawad_axd has quit IRC | 09:45 | |
| *** ttsiouts has quit IRC | 09:49 | |
| *** ttsiouts has joined #openstack-nova | 09:49 | |
| *** jawad_axd has joined #openstack-nova | 09:49 | |
| *** ociuhandu has joined #openstack-nova | 09:54 | |
| *** hoonetorg has quit IRC | 10:01 | |
| *** ociuhandu has quit IRC | 10:02 | |
| *** tkajinam has quit IRC | 10:05 | |
| *** jawad_axd has quit IRC | 10:06 | |
| *** slaweq_ has joined #openstack-nova | 10:06 | |
| *** slaweq has quit IRC | 10:09 | |
| *** ratailor_ has joined #openstack-nova | 10:09 | |
| *** ttsiouts has quit IRC | 10:11 | |
| *** ratailor has quit IRC | 10:12 | |
| *** ratailor_ has quit IRC | 10:13 | |
| *** ratailor has joined #openstack-nova | 10:13 | |
| *** slaweq_ is now known as slaweq | 10:20 | |
| *** ttsiouts has joined #openstack-nova | 10:20 | |
| *** rpittau is now known as rpittau|bbl | 10:21 | |
| *** martinkennelly has joined #openstack-nova | 10:45 | |
| *** sean-k-mooney has joined #openstack-nova | 10:52 | |
| *** tosky has joined #openstack-nova | 10:57 | |
| *** udesale has quit IRC | 11:02 | |
| openstackgerrit | Merged openstack/nova stable/stein: Make greande jobs n-v for EM and oldest stable https://review.opendev.org/737332 | 11:02 |
| *** udesale has joined #openstack-nova | 11:02 | |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware: Handle exception in destroy with attached volumes https://review.opendev.org/738416 | 11:05 |
| *** belmoreira has joined #openstack-nova | 11:27 | |
| *** hoonetorg has joined #openstack-nova | 11:37 | |
| *** ttsiouts has quit IRC | 11:41 | |
| *** raildo has joined #openstack-nova | 11:46 | |
| *** ttsiouts has joined #openstack-nova | 11:47 | |
| openstackgerrit | Wenping Song proposed openstack/nova master: Add instance project_id for cyborg arq https://review.opendev.org/738428 | 12:00 |
| *** rpittau|bbl is now known as rpittau | 12:00 | |
| *** ratailor has quit IRC | 12:02 | |
| *** ratailor has joined #openstack-nova | 12:02 | |
| *** ratailor has quit IRC | 12:08 | |
| *** ianw is now known as ianw_pto | 12:13 | |
| *** udesale_ has joined #openstack-nova | 12:20 | |
| *** udesale has quit IRC | 12:22 | |
| *** xek has joined #openstack-nova | 12:25 | |
| *** derekh has quit IRC | 12:25 | |
| *** ociuhandu has joined #openstack-nova | 12:29 | |
| openstackgerrit | renminmin proposed openstack/nova master: SRIOV: Fix instance with macvtap port live migration failed https://review.opendev.org/738432 | 12:37 |
| *** xek has quit IRC | 12:37 | |
| *** belmoreira has quit IRC | 12:39 | |
| *** lbragstad has joined #openstack-nova | 12:45 | |
| *** derekh has joined #openstack-nova | 12:46 | |
| *** mgariepy has joined #openstack-nova | 12:51 | |
| *** mgariepy has quit IRC | 12:55 | |
| *** nweinber has joined #openstack-nova | 12:55 | |
| *** mgariepy has joined #openstack-nova | 12:55 | |
| *** k_mouza has quit IRC | 13:01 | |
| *** k_mouza has joined #openstack-nova | 13:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | 13:06 |
| *** jangutter has joined #openstack-nova | 13:07 | |
| *** dcapone2004 has quit IRC | 13:09 | |
| stephenfin | gibi: I've reproposed the use-pcpu-and-vcpu-in-one-instance BP work for a runway. What was approved has merged (thanks for the reviews!), and now there are four patches at the top good to go and huaquiang is reworking the remainder at the moment | 13:13 |
| stephenfin | Will ping alex_xu when he's around and ask for reviews | 13:14 |
| gibi | stephenfin: cool | 13:14 |
| gibi | stephenfin: I will move it to the last slot then | 13:14 |
| stephenfin | \o/ | 13:14 |
| *** eharney has joined #openstack-nova | 13:15 | |
| stephenfin | Also, I took a look through Gerrit on Friday trying to find more stuff to add. No luck. melwitt and johnthetubaguy both have stuff that could conceivably go in (nova-audit and oslo.limit integration, respectively) but they both have open comments :( | 13:15 |
| * johnthetubaguy I should look at those | 13:16 | |
| johnthetubaguy | snowed under at the moment sadly | 13:16 |
| stephenfin | johnthetubaguy: I'll review if/when you do | 13:16 |
| stephenfin | The provider.yaml file work looks stalled as well :( | 13:16 |
| gibi | stephenfin: thanks for looking. | 13:17 |
| johnthetubaguy | stephenfin: thanks, I will try get to that ASAP | 13:17 |
| gibi | yeah I noticed that provider.yaml is stopped | 13:17 |
| gibi | stephenfin: what is the resolution of https://review.opendev.org/#/c/737026/2/nova/virt/hardware.py@1708 ? | 13:17 |
| johnthetubaguy | I wanted to reboot that, but right now don't have bandwidth | 13:17 |
| johnthetubaguy | (on the OpenDev call into) | 13:17 |
| stephenfin | I mean, I could take it over but I don't know who'll be available to review. I've already got the vTPM stuff and mixed CPU types work against me too | 13:19 |
| stephenfin | gibi: Oh, I've a patch for that somewhere. Let me try find it | 13:19 |
| stephenfin | gibi: nvm, pushed it. https://review.opendev.org/#/c/737026/3/nova/virt/libvirt/driver.py | 13:19 |
| gibi | stephenfin: thanks, will look | 13:20 |
| stephenfin | gibi: Sweet. Last thing, it's not ready but I've started work on adding type hints for objects. It's kind of ugly and will probably need a mypy plugin to make it not ugly, but it should fix the gap you were seeing with types not being checked for stuff from nova.objects https://review.opendev.org/#/c/738020/2 | 13:23 |
| stephenfin | To be clear, obviously not ready for review yet | 13:23 |
| gibi | stephenfin: interesting. so basically that mypy plugin could look at the ovo field declaration directly and generate the type hints on the fly for ovos | 13:24 |
| stephenfin | gibi: Yup. It seems that's what they do for Django, which has similar magic behavior for things like models https://github.com/typeddjango/django-stubs/tree/master/mypy_django_plugin | 13:25 |
| stephenfin | I just need to figure out how mypy works internally first :( | 13:26 |
| gibi | just opened the code of that plugin and got scared by the internals :) | 13:27 |
| gibi | this feel heavy lifting for me right now | 13:27 |
| stephenfin | Yeah, it's pretty low priority. If I can get the ugly but effective thing working for now, I'll do that | 13:28 |
| stephenfin | and if I did a plugin working, it would live in o.vo itself so nothing you'd have to review | 13:29 |
| gibi | don't misunderstand me I'm happy to indulge into mypy I just need some pre-learning first. so it is scary now as it is unknown | 13:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend is_ipv6_supported() to cover more error cases https://review.opendev.org/736167 | 13:31 |
| gibi | stephenfin: btw, fixed up ^^ | 13:31 |
| * stephenfin looks | 13:31 | |
| gibi | stephenfin: thanks | 13:37 |
| sean-k-mooney | gibi: when you say the provider.yaml stuff has stalled to you mean the code or the reivew | 13:40 |
| stephenfin | sean-k-mooney: the code | 13:40 |
| stephenfin | sean-k-mooney: https://review.opendev.org/#/c/673341/ | 13:40 |
| sean-k-mooney | ah ok well i guess i could looks tat that again or we can figure something out | 13:40 |
| sean-k-mooney | were there pending change sstill need after v47 | 13:41 |
| stephenfin | I don't see anything, but I haven't been involved until now | 13:42 |
| sean-k-mooney | if more changes can be done via followups i would personally prefer to start merging the code and adress it that way gibi johnthetubaguy how would you feel about that | 13:43 |
| sean-k-mooney | i think the code was perfectly resonable to merge even at the end of last cycle but im sure we can still tighten the schema definitions and testing | 13:43 |
| sean-k-mooney | i just dont want perfect to be the enemy of good enough and delay this again | 13:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | 13:44 |
| *** masterpe has quit IRC | 13:46 | |
| stephenfin | dansmith: Can you look at https://review.opendev.org/#/c/683043/ again today? | 13:49 |
| gibi | sean-k-mooney: I have to re-review the patch to see if everything is resolved or not | 13:50 |
| gibi | sean-k-mooney: restricting the schema later is a backward incompatible change which would be expensive so I'm on the side to do something that is pretty solid | 13:51 |
| gibi | it is like an API | 13:51 |
| sean-k-mooney | sure but until we have a release with this im not sure we need to be as strict | 13:52 |
| sean-k-mooney | e.g. we coudl treat the scema as a 0.X and then bump to 1.0 when we are happy and release with that | 13:52 |
| gibi | sean-k-mooney: 0.x could work, indicating that it is beta and can change in a backward incompatible way | 13:53 |
| dansmith | stephenfin: I just glanced at it and he didn't do what I prescribed (you said he did), but I haven't looked closely at why he thinks that will work | 13:53 |
| dansmith | just FYI in case you didn't examine it closely | 13:54 |
| stephenfin | You'd suggested calling '_save_extra_generic' and 'self.obj_reset_changes' from '_save_keypairs', and he's just put 'self.obj_reset_changes' into '_save_extra_generic'. That looked functionally equivalent to me | 13:55 |
| dansmith | but keypairs isn't an extra field | 13:57 |
| dansmith | I said | 13:57 |
| dansmith | "the generic save handler" but "save_extra_generic" is specifically for fields in instance_extra, which I think keypairs is not in, no? | 13:58 |
| dansmith | or maybe I'm confusing keypairS with keypair | 13:58 |
| stephenfin | I think it is | 13:59 |
| stephenfin | Yeah, it's part of _INSTANCE_EXTRA_FIELDS | 13:59 |
| dansmith | right, okay.. Instance has its own (key_name, key_data) from when we could only have one | 14:01 |
| stephenfin | TIL (that those fields existed) | 14:02 |
| stephenfin | anyway, since it's in _INSTANCE_EXTRA_FIELDS we'll trigger the correct code path https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L788-L790 | 14:02 |
| dansmith | aye | 14:03 |
| stephenfin | and calling 'self.obj_reset_changes' on a nested object field would presumably always be the correct thing to do in that path | 14:03 |
| *** xek has joined #openstack-nova | 14:04 | |
| dansmith | I'm not sure about that, I need to check something.. because there are cases where we do and don't delegate that to sub-objects | 14:04 |
| dansmith | since originally all sub-objects would have their own save handler, | 14:05 |
| dansmith | we initially (at least) didn't reset through like that | 14:05 |
| *** masterpe has joined #openstack-nova | 14:05 | |
| dansmith | I'mma pull it down and look | 14:05 |
| dansmith | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L629 | 14:06 |
| dansmith | that's why we have recursive= | 14:06 |
| dansmith | heh, he makes fake_instance() do recursive=True | 14:07 |
| *** dave-mccowan has joined #openstack-nova | 14:09 | |
| *** dklyle has joined #openstack-nova | 14:11 | |
| stephenfin | so instead of https://review.opendev.org/#/c/683043/15/nova/tests/unit/fake_instance.py@143 we could have kept that as-is, and added 'inst.keypairs.obj_reset_changes()' | 14:15 |
| stephenfin | any reason that would be preferable, given "there are cases where we do and don't delegate that to sub-objects" | 14:15 |
| stephenfin | ? | 14:15 |
| dansmith | I dunno, yet, I'm poking.. | 14:16 |
| stephenfin | ack | 14:16 |
| dansmith | aren't you a typing pedant such that assertFalse(len(of thing)) feels wrong to you? | 14:16 |
| stephenfin | Yeah /o\ I considered changing it when rebasing and decided not to for some reason. Happy to change if it's not just me | 14:17 |
| dansmith | I stared at "false is not 4" for a few moments when I broke the test on purpose... :) | 14:18 |
| stephenfin | bauzas: Mentioned this Friday but it was a bit late. Care to take a look at https://review.opendev.org/#/c/706013/ when you've time? | 14:19 |
| bauzas | stephenfin: sure I can try | 14:20 |
| *** mriedem has joined #openstack-nova | 14:22 | |
| bauzas | stephenfin: humpf, I think you can't do this https://review.opendev.org/#/c/706013/6/nova/objects/migration.py | 14:22 |
| bauzas | dansmith: ^ | 14:22 |
| bauzas | stephenfin: if you want to change an object field, you can't just change its type directly | 14:22 |
| bauzas | you need to provide another field and, | 14:23 |
| stephenfin | bauzas: dansmith looked at it in the past. It's kosher. The serialized objects look identical, and the validation works as it did | 14:23 |
| bauzas | you need to depracate the other | 14:23 |
| bauzas | deprecate* | 14:23 |
| bauzas | hmmm, ok | 14:23 |
| stephenfin | There would be an issue if I was changing from e.g. StringField to ObjectField or IntegerField, but MigrationTypeField is an EnumField | 14:24 |
| dansmith | bauzas: I haven't looked at what he's offering, but in the past, if we've converted the field type from string to enum and the enum has every possible historical value in it, we've allowed it | 14:25 |
| dansmith | i.e. as long as it won't break existing clients.. the field type doesn't go over the wire, just the assumption that it's de-serializable by the type on the remote side | 14:25 |
| bauzas | well, now I understand | 14:25 |
| bauzas | yeah, stephenfin explained it | 14:25 |
| dansmith | bauzas: I know, but if you're me you wouldn't take stephenfin's word for it, so.. :D | 14:26 |
| dansmith | hence, I assume, the name drop above | 14:26 |
| bauzas | because when deserializing the new object, then the old compute could still be able to create its object | 14:26 |
| * stephenfin feigns shock | 14:26 | |
| bauzas | dansmith: haha | 14:26 |
| dansmith | bauzas: yeah | 14:26 |
| stephenfin | dansmith: correct. Validation through association | 14:26 |
| bauzas | okay, I'll provide a comment then | 14:27 |
| dansmith | bauzas: I think we've done worse things than string->enum even :) | 14:27 |
| bauzas | just to make sure people understand why I'm accepting it | 14:27 |
| dansmith | does it have a code comment about the type changin? | 14:27 |
| dansmith | if not, you could/should -1 probably and demand it | 14:27 |
| dansmith | just so people know that older clients could be less strict | 14:27 |
| stephenfin | The type isn't changing | 14:28 |
| dansmith | it's going from string to enum right? | 14:28 |
| stephenfin | Nope. It was an EnumField with 4 allowed values. It's still an EnumField with four values | 14:28 |
| stephenfin | https://review.opendev.org/#/c/706013/6/nova/objects/migration.py | 14:28 |
| stephenfin | I've just making it a custom enum field so I have constants I can reference | 14:29 |
| dansmith | oh, even less of a thing then, nevermind | 14:29 |
| dansmith | yeah that's definitely not visible to RPC, so whatever | 14:29 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Guard against missing image cache directory https://review.opendev.org/738455 | 14:30 |
| bauzas | stephenfin: dansmith: yeah, it's just changing the EnumField to be a specific one | 14:31 |
| bauzas | but, tbc, I don't want to see other changes just changing types without thinking about this | 14:31 |
| bauzas | stephenfin: fwiw, I'd also have loved if you could have cut this change in two and not adding two properties as well in the same | 14:32 |
| bauzas | given this wasn't needed | 14:32 |
| stephenfin | It wouldn't really help though | 14:33 |
| bauzas | anyway, reviewing it | 14:33 |
| *** mgariepy has quit IRC | 14:33 | |
| stephenfin | You'd save about four lines in the first patch (the properties), and then you'd have to review a second patch that's reworks virtually everything you changed in the first one | 14:33 |
| *** boxiang_ has quit IRC | 14:36 | |
| *** boxiang has joined #openstack-nova | 14:36 | |
| *** mgariepy has joined #openstack-nova | 14:47 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Test the state of VMware NSX 3pp CI https://review.opendev.org/734114 | 14:54 |
| *** _mlavalle_1 has joined #openstack-nova | 14:55 | |
| *** mlavalle has quit IRC | 14:58 | |
| *** ttsiouts has quit IRC | 14:58 | |
| *** ttsiouts has joined #openstack-nova | 14:59 | |
| *** ttsiouts has quit IRC | 15:03 | |
| *** gyee has joined #openstack-nova | 15:03 | |
| *** boxiang has quit IRC | 15:04 | |
| *** boxiang has joined #openstack-nova | 15:05 | |
| *** psachin has quit IRC | 15:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Guard against missing image cache directory https://review.opendev.org/738455 | 15:17 |
| *** rouk has joined #openstack-nova | 15:21 | |
| *** xek has quit IRC | 15:27 | |
| *** ociuhandu has quit IRC | 15:39 | |
| *** xek has joined #openstack-nova | 15:41 | |
| *** nweinber_ has joined #openstack-nova | 15:49 | |
| *** nweinber has quit IRC | 15:51 | |
| *** priteau has joined #openstack-nova | 15:54 | |
| *** ociuhandu has joined #openstack-nova | 15:59 | |
| *** nweinber_ has quit IRC | 16:02 | |
| *** nweinber_ has joined #openstack-nova | 16:02 | |
| *** ociuhandu has quit IRC | 16:03 | |
| *** _mlavalle_1 has quit IRC | 16:05 | |
| *** xek has quit IRC | 16:09 | |
| *** xek has joined #openstack-nova | 16:09 | |
| *** vishalmanchanda has quit IRC | 16:17 | |
| *** k_mouza has quit IRC | 16:19 | |
| *** xek has quit IRC | 16:19 | |
| *** k_mouza has joined #openstack-nova | 16:23 | |
| *** udesale_ has quit IRC | 16:23 | |
| *** hamalq has joined #openstack-nova | 16:24 | |
| *** mlavalle has joined #openstack-nova | 16:25 | |
| *** k_mouza has quit IRC | 16:27 | |
| *** mlavalle has quit IRC | 16:30 | |
| *** mlavalle has joined #openstack-nova | 16:35 | |
| *** _mlavalle_1 has joined #openstack-nova | 16:36 | |
| *** _mlavalle_1 has quit IRC | 16:36 | |
| *** priteau has quit IRC | 16:38 | |
| *** mlavalle has quit IRC | 16:40 | |
| *** priteau has joined #openstack-nova | 16:49 | |
| *** derekh has quit IRC | 17:03 | |
| *** nightmare_unreal has quit IRC | 17:03 | |
| *** priteau has quit IRC | 17:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Warn at controller start if there are older than N-1 computes https://review.opendev.org/738482 | 17:21 |
| *** ccamacho has quit IRC | 17:26 | |
| *** nweinber__ has joined #openstack-nova | 17:27 | |
| *** nweinber_ has quit IRC | 17:29 | |
| *** ccamacho has joined #openstack-nova | 17:34 | |
| *** lbragstad_ has joined #openstack-nova | 17:37 | |
| openstackgerrit | Merged openstack/nova master: objects: Add MigrationTypeField https://review.opendev.org/706013 | 17:38 |
| *** lbragstad has quit IRC | 17:40 | |
| *** nweinber_ has joined #openstack-nova | 17:41 | |
| *** nweinber__ has quit IRC | 17:42 | |
| *** boxiang has quit IRC | 17:46 | |
| *** nweinber_ has quit IRC | 17:46 | |
| *** nweinber has joined #openstack-nova | 17:47 | |
| *** links has quit IRC | 17:50 | |
| *** dtantsur is now known as dtantsur|afk | 17:51 | |
| *** nweinber_ has joined #openstack-nova | 17:55 | |
| *** nweinber has quit IRC | 17:57 | |
| *** ralonsoh has quit IRC | 17:58 | |
| *** maciejjozefczyk has quit IRC | 18:39 | |
| *** maciejjozefczyk has joined #openstack-nova | 18:52 | |
| *** maciejjozefczyk has quit IRC | 19:27 | |
| *** priteau has joined #openstack-nova | 19:57 | |
| *** hoonetorg has quit IRC | 19:58 | |
| *** hoonetorg has joined #openstack-nova | 20:12 | |
| *** ociuhandu has joined #openstack-nova | 20:30 | |
| *** nweinber_ has quit IRC | 20:30 | |
| *** nweinber has joined #openstack-nova | 20:36 | |
| *** tobiash has quit IRC | 20:51 | |
| *** tobiash has joined #openstack-nova | 20:51 | |
| *** nweinber has quit IRC | 21:03 | |
| *** tesseract has quit IRC | 21:04 | |
| *** priteau has quit IRC | 21:09 | |
| *** raildo has quit IRC | 21:16 | |
| *** markvoelker has joined #openstack-nova | 21:25 | |
| *** rchurch has joined #openstack-nova | 21:28 | |
| *** markvoelker has quit IRC | 21:30 | |
| *** slaweq has quit IRC | 21:33 | |
| *** slaweq has joined #openstack-nova | 21:42 | |
| *** slaweq has quit IRC | 21:46 | |
| *** mriedem has left #openstack-nova | 21:54 | |
| *** markvoelker has joined #openstack-nova | 21:58 | |
| *** markvoelker has quit IRC | 21:58 | |
| *** whoami-rajat has quit IRC | 22:04 | |
| *** luksky has quit IRC | 22:05 | |
| *** whoami-rajat has joined #openstack-nova | 22:07 | |
| *** rcernin has joined #openstack-nova | 22:18 | |
| *** rcernin has quit IRC | 22:19 | |
| *** rcernin has joined #openstack-nova | 22:19 | |
| *** ircuser-1 has joined #openstack-nova | 22:39 | |
| *** tosky has quit IRC | 22:46 | |
| *** tkajinam has joined #openstack-nova | 22:47 | |
| *** martinkennelly has quit IRC | 23:27 | |
| *** avolkov has quit IRC | 23:54 | |
| *** markvoelker has joined #openstack-nova | 23:57 | |
| *** ociuhandu has quit IRC | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!