Friday, 2020-06-19

*** mlavalle has quit IRC00:15
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916300:29
*** dolpher has joined #openstack-nova00:50
*** spatel has joined #openstack-nova00:57
*** tbachman_ has joined #openstack-nova01:04
*** tbachman has quit IRC01:05
*** tbachman_ is now known as tbachman01:05
*** tbachman_ has joined #openstack-nova01:11
*** tbachman has quit IRC01:12
*** tbachman_ is now known as tbachman01:12
*** dlbewley has quit IRC01:18
*** dlbewley has joined #openstack-nova01:18
*** factor__ has quit IRC01:53
*** factor__ has joined #openstack-nova01:53
*** gyee has quit IRC01:58
*** mriedem has quit IRC02:00
*** factor__ has quit IRC02:02
*** rcernin has quit IRC02:12
*** mkrai has joined #openstack-nova02:28
*** dlbewley has quit IRC02:28
*** dlbewley has joined #openstack-nova02:28
*** dlbewley has quit IRC02:38
*** dlbewley has joined #openstack-nova02:39
*** lbragstad has quit IRC03:00
*** yaawang_ has quit IRC03:08
*** yaawang_ has joined #openstack-nova03:09
*** tetsuro has quit IRC03:11
*** rcernin has joined #openstack-nova03:17
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916303:21
*** psachin has joined #openstack-nova03:29
*** Liang__ has joined #openstack-nova03:30
*** tetsuro has joined #openstack-nova03:45
*** dlbewley has quit IRC03:51
*** dlbewley has joined #openstack-nova03:52
*** mkrai has quit IRC04:11
*** dlbewley has quit IRC04:11
*** mkrai_ has joined #openstack-nova04:11
*** dlbewley has joined #openstack-nova04:12
*** markvoelker has joined #openstack-nova04:24
*** markvoelker has quit IRC04:29
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** arjunbaindur has joined #openstack-nova04:36
arjunbaindurhey, have a question about configuring PCI passthrough. We have a device that has 2 functions. On the hypervisor, the PCI address has it on same bus and same slot. When it shows up inside the VM, the PCI address has it under different slots04:38
arjunbaindurfor example, suppose device has two functions at 83:00.0 and 83:00.104:39
arjunbaindurUnder the VM, the devices show up under different slots, for example 0:5.0 and 0:6.004:40
arjunbaindurany idea why?04:40
*** vishalmanchanda has joined #openstack-nova04:40
*** markvoelker has joined #openstack-nova05:09
*** markvoelker has quit IRC05:14
*** links has joined #openstack-nova05:16
*** udesale has joined #openstack-nova05:34
*** links has quit IRC05:42
*** links has joined #openstack-nova05:43
*** yaawang_ has quit IRC05:52
*** spatel has quit IRC05:59
*** dklyle has quit IRC06:01
*** dlbewley has quit IRC06:06
*** dlbewley has joined #openstack-nova06:06
*** ratailor has joined #openstack-nova06:08
*** ratailor has quit IRC06:22
openstackgerritWenping Song proposed openstack/nova master: Delete sub resource provider when delete resource provider  https://review.opendev.org/71916306:29
*** tosky has joined #openstack-nova06:30
*** ratailor has joined #openstack-nova06:30
*** tetsuro has quit IRC06:32
*** tetsuro has joined #openstack-nova06:40
*** rpittau|afk is now known as rpittau06:44
*** links has quit IRC06:46
*** belmoreira has joined #openstack-nova06:52
*** slaweq has joined #openstack-nova07:00
*** links has joined #openstack-nova07:01
*** ircuser-1 has quit IRC07:06
*** markvoelker has joined #openstack-nova07:10
*** markvoelker has quit IRC07:15
*** ttsiouts has joined #openstack-nova07:15
*** ttsiouts_ has joined #openstack-nova07:17
*** dtantsur|afk is now known as dtantsur07:17
*** tesseract has joined #openstack-nova07:17
*** dlbewley has quit IRC07:17
*** dlbewley has joined #openstack-nova07:18
*** ttsiouts_ has quit IRC07:20
*** ttsiouts has quit IRC07:21
*** ttsiouts has joined #openstack-nova07:21
*** tetsuro has quit IRC07:24
*** ttsiouts has quit IRC07:26
*** ttsiouts has joined #openstack-nova07:27
*** damien_r has joined #openstack-nova07:31
*** damien_r has quit IRC07:36
*** damien_r has joined #openstack-nova07:36
*** links has quit IRC07:37
*** ralonsoh has joined #openstack-nova07:38
*** bhagyashris|away is now known as bhagyashris07:39
*** damien_r has quit IRC07:42
*** damien_r has joined #openstack-nova07:42
*** damien_r has quit IRC07:42
*** damien_r has joined #openstack-nova07:42
*** yaawang has joined #openstack-nova07:45
*** damien_r has quit IRC07:46
*** damien_r has joined #openstack-nova07:50
*** rcernin has quit IRC07:59
*** maciejjozefczyk_ has joined #openstack-nova08:14
*** maciejjozefczyk has quit IRC08:18
*** sapd1 has joined #openstack-nova08:20
*** mkrai_ has quit IRC08:23
*** mkrai has joined #openstack-nova08:24
*** salmankhan has joined #openstack-nova08:32
*** markvoelker has joined #openstack-nova08:34
*** salmankhan has quit IRC08:36
*** salmankhan has joined #openstack-nova08:36
*** ttsiouts has quit IRC08:38
*** markvoelker has quit IRC08:39
*** links has joined #openstack-nova08:40
openstackgerritStephen Finucane proposed openstack/nova stable/ussuri: libvirt: Mark e1000e VIF as supported  https://review.opendev.org/73695708:45
*** mugsie has quit IRC08:48
*** mugsie has joined #openstack-nova08:48
openstackgerritStephen Finucane proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported  https://review.opendev.org/73696208:51
*** martinkennelly has joined #openstack-nova08:52
*** rcernin has joined #openstack-nova08:54
*** ttsiouts has joined #openstack-nova08:54
gibiaarents: there is a bug in the image cache disk reservation patch. https://bugs.launchpad.net/nova/+bug/188421408:59
openstackLaunchpad bug 1884214 in OpenStack Compute (nova) "reserve disk usage for image cache fails on a fresh hypervisor" [Medium,Confirmed] - Assigned to Balazs Gibizer (balazs-gibizer)08:59
*** rcernin has quit IRC09:01
*** links has quit IRC09:01
*** links has joined #openstack-nova09:04
gibiaarents: I will push a fix soon09:04
*** huaqiang has quit IRC09:12
*** huaqiang has joined #openstack-nova09:18
aarentsgibi: I saw that, thank you,  I was wondering if nova create _base directory only when needed at first cache() but I did not check09:21
*** tkajinam has quit IRC09:21
*** rcernin has joined #openstack-nova09:23
*** huaqiang has quit IRC09:25
*** xek has joined #openstack-nova09:27
gibiaarents: yeah I also missed that case09:29
*** priteau has joined #openstack-nova09:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Guard against missing image cache directory  https://review.opendev.org/73696409:37
gibiaarents: ^^09:39
aarentsgibi: checking09:41
*** huaqiang has joined #openstack-nova09:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Guard against missing image cache directory  https://review.opendev.org/73696409:54
*** rcernin has quit IRC09:58
*** huaqiang has quit IRC10:08
*** huaqiang has joined #openstack-nova10:09
*** maciejjozefczyk_ is now known as maciejjozefczyk10:13
*** dlbewley has quit IRC10:18
*** dlbewley has joined #openstack-nova10:18
*** brinzhang has quit IRC10:21
*** rpittau is now known as rpittau|bbl10:22
*** Liang__ has quit IRC10:24
*** mkrai has quit IRC10:36
*** dlbewley has quit IRC10:37
*** dlbewley has joined #openstack-nova10:38
*** markvoelker has joined #openstack-nova10:44
*** markvoelker has quit IRC10:49
*** rcernin has joined #openstack-nova10:54
*** rcernin has quit IRC11:08
*** ratailor has quit IRC11:09
*** dlbewley has quit IRC11:12
*** dlbewley has joined #openstack-nova11:13
*** dlbewley has quit IRC11:22
*** dlbewley has joined #openstack-nova11:23
*** mkrai has joined #openstack-nova11:29
*** martinkennelly has quit IRC11:30
openstackgerritWenping Song proposed openstack/nova master: Delete resource provider in tree by top-down traversable order  https://review.opendev.org/71916311:30
*** martinkennelly has joined #openstack-nova11:30
*** dlbewley has quit IRC11:32
*** links has quit IRC11:32
*** dlbewley has joined #openstack-nova11:33
songwenping_Hi, gibi. Pls review my latest commit for the patch:https://review.opendev.org/71916311:34
*** derekh has joined #openstack-nova11:36
*** raildo has joined #openstack-nova11:50
*** rcernin has joined #openstack-nova11:53
gibisongwenping_: I will try to look at it next week11:55
songwenping_OK. Thanks.11:56
*** boxiang has joined #openstack-nova12:01
*** boxiang_ has quit IRC12:02
*** ociuhandu has quit IRC12:03
*** tkajinam has joined #openstack-nova12:04
*** ttsiouts has quit IRC12:04
*** mkrai has quit IRC12:06
*** rcernin has quit IRC12:06
*** ttsiouts has joined #openstack-nova12:13
*** rpittau|bbl is now known as rpittau12:19
*** lbragstad has joined #openstack-nova12:19
*** ociuhandu has joined #openstack-nova12:31
*** derekh has quit IRC12:33
*** markvoelker has joined #openstack-nova12:39
*** sangeet has joined #openstack-nova12:41
*** nweinber has joined #openstack-nova12:43
*** udesale_ has joined #openstack-nova12:44
*** udesale has quit IRC12:46
*** huaqiang has quit IRC12:47
*** spatel has joined #openstack-nova12:48
*** huaqiang has joined #openstack-nova12:48
*** derekh has joined #openstack-nova12:51
*** spatel has quit IRC12:53
*** markvoelker has quit IRC12:55
*** dlbewley has quit IRC13:01
*** dlbewley has joined #openstack-nova13:01
openstackgerritHuaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance  https://review.opendev.org/73699713:05
*** dtantsur is now known as dtantsur|brb13:11
*** mriedem has joined #openstack-nova13:14
*** huaqiang has quit IRC13:31
*** huaqiang has joined #openstack-nova13:31
sangeetefried .. if the put cafile only in identity, compute fail to find it.13:31
*** ttsiouts has quit IRC13:33
*** ttsiouts has joined #openstack-nova13:36
stephenfinhuaqiang: I'm about to push up a rebase of the bp/use-pcpu-and-vcpu-in-one-instance series to address comments on the bottom 10 or so patches. Is that okay with you?13:38
*** eharney has joined #openstack-nova13:38
*** rpittau is now known as rpittau|brb13:54
*** mlavalle has joined #openstack-nova13:54
*** rpittau|brb is now known as rpittau|afk14:00
*** psachin has quit IRC14:01
*** tbachman has quit IRC14:02
*** dlbewley has quit IRC14:05
*** dlbewley has joined #openstack-nova14:05
*** ociuhandu has quit IRC14:07
*** tosky has quit IRC14:08
*** martinkennelly has quit IRC14:11
*** martinkennelly has joined #openstack-nova14:11
*** ociuhandu has joined #openstack-nova14:12
*** martinkennelly has quit IRC14:13
*** tkajinam has quit IRC14:13
*** martinkennelly has joined #openstack-nova14:20
*** KeithMnemonic has joined #openstack-nova14:23
*** martinkennelly has quit IRC14:24
*** martinkennelly has joined #openstack-nova14:24
efriedsangeet: ack.14:25
*** martinkennelly has quit IRC14:26
dansmithgibi: wanna circle back on these? just made some minor changes for melwitt: https://review.opendev.org/#/c/731550/414:27
*** dtantsur|brb is now known as dtantsur14:28
*** rchurch has quit IRC14:29
*** rchurch has joined #openstack-nova14:32
*** tbachman has joined #openstack-nova14:37
dansmithstephenfin: thoughts on this? https://review.opendev.org/#/c/736964/2/nova/virt/libvirt/imagecache.py14:39
dansmithI know it's kinda minor, but...14:39
stephenfindansmith: makes sense to me14:40
*** dlbewley has quit IRC14:40
dansmithstephenfin: okay if gibi doesn't show up here soon to object I'll just fix it for him and we can push that in14:40
*** dlbewley has joined #openstack-nova14:41
*** dklyle has joined #openstack-nova14:46
*** ccamacho has quit IRC14:48
*** ttsiouts has quit IRC14:55
*** bbowen has quit IRC14:58
*** bbowen has joined #openstack-nova14:58
openstackgerritDan Smith proposed openstack/nova master: WIP: Add libvirt RBD configuration doc  https://review.opendev.org/73157715:00
openstackgerritDan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job  https://review.opendev.org/73418415:00
*** bbowen has quit IRC15:03
*** jdillaman has joined #openstack-nova15:05
*** amodi has joined #openstack-nova15:05
huaqiangstephenfin: I am OK with your rebase. Go ahead.15:10
stephenfinsweet, thanks15:10
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Update and correct typing information  https://review.opendev.org/71469415:11
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Add typing information  https://review.opendev.org/71469515:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask'  https://review.opendev.org/46820315:11
openstackgerritStephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests  https://review.opendev.org/71469615:11
openstackgerritStephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper  https://review.opendev.org/71469715:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances  https://review.opendev.org/71469815:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes  https://review.opendev.org/71469915:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint'  https://review.opendev.org/71470015:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly  https://review.opendev.org/46145615:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation  https://review.opendev.org/71470115:11
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning'  https://review.opendev.org/71470315:11
openstackgerritStephen Finucane proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell  https://review.opendev.org/71465815:11
openstackgerritStephen Finucane proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload  https://review.opendev.org/72848015:11
openstackgerritStephen Finucane proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum  https://review.opendev.org/71626715:11
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: apply mixed instance CPU policy  https://review.opendev.org/72848115:11
openstackgerritStephen Finucane proposed openstack/nova master: Validate CPU pinning configuration for mixed instance  https://review.opendev.org/71626815:11
openstackgerritStephen Finucane proposed openstack/nova master: Calculate the CPU usage for mixed instance  https://review.opendev.org/71626915:11
openstackgerritStephen Finucane proposed openstack/nova master: online data migration for cpuset of dedicated instance  https://review.opendev.org/71849315:11
*** ociuhandu has quit IRC15:14
*** mlavalle has quit IRC15:21
*** mlavalle has joined #openstack-nova15:25
*** boxiang has quit IRC15:30
*** dlbewley has quit IRC15:32
*** rchurch has quit IRC15:32
*** dlbewley has joined #openstack-nova15:32
*** rchurch has joined #openstack-nova15:32
*** tbachman has quit IRC15:33
*** purplerbot has quit IRC15:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint'  https://review.opendev.org/71470015:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Allow 'hw:cpu_realtime_mask' to be omitted  https://review.opendev.org/73702615:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly  https://review.opendev.org/46145615:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation  https://review.opendev.org/71470115:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning'  https://review.opendev.org/71470315:35
*** masterpe has quit IRC15:35
openstackgerritStephen Finucane proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell  https://review.opendev.org/71465815:35
openstackgerritStephen Finucane proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload  https://review.opendev.org/72848015:35
openstackgerritStephen Finucane proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum  https://review.opendev.org/71626715:35
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: apply mixed instance CPU policy  https://review.opendev.org/72848115:35
openstackgerritStephen Finucane proposed openstack/nova master: Validate CPU pinning configuration for mixed instance  https://review.opendev.org/71626815:35
openstackgerritStephen Finucane proposed openstack/nova master: Calculate the CPU usage for mixed instance  https://review.opendev.org/71626915:35
openstackgerritStephen Finucane proposed openstack/nova master: online data migration for cpuset of dedicated instance  https://review.opendev.org/71849315:35
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: mixed instance CPU resource translating  https://review.opendev.org/72848215:35
openstackgerritStephen Finucane proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance  https://review.opendev.org/71470615:35
openstackgerritStephen Finucane proposed openstack/nova master: compute: bump nova-compute service version for mixed instance  https://review.opendev.org/71627115:35
openstackgerritStephen Finucane proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs  https://review.opendev.org/72848515:35
openstackgerritStephen Finucane proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints  https://review.opendev.org/71829415:35
openstackgerritStephen Finucane proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource  https://review.opendev.org/71335515:35
*** jmlowe has quit IRC15:45
*** dlbewley has quit IRC15:47
*** dlbewley has joined #openstack-nova15:48
*** hamalq has joined #openstack-nova15:49
*** tosky has joined #openstack-nova15:50
*** ttsiouts has joined #openstack-nova15:51
*** hamalq_ has joined #openstack-nova15:51
artomstephenfin, wait, are you proposing we *remove* the "must start with a ^" validation on the realtime mask?15:52
artomSo we call it a mask, except when the user doesn't feel like, and then it's not a mask?15:52
*** purplerbot has joined #openstack-nova15:52
artomI actually had no idea it was validated to start with ^ in 2.8615:52
stephenfinit's still a mask15:52
artomMy opinion would be to keep it, and make the dedicated mask the same15:52
stephenfinit's just not an exclusion mask15:53
stephenfinit behaves sanely with this change15:53
artomI've always understood mask to mean exclusion mask15:53
artomIn fact, "exclusion mask" would be a pleonasm in my book15:54
dansmithnot me15:54
*** hamalq has quit IRC15:54
stephenfinthat's not how taskset would work15:54
dansmithmask could be inclusion or inclusion to me15:54
dansmithahah15:54
dansmithinclusion or exclusion :)15:54
artomOK, I guess it's just me then, and I had it wrong?15:54
stephenfinbad artom15:55
artom*sigh* yeah15:55
dansmithselect()'s FDSET is an inclusion mask yeah?15:55
*** ttsiouts has quit IRC15:56
stephenfinoh, err, I think so?15:56
dansmithit is, the question mark was rhetorical :)15:57
stephenfinoh15:57
* stephenfin hasn't had to worry about that for a while15:57
artomdansmith, I'm trying to understand what you mean by reading `man 2 select`15:57
stephenfinwe'll come fish you out of that rabbit hole later15:57
artomThere's FD_SET(), but that's a macro15:57
dansmithartom: the readfds, for example is a pointer to a word, with bits set nonzero if the FD represented by that bit should be checked for readability15:58
artom(Also, `man 2 select` is the perfect title for a geek version of The Bachelorette)15:58
artomdansmith, there's nothing about masks in the readfds para...16:02
artomIt's a set of file descriptors16:02
dansmithartom: no, it's not, you're just not meant to know how it works under the covers16:02
dansmithFD_SET is just readfds|=(1 << fd)16:03
*** xek has quit IRC16:04
*** dtantsur is now known as dtantsur|afk16:13
*** tesseract has quit IRC16:17
*** dolpher has quit IRC16:18
*** dlbewley has quit IRC16:23
*** dlbewley has joined #openstack-nova16:24
*** udesale_ has quit IRC16:26
*** hamalq_ has quit IRC16:47
*** hamalq has joined #openstack-nova16:47
*** dlbewley has quit IRC16:53
*** dlbewley has joined #openstack-nova16:53
*** ChanServ has quit IRC16:59
*** derekh has quit IRC17:02
*** salmankhan has quit IRC17:05
openstackgerritStephen Finucane proposed openstack/nova master: Guard against missing image cache directory  https://review.opendev.org/73696417:05
stephenfindansmith: ^17:07
dansmithstephenfin: I think you got that logic wrong17:09
stephenfincrap17:09
dansmithif the directory does not exist, then True, else if it does, True if st_dev matches17:09
stephenfinAt first glance it reads correctly to me. Bear with me17:11
dansmithit's okay it's confusing, so make sure I'm right here17:11
dansmithif the directory does exist, then we need to check to see if the st_dev matches.. if the directory does not exist, then we return True because when we create it, it will be on the same device17:12
stephenfinright, yeah, makes sense17:12
stephenfinyay, Fridays17:12
stephenfinI'll respin again17:12
*** gmann is now known as gmann_afk17:13
openstackgerritStephen Finucane proposed openstack/nova master: Guard against missing image cache directory  https://review.opendev.org/73696417:18
*** efried has quit IRC17:19
dansmithstephenfin: got it17:23
stephenfinI've done enough on that so I'll defer to melwitt or someone to approve17:24
melwittyeah I'll review it17:24
dansmithack, I think that's a good idea17:25
*** ChanServ has joined #openstack-nova17:37
*** tepper.freenode.net sets mode: +o ChanServ17:37
*** mlavalle has quit IRC17:40
*** efried has joined #openstack-nova17:41
*** salmankhan has joined #openstack-nova17:43
melwittdansmith: added some comments, am I missing something? because to me it seems this is doing the opposite of what is wanted in the commit message https://review.opendev.org/73696417:47
melwittI see that you've said the first time an image is cached, the dir will be created, but update_provider_tree is a periodic task right? what will ensure the cache dir is created by the time we ask for get_disk_usage()?17:48
dansmithnothing will ensure that it's created17:49
dansmiththe bug is that if it's not created and this runs, it doesn't handle the case where it's not created17:49
*** tesseract has joined #openstack-nova17:49
dansmithhowever, we don't just want to do nothing if it's not created, we want to take the path that assumes that when it does get created, it will necessarily be on the same st_dev, and thus not report any cache17:49
melwittyeah, I got that part but from what I was looking, if the cache dir doesn't exist it will fall through and start checking usage of the cache dir and if it doesn't exist won't that be bad?17:50
dansmithwhere will it fall through?17:51
melwittcause we'll end up here if the dir doesn't exist https://github.com/openstack/nova/blob/f5f7c2540150c7ee7640c834d5caec31b3f5a7ab/nova/virt/libvirt/imagecache.py#L36617:51
*** ttsiouts has joined #openstack-nova17:52
dansmither wait, maybe I'm inverting that in my head17:52
melwittit will return 0 disk usage if self.cache_dir_is_on_same_dev_as_instances_dir is False, right?17:52
dansmithokay right right, I forgot how this ended up17:52
dansmithwe initially talked about reporting inventory for the cache disk itself,17:52
melwittelse it will do the math on the cache dir17:53
dansmithand this is the opposite where we reserve only if the cache is the _same_ disk, which I think is why we endded up checking the reverse condition instead of what we're looking for17:53
*** dlbewley has quit IRC17:53
dansmithso yeah, we need to bail if the directory doesn't exist because we're checking the cache_dir which might not exist yet17:54
dansmithI still think the property shouldnt' explode if the directory doesn't exist,17:54
dansmithbut you're right, it'll still hit the same problem but a little later on17:54
*** dlbewley has joined #openstack-nova17:54
dansmiththe logic is right, it just doesn't prevent us from hitting the same problem in the sum()17:55
melwittoh, ok, so the logic on exists() should not be inverted to remove the 'not'17:55
dansmithno, because if it does not exist, the not will make that true, which will short-circuit and return true without evaluating the st_dev part17:56
melwittoh, right17:57
dansmithI'll pull this down and make that change, just a sec17:58
melwittok, cool17:59
dansmitheff, just realized I didn't commit something I did earlier today unrelated17:59
openstackgerritDan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job  https://review.opendev.org/73418417:59
dansmithso another few days in the queue for me17:59
melwittheh :(18:00
openstackgerritDan Smith proposed openstack/nova master: Guard against missing image cache directory  https://review.opendev.org/73696418:10
dansmithmelwitt: ^18:10
*** mlavalle has joined #openstack-nova18:11
dansmithadded comments to hopefully make it clearer why each thing is happening18:12
melwittlooking ... ah yep, that is helpful18:14
dansmiththanks. I was clearly focused on getting that property to return the right thing all the time and not realizing we'd be introducing a new vector to the error :)18:19
*** songwenping__ has joined #openstack-nova18:21
*** songwenping_ has quit IRC18:24
*** ttsiouts has quit IRC18:25
*** artom has quit IRC18:32
*** artom has joined #openstack-nova18:32
*** Supersphere1 has joined #openstack-nova18:37
*** Supersphere1 has quit IRC18:39
*** dlbewley has quit IRC18:43
*** dlbewley has joined #openstack-nova18:43
*** dlbewley has quit IRC18:53
*** jmlowe has joined #openstack-nova18:53
*** dlbewley has joined #openstack-nova18:54
*** belmoreira has quit IRC18:57
*** bnemec is now known as beekneemech19:08
*** salmankhan has quit IRC19:21
*** dlbewley has quit IRC19:22
*** dlbewley has joined #openstack-nova19:23
*** markvoelker has joined #openstack-nova19:31
*** markvoelker has quit IRC19:36
*** mriedem is now known as hughjazz19:59
*** KeithMnemonic has quit IRC19:59
*** tesseract has quit IRC20:00
*** dlbewley has quit IRC20:00
*** dlbewley has joined #openstack-nova20:01
*** markvoelker has joined #openstack-nova20:04
*** nweinber has quit IRC20:05
*** markvoelker has quit IRC20:09
*** gmann_afk is now known as gmann20:15
*** _mlavalle_1 has joined #openstack-nova20:25
*** mlavalle has quit IRC20:26
*** ralonsoh has quit IRC20:33
*** priteau has quit IRC20:36
*** vishalmanchanda has quit IRC20:40
mnaserjust wanna put eyes on https://review.opendev.org/#/c/736370/ if/when possible :)20:43
*** gyee has joined #openstack-nova20:46
*** xek has joined #openstack-nova20:54
*** ttsiouts has joined #openstack-nova21:01
*** factor has joined #openstack-nova21:04
sean-k-mooneymnaser: form the title that makes sense21:04
sean-k-mooneyill take a look on monday21:05
*** dlbewley has quit IRC21:05
sean-k-mooneyactully its pretty short21:05
*** raildo has quit IRC21:05
*** dlbewley has joined #openstack-nova21:05
mnasersean-k-mooney: thank you!21:07
sean-k-mooneymelwitt: just finished reviewing https://review.opendev.org/#/c/736370/2 want to take a look?21:18
sean-k-mooneymnaser: the only thing im not sure is do we want to have a release note or not.21:18
sean-k-mooneymnaser: this would have failed anyway later so the only behavior change is that by failing in _validate_flavor_image_nostatus we now fail before creating a server record21:19
sean-k-mooneyso instead of ending up with a server in error state we just get an excption form spawn21:20
sean-k-mooneywhich is better but as an operator would you want that called out in the release notes give the excption you are raising  inherits form FlavorDiskTooSmall which can already casue the same behvoiur if the volume is less the min_gb21:21
sean-k-mooneymnaser: ^21:21
*** xek_ has joined #openstack-nova21:25
*** xek has quit IRC21:28
arjunbaindurhey, have a question about configuring PCI passthrough. We have a device that has 2 functions. On the hypervisor, the PCI address has it on same bus and same slot. When it shows up inside the VM, the PCI address has it under different slots21:31
*** dlbewley has quit IRC21:31
arjunbaindurfor example, suppose device has two functions at 83:00.0 and 83:00.121:31
arjunbaindur Under the VM, the devices show up under different slots, for example 0:5.0 and 0:6.021:31
*** dlbewley has joined #openstack-nova21:31
*** lbragstad has quit IRC21:32
sean-k-mooneyim guessing its a gpu with a second function for the audio encoder on the gpu?21:32
arjunbaindurany idea how to get them to show up as two functions under the same slot21:32
sean-k-mooneyor a similar device21:32
sean-k-mooneyunfortunetly we do not have a way to do that currently21:32
sean-k-mooneywe did dicuss it breifly about 3-6 months ago21:33
sean-k-mooneyefffectivly we would need to modify the pci alisia to support multifuntion devices21:33
sean-k-mooneysuch as allowing one pci aliase to refrence another and adding a multifuntion=true tag21:34
sean-k-mooneyso the parent alias would refence the child aliase and but or would have the multifunction=ture tag21:35
*** ttsiouts has quit IRC21:35
sean-k-mooneyarjunbaindur: i think on windows this can break the audio encoder on nvidga gpus since the driver is expecting it to be a second fuction on the same bus/slot21:36
sean-k-mooneybut on linux it works21:36
sean-k-mooneyim sure it would be an issue for other device that had the same toplogy21:36
arjunbaindurto be specific, this is a Xilinx card21:39
arjunbaindurhttps://www.xilinx.com/support/documentation/boards_and_kits/accelerator-cards/1_5/ug1301-getting-started-guide-alveo-accelerator-cards.pdf21:39
arjunbaindursince the two devices show up under diff PCI slots, we arent able to install drivers21:39
sean-k-mooneyah ok well its the same issue unfortunetly21:40
sean-k-mooneyare you trying to reproguam the aclerat using 1 fucntion21:40
sean-k-mooneyand consume it using the second21:40
*** songwenping_ has joined #openstack-nova21:41
*** lbragstad has joined #openstack-nova21:42
sean-k-mooney32-64GB of ddr4 + and fpga and some qsfp ports. that looks like a pretty interesting card21:42
sean-k-mooneyarjunbaindur: are you trying to use this via cyborg or just novas pci passhtough21:43
arjunbaindurjust Nova PCI passthrough: followed this doc basically: https://docs.openstack.org/nova/rocky/admin/pci-passthrough.html21:44
*** songwenping__ has quit IRC21:44
arjunbaindurAdded the two PCI addresses for each function in the whitelist21:44
sean-k-mooneyya so as i said we are missing the ablity to group multiple fucntion together form teh same device that are schulded togehter21:44
arjunbainduris there an upstream bug or anything to track this?21:45
sean-k-mooneyi was trying to find one. its not really a bug since it was never part of the orginial design21:45
sean-k-mooneyi suspcet this would need a short spec or maybe a specless blueprint21:46
sean-k-mooneyarjunbaindur: looking at the open blueprints no21:48
sean-k-mooneyso the feature you need is support for "multifunction pci device passthough"21:48
sean-k-mooneyif you want to file a blueprint for that and add the details of your specific usecase we could bring it up in the next meeting or dicsuss it here next week when more people are online21:49
sean-k-mooneyit has been asked for before and should not be too invasive to add but on the other hand not many people review the pci code so getting reviews might be the bigger stubleing block to addign this21:50
sean-k-mooneyits a cpablity i suspect cyborg will want eventually too so the libvirt driver work to supprot generintg the correct xml is likely to be need regardless of if we add the feature to novas pci pasthough21:51
*** xek_ has quit IRC21:54
*** eharney has quit IRC21:58
*** markvoelker has joined #openstack-nova22:05
*** markvoelker has quit IRC22:10
*** _mlavalle_2 has joined #openstack-nova22:23
*** _mlavalle_1 has quit IRC22:24
*** _mlavalle3 has joined #openstack-nova22:29
sean-k-mooneydansmith: it finally passed https://review.opendev.org/#/c/734184/ :)22:29
sean-k-mooneydansmith: ah you modified devstack in the end https://review.opendev.org/#/c/73623122:31
*** _mlavalle_2 has quit IRC22:31
*** gyee has quit IRC22:42
*** hughjazz has left #openstack-nova22:51
*** _mlavalle3 has quit IRC22:57
*** jdillaman has quit IRC23:02
*** hamalq has quit IRC23:11
artomsean-k-mooney, if by some weirdness of circumstance you're still working: https://review.opendev.org/#/c/737052/223:26
*** spatel has joined #openstack-nova23:32
*** ttsiouts has joined #openstack-nova23:32
sean-k-mooneyim watching a c++ code review of command and  conquer https://www.youtube.com/watch?v=Oee7gje-XRc&t=929s23:32
sean-k-mooneybut since my laptop is broken im using my work one23:33
sean-k-mooneyuntil i buy a new one23:33
sean-k-mooneyso ya you unabandonted that?23:33
sean-k-mooneyor is this a different fix23:33
sean-k-mooneythat is instead of https://review.opendev.org/#/c/737038/23:34
sean-k-mooneyartom: ah ok i see whats happening we are installing pacages via pip before devstack runs for crudini23:36
sean-k-mooneyso devstack has not allready installed pip23:36
sean-k-mooneyartom: so this is happing because of http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015204.html23:44
sean-k-mooneyartom: so +2 from me the ci passes and the patch makes sense23:44
*** tosky has quit IRC23:45
artomI dunno what I expected23:46
artomThank you!23:46
artomAlso, you're a lunatic23:46
sean-k-mooneyfor likeing c++23:46
artomSure, why not23:46
sean-k-mooneyor for having irc open on a different monitor while i watch youtube23:47
artomThat last part is almost reasonnable23:48
dansmithsean-k-mooney: it didn't setup glance properly though, for some devstack reason I don't understand23:48
dansmithso I'll have to work on that on monday23:48
sean-k-mooneydansmith: ah ok i can take a look on monday too if you like the main issue is i dont know how to configure what you want to configure23:49
sean-k-mooneydansmith: but let me know if i can help23:49
dansmithsean-k-mooney: well, you can see what I've got in local.conf, and that didn't end up in glance-api.conf like it did before23:49
dansmithbut anyway, I can take a look and then come crawling to you, which'll make it even more sweet for you :)23:49
sean-k-mooney:)23:50
*** martinkennelly has joined #openstack-nova23:52
sean-k-mooneyoh ya https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-api_conf.txt does not have the values but https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-image-import_conf.txt does23:52
dansmithI gotta begin my weekend, later23:53
sean-k-mooneydansmith: o/23:53
*** songwenping__ has joined #openstack-nova23:57
sean-k-mooneydansmith: for what its worth i think your hitting a devstack bug since its in the local.conf correctly. so i think  your zuul file is correct.23:59
sean-k-mooneye.g. someitng in devstack is modifying the config after the post config phase which is a bug23:59
sean-k-mooneyjust a guess23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!