| *** brinzhang has joined #openstack-nova | 00:02 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/731248 | 00:05 |
|---|---|---|
| *** hongbin has quit IRC | 00:14 | |
| *** grandchild has quit IRC | 00:15 | |
| *** hongbin has joined #openstack-nova | 00:16 | |
| *** tetsuro has joined #openstack-nova | 00:33 | |
| *** lbragstad has joined #openstack-nova | 00:34 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/train: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/731273 | 00:44 |
| *** lbragstad_ has joined #openstack-nova | 00:47 | |
| *** lbragstad has quit IRC | 00:50 | |
| *** brinzhang_ has joined #openstack-nova | 01:05 | |
| *** xiaolin has joined #openstack-nova | 01:07 | |
| *** brinzhang has quit IRC | 01:08 | |
| *** jawad_axd has joined #openstack-nova | 01:12 | |
| *** brinzhang0 has joined #openstack-nova | 01:19 | |
| *** threestrands has joined #openstack-nova | 01:19 | |
| *** xiaolin has quit IRC | 01:22 | |
| *** brinzhang_ has quit IRC | 01:23 | |
| *** brinzhang_ has joined #openstack-nova | 01:27 | |
| *** xiaolin has joined #openstack-nova | 01:28 | |
| *** brinzhang0 has quit IRC | 01:30 | |
| *** hamalq_ has quit IRC | 01:32 | |
| *** xiaolin has quit IRC | 01:33 | |
| *** sapd1 has joined #openstack-nova | 01:38 | |
| *** jawad_axd has quit IRC | 01:45 | |
| *** brinzhang0 has joined #openstack-nova | 01:46 | |
| *** brinzhang has joined #openstack-nova | 01:46 | |
| *** brinzhang_ has quit IRC | 01:47 | |
| *** brinzhang_ has joined #openstack-nova | 01:48 | |
| *** brinzhang has quit IRC | 01:51 | |
| *** mlavalle has quit IRC | 02:01 | |
| *** lbragstad_ has quit IRC | 02:05 | |
| *** lbragstad_ has joined #openstack-nova | 02:14 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732696 | 02:24 |
| *** tetsuro_ has joined #openstack-nova | 02:35 | |
| *** tetsuro_ has quit IRC | 02:38 | |
| *** brinzhang0 has joined #openstack-nova | 02:40 | |
| openstackgerrit | sunhao proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | 02:40 |
| *** brinzhang_ has quit IRC | 02:43 | |
| *** tetsuro has quit IRC | 02:46 | |
| *** brinzhang_ has joined #openstack-nova | 02:47 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732708 | 02:49 |
| *** brinzhang0 has quit IRC | 02:50 | |
| *** rcernin has quit IRC | 02:53 | |
| *** rcernin_ has joined #openstack-nova | 02:53 | |
| *** brinzhang0 has joined #openstack-nova | 02:58 | |
| *** tetsuro has joined #openstack-nova | 02:59 | |
| *** vishalmanchanda has joined #openstack-nova | 02:59 | |
| *** brinzhang_ has quit IRC | 03:02 | |
| *** brinzhang_ has joined #openstack-nova | 03:05 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/queens: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732717 | 03:07 |
| *** rcernin_ has quit IRC | 03:07 | |
| *** brinzhang0 has quit IRC | 03:08 | |
| *** tetsuro has quit IRC | 03:15 | |
| *** xiaolin has joined #openstack-nova | 03:16 | |
| *** rcernin_ has joined #openstack-nova | 03:19 | |
| *** xiaolin has quit IRC | 03:20 | |
| *** tetsuro has joined #openstack-nova | 03:23 | |
| *** rcernin_ has quit IRC | 03:24 | |
| *** rcernin has joined #openstack-nova | 03:25 | |
| *** tetsuro has quit IRC | 03:36 | |
| *** psachin has joined #openstack-nova | 03:40 | |
| *** tetsuro has joined #openstack-nova | 03:40 | |
| *** lbragstad_ has quit IRC | 04:02 | |
| *** Liang__ has joined #openstack-nova | 04:04 | |
| *** yaawang has quit IRC | 04:04 | |
| *** yaawang has joined #openstack-nova | 04:04 | |
| *** brinzhang0 has joined #openstack-nova | 04:22 | |
| *** brinzhang_ has quit IRC | 04:25 | |
| *** purplerbot has quit IRC | 04:27 | |
| *** yankcrime has quit IRC | 04:29 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** hongbin has quit IRC | 04:39 | |
| *** yaawang has quit IRC | 04:40 | |
| *** links has joined #openstack-nova | 04:40 | |
| *** yaawang has joined #openstack-nova | 04:41 | |
| *** jawad_axd has joined #openstack-nova | 04:48 | |
| *** ratailor has joined #openstack-nova | 04:52 | |
| *** udesale has joined #openstack-nova | 04:56 | |
| *** dklyle has quit IRC | 04:57 | |
| *** yaawang has quit IRC | 05:00 | |
| *** yaawang has joined #openstack-nova | 05:01 | |
| *** jraju__ has joined #openstack-nova | 05:09 | |
| *** links has quit IRC | 05:10 | |
| *** sapd1 has quit IRC | 05:55 | |
| *** xiaolin has joined #openstack-nova | 06:02 | |
| *** Liang__ has quit IRC | 06:03 | |
| *** Liang__ has joined #openstack-nova | 06:08 | |
| *** Liang__ is now known as LiangFang | 06:09 | |
| *** factor has quit IRC | 06:17 | |
| *** factor has joined #openstack-nova | 06:17 | |
| *** whoami-rajat has quit IRC | 06:17 | |
| *** vesper has quit IRC | 06:18 | |
| *** LiangFang has quit IRC | 06:18 | |
| *** vesper11 has joined #openstack-nova | 06:18 | |
| *** Liang__ has joined #openstack-nova | 06:18 | |
| *** whoami-rajat has joined #openstack-nova | 06:18 | |
| *** sapd1 has joined #openstack-nova | 06:23 | |
| *** Liang__ has quit IRC | 06:27 | |
| *** Liang__ has joined #openstack-nova | 06:28 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:38 | |
| *** Liang__ has quit IRC | 06:40 | |
| *** Liang__ has joined #openstack-nova | 06:41 | |
| tony_su | dansmith: A reviewer of ProviderConfigFile patch wanted to understand why additionProperties is set to true by default in the first place. https://review.opendev.org/#/c/673341/45/nova/compute/provider_config_schemas/provider_config_schema_v1.yaml might require your attention. Thanks. | 06:41 |
| *** jsuchome has joined #openstack-nova | 06:42 | |
| *** links has joined #openstack-nova | 06:42 | |
| *** jraju__ has quit IRC | 06:43 | |
| *** rcernin has quit IRC | 06:44 | |
| *** rcernin_ has joined #openstack-nova | 06:44 | |
| *** rcernin_ has quit IRC | 06:50 | |
| *** slaweq has joined #openstack-nova | 06:50 | |
| *** yikun has joined #openstack-nova | 06:52 | |
| *** rcernin_ has joined #openstack-nova | 06:52 | |
| *** ratailor has quit IRC | 06:53 | |
| *** ratailor has joined #openstack-nova | 06:56 | |
| *** rcernin_ has quit IRC | 06:59 | |
| *** tesseract has joined #openstack-nova | 07:01 | |
| *** xiaolin has quit IRC | 07:05 | |
| bauzas | good morning Nova | 07:09 |
| *** iurygregory has quit IRC | 07:11 | |
| *** psachin has quit IRC | 07:12 | |
| *** sapd1 has quit IRC | 07:12 | |
| *** ttsiouts has joined #openstack-nova | 07:13 | |
| *** ttsiouts has quit IRC | 07:14 | |
| *** tetsuro has quit IRC | 07:14 | |
| *** ttsiouts has joined #openstack-nova | 07:16 | |
| gibi | bauzas: good morning | 07:20 |
| bauzas | gibi: morning | 07:21 |
| bauzas | fwiw, just created a blueprint for tracking reshape tooling work for Ussuri https://blueprints.launchpad.net/nova/+spec/offline-reshape-tool | 07:21 |
| *** rpittau|afk is now known as rpittau | 07:21 | |
| gibi | bauzas: cool. Do you agree that we had enough discussion about FFU on the PTG so that I can approve that bp without further discussion on the weekly meeting? | 07:22 |
| openstackgerrit | sunhao proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | 07:23 |
| *** rcernin_ has joined #openstack-nova | 07:23 | |
| *** ccamacho has joined #openstack-nova | 07:24 | |
| *** xiaolin has joined #openstack-nova | 07:27 | |
| *** rcernin_ has quit IRC | 07:28 | |
| *** tosky has joined #openstack-nova | 07:29 | |
| bauzas | gibi: well, I'm torn about it | 07:31 |
| bauzas | gibi: we discussed at the PTG about how to call placement without having the service running | 07:31 |
| bauzas | but i'm not sure we had a consensus | 07:31 |
| bauzas | we have a way to do it that was accepted for the reshape spec in https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/reshape-provider-tree.html#direct-interface-to-placement | 07:32 |
| *** iurygregory has joined #openstack-nova | 07:33 | |
| *** dustinc has quit IRC | 07:35 | |
| gibi | bauzas: OK, then let's double check this with the team on the weekly meeting. | 07:35 |
| bauzas | thanks | 07:35 |
| gibi | I will add it to the agenda | 07:35 |
| *** jraju__ has joined #openstack-nova | 07:35 | |
| bauzas | gibi: looking at the spec, looks like we agreed on using PlacementDirect for this | 07:36 |
| bauzas | so if folks agree in the meeting, we can have a specless bp | 07:36 |
| *** xiaolin has quit IRC | 07:36 | |
| gibi | bauzas: yes, but on the PTG I was tried to mention that fact and get a pushback because that would require DB access from the compute nodes | 07:36 |
| *** links has quit IRC | 07:36 | |
| bauzas | gibi: PlacementDirect supports oslo.config | 07:36 |
| bauzas | so you would run the nova-manage command that would call PlacementDirect with DB options | 07:37 |
| gibi | true, but our deployment model does not require db access for compute hosts so far | 07:37 |
| *** tesseract-RH has joined #openstack-nova | 07:37 | |
| gibi | so the db server might not even accessible from the compute hosts | 07:37 |
| gibi | e.g network separation | 07:37 |
| bauzas | gibi: surely, but that would be something we would comment | 07:38 |
| bauzas | like a caveat | 07:38 |
| bauzas | and it's just for FFUs | 07:38 |
| gibi | OK | 07:38 |
| *** tesseract has quit IRC | 07:40 | |
| *** links has joined #openstack-nova | 07:42 | |
| *** jraju__ has quit IRC | 07:42 | |
| *** ralonsoh has joined #openstack-nova | 07:45 | |
| gibi | let's go with the original plan from the spe | 07:46 |
| gibi | c | 07:46 |
| *** jraju__ has joined #openstack-nova | 07:47 | |
| *** links has quit IRC | 07:47 | |
| *** belmoreira has joined #openstack-nova | 07:51 | |
| *** rcernin_ has joined #openstack-nova | 07:59 | |
| *** rcernin_ has quit IRC | 08:03 | |
| *** avolkov has joined #openstack-nova | 08:08 | |
| *** links has joined #openstack-nova | 08:09 | |
| *** jraju__ has quit IRC | 08:09 | |
| *** martinkennelly has joined #openstack-nova | 08:11 | |
| sean-k-mooney | gibi: bauzas well ingeneral we whould assume the db server is not accesable from the compute yes | 08:14 |
| sean-k-mooney | this is why we discussed the need to potentialy seperate the data collection from the updating of placment or the db | 08:15 |
| *** xek has joined #openstack-nova | 08:15 | |
| sean-k-mooney | e.g. we might need to run something on the compute node to generate some output which is the canges to be done via ssh then do the update from the contoler instead | 08:16 |
| sean-k-mooney | i think johnthetubaguy brought that up or dansmith in the ptg sesssion | 08:16 |
| sean-k-mooney | gibi: and ya its not even a case of our deployment model does not require it it activly discurages direct db acess form the compute on security grounds | 08:18 |
| sean-k-mooney | at least it has sicne we got rid fo the local conducor stuff like 2-3 years ago | 08:18 |
| bauzas | sean-k-mooney: operators can pipe their needs for just a FFU upgrade if they want | 08:20 |
| sean-k-mooney | "pipe there needs" ? | 08:21 |
| sean-k-mooney | by the way look like some people from vmware are fixing the vmware nsx ci | 08:22 |
| *** ravsingh has joined #openstack-nova | 08:24 | |
| *** sapd1 has joined #openstack-nova | 08:24 | |
| *** martinkennelly has quit IRC | 08:24 | |
| sean-k-mooney | http://207.189.188.190/logs/58/734658/1/check-vote/ext-nova-zuul/f8d2e76/tempest_results.html.gz | 08:24 |
| *** martinkennelly has joined #openstack-nova | 08:24 | |
| *** tetsuro has joined #openstack-nova | 08:25 | |
| *** martinkennelly has quit IRC | 08:25 | |
| sean-k-mooney | i think it has to be manually triggered via vmware-recheck-patch but i guess that is still an improvement | 08:25 |
| *** martinkennelly has joined #openstack-nova | 08:26 | |
| bauzas | sean-k-mooney: I mean, for example, to do something like piping netcat | 08:26 |
| sean-k-mooney | bauzas: they could but i dont think we sould require direct db access | 08:27 |
| sean-k-mooney | making them proxy it via netcat or ssh is a hack IMO | 08:28 |
| bauzas | it's a nova-manage command so we need it anyway :) | 08:28 |
| bauzas | they need to provide DB creds | 08:28 |
| sean-k-mooney | bauzas: so that means nova-manage is not suitable solution to this probelem | 08:28 |
| bauzas | but if you need to run this command on a nova-compute (and then you don't have a specific DB cred for it), then you could just use netcat | 08:29 |
| bauzas | sean-k-mooney: it would work for any operator that doesn't want to have compute nodes be in a specific network | 08:30 |
| sean-k-mooney | i think we should be providing a way to pass in some data structro to the nova-manage command which it uses to then do the reshapes | 08:30 |
| bauzas | sean-k-mooney: we could do it, that's one of the things we said | 08:30 |
| bauzas | hence two commands | 08:30 |
| *** ttsiouts has quit IRC | 08:30 | |
| *** martinkennelly has quit IRC | 08:31 | |
| bauzas | and piping between them (or passing a data structure) | 08:31 |
| sean-k-mooney | yep once command that you run on the compute node that gets the info form the virt driver and produces the reshap yaml or whatever and then a second that you run on a node with db access | 08:31 |
| bauzas | sean-k-mooney: but tbc, https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/reshape-provider-tree.html#direct-interface-to-placement already thought about it | 08:31 |
| sean-k-mooney | bauzas: that was not thinking about reshapes | 08:32 |
| *** dtantsur|afk is now known as dtantsur | 08:32 | |
| *** jmlowe has quit IRC | 08:32 | |
| sean-k-mooney | it was thinking about db upgrades | 08:32 |
| sean-k-mooney | those are very different things | 08:32 |
| sean-k-mooney | well it mentions reshpaes but we did not have any at that point | 08:33 |
| *** ttsiouts has joined #openstack-nova | 08:34 | |
| sean-k-mooney | actully i guess look ing at the spec in general this is the resahpe spec | 08:34 |
| *** bbowen has quit IRC | 08:34 | |
| *** bbowen has joined #openstack-nova | 08:35 | |
| sean-k-mooney | i think it was making the assumtion however that reshaps did not need compute specific infomation | 08:35 |
| *** jmlowe has joined #openstack-nova | 08:35 | |
| sean-k-mooney | looking at the ironic_flavor_migration examle i dont think that is the same as the libvirt case | 08:36 |
| sean-k-mooney | https://review.opendev.org/#/c/501025/12/nova/cmd/manage.py | 08:36 |
| sean-k-mooney | because the ironic virt dirver talks to the ironic api | 08:36 |
| sean-k-mooney | so the compute serivce virt driver does not need to be colocated on the same host as the hypervior | 08:37 |
| gibi | the spec gives solution for one side of the problem. We don't have a running placement API service during FFU but we need to write into the placement db due to reshape | 08:37 |
| gibi | placement direct allows that. | 08:38 |
| sean-k-mooney | yes it will | 08:38 |
| gibi | sean-k-mooney is right that collecting the data for the reshape is not solved in tha spec | 08:38 |
| gibi | except that it mentions to start up a virt driver, but it does not handle the implication of that statemen | 08:39 |
| gibi | t | 08:39 |
| sean-k-mooney | gibi: https://review.opendev.org/#/c/501025/ is the implemeation for ironic | 08:39 |
| sean-k-mooney | but that is very different then libvirt | 08:39 |
| sean-k-mooney | the ironic virt dirver is used here https://review.opendev.org/#/c/501025/12/nova/cmd/manage.py@988 | 08:41 |
| *** nightmare_unreal has joined #openstack-nova | 08:42 | |
| gibi | interesting | 08:42 |
| sean-k-mooney | we cant just call the reshape function in the libvirt dirver however. | 08:42 |
| sean-k-mooney | ironic works because all the info it need is either in the nova db or in the ironic api | 08:42 |
| sean-k-mooney | this is all that was doing https://github.com/openstack/nova/blob/b6f3d393aa5cb755f30fa70d4acc614c32216c99/nova/virt/ironic/driver.py#L570-L582 | 08:43 |
| sean-k-mooney | thats doing an online data migration but its not doing a reshape | 08:44 |
| gibi | the analogous call would be nova.virt.libvirt.driver.LibvirtDriver.update_provider_tree | 08:46 |
| gibi | but that needs a hypervisor connection as far as I see | 08:46 |
| sean-k-mooney | well yes an no that would update the provider i guess but it would do more then just run the reshapes | 08:46 |
| sean-k-mooney | gibi: yes it need the resouce track and a bunch of other things that reuiqre not just a connection to libvirt but file access too | 08:47 |
| sean-k-mooney | im pretty sure we need to check /sys for some things | 08:47 |
| sean-k-mooney | like sev support? we need the compute nodes config for allocation ratio stuff at the very least | 08:48 |
| gibi | sean-k-mooney: agree that update_provider_tree does more than what is needed for reshape | 08:48 |
| gibi | I guess we need to see what are the bare minimum information to run each reshape codepath and see how can we provide that | 08:49 |
| *** lvdombrkr has joined #openstack-nova | 08:49 | |
| sean-k-mooney | the pcpu reshape would need the compute node cpu_shared_set and cpu_dedicated_set config options techincally vcpu_pin_set too | 08:51 |
| sean-k-mooney | i think the vgpu reshape to have seperate RP per pGPU needs libvirt and the mdev type config options | 08:51 |
| sean-k-mooney | gibi: if we proceeed with numa in placment that is going to need the host numa toplogy info from libfirt | 08:51 |
| sean-k-mooney | gibi: this is the vgpu reshape https://github.com/openstack/nova/blob/b6f3d393aa5cb755f30fa70d4acc614c32216c99/nova/virt/libvirt/driver.py#L7757 | 08:54 |
| sean-k-mooney | well actully _update_provider_tree_for_vgpu is the top level function we would be calling and _update_provider_tree_for_pcpu is the cpu one | 08:56 |
| gibi | I see | 08:58 |
| sean-k-mooney | _get_all_assigned_mediated_devices which is used in the vgpu reshape directly read the guest xml https://github.com/openstack/nova/blob/b6f3d393aa5cb755f30fa70d4acc614c32216c99/nova/virt/libvirt/driver.py#L6940-L6973 | 08:58 |
| *** jmlowe has quit IRC | 08:58 | |
| *** jmlowe has joined #openstack-nova | 08:59 | |
| *** yikun has quit IRC | 09:01 | |
| *** tetsuro has quit IRC | 09:01 | |
| *** spatel has joined #openstack-nova | 09:13 | |
| *** Luzi has joined #openstack-nova | 09:13 | |
| *** yankcrime has joined #openstack-nova | 09:14 | |
| *** spatel has quit IRC | 09:18 | |
| *** martinkennelly has joined #openstack-nova | 09:27 | |
| *** martinkennelly has quit IRC | 09:27 | |
| *** belmoreira has quit IRC | 09:29 | |
| *** jraju__ has joined #openstack-nova | 09:29 | |
| *** links has quit IRC | 09:29 | |
| *** martinkennelly has joined #openstack-nova | 09:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/734658 | 09:35 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Add functional test for bug 1550919 https://review.opendev.org/731247 | 09:35 |
| openstack | bug 1550919 in OpenStack Compute (nova) ussuri "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood) | 09:35 |
| stephenfin | bauzas: Can you look at https://review.opendev.org/#/c/733668 ? | 09:36 |
| bauzas | stephenfin: ack, will do | 09:36 |
| bauzas | gibi: sean-k-mooney: sorry was on a meeting, saw your discussion | 09:37 |
| bauzas | yup, from a vgpu reshape perspective, we need to lookup the guest XMLs hence libvirt | 09:38 |
| bauzas | (and just not do a DB check) | 09:38 |
| *** jraju__ has quit IRC | 09:38 | |
| openstackgerrit | Merged openstack/nova-specs master: Stop to use the __future__ module. https://review.opendev.org/732879 | 09:39 |
| *** jraju__ has joined #openstack-nova | 09:40 | |
| gibi | stephenfin: about https://review.opendev.org/#/c/734658 would it worth to add a reno too to communicate a future breaking change? | 09:51 |
| *** Liang__ has quit IRC | 09:51 | |
| stephenfin | gibi: Good idea. "upgrade" section? | 09:51 |
| gibi | stephenfin: yeah | 09:51 |
| stephenfin | Cool. Sec | 09:52 |
| gibi | thanks | 09:52 |
| openstackgerrit | Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mark e1000e VIF as supported https://review.opendev.org/734777 | 09:58 |
| stephenfin | sean-k-mooney: Can you sanity check that too, please? ^ | 09:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/734658 | 10:15 |
| stephenfin | gibi: ^ | 10:15 |
| stephenfin | as requested | 10:15 |
| stephenfin | bauzas: Another (easier) one for your list https://review.opendev.org/#/c/734777/ | 10:16 |
| bauzas | stephenfin: the exception one is a bit hairy, I need to make sure you don't forget anything | 10:16 |
| sean-k-mooney | stephenfin: yep ill take a look shortly | 10:17 |
| *** ociuhandu has joined #openstack-nova | 10:18 | |
| sean-k-mooney | stephenfin: did you check if we report hugepages in the host numa toplogy blob | 10:19 |
| sean-k-mooney | when file backed memory is enabled | 10:19 |
| *** rpittau is now known as rpittau|bbl | 10:19 | |
| stephenfin | I did not. What would be the implication? | 10:19 |
| stephenfin | Just that we shouldn't do it? | 10:19 |
| sean-k-mooney | we cant use filebacked memory and hugepages at the same time | 10:20 |
| sean-k-mooney | but the numa toplogy filter has no idea if this config value is set | 10:20 |
| sean-k-mooney | so it wont elimiate those hosts | 10:20 |
| stephenfin | Hmm, good point. That'd be another good fix | 10:20 |
| stephenfin | Lemme go look | 10:20 |
| sean-k-mooney | so unless we dont report hugepages when there vailable if its set then we could get boot fails i think | 10:20 |
| sean-k-mooney | ya seperate patch if its not done | 10:21 |
| *** ociuhandu has quit IRC | 10:21 | |
| *** ociuhandu has joined #openstack-nova | 10:23 | |
| stephenfin | Does anyone know how to get a KCS taken down? https://access.redhat.com/solutions/3947641 | 10:25 |
| *** ttsiouts has quit IRC | 10:25 | |
| *** ttsiouts_ has joined #openstack-nova | 10:25 | |
| stephenfin | For some daft reason, someone suggested people modify their DB rather than ask us to resolve a trivial bug :-\ | 10:26 |
| stephenfin | ^ Ignore that. Intended for downstream IRC :) | 10:30 |
| sean-k-mooney | damit is there way way we can just stop support form publishing kcs artical without having them go through tech review | 10:37 |
| sean-k-mooney | ya i dont know but i reviewd https://review.opendev.org/#/c/734658/3 | 10:38 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/734658 | 10:41 |
| *** ociuhandu has quit IRC | 10:41 | |
| stephenfin | sean-k-mooney: Addressed doc typo. Let's track the hugepage/total GB issue separately? | 10:41 |
| sean-k-mooney | yep im cool with that we can just file a seperate bug that patch fixes the bug you have already filed | 10:42 |
| bauzas | stephenfin: https://review.opendev.org/#/c/733668/2 got a -1 because of PEP484 usage be py3 specific | 10:43 |
| gibi | stephenfin: thanks for the reno | 10:43 |
| sean-k-mooney | bauzas: we are allowed to use py3 only syntax and feature on master | 10:44 |
| bauzas | I know | 10:44 |
| stephenfin | I was about to say :) | 10:44 |
| sean-k-mooney | bauzas: and this is not enforce excpetion type it adding them | 10:44 |
| *** xek has quit IRC | 10:44 | |
| stephenfin | personally, I think this patch is too invasive to backport | 10:44 |
| bauzas | but then if we backport, we'll get linters shouting at us with no idea why | 10:44 |
| sean-k-mooney | if we backport we need to drop the type info | 10:45 |
| stephenfin | I think we're just going to have to live with that. I'll just drop the type info if I went back past stable/ussuri | 10:45 |
| sean-k-mooney | we were holding of on adding it so we did not need to use the comment syntax | 10:45 |
| stephenfin | yeah, exactly | 10:45 |
| bauzas | stephenfin: then, just amend the commit msg and we're all good | 10:45 |
| stephenfin | Sure. What should I add? | 10:46 |
| bauzas | I don't want to refrain ourselves to use py3 styles, but I rather just want us to take 5 mins before writing it and consider backportability of such things | 10:46 |
| sean-k-mooney | it took me a long time to be ok with the type on the right after all the c/c++/java/c# i wrote before learning python but im slowly gettin gused to it | 10:46 |
| bauzas | stephenfin: just tell your decision | 10:46 |
| sean-k-mooney | it seam like most lanaguges are converging on that order now | 10:47 |
| bauzas | option A/ this bugfix isn't intended to be backported | 10:47 |
| bauzas | option B/ if people feel brave enough to backport, there will be a necessary change | 10:47 |
| bauzas | in other words, document your code :) | 10:47 |
| stephenfin | Hmm, I _could_ but it does feel like stating the obvious | 10:48 |
| sean-k-mooney | bauzas: so im ok with b if iall it is is removing :<Type> | 10:48 |
| bauzas | sean-k-mooney: me too, just my point | 10:48 |
| bauzas | again, it's just a static check AFAIK | 10:48 |
| sean-k-mooney | i dont think that need to be in a comit or called out anywhere in the chagne | 10:48 |
| sean-k-mooney | bauzas: well its not even a staitc check | 10:48 |
| sean-k-mooney | the py2 jobs will fail | 10:48 |
| sean-k-mooney | it wont parse correctly | 10:49 |
| *** derekh has joined #openstack-nova | 10:49 | |
| stephenfin | We'd saying if you use Py3 syntax and your commit message has "Closes-Bug" in it, add this boilerplate | 10:49 |
| sean-k-mooney | stephenfin: i would really like to avoid that | 10:49 |
| stephenfin | I mean, we don't say "this bugfix has o.vo implications so you're not allowed backport it" in a commit | 10:49 |
| sean-k-mooney | we coudld but i dont see the point | 10:49 |
| sean-k-mooney | stephenfin: bauzas we could update the contibutor guide or somehting to call it out i guess | 10:50 |
| bauzas | sean-k-mooney: the point is that I'm afraid stable core reviewers could miss such tiny bits that would break | 10:50 |
| sean-k-mooney | bauzas: but it would not pass ci | 10:50 |
| sean-k-mooney | so it wont get merged at least | 10:50 |
| bauzas | fortunately, in this specific case, agreed, CI won't run | 10:50 |
| stephenfin | Fortunately, as sean-k-mooney points out, this will raise a SyntaxError on python 2.7 | 10:50 |
| sean-k-mooney | but they might not know why | 10:50 |
| stephenfin | heh, yeah 0:) | 10:50 |
| bauzas | this | 10:51 |
| stephenfin | how a contributor guide change? | 10:51 |
| bauzas | honestly, I don't want to bikeshed | 10:51 |
| stephenfin | *about | 10:51 |
| bauzas | you know what ? I'll just approve the change | 10:51 |
| stephenfin | Do we have a backporting section in that? | 10:51 |
| bauzas | and then people who backport should just see my comment in the review | 10:51 |
| stephenfin | \o/ WFM too :) | 10:51 |
| bauzas | if they don't, then I'll kill them | 10:52 |
| bauzas | seriously | 10:52 |
| bauzas | stephenfin: but for a second, we unnecesseraly added complexity to the existing code by adding a linter check | 10:52 |
| *** tkajinam has quit IRC | 10:53 | |
| bauzas | I could have -1d it by saying 'sorry dude, unrelated to the change' | 10:53 |
| bauzas | stephenfin: so, please refrain yourself to add more than what's necessary ;) :D | 10:53 |
| stephenfin | ooooorrr, we're reducing complexity by removing the need to worry about types | 10:53 |
| sean-k-mooney | bauzas: i could argure the opiste | 10:53 |
| stephenfin | let the compute do the work for you | 10:54 |
| sean-k-mooney | if you dont add it and added it in a seperate change that is adding uneesisary overhead in revew | 10:54 |
| stephenfin | *computer | 10:54 |
| stephenfin | agreed | 10:54 |
| stephenfin | if I wasn't changing the function signature, this would be unrelated | 10:54 |
| stephenfin | but because I am, this is a fair change | 10:54 |
| sean-k-mooney | anyway stephen are you going to chekc the hugepage/file backed memeory thing or will i doit | 10:54 |
| stephenfin | sean-k-mooney: If you've time, go for it. I'm going to lunch shortly as I'm in meetings most of this afternoon :( | 10:55 |
| stephenfin | If not, I'll aim to do it before EOD | 10:55 |
| sean-k-mooney | well i want to understand this so that i can figure out how this relates to numa in placmenet | 10:55 |
| sean-k-mooney | so ill try and doit shortly | 10:56 |
| sean-k-mooney | file backed memroy will have to be reported on the ROOT RP | 10:57 |
| sean-k-mooney | since it has no real numa affintiy | 10:57 |
| gibi | I think we can trust the stable cores to see if a code is not py2 compatible | 10:59 |
| *** lpetrut has joined #openstack-nova | 10:59 | |
| sean-k-mooney | the fact that we are not using six anymore will liekly cause more issue then type hints | 11:00 |
| gibi | also if there is such code that valid for py2 and py3 but behaves differently, then during the master review we have to make sure we add enough unit test coverage that will break when the patch is blindy backported to py2 | 11:00 |
| *** dkehn has quit IRC | 11:00 | |
| sean-k-mooney | yep | 11:00 |
| gibi | in this particular case the interpreter catches the problem | 11:01 |
| bauzas | gibi: sean-k-mooney: what I'm saying is that we somehow opted into thinking more about what we write and what we merge on master now that the ship has sailed | 11:01 |
| bauzas | that's it. | 11:01 |
| sean-k-mooney | list vs iterator/view will be one of the main one for like dict.keys() | 11:01 |
| stephenfin | and unicode/bytes | 11:02 |
| bauzas | previously, we had no brain knobs to do as we were supporting boh | 11:02 |
| sean-k-mooney | in that case its not as bad | 11:02 |
| bauzas | both* | 11:02 |
| sean-k-mooney | as we are sticter in py3 | 11:02 |
| sean-k-mooney | but yes | 11:02 |
| gibi | bauzas: sure, we should be aware, but at the same time we should not limit ourselves to write better code on master | 11:02 |
| bauzas | I don't disagree | 11:02 |
| bauzas | I'm just saying we need to ponderate the will of writing nice code with the pragmatism of running such code on different stable releases | 11:03 |
| bauzas | and from someone who sometimes has to backport things down to Newton, I'm thinking about my job for the next 3 years | 11:03 |
| bauzas | if I can ease myself, I'll certainly do | 11:04 |
| sean-k-mooney | stephenfin: so looking at http://paste.openstack.org/show/794558/ | 11:06 |
| sean-k-mooney | stephenfin: i think we are good on the numa front | 11:06 |
| sean-k-mooney | stephenfin: this is the relevent virsh output http://paste.openstack.org/show/794560/ | 11:09 |
| sean-k-mooney | so libvirt sees the hugepage i have allocated but we are not reporting any hugepages in the host numa_toplogy blob | 11:09 |
| sean-k-mooney | gibi: by the way inital_ram_allocation_ratio still default to 1.5 :( i think we just changed it to 1 in ooo | 11:11 |
| sean-k-mooney | we said we chagned it to 1.0 in the ptg but we did not | 11:12 |
| gibi | sean-k-mooney: yeah, we mentioned 1.0 but I don't remember the context | 11:12 |
| gibi | I do know that the product I helping downstream set it 1.0 directly since Icehose or Mitaka | 11:13 |
| sean-k-mooney | ya and windriver did too | 11:13 |
| sean-k-mooney | maybe we should actully chage the upstream default to 1 but we would have to be very vocal and proably add an upgrade check if we did | 11:13 |
| sean-k-mooney | 16 for our cpus is also nuts as a defalt. anything over about 4 tends to cause issue when the system is loaded | 11:15 |
| gibi | sean-k-mooney: agree about vocalization, but I don't think we should spend too much effort changing this default. | 11:15 |
| sean-k-mooney | chaning initalil_allcoation_raitio actully might be safe as it only matter for new installs | 11:15 |
| *** threestrands has quit IRC | 11:16 | |
| sean-k-mooney | gibi: well i think we change it downstream in our product, you change it in yours and windriver and i think mirantis did in theres | 11:16 |
| sean-k-mooney | so if everyone changes the default its proably a bad default | 11:16 |
| sean-k-mooney | gibi: but ya we dont need to spend time on it now | 11:17 |
| sean-k-mooney | i jsut wanted to correct myself | 11:17 |
| gibi | ack, thanks for the correction | 11:17 |
| *** links has joined #openstack-nova | 11:26 | |
| *** jraju__ has quit IRC | 11:28 | |
| *** raildo has joined #openstack-nova | 11:37 | |
| *** zigo has quit IRC | 11:41 | |
| aarents | Hi nova, | 11:42 |
| aarents | bauzas: gibi FYI, As per new element given during PTG regarding my issue https://bugs.launchpad.net/nova/+bug/1874032 , I confirm that offload snapshot upload in a native thread fix it | 11:42 |
| openstack | Launchpad bug 1874032 in OpenStack Compute (nova) "nova-compute become stuck when doing IO on busy file system" [Wishlist,In progress] - Assigned to Alexandre arents (aarents) | 11:42 |
| aarents | (i'm no more able to get nova-compute hang if file system is busy) | 11:42 |
| sean-k-mooney | stephenfin: actully im going to restart libvirt and test that agian | 11:45 |
| *** rcernin_ has joined #openstack-nova | 11:48 | |
| aarents | so I propose some thing here: https://review.opendev.org/#/c/734776/1 dansmith was planning to think about it during PTG | 11:48 |
| *** bbowen_ has joined #openstack-nova | 11:52 | |
| *** rcernin_ has quit IRC | 11:53 | |
| *** bbowen has quit IRC | 11:53 | |
| *** zigo has joined #openstack-nova | 11:56 | |
| *** bbowen_ has quit IRC | 11:57 | |
| *** bbowen_ has joined #openstack-nova | 11:57 | |
| *** lvdombrkr has quit IRC | 12:04 | |
| *** rpittau|bbl is now known as rpittau | 12:05 | |
| *** derekh has quit IRC | 12:06 | |
| *** derekh has joined #openstack-nova | 12:06 | |
| *** ttsiouts_ has quit IRC | 12:08 | |
| *** derekh has quit IRC | 12:12 | |
| *** derekh has joined #openstack-nova | 12:12 | |
| *** raildo has quit IRC | 12:14 | |
| *** raildo has joined #openstack-nova | 12:14 | |
| sean-k-mooney | aarents: right but didnt we agree not to do that and instead just use a new sepmaphore | 12:15 |
| sean-k-mooney | we have https://github.com/openstack/nova/blob/e954a0569785c941ccb89d31c7b4b847b15b5fc5/doc/source/reference/threading.rst which documents nova threading model | 12:17 |
| *** bbowen_ has quit IRC | 12:17 | |
| sean-k-mooney | there are a few cases where we have to use explcit treading but we avoid it unless absolutly required | 12:18 |
| *** bbowen has joined #openstack-nova | 12:18 | |
| *** ravsingh has quit IRC | 12:20 | |
| *** derekh has quit IRC | 12:24 | |
| *** derekh has joined #openstack-nova | 12:24 | |
| aarents | sean-k-mooney: thanks for the helpfull link, by new semaphore you mean you mean something limiting max concurrent snapshot ? | 12:25 |
| sean-k-mooney | yes | 12:26 |
| sean-k-mooney | we have a config option to limit the max builds on a host | 12:26 |
| sean-k-mooney | one of the suggestions was to add one for snapshot | 12:26 |
| sean-k-mooney | aarents: just looking at the eventlet docs | 12:27 |
| sean-k-mooney | https://eventlet.net/doc/threading.html#eventlet.tpool.execute | 12:27 |
| sean-k-mooney | so it looks like this will still be a blocking call | 12:27 |
| sean-k-mooney | but it yeild the current greenlet ? | 12:27 |
| sean-k-mooney | e.g. will that internally invoke the function on a native thread | 12:28 |
| sean-k-mooney | yeild | 12:28 |
| *** ratailor has quit IRC | 12:28 | |
| sean-k-mooney | then call thread.join at some later point | 12:28 |
| aarents | I understand more like that: coroutine delegate to native thread (block just waiting native thread finish, but in the maintime yeild to other coroutine always) | 12:30 |
| *** ttsiouts has joined #openstack-nova | 12:32 | |
| *** ttsiouts has quit IRC | 12:32 | |
| *** ttsiouts has joined #openstack-nova | 12:32 | |
| sean-k-mooney | aarents: if that is how it works then it would be ok but the docs are not clear | 12:32 |
| *** nweinber has joined #openstack-nova | 12:32 | |
| sean-k-mooney | oh i missed the prelude | 12:32 |
| sean-k-mooney | The simplest thing to do with tpool is to execute() a function with it. The function will be run in a random thread in the pool, while the calling coroutine blocks on its completion: | 12:32 |
| aarents | yep | 12:34 |
| aarents | sean-k-mooney: according the nova doc you share, I'm precisely in case "Yielding the thread in long-running tasks" but my issue is: I can't put smart greenthread.sleep(0) call because IO are in glance.client | 12:34 |
| sean-k-mooney | aarents: no that is for internal cases | 12:35 |
| sean-k-mooney | not external io | 12:35 |
| aarents | k | 12:35 |
| sean-k-mooney | if we are computing something expensive we are ment to addd sleeps to yeild | 12:35 |
| aarents | yes, aggree | 12:36 |
| *** amodi has joined #openstack-nova | 12:37 | |
| sean-k-mooney | aarents: ok left my toughts in the patch. i would proably be ok with that change if we had the config option to limit the number in parralle | 12:42 |
| stephenfin | bauzas: Last ask for the day, I promise, but could you also take a shot at https://review.opendev.org/#/c/728505/ ? It's a re-approval, if that helps | 12:43 |
| aarents | sean-k-mooney: thanks | 12:43 |
| stephenfin | If you want, will trade for review of your spec :-P | 12:44 |
| *** damien_r has quit IRC | 12:49 | |
| *** martinkennelly has quit IRC | 12:50 | |
| *** martinkennelly has joined #openstack-nova | 12:50 | |
| *** damien_r has joined #openstack-nova | 12:52 | |
| openstackgerrit | Merged openstack/nova-specs master: spec update: virtual-persistent-memory https://review.opendev.org/726284 | 12:52 |
| *** udesale_ has joined #openstack-nova | 12:54 | |
| *** ociuhandu has joined #openstack-nova | 12:56 | |
| *** damien_r has quit IRC | 12:56 | |
| *** udesale has quit IRC | 12:57 | |
| *** eharney has joined #openstack-nova | 12:57 | |
| *** avolkov_ has joined #openstack-nova | 12:57 | |
| *** martinkennelly has quit IRC | 13:00 | |
| *** avolkov has quit IRC | 13:01 | |
| *** rajinir has quit IRC | 13:01 | |
| *** avolkov_ is now known as avolkov | 13:01 | |
| *** ociuhandu has quit IRC | 13:02 | |
| *** rajinir has joined #openstack-nova | 13:04 | |
| bauzas | stephenfin: heh no worries | 13:05 |
| *** ravsingh has joined #openstack-nova | 13:07 | |
| *** ociuhandu has joined #openstack-nova | 13:09 | |
| *** ociuhandu has quit IRC | 13:11 | |
| *** Luzi has quit IRC | 13:12 | |
| *** ociuhandu has joined #openstack-nova | 13:12 | |
| *** lbragstad_ has joined #openstack-nova | 13:12 | |
| aarents | sean-k-mooney: dansmith thks, I replied https://review.opendev.org/#/c/734776/1 | 13:28 |
| *** ratailor has joined #openstack-nova | 13:30 | |
| sean-k-mooney | aarents: i was thinking more like 4 but 10 might be fine too | 13:32 |
| sean-k-mooney | what is the default build limit | 13:32 |
| sean-k-mooney | ah that is 10 | 13:32 |
| *** mriedem has joined #openstack-nova | 13:32 | |
| sean-k-mooney | ya so 10 would be fine | 13:33 |
| aarents | ok | 13:34 |
| dansmith | 10 seems like a lot to me | 13:38 |
| dansmith | well, depends on where the bottleneck is I guess | 13:39 |
| sean-k-mooney | ya that is why i was thinking 4 but we consider 10 ok for max_concurrent_builds | 13:39 |
| sean-k-mooney | maybe it should default to the value of max_concurrent_builds if its not set | 13:39 |
| sean-k-mooney | to keep them the same | 13:39 |
| sean-k-mooney | we have done that with some of the periodic intervals | 13:40 |
| *** ociuhandu has quit IRC | 13:42 | |
| *** ratailor has quit IRC | 13:42 | |
| aarents | sean-k-mooney currently we live without limit by defaut, the new idea is to not exhaust thread pool, in that case 10 is fine but we can align with other parameter why not | 13:46 |
| sean-k-mooney | aarents: well we live without a limit becasue its all in one thread | 13:46 |
| aarents | k | 13:47 |
| *** jawad_axd has quit IRC | 13:47 | |
| sean-k-mooney | update the patch and either have the default depend on the other config value or select a defalut and we can review that then | 13:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184 | 13:48 |
| aarents | sean-k-mooney: ok | 13:50 |
| sean-k-mooney | if we see Lazy-loading 'pci_devices' on Instance ... mesages on the compute node during spwan is that a bad thing? | 13:57 |
| *** brinzhang0 has quit IRC | 13:57 | |
| *** Liang__ has joined #openstack-nova | 13:57 | |
| sean-k-mooney | or more is that expected or should we have all the info in the build request? | 13:57 |
| *** ociuhandu has joined #openstack-nova | 13:58 | |
| *** Liang__ is now known as LiangFang | 14:00 | |
| *** martinkennelly has joined #openstack-nova | 14:03 | |
| *** ociuhandu has quit IRC | 14:03 | |
| *** dklyle has joined #openstack-nova | 14:03 | |
| *** ociuhandu has joined #openstack-nova | 14:05 | |
| *** dkehn has joined #openstack-nova | 14:08 | |
| *** udesale_ has quit IRC | 14:10 | |
| *** ccamacho has quit IRC | 14:11 | |
| dansmith | sean-k-mooney: it means something tried to read that field on the instance.. if we're doing that based on something in the request, then it's probably good to lazy-load it, so we're not always passing it regardless of whether or not pci is used | 14:17 |
| dansmith | if we're always looking at that regardless, then the lazy load is just a perf hit and we should pre-join it | 14:17 |
| sean-k-mooney | this was just before the xml was generated for an instance with no pci requetss or numa policy set | 14:18 |
| sean-k-mooney | i might take a look at why its doing that in a bit | 14:19 |
| sean-k-mooney | im currently testing file backed memroy | 14:19 |
| dansmith | in that case, we could either be smarter about when we look at that field to avoid the lazy-load, or we should just pre-join it | 14:19 |
| *** sapd1 has quit IRC | 14:20 | |
| sean-k-mooney | alex_xu: https://review.opendev.org/#/c/734658/4/doc/source/admin/file-backed-memory.rst@70 i added info about the numa and hugepage behavior | 14:25 |
| sean-k-mooney | numa more or less works although the numa toplogy filter will be looking at the host ram when considering numa affinity not the file backed memory | 14:26 |
| sean-k-mooney | i think i a werid way that is actully the correct thing to do | 14:26 |
| sean-k-mooney | as it will not allow a guests virtual numa node to be large then a hosts numa node | 14:27 |
| *** LiangFang has quit IRC | 14:28 | |
| sean-k-mooney | libvirt is also passing the correct numa affinity hints to qemu for the files too | 14:28 |
| *** Liang__ has joined #openstack-nova | 14:29 | |
| sean-k-mooney | so the things we could fix are hugepages, and how the local_GB is reported. both of which could be done via existing config options | 14:29 |
| sean-k-mooney | so we can just have one more pathc to document it. in the long run we might want to adress this diffrently. we dont need a code change to do the write thing but i think we should warn when we detect you have not set the config options correctly as the current patch does | 14:31 |
| *** Liang__ is now known as LiangFang | 14:33 | |
| *** links has quit IRC | 14:35 | |
| openstackgerrit | Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | 14:40 |
| *** liuyulong has joined #openstack-nova | 14:41 | |
| *** mlavalle has joined #openstack-nova | 14:47 | |
| *** LiangFang has quit IRC | 14:47 | |
| *** LiangFang has joined #openstack-nova | 14:48 | |
| *** ociuhandu has quit IRC | 14:50 | |
| *** ccamacho has joined #openstack-nova | 14:54 | |
| *** mandre has joined #openstack-nova | 14:55 | |
| *** jmlowe has quit IRC | 14:58 | |
| *** priteau has joined #openstack-nova | 14:58 | |
| stephenfin | Can anyone say why we include "cherry-picked from" lines in stable? They seem like a waste of time, particularly when you've to make changes to the backport | 15:02 |
| stephenfin | and Gerrit already does the linking based on change ID | 15:02 |
| *** JamesBenson has joined #openstack-nova | 15:03 | |
| sean-k-mooney | convention | 15:04 |
| sean-k-mooney | but other then that its not really neeed | 15:04 |
| sean-k-mooney | also if you do it via gerrit it does it differrently | 15:04 |
| sean-k-mooney | e.g. it only add the first one | 15:05 |
| sean-k-mooney | unless you do the backport on by one i think | 15:05 |
| stephenfin | Looks like it's to work around a Gerrit bug that has since been fixed https://docs.openstack.org/project-team-guide/stable-branches.html | 15:05 |
| stephenfin | cherry-pick -x option includes ‘cherry-picked from …’ line in the commit message which is required to avoid Gerrit bug | 15:05 |
| stephenfin | which points to https://code.google.com/p/gerrit/issues/detail?id=1107 | 15:05 |
| sean-k-mooney | its not required by any of our tooling | 15:05 |
| stephenfin | nope | 15:05 |
| sean-k-mooney | upstream or downstrema | 15:06 |
| stephenfin | I propose we stop doing it. It's annoying and often wrong | 15:06 |
| stephenfin | Will bring up in the next team meeting | 15:06 |
| sean-k-mooney | so use -X | 15:06 |
| sean-k-mooney | instead of -x | 15:06 |
| openstackgerrit | Merged openstack/nova-specs master: Encrypted Emulated Virtual TPM https://review.opendev.org/728505 | 15:08 |
| stephenfin | sean-k-mooney: What would -X do? the man page says something about merge strategy | 15:09 |
| sean-k-mooney | git-review -x add the cherry picked line -X does not | 15:09 |
| *** lpetrut has quit IRC | 15:09 | |
| sean-k-mooney | oh sorry its the other way around | 15:10 |
| sean-k-mooney | -X adds it and -x does not | 15:10 |
| stephenfin | I don't think the -X is related, actually | 15:10 |
| stephenfin | Reading the docs | 15:10 |
| sean-k-mooney | so if you backporting using git review | 15:10 |
| stephenfin | you won't get the line unless you specify -x | 15:10 |
| sean-k-mooney | the workflow is checkout stable/whatever | 15:10 |
| sean-k-mooney | then do git review -X | 15:11 |
| stephenfin | ahhhh | 15:11 |
| sean-k-mooney | to add the cherry picked lins | 15:11 |
| stephenfin | I just use git-cherrypick | 15:11 |
| *** dustinc has joined #openstack-nova | 15:11 | |
| sean-k-mooney | but if you do -x it does not add them | 15:11 |
| *** jmlowe has joined #openstack-nova | 15:11 | |
| sean-k-mooney | ya i was talkingbaout the arge for git review | 15:11 |
| dansmith | I guess I'm confused.. why is it not helpful? When I'm browsing history at the command line, it's helpful.. otherwise I have to go into gerrit by change-id to find the siblings | 15:11 |
| sean-k-mooney | not git cherry-pick | 15:11 |
| sean-k-mooney | dansmith: im assuming stephne it ac case where it was wrong | 15:12 |
| dansmith | when is it ever wrong? I can't think of a case. | 15:12 |
| melwitt | most of the time, I like the cherry picked lines because it lets me easily see if the changes were picked from N branch to N - 1 branch. but agreed it's a pain when you have to update one | 15:12 |
| sean-k-mooney | when people do it manually and get it wrong | 15:12 |
| sean-k-mooney | i honestly dont mind either way to be honest | 15:12 |
| stephenfin | dansmith: in general they're correct, but things break if you've to make any modification to an earlier patch | 15:13 |
| sean-k-mooney | the only thing i find annoying is that gerrit does not do it the way we want | 15:13 |
| dansmith | it also helps me see how far something was backported.. like if I'm looking at something on stein and it has N backport lines, I know that came from stein+N | 15:13 |
| * stephenfin tends to use 'git log --grep=CHANGE_ID' to find patches on different branches | 15:14 | |
| sean-k-mooney | stephenfin: maybe try using git review for backport for a while | 15:14 |
| stephenfin | True, but you have that information in the cherry picks box on the right | 15:14 |
| stephenfin | in the UI, that is | 15:14 |
| dansmith | not in the command line tho | 15:14 |
| dansmith | right | 15:14 |
| stephenfin | fair point | 15:15 |
| stephenfin | sean-k-mooney: in general, there's no issue. I just use 'git cherry-pick -x' | 15:15 |
| stephenfin | but I've been bitten a few times now where I had a stack of stable changes and had to make a tweak to a single patch higher up | 15:16 |
| stephenfin | so you've add the missing mock or the typo in your commit message or whatever else you missed | 15:16 |
| stephenfin | and then you've to go update the cherry-picked lines in every backported patch plus any patch on top in each branch. not fun :) | 15:17 |
| stephenfin | it'd be nice if it was optional | 15:17 |
| stephenfin | as something that's nice-to-have but not really necessary, particularly if it incurs pain | 15:18 |
| stephenfin | *when it incurs pain | 15:18 |
| dansmith | well, my vote is that it's worthwhile bookkeeping | 15:21 |
| stephenfin | Definitely worthwhile but not essential. I'd like to be able to loosen the cuffs on the occasion they start hurting | 15:22 |
| elod | if i'm not mistaken, then gerrit adds the cherry-picked lines correctly, iff the original patch has merged. if the patch is not merged yet, it does not add the cherry-picked line, for logical reasons, as it might not be the one that gets merged | 15:24 |
| stephenfin | elod: Ah, so that's how it makes the decision :) Can't confirm but makes sense | 15:25 |
| stephenfin | Waiting for a patch series to land on stable/X before backporting to the stable/X-1 etc. is less than optional though. It causes unnecessary context switching for both submitter and reviewer, assuming the submitter even remembers to keep backporting things | 15:26 |
| elod | that's true, we had the same discussion in our team :] | 15:27 |
| stephenfin | Ha! I'm about to discuss it downstream too 😇 | 15:27 |
| dansmith | I'd much prefer to have the bookkeeping right and I think it's very unusual that backports to N releases are that urgent | 15:27 |
| *** liuyulong has quit IRC | 15:28 | |
| elod | otherwise, if a patch needs to be fixed, then all its backports need to be fixed, so that's another extra burden. so there are two sides | 15:28 |
| *** LiangFang has quit IRC | 15:28 | |
| elod | if we stick to policy and do the backporting branch-by-branch, when a patch has merged, then this is not an issue, though | 15:29 |
| stephenfin | dansmith: so not including the cherry-picked from line would be very unusual too | 15:29 |
| stephenfin | it'd be exceptional, not the norm | 15:29 |
| stephenfin | elod: yes and no. It really depends on the nature of the change to the higher up patch | 15:31 |
| *** martinkennelly has quit IRC | 15:31 | |
| stephenfin | Consider that series I reviewed from lyarwood yesterday. The extra 'cherry-picked from' line was something that affected all commit messages | 15:32 |
| stephenfin | but there were other issues that were specific to certain backports like the 'Conflicts' and 'NOTE' sections being the wrong way round | 15:32 |
| stephenfin | it's not black and white | 15:33 |
| stephenfin | anyway, I've made my point :) now to forget about it until next time I hit this | 15:34 |
| *** yoctozepto has quit IRC | 15:34 | |
| *** yoctozepto has joined #openstack-nova | 15:34 | |
| elod | if the editing of a 'middle' patch is allowed, then that could be a source of an inproper backport. i mean most of the time it's not a problem, but sometimes we forget to backport some new changes | 15:35 |
| elod | the cherry-picked line is good to identify where the backport is coming from | 15:36 |
| elod | and as dansmith said, it's good to see how many previous backports there are | 15:37 |
| elod | but yes, if we want to backport to multiple branches at the same time, it could be painful :) | 15:38 |
| stephenfin | yup, all fair points | 15:39 |
| stephenfin | it'd just be nice have the optional, is all | 15:39 |
| stephenfin | *the option | 15:39 |
| *** jaosorior has joined #openstack-nova | 15:40 | |
| *** ociuhandu has joined #openstack-nova | 15:50 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184 | 15:53 |
| *** gyee has joined #openstack-nova | 15:54 | |
| *** hamalq has joined #openstack-nova | 16:05 | |
| *** rpittau is now known as rpittau|afk | 16:07 | |
| *** hamalq_ has joined #openstack-nova | 16:08 | |
| *** sapd1 has joined #openstack-nova | 16:08 | |
| *** hamalq has quit IRC | 16:11 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 16:13 |
| stephenfin | sean-k-mooney: your cherry-picked from lines are wrong in this https://review.opendev.org/#/c/728057/ | 16:16 |
| sean-k-mooney | they may be yes | 16:19 |
| sean-k-mooney | i did it via the gerrit ui | 16:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Silence amqp heartbeat warning https://review.opendev.org/728057 | 16:23 |
| mandre | hi, quick question regarding the hw_scsi_model and hw_disk_bus glance image annotations. Did nova always had support for them? and if we specify a virt driver that the hypervison doesn't support, does it fallback to the default driver? | 16:23 |
| mandre | Context is, I'm wondering if it's safe to set the hw_scsi_model=virtio-scsi and hw_disk_bus=scsi annotations for my images, not knowing what the environment will be. | 16:24 |
| sean-k-mooney | mandre: yes well for several years | 16:25 |
| sean-k-mooney | it predates icehouse | 16:25 |
| sean-k-mooney | mandre: technically you could detect it via the glance metadta api | 16:26 |
| sean-k-mooney | but if the could cupport nova v2 api it also support them | 16:26 |
| sean-k-mooney | mandre the issue is that the values are virt driver dependnet | 16:26 |
| sean-k-mooney | so if you dont know what hyperviror your cloud is using you don tknow what value are vaild | 16:27 |
| sean-k-mooney | if you know that its libvirt then those values will work | 16:27 |
| mandre | cool, so that answers the first part of the question, we're not deploying on anything that is older that queens I think | 16:27 |
| sean-k-mooney | as of ussuri maybe train we also report the support models to placment as traits | 16:28 |
| sean-k-mooney | just an fyi but plamcnet is an admin only api normally so that may or may not be helpful to you | 16:28 |
| mandre | right, we won't be able to use placement because we need to deploy as tenant | 16:29 |
| sean-k-mooney | ya so if you know its libvirt then as i siad those values will work | 16:31 |
| mandre | is there a way to progmatically discover the hypervisor as a tenant? | 16:31 |
| sean-k-mooney | no | 16:31 |
| sean-k-mooney | and that is intentional | 16:31 |
| sean-k-mooney | as an admin yes | 16:31 |
| sean-k-mooney | via the hyperviors api | 16:31 |
| mandre | fair enough, just checking :) | 16:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: libvirt: avoid cpu check at s390x arch https://review.opendev.org/701526 | 16:32 |
| *** boxiang has quit IRC | 16:32 | |
| sean-k-mooney | mandre: you can boot a vm and then you can kind fo tell form inside the vm | 16:33 |
| *** boxiang has joined #openstack-nova | 16:33 | |
| mandre | so if I set a driver via hw_scsi_model that the hypervisor doesn't support, it won't be able to boot the VM? or is there a fallback mechanism? | 16:34 |
| sean-k-mooney | if you set it and its not supported it wont boot | 16:34 |
| sean-k-mooney | because we could not fullfile your request | 16:35 |
| mandre | OK | 16:35 |
| *** ravsingh has quit IRC | 16:36 | |
| sean-k-mooney | mandre: if you boot a vm with a default image and run lscpi like this http://paste.openstack.org/show/794593/ | 16:37 |
| sean-k-mooney | and you see 00:02.0 PCI bridge: Red Hat, Inc. QEMU PCIe Root port for example | 16:37 |
| sean-k-mooney | you basically know it either libvirt/kvm or xen | 16:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531 | 16:37 |
| sean-k-mooney | you can also infer the hypervior in other ways | 16:38 |
| mandre | sean-k-mooney: thanks for the help | 16:39 |
| sean-k-mooney | hyperv and vmware all have similr things you can look for | 16:39 |
| sean-k-mooney | if you run lspci on hyperv for example it will almsot be empty | 16:40 |
| sean-k-mooney | there nics and disk dont show up as pci device in the normal way | 16:40 |
| sean-k-mooney | in vmware the nic model will be a special vmware one by defualt at least | 16:40 |
| *** martinkennelly has joined #openstack-nova | 16:41 | |
| sean-k-mooney | mandre: so if you are enruling you applcaiton on a generic cloud that is one way to figure it out. | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Add admin doc information about image cache resource accounting https://review.opendev.org/732542 | 16:42 |
| *** gyee has quit IRC | 16:42 | |
| mandre | sean-k-mooney: IIUC as a tenant there is no other way than spinning a VM to guess the hypervisor, so we may refrain from adding the image annotations since we won't know the environment in advance | 16:45 |
| sean-k-mooney | well we are discussing worlad onboarding or VNF onboaridng right | 16:46 |
| sean-k-mooney | i assume you are a vendor of a product that runs or can run on openstack | 16:46 |
| *** ociuhandu has quit IRC | 16:46 | |
| sean-k-mooney | if so you have a few options the first is to document your miniurm and recommended setting when onboarnidng your applcation | 16:47 |
| sean-k-mooney | if you atomate that you can add a config or do auto detection | 16:47 |
| sean-k-mooney | but its likely that you will have implcit depenencies in your applcation that will only work on some hypervieors so targeting 1 or a limites set will roably be requried jsut from a vlaidation perspective | 16:48 |
| sean-k-mooney | most openstack cloud usei libvirt/kvm | 16:48 |
| sean-k-mooney | and all that use libvirt/kvm will support those options | 16:49 |
| sean-k-mooney | if you plan to also support vmware, powervm or hyperv then you have to explore one of the other options | 16:49 |
| mandre | ok, that's good info. | 16:49 |
| sean-k-mooney | e.g. confg or docs | 16:49 |
| mandre | this is for the openshift installer on openstack platforms, so there's a good chance the hypervisor will be libvirt/kvm. If using vmware or hyperv, it's likely they'll deploy directly on vsphere or azure. | 16:52 |
| *** grandchild has joined #openstack-nova | 16:53 | |
| *** nightmare_unreal has quit IRC | 16:58 | |
| *** derekh has quit IRC | 17:00 | |
| *** priteau has quit IRC | 17:01 | |
| *** gyee has joined #openstack-nova | 17:08 | |
| *** dtantsur is now known as dtantsur|afk | 17:10 | |
| *** sapd1 has quit IRC | 17:12 | |
| openstackgerrit | Merged openstack/nova master: Add reproducer for bug #1881455 https://review.opendev.org/733667 | 17:16 |
| openstack | bug 1881455 in OpenStack Compute (nova) "migrate server reporting list index out of bound" [Undecided,In progress] https://launchpad.net/bugs/1881455 - Assigned to Stephen Finucane (stephenfinucane) | 17:16 |
| openstackgerrit | Merged openstack/nova master: Use 'Exception.__traceback__' for versioned notifications https://review.opendev.org/733668 | 17:17 |
| openstackgerrit | Merged openstack/nova stable/ussuri: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/731248 | 17:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/703115 | 17:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116 | 17:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117 | 17:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118 | 17:17 |
| stephenfin | sean-k-mooney: addressed some nits from elod on that btw ^ Figure we still want it to land | 17:24 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unnecessary retrieval of Migration object https://review.opendev.org/730351 | 17:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused function parameters https://review.opendev.org/730352 | 17:27 |
| *** tesseract-RH has quit IRC | 17:32 | |
| *** rouk has joined #openstack-nova | 17:38 | |
| elod | thanks stephenfin for the many stable reviews and patch updates :) | 17:41 |
| stephenfin | np :) | 17:42 |
| *** ociuhandu has joined #openstack-nova | 17:43 | |
| *** tbachman has quit IRC | 17:45 | |
| *** ociuhandu has quit IRC | 17:48 | |
| *** tbachman has joined #openstack-nova | 18:08 | |
| *** vishalmanchanda has quit IRC | 18:08 | |
| *** mlavalle has quit IRC | 18:22 | |
| *** lvdombrkr has joined #openstack-nova | 18:41 | |
| openstackgerrit | Merged openstack/nova stable/ussuri: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729174 | 18:45 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725931 | 18:45 |
| *** lbragstad_ is now known as lbragstad | 18:45 | |
| *** bbowen has quit IRC | 19:07 | |
| *** lvdombrkr has quit IRC | 19:13 | |
| *** hongbin has joined #openstack-nova | 19:18 | |
| *** ralonsoh has quit IRC | 19:20 | |
| *** jmlowe has quit IRC | 19:43 | |
| *** jsuchome has quit IRC | 19:44 | |
| *** jmlowe has joined #openstack-nova | 19:45 | |
| *** maciejjozefczyk has quit IRC | 19:46 | |
| *** jmlowe has quit IRC | 19:48 | |
| *** hongbin has quit IRC | 19:55 | |
| *** bbowen has joined #openstack-nova | 20:21 | |
| *** bbowen has quit IRC | 20:30 | |
| *** bbowen has joined #openstack-nova | 20:31 | |
| *** nweinber has quit IRC | 20:34 | |
| *** jdillaman has joined #openstack-nova | 20:36 | |
| *** ociuhandu has joined #openstack-nova | 20:48 | |
| *** ociuhandu has quit IRC | 20:53 | |
| *** bbowen has quit IRC | 20:55 | |
| *** bbowen has joined #openstack-nova | 20:56 | |
| *** spatel has joined #openstack-nova | 21:03 | |
| *** bbowen_ has joined #openstack-nova | 21:06 | |
| *** bbowen has quit IRC | 21:07 | |
| *** raildo has quit IRC | 21:14 | |
| *** bbowen_ has quit IRC | 21:15 | |
| *** bbowen_ has joined #openstack-nova | 21:16 | |
| *** jdillaman has quit IRC | 21:22 | |
| *** bbowen_ has quit IRC | 21:22 | |
| *** bbowen_ has joined #openstack-nova | 21:22 | |
| *** mlavalle has joined #openstack-nova | 21:29 | |
| *** spatel has quit IRC | 21:32 | |
| *** bbowen__ has joined #openstack-nova | 21:32 | |
| *** bbowen_ has quit IRC | 21:34 | |
| *** bbowen has joined #openstack-nova | 21:35 | |
| *** bbowen has quit IRC | 21:37 | |
| *** bbowen__ has quit IRC | 21:38 | |
| *** bbowen has joined #openstack-nova | 21:38 | |
| *** bbowen has quit IRC | 21:48 | |
| *** bbowen has joined #openstack-nova | 21:48 | |
| *** martinkennelly has quit IRC | 21:48 | |
| *** bbowen has quit IRC | 21:50 | |
| *** bbowen_ has joined #openstack-nova | 21:50 | |
| *** threestrands has joined #openstack-nova | 21:55 | |
| *** spatel has joined #openstack-nova | 21:56 | |
| *** mriedem has left #openstack-nova | 21:58 | |
| *** rcernin_ has joined #openstack-nova | 21:59 | |
| *** bbowen_ has quit IRC | 22:01 | |
| *** bbowen__ has joined #openstack-nova | 22:01 | |
| *** avolkov has quit IRC | 22:01 | |
| *** rcernin_ has quit IRC | 22:04 | |
| *** rcernin has joined #openstack-nova | 22:04 | |
| *** rcernin is now known as rcernin|brekkie | 22:05 | |
| *** bbowen__ has quit IRC | 22:07 | |
| *** bbowen_ has joined #openstack-nova | 22:07 | |
| *** bbowen_ has quit IRC | 22:17 | |
| *** bbowen has joined #openstack-nova | 22:17 | |
| *** rcernin|brekkie has quit IRC | 22:19 | |
| *** bbowen has quit IRC | 22:21 | |
| *** grandchild has quit IRC | 22:23 | |
| *** bbowen has joined #openstack-nova | 22:23 | |
| *** bbowen has quit IRC | 22:27 | |
| *** bbowen has joined #openstack-nova | 22:27 | |
| *** bbowen has quit IRC | 22:30 | |
| *** bbowen has joined #openstack-nova | 22:30 | |
| *** spatel has quit IRC | 22:34 | |
| *** bbowen has quit IRC | 22:43 | |
| *** ttsiouts has quit IRC | 22:43 | |
| *** tkajinam has joined #openstack-nova | 22:45 | |
| *** hongbin has joined #openstack-nova | 22:56 | |
| *** hongbin has quit IRC | 23:00 | |
| *** rcernin|brekkie has joined #openstack-nova | 23:09 | |
| *** rcernin|brekkie has quit IRC | 23:10 | |
| *** rcernin has joined #openstack-nova | 23:10 | |
| *** hongbin has joined #openstack-nova | 23:10 | |
| *** tosky has quit IRC | 23:15 | |
| *** lbragstad has quit IRC | 23:22 | |
| *** mlavalle has quit IRC | 23:32 | |
| *** tetsuro has joined #openstack-nova | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!