| *** mriedem has left #openstack-nova | 00:18 | |
| *** vishalmanchanda has quit IRC | 00:18 | |
| *** swp20 has joined #openstack-nova | 00:31 | |
| *** songwenping_ has joined #openstack-nova | 01:01 | |
| *** swp20 has quit IRC | 01:04 | |
| *** Liang__ has joined #openstack-nova | 01:07 | |
| *** spatel has joined #openstack-nova | 01:27 | |
| *** kaisers_ has quit IRC | 01:29 | |
| *** brinzhang_ has joined #openstack-nova | 01:35 | |
| *** songwenping_ has quit IRC | 01:42 | |
| *** lbragstad has quit IRC | 01:52 | |
| *** songwenping_ has joined #openstack-nova | 02:10 | |
| *** spatel has quit IRC | 02:31 | |
| *** spatel has joined #openstack-nova | 02:34 | |
| *** brinzhang_ has quit IRC | 02:44 | |
| *** brinzhang_ has joined #openstack-nova | 02:45 | |
| *** spatel has quit IRC | 02:48 | |
| *** mkrai has joined #openstack-nova | 02:55 | |
| *** brinzhang01 has joined #openstack-nova | 03:03 | |
| *** brinzhang_ has quit IRC | 03:06 | |
| *** psachin has joined #openstack-nova | 03:37 | |
| openstackgerrit | tianmaofu proposed openstack/nova master: Delete queued image after deleting instance when creating image from instance https://review.opendev.org/724839 | 03:41 |
|---|---|---|
| *** mkrai has quit IRC | 04:06 | |
| *** mkrai has joined #openstack-nova | 04:09 | |
| *** songwenping_ has quit IRC | 04:12 | |
| *** brinzhang_ has joined #openstack-nova | 04:31 | |
| *** ratailor has joined #openstack-nova | 04:31 | |
| *** munimeha1 has quit IRC | 04:32 | |
| *** brinzhang01 has quit IRC | 04:34 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:36 | |
| *** udesale has joined #openstack-nova | 04:41 | |
| *** HagunKim has joined #openstack-nova | 05:09 | |
| HagunKim | Hello Nova, I have a question. When I set my flavor vcpu=19, the vm only has 1 cpu core in linux. It is okay vcpu 18 or 17 flavor. What wrong with my Openstack? | 05:11 |
| HagunKim | libvirt vm info has 19 vpus. | 05:15 |
| *** songwenping_ has joined #openstack-nova | 05:37 | |
| *** vishalmanchanda has joined #openstack-nova | 05:45 | |
| *** songwenping__ has joined #openstack-nova | 05:46 | |
| *** mkrai has quit IRC | 05:47 | |
| *** mkrai has joined #openstack-nova | 05:48 | |
| *** jamesdenton has quit IRC | 05:48 | |
| *** jamesdenton has joined #openstack-nova | 05:49 | |
| *** songwenping_ has quit IRC | 05:49 | |
| *** brinzhang has quit IRC | 05:49 | |
| *** brinzhang_ has quit IRC | 05:50 | |
| *** brinzhang has joined #openstack-nova | 05:50 | |
| *** huaqiang has quit IRC | 05:55 | |
| *** gyee has quit IRC | 06:07 | |
| *** brinzhang_ has joined #openstack-nova | 06:17 | |
| *** ociuhandu has joined #openstack-nova | 06:17 | |
| *** brinzhang has quit IRC | 06:20 | |
| *** belmoreira has joined #openstack-nova | 06:27 | |
| *** songwenping_ has joined #openstack-nova | 06:34 | |
| *** songwenping__ has quit IRC | 06:36 | |
| *** huaqiang has joined #openstack-nova | 06:39 | |
| *** brinzhang has joined #openstack-nova | 06:41 | |
| *** brinzhang_ has quit IRC | 06:44 | |
| *** slaweq has joined #openstack-nova | 06:47 | |
| *** dklyle has quit IRC | 06:48 | |
| *** tbachman_ has joined #openstack-nova | 06:51 | |
| *** tbachman has quit IRC | 06:52 | |
| *** tbachman_ is now known as tbachman | 06:52 | |
| *** brinzhang_ has joined #openstack-nova | 07:01 | |
| *** brinzhang has quit IRC | 07:04 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 07:04 | |
| *** brinzhang has joined #openstack-nova | 07:06 | |
| *** brinzhang_ has quit IRC | 07:06 | |
| *** Yumeng has joined #openstack-nova | 07:12 | |
| *** ttsiouts has joined #openstack-nova | 07:15 | |
| *** ccamacho has joined #openstack-nova | 07:18 | |
| *** ociuhandu has quit IRC | 07:19 | |
| *** tesseract has joined #openstack-nova | 07:20 | |
| *** ralonsoh has joined #openstack-nova | 07:26 | |
| *** mgariepy has quit IRC | 07:28 | |
| *** brinzhang_ has joined #openstack-nova | 07:29 | |
| *** tosky has joined #openstack-nova | 07:31 | |
| *** nightmare_unreal has joined #openstack-nova | 07:31 | |
| *** brinzhang has quit IRC | 07:32 | |
| bauzas | good morning Nova | 07:38 |
| bauzas | gibi: fwiw, stephenfin found some races for the multiple_instance_create() vGPU functest http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22testtools.matchers._impl.MismatchError%3A%202%20!%3D%201%5C%22%20AND%20build_name%3A%5C%22nova-tox-functional-py36%5C%22 | 07:40 |
| bauzas | not a lot tho (8 for 7 days) | 07:40 |
| *** mgariepy has joined #openstack-nova | 07:42 | |
| *** brinzhang has joined #openstack-nova | 07:46 | |
| *** rpittau|afk is now known as rpittau | 07:47 | |
| *** brinzhang_ has quit IRC | 07:50 | |
| gibi | bauzas: good morning. I will check that race soon | 07:50 |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 07:50 | |
| *** TheJulia has quit IRC | 07:56 | |
| *** mnasiadka has quit IRC | 07:56 | |
| *** Anticimex has quit IRC | 07:56 | |
| *** TheJulia has joined #openstack-nova | 08:01 | |
| *** mnasiadka has joined #openstack-nova | 08:01 | |
| *** Anticimex has joined #openstack-nova | 08:01 | |
| *** belmoreira has quit IRC | 08:03 | |
| *** xek has joined #openstack-nova | 08:05 | |
| bauzas | gibi: nah, don't worry, I'll look | 08:09 |
| bauzas | if I can't find a solution soon, I'll write an e-r change | 08:10 |
| gibi | OK | 08:11 |
| *** belmoreira has joined #openstack-nova | 08:15 | |
| *** ociuhandu has joined #openstack-nova | 08:20 | |
| gibi | bauzas: I was able to recreate the race locally | 08:22 |
| * bauzas a bit on teaching mode but just looking | 08:22 | |
| bauzas | gibi: I wonder, when i tested, I wasn't having this race | 08:23 |
| *** martinkennelly has joined #openstack-nova | 08:25 | |
| gibi | could be something else changed around the test. In the recent weeks I did not run a lot of full functional suites so I don't know how far this problem goes back | 08:25 |
| bauzas | gibi: when you reproduced, have you run only this test, or more ? | 08:27 |
| gibi | I run the whole functional suite | 08:27 |
| gibi | let me try running the test alon repeatedly | 08:27 |
| bauzas | ok, because I only run the two multiple_create() methods | 08:28 |
| bauzas | (looping over) | 08:28 |
| bauzas | so, I wonder whether some global object would be raced | 08:28 |
| gibi | yeah, that is possible | 08:29 |
| gibi | I have to jump on a call now, but I will run the tests in different ways to see if it is an interference or not | 08:29 |
| bauzas | kk thanks | 08:30 |
| openstackgerrit | Jie Li proposed openstack/nova master: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/722187 | 08:33 |
| *** salmankhan has joined #openstack-nova | 08:34 | |
| * bauzas tries to remember how to ask ostestr to run the exact same concurrency from subunit that the gate ran | 08:41 | |
| *** songwenping_ has quit IRC | 08:45 | |
| *** songwenping_ has joined #openstack-nova | 08:46 | |
| bauzas | ah, bingo https://docs.openstack.org/os-testr/latest/user/subunit_trace.html | 08:47 |
| bauzas | or rather https://stestr.readthedocs.io/en/latest/MANUAL.html#running-previously-failed-tests | 08:49 |
| gibi | bauzas: running just the test_multiple_instance_create* test case I can still reproduce the problem | 08:50 |
| gibi | but it needed like ~50 execution to get it once | 08:50 |
| gibi | now trying just only the single test_multiple_instance_create$ case as I suspect that it is not an interference | 08:51 |
| gibi | when I run the two test cases the, the test_multiple_instance_create$ failed, and the two case run in two separate executor so they cannot interfere | 08:52 |
| *** kaisers_ has joined #openstack-nova | 08:53 | |
| *** martinkennelly has quit IRC | 09:00 | |
| bauzas | gibi: you can ask to use a single subunit | 09:03 |
| bauzas | gibi: that's why I'd like to get the subunit output from the failing job and trying to rerun it | 09:04 |
| gibi | bauzas: just paste me the command you want me to run and I will try that as well | 09:04 |
| bauzas | gibi: https://stestr.readthedocs.io/en/latest/MANUAL.html#parallel-testing | 09:04 |
| gibi | so far, after 77 execution no failure in the single test_multiple_instance_create$ test case execution | 09:04 |
| bauzas | gibi: I got one after a shit number of executions | 09:05 |
| Yumeng | Hi gibi! Good morning, I'm Yumeng from Cyborg Team. | 09:08 |
| Yumeng | Cyborg wants to have a "cyborg/neutron/nova sriov integration" discussion with NOVA and NEUTRON during the Virtual PTG. | 09:09 |
| Yumeng | Could you please find 1 hour for nova team to discuss this topic with cyborg and neutron team? | 09:09 |
| Yumeng | I notice that there is a nova-neutron session on PTG Friday 13:00 UTC, can we join after that on Friday 15:00 UTC? | 09:11 |
| *** salmankhan1 has joined #openstack-nova | 09:11 | |
| gibi | Yumeng: hi! the schedule already closed so we have to use an exsiting booked slot for that discussion. Do you have a room booking from Friday 15:00 ? | 09:12 |
| *** salmankhan has quit IRC | 09:12 | |
| *** salmankhan1 is now known as salmankhan | 09:12 | |
| Yumeng | gibi: no, I don't have now. But I can email Kendall and book the room if it's ok for nova and neutron. | 09:13 |
| gibi | Yumeng: I think we can try Friday 14:00 - 15:00 where we already have a room booked, or if you can get a room from Kendall then I we can do the discussion from 15:00 - 16:00 | 09:15 |
| Yumeng | gibi: aha! Friday 14:00 - 15:00 is fantastic! I am just not sure if it is already occupied. | 09:17 |
| gibi | Yumeng: I kept that as an overflow slot so I think we can use that for cyborg. If you need the neutron team present as well then you have to synch with slaweq too | 09:18 |
| *** dtantsur|afk is now known as dtantsur | 09:18 | |
| bauzas | Yumeng: tbh, what use case are you talking of ? | 09:19 |
| Yumeng | Great! Thank you so much gibi! I will sync with slaweq! ^^ | 09:19 |
| gibi | Yumeng: cool. I added it to the nova etherpad | 09:19 |
| bauzas | SR-IOV but how ? | 09:19 |
| Yumeng | bauzas: yes, exactly! | 09:19 |
| gibi | Yumeng, bauzas: yeah that is my next request, please try to prepare some material before the discussion | 09:20 |
| bauzas | Yumeng: okay, but why do you need all contributors ? | 09:20 |
| bauzas | in nova and neutron ? | 09:20 |
| bauzas | what kind of feature request would you want to do in Cyborg ? | 09:20 |
| gibi | ^^ +1 | 09:20 |
| Yumeng | We will try to write a spec to describe this topic. And one of our team member from Intel is preparing a POC. | 09:21 |
| Yumeng | yes, a lot question should be answered. ^^ | 09:21 |
| bauzas | Yumeng: before writing a spec, can you just summarize the reason ? | 09:22 |
| bauzas | Yumeng: just saying, we still need to work on providing the NUMA topologies in Placement and then providing the PCI devices | 09:28 |
| bauzas | and when we discussed about SR-IOV to be in Placement, we said 'well, why not, but it's a mid-term issue' | 09:29 |
| bauzas | at least we first need to do the above before ^ | 09:29 |
| bauzas | so, even if we would like to do it for Victoria, it wouldn't be possible | 09:29 |
| bauzas | Yumeng: that's why I just want to be honest to say that I'm not sure we could do anything for you during Victoria | 09:30 |
| bauzas | and then, not sure we would need to ask all the contributors to be around just for this | 09:30 |
| bauzas | sorry, 'this' being the virtual PTG | 09:31 |
| bauzas | Yumeng: what we *could* do tho is to discuss about that once you provide some docs, maybe just an etherpad for explaining what you'd like | 09:31 |
| *** songwenping_ has quit IRC | 09:32 | |
| *** songwenping_ has joined #openstack-nova | 09:32 | |
| Yumeng | bauzas,gibi: the use case is for smartnic and the main integration feature is to pass device_profile from nova to neutron to create a port. | 09:32 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/725801 | 09:34 |
| bauzas | Yumeng: that's not an usecase, it's rather a possible solution ;) | 09:35 |
| bauzas | Yumeng: why do you need to pass this argument to Neutron ? | 09:35 |
| *** avolkov has joined #openstack-nova | 09:39 | |
| Yumeng | I think this doc makes sense: https://etherpad.opendev.org/p/Shanghai-Neutron-Cyborg-xproj | 09:39 |
| *** masterpe has quit IRC | 09:39 | |
| Yumeng | please check from line 41 to end. | 09:40 |
| *** irclogbot_3 has quit IRC | 09:41 | |
| *** irclogbot_0 has joined #openstack-nova | 09:42 | |
| Yumeng | and line 46 describes why we need to pass the device_profile argument to neutron | 09:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix ut error on Aarch64(And other non-x86 platform) https://review.opendev.org/713163 | 09:42 |
| gibi | Yument so a smartnic provides both a programable device and an SRIOV NIC at the same time and the end user would like to specify what program should be loaded to the smarnic and then use that program via a SRIOV device | 09:46 |
| gibi | is this a correct view? | 09:46 |
| Yumeng | gibi: yes,exactly. I think your are right. | 09:48 |
| gibi | bauzas: does this help you approaching the problem? | 09:52 |
| bauzas | gibi: I'm literrally reading the etherpad | 09:52 |
| bauzas | gibi: but I don't get tho why nova needs to tell Neutron what Cyborg wants | 09:53 |
| bauzas | we already call Cyborg at boot time | 09:53 |
| bauzas | so Cyborg could ping Neutron | 09:53 |
| bauzas | the less informations Nova would have to carry, the better I think it would be :) | 09:54 |
| bauzas | also, with us stuck with neutron late binding, this would require subtantial change in nova IIUC | 09:55 |
| gibi | bauzas: current SRIOV support works by creating a port in neutron and providing that port in the nova boot request. if cyborg creates the port in neutron during the boot then we need a way in nova to know about such port | 09:55 |
| bauzas | gibi: I don't want to change this | 09:55 |
| bauzas | gibi: I'm just saying there is a piece of metadata information that neutron has to know | 09:55 |
| bauzas | which is carried by Nova | 09:56 |
| *** brinzhang_ has joined #openstack-nova | 09:56 | |
| bauzas | but which could be provided by Cyborg before the nova port creation call | 09:56 |
| gibi | sure. I'm not suggesting to change this. I just noted down the logical problem about letting cyborg handle neutron | 09:56 |
| gibi | bauzas: nova does not create the neutron port for sriov | 09:56 |
| gibi | those ports need to be pre-created and provided in the boot request to nova | 09:56 |
| gibi | afaik | 09:57 |
| bauzas | oh you're right | 09:57 |
| *** masterpe has joined #openstack-nova | 09:57 | |
| bauzas | we don't late bind | 09:57 |
| bauzas | actually, we bind | 09:57 |
| bauzas | but we don't create | 09:57 |
| *** brinzhang has quit IRC | 09:58 | |
| *** martinkennelly has joined #openstack-nova | 10:02 | |
| *** songwenping_ has quit IRC | 10:04 | |
| Yumeng | bauzas: emm IMHO, cyborg doesn't create the port in neutron during the boot. When Cyborg discovers SRIOV device and stores the device's info, user need to use Cyborg create a port/bandwith request, i.e. device_profile | 10:05 |
| bauzas | yeah I was confused, my apologies | 10:05 |
| bauzas | so, there is a pre-creation step | 10:06 |
| bauzas | and then nova gets the port at boot time | 10:06 |
| Yumeng | yes | 10:06 |
| bauzas | OK, I think I still need to go thru the etherpad to understand the reasoning but that's a good first step | 10:10 |
| *** rpittau is now known as rpittau|bbl | 10:10 | |
| Yumeng | gibi,bauzas: Thanks for your time! I am going off line now. my time is UTC+8. You can either ping me in IRC at #openstack-cyborg channel if you have more question. or just leave comments at ehterpad(topic 13):https://etherpad.opendev.org/p/cyborg-victoria-goals https://etherpad.opendev.org/p/cyborg-victoria-goals | 10:10 |
| Yumeng | bauzas: thanks for taking time reading it! | 10:11 |
| gibi | Yumeng: thanks I tried to add some not the nova etherpad. | 10:11 |
| bauzas | gibi: fwiw, playing with stestr run --until-failure and then stestr --last helps me reproduce the failure everytime | 10:11 |
| Yumeng | gibi: ok, thanks. I will go back to nova ehterpad later. | 10:11 |
| gibi | bauzas: meantime I was able to reproduce the problem only runnig the single test case test_multiple_instance_create$ so it is not test case interference | 10:12 |
| gibi | (it took 356 runs though) | 10:12 |
| gibi | Yumeng: OK. have a nice evening | 10:12 |
| bauzas | you mean, the single test method() without nova.tests.functional.libvirt.test_vgpu.VGPUTests.test_multiple_instance_create_filling_up_capacity ? | 10:12 |
| bauzas | Yumeng: ack, will do | 10:13 |
| *** Yumeng has left #openstack-nova | 10:13 | |
| gibi | bauzas: yes a single test method nova.tests.functional.libvirt.test_vgpu.VGPUTests.test_multiple_instance_create [7.793940s] ... FAILED | 10:13 |
| bauzas | gibi: if so, the race is probably because we need to hold for a few things | 10:13 |
| gibi | bauzas: yeah it is most likele a missing wait_for_<something> at some point in the test | 10:14 |
| bauzas | gibi: lemme see if adding a pause of 1 sec will just solve the problem | 10:14 |
| gibi | ack | 10:14 |
| bauzas | gibi: because what's failing is that we lookup the mdevs | 10:14 |
| bauzas | gibi: we should potentially wait a bit | 10:14 |
| bauzas | this being said, we wait for the ACTIVE status | 10:15 |
| bauzas | oh wait | 10:15 |
| bauzas | this is a multiple instance creation | 10:15 |
| bauzas | so we only check the first instance creation | 10:15 |
| gibi | that could explain it | 10:16 |
| bauzas | lemme try | 10:16 |
| bauzas | --until-failure allows me to run the test easily | 10:16 |
| * bauzas tries to remember in test_servers how we managed the multi-instance creation checks | 10:17 | |
| bauzas | ahah, interesting | 10:18 |
| bauzas | we don't hold | 10:18 |
| *** derekh has joined #openstack-nova | 10:21 | |
| *** Liang__ has quit IRC | 10:25 | |
| bauzas | gibi: okay, changed my test to wait for all servers, running it | 10:26 |
| gibi | cool | 10:26 |
| bauzas | gibi: will leave it run for one hour or so | 10:26 |
| *** jazeltq has joined #openstack-nova | 10:26 | |
| gibi | if you push the patch up I can do the same while I have lunch | 10:26 |
| bauzas | and if I no longer see any issues after, say, 200 runs, then we will know it's fixed | 10:26 |
| bauzas | k | 10:27 |
| bauzas | gibi: just writing a bug and uploading then | 10:27 |
| * bauzas rushes as my daughters don't look at Netflix yet | 10:27 | |
| gibi | ack | 10:28 |
| bauzas | ah shit, they started it :p | 10:29 |
| bauzas | https://bugs.launchpad.net/nova/+bug/1877281 | 10:30 |
| openstack | Launchpad bug 1877281 in OpenStack Compute (nova) "vGPU multiple instance creation test is racey" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 10:30 |
| bauzas | gibi: worth thinking about RC3 for this one ? :( | 10:31 |
| bauzas | or, maybe we just release and then backport later | 10:31 |
| bauzas | the issue isn't that bad | 10:31 |
| jazeltq | hello gibi | 10:32 |
| *** ociuhandu has quit IRC | 10:32 | |
| jazeltq | I have one question about nova-scheduler | 10:32 |
| *** ociuhandu has joined #openstack-nova | 10:33 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Wait for all servers to be active when testing vGPUs https://review.opendev.org/726087 | 10:35 |
| bauzas | gibi: ^ | 10:36 |
| * bauzas goes to lunch (while running the tests locally) | 10:36 | |
| bauzas | gibi: FYI (functional) [sbauza@sbauza nova]$ stestr --test-path=./nova/tests/functional run --until-failure nova.tests.functional.libvirt.test_vgpu.VGPUTests.test_multiple_instance_create | 10:37 |
| *** ociuhandu has quit IRC | 10:38 | |
| stephenfin | melwitt: When you're about, can you take a look at https://review.opendev.org/#/c/677444/ please? | 10:42 |
| *** ociuhandu has joined #openstack-nova | 10:42 | |
| *** mkrai has quit IRC | 10:48 | |
| gibi | bauzas: I don't think we need an RC for a racy func test. It is OK to merge it after GA | 10:48 |
| *** jazeltq has quit IRC | 10:59 | |
| *** ociuhandu has quit IRC | 11:04 | |
| *** ociuhandu has joined #openstack-nova | 11:04 | |
| *** brinzhang has joined #openstack-nova | 11:05 | |
| *** brinzhang_ has quit IRC | 11:08 | |
| *** ociuhandu has quit IRC | 11:10 | |
| *** jsuchome has joined #openstack-nova | 11:12 | |
| *** brinzhang_ has joined #openstack-nova | 11:23 | |
| *** brinzhang has quit IRC | 11:25 | |
| *** mgariepy has quit IRC | 11:44 | |
| *** artom has quit IRC | 11:52 | |
| *** brinzhang has joined #openstack-nova | 11:53 | |
| *** nweinber has joined #openstack-nova | 11:54 | |
| *** brinzhang_ has quit IRC | 11:56 | |
| *** songwenping_ has joined #openstack-nova | 11:58 | |
| bauzas | gibi: okay, after 4560 seconds, no errors were found | 12:00 |
| gibi | bauzas: no error seen in 412 runs | 12:00 |
| gibi | so I agree you fixed it! | 12:01 |
| gibi | nice work | 12:01 |
| *** brinzhang_ has joined #openstack-nova | 12:10 | |
| *** songwenping__ has joined #openstack-nova | 12:10 | |
| *** rpittau|bbl is now known as rpittau | 12:11 | |
| *** ygk_12345 has joined #openstack-nova | 12:12 | |
| *** songwenping_ has quit IRC | 12:13 | |
| *** brinzhang has quit IRC | 12:13 | |
| *** brinzhang_ has quit IRC | 12:13 | |
| *** ociuhandu has joined #openstack-nova | 12:25 | |
| *** raildo has joined #openstack-nova | 12:25 | |
| efried | stephenfin: go ahead and update that commit message. I'm here to re+1, for all the good it'll do ya. | 12:27 |
| *** ociuhandu has quit IRC | 12:28 | |
| *** ociuhandu has joined #openstack-nova | 12:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: config: Explicitly register 'remote_debug' CLI opts https://review.opendev.org/677444 | 12:35 |
| bauzas | stephenfin: https://review.opendev.org/#/c/726087/1 closing https://bugs.launchpad.net/nova/+bug/1877281 | 12:35 |
| openstack | Launchpad bug 1877281 in OpenStack Compute (nova) "vGPU multiple instance creation test is racey" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 12:35 |
| stephenfin | efried: ack, thanks | 12:35 |
| stephenfin | bauzas++ | 12:35 |
| efried | stephenfin: done (with bonus) | 12:37 |
| * stephenfin loves bonus stuff \o/ | 12:38 | |
| stephenfin | bauzas: I have an ask on https://review.opendev.org/#/c/726087/ | 12:39 |
| stephenfin | if you don't want to, I can live with it as-is | 12:40 |
| *** mgariepy has joined #openstack-nova | 12:40 | |
| *** udesale_ has joined #openstack-nova | 12:40 | |
| *** songwenping_ has joined #openstack-nova | 12:42 | |
| *** ratailor has quit IRC | 12:42 | |
| *** ratailor has joined #openstack-nova | 12:43 | |
| *** udesale has quit IRC | 12:43 | |
| bauzas | stephenfin: no worries, I can write a new rev | 12:43 |
| bauzas | there is no urgency to fix this race | 12:44 |
| bauzas | we only get it for around 0.5% | 12:44 |
| *** songwenping__ has quit IRC | 12:45 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Wait for all servers to be active when testing vGPUs https://review.opendev.org/726087 | 12:45 |
| bauzas | stephenfin: fer your plizure ^ | 12:46 |
| stephenfin | +" | 12:46 |
| stephenfin | *2 | 12:46 |
| *** ratailor has quit IRC | 12:56 | |
| *** spatel has joined #openstack-nova | 12:58 | |
| *** lbragstad has joined #openstack-nova | 13:12 | |
| *** ttsiouts has quit IRC | 13:17 | |
| francoisp | bauzas, salut, when you have time: https://review.opendev.org/#/c/725272/ (this time for Rocky) - thanks | 13:18 |
| *** psachin has quit IRC | 13:20 | |
| *** ociuhandu has quit IRC | 13:20 | |
| *** ociuhandu_ has joined #openstack-nova | 13:20 | |
| *** ttsiouts has joined #openstack-nova | 13:21 | |
| *** ttsiouts has quit IRC | 13:25 | |
| *** HagunKim has quit IRC | 13:29 | |
| *** songwenping_ has quit IRC | 13:32 | |
| *** songwenping_ has joined #openstack-nova | 13:32 | |
| *** jhesketh has quit IRC | 13:43 | |
| *** jangutter has joined #openstack-nova | 13:45 | |
| *** artom has joined #openstack-nova | 13:45 | |
| *** artom has quit IRC | 13:46 | |
| *** maciejjozefczyk has quit IRC | 13:46 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:46 | |
| *** artom has joined #openstack-nova | 13:46 | |
| *** jhesketh has joined #openstack-nova | 13:47 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 13:57 | |
| *** maciejjozefczyk has quit IRC | 13:58 | |
| *** belmoreira has quit IRC | 14:00 | |
| *** belmoreira has joined #openstack-nova | 14:00 | |
| *** songwenping_ has quit IRC | 14:06 | |
| *** songwenping_ has joined #openstack-nova | 14:06 | |
| *** ociuhandu_ has quit IRC | 14:09 | |
| *** ociuhandu has joined #openstack-nova | 14:10 | |
| *** slaweq_ has joined #openstack-nova | 14:14 | |
| *** slaweq has quit IRC | 14:14 | |
| *** ociuhandu has quit IRC | 14:15 | |
| *** ygk_12345 has left #openstack-nova | 14:19 | |
| *** ociuhandu has joined #openstack-nova | 14:24 | |
| bauzas | francoisp: ack, will try to do it asap | 14:27 |
| francoisp | bauzas, thank you! | 14:27 |
| *** efried has quit IRC | 14:28 | |
| *** ociuhandu has quit IRC | 14:29 | |
| *** ociuhandu has joined #openstack-nova | 14:29 | |
| *** tosky_ has joined #openstack-nova | 14:29 | |
| *** slaweq_ has quit IRC | 14:32 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | 14:32 |
| *** tosky has quit IRC | 14:32 | |
| *** slaweq has joined #openstack-nova | 14:34 | |
| openstackgerrit | Takashi Kajinami proposed openstack/nova master: Check py3 fix in python-barbicanclient https://review.opendev.org/726164 | 14:36 |
| *** dklyle has joined #openstack-nova | 14:38 | |
| *** tkajinam has quit IRC | 14:43 | |
| *** mriedem has joined #openstack-nova | 14:53 | |
| *** vishalmanchanda has quit IRC | 14:54 | |
| openstackgerrit | Sasha Andonov proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764 | 14:57 |
| *** tosky_ is now known as tosky | 15:04 | |
| *** sapd1_x has joined #openstack-nova | 15:21 | |
| *** jdillaman has quit IRC | 15:23 | |
| *** jdillaman has joined #openstack-nova | 15:24 | |
| *** kaisers_ has quit IRC | 15:25 | |
| *** songwenping__ has joined #openstack-nova | 15:27 | |
| *** songwenping_ has quit IRC | 15:30 | |
| *** gyee has joined #openstack-nova | 15:32 | |
| *** nicolasbock has quit IRC | 15:32 | |
| *** nicolasbock has joined #openstack-nova | 15:32 | |
| *** songwenping_ has joined #openstack-nova | 15:43 | |
| *** songwenping__ has quit IRC | 15:45 | |
| gibi | nova meeting starts in 15 minutes on #openstack-meeting-3 | 15:45 |
| *** priteau has joined #openstack-nova | 15:45 | |
| *** spatel has quit IRC | 15:49 | |
| *** spatel has joined #openstack-nova | 15:50 | |
| *** mgariepy has quit IRC | 15:52 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage db' docs to use proper directives https://review.opendev.org/677509 | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Use proper headers in nova-manage man page https://review.opendev.org/726191 | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage api_db', 'cell_v2' docs https://review.opendev.org/726192 | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage placement' docs https://review.opendev.org/726193 | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Only use section headers for HTML https://review.opendev.org/726194 | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document options for nova-*proxy https://review.opendev.org/726195 | 16:15 |
| *** dtantsur is now known as dtantsur|afk | 16:28 | |
| *** belmoreira has quit IRC | 16:29 | |
| *** jdillaman has quit IRC | 16:32 | |
| *** rpittau is now known as rpittau|afk | 16:34 | |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-nova | 16:36 | |
| *** songwenping__ has joined #openstack-nova | 16:43 | |
| openstackgerrit | Shi Yan proposed openstack/nova master: Fix aggregate placement sync issue https://review.opendev.org/726201 | 16:44 |
| *** songwenping_ has quit IRC | 16:45 | |
| openstackgerrit | Merged openstack/os-vif master: Remove six https://review.opendev.org/724966 | 16:47 |
| openstackgerrit | Merged openstack/os-vif master: Update master for stable/ussuri https://review.opendev.org/724714 | 16:47 |
| openstackgerrit | Merged openstack/os-vif master: Add Python3 victoria unit tests https://review.opendev.org/724715 | 16:47 |
| *** udesale_ has quit IRC | 16:52 | |
| *** derekh has quit IRC | 16:53 | |
| *** jdillaman has joined #openstack-nova | 16:54 | |
| *** mgariepy has joined #openstack-nova | 16:56 | |
| artom | gmann, continuing from #-meeting, yeah, sounds like more discussion would have been nice | 17:01 |
| gmann | stephenfin: gibi py3.8 functional job as voting on check and gate pipeline - https://review.opendev.org/#/c/725372/ | 17:02 |
| artom | I just... I don't get the opposition. Like, yeah, the name could have been better chosen, and yeah, we may want to improve it in the future | 17:02 |
| artom | But as long as we document what it does for the former, and make it evolve-able for the latter, why not do it? | 17:02 |
| stephenfin | gmann: Oh, it works now? I thought there were issues with mock from Python 3.8 | 17:03 |
| melwitt | artom: well, I think we need to know whether it's extendable right? we don't fully understand that yet, do we? | 17:03 |
| gmann | artom: i will say if old things have limit and need more clarity then documenting those is fine but any future thing and we can better design so better design is my preference than going with document-limits | 17:04 |
| *** toabctl has quit IRC | 17:04 | |
| artom | gmann, agreed, but we were pre-empted by projects with lesser standards than ours ;) | 17:04 |
| gmann | stephenfin: i think it worked. let me again check log that it is correctly doing py3.8 | 17:05 |
| melwitt | like can we build a health data cache in that middleware or is there something about it that would preclude doing that? I don't think basic investigation has been done | 17:05 |
| artom | melwitt, so, I'd be OK with just 2 URLs (and I know dansmith will hate me for that) - /healthcheck for unauthed, unversioned HTTP alice checks, and something like /status that's authed and versioned and we can evolve | 17:05 |
| melwitt | that's backward, /status should be the ping check | 17:05 |
| gmann | artom: that is something to fix since starting of openstack :), making uniform things across all projects is still an issue :). | 17:06 |
| melwitt | and so to me seems worse to do that, expose two things that are doing the opposite of their names | 17:06 |
| gmann | stephenfin: it does and worked fine - https://zuul.opendev.org/t/openstack/build/bc80a0fe21354e10b81b1e4a4db35356/log/job-output.txt#1172 | 17:07 |
| artom | melwitt, so find a way for /healthcheck to do both? | 17:07 |
| melwitt | yeah, at least do basic due diligence on it. look at the middleware enough to determine whether we could extend the health check to actually be a health check. or if we would need to expose it some other way in order to be able to extend it. that's mho | 17:08 |
| stephenfin | gmann: okay. comments left | 17:09 |
| gmann | let me do some poc for extend things.but may be next week i will be able to do. so that we can check if current proposed things can be done in compatible way with extendable. | 17:10 |
| stephenfin | who's actually going to work on this extended health check? | 17:10 |
| *** nightmare_unreal has quit IRC | 17:10 | |
| stephenfin | I mean, without someone signed up to do that work, isn't this all effectively bikeshedding? | 17:11 |
| * bauzas missed the consensus about healthcheck, some tl;dr: folks ? | 17:11 | |
| artom | bauzas, 💣 | 17:11 |
| bauzas | \o/ | 17:11 |
| artom | stephenfin, look like gmann wil try it? I kinda wanna have a whack at it too | 17:12 |
| *** salmankhan1 has joined #openstack-nova | 17:13 | |
| melwitt | I'm also willing to help work on it (if need be) since I know at least some operators would want it to be a real health check | 17:13 |
| dansmith | me too, I have some ideas on how to make it useful without requiring auth | 17:14 |
| bauzas | again, a good healthcheck is something about L7 checks | 17:14 |
| bnemec | Not a tldr, but most of the previous discussions are linked on https://storyboard.openstack.org/#!/story/2001439 | 17:14 |
| gmann | +1 | 17:14 |
| bauzas | what dansmith said | 17:14 |
| zigo | There's already some extra parameters to give to /healthcheck with the Accept: header, so we could extend that and add more headers to do deeper checks... | 17:14 |
| bnemec | There's also the detailed opt in the middleware that already allows operators to choose how much they want checked. | 17:15 |
| zigo | X-OpenStack-Check-Type: full-check | 17:15 |
| artom | So we're all just going to have a massive healthcheck party? :) | 17:15 |
| bauzas | this being said, hitting the WSGI nova v2 app could be sufficient IMHO | 17:15 |
| artom | bauzas, that's a '300 multiple choices', not '200 OK', and is different from other projects | 17:15 |
| bauzas | and AFAIK, we can hit it without being auth'd | 17:15 |
| bauzas | artom: I'm just talking of the healthcheck being part of the WSGI app | 17:16 |
| bauzas | and returning 200 | 17:16 |
| bauzas | not operators using the existing app call | 17:16 |
| artom | bauzas, you mean not using the middleware at all? | 17:16 |
| artom | It'd be easier to make it extensible, yah | 17:16 |
| bauzas | the middleware just verifies that the WSGI server runs, honestly | 17:17 |
| bauzas | and even worst, it's now a new app with another endpoint | 17:17 |
| *** salmankhan has quit IRC | 17:17 | |
| bauzas | which means that the wsgi main app can silently drop and the healthcheck would still tell 'heh, fine enough' | 17:17 |
| bauzas | having it as a separate app or a middleware just means (again) that you verify uswgi, that's it | 17:18 |
| *** salmankhan1 has quit IRC | 17:18 | |
| *** ociuhandu has quit IRC | 17:19 | |
| * zigo goes for dinner and will read the backlog later, enjoy trolling folks! :) | 17:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Moving functional jobs to Victoria testing runtime https://review.opendev.org/725372 | 17:25 |
| *** gmann is now known as gmann_afk | 17:25 | |
| *** priteau has quit IRC | 17:25 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Moving functional jobs to Victoria testing runtime https://review.opendev.org/725372 | 17:26 |
| * bauzas goes off too | 17:31 | |
| bauzas | gibi: won't be there tomorrow, yet again bank holiday | 17:32 |
| *** jsuchome has quit IRC | 17:43 | |
| sean-k-mooney | artom: some service allwo the middelware to be customisable other hardcode it | 17:49 |
| sean-k-mooney | im not sure what nova does | 17:50 |
| artom | sean-k-mooney, nova doesn't do anything yet. | 17:50 |
| artom | (And with how things are going, probably never will :P ) | 17:50 |
| sean-k-mooney | artom: i mean in terms of middelware enabling | 17:50 |
| sean-k-mooney | i cant rememebre if we hard code the list or if you can custimise it by a file | 17:50 |
| *** ccamacho has quit IRC | 17:51 | |
| *** ralonsoh has quit IRC | 17:51 | |
| melwitt | I don't think we need to be so negative about it, just want there to be some thought put into what we're doing before pulling the trigger | 17:51 |
| sean-k-mooney | artom: we do some of it via https://github.com/openstack/nova/blob/master/etc/nova/api-paste.ini | 17:52 |
| sean-k-mooney | im not entirly shure how that works but i think we can add more midelware or customise it via that file | 17:53 |
| melwitt | sean-k-mooney: do you know a lot about the middleware? the question I have is would it in anyway preclude us from doing a real health check in the future, such as accessing a cache built lazily in the background containing db/mq etc healthy kind of info? | 17:53 |
| sean-k-mooney | melwitt: i do not | 17:53 |
| sean-k-mooney | i assume we coudl swap out the implemenation in the future | 17:53 |
| sean-k-mooney | with our own version | 17:54 |
| sean-k-mooney | provided it still returned the correct info | 17:54 |
| sean-k-mooney | melwitt: i assume you would want to check if we can still acess the db and if the conductors are alive | 17:55 |
| sean-k-mooney | or something like that | 17:55 |
| melwitt | yeah, something like that. dansmith idea was to gather those lazily while normal requests are going, and an unauth'ed healthcheck could check the cache | 17:55 |
| sean-k-mooney | that sound like it shoudl also be doable i think the current healthcheck midelware would jsut serve to say hay the api is running | 17:55 |
| melwitt | right, as-is it checks whether wsgi is working | 17:56 |
| sean-k-mooney | melwitt: dont we have heartbeats for each service in service groups or something | 17:56 |
| sean-k-mooney | and the status is stored in the db | 17:56 |
| melwitt | and we were talking about having that be the first version, then next we'd extend it to do real health checks | 17:56 |
| *** ociuhandu has joined #openstack-nova | 17:57 | |
| melwitt | and we're looking to have a plan for this and the first thing to know is whether going forward with the middleware way of doing it would lock us in a corner in a way we couldn't extend it | 17:57 |
| melwitt | or if we need to expose /healthcheck in a different way | 17:57 |
| melwitt | we do have heartbeats for each service via the service groups stuff yes | 17:58 |
| sean-k-mooney | melwitt: so this is how neturon enables it | 17:59 |
| sean-k-mooney | https://opendev.org/openstack/neutron/src/branch/master/etc/api-paste.ini#L47-L48 | 17:59 |
| melwitt | gmann_afk is going to investigate next week but since you mentioned the middleware I was curious if you knew more about it already | 17:59 |
| sean-k-mooney | so we could just copy past that | 17:59 |
| sean-k-mooney | and we woudl get healtcheck endpoint | 17:59 |
| melwitt | yeah that's what's proposed already | 17:59 |
| sean-k-mooney | operator can already do that too | 17:59 |
| sean-k-mooney | they just need to add it | 17:59 |
| sean-k-mooney | but then we coudl cange the class to a nova one later | 18:00 |
| sean-k-mooney | so paste.filter_factory = oslo_middleware:Healthcheck.factory would be paste.filter_factory = nova.middelware:Healthcheck.factory | 18:00 |
| sean-k-mooney | or something like that | 18:00 |
| melwitt | ok | 18:00 |
| melwitt | and then present the same header/response options, same interface | 18:01 |
| melwitt | I wonder if we can subclass the middleware, that might be likely. anyway, gmann_afk is gonna figure it out :) | 18:01 |
| sean-k-mooney | cool it looks like this is the midealware code https://opendev.org/openstack/oslo.middleware/src/branch/master/oslo_middleware/healthcheck | 18:02 |
| sean-k-mooney | we could derive form the Healthcheck class i thikn | 18:02 |
| *** ociuhandu has quit IRC | 18:03 | |
| bnemec | Healthcheck is pluggable. | 18:03 |
| sean-k-mooney | then override process_request https://opendev.org/openstack/oslo.middleware/src/branch/master/oslo_middleware/healthcheck/__init__.py#L544 | 18:03 |
| * bnemec does not have context for this yet | 18:03 | |
| sean-k-mooney | bnemec: yes nova does not use the middelware at all by default | 18:04 |
| sean-k-mooney | bnemec: but if we start enabling it we would like something more advanced that check if critical serivce like the scheduler and condcutoer were alive | 18:04 |
| sean-k-mooney | rather then jsut saying yes the api is alive | 18:04 |
| bnemec | Right, I'm saying you don't need to reimplement it, just write a plugin for those checks. | 18:05 |
| sean-k-mooney | bnemec: right and we woudl do that by inheritinbg and then overriding process_request? | 18:05 |
| sean-k-mooney | bnemec: do you have an example we could follow? | 18:05 |
| bnemec | No, it's a stevedore-based plugin system. You just register your plugin in the appropriate namespace. | 18:06 |
| bnemec | https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/__init__.py#L388 | 18:06 |
| sean-k-mooney | bnemec: sure but we dont kwno what the plugin should do | 18:06 |
| sean-k-mooney | e.g. what i shoudl retrun | 18:06 |
| sean-k-mooney | what the api for this is as a user | 18:06 |
| bnemec | https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/pluginbase.py | 18:07 |
| sean-k-mooney | ah perfect | 18:07 |
| sean-k-mooney | so we have to retrun a HealthcheckResult | 18:07 |
| bnemec | Right | 18:08 |
| sean-k-mooney | there are some examples of the respocnes here too https://opendev.org/openstack/oslo.middleware/src/branch/master/oslo_middleware/healthcheck/__init__.py#L68-L163 | 18:08 |
| sean-k-mooney | bnemec: anyway im sure gmann_afk will figure it out or be in touch | 18:10 |
| *** ociuhandu has joined #openstack-nova | 18:11 | |
| sean-k-mooney | bnemec: what i was more interested was if there was a standard way to report erros and infomation when it not healty | 18:11 |
| sean-k-mooney | if not and we ant it to be consumable in an automated fashion then we would have too treat it like a version notification or other api resonce and managen and document it in our api ref | 18:12 |
| sean-k-mooney | https://opendev.org/openstack/oslo.middleware/src/branch/master/oslo_middleware/healthcheck/disable_by_file.py i guess are the example plugins | 18:13 |
| bnemec | Yep, versioning these checks is definitely something we should work out on the spec. | 18:13 |
| bnemec | Looks like it, yeah. | 18:14 |
| sean-k-mooney | yeah so other then establishing conventiosn this look like its not much code to add on our side to have a funtioning plugin | 18:15 |
| sean-k-mooney | then we can just make the healt check more advanced and imporve the info we return iteritivly | 18:15 |
| dansmith | I'm surprised that nobody thinks that exposing python version, gcc version, distro, version, kernel version, etc to everyone unauthenticated is not a huge problem | 18:19 |
| dansmith | because all those things are included in the healthcheck response without any recourse, as far as I can tell | 18:20 |
| artom | dansmith, only if you configure detailed=True in the paste file | 18:20 |
| artom | Which nobody should ever do | 18:20 |
| dansmith | ah, okay, I thought that was a query param | 18:20 |
| artom | It isn't - at least, based on what I saw | 18:21 |
| mriedem | if your healthcheck api would give me some credentials i could do some health checking of my own, thanks | 18:22 |
| dansmith | so the details of the healthchecks aren't either, other than the reason thing | 18:22 |
| dansmith | okay, so in that case, the config causes us to return different data types | 18:25 |
| artom | My own personal healthcheck api is to down a pint of beer. Still awak = 200 OK, pass out = 503 service unavailable | 18:25 |
| *** efried has joined #openstack-nova | 18:26 | |
| dansmith | which is unfortunate.. if nobody should ever turn on detailed=true, then hopefully nothing will ever see the conflicting structure, but.. | 18:26 |
| artom | dansmith, I suppose you could if you're absolutely certain your Nova API endpoints aren't accessible from any unsafe network | 18:26 |
| artom | Like, you trust your firewalls 110% | 18:26 |
| dansmith | hmm, I don't see the if detailed switch in the html version tough | 18:27 |
| *** ociuhandu has quit IRC | 18:27 | |
| dansmith | so the html version is always detailed? | 18:28 |
| dansmith | or maybe the default template doesn't include those things? | 18:28 |
| dansmith | oh I see, conditionals in the template, although I can't eye-parse what that all looks like by default | 18:29 |
| dansmith | ah, I see the if detailed at the top | 18:30 |
| *** efried has quit IRC | 18:30 | |
| *** efried has joined #openstack-nova | 18:31 | |
| *** ociuhandu has joined #openstack-nova | 18:32 | |
| sean-k-mooney | dansmith: so yes detailed is a vaild security consern. im not sure if we are required to exose any of the detailed info you listed | 18:33 |
| sean-k-mooney | dansmith: e.g. if we can retrun different detailed infor per service that is less scare form a security point of view | 18:33 |
| sean-k-mooney | liek the equivalent of a service list | 18:33 |
| dansmith | sean-k-mooney: no, it looks like that's all off unless show_details, but it's one switch to turn on details which then exposes a ton of internals, which may surprise someone | 18:34 |
| sean-k-mooney | ok so other then the last hour or so i have never bother looking at this in detail other then being aware it was configurable via api-paste.ini | 18:35 |
| sean-k-mooney | so im ok with the idea of a healt check api endpoint. but im not sure it we want to use teh default implemantion | 18:35 |
| dansmith | right, well, the fact that it is configurable with api-paste means this is not an emergency :) | 18:35 |
| sean-k-mooney | them more i lean about it the mor ei think no | 18:35 |
| sean-k-mooney | yep | 18:36 |
| sean-k-mooney | operatoer can add it today if they want. if the should is a different matter | 18:36 |
| dansmith | so, it's totally fine to have a spec, get people on the same page here, and make sure we have a plan for how this happens now, soon, and later | 18:36 |
| sean-k-mooney | i thikn with out detailed=true its ok but does not tell you much | 18:36 |
| dansmith | right | 18:36 |
| dansmith | sean-k-mooney: it tells you basically nothing about heath.. other than that, it's great! :) | 18:37 |
| dansmith | *health | 18:37 |
| sean-k-mooney | ya it tells you apache is running or well the wsgi app | 18:37 |
| sean-k-mooney | it does not tell you if nova is working | 18:37 |
| sean-k-mooney | which is where wrighing our own plugin would come in | 18:38 |
| *** ociuhandu has quit IRC | 18:39 | |
| *** spatel has quit IRC | 18:39 | |
| sean-k-mooney | dansmith: since your about can you take a look at https://review.opendev.org/#/c/724188/4 and the follow up | 18:40 |
| *** maciejjozefczyk_ has quit IRC | 18:41 | |
| sean-k-mooney | its jsut silencing the amqp heartbeat warning | 18:41 |
| dansmith | sean-k-mooney: omg, tell me you were the one that wrote "heartbeart" originally | 18:43 |
| sean-k-mooney | hehe for one i think not | 18:43 |
| dansmith | damn. | 18:43 |
| sean-k-mooney | but i mean i would not put it past me that is a very sean thing to do | 18:44 |
| dansmith | sean-k-mooney: jeez, I missed all the typos in the first commit message | 18:45 |
| dansmith | sean-k-mooney: can we please get those fixed since you'regoing to backport I assume? | 18:46 |
| sean-k-mooney | do you want to comment on them | 18:46 |
| dansmith | lemme just fix inline | 18:46 |
| sean-k-mooney | i can can fix them up with the other one | 18:46 |
| sean-k-mooney | dansmith: ya we have a downstream bug for osp 13 so im going to back prot this upstream as far as people are ok with | 18:46 |
| sean-k-mooney | dansmith: want to remvoe the +w on the first patch and ill fix all typos and resubmit shortly | 18:47 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Silence amqp heartbeat warning https://review.opendev.org/724188 | 18:47 |
| dansmith | sean-k-mooney: I just edited the bottom one to kick it out | 18:47 |
| sean-k-mooney | ah ok cool | 18:47 |
| dansmith | sean-k-mooney: I can do the top if you want or you can | 18:47 |
| dansmith | sean-k-mooney: look over that edit I made and then I'll +W | 18:48 |
| sean-k-mooney | damb it i misspelled heartbeats lol | 18:48 |
| dansmith | you also misspelled "damn" :P | 18:49 |
| dansmith | sean-k-mooney: okay re +Wd the bottom one | 18:50 |
| sean-k-mooney | i am honestly surpised i write code that works sometimes. if it wasnt for the fact im consitet in adjcent lines it totally would not work | 18:50 |
| dansmith | I honestly have no idea how you do, so.. there's that at least :) | 18:51 |
| dansmith | keep working on that compiler for English and you'll be set :) | 18:51 |
| dansmith | (and rich) | 18:51 |
| sean-k-mooney | :) | 18:51 |
| openstackgerrit | sean mooney proposed openstack/nova master: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/724725 | 18:56 |
| sean-k-mooney | dansmith: stephenfin ^ ok that should have the typos fixed | 18:56 |
| *** ociuhandu has joined #openstack-nova | 18:56 | |
| dansmith | no need to wake him, I'll get it | 18:56 |
| *** songwenping_ has joined #openstack-nova | 18:57 | |
| sean-k-mooney | are we still holding backport to stable/ussuri until the upstream release by the way | 18:57 |
| * dansmith does't know | 18:58 | |
| sean-k-mooney | this obviosly isnt a RC candiate but ill start preparing the backports tomorow and we can merge them whenever | 18:58 |
| melwitt | yeah there shouldn't be non RC related backports to stable/ussuri until after GA IIRC | 18:59 |
| melwitt | merged I mean | 18:59 |
| sean-k-mooney | cool ill mark the backport as workflow -1 untill after then | 18:59 |
| melwitt | +1 | 18:59 |
| *** songwenping__ has quit IRC | 19:00 | |
| sean-k-mooney | ok im going to get something to eat ttyl | 19:00 |
| *** gmann_afk is now known as gmann | 19:06 | |
| *** sapd1_x has quit IRC | 19:06 | |
| *** ociuhandu has quit IRC | 19:07 | |
| *** ociuhandu has joined #openstack-nova | 19:10 | |
| *** ociuhandu has quit IRC | 19:15 | |
| *** yaawang has quit IRC | 19:16 | |
| *** dpawlik has quit IRC | 19:23 | |
| *** ociuhandu has joined #openstack-nova | 19:59 | |
| *** nweinber has quit IRC | 20:10 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Moving functional jobs to Victoria testing runtime https://review.opendev.org/725372 | 20:21 |
| *** yaawang has joined #openstack-nova | 20:32 | |
| *** tesseract has quit IRC | 20:36 | |
| *** jamesdenton has quit IRC | 20:38 | |
| *** jamesdenton has joined #openstack-nova | 20:38 | |
| *** martinkennelly has quit IRC | 20:47 | |
| *** jangutter_ has joined #openstack-nova | 20:51 | |
| *** jangutter_ has quit IRC | 20:52 | |
| *** jangutter_ has joined #openstack-nova | 20:52 | |
| *** jangutter has quit IRC | 20:54 | |
| *** jangutter has joined #openstack-nova | 20:55 | |
| *** jangutter_ has quit IRC | 20:58 | |
| *** ociuhandu has quit IRC | 21:13 | |
| *** ociuhandu has joined #openstack-nova | 21:14 | |
| *** ociuhandu has quit IRC | 21:19 | |
| *** ociuhandu has joined #openstack-nova | 21:20 | |
| *** hemna has quit IRC | 21:26 | |
| *** ociuhandu has quit IRC | 21:36 | |
| *** ociuhandu has joined #openstack-nova | 21:36 | |
| *** avolkov has quit IRC | 21:38 | |
| *** hemna has joined #openstack-nova | 21:39 | |
| *** ociuhandu has quit IRC | 21:42 | |
| *** raildo has quit IRC | 21:45 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Add retry to cinder API calls related to volume detach https://review.opendev.org/725272 | 21:50 |
| zigo | sean-k-mooney: It's like this in Neutron because I wrote a wrong patch, that method in api-paste.ini is deprecated in the favor of the app thingy. | 21:52 |
| zigo | dansmith: re [ exposing versions of verything ] what I'd like to see happen, with my operator hat, is having the healthcheck be 1/ unauth 2/ only answering for who I decided, that is only from the haproxy IP, with a check of the X-Forwarded-For header to make sure only who I decide can read the healthcheck (ie: not everyone on the internet, just 10.x.x.x in my case). | 21:58 |
| *** xek has quit IRC | 22:04 | |
| *** mriedem has left #openstack-nova | 22:04 | |
| sean-k-mooney | zigo: well api-paste.ini was the old way to config midileware in general | 22:09 |
| sean-k-mooney | its still what nova uses | 22:09 |
| zigo | sean-k-mooney: What's the new way then? | 22:09 |
| sean-k-mooney | mainly because its not broke | 22:10 |
| sean-k-mooney | well im not sure if it has been replace but i know some service decied to not make it configurable and just hard code the middel ware they support | 22:10 |
| sean-k-mooney | so the remove the api-paste.ini file entirely | 22:11 |
| *** slaweq has quit IRC | 22:14 | |
| *** slaweq has joined #openstack-nova | 22:20 | |
| *** slaweq has quit IRC | 22:24 | |
| *** hoonetorg has quit IRC | 22:34 | |
| *** hoonetorg has joined #openstack-nova | 22:46 | |
| *** tkajinam has joined #openstack-nova | 22:49 | |
| *** spotz has quit IRC | 23:16 | |
| *** tosky has quit IRC | 23:36 | |
| *** mlavalle has quit IRC | 23:40 | |
| *** tetsuro has joined #openstack-nova | 23:52 | |
| *** gyee has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!