Thursday, 2020-04-30

« Wednesday, 2020-04-29 Index Friday, 2020-05-01 »
*** mlavalle has quit IRC00:03
*** avolkov has quit IRC00:05
gmannmelwitt: ack. I will check after finishing the testing of policy upgrade check.00:11
melwittawesome thanks00:17
*** ociuhandu has joined #openstack-nova00:24
*** ociuhandu has quit IRC00:30
*** sean-k-mooney has quit IRC00:31
gmanngibi: bauzas : uploaded the upgrade check result of fresh devstack env on patch and those are as expected. tested 3 cases 1. policy file in json format with new defaults only bug scenario http://paste.openstack.org/show/792909/  2. policy file with both defaults present http://paste.openstack.org/show/792910/ 3. policy file generated in yaml format - http://paste.openstack.org/show/792911/00:49
*** sapd1 has quit IRC01:00
*** sapd1 has joined #openstack-nova01:00
gmanncase4: no policy file - http://paste.openstack.org/raw/792913/01:05
*** Liang__ has joined #openstack-nova01:08
*** gyee has quit IRC01:10
openstackgerritxuyuanhao proposed openstack/nova master: the vms can not be force deleted when vm_status is soft-delete and task-state=deleting  https://review.opendev.org/72426002:02
*** tinwood has quit IRC02:10
*** tinwood has joined #openstack-nova02:12
*** maciejjozefczyk has quit IRC02:15
*** maciejjozefczyk has joined #openstack-nova02:15
*** mkrai has joined #openstack-nova02:31
*** JamesBenson has quit IRC02:37
*** mkrai has quit IRC02:51
*** mkrai has joined #openstack-nova02:58
*** JamesBenson has joined #openstack-nova03:05
gmannmelwitt: tested locally and it lgtm from backword compatibility point of view and without microversion. but it is fixing more APIs than listed in commit msg so need test coverage for those.03:12
*** psachin has joined #openstack-nova03:34
*** mkrai has quit IRC03:36
*** mkrai_ has joined #openstack-nova03:36
*** yedongcan has joined #openstack-nova03:50
melwittgotcha thanks gmann03:52
*** dasp_ has joined #openstack-nova03:58
*** dasp has quit IRC04:00
*** amodi has quit IRC04:03
*** ratailor has joined #openstack-nova04:20
*** jangutter_ has quit IRC04:25
*** jangutter has joined #openstack-nova04:26
*** mkrai_ has quit IRC04:30
*** mkrai__ has joined #openstack-nova04:30
*** evrardjp has quit IRC04:35
*** evrardjp has joined #openstack-nova04:36
*** jangutter_ has joined #openstack-nova04:37
*** jangutter has quit IRC04:41
*** JamesBenson has quit IRC04:43
*** gouthamr_ has joined #openstack-nova04:46
*** vishalmanchanda has joined #openstack-nova05:07
*** jangutter_ has quit IRC05:11
*** jmlowe has quit IRC05:15
*** jmlowe has joined #openstack-nova05:26
*** tetsuro has joined #openstack-nova05:29
*** sapd1_x has joined #openstack-nova05:30
*** damien_r has joined #openstack-nova05:36
*** udesale has joined #openstack-nova05:41
*** damien_r has quit IRC05:41
*** dklyle has quit IRC05:57
*** jangutter has joined #openstack-nova06:02
*** ociuhandu has joined #openstack-nova06:03
*** ociuhandu has quit IRC06:07
*** ociuhandu has joined #openstack-nova06:18
*** sapd1_x has quit IRC06:22
*** ociuhandu has quit IRC06:30
*** nightmare_unreal has joined #openstack-nova06:45
*** xek has joined #openstack-nova06:56
*** belmoreira has joined #openstack-nova06:58
*** slaweq has joined #openstack-nova06:58
*** iurygregory has joined #openstack-nova06:58
*** ociuhandu has joined #openstack-nova07:02
*** ociuhandu has quit IRC07:11
*** ociuhandu has joined #openstack-nova07:11
gibigood morning07:12
*** PrinzElvis has joined #openstack-nova07:13
PrinzElvishi all07:13
PrinzElvishttps://www.irccloud.com/pastebin/KYjd5FUo/Rabbitmq_error_from_rocky_to_stein07:15
*** tesseract has joined #openstack-nova07:17
*** ociuhandu has quit IRC07:24
*** ralonsoh has joined #openstack-nova07:27
*** ociuhandu has joined #openstack-nova07:27
*** tosky has joined #openstack-nova07:28
*** rpittau|afk is now known as rpittau07:29
gibiPrinzElvis: the only thing seems a bit strange to me is  "{% endfor %}/{{ om_rpc_vhost }}" as that will be expanded to "//" as om_rpc_vhost is "/"07:29
gibiPrinzElvis: but I'm no way expert on the rabbit config07:30
*** mkrai__ has quit IRC07:32
*** ociuhandu has quit IRC07:39
PrinzElvisgibi: Ok I  removed this "//" in my  "transport_url = rabbit://openstack:2fe0525ec5db4f1b97d4d055527501ec@10.10.1.11:5672,openstack:2fe0525ec5db4f1b97d4d055527501ec@10.10.1.12:5672,openstack:2fe0525ec5db4f1b97d4d055527501ec@10.10.1.13:5672// "07:44
nightmare_unrealartom:  can you have another look at : https://review.opendev.org/#/c/715395/ . Thanks . Also i don't understand what can cause nova-live-migration zuul job to fail ? what does it even check ?07:45
PrinzElvisgibi: and is work07:45
gibiPrinzElvis: then I think the problem is in the ansible code you pasted07:47
gibigmann, dansmith: I'm +2 now on the policy upgrade check patch https://review.opendev.org/#/c/723645/07:49
*** ratailor is now known as ratailor|lunch07:50
*** mkrai__ has joined #openstack-nova07:52
PrinzElvisgibi>  this code is from stable/stein:     https://github.com/openstack/kolla-ansible/blob/stable/stein/ansible/group_vars/all.yml07:52
*** mkrai__ has quit IRC07:54
*** mkrai_ has joined #openstack-nova07:54
*** ociuhandu has joined #openstack-nova07:54
gibiPrinzElvis: I suggest to contact the kolla developers on #openstack-kolla channel07:55
PrinzElvisgibi> Thks07:56
*** damien_r has joined #openstack-nova08:06
*** PrinzElvis has quit IRC08:07
*** PrinzElvis has joined #openstack-nova08:07
*** PrinzElvis has quit IRC08:11
*** PrinzElvis has joined #openstack-nova08:12
*** ccamacho has joined #openstack-nova08:12
*** martinkennelly has joined #openstack-nova08:15
*** avolkov has joined #openstack-nova08:20
*** ratailor|lunch is now known as ratailor08:30
*** Liang__ has quit IRC08:32
*** mkrai_ has quit IRC08:45
*** mkrai__ has joined #openstack-nova08:45
*** jsuchome has joined #openstack-nova08:46
*** N3l1x has quit IRC08:56
*** masterpe has quit IRC08:56
*** ociuhandu has quit IRC08:58
*** ociuhandu has joined #openstack-nova08:58
*** martinkennelly has quit IRC09:00
*** ociuhandu has quit IRC09:04
*** yedongcan has quit IRC09:06
*** ociuhandu has joined #openstack-nova09:16
*** dtantsur|afk is now known as dtantsur09:23
*** derekh has joined #openstack-nova09:25
*** mkrai__ has quit IRC09:28
*** mkrai__ has joined #openstack-nova09:28
*** huaqiang has quit IRC09:36
*** brtknr has quit IRC09:37
*** brtknr has joined #openstack-nova09:42
openstackgerritStephen Finucane proposed openstack/nova master: nova-audit: Use cliff instead of homegrown argparse bleh  https://review.opendev.org/72433209:46
*** masterpe has joined #openstack-nova09:47
*** martinkennelly has joined #openstack-nova10:05
*** ociuhandu has quit IRC10:07
*** ociuhandu has joined #openstack-nova10:13
*** jaosorior has quit IRC10:17
*** huaqiang has joined #openstack-nova10:21
*** rpittau is now known as rpittau|bbl10:21
kashyapsean-k-mooney: Hope my response clarifies on some of our disagreements here: https://review.opendev.org/#/c/631154/710:35
kashyapsean-k-mooney: I wasn't assuming anything particular on your part, but asking to explicitly clarify with me what I meant10:35
kashyapsean-k-mooney: As noted there, at one point in the past, QEMU *did* allow 'i440fx' + plain UEFI boot10:35
kashyap(As noted in the spec comment, Nova doesn't allow that; we know that.  Not debating that at all.)10:36
kashyapAnyway, we can sort it out on the change.  No rush to respond10:36
*** derekh has quit IRC10:41
*** derekh has joined #openstack-nova10:42
*** ociuhandu has quit IRC10:48
*** ociuhandu has joined #openstack-nova10:49
*** mkrai__ has quit IRC11:02
*** rcernin has quit IRC11:06
*** sean-k-mooney has joined #openstack-nova11:07
*** udesale_ has joined #openstack-nova11:12
*** tetsuro has quit IRC11:12
*** ociuhandu has quit IRC11:13
*** ociuhandu has joined #openstack-nova11:14
*** udesale has quit IRC11:15
*** ociuhandu has quit IRC11:18
*** raildo has joined #openstack-nova11:21
artomnightmare_unreal, yeah, I'll look11:43
nightmare_unrealThanks :)11:43
artomnightmare_unreal, nova-live-migration checks... live migration :)11:43
artomIt's unlikely to be related to your patch, most likely random failure11:43
nightmare_unrealyes that's what I meant. WHy it was failing because I didn't touched anything with migration11:44
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430111:49
*** ociuhandu has joined #openstack-nova11:49
*** ociuhandu has quit IRC11:54
*** bbowen_ has joined #openstack-nova11:57
*** bbowen has quit IRC11:57
*** nweinber has joined #openstack-nova11:58
*** maciejjozefczyk_ has joined #openstack-nova12:08
artomnightmare_unreal, somethings things fail :)12:08
*** tkajinam has quit IRC12:09
artomIn this case looks like a server evacuation timed out: https://zuul.opendev.org/t/openstack/build/8ac593dc86074d128b16ae0796e9e458/log/job-output.txt#848112:10
*** ratailor has quit IRC12:10
*** maciejjozefczyk has quit IRC12:11
lyarwoodartom: it failed12:11
*** ociuhandu has joined #openstack-nova12:12
lyarwoodartom: the timeout is just because we are waiting for the instance to go to ACTIVE but it's always in ERROR12:12
artomlyarwood, oh, right12:12
* lyarwood had thought this was fixed12:12
artomIn any case, it cannot possibly because of the changes to nova-manage heal_allocations :)12:12
lyarwood'[' ERROR '!=' ERROR ']'12:13
lyarwooderhm12:13
lyarwoodoh ignore that12:13
lyarwoodartom: but yeah sorry12:14
lyarwoodunrelated12:14
*** rpittau|bbl is now known as rpittau12:22
lyarwoodthis looks like another VIF timeout issue, I wonder if we also need to remove the OVS ports etc before restarting the agents and attempting the rescue.12:22
lyarwoodevacuation even12:22
*** mriedem has joined #openstack-nova12:23
sean-k-mooneylyarwood: you should not need too12:25
*** mkrai has joined #openstack-nova12:25
sean-k-mooneywe cenrtenly cant assume that will happen in a evacuate case12:26
lyarwoodwell the host should be fenced in an evacuation12:27
lyarwoodhttps://review.opendev.org/#/c/723853/ - I was going to add that as a precondition FWIW12:28
lyarwoodbut yeah I don't think that would actually help here12:28
*** rcernin has joined #openstack-nova12:31
*** derekh has quit IRC12:32
*** lpetrut has joined #openstack-nova12:34
*** maciejjozefczyk_ is now known as maciejjozefczyk12:35
*** slaweq has quit IRC12:35
*** slaweq has joined #openstack-nova12:36
*** derekh has joined #openstack-nova12:38
*** slaweq_ has joined #openstack-nova12:38
artomWho handles http://status.openstack.org/reviews/#nova ?12:40
artom"Page refreshed at 2020-03-20 06:38:57 UTC"12:41
artomKinda stale ;)12:41
gibiartom: I suggest to ask infra12:41
*** slaweq has quit IRC12:41
gibiI've noticed the staleness of it but never get the time to dig around12:41
sean-k-mooneyi tink it updates automaticaly nightly12:42
gibiit is just a looooong night :)12:42
sean-k-mooneyoh its 03 not 0412:42
artomYeah, this ain't Game of Thrones12:42
sean-k-mooneyadn the 20th not 30th12:42
sean-k-mooneyya just misreda the date12:43
sean-k-mooneyi mix up numbers much less often then letters but it somethimes happens12:43
*** ociuhandu has quit IRC12:44
*** ociuhandu has joined #openstack-nova12:45
*** dpawlik has joined #openstack-nova12:46
*** dpawlik has quit IRC12:46
*** dpawlik has joined #openstack-nova12:46
kashyapUrgh12:54
kashyapRabit-Holes--12:54
kashyapsean-k-mooney: I'm just reading your comment: right now 'i440fx' with UEFI *does not* work.  I wrote to the OVMF maintainer to ask about what's the deal there12:54
*** lbragstad_ has joined #openstack-nova12:55
sean-k-mooneykashyap: i think it was just not implemented12:55
kashyapsean-k-mooney: So, don't assume that: "it works with both" _today_.  As I mentioned in my comment it was working at _one_ point_ in time...12:55
kashyapsean-k-mooney: So, the core problem is this:12:55
sean-k-mooneygiven its like 20 years old im not suprised it was not a priortiy12:55
kashyapThe 'i440fx' chipset does not have SMM emulation: hence Secure Boot is not possible with it.  If someone adds SMM to 'i440fx', SB should work 'fine' for it.12:56
kashyap(But indeed it's not a priority to do that)12:56
sean-k-mooneykashyap: by the way im not assumeing ti works with both12:57
kashyapI'll comment the rest on the change.12:57
kashyapsean-k-mooney: You say on the change in the past OVMF_CODE.secboot.fd didn't work with 'i440fx'12:57
kashyapThat's of course correct -- it never wored12:57
kashyaps/wored/worked/12:57
*** lbragstad has quit IRC12:57
sean-k-mooneyyes the .secboot one did not12:57
sean-k-mooneyand the release note you quoted state that the OVMF_CODE.fd file did12:58
kashyapThe non-secboot.fd used to work in the past.  Right now, it drops me directly to the UEFI shell.12:58
kashyapsean-k-mooney: Yes, it did in December-2016.  Today, it didn't.  Still checking what's the state of it12:58
kashyapThere's only one responsive OVMF maintainer/developer that I know; and he's terribly overworked12:58
sean-k-mooneywell OVMF_CODE.fd is just uefi firmware12:59
sean-k-mooneysecure boot is an optional feature12:59
sean-k-mooneyit might be that the droped support form loadign the firmware form rom12:59
sean-k-mooneyi think pflash was not supported on i440fx12:59
sean-k-mooneyi tried to get uefi without secure boot wokking with the pc type a few times in teh past13:00
sean-k-mooneybut i have only had success using q3513:00
sean-k-mooneyusing the ovmf binarys in ubuntu 16.04 and 1813:00
sean-k-mooney.0413:00
sean-k-mooneyi have not really gone out of my way to get upstream copies or anything like that but i have had to check uefi stuff on 1-2 ocations in the past and just always ended up going to q3513:01
sean-k-mooneyanyway i think we can ignore that part of the spec as it really not relevent to chanign the default in nova13:02
sean-k-mooneyit is relevent for your secure boot spec but not this one13:03
*** mkrai has quit IRC13:03
kashyap1 sec; bbiab13:09
kashyapsean-k-mooney: I've checked how UEFI / OVMF is built for Ubuntu and Debian and SUSE as part  of some earlier work:13:10
kashyaphttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=93226913:10
openstackDebian bug 932269 in ovmf "Ship the firmware "descriptor files" as part of the 'ovmf' package" [Normal,Fixed]13:10
kashyap(And other bzs)13:10
*** JamesBenson has joined #openstack-nova13:10
sean-k-mooneykashyap: sure but its really not relevent to this spec at all13:11
kashyapIt's all well-known mess.  Anyway, I'm going into a rabbit hole13:11
sean-k-mooneycan we jsut drop this topic and remove it form the spec or put it in the refrences section13:11
kashyapsean-k-mooney: I won't just drop it, I want to highlight the advantage it brings.  Having given talks at various conferences, admins often ask me: 'tell me more about what 'q35' brings'13:12
sean-k-mooneyits not material to the topic of changing the default13:12
kashyapBut anyway, for now I'll take a break...13:12
kashyapsean-k-mooney: Yes, it's not.  Whoever said that?13:12
sean-k-mooneythat what the problem desictiopn section of the spec is ment to cover13:13
kashyapYeah, I'll move it to a separate section - it's just a matter for formatting.  I wasn't intentioanlly making it "part of problem description"13:13
*** lpetrut has quit IRC13:14
sean-k-mooneyok that is what https://github.com/openstack/nova-specs/blob/master/specs/victoria-template.rst#references is for.13:18
artomIf this was an internal call I'd cut you off and move on to the next topic ;)13:19
sean-k-mooneyhehe that is why i said can we drop this topic. i ment talking about it not the content13:19
kashyapsean-k-mooney: Aside: 'pflash' is very much supported on 'i440fx' on QEMU  ("-drive if=pflash")13:22
*** psachin has quit IRC13:22
sean-k-mooneygood to know is it the other way around then. i tought one of the two machine types only supported one option13:23
sean-k-mooneye.g. one supported pflash and the other supproted pflash and rom13:23
sean-k-mooneyso maybe q35 only support rom or i jsut had an error in my libvirt xml when i tried it in the past13:23
kashyapPerhaps; for later reading, if you want to learn more, look up: "Configuring pflash devices for OVMF firmware" (an outstanding 'qemu-devel' thread) -- it has all the truths from a maintainer13:26
*** rcernin has quit IRC13:29
*** mkrai has joined #openstack-nova13:35
*** ociuhandu has quit IRC13:53
*** ociuhandu has joined #openstack-nova13:56
openstackgerritStephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code  https://review.opendev.org/53048714:00
openstackgerritStephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid  https://review.opendev.org/53090514:00
*** eharney has quit IRC14:05
*** eharney has joined #openstack-nova14:13
*** lpetrut has joined #openstack-nova14:13
*** tkajinam has joined #openstack-nova14:16
*** spatel has joined #openstack-nova14:21
*** mkrai has quit IRC14:23
*** dtantsur has quit IRC14:24
*** dtantsur has joined #openstack-nova14:29
*** francoisp has quit IRC14:29
sean-k-mooneystephenfin: my javascript is terible but you know the code injector thing you got use to use for bugzilla. http://paste.openstack.org/show/792950/ fixes gerrit so you can copy text form gerrit comments again14:38
sean-k-mooneyjust create a new rule for code injector with review\.opendev\.org as the host and that as the content14:39
stephenfinOh, sweet. Thanks!14:39
*** grandchild has joined #openstack-nova14:39
*** mlavalle has joined #openstack-nova14:39
sean-k-mooneyacutlly i think i can make it simpler14:40
sean-k-mooneystephenfin: ya so this work and is less dumb http://paste.openstack.org/show/792952/14:43
sean-k-mooneyi proably could just make it modify the one element that was chagne but it works so its fine14:44
*** lpetrut has quit IRC14:46
*** dklyle has joined #openstack-nova14:49
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468414:57
gmanndansmith: replied on this comment if that make sense ?  -https://review.opendev.org/#/c/723645/8/nova/cmd/status.py@39114:58
gmanni think checking single base rule is enough to catch the auto generated file with new default.14:59
gmanndansmith: or we can check for these set of base rule which are default of every other rules - https://github.com/openstack/nova/blob/730eeb5fe002c093a5b477e095c3374457820007/nova/policies/base.py#L48-L5415:00
dansmithgmann: okay, it was genuinely a question, not an assertion that we should do something different.. do we have any policy rules that were added in U that wouldn't be in the policy file unless they were added by the generator?15:00
gmanndansmith: yeah we have few which were made granular.  but if old name rule present in file which will be with old default keep working15:01
gmannexample - https://github.com/openstack/nova/blob/master/nova/policies/agents.py15:02
*** slaweq_ is now known as slaweq15:03
gmann'os_compute_api:os-agents' was old and 'os_compute_api:os-agents:*' are new rule15:03
dansmithgmann: yeah, so if we have a totally new rule name, and that's in the file with the new default value, then that's a really good indication that they just generated the file right?15:04
dansmithgmann: I guess the other way to look at it is: if we check *all* the rules, and warn if any are scope-checing, but the config doesn't have scope turned on, then that's a warning, regardless right?15:05
gmanndansmith: yeah and SYSTEM_ADMIN_API which are checking is also new rule.15:05
dansmithmeaning, regardless of whether they generated the file, or if they think they've written the policy file correctly15:05
gmannenforce_scope value check i can add. so checking all the base rule which are defaults for all other rules with enforce_scope check can cover that case also - https://github.com/openstack/nova/blob/730eeb5fe002c093a5b477e095c3374457820007/nova/policies/base.py#L48-L5415:08
*** xek has quit IRC15:08
dansmithokay15:08
gmannotherwise verifying the whole file with correct or not is very difficult as they can have their own new override value with scope or without15:08
dansmithI know, but if they do so with scope, but have scope disabled, that won't work right?15:09
dansmithor do you just mean that parsing all the potential options is difficult?15:09
gmannyeah parsing.15:09
dansmitheither way, it's fine.. if system_admin_api is new, and you check the config variable, then that's good enough I think15:09
dansmithokay, gotcha15:09
gmannok, modifying.15:10
dansmiththanks for doing this15:10
gmanndansmith: np!, thanks for all those review, learnt a lot of thing on upgrade stuff :)15:11
dansmith:)15:11
*** salmankhan has joined #openstack-nova15:20
openstackgerritMerged openstack/nova stable/stein: Add retry to cinder API calls related to volume detach  https://review.opendev.org/72278315:23
*** gyee has joined #openstack-nova15:35
*** sapd1_x has joined #openstack-nova15:37
*** hemna has quit IRC15:38
*** hemna has joined #openstack-nova15:38
kashyapsean-k-mooney: FYI, one last on this: i440fx + regular UEFI boot (with OVMF) is a valid upstream configuration -- OVMF maintainer just confirmed15:41
kashyapsean-k-mooney: I just did a fresh test, and it works.  (Previously, my test was broken: I didn't have an EFI partition)15:41
openstackgerritStephen Finucane proposed openstack/nova master: WIP: objects: Add migrate-on-load behavior for legacy NUMA objects  https://review.opendev.org/72438115:41
kashyapsean-k-mooney: Evidence: https://kashyapc.fedorapeople.org/libvirt_plain_UEFI_i440fx_f31_a.xml and https://kashyapc.fedorapeople.org/QEMU_plain_UEFI_i440fx_f31_a.txt15:42
*** ioni has quit IRC15:43
*** sapd1_x has quit IRC15:44
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468415:47
*** belmoreira has quit IRC15:49
gibinova meeting starts in less then 10 minutes on #openstack-meeting-315:50
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468415:51
melwittelod, lyarwood: could I pls get review on https://review.opendev.org/723050 when you have a chance later?16:04
lyarwoodmelwitt: ack looking16:05
elodmelwitt: will do that in ~1-2 hrs16:06
melwittthanks16:07
*** rpittau is now known as rpittau|afk16:07
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468416:10
sean-k-mooneykashyap: ok i guess i just has an invalid config i was try to convert an existing instance but now that i think about it i proably also did not have a biosboot partion or a gpt partion table for that matter in the vm since it was originally booted wit a legacy bios16:15
sean-k-mooneyso ya that is proably the same issue i hit16:16
kashyapYes, having an EFI partition is critical :)16:16
* kashyap bbiab16:16
*** tbachman has quit IRC16:23
*** tbachman has joined #openstack-nova16:24
stephenfinlyarwood, melwitt: Two noddy patches for a stable core here https://review.opendev.org/#/c/722961/ https://review.opendev.org/#/c/722962/16:25
* lyarwood wonders if noddy translates for people in NA16:26
lyarwoodstephenfin: ack looking16:26
lyarwoodoh openstack/placement16:27
lyarwoodstephenfin: I'm not a stable core theree16:27
lyarwoodthere*16:27
stephenfinthen who is?16:27
stephenfinI honestly expected to be in that group :/16:27
melwittah, me neither. and no I did not know the word "noddy" :)16:27
lyarwoodI now have the song stuck in my head, thanks stephenfin16:28
lyarwoodstephenfin: https://review.opendev.org/#/admin/groups/1938,members - we might want to fix this16:29
lyarwoodstephenfin: something for the ptg, the project just came up in the meeting anyway FWIW16:29
*** ociuhandu has quit IRC16:30
lyarwoodstephenfin: https://review.opendev.org/#/admin/groups/1936,members - tbh you and others who are already cores should be copied across16:30
*** haleyb has quit IRC16:31
stephenfinefried: any chance of adding nova-stable-maint to placement-stable-maint, assuming you think that makes sense?16:32
lyarwoodor that16:32
stephenfinwhy wait ¯\_(ツ)_/¯16:32
stephenfinefried: https://review.opendev.org/#/admin/groups/540,members and https://review.opendev.org/#/admin/groups/1938,members fwiw16:33
*** tkajinam has quit IRC16:34
*** evrardjp has quit IRC16:35
*** evrardjp has joined #openstack-nova16:36
efriedstephenfin: I don't think I haven any control over stable anything.16:36
stephenfinyou're in placement-stable-maint so this might be the sole exception :)16:37
*** ioni has joined #openstack-nova16:37
efriedo rite16:37
*** udesale_ has quit IRC16:39
efriedstephenfin: I don't think it makes sense to include by group. I could cherry pick names that make sense, like dansmith and melwitt. But if someone is in nova-stable-maint but not in stable-maint-core it's because they know nova, which doesn't necessarily mean they know placement.16:40
efriedAdded dansmith and melwitt.16:41
stephenfinI've found these things to be self-selecting, personally. I'm stable core in all oslo stuff but there are backports I won't touch with a stick because I don't grok them (anything oslo.concurrency, for one)16:41
stephenfinbut that's fair16:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72364516:44
efriedHaving had two no-longer-working-in-openstack names on the list before was understandably brittle, esp considering stable-maint-core really only has one member who's active. But Dan and Mel should be able to bootstrap it from here as appropriate.16:44
*** haleyb has joined #openstack-nova16:45
*** lbragstad_ is now known as lbragstad16:46
gibiefried: thanks for fixing that up16:46
dansmithbauzas: are these proposed yet? I don't see them if you're the owner16:48
bauzasdansmith: artom16:48
bauzasdansmith: https://review.opendev.org/#/q/topic:placement-audit-backport+(status:open+OR+status:merged)16:49
bauzashe proposed the patches, I just expressed the opportunity to un-DNM them16:49
dansmiththat's quite a stack of dependencies too16:50
artomdansmith, the stein one is the last self-contained one, and even then it's kinda fugly16:50
artomrocky's a horror (picture show)16:50
artom:D16:50
openstackgerritGhanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72364516:53
*** maciejjozefczyk has quit IRC16:54
dansmithartom: so looking at it, the train one isn't terrible, and if it's really likely that people will need this then I guess it's okay, although I feel like having outstanding issues would be a stronger case17:04
dansmithespecially since they can fix one-off issues with osc-placement quite easy, and there are community tools to do it17:04
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/ussuri: Update .gitreview for stable/ussuri  https://review.opendev.org/72471217:04
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri  https://review.opendev.org/72471317:04
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Update master for stable/ussuri  https://review.opendev.org/72471417:04
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Add Python3 victoria unit tests  https://review.opendev.org/72471517:04
artomdansmith, so, full disclosure, I don't really care one or another :P17:04
dansmiththe stein one, while self-contained is already pretty smelly17:04
artomdansmith, as I said, it was purely procedural for me - I wanted to do it one release at a time, and upstream CI on it17:05
dansmithand beyond stein I think it's unreasonable without a major issue, personally17:05
dansmithartom: ack17:05
bauzaslemme look why we needed this command17:05
bauzasie. which bugs leaked the allocations17:05
bauzassome of them were old and are fixed, some of them still exist IIRC17:05
artomdansmith, so I'd be perfectly comfortable doing it downstream-only17:06
*** dtantsur is now known as dtantsur|afk17:06
artomdansmith, assuming you don't destroy the case for that as well ;)17:06
artomI probably didn't do enough "due diligence", and just blindly went ahead and started cherry-picking17:06
*** nightmare_unreal has quit IRC17:06
dansmithartom: you know I just love crushing hopes and dreams right?17:06
dansmith(I really don't despite what you probably think)17:06
artomdansmith, I know. How do you think I became such an empty husk? :)17:07
* dansmith sobs in the corner17:07
bauzashttps://review.opendev.org/#/c/670112/14/nova/tests/functional/test_nova_manage.py are the cases we verify17:07
* bauzas wishes he could have noted as a comment which bugs those checks were related17:08
bauzasso I've tested three cases17:16
openstackgerritStephen Finucane proposed openstack/nova master: docs: Note the ``hw_numa_nodes`` image property  https://review.opendev.org/68384917:16
bauzas1/ deleted instances leak allocations17:16
bauzas2/ resize confirm can also leak allocations17:16
bauzas3/ deleted compute evacuate too17:17
bauzasnow, the question is, which bugs are those 3 checks related with ?17:17
bauzasthe last one is easy17:17
*** tesseract has quit IRC17:17
bauzashttps://bugs.launchpad.net/nova/+bug/182947917:18
openstackLaunchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)17:18
bauzasdansmith: artom: just to finish, I think https://bugs.launchpad.net/nova/+bug/1829479 impacts all releases up to now17:22
openstackLaunchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)17:22
bauzaswhich makes the audit command a good workaround for it17:22
bauzasanyway, /me disappears17:22
dansmithokay I'm confused.. are we still arguing to backport this or what?17:22
dansmithdid we fix the leak due to evacuation or are we saying the fix for that is just to have the audit command?17:23
dansmithobviously for things that happened before such a fix, audit could help17:24
bauzasdansmith: nope, we haven't fixed it yet17:26
dansmithokay I would be in favor of backporting *that* :)17:26
bauzasthe audit command just cleans the mess17:26
bauzasanyway, I need a beer17:28
*** vishalmanchanda has quit IRC17:29
*** dpawlik has quit IRC17:38
*** salmankhan1 has joined #openstack-nova17:44
*** salmankhan has quit IRC17:47
mriedemhttps://review.opendev.org/#/c/678100/17:49
*** salmankhan has joined #openstack-nova17:50
*** salmankhan1 has quit IRC17:51
*** jsuchome has quit IRC17:54
openstackgerritsean mooney proposed openstack/nova master: [DNM] testing with force_legacy_port_binding workaround  https://review.opendev.org/72438717:57
*** salmankhan has quit IRC18:01
* bauzas wonders if invoking evacuate issues three times will make mriedem appear in a mirror18:01
melwittmriedem: want an e-r stat? https://review.opendev.org/72471918:03
*** ociuhandu has joined #openstack-nova18:03
mriedembauzas: no just linking in bugs that are assigned to me18:04
*** ccamacho has quit IRC18:08
mriedemmelwitt: commented18:08
*** ociuhandu has quit IRC18:08
mriedemit's weird but the before and after on that query are on the same change, and in the new query they are all coming from the same file (n-cpu in the subnode)18:08
mriedemis that expected?18:09
mriedemwas qemu or libvirt bumped in devstack on master?18:09
melwittmriedem: ah dangit ... I focused on the error log message and didn't notice the warning log is what's in the e-r query. so the query doesn't need an update. sorry :(18:11
openstackgerritsean mooney proposed openstack/nova master: silence amqp heartbeat warning  https://review.opendev.org/72418818:13
openstackgerritsean mooney proposed openstack/nova master: remove support of oslo.messagiang 9.8.0 warning message  https://review.opendev.org/72472518:13
melwittand since the bug was greyed out on http://status.openstack.org/elastic-recheck/#1840159 at the time, that reinforced my thinking that the query didn't pick it up. sigh18:13
*** ociuhandu has joined #openstack-nova18:15
mriedem\o/18:21
*** jmlowe has quit IRC18:24
*** jmlowe has joined #openstack-nova18:27
gmanndansmith: gibi this is ready - https://review.opendev.org/#/c/723645/18:33
*** ralonsoh has quit IRC18:38
*** gyee has quit IRC18:45
dansmithgmann: a couple more wording clarification tings18:49
dansmith*things18:49
*** gyee has joined #openstack-nova18:55
*** hemna has quit IRC19:07
*** hemna has joined #openstack-nova19:07
openstackgerritGhanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72364519:18
gmanndansmith: updated ^^19:18
*** damien_r has quit IRC19:18
dansmithgmann: okay lemme just fix another thing in-line to avoid you having to do it19:19
gmanndansmith: sure, thanks19:20
dansmithgmann: is it "recommended" or "required" to enable enforce_scope if you have scope checking rules?19:20
dansmithI thought required19:21
gmanndansmith: this is separate flaf not scope one - enforce_new_defaults19:21
gmannflag19:21
gmannto switch to new default without overwriting the file19:21
dansmithgmann: right, but if you have scope-checking rules and want to keep them, then you need enforce_scope=True right?19:22
dansmithyou're checking enforce_scope, but if that's disabled, you tell them to enable enforce_new_defaults19:22
gmanndansmith: ok, so enforce_scope=True is required and (enforce_new_defaults=True OR  file overwrite) to move to new things19:23
dansmithright, I think you're telling them the wrong thing19:23
dansmithlet me comment for context and you can see if I'm right19:23
gmannin that sentence i was targeting only file overwrite alternate via flag19:23
gmannbut i agree we can add enforce_scope=True also for full context19:24
dansmithbut the sentence is about keeping the new format19:25
dansmithU cinnebted19:25
dansmithwhoa19:25
dansmith"I commented"19:25
*** derekh has quit IRC19:25
gmanndansmith: replied,  https://review.opendev.org/#/c/723645/11/nova/cmd/status.py@35819:33
gmannadded scope and new flag way.19:33
dansmithgmann: ++19:34
gmannmy intention is they are aware of new flag enforce_new_defaults t o avoid legacy way of overwriting the file to new default19:34
dansmithgmann: I will try really hard to +2 the next one19:34
gmannok, updating.19:34
dansmithgmann: ack, I just think the message should include the error, and "how to fix the error"19:34
openstackgerritGhanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72364519:40
gmanndansmith: ^^ updated19:41
dansmithgmann: I think you forgot to remove the old sentence19:44
gmannohh :(19:45
dansmithotherwise that looks good to me19:45
dansmithmelwitt: you around to help me put gmann out of his misery?19:46
openstackgerritGhanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72364519:47
gmanndansmith: done, sorry for that.19:47
dansmithgmann: thanks for your patience with me, +2d19:47
dansmithmelwitt: ^19:47
dansmithI gotta stretch my legs, bbl19:48
gmanndansmith: thanks19:49
melwittyeah I'll get it19:51
*** ociuhandu has quit IRC19:57
*** slaweq has quit IRC19:57
*** ociuhandu has joined #openstack-nova19:58
*** slaweq has joined #openstack-nova19:58
*** ociuhandu has quit IRC20:03
*** ociuhandu has joined #openstack-nova20:07
melwittgmann: I found some misspellings and grammar things and what seem to be a few bugs, but I also suggested some additional info. let me know what you think. if you agree with them, I can update and approve if you want. I know you have been through a lot of updates with the policy docs things20:13
gmannmelwitt: ok, checking..20:13
melwittthe main thing I'm worried about is if operators just enable enforce_scope = True when they see the status check, without realizing that means end users will have to request scoped tokens from keystone in order to access the formerly admin, now system scoped admin APIs. if I understand correctly20:15
*** mgariepy has quit IRC20:22
*** umbSublime has joined #openstack-nova20:26
*** slaweq has quit IRC20:29
*** mgariepy has joined #openstack-nova20:32
gmannmelwitt: thanks. replied. i linked the new doc there which i can move on those line so that they have complete steps info.20:33
gmannmentioning those in upgrade checks is too much as they need to do read-only roles things also.20:34
gmannis that fine ?20:34
melwittI dunno ... will depend on how carefully the operators regard that message20:35
melwittwe can try it, just let's be ready for when/if people miss the "you have to request scoped tokens" part20:36
melwittlike blarg admin APIs no longer work!20:37
gmannok, let me add those lines and then doc link.20:37
melwittI could be wrong. let's just say I've been burned by not 100% overly clear reno/tool output ... nova-consoleauth *cough cough*20:38
*** raildo_ has joined #openstack-nova20:46
*** martinkennelly has quit IRC20:46
*** martinkennelly has joined #openstack-nova20:47
*** raildo has quit IRC20:49
*** cgoncalves has quit IRC20:53
*** Jeffrey4l has quit IRC20:53
*** gary_perkins has quit IRC20:53
*** johanssone has quit IRC20:53
*** openstackgerrit has quit IRC20:53
*** gary_perkins has joined #openstack-nova20:53
*** Jeffrey4l has joined #openstack-nova20:53
*** johanssone has joined #openstack-nova20:54
*** cgoncalves has joined #openstack-nova20:55
*** sean-k-mooney has quit IRC20:58
*** sean-k-mooney has joined #openstack-nova21:05
*** smcginnis has quit IRC21:06
*** smcginnis has joined #openstack-nova21:07
*** nweinber has quit IRC21:17
*** raildo_ has quit IRC21:19
gmannmelwitt: ^^ updated, please check if looks fine. linked the main doc as 'educate' in reno but in upgrade check msg i need to paste the complete link - https://review.opendev.org/#/c/723645/1521:22
melwittgmann: thanks. weird it didn't post an update in channel21:26
melwittoh our gerritbot left21:26
gmannmelwitt: yeah i was also surprised initially and rechecking my local branch that i did submit or not :)21:28
melwitthaha yeah21:28
melwittI mentioned it in #opendev21:28
melwittgmann: the updates look good. I will watch in zuul so I can sanity check the generated doc previews and then I'll approve it after that21:31
gmannmelwitt: sure, thanks21:31
*** mriedem has quit IRC21:39
*** mriedem has joined #openstack-nova21:39
*** mriedem has left #openstack-nova21:40
*** grandchild has quit IRC21:40
*** openstackgerrit has joined #openstack-nova21:40
openstackgerritGhanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation  https://review.opendev.org/72239221:40
gmannworking now \o/21:41
gmannsean-k-mooney: ^^ updated as per your comment on 72239221:41
sean-k-mooneyyep looking now21:41
sean-k-mooneyomg you have a white space how coudl you :P https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst@2921:42
sean-k-mooneygmann: if you have time to fix https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst those nits im happy with the content21:46
openstackgerritGhanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation  https://review.opendev.org/72239221:46
gmannsean-k-mooney: done21:46
sean-k-mooneyawsome21:47
sean-k-mooneyah i see you have already rechecked the other patch21:47
sean-k-mooneyi proably got lost with the zuul restart21:47
gmannyeah, i thought that was merged21:48
sean-k-mooneyya same21:48
sean-k-mooneyi guess not but it should merge soon21:48
sean-k-mooneythen we can merge stephens cahnge which is blocked by that21:49
gmannsean-k-mooney: seems we need to backport that on ussuri brach also -  https://review.opendev.org/#/c/724712/21:51
sean-k-mooneyya that makes sense i dont think we cap the sphinx version in the upperconstratit to prevent the issue21:52
gmannwe missed to recheck the fix and ussuri release one merged first - https://review.opendev.org/#/c/723687/21:53
sean-k-mooneyya one it merges on master we can cherry pick it and fast appove21:55
sean-k-mooneythen rebase teh git review patch on top21:55
sean-k-mooneyim not sure if i will be around much longer today be we can get that done tommorow21:55
gmann+121:58
*** rcernin has joined #openstack-nova22:04
*** larainema has quit IRC22:05
openstackgerritMerged openstack/nova stable/ussuri: zuul: Switch to the Zuulv3 grenade job  https://review.opendev.org/72418922:14
melwittgmann: added a comment on the nova-status review, I had been thinking the non-existent policy file would also result in taking all of the defaults22:20
*** ociuhandu has quit IRC22:29
*** ociuhandu has joined #openstack-nova22:30
*** martinkennelly has quit IRC22:31
*** rcernin has quit IRC22:33
*** rcernin has joined #openstack-nova22:34
*** ociuhandu has quit IRC22:35
*** tkajinam has joined #openstack-nova22:46
*** tbachman has quit IRC22:49
*** tbachman has joined #openstack-nova22:52
*** tosky has quit IRC23:11
*** spatel has quit IRC23:17
gmannmelwitt: sorry, I was away.23:22
gmannyou mean file location in nova.conf but does not exist or with defaults conf (oslo_policy.policy_file) with no file.23:23
*** tkajinam has quit IRC23:43
*** tkajinam has joined #openstack-nova23:43
melwittgmann: um... I'm not sure, I just meant like when there's no policy.json file, it uses the defaults in code?23:48
*** ociuhandu has joined #openstack-nova23:57
« Wednesday, 2020-04-29 Index Friday, 2020-05-01 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!