Friday, 2020-04-17

« Thursday, 2020-04-16 Index Saturday, 2020-04-18 »
*** tetsuro has joined #openstack-nova00:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Add docs and releasenotes for BP policy-defaults-refresh  https://review.opendev.org/72012900:37
gmannlbragstad: can you verify the steps for migration to new policy. I cannot find the keystone exact doc please let me know if there is any so that i can link that in my doc - https://review.opendev.org/#/c/720129/4..5/doc/source/configuration/policy-new-defaults.rst@22700:40
*** derekh has quit IRC00:42
*** maohongbo1 has joined #openstack-nova00:48
*** maohongbo has quit IRC00:50
*** maohongbo1 is now known as maohongbo00:50
openstackgerritmelanie witt proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest  https://review.opendev.org/52810400:51
lbragstadgmann sounds good - i'm about to pick up the review i started earlier for https://review.opendev.org/#/c/720129/4/doc/source/configuration/policy-new-defaults.rst00:53
lbragstadi'll take a look at the new patch set00:53
*** ociuhandu has joined #openstack-nova01:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage db purge to nova-audit  https://review.opendev.org/70878301:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage db archive_deleted_rows to nova-audit  https://review.opendev.org/70878401:02
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage cell_v2 discover_hosts to nova-manage  https://review.opendev.org/70878501:02
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage cell_v2 map_instances to nova-audit  https://review.opendev.org/70878601:02
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage placement sync_aggregates to nova-audit  https://review.opendev.org/70878701:02
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit  https://review.opendev.org/70878801:02
*** maohongbo1 has joined #openstack-nova01:04
*** ociuhandu has quit IRC01:05
*** maohongbo has quit IRC01:06
*** maohongbo1 is now known as maohongbo01:06
*** Liang__ has joined #openstack-nova01:10
openstackgerritMerged openstack/nova-specs master: Cleanup py27 support  https://review.opendev.org/71836801:20
*** maohongbo1 has joined #openstack-nova01:28
*** maohongbo has quit IRC01:30
*** maohongbo1 is now known as maohongbo01:30
*** maohongbo1 has joined #openstack-nova01:36
*** maohongbo has quit IRC01:38
*** maohongbo1 is now known as maohongbo01:38
*** yaawang has quit IRC01:46
*** yaawang has joined #openstack-nova01:47
*** yaawang has quit IRC01:52
*** yaawang has joined #openstack-nova01:53
*** sapd1 has quit IRC01:53
openstackgerritBrin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor  https://review.opendev.org/72043902:03
*** tetsuro has quit IRC02:06
openstackgerritBrin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor  https://review.opendev.org/72043902:07
*** maohongbo has quit IRC02:08
*** maohongbo has joined #openstack-nova02:08
*** tetsuro has joined #openstack-nova02:12
openstackgerritBrin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication'  https://review.opendev.org/71972002:23
*** rambo_li has joined #openstack-nova02:24
*** sapd1 has joined #openstack-nova02:31
rambo_lisean-k-mooney: maybe their is an error, for the bug :https://bugs.launchpad.net/nova/+bug/1841932. when we set the metadata "hide_hypervisor_id=true"in aggreate,so we will go to the https://github.com/openstack/nova/blob/46a3bcd80b41e99ec4923c7cf3d0f8dd8505e97c/nova/scheduler/filters/aggregate_instance_extra_specs.py#L69-L71, but this should not break, because the aggregate_val doesn't match the req.02:31
openstackLaunchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,New]02:31
*** igordc has joined #openstack-nova02:46
rambo_limaybe we should delete the for loop in https://github.com/openstack/nova/blob/46a3bcd80b41e99ec4923c7cf3d0f8dd8505e97c/nova/scheduler/filters/aggregate_instance_extra_specs.py#L6902:48
*** mkrai has joined #openstack-nova02:50
openstackgerritMerged openstack/os-traits master: Cleanup py27 support  https://review.opendev.org/71935002:51
*** igordc has quit IRC02:52
*** igordc has joined #openstack-nova02:52
*** igordc has quit IRC02:57
openstackgerritBrin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor  https://review.opendev.org/72043903:06
*** rcernin has quit IRC03:10
*** psachin has joined #openstack-nova03:17
*** rcernin has joined #openstack-nova03:24
*** ttsiouts_ has joined #openstack-nova03:31
*** ttsiouts has quit IRC03:34
*** rambo_li has quit IRC03:35
*** yaawang has quit IRC03:40
*** yaawang has joined #openstack-nova03:41
*** ociuhandu has joined #openstack-nova03:44
*** ociuhandu has quit IRC03:49
*** tetsuro has quit IRC03:51
*** rambo_li has joined #openstack-nova03:54
*** rambo_li has quit IRC04:14
*** rambo_li has joined #openstack-nova04:17
*** evrardjp has quit IRC04:37
*** evrardjp has joined #openstack-nova04:37
*** kevinz has joined #openstack-nova04:42
*** mkrai has quit IRC04:53
*** mkrai has joined #openstack-nova04:54
*** mkrai has quit IRC04:56
*** mkrai has joined #openstack-nova04:57
*** mnasiadka has quit IRC05:10
*** Anticimex has quit IRC05:10
*** tinwood has quit IRC05:10
*** elod has quit IRC05:10
*** tetsuro has joined #openstack-nova05:13
*** mnasiadka has joined #openstack-nova05:15
*** Anticimex has joined #openstack-nova05:15
*** tinwood has joined #openstack-nova05:15
*** elod has joined #openstack-nova05:15
*** rambo_li has quit IRC05:24
*** ratailor has joined #openstack-nova05:24
*** mkrai_ has joined #openstack-nova05:33
*** mkrai has quit IRC05:33
*** udesale has joined #openstack-nova05:35
*** ociuhandu has joined #openstack-nova05:37
*** mkrai_ has quit IRC05:37
*** rambo_li has joined #openstack-nova05:42
*** ociuhandu has quit IRC05:47
*** gyee has quit IRC05:53
*** mkrai has joined #openstack-nova06:02
*** mkrai has quit IRC06:10
*** mkrai_ has joined #openstack-nova06:10
*** dklyle has quit IRC06:26
*** udesale has quit IRC06:26
*** udesale has joined #openstack-nova06:32
brinzhanggibi, bauzas: I open a new bug https://bugs.launchpad.net/nova/+bug/1873387, please check while you are wake up.06:36
openstackLaunchpad bug 1873387 in OpenStack Compute (nova) "Unable to delete instance because cyborg.get_client() failed" [Medium,Confirmed] - Assigned to Brin Zhang (zhangbailin)06:36
*** xek has joined #openstack-nova06:36
*** ociuhandu has joined #openstack-nova06:37
*** ociuhandu has quit IRC06:43
gibibrinzhang: thanks for finding that bug06:45
gibibrinzhang: I marked it as ussuri-rc-potential as it is a new regression in Ussuri06:46
brinzhanggibi: Got it06:51
brinzhangthanks06:51
*** maohongbo1 has joined #openstack-nova06:51
*** maohongbo has quit IRC06:54
*** maohongbo1 is now known as maohongbo06:54
*** spatel has joined #openstack-nova06:55
*** links has joined #openstack-nova07:00
*** spatel has quit IRC07:00
*** nightmare_unreal has joined #openstack-nova07:02
*** jhesketh has quit IRC07:04
*** ociuhandu has joined #openstack-nova07:09
*** slaweq has joined #openstack-nova07:11
*** maohongbo1 has joined #openstack-nova07:14
*** maohongbo has quit IRC07:15
*** maohongbo1 is now known as maohongbo07:15
*** tesseract has joined #openstack-nova07:17
*** rpittau|afk is now known as rpittau07:19
*** maciejjozefczyk has joined #openstack-nova07:24
brinzhanggibi: for bug 1872934 we pushed the fix patch https://review.opendev.org/#/c/720439/, please review if you are free07:29
openstackbug 1872934 in OpenStack Compute (nova) "Accurately clean up ARQs resources during build_instances() in conductor" [Low,In progress] https://launchpad.net/bugs/1872934 - Assigned to Brin Zhang (zhangbailin)07:29
*** tosky has joined #openstack-nova07:30
*** ociuhandu has quit IRC07:30
*** harsha24 has joined #openstack-nova07:36
*** ralonsoh has joined #openstack-nova07:38
*** maohongbo has quit IRC07:49
*** maohongbo1 has joined #openstack-nova07:49
*** maohongbo1 is now known as maohongbo07:51
*** ccamacho has joined #openstack-nova07:56
*** threestrands has quit IRC07:56
*** derekh has joined #openstack-nova08:02
*** ociuhandu has joined #openstack-nova08:04
*** ttsiouts_ has quit IRC08:11
*** dtantsur|afk is now known as dtantsur08:13
*** lbragstad_ has joined #openstack-nova08:17
*** lbragstad has quit IRC08:20
*** ttsiouts has joined #openstack-nova08:21
*** tetsuro has quit IRC08:22
*** ociuhandu has quit IRC08:23
*** ociuhandu has joined #openstack-nova08:23
*** maciejjozefczyk has quit IRC08:37
*** maciejjozefczyk has joined #openstack-nova08:39
*** harsha24 has quit IRC08:41
*** sapd1 has quit IRC08:41
*** derekh has quit IRC08:43
*** ociuhandu has quit IRC08:45
*** ttsiouts has quit IRC08:47
*** maohongbo1 has joined #openstack-nova08:48
*** maohongbo has quit IRC08:48
*** maohongbo1 is now known as maohongbo08:49
*** tkajinam has quit IRC08:51
*** derekh has joined #openstack-nova08:56
*** ttsiouts has joined #openstack-nova09:00
*** mkrai_ has quit IRC09:01
*** maohongbo1 has joined #openstack-nova09:11
*** maohongbo has quit IRC09:12
*** maohongbo1 is now known as maohongbo09:12
*** ttsiouts has quit IRC09:16
openstackgerritWenping Song proposed openstack/nova master: handle to get cyborg client exception when delete instance  https://review.opendev.org/72067009:17
*** ociuhandu has joined #openstack-nova09:25
*** maohongbo has quit IRC09:32
*** maohongbo has joined #openstack-nova09:33
*** mkrai has joined #openstack-nova09:33
*** ttsiouts has joined #openstack-nova09:39
*** ociuhandu has quit IRC09:43
*** ociuhandu has joined #openstack-nova09:49
*** Liang__ has quit IRC09:52
hrwlyarwood: replied to your comment ;D10:05
openstackgerritWenping Song proposed openstack/nova master: Handle to get cyborg client exception when delete instance  https://review.opendev.org/72067010:11
lyarwoodhrw: /me rolls eyes10:15
lyarwoodhrw: just a suggestion10:15
hrwlyarwood: a bit of pure sarcasm in a morning10:19
lyarwood:) I've not had enough coffee for that yet10:19
hrwI just finished second10:19
*** rambo_li has quit IRC10:25
lyarwoodjust starting mine, tgif++10:26
lyarwoodhttps://review.opendev.org/#/c/669674/ - could use a non-RH core on this given it has an impact across virt drivers.10:26
*** rpittau is now known as rpittau|bbl10:30
*** szaher has joined #openstack-nova10:34
*** brinzhang has quit IRC10:35
*** ociuhandu has quit IRC10:48
*** ociuhandu has joined #openstack-nova10:48
*** ttsiouts has quit IRC10:49
*** ttsiouts has joined #openstack-nova10:50
*** ociuhandu has quit IRC10:52
*** spatel has joined #openstack-nova10:57
*** spatel has quit IRC11:02
*** mkrai has quit IRC11:09
*** mkrai has joined #openstack-nova11:09
*** bbowen_ has joined #openstack-nova11:18
*** bbowen has quit IRC11:19
*** ociuhandu has joined #openstack-nova11:23
*** bbowen has joined #openstack-nova11:37
*** bbowen_ has quit IRC11:39
*** belmoreira has joined #openstack-nova11:47
*** belmoreira has quit IRC11:48
*** belmoreira has joined #openstack-nova11:48
*** averi has joined #openstack-nova11:52
averihi, anyone has an idea on why code changes are not picked up by nova_compute containers (OSP 13)?11:52
averieven when spinning up a new image based on the nova-compute one, it doesn't work, code changes are there but they're like ignored all together11:53
averieven killing one of the library files results in the binary not to fail like the file was still around11:53
*** tkajinam has joined #openstack-nova11:56
*** udesale_ has joined #openstack-nova12:02
*** tkajinam has quit IRC12:04
*** udesale has quit IRC12:05
*** rcernin has quit IRC12:11
*** ttsiouts has quit IRC12:12
*** sapd1 has joined #openstack-nova12:16
*** rpittau|bbl is now known as rpittau12:19
*** mgariepy has joined #openstack-nova12:24
*** psachin has quit IRC12:26
*** mkrai has quit IRC12:28
*** mdbooth has joined #openstack-nova12:31
*** ttsiouts has joined #openstack-nova12:42
gibidansmith, sean-k-mooney, brinzhang: I need a second opinion in https://review.opendev.org/#/c/72067012:47
*** ttsiouts has quit IRC12:48
*** ociuhandu has quit IRC12:48
*** ociuhandu has joined #openstack-nova12:49
sean-k-mooneygibi: well my view is we should have been storing the acell profile in the request spec or in the instnace like we cache the flavor so we dont have this proble but ill go read what the patch acatully does now12:51
gibisean-k-mooney: it is like create an instance with accel, then remove cyborg service from deployment, then try to delete the instance which will fail12:52
sean-k-mooneygibi: im kind of felling like we should do what ever we would do if cinder or neutron went away12:52
sean-k-mooneyi would assume we would fail to delete but i confess i have never tried it12:53
gibiI can try that12:53
sean-k-mooneycool you should jsut need to delete the entry in the service in keystone to emulate that right12:54
gibiI'm not sure that a) this is a valid scenarios that cyborg service is removed from the deployment b) if yes then which is more important in general keeping cyborg - nova in sync or allowing to delete an instance during a temporary failure of cyborg12:55
sean-k-mooneygibi: i am leaning towords this si operator error for removing a service before its consumer are removed12:56
sean-k-mooneythat said i dont think they should have to do db surgury to remove the instance12:56
*** nweinber has joined #openstack-nova12:58
gibisean-k-mooney: without neutron endpoint in keystone the instance delete fails with HTTP 50013:01
gibihttp://paste.openstack.org/show/792326/13:02
sean-k-mooneyack13:02
sean-k-mooneyya that is baskcially what i expected13:02
sean-k-mooneyand i would expect the same for cyborg13:02
gibiso this also points towards that the scenario of removing cyborg is invalid13:02
sean-k-mooneyyes i was going to comment with a proceedure to do that in the bug13:03
sean-k-mooneybut just removing it i think is invalid13:03
sean-k-mooney*patch13:03
openstackgerritLee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances  https://review.opendev.org/71005013:05
sean-k-mooneygibi: left a comment with my toughts13:06
gibisean-k-mooney: thanks13:06
*** lbragstad_ is now known as lbragstad13:15
*** ratailor has quit IRC13:16
*** ratailor has joined #openstack-nova13:17
*** ratailor has quit IRC13:20
*** ratailor has joined #openstack-nova13:23
*** ttsiouts has joined #openstack-nova13:23
*** ratailor has quit IRC13:26
*** ratailor has joined #openstack-nova13:26
*** ttsiouts has quit IRC13:32
*** mkrai has joined #openstack-nova13:32
*** ttsiouts has joined #openstack-nova13:32
*** ratailor has quit IRC13:33
*** ratailor has joined #openstack-nova13:35
*** ratailor has quit IRC13:38
gibisean-k-mooney, dansmith thanks for the reviews on the https://review.opendev.org/#/c/720670 I marked the bug invalid13:38
dansmithcool13:38
*** rambo_li has joined #openstack-nova13:48
sean-k-mooneydansmith: gibi cross cell migrate was complete this cycle right it was not supported in train13:48
sean-k-mooneywell cross cell resize. same thing13:48
averidansmith, sean-k-mooney: sorry for the direct poke, got any pointer on the question above?13:48
sean-k-mooneyi did not see the quest can you repeat it. i can check scollback13:49
averiah sure, sorry13:49
averi<averi> hi, anyone has an idea on why code changes are not picked up by nova_compute containers (OSP 13)?13:49
averi<averi> even when spinning up a new image based on the nova-compute one, it doesn't work, code changes are there but they're like ignored all together13:49
averi<averi> even killing one of the library files results in the binary not to fail like the file was still around13:49
averiI cannot troubleshooting anything as soon as oslo service comes into play13:49
*** ttsiouts has quit IRC13:49
sean-k-mooneyhow are you modifying the code and restarting thet container13:50
sean-k-mooneyare you using docker directly13:50
*** lbragstad_ has joined #openstack-nova13:51
sean-k-mooneyif you exec into the contienr with doeck an modify the code then do a docker restart for the container it will pick up the changes13:51
dansmithsean-k-mooney: I haven't tried it, but yeah it was U not T13:51
averiI spin up a new container based on the upstream image, then exec within it, modify the library (interested in pymysql debugging), then shut down the container and start it again13:51
sean-k-mooneyif you are using paunch it pull a clean copy of the image every time you get it to restat the container so your changes will be lost13:52
averisean-k-mooney, the changes are there in the code, they persist, but they are completely ignored13:52
sean-k-mooneydansmith: ok just traiging a donwstream bug13:52
*** lbragstad has quit IRC13:52
dansmithaveri: this is probably not the best channel for that question13:52
averidansmith, sorry, a contact internally mentioned this was a possible good channel for that type of question13:52
sean-k-mooneyaveri: then i would guess its not using the files you are modifying and the kolla or ooo folks would be betere able to help13:53
averiwhat would be the correct channel?13:53
sean-k-mooneyaveri: #openstack-kolla or better #openstack-tripleo13:53
averithanks13:53
averimm.. 4 folks in #openstack-tripleo13:54
dansmithaveri: are you a redhatter?13:54
averiyes13:54
sean-k-mooneymaybe that is not there normal channel13:55
*** dklyle has joined #openstack-nova13:55
dansmithaveri: this is the upstream nova channel.. people here don't know anything about OSP :) I'll pm13:55
sean-k-mooneyaveri: fyi is just #tripleo13:56
averiack13:56
gibisean-k-mooney: cross cell resize merged in Ussuri not supported in Train14:00
*** mlavalle has joined #openstack-nova14:00
*** lbragstad_ has quit IRC14:00
sean-k-mooneygibi: yep i just have a resize bug specificly in a multi cell enve and i wanted to triple check that cross cell resize is not supported14:01
bauzasgibi: sorry, I was not around since this morning14:02
bauzasgibi: I haven't yet looked at the bugs14:02
bauzasthanks for working on it14:03
*** lbragstad has joined #openstack-nova14:03
rambo_lisean-k-mooney: maybe their is an error, for the bug :https://bugs.launchpad.net/nova/+bug/1841932. when we set the metadata "hide_hypervisor_id=true"in aggreate,so we will go to the https://github.com/openstack/nova/blob/46a3bcd80b41e99ec4923c7cf3d0f8dd8505e97c/nova/scheduler/filters/aggregate_instance_extra_specs.py#L69-L71, but this should not break, because the aggregate_val doesn't match the req.14:03
openstackLaunchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,New]14:03
gibibauzas: no worries there was one potential regression around cyborg but we just ruled it out as unsupported scenario14:03
gibibauzas: and honestly I did not triaged any bug, I'm just reviewing https://review.opendev.org/#/c/71916314:03
rambo_lithe aggregate_vals is "true"14:04
gmannmelwitt: stephenfin can i get your review on this which cover remaining policy of server (not reviewed previously ) - https://review.opendev.org/#/c/720104/ and its scope and defaults change patch.14:04
*** ttsiouts has joined #openstack-nova14:06
*** ociuhandu has quit IRC14:07
melwittgmann: yeah can do. I didn't review it yet because earlier patch in the stack I wanted to wait for johnthetubaguy since he spotted issues before. but you are right, can still look at the others14:08
gmannmelwitt: yeah, thanks.14:08
bauzasgibi: ack, will do as well later14:09
melwittgibi: hi, I have small follow ups here for the host_status:unknown-only policy rule here if you could please look https://review.opendev.org/71329514:09
gibimelwitt: sure. looking14:09
melwittthanks14:09
*** dtantsur is now known as dtantsur|brb14:09
*** mriedem has joined #openstack-nova14:10
openstackgerritAndreas Jaeger proposed openstack/nova master: Remove Babel requirement  https://review.opendev.org/72072514:11
*** ociuhandu has joined #openstack-nova14:11
rambo_lisean-k-mooney: if we set the metadata "hide_hypervisor_id = true "in aggregate, so the code https://github.com/openstack/nova/blob/master/nova/scheduler/filters/aggregate_instance_extra_specs.py#L62 , the aggregate_vals in code is "true". so last will also return False.so workaround this  is to set hw:hide_hypervisor_id replace hide_hypervisor_id in flavor extra_spec and aggregate metadata.14:23
*** ttsiouts has quit IRC14:31
*** rambo_li has quit IRC14:31
*** ttsiouts has joined #openstack-nova14:36
gibimelwitt: +A on the followup14:39
melwittdanke14:39
*** ttsiouts has quit IRC14:48
*** ttsiouts has joined #openstack-nova14:50
melwittgmann, bauzas, gibi, dansmith: does anyone know about babel to help review this? https://review.opendev.org/720725 it seems ok based on the ML post but I don't understand it well enough whether there could be any issue with removing it as a requirement14:51
melwittstephenfin too14:51
bauzasweirdo14:51
gibimelwitt: I have to pass on that now. I hope somebody else can take it14:52
bauzaswe don't use babel for translations14:52
melwittit's not urgent, just wanted to mention it while people are around14:52
bauzasbut I can git blame14:52
bauzasmelwitt: wow, this was old14:53
bauzasmelwitt: https://review.opendev.org/#/c/3870/14:53
bauzasbut the translation team no longer uses it AFAIK14:53
bauzas(for a while)14:53
bauzashttps://docs.openstack.org/i18n/latest/infra.html14:54
bauzasthis is now zanata14:54
bauzasso I think we can drop it14:54
bauzasbut I leave the decision to other folks :p14:54
melwittyeah. hm, so maybe we would want to remove all references. ajaeger had said babel is used to build translations so I was not sure what's going on14:55
stephenfinmelwitt: That _seems_ correct. You need Babel to run the e.g. 'python setup.py extract_messages' distutils command but I think _that_ would require it already be present, like setuptools14:55
bauzasI'm just afraid of breaking things so close to the HardStringFreeze so I'd defer this to later14:55
melwittah, nevermind14:55
stephenfinAlso, AJaeger suggested it and he knows these things so I'd trust him on that14:55
stephenfin*on this14:55
bauzasFWIW, that's how translations work atm https://docs.openstack.org/i18n/latest/reviewing-translation-import.html14:56
melwittI thought it'd be wise to see if anyone in the team understands this before merging it14:56
bauzasmelwitt: like I said, I would maybe defer this to post-RC114:57
melwittif literally no one understands it, then fine, but I wanted to check first14:57
bauzasmelwitt: we should first look at the translation jobs I think14:58
bauzasor ask someone in their team14:58
bauzasstephenfin: sean-k-mooney: trust me, if I was able to use the existing functional helpers, I'd use them15:00
bauzasstephenfin: sean-k-mooney: but all those stuff like https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L1057-L1067 are from a class that's separated from the general base test class15:01
bauzasif the whole thing was a mixin, I'd sign off for this15:01
bauzasbut using those helpers requires me to modify the inheritance of my own classes15:01
bauzasstephenfin: sean-k-mooney: https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L498-L50015:01
*** dtantsur|brb is now known as dtantsur15:03
sean-k-mooneybauzas: they are a mixin15:04
stephenfinmelwitt, bauzas: Okay, they're not using the setuptools integration any more so yes, we can remove it https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/common_translation_update.sh#L371-L37915:04
stephenfinWill ask AJaeger for more information in the commit message though15:04
bauzassean-k-mooney: huh ? https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L50015:05
sean-k-mooney oh they are not in the mixin class you are right15:07
sean-k-mooneybauzas: that said you are doing testing with placment so you proably should be inheriting form ProviderUsageBaseTestCase15:08
bauzassean-k-mooney: this was my original plan15:08
sean-k-mooneybauzas: why dont you move them up to the mixin class15:08
sean-k-mooneye.g. the resize functions15:09
bauzassean-k-mooney: see the FIXME on top15:09
bauzassean-k-mooney: oh, you mean moving my own methods to integrated_helpers ?15:09
bauzasI can do this for sure15:09
sean-k-mooneyi mean move the existing resize one form the ProviderUsageBaseTestCase to the mixin15:10
bauzassean-k-mooney: this would be doable15:10
sean-k-mooneythen you can use the mixin15:10
*** ociuhandu has quit IRC15:10
sean-k-mooneyand other that want the mixin but not the other things can too15:10
gibibauzas: fyi you got answers in https://bugs.launchpad.net/nova/+bug/186091315:11
openstackLaunchpad bug 1860913 in OpenStack Compute (nova) "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Undecided,New]15:11
bauzasgibi: this looks a bug then15:12
*** belmoreira has quit IRC15:12
bauzaslyarwood: https://bugs.launchpad.net/nova/+bug/1860913 we got answers on this one, I'm about to confirm it15:13
openstackLaunchpad bug 1860913 in OpenStack Compute (nova) "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Undecided,New]15:13
gibibauzas: yeah it is almost even triaged by pointing to the problem of the missing bdm update15:13
sean-k-mooneygibi: that sound familar15:13
bauzasgibi: agreed, I think we could dup this one15:13
gibibut I haven't checked the code15:13
sean-k-mooneylyarwood: where you looking into https://bugs.launchpad.net/nova/+bug/1860913 downstream15:13
*** ociuhandu has joined #openstack-nova15:13
gibiI let you folks to handle it :)15:14
bauzasthe 'you folks' is important :)15:14
bauzas:D15:14
lyarwoodsean-k-mooney: nope I don't recall seeing this15:15
sean-k-mooneygibi: well this is basically an issue with how we handel the snapshot15:15
sean-k-mooneyhttps://bugzilla.redhat.com/show_bug.cgi?id=1757691#c115:15
openstackbugzilla.redhat.com bug 1757691 in openstack-nova "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Urgent,New] - Assigned to nova-maint15:15
lyarwoodlooks like Matt triaged it a while ago15:15
sean-k-mooneywe discussed it on the triage call15:15
sean-k-mooneywhats happening is during the snapshot we cate a path form cinder to use a a temp file or something which updates the xml but if you do a hard reboot we regenerate it and use the one it had beofre15:16
sean-k-mooneythe real fix is to not allow reboots while we do snapshots15:17
bauzaseither way, the upstream bug is triaged with no assignee15:17
bauzasfeel free to pick it, teammates15:17
lyarwoodI'll take it15:18
bauzaslyarwood: thanks15:18
lyarwoodwe should be able to fix this easily by updating the connection_info15:18
*** mkrai has quit IRC15:18
sean-k-mooneymaybe i still think we need to lock the instance when you intialise the snapshot of the volume via cinder somehow15:19
stephenfinbauzas: RE: the integrated_helpers duplication, I'm okay with you doing that as a follow-up, so long as it's actually done and you stick a TODO in in your patch saying that it will be done :)15:23
stephenfinWill happily review the follow-up too15:23
sean-k-mooneyya i guss i would be fine with that as well.15:23
stephenfinneed the TODOs though15:24
*** maciejjozefczyk has quit IRC15:34
gibilyarwood: do you think https://bugs.launchpad.net/nova/+bug/1858402 is a duplicate of https://bugs.launchpad.net/nova/+bug/1868996 ?15:37
openstackLaunchpad bug 1858402 in OpenStack Compute (nova) "In-use volume does not support the same ceph cluster retype" [Undecided,New]15:37
openstackLaunchpad bug 1868996 in OpenStack Compute (nova) "Unable to swap between RBD volumes using virDomainBlockRebase" [High,Fix released] - Assigned to Lee Yarwood (lyarwood)15:37
*** ociuhandu has quit IRC15:40
*** sean-k-mooney has quit IRC15:41
*** ociuhandu has joined #openstack-nova15:42
bauzasstephenfin: nah, no worries, I'm pretty done with the new revision, since I need to update it for the main revert resize issue that dansmith said, I won't provide a FUP15:46
*** ociuhandu has quit IRC15:47
lyarwoodgibi: hey sorry yes that's a duplicate15:49
bauzasgibi: any idea why I got this weird exception : http://paste.openstack.org/show/792339/15:49
*** dpawlik has quit IRC15:50
gibilyarwood: tahnks15:51
lyarwoodgibi: updated the bug15:51
gibilyarwood: thanks a lot15:51
lyarwoodnp15:52
gibibauzas: looking15:52
bauzasthanks, I know it's late15:52
bauzasgibi: and that's what I wait for :15:53
bauzas        fake_notifier.wait_for_versioned_notifications(15:53
bauzas            'instance.resize_revert.end')15:53
bauzasoh, but I understand the error, I was expecting   'instance.resize_revert' but i never got it15:54
bauzasweirdo15:54
gibithat is my guess yes15:54
gibiyou can print all the notification that you received15:54
bauzasgibi: the paste says []15:55
gibifake_notifier.VERSIONED_NOTIFICATIONS15:55
bauzasdo I need to setup something specific in setUp ?15:55
gibiyou need to call stub_notifier()15:56
gibifrom fake_notifier15:56
bauzasgibi: I moved https://github.com/openstack/nova/blob/cd16ae2/nova/tests/functional/integrated_helpers.py#L1009-L1019 to https://github.com/openstack/nova/blob/cd16ae2/nova/tests/functional/integrated_helpers.py#L7515:57
gibi        fake_notifier.stub_notifier(self)15:57
gibi        self.addCleanup(fake_notifier.reset)15:57
bauzasah, thanks15:57
bauzasTIL15:57
gibicool15:58
*** dustinc has joined #openstack-nova16:00
gibiOK, I'm leaving for today. See you on Monday16:02
*** tesseract has quit IRC16:03
*** ociuhandu has joined #openstack-nova16:05
openstackgerritLee Yarwood proposed openstack/nova master: WIP block_device: Use the attachment update API to refresh connection_info  https://review.opendev.org/72076916:07
*** sapd1 has quit IRC16:07
bauzasgibi: \o16:08
openstackgerritSylvain Bauza proposed openstack/nova master: Allocate mdevs when resizing or reverting resize  https://review.opendev.org/71274116:09
bauzasstephenfin: ^ updated the last change for the vgpu resize thing16:09
stephenfinack16:10
*** ttsiouts has quit IRC16:12
*** ociuhandu has quit IRC16:15
*** ociuhandu has joined #openstack-nova16:16
*** dtantsur is now known as dtantsur|afk16:16
*** rpittau is now known as rpittau|afk16:17
*** sapd1 has joined #openstack-nova16:19
*** ociuhandu has quit IRC16:21
*** udesale_ has quit IRC16:23
*** hamzy__ has joined #openstack-nova16:31
* bauzas disappears for the week-end, bye folks16:31
*** gyee has joined #openstack-nova16:31
*** hamzy_ has quit IRC16:31
*** yaawang_ has joined #openstack-nova16:33
*** dtruong has quit IRC16:33
*** yaawang has quit IRC16:34
*** mlavalle has quit IRC16:34
*** dtruong has joined #openstack-nova16:34
*** evrardjp has quit IRC16:37
*** evrardjp has joined #openstack-nova16:37
*** kevinz has quit IRC16:40
*** ociuhandu has joined #openstack-nova16:40
*** mlavalle has joined #openstack-nova16:43
*** nightmare_unreal has quit IRC16:44
*** ociuhandu has quit IRC17:03
*** ttsiouts has joined #openstack-nova17:04
*** igordc has joined #openstack-nova17:04
*** igordc has quit IRC17:09
*** derekh has quit IRC17:12
*** links has quit IRC17:26
*** ociuhandu has joined #openstack-nova17:30
*** ociuhandu has quit IRC17:43
*** ralonsoh has quit IRC17:53
*** sapd1 has quit IRC17:58
*** tbachman_ has joined #openstack-nova18:00
*** tbachman has quit IRC18:02
*** tbachman_ is now known as tbachman18:02
*** tbachman_ has joined #openstack-nova18:05
*** tbachman has quit IRC18:08
*** tbachman_ is now known as tbachman18:08
*** ociuhandu has joined #openstack-nova18:09
*** ttsiouts has quit IRC18:14
*** ociuhandu has quit IRC18:22
*** ociuhandu has joined #openstack-nova18:23
artom*snerk* _get_all_rp_uuids_in_a_tree()18:26
artomWhy does that make me giggle18:26
artomMaybe because I'm imagining an actual tree18:26
openstackgerritGhanshyam Mann proposed openstack/nova master: Add docs and releasenotes for BP policy-defaults-refresh  https://review.opendev.org/72012918:26
artomOr that song...18:26
*** ociuhandu has quit IRC18:28
openstackgerritmelanie witt proposed openstack/nova stable/pike: Fix os-simple-tenant-usage result order  https://review.opendev.org/70960018:29
openstackgerritmelanie witt proposed openstack/nova stable/ocata: Fix os-simple-tenant-usage result order  https://review.opendev.org/70960318:36
openstackgerritmelanie witt proposed openstack/nova stable/ocata: Fix os-simple-tenant-usage result order  https://review.opendev.org/70960318:37
*** grandchild has joined #openstack-nova19:16
artomOh, I forgot func tests are broken on queens19:25
artom    sqlalchemy.exc.NoSuchTableError: migration_tmp19:26
*** ttsiouts has joined #openstack-nova19:26
artomhttps://bugs.launchpad.net/ubuntu/+source/nova/+bug/1807262 ?19:27
openstackLaunchpad bug 1807262 in nova (Ubuntu) "stein unit tests fail with sqlalchemy.exc.NoSuchTableError: migration_tmp" [High,Fix released]19:27
*** ociuhandu has joined #openstack-nova19:35
*** ociuhandu has quit IRC19:42
*** ttsiouts has quit IRC19:47
*** ttsiouts has joined #openstack-nova19:47
*** dustinc has quit IRC20:29
*** ociuhandu has joined #openstack-nova20:45
*** ociuhandu has quit IRC21:06
*** nweinber has quit IRC21:06
openstackgerritArtom Lifshitz proposed openstack/nova stable/train: DNM: Add a placement audit command  https://review.opendev.org/72083821:07
*** ociuhandu has joined #openstack-nova21:08
openstackgerritArtom Lifshitz proposed openstack/nova stable/stein: DNM: Add a placement audit command  https://review.opendev.org/72083921:10
*** ociuhandu has quit IRC21:13
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: DNM: Partial cherry-pick of assertRequestMatchesUsage()  https://review.opendev.org/72084021:21
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: DNM: Partial cherry-pick of _check_allocation_during_evacuate()  https://review.opendev.org/72084121:21
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: DNM: Add a placement audit command  https://review.opendev.org/72084221:21
artomI'm going to let CI chew on that as an extra layer of safety before even thinking about the rocky -> queens backport21:22
*** ccamacho has quit IRC21:22
artomBut it's all going downstream-only eventually21:22
gmanndansmith: lbragstad melwitt artom updated the review comments. this is ready for another re-review - https://review.opendev.org/#/c/720129/21:29
artomgmann, will take a look after supper, I guess21:30
artomgmann, btw, if my initial comments came off as flippant or "agressive" that was not at all the intention21:30
artomI guess I was having a bad say, or was annoyed at something else21:30
gmannartom: :) those were good feedback.21:31
artomMaybe I could get a screen reader so I can listen to that doc while making supper...21:31
gmannhehe or invite me for dinner, i can read for you :)21:33
artomgmann, hahaha21:33
*** ttsiouts has quit IRC21:56
*** mgariepy has quit IRC22:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Add docs and releasenotes for BP policy-defaults-refresh  https://review.opendev.org/72012922:11
*** xek has quit IRC22:12
*** ociuhandu has joined #openstack-nova22:32
*** mriedem has left #openstack-nova22:34
*** ociuhandu has quit IRC22:38
openstackgerritSylvain Bauza proposed openstack/nova master: Allocate mdevs when resizing or reverting resize  https://review.opendev.org/71274122:40
*** ttsiouts has joined #openstack-nova22:43
*** ttsiouts has quit IRC22:52
*** grandchild has quit IRC22:55
*** igordc has joined #openstack-nova23:08
*** gyee has quit IRC23:10
*** tosky has quit IRC23:21
openstackgerritmelanie witt proposed openstack/nova stable/pike: Fix os-simple-tenant-usage result order  https://review.opendev.org/70960023:23
openstackgerritmelanie witt proposed openstack/nova stable/pike: Require stestr < 3.0.0 in test-requirements  https://review.opendev.org/72084923:23
openstackgerritmelanie witt proposed openstack/nova stable/pike: Require stestr < 3.0.0 in test-requirements  https://review.opendev.org/72084923:25
openstackgerritmelanie witt proposed openstack/nova stable/pike: Fix os-simple-tenant-usage result order  https://review.opendev.org/70960023:25
*** igordc has quit IRC23:27
« Thursday, 2020-04-16 Index Saturday, 2020-04-18 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!