| *** openstack has joined #openstack-nova | 09:54 | |
| *** ChanServ sets mode: +o openstack | 09:54 | |
| *** dpawlik has quit IRC | 09:55 | |
| bauzas | gibi: stephenfin: I'm out of ideas for a problem I have with mocking a privsep helper | 09:55 |
|---|---|---|
| stephenfin | got it on Gerrit? | 09:55 |
| bauzas | stephenfin: in https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L64 | 09:56 |
| bauzas | stephenfin: there, I'm amending the fake connection to add a mdev | 09:56 |
| bauzas | stephenfin: but as you can see, all the computes have the same fake connection https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L71 | 09:56 |
| *** dpawlik has joined #openstack-nova | 09:56 | |
| bauzas | stephenfin: so, I should modify https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56-L68 to look at which compute to modify | 09:57 |
| bauzas | stephenfin: but given I'm faking privsep https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L45-L47 | 09:57 |
| bauzas | stephenfin: I can't know which compute was for | 09:58 |
| bauzas | :( | 09:58 |
| bauzas | I only know the parent PCI ID | 09:58 |
| *** tetsuro has quit IRC | 09:59 | |
| stephenfin | I think you need to keep track of individual fake connections like we do in the 'start_computes' function https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L138-L152 | 09:59 |
| bauzas | stephenfin: sure, but then how to know which fake connection to modify then ? | 10:01 |
| bauzas | I mean in https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | 10:01 |
| bauzas | both compute have the exact same PCI IDs | 10:01 |
| bauzas | computes* | 10:01 |
| stephenfin | ah, yes, gotcha | 10:02 |
| bauzas | 'self' is not the compute driver... | 10:02 |
| gibi | does the fake connection know hostname? | 10:02 |
| gibi | or nodename | 10:03 |
| bauzas | yes | 10:03 |
| bauzas | that's easy | 10:03 |
| gibi | then you can branch based on that | 10:03 |
| bauzas | but again, I don't know which compute was calling https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | 10:03 |
| bauzas | eg. if you create an instance for compute 1 and then compute2 | 10:04 |
| bauzas | then both calls to https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 will have the same arguments | 10:04 |
| bauzas | so, _create_mdev() wouldn't know which fake connection to modify | 10:04 |
| gibi | can we have different pci ids per compute? | 10:05 |
| * gibi stabs in the dark | 10:05 | |
| stephenfin | It's very hacky, but you could intercept a higher call and set some attribute to say "compute node N is now attempting to create an mdev" | 10:06 |
| bauzas | gibi: well, we could... but I think it would be a large change then :( | 10:06 |
| bauzas | stephenfin: I can try this | 10:06 |
| bauzas | tbh, I tried to discuss with you to find another solution | 10:06 |
| bauzas | but you told me the two ones I was thinking | 10:07 |
| bauzas | and both of them are difficult :p | 10:07 |
| bauzas | anyway | 10:07 |
| bauzas | I can try to resize to the same host | 10:07 |
| bauzas | (for testing what I want) | 10:07 |
| bauzas | but that won't fix the problem | 10:07 |
| bauzas | anyway, thanks | 10:07 |
| *** owalsh_afk is now known as owalsh | 10:20 | |
| *** rpittau is now known as rpittau|bbl | 10:23 | |
| stephenfin | johnthetubaguy: could you help me understand why we are changing the scope types for the create policy here? https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py | 10:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | 10:46 |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | 11:08 |
| *** priteau has quit IRC | 11:14 | |
| *** mkrai has quit IRC | 11:25 | |
| *** mkrai_ has joined #openstack-nova | 11:25 | |
| *** sapd1 has quit IRC | 11:30 | |
| *** udesale_ has joined #openstack-nova | 11:34 | |
| *** udesale has quit IRC | 11:36 | |
| *** nweinber has joined #openstack-nova | 11:38 | |
| *** ociuhandu has quit IRC | 11:41 | |
| *** ratailor has quit IRC | 11:52 | |
| *** mgariepy has joined #openstack-nova | 11:55 | |
| *** nightmare_unreal has joined #openstack-nova | 11:58 | |
| *** mkrai has joined #openstack-nova | 12:05 | |
| *** mkrai_ has quit IRC | 12:06 | |
| *** vishalmanchanda has quit IRC | 12:11 | |
| *** tkajinam has quit IRC | 12:12 | |
| *** ociuhandu has joined #openstack-nova | 12:19 | |
| *** links has quit IRC | 12:31 | |
| *** rpittau|bbl is now known as rpittau | 12:31 | |
| *** sapd1 has joined #openstack-nova | 12:33 | |
| *** ociuhandu has quit IRC | 12:34 | |
| *** ociuhandu has joined #openstack-nova | 12:35 | |
| *** lpetrut has quit IRC | 12:54 | |
| *** dklyle has joined #openstack-nova | 12:56 | |
| *** lpetrut has joined #openstack-nova | 13:01 | |
| openstackgerrit | Merged openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota sets policies https://review.opendev.org/719128 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota class policies https://review.opendev.org/719095 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in quota class Policies https://review.opendev.org/719096 | 13:06 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | 13:07 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | 13:07 |
| openstackgerrit | Merged openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | 13:07 |
| *** vishalmanchanda has joined #openstack-nova | 13:15 | |
| *** artom has joined #openstack-nova | 13:25 | |
| openstackgerrit | Merged openstack/nova master: Use placement stable version for functional job https://review.opendev.org/719119 | 13:25 |
| *** tkajinam has joined #openstack-nova | 13:33 | |
| *** mgariepy has quit IRC | 13:44 | |
| *** bcm has quit IRC | 13:50 | |
| *** cz3 has quit IRC | 13:50 | |
| *** vdrok has quit IRC | 13:50 | |
| *** rpittau has quit IRC | 13:50 | |
| *** ab-a has quit IRC | 13:51 | |
| *** mkrai has quit IRC | 13:51 | |
| *** bcm has joined #openstack-nova | 13:51 | |
| aarents | Hi there, lyarwood I put few examples on associated bug https://bugs.launchpad.net/nova/+bug/1872082 ( https://review.opendev.org/#/c/719008 ) | 13:51 |
| openstack | Launchpad bug 1872082 in OpenStack Compute (nova) "available disk on compute may be lightly overestimated in some cases" [High,In progress] - Assigned to Alexandre arents (aarents) | 13:51 |
| *** vdrok has joined #openstack-nova | 13:51 | |
| *** rpittau has joined #openstack-nova | 13:51 | |
| *** ab-a has joined #openstack-nova | 13:51 | |
| *** cz3 has joined #openstack-nova | 13:51 | |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 13:55 | |
| *** derekh has quit IRC | 13:56 | |
| *** derekh has joined #openstack-nova | 13:56 | |
| *** mgariepy has joined #openstack-nova | 13:57 | |
| lyarwood | aarents: yeah sorry missed the RAW example | 13:59 |
| *** derekh has quit IRC | 13:59 | |
| *** derekh has joined #openstack-nova | 14:00 | |
| *** ttsiouts has quit IRC | 14:00 | |
| aarents | lyarwood: np | 14:01 |
| *** ociuhandu has quit IRC | 14:03 | |
| *** ttsiouts has joined #openstack-nova | 14:04 | |
| *** ociuhandu has joined #openstack-nova | 14:04 | |
| lyarwood | aarents: so I think the RAW behaviour is actually a bug due to the way we call fallocate | 14:08 |
| lyarwood | aarents: I think it's writing out a block of zero's at the start | 14:08 |
| lyarwood | aarents: as we aren't using -d | 14:09 |
| * aarents reading man fallocate | 14:09 | |
| gmann | stephenfin: replied for SG scope things- https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py@36 | 14:10 |
| gmann | stephenfin: please check if that make sense, it is same for POST servers also | 14:10 |
| lyarwood | aarents: https://paste.centos.org/view/90da78f0 for example | 14:11 |
| lyarwood | aarents: I think your change is still good FWIW | 14:11 |
| lyarwood | aarents: but we should also fix our call to fallocate | 14:11 |
| aarents | lyarwood: exact for -d , seems necessary | 14:13 |
| *** tkajinam has quit IRC | 14:17 | |
| *** tkajinam has joined #openstack-nova | 14:18 | |
| lyarwood | aarents: actually -d is wrong | 14:18 |
| *** mriedem has joined #openstack-nova | 14:19 | |
| *** udesale_ has quit IRC | 14:20 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587 | 14:21 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server topology policies https://review.opendev.org/717524 | 14:22 |
| nightmare_unreal | how can I get migration ID when migrating an instance ? When I run the live migration cmd from CLI i don't get any output | 14:22 |
| *** dlbewley has joined #openstack-nova | 14:23 | |
| gibi | brinzhang_, sean-k-mooney, dansmith: regarding cyborg-nova integration: can I close the bp and there will be a new bp for Victoria? Does https://review.opendev.org/#/c/716186 needs to be handled as a bug? | 14:24 |
| *** sapd1 has quit IRC | 14:24 | |
| dansmith | gibi: yes and yes, IMHO | 14:24 |
| *** lpetrut has quit IRC | 14:24 | |
| gibi | dansmith: OK. I will wait for brinzhang_ to comment too and I will ask him to file the bug too | 14:25 |
| dansmith | ack | 14:25 |
| sean-k-mooney | gibi: yep agree with dansmith | 14:26 |
| gibi | sean-k-mooney: cool | 14:26 |
| sean-k-mooney | speaking of ill go file said bug before i get distracted | 14:26 |
| gibi | sean-k-mooney: thanks | 14:27 |
| sean-k-mooney | gibi: should i mark this as rc potential or shoudl we just treat it as a normal bugfix that we will backport after ussuri is released as normal. | 14:33 |
| stephenfin | gmann: Thanks for the explanation. Would it be possible edit the commit message to include that information there? | 14:33 |
| gibi | sean-k-mooney: what is the worst case issue by that bug? | 14:34 |
| gmann | stephenfin: sure, doing. | 14:35 |
| sean-k-mooney | if we create the ARQ and fail to clean them up becasue binding fail then we leak the arq. since its not bound i think its just leaking a db recored. i need to double check that | 14:36 |
| sean-k-mooney | gibi: https://bugs.launchpad.net/nova/+bug/1872730 | 14:37 |
| openstack | Launchpad bug 1872730 in OpenStack Compute (nova) "Delete ARQs for an instance when the instance is deleted only delete bound arqs" [High,Triaged] | 14:37 |
| gibi | sean-k-mooney: then I think it is not an rc potential bug | 14:38 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server topology https://review.opendev.org/717584 | 14:38 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server topology policies https://review.opendev.org/717585 | 14:38 |
| openstackgerrit | Merged openstack/nova master: workarounds: Add option to locally attach RBD volumes on compute hosts https://review.opendev.org/708029 | 14:38 |
| gibi | sean-k-mooney: thanks for fileing it | 14:38 |
| sean-k-mooney | gibi: ya i might ping thet cyborg folk to take a look too and confirm its not going to leak devices on there end. but my understanding is they dont allocate or program the device until we bind it as that is when we set the host and pass the allocation to cyborg | 14:40 |
| sean-k-mooney | so if we failed to bind it then they should not need to clean anything up | 14:40 |
| sean-k-mooney | we should be deleted and recreating the arqs when we reschdule | 14:40 |
| gibi | I have a similar understanding, thanks for following it up | 14:40 |
| openstackgerrit | Merged openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | 14:45 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in os-evacuate policies https://review.opendev.org/708237 | 14:45 |
| *** mlavalle has joined #openstack-nova | 14:45 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | 14:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 14:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 14:55 |
| gmann | stephenfin: done. also this one too - https://review.opendev.org/#/c/718501/ | 14:55 |
| gmann | stephenfin: once you are ok with those then i will rebase the series | 14:56 |
| openstackgerrit | Merged openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | 14:56 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in server group policy https://review.opendev.org/717176 | 14:56 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server external events policies https://review.opendev.org/717168 | 14:56 |
| stephenfin | gmann: comment on https://review.opendev.org/#/c/717175/10 | 14:57 |
| stephenfin | I could be wrong though | 14:58 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | 14:59 |
| gmann | stephenfin: i think yes. sorry i update that directly. | 15:00 |
| *** dosaboy_ is now known as dosaboy | 15:04 | |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in server external events policy https://review.opendev.org/717169 | 15:07 |
| *** ttsiouts has quit IRC | 15:10 | |
| *** ttsiouts has joined #openstack-nova | 15:11 | |
| *** ociuhandu has quit IRC | 15:19 | |
| *** ociuhandu has joined #openstack-nova | 15:21 | |
| *** ociuhandu has quit IRC | 15:25 | |
| *** mkrai has joined #openstack-nova | 15:31 | |
| *** mkrai_ has joined #openstack-nova | 15:33 | |
| *** mkrai has quit IRC | 15:35 | |
| gmann | johnthetubaguy: one comment, same for extended attr also - https://review.opendev.org/#/c/719730/1/nova/policies/servers.py@133 | 15:41 |
| *** ociuhandu has joined #openstack-nova | 15:56 | |
| *** avolkov has quit IRC | 15:57 | |
| *** gyee has joined #openstack-nova | 16:01 | |
| *** rpittau is now known as rpittau|afk | 16:02 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Update compute rpc version alias for ussuri https://review.opendev.org/719315 | 16:09 |
| *** mkrai_ has quit IRC | 16:09 | |
| gmann | melwitt: lyarwood master patch is merged for functional tox fix, train one is ready - https://review.opendev.org/#/c/719120/ | 16:13 |
| *** tkajinam has quit IRC | 16:20 | |
| *** yaawang_ has joined #openstack-nova | 16:32 | |
| *** yaawang has quit IRC | 16:33 | |
| *** mgariepy has quit IRC | 16:34 | |
| *** psachin has quit IRC | 16:34 | |
| *** evrardjp has quit IRC | 16:37 | |
| *** evrardjp has joined #openstack-nova | 16:37 | |
| *** mgariepy has joined #openstack-nova | 16:40 | |
| bauzas | can someone tell me why libvirt returns me a former guest that was resized to another host ? | 16:41 |
| bauzas | kashyap: stephenfin: sean-k-mooney: in case you know ? ^ | 16:42 |
| bauzas | tbc, the resize was *confirmed* | 16:42 |
| bauzas | and the allocations diseappeared accordingly | 16:42 |
| bauzas | lyarwood: maybe ? | 16:42 |
| kashyap | bauzas: Hi, need more context. But I'm hungry and just about to cook a meal. | 16:44 |
| bauzas | kashyap: https://github.com/openstack/nova/blob/9001d7e3459d97f507e8ce638d1fc3935401252d/nova/virt/libvirt/driver.py#L7023 | 16:44 |
| kashyap | Trying to maintain a Good Hermit Schedule(tm) :) | 16:44 |
| bauzas | kashyap: anyway, take your time, I'll investigate tonight so we could discuss this tomorrow | 16:46 |
| kashyap | bauzas: Hmm, that requires me to read code and delve deeper into context. I'm just recovering from 3 hours of debugging another libvirt bug | 16:46 |
| kashyap | Yep, thanks! | 16:46 |
| *** derekh has quit IRC | 16:54 | |
| *** dtantsur is now known as dtantsur|afk | 16:57 | |
| *** vishalmanchanda has quit IRC | 17:04 | |
| *** ttsiouts has quit IRC | 17:30 | |
| *** ttsiouts has joined #openstack-nova | 17:33 | |
| *** maciejjozefczyk has quit IRC | 17:36 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** ociuhandu has joined #openstack-nova | 17:41 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in quota class policies https://review.opendev.org/719100 | 17:44 |
| *** ociuhandu has quit IRC | 17:46 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in quota class policy https://review.opendev.org/720042 | 17:49 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in flavor access policy https://review.opendev.org/719607 | 17:58 |
| *** ttsiouts has quit IRC | 18:00 | |
| *** ttsiouts has joined #openstack-nova | 18:02 | |
| *** dpawlik has quit IRC | 18:02 | |
| openstackgerrit | Rafael Weingärtner proposed openstack/nova master: Enhance os-simple-tenant-usage VM hours accounting https://review.opendev.org/711113 | 18:06 |
| *** nightmare_unreal has quit IRC | 18:08 | |
| *** ociuhandu has joined #openstack-nova | 18:14 | |
| artom | melwitt, I just noticed your have 3 Ts in your Gerrit email | 18:16 |
| *** tobiash has quit IRC | 18:16 | |
| artom | Took some head banging to understand why it wasn't accepting my script's query | 18:16 |
| artom | :) | 18:16 |
| *** tobiash has joined #openstack-nova | 18:17 | |
| *** amodi has quit IRC | 18:17 | |
| *** martinkennelly has quit IRC | 18:29 | |
| *** ttsiouts has quit IRC | 18:35 | |
| *** ralonsoh has quit IRC | 18:49 | |
| *** ociuhandu has quit IRC | 18:50 | |
| *** ociuhandu has joined #openstack-nova | 18:51 | |
| *** ociuhandu has quit IRC | 18:55 | |
| *** tesseract has quit IRC | 18:59 | |
| *** ttsiouts has joined #openstack-nova | 19:10 | |
| *** ttsiouts has quit IRC | 19:15 | |
| *** ociuhandu has joined #openstack-nova | 19:16 | |
| bauzas | erm, do folks here have any ideas on how to get a right CONF.host value within a functional test ? | 19:40 |
| bauzas | I mean, I could self.flags it but given it's a global object, all the created computes in the functest will get the same valur | 19:40 |
| bauzas | value* | 19:40 |
| *** ttsiouts has joined #openstack-nova | 19:45 | |
| *** maohongbo1 has joined #openstack-nova | 19:50 | |
| *** maohongbo has quit IRC | 19:52 | |
| *** maohongbo1 is now known as maohongbo | 19:52 | |
| *** mtreinish has joined #openstack-nova | 20:12 | |
| *** tobberydberg_ has quit IRC | 20:17 | |
| *** ttsiouts has quit IRC | 20:19 | |
| *** tobberydberg has joined #openstack-nova | 20:22 | |
| *** nweinber has quit IRC | 20:26 | |
| melwitt | bauzas: yes, you do that by passing the 'host' kwarg when you start_service https://github.com/openstack/nova/blob/9001d7e3459d97f507e8ce638d1fc3935401252d/nova/test.py#L381-L391 | 20:29 |
| *** maciejjozefczyk has joined #openstack-nova | 20:30 | |
| bauzas | melwitt: sure, I saw it | 20:30 |
| *** tobberydberg has quit IRC | 20:30 | |
| bauzas | melwitt: but for example, I start two computes in a functest | 20:30 |
| bauzas | (using this helper) | 20:30 |
| melwitt | artom: yeah ... the 2 Ts version is owned by someone else and I was uncreative so I just tacked on another t. probably should have picked something else, in hindsight | 20:31 |
| bauzas | melwitt: but then, when I want to confirm resize an instance, the global CONF.host is only having the last host value | 20:31 |
| bauzas | https://github.com/openstack/nova/blob/9001d7e3459d97f507e8ce638d1fc3935401252d/nova/virt/libvirt/driver.py#L1519 | 20:31 |
| melwitt | bauzas: oh, I see. I don't know of a way around that. you would probably need the ghost of mriedem. or maybe gibi might have ideas | 20:32 |
| bauzas | melwitt: so, for example, if I create an instance for host1, resize it to host2 and then confirm the resize, it won't remove the guest in host1 because instance.host (host2) == CONF.host (host2) even I checked that it was calling host1 | 20:33 |
| bauzas | melwitt: no worries, I'll just then modify the CONF before calling confirm_resize | 20:33 |
| mriedem | isn't there another handle within the libvirt driver to the host value used when the service was started? | 20:36 |
| mriedem | the compute service i mean | 20:36 |
| mriedem | if so, you can change that code to use that and not deal with global config problems | 20:36 |
| *** tobberydberg has joined #openstack-nova | 20:36 | |
| *** tobberydberg has quit IRC | 20:37 | |
| mriedem | the compute driver has a handle to the virtapi which has a handle to the compute manager which has a self.host value | 20:38 |
| *** maciejjozefczyk has quit IRC | 20:39 | |
| bauzas | mriedem: yeah, no worries, I can provide a change for it | 20:39 |
| mriedem | so i think it's just `self.virtapi._compute.host` | 20:39 |
| melwitt | oh yeah, self.host, that will be different even in func tests. good call | 20:39 |
| mriedem | you could add a "host" property getter method to the virtapi so that the driver doesn't need to know about self._compute | 20:40 |
| mriedem | self.virtapi.host | 20:40 |
| mriedem | badabing | 20:40 |
| bauzas | thanks | 20:41 |
| bauzas | fwiw, we have a lot of CONF.host values in libvirt | 20:41 |
| bauzas | so I'll just create a change for all of them | 20:41 |
| *** tobberydberg has joined #openstack-nova | 20:42 | |
| *** tobberydberg has quit IRC | 20:43 | |
| artom | bauzas, yeah, there's not much you can do with the global CONF.host... | 20:45 |
| artom | Although the computes should keep their hostnames... | 20:45 |
| artom | So maybe there's a bug somewhere? | 20:45 |
| bauzas | artom: that's not really a bug | 20:45 |
| *** tobberydberg has joined #openstack-nova | 20:45 | |
| *** tobberydberg has quit IRC | 20:45 | |
| artom | Oh, wait, melwitt linked the "wrong" helper | 20:45 |
| *** ociuhandu has quit IRC | 20:45 | |
| bauzas | artom: it's just a problem for tests | 20:45 |
| artom | bauzas, are you using the fake driver, or the libvirt driver? | 20:46 |
| *** tobberydberg has joined #openstack-nova | 20:46 | |
| bauzas | the latter | 20:46 |
| *** tobberydberg has quit IRC | 20:46 | |
| bauzas | hence the problem | 20:46 |
| *** ociuhandu has joined #openstack-nova | 20:46 | |
| *** tobberydberg has joined #openstack-nova | 20:46 | |
| bauzas | anyway, I found the solution | 20:46 |
| melwitt | artom: what do you mean "wrong" helper? | 20:47 |
| *** tobberydberg has quit IRC | 20:47 | |
| artom | bauzas, https://github.com/openstack/nova/blob/9001d7e3459d97f507e8ce638d1fc3935401252d/nova/tests/functional/libvirt/base.py#L117 | 20:47 |
| *** tobberydberg has joined #openstack-nova | 20:47 | |
| *** tobberydberg has quit IRC | 20:47 | |
| bauzas | I all know about it | 20:47 |
| bauzas | but again, CONF.host will be overrided by the last value | 20:47 |
| bauzas | given it's a global variable | 20:48 |
| artom | bauzas, no way around it, then | 20:48 |
| artom | CONF is global per process | 20:48 |
| bauzas | we only run by a single process fwiw | 20:48 |
| artom | Yep | 20:48 |
| bauzas | (for testing) | 20:48 |
| artom | OK, my kids are impatiently calling me to literally go fly a kite | 20:48 |
| artom | So I'm off again | 20:49 |
| mriedem | if the driver code uses the host set on the compute manager (via virtapi) then you get whatever host name was used when the service was started | 20:49 |
| mriedem | so, ween off global conf | 20:49 |
| bauzas | anyway, I got the workaround (changing the value before calling the post api), and I'll create a new change for libvirt | 20:49 |
| bauzas | I mean, I'll propose the functional test first, and then another change for just using virtapi in libvirt | 20:49 |
| sean-k-mooney | i think you could mock it to have different values in different greenthread/coroutiens but ya the currnet constution makes having different values chalanging | 20:49 |
| bauzas | done. | 20:50 |
| bauzas | sean-k-mooney: oh yeah of course, we could start the services by each greenthread... and then we would see problems :p | 20:50 |
| bauzas | or I dunno | 20:50 |
| bauzas | anyway | 20:51 |
| *** tobberydberg has joined #openstack-nova | 20:51 | |
| bauzas | I'm done | 20:51 |
| *** maohongbo1 has joined #openstack-nova | 20:51 | |
| *** ociuhandu has quit IRC | 20:52 | |
| *** maohongbo has quit IRC | 20:53 | |
| *** maohongbo1 is now known as maohongbo | 20:53 | |
| *** tobberydberg has quit IRC | 20:55 | |
| *** xek has quit IRC | 20:56 | |
| *** ociuhandu has joined #openstack-nova | 21:02 | |
| *** JamesBenson has quit IRC | 21:05 | |
| *** ociuhandu has quit IRC | 21:06 | |
| *** KeithMnemonic has joined #openstack-nova | 21:08 | |
| *** KeithMnemonic has quit IRC | 21:16 | |
| *** KeithMnemonic has joined #openstack-nova | 21:17 | |
| *** tobiash has quit IRC | 21:18 | |
| *** ociuhandu has joined #openstack-nova | 21:20 | |
| *** tobiash has joined #openstack-nova | 21:20 | |
| *** ttsiouts has joined #openstack-nova | 21:22 | |
| *** ccamacho has quit IRC | 21:36 | |
| *** JamesBenson has joined #openstack-nova | 21:41 | |
| sean-k-mooney | bauzas: mriedem melwitt this is how we can mock the globals i think http://paste.openstack.org/show/792118/ | 21:51 |
| melwitt | sean-k-mooney: ahhh mine eyes! | 21:51 |
| sean-k-mooney | hehe i have to create an event loop to get it to interleave and emulate two compute services so there is a bit of boiler plate | 21:52 |
| * melwitt dies | 21:53 | |
| mriedem | or just stop using globals | 21:53 |
| bauzas | sean-k-mooney: lol | 21:53 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when resizing https://review.opendev.org/589085 | 21:53 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when reverting resize https://review.opendev.org/712118 | 21:53 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Allocate mdevs when resizing or reverting resize https://review.opendev.org/712741 | 21:53 |
| bauzas | sean-k-mooney: I'm just uploading the series ^ | 21:53 |
| bauzas | aaaaaand I'm done today (well, tomorrow is in 7 mins) | 21:53 |
| sean-k-mooney | well stop using gloabals means deviate form how oslo conf is used everywhere else in openstack | 21:53 |
| melwitt | time to start again in 7 minutes! | 21:53 |
| artom | mriedem, well, a global per-process CONF makes sense | 21:53 |
| artom | It's not like different bits of a single nova process can have different configs | 21:54 |
| sean-k-mooney | not that im saying we should not stop using globals | 21:54 |
| *** maohongbo has quit IRC | 21:54 | |
| bauzas | sean-k-mooney: artom: melwitt: honestly, let's discuss it on the change I'll provide tomorrow morning my time (ie. using virtapi.host field instead of CONF.host) | 21:54 |
| mriedem | sean-k-mooney: it's not used globally in placement, intentionally | 21:54 |
| artom | Though I suppose single global config != single global variable | 21:54 |
| sean-k-mooney | i just wanted to point out we cauld create muliple patchers for the config an activate them as needed | 21:54 |
| mriedem | cdent burned all of that out | 21:54 |
| bnemec | Ugh, really? | 21:55 |
| artom | Smart man | 21:55 |
| sean-k-mooney | mriedem: ya well that was because they had the same proablem and bit the bullet | 21:55 |
| *** ociuhandu has quit IRC | 21:55 | |
| *** maohongbo has joined #openstack-nova | 21:55 | |
| bnemec | Please don't do that. | 21:55 |
| mriedem | and it's not meant to be used globally, the oslo docs even say that i think, but that's what's happened | 21:55 |
| artom | Anyways, I have to make supper | 21:55 |
| sean-k-mooney | bnemec: stop using global or my fun with mock | 21:55 |
| artom | I do enjoy these drive-by discussions :P | 21:55 |
| *** ociuhandu has joined #openstack-nova | 21:56 | |
| mriedem | https://docs.openstack.org/oslo.config/latest/reference/faq.html#why-does-oslo-config-have-a-conf-object-global-objects-suck | 21:56 |
| *** ttsiouts has quit IRC | 21:56 | |
| mriedem | artom: i was summoned earlier | 21:56 |
| artom | mriedem, summoned eh? You're an Eldrich God? | 21:57 |
| bauzas | again, I agree with mriedem, I think the simpliest would be to just stopping to use CONF.host everytime in libvirt | 21:57 |
| artom | At least you don't talk of yourself in the third person ;) | 21:57 |
| bnemec | mriedem: That's saying you _should_ use the global object because it's what everyone else is doing. | 21:57 |
| mriedem | more like a pit fiend | 21:57 |
| mriedem | bnemec: it concedes | 21:57 |
| mriedem | "yes it sucks but everyone is doing it so sure" | 21:57 |
| * bauzas opened a can of worms and then leaves with a joker smile | 21:58 | |
| * mriedem prepares his jumping off a bridge dad-ism | 21:58 | |
| artom | Ah, the old jump off a bridge debate | 21:58 |
| bnemec | I can tell you it would break parts of the policy generator if you dropped it. | 21:58 |
| artom | mriedem, dammit, jinx! | 21:58 |
| * artom -> really off now | 21:58 | |
| mriedem | bnemec: tbc, the suggestion was to stop using the global config to access one variable in one very specific place in the libvirt driver so that functional tests weren't mocking or hacking global config to workaround its global-ness | 21:59 |
| mriedem | bnemec: nova is never going to fully move off global config usage, it's just that one spot i was talking about | 21:59 |
| * bauzas will write his next book "How to bikeshed a nit in a large opensource project" | 21:59 | |
| bnemec | That sounds perfectly reasonable. | 22:00 |
| bauzas | again, I think the easiest is to just stop using global objects as much as we can | 22:00 |
| bauzas | so, bye CONF.host and just check what we need once | 22:00 |
| * bauzas drops mic | 22:01 | |
| bnemec | The one danger of not looking it up from the conf object each time is that mutable config won't work correctly, unless you write a hook to update it. | 22:01 |
| bnemec | But that's both solvable and not an issue if that config opt isn't marked mutable. | 22:01 |
| *** ociuhandu has quit IRC | 22:01 | |
| sean-k-mooney | this is a cleaner verion of the same thing by the way http://paste.openstack.org/show/792119/ | 22:05 |
| sean-k-mooney | compute-1 and comptue-2 have there own view of the global object that they can modify without affecting each other. | 22:08 |
| sean-k-mooney | this is still rather archane so im not really sure i would want to do this but if i coudl make it into a nice decorator to hide this i could be an option. anyway i just wanted to play with mocking and see what i could do | 22:09 |
| sean-k-mooney | bnemec: we dont really support mutable config for many config options today in nova | 22:12 |
| sean-k-mooney | bnemec: some stuff yes but you cant change the virt dirver while its runing or many of the virt driver options | 22:13 |
| *** slaweq_ has quit IRC | 22:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 22:19 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 22:19 |
| gmann | stephenfin: can you re approve these, I lost +A due to rebase - https://review.opendev.org/#/c/718348/ https://review.opendev.org/#/c/718501 | 22:21 |
| mriedem | bnemec: in this case it's CONF.host which isn't mutable, and if you change the hostname on a compute node you're ... kind of destroying that node | 22:28 |
| *** ttsiouts has joined #openstack-nova | 22:30 | |
| *** ttsiouts has quit IRC | 22:34 | |
| *** ttsiouts has joined #openstack-nova | 22:42 | |
| *** ociuhandu has joined #openstack-nova | 22:46 | |
| *** tkajinam has joined #openstack-nova | 22:46 | |
| *** ttsiouts has quit IRC | 22:47 | |
| sean-k-mooney | mriedem: we often want to change other value that also are not mutable when we do multi node functional test and simple using another value is not always an option | 22:48 |
| sean-k-mooney | im thinking of the cpu_dedicated_set and other values like that where it would be really nice to have a two node functional test with different values. | 22:48 |
| sean-k-mooney | anyway its not relavent to bauzas patch but its frequently a problem we hit. | 22:49 |
| ianw | hi, nodepool testing hit the removal of "user_data" from the nova client https://opendev.org/openstack/python-novaclient/commit/03dca4bc823c82054869dfaf6925d5e1e068ac51 | 22:59 |
| ianw | we were testing that the user_data specified in the nodepool config makes it through to nova | 22:59 |
| ianw | is there another suggested way to check that? | 23:00 |
| *** ociuhandu has quit IRC | 23:01 | |
| melwitt | ianw: hm, yeah I wondered if anyone would be affected by that change when I saw it go through. I can't immediately think of anything other than using the novaclient python binding. or calling the API directly | 23:03 |
| ianw | yeah, i think maybe using the binding might work; it doesn't seem like it's generically useful enough to put back in behind a switch or something | 23:05 |
| ianw | unless others think it is ... | 23:06 |
| melwitt | yeah, I wondered the same. | 23:07 |
| melwitt | it's been years but I've looked at it before as an end user, as a "did I do that right?" sanity check | 23:09 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing flavor extra spec policies https://review.opendev.org/719372 | 23:11 |
| corvus | melwitt: yeah, i think it's worth keeping in some form because of that | 23:11 |
| corvus | but putting it behind a cli flag is fine -- i get that "dump a bunch of base64 by default" isn't optimal ux :) | 23:12 |
| melwitt | heh yeah | 23:12 |
| melwitt | well, it would have been good to have heard this before last thursday :( cause it's in there and locked in for ussuri now | 23:13 |
| melwitt | I guess we could backport | 23:13 |
| corvus | but getting at it from the cli (with a flag) "i put a key in user data, and it didn't show up in the booted vm -- did it actually make it to the cloud?" would be nice | 23:13 |
| melwitt | yeah, I agree | 23:14 |
| melwitt | cc stephenfin | 23:14 |
| corvus | ianw: i guess the -src version of that nodepool job doesn't install the clients from source? | 23:15 |
| corvus | iiuc, we have a -src job to detect pre-release problems with openstacksdk, but maybe it stops there... | 23:15 |
| ianw | coruvs: i guess not; i think it only pulls in nodepool, openstacksdk, dib | 23:16 |
| corvus | that must be how we missed it, since the changed merged in feb, and we've certainly merged nodepool changes which ran that job since then | 23:16 |
| corvus | melwitt: sorry :( | 23:16 |
| gmann | melwitt: and i think (not tried) that patch did not remove that from rebuild operation because there it is present in Rebuild API response as 'user_data' not 'OS-EXT-SRV-ATTR:user_data'. | 23:17 |
| melwitt | gmann: hah, nice | 23:17 |
| gmann | for nodepool case, can it be done via server metadata ? | 23:18 |
| *** ircuser-1 has joined #openstack-nova | 23:19 | |
| *** tosky has quit IRC | 23:20 | |
| ianw | gmann: we're really just testing that the value in the config file for nodepool made it through to the booted nova instance -- the actual data is not used in the test | 23:21 |
| *** ttsiouts has joined #openstack-nova | 23:22 | |
| gmann | ohk i thought it as just tagging the things. | 23:23 |
| *** mlavalle has quit IRC | 23:28 | |
| *** JamesBenson has quit IRC | 23:29 | |
| *** mriedem has left #openstack-nova | 23:31 | |
| *** ociuhandu has joined #openstack-nova | 23:35 | |
| *** ociuhandu has quit IRC | 23:51 | |
| *** ttsiouts has quit IRC | 23:56 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in flavor extra spec policy https://review.opendev.org/719375 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!