| gmann | lbragstad: thanks. i will update with the nova test result on that | 00:02 |
|---|---|---|
| *** brinzhang has joined #openstack-nova | 00:11 | |
| *** eharney has quit IRC | 00:12 | |
| gmann | brinzhang: you planning to add these tests in follow up right? - https://review.opendev.org/#/c/693828/25/nova/tests/unit/api/openstack/compute/test_volumes.py@1342 | 00:13 |
| brinzhang | gmann: yes | 00:13 |
| gmann | ok, thanks | 00:13 |
| brinzhang | gmann: but will be later, after FF | 00:13 |
| brinzhang | I remember this patch need to add FUP | 00:13 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 00:22 |
| brinzhang | gmann: I update the microversion 2.85 novalcient comment by stephenfin, pls review again, thanks | 00:23 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 00:52 |
| *** bauzas has quit IRC | 01:01 | |
| *** zhanglong has joined #openstack-nova | 01:13 | |
| *** Liang__ has joined #openstack-nova | 01:13 | |
| *** Liang__ has quit IRC | 01:16 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: FUP: add missing test for PUT volume attachments API https://review.opendev.org/718589 | 01:28 |
| *** bauzas has joined #openstack-nova | 01:29 | |
| brinzhang | gmann: follow up your comments in https://review.opendev.org/#/c/718589/ | 01:30 |
| openstackgerrit | Merged openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | 01:39 |
| *** corvus has quit IRC | 01:48 | |
| *** corvus has joined #openstack-nova | 01:49 | |
| *** zhanglong has quit IRC | 01:57 | |
| *** zhanglong has joined #openstack-nova | 02:03 | |
| huaqiang | ls | 02:06 |
| *** zhanglong has quit IRC | 02:19 | |
| *** zhanglong has joined #openstack-nova | 02:24 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 02:25 |
| *** ociuhandu has quit IRC | 02:31 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server password policies https://review.opendev.org/717417 | 02:34 |
| *** mkrai has joined #openstack-nova | 02:45 | |
| *** yaawang has quit IRC | 02:55 | |
| *** yaawang has joined #openstack-nova | 02:56 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884 | 03:01 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884 | 03:01 |
| *** ociuhandu has joined #openstack-nova | 03:03 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587 | 03:21 |
| *** zhanglong has quit IRC | 03:31 | |
| *** ociuhandu has quit IRC | 03:32 | |
| *** mkrai_ has joined #openstack-nova | 03:36 | |
| *** mkrai has quit IRC | 03:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689 | 04:11 |
| *** brinzhang_ has joined #openstack-nova | 04:14 | |
| *** brinzhang has quit IRC | 04:17 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689 | 04:24 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-console-auth-tokens policy https://review.opendev.org/706690 | 04:24 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654 | 04:25 |
| *** evrardjp has quit IRC | 04:37 | |
| *** evrardjp has joined #openstack-nova | 04:37 | |
| *** yaawang has quit IRC | 04:40 | |
| *** udesale has joined #openstack-nova | 04:40 | |
| *** yaawang has joined #openstack-nova | 04:41 | |
| *** brinzhang has joined #openstack-nova | 04:43 | |
| *** logan- has quit IRC | 04:45 | |
| *** brinzhang_ has quit IRC | 04:46 | |
| *** logan_ has joined #openstack-nova | 04:47 | |
| *** logan_ is now known as logan- | 04:48 | |
| *** brinzhang_ has joined #openstack-nova | 04:49 | |
| *** _mlavalle_1 has joined #openstack-nova | 04:50 | |
| *** mlavalle has quit IRC | 04:53 | |
| *** brinzhang has quit IRC | 04:53 | |
| *** brinzhang has joined #openstack-nova | 04:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654 | 04:57 |
| *** brinzhang_ has quit IRC | 04:57 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-aggregates policy https://review.opendev.org/701656 | 05:02 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 05:10 |
| *** ratailor has joined #openstack-nova | 05:10 | |
| *** brinzhang_ has joined #openstack-nova | 05:13 | |
| *** brinzhang_ has quit IRC | 05:15 | |
| *** brinzhang_ has joined #openstack-nova | 05:15 | |
| *** brinzhang has quit IRC | 05:16 | |
| *** brinzhang has joined #openstack-nova | 05:20 | |
| *** brinzhang_ has quit IRC | 05:23 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 05:26 |
| *** ociuhandu has joined #openstack-nova | 05:31 | |
| *** brinzhang_ has joined #openstack-nova | 05:32 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 05:36 |
| *** brinzhang has quit IRC | 05:36 | |
| *** mkrai has joined #openstack-nova | 05:38 | |
| *** mkrai_ has quit IRC | 05:40 | |
| *** brinzhang has joined #openstack-nova | 05:49 | |
| *** brinzhang has quit IRC | 05:51 | |
| *** brinzhang has joined #openstack-nova | 05:51 | |
| *** brinzhang_ has quit IRC | 05:52 | |
| *** ociuhandu has quit IRC | 06:01 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 06:07 |
| *** dpawlik has joined #openstack-nova | 06:07 | |
| *** ttsiouts has joined #openstack-nova | 06:30 | |
| *** slaweq_ has quit IRC | 06:36 | |
| *** dpawlik has quit IRC | 06:37 | |
| *** dpawlik has joined #openstack-nova | 06:39 | |
| *** _mlavalle_1 has quit IRC | 06:41 | |
| *** ociuhandu has joined #openstack-nova | 06:42 | |
| *** xek_ has joined #openstack-nova | 06:48 | |
| *** nightmare_unreal has joined #openstack-nova | 06:51 | |
| *** zhanglong has joined #openstack-nova | 06:59 | |
| *** vishalmanchanda has joined #openstack-nova | 06:59 | |
| *** dklyle has quit IRC | 07:00 | |
| *** slaweq_ has joined #openstack-nova | 07:00 | |
| openstackgerrit | Merged openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 07:01 |
| *** slaweq_ is now known as slaweq | 07:03 | |
| *** zhanglong has quit IRC | 07:06 | |
| *** dtantsur|afk is now known as dtantsur | 07:06 | |
| gibi | good morning | 07:09 |
| *** zhanglong has joined #openstack-nova | 07:09 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:10 | |
| *** iurygregory has joined #openstack-nova | 07:11 | |
| *** brinzhang_ has joined #openstack-nova | 07:13 | |
| *** tesseract has joined #openstack-nova | 07:15 | |
| *** brinzhang has quit IRC | 07:16 | |
| *** rpittau|afk is now known as rpittau | 07:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | 07:19 |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | 07:20 |
| *** zhanglong has quit IRC | 07:21 | |
| gibi | brinzhang_: hi! are you working on a follow up for https://review.opendev.org/#/c/712651/ ? | 07:24 |
| *** avolkov has joined #openstack-nova | 07:26 | |
| brinzhang_ | gibi: yeah, it can be follow up, but not now | 07:28 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 07:28 |
| gibi | brinzhang_: ack | 07:29 |
| bauzas | gibi: fwiw, I updated my vgpu series based on stephenfin's feedback https://review.opendev.org/#/c/715489/ | 07:29 |
| gibi | bauzas: ack :) | 07:29 |
| brinzhang_ | gibi: I fixed some commnets from stephenfin, and Takashi in PS17, can you +A for this patch? | 07:29 |
| gibi | brinzhang_: I will read, and I have to decied how much of that patch is my code before I +At. worst case we can ask stephenfin to +A-it | 07:30 |
| bauzas | gibi: thanks | 07:30 |
| bauzas | gibi: I understand your position, I don't want to rush on you | 07:31 |
| *** zhanglong has joined #openstack-nova | 07:32 | |
| brinzhang_ | gibi: got it, thanks ^^ | 07:32 |
| brinzhang_ | good morning gibi | 07:32 |
| lyarwood | \o morning all | 07:33 |
| gibi | bauzas: I want to unblock the client patches as we need to release the client today and that need the API patches to land. | 07:33 |
| gibi | lyarwood: o/ | 07:33 |
| gibi | lyarwood: surprise! your 2.87 patches got merge conflicted :/ | 07:34 |
| *** jraju__ has joined #openstack-nova | 07:35 | |
| *** psachin has joined #openstack-nova | 07:37 | |
| lyarwood | gibi: /o\ | 07:37 |
| lyarwood | gibi: ./me looks | 07:37 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 07:38 |
| lyarwood | ah stephenfin rebased his series | 07:38 |
| * lyarwood rebases all the things | 07:38 | |
| bauzas | gibi: that's totally understandable | 07:39 |
| bauzas | gibi: fwiw, I can also review a few things | 07:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 07:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 07:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 07:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430 | 07:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 07:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 07:40 |
| brinzhang_ | lyarwood: your rebase are not lost +A, surprise | 07:41 |
| brinzhang_ | today I rebased watcher, cyborg project's patch, all lost the +A :( | 07:42 |
| *** tosky has joined #openstack-nova | 07:42 | |
| *** ralonsoh has joined #openstack-nova | 07:45 | |
| bauzas | brinzhang_: you loose the +W if your rebase impacted your series somewhere | 07:46 |
| bauzas | brinzhang_: if you just rebase on some change or master that just changes SHA1s without really needing to update your series, then meh | 07:47 |
| brinzhang_ | bauzas: you mean, if anything changed, and not conflict in the same place, it will be not lost the +W? | 07:47 |
| lyarwood | brinzhang_: if nothing has changed in your changes you keep the +W | 07:47 |
| brinzhang_ | lyarwood: Got it, I will be concern this in the future ^^, thanks lyarwood, bauzas | 07:48 |
| *** ratailor has quit IRC | 07:51 | |
| *** brinzhang has joined #openstack-nova | 07:51 | |
| *** brinzhang_ has quit IRC | 07:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | 07:56 |
| *** ratailor has joined #openstack-nova | 07:58 | |
| *** zhanglong has quit IRC | 07:59 | |
| bauzas | brinzhang_: fwiw, you can upload your series without having them rebased on the gerrit remote before by using git review -R | 08:00 |
| bauzas | i never use this one tho | 08:00 |
| *** threestrands has quit IRC | 08:00 | |
| bauzas | tbc, git review does rebase on the gerrit git remote you have locally (and which is updated) before it does send it to Gerrit | 08:01 |
| bauzas | brinzhang: this is the step you can skip with the -R flag | 08:01 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Break up get_disk_mapping within blockinfo https://review.opendev.org/714962 | 08:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Combine SUPPORTED_DEVICE_BUS and SUPPORTED_STORAGE_BUSES https://review.opendev.org/718448 | 08:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Remove the use of the term `unstable rescue` INFO logs https://review.opendev.org/718451 | 08:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | 08:06 |
| lyarwood | I'm using it at the moment to avoid rebasing mine and stephenfin's unmerged stuff | 08:06 |
| bauzas | lyarwood: good call | 08:09 |
| brinzhang | bauzas: I have nerver used this, do you have some docs that I can reference, I would like to study ^^ | 08:11 |
| *** zhanglong has joined #openstack-nova | 08:11 | |
| *** xek_ is now known as xek | 08:17 | |
| bauzas | brinzhang: not more than https://docs.openstack.org/infra/git-review/usage.html | 08:20 |
| brinzhang | bauzas: "git review -R" not any suffix? that I can directly run it, and that can skip "git rebase i xxx" | 08:22 |
| *** martinkennelly has joined #openstack-nova | 08:23 | |
| bauzas | it's just a flag | 08:24 |
| bauzas | you can use any other one for uploading | 08:24 |
| bauzas | of course git review -d -R doesn't make any sense | 08:24 |
| bauzas | since you download instead | 08:24 |
| brinzhang | I always use git review -d id | 08:25 |
| gibi | stephenfin: could you hit https://review.opendev.org/#/c/712651 when you are up? | 08:25 |
| gibi | bauzas: if you have time, could you re-review https://review.opendev.org/#/c/718357 ? | 08:27 |
| gibi | stephenfin: the tests in custom trait handling needs tweeking https://review.opendev.org/#/c/718461 | 08:28 |
| gibi | we need somebody other than stephen who feels good about +2ing https://review.opendev.org/#/c/700812 in lyarwood's series. that part of nova is not my strong suite so I'm only +1 | 08:30 |
| bauzas | gibi: sure thing, I'm available for upstream this week | 08:31 |
| brinzhang | gibi: I have a question in https://review.opendev.org/#/c/712651/19/novaclient/v2/shell.py@2741 | 08:32 |
| brinzhang | gibi: do we need add default=None to --no-delete-on-termination? and why? | 08:33 |
| gibi | brinzhang: let me check that | 08:33 |
| gibi | bauzas: thanks | 08:33 |
| gibi | brinzhang: I copied stephenfin's solution from the reworked 2.83 patch | 08:33 |
| brinzhang | I reviewed the config_drive form stephenfin, I also find he also set for the --no-config-drive | 08:34 |
| gibi | ohh | 08:34 |
| brinzhang | I think it's ok, but I dont know why | 08:34 |
| gibi | I will look | 08:34 |
| brinzhang | s/ also set / also not set | 08:35 |
| gibi | ahh, then I copied well at least :D | 08:35 |
| brinzhang | gibi: yeah, I think stephenfin can answer why ^^ | 08:36 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: libvirt: change UEFI check to handle AArch64 better https://review.opendev.org/714311 | 08:36 |
| bauzas | gibi: stephenfin: mmm, something is still wrong with https://review.opendev.org/#/c/718461/3 https://5f439afd55f568b98179-509bae49365f8635e29d5b96780095d8.ssl.cf5.rackcdn.com/718461/3/check/openstack-tox-py37/bd3dc11/testr_results.html | 08:37 |
| gibi | bauzas: yepp, I think the regex changed and therefore the name of the namespace changed, so the test needs to be updated | 08:38 |
| gibi | I let stephenfin do that so we can +2 it | 08:38 |
| brinzhang | bauzas: https://review.opendev.org/#/c/718357/ this patch and https://review.opendev.org/#/c/701430 from lyarwood all modified rest_api_version_history.rst, do you think is there a conflict? | 08:39 |
| *** zhanglong has quit IRC | 08:42 | |
| gibi | brinzhang: looking at the change they are separate by unchanged lines so I think git will manage to merge it | 08:43 |
| bauzas | brinzhang: gibi: sorry a bit distracted due to the kids :) | 08:45 |
| *** ociuhandu has quit IRC | 08:46 | |
| brinzhang | gibi: yes, it's ok, I tested in local used: | 08:46 |
| brinzhang | git review -d 701430 | 08:46 |
| *** ociuhandu has joined #openstack-nova | 08:46 | |
| brinzhang | git review -x 718357 | 08:46 |
| brinzhang | I think I should simulate a scenario to check "git review -R", thanks gibi, bauzas | 08:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in servers Policies https://review.opendev.org/662968 | 08:47 |
| bauzas | brinzhang: since recent revisions, Gerrit now tells you whether it would create a merge conflict | 08:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in servers Policies https://review.opendev.org/662968 | 08:48 |
| bauzas | I mean, the Gerrit UI | 08:48 |
| gibi | I never used git review. I like the full controll of git push <remote> <what>:refs/for/<branch>/topic | 08:48 |
| *** brinzhang_ has joined #openstack-nova | 08:49 | |
| gibi | I mean <topic> | 08:49 |
| brinzhang_ | bauzas: yeah, I know, but that until the patch merged then we can know whether conflict from gerrit | 08:49 |
| huaqiang | :qa | 08:49 |
| huaqiang | exit | 08:49 |
| huaqiang | :( | 08:49 |
| *** huaqiang has left #openstack-nova | 08:49 | |
| bauzas | brinzhang: no, you can test on your local git repo | 08:50 |
| brinzhang_ | ah, I was dropped, I think I missed what did you said above, gibi | 08:50 |
| gibi | I never used git review. I like the full controll of git push <remote> | 08:50 |
| *** huaqiang has joined #openstack-nova | 08:50 | |
| gibi | <what>:refs/for/<branch>/topic | 08:50 |
| bauzas | brinzhang: you have a local git remote on your git repo that's named 'gerrit' | 08:50 |
| bauzas | git remote -v | grep gerrit | 08:50 |
| brinzhang_ | bauzas: yeah, I know, it's in the project's git/config | 08:51 |
| bauzas | correct | 08:51 |
| *** huaqiang has quit IRC | 08:51 | |
| bauzas | so you can basically test what you want | 08:51 |
| *** huaqiang has joined #openstack-nova | 08:51 | |
| brinzhang_ | I mean, Gerrit cannot know the merged conflict, if the patch doesnot merge | 08:51 |
| brinzhang_ | in local I am easy to know which is conflict | 08:52 |
| *** brinzhang has quit IRC | 08:52 | |
| brinzhang_ | s/am/can | 08:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | 08:52 |
| bauzas | maybe I misunderstand you | 08:53 |
| *** zhanglong has joined #openstack-nova | 08:53 | |
| bauzas | you mean that you can't predict that Zuul will tell you a merge conflict if there are concurrent patches coming by, if so yes I agree | 08:53 |
| brinzhang_ | gibi: yes, git push gave by gerrit form patch's "Download" tag | 08:53 |
| brinzhang_ | bauzas: yes, that's what I want to say | 08:54 |
| bauzas | ... and nobody can :-) | 08:54 |
| bauzas | that's what happens when you merge N changes at once without testing them each one by one | 08:55 |
| brinzhang_ | bauzas, gibi: haha, thanks, I will check my question from sandbox test. | 08:55 |
| brinzhang_ | bauzas: yes, agree | 08:55 |
| *** derekh has joined #openstack-nova | 08:56 | |
| *** brinzhang has joined #openstack-nova | 08:58 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | 08:58 |
| bauzas | gibi: okay so I'm confused | 08:58 |
| bauzas | gibi: about https://review.opendev.org/#/c/718461/ | 08:58 |
| bauzas | tbh, I dropped attention yesterday evening about how things were going | 08:59 |
| gibi | bauzas: we found yesterday that keys like trait:CUSTOM_* is not accepted | 08:59 |
| bauzas | that, I understood :) | 09:00 |
| gibi | and also found out that placement is more strict about trait names and resource class names than nova | 09:00 |
| gibi | I think this is the two change in that patch | 09:00 |
| *** brinzhang_ has quit IRC | 09:01 | |
| *** zhanglong has quit IRC | 09:01 | |
| kashyap | sean-k-mooney: stephenfin: Can you remind me again: Nova doesn't yet support vCPU hot unplug, yeah? | 09:01 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 09:02 |
| stephenfin | kashyap: correct | 09:02 |
| *** tobias-urdin has quit IRC | 09:02 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | 09:02 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | 09:03 |
| *** tkajinam has quit IRC | 09:03 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | 09:03 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | 09:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | 09:03 |
| kashyap | stephenfin: Thx | 09:03 |
| kashyap | And we do support I/O throttling? IIRC, we do have the I/O limit settings | 09:04 |
| stephenfin | yes, though I don't know how well they work since testing is light | 09:04 |
| kashyap | Yep; read_bytes_sec/write_bytes_sec | 09:04 |
| kashyap | stephenfin: Oh, that rings a faint bell where you were traiging a bug on it | 09:05 |
| kashyap | s/on it/about it/ | 09:05 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-evacuate policies https://review.opendev.org/708237 | 09:05 |
| brinzhang | stephenfin: can you explain why we add default=None, and not add for the --no-config-drive and --no-delete-on-termination? | 09:06 |
| brinzhang | stephenfin: thanks for +W | 09:06 |
| kashyap | Another one: no memory hotplug either, yeah? | 09:06 |
| *** zhanglong has joined #openstack-nova | 09:06 | |
| brinzhang | stephenfin: https://review.opendev.org/#/c/712651/19/novaclient/v2/shell.py@2741 and https://review.opendev.org/#/c/718349/4/novaclient/v2/shell.py@1551 | 09:07 |
| stephenfin | brinzhang: It's not necessary. The default will be set by '--config-drive' if it's not specified, and will be overridden by '--no-config-drive' if necessary | 09:08 |
| *** huaqiang has quit IRC | 09:08 | |
| brinzhang | controlled by "group"? | 09:09 |
| *** huaqiang has joined #openstack-nova | 09:09 | |
| stephenfin | Yeah, group is our own invention. It's essentially an alias for dest that also implies that we should add opts sharing the same value to a mutually exclusive group. See [1] | 09:10 |
| *** dpawlik has quit IRC | 09:10 | |
| stephenfin | [1] https://review.opendev.org/#/c/718349/4/novaclient/shell.py | 09:10 |
| stephenfin | kashyap: correct | 09:10 |
| kashyap | stephenfin: Thx; I'm answering a doc writer's questions. Hence the questions here | 09:11 |
| *** zhanglong has quit IRC | 09:11 | |
| *** zhanglong has joined #openstack-nova | 09:13 | |
| gibi | sh*t https://review.opendev.org/#/c/716222/ got double hit by https://bugs.launchpad.net/nova/+bug/1823251 the gate queue will reset :/ | 09:14 |
| openstack | Launchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] | 09:14 |
| brinzhang | stephenfin: yeah, I looked the group, got it, thanks | 09:15 |
| lyarwood | gibi: time to reintroduce https://review.opendev.org/#/c/683009/ ? | 09:16 |
| gibi | lyarwood: yeah. I think I will push that again | 09:16 |
| *** zhanglong has quit IRC | 09:17 | |
| bauzas | gibi: FWIW, I work tomorrow, I can fast-approve any change that was +W today | 09:18 |
| bauzas | in case we got hit by the gate | 09:18 |
| gibi | bauzas: thanks. I will rely on your power | 09:18 |
| bauzas | gibi: the only problem is that I could miss any change, so please CC on the ones you'd like to see | 09:19 |
| bauzas | CC me* | 09:19 |
| bauzas | I can still ask gerrit to find me all +Wd tho | 09:19 |
| bauzas | actually, nevermind, I'll work this way | 09:19 |
| gibi | bauzas: also there is the novaclient release patch that needs an update when 2.87 lands https://review.opendev.org/#/c/718260/ | 09:19 |
| gibi | and thank you | 09:20 |
| *** zhanglong has joined #openstack-nova | 09:20 | |
| bauzas | gibi: fill an etherpad for tracking if you feel I could loose anything | 09:20 |
| gibi | bauzas: I'm on it :) | 09:20 |
| bauzas | cool | 09:20 |
| bauzas | stephenfin: I thought placement wasn't accepting dashes for trait names ? | 09:21 |
| bauzas | shit, can't find the regex on the placement api-ref for reference | 09:23 |
| stephenfin | bauzas: I thought so too, but I checked the regex and they are | 09:23 |
| stephenfin | Sec, lemme drag it out | 09:23 |
| stephenfin | bauzas: https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L27 | 09:24 |
| bauzas | stephenfin: just held a procedural -1 | 09:24 |
| stephenfin | We have a similar regex somewhere in nova | 09:24 |
| bauzas | stephenfin: but then it could be nova regex | 09:24 |
| bauzas | yeah, I was thinking of so | 09:24 |
| stephenfin | bauzas: yeah, here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L57 | 09:25 |
| bauzas | because when I wanted to create a custom trait for nvidia-11, I got fucked up | 09:25 |
| stephenfin | hyphens are perfectly fine based on those | 09:25 |
| bauzas | I'm then confused | 09:26 |
| *** damien_r has quit IRC | 09:26 | |
| bauzas | lemme provide a DNM based on my func test | 09:26 |
| bauzas | and you'll see that CUSTOM_NVIDIA-11 isn't a thing accepted | 09:26 |
| bauzas | that had to be upper cases btw. | 09:26 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 09:26 |
| bauzas | stephenfin: man, we're bikeshedding on a regex while this should be documented on the api-ref... | 09:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Temporarily skip TestNovaMigrationsMySQL https://review.opendev.org/718629 | 09:27 |
| *** damien_r has joined #openstack-nova | 09:27 | |
| dtantsur | morning folks! we seem to be seeing guru meditations in grenade jobs (at least) https://zuul.opendev.org/t/openstack/build/638527be7aba44b59bb37c71dffe4a4a/log/logs/screen-n-cpu.txt#15859 | 09:27 |
| gibi | lyarwood: ^^ | 09:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Revert "Temporarily skip TestNovaMigrationsMySQL" https://review.opendev.org/718630 | 09:28 |
| *** damien_r has quit IRC | 09:28 | |
| *** tobias-urdin has joined #openstack-nova | 09:29 | |
| *** zhanglong has quit IRC | 09:32 | |
| *** damien_r has joined #openstack-nova | 09:32 | |
| bauzas | gibi: +Wd the skippest test | 09:32 |
| lyarwood | bauzas++ got there ahead of me | 09:32 |
| gibi | thanks folks! | 09:32 |
| *** udesale_ has joined #openstack-nova | 09:34 | |
| stephenfin | lyarwood: comment on https://review.opendev.org/#/c/718464/ | 09:35 |
| kashyap | lyarwood: What does the term "storage live migration" mean to you? | 09:35 |
| kashyap | (In terms of Nova) | 09:35 |
| kashyap | For me, there are two ways to read it: | 09:35 |
| kashyap | (1) Live migration without shared storage (also confusingly called "live block migration") | 09:35 |
| kashyap | (2) Migrating only the storage from src to dest, while the VM itself is running on src. | 09:36 |
| lyarwood | 2, moving storage between backends while the instance stays in place, something we only support through volume migration and retype. | 09:37 |
| *** zhanglong has joined #openstack-nova | 09:37 | |
| lyarwood | stephenfin: looking | 09:37 |
| *** udesale has quit IRC | 09:38 | |
| kashyap | lyarwood: Right, it's the thing that's based on "swap volume". | 09:38 |
| lyarwood | kashyap: yeah indeed | 09:38 |
| kashyap | lyarwood: Thx. (Context: trying to answer a docs person) | 09:39 |
| *** damien_r has quit IRC | 09:39 | |
| kashyap | lyarwood: I'd guess this doc is good enough about 'cinder retype', yeah? -- https://docs.openstack.org/cinder/rocky/contributor/migration.html | 09:40 |
| *** zhanglong has quit IRC | 09:42 | |
| lyarwood | https://docs.openstack.org/cinder/latest/contributor/migration.html but yeah | 09:43 |
| *** ociuhandu has quit IRC | 09:45 | |
| kashyap | Thx | 09:45 |
| *** dpawlik has joined #openstack-nova | 09:49 | |
| bauzas | gibi: I really appreciate your help on my series btw. given how you're overloaded | 09:49 |
| bauzas | I mean, i saw your comments | 09:49 |
| bauzas | and I appreciated them | 09:49 |
| gibi | bauzas: I think I can finish the test review before lunch :) | 09:50 |
| bauzas | tbh, I'll remember this cycle for my whole life | 09:50 |
| gibi | crazy times | 09:50 |
| bauzas | just because of the lockdown with kids hitting me every 5 mins for questions | 09:50 |
| bauzas | me, Sylvain Bauza, software engineer, teacher, IT support folk for my spouse, legal advisor, parent of 2 kids | 09:51 |
| gibi | but it is a great achievement that you can manage all these | 09:52 |
| bauzas | (legal advisor because we have to consider every time we go out whether it's a legally accepted reason) | 09:52 |
| *** ociuhandu has joined #openstack-nova | 09:58 | |
| *** brinzhang_ has joined #openstack-nova | 09:59 | |
| *** brinzhang has quit IRC | 10:02 | |
| *** d34dh0r53 has quit IRC | 10:02 | |
| *** d34dh0r53 has joined #openstack-nova | 10:03 | |
| *** zhanglong has joined #openstack-nova | 10:09 | |
| kashyap | Can anyone remind me: does Nova distnguish between these two suspend-related power states: S3 (standby) and S4 (hibernate) | 10:12 |
| *** rpittau is now known as rpittau|bbl | 10:13 | |
| *** zhanglong has quit IRC | 10:14 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | 10:15 |
| gibi | bauzas: small issue in https://review.opendev.org/#/c/717975/11/nova/tests/functional/libvirt/test_vgpu.py@173 but overall looks good | 10:15 |
| kashyap | Nope, we don't: https://docs.openstack.org/api-guide/compute/server_concepts.html | 10:15 |
| * gibi lunches | 10:16 | |
| bauzas | gibi: <3 with love | 10:19 |
| * bauzas pdb'ing to verify your point | 10:20 | |
| *** zhanglong has joined #openstack-nova | 10:22 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 10:23 |
| openstackgerrit | Merged openstack/nova master: Convert delete_on_termination from string to boolean https://review.opendev.org/718387 | 10:28 |
| *** zhanglong has quit IRC | 10:29 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | 10:30 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | 10:31 |
| *** xek has quit IRC | 10:32 | |
| sean-k-mooney | bauzas: the hypens need to be converted to _ | 10:40 |
| sean-k-mooney | bauzas: https://github.com/openstack/os-traits/blob/master/os_traits/__init__.py#L140-L156 | 10:42 |
| sean-k-mooney | kashyap: yes | 10:43 |
| sean-k-mooney | kashyap: suspend/resume is suspend to disk, pause/unpause is suspend to ram | 10:43 |
| sean-k-mooney | kashyap: so not qutie the same as s3 vs s4 | 10:44 |
| sean-k-mooney | but for pause we just stop the execution fo the qemu cpu without stoping the full qemu proces | 10:44 |
| sean-k-mooney | where as suspend does a libvirt managed save dumping guest ram to a file on disk | 10:45 |
| sean-k-mooney | from a guest os perspecitive its more or less looks the same unless you have pci passthough deivces | 10:45 |
| *** ttsiouts has quit IRC | 10:46 | |
| bauzas | sean-k-mooney: ahah, thanks for the explanation ! | 10:48 |
| bauzas | now I understand, I could have asked to create a trait like 'custom_nvidia-11' but then normalize_name() would ask Placement to create trait named 'CUSTOM_NVIDIA_11') | 10:49 |
| sean-k-mooney | you can just take the mdev type and call that function and it should work | 10:49 |
| sean-k-mooney | yes | 10:49 |
| *** ociuhandu has quit IRC | 10:50 | |
| bauzas | I could even provide a name like 'custom_foo?.%^', it would just do 'CUSTOM_FOO____' | 10:50 |
| sean-k-mooney | which means in your flavor you need to use 'CUSTOM_NVIDIA_11' or you will get no results form placement | 10:50 |
| *** zhanglong has joined #openstack-nova | 10:50 | |
| bauzas | sean-k-mooney: yeah, ok, good point | 10:50 |
| bauzas | sean-k-mooney: I'm afraid placement api-ref doesn't mention it | 10:51 |
| bauzas | not talking of the normalization | 10:51 |
| sean-k-mooney | the vaild chariters | 10:51 |
| bauzas | yup | 10:51 |
| bauzas | this would clarify the expectations | 10:51 |
| sean-k-mooney | so i think it wont normalise on your behalf | 10:51 |
| *** ociuhandu has joined #openstack-nova | 10:51 | |
| *** ttsiouts has joined #openstack-nova | 10:51 | |
| bauzas | you could do whatever you want, but ask placement the right things | 10:51 |
| sean-k-mooney | it will reject the creation fo the trait? | 10:51 |
| bauzas | sean-k-mooney: that's the whole point, I dunno | 10:52 |
| sean-k-mooney | ya i have never tried to check honestly | 10:52 |
| bauzas | I dunno whether Placement API is strict with naming or just allows anything to come by and normalize it | 10:52 |
| bauzas | with the latter, I have concerns | 10:52 |
| bauzas | this is not RESTful | 10:52 |
| bauzas | if I'm creating an object, I'm expecting the output of the creation is identical to the object I passed | 10:53 |
| bauzas | from a semantics perspective | 10:53 |
| bauzas | (or idempotent if you prefer) | 10:53 |
| sean-k-mooney | they dont actully have a test case for it but from the doc text i would expect you will get a 400 | 10:55 |
| sean-k-mooney | https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/traits.yaml#L17-L34 | 10:55 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 10:56 |
| bauzas | sean-k-mooney: FWIW, the docs I wrote for vgpu multiple types only mentions trait names being capitalized and not having other chars but the ones wanted https://8ae97f93626416bcf134-be430d2f919a8698d2e96141ed3ac146.ssl.cf1.rackcdn.com/715490/10/check/openstack-tox-docs/b670504/docs/admin/virtual-gpu.html#optional-provide-custom-traits-for-multiple-gpu-types | 10:56 |
| kashyap | sean-k-mooney: Yeap; noted - on suspend. Thanks | 10:57 |
| *** ociuhandu has quit IRC | 10:57 | |
| bauzas | sean-k-mooney: yeah thanks for the gabbit, that proves the Placement API ref should be updated to mention such limitations | 10:57 |
| sean-k-mooney | well gabbit should also be extened to test an invalid trait that is not normalised | 10:58 |
| bauzas | sean-k-mooney: talking of https://docs.openstack.org/api-ref/placement/?expanded=update-resource-provider-traits-detail#update-resource-provider-traits | 10:58 |
| bauzas | whoops, wrong link | 10:59 |
| bauzas | sean-k-mooney: this one sorry https://docs.openstack.org/api-ref/placement/?expanded=update-traits-detail#traits | 11:00 |
| bauzas | Error response codes: badRequest(400) 400 BadRequest if trait name is not prefixed with CUSTOM_ prefix. | 11:00 |
| sean-k-mooney | bauzas: found it https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L17-L22 | 11:00 |
| bauzas | I wasn't crazy \o/ | 11:01 |
| sean-k-mooney | they are using json schema for that validation https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L17-L22 | 11:01 |
| bauzas | stephenfin: ^ | 11:01 |
| sean-k-mooney | with this scema https://github.com/openstack/placement/blob/master/placement/schemas/trait.py | 11:01 |
| bauzas | I was betting this morning that it *wasn't* possible to create traits with hyphens in them | 11:01 |
| stephenfin | <stephenfin> Sec, lemme drag it out | 11:01 |
| stephenfin | <stephenfin> bauzas: https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L27 | 11:01 |
| *** mgoddard has quit IRC | 11:02 | |
| stephenfin | With 1.33 they become alphanumeric, '_', and '-' with a length limit of 64. | 11:02 |
| bauzas | you're talking of the group info | 11:02 |
| bauzas | not the trait | 11:02 |
| bauzas | https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L20 | 11:03 |
| sean-k-mooney | stephenfin: this is the important bit https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L17-L22 | 11:03 |
| sean-k-mooney | so it expands to " "^CUSTOM_[A-Z0-9_]+$" | 11:04 |
| stephenfin | I'm confused. Isn't that exactly what I have? | 11:04 |
| sean-k-mooney | so hyphen is not allowed in the name | 11:04 |
| stephenfin | https://review.opendev.org/#/c/718461/4/nova/api/validation/extra_specs/traits.py@65 | 11:04 |
| stephenfin | I don't allow hyphens in that trait name. I only allow them in the group | 11:04 |
| sean-k-mooney | no | 11:05 |
| sean-k-mooney | [a-zA-Z0-9_-] | 11:05 |
| sean-k-mooney | the trailing - | 11:05 |
| sean-k-mooney | allows hypenes | 11:05 |
| stephenfin | that's the group name, not the trait name | 11:05 |
| sean-k-mooney | oh sorry group | 11:05 |
| stephenfin | trait{group}:CUSTOM_{trait} | 11:05 |
| bauzas | stephenfin: tbc, I clarified https://review.opendev.org/#/c/718461/4 | 11:05 |
| stephenfin | r'([a-zA-Z0-9_-]{1,64})?' applies to group | 11:05 |
| bauzas | (my -1) | 11:05 |
| sean-k-mooney | yep what you have is correct | 11:05 |
| stephenfin | r'[A-Z0-9_]+' applies to trait | 11:06 |
| bauzas | my only concern is with traits | 11:06 |
| sean-k-mooney | bauzas: line 65 handels that | 11:06 |
| sean-k-mooney | and that is correct | 11:06 |
| bauzas | of what ? | 11:06 |
| sean-k-mooney | https://review.opendev.org/#/c/718461/4/nova/api/validation/extra_specs/traits.py@65 | 11:06 |
| *** ttsiouts has quit IRC | 11:07 | |
| sean-k-mooney | stephenfin: although i think bauzas was originally not talking about your validation stuff | 11:07 |
| stephenfin | bauzas: replied | 11:07 |
| bauzas | yeah, again my concern is just abotu https://review.opendev.org/#/c/718461/4/nova/tests/unit/api/validation/extra_specs/test_validators.py@33 | 11:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | 11:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | 11:07 |
| stephenfin | I think you're mixing up the {group} and {trait} parts of the validator | 11:07 |
| bauzas | oh man | 11:07 |
| bauzas | I'm getting headache | 11:07 |
| sean-k-mooney | bauzas that is the list of namespaces | 11:08 |
| sean-k-mooney | so the partern ther is the group name | 11:08 |
| bauzas | yup, turned up my vote | 11:08 |
| bauzas | anyway, lunch | 11:08 |
| sean-k-mooney | stephenfin: could you use constnts for this | 11:08 |
| sean-k-mooney | so in the test you can just refer to the constnat | 11:09 |
| sean-k-mooney | that might make it clearer? | 11:09 |
| sean-k-mooney | im not going to -1 over that but it might help | 11:09 |
| stephenfin | Not really, because we "build" the regex so I have proper groups | 11:09 |
| stephenfin | Also, I'm always reluctant to use constants in unit tests, because if you've a mistake in the constant then you propagate the mistake | 11:10 |
| sean-k-mooney | ya that is a factor although i have seen many typos in unit test where the typo was not important | 11:10 |
| sean-k-mooney | untill you change something | 11:11 |
| sean-k-mooney | ok im going to go re review the vgpu stuff | 11:11 |
| sean-k-mooney | oh lyarwood changes are on top of yours i was wondering why the validation serires was suddenly much longer | 11:12 |
| lyarwood | yeah microversion fun | 11:14 |
| gibi | bauzas: after your lunch, could you check and upgrade your vote on https://review.opendev.org/#/c/700812 ? | 11:15 |
| *** zhanglong has quit IRC | 11:15 | |
| sean-k-mooney | lyarwood: its still not as bad as last cycle when we were trying to land numa live migration, pcpus in plamcnet and vpmem all at once | 11:16 |
| sean-k-mooney | they were ligitametly conflciting at the code level too | 11:17 |
| lyarwood | ouch yeah that must have been fun | 11:17 |
| sean-k-mooney | we ended up doing the same ting stacking it all into one big chain | 11:19 |
| *** ttsiouts has joined #openstack-nova | 11:26 | |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | 11:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | 11:27 |
| *** ociuhandu has joined #openstack-nova | 11:32 | |
| *** ratailor has quit IRC | 11:36 | |
| *** yedongcan has joined #openstack-nova | 11:36 | |
| openstackgerrit | Merged openstack/nova master: Correct server shelve policy check_str https://review.opendev.org/717542 | 11:40 |
| *** ttsiouts has quit IRC | 11:42 | |
| *** ttsiouts has joined #openstack-nova | 11:43 | |
| openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | 11:46 |
| *** ociuhandu has quit IRC | 11:48 | |
| *** ociuhandu has joined #openstack-nova | 11:49 | |
| openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | 11:54 |
| *** ociuhandu has quit IRC | 11:55 | |
| *** dpawlik has quit IRC | 11:56 | |
| *** rpittau|bbl is now known as rpittau | 11:57 | |
| *** nweinber has joined #openstack-nova | 12:02 | |
| *** eharney has joined #openstack-nova | 12:03 | |
| *** dpawlik has joined #openstack-nova | 12:08 | |
| *** mkrai has quit IRC | 12:12 | |
| openstackgerrit | Alexandre arents proposed openstack/nova master: libvirt: Calculate disk_over_committed for raw instances https://review.opendev.org/717037 | 12:14 |
| bauzas | gibi: back there | 12:14 |
| bauzas | gibi: just upped to +2 https://review.opendev.org/#/c/700812/22 do you want to +W ? | 12:15 |
| gibi | bauzas: no, go ahead with +W | 12:16 |
| gibi | and thanks | 12:16 |
| *** igordc has quit IRC | 12:18 | |
| *** psachin has quit IRC | 12:26 | |
| *** ociuhandu has joined #openstack-nova | 12:27 | |
| sean-k-mooney | artom: just noticed you had https://review.opendev.org/#/c/672127/1 for https://bugs.launchpad.net/nova/train/+bug/1836389 | 12:38 |
| openstack | Launchpad bug 1836389 in OpenStack Compute (nova) ussuri "Device role tagging doesn't work for SRIOV PF" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | 12:39 |
| sean-k-mooney | i just went and triaged the bug but are you actully planning to pick that back up since its been 9 months | 12:39 |
| sean-k-mooney | it would be good to fix it but not sure if you will have time between now and rc1 | 12:40 |
| *** iurygregory has quit IRC | 12:43 | |
| *** iurygregory has joined #openstack-nova | 12:44 | |
| *** ttsiouts has quit IRC | 12:48 | |
| *** ttsiouts has joined #openstack-nova | 12:50 | |
| artom | sean-k-mooney, we had another downstream bug for that downstream, I can try to find the link | 12:51 |
| artom | sean-k-mooney, yeah, I guess I can try and get that in before RC | 12:52 |
| *** lbragstad_ has joined #openstack-nova | 12:52 | |
| sean-k-mooney | you had the link in the upstream bug | 12:53 |
| artom | sean-k-mooney, ah ok - I wonder why that stalled out | 12:54 |
| *** lbragstad has quit IRC | 12:54 | |
| sean-k-mooney | you proably got pulled into something else that was on fire | 12:55 |
| *** jamesden_ has joined #openstack-nova | 12:55 | |
| *** ociuhandu has quit IRC | 12:55 | |
| *** ociuhandu has joined #openstack-nova | 12:55 | |
| sean-k-mooney | from the looks of it the bug was filed by the nfv dfg as they were trying to use the device role tagging for configuring the trex trafic generator | 12:56 |
| sean-k-mooney | i would guess they just worked around it manually | 12:57 |
| *** jamesdenton has quit IRC | 12:57 | |
| *** ttsiouts has quit IRC | 12:59 | |
| *** ociuhandu has quit IRC | 13:00 | |
| *** ttsiouts has joined #openstack-nova | 13:03 | |
| *** ociuhandu has joined #openstack-nova | 13:04 | |
| *** ttsiouts has quit IRC | 13:19 | |
| stephenfin | bauzas: comments from sean-k-mooney and I on https://review.opendev.org/#/c/715490/ | 13:25 |
| *** ttsiouts has joined #openstack-nova | 13:29 | |
| * huaqiang | 13:36 | |
| *** huaqiang has quit IRC | 13:36 | |
| *** huaqiang has joined #openstack-nova | 13:37 | |
| bauzas | stephenfin: sean-k-mooney: yup, sorry, I was off for my kids | 13:38 |
| bauzas | will provide a new patchset | 13:40 |
| *** ociuhandu has quit IRC | 13:44 | |
| *** ociuhandu has joined #openstack-nova | 13:44 | |
| *** ociuhandu has quit IRC | 13:47 | |
| *** ociuhandu has joined #openstack-nova | 13:48 | |
| *** priteau has joined #openstack-nova | 13:49 | |
| *** ttsiouts has quit IRC | 13:49 | |
| *** ttsiouts has joined #openstack-nova | 13:49 | |
| *** rcernin has quit IRC | 13:54 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Fix ut error on Aarch64(And other non-x86 platform) https://review.opendev.org/713163 | 13:59 |
| *** nightmare_unreal has quit IRC | 14:00 | |
| lyarwood | hmm did the gate just get reset? | 14:00 |
| lyarwood | actually nvm I don't think it did | 14:02 |
| gmann | gibi ping | 14:03 |
| *** ttsiouts has quit IRC | 14:05 | |
| *** d34dh0r53 has quit IRC | 14:08 | |
| *** d34dh0r53 has joined #openstack-nova | 14:09 | |
| *** d34dh0r53 has quit IRC | 14:11 | |
| *** tkajinam has joined #openstack-nova | 14:13 | |
| bauzas | stephenfin: gibi: sean-k-mooney: new patch for https://review.opendev.org/#/c/715490/ is on its way | 14:14 |
| *** dave-mccowan has joined #openstack-nova | 14:14 | |
| sean-k-mooney | cool ill review it when its ready | 14:15 |
| bauzas | just running tests locally | 14:17 |
| bauzas | sean-k-mooney: you left a -1 but I didn't understand exacly why | 14:17 |
| * gibi is back | 14:19 | |
| *** lpetrut has joined #openstack-nova | 14:19 | |
| gibi | gmann: ping | 14:20 |
| sean-k-mooney | it was for the fact we skiped creating the mdev if the could not instead of failing to start the agent | 14:20 |
| *** lbragstad_ is now known as lbragstad | 14:20 | |
| gmann | gibi: i will be requesting the FFE for policy things as few are still need to be merged and I am thinking to do for deprecated APIs also | 14:21 |
| sean-k-mooney | bauzas: so this comment https://review.opendev.org/#/c/715490/10/nova/virt/libvirt/driver.py@814 | 14:21 |
| stephenfin | same comment for me | 14:21 |
| *** Jeffrey4l has quit IRC | 14:22 | |
| gmann | gibi: I will request on ML. my question is for cycle highlights - https://review.opendev.org/#/c/712498/2/deliverables/ussuri/nova.yaml@25 | 14:22 |
| bauzas | sean-k-mooney: okay, fixed by the rev I'm testing | 14:23 |
| bauzas | need to adapt a few more tests than planned, but fair enough | 14:23 |
| gmann | should we include policy things in highlights because amending later might not be acceptable (or at least might get missed by various other forum ) | 14:23 |
| bauzas | won't be a FUP | 14:23 |
| *** Jeffrey4l has joined #openstack-nova | 14:23 | |
| gibi | gmann: hm, let's try to grant FFE for policy bp on the today's meeting and if nobody is against that then I can add info about it to the cyclehighlight | 14:24 |
| gibi | gmann: but I would need some doc I can link to | 14:24 |
| *** ociuhandu has quit IRC | 14:25 | |
| *** ociuhandu has joined #openstack-nova | 14:25 | |
| gmann | gibi: ok. then let me work on doc part and release notes first. thanks. | 14:26 |
| *** mgoddard has joined #openstack-nova | 14:26 | |
| gibi | gmann: thanks | 14:26 |
| *** nightmare_unreal has joined #openstack-nova | 14:26 | |
| gmann | gibi: you want me to send FFE on ML and then discuss in meeting or directly in meeting ? | 14:26 |
| gibi | gmann: let's have a mail about the FFE but it is OK to send the mail after the meeting | 14:27 |
| gmann | i see. let's wait for meeting. | 14:27 |
| gibi | my point is to let's discuss that today | 14:27 |
| gmann | sure | 14:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 14:28 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 14:28 |
| bauzas | gibi: stephenfin: sean-k-mooney: last revision, based on your feedback, hardstopping if two types are provided but only one is having PCI devices | 14:30 |
| *** ociuhandu has quit IRC | 14:30 | |
| *** dave-mccowan has quit IRC | 14:30 | |
| gibi | bauzas: ack, will look shortly | 14:31 |
| bauzas | how can I help now ? | 14:31 |
| bauzas | gibi: my time is free, so maybe time for you to handover some reviews if you want | 14:31 |
| * bauzas looks at the company calendar to see whether all countries but France aren't working tomorrow (jk) | 14:32 | |
| gibi | bauzas: are you familiar with gmann's policy changes? he just pinged me about an FFE request, so we could speed that series up with some review | 14:32 |
| sean-k-mooney | bauzas: we get a company day in ireland for good friday and then monday is a public holiday | 14:33 |
| sean-k-mooney | bauzas: so stephenfin and i wont be around until tuesday | 14:33 |
| bauzas | gibi: I was knowing a bit, but I can look | 14:33 |
| gibi | bauzas: cool, that would help | 14:33 |
| bauzas | sean-k-mooney: yup, I know, also UK, Germany, Hungary and other EU countries AFAICU | 14:34 |
| gibi | yepp, me too ^^ | 14:34 |
| bauzas | some US states aren't working too | 14:34 |
| bauzas | I don't know for Canada, artom ? | 14:34 |
| gibi | but having the covid situation I might check in a bit each day | 14:34 |
| sean-k-mooney | i may have forgot easter was a thing until remineded by stephenfin that i dont need to work on friday or monday... | 14:34 |
| artom | bauzas, tomorrow? Yeah, we're off | 14:34 |
| bauzas | k | 14:35 |
| artom | Monday too | 14:35 |
| bauzas | so, afaict, I can see our Chinese contributors be around and maybe France | 14:35 |
| bauzas | can't speak for Italy and Spain | 14:35 |
| sean-k-mooney | i basically know this as FF week instead of easter | 14:35 |
| bauzas | sean-k-mooney: my wife and I just realized on Monday it was Easter this week | 14:39 |
| bauzas | you're not alone | 14:39 |
| gmann | lbragstad: this can go in or should i add the diff in some doc ? - https://review.opendev.org/#/c/717879/3 | 14:41 |
| bauzas | gibi: mind giving me the gmann's policy patches ? | 14:41 |
| gmann | bauzas: these - https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh+(status:open+OR+status:merged) | 14:42 |
| gibi | bauzas: it is multiple thread of patches but each is on this topic https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/policy-defaults-refresh | 14:42 |
| * gibi is slow | 14:42 | |
| stephenfin | gmann: How many of those are left to do? | 14:42 |
| gmann | bauzas: i need to update few policies also and deprecated API policy | 14:42 |
| stephenfin | if you know off the top of your head? | 14:42 |
| gmann | stephenfin: other than which are already up + 3 APIs new + deprecated APIs. i think doing deprecated APIs also good to update also to make it consistent as they still stay. | 14:44 |
| bauzas | gibi: gmann: FWIW, I remember our discussions at the Shanghai PTG, any important points you wanna me to explain before I go reviewing ? | 14:44 |
| bauzas | or is it something not new from Shanghai, just implementation thingies ? | 14:45 |
| nightmare_unreal | if someone has time, can you look at this : https://review.opendev.org/#/c/715395/ . | 14:45 |
| nightmare_unreal | Thanks. | 14:45 |
| gmann | bauzas: key things is the existing test coverage at the first patch and then see how those gets changed for scope and new defaults | 14:45 |
| *** ttsiouts has joined #openstack-nova | 14:45 | |
| gmann | bauzas: nothing new from shanghai. it is just implementation of that in all policies | 14:46 |
| bauzas | nightmare_unreal: we're cutting M-3 tonight with Feature Freeze, I'll spend a reasonable couple of hours for reviewing bugs in the next week | 14:46 |
| bauzas | gmann: perfect, then I know the outcomes | 14:46 |
| nightmare_unreal | aah o.O thanks for your work :) | 14:47 |
| bauzas | gmann: will you be around tomorrow or off ? | 14:47 |
| bauzas | gmann: (can't remember where you live, I apologize) | 14:47 |
| gmann | bauzas: thanks. I am working tomorrow and Monday too. might be on weekend too | 14:47 |
| *** ociuhandu has joined #openstack-nova | 14:47 | |
| gmann | bauzas: canada | 14:47 |
| *** dklyle has joined #openstack-nova | 14:47 | |
| bauzas | gmann: ok, gtk, just saying because we just discovered we'll miss a couple of countries for work tomorrow, including Canada | 14:48 |
| gmann | yeah. | 14:48 |
| bauzas | (at least for Red Hat) | 14:48 |
| artom | bauzas, in practice, feature freeze is today :P | 14:50 |
| sean-k-mooney | nightmare_unreal: that --overwrite kind of acts like a --force would | 14:50 |
| *** ttsiouts has quit IRC | 14:50 | |
| *** ociuhandu has quit IRC | 14:50 | |
| bauzas | gmann: patches seem not to be piled in a branch, but rather only by topic name | 14:50 |
| bauzas | artom: I fuckingly know about it | 14:51 |
| *** ociuhandu has joined #openstack-nova | 14:51 | |
| gmann | bauzas: correct. 2 are olso one which I are almost ready to go. | 14:52 |
| bauzas | gmann: that makes reviewing a bit hard, I don't know where to start and a couple of patches got -1 from Zuul | 14:52 |
| bauzas | gmann: so I need guidance for reviews | 14:52 |
| bauzas | gmann: I'd say https://review.opendev.org/#/c/718348/ is crucial before we move on | 14:52 |
| stephenfin | bauzas: anything +2'd by me is passing CI | 14:52 |
| gmann | bauzas: ok so there is always set of series for each API. let me find the review guidelines i sent on ML | 14:52 |
| stephenfin | and good (IMO, of course) | 14:52 |
| bauzas | stephenfin: you're Zuul \o/ | 14:52 |
| bauzas | we finally discovered it | 14:53 |
| stephenfin | I wish I was that good at multitasking | 14:53 |
| bauzas | stephenfin: raise 2 kids, get locked down and you'll be surprised about multitasking | 14:53 |
| sean-k-mooney | stephenfin: e.g. it is force updating an allocation even if we dont think it needs healing | 14:53 |
| sean-k-mooney | oh that was for nightmare_unreal ^ | 14:53 |
| gmann | bauzas: http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008504.html | 14:54 |
| bauzas | gmann: perfect, thanks | 14:54 |
| bauzas | gmann: you'd understand that I'd hold reviews on the servers API until https://review.opendev.org/#/c/718348/ get merged ? | 14:55 |
| bauzas | in particular given the criticity of the servers API about policy enforcement | 14:56 |
| gmann | bauzas: yeah that make sense. if test coverage is failing somewhere then it is good to wait to have clear pic of what going to be changed in scope and new defaults patches | 14:56 |
| gmann | bauzas: true. that is one of complex one too given the lot of inline policies per attributes . | 14:57 |
| stephenfin | bauzas: I think you missed sean-k-mooney and I's point https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 | 14:57 |
| bauzas | stephenfin: did I ? shit. | 14:58 |
| stephenfin | To be clear, I agree with the change you've made in that PS, but it's not the one we were concerned about so I think there's another one to do | 14:58 |
| bauzas | holy shit. | 14:58 |
| sean-k-mooney | bauzas: basically the current code logs a warning if an instance was using an mdev type that cant be recreated | 14:59 |
| bauzas | stephenfin: I absolutely missed your concern, I apologize. | 14:59 |
| openstackgerrit | Ivaylo Mitev proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | 14:59 |
| sean-k-mooney | i was saying that should cause the agent not to start | 14:59 |
| sean-k-mooney | which i think is what stephenfin ment by make it an error too right | 14:59 |
| bauzas | sean-k-mooney: stephenfin: lemme think about it | 14:59 |
| bauzas | I'm honestly not sure we'd have to hardstop but I could be wrong | 15:00 |
| bauzas | stephenfin: worth accepting a FUP for the doc nit ? | 15:01 |
| stephenfin | bauzas: What would happen in that situation? You wouldn't be able to restart the instance using the mdev because it wasn't recreated? | 15:01 |
| *** yedongcan has left #openstack-nova | 15:01 | |
| stephenfin | bauzas: Yeah, I'm not sure if we can hard fail for that case (missing '[vgpu_{name}]' sections) after all | 15:02 |
| stephenfin | We already allowed people to list multiple values in 'enabled_vgpu_types', yeah? | 15:02 |
| stephenfin | Even though they did nothing | 15:02 |
| stephenfin | So it's possible there are nova.conf files in the wild with e.g. '[devices] enabled_vgpu_types = nvidia-35, nvidia-36' | 15:03 |
| sean-k-mooney | bauzas: we could not start instance vm at that point right | 15:03 |
| stephenfin | and if they upgrade to Ussuri, they suddenly won't be able to start nova | 15:03 |
| stephenfin | *nova-compute | 15:03 |
| bauzas | stephenfin: I considered this point (having set multiple types while we weren't supporting it) | 15:03 |
| bauzas | stephenfin: I think the hardstop is a reasonable failure | 15:04 |
| bauzas | stephenfin: for operators having set multiple types, they would see that it wasn't really supported before and now they have some action to do | 15:04 |
| bauzas | stephenfin: instead of blindly thinking it was working | 15:05 |
| *** gyee has joined #openstack-nova | 15:05 | |
| stephenfin | right, but it was allowed and didn't break anything | 15:05 |
| bauzas | stephenfin: we only refuse to start | 15:05 |
| bauzas | stephenfin: people can just adapt their confs if so | 15:05 |
| bauzas | again, we made it on purpose | 15:05 |
| *** ttsiouts has joined #openstack-nova | 15:05 | |
| bauzas | I see this as "we won't impact you if you made things the right way" | 15:06 |
| bauzas | 'but if you made things the wrong way, it's time to change your config to make it work correctly" | 15:06 |
| stephenfin | idk, I thought it was a given that nova.conf from N should continue to work in N+1 | 15:06 |
| stephenfin | with warnings, sure | 15:06 |
| *** slaweq has quit IRC | 15:06 | |
| bauzas | stephenfin: it will | 15:06 |
| bauzas | stephenfin: but I can honestly revert to PS10 | 15:07 |
| bauzas | stephenfin: tbc, there is zero upgrade impact for single-typed configurations | 15:07 |
| bauzas | it's debatable tho and I don't want to hold | 15:08 |
| sean-k-mooney | bauzas: any chace you could add a nova-staus command for this? | 15:08 |
| bauzas | sean-k-mooney: certainly not for Train :) | 15:08 |
| bauzas | which is the case we're discussing about | 15:08 |
| sean-k-mooney | ah ok hehe | 15:08 |
| sean-k-mooney | im also not sure how useful it would be given you would have eto run it on the compute node | 15:09 |
| stephenfin | Yeah, I think what you had before was better. "Your nova.conf is wrong and needs to be fixed. We're reverting to the old Train behaviour until you do that" | 15:09 |
| *** vishalmanchanda has quit IRC | 15:09 | |
| bauzas | stephenfin: okay here is a trade-off, I can write an upgrade note saying that multiple-typed confs have to adapt their confs | 15:09 |
| bauzas | stephenfin: okay, let's revert to PS10 then | 15:10 |
| sean-k-mooney | that still does not adress https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 | 15:10 |
| bauzas | sean-k-mooney: yup, it will be PS10 with recreate hard stopping | 15:10 |
| bauzas | we all okay ? | 15:10 |
| sean-k-mooney | in that case you have a direct conflict between an instance type used by a guest on the current host and and the config | 15:10 |
| stephenfin | Yeah, change where we do the hard stop and I'm happy | 15:10 |
| sean-k-mooney | bauzas: yep | 15:10 |
| sean-k-mooney | that works for me | 15:10 |
| bauzas | cool, on it | 15:11 |
| stephenfin | that's a straight up misconfiguration and should be a hard stop | 15:11 |
| stephenfin | Might even be worth backporting a variant of that to stable/train | 15:11 |
| sean-k-mooney | the warning | 15:11 |
| sean-k-mooney | maybe | 15:11 |
| *** dklyle has quit IRC | 15:12 | |
| *** ociuhandu has quit IRC | 15:13 | |
| *** ociuhandu has joined #openstack-nova | 15:15 | |
| *** dklyle has joined #openstack-nova | 15:18 | |
| *** ociuhandu has quit IRC | 15:20 | |
| bauzas | stephenfin: you're talking of the recreate issue you raised ? | 15:21 |
| bauzas | stephenfin: apologies btw. I fucked up with your point, I thought you were arguing about what I fixed in PS11 | 15:21 |
| *** slaweq has joined #openstack-nova | 15:22 | |
| bauzas | looks like multitasking with kids raises bugs | 15:22 |
| bauzas | -ETOOMANYTHINGS | 15:22 |
| stephenfin | bauzas: Um, I am :) I'm saying I think you need to hard fail at https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 and *not* hard fail at https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@6531 | 15:23 |
| bauzas | yup, I finally understood | 15:24 |
| *** avolkov has quit IRC | 15:25 | |
| bauzas | stephenfin: worth saying, do you think we should return a InvalidLibvirtGPUConfig within https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 ? | 15:27 |
| bauzas | or another exception ? | 15:28 |
| stephenfin | It's invalid config, so that makes sense IMO | 15:28 |
| bauzas | I honestly think the operator messed up their config if so | 15:28 |
| bauzas | yup, ok | 15:28 |
| bauzas | stephenfin: to answer your last comment on https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 , | 15:30 |
| bauzas | if the operator messes up their config and self._get_vgpu_type_per_pgpu(parent) can't find the right vgpu type because $mess | 15:31 |
| bauzas | then we get a None value and the conditional statement fails | 15:31 |
| bauzas | stephenfin: but unless the operator did provided a section for each of the vGPU types and added devices, you're right, we fall back to only supporting one type, like we did previously | 15:32 |
| stephenfin | cool. gtk I was reading that correctly | 15:34 |
| *** ociuhandu has joined #openstack-nova | 15:37 | |
| *** ttsiouts has quit IRC | 15:45 | |
| *** damien_r has joined #openstack-nova | 15:45 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 15:47 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 15:47 |
| bauzas | stephenfin: sean-k-mooney: gibi ^ | 15:47 |
| sean-k-mooney | i like how gerrit leaves the filtes ticked if they have not changed form the last revision | 15:49 |
| sean-k-mooney | looking now | 15:49 |
| *** maciejjozefczyk has quit IRC | 15:49 | |
| *** tkajinam has quit IRC | 15:49 | |
| gibi | bauzas: ack | 15:50 |
| gibi | will look shortly | 15:50 |
| gibi | nova meeting starts in 9 minutes on #openstack-meeting-3 | 15:51 |
| bauzas | gibi: sean-k-mooney: shit, forgot to remove two things, will provide a FUP if you don't disagree | 15:52 |
| stephenfin | bauzas: https://review.opendev.org/#/c/715490/12/nova/virt/libvirt/driver.py@817 | 15:52 |
| stephenfin | ah, guess that's one of them | 15:52 |
| stephenfin | just respin it now? not like it's even in the queue yet | 15:52 |
| sean-k-mooney | the continue | 15:52 |
| bauzas | stephenfin: yup | 15:52 |
| bauzas | stephenfin: okay, just doing | 15:53 |
| sean-k-mooney | i have a commnet i was going to make | 15:53 |
| sean-k-mooney | its just dead code so it wont break anythying but ya | 15:53 |
| bauzas | uploading a new rev as of I speak | 15:54 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 15:55 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 15:55 |
| bauzas | (live my life, DSL with 1Mbps up) | 15:55 |
| bauzas | stephenfin: sean-k-mooney: gibi: sorry, last rev ^ | 15:55 |
| sean-k-mooney | big claime :P | 15:55 |
| gibi | last? are you sure? ;) (just kidding) | 15:55 |
| bauzas | latest* | 15:55 |
| sean-k-mooney | bauzas: so out of scope for this cycle but is there any reason in victora we could not auto report custom triats for the vgpu providres | 15:56 |
| bauzas | sean-k-mooney: it's within the spec, said as "planned" | 15:57 |
| sean-k-mooney | bauzas: so we can skip https://review.opendev.org/#/c/715490/13/doc/source/admin/virtual-gpu.rst@290 | 15:57 |
| sean-k-mooney | ok cool | 15:57 |
| sean-k-mooney | doing it manually for now is fine by the way i was just wondering | 15:57 |
| gibi | bauzas: Is there proper 4G coverage where you live? that would be a lot more than 1Mbps | 15:58 |
| sean-k-mooney | gibi: bauzas was ment to be getting fiber a few months ago but there were issues | 15:58 |
| *** rpittau is now known as rpittau|afk | 15:59 | |
| bauzas | sean-k-mooney: I did not implemented it on purpose since mdev types are passed directly from the kernel driver without any kind of abstractional outcome | 15:59 |
| sean-k-mooney | bauzas: sure i dont really thing that is a proablem | 15:59 |
| bauzas | from my position, it is | 15:59 |
| sean-k-mooney | we dont really have an abstration for cpu flags | 16:00 |
| sean-k-mooney | we do some normallisation but very little | 16:00 |
| sean-k-mooney | its basically the same thing | 16:00 |
| bauzas | if nvidia decides that nvidia-31 is no longer a thing and just uses a new typename, say nvidia-mygoo for the same headset etc. then nova would be impacted | 16:00 |
| openstackgerrit | Merged openstack/nova master: Temporarily skip TestNovaMigrationsMySQL https://review.opendev.org/718629 | 16:00 |
| sean-k-mooney | bauzas: sure, same is mostly true for cpu flags. we could provide a mapping layer if we wanted via config but anyway some other days problem | 16:01 |
| bauzas | sean-k-mooney: yup, CPU flags are the exact same things | 16:02 |
| bauzas | using traits for them is terrible | 16:02 |
| sean-k-mooney | bauzas: traits exits basicaly because of them | 16:02 |
| bauzas | we somehow need a versioned mapping table | 16:02 |
| sean-k-mooney | we do that in some places but not others | 16:02 |
| bauzas | for managing libvirt versions (and even kernel versions) against trait names | 16:02 |
| sean-k-mooney | bauzas: not really its considerdf part of the public api of the cpu | 16:03 |
| *** iurygregory has quit IRC | 16:03 | |
| sean-k-mooney | if they change it will break gcc and many many other things | 16:03 |
| sean-k-mooney | bauzas: anyway for what its worth here is the cpu fetaru flag mapping table | 16:06 |
| sean-k-mooney | https://github.com/openstack/nova/blob/c5f3d3b73256ff0d31e1c1a972909228287c3f64/nova/virt/libvirt/utils.py#L51 | 16:06 |
| *** dpawlik has quit IRC | 16:06 | |
| bauzas | sean-k-mooney: tbc, I think cpu flags are considered with more cautiousness than mdev types, y'know | 16:07 |
| *** martinkennelly has quit IRC | 16:07 | |
| sean-k-mooney | bauzas: maybe but if they ever change the mdev type we are already screwed | 16:07 |
| sean-k-mooney | the existing vms wil not be able to boot | 16:08 |
| bauzas | yeah maybe I'm overthinking it | 16:08 |
| bauzas | but at least having some way to prevent a possible API trait explosion in nova would be nice (and that was drafted in the spec likewise) | 16:09 |
| sean-k-mooney | bauzas: but didnt you hear plamcent and traits will solve all problems :) | 16:10 |
| bauzas | this alleviates some problems but raises other concerns, I'd politically say :-) | 16:10 |
| *** ociuhandu has quit IRC | 16:10 | |
| sean-k-mooney | dansmith: thanks for the review on the cyborg stuff | 16:16 |
| sean-k-mooney | i responded to your comments | 16:16 |
| sean-k-mooney | also is nova meeting now | 16:17 |
| dansmith | ack | 16:17 |
| sean-k-mooney | yes ill go join that | 16:17 |
| bauzas | sean-k-mooney: you mean the warning that was filling the logs ? | 16:20 |
| bauzas | (re: policy and olso) | 16:20 |
| bauzas | oslo* | 16:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Change UEFI check to handle AArch64 better https://review.opendev.org/714311 | 16:21 |
| sean-k-mooney | bauzas: yes | 16:22 |
| sean-k-mooney | bauzas: i think we have stop it by disabling it entirly a temp messure but gmann is altering oslo to do it properly | 16:23 |
| bauzas | k, thanks for the heads up | 16:23 |
| sean-k-mooney | so if you manually set it you will get the deprecation warning but not for the defualts | 16:23 |
| gmann | bauzas: sean-k-mooney this is nova change to adopt the new flag, waiting for new version of oslo.policy - https://review.opendev.org/#/c/717884/ | 16:24 |
| gmann | its working fine so once we have olso release then i will update the lower constraint and remvoe WIP | 16:25 |
| *** lpetrut has quit IRC | 16:26 | |
| sean-k-mooney | cool. the cyborg patch seres is like 100 commits behind master so i still get the wall fo error if i touch nova manage | 16:26 |
| sean-k-mooney | so it will be nice when that is all resovled | 16:26 |
| *** ociuhandu has joined #openstack-nova | 16:28 | |
| gmann | lbragstad: on gate, somehow new flag is not reflecting due to oslo checkout etc but tested localyl and it worked fine - https://review.opendev.org/#/c/717943/2 | 16:31 |
| *** udesale_ has quit IRC | 16:35 | |
| *** evrardjp has quit IRC | 16:37 | |
| *** evrardjp has joined #openstack-nova | 16:37 | |
| *** ociuhandu has quit IRC | 16:38 | |
| *** dtantsur is now known as dtantsur|afk | 16:46 | |
| *** nightmare_unreal has quit IRC | 16:50 | |
| *** brinzhang has joined #openstack-nova | 16:57 | |
| *** brinzhang_ has quit IRC | 17:00 | |
| bauzas | gibi: can you put some vote on https://review.opendev.org/#/c/715490/13 before you leave ? | 17:00 |
| gibi | will do | 17:00 |
| bauzas | you already +1d with comment saying you'd want to review the functest | 17:01 |
| bauzas | thanks | 17:01 |
| bauzas | (and I know this is late) | 17:01 |
| bauzas | gibi: working at home btw. during the lockdown or back to the office ? | 17:01 |
| gibi | I will do the cycle highlught patch anyhow | 17:01 |
| *** derekh has quit IRC | 17:01 | |
| *** mgoddard has quit IRC | 17:03 | |
| gibi | bauzas: I'm home in the last 3 weeks | 17:03 |
| gibi | or 4? I dont even remember | 17:04 |
| bauzas | gibi: I'm facing my 24th day in paradise | 17:04 |
| bauzas | 25th actually | 17:04 |
| gibi | paradise, lol | 17:05 |
| bauzas | I honestly and frankly enjoy this period | 17:05 |
| bauzas | I don't have to taxi the kids 4 times a day | 17:05 |
| bauzas | I can arrange my worktime like I want | 17:06 |
| bauzas | and my wife is stuck with me and discovering remote work | 17:06 |
| bauzas | what dare could I complain ? | 17:06 |
| gmann | gibi: cycle highlights lines for policy, let me know if it need to be shorten, also feel free to rephrase if needed - http://paste.openstack.org/show/791896/ | 17:08 |
| gibi | gmann: thanks a lot! looks good | 17:09 |
| gmann | ok, thanks. | 17:09 |
| gibi | bauzas: I have a fairly small flat in the middle of the capital. Now this place feels too small | 17:09 |
| gibi | bauzas: I'm +2+A on the whole vgpu series | 17:11 |
| *** jraju__ has quit IRC | 17:15 | |
| gibi | cores: latest cycle highlights patch is up https://review.opendev.org/#/c/712498 | 17:17 |
| gibi | bauzas: btw, do you want to add a highlight about the vgpu work? | 17:17 |
| bauzas | gibi: thanks | 17:17 |
| bauzas | gibi: and nope for the highlights, it's a minor thing | 17:17 |
| gibi | bauzas: ack. I just wanted to double check | 17:18 |
| *** ociuhandu has joined #openstack-nova | 17:19 | |
| gibi | I think this is it for me today. I will check the gate tomorrow but will not work much | 17:19 |
| *** priteau has quit IRC | 17:22 | |
| gmann | gibi: sent the FFE request on ML- http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014027.html | 17:23 |
| *** ociuhandu has quit IRC | 17:25 | |
| bauzas | gibi: \o and I'll handover your work | 17:33 |
| *** mlavalle has joined #openstack-nova | 17:52 | |
| *** ociuhandu has joined #openstack-nova | 18:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 18:07 |
| gmann | lbragstad: melwitt now this ^^ can test the new flag for defaults switch. flag needs to be set before load_rules() which happens during setup of test.py | 18:08 |
| melwitt | thanks | 18:08 |
| gmann | previously i was setting it after load_rules called and old defaults already as OrCheck. | 18:08 |
| melwitt | ah ok | 18:12 |
| openstackgerrit | Merged openstack/nova master: api: Add support for new cyborg extra specs https://review.opendev.org/716222 | 18:13 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in server diagnostics policy https://review.opendev.org/716810 | 18:13 |
| stephenfin | gmann: You're going to address the issues with the policy patches that are failing at the gate, I assume? | 18:17 |
| stephenfin | I started to fix some of them today but got distracted and probably won't have a chance to close it off now | 18:17 |
| gmann | stephenfin: yeah. working on those | 18:18 |
| gmann | stephenfin: np!. | 18:19 |
| gmann | let me check all review if any query for you. | 18:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add test coverage of existing shelve policies https://review.opendev.org/717539 | 18:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce scope_types in shelve server https://review.opendev.org/717571 | 18:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add new default roles in shelve server policies https://review.opendev.org/717581 | 18:20 |
| *** ociuhandu has quit IRC | 18:20 | |
| *** ralonsoh has quit IRC | 18:20 | |
| *** ociuhandu has joined #openstack-nova | 18:22 | |
| gmann | stephenfin: replied on this. is ok for you ? -https://review.opendev.org/#/c/718619/2/nova/policies/keypairs.py@26 | 18:22 |
| *** ociuhandu has quit IRC | 18:27 | |
| *** markmcclain has quit IRC | 18:27 | |
| *** markmcclain has joined #openstack-nova | 18:29 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 18:30 |
| *** mriedem has joined #openstack-nova | 18:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | 18:35 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | 18:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | 18:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | 18:36 |
| *** mgoddard has joined #openstack-nova | 18:46 | |
| *** martinkennelly has joined #openstack-nova | 18:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 19:06 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 19:07 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in servers Policies https://review.opendev.org/662968 | 19:07 |
| *** spsurya_ has quit IRC | 19:08 | |
| *** ociuhandu has joined #openstack-nova | 19:20 | |
| *** markmcclain has quit IRC | 19:22 | |
| *** markmcclain has joined #openstack-nova | 19:24 | |
| *** ociuhandu has quit IRC | 19:50 | |
| *** priteau has joined #openstack-nova | 19:55 | |
| *** tesseract has quit IRC | 20:00 | |
| openstackgerrit | Merged openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489 | 20:01 |
| openstackgerrit | Merged openstack/nova master: libvirt: Calculate disk_over_committed for raw instances https://review.opendev.org/717037 | 20:01 |
| *** priteau has quit IRC | 20:05 | |
| *** tesseract has joined #openstack-nova | 20:06 | |
| *** larsks has joined #openstack-nova | 20:09 | |
| larsks | Howdy. Has any encountered a situation where 'server list' shows a server, but any attempt to interact with that (server show <uuid>, etc) results in "No server with a name or ID of <uuid> exists"? In the database, the server has vm_state "error" and task_state "NULL". | 20:11 |
| larsks | This is queens. | 20:11 |
| melwitt | yes, let me look for a link | 20:13 |
| melwitt | I think that's likely https://bugs.launchpad.net/nova/+bug/1784093 which was fixed in queens 17.0.11 upstream | 20:15 |
| openstack | Launchpad bug 1784093 in OpenStack Compute (nova) stein "Build requests can be orphaned without instance mappings" [Medium,Fix committed] - Assigned to melanie witt (melwitt) | 20:15 |
| *** mgariepy has quit IRC | 20:16 | |
| *** tesseract has quit IRC | 20:17 | |
| larsks | melwitt: thanks, perfect! | 20:21 |
| dansmith | that looks more like a missing instance mapping to me, | 20:29 |
| dansmith | although potentially missing BR too I guess | 20:29 |
| dansmith | or maybe that bug is about BRs, but the fix is instance mappings? | 20:29 |
| melwitt | yeah, it is. it's a bit different. I think the fix is the same (atomic update of BR, IM, RS) | 20:36 |
| dansmith | ack | 20:36 |
| melwitt | but yes this is a missing IM | 20:36 |
| *** markmcclain has quit IRC | 20:42 | |
| *** markmcclain has joined #openstack-nova | 20:42 | |
| *** owalsh is now known as owalsh_afk | 20:43 | |
| *** ociuhandu has joined #openstack-nova | 21:01 | |
| *** ociuhandu has quit IRC | 21:06 | |
| *** mgariepy has joined #openstack-nova | 21:09 | |
| *** dlbewley has joined #openstack-nova | 21:11 | |
| *** martinkennelly has quit IRC | 21:16 | |
| melwitt | dansmith: ideas welcome on what to do to recover/cleanup when an instance mapping update fails due to DBError https://bugs.launchpad.net/nova/+bug/1871925 | 21:19 |
| openstack | Launchpad bug 1871925 in OpenStack Compute (nova) "Server appears in "openstack server list" but "openstack server (show|delete|etc)" insists it doesn't exist" [Medium,Confirmed] | 21:19 |
| melwitt | the "easy" solution is retry a few times and hope that does it | 21:20 |
| bauzas | gibi: good call on rechecking changes for 2.86 and 2.87, will follow up on this | 21:24 |
| melwitt | I think I'm gonna propose a retry first | 21:33 |
| *** slaweq has quit IRC | 22:14 | |
| *** nweinber has quit IRC | 22:15 | |
| *** slaweq has joined #openstack-nova | 22:15 | |
| *** slaweq has quit IRC | 22:20 | |
| mriedem | there was a bug like that in novaclient once, related to markers and how novaclient did it's marker stuff when listing servers. since osc uses novaclient, depending on when that was fixed and the version of osc being used here it could be related. | 22:24 |
| mriedem | e.g. the marker was for a build request or something, but i can't remember the details. there have been a few weird things like that with markers. | 22:25 |
| *** mriedem has left #openstack-nova | 22:25 | |
| melwitt | noted | 22:30 |
| *** tkajinam has joined #openstack-nova | 22:53 | |
| *** tosky has quit IRC | 23:08 | |
| openstackgerrit | Merged openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 23:29 |
| openstackgerrit | Merged openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 23:29 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing shelve policies https://review.opendev.org/717539 | 23:29 |
| openstackgerrit | Merged openstack/nova master: Reset the cell cache for database access in Service https://review.opendev.org/717662 | 23:30 |
| *** lseki has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!