| brinzhang | dansmith: Could you please update the separate update and seap volume policies patch? https://review.opendev.org/#/c/711194/ , I seem not get the logical what would you want to do, although I read the chat history of gmann and you. | 00:05 |
|---|---|---|
| brinzhang | gibi: I dont know whois Victor Coutellier, I have two patches of microversion 2.84 and v2.85 rebased on v2.83 https://review.opendev.org/#/c/713089/ , it is very close to April 9th, I hope he can update ASAP | 00:07 |
| *** mlavalle has quit IRC | 00:09 | |
| gmann | brinzhang: he was new to nova side, not sure if he is aware of deadline. | 00:12 |
| gmann | brinzhang: is more changes requied on his patch? | 00:13 |
| gmann | i have not looked into review comments yet | 00:13 |
| gmann | if those are not too much, we can help him by fixng those | 00:16 |
| *** alex_xu has joined #openstack-nova | 00:19 | |
| brinzhang | gmann: Got it, if so, I will looked into | 00:26 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884 | 00:26 |
| *** tetsuro has joined #openstack-nova | 00:26 | |
| brinzhang | gmann: thanks | 00:26 |
| gmann | brinzhang: thanks. | 00:27 |
| melwitt | alex_xu: heya, could you pls revisit these 2 patches you have reviewed before, they are about removing the "" to "/" redirect in nova api for version discovery https://review.opendev.org/685180 | 00:28 |
| alex_xu | melwitt: I will try it today | 00:28 |
| melwitt | and allowing unauthenticated for version discover | 00:28 |
| melwitt | thanks alex_xu | 00:28 |
| alex_xu | np | 00:29 |
| *** avolkov has quit IRC | 00:48 | |
| gmann | lbragstad: should I make the changes of operators flag to new system in this or separate ? -https://review.opendev.org/#/c/717879/1 | 00:49 |
| *** brinzhang has quit IRC | 00:50 | |
| gmann | lbragstad: the disable warning flag we need as separate so that we can disable the warning from now itself not based on new-system-flag | 00:50 |
| *** brinzhang has joined #openstack-nova | 00:51 | |
| lbragstad | gmann oh - sorry, i didn't realize you were going to put that functionality behind a separate flag | 00:51 |
| gmann | lbragstad: if under same flag then warning keep logging until operator switch to new system. | 00:52 |
| lbragstad | yeah - ok | 00:53 |
| lbragstad | so - a separate flag to opt out of the logical OR, right? | 00:54 |
| gmann | yeah | 00:54 |
| gmann | which will be config option with default to false | 00:54 |
| lbragstad | got it, ok | 00:55 |
| *** gyee has quit IRC | 00:58 | |
| *** brinzhang_ has joined #openstack-nova | 00:59 | |
| *** brinzhang has quit IRC | 01:03 | |
| *** ociuhandu has joined #openstack-nova | 01:04 | |
| *** happyhemant has quit IRC | 01:08 | |
| *** ociuhandu has quit IRC | 01:09 | |
| *** zhanglong has joined #openstack-nova | 01:12 | |
| *** Liang__ has joined #openstack-nova | 01:17 | |
| *** tbachman has quit IRC | 01:24 | |
| *** tbachman has joined #openstack-nova | 01:30 | |
| *** tbachman has quit IRC | 01:40 | |
| *** tbachman has joined #openstack-nova | 01:41 | |
| brinzhang_ | gmann: https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py with these filter parameters, need to add start_version="2.83" tag to limit the non-admin user to filter, right? | 01:51 |
| brinzhang_ | I saw Victor Coutellier missed that limit | 01:52 |
| gmann | brinzhang_: i do not think we need the start_version because 2.83 is to only enabling these filters for non-admin. they are allowed filter for admin since starting. | 01:56 |
| brinzhang_ | gmann: if so, we cannt limit non-admin request these parameters, I think | 01:58 |
| gmann | brinzhang_: from client side, non-admin will get API error like not allowed if request is with < 2.83 | 02:01 |
| brinzhang_ | gmann: and https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py@1664 if the config_drive reqeust False, it will be changed to None, and in https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 will be skip request config_drive | 02:01 |
| brinzhang_ | gmann: Ok, thanks, I missed that return error message, it ok not limit start_version | 02:02 |
| gmann | yeah, because client side do not enforce the permission things and rely on server side error. | 02:03 |
| brinzhang_ | gmann: what do you think this is an issue? https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py@1664 if the config_drive reqeust False, it will be changed to None, and in https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 will be skip request config_drive | 02:04 |
| brinzhang_ | I think we cannot filter by config_drive=False | 02:05 |
| brinzhang_ | but if I changed the config_drive = False, it will be change a required parameter will filter instances :( | 02:05 |
| openstackgerrit | Merged openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | 02:08 |
| openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Medium,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | 02:08 |
| gmann | brinzhang_: None is not allowed value but False should be | 02:10 |
| gmann | bt i have not checked that changes in detail. i can check tomorrow. | 02:10 |
| brinzhang_ | gmann: yes, https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 seems not correct | 02:11 |
| brinzhang_ | gmann: ok, thanks | 02:11 |
| *** igordc has joined #openstack-nova | 02:33 | |
| *** ociuhandu has joined #openstack-nova | 02:34 | |
| *** ociuhandu has quit IRC | 02:39 | |
| *** hamzy has quit IRC | 02:46 | |
| *** hamzy has joined #openstack-nova | 02:46 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | 02:49 |
| *** igordc has quit IRC | 03:16 | |
| *** psachin has joined #openstack-nova | 03:18 | |
| *** tetsuro has quit IRC | 03:21 | |
| *** mkrai has joined #openstack-nova | 03:23 | |
| *** mkrai has quit IRC | 03:24 | |
| *** spatel has joined #openstack-nova | 03:24 | |
| *** spatel has quit IRC | 03:25 | |
| *** mkrai has joined #openstack-nova | 03:27 | |
| *** tetsuro has joined #openstack-nova | 03:50 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 04:05 |
| openstackgerrit | norman shen proposed openstack/nova master: Update connection info in pre_live_migration https://review.opendev.org/717597 | 04:14 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | 04:26 |
| *** brinzhang has joined #openstack-nova | 04:36 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:37 | |
| *** brinzhang_ has quit IRC | 04:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix server tags policy to be admin_or_owner https://review.opendev.org/717947 | 04:55 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | 04:56 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | 05:00 |
| *** ratailor has joined #openstack-nova | 05:00 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server tags policy https://review.opendev.org/717948 | 05:06 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | 05:07 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server tags policy https://review.opendev.org/717948 | 05:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server tags policies https://review.opendev.org/717954 | 05:28 |
| *** brinzhang_ has joined #openstack-nova | 05:33 | |
| *** brinzhang has quit IRC | 05:36 | |
| *** udesale has joined #openstack-nova | 05:41 | |
| *** ralonsoh has joined #openstack-nova | 06:02 | |
| *** ircuser-1 has quit IRC | 06:07 | |
| *** udesale has quit IRC | 06:09 | |
| *** udesale has joined #openstack-nova | 06:13 | |
| *** dpawlik has joined #openstack-nova | 06:30 | |
| *** nightmare_unreal has joined #openstack-nova | 06:39 | |
| *** ratailor has quit IRC | 06:40 | |
| *** ttsiouts has joined #openstack-nova | 06:45 | |
| *** ratailor has joined #openstack-nova | 06:47 | |
| *** dklyle has quit IRC | 06:54 | |
| *** rpittau|afk is now known as rpittau | 06:56 | |
| *** zhanglong has quit IRC | 06:58 | |
| *** slaweq has joined #openstack-nova | 07:00 | |
| *** tesseract has joined #openstack-nova | 07:16 | |
| bauzas | good morning Nova | 07:17 |
| lyarwood | morning | 07:22 |
| *** tosky has joined #openstack-nova | 07:24 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | 07:33 |
| *** tetsuro_ has joined #openstack-nova | 07:38 | |
| *** tetsuro has quit IRC | 07:42 | |
| *** ociuhandu has joined #openstack-nova | 07:45 | |
| *** damien_r has joined #openstack-nova | 07:53 | |
| *** brinzhang has joined #openstack-nova | 07:56 | |
| gibi | bauzas: started reading the vgpu patches | 07:58 |
| gibi | bauzas: I have an imediate feedback about the compute service startup sequence https://review.opendev.org/#/c/715489/6/nova/virt/libvirt/driver.py@791 | 07:59 |
| *** brinzhang_ has quit IRC | 07:59 | |
| gibi | at the momemnt I'm not sure how this affect the patch but could be a problem ^^ | 08:01 |
| *** mkrai has quit IRC | 08:01 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/708436/17 - Stupid question, so this doesn't need doc/api_samples and nova/tests/functional/api_sample_tests/api_samples/ updates as you're not changing request/responses in this microversion right? | 08:04 |
| lyarwood | stephenfin: asking as I've added them in https://review.opendev.org/#/c/701430/ assuming we needed to do this regardless, if we don't I can rm -rf this from that change. | 08:05 |
| *** brinzhang_ has joined #openstack-nova | 08:05 | |
| *** ralonsoh has quit IRC | 08:05 | |
| bauzas | gibi: looking | 08:05 |
| bauzas | gibi: FWIW, I can upload a DNM patch to see how to create pGPUs | 08:06 |
| brinzhang_ | gibi: and I think there is an issue inline, but I dont have time to search how to fix it, so I add TODO in test case. The issue is filter by config_drive=False, cannt get the servers, because if we request config=False, that will be changed to None, that will be ignored | 08:06 |
| *** links has joined #openstack-nova | 08:07 | |
| gibi | brinzhang_: ack, I have to look at that client patch today. thanks for taking it over | 08:07 |
| gibi | brinzhang_: I will try to see if I can fix that while you are asleep. | 08:07 |
| brinzhang_ | gibi: thanks | 08:08 |
| *** brinzhang has quit IRC | 08:09 | |
| brinzhang_ | gibi: I was added TODO in test_shell, and test_servers file, if you are looking into, you can see it, while you fix that you can remove that TODO and complete the tes cases | 08:09 |
| luyao | gibi: Hi do you have time to help review vpmem live migration? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/support-live-migration-with-virtual-persistent-memory. I think stephenfin is still and will be busy on mixed cpu patches. | 08:11 |
| gibi | brinzhang_: thanks | 08:12 |
| brinzhang_ | gibi:np | 08:12 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: DNM: Functional test with pGPUs https://review.opendev.org/717975 | 08:12 |
| gibi | luyao: I'm knee deep in the vgpu types series, then I will jump to the novaclient patch above. So I don't think I will get to vpmem today. sorry | 08:12 |
| bauzas | gibi: so | 08:13 |
| bauzas | gibi: thanks for your comment | 08:13 |
| bauzas | gibi: fwiw, I'm working on https://review.opendev.org/717975 | 08:13 |
| gibi | bauzas: ack about the func test | 08:13 |
| gibi | will look | 08:13 |
| bauzas | gibi: see https://review.opendev.org/#/c/717975/1/nova/virt/libvirt/driver.py | 08:13 |
| bauzas | maybe I should add it to make sure it works | 08:14 |
| bauzas | (without waiting for the driver.init_host()) | 08:14 |
| luyao | gibi: OK, it does not matter | 08:15 |
| gibi | bauzas: I have to make a step back. now that we are cleare about the initialization order of the compute service. What will potentially break? and then how the driver change in 717975 prevents that? (sorry I don't have the full context yet) | 08:16 |
| bauzas | gibi, so about your concern | 08:17 |
| *** ralonsoh has joined #openstack-nova | 08:17 | |
| *** tkajinam has quit IRC | 08:17 | |
| bauzas | say we call recreate_assigned_mediated_devices() before driver.init_host() | 08:17 |
| bauzas | gibi: then we'll get the existing mdevs from libvirt XML guests | 08:18 |
| bauzas | guest XMLs | 08:18 |
| bauzas | * | 08:18 |
| bauzas | gibi: so the 'parent' argument we pass down to _create_new_mediated_device is got from the libvirt XML, not from placement | 08:18 |
| bauzas | gibi: my only concern without having https://review.opendev.org/#/c/717975/1/nova/virt/libvirt/driver.py means that if _recreate() is called before init_host() then the self.supported_vgpu_types value would be None | 08:20 |
| *** mkrai has joined #openstack-nova | 08:20 | |
| bauzas | gibi: that's why I I'll provide a new revision to add the property | 08:20 |
| gibi | OK. so the parent will not be None just the vgpu_types | 08:20 |
| bauzas | gibi: tbc, we don't call Placement within _recreate() | 08:21 |
| bauzas | gibi: it's just for recreating mdevs in sysfs | 08:21 |
| bauzas | so it's okay to not have a reshape | 08:21 |
| bauzas | gibi: but you actually found a related problem, so thanks ! | 08:21 |
| gibi | bauzas:OK, thanks. I continue reading the patches... | 08:22 |
| bauzas | gibi: I'll provide a new revision by the next 5 mins | 08:22 |
| bauzas | gibi: just by adding the property and then just modifying the tests to no longer call init_host() | 08:23 |
| bauzas | it will simplify the testrs | 08:23 |
| bauzas | (and I'll clarify the comment to explain that we don't call placement so we're all fine) | 08:23 |
| gibi | thanks | 08:24 |
| *** zhanglong has joined #openstack-nova | 08:25 | |
| *** tetsuro_ has quit IRC | 08:32 | |
| jkulik | gibi, you've given your +2 on https://review.opendev.org/#/c/713863/ and after some discussion the -1 is gone, too. Is there anything left to do? Do we wait for other reviewers? | 08:34 |
| gibi | jkulik: I hope melwitt will have time to get back to it as in general we need two +2 votes to merge a patch. | 08:35 |
| *** ccamacho has joined #openstack-nova | 08:36 | |
| jkulik | Ah, didn't know that. Thank you. | 08:36 |
| openstackgerrit | xulei proposed openstack/nova master: Add unit test for nova-api _check_metadata_properties_quota https://review.opendev.org/717981 | 08:36 |
| gibi | jkulik: this week is feature freeze so most of the reviews are busy finishing up feature reviews so it might take time to get the another +2 on your bug. I suggest to ping melwitt early next week | 08:38 |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** mkrai has quit IRC | 08:38 | |
| *** mkrai_ has joined #openstack-nova | 08:38 | |
| jkulik | Sure, thanks. Just wanted to know what's the holdup and if I can do anything. | 08:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 08:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 08:44 |
| *** ociuhandu has quit IRC | 08:50 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489 | 08:51 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 08:51 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: DNM: Functional test with pGPUs https://review.opendev.org/717975 | 08:51 |
| bauzas | gibi: updated based on your remarks ^ | 08:51 |
| gibi | bauzas: ack | 08:52 |
| bauzas | gibi: had to change a few unittests, you helped me to fix a few details | 08:52 |
| gibi | cool | 08:53 |
| bauzas | TIL init_host() is not really called when initing the host :p | 08:53 |
| gibi | I alway have to look up the code to see what is the init order | 08:56 |
| *** ociuhandu has joined #openstack-nova | 08:57 | |
| *** dtantsur|afk is now known as dtantsur | 09:01 | |
| *** priteau has joined #openstack-nova | 09:01 | |
| *** zhanglong has quit IRC | 09:03 | |
| *** zhanglong has joined #openstack-nova | 09:06 | |
| *** martinkennelly has joined #openstack-nova | 09:08 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Drop concept of '?validation' parameter https://review.opendev.org/717789 | 09:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion for extra spec validation https://review.opendev.org/708436 | 09:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 09:13 |
| *** xek has joined #openstack-nova | 09:20 | |
| *** xek has quit IRC | 09:25 | |
| *** xek has joined #openstack-nova | 09:25 | |
| *** xek has quit IRC | 09:27 | |
| *** xek has joined #openstack-nova | 09:27 | |
| *** xek_ has joined #openstack-nova | 09:30 | |
| *** xek_ has quit IRC | 09:31 | |
| *** xek has quit IRC | 09:32 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | 09:34 |
| *** zhanglong has quit IRC | 09:35 | |
| *** brinzhang has joined #openstack-nova | 09:36 | |
| nightmare_unreal | hello can someone review this : https://review.opendev.org/#/c/715395/ . Not sure why Zuul verification is failing | 09:38 |
| nightmare_unreal | thanks | 09:38 |
| *** zhanglong has joined #openstack-nova | 09:38 | |
| *** brinzhang_ has quit IRC | 09:39 | |
| gibi | nightmare_unreal: the zuul failure seems to be unrelated. | 09:42 |
| nightmare_unreal | Yeah, I was not sure why it is failing. It had merge conflict. I resolved it and since then it's -1 from zuul | 09:43 |
| nightmare_unreal | I did checked before submitting, ( pre-commit, pep8 and others) | 09:44 |
| *** kaisers_ has joined #openstack-nova | 09:47 | |
| nightmare_unreal | thanks for the review | 09:58 |
| huaqiang | stephenfin: can you have a look for this ? url:https://review.opendev.org/#/c/714658/4/nova/objects/instance_numa.py@87 | 09:59 |
| huaqiang | and do you agree with my reply for your comments? | 09:59 |
| stephenfin | huaqiang: I need to dig into it, to be honest. I think you should just include a summary of what you said as a note for now. We can bring it up again if needed | 10:01 |
| huaqiang | sure, I'll provide a note. | 10:02 |
| lyarwood | stephenfin: not sure if you saw my ping re https://review.opendev.org/#/c/708436/ earlier? | 10:02 |
| stephenfin | I did not | 10:02 |
| lyarwood | stephenfin: https://review.opendev.org/#/c/708436/17 - Stupid question, so this doesn't need doc/api_samples and nova/tests/functional/api_sample_tests/api_samples/ updates as you're not changing request/responses in this microversion right? | 10:03 |
| lyarwood | stephenfin: asking as I've added them in https://review.opendev.org/#/c/701430/ assuming we needed to do this regardless, if we don't I can rm -rf this from that change. | 10:03 |
| lyarwood | stephenfin: just about to rebase on your change and take the next microversion btw | 10:03 |
| stephenfin | lyarwood: I'd assumed not, but tbh I'm not certain. Maybe gibi would know? | 10:03 |
| stephenfin | I'm not sure why you'd need them if you're not changing the request or response | 10:03 |
| lyarwood | stephenfin: yeah right, I can't recall why I added these originally tbh, I assume something was failing but that clearly isn't the case in your change | 10:05 |
| gibi | stephenfin, lyarwood: did query param removed too? | 10:05 |
| stephenfin | gibi: In my change? Yeah | 10:05 |
| gibi | I guess I mixing changes | 10:06 |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command Closes-Bug:#1868997 https://review.opendev.org/715395 | 10:06 |
| lyarwood | yeah that isn't part of the microversion change | 10:06 |
| lyarwood | nothing changes in the request or response for that change | 10:06 |
| lyarwood | I'm just going to rm -rf my samples changes from mine while I rebase | 10:07 |
| gibi | so neither lyarwood nor stephenfin's change introduce any request or response or query string change | 10:07 |
| gibi | so both patch is OK without api sample | 10:07 |
| lyarwood | ack, thanks for clearing that up | 10:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct server shelve policy check_str https://review.opendev.org/717542 | 10:08 |
| *** zhanglong has quit IRC | 10:08 | |
| *** Liang__ has quit IRC | 10:09 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct server topology policy check_str https://review.opendev.org/717525 | 10:14 |
| lyarwood | stephenfin: ah, you didn't fetch and rebase on origin/master, any chance you could so I can rebase on https://review.opendev.org/#/c/708436/ ? | 10:16 |
| lyarwood | stephenfin: otherwise I end up pulling in loads of stuff that has already merged between your HEAD and origin/master when I rebase on your change | 10:17 |
| stephenfin | lyarwood: If I do, the bottom patch will get kicked out of the gate queue :( Do you depend on any of that additional stuff being pulled in from master? If not, can you just delete it? | 10:18 |
| lyarwood | stephenfin: ah sorry didn't see that was in the gate, assumed it hadn't been picked up in the check queue yet | 10:18 |
| lyarwood | stephenfin: yeah I can trim things down for now | 10:18 |
| nightmare_unreal | is there a devstack specific channel ? | 10:18 |
| sean-k-mooney | its #openstack-qa | 10:19 |
| sean-k-mooney | nightmare_unreal: ^ | 10:19 |
| nightmare_unreal | thanks sean-k-mooney | 10:19 |
| *** rpittau is now known as rpittau|bbl | 10:25 | |
| *** vishalmanchanda has joined #openstack-nova | 10:40 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 10:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 10:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 10:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430 | 10:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 10:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.86 - Stable device boot from volume rescue https://review.opendev.org/714956 | 10:51 |
| lyarwood | stephenfin: I was about to move these around | 10:52 |
| stephenfin | oh, sorry. I just rebased them | 10:53 |
| lyarwood | np do you have a change for 2.86? | 10:53 |
| lyarwood | I'll create one now if not | 10:53 |
| stephenfin | Not yet, no | 10:54 |
| lyarwood | kk 2 secs | 10:54 |
| gibi | bauzas: feedback in https://review.opendev.org/#/c/715490 (I have to go back and review the test later) | 10:58 |
| *** ttsiouts has quit IRC | 10:59 | |
| openstackgerrit | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | 10:59 |
| openstackgerrit | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | 10:59 |
| lyarwood | stephenfin: ^ there you go | 10:59 |
| stephenfin | thanks :) | 11:00 |
| * lyarwood looks at the other client changes | 11:00 | |
| bauzas | gibi: thanks, I'll look at them after lunching | 11:02 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723 | 11:03 |
| sean-k-mooney | given the recet conversations on the topic stephenfin lyarwood do you have osc changes for the same? if those are noops just bumping the max version in novaclinet i guess they are not needed but if actully added something osc might want to be extended too | 11:06 |
| *** ttsiouts has joined #openstack-nova | 11:09 | |
| huaqiang | stephenfin: I prepared a summary and a detail analysis in this link:https://etherpad.openstack.org/p/versioned_object-obj_from_primitive-behavior | 11:10 |
| huaqiang | please have a look when you have time. | 11:10 |
| huaqiang | and the content is in RST format, it will have a better look if you check it in a RST reader. | 11:11 |
| sean-k-mooney | stephenfin: by the way any chance we could land this https://review.opendev.org/#/c/700894/ we both kind of forgot about it but noticed it on lee's review dashboard yesterday | 11:14 |
| lyarwood | sean-k-mooney: no I didn't have anything for osc | 11:14 |
| sean-k-mooney | lyarwood: cool just said i would ask. | 11:15 |
| lyarwood | kk np | 11:17 |
| *** xek has joined #openstack-nova | 11:32 | |
| *** ociuhandu has quit IRC | 11:41 | |
| *** ociuhandu has joined #openstack-nova | 11:42 | |
| *** ociuhandu has quit IRC | 11:47 | |
| *** nweinber has joined #openstack-nova | 11:47 | |
| lyarwood | stephenfin: https://review.opendev.org/#/q/status:open+topic:workaround_native_luksv1+project:openstack/nova - would you mind hitting these today if you have any time? | 11:52 |
| *** rpittau|bbl is now known as rpittau | 12:06 | |
| *** tkajinam has joined #openstack-nova | 12:08 | |
| *** yaawang has quit IRC | 12:08 | |
| brinzhang | lyarwood: https://review.opendev.org/#/c/712651/13/novaclient/tests/unit/v2/test_shell.py@4006 I think this test is ok, I replied your comment | 12:09 |
| brinzhang | lyarwood: because we changed the PUT API, I think we should add the older feature test, and ensure it runs ok, do you think so? | 12:12 |
| bauzas | gibi: no worries about looking at the func test, it's just a WIP now | 12:13 |
| brinzhang | lyarwood: https://review.opendev.org/#/c/711194/ this policy change patch, I dont think I got dansmith want to say, so I was not rebased on, | 12:14 |
| bauzas | gibi: I provided it because you could look at why it wasn't working for you | 12:14 |
| brinzhang | lyarwood: I also agree with you, that can change the depends-on to the policy sparate patch, that we can better control the microversion 2.85 | 12:15 |
| gibi | bauzas: ack. I also did not look at the unit test on the main patch. but will at some point | 12:15 |
| *** igordc has joined #openstack-nova | 12:34 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: DNM: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | 12:34 |
| *** ttsiouts has quit IRC | 12:34 | |
| lyarwood | brinzhang: replied in the change, I just wanted to assert that the same call is made if --delete-on-termination isn't provided from 2.85 | 12:40 |
| lyarwood | brinzhang: your other tests didn't check this | 12:41 |
| brinzhang | lyarwood: ok, Got it, I will update it. | 12:42 |
| brinzhang | lyarwood: thanks | 12:42 |
| *** ttsiouts has joined #openstack-nova | 12:43 | |
| lyarwood | brinzhang: thanks :) | 12:44 |
| *** ociuhandu has joined #openstack-nova | 12:45 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 12:49 |
| brinzhang | lyarwood: update done ^^ | 12:49 |
| *** ociuhandu has quit IRC | 12:52 | |
| stephenfin | lyarwood: any chance of getting a TODO for https://review.opendev.org/#/c/708030/8, per comment? | 12:54 |
| lyarwood | brinzhang: ack thanks | 12:55 |
| lyarwood | stephenfin: looking | 12:55 |
| lyarwood | stephenfin: yeah sure | 12:55 |
| stephenfin | A follow-up is fine, btw | 12:56 |
| lyarwood | stephenfin: that would be easier yeah thanks | 12:56 |
| stephenfin | lyarwood: As for the second one, is there any reason someone would set disable_native_luksv1 but not rbd_volume_local_attach ? | 12:59 |
| *** ociuhandu has joined #openstack-nova | 12:59 | |
| *** redrobot has joined #openstack-nova | 12:59 | |
| lyarwood | stephenfin: Yes, if they are using a non-RBD Cinder Volume backend and LUKSv1 encrypted volumes. | 12:59 |
| lyarwood | stephenfin: like LVM/iSCSI etc. | 13:00 |
| stephenfin | Ah, of course /o\ Fair fair | 13:00 |
| *** ociuhandu has quit IRC | 13:00 | |
| *** ociuhandu has joined #openstack-nova | 13:01 | |
| brinzhang | lyarwood: thanks | 13:02 |
| *** udesale_ has joined #openstack-nova | 13:03 | |
| *** udesale has quit IRC | 13:05 | |
| *** mkrai_ has quit IRC | 13:06 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | 13:08 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Fix [workarounds]/rbd_volume_local_attach config docs https://review.opendev.org/718100 | 13:08 |
| lyarwood | stephenfin: ^ thanks again | 13:08 |
| *** hrw has joined #openstack-nova | 13:08 | |
| hrw | morning | 13:08 |
| *** Luzi has joined #openstack-nova | 13:09 | |
| hrw | lyarwood: you commented https://review.opendev.org/#/c/714311/3/nova/virt/libvirt/driver.py@5323 with 'supernit - return'. I do not understand. What do you mean there? | 13:09 |
| *** ratailor has quit IRC | 13:11 | |
| lyarwood | hrw: morning, by supernit I mean something that is beyond a normal nit (a small issue with a change) and as such not something I'd actually ask someone to respin the change to correct. | 13:11 |
| lyarwood | hrw: here I was just suggesting that you could just return instead of using support_uefi | 13:12 |
| hrw | lyarwood: ok | 13:12 |
| hrw | lyarwood: I see now. | 13:13 |
| lyarwood | hrw: yeah apologies if it wasn't clear, +1 on the change anyway. | 13:13 |
| hrw | lyarwood: it was copied from one place, adapted and reused. | 13:13 |
| sean-k-mooney | hrw by convention in python if a varible is not used in the same function and is just returned we should just retrun the expression | 13:13 |
| hrw | yeah | 13:14 |
| sean-k-mooney | but its not important enough to actully repin a patch over as lyarwood said | 13:14 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | 13:14 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856 | 13:14 |
| hrw | just with amount of comments around that comment took me a while to notice which part of line it applied to ;D | 13:14 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | 13:15 |
| luyao | stephenfin: Thanks for review :), your comments are addressed. https://review.opendev.org/687856 | 13:16 |
| stephenfin | cool | 13:25 |
| stephenfin | lyarwood: could you take a look at https://review.opendev.org/715406 and its predecessor to close that out? | 13:26 |
| lyarwood | stephenfin: yup looking | 13:26 |
| *** ociuhandu has quit IRC | 13:32 | |
| *** ociuhandu has joined #openstack-nova | 13:33 | |
| stephenfin | sean-k-mooney: replied on https://review.opendev.org/#/c/700894/ | 13:35 |
| *** hrw has left #openstack-nova | 13:35 | |
| sean-k-mooney | ok. ill take a look at it sortly. that said i tried doing it a few different ways and without a significant rewrite this was the cleanest way i could do it | 13:36 |
| dansmith | brinzhang: are you able to work on that policy patch? | 13:40 |
| sean-k-mooney | stephenfin: in anycase ill take a look again and rebase it ontop of your mock lib removal patch | 13:45 |
| *** _kukacz has joined #openstack-nova | 13:45 | |
| stephenfin | sean-k-mooney: don't rebase it - that mock removal patch is having teething issues and won't be finished this week | 13:45 |
| stephenfin | specifically I'm hitting bugs in the stdlib mock libraries that I'm having to work around :( | 13:46 |
| sean-k-mooney | stephenfin: ok | 13:46 |
| sean-k-mooney | i didnt want it to conflict | 13:46 |
| sean-k-mooney | stephenfin: or bugs in mock the lib | 13:46 |
| *** yaawang has joined #openstack-nova | 13:47 | |
| sean-k-mooney | stephenfin: i have hit bugs with the mock lib before so its proably that we work around those initally now we need to return to the normal behavior | 13:47 |
| stephenfin | afaict, mock the lib is a straight backport of the stdlib library | 13:47 |
| stephenfin | so we'd presumably see the same issues if we downgraded to e.g. mock 2.0 | 13:48 |
| sean-k-mooney | stephenfin: it is ment to be yes but im not sure that is always true | 13:48 |
| *** READ10 has joined #openstack-nova | 13:56 | |
| *** mlavalle has joined #openstack-nova | 13:58 | |
| *** dave-mccowan has joined #openstack-nova | 13:59 | |
| *** tkajinam has quit IRC | 14:03 | |
| *** tkajinam has joined #openstack-nova | 14:03 | |
| *** Luzi has quit IRC | 14:07 | |
| *** dave-mccowan has quit IRC | 14:10 | |
| *** yaawang_ has joined #openstack-nova | 14:11 | |
| *** yaawang has quit IRC | 14:14 | |
| *** martinkennelly has quit IRC | 14:18 | |
| gibi | nova api experts, how can I specify a config_drive filter of GET /server/details to get the servers that does not have a config drive | 14:37 |
| gibi | ? | 14:37 |
| *** priteau has quit IRC | 14:37 | |
| gibi | GET /servers/detail?config_drive=& is rejected by the schema | 14:37 |
| gibi | GET /servers/detail?config_drive=False returns empty list even if I have servers without config drive | 14:38 |
| gibi | config_drive in the response is defined like | 14:39 |
| gibi | "Indicates whether or not a config drive was used for this server. The value is True or an empty string. An empty string stands for False." | 14:39 |
| gibi | https://bugs.launchpad.net/nova/+bug/1871409 | 14:41 |
| openstack | Launchpad bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Undecided,New] | 14:41 |
| *** ttsiouts has quit IRC | 14:42 | |
| *** tkajinam has quit IRC | 14:42 | |
| *** ttsiouts has joined #openstack-nova | 14:46 | |
| *** dklyle has joined #openstack-nova | 14:48 | |
| *** ttsiouts_ has joined #openstack-nova | 14:49 | |
| *** ttsiouts has quit IRC | 14:49 | |
| openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | 14:51 |
| *** yaawang has joined #openstack-nova | 14:53 | |
| *** yaawang__ has joined #openstack-nova | 14:54 | |
| *** yaawang_ has quit IRC | 14:56 | |
| *** mkrai has joined #openstack-nova | 14:57 | |
| *** yaawang has quit IRC | 14:58 | |
| *** ttsiouts_ has quit IRC | 15:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: fix config_drive filter in GET /servers/details https://review.opendev.org/718140 | 15:02 |
| *** martinkennelly has joined #openstack-nova | 15:03 | |
| gibi | stephenfin: in https://review.opendev.org/682772 do you mean accepting boolean like values or do you also mean defaulting config_drive to False if not present? | 15:10 |
| stephenfin | just the former | 15:10 |
| stephenfin | sorry, that wasn't clear | 15:10 |
| *** ircuser-1 has joined #openstack-nova | 15:11 | |
| gibi | stephenfin: no worries. I just discovered this bug while trying to make the 2.83 client patch to work | 15:11 |
| *** rcernin has quit IRC | 15:13 | |
| gibi | stephenfin: so for boolean like True value we should translate the filter to True and for a boolean like False value translate it to empty string? or keep the empty string as False semantic as in the response today? | 15:13 |
| stephenfin | so 'GET /servers/details?config_drive=' will get us servers without a config drive? We probably need to retain that behavior, if so | 15:15 |
| gibi | stephenfin: currently 'GET /servers/details?config_drive=' is not accepted by the schema | 15:15 |
| stephenfin | what do you mean by the empty string, in that case? | 15:15 |
| gibi | stephenfin: the respons of GET servers/details use empty value in the config_drive field to indicate no config drive (crazy) | 15:15 |
| stephenfin | Ah | 15:16 |
| gibi | https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detailed-detail#id21 | 15:16 |
| stephenfin | I guess we've to keep that the same, but I don't think the filter needs to work like that | 15:16 |
| stephenfin | We could change that API response in a future clean up microversion | 15:17 |
| gibi | so the API response will keep using True or "", the filter in the query will use truelike or falselike values | 15:17 |
| stephenfin | Yeah, that's sensible IMO | 15:17 |
| gibi | OK, thanks | 15:17 |
| gibi | I will do that then | 15:17 |
| stephenfin | No point letting the crazy spread into the query string too | 15:18 |
| gibi | gmann: Do we alredy have an API cleanup item for the crazy config drive value in https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detailed-detail#id21 | 15:18 |
| gibi | ? | 15:18 |
| gibi | stephenfin: yeah, make sense | 15:18 |
| sean-k-mooney | gibi: you mean where the config drive is a cinder volume uuid | 15:19 |
| gmann | gibi: to dis-allow empty dict? | 15:19 |
| sean-k-mooney | or was it swift object uuid | 15:19 |
| gibi | sean-k-mooney whaaat? | 15:19 |
| sean-k-mooney | it was a thing that rack space implemented | 15:19 |
| gibi | gmann: to not have True or empty string, but have proper False value | 15:19 |
| sean-k-mooney | and we used to allow in the api but i dont think the support is still nove or perhaps never was upstreamed | 15:20 |
| gibi | sean-k-mooney: does it mean the api ref is incomplete for config_drive here https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detailed-detail#id21 ? | 15:20 |
| gibi | sean-k-mooney: or you only mean we allowed empty string there to let rackspace replace that with a uuid downstream? | 15:21 |
| sean-k-mooney | gibi i need to go check the code but we used to accetp a uuid there at the api level but i dont know when we stopped i might even be a pre microverion thing | 15:22 |
| gibi | the db schema allows for a string(255) for config drive | 15:23 |
| sean-k-mooney | yes | 15:23 |
| sean-k-mooney | because rackspace used to put a uuid in it | 15:23 |
| gmann | empty string not allowed i think. schema allow bool only - https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L219 | 15:24 |
| gmann | this is test verify it - https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_serversV21.py#L4657 | 15:25 |
| gibi | gmann: at POST /serves, yes https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L193 but at the query string of GET /servers/details it is not boolean https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L607 | 15:25 |
| gmann | ohk, you mean in response | 15:26 |
| gibi | do we have schema for GET rsp? | 15:26 |
| gmann | gibi: query schema are the only one for GET | 15:27 |
| *** ttsiouts has joined #openstack-nova | 15:27 | |
| sean-k-mooney | gibi: in the current api it should always be a bool | 15:27 |
| gmann | and eevrything on query param is string so we cannot restrict that in schema side. we need to add code check for that | 15:27 |
| sean-k-mooney | we should just use the sting to bool thing form oslo | 15:28 |
| gibi | gmann: the current schema does not allow empty string, but the db contains an empty string if there is no config drive attached | 15:28 |
| gmann | until we check the regex of bool values in schema which will be very complex | 15:28 |
| sean-k-mooney | e.g. to accpeth true True yes y 1 all as true | 15:28 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | 15:29 |
| gibi | sean-k-mooney: in the current API config_drive is "True" or empty string' | 15:29 |
| gmann | yeah, we can 1. always return bool in response (convert empty string to False) and 2. allow query for bool value only | 15:29 |
| gibi | I don't want to change the GET rsp, but I need to provide filtering support | 15:29 |
| gibi | in the query string | 15:29 |
| *** READ10 has quit IRC | 15:29 | |
| gibi | gmann: changing GET rsp is an API cleanup that needs a microversion and outside of my bugfixing effort | 15:30 |
| gibi | gmann: but I still need to support some way to filter for servers wihtout config drive | 15:30 |
| gibi | stephenfin: suggested to use True and False like values there | 15:30 |
| gibi | but if there is a hidden rackspace dependency for a uuid in the config_drive filed then this change will break them | 15:31 |
| gmann | if no change in GET response then it might be confusing ? not sure client side will show black value for that. i think we had same issue on swap field in flavor | 15:31 |
| *** gyee has joined #openstack-nova | 15:31 | |
| gibi | currently client side (novaclient) use empty value | 15:32 |
| gibi | | config_drive | | | 15:32 |
| gmann | gibi: does query with empty string just ignore the filter or error ? | 15:32 |
| gibi | gmann: error as per https://bugs.launchpad.net/nova/+bug/1871409 | 15:32 |
| openstack | Launchpad bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Medium,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 15:32 |
| gibi | the query string schema does not allow empty string | 15:33 |
| gibi | gmann: I can fix that by https://review.opendev.org/#/c/718140/1/nova/api/openstack/compute/schemas/servers.py | 15:33 |
| gibi | but then stephenfin had a point that by this we spread the True or "" crazyness from the GET rsp to the query sting | 15:33 |
| gmann | yeah that is my concern also. | 15:35 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | 15:35 |
| bauzas | gibi: FWIW, I'm almost done with the functional test, including for multiple types https://review.opendev.org/717975 | 15:35 |
| gmann | gibi: and with your fix (allow '' in schema) does give correct servers list ? | 15:36 |
| gibi | I can do a True or False query filter but then we break rackspace if they depend on passing through a uuid in the filter | 15:36 |
| bauzas | gibi: you can look at it to see that we don't support some specific pGPU if the asked type by the configuration is not actually used by the pGPU | 15:36 |
| gibi | gmann: yes, the WIP patch works for me | 15:36 |
| gibi | bauzas: ack, I will get back to that tomorrow. | 15:36 |
| * bauzas now goes back to look at gibi's comments | 15:36 | |
| gmann | gibi: ok, apart from rackspace usecase, if we allow empty string in query which is disallowed now still need microversion as it change the interface | 15:37 |
| gmann | for interoperability | 15:38 |
| gibi | gmann: we cannot filter for servers without config drive today, it is a bug | 15:38 |
| gmann | humm | 15:38 |
| gibi | as that filter would look like: ?config_drive= | 15:39 |
| gibi | as the db contains empty value for the no config drive case | 15:39 |
| *** READ10 has joined #openstack-nova | 15:40 | |
| gmann | i was thinking to fix it with GET reponse and DB to have false in case of no config drive(empty string) | 15:40 |
| gibi | gmann: that is DB migration + microversion on the API (due to the rsp change) so that is someting I wouldn't start at the week of FF | 15:41 |
| gibi | also it has a rackspace crazyness to it | 15:41 |
| gibi | but on the long term this might be the good way | 15:41 |
| gibi | for API consistency | 15:42 |
| gibi | so I agree to add this to the API cleanup etherpad | 15:42 |
| gmann | but i am thinking if changing query things is ok without microversion as it can create interop issue | 15:42 |
| gibi | yeah, so I have to find a way now to unblock the 2.83 client patch without the need to change the query string semantic | 15:43 |
| gibi | I can say that we have a nova bug but the client patch does not make it worse it just keep passing what it gets from the user to the nova API, and as soon as we fix the nova API we can stricten the client code too | 15:43 |
| gmann | ok. I will check that, i think we can keep error there as it get from API | 15:44 |
| gmann | yeah, ditto | 15:44 |
| gmann | i will add that on etherpad and we can discuss the best possible solution. | 15:44 |
| gibi | gmann: cool. thanks. | 15:44 |
| gmann | thanks. we might have few more field like that | 15:45 |
| gmann | gibi: done, L86 - https://etherpad.openstack.org/p/nova-api-cleanup | 15:46 |
| gibi | ack | 15:46 |
| gibi | thanks | 15:46 |
| sean-k-mooney | gibi: this is what i was thining of by the way https://bugs.launchpad.net/python-novaclient/+bug/1314395 https://github.com/openstack/python-novaclient/commit/adf6c351a05d205573be4f00db1e53aa2615a593 | 15:54 |
| openstack | Launchpad bug 1314395 in python-novaclient "Documentation for config_drive boot parameter is incorrect" [Undecided,Fix released] - Assigned to Jason Dunsmore (jasondunsmore) | 15:54 |
| sean-k-mooney | gibi: many many many moons ago e.g. like essex it used to take a volume id too | 15:54 |
| artom | stephenfin, so, I know I said the NUMA LM tests can wait until after FF | 15:54 |
| artom | But with https://review.opendev.org/#/c/715362/4, I'd kinda want to see them merge first? | 15:54 |
| gibi | sean-k-mooney: thanks for the reference | 15:55 |
| artom | I'd be the only place where we test the fancier live migration stuff | 15:55 |
| stephenfin | Hmm, that's a fair point. I'll try dig back into it tomorrow morning | 15:57 |
| sean-k-mooney | ah the uuid was only for nova v1 api and was droped in https://review.opendev.org/#/c/10934/ damb that was a long time ago. im surprise we only update the docs in rocky | 15:58 |
| artom | stephenfin, I've addressed your hatred of the weird 3/2 split, FWIW, hopefully it's easier to understand now | 15:59 |
| *** dpawlik has quit IRC | 16:00 | |
| artom | stephenfin, also, https://review.opendev.org/#/c/687856/24/nova/compute/manager.py@7672 | 16:01 |
| artom | Am I being overly dramatic? | 16:01 |
| *** _kukacz has quit IRC | 16:01 | |
| stephenfin | artom: You need to have a guest NUMA topology to use vPMEM | 16:01 |
| artom | stephenfin, ah, doh. | 16:02 |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| *** udesale_ has quit IRC | 16:08 | |
| *** dtantsur is now known as dtantsur|afk | 16:08 | |
| *** READ10 has quit IRC | 16:12 | |
| dansmith | gmann: around? | 16:17 |
| gmann | dansmith: hi | 16:17 |
| dansmith | gmann: I need some help understanding the policy tests so I can rebase this patch | 16:18 |
| gmann | sure | 16:18 |
| dansmith | gmann: https://review.opendev.org/#/c/711194/13/nova/tests/unit/policies/test_volumes.py@240 | 16:18 |
| *** ociuhandu has quit IRC | 16:18 | |
| *** ociuhandu has joined #openstack-nova | 16:19 | |
| dansmith | gmann: that test is running with system_foo_context and validating that policy fails.. | 16:19 |
| dansmith | gmann: so I'm guessing whatever system_policy_context is does not have admin to do swap, and is not owner for update? | 16:19 |
| *** mkrai has quit IRC | 16:20 | |
| gmann | dansmith: yeah system_foo_context does not have admin. these are all context defined - https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/tests/unit/policies/base.py#L54 | 16:21 |
| dansmith | oh, so system_foo is "some random other user" ? | 16:21 |
| sean-k-mooney | stephenfin: artom well wehn you use vpmem it creates an implict numa toplogy like cpu pinning or hugepages | 16:22 |
| dansmith | gmann: so that should fail for both reasons... "not admin and not owner" right? | 16:22 |
| gmann | dansmith: yeah, basically checking 'foo' role has access or not | 16:22 |
| gmann | true | 16:22 |
| artom | sean-k-mooney, yeah, I got it completely wrong and panicked for nothing | 16:22 |
| sean-k-mooney | artom: hehe k | 16:22 |
| dansmith | gmann: okay, so the next test after that.. is changing the policy it looks like? | 16:23 |
| gmann | dansmith: i think we should test those policy against each context. we can hack the first policy check to allow-all to verify the second. | 16:23 |
| gmann | dansmith: yeah changing the first policy, so that we can verify the second enforced policy | 16:24 |
| sean-k-mooney | im going to see if my second attempt to get shopping without spenindg 30 mins queing to get in to the shop works so ill be back in an hour too since ill be cooking dinner in ither case | 16:24 |
| dansmith | gmann: I'm not checking both, I'm checking one or the other.. maybe I should just push up what I have for discussion and work on the tests after we agree? | 16:24 |
| gmann | dansmith: yeah, because those tests are with old order of policy | 16:24 |
| gmann | once we have correct order of policy enforcement then we can better judge how to tests | 16:24 |
| dansmith | right okay.. let me remove that last test since it's testing the serial checking of policy anyway | 16:25 |
| dansmith | ack | 16:25 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing flavor_manage policies https://review.opendev.org/714814 | 16:27 |
| *** lpetrut has joined #openstack-nova | 16:27 | |
| *** luyao has quit IRC | 16:27 | |
| sean-k-mooney | oh while i think if it we have a but with how we do validation of numa paramater if we have an automatic numa toplogy. ill try an file it when i get back but basically we ignore the hw:nuam_cpu and hw:numa_mem options if you dont have multiple numa nodes to you can set things that refer to cells that dont exist e.g hw:numa_mem.1=512 when you only have one numa node(node 0) or possible no numa nodes i | 16:28 |
| sean-k-mooney | havent fullly check how broken it is. | 16:28 |
| sean-k-mooney | i think the code that reads that extra spec just does not run if you dont have hw:numa_nodes>=2 | 16:29 |
| stephenfin | lyarwood: You have two merge conflict issues in the https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue series, fyi https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue | 16:29 |
| *** brinzhang has quit IRC | 16:30 | |
| lyarwood | stephenfin: looking | 16:30 |
| lyarwood | how on earth | 16:31 |
| *** brinzhang has joined #openstack-nova | 16:31 | |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | 16:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430 | 16:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 16:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 16:36 |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-nova | 16:37 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 16:37 |
| gibi | stephenfin, gmann, brinzhang: made --config-drive a pass through option in https://review.opendev.org/713089 to decuple that change from the bugfix https://bugs.launchpad.net/nova/+bug/1871409 | 16:38 |
| openstack | Launchpad bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Medium,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 16:38 |
| stephenfin | gibi: What kind of values can the user actually pass through at the moment? | 16:40 |
| *** ttsiouts has quit IRC | 16:40 | |
| gibi | stephenfin: API schema allows any string | 16:40 |
| gibi | stephenfin: and matches it against the DB value | 16:40 |
| gibi | which is also a String(255) | 16:40 |
| gibi | (the API schema does not allow empty string though) | 16:41 |
| stephenfin | right, but what values will do something meaningful? Do we only ever store a string-ified True/False value in there? | 16:41 |
| gibi | stephenfin: we definitely store "True" and "", but I'm not sure if we store other values | 16:41 |
| *** ociuhandu has quit IRC | 16:42 | |
| gibi | at some point in the past we allowed to store a uuid there | 16:42 |
| gibi | https://bugs.launchpad.net/python-novaclient/+bug/1314395 | 16:42 |
| openstack | Launchpad bug 1314395 in python-novaclient "Documentation for config_drive boot parameter is incorrect" [Undecided,Fix released] - Assigned to Jason Dunsmore (jasondunsmore) | 16:42 |
| gibi | so in some crazy old deployment the db could contain a uuid | 16:43 |
| *** ociuhandu has joined #openstack-nova | 16:43 | |
| gibi | old, mean existed for a long time but upgraded to new nova code | 16:43 |
| stephenfin | gibi: We haven't let you create such a server in quite some time though https://github.com/openstack/nova/blob/bae8b1306eb/nova/compute/api.py#L532-L545 | 16:44 |
| stephenfin | What I'm getting at is that it doesn't seem like there's much point allowing the user to pass through an arbitrary string, since the users that can use it are vanishingly small | 16:45 |
| stephenfin | So I wonder if we should just allow true/false and add a TODO that false doesn't actually work until that bug is fixed? | 16:45 |
| stephenfin | specifically, we should use a '--[no-]config-drive' option pair | 16:45 |
| gibi | the API allows now to send in any string in the query param config_drive, when we fix that we need to bump the API microversion. I guess that will be a good signal to change the client to only allow true/false to be passed | 16:47 |
| stephenfin | True. The client doesn't have to match the server 100% though. We could limit the user client side, even if it's currently a free-for-all server side | 16:48 |
| *** ociuhandu has quit IRC | 16:48 | |
| gibi | true | 16:48 |
| stephenfin | I just think allowing '--config-drive foo' is daft, since no ones going to use it, and '--config-drive [True|False]' is worse than '--[no-]config-drive' | 16:49 |
| gibi | I have to finish for today and we have like 2 days to land the client patches. I can look at it tomorrow again | 16:49 |
| stephenfin | Yeah, me too. The dog's not going to walk itself :) | 16:50 |
| gibi | I free I buring time on this that would be better burnt on review | 16:50 |
| gibi | I feel | 16:50 |
| gibi | but meh. | 16:50 |
| gibi | see you tomorrow | 16:50 |
| stephenfin | o/ | 16:50 |
| *** psachin has quit IRC | 16:55 | |
| *** lpetrut has quit IRC | 16:56 | |
| stephenfin | gmann: Am I correct here? https://review.opendev.org/#/c/709955/3/nova/api/openstack/compute/volumes.py@401 | 17:01 |
| *** mriedem has joined #openstack-nova | 17:01 | |
| gmann | stephenfin: yeah. scope_type are not override-able so passing instance project_id is no use there | 17:09 |
| stephenfin | Sweet. Thanks, gmann | 17:10 |
| gmann | stephenfin: for few server actions like migration, we default them to SYSTEM_ADMIN and passing the project_id also by keeping scope_type as ['system', 'project'] so that operator can give access to project scope role also if they want | 17:10 |
| gmann | but when scope_type itself is 'system' only then no use of project_id | 17:11 |
| *** xek_ has joined #openstack-nova | 17:11 | |
| *** ttsiouts has joined #openstack-nova | 17:13 | |
| *** xek has quit IRC | 17:14 | |
| *** ttsiouts has quit IRC | 17:18 | |
| *** martinkennelly has quit IRC | 17:30 | |
| *** ttsiouts has joined #openstack-nova | 17:31 | |
| gmann | dansmith: what you think on this. checking 'update' policy always and then swap if request is swap - https://review.opendev.org/#/c/711194/14/nova/api/openstack/compute/volumes.py@478 | 17:37 |
| *** links has quit IRC | 17:38 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-flavor-manage https://review.opendev.org/714818 | 17:38 |
| *** xek_ has quit IRC | 17:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server topology policies https://review.opendev.org/717524 | 17:40 |
| dansmith | gmann: that's an option too yeah. I guess the reason that seems less good is that, unless we check, in order to swap you have to have both permissions.. we might as well make one the superset and not require you to have both explicitly | 17:45 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in os-flavor_manage policies https://review.opendev.org/714819 | 17:46 |
| *** ttsiouts has quit IRC | 17:46 | |
| *** vishalmanchanda has quit IRC | 17:47 | |
| *** nightmare_unreal has quit IRC | 17:48 | |
| gmann | dansmith: yeah, i am thinking doing PUT is always need 'update' policy permission like we do in unlock. first unlock policy permission and then additional unlock_override permission. | 17:48 |
| dansmith | okay, seems *more* confusing to me, but consistency is good, so if theres already precedent that's fine | 17:49 |
| gmann | or if we think the use case of override i mentioned is not valid/make sense then we can keep the same way it is currently | 17:50 |
| dansmith | gmann: does that mean we require update auth for <2.85 as well? meaning I can just put the update policy check always (i.e. remove it from under the else)? | 17:50 |
| gmann | because it is swap operation so i am not sure interpreting it more user side cases is required or not | 17:50 |
| *** brinzhang_ has joined #openstack-nova | 17:51 | |
| gmann | dansmith: ah no, after >2.85 only and before it is always swap-only policy | 17:51 |
| dansmith | why/ | 17:51 |
| gmann | because we are changing default means new policy itself for new operation which is allowed after 2.85 | 17:52 |
| dansmith | won't the user, who doesn't know anything about policy, wonder why they can do swap with 2.1, but cannot do swap with 2.85, because the admin has not given them update perms yet? | 17:52 |
| gmann | if we keep default same as old 'update' policy then it is ok | 17:52 |
| dansmith | .../ | 17:53 |
| gmann | dansmith: without overeride policy they get permission automatically but if overriding the swap policy then even no-deprecation is issue | 17:53 |
| *** brinzhang has quit IRC | 17:53 | |
| dansmith | I don't understand what you're saying | 17:54 |
| dansmith | if the policy defaults are kept, then if I roll out ussuri, users who should have swap permissions will lose that ability with microversion 2.85 until I grant them update permission | 17:54 |
| dansmith | but they would continue to be able to do it with 2.1 | 17:55 |
| dansmith | however, with what I have, they will see no change in behavior | 17:55 |
| gmann | with defaults they are always have update permission as it is subset of swap default. | 17:55 |
| gmann | with defaults, there is no issue on your proposal | 17:55 |
| gmann | i am thinking if uses has override the old swap policy and want to do the same for new update policy | 17:56 |
| gmann | if we consider either case default or override - swap is always supeset then it is ok | 17:57 |
| gmann | but yes, we can not handle all cases in this case | 17:58 |
| *** kaisers_ has quit IRC | 17:59 | |
| gmann | dansmith: i think it is ok with your approach and we update policy doc that for swap + update we only check swap policy which is expected to be superset of 'update' | 17:59 |
| dansmith | okay | 18:00 |
| dansmith | will you comment on the patch about that? | 18:00 |
| gmann | doing, | 18:00 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in os-flavor-manage policy https://review.opendev.org/714822 | 18:00 |
| dansmith | thanks | 18:01 |
| gmann | dansmith: done. added comment on tests cases, few are not needed and does not test much | 18:10 |
| *** ttsiouts has joined #openstack-nova | 18:25 | |
| *** ttsiouts has quit IRC | 18:30 | |
| openstackgerrit | Merged openstack/nova master: Fix resume server policy to be admin_or_owner https://review.opendev.org/717561 | 18:32 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing suspend server policies https://review.opendev.org/717554 | 18:32 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in suspend server https://review.opendev.org/717582 | 18:32 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in suspend server policies https://review.opendev.org/717583 | 18:32 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in limits policy https://review.opendev.org/715680 | 18:32 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in limits policies https://review.opendev.org/715760 | 18:33 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server group policies https://review.opendev.org/717173 | 18:33 |
| *** maciejjozefczyk has quit IRC | 18:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 18:39 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 18:40 |
| *** ccamacho has quit IRC | 18:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server topology policies https://review.opendev.org/717524 | 18:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server topology https://review.opendev.org/717584 | 18:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server topology policies https://review.opendev.org/717585 | 18:53 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server group policy https://review.opendev.org/717174 | 19:03 |
| openstackgerrit | Merged openstack/nova stable/queens: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715405 | 19:04 |
| *** ttsiouts has joined #openstack-nova | 19:14 | |
| *** tesseract has quit IRC | 19:25 | |
| openstackgerrit | Merged openstack/nova stable/queens: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715406 | 19:29 |
| *** derekh has quit IRC | 19:39 | |
| *** ralonsoh has quit IRC | 19:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server topology policies https://review.opendev.org/717585 | 19:40 |
| melwitt | gmann: hey, what were you meaning here? https://review.opendev.org/#/c/716809/1/tempest/scenario/test_server_advanced_ops.py are you saying that the test involves passing a specific network during server create? and that getting the 409 multiple networks error means somehow the list_networks is returning None? | 19:43 |
| melwitt | oops, I should have written that in -qa | 19:43 |
| *** slaweq has quit IRC | 19:44 | |
| gmann | melwitt: yeah. that is one possibility otherwise scenario base tests always send the network in create request | 19:45 |
| gmann | it was API tests where we reply on tenants network created during setup of credential. | 19:45 |
| gmann | s/reply/rely | 19:45 |
| melwitt | ok | 19:46 |
| *** ttsiouts has quit IRC | 19:48 | |
| *** nweinber has quit IRC | 19:52 | |
| *** ociuhandu has joined #openstack-nova | 19:54 | |
| *** slaweq has joined #openstack-nova | 19:54 | |
| *** ociuhandu has quit IRC | 20:00 | |
| *** derekh has joined #openstack-nova | 20:13 | |
| *** derekh has quit IRC | 20:14 | |
| *** READ10 has joined #openstack-nova | 20:22 | |
| *** READ10 has quit IRC | 20:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | 20:32 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | 20:40 |
| *** igordc has quit IRC | 20:47 | |
| *** igordc has joined #openstack-nova | 20:48 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489 | 20:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 20:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | 20:50 |
| *** slaweq_ has joined #openstack-nova | 21:04 | |
| *** slaweq has quit IRC | 21:04 | |
| *** slaweq_ has quit IRC | 21:34 | |
| *** ociuhandu has joined #openstack-nova | 21:34 | |
| *** ociuhandu has quit IRC | 21:39 | |
| *** ttsiouts has joined #openstack-nova | 21:44 | |
| openstackgerrit | sean mooney proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | 22:09 |
| *** rcernin has joined #openstack-nova | 22:11 | |
| *** ttsiouts has quit IRC | 22:18 | |
| *** eharney has quit IRC | 22:20 | |
| *** tkajinam has joined #openstack-nova | 22:56 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | 23:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Functional test with pGPUs https://review.opendev.org/717975 | 23:10 |
| *** mriedem has left #openstack-nova | 23:15 | |
| *** mlavalle has quit IRC | 23:15 | |
| *** yaawang__ has quit IRC | 23:16 | |
| *** yaawang__ has joined #openstack-nova | 23:17 | |
| *** tosky has quit IRC | 23:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!