| *** gyee has quit IRC | 00:08 | |
| *** rs91 has joined #openstack-nova | 00:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in security group policies https://review.opendev.org/716797 | 00:13 |
|---|---|---|
| *** rs91 has quit IRC | 00:15 | |
| *** ociuhandu has joined #openstack-nova | 00:34 | |
| *** mlavalle has quit IRC | 00:36 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server diagnostics policies https://review.opendev.org/716800 | 00:37 |
| *** ociuhandu has quit IRC | 00:38 | |
| brinzhang_ | gmann:I think you mean I should merged https://review.opendev.org/#/c/716679 to https://review.opendev.org/#/c/716679, right? | 00:39 |
| gmann | brinzhang_: that is just example patch i showed instead of comment which was little hard to explain. i will abandon this once you do those changes in your patch. | 00:40 |
| brinzhang_ | gmann: I think I know what you want to say, if the user want to swap, need to check the v2.85 and swap policy, | 00:42 |
| brinzhang_ | gmann: if the user want to swap + update, they should check update policy for d-o-t, because of other parameters we doesnot allow to update (update only) | 00:43 |
| gmann | brinzhang_: swap policy check for swap only or update+swap both. swap only can be with any microversion | 00:43 |
| brinzhang_ | yes | 00:43 |
| gmann | brinzhang_: correct. because that is place where we know request is for update | 00:44 |
| brinzhang_ | and I can say, swap policy can do anything in update api, contains update policy | 00:45 |
| brinzhang_ | gmann: I will update and add the these test said by gibi | 00:47 |
| gmann | brinzhang_: yeah, tests covering all those cases will be good | 00:48 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server diagnostics https://review.opendev.org/716803 | 00:57 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in security group policies https://review.opendev.org/716793 | 01:05 |
| *** Liang__ has joined #openstack-nova | 01:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server diagnostics policies https://review.opendev.org/716805 | 01:08 |
| *** N3l1x has quit IRC | 01:09 | |
| brinzhang_ | gmann: context.can(va_policies.POLICY_ROOT % 'swap') this policy check, does we need to add target={} in it? | 01:30 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in server diagnostics policy https://review.opendev.org/716810 | 01:31 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit https://review.opendev.org/708788 | 01:36 |
| *** zhanglong has joined #openstack-nova | 01:40 | |
| melwitt | gmann: hey, just to clarify, if I understand correctly we're going to address the warning log issue in a later patch before FF with the plan being to remove the warning log and use Upgrade reno instead? and we'll have a nova doc page explaining the detail of the change in defaults with instructions for users on how to review the new defaults and use them? (enforce_scope = True and how to generate new defaults for review)? | 01:51 |
| *** links has joined #openstack-nova | 02:17 | |
| *** tetsuro has quit IRC | 02:50 | |
| *** mkrai has joined #openstack-nova | 02:54 | |
| *** links has quit IRC | 03:00 | |
| *** ccamacho has quit IRC | 03:03 | |
| *** sapd1_x has joined #openstack-nova | 03:10 | |
| *** Liang__ is now known as LiangFang | 03:22 | |
| *** tetsuro has joined #openstack-nova | 03:30 | |
| *** igordc has quit IRC | 03:42 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 03:45 |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | 03:46 |
| *** mkrai has quit IRC | 03:48 | |
| *** mkrai_ has joined #openstack-nova | 03:48 | |
| brinzhang_ | gibi, gmann: I addressed your comments in https://review.opendev.org/#/c/711194/11, but when I want to add the "policy check fails for swap + update due to update policy failure" case, that cannot get what I want, see http://paste.openstack.org/show/791501/ | 03:48 |
| brinzhang_ | gibi, gmann: Anything I missed? | 03:48 |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:37 | |
| *** amodi has quit IRC | 04:47 | |
| *** udesale has joined #openstack-nova | 04:56 | |
| *** sapd1_x has quit IRC | 05:02 | |
| *** yaawang has quit IRC | 05:05 | |
| *** yaawang has joined #openstack-nova | 05:05 | |
| *** threestrands has joined #openstack-nova | 05:06 | |
| *** fnordahl has joined #openstack-nova | 05:10 | |
| *** ratailor has joined #openstack-nova | 05:13 | |
| *** sapd1_x has joined #openstack-nova | 05:14 | |
| *** links has joined #openstack-nova | 05:25 | |
| *** ociuhandu has joined #openstack-nova | 05:58 | |
| *** ociuhandu has quit IRC | 06:02 | |
| *** spatel has joined #openstack-nova | 06:20 | |
| *** mnasiadka has quit IRC | 06:21 | |
| *** mnasiadka has joined #openstack-nova | 06:21 | |
| *** ociuhandu has joined #openstack-nova | 06:23 | |
| *** spatel has quit IRC | 06:25 | |
| *** sapd1_x has quit IRC | 06:29 | |
| *** vishalmanchanda has joined #openstack-nova | 06:30 | |
| *** nightmare_unreal has joined #openstack-nova | 06:31 | |
| *** zhanglong has quit IRC | 06:39 | |
| *** zhanglong has joined #openstack-nova | 06:40 | |
| *** sapd1_x has joined #openstack-nova | 06:41 | |
| *** mkrai_ has quit IRC | 06:52 | |
| *** mkrai has joined #openstack-nova | 06:52 | |
| *** dklyle has quit IRC | 06:53 | |
| *** david-lyle has joined #openstack-nova | 06:53 | |
| *** gary_perkins has quit IRC | 06:55 | |
| *** ccamacho has joined #openstack-nova | 06:56 | |
| *** tesseract has joined #openstack-nova | 06:57 | |
| *** gary_perkins has joined #openstack-nova | 06:58 | |
| *** ociuhandu has quit IRC | 07:03 | |
| *** ociuhandu has joined #openstack-nova | 07:04 | |
| *** maciejjozefczyk has quit IRC | 07:04 | |
| *** frickler_ is now known as frickler | 07:05 | |
| gibi | good morning nova | 07:08 |
| gibi | brinzhang_: will get to it soon | 07:08 |
| *** maciejjozefczyk has joined #openstack-nova | 07:08 | |
| brinzhang_ | good morning gibi | 07:08 |
| gibi | _erlon_: it is up as usual. I update the agenda as soon | 07:08 |
| brinzhang_ | gibi: thanks, wait for your check | 07:08 |
| *** slaweq has joined #openstack-nova | 07:08 | |
| *** ociuhandu has quit IRC | 07:09 | |
| *** tetsuro_ has joined #openstack-nova | 07:10 | |
| brinzhang_ | gibi: the noVnc feature, my colleague pushed the PoC code, maybe we can done of that feature, I will give him help as soon as possiable https://review.opendev.org/#/c/622336/ | 07:11 |
| brinzhang_ | gibi: you dont too review now, when it's ready, I will respin | 07:12 |
| *** tetsuro has quit IRC | 07:13 | |
| gibi | brinzhang_: ack, I saw the patch getting up | 07:14 |
| *** tetsuro_ has quit IRC | 07:14 | |
| *** avolkov has joined #openstack-nova | 07:16 | |
| *** rpittau|afk is now known as rpittau | 07:17 | |
| *** masterpe has quit IRC | 07:29 | |
| *** yaawang has quit IRC | 07:34 | |
| *** yaawang has joined #openstack-nova | 07:34 | |
| *** ociuhandu has joined #openstack-nova | 07:37 | |
| *** sapd1_x has quit IRC | 07:39 | |
| *** tetsuro has joined #openstack-nova | 07:40 | |
| *** dtantsur|afk is now known as dtantsur | 07:44 | |
| gibi | brinzhang_: regarding http://paste.openstack.org/show/791501/ the test fails as the calls https://review.opendev.org/#/c/711194/11/nova/api/openstack/compute/volumes.py@488 raises instead of returns False | 07:49 |
| gibi | so somehow you setting @ for swap policy does not pass | 07:51 |
| brinzhang_ | but I overwrite to self.policy_root % "swap": "@", | 07:51 |
| gibi | yeah | 07:51 |
| brinzhang_ | why? | 07:51 |
| gibi | I have no clue yet | 07:51 |
| gibi | there are 3 test classes all inheriting the unit test 2 of the fails 1 passes | 07:53 |
| gibi | so something is different in those classes | 07:54 |
| gibi | this passes VolumeAttachPolicyTest | 07:55 |
| gibi | VolumeAttachNoLegacyPolicyTest and .VolumeAttachScopeTypePolicyTest fails | 07:55 |
| brinzhang_ | yes, it's ok in VolumeAttachPolicyTest class, and not ok in VolumeAttachScopeTypePolicyTest and VolumeAttachNoLegacyPolicyTest class | 07:55 |
| brinzhang_ | I tried move it to VolumeAttachScopeTypePolicyTest class, but I think I cannot do that, I should keep them in the base class, I think | 07:56 |
| brinzhang_ | of course, in VolumeAttachScopeTypePolicyTest it's also failed | 07:56 |
| *** masterpe has joined #openstack-nova | 07:59 | |
| *** threestrands has quit IRC | 08:01 | |
| *** tosky has joined #openstack-nova | 08:02 | |
| *** yaawang has quit IRC | 08:03 | |
| *** yaawang has joined #openstack-nova | 08:04 | |
| *** ralonsoh has joined #openstack-nova | 08:12 | |
| gibi | I gave up, we need gmann to look at these tests | 08:13 |
| *** sapd1_x has joined #openstack-nova | 08:13 | |
| *** sapd1 has quit IRC | 08:16 | |
| brinzhang_ | gibi: yeah, thanks also ^^ | 08:17 |
| *** xek has joined #openstack-nova | 08:25 | |
| gibi | stephenfin: just to double check is this bp done now? https://blueprints.launchpad.net/nova/+spec/remove-nova-network-ussuri | 08:32 |
| *** yaawang has quit IRC | 08:32 | |
| gibi | I don't see any open patches | 08:32 |
| gibi | stephenfin: nvm, I see that the bp is in Implemented state | 08:32 |
| *** yaawang has joined #openstack-nova | 08:34 | |
| *** ociuhandu has quit IRC | 08:36 | |
| *** rambo_li has joined #openstack-nova | 08:38 | |
| *** ociuhandu has joined #openstack-nova | 08:38 | |
| *** martinkennelly has joined #openstack-nova | 08:39 | |
| *** ociuhandu has quit IRC | 08:43 | |
| *** rambo_li has quit IRC | 08:47 | |
| stephenfin | Yeah, I updated that last week | 08:52 |
| gibi | stephenfin: thanks | 08:53 |
| gibi | I'm going through the BPs targeted to ussuri just by eye skipped a line an thought nova-net bp is not closed | 08:54 |
| gibi | s/by/my | 08:54 |
| gibi | stephenfin: how familiar you are with the oslo policy stuff? | 08:54 |
| stephenfin | I've been learning it slowly | 08:55 |
| gibi | stephenfin: brinzhang_ has a test that fails on policy problem and I didn't find the solution | 08:55 |
| *** luyao has joined #openstack-nova | 08:55 | |
| gibi | stephenfin: this is the problematic test (in the comment in the paste) https://review.opendev.org/#/c/711194/11/nova/tests/unit/policies/test_volumes.py@176 if you have time. If not then no worries we will ping gmann later | 08:56 |
| brinzhang_ | gibi, thanks mention these, if stephenfin can give some help, I will be appreciate | 08:59 |
| stephenfin | will do | 09:03 |
| luyao | stephenfin: Hi, I hope you could continue looking at vpmem live migration support https://review.opendev.org/#/c/687856/ if you have time. :) | 09:03 |
| *** rambo_li has joined #openstack-nova | 09:06 | |
| *** ociuhandu has joined #openstack-nova | 09:10 | |
| *** rambo_li has quit IRC | 09:11 | |
| *** rambo_li has joined #openstack-nova | 09:12 | |
| *** tetsuro has quit IRC | 09:14 | |
| brinzhang_ | gibi, dansmith: I will modify the SPEC in 2020/4/4 or 2020/4/5, to show the new PUT api changes, I think it's not later | 09:17 |
| gibi | brinzhang_: sure. doc changes can go in after FF. and the spec repo is not even released so that is OK to update even later | 09:17 |
| *** tframbo has joined #openstack-nova | 09:20 | |
| brinzhang_ | gibi: thank, if so, I will update that while I have more free time ^^ | 09:20 |
| gibi | brinzhang_: thanks | 09:21 |
| brinzhang_ | gibi: np | 09:21 |
| *** LiangFang has quit IRC | 09:22 | |
| *** tframbo has quit IRC | 09:22 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove future imports https://review.opendev.org/714675 | 09:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | 09:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/708768 | 09:39 |
| *** tkajinam has quit IRC | 09:47 | |
| *** ygk_12345 has joined #openstack-nova | 09:52 | |
| *** ygk_12345 has left #openstack-nova | 09:55 | |
| *** zhanglong has quit IRC | 10:08 | |
| *** spatel has joined #openstack-nova | 10:09 | |
| *** sapd1_x has quit IRC | 10:09 | |
| *** spatel has quit IRC | 10:14 | |
| *** rpittau is now known as rpittau|bbl | 10:14 | |
| *** brinzhang_ has quit IRC | 10:24 | |
| *** brinzhang_ has joined #openstack-nova | 10:24 | |
| stephenfin | gibi, brinzhang_: RE: https://review.opendev.org/#/c/711194/11/nova/tests/unit/policies/test_volumes.py@176 - you're using the wrong HTTPRequest object | 10:28 |
| stephenfin | you're modifying 'nova.context' on 'self.req' and then calling things with a local 'req' that doesn't have 'nova.context' configured | 10:29 |
| brinzhang_ | stephenfin: I should add v2.85 support, what I do to change req = fakes.HTTPRequest.blank('', version='2.85')? | 10:30 |
| gibi | stephenfin: good eyes! thanks! | 10:30 |
| stephenfin | brinzhang_: I'm guessing but I think think self.req.version = '2.85' should do the trick?? | 10:31 |
| stephenfin | If not, you need to do req = fakes.HTTPRequest.blank('', version='2.85') | 10:31 |
| brinzhang_ | stephenfin: let me try | 10:31 |
| stephenfin | and the do e.g. req.environ['nova.context'] = self.system_foo_context | 10:31 |
| stephenfin | ^ that's what I did locally | 10:32 |
| stephenfin | brinzhang_: Actually, in the setUp, is there any reason not to configure 'self.req' with a version argument? | 10:33 |
| stephenfin | You're testing policy, not microversion support, so you'll always want to use a known working version, right? | 10:33 |
| brinzhang_ | yes | 10:33 |
| brinzhang_ | stephenfin: you mean I should change self.req to req in setup()? | 10:35 |
| stephenfin | no | 10:35 |
| stephenfin | instead of self.req = fakes.HTTPRequest.blank('') | 10:36 |
| stephenfin | do self.req = fakes.HTTPRequest.blank('', version='2.85') | 10:36 |
| stephenfin | here https://review.opendev.org/#/c/711194/12/nova/tests/unit/policies/test_volumes.py@78 | 10:36 |
| brinzhang_ | no, it dosenot only for v2.85 | 10:37 |
| brinzhang_ | so I just used req in v2.85 policy tests | 10:37 |
| stephenfin | ah, I see now, this is only for the 'update_volume' case | 10:37 |
| brinzhang_ | yes | 10:37 |
| stephenfin | gotcha | 10:37 |
| brinzhang_ | req.environ['nova.context'] = self.system_foo_context | 10:37 |
| stephenfin | yup, that'll do so ^ | 10:38 |
| brinzhang_ | I added this, it run ok now, will update | 10:38 |
| brinzhang_ | thansk stephenfin, gibi | 10:38 |
| *** sapd1 has joined #openstack-nova | 10:41 | |
| *** rambo_li has quit IRC | 10:42 | |
| *** derekh has joined #openstack-nova | 10:44 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 10:47 |
| brinzhang_ | gibi, stephenfin: done thanks | 10:47 |
| brinzhang_ | stephenfin: can you +A for this patch https://review.opendev.org/#/c/693828/25? it's ready for everything, that comment inline, I will fixed by FUP | 10:48 |
| stephenfin | brinzhang_: I haven't looked at that in a while so I'll need a while | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add support for new cyborg extra specs https://review.opendev.org/716222 | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.85, extra spec validation https://review.opendev.org/708436 | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 10:50 |
| stephenfin | gibi: addressed the comments from Sundar and removed those errant prints from the last doc patch ^ | 10:51 |
| brinzhang_ | stephenfin, gibi, gmann: thanks, hope you have a greate day ^^ | 10:51 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489 | 10:52 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Support different vGPU types per pGPU https://review.opendev.org/715490 | 10:52 |
| bauzas | sean-k-mooney: ^ | 10:52 |
| *** brinzhang has joined #openstack-nova | 10:58 | |
| *** brinzhang_ has quit IRC | 11:01 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in remote console policies https://review.opendev.org/716484 | 11:03 |
| *** ratailor_ has joined #openstack-nova | 11:08 | |
| *** mkrai has quit IRC | 11:09 | |
| *** ratailor has quit IRC | 11:10 | |
| *** tkajinam has joined #openstack-nova | 11:12 | |
| *** brinzhang_ has joined #openstack-nova | 11:21 | |
| *** ratailor_ has quit IRC | 11:23 | |
| *** ratailor_ has joined #openstack-nova | 11:23 | |
| *** brinzhang has quit IRC | 11:24 | |
| *** ratailor__ has joined #openstack-nova | 11:30 | |
| *** ratailor_ has quit IRC | 11:33 | |
| *** ratailor__ has quit IRC | 11:33 | |
| gibi | stephenfin: ack, will look shortly | 11:38 |
| *** udesale_ has joined #openstack-nova | 11:40 | |
| gibi | stephenfin: I'm all the way +2 on that series. Do you have a novaclient change as well? | 11:41 |
| *** udesale has quit IRC | 11:43 | |
| *** rcernin has quit IRC | 11:54 | |
| *** ratailor has joined #openstack-nova | 11:56 | |
| *** rpittau|bbl is now known as rpittau | 12:12 | |
| stephenfin | bauzas: You think you could review https://review.opendev.org/#/c/710037/8/doc/ext/extra_specs.py ? It's not the least bit complicated, if that helps :) | 12:25 |
| bauzas | oh yeah | 12:25 |
| stephenfin | Happy to trade reviews | 12:25 |
| sean-k-mooney | bauzas: at the moment i assume you are not allowing multiple vGPU types on a single pGPU | 12:34 |
| sean-k-mooney | bauzas: there is noting in princiapl that prevents that form working even if nvida does not support that | 12:34 |
| *** mkrai has joined #openstack-nova | 12:34 | |
| sean-k-mooney | the vfio mediated device framework fully support using multiple mdev_types on the same devcie concurrnetly | 12:35 |
| alex_xu | anyone know why we can swap the same volume before https://review.opendev.org/#/c/693828/25/nova/api/openstack/compute/volumes.py@495... | 12:35 |
| sean-k-mooney | alex_xu: lyarwood is on pto i think but i think we can may do that for a volume retype on the cinder side | 12:36 |
| alex_xu | oh, I guess we can't, that will fail at later voluem status check | 12:36 |
| alex_xu | sean-k-mooney: ah, thanks | 12:36 |
| sean-k-mooney | alex_xu: im not sure if my guess above was correct by the way. we could very well just fail later as you said | 12:37 |
| alex_xu | yea | 12:37 |
| sean-k-mooney | but i think cinder allows use to retype a voule while its attached to an instance and this is the only way i can think if for it to tell nova that it has updated | 12:38 |
| alex_xu | sean-k-mooney: ok, thanks | 12:39 |
| sean-k-mooney | alex_xu: i didnt review the rest of that patch but just -1'd it since its aliasing the id builtin fucntion and using id as a varible which is wrong | 12:41 |
| sean-k-mooney | in this context it wont break anything but we should never do that | 12:41 |
| alex_xu | sean-k-mooney: I'm not sure we can check that, I need to check the api code. we use 'id' in many API. but I agree that seems wrong | 12:51 |
| sean-k-mooney | im not sure we call id directly in nova since we normally dont care about the objects address in memory | 12:53 |
| sean-k-mooney | but its just not good practic to alias builtins in general | 12:53 |
| sean-k-mooney | it would only really be an issue if you did "id=dir" or something at module scope | 12:54 |
| sean-k-mooney | inside a function it will jsut make id unavialbel in that function body | 12:54 |
| *** nweinber has joined #openstack-nova | 12:55 | |
| *** mriedem has joined #openstack-nova | 12:55 | |
| sean-k-mooney | but if you do python3 -c "id=dir; help(id)" it will show the help for dir so if you do that at module scope anything that uses id after will get dir instead | 12:57 |
| alex_xu | yea, agree with that | 12:58 |
| alex_xu | sean-k-mooney: this is where id coming from https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L820 | 12:58 |
| sean-k-mooney | ah i see ya we proably shoucl change that to <resouce>_id for all of the usages and add a hacking check. | 13:00 |
| sean-k-mooney | that is a seperate change however so ill remove my -1 | 13:00 |
| sean-k-mooney | this is an existing bug | 13:00 |
| *** mkrai has quit IRC | 13:02 | |
| *** ociuhandu has quit IRC | 13:02 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 13:02 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | 13:02 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/716984 | 13:02 |
| *** francoisp has joined #openstack-nova | 13:03 | |
| *** mkrai has joined #openstack-nova | 13:04 | |
| *** derekh has quit IRC | 13:10 | |
| *** mkrai has quit IRC | 13:10 | |
| *** tesseract has quit IRC | 13:11 | |
| *** ratailor has quit IRC | 13:12 | |
| *** tesseract-RH has joined #openstack-nova | 13:16 | |
| artom | stephenfin, could you take a look at the bottom patch in the NUMA LM series? Dan Smith is +2, if you agree, we can at least get the first 2 patches in that series in the gate | 13:19 |
| stephenfin | sure | 13:19 |
| artom | The rest can wait until after FF I guess, since there are probably more important series to review | 13:20 |
| artom | stephenfin, err, link: https://review.opendev.org/#/c/714228/2 | 13:20 |
| bauzas | sean-k-mooney: that's a correct assumption, I prevent such thing (supporting multiple types concurrently for *each* pGPU) | 13:21 |
| sean-k-mooney | bauzas: ok. well that is not limitation of mdevs just of the nova/nvida usage | 13:22 |
| sean-k-mooney | bauzas: that is fine for now in anycase | 13:22 |
| bauzas | sean-k-mooney: like I also doesn't want to support yet asking for multiple allocations using groups | 13:22 |
| bauzas | i limit to only one allocation for the VGPU resource class | 13:23 |
| bauzas | I mean, people can ask VGPU>1 | 13:23 |
| bauzas | (of course) | 13:23 |
| bauzas | but not with numbered request groups | 13:23 |
| sean-k-mooney | ya that is fine | 13:23 |
| sean-k-mooney | i dont think we shoudl use numbered request groups in teh flavor anyway so im fine with that | 13:24 |
| bauzas | I don't return an exception for this | 13:24 |
| bauzas | I just take the first one | 13:24 |
| sean-k-mooney | that could be an improvement to add as a followup | 13:25 |
| sean-k-mooney | bauzas: its documented which is the important thing | 13:25 |
| bauzas | yup | 13:25 |
| *** markmcclain has joined #openstack-nova | 13:26 | |
| bauzas | sean-k-mooney: yeah I know the mdev framework does that | 13:28 |
| bauzas | (I mean having multiple vGPU types per pGPU= | 13:28 |
| bauzas | but then if you create one mdev with the nvidia driver, then automatically and magically the available instances of vGPU for the other types turn to 0 :D | 13:29 |
| bauzas | (at least GRID10 AFAIK) | 13:29 |
| bauzas | anyway, rushing to finish my change so that I can decently review stephenfin's extra spec validation thingies https://review.opendev.org/#/c/704643/20 | 13:30 |
| *** mkrai has joined #openstack-nova | 13:31 | |
| *** amodi has joined #openstack-nova | 13:42 | |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 13:53 |
| nightmare_unreal | mriedem: if you get some time can you see this : https://review.opendev.org/#/c/714459/ . I can't seem to figure out the issue with the unit test case I wrote. Thank you :) . I have fixed rest of the points you mentioned | 13:54 |
| *** vishalmanchanda has quit IRC | 13:58 | |
| *** dtantsur is now known as dtantsur|brb | 14:10 | |
| *** mkrai has quit IRC | 14:14 | |
| mriedem | nightmare_unreal: this? "Exception: This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later." | 14:15 |
| mriedem | that means the unit test class is using NoDBTestCase or whatever it's called, which means something in the test is trying to make a database connection and isn't allowed, | 14:15 |
| *** asettle has quit IRC | 14:15 | |
| mriedem | so either move that test to the functional test class where there is a DB connection, or you have to mock out the DB call to raise the NotFound error or whatever for the test | 14:16 |
| mriedem | your test can mock objects.CellMapping.get_by_uuid to raise CellMappingNotFound | 14:16 |
| *** mkrai has joined #openstack-nova | 14:16 | |
| *** ociuhandu has joined #openstack-nova | 14:17 | |
| mriedem | @mock.patch('nova.objects.CellMapping.get_by_uuid', side_effect=exception.CellMappingNotFound('uuid') | 14:17 |
| mriedem | something like that as a decorator to the test case method | 14:18 |
| openstackgerrit | Merged openstack/nova master: Combine the limits policies in single place https://review.opendev.org/715678 | 14:20 |
| *** N3l1x has joined #openstack-nova | 14:26 | |
| nightmare_unreal | Thanks !! | 14:28 |
| *** mkrai has quit IRC | 14:29 | |
| *** ociuhandu has quit IRC | 14:34 | |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 14:35 |
| dansmith | brinzhang_: are you working on feedback on the PUT patch? | 14:35 |
| francoisp | stephenfin, just to draw your attention, I answered your last question on https://review.opendev.org/#/c/669674/10 - thanks! | 14:41 |
| stephenfin | ack | 14:42 |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Calculate over_committed_disk_size for raw instances https://review.opendev.org/717037 | 14:48 |
| *** ttsiouts has quit IRC | 14:49 | |
| *** macz_ has joined #openstack-nova | 14:55 | |
| *** mkrai has joined #openstack-nova | 15:00 | |
| *** links has quit IRC | 15:03 | |
| *** david-lyle has quit IRC | 15:08 | |
| *** dklyle has joined #openstack-nova | 15:08 | |
| *** ttsiouts has joined #openstack-nova | 15:08 | |
| *** gyee has joined #openstack-nova | 15:11 | |
| *** mlavalle has joined #openstack-nova | 15:16 | |
| *** ociuhandu has joined #openstack-nova | 15:18 | |
| *** mkrai has quit IRC | 15:22 | |
| *** ociuhandu has quit IRC | 15:23 | |
| *** mkrai has joined #openstack-nova | 15:31 | |
| *** ociuhandu has joined #openstack-nova | 15:34 | |
| *** avolkov has quit IRC | 15:36 | |
| gmann | melwitt: that is correct. I need to propose some ideas on warning disable on oslo side what discussed with lbragstad. But yes all these are planed before FF. I am hoping to finish the policy things first by this Sat or Sunday. | 15:38 |
| *** ttsiouts has quit IRC | 15:46 | |
| *** ttsiouts has joined #openstack-nova | 15:48 | |
| gibi | nova meeting starts in 10 minutes on #openstack-meeting-3 | 15:50 |
| bauzas | melwitt: sorry I didn't had time yet to review your nova-manage patches, is it still worth it given the -W ? | 15:50 |
| dansmith | gibi: fyi, I'm running final tests on a change to that PUT patch to address just the critical bits of alex_xu's review | 15:50 |
| bauzas | but of course I'll do it if you want | 15:50 |
| *** mkrai has quit IRC | 15:50 | |
| dansmith | didn't get a response from brinzhang_ so I assume he's not working on it right now | 15:51 |
| gibi | dansmith: ack. thanks | 15:52 |
| *** tesseract-RH has quit IRC | 15:55 | |
| *** rpittau is now known as rpittau|afk | 15:56 | |
| gmann | dansmith: gibi also we need to add schema tests coverage for None to verify those things. | 15:58 |
| dansmith | gmann: I'm changing how those checks work, which might mean not | 15:59 |
| dansmith | device_name appears to be nullable at least, in the schema and in the db | 15:59 |
| dansmith | the others are all separate definitions I think | 16:00 |
| gmann | yeah, other does not allow None from schema only device do. | 16:01 |
| *** dtantsur|brb is now known as dtantsur | 16:01 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/716984 | 16:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix assertEqual param order in Accelerator tests https://review.opendev.org/717069 | 16:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Stabilize functional tests https://review.opendev.org/717070 | 16:02 |
| *** ttsiouts has quit IRC | 16:04 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828 | 16:04 |
| dansmith | gmann: ^ | 16:04 |
| gmann | thanks checking | 16:05 |
| tosky | for stable maintainers: this last review should remove any reference to legacy-tempest-dsvm-full-devstack-plugin-nfs (then we are doing the same in Cinder): https://review.opendev.org/#/c/714958/ | 16:08 |
| gmann | dansmith: do not we nee do check dot with old value vefore change - https://review.opendev.org/#/c/693828/25..26/nova/api/openstack/compute/volumes.py@460 | 16:08 |
| gmann | before | 16:08 |
| dansmith | gmann: why? we sad that if you PUT with no changes it's not an error right? | 16:08 |
| dansmith | technically BDM should not be doing a db save if there are no changes, but not all objects do that properly.. but either way, no reason to just add more to the conditional really | 16:09 |
| gmann | dansmith: yeah but when we add policy in next patch that become difficult to handle on "update request" vs "no change means not update request" | 16:10 |
| dansmith | gmann: I don't follow | 16:10 |
| gmann | in case of "swap + update" - we consider request is for update only when value is changed right. if value is same then we need to consider no update request and it is onyl swap | 16:11 |
| gmann | in that case, how we can check the update policy so that that policy is being checked only when request is update (means value change) | 16:11 |
| dansmith | in 2.85 we should only consider it a swap if volumeId is changed | 16:12 |
| gmann | but we support swap + update together also | 16:12 |
| dansmith | i.e. only check the stricter policy if volumeId is changed, otherwise we check the regular PUT policy | 16:12 |
| gmann | >2.85 | 16:12 |
| dansmith | the swap policy should imply you can also change the other values right? | 16:12 |
| gmann | yeah and checking regular PUT policy when value is same is wrong. | 16:12 |
| dansmith | I disagre | 16:13 |
| gmann | we want to allow update for non-admin | 16:13 |
| dansmith | if volumeId is changed, we check the swap policy, else check PUT policy | 16:13 |
| gmann | let me rephrase | 16:13 |
| dansmith | in this patch it's all one policy, and the next patch splits them into two | 16:14 |
| gmann | ok, we can discuss in next patch but there question was - we should not check the PUT policy if request is swap only not update. | 16:16 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 16:16 |
| gmann | knowing it is 'not update' is only done by if value is changed | 16:17 |
| dansmith | gmann: and like I said, I think >=2.85, we should only ever consider something a swap if the volumeId changed, otherwise it's a put, even if *nothing* changed | 16:17 |
| gmann | dansmith: that is question actually. if nothing changes should we consider that as update request ? especially when we allow people to replicate the PUT and change only volumeId fir swap | 16:18 |
| gmann | if do so then we endup checking two (PUT and SWAP) policy for swap | 16:18 |
| dansmith | I strongly feel that going forward this should behave like a regular PUT, where you can PUT with no changes all the time, | 16:19 |
| dansmith | and only check the swap policy if you're actually changing the volume | 16:19 |
| dansmith | I don't see how anything else makes sense | 16:19 |
| gmann | dansmith: yeah +1 on 'only check the swap policy if you're actually changing the volume'. but this became hard to implement with no value check of dot. | 16:21 |
| gmann | i think if you rebase the policy patch then it will be clear. | 16:22 |
| dansmith | okay I don't see what the value of dot has to do with which policy gets checked | 16:22 |
| gmann | policy stuff is a challenge here | 16:22 |
| bauzas | gibi: if you don' mind, I would appreciate https://blueprints.launchpad.net/nova/+spec/vgpu-multiple-types to be targeted for ussuri-3 | 16:22 |
| dansmith | gmann: do you not agree that if you have swap permissions, you should also be able to change dot? | 16:23 |
| bauzas | the patches in question are small | 16:23 |
| gmann | dansmith: that is fine but vice versa should not | 16:23 |
| gmann | dansmith: here - https://review.opendev.org/#/c/711194/11..13/nova/api/openstack/compute/volumes.py@468 | 16:23 |
| gibi | bauzas: noted, I will update lauchpad after the meeting | 16:23 |
| gmann | otherwise we end up doing PUT policy check always | 16:23 |
| bauzas | gibi: thanks | 16:24 |
| dansmith | gmann: right but as stephen (and now I) say there, that's the wrong place to check policy | 16:24 |
| dansmith | gmann: we should check at the beginning of update(), either the PUT or PUT-with-swap policy based on whether or not volumeId is changed.. it should be very simple if..else | 16:24 |
| dansmith | gmann: anyway, once the base patch looks like it's +2 I will rebase the policy patch (or help brinzhang_ ) and we can discuss/argue the policy bit on that | 16:25 |
| *** udesale_ has quit IRC | 16:26 | |
| gmann | dansmith: ok. after rebase it will be more clear. But i think i got your point of swap policy supersede the PUT policy | 16:27 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828 | 16:27 |
| dansmith | gmann: ack | 16:27 |
| dansmith | gmann: ^ that removes one more thing alex asked about that I forgot | 16:27 |
| gmann | ok | 16:27 |
| dansmith | gmann: sorry if it got lost in the policy discussion, but... is there still a need to change the schema for null-ness? | 16:28 |
| gmann | with 'x in attr' check, it is not needed | 16:29 |
| dansmith | gmann: okay cool | 16:29 |
| stephenfin | dansmith: off the top of your head, obj_from_primitive is called whenever we pull an o.vo from the DB, yeah? | 16:31 |
| dansmith | stephenfin: for serialized objects | 16:31 |
| bauzas | artom: FWIW, I left the bare minimum in the etherpad for your OSC concerns, the floor is yours :p | 16:36 |
| bauzas | artom: https://etherpad.openstack.org/p/nova-victoria-ptg | 16:36 |
| artom | bauzas, OK | 16:36 |
| *** evrardjp has quit IRC | 16:36 | |
| artom | bauzas, I'll proll'y just be lazy and harass mordred | 16:36 |
| *** evrardjp has joined #openstack-nova | 16:36 | |
| bauzas | I think the problem isn't the design as I said | 16:37 |
| artom | About where any new microversion-enabling client code should go | 16:37 |
| bauzas | we discussed it so many times | 16:37 |
| bauzas | I think we just need hands | 16:37 |
| artom | bauzas, well that's the point, right? We already say "if you're adding a new microversion, you must provide the novaclient patch" | 16:37 |
| artom | Not we'll be saying "and you also need to provide the osdk patch" | 16:37 |
| bauzas | artom: it's more complicated than that | 16:37 |
| artom | If osdk is indeed the correct place | 16:37 |
| bauzas | artom: if you're about to propose, say 2.81 | 16:37 |
| * mordred waves | 16:38 | |
| bauzas | artom: then you also need to make sure that <2.81 works too | 16:38 |
| bauzas | and then you signed-off for doing all the stuff, yay | 16:38 |
| artom | bauzas, oh, because of the gap | 16:38 |
| artom | *sigh* | 16:38 |
| artom | Yeah ok, I get it | 16:38 |
| mordred | well - once we reach steady-state making sure <2.81 works too should be pretty easy | 16:38 |
| artom | mordred, what does steady-state mean in this context? | 16:39 |
| mordred | that said - if we can just start getting folks to submit an osdk patch wehn new microversions are made so we can start tracking new things, we can use those as opportunities to fill in old stuff - and I'm happy to help do that | 16:39 |
| *** ttsiouts has joined #openstack-nova | 16:39 | |
| artom | mordred, I think I'd like that - we have to start somewhere | 16:39 |
| mordred | artom: I mean havig filled in the support for the existing old microversions | 16:39 |
| artom | mordred, ah, that was the thing that mriedem started | 16:40 |
| mordred | most of the time when someone says "I want to support microversion vX" - it turns out ot be quite easy | 16:40 |
| artom | Well, started driving | 16:40 |
| mordred | yeah | 16:40 |
| mordred | but - there's a bunch we need to walk through and make sure we understand :) | 16:40 |
| artom | mordred, in terms of how the Nova API works? | 16:40 |
| mordred | yeah- many of them wind up being no-ops from sdk point of view | 16:40 |
| mordred | but it's good to go look at the MV and say "yup, nothing to do | 16:41 |
| artom | mordred, ah, for example for things like new fields in responses? sdk just shows them with no added logic | 16:41 |
| artom | (Right?) | 16:41 |
| gmann | yeah, like adding the field in response is same list | 16:41 |
| mordred | yeah, well, we need to add new fields when they're added | 16:42 |
| mordred | but - we already are up to date with most fields as of like the mid-2.4x or 2.5x - just not labeled that way | 16:42 |
| mordred | so for many of them we're already caught up :) | 16:42 |
| mordred | and for new ones adding support is _usually_ very trivial - one or two lines | 16:42 |
| mordred | the behavior breaks - like changing live migration - those take some real thought | 16:43 |
| mordred | but - those require real thought to do the feature too | 16:43 |
| artom | Yeah, the live migration thing was ugly | 16:44 |
| artom | But let's not revisit that :) | 16:44 |
| gmann | is it not we need to bump the python-novaclint version on OSC because we maintain the MAX_VERSION there and increase when no change needed | 16:44 |
| mordred | yeah. but - that's one of the ones where I'm quite happy with our support | 16:44 |
| mriedem | in my experience adding feature parity for compute API microversions to OSC, for example, is not always so trivial, especially when the people reviewing the changes aren't from the nova team or aren't familiar with how the API works | 16:45 |
| gmann | +1 | 16:46 |
| mordred | I agree - although I'd like to make progress on changing that :) | 16:46 |
| artom | mordred, alright, we'll probably talk this over at the PTG again, but the initial "action item" of "require sdk patch, use as opportunity to catch up a bit" makes sense to me | 16:46 |
| mriedem | so random person throws up a change and the OSC team just basically trusts that it's correct from an API POV and then their review is based on UX standards for OSC | 16:46 |
| mriedem | mordred: there was progress while i was pushing it from the nova team, but ... | 16:46 |
| mriedem | someone needs to fill those shoes | 16:46 |
| artom | Yeah, having someone from the project reviewing the change should be a must | 16:46 |
| mordred | mriedem: we just need to clone you | 16:46 |
| artom | Doesn't have to be core | 16:47 |
| gmann | I can volunteer for that | 16:47 |
| artom | Like, I feel I have a good enough handle on it to give +1s | 16:47 |
| artom | (Or -1s) | 16:47 |
| mriedem | no it doesn't have to be a core, but it's good to be familiar with the actual API change and spec and all that | 16:47 |
| artom | ... which I never did, so mea culpa, I guess | 16:47 |
| mriedem | and the people that review API changes and specs are ... usually cores | 16:47 |
| artom | Well, assuming the api-ref is correct and complete, that's good enough doc, no? | 16:48 |
| mriedem | anyway, if the api side core review enforces good docs / api ref then anyone should be able to review the client side changes | 16:48 |
| mriedem | jinx | 16:48 |
| artom | And if you review the sdk change, look at the api-ref, and can't grok if it makes sense or not, it means we've failed at api-ref | 16:48 |
| mriedem | lots of ifs | 16:48 |
| artom | And butts | 16:49 |
| artom | (Sorry) | 16:49 |
| mriedem | candy and nuts | 16:49 |
| gmann | mriedem: how you do, monitoring yourself or osc team add as reviewer etc ? | 16:49 |
| gmann | you did | 16:49 |
| mriedem | i'd have to find my old etherpad that was tracking the compute API microversion gaps in OSC | 16:49 |
| mriedem | but that's usually how i'd track things, then once there was a review up i'd add myself as reviewer yeah | 16:50 |
| mriedem | i also just started making the changes myself | 16:50 |
| artom | https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps ? | 16:50 |
| gmann | ohk, i know that etherpad. | 16:50 |
| mriedem | then was made OSC core about a month before i left :) | 16:50 |
| mriedem | artom: close: https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc | 16:50 |
| *** rambo_li has joined #openstack-nova | 16:51 | |
| mriedem | note the gap continues to widen, | 16:51 |
| mriedem | and we're not tracking the last few new microversions in there | 16:52 |
| *** ociuhandu has quit IRC | 16:52 | |
| artom | Yeah, that's what prompted by question | 16:52 |
| artom | We're adding new mvs, but not requiring changes to sdk | 16:52 |
| artom | It's a battle we can't win | 16:52 |
| mriedem | just takes someone that cares and discipline | 16:52 |
| artom | So better just give up then, right? | 16:53 |
| mriedem | sure | 16:53 |
| *** ttsiouts has quit IRC | 16:54 | |
| *** dtantsur is now known as dtantsur|afk | 16:59 | |
| artom | sean-k-mooney, tbh I wasn't really planning on attending those - ML is fine with me | 17:00 |
| artom | I can share the info, but don't feel like taking on planning tasks | 17:00 |
| artom | That's TC's job, and I have no TC ambitions | 17:01 |
| artom | (Or whatever other committee handles that) | 17:02 |
| bauzas | artom: well, the problem is that lots of operators (including the ones that are getting a certain product from a big red company) are told to use OSC by the documentation | 17:03 |
| bauzas | which is fine if you wanna have a stable and interoperable experience | 17:03 |
| bauzas | (eg. with public clouds) | 17:03 |
| sean-k-mooney | artom: well the indivugal teams normlaly work out the detailed timetable | 17:04 |
| mriedem | osc isn't only good for that, | 17:04 |
| mriedem | a unified CLI is important for new users to openstack, even if it's just your private cloud | 17:04 |
| sean-k-mooney | so i dont expect the tc to do that just beasue it now virutal | 17:04 |
| mriedem | needing to install and learn 10 different python-*client project CLIs sucks | 17:04 |
| sean-k-mooney | yep i agreee with ^ | 17:04 |
| mriedem | all with their own options and command structure | 17:04 |
| bauzas | I'm just saying that a company that provides top-notch features to their customers and provide internal docs about using OSC should also care about making sure OSC is workable for those top-notch featureds | 17:05 |
| artom | bauzas, yeah, that's an argument for centralizing on osc/sdk and eventually getting rid of novaclient altogether :) | 17:05 |
| dansmith | mriedem: I agree with that in principle of course, but I don't know that I agree that osc is currently better | 17:05 |
| artom | Which is what we're doing :) | 17:05 |
| sean-k-mooney | which compay might that be ? :P and yes | 17:05 |
| mriedem | dansmith: not until someone works to make it better | 17:05 |
| mriedem | e.g. the bfv gaps | 17:05 |
| mriedem | live migration sucking ass | 17:05 |
| dansmith | yep, as long as that's in the mix | 17:05 |
| bauzas | I personnally gave up with this. | 17:06 |
| dansmith | mriedem: and all the version override hacks you have to do to do anything | 17:06 |
| mriedem | yup the version discovery is way better in nova cli | 17:06 |
| mriedem | s/way better/exists/ | 17:06 |
| sean-k-mooney | mriedem: i do think that if you use an option that requries a min cli you should not have to specify it with osc like you do today | 17:07 |
| dansmith | tbh I've seen less confusion from the different project clients than I have from people wondering how they're supposed to know when to use a given version to do something in nova | 17:07 |
| mriedem | sean-k-mooney: that's shade or oaktree or whatever mordred had before | 17:07 |
| sean-k-mooney | but im not sure the bevhior of nova cli always using latest is actully good | 17:07 |
| mriedem | "the nova cli is not a bash sdk" | 17:07 |
| dansmith | you can run fooclient --help and bumble the way through a thing, but you can't do that with osc help because you don't have the magic version decoder ring | 17:08 |
| mriedem | the osc help should tell you what version is needed to do things, | 17:08 |
| *** martinkennelly has quit IRC | 17:08 | |
| mriedem | but that's been a gap in people reviewing and enforcing those osc changes | 17:08 |
| sean-k-mooney | dansmith: ya its both better and worse that it show you the help for the microversion you specify | 17:08 |
| sean-k-mooney | if you dont know the microverion exits your screwed | 17:08 |
| *** martinkennelly has joined #openstack-nova | 17:09 | |
| dansmith | mriedem: okay I've literally never seen that on a help, but maybe because the things I needed didn't have it | 17:09 |
| mriedem | e.g. https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-event.html#server-event-show | 17:09 |
| mriedem | part of the gaps closure in that etherpad is just adding stuff like that to the help | 17:09 |
| dansmith | mriedem: oh that's in the docs not in the --help? | 17:09 |
| mriedem | same | 17:09 |
| mriedem | docs are generated from the help | 17:10 |
| mriedem | like osc-placement | 17:10 |
| dansmith | okay well, I've never seen it in the help for things I was looking at, but okay | 17:10 |
| mriedem | another example for 2.73 that tssurya added https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-lock | 17:10 |
| mriedem | yeah it's a constant fight to make sure people remember to add those, | 17:11 |
| mriedem | and get people to backfill them | 17:11 |
| mriedem | hence the etherpad | 17:11 |
| dansmith | in that one page, one says "use version X" and another says "use version X by passing --this-complicated-arg-thing" | 17:11 |
| dansmith | but yeah, it would definitely be better if that was all consistent enough to rely on | 17:11 |
| rambo_li | Excuse me, sean-k-mooney ralonsoh Please Let’s talk about the bug here: | 17:12 |
| rambo_li | https://bugs.launchpad.net/neutron/+bug/1815989 And what is our plan to solve this bug? | 17:12 |
| openstack | Launchpad bug 1815989 in OpenStack Compute (nova) "OVS drops RARP packets by QEMU upon live-migration causes up to 40s ping pause in Rocky" [Medium,In progress] - Assigned to sean mooney (sean-k-mooney) | 17:12 |
| dansmith | I'm not helping so I know I can't complain too much, but in the current state of the world, I don't see osc as better | 17:12 |
| mordred | mriedem: fwiw - I want to completely change what the version story is in osc - and I agree with sean-k-mooney - I do not think you should have to specify a min version on the cli | 17:13 |
| sean-k-mooney | rambo_li: at the moment im not working on it, the patch i submited shoudl fix it but they dont work anymore due to rebases and refacoting | 17:13 |
| mordred | it is that way for hysterical raisins and I think those raisins are no longer useful to us | 17:13 |
| sean-k-mooney | mordred: if we default to oldest that support feature ex it keeps the stablity and if you want the new behavior you ask for it | 17:14 |
| mordred | I am planning on writing something up so we can discuss it around PTG time to make sure it meets what people are wanting | 17:14 |
| *** ttsiouts has joined #openstack-nova | 17:14 | |
| sean-k-mooney | but we dont do that today in many cases we say to use option x you need to pass version y | 17:14 |
| sean-k-mooney | i have noticed that lately with osc-placment when trying ot use some operation but im sure we have the same behviaor in the nova supprot in osc | 17:15 |
| mordred | right - I think there's actually a third option which can be more aggressive about new things while not breaking people - but I need to write it up | 17:15 |
| mordred | from my end-user pov - if I *ever* have to give osc a version for a reason other than "I am a developer debugging the rest api" something has completely failed | 17:16 |
| *** artom has quit IRC | 17:16 | |
| dansmith | mordred: ++ | 17:16 |
| mordred | which is not to say that this failure isn't happening consistently today :) | 17:16 |
| *** artom has joined #openstack-nova | 17:16 | |
| mordred | but - it's a failure from an UX perspective and I want to fix it | 17:16 |
| mordred | s/want/am going to/ | 17:16 |
| mordred | I will know I'm successful when everyone here thinks it's behaving properly ;) | 17:17 |
| dansmith | "if you've ever had to pass a version to OSC in the last six months, you get an ATC pass to the summit" | 17:17 |
| mordred | dansmith: ++ | 17:17 |
| sean-k-mooney | mordred: you will have to get the ironic folks on board too | 17:18 |
| sean-k-mooney | mordred: sicne they went ahead and impleemnted the same version negoction logic in there plugin they had in the legacy client | 17:18 |
| mordred | sean-k-mooney: yeah - I've already got good ironic support done by the ironic team in sdk though - so I think I'm closer with them | 17:19 |
| sean-k-mooney | mordred: i think one thing to condiser is moveing everything after nova v2.0 out of osc and into a nova plugin | 17:19 |
| mordred | I want to get rid of all plugins | 17:19 |
| sean-k-mooney | mordred: well part of the issue currently is geting things landed in osc | 17:20 |
| mordred | right. that's based on the past - we're making some massive changes | 17:20 |
| sean-k-mooney | so project wich plugisn could make progress but "core" project had an issue | 17:20 |
| mordred | so - gimme a little bit to let those changes percolate | 17:20 |
| sean-k-mooney | sure im glad the sdk and ocs team are combined/combinging | 17:20 |
| *** martinkennelly has quit IRC | 17:24 | |
| *** rambo_li has quit IRC | 17:24 | |
| *** nightmare_unreal has quit IRC | 17:27 | |
| *** KeithMnemonic has joined #openstack-nova | 17:28 | |
| *** martinkennelly has joined #openstack-nova | 17:28 | |
| sean-k-mooney | mordred: honestly if we could deprecate the nova clinet and deliver changes as easily as we can today to osc for V that would be awsome but there are still a long list of gaps to close before that is realistic | 17:31 |
| *** ociuhandu has joined #openstack-nova | 17:32 | |
| artom | sean-k-mooney, I don't think anyone disagrees - but to paraphrase mriedem, and directly quote Nike, "just do it" :) | 17:33 |
| *** ociuhandu has quit IRC | 17:36 | |
| mordred | sean-k-mooney: I agree ... but I'm going to make a concerted push to see how many of those gaps I can close and how much I can ease the situation | 17:37 |
| mordred | might not work, obviously- but otoh - getting novaclient parity and being able to deprecate it would be a _huge_ step forward in terms of gravity, so I think it's worth extra attention | 17:38 |
| *** sapd1 has quit IRC | 17:38 | |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server diagnostics policies https://review.opendev.org/716800 | 17:39 |
| sean-k-mooney | well i almost never need to use nova client for day to day things but it does happen. | 17:40 |
| sean-k-mooney | i should really just chagne https://review.opendev.org/#/c/643578/ back to evacuate too | 17:40 |
| sean-k-mooney | mordred: should i just abandon ^ by the way or if i rebase it and change the command back to evacuate will it get reviews | 17:44 |
| sean-k-mooney | i kindof gave up on this since i was hoping it would be a non contoversionl quick gap to close and it ended up being the opisite | 17:44 |
| mordred | sean-k-mooney: I will totally review it | 17:51 |
| mordred | actually. lemme read the scrollback on it real quick | 17:51 |
| sean-k-mooney | mordred: context was at the fourm sesseion we express frustration that evacuate did not match with peopel expcations of keeping data at least not unless you are on shared storage | 17:53 |
| sean-k-mooney | so it was suggested to change the name to resurect or recreate | 17:53 |
| sean-k-mooney | so i did but there is also the consernt that using a different name | 17:53 |
| sean-k-mooney | would confuse people that think its somehting new or different | 17:54 |
| mordred | sean-k-mooney: hrm. well - I like the idea of the term ressurrect | 17:54 |
| mordred | (for all the reasons you mention in the patch) | 17:54 |
| sean-k-mooney | i kind of feel like we should really change how the api works | 17:55 |
| sean-k-mooney | and then have two seperate commands | 17:55 |
| mordred | sean-k-mooney: I kinda want it to be resurrect and then just have evacuate work as an alias for it - so that people with muscle memory will get what they're expecting, but new people will learn something new | 17:55 |
| mordred | or maybe that | 17:55 |
| sean-k-mooney | one that will always preserve your data and refuse to work if not on shared stroate | 17:55 |
| sean-k-mooney | and one that always recretes the vm | 17:56 |
| sean-k-mooney | basicaly just rebuild on a differnet host | 17:56 |
| mordred | yeah - but with the same volumes and ports | 17:56 |
| sean-k-mooney | ya so litrally rebuild on different host reimabing the root disk | 17:56 |
| sean-k-mooney | *reimageing | 17:56 |
| sean-k-mooney | see its tricky and once its in a cli we cant really remove it | 17:58 |
| *** ccamacho has quit IRC | 18:13 | |
| *** maciejjozefczyk has quit IRC | 18:20 | |
| *** ralonsoh has quit IRC | 18:28 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server diagnostics https://review.opendev.org/716803 | 18:30 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server diagnostics policies https://review.opendev.org/716805 | 18:39 |
| openstackgerrit | Merged openstack/nova master: func tests: move _run_periodics() into base class https://review.opendev.org/714228 | 18:39 |
| openstackgerrit | Merged openstack/nova master: tests: work around malformed serial XML https://review.opendev.org/705546 | 18:39 |
| *** tbachman has quit IRC | 19:14 | |
| *** tbachman has joined #openstack-nova | 19:16 | |
| *** ociuhandu has joined #openstack-nova | 19:52 | |
| _erlon_ | bauzas: ping | 19:55 |
| _erlon_ | bauzas: so, you mentioned that there is a way to add a custom filter without having to change the egg files? | 19:56 |
| *** ttsiouts has quit IRC | 19:56 | |
| *** ociuhandu has quit IRC | 20:02 | |
| *** ociuhandu has joined #openstack-nova | 20:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 20:07 |
| *** ociuhandu has quit IRC | 20:07 | |
| mriedem | hello nova cores, ^ is pretty simple and would be nice to get in before that stuff is all refactored to nova-audit | 20:07 |
| artom | _erlon_, since bauzas is in France is done for the day, maybe https://docs.openstack.org/nova/latest/user/filter-scheduler.html#writing-your-own-filter can help you? | 20:36 |
| *** iurygregory has quit IRC | 20:38 | |
| *** iurygregory has joined #openstack-nova | 20:39 | |
| _erlon_ | artom: hey, thanks for helping, my question was more about the import error that I was getting the last time I tried to add a class that was not in the built in filters | 20:39 |
| _erlon_ | artom: let's say I create a new file my_filter.py, with TheFilter, inside. If I put my_filter,py inside the nova/scheduler/filters, and change enabled_filters=+TheFilter, it use to give me an import error | 20:42 |
| _erlon_ | artom: so, we needed to add an entry_point in the nova-egg | 20:42 |
| *** nweinber has quit IRC | 20:44 | |
| *** ttsiouts has joined #openstack-nova | 20:45 | |
| *** ttsiouts_ has joined #openstack-nova | 20:46 | |
| *** ttsiouts has quit IRC | 20:49 | |
| mordred | _erlon_: don't put it in nova/scheduler/filters - check that link | 21:01 |
| *** ociuhandu has joined #openstack-nova | 21:02 | |
| *** igordc has joined #openstack-nova | 21:05 | |
| *** xek has quit IRC | 21:05 | |
| *** ociuhandu has quit IRC | 21:06 | |
| _erlon_ | mordred: got it! As he puts in the config file, isnt that overwriting the default available filters? | 21:07 |
| _erlon_ | see that thereis 2 instances under the same stanza: | 21:07 |
| _erlon_ | [filter_scheduler] | 21:07 |
| _erlon_ | available_filters = nova.scheduler.filters.all_filters | 21:07 |
| _erlon_ | available_filters = myfilter.MyFilter | 21:07 |
| *** slaweq has quit IRC | 21:07 | |
| mriedem | no, it's multi-valued https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.available_filters | 21:09 |
| *** iurygregory has quit IRC | 21:12 | |
| *** dpawlik has quit IRC | 21:12 | |
| *** slaweq has joined #openstack-nova | 21:14 | |
| *** slaweq has quit IRC | 21:26 | |
| *** lbragstad has quit IRC | 21:27 | |
| *** brinzhang has joined #openstack-nova | 21:34 | |
| *** lbragstad has joined #openstack-nova | 21:35 | |
| *** brinzhang_ has quit IRC | 21:37 | |
| *** mriedem has left #openstack-nova | 21:38 | |
| *** rcernin has joined #openstack-nova | 22:22 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing limits policies https://review.opendev.org/715674 | 22:23 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Correct security groups policy check_str https://review.opendev.org/716782 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage db purge to nova-audit https://review.opendev.org/708783 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage db archive_deleted_rows to nova-audit https://review.opendev.org/708784 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage cell_v2 discover_hosts to nova-manage https://review.opendev.org/708785 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage cell_v2 map_instances to nova-audit https://review.opendev.org/708786 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage placement sync_aggregates to nova-audit https://review.opendev.org/708787 | 22:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit https://review.opendev.org/708788 | 22:29 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in limits policy https://review.opendev.org/715680 | 22:37 |
| *** ttsiouts_ has quit IRC | 22:38 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in limits policies https://review.opendev.org/715760 | 22:43 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 22:48 |
| *** openstackstatus has quit IRC | 22:56 | |
| *** openstack has joined #openstack-nova | 22:58 | |
| *** ChanServ sets mode: +o openstack | 22:58 | |
| *** macz_ has quit IRC | 22:59 | |
| *** tosky has quit IRC | 23:00 | |
| openstackgerrit | Merged openstack/nova master: FUP for Add a placement audit command https://review.opendev.org/715797 | 23:08 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in list migrations https://review.opendev.org/716141 | 23:08 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in migrations policies https://review.opendev.org/716145 | 23:08 |
| openstackgerrit | Merged openstack/nova master: Fix assertEqual param order in Accelerator tests https://review.opendev.org/717069 | 23:08 |
| *** brinzhang_ has joined #openstack-nova | 23:15 | |
| *** ttsiouts has joined #openstack-nova | 23:16 | |
| *** brinzhang has quit IRC | 23:18 | |
| *** ttsiouts has quit IRC | 23:21 | |
| *** martinkennelly has quit IRC | 23:21 | |
| *** gyee has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!