| *** TxGirlGeek has quit IRC | 00:22 | |
| *** artom has quit IRC | 00:32 | |
| *** artom has joined #openstack-nova | 00:35 | |
| *** ociuhandu has joined #openstack-nova | 00:44 | |
| *** tosky has quit IRC | 00:46 | |
| *** Liang__ has joined #openstack-nova | 00:48 | |
| *** ociuhandu has quit IRC | 00:49 | |
| *** lbragstad has joined #openstack-nova | 00:49 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 00:55 |
|---|---|---|
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Refine and introduce correct parameters for test_get_guest_config_numa_host_instance_topo_cpu_pinning https://review.opendev.org/713351 | 00:55 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: scheduler: Introduce 'dedicated' and 'sharing' CPUs for InstanceNUMACell https://review.opendev.org/713352 | 00:55 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Derive 'cpu_pinning_requested' property from cpu_policy https://review.opendev.org/713353 | 00:55 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'MIXED' CPU allocation policy for instance https://review.opendev.org/713354 | 00:55 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the interface of creating 'MIXED' policy instance through 'PCPU' and 'VCPU' https://review.opendev.org/713355 | 00:55 |
| *** nicolasbock has quit IRC | 01:04 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478 | 01:23 |
| openstack | bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929 | 01:23 |
| *** slaweq has joined #openstack-nova | 01:23 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478 | 01:27 |
| openstack | bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929 | 01:27 |
| *** slaweq has quit IRC | 01:28 | |
| *** lbragstad_ has joined #openstack-nova | 01:43 | |
| *** lbragstad has quit IRC | 01:45 | |
| *** kaisers_ has quit IRC | 02:13 | |
| *** boldo has joined #openstack-nova | 02:16 | |
| openstackgerrit | Merged openstack/nova master: Use fair locks in resource tracker https://review.opendev.org/711528 | 02:25 |
| openstackgerrit | Merged openstack/nova master: Ensures that COMPUTE_RESOURCE_SEMAPHORE usage is fair https://review.opendev.org/712674 | 02:25 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494 | 02:57 |
| *** mkrai has joined #openstack-nova | 03:09 | |
| *** lbragstad_ has quit IRC | 03:23 | |
| *** Liang__ has quit IRC | 03:34 | |
| *** Liang__ has joined #openstack-nova | 03:47 | |
| *** factor has quit IRC | 03:56 | |
| *** factor has joined #openstack-nova | 03:56 | |
| *** tetsuro has joined #openstack-nova | 03:59 | |
| *** sapd1 has quit IRC | 04:12 | |
| *** sapd1 has joined #openstack-nova | 04:12 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova master: DNM: Add reproducer for subunit parser error https://review.opendev.org/700522 | 04:20 |
| *** vishalmanchanda has joined #openstack-nova | 04:57 | |
| *** udesale has joined #openstack-nova | 04:57 | |
| *** mkrai has quit IRC | 05:08 | |
| *** mkrai_ has joined #openstack-nova | 05:08 | |
| *** links has joined #openstack-nova | 05:10 | |
| *** ratailor has joined #openstack-nova | 05:20 | |
| *** Liang__ has quit IRC | 05:24 | |
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #openstack-nova | 05:36 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494 | 05:50 |
| *** dklyle has quit IRC | 06:06 | |
| *** ociuhandu has joined #openstack-nova | 06:17 | |
| *** ociuhandu has quit IRC | 06:28 | |
| *** ociuhandu has joined #openstack-nova | 06:28 | |
| *** ociuhandu has quit IRC | 06:33 | |
| *** dpawlik has joined #openstack-nova | 06:57 | |
| *** damien_r has joined #openstack-nova | 07:24 | |
| *** dpawlik has quit IRC | 07:41 | |
| *** dpawlik has joined #openstack-nova | 07:42 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 07:47 |
| *** dpawlik has quit IRC | 07:48 | |
| *** ociuhandu has joined #openstack-nova | 07:49 | |
| *** lpetrut has joined #openstack-nova | 07:51 | |
| *** slaweq has joined #openstack-nova | 07:56 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:05 | |
| *** ccamacho has joined #openstack-nova | 08:06 | |
| *** maciejjozefczyk has quit IRC | 08:07 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:09 | |
| *** tkajinam has quit IRC | 08:15 | |
| *** tesseract has joined #openstack-nova | 08:17 | |
| *** dtantsur|afk is now known as dtantsur | 08:24 | |
| *** xek has joined #openstack-nova | 08:24 | |
| *** amoralej|off is now known as amoralej | 08:31 | |
| *** mkrai_ has quit IRC | 08:35 | |
| *** ociuhandu has quit IRC | 08:39 | |
| *** ociuhandu has joined #openstack-nova | 08:39 | |
| lyarwood | elod: https://review.opendev.org/#/c/713035/ - btw is finally stable, once on master I'll backport to stable/pike to hopefully resolve the issues with the LM job we've been seeing there. | 08:45 |
| lyarwood | ^ any non-RH core reviews would be appreicated btw so we can fix a few of the stable branches | 08:46 |
| lyarwood | doesn't appear to fail often on master but I'm assuming we get better test nodes somehow? | 08:46 |
| lyarwood | s/better/faster/g | 08:46 |
| elod | lyarwood: thanks! looking! | 08:54 |
| *** ociuhandu has quit IRC | 08:54 | |
| elod | gibi: can you also review that? ^^^ | 08:54 |
| lyarwood | thanks both! | 08:58 |
| *** priteau has joined #openstack-nova | 09:01 | |
| gibi | lyarwood: thanks for working on that | 09:02 |
| *** mkrai_ has joined #openstack-nova | 09:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384 | 09:11 |
| *** ociuhandu has joined #openstack-nova | 09:17 | |
| *** tosky has joined #openstack-nova | 09:18 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | 09:20 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Make serialize_args handle exception messages safely https://review.opendev.org/712697 | 09:20 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Store instance action event exc_val fault details https://review.opendev.org/694428 | 09:20 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430 | 09:20 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251 | 09:20 |
| gibi | elod, lyarwood: stable backport of a fix for a recent bugfix regression test https://review.opendev.org/#/c/713384/ | 09:21 |
| *** ociuhandu has quit IRC | 09:22 | |
| gibi | needs to properly unblock (other than recheck) https://review.opendev.org/#/c/713196/ | 09:22 |
| *** yaawang has quit IRC | 09:24 | |
| *** yaawang has joined #openstack-nova | 09:27 | |
| *** priteau has quit IRC | 09:31 | |
| brinzhang_ | gibi: Hi, the bp/action-event-fault-details is ready to review https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/action-event-fault-details | 09:38 |
| *** rpittau|afk is now known as rpittau | 09:38 | |
| gibi | brinzhang_: ack, I will try | 09:44 |
| gibi | to look at ti | 09:44 |
| gibi | it | 09:44 |
| brinzhang_ | gibi: cool, thanks | 09:44 |
| brinzhang_ | gibi: and about the bp/destroy-instance-with-datavolume feature, I hope you can add your list too, it's ready to review too. https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/destroy-instance-with-datavolume | 09:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/713388 | 09:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110 | 09:47 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856 | 09:47 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451 | 09:47 |
| gibi | brinzhang_: I can add but it will take time to get there | 09:48 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384 | 09:48 |
| brinzhang_ | gibi: yeah, I know, and it's ready too long, while you are free pls review :) | 09:49 |
| gibi | brinzhang_: could you try to ping others too? :) | 09:50 |
| brinzhang_ | and I will also ask stephenfin, sean-k-mooney, alex_xu, melwitt, lyarwood too. | 09:50 |
| *** tetsuro has quit IRC | 09:52 | |
| brinzhang_ | gibi: I dont know who can help me to review? I am not sure whether troulbes them :) | 09:53 |
| lyarwood | gibi: ack sorry I'll check that shortly | 09:54 |
| lyarwood | brinzhang_: ack working my way towards it :) | 09:55 |
| lyarwood | downstream-- | 09:55 |
| brinzhang_ | lyarwood: thanks | 09:55 |
| *** threestrands has quit IRC | 09:56 | |
| *** tetsuro has joined #openstack-nova | 09:56 | |
| brinzhang_ | bp/destroy-instance-with-datavolume https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/destroy-instance-with-datavolume | 09:56 |
| brinzhang_ | bp/action-event-fault-details https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/action-event-fault-details | 09:56 |
| *** tetsuro has quit IRC | 09:57 | |
| *** ociuhandu has joined #openstack-nova | 10:05 | |
| *** ociuhandu has quit IRC | 10:12 | |
| *** ociuhandu has joined #openstack-nova | 10:12 | |
| *** yaawang has quit IRC | 10:23 | |
| *** yaawang has joined #openstack-nova | 10:23 | |
| *** jraju__ has joined #openstack-nova | 10:28 | |
| *** links has quit IRC | 10:29 | |
| *** ociuhandu has quit IRC | 10:46 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834 | 10:47 |
| *** kaisers_ has joined #openstack-nova | 10:47 | |
| *** jraju__ has quit IRC | 10:53 | |
| *** kaisers_ has quit IRC | 10:54 | |
| *** ociuhandu has joined #openstack-nova | 10:54 | |
| *** mgariepy has quit IRC | 10:55 | |
| openstackgerrit | mashuting proposed openstack/nova master: Revert "Deprecate the vmwareapi driver" https://review.opendev.org/713401 | 10:55 |
| *** mkrai_ has quit IRC | 10:57 | |
| *** ociuhandu has quit IRC | 10:59 | |
| kashyap | lyarwood: Hi, what do you mean "Done" for the comment on line-1811? -- https://review.opendev.org/#/c/696834/8..9/nova/virt/libvirt/driver.py | 11:01 |
| lyarwood | kashyap: gah sorry miss click | 11:02 |
| kashyap | NP. | 11:02 |
| lyarwood | kashyap: there's no concept of a destination host in swap_volume, everything is confined to a single host. | 11:03 |
| lyarwood | kashyap: is that what you're referring to? | 11:03 |
| kashyap | lyarwood: Yeah, would be good to add a note of it, if you have a reason to respin | 11:04 |
| lyarwood | kashyap: for what? | 11:05 |
| lyarwood | kashyap: there comment is pretty clear, I don't understand what your point is. | 11:05 |
| *** nicolasbock has joined #openstack-nova | 11:05 | |
| kashyap | lyarwood: Well, "remote disks" imply storage is non-local | 11:06 |
| kashyap | So it isn't entirely evident for everyone reading the code. | 11:06 |
| *** ociuhandu has joined #openstack-nova | 11:07 | |
| lyarwood | kashyap: eh, so what would that have to do with a host check? | 11:07 |
| kashyap | But thanks for the remidner on swap_volume() being local; not sure what I was thinking there. | 11:08 |
| *** mgariepy has joined #openstack-nova | 11:08 | |
| lyarwood | kashyap: sorry I'm still failing to see your point here :) | 11:08 |
| kashyap | lyarwood: You're right in that, you answered my question of the host check being irrelvant in this case. And then I proceeded to comment on the comment :D | 11:08 |
| kashyap | Only adjust if you have a need to respin | 11:09 |
| lyarwood | kashyap: np ack thanks | 11:09 |
| *** ociuhandu has quit IRC | 11:18 | |
| *** ociuhandu has joined #openstack-nova | 11:29 | |
| *** mkrai_ has joined #openstack-nova | 11:33 | |
| *** rpittau is now known as rpittau|afk | 11:34 | |
| *** rpittau|afk is now known as rpittau|bbl | 11:34 | |
| *** nicolasbock has quit IRC | 11:34 | |
| *** ociuhandu has quit IRC | 11:34 | |
| *** tkajinam has joined #openstack-nova | 11:37 | |
| *** nicolasbock has joined #openstack-nova | 11:38 | |
| *** tkajinam has quit IRC | 11:39 | |
| *** tkajinam has joined #openstack-nova | 11:40 | |
| *** nicolasbock has quit IRC | 11:40 | |
| *** tkajinam has quit IRC | 11:41 | |
| gibi | lyarwood, stephenfin: went through both of the luksv1 patch series. I +2d most of it. but I don't feel confident about https://review.opendev.org/#/c/708029 | 11:48 |
| gibi | you can convince me to +A it by having some other cores review it thoroughly | 11:49 |
| *** tkajinam has joined #openstack-nova | 11:53 | |
| lyarwood | gibi: ack thanks, I'll try to pull some folks in on the RH side today | 11:56 |
| *** bbowen has quit IRC | 12:00 | |
| *** bbowen has joined #openstack-nova | 12:01 | |
| *** ociuhandu has joined #openstack-nova | 12:08 | |
| *** ociuhandu has quit IRC | 12:18 | |
| gibi | sean-k-mooney: I have questions in https://review.opendev.org/#/c/666915/ | 12:20 |
| * gibi goes to get something to eat | 12:21 | |
| *** rcernin has quit IRC | 12:26 | |
| *** ociuhandu has joined #openstack-nova | 12:33 | |
| *** nicolasbock has joined #openstack-nova | 12:42 | |
| *** damien_r has quit IRC | 12:47 | |
| *** damien_r has joined #openstack-nova | 12:47 | |
| *** nweinber has joined #openstack-nova | 12:49 | |
| *** rpittau|bbl is now known as rpittau | 12:51 | |
| *** udesale_ has joined #openstack-nova | 12:53 | |
| *** Luzi has joined #openstack-nova | 12:54 | |
| *** udesale has quit IRC | 12:55 | |
| *** mkrai_ has quit IRC | 13:02 | |
| *** dklyle has joined #openstack-nova | 13:03 | |
| *** ociuhandu has quit IRC | 13:07 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Switching new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | 13:09 |
| *** lbragstad_ has joined #openstack-nova | 13:10 | |
| *** amoralej is now known as amoralej|lunch | 13:13 | |
| lyarwood | stephenfin / melwitt: would you be able to review https://review.opendev.org/#/c/708030 & https://review.opendev.org/#/c/708029/ when you have a chance today? | 13:21 |
| *** yedongcan has joined #openstack-nova | 13:39 | |
| *** dave-mccowan has joined #openstack-nova | 13:40 | |
| *** ociuhandu has joined #openstack-nova | 13:43 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494 | 13:45 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: FUP I41b7c1653c6a887ee4b08e588c5d422409aebfba https://review.opendev.org/711262 | 13:47 |
| lyarwood | ^ trivial fup is anyone has time | 13:47 |
| *** eharney has joined #openstack-nova | 13:49 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679 | 13:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.83 allowing boot from volume rescue https://review.opendev.org/701430 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 13:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | 13:53 |
| *** ociuhandu has quit IRC | 13:54 | |
| *** ociuhandu has joined #openstack-nova | 13:55 | |
| *** ociuhandu has quit IRC | 13:58 | |
| *** MrWatson has quit IRC | 13:58 | |
| *** ociuhandu has joined #openstack-nova | 13:58 | |
| *** NostawRm has joined #openstack-nova | 13:59 | |
| *** mkrai has joined #openstack-nova | 14:00 | |
| dansmith | does anyone know if that third party CI status page is still up anywhere? I don't seem to be able to find it | 14:02 |
| dansmith | looks like zvm CI has been off the rails for a while as well | 14:02 |
| dansmith | failing changes and the logs are 404 | 14:02 |
| *** spotz has joined #openstack-nova | 14:14 | |
| *** amoralej|lunch is now known as amoralej | 14:15 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | 14:35 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | 14:35 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 14:35 |
| *** links has joined #openstack-nova | 14:35 | |
| *** links has quit IRC | 14:35 | |
| bauzas | dansmith: you meant tritri something ? | 14:35 |
| dansmith | bauzas: yeah | 14:36 |
| brinzhang_ | lyarwood: https://review.opendev.org/#/c/710965/8/nova/tests/functional/api_sample_tests/test_volumes.py I think this is not necessary, and I cannot get the response too. | 14:36 |
| brinzhang_ | lyarwood: In https://review.opendev.org/#/c/693828/19/nova/tests/unit/api/openstack/compute/test_volumes.py@1179 I update the unit test case, and assert the delete_on_termination after bdm.save(), I think it's enough, what do you think? | 14:38 |
| bauzas | dansmith: AFAIR it moved recently, trying to find the link | 14:38 |
| bauzas | it was something like [[local|localrc]] | 14:40 |
| bauzas | ADMIN_PASSWORD=secret | 14:40 |
| bauzas | DATABASE_PASSWORD=$ADMIN_PASSWORD | 14:40 |
| bauzas | RABBIT_PASSWORD=$ADMIN_PASSWORD | 14:40 |
| bauzas | SERVICE_PASSWORD=$ADMIN_PASSWORD | 14:40 |
| bauzas | oh shit | 14:40 |
| bauzas | openstack-ci.tintri.com | 14:40 |
| bauzas | dansmith: but it's no longer responding | 14:40 |
| dansmith | ack, yeah | 14:41 |
| lyarwood | bauzas: just updated with a comment, we should be able to get the updated attachment from the fixture | 14:45 |
| lyarwood | ah sorry | 14:45 |
| lyarwood | brinzhang_: ^ tab-- | 14:45 |
| brinzhang_ | lyarwood: I will check again | 14:47 |
| lyarwood | brinzhang_: actually ignore that this isn't a fixture, it's n-api. | 14:47 |
| lyarwood | brinzhang_: we should be able to test this directly | 14:47 |
| *** gmann is now known as gmann_afk | 14:48 | |
| *** tkajinam has quit IRC | 14:48 | |
| brinzhang_ | lyarwood: yeas, I think I know what should I do, will update ^^ | 14:49 |
| lyarwood | brinzhang_: excellent thanks | 14:50 |
| brinzhang_ | lyarwood: np, thanks too. | 14:50 |
| *** ratailor has quit IRC | 14:55 | |
| openstackgerrit | Merged openstack/nova master: Clarify fitting hugepages log message https://review.opendev.org/702981 | 14:56 |
| *** ociuhandu has quit IRC | 14:56 | |
| *** dtantsur is now known as dtantsur|brb | 15:00 | |
| *** yedongcan has quit IRC | 15:00 | |
| *** ociuhandu has joined #openstack-nova | 15:01 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.82 - nova cyborg interaction https://review.opendev.org/712700 | 15:04 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 15:05 |
| *** yedongcan has joined #openstack-nova | 15:06 | |
| *** umbSublime has quit IRC | 15:07 | |
| brinzhang_ | lyarwood: done. Can you check is that rirht? | 15:08 |
| *** mlavalle has joined #openstack-nova | 15:08 | |
| *** umbSublime has joined #openstack-nova | 15:11 | |
| *** CeeMac has joined #openstack-nova | 15:11 | |
| lyarwood | brinzhang_: yup LGTM now, tested locally and it's passing. | 15:11 |
| *** yedongcan has left #openstack-nova | 15:11 | |
| brinzhang_ | lyarwood: thanks ^^ | 15:12 |
| *** lpetrut has quit IRC | 15:14 | |
| brinzhang_ | lyarwood: do you know Andrey Kurilin's irc name ? | 15:15 |
| brinzhang_ | lyarwood: I donot think we should add @api_versions.wraps("2.83") to https://review.opendev.org/#/c/712651/4/novaclient/v2/volumes.py@127 | 15:15 |
| brinzhang_ | lyarwood: the patch_server_volume() function is only one, is it need to add the @api_versions.wraps("2.83") to limit? | 15:16 |
| lyarwood | brinzhang_: I don't sorry | 15:17 |
| *** bbowen has quit IRC | 15:17 | |
| lyarwood | brinzhang_: yeah I thought you had done it correctly | 15:18 |
| lyarwood | brinzhang_: however create_server_volume appears to do it | 15:18 |
| bauzas | lyarwood: brinzhang_: https://launchpad.net/~andreykurilin | 15:19 |
| brinzhang_ | lyarwood: create_server_volume appears is there are some microversion added in it, so that need to add the api_version_wraps to limit it's microversion | 15:19 |
| lyarwood | ah I see | 15:20 |
| brinzhang_ | lyarwood: And the patch volume api just the only one to do, if there is another microversion need to add in the future, I think that add the wrap is ok | 15:21 |
| brinzhang_ | so I will keep it not limit by api_version_wraps, unless andreykurilin insists. | 15:22 |
| brinzhang_ | bauzas: thanks | 15:22 |
| *** bbowen has joined #openstack-nova | 15:25 | |
| brinzhang_ | andreykurilin: are you around? | 15:28 |
| *** priteau has joined #openstack-nova | 15:33 | |
| *** grandchild has joined #openstack-nova | 15:35 | |
| *** mriedem has joined #openstack-nova | 15:37 | |
| *** gyee has joined #openstack-nova | 15:38 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83: Add volume-patch CLI https://review.opendev.org/712651 | 15:39 |
| mriedem | oh wow nova's first PATCH API https://review.opendev.org/#/c/693828/ | 15:43 |
| *** dave-mccowan has quit IRC | 15:47 | |
| *** TxGirlGeek has joined #openstack-nova | 15:49 | |
| *** dave-mccowan has joined #openstack-nova | 15:52 | |
| *** umbSublime has quit IRC | 15:53 | |
| *** ociuhandu has quit IRC | 15:58 | |
| dansmith | hmm, we had a discussion recently about whether or not to add a PATCH API and I thought the agreement was to not | 16:09 |
| lyarwood | I wanted to move swap_volume out from under the UPDATE API but IIRC it was eventually agreed in the spec to go with PUT | 16:11 |
| lyarwood | https://review.opendev.org/#/c/580336/ yeah | 16:11 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83: Add volume-attachment-update CLI https://review.opendev.org/712651 | 16:12 |
| *** Luzi has quit IRC | 16:20 | |
| *** ociuhandu has joined #openstack-nova | 16:31 | |
| andreykurilin | brinzhang_, lyarwood: hi! wrapping with `@api_versions.wraps(2.83)` decorator is preventive protection to avoid redundant calls to Nova API side in case when novaclient is initialized with <2.83 version | 16:35 |
| *** dtantsur|brb is now known as dtantsur | 16:40 | |
| *** ociuhandu has quit IRC | 16:45 | |
| *** ociuhandu has joined #openstack-nova | 16:47 | |
| *** udesale_ has quit IRC | 16:57 | |
| *** rpittau is now known as rpittau|afk | 17:10 | |
| *** lyarwood has quit IRC | 17:11 | |
| *** priteau has quit IRC | 17:12 | |
| *** mkrai has quit IRC | 17:20 | |
| openstackgerrit | Merged openstack/nova master: images: Move qemu-img info calls into privsep https://review.opendev.org/706897 | 17:23 |
| *** evrardjp has quit IRC | 17:35 | |
| *** evrardjp has joined #openstack-nova | 17:36 | |
| *** tesseract has quit IRC | 17:37 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/713498 | 17:43 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: update quota apis with keystone limits and usage https://review.opendev.org/713499 | 17:43 |
| *** dtantsur is now known as dtantsur|afk | 17:59 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Report storage bus traits https://review.opendev.org/666914 | 18:21 |
| *** ociuhandu has quit IRC | 18:37 | |
| *** umbSublime has joined #openstack-nova | 18:46 | |
| *** tbachman has joined #openstack-nova | 18:48 | |
| *** amoralej is now known as amoralej|off | 19:02 | |
| *** vishalmanchanda has quit IRC | 19:07 | |
| *** gmann_afk is now known as gmann | 19:25 | |
| *** openstackgerrit has quit IRC | 19:33 | |
| *** maciejjozefczyk has quit IRC | 19:39 | |
| *** lbragstad_ is now known as lbragstad | 19:42 | |
| *** macz_ has joined #openstack-nova | 20:06 | |
| *** openstackgerrit has joined #openstack-nova | 20:17 | |
| openstackgerrit | Merged openstack/nova stable/train: Fix intermittently failing regression case https://review.opendev.org/713384 | 20:17 |
| *** ociuhandu has joined #openstack-nova | 20:21 | |
| *** nweinber has quit IRC | 20:35 | |
| artom | Do people still look at http://status.openstack.org/reviews/#nova ? | 20:35 |
| artom | The first, like, 20 or so, are so old and are either in merge conflict of with legit -1 reviews, and can be force-abandonned | 20:35 |
| artom | (IMO, at any rate) | 20:35 |
| *** ociuhandu has quit IRC | 20:57 | |
| *** ociuhandu has joined #openstack-nova | 21:14 | |
| *** damien_r has quit IRC | 21:26 | |
| *** damien_r has joined #openstack-nova | 21:30 | |
| *** rcernin has joined #openstack-nova | 21:30 | |
| *** rcernin has quit IRC | 21:37 | |
| *** rcernin has joined #openstack-nova | 21:38 | |
| *** damien_r has quit IRC | 21:42 | |
| *** xek has quit IRC | 21:46 | |
| *** ociuhandu has quit IRC | 21:46 | |
| *** ociuhandu has joined #openstack-nova | 22:01 | |
| *** ociuhandu has quit IRC | 22:06 | |
| *** slaweq has quit IRC | 22:39 | |
| *** bbowen has quit IRC | 22:45 | |
| *** bbowen has joined #openstack-nova | 22:45 | |
| *** slaweq has joined #openstack-nova | 22:50 | |
| *** slaweq has quit IRC | 22:54 | |
| *** tkajinam has joined #openstack-nova | 22:58 | |
| *** macz_ has quit IRC | 23:01 | |
| *** lbragstad has quit IRC | 23:01 | |
| *** macz_ has joined #openstack-nova | 23:02 | |
| *** macz_ has quit IRC | 23:16 | |
| *** grandchild has quit IRC | 23:33 | |
| *** tosky has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!