| *** tbachman has quit IRC | 00:01 | |
| *** brinzhang has joined #openstack-nova | 00:03 | |
| *** brinzhang_ has joined #openstack-nova | 00:33 | |
| *** brinzhang has quit IRC | 00:36 | |
| *** ociuhandu has joined #openstack-nova | 00:42 | |
| *** gyee has quit IRC | 00:44 | |
| *** brinzhang has joined #openstack-nova | 00:44 | |
| *** brinzhang_ has quit IRC | 00:47 | |
| *** ociuhandu has quit IRC | 00:48 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | 01:07 |
|---|---|---|
| *** yedongcan has joined #openstack-nova | 01:09 | |
| *** zhanglong has joined #openstack-nova | 01:17 | |
| *** huaqiang has quit IRC | 01:23 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | 01:31 |
| *** brinzhang_ has joined #openstack-nova | 01:54 | |
| *** brinzhang has quit IRC | 01:57 | |
| *** brinzhang has joined #openstack-nova | 01:59 | |
| *** brinzhang has quit IRC | 02:01 | |
| *** brinzhang has joined #openstack-nova | 02:02 | |
| *** brinzhang_ has quit IRC | 02:02 | |
| *** brinzhang_ has joined #openstack-nova | 02:16 | |
| *** brinzhang has quit IRC | 02:19 | |
| *** zhanglong has quit IRC | 02:26 | |
| rm_work | gibi: reviewed the routed-network tempest test -- that test needs a bit of cleanup | 02:26 |
| *** zhanglong has joined #openstack-nova | 02:28 | |
| *** ociuhandu has joined #openstack-nova | 02:43 | |
| *** ociuhandu has quit IRC | 02:48 | |
| *** brinzhang has joined #openstack-nova | 02:54 | |
| *** brinzhang_ has quit IRC | 02:57 | |
| *** jdillaman has quit IRC | 03:03 | |
| *** nicolasbock has quit IRC | 03:09 | |
| *** brinzhang_ has joined #openstack-nova | 03:18 | |
| *** tbachman has joined #openstack-nova | 03:18 | |
| *** brinzhang_ has quit IRC | 03:19 | |
| *** brinzhang_ has joined #openstack-nova | 03:20 | |
| *** brinzhang_ has quit IRC | 03:21 | |
| *** brinzhang has quit IRC | 03:22 | |
| *** brinzhang has joined #openstack-nova | 03:22 | |
| *** brinzhang_ has joined #openstack-nova | 03:24 | |
| *** brinzhang has quit IRC | 03:25 | |
| *** brinzhang_ has quit IRC | 03:26 | |
| *** brinzhang has joined #openstack-nova | 03:26 | |
| *** rchurch has quit IRC | 03:28 | |
| *** brinzhang_ has joined #openstack-nova | 03:30 | |
| *** brinzhang_ has quit IRC | 03:31 | |
| *** brinzhang has quit IRC | 03:34 | |
| *** mkrai has joined #openstack-nova | 03:53 | |
| *** udesale has joined #openstack-nova | 04:35 | |
| *** ociuhandu has joined #openstack-nova | 04:45 | |
| *** imacdonn has quit IRC | 04:47 | |
| *** imacdonn has joined #openstack-nova | 04:48 | |
| *** ociuhandu has quit IRC | 04:49 | |
| *** larainema has joined #openstack-nova | 05:06 | |
| *** rcernin has quit IRC | 05:33 | |
| *** rcernin has joined #openstack-nova | 05:33 | |
| *** evrardjp has quit IRC | 05:34 | |
| *** evrardjp has joined #openstack-nova | 05:35 | |
| *** links has joined #openstack-nova | 05:53 | |
| *** zhanglong has quit IRC | 05:55 | |
| *** zhanglong has joined #openstack-nova | 05:57 | |
| *** ratailor has joined #openstack-nova | 06:01 | |
| *** kozhukalov has joined #openstack-nova | 06:07 | |
| *** rcernin has quit IRC | 06:24 | |
| *** lbragstad has quit IRC | 06:26 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:43 | |
| *** ociuhandu has joined #openstack-nova | 06:45 | |
| *** ccamacho has quit IRC | 06:49 | |
| *** ociuhandu has quit IRC | 06:50 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | 06:52 |
| *** maciejjozefczyk has quit IRC | 06:55 | |
| *** ociuhandu has joined #openstack-nova | 07:02 | |
| *** ociuhandu has quit IRC | 07:07 | |
| *** mmethot has quit IRC | 07:11 | |
| *** mmethot has joined #openstack-nova | 07:22 | |
| *** ralonsoh has joined #openstack-nova | 07:28 | |
| *** jawad_axd has joined #openstack-nova | 07:47 | |
| *** tesseract has joined #openstack-nova | 07:53 | |
| *** slaweq has joined #openstack-nova | 07:53 | |
| *** brinzhang has joined #openstack-nova | 08:00 | |
| *** tkajinam has quit IRC | 08:02 | |
| *** brinzhang has quit IRC | 08:02 | |
| *** damien_r has joined #openstack-nova | 08:02 | |
| *** brinzhang has joined #openstack-nova | 08:02 | |
| *** damien_r has quit IRC | 08:03 | |
| *** damien_r has joined #openstack-nova | 08:03 | |
| *** ociuhandu has joined #openstack-nova | 08:06 | |
| aarents | Hi there, gibi when you will have time for that, can you confirm that https://review.opendev.org/#/c/702368/ is ok for you, I fixed the nits you reported. | 08:08 |
| *** maciejjozefczyk has joined #openstack-nova | 08:11 | |
| *** ociuhandu has quit IRC | 08:12 | |
| *** ccamacho has joined #openstack-nova | 08:18 | |
| gibi | rm_work: thank you for the tempest review. I've started working on the pre-filter patch from mriedem | 08:22 |
| gibi | aarents: opening the patch now... | 08:22 |
| rm_work | :thumbsup: | 08:22 |
| *** ociuhandu has joined #openstack-nova | 08:28 | |
| gibi | stephenfin: a relatively easy bugfix needs a second code https://review.opendev.org/#/c/702368 | 08:31 |
| gibi | aarents: thanks for the bufix, I'm +2 on it | 08:31 |
| *** udesale has quit IRC | 08:31 | |
| gibi | stephenfin: s/code/core/ // I need more coffeee | 08:32 |
| *** udesale has joined #openstack-nova | 08:32 | |
| aarents | gibi: thks | 08:32 |
| *** ociuhandu has quit IRC | 08:38 | |
| *** amoralej|off is now known as amoralej | 08:43 | |
| lyarwood | kashyap / stephenfin ; https://review.opendev.org/#/c/708745/ - a simple partial fix for the libvirt v6.0.0 qcow2 backing file format issue if you have time to review today. | 08:48 |
| kashyap | lyarwood: Morning, will look | 08:54 |
| kashyap | lyarwood: The discussions upstream turned even more complex; but I think we should go with this fix for now | 08:56 |
| kashyap | Looks good to me | 08:56 |
| *** rpittau|afk is now known as rpittau | 09:09 | |
| *** ociuhandu has joined #openstack-nova | 09:14 | |
| *** elod has quit IRC | 09:19 | |
| *** brinzhang_ has joined #openstack-nova | 09:25 | |
| *** brinzhang_ has quit IRC | 09:27 | |
| *** brinzhang_ has joined #openstack-nova | 09:27 | |
| *** brinzhang has quit IRC | 09:28 | |
| *** breizhkoala has joined #openstack-nova | 09:36 | |
| *** ociuhandu has quit IRC | 09:41 | |
| *** xek__ has joined #openstack-nova | 09:43 | |
| *** maysams has joined #openstack-nova | 09:48 | |
| *** jangutter has joined #openstack-nova | 10:08 | |
| *** ociuhandu has joined #openstack-nova | 10:12 | |
| *** jangutter has quit IRC | 10:28 | |
| *** elod has joined #openstack-nova | 10:29 | |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: Validate id as integer for os-aggregates https://review.opendev.org/710214 | 10:30 |
| *** mkrai has quit IRC | 10:30 | |
| jkulik | regarding ^ afaics, osc-lib first tries to get() whatever is supplied to `openstack aggregate show`, which the os-aggregates endpoint doesn't handle well, if it's a name and not an id. | 10:34 |
| jkulik | resulted in too many 500 errors in our environment | 10:34 |
| *** ociuhandu has quit IRC | 10:39 | |
| *** mkrai has joined #openstack-nova | 10:47 | |
| kashyap | lyarwood: Reviewed; I also posted the upstream libvirt conclusion for selective format probing (and not letting it recurse into multiple levels of backing chains) | 10:51 |
| kashyap | (Read this one: https://www.redhat.com/archives/libvir-list/2020-February/msg01001.html) | 10:51 |
| *** mkrai has quit IRC | 10:52 | |
| lyarwood | kashyap: ack thanks | 10:58 |
| *** brinzhang has joined #openstack-nova | 11:10 | |
| *** rpittau is now known as rpittau|bbl | 11:12 | |
| *** brinzhang_ has quit IRC | 11:14 | |
| *** kozhukalov has quit IRC | 11:17 | |
| *** ociuhandu has joined #openstack-nova | 11:18 | |
| *** ociuhandu has quit IRC | 11:18 | |
| *** ociuhandu has joined #openstack-nova | 11:19 | |
| *** ociuhandu has quit IRC | 11:20 | |
| *** kozhukalov has joined #openstack-nova | 11:21 | |
| *** ociuhandu has joined #openstack-nova | 11:21 | |
| *** ociuhandu has quit IRC | 11:26 | |
| *** ociuhandu has joined #openstack-nova | 11:26 | |
| *** ociuhandu has quit IRC | 11:29 | |
| *** ociuhandu has joined #openstack-nova | 11:30 | |
| *** kozhukalov has quit IRC | 11:35 | |
| *** ociuhandu has quit IRC | 11:35 | |
| *** kozhukalov has joined #openstack-nova | 11:35 | |
| *** ociuhandu has joined #openstack-nova | 11:36 | |
| *** ociuhandu has quit IRC | 11:36 | |
| *** ociuhandu has joined #openstack-nova | 11:37 | |
| *** jangutter has joined #openstack-nova | 11:38 | |
| *** ociuhandu has quit IRC | 11:39 | |
| *** ociuhandu has joined #openstack-nova | 11:39 | |
| *** ociuhandu has quit IRC | 11:40 | |
| *** tbachman has quit IRC | 11:41 | |
| *** ociuhandu has joined #openstack-nova | 11:42 | |
| *** kozhukalov has quit IRC | 11:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use 'import foo from bar' https://review.opendev.org/710235 | 11:45 |
| *** ociuhandu has quit IRC | 11:48 | |
| *** ociuhandu has joined #openstack-nova | 11:48 | |
| *** ivve has joined #openstack-nova | 11:53 | |
| *** ociuhandu has quit IRC | 11:56 | |
| *** ociuhandu has joined #openstack-nova | 11:56 | |
| *** ociuhandu has quit IRC | 11:57 | |
| *** ociuhandu has joined #openstack-nova | 11:57 | |
| *** ociuhandu has quit IRC | 11:58 | |
| *** iurygregory has joined #openstack-nova | 11:59 | |
| *** brinzhang_ has joined #openstack-nova | 11:59 | |
| *** brinzhang_ has quit IRC | 12:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | 12:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove QEMU_VERSION_REQ_SHARED https://review.opendev.org/710239 | 12:01 |
| *** brinzhang_ has joined #openstack-nova | 12:01 | |
| *** brinzhang has quit IRC | 12:02 | |
| *** brinzhang_ has quit IRC | 12:03 | |
| *** nicolasbock has joined #openstack-nova | 12:03 | |
| *** brinzhang_ has joined #openstack-nova | 12:03 | |
| *** brinzhang_ has quit IRC | 12:05 | |
| *** brinzhang_ has joined #openstack-nova | 12:05 | |
| *** brinzhang_ has quit IRC | 12:06 | |
| *** brinzhang_ has joined #openstack-nova | 12:07 | |
| *** amoralej is now known as amoralej|lunch | 12:08 | |
| *** udesale_ has joined #openstack-nova | 12:19 | |
| *** udesale_ has quit IRC | 12:21 | |
| *** udesale_ has joined #openstack-nova | 12:21 | |
| *** udesale has quit IRC | 12:22 | |
| *** iurygregory has quit IRC | 12:32 | |
| *** mgariepy has joined #openstack-nova | 12:32 | |
| *** cz3 is now known as papiez | 12:33 | |
| *** papiez is now known as cz3 | 12:33 | |
| *** iurygregory has joined #openstack-nova | 12:36 | |
| *** ociuhandu has joined #openstack-nova | 12:38 | |
| *** mgariepy has quit IRC | 12:38 | |
| *** kozhukalov has joined #openstack-nova | 12:39 | |
| *** ociuhandu has quit IRC | 12:40 | |
| *** eharney has quit IRC | 12:45 | |
| *** ociuhandu has joined #openstack-nova | 12:48 | |
| *** ratailor has quit IRC | 12:50 | |
| *** mgariepy has joined #openstack-nova | 12:52 | |
| *** jangutter has quit IRC | 12:56 | |
| *** jangutter has joined #openstack-nova | 12:56 | |
| *** tbachman has joined #openstack-nova | 12:57 | |
| *** brinzhang_ has quit IRC | 12:59 | |
| *** brinzhang_ has joined #openstack-nova | 12:59 | |
| *** sean-k-mooney has joined #openstack-nova | 13:00 | |
| *** brinzhang_ has quit IRC | 13:00 | |
| *** brinzhang_ has joined #openstack-nova | 13:01 | |
| *** jangutter has quit IRC | 13:02 | |
| *** brinzhang_ has quit IRC | 13:02 | |
| *** brinzhang_ has joined #openstack-nova | 13:03 | |
| *** nicolasbock has quit IRC | 13:03 | |
| *** nicolasbock has joined #openstack-nova | 13:04 | |
| *** udesale_ has quit IRC | 13:05 | |
| *** udesale_ has joined #openstack-nova | 13:05 | |
| *** tbachman has quit IRC | 13:07 | |
| *** ociuhandu has quit IRC | 13:17 | |
| *** ociuhandu has joined #openstack-nova | 13:18 | |
| *** amoralej|lunch is now known as amoralej | 13:18 | |
| *** nicolasbock has quit IRC | 13:21 | |
| *** ociuhandu has quit IRC | 13:23 | |
| *** rpittau|bbl is now known as rpittau | 13:24 | |
| *** nicolasbock has joined #openstack-nova | 13:26 | |
| *** ociuhandu has joined #openstack-nova | 13:26 | |
| *** jangutter has joined #openstack-nova | 13:31 | |
| *** lpetrut has joined #openstack-nova | 13:36 | |
| *** waverider has joined #openstack-nova | 13:44 | |
| *** iurygregory has quit IRC | 13:46 | |
| *** brinzhang has joined #openstack-nova | 13:53 | |
| *** brinzhang has quit IRC | 13:54 | |
| *** brinzhang has joined #openstack-nova | 13:54 | |
| *** nweinber has joined #openstack-nova | 13:55 | |
| *** eharney has joined #openstack-nova | 13:56 | |
| *** brinzhang has quit IRC | 13:56 | |
| *** brinzhang has joined #openstack-nova | 13:57 | |
| *** brinzhang has quit IRC | 13:58 | |
| *** brinzhang has joined #openstack-nova | 13:59 | |
| *** lbragstad has joined #openstack-nova | 13:59 | |
| *** brinzhang has quit IRC | 14:00 | |
| *** jawad_axd has quit IRC | 14:04 | |
| *** tbachman has joined #openstack-nova | 14:05 | |
| *** zhanglong has quit IRC | 14:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/708340 | 14:10 |
| stephenfin | lyarwood: I rebased that onto one of your patches to avoid a merge conflict. Any change you could re +2? ^ | 14:11 |
| * lyarwood looks | 14:11 | |
| lyarwood | stephenfin: done, elod ^ if you have a chance btw. | 14:14 |
| *** mgariepy has quit IRC | 14:14 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: setup.cfg: Configure 'python-requires' https://review.opendev.org/704534 | 14:25 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Remove use of six https://review.opendev.org/710274 | 14:25 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Switch to hacking 2.x https://review.opendev.org/710275 | 14:25 |
| openstackgerrit | Stephen Finucane proposed openstack/os-resource-classes master: Switch to hacking 2.x https://review.opendev.org/710276 | 14:25 |
| stephenfin | bauzas, gibi, efried: Some dead simple python27 cleanup patches there, if you want the stats ^ | 14:26 |
| bauzas | heh | 14:26 |
| * bauzas clicks | 14:26 | |
| efried | sean-k-mooney: did you see my comments yesterday about ksa->sdk conversion? | 14:29 |
| *** yedongcan has left #openstack-nova | 14:32 | |
| lyarwood | https://review.opendev.org/#/c/708745/ - For any non-RH cores, this is a simple partial fix for an issue introduced recently in Libvirt v6.0.0. | 14:33 |
| sean-k-mooney | efried: no | 14:34 |
| sean-k-mooney | i was logged off ill look at irc logs unless you want to summerise | 14:34 |
| efried | sean-k-mooney: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-02-26.log.html#t2020-02-26T23:11:23 | 14:34 |
| efried | not too much to summarize | 14:35 |
| sean-k-mooney | ah i see | 14:35 |
| efried | I don't like the idea of un-singleton-ing, which would mean we do the whole Adapter setup with every API call, versus putting in something that will keep the token alive for us. If that thing is converting to sdk, win/win. | 14:36 |
| sean-k-mooney | so ya my theory is that by making it a singolton in the current patch we are not refrshing the token | 14:36 |
| sean-k-mooney | so the fact we were always createing the adapters in other case was masking that | 14:36 |
| efried | yup | 14:36 |
| sean-k-mooney | so unless we do the swich i think the singolton is wrong or at least we would need to add an expiry/token check to it if we kept it | 14:37 |
| sean-k-mooney | i have been using https://review.opendev.org/#/c/679914/ | 14:38 |
| sean-k-mooney | in my testing | 14:38 |
| sean-k-mooney | oh which is now merged cool | 14:38 |
| sean-k-mooney | so that seams to work fine | 14:38 |
| sean-k-mooney | if that has all the feature we need then ya using the sdk i think make sense if it will handel the tokens for us | 14:39 |
| sean-k-mooney | efried: do you know if an update to the series is in the works | 14:44 |
| efried | I don't know, no. | 14:44 |
| sean-k-mooney | ok | 14:44 |
| efried | If there's now real sdk impl (rather than just REST primitive passthrough) that we could switch to, so much the better, though I would argue that should be done later, since it doesn't involve a problem we need to solve immediately. | 14:45 |
| sean-k-mooney | in that case i might just put a testing patch on the top of the chain that swaps the function calls and runs my multi node job to see if it fixes it | 14:45 |
| sean-k-mooney | ya i was thinkig of just doint the s/get_ksa_adapter/get_sdk_adapter/ | 14:46 |
| efried | yeah | 14:46 |
| efried | worth a try | 14:46 |
| sean-k-mooney | and see if that works | 14:46 |
| efried | I don't remember for sure whether that's all it takes... | 14:46 |
| *** nweinber has quit IRC | 14:47 | |
| efried | but easy enough to sniff out. | 14:47 |
| sean-k-mooney | if we are basically doing raw request i think it is | 14:47 |
| efried | If you have a live env handy it might make sense to try it out to winnow out any easy problems. | 14:47 |
| sean-k-mooney | if we wanted to use the new proxy function that would be more involed | 14:47 |
| efried | yeah, it wouldn't be wrt the requests, it would be with the setup. | 14:47 |
| *** nweinber has joined #openstack-nova | 14:48 | |
| sean-k-mooney | did you see i updated https://review.opendev.org/#/c/673341/ yesterday by the way | 14:49 |
| sean-k-mooney | im going to try and do the rest of the cain later today | 14:49 |
| efried | sean-k-mooney: yeah, I was going to wait until all updated to start reviewing, unless you think I should look sooner. | 14:51 |
| sean-k-mooney | am whatever works for you. most of the comments were gibis so i think he is the one that is more pressing | 14:51 |
| sean-k-mooney | that said waiting till they are all done is proably for the best | 14:52 |
| sean-k-mooney | that way you will have less context switching | 14:52 |
| efried | mordred: I think there's not too much context to be missed here. In proposed patch series, nova is talking to cyborg using a raw ksa adapter. I insisted we make that client a singleton, and we're seeing tokens expire after a while (I guess ksa doesn't take care of keeping them fresh). We want to cut over to using sdk anyway, so if sdk handles expiration under the covers, two birds. | 14:53 |
| sean-k-mooney | so ya im just going to grab lunch. when i get back ill quickly do the test patch for the cyborg series and then ill start on the provider.yaml patches | 14:53 |
| efried | ++ | 14:53 |
| *** mgariepy has joined #openstack-nova | 14:55 | |
| *** udesale_ has quit IRC | 14:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Always provide the size in bytes when calling virDomainBlockResize https://review.opendev.org/707590 | 14:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: images: Remove Libvirt specific configurable use from qemu_img_info https://review.opendev.org/707591 | 14:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | 15:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove QEMU_VERSION_REQ_SHARED https://review.opendev.org/710239 | 15:03 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: setup.cfg: Configure 'python-requires' https://review.opendev.org/704534 | 15:05 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: setup.cfg: Remove unused 'build_sphinx' configuration https://review.opendev.org/704535 | 15:05 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Remove use of six https://review.opendev.org/710274 | 15:05 |
| openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Switch to hacking 2.x https://review.opendev.org/710275 | 15:05 |
| stephenfin | lyarwood: I've a question left at https://review.opendev.org/#/c/706898/ btw | 15:08 |
| *** ociuhandu has quit IRC | 15:08 | |
| stephenfin | regarding how we're going to backport this fix if depends on a new oslo.utils feature | 15:08 |
| stephenfin | not sure if you've thought through that yet or no | 15:09 |
| *** ileixe has quit IRC | 15:10 | |
| *** ileixe has joined #openstack-nova | 15:11 | |
| mordred | efried: ok. that's something I think we should still look in to ... ksa should be auto-renewing tokens ... but sdk should _certainly_ be doing it | 15:12 |
| mordred | efried: and I'd consider it a bug in sdk if it's not - even if it's something we should be getting ksa to do for us - so that sounds like a good plan | 15:13 |
| efried | ack, thx | 15:13 |
| mordred | efried: are these tokens created from credentials nova has? or tokens received from the user that nova is re-using? | 15:13 |
| *** ociuhandu has joined #openstack-nova | 15:14 | |
| efried | mordred: from conf, via our soon-to-be-famous oslo.config loader | 15:14 |
| efried | um, I think | 15:14 |
| efried | Now I can't remember whether we decided to do cyborg-ness as user or admin... | 15:14 |
| efried | ...user | 15:15 |
| efried | mordred: so you can conf the session & adapter opts, but the auth should be the nova user's. | 15:15 |
| efried | Which means it makes even less sense that the token is expiring. | 15:15 |
| *** ileixe has quit IRC | 15:16 | |
| lyarwood | stephenfin: sorry just back from a call | 15:16 |
| lyarwood | stephenfin: yeah I was talking of backporting this more in a downstream context where we control everything within a given container | 15:17 |
| lyarwood | stephenfin: and then only to stable/train | 15:17 |
| lyarwood | stephenfin: for upstream, what do you mean in terms of vendoring? | 15:17 |
| stephenfin | I mean copying the newly updated contents of 'oslo_utils.imageutils' into the nova tree | 15:20 |
| *** alex_xu has quit IRC | 15:20 | |
| *** gyee has joined #openstack-nova | 15:21 | |
| openstackgerrit | GEET JAIN proposed openstack/nova master: Fix bug where aggregate api works with invalid id https://review.opendev.org/710290 | 15:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove QEMU_VERSION_REQ_SHARED https://review.opendev.org/710239 | 15:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | 15:22 |
| lyarwood | stephenfin: ah wait, so in the context of the bugfix I just need to bump requirements in https://review.opendev.org/#/c/706900/ | 15:22 |
| *** Sundar has joined #openstack-nova | 15:23 | |
| stephenfin | For the master patch, yup | 15:24 |
| stephenfin | Assuming a new oslo.utils patch has been cut since | 15:24 |
| lyarwood | https://review.opendev.org/#/c/710078/ - cut but not released | 15:25 |
| mordred | efried: yeah - it should *really* be renewing | 15:29 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | 15:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Connect RBD volumes to the compute host as block devices https://review.opendev.org/708029 | 15:30 |
| sean-k-mooney | efried: we should be useing the token form the api request not form the config | 15:31 |
| sean-k-mooney | we are not adding setting up the service user in the config and we are not adding a cyborg section to the nova.conf | 15:31 |
| sean-k-mooney | so i dont think the issue is with renewing the token in the nova code | 15:32 |
| sean-k-mooney | i think with the singelton we create the client onece capturing the context and token at that point | 15:32 |
| sean-k-mooney | and then it never gets updated again | 15:32 |
| sean-k-mooney | mordred: ^ that is also relevent to you i guess | 15:34 |
| mordred | yeah. that - if we're using the api request token, then when we get the singleton sdk connection object, we need to call conn.connect_as on it to get a new connection with the credentials we've been given, otherwise we're making all of the requests with the creds of the original user :) | 15:37 |
| sean-k-mooney | ya we are not doing that | 15:38 |
| sean-k-mooney | so that is likely the bug | 15:38 |
| mordred | conn.connect_as lets us keep discovery cache appropriately and all of that - but will construct a new underlying Auth construct and a new Adapter | 15:38 |
| mordred | sean-k-mooney: computers are hard | 15:38 |
| sean-k-mooney | mordred: we would do that here right https://review.opendev.org/#/c/631242/51/nova/accelerator/cyborg.py@32 just before the retrun? | 15:39 |
| sean-k-mooney | although im not sure that would be safe | 15:39 |
| sean-k-mooney | we could context switch at any point so we would have to take the lock | 15:39 |
| sean-k-mooney | and do it before making any call | 15:39 |
| mordred | sean-k-mooney: sdk is threadsafe | 15:41 |
| mordred | you shouldn't need a lock | 15:41 |
| sean-k-mooney | is it eventlet safe | 15:42 |
| mordred | _should_ be | 15:42 |
| mordred | if it's not it's a bug | 15:42 |
| sean-k-mooney | if the con.connect_as returns a new object that we then make new calls on it should work | 15:42 |
| mordred | I mean - but that said - with eventlet who the hell knows | 15:42 |
| mordred | sean-k-mooney: yes - connect_as returns a new object | 15:42 |
| mordred | it returns a whole new Connection with all the settings of the old one but with just the auth bits replaced | 15:43 |
| sean-k-mooney | and that object basicaly poxies the requeqes on it to the adapter it was created form but with the update creds | 15:43 |
| mordred | it has to create a new adapter - because an adapter is a container of session+auth+endpoint-config - you can't use the old adapter if you have new auth, you need a new adapter | 15:44 |
| mordred | but it does keep/share the things that are safe to keep/share | 15:44 |
| sean-k-mooney | is so then we just need to change "return _CYBORG_CLIENT" to "return _CYBORG_CLIENT.connect_as(context) | 15:44 |
| mordred | yeah | 15:44 |
| mordred | with a little hand wavey, because we'll want to make sure we're doing the right things with context ... but pseudo-code-wide yes | 15:45 |
| sean-k-mooney | ok so ill swap to the sdk adapter and add the connect_as | 15:45 |
| sean-k-mooney | mordred: ya, this isnt my code and i havent realy review it im just testing it but i can relyably repoduce that the current code is borked so tring to fine the minimal correct fix and test that in a follow up patch | 15:46 |
| sean-k-mooney | if it fixes the issue then we can squash it in and move on to the next thing | 15:47 |
| mordred | ++ | 15:47 |
| mordred | let me know if you have issues and want me to dive in further | 15:48 |
| mordred | I'm sure I could find some lovely new ways to curse | 15:48 |
| *** jangutter has quit IRC | 15:53 | |
| *** jangutter has joined #openstack-nova | 15:53 | |
| *** maciejjozefczyk has quit IRC | 15:54 | |
| efried | If we have to build a new adapter anyway, then I suppose we might as well just do as dansmith suggests and un-singleton for now. We'll want to do the SDK cutover later, but there's no way we'll forget to do that. | 15:56 |
| dansmith | ++ | 15:56 |
| sean-k-mooney | im not sure if the connect_as is cheaper then building the adapter from scratch but ya i just want to see this working and then iterate on it later to not loose the momentem we have while people are around to ask questions | 15:57 |
| sean-k-mooney | *answer | 15:58 |
| openstackgerrit | Stephen Finucane proposed openstack/os-resource-classes master: Switch to hacking 2.x https://review.opendev.org/710276 | 15:58 |
| *** priteau has joined #openstack-nova | 16:00 | |
| *** factor has quit IRC | 16:08 | |
| *** factor has joined #openstack-nova | 16:08 | |
| *** tbachman has quit IRC | 16:08 | |
| *** ccamacho has quit IRC | 16:08 | |
| *** factor has quit IRC | 16:11 | |
| *** factor has joined #openstack-nova | 16:13 | |
| *** links has quit IRC | 16:14 | |
| *** ociuhandu_ has joined #openstack-nova | 16:21 | |
| *** factor has quit IRC | 16:22 | |
| *** factor has joined #openstack-nova | 16:22 | |
| *** factor has quit IRC | 16:23 | |
| *** ociuhandu has quit IRC | 16:25 | |
| *** ociuhandu_ has quit IRC | 16:26 | |
| *** tesseract has quit IRC | 16:27 | |
| *** canori01 has quit IRC | 16:33 | |
| openstackgerrit | Merged openstack/os-traits master: setup.cfg: Configure 'python-requires' https://review.opendev.org/704534 | 16:34 |
| openstackgerrit | Merged openstack/os-traits master: setup.cfg: Remove unused 'build_sphinx' configuration https://review.opendev.org/704535 | 16:34 |
| *** damien_r has quit IRC | 16:39 | |
| *** waverider has quit IRC | 16:40 | |
| *** lpetrut has quit IRC | 16:40 | |
| gibi | sean-k-mooney: re: provider config. I have to take tomorrow off so I will look at your update earliest on Monday | 16:40 |
| *** mriedem has joined #openstack-nova | 16:40 | |
| *** ileixe has joined #openstack-nova | 16:43 | |
| *** damien_r has joined #openstack-nova | 16:44 | |
| *** dosaboy has quit IRC | 16:45 | |
| Sundar | dansmith, gibi, sean-k-mooney, efried: On the rescheduling front, I don't have a multi-node env to test it. It is not going to be easy for me to get the lab resources, even without FPGAs, to set that up. Plus, I have other things I need to focus on. Any ideas on bringing this to a timely closure? | 16:48 |
| dansmith | Sundar: functional tests? | 16:48 |
| efried | Sundar: Also, sean-k-mooney set up a multinode CI job. | 16:48 |
| dansmith | multinode ci might be hard to trigger a reschedule though | 16:49 |
| dansmith | Sundar: tangential to this part, did you see my comment about moving the event to the front of the queue, below the -2'd ksa patch? | 16:49 |
| Sundar | dansmith: Yes, I saw that. I have moved it before the ksa patch in my local env. The next commit should have it. | 16:50 |
| dansmith | Sundar: cool | 16:50 |
| Sundar | dansmith: With functional tests, I can check if the logs show rescheduling messages, and that the tests pass. Is there anything more you are looking for? | 16:51 |
| efried | You can do better than that to prove a reschedule occurred: use the fixture that makes the initial host predictable and prove that it lands on a different one. | 16:51 |
| gibi | efried ++ | 16:52 |
| dansmith | Sundar: "tests passing" isn't a bar to meet, "tests validating something useful" is | 16:52 |
| efried | there should be some good examples | 16:52 |
| dansmith | yep, what efried said | 16:52 |
| Sundar | efried: Thanks, will look for that. If you happen to remember the(rough) name of the fixture, off the top of your head, I'll start with that. | 16:52 |
| dansmith | Sundar: what specifically are you stuck on? there's lots of feedback to work on without much response from you yet that I can see.. is there something specific that you're blocked on? | 16:53 |
| *** ccamacho has joined #openstack-nova | 16:53 | |
| Sundar | dansmith: Not sure that any of my changes will actually work in the real world, without a multinode env. I tried to get a 2nd server but it will take time, if at all. | 16:53 |
| efried | Sundar: HostNameWeigherFixture I think | 16:53 |
| gibi | Sundar: HostNameWeigherFixture makes the host selection peridctable | 16:53 |
| dansmith | Sundar: functional tests man :) | 16:54 |
| Sundar | efried, gibi: Thanks, got it | 16:54 |
| *** jmlowe has quit IRC | 16:54 | |
| dansmith | Sundar: if you have reasonable functional tests that don't mock out insane levels of things and validate reasonable conditions, then any real world failure we find later is understandable | 16:54 |
| dansmith | Sundar: test_servers.py has a bunch of reschedule-specific tests | 16:55 |
| Sundar | dansmith: Ok, let's just focus on functional tests, then. BTW, https://review.opendev.org/gitweb?p=openstack/nova.git;f=nova/conductor/manager.py;hb=refs/changes/44/631244/63#l602 is specific to the resheduling path AFAICS. is there any other path, like rebuild/resize/whatever, that invokes this? | 17:00 |
| dansmith | Sundar: only if one of those things needs a reschedule, AFAIK | 17:01 |
| *** dosaboy has joined #openstack-nova | 17:01 | |
| Sundar | Ok. BTW, I will be travelling over the next couple of days. I will respond with the comments I accepted by today, and will post the rest in a few days. | 17:04 |
| dansmith | okay | 17:04 |
| *** tbachman has joined #openstack-nova | 17:05 | |
| Sundar | dansmith: In https://review.opendev.org/#/c/631244/63/nova/conductor/manager.py@848, is there any resource to be cleaned up in the exception path? | 17:05 |
| dansmith | Sundar: seems like there's network and block devices to clean up, but I'm not sure why the error paths above aren't doing that | 17:07 |
| dansmith | Sundar: should you be deleting arqs? | 17:07 |
| dansmith | or are you assuming those get deleted when the error'd instance gets deleted? | 17:07 |
| dansmith | Sundar: there is a _cleanup_after_reschedule_fails() method in there... | 17:08 |
| sean-k-mooney | gibi: ack that is fine. i likely will not be ready until then anyway | 17:08 |
| dansmith | er, cleanup_when_reschedule_fails | 17:09 |
| dansmith | which cleans up allocated network resources at least | 17:09 |
| Sundar | Well, not in this patch for sure, because delete ARQ functionality comes later. However, we should do that in the delete patch because Create ARQs may succeed but bind may throw an exception potentially. Then, Cyborg should be informed to delete the created ARQs. | 17:09 |
| dansmith | Sundar: okay your existing code won't even leave the instance in error state, which is bad.. but that cleanup method will do that for you | 17:09 |
| Sundar | dansmith: Yes, I see it. Good. Thanks. | 17:10 |
| *** ileixe has quit IRC | 17:11 | |
| Sundar | dansmith: I could tie the delete ARQs to _cleanup_when_reschedule_fails(). I'll check to see what other impact it has. | 17:11 |
| dansmith | Sundar: if deleting the instance in un-scheduled state will clean those up, then it's probably okay to punt to that.. the only problem might be if the ARQs are holding some resource for the dead instance | 17:12 |
| Sundar | dansmith: If the bind succeeds, then ARQs are holding real resources. So, if some other task fails during rescheduling, then Cyborg should be told to delete the ARQs. I think the changes we already have should take care of that. | 17:14 |
| *** tbachman has quit IRC | 17:16 | |
| dansmith | Sundar: right but the bind is right before the call back to compute, so if that fails, no bind was done, and if it has failed before that, we're already unbound from the original host, so not holding resource... is that right? | 17:17 |
| Sundar | dansmith: bind is async. The call here just kicks off the process, and the actual bind may succeed or fail after that. If the bind fails, either Cyborg sends a failure notification or Nova gets a timeout (in corner cases). That is already handled. if the bind succeeds, Cyborg has allocated and prepared resources. But something else in Nova may | 17:21 |
| Sundar | fail. It is this second path that I am not terribly sure about. | 17:21 |
| dansmith | I think you're missing my point | 17:21 |
| dansmith | or maybe you're talking about the reschedule racing with the *original* bind? | 17:21 |
| *** rpittau is now known as rpittau|afk | 17:23 | |
| Sundar | dansmith: I am talking of the bind during the rescheduling in https://review.opendev.org/#/c/631244/63/nova/conductor/manager.py@842 . Yes, if there is a failure in _create_and_bind_arqs( ) or earlier, no resources are allocated. | 17:24 |
| *** bbowen has quit IRC | 17:25 | |
| dansmith | Sundar: so you're concerned about what happens if the bind during reschedule fails and not knowing whether things are actually bound or not? | 17:25 |
| dansmith | if so that's... pretty scary | 17:25 |
| Sundar | I was talking of the scenario where _create_and_bind_arqs() succeeds, Nova goes ahead with the reschedule, CYborg prepares devices in the new host, and then things go south. | 17:25 |
| Sundar | Things go south in Nova | 17:26 |
| Sundar | So, every failure path in reschedule must call Cyborg to delete ARQs | 17:26 |
| dansmith | depends on where it goes south, but there's not much we can do about it | 17:26 |
| dansmith | try to delete the arqs when we can in error paths, | 17:26 |
| *** larainema has quit IRC | 17:26 | |
| dansmith | but as long as the instance delete will clean things up gracefully, that's the safety net | 17:27 |
| dansmith | after your bind in the reschedule path, the rest of it is identical to the regular build process | 17:27 |
| Sundar | I am trying to see if I am missing any error paths. AFAICS, we haven't missed any in the conductor. In the compute manager, if the reschedule takes the same code paths as the priginal schedule, we should be good. | 17:27 |
| dansmith | right | 17:27 |
| Sundar | Ok, then we are good | 17:28 |
| dansmith | if your bind in reschedule in conductor succeeds, then it's a regular build after that | 17:28 |
| *** jangutter has quit IRC | 17:29 | |
| *** jangutter_ has joined #openstack-nova | 17:29 | |
| *** maciejjozefczyk has joined #openstack-nova | 17:31 | |
| *** evrardjp has quit IRC | 17:35 | |
| *** LiangFang has quit IRC | 17:35 | |
| *** evrardjp has joined #openstack-nova | 17:35 | |
| *** maysams has quit IRC | 17:35 | |
| *** Liang__ has joined #openstack-nova | 17:35 | |
| *** maciejjozefczyk has quit IRC | 17:39 | |
| *** igordc has joined #openstack-nova | 17:39 | |
| *** ileixe has joined #openstack-nova | 17:39 | |
| *** maciejjozefczyk has joined #openstack-nova | 17:39 | |
| *** priteau has quit IRC | 17:40 | |
| openstackgerrit | Merged openstack/os-traits master: Remove use of six https://review.opendev.org/710274 | 17:45 |
| melwitt | mgoddard: do you know if there's any workaround for this bug you're working on? https://bugs.launchpad.net/nova/+bug/1853009 | 17:56 |
| openstack | Launchpad bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [Undecided,In progress] - Assigned to Mark Goddard (mgoddard) | 17:56 |
| *** mriedem has left #openstack-nova | 17:57 | |
| mgoddard | melwitt: don't restart nova-compute? :/ | 17:59 |
| mgoddard | well that's more how not to hit it | 17:59 |
| mgoddard | let me check my notes | 18:00 |
| mgoddard | melwitt: also when you say I'm working on it, mostly I'm just waiting for reviews | 18:00 |
| *** jmlowe has joined #openstack-nova | 18:01 | |
| mgoddard | Nothing of much help in my notes | 18:01 |
| *** igordc has quit IRC | 18:01 | |
| mgoddard | Restarting nova-compute one by one might help, but it might also create new problems | 18:02 |
| mgoddard | I think the approach we took was to apply those patches (backported to rocky) | 18:02 |
| mgoddard | rather than workaround | 18:02 |
| melwitt | mgoddard: gotcha ... thanks. I was looking through the lp bug trying to figure whether there's a workaround and wondered if you might already know | 18:03 |
| *** igordc has joined #openstack-nova | 18:04 | |
| mgoddard | sometimes you can do some DB hacking to change the compute node IDs. I can't remember if it works in this case | 18:04 |
| *** jmlowe has quit IRC | 18:05 | |
| *** jmlowe has joined #openstack-nova | 18:05 | |
| melwitt | mgoddard: thanks. definitely will review your patches, I was trying to work out whether there's any workaround possible to stop the bleeding in the immediate term while the patches get reviewed | 18:08 |
| sean-k-mooney | mgoddard: we have a customer that is seeing similar behavior when they do a ooo scale out. | 18:09 |
| mgoddard | if it's a problem there might be something that could be worked out. It should be possible to reproduce with a multinode control plane and a few ironic nodes (possibly fake) | 18:10 |
| mgoddard | keep restarting nova computes, and eventually the DB and placement will go astray | 18:10 |
| mgoddard | anyways, need to head off now | 18:10 |
| mgoddard | good luck! | 18:10 |
| melwitt | thanks mgoddard | 18:11 |
| *** macz_ has joined #openstack-nova | 18:12 | |
| *** damien_r has quit IRC | 18:14 | |
| *** macz_ has quit IRC | 18:14 | |
| *** amoralej is now known as amoralej|off | 18:14 | |
| *** macz_ has joined #openstack-nova | 18:15 | |
| *** jmlowe has quit IRC | 18:27 | |
| *** jangutter_ has quit IRC | 18:27 | |
| *** jmlowe has joined #openstack-nova | 18:30 | |
| *** jmlowe has quit IRC | 18:34 | |
| *** jmlowe has joined #openstack-nova | 18:35 | |
| *** jmlowe has quit IRC | 18:36 | |
| *** mriedem has joined #openstack-nova | 18:45 | |
| *** jangutter has joined #openstack-nova | 18:48 | |
| *** jangutter has quit IRC | 18:50 | |
| *** tbachman has joined #openstack-nova | 18:54 | |
| CeeMac | What would cause a block device mapping failure when deploying a new instance? I see the volume creating fine in cinder and on the backend iscsi storage (zadara) but there seems to be something preventing the volume mounting to the vm. Just trti g to piece the interconnecting pieces together ready for another round of troubleshooting tomorrow | 18:56 |
| *** jmlowe has joined #openstack-nova | 18:56 | |
| CeeMac | This is on a new compute/storage node I added today. I've been through the configs again and nothing obvious jumps out at me as being missed. Running rocky btw. | 18:57 |
| *** jmlowe has quit IRC | 18:59 | |
| melwitt | CeeMac: there's likely error logging about it in nova-compute logs | 19:03 |
| *** sean-k-mooney has quit IRC | 19:05 | |
| CeeMac | melwitt: yeah, I couldn't see anything specific beyond it timing out after x seconds etc | 19:08 |
| *** maciejjozefczyk has quit IRC | 19:08 | |
| CeeMac | I'll take another run at it and double check the logs in the morning | 19:08 |
| *** ralonsoh has quit IRC | 19:08 | |
| melwitt | CeeMac: ok. I'd turn on debug logging (debug=True in nova.conf for nova-compute) and find which command times out. I'm guessing it will be something os-brick is trying to do. and then go from there | 19:09 |
| CeeMac | The other weird thing I noticed was when I tried a live migration os-brick wasn't able to see the volume as there were no active iscsi sessions. Except I can see the server connecting to the storage and the volume getting created on the back end. | 19:10 |
| CeeMac | Does os-brick log somewhere specific? | 19:10 |
| melwitt | it logs in nova-compute but only at level DEBUG | 19:10 |
| CeeMac | Right | 19:11 |
| CeeMac | I'll check that first then, thanks | 19:11 |
| melwitt | yeah, once you find what command is timing out or returning something unexpected, you can start trying to piece it together with things that might be happening with the backend | 19:11 |
| -openstackstatus- NOTICE: Memory pressure on zuul.opendev.org is causing connection timeouts resulting in POST_FAILURE and RETRY_LIMIT results for some jobs since around 06:00 UTC today; we will be restarting the scheduler shortly to relieve the problem, and will follow up with another notice once running changes are reenqueued. | 19:11 | |
| CeeMac | melwitt: I'm hoping it'll be something obvious, it's a while since I last added a host and I've not made any changes to the config files that I can recall | 19:14 |
| melwitt | I hope so too | 19:17 |
| *** jmlowe has joined #openstack-nova | 19:31 | |
| *** eharney has quit IRC | 19:43 | |
| -openstackstatus- NOTICE: The scheduler for zuul.opendev.org has been restarted; any changes which were in queues at the time of the restart have been reenqueued automatically, but any changes whose jobs failed with a RETRY_LIMIT, POST_FAILURE or NODE_FAILURE build result in the past 14 hours should be manually rechecked for fresh results | 19:45 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:45 | |
| *** ociuhandu has joined #openstack-nova | 19:48 | |
| *** gyee has quit IRC | 19:49 | |
| *** gyee has joined #openstack-nova | 19:49 | |
| openstackgerrit | Merged openstack/os-traits master: Switch to hacking 2.x https://review.opendev.org/710275 | 19:52 |
| *** maciejjozefczyk has quit IRC | 19:57 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:58 | |
| *** jmlowe has quit IRC | 20:07 | |
| *** nicolasbock has quit IRC | 20:07 | |
| *** kozhukalov has quit IRC | 20:27 | |
| *** martinkennelly has joined #openstack-nova | 20:28 | |
| *** kozhukalov has joined #openstack-nova | 20:28 | |
| *** jmlowe has joined #openstack-nova | 20:30 | |
| *** Sundar has quit IRC | 20:35 | |
| *** mlavalle has joined #openstack-nova | 20:40 | |
| efried | Nova meeting in ~15 minutes in #openstack-meeting | 20:45 |
| *** ociuhandu has quit IRC | 20:53 | |
| *** kozhukalov has quit IRC | 21:08 | |
| *** tbachman has quit IRC | 21:11 | |
| *** slaweq has quit IRC | 21:15 | |
| *** david_4 has joined #openstack-nova | 21:23 | |
| *** aarents has quit IRC | 21:23 | |
| david_4 | Hi, I am new to Nova, I wanted add a scheduler filter and want to know how to test filters in nova-scheduler. I have an openstack env running with 3 head nodes and 3 work node, I am not using devstack. | 21:25 |
| david_4 | any help please !! | 21:34 |
| *** kozhukalov has joined #openstack-nova | 21:40 | |
| *** dpawlik has quit IRC | 21:43 | |
| *** rcernin has joined #openstack-nova | 21:44 | |
| *** martinkennelly has quit IRC | 21:46 | |
| *** xek__ has quit IRC | 21:53 | |
| *** tbachman has joined #openstack-nova | 22:09 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** david_4 has quit IRC | 22:11 | |
| *** slaweq has quit IRC | 22:15 | |
| *** slaweq has joined #openstack-nova | 22:18 | |
| *** tbachman has quit IRC | 22:19 | |
| *** N3l1x has joined #openstack-nova | 22:20 | |
| *** maciejjozefczyk has quit IRC | 22:20 | |
| *** slaweq has quit IRC | 22:22 | |
| *** eharney has joined #openstack-nova | 22:29 | |
| *** jawad_axd has joined #openstack-nova | 22:38 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix H702 pep8 error with latest hacking https://review.opendev.org/710344 | 22:40 |
| *** jawad_axd has quit IRC | 22:43 | |
| efried | gmann: Is that the only thing you want in that patch? ^ | 22:45 |
| efried | if so, I'll fast approve | 22:45 |
| *** tkajinam has joined #openstack-nova | 22:51 | |
| *** tkajinam has quit IRC | 22:51 | |
| *** tkajinam has joined #openstack-nova | 22:51 | |
| *** ivve has quit IRC | 22:57 | |
| *** owalsh has quit IRC | 22:58 | |
| mriedem | if david_4 ever comes back, point him at something like https://github.com/openstack/nova/blob/master/nova/tests/functional/test_json_filter.py as an example of how to test scheduler filters in functional tests - easier than getting a real environment setup (assuming he can navigate how to run functional tests) | 23:01 |
| *** alex_xu has joined #openstack-nova | 23:01 | |
| mriedem | smell ya later! | 23:02 |
| *** mriedem has left #openstack-nova | 23:02 | |
| *** nweinber has quit IRC | 23:03 | |
| *** slaweq has joined #openstack-nova | 23:11 | |
| *** ociuhandu has joined #openstack-nova | 23:12 | |
| *** slaweq has quit IRC | 23:16 | |
| *** owalsh has joined #openstack-nova | 23:16 | |
| *** ociuhandu_ has joined #openstack-nova | 23:19 | |
| *** ociuhandu_ has quit IRC | 23:21 | |
| *** tbachman has joined #openstack-nova | 23:21 | |
| *** aarents has joined #openstack-nova | 23:21 | |
| *** ociuhandu has quit IRC | 23:22 | |
| gmann | efried: yeah, that is only error for now. | 23:31 |
| *** kozhukalov has quit IRC | 23:35 | |
| gmann | efried: wait, few more seems. let me update. | 23:38 |
| *** jawad_axd has joined #openstack-nova | 23:40 | |
| *** jawad_axd has quit IRC | 23:45 | |
| *** jamesdenton has quit IRC | 23:49 | |
| *** jamesdenton has joined #openstack-nova | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!