| *** Liang__ has joined #openstack-nova | 00:04 | |
| *** igordc has quit IRC | 00:06 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** jmlowe has quit IRC | 00:15 | |
| *** slaweq has quit IRC | 00:15 | |
| *** spatel has joined #openstack-nova | 00:18 | |
| *** spatel has quit IRC | 00:22 | |
| *** abaindur has quit IRC | 00:22 | |
| *** abaindur has joined #openstack-nova | 00:23 | |
| *** mlavalle has quit IRC | 00:28 | |
| *** tbachman has joined #openstack-nova | 00:30 | |
| *** maohongbo1 has joined #openstack-nova | 00:31 | |
| *** maohongbo has quit IRC | 00:31 | |
| *** maohongbo1 is now known as maohongbo | 00:31 | |
| *** Liang__ has quit IRC | 00:46 | |
| *** Liang__ has joined #openstack-nova | 00:48 | |
| *** brinzhang has quit IRC | 01:02 | |
| *** brinzhang has joined #openstack-nova | 01:02 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** slaweq has quit IRC | 01:15 | |
| *** nweinber has joined #openstack-nova | 01:27 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/699148 | 01:37 |
|---|---|---|
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856 | 01:37 |
| *** yedongcan has joined #openstack-nova | 01:48 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** ociuhandu has joined #openstack-nova | 02:13 | |
| *** slaweq has quit IRC | 02:16 | |
| *** ociuhandu has quit IRC | 02:17 | |
| *** purplerbot has quit IRC | 02:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use tempest-full-py3 as base job https://review.opendev.org/708548 | 02:35 |
| *** purplerbot has joined #openstack-nova | 02:36 | |
| *** Roamer` has quit IRC | 02:36 | |
| *** larainema has joined #openstack-nova | 02:42 | |
| *** sapd1_ has quit IRC | 02:43 | |
| *** sapd1_ has joined #openstack-nova | 02:44 | |
| *** hongbin has joined #openstack-nova | 02:53 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** abaindur has quit IRC | 03:14 | |
| *** slaweq has quit IRC | 03:16 | |
| *** hongbin has quit IRC | 03:23 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** spatel has joined #openstack-nova | 03:38 | |
| *** spatel has quit IRC | 03:38 | |
| *** nweinber has quit IRC | 04:01 | |
| *** artom has quit IRC | 04:05 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| openstackgerrit | Merged openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/707738 | 04:15 |
| *** slaweq has quit IRC | 04:16 | |
| *** gyee has quit IRC | 04:20 | |
| *** lbragstad has quit IRC | 04:22 | |
| *** TxGirlGeek has quit IRC | 04:42 | |
| *** imacdonn has quit IRC | 04:44 | |
| *** imacdonn has joined #openstack-nova | 04:44 | |
| *** udesale has joined #openstack-nova | 04:50 | |
| *** vishalmanchanda has joined #openstack-nova | 04:54 | |
| *** ratailor has joined #openstack-nova | 04:59 | |
| *** macz_ has quit IRC | 05:00 | |
| *** ebbex has quit IRC | 05:08 | |
| *** ebbex has joined #openstack-nova | 05:10 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** ebbex has quit IRC | 05:28 | |
| *** ebbex has joined #openstack-nova | 05:30 | |
| *** evrardjp has quit IRC | 05:34 | |
| *** evrardjp has joined #openstack-nova | 05:34 | |
| *** links has joined #openstack-nova | 05:35 | |
| *** dave-mccowan has quit IRC | 06:04 | |
| *** dave-mccowan has joined #openstack-nova | 06:07 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** slaweq has quit IRC | 06:15 | |
| *** hongbin has joined #openstack-nova | 06:23 | |
| *** hongbin has quit IRC | 06:28 | |
| *** brinzhang has quit IRC | 06:30 | |
| *** brinzhang has joined #openstack-nova | 06:31 | |
| *** maohongbo1 has joined #openstack-nova | 06:35 | |
| *** maohongbo has quit IRC | 06:37 | |
| *** maohongbo1 is now known as maohongbo | 06:37 | |
| *** zhanglong has joined #openstack-nova | 06:59 | |
| *** openstack has joined #openstack-nova | 07:19 | |
| *** ChanServ sets mode: +o openstack | 07:19 | |
| *** openstack has joined #openstack-nova | 07:43 | |
| *** ChanServ sets mode: +o openstack | 07:43 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:47 | |
| *** slaweq has joined #openstack-nova | 07:51 | |
| *** zzzeek has joined #openstack-nova | 07:51 | |
| *** zzzeek has quit IRC | 07:54 | |
| *** zzzeek has joined #openstack-nova | 07:56 | |
| *** dpawlik has joined #openstack-nova | 07:58 | |
| *** tesseract has joined #openstack-nova | 08:07 | |
| *** tkajinam has quit IRC | 08:11 | |
| *** tetsuro has joined #openstack-nova | 08:12 | |
| *** tetsuro__ has joined #openstack-nova | 08:13 | |
| *** tetsuro_ has quit IRC | 08:14 | |
| *** ccamacho has joined #openstack-nova | 08:15 | |
| gibi | sean-k-mooney: thanks. I will try to set up something with a fake cyborg driver. So if you have patches to the driver then I could use it as well | 08:16 |
| *** tetsuro has quit IRC | 08:16 | |
| *** tetsuro has joined #openstack-nova | 08:17 | |
| *** tetsuro__ has quit IRC | 08:21 | |
| *** zhanglong has quit IRC | 08:22 | |
| *** links has quit IRC | 08:24 | |
| *** amoralej|off is now known as amoralej | 08:24 | |
| *** zhanglong has joined #openstack-nova | 08:24 | |
| *** abaindur has quit IRC | 08:27 | |
| *** takamatsu has quit IRC | 08:27 | |
| *** abaindur has joined #openstack-nova | 08:28 | |
| *** maohongbo has quit IRC | 08:30 | |
| *** maohongbo has joined #openstack-nova | 08:30 | |
| *** mvkr has joined #openstack-nova | 08:36 | |
| *** arne_wiebalck has quit IRC | 08:36 | |
| *** vdrok has quit IRC | 08:36 | |
| *** vishalmanchanda has quit IRC | 08:36 | |
| *** arne_wiebalck has joined #openstack-nova | 08:37 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Reject boot request for unsupported images https://review.opendev.org/708577 | 08:37 |
| *** vishalmanchanda has joined #openstack-nova | 08:37 | |
| *** vdrok has joined #openstack-nova | 08:37 | |
| *** rpittau|afk is now known as rpittau | 08:37 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Reject boot request for unsupported images https://review.opendev.org/708578 | 08:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use recognized extra specs in tests https://review.opendev.org/708435 | 08:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 08:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.82, extra spec validation https://review.opendev.org/708436 | 08:39 |
| *** spatel has joined #openstack-nova | 08:48 | |
| *** spatel has quit IRC | 08:52 | |
| *** ralonsoh has joined #openstack-nova | 08:54 | |
| *** links has joined #openstack-nova | 09:01 | |
| *** ociuhandu has joined #openstack-nova | 09:08 | |
| *** tetsuro_ has joined #openstack-nova | 09:09 | |
| *** tetsuro has quit IRC | 09:09 | |
| *** Jeffrey4l has quit IRC | 09:12 | |
| *** Jeffrey4l has joined #openstack-nova | 09:13 | |
| *** abaindur has quit IRC | 09:17 | |
| *** tetsuro has joined #openstack-nova | 09:21 | |
| *** ociuhandu has quit IRC | 09:25 | |
| *** tetsuro_ has quit IRC | 09:25 | |
| *** ociuhandu has joined #openstack-nova | 09:27 | |
| *** tetsuro has quit IRC | 09:27 | |
| lyarwood | Morning all, https://review.opendev.org/#/c/708126/ - any non-RH cores able to review this? Looking to close it out and backport if possible. | 09:37 |
| *** abaindur has joined #openstack-nova | 09:37 | |
| lyarwood | stephenfin: ah so you're also trying to land on 2.82, is there any etiquette around multiple changes trying to land on the same microversion between M2 and M3? | 09:37 |
| lyarwood | stephenfin: for context https://review.opendev.org/#/c/701430/ | 09:38 |
| *** dtantsur|afk is now known as dtantsur | 09:38 | |
| stephenfin | lyarwood: whoever gets there first? :) | 09:38 |
| lyarwood | stephenfin: ack, may the best change win | 09:38 |
| * lyarwood cracks whip | 09:39 | |
| stephenfin | -2 -2 -2 -2 -2 | 09:39 |
| stephenfin | sorted. | 09:39 |
| lyarwood | lol | 09:39 |
| lyarwood | MINE MINE MINE | 09:39 |
| *** derekh has joined #openstack-nova | 09:43 | |
| gibi | lyarwood: put https://review.opendev.org/#/c/708126/ into my review queue | 09:49 |
| *** martinkennelly has joined #openstack-nova | 09:49 | |
| lyarwood | gibi: awesome thank you | 09:49 |
| *** abaindur has quit IRC | 09:50 | |
| stephenfin | bauzas: Want to help me close out my oldest review today? :) https://review.opendev.org/#/c/399653/ | 09:58 |
| gibi | lyarwood, stephenfin, rosmaita: I have one question regarding the release notes https://review.opendev.org/#/c/708126/3/releasenotes/notes/absolutely-non-inheritable-image-properties-85f7f304fdc20b61.yaml@19 | 09:59 |
| kashyap | stephenfin: Wonder if I can borrow your rST eyes for a quick once-over for a QEMU upstream doc: https://kashyapc.fedorapeople.org/qemu_v4.2.0-1300-g5da20ed7e3_docs/system/qemu-cpu-models.html | 09:59 |
| kashyap | stephenfin: Reading from the bottom, do you find the QEMU / libvirt examples with bullet / sub-bullet combo ugly? | 09:59 |
| kashyap | Or "unclean", or "inelegant", or "un-rST" or ... | 10:00 |
| stephenfin | gibi: Replied. It was done in change https://review.opendev.org/#/c/707738/ | 10:00 |
| stephenfin | kashyap: you mean the "Syntax for configuring CPU models" section? | 10:01 |
| kashyap | stephenfin: Exactly | 10:01 |
| stephenfin | Yeah, I tend to refrain from bullet points in favour of definition lists or simply sub-titles | 10:02 |
| stephenfin | though the former wouldn't work here | 10:02 |
| *** ociuhandu has quit IRC | 10:03 | |
| stephenfin | For things like the "Important CPU features for AMD x86 hosts" section though, definitely definition lists for the flags, IMO | 10:03 |
| kashyap | stephenfin: I'll turn them into sub-titles, then. | 10:03 |
| gibi | stephenfin: thanks. I see now. I'm +A | 10:03 |
| * kashyap goes to remind himself of an example of a "definition list" | 10:03 | |
| stephenfin | kashyap: | 10:03 |
| stephenfin | definition term | 10:03 |
| stephenfin | definition definition | 10:04 |
| stephenfin | no newlines between the two | 10:04 |
| kashyap | stephenfin: I see, okay, you suggest that for the CPU features for AMD|Intel hosts. (I'll ACK your review in the QEMU commit message, of course.) | 10:06 |
| bauzas | stephenfin: oh sorry, missed your ping | 10:09 |
| * bauzas clicks | 10:09 | |
| *** zhanglong has quit IRC | 10:15 | |
| bauzas | stephenfin: call it a deal | 10:17 |
| *** zhanglong has joined #openstack-nova | 10:18 | |
| *** ivve has joined #openstack-nova | 10:20 | |
| brinzhang | A follow up patch of bp/support-delete-on-termination-in-server-attach-volume | 10:22 |
| brinzhang | https://review.opendev.org/#/c/680655/ | 10:22 |
| brinzhang | Anyone can review this? It has been pushed for a long time | 10:22 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Reject boot request for unsupported images https://review.opendev.org/708608 | 10:35 |
| *** derekh has quit IRC | 10:37 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Reject boot request for unsupported images https://review.opendev.org/708609 | 10:38 |
| gibi | brinzhang: it would be nice to get gmann and or takashi vote on that followup as that fixes their comments | 10:50 |
| brinzhang | gibi: yes, thanks | 10:51 |
| brinzhang | gibi: and that update gmann and takashi's comments, so I think it would be ok now, and in PS4, they are all +1 for that :) | 10:53 |
| gibi | brinzhang: I see takashi's +1 but I only see -1 from gmann. anyhow I queued that path for review on my side | 10:55 |
| stephenfin | bauzas: Reviewed https://review.opendev.org/#/c/670112/ - just two changes requested and I'm happy | 10:56 |
| brinzhang | gibi: yeah, thanks, I was already fixed gmann's comments, and wait for gmann check for that | 10:56 |
| brinzhang | gmann: please check again https://review.opendev.org/#/c/680655/9 | 10:56 |
| *** samc-bbc has quit IRC | 11:01 | |
| *** zhanglong has quit IRC | 11:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/701754 | 11:03 |
| stephenfin | bauzas: Got another suppppper easy one here for you https://review.opendev.org/#/c/706466/ | 11:05 |
| *** zhanglong has joined #openstack-nova | 11:05 | |
| *** slaweq has quit IRC | 11:06 | |
| *** slaweq has joined #openstack-nova | 11:11 | |
| *** zhanglong has quit IRC | 11:13 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 11:13 | |
| *** maciejjozefczyk has quit IRC | 11:14 | |
| *** maciejjozefczyk_ has quit IRC | 11:14 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 11:14 | |
| *** zhanglong has joined #openstack-nova | 11:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708615 | 11:19 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708616 | 11:19 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708617 | 11:19 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708615 | 11:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708615 | 11:24 |
| lyarwood | gah, I need to repost some of these, sorry! | 11:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708616 | 11:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Make RBD imagebackend flatten method idempotent https://review.opendev.org/708617 | 11:25 |
| lyarwood | okay done, lyarwood-- | 11:25 |
| *** slaweq has quit IRC | 11:32 | |
| *** takamatsu has joined #openstack-nova | 11:32 | |
| *** slaweq has joined #openstack-nova | 11:34 | |
| *** rpittau is now known as rpittau|bbl | 11:40 | |
| *** takamatsu has quit IRC | 12:08 | |
| *** yedongcan has quit IRC | 12:08 | |
| *** ociuhandu has joined #openstack-nova | 12:10 | |
| *** ociuhandu has quit IRC | 12:11 | |
| *** ociuhandu has joined #openstack-nova | 12:12 | |
| *** takamatsu has joined #openstack-nova | 12:13 | |
| *** ociuhandu has quit IRC | 12:16 | |
| *** mgoddard has quit IRC | 12:16 | |
| *** mgoddard has joined #openstack-nova | 12:21 | |
| *** spatel has joined #openstack-nova | 12:24 | |
| *** derekh has joined #openstack-nova | 12:25 | |
| *** spatel has quit IRC | 12:28 | |
| *** zhanglong has quit IRC | 12:32 | |
| *** rcernin has quit IRC | 12:37 | |
| *** zhanglong has joined #openstack-nova | 12:48 | |
| *** udesale_ has joined #openstack-nova | 12:49 | |
| *** b3nt_pin has joined #openstack-nova | 12:51 | |
| *** udesale has quit IRC | 12:52 | |
| *** tbachman has quit IRC | 12:53 | |
| *** brinzhang_ has joined #openstack-nova | 12:53 | |
| *** brinzhang has quit IRC | 12:56 | |
| *** b3nt_pin is now known as beagles | 13:01 | |
| *** rpittau|bbl is now known as rpittau | 13:02 | |
| *** martinkennelly has quit IRC | 13:03 | |
| stephenfin | lyarwood: Question for you at https://review.opendev.org/#/c/706897/2/nova/virt/images.py@53 | 13:06 |
| *** ratailor has quit IRC | 13:20 | |
| *** ociuhandu has joined #openstack-nova | 13:23 | |
| *** liuyulong has joined #openstack-nova | 13:29 | |
| *** amoralej is now known as amoralej|lunch | 13:31 | |
| mnaser | dansmith: the backfilling issue is confirmed to be resolved, just did it against a cloud with ~450kish records in instances table | 13:32 |
| mnaser | so it didnt try to backfill the hidden value | 13:32 |
| *** davidsha has joined #openstack-nova | 13:35 | |
| *** nweinber has joined #openstack-nova | 13:39 | |
| *** lbragstad has joined #openstack-nova | 13:47 | |
| *** lbragsta_ has joined #openstack-nova | 13:52 | |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 13:52 | |
| *** lbragstad has quit IRC | 13:54 | |
| openstackgerrit | Merged openstack/nova master: Absolutely-non-inheritable image properties https://review.opendev.org/708126 | 13:58 |
| *** Liang__ is now known as LiangFang | 13:58 | |
| openstackgerrit | Merged openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653 | 13:58 |
| *** tbachman has joined #openstack-nova | 13:59 | |
| *** rosmaita has left #openstack-nova | 13:59 | |
| *** eharney has joined #openstack-nova | 13:59 | |
| *** amoralej|lunch is now known as amoralej | 14:00 | |
| *** jaosorior has joined #openstack-nova | 14:16 | |
| *** links has quit IRC | 14:18 | |
| *** lbragsta_ has quit IRC | 14:20 | |
| *** lbragstad has joined #openstack-nova | 14:21 | |
| *** zhanglong has quit IRC | 14:22 | |
| *** zhanglong has joined #openstack-nova | 14:25 | |
| *** spatel has joined #openstack-nova | 14:27 | |
| *** slaweq has quit IRC | 14:27 | |
| *** slaweq has joined #openstack-nova | 14:30 | |
| *** spatel has quit IRC | 14:31 | |
| bauzas | stephenfin: ack for the placement audit review and thanks, will look | 14:34 |
| bauzas | stephenfin: and I added a better explanation in https://review.opendev.org/#/c/706466/ | 14:36 |
| bauzas | that won't be in the commit msg but okay | 14:36 |
| *** jaosorior has quit IRC | 14:38 | |
| *** zhanglong has quit IRC | 14:41 | |
| dansmith | mnaser: sweet, that's been backported and released now so hopefully nobody else will hit it | 14:44 |
| dansmith | mnaser: thanks for being the front line :) | 14:44 |
| *** jmlowe has joined #openstack-nova | 14:48 | |
| mnaser | dansmith: yep, thanks for helping out in nailing down the root cause. I appreciate it. | 14:49 |
| dansmith | np | 14:49 |
| *** tosky has joined #openstack-nova | 14:54 | |
| *** jmlowe has quit IRC | 14:56 | |
| *** eharney has quit IRC | 14:56 | |
| openstackgerrit | Dongcan Ye proposed openstack/nova master: libvirt: Check the guest support UEFI https://review.opendev.org/685678 | 14:56 |
| *** irclogbot_2 has quit IRC | 14:56 | |
| *** artom has joined #openstack-nova | 14:57 | |
| *** irclogbot_1 has joined #openstack-nova | 15:02 | |
| lyarwood | stephenfin: ack thanks, I'll reply shortly | 15:07 |
| *** dave-mccowan has quit IRC | 15:08 | |
| *** psachin has quit IRC | 15:09 | |
| *** lpetrut has quit IRC | 15:11 | |
| *** ociuhandu has quit IRC | 15:11 | |
| *** ociuhandu has joined #openstack-nova | 15:17 | |
| dansmith | sean-k-mooney: so looking into my failures from yesterday, I'm actually getting an error from placement: | 15:20 |
| *** jmlowe has joined #openstack-nova | 15:20 | |
| dansmith | sean-k-mooney: "There is more than one numbered request group in the allocation candidate query but the flavor did not specify any group policy. This query would fail in placement due to the missing group policy." | 15:20 |
| dansmith | efried: ^ | 15:20 |
| dansmith | my flavor is pretty vanilla with the exception of an accel:device_profile key | 15:21 |
| efried | interesting; there should be gibi code defaulting the group_policy in this case. Perhaps the dp groups are being added after that. | 15:21 |
| gibi | hm hm | 15:22 |
| dansmith | but it sounds like it works (past this point) for sean-k-mooney and was working in the tempest job last I looked | 15:22 |
| gibi | the defaulting code checks what groups are coming from the flavor and what are from the ports | 15:22 |
| gibi | we only default to none if the flavor does not specify groups | 15:24 |
| *** johanssone has quit IRC | 15:24 | |
| efried | dansmith: oh, is that warning actually preceding a failure? | 15:24 |
| dansmith | efried: yeah, "got no acs", but I guess I thought it was saying "expect no results shortly" | 15:24 |
| efried | sorry, I'm interleaving. Sounds like this is working as designed, defaulting the group_policy to 'none'. | 15:24 |
| dansmith | ahhh | 15:24 |
| dansmith | I see the real error, it was hidden in the json: | 15:25 |
| dansmith | Invalid resource class in resources parameter: No such resource class CUSTOM_ACCELERATOR_XYZ | 15:25 |
| dansmith | duh sorry | 15:25 |
| dansmith | I'm not sure where that comes from or what I'm supposed to do to make this work in devstack | 15:25 |
| efried | would there be a better way to percolate that error up? | 15:26 |
| dansmith | I would have expected it to fully configure a fake driver, compute, and traits/classes | 15:26 |
| efried | dansmith: I think ordinarily cyborg would create the resource class. In devstack you can create it manually. | 15:26 |
| efried | yeah, good point, the "fake driver" should probably do it. | 15:26 |
| dansmith | I'm not sure where "CUSTOM_ACCELERATOR_XYZ" comes from either | 15:26 |
| efried | That would be in the device profile. | 15:27 |
| dansmith | from cyborg I guess, stating what the resources for the profile should be? | 15:27 |
| dansmith | yeah, | 15:27 |
| dansmith | so ... seems like it should have done more | 15:27 |
| efried | agree | 15:27 |
| *** johanssone has joined #openstack-nova | 15:27 | |
| *** TxGirlGeek has joined #openstack-nova | 15:27 | |
| dansmith | efried: I was asking sean-k-mooney this yesterday, but will the fake driver expose the inventory for me as well or do I need to hack up some of that? | 15:27 |
| efried | dansmith: I don't know what it *does* do, but I feel like ultimately it *should* do all of that. | 15:29 |
| gibi | for me the cyborg fake driver created FPGA rc and inventory with a CUSTOM_FAKE_DEVICE trait | 15:29 |
| dansmith | yeah, looking for the former | 15:29 |
| dansmith | now I get complaints about two traits that don't exist, so I guess I need to create those too? | 15:29 |
| gibi | dansmith: can it be that you need to create a device profile that asks for FPGA resource and some fake device ? | 15:31 |
| dansmith | gibi: I dunno, I was expecting this to all kinda be done for me in devstack, so I'm not sure what I'm expected to do | 15:31 |
| dansmith | gibi: did you get it working? | 15:31 |
| gibi | dansmith: the device profile Sundar's script describes does not match with what the fake driver provides | 15:31 |
| *** priteau has joined #openstack-nova | 15:32 | |
| gibi | dansmith: I was able to stack a devstack but did not created any device profile yet to consume | 15:32 |
| dansmith | yeah, I'm right about there myself | 15:32 |
| gibi | dansmith: I think the mistmatch is in http://paste.openstack.org/show/789709/ Sundar provided. Those examples are not aligned with the fake driver | 15:33 |
| dansmith | okay | 15:33 |
| gibi | we nead sean-k-mooney to show us what kind of device profile he uses | 15:33 |
| dansmith | yeah he said he was going to do that this morning I think | 15:34 |
| gibi | sorry I have to leave for today :/ I will read back tomorrow | 15:34 |
| dansmith | o/ | 15:34 |
| gibi | o/ | 15:35 |
| dansmith | it also seems like there is a bunch in that "script" that could/should be replaced with client calls | 15:38 |
| dansmith | instead of curl'ing everything | 15:38 |
| openstackgerrit | Dongcan Ye proposed openstack/nova master: libvirt: Check the guest support UEFI https://review.opendev.org/685678 | 15:39 |
| *** eharney has joined #openstack-nova | 15:40 | |
| dansmith | efried: is there any way in the placement osc client to tell what providers are parent/child of each other? | 15:48 |
| efried | dansmith: Almost sure you can see parent RP IDs, but there's not going to be like a tree view or anything. | 15:48 |
| dansmith | do I need a microversion for that? | 15:49 |
| dansmith | in rp show, I don't see anything | 15:49 |
| dansmith | ah yeah, picked a random higher microversion and I see parent_uuid | 15:49 |
| efried | dansmith: there's a --in-tree | 15:49 |
| dansmith | so, the cyborg fake driver is creating a RP peer to the compute node RP, not in a tree | 15:50 |
| efried | oops :P | 15:50 |
| dansmith | I've been kinda punting on looking at how these are modeled, but... is that how it's supposed to be? are we using aggregates to associate those? | 15:50 |
| efried | (I would set OS_PLACEMENT_API_VERSION=1.36 so you don't have to worry about it anymore) | 15:50 |
| efried | No, it's supposed to be a child of the compute node | 15:51 |
| dansmith | okay | 15:51 |
| efried | unless something drastic changed about the design. | 15:51 |
| dansmith | thought so | 15:51 |
| *** ociuhandu_ has joined #openstack-nova | 15:51 | |
| dansmith | efried: btw, Invalid placement client version '1.36'. must be one of: 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16, 1.17, 1.18, 1.19, 1.20, 1.21, 1.22, 1.28 | 15:52 |
| dansmith | dan@guaranine:~$ | 15:52 |
| efried | That's an odd max version, middle of rocky. | 15:53 |
| efried | oh, unless the osc commands individually cap, which they very well might :( | 15:53 |
| dansmith | ugh, osc version handling sucks so bad | 15:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: images: Move qemu-img info calls into privsep https://review.opendev.org/706897 | 15:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: images: Allow the output format of qemu-img info to be controlled https://review.opendev.org/706898 | 15:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Pass request context to extend_volume https://review.opendev.org/706899 | 15:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Correctly resize encrypted LUKSv1 volumes https://review.opendev.org/706900 | 15:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test TEMPEST_EXTEND_ATTACHED_ENCRYPTED_VOLUME https://review.opendev.org/707593 | 15:53 |
| efried | so, never mind, that env var isn't helpful. Yes, agree. | 15:53 |
| dansmith | every time I have to tell people to specify a specific version to do some thing I die a little inside | 15:54 |
| efried | I'm sure it came from a place of, "This command has only been coded to handle up to microversion X, so using anything higher might blow it up, so let's cap it" | 15:54 |
| dansmith | yeah | 15:54 |
| *** ociuhandu has quit IRC | 15:54 | |
| dansmith | and that's fine, but I should be able to specify a max, or have it use its own max when in CLI mode like we do in nova | 15:55 |
| efried | right, you should be able to say 'latest' and have it do the latter. | 15:55 |
| dansmith | so, | 15:55 |
| *** ociuhandu_ has quit IRC | 15:55 | |
| dansmith | it looks like the fake driver just exports devices and something in cyborg itself is what creates the providers | 15:55 |
| dansmith | which really shouldn't happen without a parent, AFAICT, so I guess cyborg itself has a bug, both in how it is creating the provider, and that it is agreeing to create one as a root | 15:56 |
| *** MrWatson has joined #openstack-nova | 15:56 | |
| *** NostawRm has quit IRC | 15:57 | |
| *** mlavalle has joined #openstack-nova | 15:58 | |
| *** spatel has joined #openstack-nova | 16:02 | |
| *** spatel has quit IRC | 16:09 | |
| *** xek_ has joined #openstack-nova | 16:09 | |
| sean-k-mooney | dansmith: you mean in how the cyborg agent on the compute node does an rpc call to the conductor to create and update then placment RP form a perodic task | 16:10 |
| sean-k-mooney | because yse i think that is also an architural bug | 16:10 |
| dansmith | not sure I parsed that | 16:11 |
| dansmith | sean-k-mooney: there should be an RP created by cyborg, which is a child of the compute node provider right? | 16:11 |
| sean-k-mooney | the cyborg agents dont call placement to create the RPs or update them | 16:11 |
| sean-k-mooney | yes | 16:11 |
| dansmith | sean-k-mooney: in my stack, cyborg has created a root provider called "FakeDevice", not child under the compute node | 16:11 |
| *** xek has quit IRC | 16:12 | |
| sean-k-mooney | in my case its a child | 16:12 |
| dansmith | okay, not sure how that got screwed up for me, but this is basically a virgin stack | 16:12 |
| *** artom has quit IRC | 16:13 | |
| sean-k-mooney | am it could be down to the oder in which they started | 16:13 |
| *** artom has joined #openstack-nova | 16:13 | |
| sean-k-mooney | or if the config name is not correct in the cyborg config | 16:13 |
| dansmith | that's a bug then, | 16:13 |
| dansmith | because it shouldn't create it as a root if it doesn't find the parent | 16:13 |
| sean-k-mooney | ya | 16:13 |
| sean-k-mooney | it should likely fail to start the agent and complain loudly in the log | 16:14 |
| dansmith | yes | 16:14 |
| sean-k-mooney | but it think that is a sideffect fo the fact the agentd dont create or manage the RPs | 16:14 |
| dansmith | I don't have a hostname configured in my cyborg.conf, if that's what you mean | 16:14 |
| dansmith | it shouldn't matter | 16:14 |
| dansmith | if you need a uuid for the parent and don't find one, you should not create a root one | 16:14 |
| sean-k-mooney | the [DEFAULT]/host option | 16:15 |
| sean-k-mooney | yes | 16:15 |
| sean-k-mooney | well | 16:15 |
| sean-k-mooney | actully no | 16:15 |
| sean-k-mooney | so in the case where cyborg is managning a device on a node that is not a compute node you should | 16:15 |
| sean-k-mooney | there cinder like use case | 16:15 |
| dansmith | sure, but not in this case | 16:15 |
| sean-k-mooney | ya | 16:15 |
| sean-k-mooney | im not sure they have a way to tell however | 16:16 |
| dansmith | well, then *that* is broken :) | 16:16 |
| sean-k-mooney | ya they may have or need a is_compute_node config option | 16:16 |
| dansmith | so are you thinking that I could delete the provider and restart the conductor and have it re-create it? | 16:16 |
| sean-k-mooney | yes | 16:16 |
| sean-k-mooney | i dont know if it will work but i think it should | 16:17 |
| dansmith | 9-700a-4401-915f-3a9036bf4d4a - - - - -] Error, provider guaranine can not be found: IndexError: list index out of range | 16:18 |
| dansmith | but my compute node provider is the fqdn | 16:18 |
| sean-k-mooney | it could be a fqdn vs host name issue | 16:19 |
| dansmith | the log is full of those errors, yet it's returning None from the _get_root_provider() which is letting it create it without a parent | 16:19 |
| dansmith | so if it's really an error (as evidenced by the log level) it should not be just silently returning None and creating the provider anyway | 16:19 |
| dansmith | is cyborg on storyboard? | 16:19 |
| sean-k-mooney | :( yes i think so | 16:22 |
| dansmith | guh, it's nearly empty | 16:22 |
| dansmith | how do I file a bug? create a new story? | 16:22 |
| *** liuyulong has quit IRC | 16:24 | |
| sean-k-mooney | dansmith: sorry on downstream call but yes i think storybord unfrotunetly | 16:26 |
| dansmith | lol, got a 400 and a 500 from storyboard while trying to save my bug | 16:27 |
| *** spatel has joined #openstack-nova | 16:31 | |
| *** spatel has quit IRC | 16:32 | |
| dansmith | sean-k-mooney: ah, I missed it but I did get host=$short in my cyborg.conf file | 16:36 |
| *** gyee has joined #openstack-nova | 16:36 | |
| dansmith | deleting the provider, updating the conf, restarting the agent fixed me | 16:38 |
| *** ivve has quit IRC | 16:41 | |
| sean-k-mooney | cool | 16:42 |
| sean-k-mooney | so i know what bug is | 16:43 |
| sean-k-mooney | i can go fix it | 16:43 |
| dansmith | devstack doesn't install a cyborg client apparently | 16:43 |
| dansmith | sean-k-mooney: https://storyboard.openstack.org/#!/story/2007310 | 16:43 |
| sean-k-mooney | cyborg default to useing the fqdn we defualt to the hostname | 16:43 |
| sean-k-mooney | for the conf.host value | 16:43 |
| stephenfin | efried: when you've time, can I annoy you with some trivial but nice-to-have patches https://review.opendev.org/#/c/705652/ | 16:43 |
| dansmith | sean-k-mooney: the opposite, but yeah | 16:43 |
| sean-k-mooney | https://review.opendev.org/#/c/696014/2/cyborg/agent/manager.py | 16:45 |
| dansmith | sean-k-mooney: right, but conf.host is set to the short name | 16:45 |
| dansmith | so it's a devstack config thing | 16:45 |
| efried | stephenfin: ack, though my tenure is officially on a timer as of this morning, so I may want to dedicate myself to "important" things where possible? | 16:45 |
| efried | not that I'm doing a great job of that anyway. | 16:45 |
| stephenfin | :( | 16:46 |
| stephenfin | yes, definitely in that case | 16:46 |
| dansmith | cripes, cyborgclient can't actually do anything | 16:46 |
| sean-k-mooney | you need a diffenrt patch that is not merged yet | 16:47 |
| *** rpittau is now known as rpittau|afk | 16:48 | |
| *** ociuhandu has joined #openstack-nova | 16:48 | |
| sean-k-mooney | dansmith: basicaly you need to isntall a patched version of the openstacksdk and then you need a different eversion fo cyborg client | 16:50 |
| sean-k-mooney | ill get the links | 16:50 |
| dansmith | fwiw, I deleted the device profile underneath an instance and now I can't delete the instance | 16:51 |
| sean-k-mooney | ya | 16:51 |
| sean-k-mooney | so i dont think that is the issue | 16:51 |
| sean-k-mooney | i have not been able to delete vms with cyborg devices in general | 16:51 |
| dansmith | no, just noting that I hit that | 16:51 |
| dansmith | oh hah | 16:51 |
| sean-k-mooney | i fails with auth erros for me | 16:52 |
| sean-k-mooney | basically cyborg reject the arq delete with a 401 form keysonte midelware | 16:52 |
| *** ociuhandu has quit IRC | 16:52 | |
| sean-k-mooney | but i can delete by hand | 16:52 |
| sean-k-mooney | i also notice a similar issue which spawaynign vms after it had been running for an hour | 16:53 |
| dansmith | okay | 16:53 |
| sean-k-mooney | i think we are caching or not updating a token someher in the nova side | 16:53 |
| dansmith | I recreated my device profile with the same name and now I'm getting a 401 from cyborg when nova tries to fetch it | 16:53 |
| sean-k-mooney | ya | 16:53 |
| sean-k-mooney | try restarting the nova conductor | 16:53 |
| dansmith | I don't think it's getting to conductor | 16:55 |
| sean-k-mooney | i guss it could be in the schduler. i restarted all the nova serivces | 16:56 |
| *** udesale_ has quit IRC | 16:56 | |
| sean-k-mooney | well i restart all the nova and cyborg services to be more accurate | 16:56 |
| dansmith | if it's not getting to conductor it's not getting to scheduler | 16:58 |
| sean-k-mooney | dansmith: you need https://review.opendev.org/#/c/681391/ and https://review.opendev.org/#/c/679914/ to get the client to work by they way | 16:58 |
| sean-k-mooney | dansmith: where do we get the device profile form the api? | 16:59 |
| sean-k-mooney | are we doing that in the api? | 16:59 |
| *** igordc has joined #openstack-nova | 16:59 | |
| dansmith | idk, i just don't see any traffic in any conductor logs making it look like it's even getting called | 16:59 |
| sean-k-mooney | i assumed it would be later but i guess we might be doing an early check to ensure it exits | 16:59 |
| dansmith | sean-k-mooney: https://review.opendev.org/#/c/631243/57/nova/compute/api.py | 17:01 |
| dansmith | okay yeah, stale token i guess | 17:04 |
| dansmith | had to restart n-api | 17:04 |
| dansmith | now I get Binding failed for ARQ UUIDs | 17:05 |
| *** davidsha has quit IRC | 17:05 | |
| dansmith | which is this from cyborg-api: Feb 19 09:04:37 guaranine devstack@cyborg-api.service[767]: : sqlalchemy.orm.exc.MultipleResultsFound: Multiple rows were found for one() | 17:05 |
| dansmith | from the stack trace, I'd guess there are two deployables for the FakeDriver RP maybe | 17:06 |
| dansmith | since they're using a dns-scoped uuid | 17:06 |
| efried | dansmith: Don't look at this now, but please open tab or however you queue for "later": https://review.opendev.org/#/c/707064/11/upper-constraints.txt@721 | 17:06 |
| prometheanfire | efried: it'd be nice to have it looked at, but I can remove it for now and let it show up next run | 17:08 |
| efried | prometheanfire: ack. | 17:09 |
| dansmith | sean-k-mooney: got a booted instance after cleaning up their database | 17:09 |
| sean-k-mooney | cool | 17:09 |
| dansmith | so definitely some fragility here | 17:10 |
| *** dtantsur is now known as dtantsur|afk | 17:11 | |
| *** jmlowe has quit IRC | 17:11 | |
| *** jmlowe has joined #openstack-nova | 17:12 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Merge qos related renos for Ussuri https://review.opendev.org/706766 | 17:12 |
| dansmith | sean-k-mooney: documented that here: https://storyboard.openstack.org/#!/story/2007310 | 17:14 |
| sean-k-mooney | ya i guess i have had slightly better look since in my case the fqdn and host name are returned the same as just the hostname | 17:15 |
| *** tosky has quit IRC | 17:16 | |
| sean-k-mooney | but its definetly one of the "it worked on my devstack" moments | 17:16 |
| openstackgerrit | Merged openstack/nova master: Remove universal wheel configuration https://review.opendev.org/706466 | 17:17 |
| dansmith | I'm less concerned about the actual hostname thing, since it's actually a devstack thing, | 17:17 |
| openstackgerrit | Merged openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/701754 | 17:17 |
| dansmith | and more concerned about how fragile this is trying to get it fixed | 17:17 |
| dansmith | efried: I don't know the answer nor why we need to name our enums | 17:17 |
| dansmith | efried: if those names go into the DDL then I guess we need a migration for it | 17:18 |
| dansmith | efried: if it's just client-side in the model, then I guess we can just add them/ | 17:18 |
| dansmith | s#/#?# | 17:18 |
| efried | I figured it was going to sound something like that. If we put up a patch that adds the names, will the test results make it clear whether or not we need a migration? (I fear not...) | 17:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-next: Start testing the q35 machine type https://review.opendev.org/708701 | 17:20 |
| dansmith | efried: add them to the models and see if functional tests pass locally | 17:21 |
| dansmith | and then if yeah, it all just works through grenade tests and functional then it should be okay I think | 17:21 |
| dansmith | if the model sync test complains about schema vs. models, then... sadface | 17:22 |
| efried | dansmith: I need to do something locally to make pg tests actually run, but I'm not sure what that is. | 17:22 |
| dansmith | oh is this on pg? | 17:22 |
| efried | if the test result is to be believed. | 17:22 |
| efried | sorry, is that not clear from the context? I'll add it in... | 17:23 |
| efried | yeah Failure in nova.tests.unit.db.test_migrations.TestNovaMigrationsPostgreSQL.test_models_sync | 17:23 |
| efried | That means pg, right? | 17:23 |
| dansmith | yeah sorry I just skimmed to rsplit('.')[-1] | 17:24 |
| *** jmlowe has quit IRC | 17:24 | |
| dansmith | so if it fails on pg, then we probably need a schema migration, which is pretty god awful | 17:24 |
| *** nicolasbock has joined #openstack-nova | 17:24 | |
| efried | prometheanfire: remind me how I would test a nova fix here: can I make the nova patch depend-on the req patch or does it have to be vice versa? | 17:24 |
| dansmith | we don't use alembic, so it's super unfortunate to have to migrate people's databases to take this... :/ | 17:25 |
| prometheanfire | efried: first, a reqs review would be made that included only the bump to alembic, then you'd dep on that | 17:27 |
| jroll | efried: it doesn't look like I'm going to be able to finish the vTPM things in U, so you can go ahead and bump that out of Direction:Approve. sorry :( | 17:28 |
| dansmith | efried: context being PG is definitely clear, I'm ignoring a call to mess with cyborg, so I just wasn't looking closely enough originally when I just hopped over to look | 17:28 |
| efried | no worries, swhy I said for later, didn't want to distract you from cyborg. | 17:29 |
| efried | jroll: ack, thanks for the heads up. | 17:29 |
| jroll | np | 17:29 |
| prometheanfire | efried: https://review.opendev.org/708706 | 17:29 |
| *** nicolasbock has quit IRC | 17:31 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Name Enums https://review.opendev.org/708707 | 17:33 |
| efried | prometheanfire, dansmith: ^ | 17:33 |
| *** evrardjp has quit IRC | 17:34 | |
| *** evrardjp has joined #openstack-nova | 17:34 | |
| *** Sundar has joined #openstack-nova | 17:35 | |
| *** jmlowe has joined #openstack-nova | 17:37 | |
| *** tbachman has quit IRC | 17:41 | |
| *** jmlowe has quit IRC | 17:43 | |
| *** igordc has quit IRC | 17:46 | |
| *** nicolasbock has joined #openstack-nova | 17:46 | |
| *** ociuhandu has joined #openstack-nova | 17:53 | |
| dansmith | sean-k-mooney: so I was able to delete my cyborg instance.. were you saying you just couldn't delete once the token expired? | 17:54 |
| dansmith | and I wonder if that token expiry problem is related to efried's demanding a singleton? | 17:54 |
| sean-k-mooney | ya so i only tried to delete it after an hour or two of other manual tests | 17:55 |
| dansmith | okay | 17:55 |
| sean-k-mooney | im currently trying to fix there multi node devstack support so i dont have an env runing to test with | 17:55 |
| sean-k-mooney | but it was just failing on the keystone token | 17:55 |
| dansmith | gotcha | 17:56 |
| dansmith | sean-k-mooney: so you're fixing the fakedriver too or just the devstack part? | 17:56 |
| sean-k-mooney | i fixed the fake libvirt driver already | 17:56 |
| sean-k-mooney | im not going to fix the config generation | 17:56 |
| dansmith | I mean the fake cyborg driver | 17:56 |
| sean-k-mooney | and i might fix the host name issue too | 17:56 |
| sean-k-mooney | sorry | 17:56 |
| sean-k-mooney | i ment fake cyborg dirver too | 17:57 |
| dansmith | okay | 17:57 |
| sean-k-mooney | im just used to typing libvirt :) | 17:57 |
| sean-k-mooney | so im hopign to fix it so it stacks probly on two nodes with two agents then ill submit a DNM change to nova that adds a multi node jobs with a cyborg flavor and standard tempest | 17:58 |
| dansmith | cool that sounds good | 17:58 |
| sean-k-mooney | im about to go get food but ill be back in an hour or so. | 17:59 |
| *** ociuhandu has quit IRC | 17:59 | |
| sean-k-mooney | i might get the job done later tonight if not ill do it in the morning i dont think it will take too much to get right | 18:00 |
| *** jmlowe has joined #openstack-nova | 18:00 | |
| *** derekh has quit IRC | 18:00 | |
| dansmith | cool | 18:00 |
| dansmith | we're missing a lot of replies to comments from sundar at this point | 18:00 |
| dansmith | like most of the patches have a -1 on them looking for change or clarification | 18:00 |
| sean-k-mooney | ya i need to set some time aside to also go through the patch chain and actully review them but i have been relying on you, gibi and erric to to that mostly and just commeinting if i know the anser and i happend to see the gerrit email notification | 18:03 |
| dansmith | yeah, I'm not sure more comments will help right now, | 18:05 |
| dansmith | so it might be good to hold off and focus on things we can fix, like what you're doing | 18:05 |
| dansmith | I don't want to push Sundar so much that the queue of feedback seems insurmountable before he has to move on | 18:05 |
| sean-k-mooney | ya makes sense | 18:06 |
| dansmith | the more layers of feedback the harder it is to take action sometimes | 18:06 |
| *** TxGirlGeek has quit IRC | 18:06 | |
| dansmith | anybody know how the reference a task in a story in a commit message? | 18:07 |
| TheJulia | dansmith: task: | 18:07 |
| TheJulia | and number | 18:07 |
| dansmith | thanks | 18:07 |
| *** igordc has joined #openstack-nova | 18:22 | |
| *** priteau has quit IRC | 18:27 | |
| *** ivve has joined #openstack-nova | 18:32 | |
| *** jmlowe has quit IRC | 18:33 | |
| bauzas | folks, I'm becoming crazy | 18:36 |
| bauzas | (py37) [sbauza@sbauza nova]$ stestr run | 18:36 |
| bauzas | usage: stestr [-h] [--config-dir DIR] [--config-file PATH] [--debug] | 18:36 |
| bauzas | [--log-config-append PATH] [--log-date-format DATE_FORMAT] | 18:36 |
| bauzas | [--log-dir LOG_DIR] [--log-file PATH] [--nodebug] | 18:36 |
| bauzas | [--nouse-journal] [--nouse-json] [--nouse-syslog] | 18:36 |
| bauzas | [--nowatch-log-file] [--syslog-log-facility SYSLOG_LOG_FACILITY] | 18:36 |
| bauzas | [--use-journal] [--use-json] [--use-syslog] [--version] | 18:36 |
| bauzas | [--watch-log-file] [--remote_debug-host REMOTE_DEBUG_HOST] | 18:36 |
| bauzas | [--remote_debug-port REMOTE_DEBUG_PORT] | 18:36 |
| bauzas | stestr: error: unrecognized arguments: run | 18:36 |
| *** jmlowe has joined #openstack-nova | 18:36 | |
| bauzas | WTF?!!!! | 18:36 |
| bauzas | stestr can't recognize the first argument | 18:36 |
| bauzas | like if argparse wasn't correctly working | 18:36 |
| sean-k-mooney | i guess its because its a postional arg | 18:43 |
| sean-k-mooney | so the non postional arg parser was able to construct but if you had an eeror later it might not be able to finsih construction the rest | 18:44 |
| bauzas | I can litterally run something by doing stestr, then launching the 'run' command | 18:45 |
| sean-k-mooney | what happens if you do stestr --help | 18:45 |
| sean-k-mooney | does it print the command list | 18:46 |
| bauzas | nope | 18:46 |
| bauzas | just the options list | 18:46 |
| sean-k-mooney | ok so the run command is proably fine but one of the others is broken | 18:46 |
| *** larainema has quit IRC | 18:47 | |
| sean-k-mooney | it should print this http://paste.openstack.org/show/789762/ | 18:48 |
| bauzas | sean-k-mooney: in order to run tests, I have to, like I said, just type 'stestr' in the venv, and then once I'm having the (stestr) invite, ask for 'run <mytests>' | 18:48 |
| sean-k-mooney | ya i understand | 18:49 |
| bauzas | actually, I got the same with -h | 18:50 |
| bauzas | I get the command list | 18:50 |
| sean-k-mooney | oh ok | 18:50 |
| sean-k-mooney | by tox or stestr run jsut fail unless you drop into the interactive shell | 18:50 |
| *** ralonsoh has quit IRC | 18:52 | |
| bauzas | correct | 18:52 |
| bauzas | a single tox -epy27 even doesn't work | 18:52 |
| bauzas | without any posargs | 18:53 |
| bauzas | I'm just one second before tableflipping, literally | 18:53 |
| sean-k-mooney | ill see if i can repoduce | 18:53 |
| sean-k-mooney | where you testing a patch or will this happen on master? | 18:53 |
| bauzas | I'm on a branch | 18:53 |
| bauzas | but I rebased | 18:53 |
| bauzas | from master | 18:53 |
| bauzas | and nothing changes | 18:54 |
| sean-k-mooney | ok ill just try and recreate a tox enve with master | 18:54 |
| sean-k-mooney | tox -epy27 wont work on master by the way | 18:54 |
| sean-k-mooney | we dont allow nova to install on 27 anymore | 18:54 |
| bauzas | whoops, s/py27/37 of course | 18:57 |
| sean-k-mooney | "tox -e py37 -r" to recreate the env is workifn fine for me with master | 18:57 |
| sean-k-mooney | you could try doing "stestr -v run" | 18:57 |
| bauzas | holy shit | 18:57 |
| sean-k-mooney | to get verbose output | 18:57 |
| sean-k-mooney | it might tell you what is wrong | 18:57 |
| bauzas | sean-k-mooney: nope http://paste.openstack.org/show/789764/ | 18:58 |
| sean-k-mooney | wait what | 18:58 |
| sean-k-mooney | why is is login sqlacheme form nova.db.sqlalchemy.api | 18:59 |
| bauzas | no idea | 18:59 |
| sean-k-mooney | is it doing a local import | 18:59 |
| sean-k-mooney | are you in nova/nova | 18:59 |
| sean-k-mooney | if so can you go up one level | 18:59 |
| bauzas | I am | 18:59 |
| bauzas | ah no | 19:00 |
| bauzas | i'm in the root repo | 19:00 |
| sean-k-mooney | ya ok | 19:00 |
| bauzas | (py37) [sbauza@sbauza nova]$ pwd | 19:00 |
| bauzas | /home/sbauza/git/openstack/nova | 19:00 |
| sean-k-mooney | ya | 19:00 |
| sean-k-mooney | so it should not be a local import issue with your current directory | 19:00 |
| bauzas | I recreated the venv so many times... | 19:01 |
| sean-k-mooney | i never actully got food when i said i would so im going to go get it now. if you push the chagne somewhere ill try and run it when i get back | 19:01 |
| bauzas | yeah I need to drop too | 19:02 |
| bauzas | but I'm about to quite | 19:02 |
| bauzas | quit | 19:02 |
| bauzas | frankly | 19:02 |
| *** maciejjozefczyk has quit IRC | 19:02 | |
| bauzas | that's making me maaaad | 19:02 |
| bauzas | anyway, good dinner | 19:02 |
| sean-k-mooney | bauzas: i would just push hte patch let teh gate check it and clone a new copy of the repo in the morning | 19:04 |
| sean-k-mooney | just too make sure that its clean | 19:04 |
| sean-k-mooney | bauzas: oh you proably have a local file for opertunistic db testign configured | 19:05 |
| sean-k-mooney | i forget how to configure that but there is a way | 19:06 |
| sean-k-mooney | or maybe that is just a thing in sqlalcemey migrate https://opendev.org/x/sqlalchemy-migrate/src/branch/master/test_db.cfg | 19:09 |
| *** tbachman has joined #openstack-nova | 19:10 | |
| *** vishalmanchanda has quit IRC | 19:11 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | 19:12 |
| sean-k-mooney | ya i guess its hard coded https://github.com/openstack/nova/blob/e20d529dbf656ddcacb7ab3497a6c71e89985f50/nova/tests/unit/db/test_migrations.py#L17-L33 | 19:13 |
| *** tesseract has quit IRC | 19:16 | |
| *** amoralej is now known as amoralej|off | 19:22 | |
| *** mvkr has quit IRC | 19:27 | |
| *** spatel has joined #openstack-nova | 19:36 | |
| efried | stephenfin: did those | 19:37 |
| *** N3l1x has joined #openstack-nova | 19:54 | |
| *** eharney has quit IRC | 19:56 | |
| *** lbragstad has quit IRC | 20:04 | |
| *** eharney has joined #openstack-nova | 20:08 | |
| *** lbragstad has joined #openstack-nova | 20:09 | |
| *** ociuhandu has joined #openstack-nova | 20:12 | |
| *** spatel has quit IRC | 20:13 | |
| *** ociuhandu has quit IRC | 20:16 | |
| *** abaindur has joined #openstack-nova | 20:20 | |
| *** abaindur has quit IRC | 20:21 | |
| *** abaindur has joined #openstack-nova | 20:21 | |
| *** jmlowe has quit IRC | 20:24 | |
| *** ociuhandu has joined #openstack-nova | 20:24 | |
| *** abaindur has quit IRC | 20:26 | |
| *** abaindur has joined #openstack-nova | 20:27 | |
| *** iurygregory has quit IRC | 20:27 | |
| bauzas | sean-k-mooney: nope I didn't configured it | 20:27 |
| *** ociuhandu has quit IRC | 20:31 | |
| *** ociuhandu has joined #openstack-nova | 20:31 | |
| *** tbachman has quit IRC | 20:32 | |
| *** jmlowe has joined #openstack-nova | 20:44 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | 20:45 |
| *** spatel has joined #openstack-nova | 20:49 | |
| *** eharney has quit IRC | 20:53 | |
| bauzas | sean-k-mooney: mmm, cloning nova on another local repo seems to work | 20:53 |
| sean-k-mooney | bauzas: ya you must have a local file or something in that copy which is messign it up | 20:54 |
| bauzas | possibly | 20:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | 20:54 |
| *** jmlowe has quit IRC | 20:56 | |
| *** mgariepy has quit IRC | 21:02 | |
| spatel | sean-k-mooney: do you thing ksmd is good for openstack ? its using 40% cpu on my compute node. | 21:04 |
| sean-k-mooney | ksmd as in kernel shared memory deamon? | 21:04 |
| * sean-k-mooney ask google | 21:04 | |
| spatel | I did and some folks saying disable for compute node | 21:05 |
| sean-k-mooney | yes i would proably disable it also | 21:05 |
| spatel | I will run my load-test and see if any impact. | 21:06 |
| sean-k-mooney | im just checking that its what i think it is | 21:06 |
| spatel | we found why erlang doesn't like two NUMA nodes. | 21:06 |
| spatel | erlang scheduler default migrate process from CPU to CPU and that is why we were getting performance hit | 21:07 |
| sean-k-mooney | ya so assuming its related to https://www.kernel.org/doc/Documentation/vm/ksm.txt which i think it is we recommend disable ksm on all nfv systems | 21:07 |
| spatel | I will disable KSM | 21:07 |
| spatel | sean-k-mooney: where i should change numa_policy to preferred ? (default is lagacy) | 21:08 |
| spatel | does flavor support that feature on stein? | 21:08 |
| *** jmlowe has joined #openstack-nova | 21:09 | |
| sean-k-mooney | spatel: that has never been suported | 21:10 |
| spatel | so i have only option to set it up in /etc/nova/nova.conf? | 21:11 |
| sean-k-mooney | which numa policy are you refering to specificly | 21:11 |
| spatel | https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html | 21:11 |
| spatel | I want to spin up VM across numa (default sriov won't let you do that) | 21:12 |
| sean-k-mooney | ah the pci polices | 21:12 |
| spatel | Yes | 21:12 |
| sean-k-mooney | so you can set that in the config and i recently added it to the flavor | 21:12 |
| sean-k-mooney | i need to check if it merged in train but i think it did | 21:12 |
| spatel | but does it available in stein ? | 21:13 |
| spatel | I am running stein (if its not available in stein then only option is nova.conf right?) | 21:13 |
| sean-k-mooney | actully no it only merged in ussuri https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/vm-scoped-sriov-numa-affinity.html | 21:13 |
| sean-k-mooney | before ussuri you can only set it in the nova.conf for pci alias | 21:13 |
| sean-k-mooney | meaning it does not work with neutron sriov ports | 21:13 |
| spatel | nova-api service or compute? | 21:14 |
| sean-k-mooney | you have to set it in both | 21:14 |
| spatel | i will give it a try.. | 21:14 |
| sean-k-mooney | it will not work if you are using neutron sriov port e.g. vnic_type=direct | 21:14 |
| sean-k-mooney | it will only be applied to pci devices that are requested vai an alias in the flavor | 21:15 |
| sean-k-mooney | neutron sriov only supports legacy before ussuri | 21:15 |
| *** jmlowe has quit IRC | 21:16 | |
| spatel | sean-k-mooney: ohhhh! | 21:18 |
| spatel | i am using vnic_type=direct | 21:18 |
| sean-k-mooney | yes the abiltiy to chagne that was only added in ussuri upstream | 21:18 |
| sean-k-mooney | i have backported it downstream but this is not a candiate for backporting upstream | 21:19 |
| sean-k-mooney | spatel: this https://review.opendev.org/#/c/674072/ is the patch you want | 21:21 |
| spatel | any plan that patch get merge in future release? | 21:23 |
| *** TxGirlGeek has joined #openstack-nova | 21:24 | |
| sean-k-mooney | its merged in master so it will be released in ussuri | 21:24 |
| sean-k-mooney | but its adding a new feature so it cant be backported upstream | 21:24 |
| spatel | sean-k-mooney: totally understand.. | 21:24 |
| sean-k-mooney | downstream we are aboult to do a partial backport with out the support for the image property or notification as we cant backport object changes | 21:25 |
| sean-k-mooney | *able | 21:25 |
| sean-k-mooney | that said we avoid it when we can | 21:25 |
| *** tbachman has joined #openstack-nova | 21:26 | |
| spatel | make sense to avoid thatif there are lots of moving part | 21:26 |
| spatel | http://openstack-in-production.blogspot.com/2015/08/ept-and-ksm-for-high-throughput.html | 21:27 |
| spatel | What do you think about EPT ? | 21:27 |
| sean-k-mooney | you should alway always have it enabeld | 21:27 |
| spatel | CERN suggesting to disable to gain performance | 21:28 |
| sean-k-mooney | if you turn of extended page tables it almost as bad as disbaling kvm and falling back to qemu | 21:28 |
| *** xek_ has quit IRC | 21:28 | |
| spatel | hmm! interesting. | 21:28 |
| sean-k-mooney | our perfomance team messurad a huge performance hit to disabeling for the specter/meltdown mitigations | 21:29 |
| spatel | I have that disabled on compute machine but not on VM. | 21:29 |
| sean-k-mooney | spatel: read https://www.redhat.com/pt-br/blog/understanding-l1-terminal-fault-aka-foreshadow-what-you-need-know specifcally the "Beyond bare metal" section alth the full blog is good too | 21:33 |
| spatel | reading... | 21:33 |
| *** nweinber has quit IRC | 21:38 | |
| sean-k-mooney | if you turn of EPT you fallback to shadowtables which will result in significat qemu overhead in the 10s or % range based on there testing when fixing l1tf | 21:42 |
| spatel | Yes, you are right. (also based on your link) | 21:43 |
| *** mvkr has joined #openstack-nova | 21:58 | |
| *** tosky has joined #openstack-nova | 22:00 | |
| *** spatel has quit IRC | 22:18 | |
| *** dpawlik has quit IRC | 22:21 | |
| *** eharney has joined #openstack-nova | 22:21 | |
| *** slaweq has quit IRC | 22:29 | |
| *** efried has quit IRC | 22:30 | |
| *** jmlowe has joined #openstack-nova | 22:32 | |
| *** efried has joined #openstack-nova | 22:33 | |
| *** ociuhandu has quit IRC | 22:38 | |
| efried | dansmith: results for the Enum thing are back. Func passed; one unit failed but I'm not sure if it means we need a migration; and grenade failed but I can't tell if it's related. https://review.opendev.org/#/c/708707/ | 22:40 |
| *** Sundar has quit IRC | 22:49 | |
| *** jmlowe has quit IRC | 22:51 | |
| *** tkajinam has joined #openstack-nova | 22:58 | |
| *** jmlowe has joined #openstack-nova | 22:59 | |
| *** jmlowe has quit IRC | 23:00 | |
| *** rcernin has joined #openstack-nova | 23:04 | |
| *** jmlowe has joined #openstack-nova | 23:11 | |
| *** mlavalle has quit IRC | 23:15 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use stock mock https://review.opendev.org/708262 | 23:34 |
| *** tosky has quit IRC | 23:34 | |
| *** mvkr has quit IRC | 23:42 | |
| *** ociuhandu has joined #openstack-nova | 23:45 | |
| *** eharney has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!