| *** ociuhandu has joined #openstack-nova | 00:02 | |
| *** ociuhandu has quit IRC | 00:03 | |
| *** ociuhandu has joined #openstack-nova | 00:04 | |
| *** tbachman has quit IRC | 00:06 | |
| *** tbachman has joined #openstack-nova | 00:06 | |
| *** ociuhandu has quit IRC | 00:09 | |
| *** jmlowe has joined #openstack-nova | 00:16 | |
| *** jmlowe has quit IRC | 00:23 | |
| *** dave-mccowan has joined #openstack-nova | 00:23 | |
| *** vishalmanchanda has joined #openstack-nova | 00:24 | |
| *** jmlowe has joined #openstack-nova | 00:32 | |
| *** xiaolin has joined #openstack-nova | 00:45 | |
| *** dave-mccowan has quit IRC | 00:48 | |
| *** jmlowe has quit IRC | 00:55 | |
| *** tbachman has quit IRC | 01:10 | |
| *** yedongcan has joined #openstack-nova | 01:11 | |
| *** zhanglong has joined #openstack-nova | 01:18 | |
| *** ociuhandu has joined #openstack-nova | 02:23 | |
| *** ociuhandu has quit IRC | 02:29 | |
| *** brinzhang_ has quit IRC | 02:34 | |
| *** mkrai has joined #openstack-nova | 03:33 | |
| *** tbachman has joined #openstack-nova | 03:39 | |
| *** udesale has joined #openstack-nova | 04:10 | |
| *** tbachman has quit IRC | 04:31 | |
| *** imacdonn has quit IRC | 04:43 | |
| *** imacdonn has joined #openstack-nova | 04:44 | |
| *** mkrai has quit IRC | 05:17 | |
| *** ociuhandu has joined #openstack-nova | 05:30 | |
| *** mkrai has joined #openstack-nova | 05:31 | |
| *** evrardjp has quit IRC | 05:34 | |
| *** evrardjp has joined #openstack-nova | 05:34 | |
| *** ociuhandu has quit IRC | 05:35 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058 | 05:41 |
|---|---|---|
| *** ratailor has joined #openstack-nova | 05:58 | |
| *** mkrai has quit IRC | 05:59 | |
| *** links has joined #openstack-nova | 06:09 | |
| *** mkrai has joined #openstack-nova | 06:19 | |
| *** ircuser-1 has quit IRC | 06:23 | |
| *** TristanSullivan has quit IRC | 06:34 | |
| *** dpawlik has joined #openstack-nova | 06:48 | |
| *** iurygregory has joined #openstack-nova | 06:57 | |
| *** ociuhandu has joined #openstack-nova | 07:01 | |
| *** ociuhandu has quit IRC | 07:05 | |
| openstackgerrit | Kobi Samoray proposed openstack/nova master: Support large network queries towards neutron https://review.opendev.org/704520 | 07:37 |
| openstackgerrit | Kobi Samoray proposed openstack/nova master: Support large network queries towards neutron https://review.opendev.org/704520 | 07:39 |
| *** Jeffrey4l has quit IRC | 07:41 | |
| *** Jeffrey4l has joined #openstack-nova | 07:41 | |
| *** ralonsoh has joined #openstack-nova | 07:52 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:57 | |
| *** slaweq_ has joined #openstack-nova | 07:58 | |
| *** slaweq_ is now known as slaweq | 07:59 | |
| *** zhanglong has quit IRC | 08:01 | |
| *** ociuhandu has joined #openstack-nova | 08:01 | |
| *** zhanglong has joined #openstack-nova | 08:02 | |
| *** ociuhandu has quit IRC | 08:03 | |
| *** ociuhandu has joined #openstack-nova | 08:04 | |
| *** rpittau|afk is now known as rpittau | 08:10 | |
| *** tkajinam has quit IRC | 08:15 | |
| *** ociuhandu has quit IRC | 08:16 | |
| *** lpetrut has joined #openstack-nova | 08:22 | |
| *** lpetrut has quit IRC | 08:22 | |
| *** lpetrut has joined #openstack-nova | 08:23 | |
| *** mkrai has quit IRC | 08:25 | |
| bauzas | gibi: thanks for +Wing https://review.opendev.org/#/c/552924/ I'll create a FUP change | 08:26 |
| *** mkrai has joined #openstack-nova | 08:27 | |
| *** tesseract has joined #openstack-nova | 08:30 | |
| *** ociuhandu has joined #openstack-nova | 08:35 | |
| *** amoralej|off is now known as amoralej | 08:37 | |
| *** ccamacho has joined #openstack-nova | 08:37 | |
| *** dtantsur|afk is now known as dtantsur | 08:41 | |
| *** ociuhandu has quit IRC | 08:46 | |
| *** ociuhandu has joined #openstack-nova | 08:47 | |
| *** ociuhandu has quit IRC | 08:52 | |
| *** xek has joined #openstack-nova | 08:52 | |
| *** lpetrut has quit IRC | 09:03 | |
| *** ivve has joined #openstack-nova | 09:07 | |
| *** FlorianFa has joined #openstack-nova | 09:18 | |
| gibi | bauzas: I was happy to push it through | 09:23 |
| bauzas | cool thanks | 09:23 |
| *** martinkennelly has joined #openstack-nova | 09:30 | |
| *** derekh has joined #openstack-nova | 09:33 | |
| *** Xuchu has joined #openstack-nova | 09:39 | |
| *** ratailor has quit IRC | 09:43 | |
| *** ratailor has joined #openstack-nova | 09:44 | |
| *** ociuhandu has joined #openstack-nova | 09:45 | |
| *** ociuhandu has quit IRC | 09:49 | |
| *** mkrai has quit IRC | 09:58 | |
| *** damien_r has joined #openstack-nova | 09:58 | |
| *** udesale_ has joined #openstack-nova | 10:00 | |
| *** udesale_ has quit IRC | 10:01 | |
| *** udesale has quit IRC | 10:01 | |
| *** udesale has joined #openstack-nova | 10:01 | |
| *** damien_r has quit IRC | 10:02 | |
| *** aloga has quit IRC | 10:03 | |
| *** purplerbot has joined #openstack-nova | 10:04 | |
| *** mkrai has joined #openstack-nova | 10:09 | |
| *** brinzhang has joined #openstack-nova | 10:11 | |
| *** ociuhandu has joined #openstack-nova | 10:22 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | 10:23 |
| *** ociuhandu has quit IRC | 10:27 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | 10:30 |
| *** udesale has quit IRC | 10:38 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: FUP for NUMA Topology spec https://review.opendev.org/708088 | 10:40 |
| bauzas | gibi: ^ | 10:40 |
| gibi | bauzas: ack | 10:40 |
| gibi | bauzas: thanks, +2 | 10:42 |
| bauzas | kk thanks | 10:42 |
| *** ociuhandu has joined #openstack-nova | 10:44 | |
| *** decrypt has quit IRC | 10:49 | |
| *** mkrai has quit IRC | 10:58 | |
| *** lpetrut has joined #openstack-nova | 11:03 | |
| *** rpittau is now known as rpittau|bbl | 11:03 | |
| *** ratailor has quit IRC | 11:16 | |
| *** ociuhandu has quit IRC | 11:20 | |
| *** ratailor has joined #openstack-nova | 11:23 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 11:32 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 11:36 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 11:42 |
| *** ratailor has quit IRC | 11:47 | |
| *** ociuhandu has joined #openstack-nova | 11:54 | |
| *** ociuhandu has quit IRC | 11:59 | |
| *** aloga has joined #openstack-nova | 12:00 | |
| *** mvkr has joined #openstack-nova | 12:10 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110 | 12:11 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 12:14 |
| *** factor has joined #openstack-nova | 12:15 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 12:25 |
| *** udesale has joined #openstack-nova | 12:31 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 12:35 |
| *** rpittau|bbl is now known as rpittau | 12:37 | |
| *** jaosorior has joined #openstack-nova | 12:37 | |
| *** Luzi has joined #openstack-nova | 12:44 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 12:47 |
| *** maciejjozefczyk has quit IRC | 12:47 | |
| *** nicolasbock has joined #openstack-nova | 12:47 | |
| *** bbowen_ has quit IRC | 12:48 | |
| *** bbowen has joined #openstack-nova | 12:49 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | 12:49 |
| sean-k-mooney | bauzas: gibi by the way rather then adapt the exitisting filter to work on allocation candiates we might actully want to a seperate filtering laywer that works on allocatgion candiates before the existing filters | 12:55 |
| gibi | sean-k-mooney: that could be an alternative | 12:56 |
| sean-k-mooney | that would avoid needing to pass an addtional paramater to all the filters so we wont break out of tree filters by changing the interface | 12:56 |
| gibi | sean-k-mooney: it has a trade off to change the order of the filters as then NTF would run before any other filter | 12:56 |
| gibi | but the such order just affects scheduling performance not scheduling result | 12:57 |
| sean-k-mooney | im suggesting we leave the NTF unchanged and add a new one but yes the oder does affect performance | 12:57 |
| sean-k-mooney | *order | 12:57 |
| sean-k-mooney | you could put the new filter after the exstiing onece i guess | 12:58 |
| sean-k-mooney | the NTF normally should go at the end of the existing list anyway | 12:58 |
| sean-k-mooney | so maybe that would make more sense | 12:58 |
| sean-k-mooney | so prefilters->placemnt->currnent filters->allocation candiate filters->weighers? | 12:59 |
| *** brinzhang has quit IRC | 13:00 | |
| *** brinzhang has joined #openstack-nova | 13:01 | |
| gibi | sean-k-mooney: yeah, NTF tend to be at the end of the list so having the ac filter at the end would be closer to todays behavior | 13:01 |
| sean-k-mooney | from an information gain point of view the host based fileter have the potentail to eliminate multipel allocation candiates by removing the host | 13:02 |
| sean-k-mooney | so i think it makes sesne for them to come after too | 13:02 |
| bauzas | sean-k-mooney: well, let's discuss this during the implementation | 13:02 |
| sean-k-mooney | ya we can | 13:03 |
| sean-k-mooney | i was just wondering if we could avoid breaking out of tree filters | 13:03 |
| sean-k-mooney | which i think this would allow | 13:03 |
| *** ociuhandu has joined #openstack-nova | 13:07 | |
| openstackgerrit | Brian Rosmaita proposed openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/708126 | 13:07 |
| *** maciejjozefczyk has joined #openstack-nova | 13:09 | |
| *** ociuhandu has quit IRC | 13:12 | |
| *** amoralej is now known as amoralej|lunch | 13:12 | |
| gibi | stephenfin: do you have some ideas why jsonutils fails while json does not in https://review.opendev.org/#/c/703133 ? | 13:20 |
| stephenfin | have you got a traceback? | 13:20 |
| gibi | stephenfin: sure, give me a sec | 13:21 |
| gibi | stephenfin: http://paste.openstack.org/show/789642/ | 13:21 |
| gibi | stephenfin: are nova uses old oslo.serialization that is not py37 compatible? | 13:22 |
| sean-k-mooney | it would seam that we are mixing byte and text strings somehwere | 13:23 |
| sean-k-mooney | but this would have broken on py3.5 | 13:23 |
| sean-k-mooney | so its not a py 3.7 thing | 13:23 |
| gibi | sean-k-mooney: right. but the combination for byte and str seems to happen in codecs which is stdlib | 13:26 |
| sean-k-mooney | right so we are expecting to pass in a string | 13:27 |
| stephenfin | gibi: looking at the source, it seems we attempt to decode whatever file we get to utf-8 | 13:27 |
| sean-k-mooney | and its expecting bytes? | 13:27 |
| stephenfin | but I don't know why that's no okay | 13:27 |
| sean-k-mooney | you mean https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L255-L276 | 13:28 |
| stephenfin | at meetings for the day but I'll take a look over the week | 13:28 |
| stephenfin | bauzas: You think you could take a look at this today? https://review.opendev.org/#/c/662522/ | 13:37 |
| *** ociuhandu has joined #openstack-nova | 13:37 | |
| * bauzas clicks | 13:40 | |
| *** dave-mccowan has joined #openstack-nova | 13:41 | |
| bauzas | stephenfin: ok, will look today | 13:41 |
| *** yedongcan has left #openstack-nova | 13:47 | |
| *** stephenfin has left #openstack-nova | 13:49 | |
| *** stephenfin has joined #openstack-nova | 13:49 | |
| *** amoralej|lunch is now known as amoralej | 13:53 | |
| gibi | hm. If I change the test to load the content of the file first and then call jsonutils.loads() then it works | 13:57 |
| gibi | with open(schema_file) as f: | 13:57 |
| gibi | data = f.read() | 13:57 |
| gibi | schema = jsonutils.loads(data) | 13:57 |
| * gibi needs to get away from the keyboard for a while | 13:58 | |
| *** dave-mccowan has quit IRC | 14:06 | |
| openstackgerrit | Brian Rosmaita proposed openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/707738 | 14:07 |
| *** dave-mccowan has joined #openstack-nova | 14:10 | |
| *** lbragstad__ is now known as lbragstad | 14:15 | |
| *** lbragstad has quit IRC | 14:21 | |
| *** eharney has quit IRC | 14:22 | |
| openstackgerrit | Brian Rosmaita proposed openstack/nova master: Absolutely-non-inheritable image properties https://review.opendev.org/708126 | 14:28 |
| *** Luzi has quit IRC | 14:30 | |
| *** vishalmanchanda has quit IRC | 14:32 | |
| *** links has quit IRC | 14:34 | |
| *** zhanglong has quit IRC | 14:36 | |
| *** nweinber has joined #openstack-nova | 14:42 | |
| *** larainema_ has joined #openstack-nova | 14:54 | |
| *** larainema_ is now known as larainema | 14:55 | |
| *** jhesketh has quit IRC | 14:55 | |
| *** artom has joined #openstack-nova | 14:56 | |
| *** jhesketh has joined #openstack-nova | 14:56 | |
| *** lbragstad has joined #openstack-nova | 15:02 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: func tests: move _run_periodics() into own mixin https://review.opendev.org/705545 | 15:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: tests: work around malformed serial XML https://review.opendev.org/705546 | 15:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 15:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 15:04 |
| openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 15:04 |
| *** eharney has joined #openstack-nova | 15:05 | |
| openstackgerrit | Brian Rosmaita proposed openstack/nova master: Absolutely-non-inheritable image properties https://review.opendev.org/708126 | 15:14 |
| *** efried has joined #openstack-nova | 15:15 | |
| openstackgerrit | Brian Rosmaita proposed openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/707738 | 15:21 |
| artom | So I guess something Fedora-specific is wrong with the stable/queens func tests? | 15:23 |
| artom | Because locally I don't get the same failure as https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c05/707887/1/check/nova-tox-functional-py35/c05109a/testr_results.html | 15:24 |
| *** lpetrut has quit IRC | 15:29 | |
| *** rosmaita has joined #openstack-nova | 15:34 | |
| *** mlavalle has joined #openstack-nova | 15:34 | |
| rosmaita | alex_xu: gmann: need your opinion on whether https://review.opendev.org/#/c/707738/ will require a microversion bump | 15:34 |
| *** efried has quit IRC | 15:37 | |
| *** efried has joined #openstack-nova | 15:37 | |
| *** nicolasbock has quit IRC | 15:38 | |
| sean-k-mooney | artom: the functional tests should not be os specific nor should any of the other tests really | 15:38 |
| artom | sean-k-mooney, I know, which is why it's so weird | 15:40 |
| artom | In any case, it's a moot point | 15:40 |
| artom | Because turns out my backport isn't applicable, and I got the root cause completely wrong | 15:40 |
| artom | So back to square 1 for me, and I really don't feel like log diving | 15:40 |
| artom | But no choice :( | 15:40 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058 | 15:42 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058 | 15:43 |
| *** ccamacho has quit IRC | 15:58 | |
| *** ccamacho has joined #openstack-nova | 15:58 | |
| openstackgerrit | Merged openstack/nova master: Support large network queries towards neutron https://review.opendev.org/704520 | 16:04 |
| *** ccamacho has quit IRC | 16:05 | |
| bauzas | stephenfin: FWIW, have a comment https://review.opendev.org/#/c/662522/17 | 16:06 |
| bauzas | stephenfin: just tell me when you see it and then I'll +W it | 16:06 |
| stephenfin | bauzas: Do you mean something more than I provided? https://review.opendev.org/#/c/662522/17/nova/tests/functional/libvirt/test_numa_servers.py | 16:07 |
| sean-k-mooney | efried: regarding https://review.opendev.org/#/c/706276/ i can remove the changes related to the one ussuri spec that got pulled in but for the removal of the template, looking at the other releases we keep it in the root of the specs folder an remove it in the approve/implemented folder | 16:07 |
| bauzas | stephenfin: oh my bad | 16:07 |
| bauzas | stephenfin: lemme look at it | 16:07 |
| bauzas | (for some reason, I only saw the L169 modification) | 16:08 |
| sean-k-mooney | efried: so i think removing the template is correct and the only issue with the auto generated patch was the spec that got finished in ussuri | 16:08 |
| bauzas | stephenfin: +W | 16:09 |
| *** maciejjozefczyk has quit IRC | 16:09 | |
| sean-k-mooney | yay :) it will be nice to have ^ merged | 16:10 |
| sean-k-mooney | also very much https://review.opendev.org/#/c/663382/ | 16:11 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: move implemented spec for train https://review.opendev.org/706276 | 16:20 |
| sean-k-mooney | efried: ^ i fixed the incorrect spec but left the deletion of the symlinks to the template. the teamplate is still n the root spec folder i just wont be listed in teh set of specs on the specs site under specific release | 16:22 |
| stephenfin | bauzas: Thanks :) | 16:30 |
| bauzas | stephenfin: again, apologies for missing it | 16:30 |
| stephenfin | it's all good | 16:30 |
| stephenfin | least we know you and gibi think alike (he suggested adding it in the first place) ;) | 16:31 |
| sean-k-mooney | stephenfin: i have given up on unit test being enough anythime i go near numa at this point | 16:31 |
| sean-k-mooney | i just always assume a new functional test will be needed | 16:32 |
| stephenfin | agreed | 16:34 |
| efried | sean-k-mooney: Technically the reason to never delete anything without providing a redirect is in case there's a link to the old thing somewhere in the wild. | 16:36 |
| efried | For a template for $release I'm not super worried about it, really. | 16:37 |
| efried | but it's the Right Thing To Do | 16:37 |
| *** N3l1x has joined #openstack-nova | 16:39 | |
| efried | sean-k-mooney: Cross-cell resize needs to not be moved to implemented for Train. So since a respin is needed, might as well add those redirects. | 16:45 |
| efried | For that matter, I'm really not convinced we need those templates in the directories in the first place. Maybe starting in V we can just drop them and just have specs/victoria-template.rst | 16:45 |
| efried | or actually I would prefer specs/victoria/template.rst | 16:46 |
| *** tbachman has joined #openstack-nova | 16:48 | |
| *** jmlowe has joined #openstack-nova | 16:52 | |
| *** rpittau is now known as rpittau|afk | 16:54 | |
| *** ivve has quit IRC | 16:58 | |
| sean-k-mooney | efried: sorry was in a meeting just saw your comments ya ill make those changes manually so and update the script in a seperate change | 17:02 |
| sean-k-mooney | efried: and ya we dont need the templates in the directories | 17:02 |
| sean-k-mooney | i think they were there to make copying them 1% simpler | 17:03 |
| *** dtantsur is now known as dtantsur|afk | 17:03 | |
| *** jmlowe has quit IRC | 17:13 | |
| *** jmlowe has joined #openstack-nova | 17:15 | |
| *** udesale has quit IRC | 17:17 | |
| *** ociuhandu_ has joined #openstack-nova | 17:20 | |
| *** ccamacho has joined #openstack-nova | 17:20 | |
| *** dpawlik has quit IRC | 17:22 | |
| *** jmlowe has quit IRC | 17:22 | |
| efried | melwitt: there's no code for nova-audit yet, right? | 17:23 |
| *** ociuhandu has quit IRC | 17:24 | |
| dansmith | gibi: I saw you +2d the bottom patch of the cyborg stuff but there's only +2s three patches up the stack | 17:24 |
| dansmith | gibi: are you comfortable with the whole stack now? I haven't circled back on all the resched stuff yet, but should I? | 17:25 |
| *** ociuhandu_ has quit IRC | 17:25 | |
| dansmith | sean-k-mooney: I don't suppose you've poked at the resched/move operations with the latest patch set yet have you? | 17:25 |
| *** dklyle has joined #openstack-nova | 17:29 | |
| efried | brinzhang: Are you taking over https://review.opendev.org/#/c/623120/ (safer remote console with password authentication)? | 17:30 |
| efried | More specifically the code here https://review.opendev.org/#/c/622336/ (last updated in May) | 17:30 |
| *** factor has quit IRC | 17:30 | |
| *** evrardjp has quit IRC | 17:34 | |
| *** evrardjp has joined #openstack-nova | 17:34 | |
| openstackgerrit | Merged openstack/nova-specs master: FUP for NUMA Topology spec https://review.opendev.org/708088 | 17:39 |
| openstackgerrit | Merged openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058 | 17:39 |
| sean-k-mooney | dansmith: no i have not. would you like me to prioitise that | 17:39 |
| dansmith | sean-k-mooney: well, I just figured since you had been doing testing with that stuff it'd be easier sooner than later | 17:40 |
| dansmith | I suppose we can get on with the set without knowing that and fix it later if it doesn't work it's just one of those things where if we're not going to be able to gate on it normally, it could just never get tested/fixed | 17:41 |
| sean-k-mooney | ok well i deploy 2 vms later today and set up the multi node env with the fake driver. | 17:42 |
| dansmith | sean-k-mooney: yeah doing it with the fake driver seems enough to make sure the plumbing is good at least | 17:44 |
| sean-k-mooney | cool ill do that so. | 17:45 |
| dansmith | sean-k-mooney: is it possible that hacking some multi-node-ness on top of the tempest test patch in this set would be worthwhile for gating? | 17:45 |
| sean-k-mooney | well i can just run the standard tempest multinode test with a cyborg flavor | 17:45 |
| sean-k-mooney | i could proably hack up an experimtal job to do that | 17:46 |
| sean-k-mooney | but im not sure if that is worth it or not | 17:46 |
| sean-k-mooney | i guess i could add tests to the plugin | 17:46 |
| *** ociuhandu has joined #openstack-nova | 17:51 | |
| *** mvkr has quit IRC | 17:52 | |
| efried | lyarwood: virt-bfv-instance-rescue -- what state is this code in? Would you say ready for review? | 17:54 |
| efried | https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue+status:open | 17:54 |
| *** cz3 is now known as tequilasunset | 17:55 | |
| *** tequilasunset is now known as cz3 | 17:56 | |
| openstackgerrit | Merged openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 17:59 |
| *** ociuhandu has quit IRC | 18:00 | |
| *** derekh has quit IRC | 18:00 | |
| *** ircuser-1 has joined #openstack-nova | 18:01 | |
| *** tesseract has quit IRC | 18:02 | |
| *** ociuhandu has joined #openstack-nova | 18:05 | |
| *** rcernin has quit IRC | 18:06 | |
| *** mordred has quit IRC | 18:06 | |
| efried | kashyap: What's the state of https://review.opendev.org/#/q/topic:bp/allow-secure-boot-for-qemu-kvm-guests+status:open ? | 18:06 |
| *** klippo has quit IRC | 18:07 | |
| *** mordred has joined #openstack-nova | 18:09 | |
| *** jmlowe has joined #openstack-nova | 18:09 | |
| gibi | dansmith: I will check the cyborg series tomorrow | 18:10 |
| *** martinkennelly has quit IRC | 18:14 | |
| *** jmlowe has quit IRC | 18:19 | |
| *** rcernin has joined #openstack-nova | 18:20 | |
| *** jmlowe has joined #openstack-nova | 18:24 | |
| *** jmlowe has quit IRC | 18:27 | |
| *** jmlowe has joined #openstack-nova | 18:29 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Move 'live migration with vpmems' spec https://review.opendev.org/708229 | 18:30 |
| *** larainema has quit IRC | 18:30 | |
| efried | lyarwood: what about this one https://review.opendev.org/#/q/topic:bp/virt-rescue-stable-disk-devices+status:open | 18:37 |
| *** ociuhandu has quit IRC | 18:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing evacuate policies https://review.opendev.org/708230 | 18:41 |
| *** ociuhandu has joined #openstack-nova | 18:41 | |
| *** jmlowe has quit IRC | 18:41 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing evacuate policies https://review.opendev.org/708230 | 18:41 |
| efried | dustinc: checking in on provider config. | 18:41 |
| *** ociuhandu has quit IRC | 18:47 | |
| *** klippo has joined #openstack-nova | 18:47 | |
| melwitt | efried: no code yet | 18:49 |
| efried | thx | 18:49 |
| *** mvkr has joined #openstack-nova | 18:51 | |
| *** amoralej is now known as amoralej|off | 18:52 | |
| *** ralonsoh has quit IRC | 18:55 | |
| dansmith | gibi: aight | 18:59 |
| *** jmlowe has joined #openstack-nova | 19:00 | |
| dansmith | efried: do you know enough about zuul things to guess at how difficult it would be to make the cyborg job run with multiple nodes? | 19:00 |
| dansmith | it's been a long time since I've had to look at this stuff, and things have evolved way out of my scope of understanding | 19:00 |
| dansmith | I'm wondering if it's tied to n-cpu enough that just spinning up another node where n-cpu will be installed would be enough to properly configure the cyborg bits? | 19:01 |
| efried | dansmith: Sorry, no, I would probably ask sean-k-mooney's help if I had to go there. | 19:01 |
| dansmith | yeah, trying not to just depend on him for everything :D | 19:01 |
| efried | depending on me for anything might not be the best strategy either. | 19:02 |
| sean-k-mooney | dansmith: making the job multinode is just changing the nodeset and then for the subnode defining sliktly differnet setting in the local.conf | 19:05 |
| sean-k-mooney | dansmith: the cyborg devstack plugin appartly support multi node so when i get it stackted that way locally i can try and push a patch on top of the current cyborg tempest patch that deploys it multi node | 19:06 |
| dansmith | sean-k-mooney: okay I was just about to look through the cyborg devstack stuff before my call just now to see, but good to know | 19:07 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing evacuate policies https://review.opendev.org/708230 | 19:07 |
| sean-k-mooney | we basically just have to disabel the cyborg conductor and api services so that it just install the cyborg agent | 19:07 |
| dansmith | yeah, I figured.. do they not look at n-cpu to determine whether or not they should install the other things? I would think that would be a reasonable sentinel | 19:08 |
| dansmith | unless they really want to be able to be installed in isolation | 19:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-evacuate https://review.opendev.org/708235 | 19:14 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-evacuate policies https://review.opendev.org/708237 | 19:20 |
| *** maciejjozefczyk has joined #openstack-nova | 19:22 | |
| *** mvkr has quit IRC | 19:32 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 19:32 | |
| *** maciejjozefczyk has quit IRC | 19:33 | |
| *** jmlowe has quit IRC | 19:37 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:38 | |
| *** maciejjozefczyk_ has quit IRC | 19:40 | |
| *** klippo has quit IRC | 19:46 | |
| *** openstackstatus has quit IRC | 19:49 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 19:52 | |
| *** maciejjozefczyk has quit IRC | 19:54 | |
| *** jaosorior has quit IRC | 20:02 | |
| *** ociuhandu has joined #openstack-nova | 20:04 | |
| *** ociuhandu has quit IRC | 20:09 | |
| *** hoonetorg has quit IRC | 20:14 | |
| *** hoonetorg has joined #openstack-nova | 20:18 | |
| *** klippo has joined #openstack-nova | 20:20 | |
| *** maciejjozefczyk_ has quit IRC | 20:36 | |
| *** maciejjozefczyk has joined #openstack-nova | 20:37 | |
| *** ociuhandu has joined #openstack-nova | 20:42 | |
| *** eharney has quit IRC | 20:43 | |
| *** nicolasbock has joined #openstack-nova | 20:43 | |
| *** ociuhandu has quit IRC | 20:45 | |
| *** ociuhandu has joined #openstack-nova | 20:45 | |
| *** ociuhandu has quit IRC | 20:51 | |
| *** prometheanfire has joined #openstack-nova | 20:52 | |
| prometheanfire | reqs update causing issues, might be mock https://review.opendev.org/#/c/707064/ | 20:52 |
| prometheanfire | https://review.opendev.org/#/c/708232 is how octavia solved it | 20:52 |
| sean-k-mooney | prometheanfire: whats the backport candiate lable in gerrit? is that new | 20:56 |
| prometheanfire | ya, first time I've seen it | 20:57 |
| sean-k-mooney | i wonder if that is enforced anyway e.g. will it prevent you form cherry picking or something | 20:57 |
| sean-k-mooney | if not im not sure its very useful | 20:57 |
| sean-k-mooney | although it might be | 20:57 |
| *** mlavalle has quit IRC | 21:01 | |
| efried | prometheanfire: are we really going to fix this, rather than letting mock fix self and blacklisting 4.0.1? | 21:03 |
| prometheanfire | efried: talking about mock? Is there an upstream bug you are talking about? | 21:06 |
| efried | prometheanfire: Yes. Don't know, would assume if it breaks half a dozen openstack projects that we know of, there will be, or there should be. | 21:07 |
| sean-k-mooney | by the way now that we using python3 only is there any reason to keep using mock the lib | 21:07 |
| sean-k-mooney | we should be able to drop it as a dep an just use the standard lib version now | 21:08 |
| prometheanfire | sean-k-mooney: good point, but that's on the projects themselves :P | 21:08 |
| sean-k-mooney | sure i was asking more for nova | 21:09 |
| efried | sean-k-mooney: I don't even know how we would do that. Can you propose a patch? | 21:09 |
| efried | sean-k-mooney: Like, how would we prevent picking up transitive deps etc? | 21:09 |
| *** nweinber has quit IRC | 21:09 | |
| sean-k-mooney | ya so i dont know if we could prevent it | 21:09 |
| sean-k-mooney | but we could just stop listing it in our test requirements | 21:10 |
| sean-k-mooney | eventurally if we got all the project to do that we would stop using it | 21:10 |
| efried | prometheanfire: At a quick look, there are on the order of a hundred uses of mock spec in nova. I would rather find a better way to fix this than hacking dir() into each of them (and it *is* a hack). | 21:10 |
| efried | sean-k-mooney: since it's in the test env, hopefully projects only have it in their test-requirements, which *should* mean the only transitive deps we would have to worry about would be things like oslotest. But... no idea. | 21:11 |
| prometheanfire | efried: if upstream considers it a bug (aka, they plan on fixing something) we can blacklist 4.0.0/4.0.1 | 21:12 |
| prometheanfire | otherwise we are in denial | 21:12 |
| efried | prometheanfire: okay, that was going to be my next question: also broken in 4.0.0? | 21:12 |
| prometheanfire | efried: not sure, this jumped over it, but I imagine it has the same issue | 21:12 |
| sean-k-mooney | ya so os-vif does not use it as far as i know. ill remove it if it does. os-brick might but other then that the only other poject nova really depends on is oslo | 21:12 |
| sean-k-mooney | i guess hacking also | 21:13 |
| efried | prometheanfire: okay, so we need to make sure an upstream issue is opened. They may kill it, but at least the path would be clear. If you don't know of one already, or know of someone who would know, I can go digging... | 21:13 |
| efried | johnsom: ^ ? | 21:14 |
| johnsom | Reading scroll back | 21:14 |
| efried | meanwhile I'll try a local build with mock removed from reqs and see if the venv still installs it... | 21:14 |
| sean-k-mooney | ya so bunch of oslo libs use it | 21:15 |
| sean-k-mooney | http://codesearch.openstack.org/?q=mock&i=nope&files=test-requirements.txt&repos=openstack/oslo-cookiecutter,openstack/oslo-specs,openstack/oslo.cache,openstack/oslo.concurrency,openstack/oslo.config,openstack/oslo.context,openstack/oslo.db,openstack/oslo.i18n,openstack/oslo.limit,openstack/oslo.log,openstack/oslo.messaging,openstack/oslo.middleware,openstack/oslo.policy,openstack/oslo.privsep,opensta | 21:15 |
| sean-k-mooney | ck/oslo.reports,openstack/oslo.rootwrap,openstack/oslo.serialization,openstack/oslo.service,openstack/oslo.tools,openstack/oslo.upgradecheck,openstack/oslo.utils,openstack/oslo.versionedobjects,openstack/oslo.vmware,openstack/oslotest | 21:15 |
| efried | f | 21:15 |
| *** jmlowe has joined #openstack-nova | 21:15 | |
| johnsom | backport candidate is a tool the Octavia cores are using to track patches for backport to stable branches. We added that for our repos. | 21:15 |
| johnsom | Since.... Storyboard...... Enough said | 21:16 |
| efried | johnsom: I was poking you about whether there's a known bug opened against mock for this | 21:16 |
| sean-k-mooney | efried: what we could do is update the requriements file only install mock on python2 | 21:16 |
| johnsom | efried I burned my morning trying to fix a cause and or fix for this. No luck. I'm also not sure this is the same issue your project has with the UC changes. | 21:17 |
| sean-k-mooney | we would then need to update all the projects. | 21:17 |
| efried | sean-k-mooney: not sure that helps, | 21:17 |
| efried | But taking that idea... | 21:17 |
| efried | It might be possible to say | 21:17 |
| efried | mock;python!=3.xx | 21:17 |
| efried | johnsom: yeah, valid point, I didn't actually look. | 21:17 |
| *** maciejjozefczyk has quit IRC | 21:17 | |
| johnsom | We are having the same discussion, whether we should be using this package or reverting to the built-in now. | 21:17 |
| sean-k-mooney | ya so we have a way to match based on python version in the requeriments file already | 21:17 |
| efried | well, fwiw, simply removing mock from test-requirements didn't stop it from installing in the venv. Imagine we would have to yank it from oslotest and oslo.vmware at least. | 21:18 |
| sean-k-mooney | efried: i can ask the requirements folk about it tomorrow seperate form the current disucssion | 21:18 |
| sean-k-mooney | efried: yes we would | 21:18 |
| sean-k-mooney | efried: if you mannually remove it form the enve does it resovel the issue | 21:19 |
| efried | right -- prometheanfire fyi ^ unless you know a way we can explicitly prevent mock from installing, we'll still get it from transitive if we just remove it from our own test-requirements. | 21:19 |
| johnsom | Agreed, it is a total hack, but it was only in "legacy" code for us, so we were like.... good enough, it's going to die anyway. | 21:19 |
| prometheanfire | heh, that's a good point | 21:20 |
| *** artom has quit IRC | 21:20 | |
| prometheanfire | efried: I don't know of one yet | 21:20 |
| efried | johnsom: I totally wasn't judging you btw :P | 21:21 |
| sean-k-mooney | prometheanfire: have you confirmed if removing the lib version resolved the issue | 21:21 |
| sean-k-mooney | also what is the issue? | 21:21 |
| efried | https://ad2781ccb869c0ef3e99-0fce708e89812c28d28e2be1213f1c9b.ssl.cf5.rackcdn.com/707064/10/check/cross-nova-py36/d1c7fa6/testr_results.html | 21:22 |
| prometheanfire | I don't have a link to an issue yet, this is bigger than I first though that it was | 21:22 |
| johnsom | Yeah, your logs don't look like the same issue we had | 21:22 |
| sean-k-mooney | "ValueError: Sentinels must not start with _" ? | 21:23 |
| johnsom | Ah, ok, some are kind of similar | 21:23 |
| johnsom | Yeah, that appears to be on a "spec" mock | 21:23 |
| prometheanfire | heh https://github.com/testing-cabal/mock/pull/482 | 21:23 |
| sean-k-mooney | right so we could just replace all uses of import mock with import unittest.mock? | 21:25 |
| sean-k-mooney | to get rid of the dep on mock the lib | 21:25 |
| efried | "just" | 21:25 |
| sean-k-mooney | if we wanted too in the futrue and add a hacking check | 21:25 |
| sean-k-mooney | efried: its hopefully 1 sed command but yes | 21:26 |
| sean-k-mooney | it could explode | 21:26 |
| efried | 384 occurrences. | 21:26 |
| prometheanfire | well, there's a way to find out I guess | 21:27 |
| efried | yeah, working on it. | 21:28 |
| sean-k-mooney | there has been a long standing issue in nova where we cant use self.assertRaises as a context manager in a with statement which im pretty sure is caused by mock the lib by the way whic this might also fix | 21:28 |
| efried | prometheanfire, sean-k-mooney, johnsom: so yeah, that fixes it, at least for the one instance I tried. | 21:29 |
| efried | s/^import mock$/from unittest import mock/ | 21:29 |
| prometheanfire | heh | 21:29 |
| johnsom | Hmmm, so tempting..... grin | 21:29 |
| sean-k-mooney | can you do that for all nova and see if the tests still run | 21:29 |
| johnsom | Yeah, I think I will try that too | 21:29 |
| efried | sean-k-mooney: yeah but I'm not gonna run locally. | 21:30 |
| efried | My laptop will burn a hole to the center of the earth. | 21:30 |
| efried | I'll let zuul do it. | 21:30 |
| sean-k-mooney | ok | 21:30 |
| johnsom | It's a mock revolt. lol | 21:30 |
| sean-k-mooney | if it does have issue i guess we could just do it selectivly to solve the issues we currently have until either mock is fixt or we fix the issues we find | 21:31 |
| efried | sean-k-mooney: the sed command works fine... except for the pep8 requirement to sort imports :P | 21:32 |
| sean-k-mooney | autopep8 might fix that for you | 21:32 |
| sean-k-mooney | unlike black it only fixes the minium amount of stuff to pass pep8 | 21:32 |
| sean-k-mooney | so it does not break the worlds and passes our gate | 21:33 |
| sean-k-mooney | anyway we coudl cross that bridge when we see if it even passes the zuul run | 21:33 |
| efried | prometheanfire: having proven this is a bug in the mock library, are you more convinced that we should blacklist the mock versions? | 21:37 |
| sean-k-mooney | got to love that commit message https://github.com/testing-cabal/mock/commit/9e5e0380626fd3c540aa4799df0e794cf24d16aa | 21:38 |
| prometheanfire | efried: ya, kinda sucks, but ok | 21:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use stock mock https://review.opendev.org/708262 | 21:38 |
| *** mvkr has joined #openstack-nova | 21:38 | |
| efried | prometheanfire: if you want to try making your patch dep on ^ ... | 21:38 |
| *** eharney has joined #openstack-nova | 21:39 | |
| efried | sean-k-mooney: --^ | 21:39 |
| johnsom | Yeah, octavia seems to pass fine with the native mock | 21:39 |
| efried | o queso we need a bug against mock | 21:39 |
| efried | am I reading this right that there are zero open issues? | 21:40 |
| efried | am I looking at the right repo? | 21:40 |
| sean-k-mooney | and 404 closed | 21:40 |
| johnsom | Zero for that repo | 21:40 |
| johnsom | Though they pull in from the native bugs too | 21:41 |
| sean-k-mooney | i guess they just fix them quickly or close them as wont fix | 21:41 |
| prometheanfire | efried: well, for me I'm blacklisting on the reqs side, not nova side | 21:41 |
| sean-k-mooney | e.g. they dont leave them open for log | 21:41 |
| sean-k-mooney | *long | 21:41 |
| efried | prometheanfire: I assume we would like to be able to continue following upgrades here, given that trying to fix the transitive deps through all of openstack would be hard and take long. So we should still open an issue for this. Agree? | 21:43 |
| sean-k-mooney | efried: if it broke us it will proably break others | 21:44 |
| sean-k-mooney | so its worth reporting in any case | 21:44 |
| prometheanfire | efried: ya, definitely | 21:44 |
| *** xek has quit IRC | 21:45 | |
| efried | prometheanfire, sean-k-mooney, johnsom: https://github.com/testing-cabal/mock/issues/487 | 21:46 |
| *** nicolasbock has quit IRC | 21:46 | |
| prometheanfire | watching, thanks | 21:47 |
| prometheanfire | I'll submit a blacklist review to the reqs repo in a few min | 21:47 |
| prometheanfire | submitted and updated the gr update review | 21:54 |
| sean-k-mooney | oh looking at that traceback this looks like our error | 21:54 |
| sean-k-mooney | the reason its passing on python 3.7 is _is_coroutine was likely added by python 3.8 | 21:55 |
| efried | johnsom: want to throw https://zuul.opendev.org/t/openstack/build/c5fd6cadc9bf4b3b9ea81372ef047246/log/job-output.txt#4605 in there? | 21:56 |
| efried | sean-k-mooney: what do you mean passing on py37? It failed locally for me on py37 | 21:56 |
| sean-k-mooney | with unittest.mock | 21:57 |
| johnsom | Yeah, I can | 21:57 |
| *** ociuhandu has joined #openstack-nova | 22:00 | |
| sean-k-mooney | efried: basiacly i think we are asserting that that the attibute does not start with _ incorrectly here https://github.com/openstack/oslo.utils/blob/master/oslo_utils/fixture.py#L81-L82 | 22:04 |
| sean-k-mooney | or actully no maybe that is not the issue | 22:04 |
| sean-k-mooney | that is where the exctip is being raised but i have looked at why we are calling that code | 22:05 |
| efried | yeah, the issue is that the wrong `name` is now getting to that point. | 22:05 |
| efried | probably '_AutoSpecMagicMock' as opposed to the name of the actual sentinel. | 22:05 |
| sean-k-mooney | ya | 22:06 |
| sean-k-mooney | so i was wondering is this a change in python 3.8 | 22:06 |
| *** ociuhandu has quit IRC | 22:06 | |
| sean-k-mooney | that they have now backported to mock the lib | 22:06 |
| sean-k-mooney | or is it a mock the lib issue | 22:07 |
| efried | sean-k-mooney: do you have 3.8 installed somewhere? Easy enough to try it out. | 22:07 |
| efried | Just | 22:08 |
| efried | .tox/py38/bin/pip install -U mock | 22:08 |
| efried | and run nova.tests.unit.virt.libvirt.test_host.HostTestCase | 22:08 |
| efried | ...with stock/lib mock | 22:08 |
| sean-k-mooney | mock the lib give you the py38 behavior on all python versions | 22:09 |
| sean-k-mooney | and i might let me check | 22:10 |
| sean-k-mooney | im wonder if its related to https://bugs.python.org/issue39082 or https://bugs.python.org/issue39485 | 22:12 |
| *** efried has quit IRC | 22:12 | |
| *** efried has joined #openstack-nova | 22:15 | |
| *** adrianc has quit IRC | 22:15 | |
| *** lennyb has quit IRC | 22:17 | |
| *** adrianc has joined #openstack-nova | 22:17 | |
| *** slaweq has quit IRC | 22:17 | |
| *** lennyb has joined #openstack-nova | 22:20 | |
| *** nweinber has joined #openstack-nova | 22:23 | |
| *** jmlowe has quit IRC | 22:27 | |
| *** nweinber has quit IRC | 22:34 | |
| *** jmlowe has joined #openstack-nova | 22:36 | |
| *** jmlowe has quit IRC | 22:53 | |
| *** tkajinam has joined #openstack-nova | 22:59 | |
| *** tkajinam has quit IRC | 22:59 | |
| *** tkajinam has joined #openstack-nova | 23:01 | |
| *** openstackstatus has joined #openstack-nova | 23:02 | |
| *** ChanServ sets mode: +v openstackstatus | 23:02 | |
| *** igordc has joined #openstack-nova | 23:03 | |
| *** slaweq has joined #openstack-nova | 23:11 | |
| sean-k-mooney | efried: regarding https://review.opendev.org/#/c/702451/10 the conenction to the nova net removal is that stephenfin removed the nova.network.api modules earlier in the series and now image module was the only one with a .api module so stephenfin wrote that patch to make them all consitent | 23:15 |
| sean-k-mooney | efried: but ya it confused the hell out of me too at first | 23:15 |
| sean-k-mooney | also i jsut realised what time it is so o/ night all | 23:15 |
| *** slaweq has quit IRC | 23:16 | |
| *** ociuhandu has joined #openstack-nova | 23:30 | |
| *** ociuhandu has quit IRC | 23:35 | |
| *** mvkr has quit IRC | 23:38 | |
| *** artom has joined #openstack-nova | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!