Wednesday, 2020-02-12

*** Liang__ has quit IRC00:03
*** Liang__ has joined #openstack-nova00:04
*** rcernin has joined #openstack-nova00:07
*** artom has quit IRC00:10
*** slaweq has joined #openstack-nova00:11
*** artom has joined #openstack-nova00:14
*** artom has quit IRC00:15
*** artom has joined #openstack-nova00:15
*** slaweq has quit IRC00:16
*** tosky has quit IRC00:38
*** macz has quit IRC00:38
*** rcernin has quit IRC00:55
*** rcernin has joined #openstack-nova00:55
*** masayukig is now known as migawa|AFK01:08
*** migawa|AFK is now known as migawa01:09
*** slaweq has joined #openstack-nova01:11
*** slaweq has quit IRC01:16
*** brinzhang has quit IRC01:22
*** damien_r has joined #openstack-nova01:25
*** brinzhang has joined #openstack-nova01:51
*** slaweq has joined #openstack-nova02:11
*** damien_r has quit IRC02:14
*** slaweq has quit IRC02:16
*** macz has joined #openstack-nova02:40
*** macz has quit IRC02:45
*** rcernin has quit IRC03:06
*** mkrai has joined #openstack-nova03:11
*** slaweq has joined #openstack-nova03:11
*** slaweq has quit IRC03:16
*** tbachman has quit IRC03:20
*** psachin has joined #openstack-nova03:22
*** rcernin has joined #openstack-nova03:23
*** mkrai has quit IRC03:45
*** udesale has joined #openstack-nova04:05
*** gyee has quit IRC04:08
*** slaweq has joined #openstack-nova04:11
*** vishalmanchanda has joined #openstack-nova04:13
*** slaweq has quit IRC04:16
*** rcernin has quit IRC04:16
*** rcernin has joined #openstack-nova04:16
*** mkrai has joined #openstack-nova04:22
*** TxGirlGeek has quit IRC04:32
*** psachin has quit IRC04:33
*** artom has quit IRC04:35
*** macz has joined #openstack-nova04:41
*** dave-mccowan has quit IRC04:43
*** macz has quit IRC04:46
*** migawa is now known as migawa|lunch|AFK04:50
*** rcernin is now known as rcernin|lunch05:01
*** slaweq has joined #openstack-nova05:11
*** slaweq has quit IRC05:16
*** migawa|lunch|AFK is now known as migawa|lunch05:18
*** evrardjp has quit IRC05:34
*** evrardjp has joined #openstack-nova05:34
*** mmethot_ has joined #openstack-nova05:35
*** mmethot has quit IRC05:37
*** macz has joined #openstack-nova05:41
*** zhanglong has joined #openstack-nova05:42
*** macz has quit IRC05:45
*** ratailor has joined #openstack-nova05:51
*** macz has joined #openstack-nova05:58
*** macz has quit IRC06:03
*** slaweq has joined #openstack-nova06:11
*** slaweq has quit IRC06:16
*** mlycka has joined #openstack-nova06:40
*** slaweq has joined #openstack-nova07:08
*** slaweq has quit IRC07:15
*** rpittau|afk is now known as rpittau07:21
*** ivve has quit IRC07:24
*** macz has joined #openstack-nova07:24
*** yoctozepto has quit IRC07:28
*** yoctozepto has joined #openstack-nova07:28
*** macz has quit IRC07:29
*** brinzhang has quit IRC07:29
*** lpetrut has joined #openstack-nova07:31
*** yoctozepto has quit IRC07:33
*** iurygregory has joined #openstack-nova07:35
*** slaweq has joined #openstack-nova07:51
*** imacdonn has quit IRC07:54
*** imacdonn has joined #openstack-nova07:54
*** maciejjozefczyk has joined #openstack-nova07:54
*** slaweq has quit IRC07:57
*** slaweq has joined #openstack-nova07:59
*** yoctozepto has joined #openstack-nova07:59
*** xek_ has joined #openstack-nova08:09
*** tkajinam has quit IRC08:10
*** tosky has joined #openstack-nova08:22
*** Liang__ has quit IRC08:22
*** Liang__ has joined #openstack-nova08:23
*** amoralej|off is now known as amoralej08:26
*** ccamacho has joined #openstack-nova08:27
*** mkrai has quit IRC08:33
*** mkrai has joined #openstack-nova08:37
*** ralonsoh has joined #openstack-nova08:38
*** ivve has joined #openstack-nova08:45
*** dtantsur|afk is now known as dtantsur08:45
gibiefried_afk, sean-k-mooney, dansmith: read up on the numa fallback discussion from yesterday. impressive work. I need to digest the result09:02
*** iurygregory has quit IRC09:21
*** tetsuro has joined #openstack-nova09:27
*** jangutter has joined #openstack-nova09:27
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240009:30
*** xiaolin has quit IRC09:34
openstackgerritLee Yarwood proposed openstack/nova master: WIP libvirt: Fix attached encrypted LUKSv1 volume extension  https://review.opendev.org/70690009:38
*** iurygregory has joined #openstack-nova09:39
*** ileixe has quit IRC09:43
*** xiaolin has joined #openstack-nova09:43
openstackgerritGuo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication  https://review.opendev.org/62312009:44
*** ileixe has joined #openstack-nova09:44
*** ileixe has joined #openstack-nova09:45
*** ociuhandu has joined #openstack-nova09:56
*** martinkennelly has joined #openstack-nova09:56
bauzasgibi: yeah I did it too10:00
bauzasI'll work on a new revision10:01
*** xiaolin has quit IRC10:03
*** derekh has joined #openstack-nova10:13
bauzasgibi: honestly, I'm looking at https://review.opendev.org/#/c/552924/17/specs/ussuri/approved/numa-topology-with-rps.rst@516 and I don't know what the outcome consensus...10:14
bauzaswhat is*10:14
bauzasgibi: efried_afk tried to summarize but that's still a bit confusing for me10:15
*** ileixe has quit IRC10:18
*** rcernin|lunch has quit IRC10:22
*** kaisers has quit IRC10:27
*** kaisers has joined #openstack-nova10:35
*** rcernin|lunch has joined #openstack-nova10:36
*** jangutter has quit IRC10:51
*** mkrai has quit IRC10:57
*** udesale has quit IRC11:06
*** vishalmanchanda has quit IRC11:12
*** zhanglong has quit IRC11:19
gibibauzas: I had a doctors appointment until now and now jump on the meeting. After that I will try to summarize how I understood the consensus11:26
gibiand crosscheck it with your summary11:26
bauzasmerging two calls AFAIK11:26
bauzasAFAICU*11:26
bauzasanyway, i'll try to provide a new revision11:27
*** rpittau is now known as rpittau|bbl11:33
*** tbachman has joined #openstack-nova11:36
*** tbachman has quit IRC11:42
sean-k-mooneybauzas: gibi im just going to grab a coffe but do you want to have a quick bluejeans call to recap on where we are with the numa spec11:46
sean-k-mooneyi can explain what the alternitive is in more detail. i think the last sticking point is just the default and how the query is done11:47
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs  https://review.opendev.org/55292411:48
bauzassean-k-mooney: sorry but no11:48
bauzasI need to go lunch and then I'll have a doctor appointment11:48
bauzasat 2pm11:48
bauzas(my time)11:48
bauzasremember, not all people work after 6pm11:48
bauzassean-k-mooney: and when i read your comments that are around 3am your time, my point is : 'heh, Sean, please go to bed!" ;)11:49
sean-k-mooneyhehe11:49
sean-k-mooneyi did whihc is why i started at 1111:49
bauzasI was a night owl11:50
bauzasbut then my brain fried 4 years ago11:50
bauzasor maybe 311:50
bauzasactually, 311:50
sean-k-mooneyi can try and sumerises in the spec but and in our internal tech  call what i discussed with dansmith and efried_afk last night11:50
sean-k-mooneyi was fine with the pervisous revision with the fallback query11:51
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240011:51
sean-k-mooneybut the alternitive is to enable numa reporting by default and then make all non numa instance have a numa toplogy dynamicaly by makeing multiple queries with differnt numa toplogies upt to a max numer of numa nodes11:52
sean-k-mooneyso large instance that cant fit on one numa node would dynamicaly get split across up to X numa nodes as defiend in the schduler config11:53
sean-k-mooneyif you set the max to 0 it disabel the implcit numa creation and large non numa guest could only land on hosts with numa reporting disabled or train hosts during an upgrade11:54
*** jaosorior has joined #openstack-nova12:01
*** nicolasbock has joined #openstack-nova12:06
*** ociuhandu has quit IRC12:09
*** ociuhandu has joined #openstack-nova12:10
sean-k-mooneybauzas: also not sure if you saw ^ we can talk about it in the tech call too if you can make that12:11
*** mkrai has joined #openstack-nova12:15
*** udesale has joined #openstack-nova12:34
*** mkrai has quit IRC12:35
*** ratailor has quit IRC12:36
*** ratailor has joined #openstack-nova12:38
*** ratailor has quit IRC12:43
bauzassean-k-mooney: thanks, I need to be in a doctor's appointment in 15 mins, back around 1.45pm UTC I think12:43
*** nweinber has joined #openstack-nova12:54
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240012:54
*** amoralej is now known as amoralej|lunch12:56
*** Liang__ has quit IRC13:03
*** Liang__ has joined #openstack-nova13:04
*** rpittau|bbl is now known as rpittau13:05
*** ociuhandu has quit IRC13:11
*** derekh has quit IRC13:30
stephenfinefried_afk, bauzas, gibi, others: I hope I'm not overstepping things by -2ing this, but it seems clear to me that we've decided not to do orchestration stuff, right? https://review.opendev.org/#/c/672400/13:32
gibistephenfin: I support your -213:32
gibistephenfin: a similar spec for port mac address https://review.opendev.org/#/c/700429/13:33
stephenfingibi: I've also -2'd that. Happy to take the backlash13:37
gibigood :) thanks :)13:37
*** nicolasbock has quit IRC13:43
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Remove 'test_cold_migrate_with_physnet_fails' test  https://review.opendev.org/70311513:45
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed  https://review.opendev.org/70311613:45
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/70311713:45
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: FUP for in-place numa rebuild  https://review.opendev.org/70311813:45
lyarwoodsean-k-mooney: ^ just rebasing as stable/rocky should be passing again now and I'd like to land this before we switch over to EM13:45
lyarwoodaaaaaand I missed elod's comment13:46
*** nicolasbock has joined #openstack-nova13:48
*** ociuhandu has joined #openstack-nova13:48
*** rcernin|lunch has quit IRC13:50
*** liuyulong has joined #openstack-nova13:51
*** ociuhandu has quit IRC13:52
*** eharney has quit IRC13:55
bauzasgibi: sean-k-mooney: I'm back13:56
*** rosmaita has left #openstack-nova13:57
*** amoralej|lunch is now known as amoralej13:58
gibibauzas: just replied with my understanding of Eric's summary13:59
*** Liang__ is now known as LiangFang14:00
*** lbragstad has quit IRC14:02
*** lbragstad has joined #openstack-nova14:02
*** ociuhandu has joined #openstack-nova14:04
*** derekh has joined #openstack-nova14:05
*** lbragstad has quit IRC14:08
*** vishalmanchanda has joined #openstack-nova14:11
*** ociuhandu has quit IRC14:15
*** tesseract has quit IRC14:20
sean-k-mooneybauzas: just back too14:24
sean-k-mooneyhad to go to my bank to sort things for the house purchase14:24
bauzasgibi: coolio thanks14:25
sean-k-mooneygibi: ya that is more or less a good summary14:29
gibibauzas: I think I got enough from efried_afk's summary that I see that my issue is solved by this propsal as well14:29
sean-k-mooneygibi: well this still has the fallback which solves your main issue but also make the numa reporting the default which solve erics main issue of people using the fature after all this work14:30
gibisean-k-mooney: I treated the splitting algo as an impl detail for now. I think we can make it good enough and if not we have a way out14:30
gibisean-k-mooney: yeah, I'm OK that U compute is reshape by default14:30
sean-k-mooneygibi: ya honelsty the poc i did would be good enouch in my book14:30
gibisean-k-mooney: agree14:30
sean-k-mooneyi will likely refacto that algoritim and submit a standalone patch later in the week14:31
sean-k-mooneyallowing asymetic spliting by default when you just set hw:numa_nodes is a minor change14:31
sean-k-mooneyand would be useful for numa instnaces14:32
*** jaosorior has quit IRC14:32
*** jaosorior has joined #openstack-nova14:32
sean-k-mooneyonce we do that its just a matter of calling the get_numa_constratis function in a loop and generting the multiple queies and merging the results14:32
*** tbachman has joined #openstack-nova14:33
*** eharney has joined #openstack-nova14:41
huaqianghi alex_xu14:44
alex_xuhuaqiang: i'm here14:44
huaqiangdo you mean, in the review of spec https://review.opendev.org/#/c/668656/, we have to mix 'hw:pinned_cpus' with 'resources:P|VCPU'14:45
huaqiangBUT we should avoid the mixing of 'hw_pinned_cpus' with 'resources:xx;14:46
huaqiangright?14:46
alex_xuhuaqiang: I mean it have to, althought we don't want that.14:47
alex_xuI don't think we have other choice14:47
huaqiangthen there is no problem for setting the 'mixed' policy and cpu bitmask in image properties and then specify the PCPU and VCPU in flavor 'resources:P|VCPU'?14:49
*** efried_afk is now known as efried14:50
*** tbachman has quit IRC14:51
*** ociuhandu has joined #openstack-nova14:53
*** Sundar has joined #openstack-nova14:54
sean-k-mooneyi have the mixed cpu spec open by the way so im going to try and finish reviewing it in the next hour or so before my next meeting14:54
*** jaosorior has quit IRC14:54
alex_xuhuaqiang: yes, I think there is no problem14:54
alex_xusean-k-mooney: thanks14:55
huaqiangsean-k-mooney: thank you :)14:55
huaqiangalex_xu: got. thanks14:55
sean-k-mooneyalex_xu: are you largly happy with it?14:57
alex_xusean-k-mooney: yes, I think so14:57
sean-k-mooneyok just wondering if you had pending comments. ill try and go through it form top to bottom now so14:57
alex_xuno more pending comments.14:58
*** ociuhandu has quit IRC14:58
Sundargibi, dansmith, efried, sean-k-mooney: Trying to get my head around the rescheduling thing. Previously, the creation and binding of ARQs were happening in the compute manager. So, on failure, we just deleted the ARQs (which will be unbound by Cyborg if needed) and the retry would presumably have created/bound the ARQs on another node. Now the15:03
Sundarcreate/bind are moved to the conductor, but that is done just before the RPC call to compute manager. So, could we still delete and recreate/rebind the ARQs?15:03
dansmithSundar: why is it any different?15:04
sean-k-mooneyso on a resudue instead of delete and recreate we can just rebind in the conductor15:04
dansmithcan we rebind? if so, then sure15:05
sean-k-mooneyif we cant delete and recreeate is fine too15:05
sean-k-mooneywe can update the host for an exisitng binding15:05
sean-k-mooneyit woudl be needed for move opertions anyway15:05
dansmithwell, not necessarily15:05
dansmithdepends on how they want to do it15:05
sean-k-mooneyi guess we could use a souce and dest arg15:06
sean-k-mooney*arq15:06
sean-k-mooneythat might be better in some ways15:06
dansmithif they wanted another ARQ bound to the new host and a switch, or whatever15:06
dansmiththat's not what he's asking though I assume15:06
sean-k-mooneyya like we  now do with neutron ports15:06
*** spatel has joined #openstack-nova15:06
dansmithright15:06
Sundardansmith, sean-k-mooney: It may be simpler to delete and re-create, similar to the rest of the patches.15:06
dansmithyeah, that's fine15:07
SundarYes, I am not talking about migration, which is out of scope for now15:07
sean-k-mooneySundar: i think dansmith and i both think thats fine15:07
SundarCool, thanks, dansmith and sean-k-mooney.15:07
*** jmlowe has joined #openstack-nova15:08
sean-k-mooneyif delete and recreate makes runing through the cyborg state machicne to prepare the device on the dest simpler i think it also makes sense to just do that15:08
sean-k-mooneyi.e. for that reason on its own in addtion to the fact thats what the other patches do and the workflow you have been using15:09
*** spatel has quit IRC15:11
*** artom has joined #openstack-nova15:11
*** mkrai has joined #openstack-nova15:11
Sundarsean-k-mooney: The Cyborg state machine can technically handle ARQ_UNBOUND state, which is reached when you unbind an existing ARQ without deleting it (and distinct from Initial state). That may be of use in the future, but for now it is simpler IMHO to just delete and recreate.15:11
sean-k-mooneycool works for me15:11
sean-k-mooneySundar: speaking of delete where you able to repoduce the vm delete issue i hit15:12
SundarI am not hitting it even after reboots.15:12
sean-k-mooneywith the fake driver15:12
SundarI mostly used the real FPGA driver, but shouldn't matter, one would think. But let me try with the fake anyway.15:13
sean-k-mooneyits a keystone auth issue so the driver should not make a difference but i dont know15:14
sean-k-mooneyi do now have access to a system with the same fpga you have. but 1 im not sure what image to use and 2 it currently has rhel 7.7 so i have not figured out how to deploy opensatck on it yet15:14
*** lbragstad has joined #openstack-nova15:15
sean-k-mooneyi might see if it can be reinstalled with centos 7.7 or ubuntu 18.04 so that i can use devstack15:15
*** priteau has joined #openstack-nova15:15
*** dtantsur is now known as dtantsur|brb15:18
SundarWhat's the issue with RHEL 7.7?15:18
SundarI am using Centos 7.715:19
sean-k-mooneyits not supported by devstack and im not sure i will be able to get it to install with out enable eple and rdo repos which dont technicaly support RHEL15:21
sean-k-mooneyim going to try and stack in a vm first with RHEL 7.7 but im expecting the subsription manager to get in the way15:21
*** jmlowe has quit IRC15:21
sean-k-mooneytl;dr im expecting missing packages15:21
SundarGot it.15:22
sean-k-mooneyif your using centos 7.7 and i have to reinstall ill just use that15:22
*** lpetrut has quit IRC15:24
*** ociuhandu has joined #openstack-nova15:25
sean-k-mooneyhuaqiang: some minor nits to clean up in a follow up patch but im +1 on the mixed cpu spec15:30
*** mlavalle has joined #openstack-nova15:31
*** rpittau is now known as rpittau|afk15:31
sean-k-mooneystephenfin: i think you are probaly the best person to be the final +2 on https://review.opendev.org/#/c/668656/19 if you think its ready.15:31
*** jmlowe has joined #openstack-nova15:34
*** tbachman has joined #openstack-nova15:44
*** READ10 has joined #openstack-nova15:53
efriedstephenfin: yes please, what sean-k-mooney said ^15:55
*** spatel has joined #openstack-nova15:56
stephenfinLooking15:59
sean-k-mooneyi just responed to alex_xu coment regarding the service object version bump. i think we can use a comptue capablity trait instead and avoid the need for that16:00
sean-k-mooneybut excpetion for that point im good with it16:00
*** udesale has quit IRC16:02
*** udesale has joined #openstack-nova16:02
*** tesseract has joined #openstack-nova16:02
*** maciejjozefczyk has quit IRC16:06
*** jmlowe has quit IRC16:13
openstackgerritMerged openstack/nova stable/queens: Use stable constraint for Tempest pinned stable branches  https://review.opendev.org/70671416:16
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Block deleting compute services with in-progress migrations  https://review.opendev.org/69971816:21
*** ivve has quit IRC16:23
*** tbachman has quit IRC16:25
openstackgerritGhanshyam Mann proposed openstack/nova master: Skip to run all integration jobs for policy-only changes.  https://review.opendev.org/70726816:33
gmannstephenfin: melwitt updated ^^16:33
melwittgmann: do you have a Depends-On change that shows what gets run on a policy change? I think that's the best way to check whether it's doing what we want before +2ing16:34
gmannmelwitt: ok, i can do that.16:34
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies  https://review.opendev.org/70704116:35
gmannmelwitt: ^^ done. let's see once gate finish16:36
melwittthanks gmann16:36
melwittgmann: oh, you have a typo Depednds-On16:37
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies  https://review.opendev.org/70704116:37
gmannah sorry, updated16:37
*** tbachman has joined #openstack-nova16:38
*** priteau has quit IRC16:38
*** martinkennelly has quit IRC16:39
*** priteau has joined #openstack-nova16:39
*** TxGirlGeek has joined #openstack-nova16:40
Sundarsean-k-mooney: Do you think https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L655 is a good place to delete the old ARQs?16:40
gmannmelwitt: I am not sure if default  GET AZ to admin is right things. can you check this - https://review.opendev.org/#/c/706683/16:42
melwittgmann: ok, will look16:43
gmannIt is currently admin-or-owner which is open for everyone due to bug or that is expected and admin-or-owner in policy is just misleading16:43
gmannmelwitt: thanks16:43
*** macz has joined #openstack-nova16:43
*** macz has quit IRC16:43
*** macz has joined #openstack-nova16:44
*** martinkennelly has joined #openstack-nova16:44
melwittgmann: I think it should be admin_or_owner, is it possible to just fix the bug? AZ is user-facing but usually only project members would be able to see which AZ in a instance is in (not everybody from other projects)16:48
*** macz has quit IRC16:50
* melwitt added a comment on the review16:50
*** udesale has quit IRC16:51
*** priteau has quit IRC16:51
*** udesale has joined #openstack-nova16:52
*** gyee has joined #openstack-nova16:52
*** martinkennelly has quit IRC16:53
*** iurygregory has quit IRC16:58
*** tbachman has quit IRC17:00
*** mkrai has quit IRC17:04
*** udesale has quit IRC17:08
sean-k-mooneySundar: looking17:08
gmannmelwitt: but issue is we do not know the owner while GET AZ.17:08
melwittoh ... /me looks again17:08
gmannmelwitt: this is list and detail API - https://github.com/openstack/nova/blob/1fcd74730d343b7cee12a0a50ea537dc4ff87f65/nova/api/openstack/compute/availability_zone.py#L10817:08
sean-k-mooneyam we could. althoh i belive we will do a cleaup of the failed spawn before that so you might be able to do it earlier.17:09
sean-k-mooneythat is proably the latest i would delete and recreate the ARQ17:10
sean-k-mooneySundar: you could also do it here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L69417:10
sean-k-mooneywhich i think is where i would expect it to happen17:11
melwittgmann: ohhhh this is just giving a list of all the AZs that exist, not the AZ of any particular instance. yeah, sorry, let me comment again17:11
gmannmelwitt: "which AZ is instance is in"  is admin-or-owner which is via GET /servers API17:11
gmannmelwitt: yeah17:12
Sundarsean-k-mooney: Ok, got it. Thanks.17:12
sean-k-mooneyim not 100% if you want to be in our out side of the if but you likely should be doing the clean up in that exeption handeling code https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L674-L69917:12
melwittgmann: yeah, I agree it should be allowing everyone to see AZ list by default. I added a comment17:14
gmannmelwitt: ok. detail make sense to be admin-only as it has host info17:15
melwittgmann: right, agreed17:15
gmannthanks. I will modify accordingly17:16
*** igordc has joined #openstack-nova17:17
*** tbachman has joined #openstack-nova17:20
*** READ10 has quit IRC17:23
stephenfinsean-k-mooney: You can only specify the number of instance CPUs via the flavor, right?17:29
stephenfini.e. not via the image17:29
sean-k-mooneyyes17:30
*** tesseract has quit IRC17:32
sean-k-mooneytechnically you could do evial things with a cyborg device profile but if you put VCPU or PCPU int eh device profile your on your own17:32
*** ociuhandu_ has joined #openstack-nova17:32
*** evrardjp has quit IRC17:34
*** evrardjp has joined #openstack-nova17:34
sean-k-mooney*evil17:35
*** ociuhandu has quit IRC17:36
*** ociuhandu_ has quit IRC17:37
sean-k-mooneylyarwood: by the way did you want me to do anything with the backprots for the numa inplace rebuild patches17:38
sean-k-mooneylyarwood: you pinged my earlier but i was not sure if you already fixt them up or if there was still stuff pending17:39
stephenfinhuaqiang: Reviewed https://review.opendev.org/#/c/668656/. You need to drop the image metadata option and avoid the need to mix placement'y syntax extra specs with legacy extra specs. Do that and I'm +217:39
stephenfinsean-k-mooney, efried, alex_xu: ^17:39
sean-k-mooneywhat do you think about the need for the service bump17:40
*** iurygregory has joined #openstack-nova17:40
sean-k-mooneye.g. do you think we could use a compute capablity trait isntead17:40
stephenfinvs. a capability?17:40
sean-k-mooneyya17:40
sean-k-mooneyi would be fine with leaving that to impleenation to decied17:40
sean-k-mooneybut i think the trait would work17:41
sean-k-mooneythere may be another reason for the service version bump that i missed17:41
stephenfinI used a capability for the PCPU work17:41
stephenfinso yeah, I'd probably do the same again17:42
*** xek__ has joined #openstack-nova17:42
stephenfincommit f329ee5a3b617:42
sean-k-mooneyusing the capablity trait means we can support rolling upgrades too rather then requiring all nodes to be upgraded17:42
sean-k-mooneyjust the contoler and the host it lands on will need to be ussuri17:43
*** ivve has joined #openstack-nova17:44
*** xek_ has quit IRC17:44
stephenfinExactly17:44
sean-k-mooneythere is a usecase for keeping the image property by the way17:45
sean-k-mooneywe support setting the realtime mask in the image17:45
stephenfinWe do, but I think that's wrong17:45
sean-k-mooneyso for parity we could support the pinned cpus there too17:45
sean-k-mooneywhy17:45
stephenfinFor the same reasons17:45
stephenfinYou boot an N core instance17:46
sean-k-mooneythe idea is the vnf vendor will package teh image and expres the requirements in the image properties17:46
stephenfinRight, but they can't express the number of CPUs17:46
stephenfinwhich is probably also required17:46
sean-k-mooneywell the can express a min numa of cpus in the image17:46
stephenfinVia the topology stuff?17:47
sean-k-mooneythe same way they can express a min amount of ram or disk17:47
stephenfinThat's a bit of hack17:47
sean-k-mooneyno17:47
sean-k-mooneyone sec17:47
sean-k-mooneymedtadef time17:47
sean-k-mooneyactully im not sure this is even a metadef it migh be directly on the image17:47
stephenfinHmm, we do also have 'hw_numa_cpus' there17:48
stephenfinThat's wrong too, IMO :(17:48
stephenfinI wonder if we should do this just to be compatible even if it's not a great design though17:49
stephenfinWe have a 'img_bittorrent' field on the 'ImageMetaProps' object. Good Lord17:49
sean-k-mooneyoh looks like it only has min disk and min ram17:50
sean-k-mooneyhttps://docs.openstack.org/python-openstackclient/pike/cli/command-objects/image.html#image-create17:50
sean-k-mooneystephenfin: its by design17:50
sean-k-mooneyagain the intent was to allow the image to descibr the toplogy17:51
*** vishalmanchanda has quit IRC17:51
sean-k-mooneyand the flavor to describe the quantity17:51
stephenfinsean-k-mooney: But remember, that's a not a simple list17:51
stephenfinor actually, maybe it is for the image metadata17:51
stephenfinwhat happens if you create an N node instance that lists M CPUs in the 'hw_numa_cpus' image metadata option?17:52
sean-k-mooneystephenfin: i agree that we should not mix it with the resouces:* syntax17:52
stephenfinyeah, I really don't think we need the image metadata option. If anything, I'd be looking to deprecate the likes of 'hw_numa_cpus'17:53
sean-k-mooneybut if we are seting hw_cpu_policy=mixed in the image seting hw_pinned_cpus=1-5 i think is ok17:53
sean-k-mooneystephenfin: i dont think that we shoudl do that17:54
sean-k-mooneywe could but its there for a reason17:54
stephenfinso if we boot using a flavor with 4 cores, what happens?17:54
stephenfinor with 8 cores?17:54
sean-k-mooneypartly to prevent falvor explosion17:54
sean-k-mooneywith 4 course it woudl be rejected by the numa constraint in the api17:55
stephenfinby having image explosion instead?17:55
sean-k-mooneybefore we even create the instance record17:55
sean-k-mooneystephenfin: for 8 cors 0,6,7 would be un pinned17:55
stephenfinYeah, that seems wrong to me17:56
stephenfinI'd be okay with a ratio17:56
stephenfini.e. 3:1 pinned:unpinned17:56
stephenfinbecause it's a hint17:56
sean-k-mooneyright but we said its a list17:56
stephenfinbut I don't think anyone's asked for that17:56
stephenfinhas anyone actually said they need the image metadata option?17:57
sean-k-mooneya ratio is not ok in general17:57
sean-k-mooneythats a question for huaqiang and alex_xu17:57
stephenfinwell we have that in a manner already17:57
stephenfinthat's what e.g. the 'hw_cpu_cores' thing is doing17:57
stephenfinthe ratio of cores to threads and sockets17:58
sean-k-mooneyyes although its not really a raitio17:58
sean-k-mooneyit indireclty is17:58
sean-k-mooneybut ya17:58
stephenfina flat number of unpinned cores would also be okay for me17:58
redrobotHi friends!  I have a question about your pep8 gate configuration.17:59
stephenfinbut again, I don't know how much that achieves17:59
sean-k-mooneyits really socket per vm, cores per socket and then threads per core17:59
stephenfinredrobot: shoot17:59
redrobotSeeing this error right now:17:59
redrobot> F841 local variable '_' is assigned to but never used17:59
redrobotI'm used to _ being used for throwaways in tests17:59
redrobotbut I was wondering if y'all handled it differently?17:59
stephenfinYeah, I thought that was usually ignored17:59
sean-k-mooneyit depens on the context i think18:00
stephenfinGot a link to a build? We're just using flake8 + hacking18:00
sean-k-mooneyif you do _ = 418:00
sean-k-mooneyi think we will raise an error18:00
stephenfinyeah, maybe18:00
sean-k-mooneyif you for _ , i  in x:18:00
sean-k-mooneyi think it will be fine18:00
stephenfinyup18:00
sean-k-mooney or if you do multiple assingment18:00
stephenfinin my experience, anyway18:00
redrobotstephenfin, https://zuul.opendev.org/t/openstack/build/342ef93cbf464e01b72564695b2d610d18:00
*** derekh has quit IRC18:01
sean-k-mooneyso _, x = sum_fun()18:01
stephenfinredrobot: I'm not seeing that issue18:01
stephenfinI'm seeing this18:01
stephenfin./nova/console/websocketproxy.py:326:32: F632 use ==/!= to compare str, bytes, and int literals18:01
stephenfin./nova/tests/unit/cmd/test_baseproxy.py:93:50: E241 multiple spaces after ','18:01
sean-k-mooneyya same i dont see it compain about _18:02
redrobotoh d'oh.  It's complaining about _ when I run tox -e pep8 locally18:02
redrobotbut also the extra space18:02
redrobotI'll follow up the patch with the fix for the space and hopefully that'll work.18:02
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs  https://review.opendev.org/55292418:03
stephenfinredrobot: Ah, yes, this https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@64218:03
stephenfinYou don't need that assignment18:03
stephenfinIf you don't want the value, don't assign to anything18:03
stephenfinso just18:03
stephenfinwebsocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver)18:03
stephenfininstead of18:03
stephenfin_ = websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver)18:03
sean-k-mooneyso yes dont do https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@63118:03
stephenfin'zactly ^18:03
sean-k-mooneythat should raise a style error18:03
* stephenfin has to run but trusts sean-k-mooney can answer other questions here :)18:04
redrobotstephenfin, ack, I'll change that18:04
redrobotthanks for the help, y'all!18:04
sean-k-mooneyno worries18:05
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Correctly resize encrypted LUKSv1 volumes  https://review.opendev.org/70690018:05
bauzasefried: sean-k-mooney: gibi: dansmith: stephenfin: just wrote the last round of the NUMA/placement spec18:05
bauzasit's fuckingly 7pm and I'm deprived of meat18:06
openstackgerritDouglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies  https://review.opendev.org/67950218:06
sean-k-mooneybauzas: go get foods hehe18:06
bauzasto make it clear, I turn-voted into *not* reshaping by default in Ussuri because i think it's important for us to be very conservative and super cautious18:06
bauzaswe will have time to make it mandatory for Victoria and write some nice nova-status command later in Ussuri18:07
*** igordc has quit IRC18:08
bauzassean-k-mooney: well, I also have to join a city council meeting since I run for a mayor's list :)18:08
* bauzas starts politics18:08
sean-k-mooneyireland had some interesting political change over the weekend too.18:09
sean-k-mooneyim going to similarly go to the store and get stuff for dinner but ill review it in the next hour or so18:09
*** READ10 has joined #openstack-nova18:15
*** Sundar has quit IRC18:15
*** eharney has quit IRC18:18
gmannmelwitt: stephenfin you can see the jobs running for policy-only changes with proposed change-  https://review.opendev.org/#/c/707041/18:20
melwittgmann: cool thanks18:20
lyarwoodsean-k-mooney: sorry missed your pings earlier, yeah can you take a look at elod's comments in the first change and address them if you have time this week?18:22
lyarwoodsean-k-mooney: I was just rebasing to get them passing in CI again now that gmann++ fixed up stable/rocky18:22
*** igordc has joined #openstack-nova18:23
*** amoralej is now known as amoralej|off18:36
*** READ10 has quit IRC18:37
*** jmlowe has joined #openstack-nova18:40
*** tosky has quit IRC18:47
*** ralonsoh has quit IRC19:04
*** TxGirlGeek has quit IRC19:06
*** mlycka has quit IRC19:10
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies  https://review.opendev.org/70745519:15
*** eharney has joined #openstack-nova19:17
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix os-os-deferred-delete policy to be admin_or_owner  https://review.opendev.org/70745719:31
*** TxGirlGeek has joined #openstack-nova19:35
sean-k-mooneylyarwood: ok ya ill take a look at that tomorrow19:37
lyarwoodsean-k-mooney: ack thanks19:37
*** TxGirlGeek has quit IRC19:46
*** gentoorax is now known as gentoorax_away19:50
*** gentoorax_away is now known as gentoorax19:50
*** dtantsur|brb is now known as dtantsur|afk19:51
openstackgerritArtom Lifshitz proposed openstack/nova master: func tests: move _run_periodics() into own mixin  https://review.opendev.org/70554519:53
openstackgerritArtom Lifshitz proposed openstack/nova master: tests: work around malformed serial XML  https://review.opendev.org/70554619:53
openstackgerritArtom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration  https://review.opendev.org/67259519:53
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146  https://review.opendev.org/68740419:53
openstackbug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)19:53
*** igordc has quit IRC19:58
*** LiangFang has quit IRC20:05
*** jmlowe has quit IRC20:08
openstackgerritGhanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str  https://review.opendev.org/70668320:12
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies  https://review.opendev.org/70668220:13
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner  https://review.opendev.org/70672720:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies  https://review.opendev.org/70672620:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup  https://review.opendev.org/70703820:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies  https://review.opendev.org/70703920:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies  https://review.opendev.org/70668220:24
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone  https://review.opendev.org/70668420:44
*** N3l1x has joined #openstack-nova20:48
*** ChanServ has quit IRC20:50
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies  https://review.opendev.org/70668620:53
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy  https://review.opendev.org/70669120:54
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies  https://review.opendev.org/70668221:00
openstackgerritDouglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies  https://review.opendev.org/67950221:05
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone  https://review.opendev.org/70668421:10
*** artom has quit IRC21:12
*** ChanServ has joined #openstack-nova21:13
*** orwell.freenode.net sets mode: +o ChanServ21:13
*** rcernin has joined #openstack-nova21:18
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies  https://review.opendev.org/70668621:19
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy  https://review.opendev.org/70669121:19
*** jmlowe has joined #openstack-nova21:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies  https://review.opendev.org/70745521:29
*** ivve has quit IRC21:31
openstackgerritCorey Bryant proposed openstack/nova master: Monkey patch original current_thread _active  https://review.opendev.org/70747421:34
*** ociuhandu has joined #openstack-nova21:37
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete  https://review.opendev.org/70747621:38
*** ociuhandu has quit IRC21:48
*** ociuhandu has joined #openstack-nova21:49
*** READ10 has joined #openstack-nova21:50
*** spatel has quit IRC21:50
*** READ10 has quit IRC21:52
*** ociuhandu has quit IRC21:52
*** nweinber has quit IRC21:54
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies  https://review.opendev.org/70748522:15
*** slaweq has quit IRC22:26
*** jmlowe has quit IRC22:40
openstackgerritGhanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str  https://review.opendev.org/70668322:40
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies  https://review.opendev.org/70668222:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies  https://review.opendev.org/70668222:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone  https://review.opendev.org/70668422:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies  https://review.opendev.org/70668622:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy  https://review.opendev.org/70669122:41
*** jmlowe has joined #openstack-nova22:43
*** jmlowe has quit IRC22:53
*** tkajinam has joined #openstack-nova22:54
*** jmlowe has joined #openstack-nova22:56
*** xek__ has quit IRC23:08
*** spatel has joined #openstack-nova23:11
*** jmlowe has quit IRC23:12
*** spatel has quit IRC23:16
*** xek has joined #openstack-nova23:37
*** tbachman has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!