| *** macz has quit IRC | 00:16 | |
| *** macz has joined #openstack-nova | 00:17 | |
| *** cz3 has quit IRC | 00:18 | |
| *** TheJulia has quit IRC | 00:18 | |
| *** donnyd has quit IRC | 00:18 | |
| *** bcm has quit IRC | 00:18 | |
| *** rajinir has quit IRC | 00:18 | |
| *** dave-mccowan has quit IRC | 00:19 | |
| *** rajinir has joined #openstack-nova | 00:19 | |
| *** bcm has joined #openstack-nova | 00:19 | |
| *** donnyd has joined #openstack-nova | 00:20 | |
| *** cz3 has joined #openstack-nova | 00:20 | |
| *** vishalmanchanda has joined #openstack-nova | 00:20 | |
| *** TheJulia has joined #openstack-nova | 00:22 | |
| *** macz has quit IRC | 00:22 | |
| *** csatari has joined #openstack-nova | 00:23 | |
| *** TxGirlGeek has quit IRC | 00:26 | |
| *** rpittau|afk has joined #openstack-nova | 00:35 | |
| *** bauzas has quit IRC | 00:36 | |
| *** dave-mccowan has joined #openstack-nova | 00:37 | |
| *** bauzas has joined #openstack-nova | 00:38 | |
| *** rpittau|afk has quit IRC | 00:42 | |
| *** knikolla has quit IRC | 00:42 | |
| *** samc-bbc has quit IRC | 00:42 | |
| *** csatari has quit IRC | 00:42 | |
| *** rm_work has quit IRC | 00:43 | |
| *** donnyd has quit IRC | 00:43 | |
| *** ildikov has quit IRC | 00:43 | |
| *** gmann has quit IRC | 00:43 | |
| *** vishalmanchanda has quit IRC | 00:43 | |
| *** TheJulia has quit IRC | 00:44 | |
| *** vdrok has quit IRC | 00:44 | |
| *** cz3 has quit IRC | 00:44 | |
| *** rajinir has quit IRC | 00:44 | |
| *** arne_wiebalck has quit IRC | 00:45 | |
| *** _erlon_ has quit IRC | 00:46 | |
| *** mnasiadka has quit IRC | 00:46 | |
| *** awestin1 has quit IRC | 00:46 | |
| *** jungleboyj has quit IRC | 00:46 | |
| *** dustinc has quit IRC | 00:46 | |
| *** portdirect has quit IRC | 00:46 | |
| *** coreycb has quit IRC | 00:46 | |
| *** guilhermesp has quit IRC | 00:47 | |
| *** tonyb[m] has quit IRC | 00:47 | |
| *** jrosser has quit IRC | 00:48 | |
| *** NobodyCam has quit IRC | 00:48 | |
| *** masayukig has quit IRC | 00:49 | |
| *** mnaser has quit IRC | 00:49 | |
| *** johnsom has quit IRC | 00:52 | |
| *** Liang__ has joined #openstack-nova | 00:55 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_QEMU_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/695915 | 00:58 |
|---|---|---|
| *** zhanglong has joined #openstack-nova | 01:01 | |
| *** Li_Liu has quit IRC | 01:01 | |
| *** pas-ha has quit IRC | 01:02 | |
| *** bcm has quit IRC | 01:06 | |
| *** csatari has joined #openstack-nova | 01:16 | |
| *** mnasiadka has joined #openstack-nova | 01:18 | |
| *** csatari has quit IRC | 01:22 | |
| *** csatari has joined #openstack-nova | 01:24 | |
| *** dave-mccowan has quit IRC | 01:26 | |
| *** mnasiadka has quit IRC | 01:29 | |
| *** gyee has quit IRC | 01:30 | |
| *** csatari has quit IRC | 01:31 | |
| *** xiaolin has joined #openstack-nova | 01:33 | |
| *** xiaolin has joined #openstack-nova | 01:35 | |
| xiaolin | hello guys, I'm trying to run tempest test "rally verify start --pattern set=volume", but got an error "Forbidden: Policy doesn't allow os_compute_api:os-assisted-volume-snapshots:create to be performed. (HTTP 403)", can anyone give me some advice ? | 01:39 |
| xiaolin | when i modify base.RULE_ADMIN_API to base.RULE_ANY in /usr/lib/python2.7/site-packages/nova/policies/assisted_volume_snapshots.py, the test passed | 01:39 |
| xiaolin | Is this permission setting reasonable? | 01:39 |
| *** macz has joined #openstack-nova | 01:41 | |
| *** igordc has quit IRC | 01:42 | |
| *** macz has quit IRC | 01:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:47 | |
| openstackgerrit | wangjiajing proposed openstack/nova master: Optimize the comments for the "test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec" method. https://review.opendev.org/702781 | 01:59 |
| alex_xu | xiaolin: that API I thought should be called by cinder side, probably can go to check the cinder side's nova config, whether it is admin user | 02:05 |
| *** yedongcan has joined #openstack-nova | 02:16 | |
| *** Liang__ is now known as LiangFang | 02:32 | |
| *** jamesdenton has quit IRC | 02:40 | |
| *** jamesdenton has joined #openstack-nova | 02:43 | |
| *** mkrai_ has joined #openstack-nova | 03:12 | |
| *** knikolla has joined #openstack-nova | 03:18 | |
| *** zhanglong has quit IRC | 03:21 | |
| *** knikolla has quit IRC | 03:24 | |
| *** zhanglong has joined #openstack-nova | 03:27 | |
| *** abhishekk has quit IRC | 03:31 | |
| *** abhishekk has joined #openstack-nova | 03:32 | |
| *** macz has joined #openstack-nova | 03:34 | |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** mkrai_ has quit IRC | 03:38 | |
| *** macz has quit IRC | 03:39 | |
| *** knikolla has joined #openstack-nova | 03:39 | |
| *** mkrai_ has joined #openstack-nova | 03:42 | |
| *** knikolla has quit IRC | 03:44 | |
| *** zhanglong has quit IRC | 03:47 | |
| *** bhagyashris has joined #openstack-nova | 03:48 | |
| *** zhanglong has joined #openstack-nova | 03:50 | |
| *** knikolla has joined #openstack-nova | 04:03 | |
| *** udesale has joined #openstack-nova | 04:05 | |
| *** zhanglong has quit IRC | 04:09 | |
| *** knikolla has quit IRC | 04:09 | |
| *** zhanglong has joined #openstack-nova | 04:10 | |
| *** openstackgerrit has quit IRC | 04:12 | |
| *** jungleboyj has joined #openstack-nova | 04:14 | |
| *** yaawang has quit IRC | 04:14 | |
| *** zhanglong has quit IRC | 04:15 | |
| *** jungleboyj has quit IRC | 04:20 | |
| *** masayukig has joined #openstack-nova | 04:23 | |
| *** masayukig has quit IRC | 04:26 | |
| *** openstackgerrit has joined #openstack-nova | 04:33 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790 | 04:33 |
| *** tkajinam has quit IRC | 04:39 | |
| *** tkajinam has joined #openstack-nova | 04:41 | |
| *** tkajinam_ has joined #openstack-nova | 05:03 | |
| *** tkajinam has quit IRC | 05:07 | |
| *** samc-bbc has joined #openstack-nova | 05:09 | |
| *** yaawang has joined #openstack-nova | 05:11 | |
| *** samc-bbc has quit IRC | 05:20 | |
| *** macz has joined #openstack-nova | 05:22 | |
| *** macz has quit IRC | 05:27 | |
| *** ociuhandu has joined #openstack-nova | 05:31 | |
| *** evrardjp has quit IRC | 05:34 | |
| *** evrardjp has joined #openstack-nova | 05:34 | |
| *** ociuhandu has quit IRC | 05:35 | |
| *** yedongcan has quit IRC | 05:52 | |
| *** yedongcan has joined #openstack-nova | 05:53 | |
| *** ratailor has joined #openstack-nova | 06:08 | |
| *** mkrai_ has quit IRC | 06:13 | |
| *** mkrai_ has joined #openstack-nova | 06:13 | |
| LiangFang | hi folks, regarding the volume local cache spec. https://review.opendev.org/#/c/689070/ | 06:15 |
| LiangFang | I'm thinking to simply the logic. If the compute node have cache capability, then leverage it. If not have the capability, then just go ahead without caching. | 06:16 |
| LiangFang | We can use aggregate to group the servers that has cache capability | 06:17 |
| LiangFang | this way is not perfect for every scenarios, e.g. only support libvirt, not schedule by flavor. But in some private cloud, it is simple and useful. | 06:20 |
| *** rajinir has joined #openstack-nova | 06:23 | |
| LiangFang | in the cinder spec https://review.opendev.org/#/c/684556/, lots of concerns if we fail the attach volume operation | 06:25 |
| *** cz3 has joined #openstack-nova | 06:30 | |
| *** rajinir has quit IRC | 06:30 | |
| *** cz3 has quit IRC | 06:36 | |
| *** gmann has joined #openstack-nova | 06:48 | |
| *** cz3 has joined #openstack-nova | 06:48 | |
| *** vishalmanchanda has joined #openstack-nova | 06:49 | |
| *** mnaser has joined #openstack-nova | 06:49 | |
| *** donnyd has joined #openstack-nova | 06:52 | |
| *** rajinir has joined #openstack-nova | 06:52 | |
| *** rm_work has joined #openstack-nova | 06:53 | |
| *** rm_work has quit IRC | 06:53 | |
| *** Li_Liu has joined #openstack-nova | 06:54 | |
| *** portdirect has joined #openstack-nova | 06:59 | |
| *** csatari has joined #openstack-nova | 07:00 | |
| *** vdrok has joined #openstack-nova | 07:00 | |
| *** pcaruana has joined #openstack-nova | 07:00 | |
| *** johnsom has joined #openstack-nova | 07:02 | |
| *** coreycb has joined #openstack-nova | 07:02 | |
| *** jrosser has joined #openstack-nova | 07:03 | |
| *** TheJulia has joined #openstack-nova | 07:03 | |
| *** dustinc has joined #openstack-nova | 07:03 | |
| *** masayukig has joined #openstack-nova | 07:05 | |
| *** pas-ha has joined #openstack-nova | 07:05 | |
| *** _erlon_ has joined #openstack-nova | 07:06 | |
| *** awestin1 has joined #openstack-nova | 07:07 | |
| *** knikolla has joined #openstack-nova | 07:11 | |
| *** jungleboyj has joined #openstack-nova | 07:11 | |
| *** mnasiadka has joined #openstack-nova | 07:14 | |
| *** bcm has joined #openstack-nova | 07:15 | |
| *** NobodyCam has joined #openstack-nova | 07:16 | |
| *** rpittau|afk has joined #openstack-nova | 07:19 | |
| *** samc-bbc has joined #openstack-nova | 07:22 | |
| *** rchurch has quit IRC | 07:23 | |
| *** rcernin has quit IRC | 07:25 | |
| *** arne_wiebalck has joined #openstack-nova | 07:25 | |
| *** ildikov has joined #openstack-nova | 07:25 | |
| *** tonyb[m] has joined #openstack-nova | 07:31 | |
| *** osmanlicilegi has joined #openstack-nova | 07:47 | |
| *** osmanlicilegi has left #openstack-nova | 07:47 | |
| *** guilhermesp has joined #openstack-nova | 07:48 | |
| *** rm_work has joined #openstack-nova | 07:48 | |
| *** rm_work has quit IRC | 07:49 | |
| *** rm_work has joined #openstack-nova | 07:49 | |
| openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | 07:51 |
| *** damien_r has joined #openstack-nova | 08:00 | |
| *** bhagyashris is now known as bhagyashris|NHO | 08:03 | |
| *** awalende has joined #openstack-nova | 08:05 | |
| openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | 08:07 |
| *** yedongcan has quit IRC | 08:07 | |
| *** slaweq has joined #openstack-nova | 08:08 | |
| *** yedongcan has joined #openstack-nova | 08:09 | |
| *** tesseract has joined #openstack-nova | 08:10 | |
| *** xiaolin has quit IRC | 08:10 | |
| lyarwood | efried: ack thanks for that, I missed that another trait had or at least was about to land. | 08:21 |
| *** maciejjozefczyk has joined #openstack-nova | 08:22 | |
| *** xiaolin has joined #openstack-nova | 08:22 | |
| *** udesale_ has joined #openstack-nova | 08:25 | |
| openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | 08:26 |
| *** udesale has quit IRC | 08:28 | |
| *** rpittau|afk is now known as rpittau | 08:31 | |
| *** tosky has joined #openstack-nova | 08:32 | |
| *** ociuhandu has joined #openstack-nova | 08:33 | |
| *** ociuhandu has quit IRC | 08:33 | |
| *** jcosmao has joined #openstack-nova | 08:33 | |
| *** ociuhandu has joined #openstack-nova | 08:34 | |
| *** iurygregory has joined #openstack-nova | 08:36 | |
| *** alex_xu has quit IRC | 08:40 | |
| *** alex_xu has joined #openstack-nova | 08:40 | |
| *** zhanglong has joined #openstack-nova | 08:42 | |
| gibi | dansmith: hi! stephenfin would like you to look at one of the qos patch https://review.opendev.org/#/c/702261/ and if you are there already the rest is also ready for review | 08:47 |
| *** ociuhandu_ has joined #openstack-nova | 08:48 | |
| *** ociuhandu has quit IRC | 08:51 | |
| *** ralonsoh has joined #openstack-nova | 08:52 | |
| *** sapd1 has quit IRC | 08:55 | |
| *** sapd1_ has joined #openstack-nova | 08:55 | |
| *** ociuhandu_ has quit IRC | 08:58 | |
| *** ociuhandu has joined #openstack-nova | 08:59 | |
| *** udesale_ has quit IRC | 09:04 | |
| *** xek_ has joined #openstack-nova | 09:11 | |
| openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | 09:14 |
| stephenfin | efried: Probably would have waited til https://review.opendev.org/#/c/702440/ was merged to mark that BP as complete, personally - I'd like to get the whole thing closed out | 09:22 |
| stephenfin | but hey, the hardest work is done | 09:22 |
| *** LiangFang has quit IRC | 09:28 | |
| *** elod has quit IRC | 09:28 | |
| *** ccamacho has joined #openstack-nova | 09:29 | |
| openstackgerrit | Riccardo Pittau proposed openstack/nova master: Fix typos for update_available_resource reference https://review.opendev.org/702602 | 09:31 |
| stephenfin | yo, sean-k-mooney, looks like you added https://github.com/openstack/nova/blob/b44b540fc70504f3869ef23022642095de0ea99e/nova/virt/libvirt/vif.py#L299-L301 | 09:39 |
| stephenfin | sean-k-mooney: but that function has existed since it was removed in commit 92323586b5d03b31c18657ad64646a8ce3b8a742 | 09:41 |
| stephenfin | sean-k-mooney: so that means that code is not being called by anything yet. In either case, want to work on the fix or will I? | 09:42 |
| stephenfin | sean-k-mooney: fwiw, I'm running pytype over the code base to see what it reveals. That's one of two actual issues it has found so far | 09:42 |
| openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | 09:42 |
| *** martinkennelly has joined #openstack-nova | 09:47 | |
| *** jangutter has joined #openstack-nova | 09:48 | |
| *** elod has joined #openstack-nova | 09:53 | |
| kashyap | stephenfin: Hey, any clue how to resolve this "duplicate label" thing?: | 10:00 |
| kashyap | Warning, treated as error: | 10:00 |
| kashyap | /home/zuul/src/opendev.org/openstack/nova-specs/doc/source/specs/ussuri/approved/allow-secure-boot-for-qemu-kvm-guests.rst:72:duplicate label proposed change, other instance in /home/zuul/src/opendev.org/openstack/nova-specs/doc/source/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst | 10:00 |
| kashyap | --- | 10:01 |
| *** zhanglong has quit IRC | 10:01 | |
| stephenfin | kashyap: Use anonymous labels instead | 10:04 |
| stephenfin | `foo`__ | 10:04 |
| stephenfin | __ https://example.com/ | 10:04 |
| stephenfin | (double underscore) | 10:04 |
| kashyap | stephenfin: Ah-ha! you, sir, are the Main Man! | 10:04 |
| kashyap | Okay, good to know: "... However, this feature [Anonymous Hyperlinks] is easily abused and can result in unreadable plaintext and/or unmaintainable documents. Caution is advised." | 10:07 |
| kashyap | stephenfin: Oh, wait -- | 10:08 |
| *** zbr is now known as zbr|rover | 10:09 | |
| kashyap | stephenfin: I see that anonymous labels are only for URLs | 10:09 |
| kashyap | stephenfin: I'm trying to refer to a section in the _same_ document; thus no URL here | 10:09 |
| kashyap | Here is a small concrete example: http://paste.openstack.org/show/788455/ | 10:11 |
| * kashyap just changes the label name, and sticks with existing syntax; as anonymous labels don't seem to work in this case. | 10:15 | |
| kashyap | Okay, that works. | 10:20 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | 10:20 |
| *** rpittau is now known as rpittau|bbl | 10:21 | |
| *** jawad_axd has joined #openstack-nova | 10:25 | |
| *** udesale has joined #openstack-nova | 10:38 | |
| *** macz has joined #openstack-nova | 10:46 | |
| *** macz has quit IRC | 10:50 | |
| *** udesale has quit IRC | 11:14 | |
| *** jangutter has quit IRC | 11:29 | |
| *** artom has quit IRC | 11:38 | |
| *** yedongcan has left #openstack-nova | 11:41 | |
| *** panda is now known as panda|drappt | 11:46 | |
| *** bhagyashris|NHO is now known as bhagyashris | 12:02 | |
| *** dtantsur|afk is now known as dtantsur | 12:07 | |
| *** mrch_ has joined #openstack-nova | 12:09 | |
| *** xek__ has joined #openstack-nova | 12:13 | |
| *** xek_ has quit IRC | 12:16 | |
| *** rpittau|bbl is now known as rpittau | 12:25 | |
| openstackgerrit | waleed mousa proposed openstack/os-vif master: Add delete_netdev field in VIFPortProfileOpenVSwitch profile https://review.opendev.org/702857 | 12:29 |
| *** macz has joined #openstack-nova | 12:35 | |
| openstackgerrit | waleed mousa proposed openstack/os-vif master: Add delete_netdev field in VIFPortProfileOpenVSwitch profile https://review.opendev.org/702857 | 12:38 |
| *** macz has quit IRC | 12:39 | |
| *** tetsuro has quit IRC | 12:45 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | 12:53 |
| *** ratailor has quit IRC | 12:58 | |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | 13:00 |
| *** mkrai_ has quit IRC | 13:06 | |
| *** mgariepy has quit IRC | 13:10 | |
| *** mgariepy has joined #openstack-nova | 13:13 | |
| *** dviroel has joined #openstack-nova | 13:21 | |
| *** panda|drappt is now known as panda | 13:25 | |
| efried | stephenfin: I'm confused. Is https://review.opendev.org/#/c/702440/ related to mox somehow? | 13:36 |
| efried | I marked the mox blueprint complete, not the nova-net one. | 13:36 |
| efried | ...at least that's what I meant to do... | 13:37 |
| efried | lyarwood: I don't think you missed anything; that other trait merged later. I just wanted to pick it up in the same release since the timing worked out. | 13:38 |
| *** vesper11 has quit IRC | 13:42 | |
| *** vesper11 has joined #openstack-nova | 13:42 | |
| *** artom has joined #openstack-nova | 13:47 | |
| *** eharney has quit IRC | 13:47 | |
| *** artom has quit IRC | 13:52 | |
| *** udesale has joined #openstack-nova | 13:52 | |
| efried | stephenfin: tidy docs patch for the ironic virt driver, should be an easy +A for you: https://review.opendev.org/#/c/701998/ (Note that more is possible, but the information there is accurate afaict and it has nod from ironic cores) | 13:54 |
| *** Liang__ has joined #openstack-nova | 14:01 | |
| *** ociuhandu has quit IRC | 14:02 | |
| *** dtantsur is now known as dtantsur|brb | 14:03 | |
| *** ociuhandu has joined #openstack-nova | 14:06 | |
| iurygregory | efried, thanks for the +2 =) | 14:08 |
| efried | iurygregory: yahyoubetcha. Appreciate the patch. | 14:09 |
| iurygregory | \o/ | 14:09 |
| efried | dansmith: I started to look at https://review.opendev.org/#/c/580271/ and successor and they seem fine, but I don't have the confidence to approve. Would you please cast your discerning eye? Should be an easy +A for you, if it's right. | 14:14 |
| *** ociuhandu has quit IRC | 14:15 | |
| *** nweinber has joined #openstack-nova | 14:16 | |
| *** ociuhandu has joined #openstack-nova | 14:17 | |
| *** bhagyashris has quit IRC | 14:18 | |
| *** ociuhandu has quit IRC | 14:24 | |
| dansmith | efried: so I've always been told we shouldn't mess with those fields from python land, so I'm not confident to +W that either | 14:25 |
| efried | glad I asked | 14:25 |
| dansmith | I would think we'd want someone from oslo db land to say they're comfortable with them | 14:25 |
| dansmith | maybe stephenfin has already consulted the expert or is an expert himself since he's already +2? | 14:25 |
| stephenfin | I was expecting SQLA to handle those fields for us, tbh, but I couldn't find anything that suggested it would | 14:26 |
| *** psachin has quit IRC | 14:26 | |
| stephenfin | I didn't think about looking in oslo.db though /o\ /me goes to investigate | 14:28 |
| dansmith | the update *is* handled by SQLA fwiw | 14:30 |
| *** awalende has quit IRC | 14:30 | |
| sean-k-mooney | dansmith: efried it looks like there are some issues with the arq binding on the cyborg side http://paste.openstack.org/show/788470/ | 14:30 |
| stephenfin | Yup, have spotted the use of 'TimestampMixin' in NovaBase | 14:31 |
| *** awalende has joined #openstack-nova | 14:31 | |
| *** derekh has joined #openstack-nova | 14:31 | |
| efried | gibi: I'd like to queue up some review time from you for the provider config file bp if possible please. It's pretty straightforward stuff, kind of fun to look at IMO. It's very close to ready, if you want to preview: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/provider-config-file | 14:32 |
| *** eharney has joined #openstack-nova | 14:32 | |
| gibi | efried: ack, tomorrow I can start the day with that | 14:32 |
| efried | great, thank you. | 14:32 |
| dansmith | sean-k-mooney: ack | 14:32 |
| belmoreira | Hi, we are hitting https://review.opendev.org/#/c/684375/3 can we get an agreement on how to proceed? kashyap stephenfin | 14:33 |
| *** pcaruana has quit IRC | 14:33 | |
| efried | sean-k-mooney: are other nova api comms working in that env? Could it just be a creds-in-config thing? | 14:33 |
| sean-k-mooney | ill try booting a normal vm | 14:34 |
| sean-k-mooney | that shoudl trigger the neutron events | 14:34 |
| *** awalende has quit IRC | 14:35 | |
| sean-k-mooney | ya that booted fine | 14:35 |
| efried | sean-k-mooney: point would be cyborg.conf's creds to [nova] | 14:35 |
| sean-k-mooney | so it could be | 14:35 |
| sean-k-mooney | nova] | 14:36 |
| sean-k-mooney | project_domain_name = Default | 14:36 |
| sean-k-mooney | project_name = service | 14:36 |
| sean-k-mooney | user_domain_name = Default | 14:36 |
| sean-k-mooney | password = password | 14:36 |
| sean-k-mooney | username = nova | 14:36 |
| sean-k-mooney | auth_url = http://192.168.135.77/identity | 14:36 |
| sean-k-mooney | auth_type = password | 14:36 |
| sean-k-mooney | that looks fine to me | 14:36 |
| sean-k-mooney | well fine for devstack | 14:37 |
| stephenfin | belmoreira: Should have been more exact about that. I'm not happy with changing the default for everyone to work around a temporary blip with a buggy kernel (which is what that appears to be) | 14:37 |
| sean-k-mooney | we should not proceed with that patch unless we really really reallly have too | 14:38 |
| stephenfin | sean-k-mooney: are you referring to the hugepages one or something else? | 14:38 |
| efried | stephenfin: would you be okay if we implemented the [workaround] opt as suggested? | 14:39 |
| sean-k-mooney | the mempages mode=preferred change | 14:39 |
| stephenfin | efried: That depends on when the bug was introduced and when it was fixed. Latter seems to be 4.19 but kashyap's notes don't appear to capture the former | 14:40 |
| belmoreira | sean-k-mooney what's your main concern? | 14:40 |
| stephenfin | not sean-k-mooney but I'm going to guess potentially huge performance penalties if you haven't correctly configured your host | 14:40 |
| sean-k-mooney | so i originally suggested perfered to kashyap as a potentil solution but im more conserned about non hugepage guest that use hw:numa_nodes=* | 14:42 |
| kashyap | belmoreira: Hi | 14:42 |
| * kashyap reads | 14:42 | |
| sean-k-mooney | for hugepage we pin the pages seperately so they will be allocated form the numa node we expect | 14:42 |
| sean-k-mooney | however setting perfered by default means we can be sure that the memory of a gues that has a numa doploty but is not backed by hugepage will come form the numa node we expect | 14:43 |
| sean-k-mooney | which will cause issue if we ever model numa in placment | 14:43 |
| sean-k-mooney | i suspect that most of the time it would likely be fine but im not sure what all the sideeffect will be | 14:45 |
| sean-k-mooney | belmoreira: have you tested the patch and conrimed that it fixes the issue? | 14:45 |
| sean-k-mooney | belmoreira: we were not able to get our customer to do that and we did not have a plathform where we could repoduce the issue | 14:45 |
| sean-k-mooney | belmoreira: so we dont acatully know that will fix it although we suspect it will | 14:45 |
| kashyap | stephenfin: I don't know when exactly it was introduced; I need to do kernel commit message digging (if it's not there, then worse, do bisection myself or ask a KVM dev) | 14:46 |
| sean-k-mooney | stephenfin: belmoreira i would be more ok with his as a workaround config option and keeping the default to strict with the expection we might remvoe it in the future. | 14:47 |
| kashyap | stephenfin: On forcing distros to backport — normally, that would be my approach such kernel cases. But here, we need to bear in mind all the existing OpenStack deployments in the wild. | 14:48 |
| * kashyap pulls the KVM tree; nuked it due to space reasons | 14:49 | |
| sean-k-mooney | i think this issue is only going to show up on centos/rhel maybe suse | 14:49 |
| kashyap | sean-k-mooney: I think they'd be the distros that are most likely to _backport_ those | 14:49 |
| *** mkrai_ has joined #openstack-nova | 14:49 | |
| sean-k-mooney | if you are using the hwe kernel on ubunutu 18.04 you will be on 5.x | 14:50 |
| kashyap | Right | 14:50 |
| *** macz has joined #openstack-nova | 14:50 | |
| sean-k-mooney | i supose if you stuck with the orginal ubuntu 18.04 kernel that was 4.15 | 14:50 |
| kashyap | belmoreira: I take it that rebooting the host kernel is not an option in your deployments? | 14:52 |
| sean-k-mooney | belmoreira: o i see you noted that the patch did solve the problem | 14:52 |
| kashyap | Yeah, he tested it | 14:52 |
| kashyap | sean-k-mooney: And in general, 'preferred' is what we recommend _anyway_, no? | 14:53 |
| sean-k-mooney | no | 14:53 |
| sean-k-mooney | we recommend strict | 14:54 |
| kashyap | I have to remind myself of this everytime. | 14:54 |
| sean-k-mooney | prefered makes the memory allcoation of non hugepage memory a hint not a requirement | 14:54 |
| kashyap | "Where, 'preferred' means: disable NUMA affinity and so the | 14:54 |
| kashyap | request is turned to a "hint", i.e. "if possible, allocate from the | 14:54 |
| kashyap | given NUMA node; otherwise, fallback to other nodes" | 14:54 |
| kashyap | Yes | 14:54 |
| *** macz has quit IRC | 14:55 | |
| sean-k-mooney | which will break our numa aware memory tracking | 14:55 |
| sean-k-mooney | and will not work if we model memory in plamcent in the future per numa node | 14:55 |
| sean-k-mooney | since we can rely on the memory being allcoated form the numa node we said | 14:55 |
| sean-k-mooney | for hugepage memeory the option will be ignored so hugepage backed vms will be fine | 14:55 |
| kashyap | Yeah, then I don't want to muck with defaults. With all these future caveats (which are not properly documented.) | 14:56 |
| sean-k-mooney | but vm with a numa toplogy but no hugepages could have there memory allcoated from any numa node if the one we select was full | 14:56 |
| * kashyap needs to head into a meeting; bbiab | 14:56 | |
| sean-k-mooney | stephenfin: kashyap belmoreira i left a comment on the patch | 14:58 |
| *** jawad_axd has quit IRC | 15:07 | |
| *** jawad_axd has joined #openstack-nova | 15:08 | |
| *** jawad_ax_ has joined #openstack-nova | 15:12 | |
| *** jawad_axd has quit IRC | 15:13 | |
| *** mkrai_ has quit IRC | 15:13 | |
| belmoreira | sorry, needed to leave the office | 15:14 |
| belmoreira | sean-k-mooney yes, I can reproduce with centos 7.6 kernel: Linux XXX 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 29 14:49:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | 15:15 |
| belmoreira | libvirtd 4.5.0-23 | 15:15 |
| belmoreira | qemu 2.12.0-33 | 15:16 |
| belmoreira | changing to "preferred" fix it (can create new instances) | 15:16 |
| *** jawad_ax_ has quit IRC | 15:16 | |
| sean-k-mooney | ya as far as i know this is not fixed in 7.6 | 15:16 |
| sean-k-mooney | i think the fix should be in 7.8 | 15:17 |
| belmoreira | kashyap we upgraded to centos 7.7 but didn't reboot the compute nodes. It's a very painful process | 15:17 |
| sean-k-mooney | it might be in 7.7 | 15:17 |
| sean-k-mooney | belmoreira: are you ok with it if we make it a workaround config option and default to strict | 15:18 |
| belmoreira | sean-k-mooney for now I can't reproduce it with 7.7 | 15:18 |
| sean-k-mooney | ok cool then that likely already has the backport | 15:18 |
| sean-k-mooney | although this is hardware specific | 15:18 |
| sean-k-mooney | so if its a differen model fo server then you migh not see it | 15:18 |
| belmoreira | sean-k-mooney yes, took me some time to isolate this | 15:19 |
| sean-k-mooney | ya it took us a day or two to figure this out downstream too when it was first reported to us | 15:20 |
| sean-k-mooney | its a very rare edgecase | 15:20 |
| sean-k-mooney | normlaly you will have dma regions per socket | 15:20 |
| sean-k-mooney | or numa node | 15:21 |
| belmoreira | I think that the workaround config will be useful for everyone that is running NUMA aware VMs. Then needs to be backported to older releases | 15:21 |
| sean-k-mooney | so you need a server that does not + requst a numa toploy + have a kernel with the kvm bug | 15:21 |
| sean-k-mooney | well no it will be useful for the minority that have ^ | 15:22 |
| sean-k-mooney | but i would be ok with proceeding on that basis | 15:22 |
| belmoreira | sean-k-mooney ok, true :) | 15:22 |
| belmoreira | but also shows that the nova community is aware of the issue and has a work around | 15:24 |
| belmoreira | sean-k-mooney thanks | 15:24 |
| kashyap | belmoreira: We're very much aware, FWIW, see this response on 'openstack-discuss' list: http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009770.html | 15:25 |
| belmoreira | sean-k-mooney but to clarify, "preferred" would break the future placement tracking and this should be disable as soon the new fixed kernel is loaded | 15:26 |
| sean-k-mooney | that placement tracking proably wont be a thing until V | 15:26 |
| sean-k-mooney | i could mess up our tracking in the resouce tracker today | 15:26 |
| sean-k-mooney | but if you have the choice between not being able to use an entire socket | 15:27 |
| *** ociuhandu has joined #openstack-nova | 15:27 | |
| sean-k-mooney | or slightly reduced performace im guess your ok with the slight perfromace hit | 15:27 |
| sean-k-mooney | and slightly in accurate tracking | 15:27 |
| *** Sundar has joined #openstack-nova | 15:28 | |
| sean-k-mooney | belmoreira: my conser is only for instace with a numa toplogy that dont use hugepages | 15:28 |
| *** ociuhandu has quit IRC | 15:28 | |
| belmoreira | got it | 15:29 |
| sean-k-mooney | hugepage guess will be tracked properly in either case | 15:29 |
| belmoreira | thanks a lot for this discussion and proposal | 15:30 |
| Sundar | sean-k-mooney: Please make sure to pull in https://review.opendev.org/698846 and https://review.opendev.org/700261 | 15:32 |
| *** dave-mccowan has joined #openstack-nova | 15:32 | |
| Sundar | They are called out as dependencies in the create/bind patch | 15:32 |
| Sundar | i.e. https://review.opendev.org/#/c/631244/ | 15:33 |
| sean-k-mooney | i cant have devstack pull in both if they are not in the same patch change | 15:33 |
| sean-k-mooney | *chain | 15:33 |
| *** mvkr has quit IRC | 15:33 | |
| sean-k-mooney | so ill have to create a local branch and merge them in | 15:33 |
| sean-k-mooney | i have https://review.opendev.org/#/c/698846/ but not https://review.opendev.org/#/c/700261/ | 15:34 |
| kashyap | belmoreira: stephenfin: efried: The kernel issue (https://review.opendev.org/#/c/684375/) has been latent. (Just confirmed w/ a KVM mainatiner.) | 15:34 |
| *** gyee has joined #openstack-nova | 15:34 | |
| Sundar | Both are listed as dependencies in the same Nova patch | 15:34 |
| kashyap | sean-k-mooney: (Responded on the change.) Thanks! | 15:34 |
| sean-k-mooney | yes but devstack can only clone one it does not have the zuul logic to create a merge commti from both | 15:34 |
| sean-k-mooney | but i can do it manually and restart the services | 15:35 |
| stephenfin | kashyap: I wonder why there wasn't a sudden spike so? Surely this would have been affecting belmoreira and co. for years now if it's been there forever | 15:35 |
| sean-k-mooney | Sundar: in general depends-on should not be used within the same repo | 15:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 15:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 15:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add stable device rescue docs https://review.opendev.org/700837 | 15:35 |
| kashyap | stephenfin: Yeah, I don't have a solid answer to that yet :-( | 15:35 |
| sean-k-mooney | https://review.opendev.org/#/c/698846/ should be rebased on https://review.opendev.org/#/c/700261/ | 15:35 |
| kashyap | stephenfin: Let me see the original kernel report I quoted in the commit, maybe there's something in there | 15:36 |
| sean-k-mooney | stephenfin: i have never seen hardware that actully does not have a dma regoin per numa node | 15:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | 15:37 |
| *** ociuhandu has joined #openstack-nova | 15:37 | |
| sean-k-mooney | stephenfin: and i mean ever in the 7+ years i have been working on this stuff | 15:37 |
| *** dave-mccowan has quit IRC | 15:37 | |
| sean-k-mooney | so i am not surprised people have not hit this before | 15:37 |
| stephenfin | efried: I think I'm going to have to get you to weigh in on https://review.opendev.org/#/c/696745/, because I _think_ I've addressed the concerns but everyone else is still avoiding it :) | 15:38 |
| kashyap | sean-k-mooney: Ah, interesting | 15:38 |
| stephenfin | It's almost all refactor noise _except_ the rename of 'nova.network.neutronv2.api' to just 'nova.network.neutron', and the subsequent removal of the 'nova.network.api' shim | 15:38 |
| kashyap | sean-k-mooney: I don't have the data about the hardware assmuption here (which hosts might not have the DMA32 region): https://lkml.org/lkml/2018/7/24/152 | 15:39 |
| sean-k-mooney | kashyap: i also suspect that htis was not alway the behavior or kvm by the way | 15:40 |
| sean-k-mooney | i proably had been that way for a long time but i susspect it was altered at somepoint | 15:41 |
| kashyap | sean-k-mooney: FWIW, a bit ago I checked w/ Paolo (one of the upstream KVM devs); he confirmed it's "latent" | 15:41 |
| kashyap | Probably | 15:41 |
| sean-k-mooney | maybe i dont knwo why but if feel like if you grabed ubuntu 12.04 or centos 5.4 it likely wont happen | 15:42 |
| belmoreira | stephenfin our batch VMs (running in dedicated compute nodes with NUMA/huge pages aware) are long lived VM | 15:42 |
| sean-k-mooney | kashyap: i just get the feelign like there was a refactor of this at some point but i dont recall why i have that feeling | 15:43 |
| belmoreira | true that we are seeing this issue for awhile. Until now our solution has been to reboot the affected node. | 15:43 |
| *** Liang__ has quit IRC | 15:44 | |
| *** Sundar has quit IRC | 15:45 | |
| *** ociuhandu has quit IRC | 15:45 | |
| *** ociuhandu has joined #openstack-nova | 15:45 | |
| *** mvkr has joined #openstack-nova | 15:48 | |
| *** macz has joined #openstack-nova | 15:49 | |
| *** zhanglong has joined #openstack-nova | 15:49 | |
| *** mlavalle has joined #openstack-nova | 15:56 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Avoid spurious error logging in _get_compute_nodes_in_db https://review.opendev.org/702902 | 16:00 |
| *** artom has joined #openstack-nova | 16:00 | |
| *** dtantsur|brb is now known as dtantsur | 16:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Error out interrupted builds https://review.opendev.org/687918 | 16:06 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Fix false ERROR message at compute restart https://review.opendev.org/699496 | 16:06 |
| *** TxGirlGeek has joined #openstack-nova | 16:09 | |
| dansmith | efried: do you have any opinions on the newer literal set syntax (i.e {1, 2}) ? | 16:10 |
| dansmith | IMHO, it's one of the worst things ever, because it's super confusing and looks like a dict | 16:10 |
| dansmith | just wondering if anyone else would be interested in a developer convention in nova of not adding code with that syntax to our tree | 16:10 |
| gibi | dansmith: I have no problem with the literal set sytnax for me the absense of ':' is enough to notice that it is a set | 16:11 |
| dansmith | it's super easy to not notice that there's no : though | 16:12 |
| gibi | I guess we are different | 16:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Ensure source service is up before resizing/migrating https://review.opendev.org/701757 | 16:12 |
| dansmith | gibi: that's fine, I asked because I was wondering if I'm the only one | 16:12 |
| artom | dansmith, as per your request, I'm not letting you forget https://review.opendev.org/#/c/687404/8 | 16:18 |
| *** mvkr has quit IRC | 16:20 | |
| gibi | dansmith: I think for me it is mostly about the fact that I used to it. I guess I would be pretty against assignment expression because that would be something I never used before in python | 16:20 |
| dansmith | artom: okay I'm in the middle of one of the cyborg patches, which is making me angry because apparently validating that our new methods are called like we expect them to is far too high a bar | 16:21 |
| artom | dansmith, to adjust nagging frequency, press 1 now ;) | 16:21 |
| dansmith | gibi: I think it's confusing that foo={} is a dict but foo={1} is a set, and easy to confuse foo={1:2} with foo={1,2}, and set comprehensions look a lot like dict comprehensions | 16:22 |
| dansmith | gibi: obviously you *can* tell the difference, it's just very easy to miss, IMHO | 16:22 |
| *** belmoreira has quit IRC | 16:22 | |
| gibi | I accept your view | 16:25 |
| dansmith | hah | 16:25 |
| efried | dansmith: I personally have no problem with {1, 2} set syntax. A set is a dict with only keys. And I don't have trouble distinguishing between commas and colons. | 16:26 |
| dansmith | aight, well, that settles it then | 16:26 |
| artom | " A set is a dict with only keys" Umm... | 16:26 |
| efried | dansmith: but jaypipes expressed a distaste for it (for the same reasons) so I avoided it... until he was gone. | 16:26 |
| dansmith | oh did he? damn, should have gotten my rule landed then | 16:26 |
| *** artom has quit IRC | 16:27 | |
| *** rpittau is now known as rpittau|afk | 16:27 | |
| *** zhanglong has quit IRC | 16:28 | |
| efried | a) I think set((1, 2)) is overly verbose and unnecessary, b) my IDE warns that I should use a set literal, c) I believe set((1, 2)) is also less efficient because it first creates a tuple, then calls a method to turn it into a set. | 16:28 |
| efried | obv b) I could ignore / turn off, and I'm sure c) is negligible in 99.99% of cases. But given aforementioned not-problem with the literal syntax, it's enough for me. | 16:29 |
| dansmith | yeah, I don't like how verbose set() has to be, and yes there's some overhead but I think it's trivial in this case | 16:29 |
| dansmith | ack | 16:30 |
| *** mvkr has joined #openstack-nova | 16:32 | |
| efried | stephenfin: before I dig into that: I'm of the opinion that a) we should make it look like the other service API shims. nova/$service_type/$project_name.py; b) I don't see a need for a generic abstract API layer. | 16:36 |
| efried | Is that what you've done? | 16:36 |
| *** tesseract has quit IRC | 16:39 | |
| sean-k-mooney | dansmith: for what its worth i dislike {} as that allways meen a dict so i dont like useing it to initalise a default. i alway use set() if i want a set in that case | 16:41 |
| sean-k-mooney | well if its empty that is | 16:41 |
| dansmith | well, confirmation that I'm not crazy, at least | 16:41 |
| efried | If set(1, 2) were allowed I would be less grouchy about it. | 16:42 |
| dansmith | or.. "at least as crazy as sean-k-mooney" I guess :P | 16:42 |
| sean-k-mooney | efried you have to do set({...}) right | 16:42 |
| efried | but having multiple meanings for the same operator/punctuation doesn't bother me as long as it's clear from the context, which IMO it is in this case, because colons. | 16:42 |
| sean-k-mooney | that is annoying | 16:42 |
| efried | sean-k-mooney: set($iterable) | 16:42 |
| sean-k-mooney | ya | 16:43 |
| * stephenfin wonders why they didn't choose <> | 16:43 | |
| efried | so {...} if that's a set or a dict would work to get you a set of the keys; (...) for a tuple, [...] for a list etc. | 16:43 |
| dansmith | stephenfin: same | 16:43 |
| sean-k-mooney | stephenfin: becasue paython is annoying enough to parse as it is | 16:43 |
| efried | I don't really get why that would be better; but I'm going to guess they chose {} because, as I said, a set is a dict without values. | 16:43 |
| sean-k-mooney | <> i think is technically not equal in python 2 | 16:43 |
| dansmith | a set is not a dict with no values :) | 16:44 |
| stephenfin | sean-k-mooney: indeed, it is | 16:44 |
| stephenfin | I've seen that once in my life, I think | 16:44 |
| stephenfin | (docutils) | 16:44 |
| efried | dansmith: totally is. O(1) hashing, just no pointers out of the buckets. | 16:44 |
| dansmith | sean-k-mooney: as hateful as they are, I can imagine them doing that in py3 to break compatibility for fun and profit.. I guess dict literals just got added too early :) | 16:44 |
| sean-k-mooney | although i think its also the same as != and is checking identiy not equality but i might be wrong on that | 16:44 |
| dansmith | efried: totally is not :) | 16:45 |
| dansmith | it may be the same implementation under the covers, but that does not make the statement true :) | 16:45 |
| efried | nova-live-migration seems to be ill. Anyone available to dig in? | 16:47 |
| dansmith | I would think artom would be a good person to maybe start taking on some responsibility for that stuff given his numa LM work | 16:53 |
| dansmith | building some context for the future and what not | 16:54 |
| *** mlavalle has quit IRC | 16:54 | |
| *** psachin has joined #openstack-nova | 16:54 | |
| sean-k-mooney | i got landed with some downstream stuff but in theory i am ment to be helping porting those jobs to be non legacy too | 16:54 |
| sean-k-mooney | efried: is it blocking ci or just starting to fail more then we would like | 16:55 |
| *** mlavalle has joined #openstack-nova | 16:55 | |
| efried | sean-k-mooney: It has tanked many patches in CI in the last 18h or so. | 16:55 |
| efried | doesn't seem to be 100%, but it's close. | 16:56 |
| efried | I haven't looked into it at all because I haven't yet been bothered to f'ing unzip the logs. | 16:56 |
| sean-k-mooney | has my patch merged to fix that yet | 16:56 |
| sean-k-mooney | you rechecked it this morning/last night right | 16:56 |
| efried | your patch did merge, yes. Not sure if any of the failed jobs started since then. | 16:57 |
| sean-k-mooney | ya looks like it di | 16:57 |
| efried | I don't even know if the failures are the same across the board. I just know many have been failing. (Most of the nova-next failures are due to 'multiple possible networks', which I'm fixing elsewhere.) | 16:57 |
| sean-k-mooney | yes with your tempest patch | 16:58 |
| *** damien_r has quit IRC | 16:59 | |
| sean-k-mooney | that should also be merged now. if no one else fixes it ill try and get though these backprots then i can look at ci but proably tomorow or monday. | 17:00 |
| *** slaweq has quit IRC | 17:01 | |
| *** artom has joined #openstack-nova | 17:03 | |
| *** slaweq has joined #openstack-nova | 17:04 | |
| efried | stephenfin: +2 on https://review.opendev.org/#/c/696745/ | 17:08 |
| efried | I guess controversy was in previous versions. | 17:08 |
| efried | I get the gripe about making backports difficult, but the code base will just get messier and messier if we don't bite the bullet and clean this stuff up from time to time. | 17:08 |
| efried | Besides, I don't see backports being hugely affected by this. | 17:08 |
| efried | So ++ | 17:08 |
| stephenfin | thanks | 17:08 |
| *** slaweq has quit IRC | 17:09 | |
| *** iurygregory has quit IRC | 17:14 | |
| *** slaweq has joined #openstack-nova | 17:20 | |
| *** slaweq has quit IRC | 17:25 | |
| efried | I can't even see why https://zuul.opendev.org/t/openstack/build/093f129de3ca47549239eed0d6acf288 is failing. The job output says devstack failed, but the devstack log looks okay to me. Anyone? Bueller? | 17:26 |
| efried | /opt/stack/new/devstack/lib/databases/mysql: line 64: mysql: command not found | 17:29 |
| efried | ^ on the subnode. wtf? | 17:29 |
| artom | Wait, that .gz compression thing hasn't been fixed? | 17:30 |
| efried | artom: sean-k-mooney fixed it somewheres, but this job may have started before that fix merged. | 17:30 |
| efried | Real PITA. | 17:30 |
| artom | Seriously, wit hummus. | 17:30 |
| efried | mm, hummus. | 17:30 |
| * efried feeds face | 17:30 | |
| *** udesale has quit IRC | 17:31 | |
| sean-k-mooney | artom: https://review.opendev.org/#/c/702465/ meged this morning | 17:31 |
| sean-k-mooney | but if the job started before that merged then ya they would be compressed | 17:32 |
| artom | sean-k-mooney, were they not gziped but transparently decompressed before? | 17:32 |
| sean-k-mooney | yes | 17:32 |
| sean-k-mooney | well no | 17:32 |
| artom | So what killed the transparent decompression? | 17:32 |
| sean-k-mooney | they were gzip and serve with hearders to decompress them | 17:32 |
| sean-k-mooney | but that had issues with swift | 17:33 |
| artom | Oh, the browser did it | 17:33 |
| artom | Client-side | 17:33 |
| sean-k-mooney | yes the borser did but the issue is they were getting double compressed wehn being served form swift | 17:33 |
| sean-k-mooney | so that is why you see the garbage in your browser | 17:33 |
| *** evrardjp has quit IRC | 17:34 | |
| artom | Oh, does Swift automagically compress text or something? | 17:34 |
| sean-k-mooney | it is still decompressing with deflate but not then decompressing that with gzip | 17:34 |
| *** evrardjp has joined #openstack-nova | 17:34 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392 | 17:34 |
| sean-k-mooney | artom: i did not look into it fully but fungi would be able to actully explain it | 17:34 |
| sean-k-mooney | artom: for now just do curl <url> | zcat | less | 17:35 |
| sean-k-mooney | or lnav lnav is good | 17:35 |
| artom | I want to make a `squat` and `rack` command | 17:35 |
| artom | So I can squat | curl | rack | 17:35 |
| *** jcosmao has left #openstack-nova | 17:37 | |
| sean-k-mooney | looking at the log failrue we are getting nova warning for using deprecated version of qemu and libvirt | 17:38 |
| fungi | sean-k-mooney: we're not clear whether it's a behavior in rackspace's swift implementation or the cdn they put in front of it, but if we upload .gz files with a content-type of application/gzip then they will be transparently decompressed when browsers or other clients request them and indicate they accept that content-type. sounds convenient, right? until you save a .tar.gz file there and it's | 17:39 |
| fungi | quietly decompressed on retrieval without altering the extension, so you've downloaded a file whose name claims it's a gzipped tarball but which is in reality now an uncompressed tar archive. now make that an intermediate step in a release publication job and you're pushing python sdists or similar tarballs somewhere when they're not actually installable (because tools think they're compressed when | 17:39 |
| fungi | they're not) | 17:39 |
| fungi | so we altered the way we store job artifacts in swift to make it so that we transparently compress everything on upload, unless it's already a compressed file, and assume that if the file has been precompressed then it should not be transparently decompressed for requesting clients | 17:40 |
| fungi | artom: ^ | 17:40 |
| efried | clearly fungi has had to explain this before :P | 17:42 |
| artom | fungi, to be honest I didn't grok most of that. My takeaway is: layers do deep even onions are like "whoa dude" | 17:42 |
| sean-k-mooney | yes | 17:42 |
| artom | *so deep | 17:42 |
| sean-k-mooney | but thanks for the explaination again. | 17:42 |
| fungi | we fixed the obvious cases we knew about in abstract jobs/roles but there were some in devstack which had to get fixed too | 17:43 |
| sean-k-mooney | fungi: funnialy enogh the last time i tried deploying zuul at home geting the logs to render properly in the bower when loadbalnace via nginx in k8s was actully one of the hardest parts | 17:44 |
| fungi | and there are also some project-specific jobs which are also precompressing logs from things which will need to be adjusted to stop compressing within the job | 17:44 |
| fungi | which should be updated as we encounter them | 17:44 |
| efried | dansmith: Would you please look at https://review.opendev.org/#/c/696392/ ? I'm not clear whether this counts as an API change... | 17:45 |
| efried | artom: so are you investigating the failure amid all of that? | 17:47 |
| artom | efried, which failure? The missing MySQL? | 17:48 |
| efried | yeah | 17:48 |
| artom | Heh, I'm being volunteered, aren't I? ;) | 17:48 |
| artom | I'll take a look :) | 17:48 |
| efried | whatever's causing nova-live-migration to fail | 17:48 |
| efried | thanks artom. Rather you than me. | 17:48 |
| efried | I'll go check the other instances of n-l-m fail and see if they're the same. | 17:49 |
| artom | sean-k-mooney, zless is a thing, btw :) | 17:50 |
| artom | Don't need to | zcat | less | 17:50 |
| artom | Straight up | zless | 17:50 |
| sean-k-mooney | artom: sure but im actully sendign it to lnav | 17:50 |
| sean-k-mooney | and you use to be able to send it to firefox | 17:50 |
| sean-k-mooney | but they droped readign from standar in at some point | 17:51 |
| sean-k-mooney | but good to know zless is a thing. zgrep is also a thing | 17:51 |
| dansmith | efried: that patch doesn't change what can be raised on error, so not an api change needing a microversion, if that's what you're asking for | 17:51 |
| dansmith | efried: it adds a scan of all cells on delete, which the user doesn't know about anyway | 17:52 |
| efried | artom: so far 5/5 on the ones I've looked at, fails from the last 2h or so. | 17:52 |
| efried | dansmith: okay. afaict it makes it so HostMappingNotFound can no longer be raised when removing host from agg. That's kind of a behavior change, so I wasn't really sure. | 17:54 |
| artom | efried, so, mysql-client should be getting installed | 17:54 |
| efried | artom: I don't disagree. Why isn't it? | 17:54 |
| artom | And it isn't, afaict | 17:54 |
| artom | efried, yeah, no idea what changed yet | 17:54 |
| efried | okay. Maybe -infra knows? | 17:54 |
| dansmith | efried: it's the same error handler as ComputeHostNotFound in the api code though so it doesn't change anything the user can see | 17:55 |
| efried | right, what I mean is that with a certain set of conditions, previously there would *be* an error, but now there would *not* be. | 17:56 |
| efried | ...with those same conditions. | 17:56 |
| efried | I guess that's kind of the definition of a bug fix though | 17:56 |
| efried | so I'm going to +2. | 17:56 |
| dansmith | the user doesn't know about those conditions | 17:56 |
| dansmith | it'd be like saying we failed on mysql 4.1 and succed on 4.2 so that's user-visible | 17:56 |
| efried | Okay, I must have misinterpreted that based on the bug description. | 17:56 |
| *** yan0s has quit IRC | 17:56 | |
| efried | okay. | 17:57 |
| artom | efried, what was the last time that job passed? I want to compare logs, see if it installed the mysqlclient | 17:58 |
| efried | I'll look for one... | 17:59 |
| artom | Hrmm, so it installs it on the *main* node | 17:59 |
| efried | artom: here's one from ~24h ago, not sure if that's the most recent https://review.opendev.org/#/c/696745/ | 18:00 |
| artom | efried, that works, thanks | 18:01 |
| *** derekh has quit IRC | 18:01 | |
| artom | Ah, so, on the main node, because we install the server, that pulls in the client | 18:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.opendev.org/702943 | 18:01 |
| efried | artom: assume this has nothing to do with cirros images http://lists.openstack.org/pipermail/openstack-discuss/2020-January/012024.html | 18:06 |
| artom | efried, don't think so - looks like it has something to do with whether we configure glance or not | 18:07 |
| artom | The broken one runs through this: | 18:07 |
| artom | 2020-01-16 14:30:39.880 | + ./stack.sh:echo_summary:458 : echo -e Configuring Glance | 18:07 |
| artom | 2020-01-16 14:30:39.883 | + ./stack.sh:main:1160 : init_glance | 18:07 |
| artom | 2020-01-16 14:30:39.885 | + lib/glance:init_glance:276 : rm -rf /opt/stack/data/glance/images | 18:07 |
| artom | 2020-01-16 14:30:39.889 | + lib/glance:init_glance:277 : mkdir -p /opt/stack/data/glance/images | 18:07 |
| artom | 2020-01-16 14:30:39.893 | + lib/glance:init_glance:280 : recreate_database glance | 18:07 |
| efried | gdi, why do I suck at logstash. Shouldn't it be as simple as searching for message:"mysql: command not found" ?? | 18:08 |
| *** maciejjozefczyk has quit IRC | 18:09 | |
| efried | ...unless logstash is also trying to read gzipped files and getting garbage. | 18:11 |
| artom | Hrmm, hol'up | 18:12 |
| artom | Working: is_service_enabled g-reg | 18:12 |
| artom | Broken: is_glance_enabled | 18:12 |
| artom | Which looks for g- in ENABLED_SERVICES, so g-api matches | 18:12 |
| sean-k-mooney | artom: that is not somthign that would be changeing per fun but it would be different if patches had not been rebased i guess | 18:13 |
| melwitt | do you think we would expect to run mysql commands on the subnode? that one is compute only and shouldn't have a database on it anyway | 18:15 |
| efried | artom: https://review.opendev.org/#/c/702707/ | 18:15 |
| artom | efried, bingo | 18:15 |
| artom | That eventually triggers it to attempt to recreate the glance database on the subnode | 18:16 |
| artom | Which calls the missing mysql binary | 18:16 |
| artom | I gotta run to a quick apt | 18:16 |
| dansmith | melwitt: that may be true for nova, but not all the services | 18:16 |
| melwitt | dansmith: ack | 18:16 |
| dansmith | and of course "mysql -h primary" could be some use case for sequencing (just making that up) | 18:17 |
| efried | artom: will this make it okay? https://review.opendev.org/#/c/702709/1 | 18:17 |
| sean-k-mooney | dansmith: while you are right i dont think cinder cyborg or neutron do direct db acess form the compute nodes eitehr | 18:17 |
| dansmith | sean-k-mooney: apparently glance is the service in question here? | 18:18 |
| sean-k-mooney | ya | 18:18 |
| dansmith | presumably other projects do or could use multinode for things | 18:18 |
| dansmith | (or should) | 18:18 |
| sean-k-mooney | glance should normally not be on the compute node but we can enable it there if we want | 18:19 |
| *** ociuhandu_ has joined #openstack-nova | 18:19 | |
| sean-k-mooney | maybe its beign used for the multi image store testing or something like that | 18:19 |
| *** ociuhandu has quit IRC | 18:22 | |
| *** ociuhandu_ has quit IRC | 18:23 | |
| efried | artom: I guess not, since they both merged at essentially the same time. | 18:24 |
| openstackgerrit | Merged openstack/nova stable/pike: lxc: make use of filter python3 compatible https://review.opendev.org/676502 | 18:29 |
| *** dtantsur is now known as dtantsur|afk | 18:30 | |
| *** slaweq has joined #openstack-nova | 18:31 | |
| efried | https://bugs.launchpad.net/nova/+bug/1860021 | 18:33 |
| openstack | Launchpad bug 1860021 in OpenStack Compute (nova) "nova-live-migration fails 100% with "mysql: command not found" on subnode" [Undecided,New] | 18:33 |
| efried | Correct me if I'm wrong: we didn't need init_glance to be happening on the subnode, cause it wasn't before? | 18:34 |
| *** martinkennelly has quit IRC | 18:34 | |
| *** liuyulong has quit IRC | 18:34 | |
| sean-k-mooney | efried: well we dont need a second copy of glance running on the subnode no | 18:35 |
| sean-k-mooney | unless we are specificly trying to test image that are in multiple data stores | 18:35 |
| melwitt | is it only our multinode job that's failing? I would expect all would be | 18:35 |
| sean-k-mooney | i think this was only nova livemigation? | 18:35 |
| efried | melwitt: many patches have failed with just n-l-m in the red. A few have failed with other things, but I haven't looked into them. | 18:35 |
| melwitt | meaning I would think all multinode jobs regardless of project would fail from this | 18:36 |
| efried | (other than nova-next with 'multiple possible networks' as noted, fix in the pipe) | 18:36 |
| *** slaweq has quit IRC | 18:36 | |
| sean-k-mooney | melwitt: it could be that nova live migration is a legacy job | 18:36 |
| melwitt | hm, that is surprising. so that means there's some other boilerplate in other jobs that we don't have in nova-live-migration if we're the only ones failing | 18:36 |
| efried | perhaps somehow we're installing mysql client on the other jobs | 18:36 |
| melwitt | yeah, that's what I'm wondering | 18:37 |
| sean-k-mooney | and our other multinode jobs may be zuul v3 so the glance service might not be enabled on the sub nodes | 18:37 |
| melwitt | sean-k-mooney: in what way is it a legacy job? I remember moving it over to zuul v3 | 18:37 |
| efried | the right thing would be to figure out how to make the subnode not init_glance; but I would be happy enough with a solution that got mysql client installed there so we could go back to the way we were. | 18:37 |
| sean-k-mooney | oh maybe im thinking of nova-next | 18:37 |
| efried | n-l-m is legacy | 18:37 |
| efried | isn't it? | 18:37 |
| melwitt | I didn't think so | 18:37 |
| melwitt | let me look it up because maybe I'm wrong | 18:38 |
| sean-k-mooney | well there is one way to find out | 18:38 |
| efried | if it weren't, wouldn't we be not having the gz problem? | 18:38 |
| sean-k-mooney | https://github.com/openstack/nova/tree/stable/stein/playbooks/legacy | 18:38 |
| melwitt | oh yeah, I see https://review.opendev.org/#/c/693364 | 18:38 |
| melwitt | so moving it to the .zuul.yaml does not make it zuul v3 apparently. I didn't know that | 18:38 |
| sean-k-mooney | so it has playbooks in the legacy folder and https://github.com/openstack/nova/blob/stable/stein/.zuul.yaml#L114-L122 still runs them so ya | 18:39 |
| melwitt | ok. I had previously thought that migrating jobs in tree made them zuul v3 but that was a wrong thought | 18:39 |
| melwitt | sorry about that | 18:39 |
| *** ociuhandu has joined #openstack-nova | 18:40 | |
| sean-k-mooney | melwitt: yep matt start to move it but did not have time to finish it | 18:40 |
| sean-k-mooney | also you gerrit foo is better then mine i spent 20 minuts trying to find that last week an gave up | 18:40 |
| sean-k-mooney | maybe i filtered out abandoned chagnes | 18:41 |
| melwitt | lol. I just did "message:nova-live" nothing fancy | 18:41 |
| sean-k-mooney | message:? | 18:41 |
| melwitt | yeah means look in commit message | 18:41 |
| sean-k-mooney | oh that checks the commt message? | 18:41 |
| melwitt | "comment:" looks in comments | 18:41 |
| sean-k-mooney | see you gerrit foo is better then mine | 18:41 |
| melwitt | gerrit search is pretty cool | 18:41 |
| sean-k-mooney | so ya i would guess that this has somethign to do with devstack-gate | 18:43 |
| sean-k-mooney | the legacy jobs are going to be using devstack-gate and the non legacy ones will not | 18:43 |
| melwitt | I'm trying to look at tempest-multinode-full-py3 to see if it's legacy but I think you could figure that out faster than me | 18:44 |
| melwitt | that's an example from neutron | 18:44 |
| melwitt | which is passing | 18:44 |
| sean-k-mooney | i think that is not a legacy job | 18:44 |
| sean-k-mooney | the legacy ones usually specify run: playbook | 18:45 |
| *** ociuhandu has quit IRC | 18:45 | |
| melwitt | I see, ok. so that's a data point in favor of it being related to legacy-ness | 18:45 |
| melwitt | I don't know what it is about the non-legacy stuff that can handle the mysql commands. do they have the client available or something more involved | 18:46 |
| *** psachin has quit IRC | 18:46 | |
| sean-k-mooney | is it related to this? https://github.com/openstack/devstack-gate/commit/183a58eab185c2e6f48afb4d99417d49e88c0f5a | 18:47 |
| sean-k-mooney | specificlly https://github.com/openstack/devstack-gate/commit/183a58eab185c2e6f48afb4d99417d49e88c0f5a#diff-987768d02fbf43ebb74ad9a359222903R27 | 18:47 |
| sean-k-mooney | matt enabled glance api on the subnode | 18:48 |
| artom | efried, back - no, it won't, because is_glance_enabled checks for 'g-' in the ENABLED_SERVICES | 18:48 |
| sean-k-mooney | that was also like 27 days ago | 18:48 |
| artom | So g-api triggers it too | 18:48 |
| efried | Looking for some way to redefine is_glance_enabled as a stopgap | 18:48 |
| artom | We might want to consult with the devstack folks | 18:49 |
| efried | wherezat? -infra? -qa? | 18:49 |
| sean-k-mooney | qa | 18:49 |
| sean-k-mooney | artom: are you sure its not https://github.com/openstack/devstack-gate/commit/183a58eab185c2e6f48afb4d99417d49e88c0f5a#diff-987768d02fbf43ebb74ad9a359222903R27 | 18:49 |
| artom | sean-k-mooney, I'm never sure of anything, but I don't think so | 18:50 |
| sean-k-mooney | i guess that is GRENADE_SUBNODE_MASTER | 18:50 |
| efried | could be that, and then the glance-enabled check exposed it. | 18:50 |
| artom | Wait, what did that change? | 18:51 |
| artom | Added g-api to the subnode? | 18:51 |
| *** ralonsoh has quit IRC | 18:51 | |
| sean-k-mooney | yes | 18:52 |
| sean-k-mooney | although maybe only in the grenade jobs | 18:53 |
| *** openstackgerrit has quit IRC | 18:58 | |
| *** openstackgerrit has joined #openstack-nova | 19:05 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test fix for bug 1860021 https://review.opendev.org/702961 | 19:05 |
| openstack | bug 1860021 in devstack "nova-live-migration fails 100% with "mysql: command not found" on subnode" [Undecided,In progress] https://launchpad.net/bugs/1860021 - Assigned to Radosław Piliszek (yoctozepto) | 19:05 |
| efried | artom: ^ | 19:05 |
| artom | efried, thanks! | 19:08 |
| efried | artom: thanks for helping triage this. | 19:09 |
| artom | \o/ I'm useful! | 19:09 |
| *** ccamacho has quit IRC | 19:18 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Cache security group driver https://review.opendev.org/697505 | 19:22 |
| *** nweinber_ has joined #openstack-nova | 19:30 | |
| *** nweinber has quit IRC | 19:33 | |
| *** nweinber__ has joined #openstack-nova | 19:47 | |
| *** nweinber_ has quit IRC | 19:49 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Block deleting compute services with in-progress migrations https://review.opendev.org/698113 | 19:57 |
| openstackgerrit | sean mooney proposed openstack/nova stable/stein: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/702971 | 19:59 |
| openstackgerrit | sean mooney proposed openstack/nova stable/stein: Block rebuild when NUMA topology changed https://review.opendev.org/702972 | 19:59 |
| openstackgerrit | sean mooney proposed openstack/nova stable/stein: Disable NUMATopologyFilter on rebuild https://review.opendev.org/702973 | 19:59 |
| openstackgerrit | sean mooney proposed openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974 | 19:59 |
| sean-k-mooney | that totally did not take an hour... | 20:00 |
| sean-k-mooney | also night o/ | 20:00 |
| *** tosky has quit IRC | 20:04 | |
| efried | sean-k-mooney: FYI I'm still getting gzips in https://7cb0f59696603595f18f-52bbbaaadc4f7624d8dbaffca646d87d.ssl.cf1.rackcdn.com/702961/1/check/nova-live-migration/f6ff2d6/logs/ | 20:21 |
| *** tbachman has joined #openstack-nova | 20:29 | |
| gmann | efried: this job does not use the devstack roles sean-k-mooney modified to not gzips the logs. somewhere legacy base jobs need to do the same. | 20:30 |
| efried | okay. I wasn't sure. | 20:30 |
| melwitt | same in here https://zuul.opendev.org/t/openstack/build/fb368e8af1854170b701dac772f53bc8/log/logs/mysql/error.txt.gz | 20:31 |
| melwitt | grenade-py3 | 20:32 |
| gmann | yeah that is also legacy job. i am not sure where exactly those logs are defined | 20:33 |
| efried | I will fast approve patches that fix that. | 20:33 |
| efried | and do a little dance | 20:34 |
| melwitt | dang, everything legacy | 20:35 |
| *** mriedem has joined #openstack-nova | 20:36 | |
| melwitt | I guess I don't understand that bc it says legacy jobs should have migrated with a legacy- prefix in the name https://docs.openstack.org/infra/manual/zuulv3.html#legacy-job-migration-details | 20:37 |
| melwitt | like why are all the jobs secret legacy somehow | 20:37 |
| *** slaweq has joined #openstack-nova | 20:38 | |
| melwitt | ok, should have read further before typing. once moved in-tree they had to be renamed to not collide with naming, now this is the next step https://docs.openstack.org/infra/manual/zuulv3.html#reworking-legacy-jobs-to-be-v3-native | 20:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Clarify fitting hugepages log message https://review.opendev.org/702981 | 20:39 |
| melwitt | looks like there's some work in-flight for the grenade jobs https://review.opendev.org/#/q/topic:grenade_zuulv3+(status:open+OR+status:merged) | 20:42 |
| *** artom has quit IRC | 20:45 | |
| *** amuller has joined #openstack-nova | 20:51 | |
| amuller | hi folks, looking at nova.conf... [glance] -> api_servers was deprecated in https://github.com/openstack/nova/commit/cffbc2e431e90f7b6a67cf4a82349ee1d8de202a | 20:51 |
| amuller | I was wondering what option replaced it? | 20:51 |
| efried | amuller: Use standard ksa opts to get at glance | 20:52 |
| amuller | efried: do you remember the section and conf key off the top of your head? | 20:52 |
| efried | we don't support rotating IPs (poor man's load balancer hack) there anymore | 20:52 |
| amuller | [keystone_authtoken] ? | 20:53 |
| efried | amuller: If you simply remove api_servers, it should just pick up what's in your service catalog. If you really need to specify something different, you can use [glance]endpoint_override. | 20:53 |
| efried | But I would suggest if you find yourself needing that ^ then your service catalog is busted :) | 20:53 |
| efried | I guess some edge deployments might want to override, I think I heard that from someone. | 20:53 |
| dansmith | from me | 20:55 |
| amuller | efried++ | 20:55 |
| amuller | thank you | 20:55 |
| efried | no problem, good luck. | 20:55 |
| amuller | I see that TripleO Stein still sets [glance] api_servers | 20:56 |
| amuller | though the option was deprecated in Queens =p | 20:56 |
| efried | if only someone from tripleo was paying attention | 20:56 |
| *** nweinber__ has quit IRC | 20:57 | |
| efried | nova meeting now ish in #openstack-meeting | 20:59 |
| *** alistarle has joined #openstack-nova | 21:04 | |
| *** slaweq has quit IRC | 21:09 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478 | 21:23 |
| openstack | bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929 | 21:23 |
| *** eharney has quit IRC | 21:26 | |
| *** alistarle has quit IRC | 21:38 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 21:50 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 21:50 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 21:50 |
| dustinc | efried: it is ready for re-review now :) | 21:58 |
| efried | ack | 21:58 |
| *** gentoorax is now known as gentoorax_away | 21:59 | |
| *** gentoorax_away is now known as gentoorax | 21:59 | |
| donnyd | sean-k-mooney: FN is back in operation | 22:00 |
| * donnyd waves to everyone in nova | 22:01 | |
| *** brault has joined #openstack-nova | 22:07 | |
| *** rcernin has joined #openstack-nova | 22:07 | |
| efried | o/ donnyd! | 22:10 |
| *** amuller has quit IRC | 22:14 | |
| *** xek__ has quit IRC | 22:17 | |
| *** artom has joined #openstack-nova | 22:18 | |
| *** TxGirlGeek has quit IRC | 22:21 | |
| *** zhanglong has joined #openstack-nova | 22:37 | |
| efried | dustinc: if you write one more meaty test case, I'll be +2 on that top patch. | 22:49 |
| dustinc | efried: happy to, did you post the case in gerrit? | 22:50 |
| efried | and I convinced gibi to put the series in his queue for tomorrow morning, so you could conceivably come back next week to a completed bp :) | 22:50 |
| efried | dustinc: yeah | 22:50 |
| dustinc | ok, maybe I will drop my other task to get that done.. | 22:50 |
| *** smcginnis is now known as smcginnis|PTO | 22:52 | |
| *** zhanglong has quit IRC | 22:53 | |
| *** dviroel has quit IRC | 22:54 | |
| *** TxGirlGeek has joined #openstack-nova | 23:08 | |
| *** awalende has joined #openstack-nova | 23:24 | |
| *** awalende has quit IRC | 23:29 | |
| *** tbachman has quit IRC | 23:47 | |
| *** mlavalle has quit IRC | 23:52 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Join migration_context and flavor in Migration.instance https://review.opendev.org/696572 | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!