Monday, 2020-01-13

« Sunday, 2020-01-12 Index Tuesday, 2020-01-14 »
*** threestrands has joined #openstack-nova00:38
*** jistr has quit IRC00:45
*** jistr has joined #openstack-nova00:48
*** yedongcan has joined #openstack-nova00:53
*** Liang__ has joined #openstack-nova00:58
*** mvkr has joined #openstack-nova01:15
*** yedongcan has quit IRC01:20
*** lvbin02 has joined #openstack-nova01:41
*** threestrands has quit IRC01:43
*** lvbin01 has quit IRC01:44
*** lvbin02 is now known as lvbin0101:44
*** yedongcan has joined #openstack-nova02:11
*** tbachman has joined #openstack-nova02:20
*** awalende has joined #openstack-nova02:45
*** awalende has quit IRC02:49
openstackgerritBrin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated  https://review.opendev.org/58027103:09
*** threestrands has joined #openstack-nova03:10
*** threestrands has quit IRC03:11
*** threestrands has joined #openstack-nova03:11
*** huaqiang has quit IRC03:24
*** mkrai has joined #openstack-nova04:00
*** davee__ has joined #openstack-nova04:03
*** yedongcan has quit IRC04:04
*** davee_ has quit IRC04:05
*** davee___ has quit IRC04:05
*** davee_ has joined #openstack-nova04:06
*** nweinber__ has joined #openstack-nova04:08
*** bhagyashris has joined #openstack-nova04:11
*** nweinber__ has quit IRC04:22
*** bhagyashris has quit IRC04:42
*** bhagyashris has joined #openstack-nova05:04
*** TxGirlGeek has joined #openstack-nova05:10
alex_xuefried: sean-k-mooney, if we only support placement-ese, then we will get mixing case like, user specified the cpu_policy=dedicated or shared, also specified PCPU and VCPU in resources.05:12
*** awalende has joined #openstack-nova05:18
alex_xuefried: sean-k-mooney, huaqiang reminder me, we currently refuse both cpu_policy and PCPU/VPCU are specified, so it should be ok05:18
*** TxGirlGeek has quit IRC05:18
alex_xuefried: sean-k-mooney i'm ok with that algo, I guess that algo will be done at API layer,not the virt layer.05:19
*** awalende has quit IRC05:22
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:34
*** threestrands has quit IRC05:38
alex_xuefried: sean-k-mooney and if the user specified PCPU and VCPU in resources, then the value of InstanceNUMACell.cpu_policy will be 'dedicated'. then we didn't introduce new policy 'mixed' anymore, does sounds make sense to you?05:51
*** huaqiang has joined #openstack-nova05:55
*** ratailor has joined #openstack-nova05:58
*** zhanglong has joined #openstack-nova06:00
*** yedongcan has joined #openstack-nova06:00
*** huaqiang has quit IRC06:03
*** huaqiang has joined #openstack-nova06:03
*** zhanglong has quit IRC06:04
*** zhanglong has joined #openstack-nova06:05
*** yedongcan has quit IRC06:07
*** huaqiang has quit IRC06:09
*** udesale has joined #openstack-nova06:09
*** huaqiang has joined #openstack-nova06:09
*** udesale is now known as udesale_06:28
*** udesale_ is now known as udesale06:29
*** Luzi has joined #openstack-nova06:35
*** zhanglong has quit IRC06:36
openstackgerritBrin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated  https://review.opendev.org/58027106:39
*** ratailor_ has joined #openstack-nova06:41
*** ratailor has quit IRC06:42
*** zhanglong has joined #openstack-nova06:44
*** ratailor__ has joined #openstack-nova06:46
*** zhanglong has quit IRC06:49
*** ratailor_ has quit IRC06:49
*** zhanglong has joined #openstack-nova06:51
*** shilpasd has joined #openstack-nova06:55
*** awalende has joined #openstack-nova07:01
*** jawad-axd has joined #openstack-nova07:02
*** awalende_ has joined #openstack-nova07:03
*** awalende has quit IRC07:05
*** jawad-axd has quit IRC07:06
*** slaweq has joined #openstack-nova07:07
*** jawad-axd has joined #openstack-nova07:07
*** jawad-ax_ has joined #openstack-nova07:10
*** jawad-axd has quit IRC07:12
*** slaweq has quit IRC07:12
*** rcernin has quit IRC07:13
*** slaweq has joined #openstack-nova07:16
*** zhanglong has quit IRC07:18
*** dpawlik has joined #openstack-nova07:21
*** zhanglong has joined #openstack-nova07:21
*** brinzhang has joined #openstack-nova07:24
*** ralonsoh has joined #openstack-nova07:29
*** ircuser-1 has quit IRC07:33
*** aarents has joined #openstack-nova07:34
*** brinzhang_ has joined #openstack-nova07:36
*** brinzhang has quit IRC07:39
*** maciejjozefczyk has joined #openstack-nova07:47
*** brinzhang has joined #openstack-nova07:48
*** brinzhang_ has quit IRC07:51
*** bhagyashris has quit IRC07:58
*** trident has joined #openstack-nova08:02
*** ganso has quit IRC08:08
*** ganso has joined #openstack-nova08:09
*** damien_r has joined #openstack-nova08:10
*** brinzhang_ has joined #openstack-nova08:10
*** brinzhang has quit IRC08:13
*** tesseract has joined #openstack-nova08:21
*** tosky has joined #openstack-nova08:22
*** jangutter has joined #openstack-nova08:33
*** rpittau|afk is now known as rpittau08:35
*** zbr is now known as zbr|rover08:37
*** iurygregory has joined #openstack-nova09:02
*** bhagyashris has joined #openstack-nova09:05
*** ociuhandu has joined #openstack-nova09:07
*** ociuhandu has quit IRC09:12
*** xek has joined #openstack-nova09:16
*** ociuhandu has joined #openstack-nova09:20
*** brinzhang_ has quit IRC09:32
*** Liang__ is now known as Liangfang09:33
*** Liangfang is now known as LiangFang09:33
*** brinzhang_ has joined #openstack-nova09:33
*** derekh has joined #openstack-nova09:38
*** ociuhandu has quit IRC09:39
*** ociuhandu has joined #openstack-nova09:40
*** brinzhang has joined #openstack-nova09:41
*** martinkennelly has joined #openstack-nova09:43
*** ociuhandu has quit IRC09:44
*** brinzhang_ has quit IRC09:45
*** pcaruana has joined #openstack-nova09:49
*** brinzhang_ has joined #openstack-nova09:51
*** mkrai has quit IRC09:53
*** brinzhang has quit IRC09:55
openstackgerritLiang Fang proposed openstack/nova-specs master: Support volume local cache  https://review.opendev.org/68907009:55
*** ociuhandu has joined #openstack-nova09:56
*** pcaruana has quit IRC09:56
*** ociuhandu has quit IRC09:58
*** ratailor has joined #openstack-nova09:59
*** ociuhandu has joined #openstack-nova09:59
*** LiangFang has quit IRC09:59
*** ratailor__ has quit IRC10:01
*** brinzhang has joined #openstack-nova10:02
*** ociuhandu has quit IRC10:03
*** zhanglong has quit IRC10:04
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Mask the token used to allow access to consoles  https://review.opendev.org/70218110:04
*** ociuhandu has joined #openstack-nova10:05
*** brinzhang_ has quit IRC10:06
*** jawad-ax_ has quit IRC10:07
*** ociuhandu has quit IRC10:07
*** ratailor_ has joined #openstack-nova10:17
*** iurygregory has quit IRC10:18
*** ratailor has quit IRC10:19
*** brinzhang_ has joined #openstack-nova10:21
*** brinzhang has quit IRC10:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Use EphemeralObject for non DB versioned objects  https://review.opendev.org/70218410:25
*** iurygregory has joined #openstack-nova10:28
*** brinzhang has joined #openstack-nova10:30
*** ociuhandu has joined #openstack-nova10:32
*** dtantsur|afk is now known as dtantsur10:32
*** brinzhang_ has quit IRC10:33
*** ociuhandu has quit IRC10:34
*** brinzhang_ has joined #openstack-nova10:40
*** brinzhang has quit IRC10:43
*** jawad-axd has joined #openstack-nova10:49
*** jawad-axd has quit IRC10:53
*** rpittau is now known as rpittau|bbl11:03
*** ociuhandu has joined #openstack-nova11:06
*** rcernin has joined #openstack-nova11:11
*** jawad-axd has joined #openstack-nova11:14
*** brinzhang has joined #openstack-nova11:30
*** brinzhang_ has quit IRC11:34
*** dviroel has joined #openstack-nova11:38
*** brinzhang_ has joined #openstack-nova11:39
*** brinzhang has quit IRC11:42
*** tbachman has quit IRC11:47
*** bhagyashris has quit IRC11:50
*** brinzhang_ has quit IRC11:52
*** brinzhang_ has joined #openstack-nova11:52
*** brinzhang has joined #openstack-nova11:54
*** zhanglong has joined #openstack-nova11:56
*** brinzhang_ has quit IRC11:58
*** bhagyashris has joined #openstack-nova12:02
*** brinzhang has quit IRC12:06
*** brinzhang has joined #openstack-nova12:07
*** zzzeek has quit IRC12:16
*** zzzeek has joined #openstack-nova12:17
*** ociuhandu has quit IRC12:23
*** udesale has quit IRC12:23
*** abhishekk has quit IRC12:23
*** abhishekk has joined #openstack-nova12:24
*** ociuhandu has joined #openstack-nova12:31
*** mlycka has joined #openstack-nova12:34
*** brinzhang_ has joined #openstack-nova12:38
*** brinzhang_ has quit IRC12:40
*** brinzhang_ has joined #openstack-nova12:41
brinzhang_Hi all, https://review.opendev.org/#/c/580271/ this patch I was resolved the functional test and python test, but there are some errors I donot know why.12:41
brinzhang_is there need some dependency packges?12:41
*** brinzhang has quit IRC12:42
*** brinzhang_ has quit IRC12:42
*** brinzhang_ has joined #openstack-nova12:43
brinzhang_any professional python expert can give some guide? thanks ^^12:43
lyarwoodbrinzhang_: https://storyboard.openstack.org/#!/story/200708412:44
*** brinzhang_ has quit IRC12:44
*** brinzhang has joined #openstack-nova12:45
*** brinzhang has quit IRC12:46
*** brinzhang has joined #openstack-nova12:47
*** adriant has quit IRC12:48
*** adriant has joined #openstack-nova12:49
lyarwoodbrinzhang: I'm not sure if you saw this, https://storyboard.openstack.org/#!/story/2007084 | http://lists.openstack.org/pipermail/openstack-discuss/2020-January/011956.html12:50
brinzhanglyarwood: Oh no, see it by your send12:51
*** ociuhandu has quit IRC12:52
*** tbachman has joined #openstack-nova13:16
*** ociuhandu has joined #openstack-nova13:16
*** ociuhandu has quit IRC13:16
*** shilpasd has quit IRC13:16
*** ociuhandu has joined #openstack-nova13:16
*** brinzhang_ has joined #openstack-nova13:20
*** brinzhang_ has quit IRC13:21
*** brinzhang_ has joined #openstack-nova13:21
*** zhanglong has quit IRC13:22
*** tbachman has quit IRC13:22
*** brinzhang_ has quit IRC13:22
*** brinzhang_ has joined #openstack-nova13:23
*** brinzhang has quit IRC13:23
*** tbachman has joined #openstack-nova13:23
*** brinzhang_ has quit IRC13:24
*** brinzhang_ has joined #openstack-nova13:24
*** nweinber__ has joined #openstack-nova13:24
brinzhang_gibi: hi, I am not very clear what did you mean, can you give me more details about this https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@12813:25
brinzhang_gibi: thanks :)13:25
*** derekh has quit IRC13:30
*** rpittau|bbl is now known as rpittau13:32
*** ratailor_ has quit IRC13:35
*** brinzhang has joined #openstack-nova13:37
*** brinzhang_ has quit IRC13:40
*** brinzhang_ has joined #openstack-nova13:42
*** brinzhang has quit IRC13:45
*** mriedem has joined #openstack-nova13:51
*** rcernin has quit IRC13:53
*** KeithMnemonic has joined #openstack-nova13:59
*** brinzhang has joined #openstack-nova14:01
*** brinzhang has quit IRC14:03
*** brinzhang has joined #openstack-nova14:03
*** brinzhang_ has quit IRC14:04
efriedalex_xu: I don't fully have in my head all the combinations that would or would not make sense.14:05
efriedBut somebody should14:05
efriedAnd then block the ones that don't make sense.14:05
efriedI don't know if cpu_policy=$anything makes sense in the mixed CPU case, because you're dedicating some and sharing some.14:05
efriedSo perhaps those should be mutually exclusive.14:05
efriedbut that ^ kind of decision just needs to be made, in a way that makes sense, for all the relevant options.14:06
efried...by someone who knows what makes sense, which ain't me :P14:06
*** derekh has joined #openstack-nova14:06
efriedBut tl;dr we're not going to freak out about combining placement-ese and other syntaxes, because dansmith beat me down. I'm now a husk of my former self.14:07
*** Luzi has quit IRC14:12
*** brinzhang_ has joined #openstack-nova14:31
*** brinzhang has quit IRC14:34
*** pcaruana has joined #openstack-nova14:34
*** brinzhang has joined #openstack-nova14:37
*** amodi has quit IRC14:38
*** brinzhang_ has quit IRC14:40
gibibrinzhang_: extended my comment in https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@12814:40
*** ociuhandu has quit IRC14:41
sean-k-mooneyefried: we were going to use an expcitly cpu_policy=mixed for mixed cpus if you dont set that you cant use the feature14:45
efried'mixed' is a new value?14:46
sean-k-mooneyyes14:46
efriedAnd why do we need it?14:47
efriedIs cpu_policy a required field otherwise?14:47
sean-k-mooneyit how you enable pinning14:47
efriedI would expect we could infer 'mixed' based on the fact you specified both vcpu and pcpu14:47
sean-k-mooneyand it need to be set for realtime14:47
sean-k-mooneyand we do not want to use cpu_policy=dedicated with mixed cpus14:47
sean-k-mooneyall the pinning code check the cpu_policy values so if stephen enabeld pinning with resouces:PCPU he is implcitly setting that internally14:49
sean-k-mooneyi am 90% sure he did not remove all the check that were based on cpu_policy14:50
sean-k-mooneyya we still use it https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1482-L152014:51
huaqiangthe internal logic need a cpu_policy, no matter it is specified by flavor/image or specified implicitly through resources:RC14:51
*** tbachman has quit IRC14:51
*** bhagyashris has quit IRC14:51
sean-k-mooneythis is where translation for the placement request https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L252-L29814:53
sean-k-mooneyhe would have to infer the cpu_policy before that14:54
huaqiangsean-k-mooney: I ma not intent to object the new policy 'mixed', but if this new mixed policy is added, we have to find the CPU quantity information from resources:RC. The 'mixed' policy will not work if no CPU quantity information is found in resources:RC. This is not like the way that dedicated or shared policy works.14:57
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Skip checking of target_dev for vhostuser  https://review.opendev.org/70223114:57
sean-k-mooneyhuaqiang: well we have to find it form resouce:* or have a hw:* extra spec yes14:58
huaqiangThis is something weired if we comapring the requirements for creating 'mixed' instance and 'dedicated' or 'shared' instance.14:58
sean-k-mooneyi think it shoudl be a error to jsut set mixed on its own14:59
huaqiangtechnically we can do as you said14:59
sean-k-mooneywell for realtime instance we have two thing that must be set. you must enabel it with a boolean and then provide a mask15:00
sean-k-mooneywe did that in the realtime case to allow the image to provide the mask15:00
huaqiangthis will a little different with the 'mixed' instance case15:01
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Skip checking of target_dev for vhostuser  https://review.opendev.org/70223115:01
huaqiangbecause we don't have a mask15:01
*** eharney has quit IRC15:02
sean-k-mooneywell we either have a mask or you have to use the placement syntax unless we are goint to placement syntax only. if we do that then i think that is problematic as long as we support groups in the flavor15:02
huaqiangefried said in his conclusion that if the plamenent-ness works, then the placement interface is the only interface I think, that is no mask for it15:05
efriedwhat does "realtime" mean?15:06
sean-k-mooneywe have the ablity to mark the gust cpus as executing with realtime priority15:06
huaqiangsean-k-mooney: What kind of  problem? Do we have spec for how to support placement groups in nova?15:06
efriedsean-k-mooney: so that's not the same thing as pinning?15:07
sean-k-mooneyand when you enable that feature you have to set a mask of which cpus are realtime and which are not15:07
sean-k-mooneyefried: its seperate but can only be enabled if you are using pinning15:07
efriedWhat I'm getting at is: I don't mind if we have to change some internal logic/data to represent "mixed", but for the UX it seems unnecessary, because we can infer it.15:07
sean-k-mooneyhuaqiang: it has been supported for several release15:07
sean-k-mooneyefried: if we have it as an internal value i think we should allow it to be set15:08
efriedBut you can't set mixed unless you mix, and if you mix, you can't set it to any other value. That doesn't seem like good UX to me.15:08
sean-k-mooneyefried: but also i really reallly want to make sure that this new bevaior is only  enabeld if we do it intentionally15:08
sean-k-mooneyefried: so there is a discoverabliy aspect too15:09
efriedAs a user, I don't want to say VCPU=$n,PCPU=$m only to have my build rejected with a message like "if you set both VCPU and PCPU, you must say cpu_policy=mixed as well"15:09
sean-k-mooneyif we dont set mixed as teh cpu_policy15:09
sean-k-mooneyi now need to prse the Resouces:* to figure out if this flavor is mixed pinnend or floating15:09
efriedbe like, "No, you can't do mixed CPUs unless you also set this option that says you really mean it"15:09
*** ociuhandu has joined #openstack-nova15:10
efriedsean-k-mooney: we're doing that anyway to make sure they're not f'ing up the combination.15:10
*** artom has joined #openstack-nova15:10
sean-k-mooneyno i mean as an end user15:10
sean-k-mooneywho is tryign to fine a flavor to use15:10
efriedmmph, I don't buy that.15:10
sean-k-mooneythat havign to check both cpu policy and Resocues: is a pain?15:11
efriedIf you really think your user can't handle realizing VCPU=$n,PCPU=$m means mixed, name the flavor "mixed_cpu_XXX"15:11
efriedI just don't like the redundancy.15:11
sean-k-mooneyefried: a human can programing it is just annoying but ok15:11
efriedI don't see why programming it is annoying.15:12
*** lpetrut has joined #openstack-nova15:12
sean-k-mooneybecause i now instead of looking at just the cpu policy i also need to look at resouces:*15:12
sean-k-mooneywhen cpu_policy is not set15:13
efriedYou have to look at it anyway15:13
sean-k-mooneyalso if cpu_polciy is not set it allows the image to set any cpu_policy15:13
sean-k-mooneyyou didnt before stephens change15:13
huaqiangcan we create an instance through PCPU and VCPU resources without naming it 'dedicated' or 'shared'. It is just an instance?15:13
sean-k-mooneybut yes technically you would have15:13
efriedsorry, are you telling me that every internal field maps to a user input??15:14
sean-k-mooneyhuaqiang: apparently yes however i have not found where in the code that works15:14
sean-k-mooneyefried: the cpu_polciy is not an internal field15:14
sean-k-mooneyif we consider resouces:* to be then users proably should not set them15:15
efriedIt's probably just ignorance on my part. But it seems to me that if I say resources:PCPU, cpu_policy=pinned is implied and I shouldn't be *required* to say it.15:17
efriedLikewise if I say resources:PCPU+resources:VCPU, cpu_policy=mixed is implied and I shouldn't be required to say it.15:17
sean-k-mooneyefried: so in theory stephens PCPU in placment feature allows you to say that and make it so you don thave to set cpu_policy=dedicated15:17
sean-k-mooneybut as i argured in the spec review i think that is a regression in functionality as you have to ensure the PCPU vaule now matches the flavor.vcpus15:18
huaqiangsean-k-mooney: in current code, each instance a policy, either 'dedicated' or 'shared', no matter you named it explicitly or implicitly.15:19
sean-k-mooneyactuuly it shared dedicated or unset15:19
efriedIMO we should bite the bullet and start allowing flavor.vcpus=015:19
sean-k-mooneywhen its unset itst treated as shared but the image can set it15:19
*** tbachman has joined #openstack-nova15:20
sean-k-mooneyefried: i disagree unless we remove all out resouce filed form the flavor or allow them all too be 015:20
sean-k-mooneyalso doing that will break the world15:20
sean-k-mooneythere is plenty of logic built up around search on flavor by flavor.*15:20
efried"bite the bullet" means it will be hard and breaking but will result in a better world.15:21
sean-k-mooneyim not sold on that15:21
sean-k-mooneye.g. that its better but sure we could15:22
*** awalende_ has quit IRC15:22
sean-k-mooneywe woudl effectivly be saying that the only filed that maters in the falvor is the unversion dict of string that is the extra specs15:22
efriedThe alternative is making flavor.pcpus15:22
sean-k-mooneyno15:22
sean-k-mooneyflavor.vcpu has nothing to do with if its floating or pinned or mixed15:23
*** awalende has joined #openstack-nova15:23
sean-k-mooneyit is the number of logical guest cpus15:23
efriedokay, I can buy that.15:23
efriedThen flavor.vcpus must equal resources:VCPUS+resources:PCPUS15:23
efriedwhich is confusing as shit IMO15:23
sean-k-mooneyas of train yes15:23
sean-k-mooneybefore train no15:23
sean-k-mooneyactully even now no15:24
sean-k-mooneyif you use emulator thread polciy = isolate15:24
huaqiangefried: for PCPU we have to consider emulator thread15:24
efriedthen it's 2x or something?15:24
sean-k-mooneyit will be resources:VCPUS+resources:PCPUS+115:24
huaqiangit might be isolate emulator thread15:24
efriedright15:24
efriedBut my point is,15:24
efriedflavor.vcpus and resources:VCPU are not the same thing15:24
efriedwhich is confusing as shit.15:24
sean-k-mooneycorrrect15:24
sean-k-mooneywell we should not have used VCPUs as the resouce class name15:25
efriedAlmost like we should make a resources:SCPUS or something15:25
efriedright15:25
sean-k-mooneyit should be SCPUs15:25
efriedPerhaps we should do that.15:25
efriedAnd just tell people not to use the r-t releases15:25
sean-k-mooneyyep i had this argument after we had already commited the VCPUs resouce class code in plament and no one wnated to change it15:26
* efried bbiab15:26
*** awalende_ has joined #openstack-nova15:27
*** jawad-axd has quit IRC15:27
*** awalende has quit IRC15:27
huaqiangefried,sean-k-mooney: do we have conclusion on adding a new cpu policy 'mixed' or just don't naming it as policy if we don't provided a policy?15:28
huaqiangfor later case we just create an instance through PCPU&VCPU and we don't assign any policy to it internally15:30
sean-k-mooneythat will triger alot of the "shared" policy code paths and break realtime cpus15:30
*** awalende_ has quit IRC15:31
sean-k-mooneygiven realtime guest is one of the primary usecase it think that would be bad unless you also modify the logic so that we take into account the realtime mask15:31
sean-k-mooneyi mean we shoudl do that anyway but the more things we make implcit the more edgecase you will have to handel interanlly15:32
huaqiangthe logic for creating a mixed instance follows the code path of 'dedicated' policy mostly.15:36
sean-k-mooneyyes both most of the code check expcitly check for dedicated then assuem if that is not set that it is shared15:37
huaqiangbut we have to create a internal variable to represent of mixed instance, not a policy but works paraelly with policies.15:37
sean-k-mooneyso if you dont set a policy it will be treated as shared15:37
sean-k-mooneyi think that would be a mistake15:37
sean-k-mooneythis is a policy15:37
huaqiangI also think that is a problem15:37
sean-k-mooneyhaving yet another thing to check would just make the code more complcatedd15:38
huaqiangHow about tell user, the 'dedicated' is extended with the concept that not all CPUs are pinning CPUs.15:39
huaqiangthis was denied byefore15:39
sean-k-mooneynoop15:39
sean-k-mooneyi really hate that idea15:40
huaqiangfor inconsistent behavior15:40
sean-k-mooneyyes it would have different meaning on different versions of openstack15:41
sean-k-mooneywe could add teh mixed policy and make it optional15:43
sean-k-mooneyso we have an internal value to use and the user can choose not to set it and just use the placmenet syntax15:43
sean-k-mooneyi would still always recomend setting it but if we can infer the mixed case the it woudl not be required15:44
sean-k-mooneyhowever that woudl allwo you to do something like flavor.vcpu=8 hw:cpu_policy=mixed resouces:vcpu:215:45
sean-k-mooneyand because we know its mixed we know the other 6 cpus must be pinned15:45
huaqiangand the number of PCPU could be derived from the give information15:46
sean-k-mooneyyou could also do flavor.vcpu=8 resouces:vcpu:2 resouces:PCPUS:615:46
sean-k-mooneyyep15:46
huaqiangif emulator thread policy is isolate15:46
huaqiangthen another PCPU is requred15:46
sean-k-mooneyyep15:46
sean-k-mooneybut again we can derive that form the info availble15:47
*** dave-mccowan has joined #openstack-nova15:47
*** derekh has quit IRC15:47
huaqiangyes15:47
huaqiangworks for me15:47
sean-k-mooneyknowing its a mixed cpu explictly makes it eairer to derive thing in my view15:47
sean-k-mooneybut makeing it optional as long as you tell us how much of each type you want keeps it clean15:48
sean-k-mooneyif that is what you prefer15:48
efriedYeah, I really don't understand why it needs to be explicitly stated by the user.15:49
efried"will trigger X code paths by default" <== we will be changing those code paths as part of this feature, right?? That's what code changes are for??15:49
efriedMixed means you have to take shared code paths in some places, dedicated in other places.15:50
efriedThat's gonna happen internally regardless.15:50
sean-k-mooneyi think we only ever check for dedicated so i think you would always take the shared path15:50
sean-k-mooneybut yes it will be changed in anycase by this feature15:50
efriedI'm not refuting that we need "mixed" logic internally.15:51
sean-k-mooneyby the way im still looking for the code that allows resouce:PCPU=4 to actully give you a pinned guest15:51
efriedI'm saying, why require it to be stated by the user if it can be inferred 100% from the fact that they MIXED THEIR CPUs in the flavor?15:51
*** dave-mccowan has quit IRC15:52
sean-k-mooneywell the field is an ovo filed and i dont like adding another seperate variable15:52
efriedan OVO field in what, the Flavor?15:52
sean-k-mooneyso if we extend the ovo filed defintion it will alther the api check implcitly to allow it15:52
sean-k-mooneyno in the image metadata15:52
sean-k-mooneyand in the numa objects15:52
efriedbut it's not a required field.15:53
sean-k-mooneyyes it can be unset or set to shraed explcitly for floating instance or set to dedicated15:53
efriedFine.15:53
efriedbut don't require it.15:53
efriedI assume you can set it from either the flavor or the image?15:54
sean-k-mooneythe sematica are that if its not set in the flavor it means the image can requst pinning. so unset and set to shared are different15:54
*** derekh has joined #openstack-nova15:54
efriedSo we funnel those into the numa object15:54
sean-k-mooneyyes15:54
sean-k-mooneyand it becomes part of the numa constratin used in the numa toplogy filter and on the compute node15:55
efriedwe logically evaluate cpu policy-ness from the flavor and the image to determine the value in the internal numa object15:55
efried? ^15:55
sean-k-mooneywe store it as cpu_polciy in the instnace numa topology15:55
*** eharney has joined #openstack-nova15:56
sean-k-mooneyby reading the flavor and image properties yes15:56
efriedcool,15:56
efriedso what I'm saying is,15:56
efriedif neither the flavor nor the image dictates a cpu_policy, and the flavor specifies both VCPUs and PCPUs, we set the value internally to mixed.15:56
efriedbut we do not require the flavor or image to say 'mixed'.15:56
sean-k-mooneyyep15:56
sean-k-mooneyya we coudl do that15:56
efriedbecause they already did, by specifying VCPU+PCPU15:56
efriedand,15:56
sean-k-mooneybut i think we should not block it either15:56
efriedif they say VCPU+PCPU and specify cpu_policy=$anything_other_than_mixed, we have to fail.15:56
sean-k-mooneyam yes i think we can do that15:57
sean-k-mooneyinfact i think we should already be doint that in the api somewhere15:57
efriedso if we're going to do that, I don't see why we even need to bother exposing the *ability* for them to say cpu_policy=mixed in the flavor/image.15:57
efriedbut I won't die on a hill for that.15:57
sean-k-mooneyit would be more work to not expose it15:57
efriedfine15:57
*** maciejjozefczyk has quit IRC15:58
sean-k-mooneyefried: huaqiang are we really sure we supprot enabling cpu_pinning by using PCPUs15:59
sean-k-mooneyhttps://github.com/openstack/nova/blob/0012fdfdc387da97d1d396e5ebda152d7c10b091/nova/objects/instance_numa.py#L111-L11215:59
sean-k-mooneywell i guess maybe if we have set that internally15:59
sean-k-mooneyi still need to find that code16:00
huaqiangsean-k-mooney: in hardware.py I'll find it for yo16:03
huaqianghttps://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L186016:04
sean-k-mooneythanks ok and https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1840-L1843 is where we block the mixed case16:06
sean-k-mooneyso the transformation happens in the api16:06
sean-k-mooneynuma_get_constraints is invoked form teh api to validate teh request and it si used when constuction teh numa toplogy object that is passed to the schduler16:07
*** ociuhandu has quit IRC16:07
huaqiangit will be permitted for mixed case16:07
sean-k-mooneyyes so basicaly at line 1840 you will replace that with a check that will set the polciy to mixed internally16:08
openstackgerritIury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc  https://review.opendev.org/70199816:08
sean-k-mooneythen make the if on line 1845 an elif16:08
sean-k-mooneyso we only take it if its a non mixed case16:08
*** tbachman has quit IRC16:09
*** pcaruana has quit IRC16:12
huaqianghttps://review.opendev.org/#/c/696009/1/nova/virt/hardware.py16:13
huaqiangthis is my poc code for this part16:13
*** gyee has joined #openstack-nova16:15
*** macz has joined #openstack-nova16:16
*** iurygregory has quit IRC16:17
huaqiangsean-k-mooney, efried: It is too late for me, I'll go to sleep, and I caught the current idea is using an interal policy 'mixed' in code path, but without exposing it to end user for using in flavor or image properties.16:21
*** ociuhandu has joined #openstack-nova16:26
sean-k-mooneyhuaqiang: good night o/16:27
efriedhuaqiang: to be clear, I'm saying don't *require* it from the end user. I would prefer not to expose it, but if doing so (as optional) makes something significantly easier, I won't object to it.16:31
*** gentoorax has quit IRC16:32
*** gentoorax has joined #openstack-nova16:32
*** TxGirlGeek has joined #openstack-nova16:33
*** tbachman has joined #openstack-nova16:42
*** nweinber__ has quit IRC16:42
*** derekh has quit IRC16:49
*** jmlowe has quit IRC16:51
*** jmlowe has joined #openstack-nova16:53
*** mlavalle has joined #openstack-nova16:54
*** icarusfactor has quit IRC16:55
*** rpittau is now known as rpittau|afk17:02
*** damien_r has quit IRC17:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports  https://review.opendev.org/70226117:06
*** Sundar has joined #openstack-nova17:11
*** pcaruana has joined #openstack-nova17:13
*** mlycka has quit IRC17:18
*** nicolasbock has joined #openstack-nova17:21
*** maciejjozefczyk has joined #openstack-nova17:31
*** jawad-axd has joined #openstack-nova17:33
*** evrardjp has quit IRC17:33
*** eharney has quit IRC17:34
*** evrardjp has joined #openstack-nova17:34
*** maciejjozefczyk has quit IRC17:41
*** eharney has joined #openstack-nova17:41
*** martinkennelly has quit IRC17:49
*** TxGirlGeek has quit IRC17:52
*** dtantsur is now known as dtantsur|afk17:53
*** lpetrut has quit IRC17:54
*** ociuhandu_ has joined #openstack-nova17:55
*** TxGirlGeek has joined #openstack-nova17:56
*** derekh has joined #openstack-nova17:58
*** ociuhandu has quit IRC17:58
*** ociuhandu_ has quit IRC17:59
*** tbachman has quit IRC18:00
artomI can never remember this, what's the order of assertEqual(expected, actual)?18:02
*** jawad-axd has quit IRC18:04
dansmithexpected,actual18:12
*** bnemec has quit IRC18:14
*** lpetrut has joined #openstack-nova18:17
mriedemfyi https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py18:17
* artom eyes mriedem suspiciously...18:18
*** bnemec has joined #openstack-nova18:18
*** TxGirlGeek has quit IRC18:18
mriedemjust your friendly neighborhood lurker18:19
artomAre we... are we like crack to you?18:20
mriedemjust eating lunch18:21
mriedemmy artom sense went off18:21
artomAww, you have a sense for me18:21
*** TxGirlGeek has joined #openstack-nova18:25
*** lpetrut has quit IRC18:28
*** tbachman has joined #openstack-nova18:32
*** jawad-axd has joined #openstack-nova18:45
*** tesseract has quit IRC18:53
*** jawad-axd has quit IRC19:00
efriedsomeone should19:01
efried<tsssss>19:01
*** Sundar has quit IRC19:19
*** awalende has joined #openstack-nova19:23
*** awalende has quit IRC19:28
*** ociuhandu has joined #openstack-nova19:45
*** ociuhandu has quit IRC19:50
*** eharney has quit IRC20:03
openstackgerritArtom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration  https://review.opendev.org/67259520:15
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146  https://review.opendev.org/68740420:15
openstackbug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)20:15
artom*finally*20:15
sean-k-mooneyoh its stacked ...20:19
*** ralonsoh has quit IRC20:34
efrieddustinc: You have a couple of notes in https://review.opendev.org/#/c/676522/ about needing more UT coverage. Is that still true?20:35
efried(I haven't dug in yet to verify)20:35
openstackgerritDan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects  https://review.opendev.org/70204920:41
*** artom has quit IRC20:51
openstackgerritMerged openstack/nova-specs master: Update provider config spec for identification conflicts  https://review.opendev.org/69341420:55
*** eharney has joined #openstack-nova20:57
*** bbowen has quit IRC20:57
*** eharney has quit IRC21:01
dustincefried: I thought it was good and I just forgot to remove the note, but I checked again just to be sure and actually found another scenario I want to write a test for..21:10
efrieddustinc: I just finished reviewing the code side and found some things that need to be fixed anyway.21:10
dustincI have to step away for a few minutes, but I will check it out in a few. Thanks!21:11
efriedno hurry21:13
*** derekh has quit IRC21:30
*** mriedem has left #openstack-nova21:44
*** ociuhandu has joined #openstack-nova21:55
*** ociuhandu has quit IRC22:00
*** vesper has joined #openstack-nova22:00
*** vesper11 has quit IRC22:01
*** slaweq has quit IRC22:12
*** xek has quit IRC22:24
*** brinzhang_ has joined #openstack-nova22:35
*** brinzhang has quit IRC22:39
*** tkajinam has joined #openstack-nova22:49
*** rcernin has joined #openstack-nova22:57
*** tosky has quit IRC23:06
*** awalende has joined #openstack-nova23:19
*** awalende has quit IRC23:23
*** Liang__ has joined #openstack-nova23:25
*** TxGirlGeek has quit IRC23:27
*** ociuhandu has joined #openstack-nova23:30
*** TxGirlGeek has joined #openstack-nova23:31
*** ociuhandu has quit IRC23:35
*** mlavalle has quit IRC23:49
*** Liang__ has quit IRC23:59
« Sunday, 2020-01-12 Index Tuesday, 2020-01-14 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!